pounce_cli/

qp_extract.rs

//! Extract a `pounce_convex::QpProblem` (standard form) from a parsed
//! `.nl` problem, for the LP/QP dispatch path (Phase 2).
//!
//! The classifier (`crate::dispatch`) has already decided the problem is
//! an LP or convex QP; this module marshals the parsed `NlProblem` into
//! the standard form the convex IPM consumes:
//!
//! ```text
//! minimize    ½ xᵀP x + cᵀx
//! subject to  A x = b          (equalities)
//!             G x ≤ h          (inequalities)
//!             lb ≤ x ≤ ub      (the variable box)
//! ```
//!
//! Mapping from the `.nl` representation:
//! - **Objective.** `P` is the Hessian of the (degree-≤2) objective —
//!   recovered with the same `analyze_quadratic` the classifier uses, so
//!   `P` here is exactly the matrix whose definiteness was tested. `c`
//!   is the objective's linear part. A `maximize` objective is negated
//!   into a minimization.
//! - **Constraints.** Each row has a linear part and bounds `g_l ≤ row ≤
//!   g_u`. An equality (`g_l == g_u`) becomes a row of `A`; a one- or
//!   two-sided inequality becomes one or two rows of `G` (`row ≤ g_u`
//!   and/or `−row ≤ −g_l`).
//! - **Variable bounds.** Present `x_l`/`x_u` become the solver's explicit
//!   box (see [`extract_box`] for why they are no longer emitted as `G`
//!   rows). The `.nl` "infinity" sentinel is read directionally: `x_l ≤
//!   -1e19` is no lower bound, `x_u ≥ 1e19` is no upper bound. A bound past
//!   the *opposite* sentinel (an upper bound of `-5e20`) is an ordinary
//!   bound and is kept.

use crate::nl_reader::NlProblem;
// Bound presence is read **directionally** — a lower bound is absent only at
// or below `-1e19`, an upper bound only at or above `+1e19`. This file used a
// symmetric `|v| < 1e19` test (gh #401): a real upper bound of `-5e20` failed
// it and was dropped from `G` entirely, so the QP was solved over a strictly
// larger box and reported `Optimal` at a point the model excludes.
use pounce_common::types::{lower_bound_present, upper_bound_present};
use pounce_convex::{ConeSpec, QpProblem, QpResiduals, QpSolution, Triplet};

/// Ipopt's `bound_relax_factor` widening, as the convex extractors apply it.
///
/// The NLP path widens `x_L/x_U` and the inequality-row bounds `d_L/d_U`
/// before the algorithm ever sees them (`OrigIpoptNlp::relax_bounds`, driven
/// from `Application` with `bound_relax_factor` — Ipopt default `1e-8` —
/// capped by `constr_viol_tol`, default `1e-4`). The convex path did not,
/// so the *same binary* solved a materially different model depending on
/// `solver_selection`.
///
/// That is not a hairline difference on a constraint-degenerate model. On
/// `LISWET1` (gh #744) every one of the 10 000 monotonicity rows is active at
/// the optimum and the multipliers sum to `1.6e9`, so a `1e-8` widening of the
/// rows buys `9.0` of objective — the convex arm returned the exact optimum
/// `36.1224` and the NLP arm (and Ipopt-MA57) the relaxed one, `27.1221`, and
/// the 33% gap was read as a convex-solver bug. Both arms now relax, so both
/// report `27.1221`, and `bound_relax_factor=0` gets `36.1224` from either.
///
/// Faithful to `relax_bounds` in three details that matter:
/// * **Equality rows are not relaxed.** Upstream they live in `c(x) = 0`,
///   which `relax_bounds` never touches; only `d_L/d_U` (inequality rows) and
///   the variable box are widened.
/// * **Rows use the scale-relative width** `min(factor, cap)·|b|` (with `|b|`
///   read as `1` at a declared-zero bound), the gh #385 form. The variable box
///   keeps the upstream absolute formula `min(factor·max(|b|,1), cap)`.
/// * **Fixed variables (`x_l == x_u`) keep their bounds.** Under the default
///   `fixed_variable_treatment=make_parameter` upstream removes them before
///   `relax_bounds` runs, so they are never widened.
#[derive(Debug, Clone, Copy, PartialEq)]
pub struct BoundRelax {
    /// `bound_relax_factor`. Non-positive disables the widening entirely.
    pub factor: f64,
    /// `constr_viol_tol` — the cap on the widening.
    pub cap: f64,
}

impl BoundRelax {
    /// No widening — the model exactly as declared. What the convex path did
    /// unconditionally before gh #744, and what `bound_relax_factor=0` selects.
    pub const NONE: Self = Self {
        factor: 0.0,
        cap: 0.0,
    };

    /// Whether any widening is actually applied. Public so a caller can tell
    /// "the declared model and the solved model coincide" from "they differ",
    /// which struct equality against [`Self::NONE`] cannot: `bound_relax_factor=0`
    /// zeroes the factor but leaves `cap` at `constr_viol_tol`, so the pair is
    /// inactive without being `NONE`.
    pub fn active(self) -> bool {
        self.factor > 0.0 && self.cap > 0.0
    }

    /// Widening of a variable bound `b`: `min(factor·max(|b|,1), cap)`.
    fn var_delta(self, b: f64) -> f64 {
        if !self.active() {
            return 0.0;
        }
        (self.factor.abs() * b.abs().max(1.0)).min(self.cap)
    }

    /// Widening of an inequality-row bound `b`: `min(factor, cap)·|b|`, with a
    /// declared-zero bound taking the absolute width (it has no scale).
    /// The widening to apply to a row whose declared sides are `lo`/`hi`.
    ///
    /// A crossed pair (`lo > hi`) declares an *empty* feasible set — an
    /// inconsistent model, which the NLP path rejects as
    /// `Invalid_Problem_Definition` before `relax_bounds` is ever reached.
    /// Widening both sides of one closes the gap whenever the crossing is
    /// narrower than the relaxation, turning "this model has no feasible
    /// point" into an optimal answer. A crossed row is therefore passed
    /// through exactly as declared, so the emptiness screen still sees it
    /// (gh #491).
    fn for_row(self, lo: f64, hi: f64) -> Self {
        if lower_bound_present(lo) && upper_bound_present(hi) && lo > hi {
            Self::NONE
        } else {
            self
        }
    }

    fn row_delta(self, b: f64) -> f64 {
        if !self.active() {
            return 0.0;
        }
        let scale = if b == 0.0 { 1.0 } else { b.abs() };
        self.factor.abs().min(self.cap) * scale
    }
}

/// Convert a classified LP/convex-QP `NlProblem` into `QpProblem`
/// standard form. Returns `None` if the objective is not actually a
/// degree-≤2 polynomial (should not happen for a problem the classifier
/// routed here, but the conversion is total and falls back gracefully).
pub fn extract_qp(prob: &NlProblem, relax: BoundRelax) -> Option<QpProblem> {
    Some(extract_qp_with_map(prob, relax)?.0) // drops con_map + reporting constant
}

/// Where each `.nl` constraint's rows landed in the standard-form QP, so
/// the QP's multipliers can be mapped back to a per-`.nl`-constraint
/// dual for the `.sol`. One entry per original constraint, in order.
#[derive(Debug, Clone)]
pub enum ConRowMap {
    /// Equality constraint → row `a_row` of `A` (multiplier `y[a_row]`).
    Eq { a_row: usize },
    /// Inequality / range constraint → up to two rows of `G`: the
    /// `row ≤ g_u` upper bound and/or the `−row ≤ −g_l` lower bound
    /// (multipliers `z[..]`, each ≥ 0).
    Ineq {
        upper: Option<usize>,
        lower: Option<usize>,
    },
}

/// The residuals of `sol` measured against the model **as declared**, before
/// the [`BoundRelax`] widening.
///
/// [`QpSolution::kkt_residuals`] measures the problem the solver was handed,
/// whose inequality rows and variable box are widened by
/// `bound_relax_factor`. That is correct for the convergence test — the
/// solver must converge on the model it is solving, and pounce-convex's own
/// acceptance tests call it on exactly that model — and wrong for the number
/// a caller reads as "how well does my model hold".
///
/// The gap is the widening itself, `min(factor, cap)·|b|` per row. On
/// `afiro` the returned point sits `4.99e-06` outside the declared row
/// `b = 500` — precisely `1e-8 · 500` — while the widened measurement reads
/// `8.68e-13`, seven orders tighter, because the point does satisfy the
/// widened row. `25fv47` reports `2.19e-11` against a declared `1.97e-05`.
/// Neither is a solver defect: both are the widening working as designed and
/// then being reported against the wrong model.
///
/// Returns `None` when no widening was applied (the two measurements
/// coincide by construction, so the caller keeps the one it already has) or
/// when re-extraction fails.
pub fn declared_residuals_qp(
    prob: &NlProblem,
    sol: &QpSolution,
    relax: BoundRelax,
) -> Option<QpResiduals> {
    if !relax.active() {
        return None;
    }
    let (declared, _, _) = extract_qp_with_map(prob, BoundRelax::NONE)?;
    // Structurally the re-extraction differs from the solved model only in
    // the bound VALUES, so the shapes must agree; a mismatch would silently
    // measure one model's point against another's rows.
    debug_assert_eq!(declared.n, sol.x.len(), "declared re-extraction changed n");
    // Only `primal_infeasibility` is consumed. The dual and complementarity
    // terms this also computes are measured against a model whose multipliers
    // are not the ones that produced them, so they are meaningless here and
    // deliberately unused rather than reported.
    Some(sol.kkt_residuals(&declared))
}

/// [`declared_residuals_qp`] for the conic arm: measures each block with its
/// own cone, as [`QpSolution::kkt_residuals_conic`] does, so a converged SOC
/// block is not read as infeasible (pounce#209). The cones come from the
/// re-extraction rather than the caller, so the blocks and the bounds
/// describe one model.
pub fn declared_residuals_socp(
    prob: &NlProblem,
    sol: &QpSolution,
    relax: BoundRelax,
) -> Option<QpResiduals> {
    if !relax.active() {
        return None;
    }
    let (declared, _, _, cones) = extract_socp_with_map(prob, BoundRelax::NONE)?;
    debug_assert_eq!(declared.n, sol.x.len(), "declared re-extraction changed n");
    // As above: only `primal_infeasibility` is consumed.
    Some(sol.kkt_residuals_conic(&declared, &cones))
}

/// Extract the QP, the constraint→row provenance map, and the objective
/// constant folded into the nonlinear tree (see below), together.
///
/// The third return value is the **degree-0 term of the nonlinear
/// objective** (e.g. the `+9` of `(x₀−3)²` that AMPL/Pyomo emit inside the
/// nonlinear tree rather than in `NlProblem::obj_constant`). The QP itself
/// ignores it — it does not move the minimizer — but the caller must add
/// it to the *reported* objective so the convex solve agrees with the NLP
/// path. It is returned in the problem's natural (user) sense, *not*
/// multiplied by the maximize/minimize `sign`.
pub fn extract_qp_with_map(
    prob: &NlProblem,
    relax: BoundRelax,
) -> Option<(QpProblem, Vec<ConRowMap>, f64)> {
    let n = prob.n;
    let sign = if prob.minimize { 1.0 } else { -1.0 };

    // --- objective Hessian P (lower triangle) + nonlinear-tree linear part
    //     + nonlinear-tree constant (degree-0 term, for reporting only) ---
    let (hess, obj_nl_linear, obj_nl_constant) = prob.obj_nonlinear.analyze_quadratic_full()?;
    let mut p_lower: Vec<Triplet> = Vec::with_capacity(hess.len());
    for ((i, j), v) in &hess {
        // analyze_quadratic returns (i ≤ j) upper-ish keys; store as
        // lower triangle (row ≥ col) for the solver.
        let (row, col) = if i >= j { (*i, *j) } else { (*j, *i) };
        p_lower.push(Triplet::new(row, col, sign * v));
    }

    // --- objective linear term c ---
    // Two disjoint sources, exactly as the NLP path's eval_f sums them:
    // the `.nl` linear section (`obj_linear`) and the degree-1 terms AMPL
    // kept inside the nonlinear objective tree (e.g. the `−6·x₀` of
    // `(x₀−3)²`). Dropping the latter silently solves the wrong objective.
    let mut c = vec![0.0; n];
    for (var, coef) in &prob.obj_linear {
        c[*var] += sign * coef;
    }
    for (var, coef) in &obj_nl_linear {
        c[*var] += sign * coef;
    }

    // --- constraints: equalities → A x = b, inequalities → G x ≤ h ---
    let mut a: Vec<Triplet> = Vec::new();
    let mut b: Vec<f64> = Vec::new();
    let mut g: Vec<Triplet> = Vec::new();
    let mut h: Vec<f64> = Vec::new();
    let mut con_map: Vec<ConRowMap> = Vec::with_capacity(prob.con_linear.len());

    for (row, lin) in prob.con_linear.iter().enumerate() {
        let lo = prob.g_l[row];
        let hi = prob.g_u[row];

        // Combine the `.nl` linear section with any degree-≤1 terms AMPL
        // folded into the (here empty-Hessian) nonlinear tree — the
        // classifier admits constraint rows whose nonlinear expression
        // reduces to degree ≤ 1 (`dispatch.rs`), e.g. defined variables
        // or a quadratic the writer wrote out and cancelled exactly, and
        // those linear/constant terms live in `con_nonlinear`, not
        // `con_linear`. Dropping them silently solves the wrong
        // constraint. (A row whose coefficients cancelled *in the
        // recognizer's own arithmetic* does not reach here at all: it
        // never classifies LP/QP — gh #685.) The folded constant
        // shifts the bounds: `g_l ≤ row + k ≤ g_u  ⇔  g_l−k ≤ row ≤ g_u−k`.
        // This mirrors the SOCP extractor's linear-constraint handling.
        let (nl_lin, const_shift) = prob.con_nonlinear[row]
            .analyze_quadratic_full()
            .map(|(_, l, k)| (l, k))
            .unwrap_or_default();
        let mut coef = vec![0.0; n];
        for (var, v) in lin {
            coef[*var] += *v;
        }
        for (var, v) in &nl_lin {
            coef[*var] += *v;
        }
        let nonzeros = || coef.iter().enumerate().filter(|(_, v)| **v != 0.0);

        if lo == hi && lower_bound_present(lo) && upper_bound_present(hi) {
            // Equality row.
            let eq_row = next_row(&b);
            for (var, v) in nonzeros() {
                a.push(Triplet::new(eq_row, var, *v));
            }
            b.push(lo - const_shift);
            con_map.push(ConRowMap::Eq { a_row: eq_row });
        } else {
            // Inequality row. Both sides carry the `bound_relax_factor`
            // widening the NLP path applies to `d_L/d_U` (see [`BoundRelax`]);
            // it is zero when the caller passed `BoundRelax::NONE`, and on a
            // crossed row, which must stay crossed.
            let relax = relax.for_row(lo, hi);
            // Upper bound: row ≤ hi.
            let upper = if upper_bound_present(hi) {
                let gr = next_row(&h);
                for (var, v) in nonzeros() {
                    g.push(Triplet::new(gr, var, *v));
                }
                h.push(hi + relax.row_delta(hi) - const_shift);
                Some(gr)
            } else {
                None
            };
            // Lower bound: row ≥ lo  ⇔  −row ≤ −lo.
            let lower = if lower_bound_present(lo) {
                let gr = next_row(&h);
                for (var, v) in nonzeros() {
                    g.push(Triplet::new(gr, var, -*v));
                }
                h.push(-(lo - relax.row_delta(lo) - const_shift));
                Some(gr)
            } else {
                None
            };
            con_map.push(ConRowMap::Ineq { upper, lower });
        }
    }

    // --- variable bounds as the explicit box (not as `G` rows) ---
    let (lb, ub) = extract_box(prob, relax);

    Some((
        QpProblem {
            n,
            p_lower,
            c,
            a,
            b,
            g,
            h,
            lb,
            ub,
        },
        con_map,
        obj_nl_constant,
    ))
}

/// The `.nl` variable bounds as `pounce-convex`'s explicit box, with an
/// absent bound spelled `∓∞`.
///
/// Both extractors used to emit each finite bound as a `G` row (`x_i ≤ x_u`,
/// `−x_i ≤ −x_l`) and leave `lb`/`ub` empty. That was never wrong — the IPM
/// re-expands finite bounds into exactly those rows internally — but it threw
/// away the one thing the solvers can only get from the box: **that these
/// rows are a box**. Three consequences, all real:
///
/// * The empty-box screen ([`pounce_convex`]'s `screen_variable_box`, gh #491)
///   reads `lb`/`ub`, so a model with a reversed bound arrived as a pair of
///   contradictory rows instead — an infeasibility that has to be *certified*
///   numerically rather than seen. The interior-point method managed that at
///   most widths but returned `NumericalFailure` at a `NaN` iterate for
///   crossings around `1e-8`.
/// * The active-set engine handles a box with bound *statuses*, not with
///   constraint rows; feeding it `2n` extra rows made every `.nl` QP that much
///   larger in the one dimension an active-set method pays combinatorially
///   for.
/// * Presolve reasons about `tlb`/`tub` directly, so bounds hidden in rows had
///   to be rediscovered by activity-based tightening before any box reduction
///   could fire.
///
/// The bound *multipliers* now come back in the solution's `z_lb`/`z_ub`
/// rather than being decoded out of `z` by row position.
fn extract_box(prob: &NlProblem, relax: BoundRelax) -> (Vec<f64>, Vec<f64>) {
    // Two declared boxes are passed through untouched.
    //
    // A variable pinned by `x_l == x_u` is fixed, and upstream's default
    // `fixed_variable_treatment=make_parameter` lifts it out of the problem
    // before `relax_bounds` runs — so it is never widened. Keep it pinned
    // here too; widening it would hand the solver two decision variables'
    // worth of slack that the NLP path does not have.
    //
    // A *crossed* box (`x_l > x_u`) is an empty set, and the NLP path rejects
    // it as `Invalid_Problem_Definition` before relaxation. Widening it by
    // more than the crossing would close the gap and return an optimal point
    // for a model with no feasible one — gh #491's `1e-8` fixture crosses by
    // less than the default `2 × 1e-8` widening. Leave it crossed so the
    // empty-box screen downstream still sees it.
    let as_declared = |i: usize| {
        let (l, u) = (prob.x_l[i], prob.x_u[i]);
        lower_bound_present(l) && upper_bound_present(u) && l >= u
    };
    let lb = (0..prob.n)
        .map(|i| {
            let v = prob.x_l[i];
            if !lower_bound_present(v) {
                f64::NEG_INFINITY
            } else if as_declared(i) {
                v
            } else {
                v - relax.var_delta(v)
            }
        })
        .collect();
    let ub = (0..prob.n)
        .map(|i| {
            let v = prob.x_u[i];
            if !upper_bound_present(v) {
                f64::INFINITY
            } else if as_declared(i) {
                v
            } else {
                v + relax.var_delta(v)
            }
        })
        .collect();
    (lb, ub)
}

/// Map the QP solver's multipliers `(y, z)` back to a per-`.nl`-
/// constraint dual vector (length `prob.m`), in the AMPL `.sol`
/// convention used by POUNCE's NLP path.
///
/// The QP solver enforces stationarity `∇f + Aᵀy + Gᵀz = 0` with
/// `z ≥ 0`, where each inequality `.nl` row contributes a `row ≤ g_u`
/// (`+row`) and/or `−row ≤ −g_l` (`−row`) `G` row. The per-constraint
/// `.nl`/Ipopt multiplier `λ` is recovered as:
/// - equality: `λ = sign · y[a_row]`;
/// - inequality: `λ = sign · (z_upper − z_lower)` — at most one of the
///   two bound rows is active at a solution.
///
/// The inequality sign (`z_upper − z_lower`, *not* `z_lower − z_upper`)
/// is fixed to match POUNCE's NLP path, which is the reference for what
/// a POUNCE `.sol` carries; this is verified empirically against the NLP
/// solve in the crate tests. `sign` undoes the maximize→minimize
/// negation so the reported dual is in the user's original sense.
pub fn recover_duals(prob: &NlProblem, con_map: &[ConRowMap], y: &[f64], z: &[f64]) -> Vec<f64> {
    let sign = if prob.minimize { 1.0 } else { -1.0 };
    con_map
        .iter()
        .map(|m| match m {
            ConRowMap::Eq { a_row } => sign * y[*a_row],
            ConRowMap::Ineq { upper, lower } => {
                let zu = upper.map(|r| z[r]).unwrap_or(0.0);
                let zl = lower.map(|r| z[r]).unwrap_or(0.0);
                sign * (zu - zl)
            }
        })
        .collect()
}

/// The next 0-based row index for a constraint block keyed by its RHS
/// vector's current length.
fn next_row(rhs: &[f64]) -> usize {
    rhs.len()
}

/// Recover the per-variable **bound multipliers** from a solved QP or SOCP.
///
/// Both extractors put the `.nl` variable bounds in the explicit box
/// ([`extract_box`]), so the solver returns their multipliers directly in
/// `z_lb`/`z_ub` and this is a length-normalizing read rather than the
/// row-position decode it used to be. Variables are 1:1 with the `.nl`
/// variables in both extractors, so no index remap is needed; a slot without
/// a finite bound stays `0.0` because no bound was active there.
///
/// The returned `z_lb` / `z_ub` are the raw non-negative multipliers of the
/// *internal minimize* problem (a maximize objective was negated during
/// extraction); the caller applies the maximize `sign` and the Ipopt
/// `ipopt_zL_out = +z_l`, `ipopt_zU_out = −z_u` output convention.
pub fn recover_bound_mults(prob: &NlProblem, sol: &QpSolution) -> (Vec<f64>, Vec<f64>) {
    let read = |v: &[f64]| -> Vec<f64> {
        (0..prob.n)
            .map(|i| v.get(i).copied().unwrap_or(0.0))
            .collect()
    };
    (read(&sol.z_lb), read(&sol.z_ub))
}

// ===========================================================================
// QCQP → SOCP extraction
// ===========================================================================

/// Where each `.nl` constraint landed in the standard-form **conic** program,
/// so the cone multipliers can be mapped back to a per-`.nl`-constraint dual.
/// One entry per original constraint, in order. (Analogue of [`ConRowMap`] for
/// the SOCP path produced by [`extract_socp_with_map`].)
#[derive(Debug, Clone)]
pub enum ConSocpMap {
    /// Linear equality → row `a_row` of `A` (multiplier `y[a_row]`).
    Eq { a_row: usize },
    /// Linear inequality / range → up to two rows of the nonnegative `G`
    /// block (`row ≤ g_u` and/or `−row ≤ −g_l`), multipliers `z[..] ≥ 0`.
    Ineq {
        upper: Option<usize>,
        lower: Option<usize>,
    },
    /// Convex quadratic inequality `g(x) ≤ g_u`, reformulated to one
    /// second-order cone. The first two cone rows both carry the linear
    /// coefficient vector `a/κ`, so the original constraint multiplier is
    /// recovered as `(z[r0] + z[r1])/κ` (see [`recover_socp_duals`]; `κ` is
    /// the rotated cone's balancing factor, `1` unless `|b| > 1`).
    Quad {
        z_row0: usize,
        z_row1: usize,
        kappa: f64,
    },
}

/// A deferred second-order-cone block, built after the nonnegative `G` rows
/// are known so the cones partition `G` in row order (nonneg block first,
/// then the SOCs).
/// Everything here is sized by the row's own **support** `k` — the variables
/// that actually appear in it — never by the problem width `n`. A QCQP row
/// typically touches a handful of variables out of `n` in the hundreds of
/// thousands (`nql180`: `k = 2`, `n = 129 601`), so an `n`-sized structure per
/// row is the difference between kilobytes and tens of gigabytes.
struct SocBlock {
    /// Index in `con_map` of the originating constraint, to patch with the
    /// final cone-row indices once they are assigned.
    con_idx: usize,
    /// Linear coefficients of the constraint as `(variable, coefficient)`,
    /// ascending by variable and with zeros dropped.
    a: Vec<(usize, f64)>,
    /// `b_eff = (nonlinear constant) − g_u`, the constraint's degree-0 term
    /// after moving the upper bound to the right: `½xᵀQx + aᵀx + b_eff ≤ 0`.
    b_eff: f64,
    /// Rows of the factor `F` with `FᵀF = Q`, each a sparse
    /// `(variable, coefficient)` list in the problem's own indexing.
    ///
    /// Sparse rather than length-`n` (or even length-`k`) dense: a diagonal
    /// `Q` — the `qssp180`/`nql180` regime — has rank `k` and one nonzero per
    /// factor row, so a dense factor would be `k²` to hold a `k`-nonzero
    /// object.
    f_rows: Vec<Vec<(usize, f64)>>,
}

/// Convert a classified **convex QCQP** `NlProblem` into the conic standard
/// form the SOCP IPM consumes:
///
/// ```text
/// minimize    ½ xᵀP x + cᵀx
/// subject to  A x = b
///             h − G x  ∈  K        (K = nonneg orthant × second-order cones)
/// ```
///
/// Returns `(QpProblem, con_map, obj_nl_constant, cones)`:
/// - the objective `P`/`c` exactly as the LP/QP path builds them;
/// - linear equalities in `A`/`b`; linear inequalities and finite variable
///   bounds as a leading **nonnegative** `G` block; and each convex quadratic
///   inequality `g(x) ≤ g_u` as one **second-order cone** block appended
///   after it (so `cones` covers the `G` rows in order);
/// - `con_map` mapping each original constraint to its rows for dual recovery;
/// - `obj_nl_constant`, the objective's folded degree-0 term (added back to the
///   reported value, exactly as in [`extract_qp_with_map`]).
///
/// `None` if the objective is not degree-≤2 (should not happen for a problem
/// the classifier routed here). The reformulation of a convex quadratic
/// `½xᵀQx + aᵀx + b_eff ≤ 0` (with `Q = FᵀF ⪰ 0`) is the standard rotated→
/// standard SOC: writing `s = −(aᵀx + b_eff)`, the cone slack
/// `(s+1, s−1, √2·Fx)` lies in the second-order cone iff `‖Fx‖² ≤ 2s`, i.e.
/// iff the original constraint holds.
///
/// The cone is **centred** first (gh #1041): the part of `a` in the range of
/// `Fᵀ` is absorbed by completing the square, `Fᵀw = a_∥`, so the constraint
/// becomes `½‖Fx + w‖² + a_⊥ᵀx + (b_eff − ½‖w‖²) ≤ 0` and the cone slack is
/// `(s+1, s−1, √2·(Fx + w))` with `s = −(a_⊥ᵀx + b_eff − ½‖w‖²)`. See
/// [`centre_soc`] for why the uncentred form fails on a ball far from the
/// origin.
pub fn extract_socp_with_map(
    prob: &NlProblem,
    relax: BoundRelax,
) -> Option<(QpProblem, Vec<ConSocpMap>, f64, Vec<ConeSpec>)> {
    let n = prob.n;
    let sign = if prob.minimize { 1.0 } else { -1.0 };

    // --- objective P (lower triangle) + folded linear / constant terms ---
    let (hess, obj_nl_linear, obj_nl_constant) = prob.obj_nonlinear.analyze_quadratic_full()?;
    let mut p_lower: Vec<Triplet> = Vec::with_capacity(hess.len());
    for ((i, j), v) in &hess {
        let (row, col) = if i >= j { (*i, *j) } else { (*j, *i) };
        p_lower.push(Triplet::new(row, col, sign * v));
    }
    let mut c = vec![0.0; n];
    for (var, coef) in &prob.obj_linear {
        c[*var] += sign * coef;
    }
    for (var, coef) in &obj_nl_linear {
        c[*var] += sign * coef;
    }

    // --- constraints: equalities → A; linear ineqs → nonneg G block;
    //     convex quadratics → deferred SOC blocks (added after the nonneg
    //     rows so the cones partition G in row order) ---
    let mut a: Vec<Triplet> = Vec::new();
    let mut b: Vec<f64> = Vec::new();
    let mut g: Vec<Triplet> = Vec::new();
    let mut h: Vec<f64> = Vec::new();
    let mut con_map: Vec<ConSocpMap> = Vec::with_capacity(prob.m);
    let mut soc_blocks: Vec<SocBlock> = Vec::new();

    for (row, lin) in prob.con_linear.iter().enumerate() {
        let lo = prob.g_l[row];
        let hi = prob.g_u[row];
        let nl = &prob.con_nonlinear[row];
        let quad = nl.analyze_quadratic_full();
        let is_quadratic = matches!(&quad, Some((hmap, _, _)) if !hmap.is_empty());

        if is_quadratic {
            // Convex quadratic inequality `g(x) ≤ g_u` (the classifier
            // guarantees an upper-only bound with PSD Hessian). Build the
            // factor F (FᵀF = Q) and defer the SOC rows.
            let (hmap, nl_lin, nl_const) = quad.expect("checked above");
            // Linear coefficients a = linear-section + folded nonlinear-tree
            // linear part, accumulated sparsely: a QCQP row's linear part is
            // as narrow as its quadratic part, and `n` here can be six digits.
            let mut a_map: std::collections::BTreeMap<usize, f64> =
                std::collections::BTreeMap::new();
            for (var, coef) in lin {
                *a_map.entry(*var).or_insert(0.0) += *coef;
            }
            for (var, coef) in &nl_lin {
                *a_map.entry(*var).or_insert(0.0) += *coef;
            }
            let a_vec: Vec<(usize, f64)> = a_map.into_iter().filter(|&(_, c)| c != 0.0).collect();

            let f_rows = socp_factor_rows(&hmap);
            let con_idx = con_map.len();
            con_map.push(ConSocpMap::Quad {
                z_row0: 0,
                z_row1: 0,
                kappa: 1.0,
            }); // patched in the SOC pass below
            soc_blocks.push(SocBlock {
                con_idx,
                a: a_vec,
                b_eff: nl_const - (hi + relax.row_delta(hi)),
                f_rows,
            });
            continue;
        }

        // Linear constraint. Combine the `.nl` linear section with any
        // degree-≤1 terms AMPL folded into the (here empty-Hessian)
        // nonlinear tree, and shift the bounds by the folded constant.
        let (nl_lin, const_shift) = quad.map(|(_, l, k)| (l, k)).unwrap_or_default();
        let mut coef = vec![0.0; n];
        for (var, v) in lin {
            coef[*var] += *v;
        }
        for (var, v) in &nl_lin {
            coef[*var] += *v;
        }
        let nonzeros = || coef.iter().enumerate().filter(|(_, v)| **v != 0.0);
        if lo == hi && lower_bound_present(lo) && upper_bound_present(hi) {
            let eq_row = next_row(&b);
            for (var, v) in nonzeros() {
                a.push(Triplet::new(eq_row, var, *v));
            }
            b.push(lo - const_shift);
            con_map.push(ConSocpMap::Eq { a_row: eq_row });
        } else {
            let relax = relax.for_row(lo, hi);
            let upper = if upper_bound_present(hi) {
                let gr = next_row(&h);
                for (var, v) in nonzeros() {
                    g.push(Triplet::new(gr, var, *v));
                }
                h.push(hi + relax.row_delta(hi) - const_shift);
                Some(gr)
            } else {
                None
            };
            let lower = if lower_bound_present(lo) {
                let gr = next_row(&h);
                for (var, v) in nonzeros() {
                    g.push(Triplet::new(gr, var, -*v));
                }
                h.push(-(lo - relax.row_delta(lo) - const_shift));
                Some(gr)
            } else {
                None
            };
            con_map.push(ConSocpMap::Ineq { upper, lower });
        }
    }

    // Variable bounds go in the explicit box, not into this orthant block —
    // see [`extract_box`]. `solve_socp_ipm` appends them as a trailing
    // nonnegative block of its own, *after* the cones, so they stay outside
    // the partition `cones` has to cover.
    let (lb, ub) = extract_box(prob, relax);

    // The nonnegative block is every G row built so far. The cones list must
    // cover G in row order: this orthant block, then one SOC per quadratic.
    let num_nonneg = h.len();
    let mut cones: Vec<ConeSpec> = Vec::with_capacity(1 + soc_blocks.len());
    if num_nonneg > 0 {
        cones.push(ConeSpec::Nonneg(num_nonneg));
    }

    // --- emit the deferred second-order cones ---
    for blk in soc_blocks {
        let r = blk.f_rows.len();
        let dim = r + 2;
        // Complete the square: `a = Fᵀw + a_⊥`, `b = b_eff − ½‖w‖²`.
        let (a_perp, w) = centre_soc(&blk.f_rows, &blk.a);
        let b_c = blk.b_eff - 0.5 * w.iter().map(|v| v * v).sum::<f64>();
        // Balance the rotated cone's two factors (gh #1056): see
        // [`rotated_cone_balance`]. `κ = 1` is the historical `(s+1, s−1)`.
        let kappa = rotated_cone_balance(b_c);
        let row0 = next_row(&h);
        // s0 = s/κ + κ, s = −b − a_⊥ᵀx  →  G row = a_⊥/κ, h = −b/κ + κ.
        for &(var, coef) in &a_perp {
            g.push(Triplet::new(row0, var, coef / kappa));
        }
        h.push(-b_c / kappa + kappa);
        let row1 = next_row(&h);
        // s1 = s/κ − κ  →  G row = a_⊥/κ, h = −b/κ − κ.
        for &(var, coef) in &a_perp {
            g.push(Triplet::new(row1, var, coef / kappa));
        }
        h.push(-b_c / kappa - kappa);
        // s_{2+k} = √2·(Fx + w)_k  →  G row = −√2·F_k, h = √2·w_k.
        let sqrt2 = std::f64::consts::SQRT_2;
        for (f, &wk) in blk.f_rows.iter().zip(&w) {
            let gr = next_row(&h);
            for &(var, fv) in f {
                g.push(Triplet::new(gr, var, -sqrt2 * fv));
            }
            h.push(sqrt2 * wk);
        }
        cones.push(ConeSpec::SecondOrder(dim));
        con_map[blk.con_idx] = ConSocpMap::Quad {
            z_row0: row0,
            z_row1: row1,
            kappa,
        };
    }

    Some((
        QpProblem {
            n,
            p_lower,
            c,
            a,
            b,
            g,
            h,
            lb,
            ub,
        },
        con_map,
        obj_nl_constant,
        cones,
    ))
}

/// Map the SOCP solver's multipliers `(y, z)` back to a per-`.nl`-constraint
/// dual vector (length `prob.m`), in POUNCE's NLP-path `.sol` convention.
///
/// Linear rows reuse the QP-path recovery (`y[a_row]` for an equality;
/// `z_upper − z_lower` for an inequality). For a convex quadratic
/// `g(x) ≤ g_u` reformulated to a second-order cone, the constraint
/// multiplier is recovered as the sum of the two cone duals on the rows
/// carrying the linear coefficient vector `a`: `λ = z[r0] + z[r1]`. (At a
/// KKT point stationarity reads `λ(∇g) = (z[r0]+z[r1])·a + …`, so this sum is
/// the original multiplier; the cone's remaining rows reconstruct the `Qx`
/// part.) `sign` undoes the maximize→minimize negation.
pub fn recover_socp_duals(
    prob: &NlProblem,
    con_map: &[ConSocpMap],
    y: &[f64],
    z: &[f64],
) -> Vec<f64> {
    let sign = if prob.minimize { 1.0 } else { -1.0 };
    con_map
        .iter()
        .map(|m| match m {
            ConSocpMap::Eq { a_row } => sign * y[*a_row],
            ConSocpMap::Ineq { upper, lower } => {
                let zu = upper.map(|r| z[r]).unwrap_or(0.0);
                let zl = lower.map(|r| z[r]).unwrap_or(0.0);
                sign * (zu - zl)
            }
            ConSocpMap::Quad {
                z_row0,
                z_row1,
                kappa,
            } => sign * (z[*z_row0] + z[*z_row1]) / kappa,
        })
        .collect()
}

/// The balancing factor `κ` for a rotated cone whose constant is `b`
/// (gh #1056).
///
/// `½‖y‖² ≤ s` is the rotated cone `2·u·v ≥ ‖y‖²` with `u·v = s`, emitted as
/// the standard cone `(u + v, u − v, √2·y)`. Taking `v = 1` — the historical
/// `(s + 1, s − 1)` — puts the whole magnitude of `s` in one factor, and in
/// doubles `1e20 ± 1` are both `1e20`: on `x₀² + x₁² ≤ 1e20` the row was
/// `(1e20, 1e20, 2x₀, 2x₁)`, whose determinant is `−4‖x‖²`, so the declared
/// cone was empty but for `x = 0` and the conic IPM ended `Numerical
/// failure`. Well before the `1` vanishes the imbalance costs: the same
/// inactive ball takes 159 iterations at `1e6`, and an *active* ball of
/// radius `1e4` already failed.
///
/// `u = s/κ`, `v = κ` keeps `4uv = 4s`, so cone membership is unchanged, and
/// with `κ ≈ √|b|` the two factors are the same size wherever `s` is near its
/// constant. A power of two, so `s/κ` and `a/κ` are exact; `1` when
/// `|b| ≤ 1`, which leaves every such row exactly as it was. The multiplier
/// maps back as `(z₀ + z₁)/κ` ([`recover_socp_duals`]).
pub(crate) fn rotated_cone_balance(b: f64) -> f64 {
    if !(b.abs() > 1.0) || !b.is_finite() {
        return 1.0;
    }
    let k = 2.0_f64.powi((0.5 * b.abs().log2()).round() as i32);
    if k.is_finite() && k > 0.0 { k } else { 1.0 }
}

/// Split a quadratic row's linear part `a` into `Fᵀw + a_⊥` (gh #1041),
/// returning `(a_⊥, w)` with `w` indexed like `f_rows`.
///
/// Without this the rotated cone carries `‖Fx‖²` and `2s = −2(aᵀx + b_eff)`
/// as two separate, huge quantities whose *difference* is the constraint: on
/// `(x − 1000)² ≤ 1` both are ~2·10⁶ at the optimum while the ball's radius is
/// 1, so the cone is pinned to its boundary to six digits and the conic IPM
/// stalls at an infeasible point (x ≈ 1003.4). Centred, the same row is
/// `(2, 0, 2(x − 1000))` — the explicit SOC `pounce.solve_socp` solves
/// exactly. The cancellation still happens, but once, in the scalar
/// `b_eff − ½‖w‖²`, not inside every iterate.
///
/// `w` is the least-squares solution of `Fᵀw = a` (normal equations
/// `FFᵀw = Fa`, positive definite because the factor rows are linearly
/// independent by construction). A diagonal factor — one variable per row —
/// takes the closed form `w_k = a_i / f_k` and leaves `a_⊥` exactly zero on
/// the factored variables. Otherwise a residual entry at roundoff level of the
/// two terms it is the difference of is set to zero, so a ball whose centre
/// is in range does not keep a spurious `1e-16`-scale linear term.
fn centre_soc(f_rows: &[Vec<(usize, f64)>], a: &[(usize, f64)]) -> (Vec<(usize, f64)>, Vec<f64>) {
    use std::collections::BTreeMap;
    let r = f_rows.len();
    if r == 0 {
        return (a.to_vec(), Vec::new());
    }
    let a_map: BTreeMap<usize, f64> = a.iter().copied().collect();
    let a_at = |var: usize| a_map.get(&var).copied().unwrap_or(0.0);

    let diagonal = f_rows.iter().all(|f| f.len() == 1) && {
        let mut vars: Vec<usize> = f_rows.iter().map(|f| f[0].0).collect();
        vars.sort_unstable();
        vars.windows(2).all(|p| p[0] != p[1])
    };
    if diagonal {
        let w: Vec<f64> = f_rows.iter().map(|f| a_at(f[0].0) / f[0].1).collect();
        let covered: std::collections::BTreeSet<usize> = f_rows.iter().map(|f| f[0].0).collect();
        let a_perp = a
            .iter()
            .copied()
            .filter(|(v, _)| !covered.contains(v))
            .collect();
        return (a_perp, w);
    }

    // Normal equations `M w = F a`, `M = F Fᵀ` (r×r, SPD).
    let dense_rows: Vec<BTreeMap<usize, f64>> =
        f_rows.iter().map(|f| f.iter().copied().collect()).collect();
    let dot = |x: &BTreeMap<usize, f64>, y: &[(usize, f64)]| -> f64 {
        y.iter()
            .map(|(v, c)| c * x.get(v).copied().unwrap_or(0.0))
            .sum()
    };
    let mut m = vec![0.0; r * r];
    for i in 0..r {
        for j in 0..=i {
            let v = dot(&dense_rows[i], &f_rows[j]);
            m[i * r + j] = v;
            m[j * r + i] = v;
        }
    }
    let mut w: Vec<f64> = f_rows
        .iter()
        .map(|f| f.iter().map(|&(v, c)| c * a_at(v)).sum())
        .collect();
    // Cholesky M = L Lᵀ in place (lower triangle), then two triangular solves.
    for j in 0..r {
        let diag = m[j * r + j];
        let mut d = diag;
        for k in 0..j {
            d -= m[j * r + k] * m[j * r + k];
        }
        // A dependent row's pivot is the difference of `diag` and what the
        // earlier rows explain of it, so it lands at roundoff of `diag` —
        // often just *above* zero — not at zero. Testing `d <= 0` alone let
        // that through and solved with a pivot of pure noise.
        if d.is_nan() || d <= 16.0 * f64::EPSILON * diag {
            // Numerically rank-deficient factor: leave the cone uncentred,
            // which is exactly the pre-gh#1041 reformulation. Traced, because
            // an offset ball that lands here is back to the conditioning
            // gh#1041 fixed and would otherwise fail with no clue why.
            tracing::debug!(
                target: "pounce::socp",
                rank = r, pivot = j, value = d,
                "centre_soc: FFᵀ not positive definite; SOC block left uncentred"
            );
            return (a.to_vec(), vec![0.0; r]);
        }
        let d = d.sqrt();
        m[j * r + j] = d;
        for i in (j + 1)..r {
            let mut v = m[i * r + j];
            for k in 0..j {
                v -= m[i * r + k] * m[j * r + k];
            }
            m[i * r + j] = v / d;
        }
    }
    for i in 0..r {
        for k in 0..i {
            w[i] -= m[i * r + k] * w[k];
        }
        w[i] /= m[i * r + i];
    }
    for i in (0..r).rev() {
        for k in (i + 1)..r {
            w[i] -= m[k * r + i] * w[k];
        }
        w[i] /= m[i * r + i];
    }

    // a_⊥ = a − Fᵀw over the union of a's and F's supports.
    let mut ftw: BTreeMap<usize, f64> = BTreeMap::new();
    for (f, &wk) in f_rows.iter().zip(&w) {
        for &(v, c) in f {
            *ftw.entry(v).or_insert(0.0) += c * wk;
        }
    }
    let mut vars: Vec<usize> = a_map.keys().chain(ftw.keys()).copied().collect();
    vars.sort_unstable();
    vars.dedup();
    let a_perp = vars
        .into_iter()
        .filter_map(|v| {
            let (av, fv) = (a_at(v), ftw.get(&v).copied().unwrap_or(0.0));
            let res = av - fv;
            let roundoff = 16.0 * f64::EPSILON * av.abs().max(fv.abs());
            (res.abs() > roundoff).then_some((v, res))
        })
        .collect();
    (a_perp, w)
}

/// Factor one quadratic row's Hessian `Q` into sparse rows `f_k` (in the
/// problem's variable indexing) with `Σ_k f_k f_kᵀ = Q`.
///
/// Two paths, and the cheap one is the common one:
///
/// * **Diagonal `Q`** — `f` is one row per positive diagonal entry, each with a
///   single nonzero `√d_i`. `O(k)` time and `O(k)` space in the row's support.
///   This is the `qssp180`/`nql180` regime, where the general path's `O(k³)`
///   factorization and `k²` factor would both be ruinous for no benefit.
/// * **Otherwise** — pivoted Cholesky on a dense `k×k` over the row's support,
///   then scatter the rows back to problem indices, dropping zeros. Sized by
///   `k`, never by `n`.
fn socp_factor_rows(
    hmap: &std::collections::BTreeMap<(usize, usize), f64>,
) -> Vec<Vec<(usize, f64)>> {
    let support = quad_support(hmap);
    let k = support.len();

    if !hmap.keys().any(|&(i, j)| i != j) {
        // Diagonal: one factor row per variable, holding that entry's square
        // root. Nonpositive diagonal entries are the zero eigenvalues of a PSD
        // diagonal matrix (convexity is already established before we get
        // here), and contribute no row.
        //
        // Two details make this a *shortcut* rather than an approximation, so
        // the fast path and the general path emit bit-identical factors and a
        // problem's trajectory cannot depend on which one ran:
        //
        //  * the tolerance is the same expression `psd_outer_factor` uses, so
        //    both drop exactly the same entries and agree on the cone's
        //    dimension. Since gh #703 that expression is **relative to the
        //    entry's own magnitude**, not to the largest diagonal: on a
        //    diagonal `Q` no downdate ever touches another pivot, so every
        //    positive entry is a genuine eigenvalue whatever its size, and the
        //    filter here is simply `v > 0`. Cutting at `1e-12 · max_diag`
        //    instead discarded real directions on a column-scaled model — see
        //    `psd_outer_factor`;
        //  * the value is `d / √d`, not `√d`. They differ by an ulp — `√2` is
        //    `0x1.6a09e667f3bcdp+0` and `2/√2` is `0x1.6a09e667f3bccp+0` — and
        //    `d / √d` is what the general path's `a[i][p] / d_pivot` computes.
        //    Reproducing it is free; not reproducing it moved `qcqp_ball` from
        //    17 conic iterations to 12 on a 2-ulp perturbation of one `G`
        //    entry, which is precisely the kind of invisible trajectory change
        //    `scripts/sweep-fixtures.sh` exists to catch.
        //  * the rows come out in **pivot order**, largest diagonal first. On a
        //    diagonal matrix the rank-1 downdate only zeros the pivot, so the
        //    general path's complete pivoting visits entries in descending
        //    order with ties going to the lower index — which is what a
        //    *stable* sort of the (ascending-by-index) map entries gives.
        //    `‖Fx‖` does not care about row order, but `G` does: the rows land
        //    in the KKT matrix and the ordering feeds the fill-reducing
        //    permutation.
        let mut diag: Vec<(usize, f64)> = hmap
            .iter()
            .filter(|&(_, &v)| v > 0.0)
            .map(|(&(i, _), &v)| (i, v))
            .collect();
        diag.sort_by(|a, b| b.1.partial_cmp(&a.1).expect("PSD diagonal is finite"));
        return diag
            .into_iter()
            .map(|(i, v)| vec![(i, v / v.sqrt())])
            .collect();
    }

    let dense = dense_symmetric_on_support(hmap, &support);
    psd_outer_factor(dense, k)
        .into_iter()
        .map(|f| {
            f.into_iter()
                .enumerate()
                .filter(|&(_, fv)| fv != 0.0)
                .map(|(loc, fv)| (support[loc], fv))
                .collect()
        })
        .collect()
}

/// The variables a quadratic row touches, ascending and deduplicated.
///
/// This is the row's *support*, and it is what every downstream structure is
/// sized by. `hmap` stores only `i ≤ j`, so both coordinates must be collected.
fn quad_support(hmap: &std::collections::BTreeMap<(usize, usize), f64>) -> Vec<usize> {
    let mut s: Vec<usize> = hmap.keys().flat_map(|&(i, j)| [i, j]).collect();
    s.sort_unstable();
    s.dedup();
    s
}

/// Build a dense symmetric `k×k` matrix over a row's `support` from a
/// [`QuadHessian`]-style map of `(i ≤ j) → Hessian entry` (diagonal entries are
/// the full `∂²/∂xᵢ²`, so `½xᵀHx` reproduces the quadratic form). Off-diagonals
/// are mirrored.
///
/// Sized by `k`, never by `n`: the previous `n×n` version asked for 134 GB on a
/// two-variable row of `nql180`.
fn dense_symmetric_on_support(
    hmap: &std::collections::BTreeMap<(usize, usize), f64>,
    support: &[usize],
) -> Vec<f64> {
    let k = support.len();
    // `support` is sorted, so a binary search is the local index.
    let loc = |v: usize| support.binary_search(&v).expect("key came from support");
    let mut dense = vec![0.0; k * k];
    for (&(i, j), &v) in hmap {
        let (li, lj) = (loc(i), loc(j));
        dense[li * k + lj] = v;
        dense[lj * k + li] = v;
    }
    dense
}

/// Symmetric **pivoted (rank-revealing) Cholesky** of a PSD matrix `H`
/// (row-major `n×n`, consumed as scratch), returning the factor rows `f_k`
/// (each length `n`) such that `Σ_k f_k f_kᵀ = H` — equivalently `FᵀF = H`
/// with `F` the matrix whose rows are the `f_k`.
///
/// Callers pass a **row's support size** `k` here, not the problem width: this
/// is `O(n³)` in whatever it is handed, so the distinction is what makes a wide
/// QCQP extractable at all.
///
/// The number of rows is the
/// numerical rank, so a rank-deficient `Q` (e.g. `Q = vvᵀ`) yields the
/// minimal cone. Complete diagonal pivoting keeps the factorization stable
/// on the indefinite-looking-but-PSD matrices finite precision can produce.
///
/// # The rank test is relative to each pivot's own starting magnitude (gh #703)
///
/// This used to cut at `1e-12 · max_diag` — a *global* threshold — and that
/// is not a rank test, it is a units test. Rank deficiency is what the
/// rank-1 downdate reveals: a direction already spanned by the pivots taken
/// so far has its residual diagonal driven from `Q_pp` to (numerically)
/// zero. A direction that is merely *small in the coordinates the model was
/// written in* has its residual diagonal stay a healthy fraction of `Q_pp`,
/// and is a genuine eigenvalue however far below `max_diag` it sits.
///
/// The global cut confused the two, and silently. On
/// `qcqp_columns_illcond.nl` — the well-conditioned fixture under the exact
/// substitution `x_j → x_j / c_j`, so a matrix of provably identical rank —
/// the diagonal spans `[1.5e-7, 4.3e9]`, `1e-12 · max_diag ≈ 4.3e-3`
/// discarded **7 of 24** directions, and the cone `‖Fx‖ ≤ t` stopped
/// constraining them. The conic solver then satisfied *its* cone to
/// `2.66e-15` and reported `SolveSucceeded` at an objective 10% away from
/// the true optimum, on a point that violates the original quadratic row by
/// `4.948e+01` — 38% of its right-hand side. A relative residual check
/// would not have caught it either: measured against `‖Q‖ = 4.3e9` the
/// reconstruction error is `5.4e-13`. The dropped rank is the only signal.
///
/// `a[p][p] > 1e-12 · Q_pp` is that test, and it is invariant under the
/// diagonal congruence `Q → CQC` that provoked the bug, since both sides
/// scale by `c_p²`. It changes nothing about the pivot *order* (still the
/// largest remaining diagonal), so a well-scaled matrix factors bit for bit
/// as before, and it keeps the diagonal shortcut above interchangeable with
/// this path: on a diagonal `Q` no downdate touches a pivot, so both keep
/// exactly the positive entries.
fn psd_outer_factor(mut a: Vec<f64>, n: usize) -> Vec<Vec<f64>> {
    let mut rows: Vec<Vec<f64>> = Vec::new();
    // Each pivot's *initial* diagonal, so the rank test below can ask how far
    // the downdate has moved it rather than how it compares to the model's
    // units. Clamped at zero: a PSD matrix has `Q_ii ≥ 0`, and an entry that
    // finite precision has pushed slightly negative must not produce a
    // negative threshold that admits it.
    let d0: Vec<f64> = (0..n).map(|i| a[i * n + i].max(0.0)).collect();
    // Columns already decided — either factored out, or ruled a zero
    // eigenvalue. A pivoted Cholesky never revisits a pivot, and the residual
    // it leaves on that diagonal is roundoff, not a candidate.
    let mut settled = vec![false; n];
    for _ in 0..n {
        // Largest undecided diagonal pivot.
        let mut p = usize::MAX;
        let mut best = f64::NEG_INFINITY;
        for i in 0..n {
            if settled[i] {
                continue;
            }
            let d = a[i * n + i];
            if d > best {
                best = d;
                p = i;
            }
        }
        if p == usize::MAX {
            break;
        }
        // Rule it a zero eigenvalue when the downdate has reduced it to a
        // negligible fraction of where it started — that is the residual
        // saying the direction is already spanned. `best <= 0` (including a
        // pivot whose `d0` is zero, where the threshold is zero) rules it out
        // too.
        //
        // `continue`, not `break`: with an *absolute* threshold the pivot
        // order and the rank order were the same order, so the first failure
        // ended it. A relative threshold decouples them — a column whose `d0`
        // is `1e-20` is still live at a residual of `1e-20`, while a spent
        // column with `d0 = 2` is dead at the `4e-16` of roundoff it carries,
        // and the dead one sorts first. Breaking there would drop the live
        // column and make the rank depend on the model's units again, which
        // is the whole defect this test was rewritten to fix.
        if best <= 1e-12 * d0[p] || best <= 0.0 {
            settled[p] = true;
            continue;
        }
        settled[p] = true;
        let d = best.sqrt();
        // f = column p of the residual, scaled by 1/d.
        let mut f = vec![0.0; n];
        for i in 0..n {
            f[i] = a[i * n + p] / d;
        }
        // Rank-1 downdate: A ← A − f fᵀ.
        for i in 0..n {
            let fi = f[i];
            if fi == 0.0 {
                continue;
            }
            for j in 0..n {
                a[i * n + j] -= fi * f[j];
            }
        }
        rows.push(f);
    }
    rows
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::nl_reader::NlBody;
    use crate::nl_reader::{BinOp, Expr};
    use pounce_convex::{QpOptions, QpStatus, solve_qp_ipm, solve_socp_ipm};
    use pounce_feral::FeralSolverInterface;
    use pounce_linsol::SparseSymLinearSolverInterface;

    fn backend() -> Box<dyn SparseSymLinearSolverInterface> {
        Box::new(FeralSolverInterface::new())
    }

    fn pow2(var: usize) -> Expr {
        Expr::Binary(
            BinOp::Pow,
            Box::new(Expr::Var(var)),
            Box::new(Expr::Const(2.0)),
        )
    }

    /// min −x0 − x1  s.t.  x0² + x1² ≤ 1  → x* = (1/√2, 1/√2), f* = −√2.
    /// Exercises the QCQP→SOCP reformulation end-to-end: a rank-2 ball
    /// constraint becomes one second-order cone, no nonnegative block.
    #[test]
    fn extract_and_solve_socp_ball() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 2,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, -1.0), (1, -1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(Expr::Binary(
                BinOp::Add,
                Box::new(pow2(0)),
                Box::new(pow2(1)),
            ))],
            con_linear: vec![vec![]],
            x_l: vec![-2e19, -2e19],
            x_u: vec![2e19, 2e19],
            g_l: vec![-2e19],
            g_u: vec![1.0],
            x0: vec![0.0, 0.0],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let (qp, con_map, obj_const, cones) =
            extract_socp_with_map(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(obj_const, 0.0);
        // No linear inequalities / bounds → no nonneg block; one SOC of
        // dimension rank(Q)+2 = 2+2 = 4.
        assert_eq!(cones, vec![ConeSpec::SecondOrder(4)]);
        assert_eq!(qp.m_ineq(), 4);

        let sol = solve_socp_ipm(&qp, &cones, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        let inv_sqrt2 = 1.0 / 2.0_f64.sqrt();
        assert!((sol.x[0] - inv_sqrt2).abs() < 1e-5, "x0={}", sol.x[0]);
        assert!((sol.x[1] - inv_sqrt2).abs() < 1e-5, "x1={}", sol.x[1]);
        assert!(
            (sol.obj - (-2.0_f64.sqrt())).abs() < 1e-5,
            "obj={}",
            sol.obj
        );

        // Analytic multiplier: c + λ·2x = 0 ⇒ λ = 1/(2x0) = √2/2 ≈ 0.7071,
        // positive (active upper bound), matching the `.sol` sign convention.
        let lambda = recover_socp_duals(&prob, &con_map, &sol.y, &sol.z);
        assert_eq!(lambda.len(), 1);
        assert!(
            (lambda[0] - 0.5 * 2.0_f64.sqrt()).abs() < 1e-3,
            "ball constraint dual={}",
            lambda[0]
        );
    }

    /// min x0  s.t.  (x0−3)² ≤ 1  → feasible x0 ∈ [2, 4], optimum x0 = 2.
    /// The constraint's linear (`−6x0`) and constant (`+9`) terms are folded
    /// into the nonlinear tree; the reformulation must recover `b_eff = 9 − 1`
    /// so the cone encodes `x0² − 6x0 + 8 ≤ 0`, not `x0² ≤ 1`.
    #[test]
    fn extract_and_solve_socp_folds_constraint_constant() {
        let con = Expr::Binary(
            BinOp::Pow,
            Box::new(Expr::Binary(
                BinOp::Sub,
                Box::new(Expr::Var(0)),
                Box::new(Expr::Const(3.0)),
            )),
            Box::new(Expr::Const(2.0)),
        );
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(con)],
            con_linear: vec![vec![]],
            x_l: vec![-2e19],
            x_u: vec![2e19],
            g_l: vec![-2e19],
            g_u: vec![1.0],
            x0: vec![0.0],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let (qp, _con_map, obj_const, cones) =
            extract_socp_with_map(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(obj_const, 0.0);
        assert_eq!(cones, vec![ConeSpec::SecondOrder(3)]); // rank 1 + 2.

        let sol = solve_socp_ipm(&qp, &cones, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 2.0).abs() < 1e-5, "x0={}", sol.x[0]);
    }

    /// Build `min −x_i − x_j  s.t.  x_i² + x_j² ≤ 1` over `n` variables, where
    /// `i` and `j` are neither low-numbered nor adjacent.
    fn wide_ball(n: usize, i: usize, j: usize) -> NlProblem {
        let sq = |v: usize| {
            Expr::Binary(
                BinOp::Pow,
                Box::new(Expr::Var(v)),
                Box::new(Expr::Const(2.0)),
            )
        };
        NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(i, -1.0), (j, -1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(Expr::Binary(
                BinOp::Add,
                Box::new(sq(i)),
                Box::new(sq(j)),
            ))],
            con_linear: vec![vec![]],
            x_l: vec![-10.0; n],
            x_u: vec![10.0; n],
            g_l: vec![-2e19],
            g_u: vec![1.0],
            x0: vec![0.0; n],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        }
    }

    /// The cone factor is built on the row's **support**, so its columns are
    /// support-local and must be scattered back through `support` on emission.
    /// If that scatter is dropped, a row touching `x11`/`x37` silently
    /// constrains `x0`/`x1` instead — a wrong answer, not a crash.
    #[test]
    fn socp_factor_columns_scatter_back_to_original_variables() {
        let prob = wide_ball(40, 11, 37);
        let (qp, _con_map, _obj_const, cones) =
            extract_socp_with_map(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(cones, vec![ConeSpec::SecondOrder(4)]); // rank 2 + 2.

        // Every G entry in the two factor rows must sit in column 11 or 37.
        // Rows 0 and 1 are the `a`-rows (here empty: no linear part).
        let factor_cols: std::collections::BTreeSet<usize> =
            qp.g.iter().filter(|t| t.row >= 2).map(|t| t.col).collect();
        assert_eq!(
            factor_cols,
            [11usize, 37].into_iter().collect(),
            "factor rows must reference the row's own variables, got {factor_cols:?}"
        );
    }

    /// The extractor must be sized by a row's support, not by the problem
    /// width. A two-variable quadratic row in a 50 000-variable problem needs
    /// kilobytes; sizing it `n×n` would ask for 20 GB and abort the process.
    #[test]
    fn socp_extraction_is_sized_by_support_not_problem_width() {
        let n = 50_000;
        let prob = wide_ball(n, 7, n - 3);
        let (qp, _con_map, _obj_const, cones) =
            extract_socp_with_map(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(cones, vec![ConeSpec::SecondOrder(4)]);
        // The cone contributes exactly two nonzeros per factor row.
        assert_eq!(qp.g.iter().filter(|t| t.row >= 2).count(), 2);
    }

    /// The same scatter, but through the **dense** path: a cross term makes `Q`
    /// non-diagonal, so the row goes through the pivoted Cholesky and its
    /// support-local columns must be mapped back. Rank 1, so one factor row.
    #[test]
    fn socp_dense_factor_columns_scatter_back_to_original_variables() {
        // (x11 + x37)² ≤ 1 — off-diagonal Q, rank 1.
        let con = Expr::Binary(
            BinOp::Pow,
            Box::new(Expr::Binary(
                BinOp::Add,
                Box::new(Expr::Var(11)),
                Box::new(Expr::Var(37)),
            )),
            Box::new(Expr::Const(2.0)),
        );
        let mut prob = wide_ball(40, 11, 37);
        prob.con_nonlinear = vec![NlBody::Tree(con)];

        let (qp, _con_map, _obj_const, cones) =
            extract_socp_with_map(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(cones, vec![ConeSpec::SecondOrder(3)], "rank 1 + 2");
        let factor_cols: std::collections::BTreeSet<usize> =
            qp.g.iter().filter(|t| t.row >= 2).map(|t| t.col).collect();
        assert_eq!(factor_cols, [11usize, 37].into_iter().collect());
    }

    /// A diagonal `Q` must not be densified. `socp_factor_rows` returns one
    /// single-nonzero row per positive diagonal entry, so the factor is `O(k)`
    /// — this is what makes the very large diagonal QCQPs (`qssp180`,
    /// `nql180`) representable at all.
    #[test]
    fn diagonal_hessian_factors_in_linear_space() {
        let mut h = std::collections::BTreeMap::new();
        for i in 0..1000usize {
            h.insert((i, i), 4.0);
        }
        let rows = socp_factor_rows(&h);
        assert_eq!(rows.len(), 1000);
        assert!(
            rows.iter().all(|r| r.len() == 1),
            "a diagonal Q must give one nonzero per factor row"
        );
        for (k, r) in rows.iter().enumerate() {
            assert_eq!(r[0].0, k);
            assert!((r[0].1 - 2.0).abs() < 1e-12, "√4 = 2, got {}", r[0].1);
        }
    }

    /// Both factor paths must satisfy the same contract, `Σ_k f_k f_kᵀ = Q`,
    /// and must agree on the rank. There are now two of them — an `O(k)`
    /// diagonal shortcut and the general pivoted Cholesky — so the contract is
    /// asserted directly rather than inferred from the shortcut's derivation.
    ///
    /// The near-zero diagonal entry is the rank agreement. Since gh #703 the
    /// rank test is relative to each pivot's *own* starting magnitude rather
    /// than to `max_diag`, so a diagonal matrix has no zero eigenvalues at
    /// all: `1e-20` on its own row is a genuine, tiny eigenvalue and both
    /// paths must **keep** it. What must not differ is which of them thinks
    /// so — a disagreement would build cones of different dimension for the
    /// same constraint.
    #[test]
    fn both_factor_paths_reconstruct_q_and_agree_on_rank() {
        let recon = |rows: &[Vec<(usize, f64)>]| {
            let mut q: std::collections::BTreeMap<(usize, usize), f64> = Default::default();
            for r in rows {
                for &(i, fi) in r {
                    for &(j, fj) in r {
                        *q.entry((i, j)).or_insert(0.0) += fi * fj;
                    }
                }
            }
            q.retain(|_, v| v.abs() > 1e-12);
            q
        };

        // Diagonal path, with one entry twenty orders of magnitude below the
        // largest. Deliberately *not* descending by index: the largest entry
        // sits on the highest variable, so a shortcut that emitted in index
        // order would produce the right cone with the rows in the wrong order.
        let diag: std::collections::BTreeMap<(usize, usize), f64> =
            [((3, 3), 2.0), ((8, 8), 9.0), ((9, 9), 1e-20)]
                .into_iter()
                .collect();
        let drows = socp_factor_rows(&diag);
        assert_eq!(
            drows.len(),
            3,
            "1e-20 on its own row is a small eigenvalue, not a missing one"
        );

        // The shortcut must be *bit*-identical to the general path, not merely
        // close: a 2-ulp difference in one `G` entry visibly moved `qcqp_ball`'s
        // conic trajectory (17 → 12 iterations). Run the same matrix through
        // `psd_outer_factor` and compare the raw bits.
        let support = quad_support(&diag);
        let general = psd_outer_factor(dense_symmetric_on_support(&diag, &support), support.len());
        let general_vals: Vec<f64> = general
            .iter()
            .map(|f| f.iter().copied().find(|v| *v != 0.0).expect("one nonzero"))
            .collect();
        let short_vals: Vec<f64> = drows.iter().map(|r| r[0].1).collect();
        assert_eq!(
            short_vals.iter().map(|v| v.to_bits()).collect::<Vec<_>>(),
            general_vals.iter().map(|v| v.to_bits()).collect::<Vec<_>>(),
            "diagonal shortcut must reproduce psd_outer_factor bit for bit \
             (got {short_vals:?} vs {general_vals:?})"
        );
        assert_eq!(drows[0][0].0, 8, "largest diagonal pivots first");
        assert_eq!(drows[1][0].0, 3);
        assert_eq!(drows[2][0].0, 9, "then the smallest, still emitted");
        assert!(
            (drows[2][0].1 - 1e-10).abs() < 1e-22,
            "√1e-20 = 1e-10, got {}",
            drows[2][0].1
        );
        let dq = recon(&drows);
        // Two entries, not three: `recon` drops anything under `1e-12`, and
        // `(1e-10)² = 1e-20` is under it. The row is in the factor; its
        // contribution to `Q` is genuinely below what a reconstruction can
        // see, which is the whole reason the *pivot* test cannot be absolute.
        assert_eq!(dq.len(), 2);
        assert!((dq[&(3, 3)] - 2.0).abs() < 1e-12);
        assert!((dq[&(8, 8)] - 9.0).abs() < 1e-12);

        // General path: same matrix plus a cross term, so the diagonal
        // shortcut no longer applies. Q = [[2,1],[1,9]] on {3,8} is positive
        // definite, so full rank 2.
        let mut coupled = diag.clone();
        coupled.insert((3, 8), 1.0);
        let grows = socp_factor_rows(&coupled);
        assert_eq!(grows.len(), 3, "2 from the coupled block, 1 from `1e-20`");
        let gq = recon(&grows);
        assert!((gq[&(3, 3)] - 2.0).abs() < 1e-10);
        assert!((gq[&(8, 8)] - 9.0).abs() < 1e-10);
        assert!((gq[&(3, 8)] - 1.0).abs() < 1e-10);
        assert!((gq[&(8, 3)] - 1.0).abs() < 1e-10);
        assert!(
            !gq.contains_key(&(9, 9)),
            "1e-20 is below what the reconstruction resolves"
        );
    }

    /// `psd_outer_factor` recovers a rank-1 `Q = vvᵀ` with a single factor row
    /// (minimal cone), and reconstructs `Q` exactly.
    #[test]
    fn psd_outer_factor_is_rank_revealing() {
        // Q = [[1,2],[2,4]] = v vᵀ with v = (1,2): rank 1.
        let q = vec![1.0, 2.0, 2.0, 4.0];
        let rows = psd_outer_factor(q.clone(), 2);
        assert_eq!(rows.len(), 1, "rank-1 Q must give one factor row");
        // Reconstruct Σ f fᵀ and compare to Q.
        let mut recon = vec![0.0; 4];
        for f in &rows {
            for i in 0..2 {
                for j in 0..2 {
                    recon[i * 2 + j] += f[i] * f[j];
                }
            }
        }
        for k in 0..4 {
            assert!((recon[k] - q[k]).abs() < 1e-9, "recon[{k}]={}", recon[k]);
        }
    }

    /// **The rank of `Q` is a property of `Q`, not of the units its variables
    /// are measured in.** `psd_outer_factor` decides the dimension of the cone
    /// a QCQP row becomes, so if a change of units can change that number, the
    /// solver builds a different — smaller — feasible set for the same model
    /// and reports success on the answer to a different problem.
    ///
    /// That is exactly what gh #703 hit. The rank test used to be
    /// `1e-12 · max_diag`, one absolute cut for the whole matrix, which asks
    /// how a pivot compares to the *largest* entry rather than how far its own
    /// downdate has moved it. Rescaling the columns of `qcqp_columns` by
    /// `10^{-4}…10^{4}` spread `max_diag` over nineteen orders of magnitude and
    /// took the rank of a full-rank 24×24 row from 24 to **17** — seven real
    /// directions dropped, `SolveSucceeded`, a self-reported violation of
    /// `2.66e-15` against an actual one of `4.948e+01`, and an objective 10%
    /// off its well-conditioned twin.
    ///
    /// Diagonal congruence `Q → C Q C` with `C ≻ 0` diagonal is precisely a
    /// change of units, and it preserves rank exactly (Sylvester). So the test
    /// is: factor the same `Q` under a spread of column scalings and require
    /// the row count never to move.
    #[test]
    fn rank_does_not_depend_on_the_units_the_columns_are_measured_in() {
        // A 4×4 PSD matrix of exact rank 3: `Q = Σ_{k<3} v_k v_kᵀ` over three
        // independent vectors, so one direction is genuinely absent and the
        // factorization must find that too — an invariance test that only ever
        // returned `n` would be satisfied by a rank test that never fires.
        let vs = [
            [1.0, 2.0, 0.0, -1.0],
            [0.0, 1.0, 3.0, 1.0],
            [2.0, 0.0, 1.0, 4.0],
        ];
        let n = 4;
        let mut q = vec![0.0; n * n];
        for v in &vs {
            for i in 0..n {
                for j in 0..n {
                    q[i * n + j] += v[i] * v[j];
                }
            }
        }
        assert_eq!(psd_outer_factor(q.clone(), n).len(), 3, "unscaled rank");

        // `C = diag(10^e)`. The exponents run over the same range the
        // `qcqp_columns` fixtures use, and are deliberately *not* uniform: a
        // uniform scaling is a scalar multiple, which even an absolute
        // threshold survives.
        for spread in [1i32, 2, 3, 4, 6] {
            for sign in [1i32, -1] {
                let c: Vec<f64> = (0..n)
                    .map(|i| 10f64.powi(sign * spread * (i as i32 - 1)))
                    .collect();
                let mut scaled = vec![0.0; n * n];
                for i in 0..n {
                    for j in 0..n {
                        scaled[i * n + j] = c[i] * q[i * n + j] * c[j];
                    }
                }
                let rank = psd_outer_factor(scaled, n).len();
                assert_eq!(
                    rank, 3,
                    "C Q C with C = diag(10^({sign}·{spread}·(i−1))) has the \
                     same rank as Q; got {rank}"
                );
            }
        }
    }

    /// The companion property, on the other side of the same threshold: a
    /// direction that *is* spanned must still be dropped, however the columns
    /// are scaled. Rank invariance alone would be satisfied by never cutting
    /// anything, which would hand every row a full-dimensional cone and cost
    /// the `qssp180`-class models their whole reason for taking the conic
    /// route.
    #[test]
    fn a_spanned_direction_is_dropped_at_every_column_scaling() {
        // Exactly rank 1: `Q = v vᵀ`, so three of four directions are spanned.
        let v = [1.0, 2.0, -3.0, 0.5];
        let n = 4;
        let mut q = vec![0.0; n * n];
        for i in 0..n {
            for j in 0..n {
                q[i * n + j] = v[i] * v[j];
            }
        }
        for e in [-8i32, -4, 0, 4, 8] {
            let c: Vec<f64> = (0..n).map(|i| 10f64.powi(e * (i as i32 - 1))).collect();
            let mut scaled = vec![0.0; n * n];
            for i in 0..n {
                for j in 0..n {
                    scaled[i * n + j] = c[i] * q[i * n + j] * c[j];
                }
            }
            assert_eq!(
                psd_outer_factor(scaled, n).len(),
                1,
                "rank-1 Q stays rank 1 under diag(10^({e}·(i−1)))"
            );
        }
    }

    /// A pivot the downdate has *not* spent must survive even when a spent one
    /// sorts above it. This is the case that made the fix more than a change of
    /// threshold: `√2 · √2 ≠ 2` in binary, so a factored-out column of size 2
    /// carries `4.4e-16` of roundoff on its diagonal afterwards, which is
    /// larger than a genuine `1e-20` eigenvalue sitting untouched on another
    /// column. Complete pivoting picks the roundoff first. With an absolute
    /// threshold that did not matter — both failed the same cut. With a
    /// relative one they disagree, so the loop has to *settle* the failing
    /// pivot and keep looking rather than stop at the first failure.
    #[test]
    fn a_live_pivot_below_a_spent_ones_roundoff_is_still_found() {
        let n = 2;
        // diag(2, 1e-20), the smaller entry twenty orders down.
        let rows = psd_outer_factor(vec![2.0, 0.0, 0.0, 1e-20], n);
        assert_eq!(
            rows.len(),
            2,
            "both diagonal entries are eigenvalues; got {rows:?}"
        );
        assert!(
            (rows[1][1] - 1e-10).abs() < 1e-22,
            "the surviving row is √1e-20, got {}",
            rows[1][1]
        );
    }

    /// gh #1056: the rotated cone's two leading rows are `h₀ = −b/κ + κ` and
    /// `h₁ = −b/κ − κ`, and their whole job is `h₀² − h₁² = −4b`. With the
    /// historical `κ = 1`, at `b = −1e20` both round to `1e20` and the
    /// difference is `0` — the declared cone is empty. Balanced, it is exact,
    /// and `κ` is a power of two (so `a/κ` is exact) and `1` for `|b| ≤ 1`.
    #[test]
    fn the_rotated_cone_keeps_its_constant_at_any_magnitude() {
        for b in [-0.5, -1.0, 1.0, -4.0, -1e6, -1e20, -1e100, 3e40] {
            let k = super::rotated_cone_balance(b);
            assert!(k > 0.0 && k.log2().fract() == 0.0, "b = {b:e}: κ = {k}");
            if b.abs() <= 1.0 {
                assert_eq!(k, 1.0, "b = {b:e}");
            }
            let (h0, h1) = (-b / k + k, -b / k - k);
            let got = (h0 - h1) * (h0 + h1);
            assert!(
                ((got + 4.0 * b) / (4.0 * b)).abs() < 1e-12,
                "b = {b:e}, κ = {k}: h₀² − h₁² = {got:e}, want {:e}",
                -4.0 * b
            );
        }
        // What κ = 1 did.
        assert_eq!(1.0 - -1e20, -(1.0 + -1e20));
    }

    /// gh #1041: `centre_soc` must split `a` into `Fᵀw + a_⊥` exactly, on
    /// both of its branches — the diagonal closed form and the normal
    /// equations — and leave `a_⊥` zero where `a` is in range.
    #[test]
    fn centre_soc_splits_a_into_range_and_complement() {
        let check = |f_rows: &[Vec<(usize, f64)>], a: &[(usize, f64)], n: usize| {
            let (a_perp, w) = centre_soc(f_rows, a);
            let mut back = vec![0.0; n];
            for (f, wk) in f_rows.iter().zip(&w) {
                for &(v, c) in f {
                    back[v] += c * wk;
                }
            }
            for &(v, c) in &a_perp {
                back[v] += c;
            }
            let mut want = vec![0.0; n];
            for &(v, c) in a {
                want[v] += c;
            }
            for i in 0..n {
                assert!(
                    (back[i] - want[i]).abs() <= 1e-9 * want[i].abs().max(1.0),
                    "Fᵀw + a_⊥ ≠ a at {i}: {back:?} vs {want:?}"
                );
            }
            a_perp
        };
        // Diagonal: (x0 − 1000)² + (x1 − 5)² with a linear term in x2.
        let s2 = std::f64::consts::SQRT_2;
        let a_perp = check(
            &[vec![(0, s2)], vec![(1, s2)]],
            &[(0, -2000.0), (1, -10.0), (2, 3.0)],
            3,
        );
        assert_eq!(a_perp, vec![(2, 3.0)], "in-range part must leave exactly");
        // Coupled: Q = [[8, −4], [−4, 8]] (from (x+y)² + 3(x−y)², doubled),
        // a = Q·(1000, 1000) − e₂ so the residual is the x2 term only.
        let f = psd_outer_factor(vec![8.0, -4.0, -4.0, 8.0], 2)
            .into_iter()
            .map(|r| {
                r.into_iter()
                    .enumerate()
                    .filter(|&(_, v)| v != 0.0)
                    .collect()
            })
            .collect::<Vec<Vec<(usize, f64)>>>();
        let a_perp = check(&f, &[(0, -4000.0), (1, -4000.0), (2, -1.0)], 3);
        assert_eq!(a_perp, vec![(2, -1.0)], "roundoff in range must be dropped");
    }

    /// The fallback branch of `centre_soc`: factor rows that are linearly
    /// dependent make `FFᵀ` singular, and the block must come back exactly
    /// uncentred (`a_⊥ = a`, `w = 0`). Before the pivot test was relative,
    /// this case's second pivot came out at roundoff *above* zero and the
    /// solve returned `w = (48, −2048)` from a pivot of pure noise.
    #[test]
    fn centre_soc_falls_back_to_uncentred_on_a_singular_gram() {
        let row = vec![(0, 1.0), (1, 1.0)];
        let a = [(0, -2000.0), (1, -2000.0)];
        let (a_perp, w) = centre_soc(&[row.clone(), row], &a);
        assert_eq!(a_perp, a.to_vec());
        assert_eq!(w, vec![0.0, 0.0]);
    }

    /// min (x0)^2 + (x1)^2 s.t. x0 + x1 = 2, no var bounds → (1,1), f*=2.
    #[test]
    fn extract_and_solve_equality_qp() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 2,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Binary(
                BinOp::Add,
                Box::new(pow2(0)),
                Box::new(pow2(1)),
            )),
            obj_linear: vec![],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(Expr::Const(0.0))],
            con_linear: vec![vec![(0, 1.0), (1, 1.0)]],
            x_l: vec![-2e19, -2e19],
            x_u: vec![2e19, 2e19],
            g_l: vec![2.0],
            g_u: vec![2.0],
            x0: vec![0.0, 0.0],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let (qp, con_map, obj_const) =
            extract_qp_with_map(&prob, BoundRelax::NONE).expect("extract");
        // No constant anywhere in this objective.
        assert_eq!(obj_const, 0.0);
        // P = 2I → two diagonal entries.
        assert_eq!(qp.p_lower.len(), 2);
        assert_eq!(qp.m_eq(), 1);
        assert_eq!(qp.m_ineq(), 0);

        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 1.0).abs() < 1e-6, "x0={}", sol.x[0]);
        assert!((sol.x[1] - 1.0).abs() < 1e-6, "x1={}", sol.x[1]);
        assert!((sol.obj - 2.0).abs() < 1e-6, "obj={}", sol.obj);

        // KKT for the equality: ∇f + y·∇g = 0 → 2x_i + y = 0 at x=1 → y=−2.
        let lambda = recover_duals(&prob, &con_map, &sol.y, &sol.z);
        assert_eq!(lambda.len(), 1);
        assert!(
            (lambda[0] - (-2.0)).abs() < 1e-5,
            "equality dual={}",
            lambda[0]
        );
    }

    /// Regression for the dropped-linear-term bug: the objective `(x0-3)²`
    /// lives entirely in the nonlinear tree, so its linear part (`−6·x0`)
    /// must be folded into `c`. Without it the solve minimizes `x0²`
    /// (optimum 0) instead of `(x0-3)²` (optimum 3).
    #[test]
    fn extract_keeps_linear_term_from_nonlinear_tree() {
        // (x0 - 3)^2 = x0^2 - 6 x0 + 9, all in obj_nonlinear.
        let obj = Expr::Binary(
            BinOp::Pow,
            Box::new(Expr::Binary(
                BinOp::Sub,
                Box::new(Expr::Var(0)),
                Box::new(Expr::Const(3.0)),
            )),
            Box::new(Expr::Const(2.0)),
        );
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 0,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(obj),
            obj_linear: vec![],
            obj_constant: 0.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            x_l: vec![-2e19],
            x_u: vec![2e19],
            g_l: vec![],
            g_u: vec![],
            x0: vec![0.0],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(qp.c.len(), 1);
        assert!(
            (qp.c[0] - (-6.0)).abs() < 1e-12,
            "c[0]={} — linear term from the nonlinear tree was dropped",
            qp.c[0]
        );
        // P = 2 (one diagonal entry).
        assert_eq!(qp.p_lower.len(), 1);

        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!(
            (sol.x[0] - 3.0).abs() < 1e-6,
            "x0={} (expected 3)",
            sol.x[0]
        );
    }

    /// Inequality dual sign/magnitude. min x0² s.t. x0 ≥ 1 (a one-sided
    /// inequality g_l=1, g_u=+inf). Optimum x0=1, active. The expected
    /// dual −2.0 is the value POUNCE's *NLP* path writes for this exact
    /// problem (verified by running `solver_selection=nlp` on the same
    /// `.nl`); recover_duals must match that reference convention.
    #[test]
    fn inequality_dual_recovered() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(pow2(0)),
            obj_linear: vec![],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(Expr::Const(0.0))],
            con_linear: vec![vec![(0, 1.0)]], // g(x) = x0
            x_l: vec![-2e19],
            x_u: vec![2e19],
            g_l: vec![1.0], // x0 ≥ 1
            g_u: vec![2e19],
            x0: vec![0.0],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let (qp, con_map, obj_const) =
            extract_qp_with_map(&prob, BoundRelax::NONE).expect("extract");
        // This model puts its constant in the `obj_constant` field, not the
        // nonlinear tree, so the tree constant is 0 here.
        assert_eq!(obj_const, 0.0);
        // One inequality row (the lower bound row −x0 ≤ −1); no upper.
        assert_eq!(qp.m_ineq(), 1);
        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 1.0).abs() < 1e-6, "x0={}", sol.x[0]);
        let lambda = recover_duals(&prob, &con_map, &sol.y, &sol.z);
        assert!((lambda[0] - (-2.0)).abs() < 1e-5, "ineq dual={}", lambda[0]);
    }

    /// Regression (M11): a *constraint* whose linear and constant
    /// terms are folded into the nonlinear tree (not the `con_linear`
    /// section) must still reach `A`/`G`. AMPL/Pyomo emit this shape for
    /// rows the classifier admits as degree-≤1 (cancelled quadratics,
    /// defined variables): the whole `x0 − 3` lives in `con_nonlinear`
    /// and `con_linear[0]` is empty.
    ///
    ///     min x0   s.t.   x0 − 3 ≥ 0     (body in the nonlinear tree)
    ///
    /// True optimum: x0 = 3. The QP extractor used to build `A`/`G` from
    /// `con_linear` only — dropping the folded `+x0` *and* the `−3`
    /// shift, leaving a vacuous `0 ≤ 0` row, so `min x0` came out
    /// unbounded (or otherwise wrong) on the convex path.
    #[test]
    fn constraint_linear_terms_folded_in_tree_are_recovered() {
        // con body = x0 − 3, entirely in the nonlinear tree.
        let con = Expr::Binary(
            BinOp::Sub,
            Box::new(Expr::Var(0)),
            Box::new(Expr::Const(3.0)),
        );
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(con)],
            con_linear: vec![vec![]], // the `+x0` lives in the TREE
            x_l: vec![-2e19],
            x_u: vec![2e19],
            g_l: vec![0.0], // x0 − 3 ≥ 0
            g_u: vec![2e19],
            x0: vec![0.0],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let (qp, con_map, _obj_const) =
            extract_qp_with_map(&prob, BoundRelax::NONE).expect("extract");
        // One inequality row: −x0 ≤ −3 (the lower bound, constant-shifted).
        assert_eq!(qp.m_ineq(), 1);
        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 3.0).abs() < 1e-5, "x0={}", sol.x[0]);
        // Dual is recoverable and finite (the row carries a real coef now).
        let lambda = recover_duals(&prob, &con_map, &sol.y, &sol.z);
        assert_eq!(lambda.len(), 1);
        assert!(lambda[0].is_finite(), "dual={}", lambda[0]);
    }

    /// Regression: a constant folded into the *nonlinear objective tree*
    /// (not the `obj_constant` field) must still reach the reported
    /// objective. This is the real `.nl` shape AMPL/Pyomo emit for
    /// `min (x0-3)^2` — the whole `x0^2 - 6 x0 + 9` lives in the nonlinear
    /// tree and `obj_constant == 0`. The convex path used to drop the `+9`
    /// and report an objective 9 too small (cf. HS35 in the benchmark
    /// comparison). The minimizer is x0 = 1 (upper bound binds), where the
    /// true objective is (1-3)^2 = 4.
    #[test]
    fn tree_embedded_objective_constant_is_recovered() {
        // (x0 - 3)^2 as a single nonlinear tree: Pow(Sub(x0, 3), 2).
        let obj = Expr::Binary(
            BinOp::Pow,
            Box::new(Expr::Binary(
                BinOp::Sub,
                Box::new(Expr::Var(0)),
                Box::new(Expr::Const(3.0)),
            )),
            Box::new(Expr::Const(2.0)),
        );
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 0,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(obj),
            obj_linear: vec![],
            obj_constant: 0.0, // the +9 is in the TREE, not here
            con_nonlinear: vec![],
            con_linear: vec![],
            x_l: vec![0.0],
            x_u: vec![1.0],
            g_l: vec![],
            g_u: vec![],
            x0: vec![0.0],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let (qp, _con_map, obj_const) =
            extract_qp_with_map(&prob, BoundRelax::NONE).expect("extract");
        // The degree-0 term of (x0-3)^2 is +9, recovered from the tree.
        assert!((obj_const - 9.0).abs() < 1e-12, "tree constant={obj_const}");
        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 1.0).abs() < 1e-6, "x0={}", sol.x[0]);
        // Reported objective = (½xᵀPx + cᵀx) + obj_const must equal the true
        // (1-3)^2 = 4, not the constant-dropped −5.
        let reported = sol.obj + obj_const;
        assert!((reported - 4.0).abs() < 1e-5, "reported obj={reported}");
    }

    /// Bound-constrained: min (x0-3)^2 = x0^2 - 6 x0 + 9, 0 ≤ x0 ≤ 1.
    /// Optimum x0 = 1 (upper bound binds). Here the constant 9 is carried
    /// in the `obj_constant` field (not the tree), so the extracted tree
    /// constant is 0 (asserted inside).
    #[test]
    fn extract_and_solve_bounded_qp() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 0,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(pow2(0)),
            obj_linear: vec![(0, -6.0)],
            obj_constant: 9.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            x_l: vec![0.0],
            x_u: vec![1.0],
            g_l: vec![],
            g_u: vec![],
            x0: vec![0.0],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        // The bounds are the box, not `G` rows.
        assert_eq!(qp.m_ineq(), 0);
        assert_eq!((qp.lb[0], qp.ub[0]), (0.0, 1.0));
        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 1.0).abs() < 1e-6, "x0={}", sol.x[0]);
    }

    /// LP: min −x0 − x1, 0 ≤ x ≤ 1 → (1,1).
    #[test]
    fn extract_and_solve_lp() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 2,
            m: 0,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, -1.0), (1, -1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            x_l: vec![0.0, 0.0],
            x_u: vec![1.0, 1.0],
            g_l: vec![],
            g_u: vec![],
            x0: vec![0.0, 0.0],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        assert!(qp.p_lower.is_empty(), "LP has no Hessian");
        assert_eq!(qp.m_ineq(), 0, "bounds are the box, not `G` rows");
        assert_eq!(qp.lb, vec![0.0, 0.0]);
        assert_eq!(qp.ub, vec![1.0, 1.0]);
        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 1.0).abs() < 1e-6);
        assert!((sol.x[1] - 1.0).abs() < 1e-6);
    }

    /// maximize x0 s.t. 0 ≤ x0 ≤ 5 → x0 = 5. Tests sign flip on a
    /// maximize objective.
    #[test]
    fn extract_maximize_negates() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 0,
            num_obj: 1,
            minimize: false,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            x_l: vec![0.0],
            x_u: vec![5.0],
            g_l: vec![],
            g_u: vec![],
            x0: vec![0.0],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        // minimize −x0.
        assert_eq!(qp.c[0], -1.0);
        let sol = solve_qp_ipm(&qp, &QpOptions::default(), backend);
        assert_eq!(sol.status, QpStatus::Optimal);
        assert!((sol.x[0] - 5.0).abs() < 1e-6, "x0={}", sol.x[0]);
    }

    /// **gh #401.** A real bound past the *opposite* absent-bound sentinel is
    /// an ordinary bound, and must survive into `G`.
    ///
    /// `is_finite_bound` was `|v| < 1e19`, a symmetric magnitude test. An upper
    /// bound of `-5e20` failed it and the row `x_0 <= -5e20` never entered `G`,
    /// so the QP was solved over a strictly larger box — `min x_0` subject to
    /// nothing, which the IPM answers `Optimal` at a point the model excludes.
    #[test]
    fn variable_bound_past_the_opposite_sentinel_is_kept() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 1,
            m: 0,
            num_obj: 1,
            minimize: false, // maximize x0, so the -5e20 upper bound binds
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            // No lower bound (`-1e21` is past the lower sentinel, so absent);
            // a real upper bound of `-5e20`, which is *not*.
            x_l: vec![-1e21],
            x_u: vec![-5e20],
            g_l: vec![],
            g_u: vec![],
            x0: vec![-7e20],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(
            qp.ub[0], -5e20,
            "`x0 <= -5e20` is a real bound and must reach the box; the \
             symmetric |v| < 1e19 test dropped it, leaving an \
             unbounded-above box the model does not declare"
        );
    }

    /// **gh #401.** A row with equal bounds past the sentinel used to vanish
    /// from the problem *entirely* — contributing nothing to `A` and nothing
    /// to `G`.
    ///
    /// Directionally, `g_l = g_u = -5e20` is not an equality at all: the lower
    /// bound is absent (it is past `-1e19`) and the upper bound is real, so the
    /// row is the one-sided `x0 + x1 <= -5e20`. The old code got there by a
    /// different route and lost it: `lo == hi && is_finite_bound(lo)` failed, so
    /// the row fell into the inequality branch — where `is_finite_bound(hi)` and
    /// `is_finite_bound(lo)` were false too, leaving `upper` and `lower` both
    /// `None`. Silently deleted.
    ///
    /// (Note there is no such thing as an equality row outside `±1e19` under
    /// this convention: an equality needs both bounds present, and the two
    /// presence tests only overlap inside the band.)
    #[test]
    fn a_row_with_equal_bounds_past_the_sentinel_does_not_vanish() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 2,
            m: 1,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![NlBody::Tree(Expr::Const(0.0))],
            con_linear: vec![vec![(0, 1.0), (1, 1.0)]],
            x_l: vec![-2e19, -2e19],
            x_u: vec![2e19, 2e19],
            g_l: vec![-5e20],
            g_u: vec![-5e20],
            x0: vec![0.0, 0.0],
            lambda0: vec![0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(
            qp.m_eq(),
            0,
            "the lower bound is absent, so this is no equality"
        );
        assert_eq!(
            qp.m_ineq(),
            1,
            "`x0 + x1 <= -5e20` is a real constraint and must reach G; it used \
             to disappear from the problem entirely"
        );
        assert_eq!(qp.h[0], -5e20);
    }

    /// **gh #401.** The box is built with the *directional* presence test, so
    /// a bound past the opposite sentinel survives while a genuinely absent
    /// one becomes `∓∞`. Pins the case only the directional reading admits.
    ///
    /// This used to assert instead that `recover_bound_mults` walked the same
    /// `G`-row layout the builder emitted — a real hazard when the two agreed
    /// only by construction, and one that no longer exists: bounds are the
    /// box, and their multipliers come back in `z_lb`/`z_ub` with no layout
    /// to keep in step.
    #[test]
    fn the_box_is_built_with_the_directional_bound_test() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 2,
            m: 0,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0), (1, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            // x0: upper bound past the *lower* sentinel, no lower bound.
            // x1: an ordinary two-sided box.
            x_l: vec![-2e19, 0.0],
            x_u: vec![-5e20, 1.0],
            g_l: vec![],
            g_u: vec![],
            x0: vec![-6e20, 0.5],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let qp = extract_qp(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(qp.m_ineq(), 0, "bounds are the box, not `G` rows");
        // x0: no lower bound; a real upper bound past the *lower* sentinel.
        assert_eq!(qp.lb[0], f64::NEG_INFINITY);
        assert_eq!(qp.ub[0], -5e20);
        // x1: an ordinary two-sided box, carried through unchanged.
        assert_eq!(qp.lb[1], 0.0);
        assert_eq!(qp.ub[1], 1.0);
    }

    /// The bound multipliers a solve produces are handed back per variable,
    /// not decoded from a row layout. A short `z_lb`/`z_ub` (a driver that
    /// returned early without them) reads as "no bound active" rather than
    /// panicking on the index.
    #[test]
    fn bound_multipliers_come_back_per_variable() {
        let prob = NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 2,
            m: 0,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0), (1, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![],
            con_linear: vec![],
            x_l: vec![0.0, 0.0],
            x_u: vec![1.0, 1.0],
            g_l: vec![],
            g_u: vec![],
            x0: vec![0.5, 0.5],
            lambda0: vec![],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        };
        let sol = QpSolution {
            status: pounce_convex::QpStatus::Optimal,
            x: vec![0.0, 1.0],
            y: vec![],
            z: vec![],
            z_lb: vec![7.0, 0.0],
            z_ub: vec![0.0, 9.0],
            obj: 0.0,
            iters: 0,
            iterates: Vec::new(),
        };
        let (z_lb, z_ub) = recover_bound_mults(&prob, &sol);
        assert_eq!(z_lb, vec![7.0, 0.0]);
        assert_eq!(z_ub, vec![0.0, 9.0]);

        let empty = QpSolution {
            z_lb: Vec::new(),
            z_ub: Vec::new(),
            ..sol
        };
        let (z_lb, z_ub) = recover_bound_mults(&prob, &empty);
        assert_eq!(z_lb, vec![0.0, 0.0]);
        assert_eq!(z_ub, vec![0.0, 0.0]);
    }

    /// gh #744/#745: `bound_relax_factor` reaches the extracted model.
    ///
    /// One inequality row (`x0 + x1 >= 2`), one two-sided range row, one
    /// equality row, a bounded variable, a fixed variable, and a free
    /// variable — so every case the widening treats differently is present.
    fn relax_fixture() -> NlProblem {
        NlProblem {
            src: None,
            cse_bodies: Vec::new(),
            complementarity: Vec::new(),
            n: 3,
            m: 3,
            num_obj: 1,
            minimize: true,
            obj_nonlinear: NlBody::Tree(Expr::Const(0.0)),
            obj_linear: vec![(0, 1.0)],
            obj_constant: 0.0,
            con_nonlinear: vec![
                NlBody::Tree(Expr::Const(0.0)),
                NlBody::Tree(Expr::Const(0.0)),
                NlBody::Tree(Expr::Const(0.0)),
            ],
            con_linear: vec![
                vec![(0, 1.0), (1, 1.0)],
                vec![(1, 1.0), (2, 1.0)],
                vec![(0, 1.0), (2, 1.0)],
            ],
            // x0 bounded above and below, x1 fixed, x2 free.
            x_l: vec![-4.0, 5.0, -2e19],
            x_u: vec![8.0, 5.0, 2e19],
            // row 0: >= 2 (lower only); row 1: -3 <= . <= 6 (range);
            // row 2: == 7 (equality).
            g_l: vec![2.0, -3.0, 7.0],
            g_u: vec![2e19, 6.0, 7.0],
            x0: vec![0.0, 0.0, 0.0],
            lambda0: vec![0.0, 0.0, 0.0],
            suffixes: Default::default(),
            imported_funcs: Vec::new(),
            ampl_options: Vec::new(),
            nl_counts: None,
            n_discrete: None,
            var_names: Vec::new(),
            con_names: Vec::new(),
        }
    }

    #[test]
    fn bound_relax_none_leaves_the_declared_model_alone() {
        let prob = relax_fixture();
        let (qp, _, _) = extract_qp_with_map(&prob, BoundRelax::NONE).expect("extract");
        assert_eq!(qp.lb, vec![-4.0, 5.0, f64::NEG_INFINITY]);
        assert_eq!(qp.ub, vec![8.0, 5.0, f64::INFINITY]);
        assert_eq!(qp.b, vec![7.0]);
        // Rows, in emission order: row0's `>= 2` as `-x0-x1 <= -2`;
        // row1's `<= 6` then its `>= -3` as `<= 3`.
        assert_eq!(qp.h, vec![-2.0, 6.0, 3.0]);
    }

    #[test]
    fn bound_relax_widens_inequality_rows_and_the_free_box_only() {
        let prob = relax_fixture();
        let relax = BoundRelax {
            factor: 1e-8,
            cap: 1e-4,
        };
        let (qp, _, _) = extract_qp_with_map(&prob, relax).expect("extract");

        // Variable box: upstream's absolute formula `min(f*max(|b|,1), cap)`.
        // x0's bounds widen outward; x1 is *fixed* and must not move (upstream
        // removes fixed variables before `relax_bounds` runs); x2 is free.
        assert!((qp.lb[0] - (-4.0 - 4e-8)).abs() < 1e-18);
        assert!((qp.ub[0] - (8.0 + 8e-8)).abs() < 1e-18);
        assert_eq!(qp.lb[1], 5.0);
        assert_eq!(qp.ub[1], 5.0);
        assert_eq!(qp.lb[2], f64::NEG_INFINITY);
        assert_eq!(qp.ub[2], f64::INFINITY);

        // Equality rows are never relaxed — upstream keeps them in `c(x) = 0`,
        // which `relax_bounds` does not touch.
        assert_eq!(qp.b, vec![7.0]);

        // Inequality rows use the scale-relative width `min(f, cap)*|b|`.
        // `x0+x1 >= 2` → `-x0-x1 <= -(2 - 2e-8)`.
        assert!((qp.h[0] - -(2.0 - 2e-8)).abs() < 1e-18);
        // `. <= 6` → `<= 6 + 6e-8`; `. >= -3` → `<= 3 + 3e-8`.
        assert!((qp.h[1] - (6.0 + 6e-8)).abs() < 1e-18);
        assert!((qp.h[2] - (3.0 + 3e-8)).abs() < 1e-18);
    }

    #[test]
    fn bound_relax_caps_the_widening_and_floors_a_zero_row_bound() {
        let mut prob = relax_fixture();
        // A huge row bound: the relative width `min(f, cap)*|b|` would be
        // enormous without the `min` against `cap` in the *factor*.
        prob.g_l[0] = 0.0; // declared-zero bound: no scale, absolute width.
        let relax = BoundRelax {
            factor: 1e-2,
            cap: 1e-4,
        };
        let (qp, _, _) = extract_qp_with_map(&prob, relax).expect("extract");
        // Zero bound → width is `min(1e-2, 1e-4) * 1 = 1e-4`.
        assert!((qp.h[0] - 1e-4).abs() < 1e-18, "{}", qp.h[0]);
        // Variable box is capped by `cap` outright: `1e-2*max(4,1) = 4e-2`,
        // capped to `1e-4`.
        assert!((qp.lb[0] - (-4.0 - 1e-4)).abs() < 1e-18);
    }

    /// An empty declared set must survive extraction empty. Relaxation runs
    /// *after* upstream's consistency check, and the emptiness screens on the
    /// convex side read the extracted `lb`/`ub` and row pairs — so widening a
    /// crossing narrower than the relaxation would silently make an
    /// inconsistent model solvable (gh #491, gh #744).
    #[test]
    fn bound_relax_does_not_close_a_crossed_box_or_a_crossed_row() {
        let mut prob = relax_fixture();
        // x0's box crossed by 1e-8, narrower than the 2*4e-8 it would widen by.
        prob.x_l[0] = 0.0;
        prob.x_u[0] = -1e-8;
        // Row 1 crossed by 1e-8 too: `1e-8 <= x1 + x2 <= 0`.
        prob.g_l[1] = 1e-8;
        prob.g_u[1] = 0.0;
        let relax = BoundRelax {
            factor: 1e-8,
            cap: 1e-4,
        };
        let (qp, _, _) = extract_qp_with_map(&prob, relax).expect("extract");
        assert_eq!(qp.lb[0], 0.0);
        assert_eq!(qp.ub[0], -1e-8);
        // Row 1's pair: `<= 0` and `>= 1e-8` (as `<= -1e-8`), both verbatim.
        assert_eq!(qp.h[1], 0.0);
        assert_eq!(qp.h[2], -1e-8);
        // The uncrossed row 0 is still widened.
        assert!((qp.h[0] - -(2.0 - 2e-8)).abs() < 1e-18);
    }
}