pawan/healing/

mod.rs

//! Self-healing module for Pawan
//!
//! This module provides automated fixing capabilities for:
//! - Compilation errors (`rustc` errors)
//! - Clippy warnings
//! - Test failures
//! - Missing documentation

use crate::config::HealingConfig;
use crate::{PawanError, Result};
use serde::{Deserialize, Serialize};
use std::path::{Path, PathBuf};
use std::process::Stdio;
use tokio::process::Command;

/// Shared cargo command runner with concurrent stdout/stderr reads and 5-minute timeout.
async fn run_cargo_command(workspace_root: &Path, args: &[&str]) -> Result<String> {
    let child = Command::new("cargo")
        .args(args)
        .current_dir(workspace_root)
        .stdout(Stdio::piped())
        .stderr(Stdio::piped())
        .stdin(Stdio::null())
        .spawn()
        .map_err(PawanError::Io)?;

    let output = tokio::time::timeout(
        std::time::Duration::from_secs(300),
        child.wait_with_output(),
    )
    .await
    .map_err(|_| PawanError::Timeout("cargo command timed out after 5 minutes".into()))?
    .map_err(PawanError::Io)?;

    let stdout = String::from_utf8_lossy(&output.stdout);
    let stderr = String::from_utf8_lossy(&output.stderr);
    Ok(format!("{}\n{}", stdout, stderr))
}

/// A compilation diagnostic (error or warning)
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Diagnostic {
    /// The type of diagnostic
    pub kind: DiagnosticKind,
    /// The diagnostic message
    pub message: String,
    /// File path where the issue is
    pub file: Option<PathBuf>,
    /// Line number (1-indexed)
    pub line: Option<usize>,
    /// Column number (1-indexed)  
    pub column: Option<usize>,
    /// The error/warning code (e.g., E0425)
    pub code: Option<String>,
    /// Suggested fix from the compiler
    pub suggestion: Option<String>,
    /// Full raw output for context
    pub raw: String,
}

/// Type of diagnostic
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
pub enum DiagnosticKind {
    Error,
    Warning,
    Note,
    Help,
}

impl Diagnostic {
    /// Return a stable 64-bit fingerprint for this diagnostic.
    ///
    /// Two diagnostics with the same fingerprint represent the same
    /// underlying problem.  Used by the anti-thrash guard in
    /// `heal_with_retries` to detect when the LLM is not making
    /// progress.
    ///
    /// The fingerprint covers `kind`, `code`, and the first 120 chars
    /// of `message` — enough to distinguish issues without being
    /// sensitive to trailing whitespace or minor formatting differences.
    pub fn fingerprint(&self) -> u64 {
        use std::collections::hash_map::DefaultHasher;
        use std::hash::{Hash, Hasher};
        let mut hasher = DefaultHasher::new();
        (self.kind as u8).hash(&mut hasher);
        self.code.as_deref().unwrap_or("").hash(&mut hasher);
        let msg_prefix: String = self.message.chars().take(120).collect();
        msg_prefix.hash(&mut hasher);
        hasher.finish()
    }
}

/// Result from a healing operation containing remaining issues and a summary.
#[derive(Debug)]
pub struct HealingResult {
    /// Remaining unfixed issues
    pub remaining: Vec<Diagnostic>,
    /// Description of what was done
    pub summary: String,
}

/// Compiler error fixer — parses cargo check output (JSON + text fallback) into Diagnostics.
pub struct CompilerFixer {
    workspace_root: PathBuf,
}

impl CompilerFixer {
    /// Create a new CompilerFixer
    pub fn new(workspace_root: PathBuf) -> Self {
        Self { workspace_root }
    }

    /// Parse cargo check output into diagnostics
    ///
    /// This method supports both JSON output (from `cargo check --message-format=json`)
    /// and text output formats.
    ///
    /// # Arguments
    /// * `output` - The output from cargo check
    ///
    /// # Returns
    /// A vector of Diagnostic objects representing compilation errors and warnings
    pub fn parse_diagnostics(&self, output: &str) -> Vec<Diagnostic> {
        let mut diagnostics = Vec::new();

        // Parse the JSON output from cargo check --message-format=json
        for line in output.lines() {
            if let Ok(json) = serde_json::from_str::<serde_json::Value>(line) {
                if let Some(msg) = json.get("message") {
                    let diagnostic = self.parse_diagnostic_message(msg, line);
                    if let Some(d) = diagnostic {
                        diagnostics.push(d);
                    }
                }
            }
        }

        // If no JSON output, try parsing text format
        if diagnostics.is_empty() {
            diagnostics = self.parse_text_diagnostics(output);
        }

        diagnostics
    }

    /// Parse a JSON diagnostic message
    fn parse_diagnostic_message(&self, msg: &serde_json::Value, raw: &str) -> Option<Diagnostic> {
        let level = msg.get("level")?.as_str()?;
        let message = msg.get("message")?.as_str()?.to_string();

        let kind = match level {
            "error" => DiagnosticKind::Error,
            "warning" => DiagnosticKind::Warning,
            "note" => DiagnosticKind::Note,
            "help" => DiagnosticKind::Help,
            _ => return None,
        };

        // Skip ICE messages and internal errors
        if message.contains("internal compiler error") {
            return None;
        }

        // Extract code
        let code = msg
            .get("code")
            .and_then(|c| c.get("code"))
            .and_then(|c| c.as_str())
            .map(|s| s.to_string());

        // Extract primary span
        let spans = msg.get("spans")?.as_array()?;
        let primary_span = spans.iter().find(|s| {
            s.get("is_primary")
                .and_then(|v| v.as_bool())
                .unwrap_or(false)
        });

        let (file, line, column) = if let Some(span) = primary_span {
            let file = span
                .get("file_name")
                .and_then(|v| v.as_str())
                .map(PathBuf::from);
            let line = span
                .get("line_start")
                .and_then(|v| v.as_u64())
                .map(|v| v as usize);
            let column = span
                .get("column_start")
                .and_then(|v| v.as_u64())
                .map(|v| v as usize);
            (file, line, column)
        } else {
            (None, None, None)
        };

        // Extract suggestion
        let suggestion = msg
            .get("children")
            .and_then(|c| c.as_array())
            .and_then(|children| {
                children.iter().find_map(|child| {
                    let level = child.get("level")?.as_str()?;
                    if level == "help" {
                        let help_msg = child.get("message")?.as_str()?;
                        // Look for suggested replacement
                        if let Some(spans) = child.get("spans").and_then(|s| s.as_array()) {
                            for span in spans {
                                if let Some(replacement) =
                                    span.get("suggested_replacement").and_then(|v| v.as_str())
                                {
                                    return Some(format!("{}: {}", help_msg, replacement));
                                }
                            }
                        }
                        return Some(help_msg.to_string());
                    }
                    None
                })
            });

        Some(Diagnostic {
            kind,
            message,
            file,
            line,
            column,
            code,
            suggestion,
            raw: raw.to_string(),
        })
    }

    /// Parse text format diagnostics (fallback)
    fn parse_text_diagnostics(&self, output: &str) -> Vec<Diagnostic> {
        let mut diagnostics = Vec::new();
        let mut current_diagnostic: Option<Diagnostic> = None;

        for line in output.lines() {
            // Match pattern: error[E0425]: cannot find value `x` in this scope
            if line.starts_with("error") || line.starts_with("warning") {
                // Save previous diagnostic
                if let Some(d) = current_diagnostic.take() {
                    diagnostics.push(d);
                }

                let kind = if line.starts_with("error") {
                    DiagnosticKind::Error
                } else {
                    DiagnosticKind::Warning
                };

                // Extract code like E0425
                let code = line
                    .find('[')
                    .and_then(|start| line.find(']').map(|end| line[start + 1..end].to_string()));

                // Extract message
                let message = if let Some(colon_pos) = line.find("]: ") {
                    line[colon_pos + 3..].to_string()
                } else if let Some(colon_pos) = line.find(": ") {
                    line[colon_pos + 2..].to_string()
                } else {
                    line.to_string()
                };

                current_diagnostic = Some(Diagnostic {
                    kind,
                    message,
                    file: None,
                    line: None,
                    column: None,
                    code,
                    suggestion: None,
                    raw: line.to_string(),
                });
            }
            // Match pattern: --> src/main.rs:10:5
            else if line.trim().starts_with("-->") {
                if let Some(ref mut d) = current_diagnostic {
                    let path_part = line.trim().trim_start_matches("-->").trim();
                    // Parse file:line:column (column may be absent)
                    let parts: Vec<&str> = path_part.rsplitn(3, ':').collect();
                    match parts.len() {
                        3 => {
                            // file:line:column
                            d.column = parts[0].parse().ok();
                            d.line = parts[1].parse().ok();
                            d.file = Some(PathBuf::from(parts[2]));
                        }
                        2 => {
                            // file:line (no column)
                            d.line = parts[0].parse().ok();
                            d.file = Some(PathBuf::from(parts[1]));
                        }
                        _ => {}
                    }
                }
            }
            // Match help suggestions
            else if line.trim().starts_with("help:") {
                if let Some(ref mut d) = current_diagnostic {
                    let suggestion = line.trim().trim_start_matches("help:").trim();
                    d.suggestion = Some(suggestion.to_string());
                }
            }
        }

        // Don't forget the last one
        if let Some(d) = current_diagnostic {
            diagnostics.push(d);
        }

        diagnostics
    }

    /// Run cargo check and get diagnostics
    pub async fn check(&self) -> Result<Vec<Diagnostic>> {
        let output =
            run_cargo_command(&self.workspace_root, &["check", "--message-format=json"]).await?;
        Ok(self.parse_diagnostics(&output))
    }
}

/// Clippy warning fixer — runs clippy and filters to warnings only.
pub struct ClippyFixer {
    workspace_root: PathBuf,
}

impl ClippyFixer {
    pub fn new(workspace_root: PathBuf) -> Self {
        Self { workspace_root }
    }

    /// Run clippy and get warnings
    pub async fn check(&self) -> Result<Vec<Diagnostic>> {
        let output = run_cargo_command(
            &self.workspace_root,
            &["clippy", "--message-format=json", "--", "-W", "clippy::all"],
        )
        .await?;
        let fixer = CompilerFixer::new(self.workspace_root.clone());
        let mut diagnostics = fixer.parse_diagnostics(&output);
        diagnostics.retain(|d| d.kind == DiagnosticKind::Warning);
        Ok(diagnostics)
    }
}

/// Security advisory fixer — runs `cargo audit --json` and parses each
/// advisory into a `Diagnostic` so the heal loop can treat security
/// findings the same way it treats compile errors and clippy warnings.
///
/// This is part of the "compile-as-auditor" amplification (#38): we widen
/// the heal loop's input from `cargo check + clippy + test` to also include
/// dependency vulnerabilities, treating the toolchain as a unified code
/// auditor rather than just a build pipeline.
///
/// `cargo audit` is a separate binary and not always installed. If it's
/// missing or fails to run, this fixer returns an empty Vec rather than
/// erroring — security checks are advisory, not blocking.
pub struct AuditFixer {
    workspace_root: PathBuf,
}

impl AuditFixer {
    /// Create a new AuditFixer
    pub fn new(workspace_root: PathBuf) -> Self {
        Self { workspace_root }
    }

    /// Run `cargo audit --json` and convert each vulnerability into a Diagnostic.
    pub async fn check(&self) -> Result<Vec<Diagnostic>> {
        let child = Command::new("cargo")
            .args(["audit", "--json"])
            .current_dir(&self.workspace_root)
            .stdout(Stdio::piped())
            .stderr(Stdio::piped())
            .stdin(Stdio::null())
            .spawn();

        // If cargo audit isn't installed, return empty rather than error.
        let child = match child {
            Ok(c) => c,
            Err(_) => return Ok(Vec::new()),
        };

        let output = match tokio::time::timeout(
            std::time::Duration::from_secs(120),
            child.wait_with_output(),
        )
        .await
        {
            Ok(Ok(o)) => o,
            _ => return Ok(Vec::new()),
        };

        // cargo audit prints JSON to stdout (vulns + warnings sections);
        // exit code is non-zero when vulnerabilities are present, but stdout
        // still contains the JSON we want to parse.
        let stdout = String::from_utf8_lossy(&output.stdout);
        Ok(Self::parse_audit_json(&stdout))
    }

    /// Parse `cargo audit --json` output into Diagnostic entries.
    /// Pure function — extracted so it can be unit-tested without invoking
    /// the binary.
    pub fn parse_audit_json(json_text: &str) -> Vec<Diagnostic> {
        let mut diagnostics = Vec::new();

        let parsed: serde_json::Value = match serde_json::from_str(json_text) {
            Ok(v) => v,
            Err(_) => return diagnostics,
        };

        // Hard vulnerabilities (CVEs) — error level
        if let Some(vulns) = parsed
            .get("vulnerabilities")
            .and_then(|v| v.get("list"))
            .and_then(|v| v.as_array())
        {
            for vuln in vulns {
                let advisory = vuln.get("advisory");
                let id = advisory
                    .and_then(|a| a.get("id"))
                    .and_then(|v| v.as_str())
                    .unwrap_or("unknown");
                let title = advisory
                    .and_then(|a| a.get("title"))
                    .and_then(|v| v.as_str())
                    .unwrap_or("");
                let crate_name = vuln
                    .get("package")
                    .and_then(|p| p.get("name"))
                    .and_then(|v| v.as_str())
                    .unwrap_or("unknown");
                let crate_version = vuln
                    .get("package")
                    .and_then(|p| p.get("version"))
                    .and_then(|v| v.as_str())
                    .unwrap_or("");

                diagnostics.push(Diagnostic {
                    kind: DiagnosticKind::Error,
                    message: format!("[security] {crate_name} {crate_version}: {title}"),
                    file: None,
                    line: None,
                    column: None,
                    code: Some(id.to_string()),
                    suggestion: None,
                    raw: vuln.to_string(),
                });
            }
        }

        // Soft warnings (unmaintained, unsound, yanked) — warning level
        if let Some(warnings) = parsed.get("warnings").and_then(|v| v.as_object()) {
            for (kind_name, list) in warnings {
                if let Some(arr) = list.as_array() {
                    for entry in arr {
                        let advisory = entry.get("advisory");
                        let id = advisory
                            .and_then(|a| a.get("id"))
                            .and_then(|v| v.as_str())
                            .unwrap_or("unknown");
                        let title = advisory
                            .and_then(|a| a.get("title"))
                            .and_then(|v| v.as_str())
                            .unwrap_or("");
                        let crate_name = entry
                            .get("package")
                            .and_then(|p| p.get("name"))
                            .and_then(|v| v.as_str())
                            .unwrap_or("unknown");

                        diagnostics.push(Diagnostic {
                            kind: DiagnosticKind::Warning,
                            message: format!("[{kind_name}] {crate_name}: {title}"),
                            file: None,
                            line: None,
                            column: None,
                            code: Some(id.to_string()),
                            suggestion: None,
                            raw: entry.to_string(),
                        });
                    }
                }
            }
        }

        diagnostics
    }
}

/// Test failure fixer — parses cargo test output to identify and locate failed tests.
pub struct TestFixer {
    workspace_root: PathBuf,
}

/// A failed test with name, module, failure output, and optional source location.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FailedTest {
    /// Test name (full path)
    pub name: String,
    /// Test module path
    pub module: String,
    /// Failure message/output
    pub failure: String,
    /// Location of the test
    pub file: Option<PathBuf>,
    /// Line number
    pub line: Option<usize>,
}

impl TestFixer {
    /// Create a new TestFixer
    pub fn new(workspace_root: PathBuf) -> Self {
        Self { workspace_root }
    }

    /// Run tests and get failures
    pub async fn check(&self) -> Result<Vec<FailedTest>> {
        let output = run_cargo_command(
            &self.workspace_root,
            &["test", "--no-fail-fast", "--", "--nocapture"],
        )
        .await?;
        Ok(self.parse_test_output(&output))
    }

    /// Parse test output for failures
    fn parse_test_output(&self, output: &str) -> Vec<FailedTest> {
        let mut failures = Vec::new();
        let mut in_failures_section = false;
        let mut current_test: Option<String> = None;
        let mut current_output = String::new();

        for line in output.lines() {
            // Detect failures section
            if line.contains("failures:") && !line.contains("test result:") {
                in_failures_section = true;
                continue;
            }

            // End of failures section
            if in_failures_section && line.starts_with("test result:") {
                // Save last failure
                if let Some(test_name) = current_test.take() {
                    failures.push(FailedTest {
                        name: test_name.clone(),
                        module: self.extract_module(&test_name),
                        failure: current_output.trim().to_string(),
                        file: None,
                        line: None,
                    });
                }
                break;
            }

            // Detect individual test failure
            if line.starts_with("---- ") && line.ends_with(" stdout ----") {
                // Save previous failure
                if let Some(test_name) = current_test.take() {
                    failures.push(FailedTest {
                        name: test_name.clone(),
                        module: self.extract_module(&test_name),
                        failure: current_output.trim().to_string(),
                        file: None,
                        line: None,
                    });
                }

                // Start new failure
                let test_name = line
                    .trim_start_matches("---- ")
                    .trim_end_matches(" stdout ----")
                    .to_string();
                current_test = Some(test_name);
                current_output.clear();
            } else if current_test.is_some() {
                current_output.push_str(line);
                current_output.push('\n');
            }
        }

        // Also look for simple FAILED lines (but skip "test result:" summary lines)
        for line in output.lines() {
            if line.contains("FAILED")
                && line.starts_with("test ")
                && !line.starts_with("test result:")
            {
                let parts: Vec<&str> = line.split_whitespace().collect();
                if parts.len() >= 2 {
                    let test_name = parts[1].trim_end_matches(" ...");

                    // Check if we already have this failure
                    if !failures.iter().any(|f| f.name == test_name) {
                        failures.push(FailedTest {
                            name: test_name.to_string(),
                            module: self.extract_module(test_name),
                            failure: line.to_string(),
                            file: None,
                            line: None,
                        });
                    }
                }
            }
        }

        failures
    }

    /// Extract module path from test name
    fn extract_module(&self, test_name: &str) -> String {
        if let Some(pos) = test_name.rfind("::") {
            test_name[..pos].to_string()
        } else {
            String::new()
        }
    }
}

/// Healer — coordinates CompilerFixer, ClippyFixer, and TestFixer for self-healing.
pub struct Healer {
    #[allow(dead_code)]
    workspace_root: PathBuf,
    config: HealingConfig,
    compiler_fixer: CompilerFixer,
    clippy_fixer: ClippyFixer,
    test_fixer: TestFixer,
    audit_fixer: AuditFixer,
}

impl Healer {
    /// Create a new Healer
    pub fn new(workspace_root: PathBuf, config: HealingConfig) -> Self {
        Self {
            compiler_fixer: CompilerFixer::new(workspace_root.clone()),
            clippy_fixer: ClippyFixer::new(workspace_root.clone()),
            test_fixer: TestFixer::new(workspace_root.clone()),
            audit_fixer: AuditFixer::new(workspace_root.clone()),
            workspace_root,
            config,
        }
    }

    /// Get all diagnostics (errors and warnings) from the workspace
    ///
    /// This method runs cargo check, clippy, and (if `fix_security` is on)
    /// `cargo audit` to collect compilation errors, warnings, and security
    /// advisories — the "compile-as-auditor" amplification (#38) treats the
    /// toolchain as a unified code reviewer rather than just a build pipeline.
    ///
    /// # Returns
    /// A vector of Diagnostic objects, or an error if the checks fail to run
    pub async fn get_diagnostics(&self) -> Result<Vec<Diagnostic>> {
        let mut all = Vec::new();

        if self.config.fix_errors {
            all.extend(self.compiler_fixer.check().await?);
        }

        if self.config.fix_warnings {
            all.extend(self.clippy_fixer.check().await?);
        }

        if self.config.fix_security {
            all.extend(self.audit_fixer.check().await?);
        }

        Ok(all)
    }

    /// Get all failed tests from the workspace
    ///
    /// This method runs cargo test and collects information about failed tests.
    ///
    /// # Returns
    /// A vector of FailedTest objects, or an error if the tests fail to run
    pub async fn get_failed_tests(&self) -> Result<Vec<FailedTest>> {
        if self.config.fix_tests {
            self.test_fixer.check().await
        } else {
            Ok(Vec::new())
        }
    }

    /// Count total issues concurrently: (errors, warnings, failed_tests).
    pub async fn count_issues(&self) -> Result<(usize, usize, usize)> {
        let (diagnostics, tests) = tokio::join!(self.get_diagnostics(), self.get_failed_tests(),);
        let diagnostics = diagnostics?;
        let tests = tests?;

        let errors = diagnostics
            .iter()
            .filter(|d| d.kind == DiagnosticKind::Error)
            .count();
        let warnings = diagnostics
            .iter()
            .filter(|d| d.kind == DiagnosticKind::Warning)
            .count();
        let failed_tests = tests.len();

        Ok((errors, warnings, failed_tests))
    }

    /// Format diagnostics for LLM prompt
    ///
    /// This method formats compilation diagnostics into a structured format
    /// suitable for inclusion in an LLM prompt.
    ///
    /// # Arguments
    /// * `diagnostics` - A slice of Diagnostic objects to format
    ///
    /// # Returns
    /// A formatted string ready for use in an LLM prompt
    pub fn format_diagnostics_for_prompt(&self, diagnostics: &[Diagnostic]) -> String {
        let mut output = String::new();

        for (i, d) in diagnostics.iter().enumerate() {
            output.push_str(&format!("\n### Issue {}\n", i + 1));
            output.push_str(&format!("Type: {:?}\n", d.kind));

            if let Some(ref code) = d.code {
                output.push_str(&format!("Code: {}\n", code));
            }

            output.push_str(&format!("Message: {}\n", d.message));

            if let Some(ref file) = d.file {
                output.push_str(&format!(
                    "Location: {}:{}:{}\n",
                    file.display(),
                    d.line.unwrap_or(0),
                    d.column.unwrap_or(0)
                ));
            }

            if let Some(ref suggestion) = d.suggestion {
                output.push_str(&format!("Suggestion: {}\n", suggestion));
            }
        }

        output
    }

    /// Format failed tests for LLM prompt
    pub fn format_tests_for_prompt(&self, tests: &[FailedTest]) -> String {
        let mut output = String::new();

        for (i, test) in tests.iter().enumerate() {
            output.push_str(&format!("\n### Failed Test {}\n", i + 1));
            output.push_str(&format!("Name: {}\n", test.name));
            output.push_str(&format!("Module: {}\n", test.module));
            output.push_str(&format!("Failure:\n```\n{}\n```\n", test.failure));
        }

        output
    }
}

/// Run a user-supplied shell command (stage-2 verify gate) from `workspace_root`.
///
/// Returns `Ok(None)` if the command exits 0 (passed).
/// Returns `Ok(Some(diagnostic))` if it exits non-zero (failed) — the
/// diagnostic message contains the captured stdout+stderr so the heal loop
/// can pass it back to the LLM as context.
/// Returns `Err` only if the command itself cannot be spawned.
pub async fn run_verify_cmd(workspace_root: &Path, cmd: &str) -> Result<Option<Diagnostic>> {
    let output = Command::new("sh")
        .arg("-c")
        .arg(cmd)
        .current_dir(workspace_root)
        .stdout(Stdio::piped())
        .stderr(Stdio::piped())
        .output()
        .await
        .map_err(PawanError::Io)?;

    if output.status.success() {
        return Ok(None);
    }

    let stdout = String::from_utf8_lossy(&output.stdout).to_string();
    let stderr = String::from_utf8_lossy(&output.stderr).to_string();
    let combined = match (stdout.trim().is_empty(), stderr.trim().is_empty()) {
        (false, false) => format!("{stdout}\n{stderr}"),
        (true, _) => stderr,
        (_, true) => stdout,
    };

    Ok(Some(Diagnostic {
        kind: DiagnosticKind::Error,
        message: format!("verify_cmd `{cmd}` exited with {}", output.status),
        file: None,
        line: None,
        column: None,
        code: None,
        suggestion: None,
        raw: combined,
    }))
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_parse_text_diagnostic() {
        let output = r#"error[E0425]: cannot find value `x` in this scope
   --> src/main.rs:10:5
    |
10  |     x
    |     ^ not found in this scope
"#;

        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);

        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].kind, DiagnosticKind::Error);
        assert_eq!(diagnostics[0].code, Some("E0425".to_string()));
        assert!(diagnostics[0].message.contains("cannot find value"));
    }

    #[test]
    fn test_extract_module() {
        let fixer = TestFixer::new(PathBuf::from("."));

        assert_eq!(
            fixer.extract_module("crate::module::tests::test_foo"),
            "crate::module::tests"
        );
        assert_eq!(fixer.extract_module("test_foo"), "");
    }

    #[test]
    fn test_parse_text_diagnostic_with_location() {
        let output = "error[E0308]: mismatched types\n   --> src/lib.rs:42:10\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].file, Some(PathBuf::from("src/lib.rs")));
        assert_eq!(diagnostics[0].line, Some(42));
        assert_eq!(diagnostics[0].column, Some(10));
    }

    #[test]
    fn test_parse_text_diagnostic_file_line_only() {
        // Some diagnostics omit the column
        let output = "warning: unused variable\n   --> src/main.rs:5\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].file, Some(PathBuf::from("src/main.rs")));
        assert_eq!(diagnostics[0].line, Some(5));
        assert_eq!(diagnostics[0].column, None);
    }

    #[test]
    fn test_parse_text_diagnostic_warning() {
        let output = "warning: unused variable `x`\n   --> src/lib.rs:3:5\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].kind, DiagnosticKind::Warning);
        assert!(diagnostics[0].message.contains("unused variable"));
    }

    #[test]
    fn test_parse_text_diagnostic_with_help() {
        let output = "error[E0425]: cannot find value `x`\n   --> src/main.rs:10:5\nhelp: consider importing this\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(
            diagnostics[0].suggestion,
            Some("consider importing this".to_string())
        );
    }

    #[test]
    fn test_parse_text_multiple_diagnostics() {
        let output = "error[E0425]: first error\n   --> a.rs:1:1\nerror[E0308]: second error\n   --> b.rs:2:2\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 2);
        assert_eq!(diagnostics[0].code, Some("E0425".to_string()));
        assert_eq!(diagnostics[1].code, Some("E0308".to_string()));
        assert_eq!(diagnostics[0].file, Some(PathBuf::from("a.rs")));
        assert_eq!(diagnostics[1].file, Some(PathBuf::from("b.rs")));
    }

    #[test]
    fn test_parse_text_empty_output() {
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics("");
        assert!(diagnostics.is_empty());
    }

    #[test]
    fn test_parse_json_diagnostic() {
        let json_line = r#"{"reason":"compiler-message","message":{"level":"error","message":"unused","code":{"code":"E0001"},"spans":[{"file_name":"src/lib.rs","line_start":5,"column_start":3,"is_primary":true}],"children":[]}}"#;
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_diagnostics(json_line);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].kind, DiagnosticKind::Error);
        assert_eq!(diagnostics[0].file, Some(PathBuf::from("src/lib.rs")));
        assert_eq!(diagnostics[0].line, Some(5));
        assert_eq!(diagnostics[0].column, Some(3));
    }

    #[test]
    fn test_parse_json_skips_ice() {
        let json_line = r#"{"reason":"compiler-message","message":{"level":"error","message":"internal compiler error: something broke","spans":[],"children":[]}}"#;
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_diagnostics(json_line);
        assert!(diagnostics.is_empty());
    }

    #[test]
    fn test_parse_test_output_failures() {
        let output = "---- tests::test_add stdout ----\nthread panicked at 'assertion failed'\n\nfailures:\n    tests::test_add\n\ntest result: FAILED. 1 passed; 1 failed;\n";
        let fixer = TestFixer::new(PathBuf::from("."));
        let failures = fixer.parse_test_output(output);
        assert_eq!(failures.len(), 1);
        assert_eq!(failures[0].name, "tests::test_add");
        assert_eq!(failures[0].module, "tests");
        assert!(failures[0].failure.contains("assertion failed"));
    }

    #[test]
    fn test_parse_test_output_no_failures() {
        let output = "running 5 tests\ntest result: ok. 5 passed; 0 failed;\n";
        let fixer = TestFixer::new(PathBuf::from("."));
        let failures = fixer.parse_test_output(output);
        assert!(failures.is_empty());
    }

    #[test]
    fn test_parse_test_output_simple_failed_line() {
        // Use only the "test X ... FAILED" line without "test result: FAILED"
        let output = "test my_module::test_thing ... FAILED\n";
        let fixer = TestFixer::new(PathBuf::from("."));
        let failures = fixer.parse_test_output(output);
        assert_eq!(failures.len(), 1);
        assert_eq!(failures[0].name, "my_module::test_thing");
        assert_eq!(failures[0].module, "my_module");
    }

    #[test]
    fn test_format_diagnostics_for_prompt() {
        let healer = Healer::new(PathBuf::from("."), HealingConfig::default());
        let diagnostics = vec![Diagnostic {
            kind: DiagnosticKind::Error,
            message: "unused variable".into(),
            file: Some(PathBuf::from("src/lib.rs")),
            line: Some(10),
            column: Some(5),
            code: Some("E0001".into()),
            suggestion: Some("remove it".into()),
            raw: String::new(),
        }];
        let output = healer.format_diagnostics_for_prompt(&diagnostics);
        assert!(output.contains("Issue 1"));
        assert!(output.contains("E0001"));
        assert!(output.contains("unused variable"));
        assert!(output.contains("src/lib.rs:10:5"));
        assert!(output.contains("remove it"));
    }

    #[test]
    fn test_format_tests_for_prompt() {
        let healer = Healer::new(PathBuf::from("."), HealingConfig::default());
        let tests = vec![FailedTest {
            name: "tests::test_foo".into(),
            module: "tests".into(),
            failure: "assertion failed".into(),
            file: None,
            line: None,
        }];
        let output = healer.format_tests_for_prompt(&tests);
        assert!(output.contains("Failed Test 1"));
        assert!(output.contains("tests::test_foo"));
        assert!(output.contains("assertion failed"));
    }

    #[test]
    fn test_parse_json_note_and_help_levels() {
        // Note and Help are valid diagnostic kinds — should not be filtered out.
        let note_line = r#"{"reason":"compiler-message","message":{"level":"note","message":"for more info, see E0001","spans":[],"children":[]}}"#;
        let help_line = r#"{"reason":"compiler-message","message":{"level":"help","message":"consider borrowing","spans":[],"children":[]}}"#;
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let combined = format!("{}\n{}", note_line, help_line);
        let diagnostics = fixer.parse_diagnostics(&combined);
        assert_eq!(diagnostics.len(), 2);
        assert_eq!(diagnostics[0].kind, DiagnosticKind::Note);
        assert_eq!(diagnostics[1].kind, DiagnosticKind::Help);
        assert_eq!(diagnostics[0].file, None);
        assert_eq!(diagnostics[0].line, None);
    }

    #[test]
    fn test_parse_json_unknown_level_is_filtered() {
        // An unrecognized level like "trace" or "debug" should be skipped entirely.
        let line = r#"{"reason":"compiler-message","message":{"level":"trace","message":"verbose info","spans":[],"children":[]}}"#;
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_diagnostics(line);
        assert!(
            diagnostics.is_empty(),
            "unknown level should be filtered, got {} diagnostics",
            diagnostics.len()
        );
    }

    #[test]
    fn test_parse_json_suggestion_with_replacement() {
        // children[].spans[].suggested_replacement should be combined into the
        // suggestion field as "help_msg: replacement_text".
        let json = r#"{"reason":"compiler-message","message":{"level":"error","message":"missing semicolon","code":{"code":"E0001"},"spans":[{"file_name":"src/foo.rs","line_start":3,"column_start":10,"is_primary":true}],"children":[{"level":"help","message":"add semicolon","spans":[{"suggested_replacement":";"}]}]}}"#;
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_diagnostics(json);
        assert_eq!(diagnostics.len(), 1);
        let d = &diagnostics[0];
        assert!(d.suggestion.is_some(), "suggestion should be populated");
        let suggestion = d.suggestion.as_ref().unwrap();
        assert!(
            suggestion.contains("add semicolon"),
            "suggestion missing help text: {}",
            suggestion
        );
        assert!(
            suggestion.contains(";"),
            "suggestion missing replacement: {}",
            suggestion
        );
    }

    #[test]
    fn test_parse_json_no_primary_span() {
        // When no span has is_primary=true, file/line/column should all be None.
        let json = r#"{"reason":"compiler-message","message":{"level":"error","message":"no primary span","code":null,"spans":[{"file_name":"src/x.rs","line_start":1,"is_primary":false}],"children":[]}}"#;
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_diagnostics(json);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].file, None);
        assert_eq!(diagnostics[0].line, None);
        assert_eq!(diagnostics[0].column, None);
    }

    #[test]
    fn test_parse_mixed_json_and_text_prefers_json() {
        // When JSON parsing succeeds on at least one line, text fallback must NOT
        // fire — otherwise a single good JSON line would be augmented with
        // potentially wrong text-parsed versions of surrounding lines.
        let mixed = format!(
            "{}\nerror[E0999]: should not be double-parsed\n",
            r#"{"reason":"compiler-message","message":{"level":"error","message":"real error","code":{"code":"E0001"},"spans":[{"file_name":"src/a.rs","line_start":1,"column_start":1,"is_primary":true}],"children":[]}}"#
        );
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_diagnostics(&mixed);
        assert_eq!(
            diagnostics.len(),
            1,
            "text fallback must be suppressed when JSON parsing yielded any diagnostics"
        );
        assert_eq!(diagnostics[0].message, "real error");
    }

    // ─── Edge cases for text parser (task #23 extension) ─────────────────

    #[test]
    fn test_parse_text_error_without_code_bracket() {
        // Some cargo errors don't have [E0xxx] codes — e.g. "error: cannot
        // find crate" or the io::Error reported by rustc. The parser must
        // still produce a diagnostic with code=None and the message intact.
        let output = "error: cannot find crate `missing`\n   --> src/lib.rs:1:5\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 1);
        assert_eq!(diagnostics[0].kind, DiagnosticKind::Error);
        assert_eq!(diagnostics[0].code, None, "no [Exxxx] → code is None");
        assert!(
            diagnostics[0].message.contains("cannot find crate"),
            "message must be extracted after 'error: '"
        );
    }

    #[test]
    fn test_parse_text_help_before_any_error_is_dropped() {
        // A `help:` line appearing before any error/warning has no current
        // diagnostic to attach to — it must be silently dropped, not crash.
        let output = "help: this is orphaned\nhelp: also orphaned\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert!(
            diagnostics.is_empty(),
            "orphan help: must not create a diagnostic"
        );
    }

    #[test]
    fn test_parse_text_arrow_with_only_filename_no_colons() {
        // An unusual --> with just a filename (no :line:column) must not
        // panic — the rsplitn(3, ':') yields 1 part which falls through the
        // match with `_ => {}`, leaving file/line/column unset.
        let output = "error[E0999]: malformed error\n   --> weird_filename\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert_eq!(diagnostics.len(), 1);
        // Parser leaves all three None because parts.len() is 1 (no colons)
        assert_eq!(diagnostics[0].file, None);
        assert_eq!(diagnostics[0].line, None);
        assert_eq!(diagnostics[0].column, None);
    }

    #[test]
    fn test_format_diagnostics_empty_vec_produces_empty_output() {
        // Regression: format_diagnostics_for_prompt on an empty vec must
        // return an empty/minimal string, not panic or iterate a None.
        let healer = Healer::new(PathBuf::from("."), HealingConfig::default());
        let out = healer.format_diagnostics_for_prompt(&[]);
        // No diagnostic markers should appear
        assert!(
            !out.contains("Issue 1"),
            "empty diagnostics should not render any Issue lines, got: {out}"
        );
    }

    #[test]
    fn test_extract_module_with_deeply_nested_path() {
        // rfind("::") correctly extracts everything before the last `::`
        let fixer = TestFixer::new(PathBuf::from("."));
        assert_eq!(
            fixer.extract_module("a::b::c::d::test_foo"),
            "a::b::c::d",
            "deeply nested paths strip only the last segment"
        );
        assert_eq!(
            fixer.extract_module("single::test"),
            "single",
            "single-level path strips to top module"
        );
        assert_eq!(
            fixer.extract_module(""),
            "",
            "empty string stays empty (no panic)"
        );
    }

    #[test]
    fn test_parse_text_diagnostic_with_no_content_at_all() {
        // Running parser on lines that don't look like errors at all (build
        // progress, linker notes) must return 0 diagnostics.
        let output = "   Compiling pawan-core v0.3.1\n    Building [====>    ] 42/100\n   Finished dev [unoptimized] in 2.3s\n";
        let fixer = CompilerFixer::new(PathBuf::from("."));
        let diagnostics = fixer.parse_text_diagnostics(output);
        assert!(
            diagnostics.is_empty(),
            "build progress lines should not produce diagnostics, got {}",
            diagnostics.len()
        );
    }

    // ─── AuditFixer parser tests (compile-as-auditor amplification) ──────

    #[test]
    fn test_audit_parse_empty_output_returns_empty() {
        let diagnostics = AuditFixer::parse_audit_json("");
        assert!(diagnostics.is_empty());
    }

    #[test]
    fn test_audit_parse_invalid_json_returns_empty() {
        // Garbage in, no panic, empty out — `cargo audit` failures must
        // never crash the heal loop.
        let diagnostics = AuditFixer::parse_audit_json("not json at all { ] [");
        assert!(diagnostics.is_empty());
    }

    #[test]
    fn test_audit_parse_no_findings_returns_empty() {
        let json = r#"{"vulnerabilities":{"list":[]},"warnings":{}}"#;
        let diagnostics = AuditFixer::parse_audit_json(json);
        assert!(diagnostics.is_empty());
    }

    #[test]
    fn test_audit_parse_vulnerability_becomes_error_diagnostic() {
        let json = r#"{
            "vulnerabilities": {
                "list": [{
                    "advisory": {
                        "id": "RUSTSEC-2023-0071",
                        "title": "Marvin Attack: timing sidechannel in RSA"
                    },
                    "package": {
                        "name": "rsa",
                        "version": "0.9.10"
                    }
                }]
            },
            "warnings": {}
        }"#;
        let diagnostics = AuditFixer::parse_audit_json(json);
        assert_eq!(diagnostics.len(), 1);
        let d = &diagnostics[0];
        assert_eq!(d.kind, DiagnosticKind::Error);
        assert_eq!(d.code.as_deref(), Some("RUSTSEC-2023-0071"));
        assert!(d.message.contains("rsa"));
        assert!(d.message.contains("0.9.10"));
        assert!(d.message.contains("Marvin Attack"));
        assert!(d.message.starts_with("[security]"));
    }

    #[test]
    fn test_audit_parse_unmaintained_warning_becomes_warning_diagnostic() {
        let json = r#"{
            "vulnerabilities": {"list": []},
            "warnings": {
                "unmaintained": [{
                    "advisory": {
                        "id": "RUSTSEC-2025-0012",
                        "title": "backoff is unmaintained"
                    },
                    "package": {"name": "backoff", "version": "0.4.0"}
                }]
            }
        }"#;
        let diagnostics = AuditFixer::parse_audit_json(json);
        assert_eq!(diagnostics.len(), 1);
        let d = &diagnostics[0];
        assert_eq!(d.kind, DiagnosticKind::Warning);
        assert_eq!(d.code.as_deref(), Some("RUSTSEC-2025-0012"));
        assert!(d.message.contains("[unmaintained]"));
        assert!(d.message.contains("backoff"));
    }

    #[test]
    fn test_audit_parse_mixed_vuln_and_warning_separates_kinds() {
        let json = r#"{
            "vulnerabilities": {
                "list": [{
                    "advisory": {"id": "RUSTSEC-2023-0071", "title": "marvin"},
                    "package": {"name": "rsa", "version": "0.9.10"}
                }]
            },
            "warnings": {
                "unsound": [{
                    "advisory": {"id": "RUSTSEC-2026-0097", "title": "rand thread_rng"},
                    "package": {"name": "rand", "version": "0.8.5"}
                }]
            }
        }"#;
        let diagnostics = AuditFixer::parse_audit_json(json);
        assert_eq!(diagnostics.len(), 2);
        let errors: Vec<_> = diagnostics
            .iter()
            .filter(|d| d.kind == DiagnosticKind::Error)
            .collect();
        let warnings: Vec<_> = diagnostics
            .iter()
            .filter(|d| d.kind == DiagnosticKind::Warning)
            .collect();
        assert_eq!(errors.len(), 1, "vulnerability must be Error kind");
        assert_eq!(warnings.len(), 1, "unsound entry must be Warning kind");
        assert!(warnings[0].message.contains("[unsound]"));
    }

    #[test]
    fn test_audit_parse_handles_missing_fields_gracefully() {
        // Real-world JSON has occasional missing optional fields. Parser
        // should default to "unknown" rather than panicking.
        let json = r#"{
            "vulnerabilities": {
                "list": [{
                    "package": {}
                }]
            },
            "warnings": {}
        }"#;
        let diagnostics = AuditFixer::parse_audit_json(json);
        assert_eq!(diagnostics.len(), 1);
        let d = &diagnostics[0];
        assert_eq!(d.code.as_deref(), Some("unknown"));
        assert!(d.message.contains("unknown"));
    }

    // ─── Diagnostic::fingerprint tests ───────────────────────────────────

    fn make_diag(kind: DiagnosticKind, code: Option<&str>, message: &str) -> Diagnostic {
        Diagnostic {
            kind,
            message: message.to_string(),
            file: None,
            line: None,
            column: None,
            code: code.map(str::to_string),
            suggestion: None,
            raw: String::new(),
        }
    }

    #[test]
    fn test_fingerprint_same_diag_is_stable() {
        let d = make_diag(
            DiagnosticKind::Error,
            Some("E0425"),
            "cannot find value `x`",
        );
        assert_eq!(
            d.fingerprint(),
            d.fingerprint(),
            "fingerprint must be deterministic"
        );
    }

    #[test]
    fn test_fingerprint_different_code_differs() {
        let d1 = make_diag(DiagnosticKind::Error, Some("E0425"), "msg");
        let d2 = make_diag(DiagnosticKind::Error, Some("E0308"), "msg");
        assert_ne!(
            d1.fingerprint(),
            d2.fingerprint(),
            "different codes must differ"
        );
    }

    #[test]
    fn test_fingerprint_different_kind_differs() {
        let d1 = make_diag(DiagnosticKind::Error, Some("E0001"), "msg");
        let d2 = make_diag(DiagnosticKind::Warning, Some("E0001"), "msg");
        assert_ne!(
            d1.fingerprint(),
            d2.fingerprint(),
            "different kinds must differ"
        );
    }

    #[test]
    fn test_fingerprint_ignores_raw_field() {
        // raw captures full compiler output; it must not affect the fingerprint
        // so that the same logical error seen twice (with different raw context)
        // is still identified as the same fingerprint.
        let mut d1 = make_diag(DiagnosticKind::Error, Some("E0001"), "msg");
        let mut d2 = d1.clone();
        d1.raw = "first run output".to_string();
        d2.raw = "second run output (different)".to_string();
        assert_eq!(
            d1.fingerprint(),
            d2.fingerprint(),
            "raw must not affect fingerprint"
        );
    }

    #[test]
    fn test_fingerprint_long_message_truncated_to_120_chars() {
        // Two diagnostics that share the same first 120 chars but differ after
        // must produce the same fingerprint (truncation at 120).
        let prefix = "x".repeat(120);
        let d1 = make_diag(DiagnosticKind::Error, None, &format!("{prefix}suffix_A"));
        let d2 = make_diag(DiagnosticKind::Error, None, &format!("{prefix}suffix_B"));
        assert_eq!(
            d1.fingerprint(),
            d2.fingerprint(),
            "messages differing only beyond 120 chars must share a fingerprint"
        );
    }

    // ─── run_verify_cmd tests ──────────────────────────────────────────────

    #[test]
    fn test_healing_config_default_has_no_verify_cmd() {
        let cfg = HealingConfig::default();
        assert!(cfg.verify_cmd.is_none(), "verify_cmd must default to None");
    }

    #[tokio::test]
    async fn test_run_verify_cmd_success_returns_none() {
        // `true` always exits 0
        let result = run_verify_cmd(Path::new("."), "true").await;
        assert!(result.is_ok());
        assert!(result.unwrap().is_none(), "exit 0 should return Ok(None)");
    }

    #[tokio::test]
    async fn test_run_verify_cmd_failure_returns_some_diagnostic() {
        // `false` always exits 1 with no output
        let result = run_verify_cmd(Path::new("."), "false").await;
        assert!(result.is_ok());
        let diag = result.unwrap();
        assert!(diag.is_some(), "exit non-zero should return Ok(Some(_))");
        let d = diag.unwrap();
        assert_eq!(d.kind, DiagnosticKind::Error);
        assert!(
            d.message.contains("false"),
            "message should name the command"
        );
    }

    #[tokio::test]
    async fn test_run_verify_cmd_failure_captures_stderr() {
        // echo to stderr then exit non-zero
        let result =
            run_verify_cmd(Path::new("."), "echo 'stage2-failure-marker' >&2; exit 1").await;
        assert!(result.is_ok());
        let d = result.unwrap().expect("should be Some on failure");
        assert!(
            d.raw.contains("stage2-failure-marker"),
            "stderr output must appear in raw field, got: {:?}",
            d.raw
        );
    }
}