onevcs_testing/state.rs
1//! What a provider knows, in a shape a journey can write down and read back.
2//!
3//! One state type per interface, shared by both flavours of it — the in-memory
4//! provider and the file-backed one differ in where the state lives and in nothing
5//! else, so a scenario seeded for one is the same scenario for the other.
6
7use std::collections::{BTreeMap, BTreeSet};
8
9use serde::{Deserialize, Serialize};
10
11use onevcs::rules::{Approvals, Drafts};
12use onevcs::{
13 ChangeId, ChangeRequest, Check, CheckSource, DraftReason, Error, Identity, Landed,
14 MergeOutcome, Recoverable, Result,
15};
16use onevcs::{MergePolicy, Publication, RequiredChecks, Session, SessionRequest, SessionToken};
17
18use crate::events;
19use crate::store::Checked;
20
21/// The version of the state document this build writes.
22///
23/// A file-backed state outlives the process that wrote it and is read by the next
24/// one, which makes it a stored contract like `onevcs`'s own registry document —
25/// and like that document, the version a document declares decides what is done
26/// with it rather than being guessed at. [`STATE_VERSION`] is the shape the goldens in
27/// `tests/golden/` hold, and those goldens are compared byte for byte, so a change
28/// to the document cannot reach a consumer without the diff saying so.
29///
30/// `2` was what both sides learned when publishing and closing a session came
31/// through the interface: [`VcsState::policy`], [`VcsState::closed_sessions`],
32/// [`VcsState::publications`], and [`HostState::titles`]. `3` is
33/// [`HostState::bodies`], the body a change request was opened with. `4` is the two
34/// fields a `Recoverable` gained inside [`VcsState::preserved`] — the live session
35/// holding a branch, and the lines it would land when it removes more than it adds.
36/// `5` is one more of those: whether the branch's work reached its base, and what
37/// says so. `6` is the two a `Check` gained inside [`HostState::checks`] — the
38/// commit the host attached that check to, and where the check is on the host. `7`
39/// is the two a draft change request needs — [`HostState::drafts`], the reason each
40/// change request was opened as a draft with, and [`HostState::made_ready`], the
41/// `ready_for_review` calls it took. `8` is the two an [`Identity`] inside
42/// [`VcsState::identities`] **lost** — `workflow` and `repo_type`, the registry's
43/// inferences from whether an origin had a host, which every decision they made now
44/// takes from the resolved publication policy instead. `9` is the draft reason inside
45/// [`HostState::drafts`] becoming one of two kinds and saying which — `kind` is
46/// `awaiting-release` or `held` — and [`HostState::described`], the descriptions a
47/// host was handed for a change request after it was opened. `10` is the failure
48/// vocabulary a publication's outcome inside [`VcsState::publications`] may name
49/// widening by one kind, `host-prerequisite` — no field moved, but a document naming
50/// it is one a version 9 build cannot read, and the version is how it says so. `11` is
51/// one more field a `Recoverable` gained inside [`VcsState::preserved`], the same way
52/// `4` and `5` were: where `onevcs preserve` put that branch on its identity's origin,
53/// and the commit the origin carries it at. `12` is the labels a session is opened
54/// with — [`VcsState::session_labels`], keyed by token the way its identity is — and
55/// the two fields a `Recoverable` gained inside [`VcsState::preserved`] to carry them:
56/// the session that answers for the row, and that session's labels. `13` is one more
57/// field a `Recoverable` gained there: the branch's retirement classification — whether
58/// it provably holds nothing beyond its base, was superseded by a retry that landed, or
59/// is kept, and the evidence for it. No provider here classifies a row, so a row this
60/// crate writes carries none; a scenario may seed one. `14` is the draft lifecycle:
61/// [`HostState::awaiting_checks`], the change requests opened as a draft while their
62/// required checks run, [`HostState::checks_after_lift`], the checks a host registers
63/// only once a change is lifted, and [`HostState::required_checks`], what the host
64/// says a merge into a base requires — beside [`VcsState::approvals`] and
65/// [`VcsState::drafts`], the two policy fields a provider's publication now routes
66/// the lifecycle on. A publication outcome inside [`VcsState::publications`] may also
67/// be `change-review-draft`.
68///
69/// **Every change to the document is versioned, an added field included.** A field
70/// that only ever appears when it holds something is *compatible* — that is what
71/// [`OLDEST_READABLE_VERSION`] is for — but compatible is not the same as
72/// unremarkable: the version is how a consumer's checked-in scenario says which
73/// shape it was written against, and a document that gained a field without saying
74/// so leaves nothing able to tell "this build wrote no body" from "this document
75/// predates bodies". The two answers differ for exactly the journey this crate
76/// exists to support.
77pub const STATE_VERSION: u32 = 14;
78
79/// The oldest document version this build reads.
80///
81/// Every version from here to [`STATE_VERSION`] is read and carried forward on the
82/// way in, which is how `onevcs`'s own registry document treats its older
83/// versions: what separates a readable older version from a refused one is whether
84/// its every field still means here what it meant there. `2` to `3` added a field
85/// and changed none, so a version 2 document reads as one whose change requests
86/// were opened with no body — which is what they were; `3` to `4` added two the same
87/// way, so a version 3 document reads as one whose preserved rows say nothing about a
88/// hold or a line count, which is what they said. `4` to `5` added one that every row
89/// answers rather than one that appears when it holds something, so a version 4
90/// document's rows are carried forward as the answer that list *was*: preserved work
91/// nobody published, which is work that did not land. `5` to `6` added two that
92/// appear only when they hold something, so a version 5 document's checks read as
93/// checks whose commit and address that build never recorded — which is what they
94/// were, and the one thing that must not be filled in from the change request's own
95/// head. `6` to `7` added two more of that kind, so a version 6 document reads as one
96/// whose change requests were opened before this crate could draft one — which is what
97/// they were: no draft reason recorded for any of them, and no lift ever asked for.
98/// `7` to `8` *removed* two from each identity, and a version 7 document reads past
99/// them: an identity is its origin and its gate here as it is in `onevcs`, and the two
100/// keys beside them are ones this build has no opinion on. `8` to `9` gave every
101/// draft reason a `kind`, and a reason written without one is read as the one kind
102/// there was — `awaiting-release`, whose four fields it carries unchanged — which is
103/// `drafts_of_any_version`'s whole job; the descriptions beside it are absent from a
104/// document written before them, which is the answer, since that build could describe
105/// nothing. `9` to `10` changed no field and no meaning: every failure kind a version 9
106/// document can hold is spelled here as it was there and means what it meant, so it
107/// reads unchanged and needs no carrying forward beyond its version. `10` to `11` added
108/// one that appears only when it holds something, so a version 10 document's preserved
109/// rows read as rows saying nothing about an origin — which is what they said, since
110/// that build had no verb that could put a branch on one. `11` to `12` added the
111/// labels, which appear only where a session was opened with some, and the two row
112/// fields that carry them, which a version 11 row reads as absent: a session nobody
113/// labelled, and a row that names no session — which is what that build's rows said,
114/// since it recorded neither. `12` to `13` added the row's retirement, which appears only
115/// where a row holds one, so a version 12 row reads as one nothing classified — which
116/// is what it was, since that build had no classification to record. `13` to `14`
117/// added fields that appear only when they hold something, so a version 13 document
118/// reads as one whose change requests were opened before the lifecycle drafted any,
119/// whose checks never change on a lift, whose host declares its required checks by
120/// the checks it was seeded with, and whose policy leaves approvals and drafts at
121/// their defaults — which is what that build published under.
122///
123/// `1` is refused rather than read for the opposite reason: it describes a provider
124/// that could not publish, and every session in it would read back as open — a
125/// wrong answer where a journey asserting on a session it had closed needs a
126/// refusal.
127pub const OLDEST_READABLE_VERSION: u32 = 2;
128
129/// Everything the repository side of a run knows about itself.
130///
131/// Every field is public and serializable, so a journey both seeds a scenario and
132/// asserts on what a run left behind. Everything but the version is omitted when
133/// it holds nothing, so a hand-written document names only the part of a scenario
134/// that matters — and a document written by a build that knew fewer fields still
135/// reads here.
136#[derive(Debug, Clone, Serialize, Deserialize)]
137#[serde(default)]
138pub struct VcsState {
139 /// The schema version this state was written at. A document that names none is
140 /// the one this build writes.
141 // llmlint: ignore[boundary_inputs_validated] deciding what to do with a version this
142 // build does not read is the whole of the check — and it is in `Checked::check` below,
143 // where a document is read, rather than here where serde only proves the shape.
144 pub version: u32,
145 /// The repository identities this provider can resolve. A
146 /// [`SessionRequest::repo`] naming none of them is refused, the way an
147 /// unregistered repository is.
148 #[serde(skip_serializing_if = "Vec::is_empty")]
149 pub identities: Vec<Identity>,
150 /// Every session opened or seeded, in the order they were opened.
151 #[serde(skip_serializing_if = "Vec::is_empty")]
152 pub sessions: Vec<Session>,
153 /// Which identity each session belongs to.
154 ///
155 /// Beyond the sketch this crate was specified from, and unavoidable: a
156 /// [`Session`] carries no identity, and a [`Recoverable`] must name one — so
157 /// preserving a session's branch could not answer the question `recoverable`
158 /// asks without this. `open_session` records it; nothing else writes it.
159 // llmlint: ignore[invalid_states_unrepresentable] an identity key is a `String`
160 // everywhere the crate this mirrors spells one — `Recoverable.identity`,
161 // `Identity.origin`, the registry document's own map key — and a newtype here would
162 // make a seeded state disagree with the types it is made of. Every value written to
163 // this map came out of `identity_of`, so it names an identity this provider holds.
164 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
165 pub session_identities: BTreeMap<SessionToken, String>,
166 /// The labels each session was opened with, for the sessions opened with any.
167 ///
168 /// Keyed by token the way [`session_identities`](Self::session_identities) is,
169 /// and for the same reason: a [`Session`] carries no labels, and both `session
170 /// holders` and every `recoverable` row report them. `open_session` records
171 /// them; nothing else writes it.
172 // llmlint: ignore[invalid_states_unrepresentable] keyed by session token, exactly as
173 // `session_identities` above is and for the same reason it gives.
174 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
175 pub session_labels: BTreeMap<SessionToken, BTreeMap<String, String>>,
176 /// Preserved work, newest last, as `recoverable` reports it.
177 ///
178 /// [`Recoverable`] rather than `PreservedBranch` — it *contains* the preserved
179 /// branch and adds the identity, the checkout, why the workstream stopped, and
180 /// the command that lands it, none of which are derivable from the branch
181 /// alone. One list rather than two that could disagree.
182 #[serde(skip_serializing_if = "Vec::is_empty")]
183 pub preserved: Vec<Recoverable>,
184 /// The sessions that have been closed. Every other session here is open.
185 ///
186 /// One way to say closed rather than two, so a scenario written by hand names
187 /// only the sessions whose lifecycle is not the one they were opened in.
188 // llmlint: ignore[invalid_states_unrepresentable] keyed by session token, exactly as
189 // `session_identities` above is and for the same reason: this document is a scenario
190 // somebody writes by hand, and a session is named once under `sessions` with the rest
191 // of the state keyed to it rather than nested inside a shape that could hold only one
192 // arrangement. A token here that names no opened session is refused in
193 // `Checked::check`, where the document is read — the same trust boundary every other
194 // cross-reference in it is checked at.
195 #[serde(skip_serializing_if = "BTreeSet::is_empty")]
196 pub closed_sessions: BTreeSet<SessionToken>,
197 /// The policy this provider publishes under.
198 ///
199 /// The answer a rules file gives the real implementation, which a provider has
200 /// none of — so a journey states it, and unset is the policy the contract's own
201 /// `default:` names ([`DEFAULT_PUBLICATION`](crate::DEFAULT_PUBLICATION)). A
202 /// per-run policy narrows it through [`MergePolicy::narrow`], which is the
203 /// rules system's rule rather than a restatement of it here.
204 #[serde(skip_serializing_if = "Option::is_none")]
205 pub policy: Option<MergePolicy>,
206 /// Whether this provider's changes need an approval, which is the other half of
207 /// what decides a green draft's ending: `change-open` with approvals required
208 /// keeps it for its user's review. Unset is the contract's own `default:`,
209 /// [`DEFAULT_APPROVALS`](crate::DEFAULT_APPROVALS).
210 #[serde(skip_serializing_if = "Option::is_none")]
211 pub approvals: Option<Approvals>,
212 /// The `drafts:` a rules file would give this provider's identity. Unset, and
213 /// each key it leaves unset, is the shipped default: the lifecycle on and the
214 /// early-lift warning on.
215 #[serde(skip_serializing_if = "Option::is_none")]
216 pub drafts: Option<Drafts>,
217 /// Every publication this provider performed, in the order it performed them.
218 ///
219 /// Both a record a journey asserts on and the answer to "has this session been
220 /// published already": a second publication of a session that landed has
221 /// nothing the base does not already carry, which is what the real
222 /// implementation reports for the same reason.
223 // llmlint: ignore[invalid_states_unrepresentable] this holds `onevcs::Publication`
224 // verbatim — the value `Vcs::publish` handed back, carrying its own session and branch
225 // — so a journey asserts on exactly what a caller would receive. A shape that made
226 // "this publication is of some other session's branch" unrepresentable could not hold
227 // that type, and would be a second spelling of the answer the crate next door already
228 // has. The cross-reference is checked in `Checked::check` instead, where the document
229 // is read.
230 #[serde(skip_serializing_if = "Vec::is_empty")]
231 pub publications: Vec<Publication>,
232}
233
234/// A repository side that knows nothing, at the version this build writes.
235impl Default for VcsState {
236 fn default() -> Self {
237 Self {
238 version: STATE_VERSION,
239 identities: Vec::new(),
240 sessions: Vec::new(),
241 session_identities: BTreeMap::new(),
242 session_labels: BTreeMap::new(),
243 preserved: Vec::new(),
244 closed_sessions: BTreeSet::new(),
245 policy: None,
246 approvals: None,
247 drafts: None,
248 publications: Vec::new(),
249 }
250 }
251}
252
253/// Everything the remote-host side of a run knows about itself.
254///
255/// Omitted-when-empty and versioned for the same reasons [`VcsState`] is.
256#[derive(Debug, Clone, Serialize, Deserialize)]
257#[serde(default)]
258pub struct HostState {
259 /// The schema version this state was written at. A document that names none is
260 /// the one this build writes.
261 // llmlint: ignore[boundary_inputs_validated] as on `VcsState::version`: the decision
262 // about an unreadable version is made in `Checked::check`, where the document is read.
263 pub version: u32,
264 /// Who the host says is calling. Empty is refused, exactly as a `gh` that
265 /// reports no authenticated user is.
266 // llmlint: ignore[invalid_states_unrepresentable] the interface this satisfies is
267 // `authenticated_user() -> Result<String>`, so the login is a `String` by contract and
268 // the one unusable value — a host that names nobody — is refused where it is read
269 // rather than made unrepresentable in a state a journey writes by hand.
270 pub authenticated_user: String,
271 /// Every change request that has been opened or seeded.
272 #[serde(skip_serializing_if = "Vec::is_empty")]
273 pub changes: Vec<ChangeRequest>,
274 /// The head branch each change request was opened from.
275 ///
276 /// Beyond the sketch, and unavoidable: [`ChangeRequest`] records only the base
277 /// it targets, and `find_changes` matches on the head as well.
278 // llmlint: ignore[invalid_states_unrepresentable] the matching `ChangeSpec.head` and
279 // `ChangeRequest.base` are `String` in the contract this mirrors, and a validated ref
280 // type here would disagree with them. Every value written to this map went through
281 // `addressable` in `open_change` first, which is the same refusal the real
282 // implementation makes at the same point.
283 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
284 pub heads: BTreeMap<ChangeId, String>,
285 /// The title each change request was opened under.
286 ///
287 /// Beyond the sketch, and for the same reason [`heads`](HostState::heads) is:
288 /// [`ChangeRequest`] records neither, and the title is what a publication's
289 /// commit subject becomes — so a journey asserting that the subject it asked
290 /// for is the one the host was given has nowhere else to read it.
291 // llmlint: ignore[invalid_states_unrepresentable] this records the `ChangeSpec.title`
292 // the contract fixes as a `String`, so a validated type here would disagree with the
293 // one it mirrors. `Subject` is not that type: it is `onevcs`'s rule for a *commit
294 // subject*, and a host's own limit is its own — spelling it here would
295 // refuse a seeded title a real host accepts, which is drift in the direction that
296 // looks like rigour. What the host itself refuses is a title that names nothing, and
297 // that is refused below and in `open_change`, at the boundary the value arrives at.
298 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
299 pub titles: BTreeMap<ChangeId, String>,
300 /// The body each change request was opened with, for the change requests that
301 /// were opened with one.
302 ///
303 /// Beside [`titles`](HostState::titles) and for its reason: the body is what a
304 /// caller passes on the `PublishRequest` and nothing else records it, so a
305 /// journey asserting that the body it drafted is the one the host was given has
306 /// nowhere else to read it. A change request with no entry was opened with no
307 /// body at all, which is what a publication nobody gave one does — the two are
308 /// different scenarios, and an empty string is the first rather than the second.
309 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
310 pub bodies: BTreeMap<ChangeId, String>,
311 /// The checks the host reports on each change request. A change with no entry
312 /// has no checks, which is what a repository with no CI reports.
313 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
314 pub checks: BTreeMap<ChangeId, Vec<Check>>,
315 /// The log the host hands over for a check, keyed by change request and then by
316 /// check name. Beyond the sketch: `check_log` is one of the six methods, and
317 /// without this the only log a journey could asssert on is a synthesized one.
318 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
319 pub check_logs: BTreeMap<ChangeId, BTreeMap<String, String>>,
320 /// The reason each change request that was opened as a **draft** was drafted
321 /// with, for the change requests that were.
322 ///
323 /// Beside [`bodies`](HostState::bodies) and for its reason: the reason is what a
324 /// caller passes on the `PublishRequest` and this is where a journey reads back
325 /// that the host was given it. A change with no entry is not a draft, which is
326 /// what every change request opened without one is.
327 ///
328 /// Nothing is refused about the reason itself here. Its shape — that every field
329 /// of it renders as the one line it is printed on — is `onevcs`'s own rule, and
330 /// it is applied where a publication takes one in, before any host is asked.
331 #[serde(
332 skip_serializing_if = "BTreeMap::is_empty",
333 deserialize_with = "drafts_of_any_version"
334 )]
335 pub drafts: BTreeMap<ChangeId, DraftReason>,
336 /// Every `ready_for_review` call this host has taken, in the order it took them
337 /// — the lifts it was asked to perform, never a request for a *reviewer*.
338 ///
339 /// A list rather than a set, and beyond the sketch for a reason a set could not
340 /// serve: lifting a draft is required to be *idempotent*, so what a journey
341 /// asserts is that a second publication asked the host for nothing — and only a
342 /// record of the calls themselves can say that. A change named here is not a
343 /// draft any more, whatever [`drafts`](HostState::drafts) says it was opened as.
344 #[serde(skip_serializing_if = "Vec::is_empty")]
345 pub made_ready: Vec<ChangeId>,
346 /// The change requests opened as a draft **while their required checks run** —
347 /// the lifecycle's draft, which no caller gave a reason for and so is not in
348 /// [`drafts`](HostState::drafts). A change named here is a draft until
349 /// [`made_ready`](HostState::made_ready) names it.
350 #[serde(skip_serializing_if = "BTreeSet::is_empty")]
351 pub awaiting_checks: BTreeSet<ChangeId>,
352 /// The checks the host reports on a change request once it has been lifted out of
353 /// its draft, in place of [`checks`](HostState::checks).
354 ///
355 /// What a repository whose workflow skips drafts looks like from outside: the
356 /// draft's checks are skipped or absent, and the run the lift triggers registers
357 /// after it. A change with no entry reports the same checks either side of a lift.
358 ///
359 /// A publication tells the run a lift triggered from the draft's by the run's own
360 /// identity, as it would on a real host: a check named here that the draft also
361 /// reported is a new run — running or settled — only where its
362 /// [`started_at`](Check::started_at) is one no draft-era run of that check reported. So seed a re-run with a start of its own — an entry repeating
363 /// the draft's start, or reporting none, is the draft's run still standing.
364 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
365 pub checks_after_lift: BTreeMap<ChangeId, Vec<Check>>,
366 /// What this host answers when asked which checks a merge into a base requires.
367 ///
368 /// Unset is a host whose branch protection names exactly the checks it was seeded
369 /// as required, on any change request — a complete answer, and an empty one where
370 /// none is seeded required. Seeded, it is the answer for every base: an empty
371 /// complete one is a repository declaring no required check, and one naming an
372 /// `unconsulted` source is the incomplete answer a narrower credential gets.
373 #[serde(skip_serializing_if = "Option::is_none")]
374 pub required_checks: Option<RequiredChecks>,
375 /// Every `describe_change` call this host has taken, in the order it took them:
376 /// which change request, the title it was handed when it was handed one, and the
377 /// body.
378 ///
379 /// The calls themselves, for the reason [`made_ready`](HostState::made_ready) is:
380 /// what a journey asks is what a closeout *wrote*, call by call, and the current
381 /// title and body — which each call also writes into
382 /// [`titles`](HostState::titles) and [`bodies`](HostState::bodies), so
383 /// `change_description` answers from the same record `open_change` wrote — can
384 /// only say where the description ended up.
385 #[serde(skip_serializing_if = "Vec::is_empty")]
386 pub described: Vec<Described>,
387 /// Which sources this host answers about its checks from, which is what the
388 /// real implementation reports alongside them.
389 ///
390 /// Unset is a credential allowed to read everything: the whole rollup, exactly
391 /// what a host with nothing to hide reports. A journey states a narrower set to
392 /// be the credential the real one meets in CI — a fine-grained token, which
393 /// cannot read check runs at all and sees GitHub Actions and nothing else — and
394 /// states an *empty* one to be a credential that can read no source at all,
395 /// which is a refusal rather than "no checks". Unset and empty are therefore
396 /// different scenarios, which is why this is an `Option` rather than a set whose
397 /// emptiness means "not stated".
398 #[serde(skip_serializing_if = "Option::is_none")]
399 pub check_sources: Option<BTreeSet<CheckSource>>,
400 /// What merging each change request did.
401 ///
402 /// Both a script and a record: an entry seeded here is what `merge` answers,
403 /// whatever the policy asks for — which is how a journey expresses a host that
404 /// queues or refuses — and a merge the policy decided is written back here.
405 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
406 pub merges: BTreeMap<ChangeId, MergeOutcome>,
407}
408
409/// One description a host was handed for a change request after it was opened.
410///
411/// What `RemoteHost::describe_change` was given, verbatim: the title only where the
412/// call carried one, because a call that replaced the body alone left the title as
413/// it was, and a record that filled it in would say the caller wrote a title nobody
414/// wrote.
415// llmlint: ignore[invalid_states_unrepresentable] the title and body are the `&str`s the
416// seam hands over — a host places no shape on prose, and `onevcs`'s own `Subject` rule
417// was applied where the description was composed, before any host was asked.
418#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
419pub struct Described {
420 /// The change request the description was written to.
421 pub id: ChangeId,
422 /// The title the call replaced the change request's with, when it replaced one.
423 #[serde(default, skip_serializing_if = "Option::is_none")]
424 pub title: Option<String>,
425 /// The body the call replaced the change request's with.
426 pub body: String,
427}
428
429/// The `drafts` map of a document at any readable version.
430///
431/// A document written before version 9 spells a draft reason as the four fields of
432/// the one kind there was and no `kind` beside them; this build's reason is one of
433/// two kinds and says which. So a reason arriving without a `kind` is read as
434/// `awaiting-release` — exactly what it was — rather than refused, which is what
435/// keeps a consumer's checked-in scenario readable across the bump. A reason that
436/// *names* a kind is read as it names it, so nothing written by this build is
437/// reinterpreted.
438fn drafts_of_any_version<'de, D>(
439 deserializer: D,
440) -> std::result::Result<BTreeMap<ChangeId, DraftReason>, D::Error>
441where
442 D: serde::Deserializer<'de>,
443{
444 let raw: BTreeMap<ChangeId, serde_json::Map<String, serde_json::Value>> =
445 Deserialize::deserialize(deserializer)?;
446 raw.into_iter()
447 .map(|(id, mut fields)| {
448 fields
449 .entry("kind")
450 .or_insert_with(|| serde_json::Value::from("awaiting-release"));
451 serde_json::from_value::<DraftReason>(serde_json::Value::Object(fields))
452 .map(|reason| (id, reason))
453 .map_err(serde::de::Error::custom)
454 })
455 .collect()
456}
457
458/// Who a host with nothing seeded says is calling.
459///
460/// A host that answers nobody is refused by the real implementation, so a default
461/// state that answered nobody would be a provider that cannot run a publication
462/// until it is configured.
463pub const DEFAULT_AUTHENTICATED_USER: &str = "onevcs-testing";
464
465impl Default for HostState {
466 fn default() -> Self {
467 Self {
468 version: STATE_VERSION,
469 authenticated_user: DEFAULT_AUTHENTICATED_USER.to_owned(),
470 changes: Vec::new(),
471 heads: BTreeMap::new(),
472 titles: BTreeMap::new(),
473 bodies: BTreeMap::new(),
474 drafts: BTreeMap::new(),
475 made_ready: Vec::new(),
476 awaiting_checks: BTreeSet::new(),
477 checks_after_lift: BTreeMap::new(),
478 required_checks: None,
479 described: Vec::new(),
480 checks: BTreeMap::new(),
481 check_logs: BTreeMap::new(),
482 check_sources: None,
483 merges: BTreeMap::new(),
484 }
485 }
486}
487
488/// The identity a session request names, or the reason none of them is it.
489///
490/// Three ways to name one, mirroring what the registry accepts: the identity key
491/// itself, the `owner/name` tail of it, or the bare repository name.
492pub(crate) fn identity_of<'a>(state: &'a VcsState, origin_or_path: &str) -> Option<&'a Identity> {
493 let wanted = origin_or_path.trim_end_matches('/');
494 state
495 .identities
496 .iter()
497 .find(|identity| identity.origin == wanted)
498 .or_else(|| {
499 state.identities.iter().find(|identity| {
500 identity
501 .origin
502 .rsplit('/')
503 .next()
504 .is_some_and(|name| name == wanted)
505 || identity.origin.ends_with(&format!("/{wanted}"))
506 })
507 })
508}
509
510/// The known identities, as a refusal names them.
511pub(crate) fn known(state: &VcsState) -> String {
512 if state.identities.is_empty() {
513 return "this provider was seeded with no identities".to_owned();
514 }
515 let names: Vec<&str> = state
516 .identities
517 .iter()
518 .map(|identity| identity.origin.as_str())
519 .collect();
520 format!("it knows {}", names.join(", "))
521}
522
523/// The identity a session belongs to, or the reason this provider cannot say.
524///
525/// `open_session` records it and nothing else writes it, so a session that arrived
526/// in a hand-written scenario without one is refused here rather than published
527/// against a repository nobody named.
528pub(crate) fn identity_for(state: &VcsState, token: &SessionToken) -> Result<String> {
529 state
530 .session_identities
531 .get(token)
532 .cloned()
533 .ok_or_else(|| Error::Invalid {
534 reason: format!(
535 "this provider has no record of session {:?}, so it cannot say which identity \
536 its work belongs to",
537 token.0
538 ),
539 })
540}
541
542/// The session a token names.
543pub(crate) fn session_of<'a>(state: &'a VcsState, token: &SessionToken) -> Option<&'a Session> {
544 state
545 .sessions
546 .iter()
547 .find(|session| session.token == *token)
548}
549
550/// The branch a request asks for, or the one that is derived from the token.
551///
552/// `branch` and `branch_name` are two answers to one question — *continue this* and
553/// *cut one at this* — so a request naming both is refused here as the real
554/// implementation refuses it: that refusal is about the shape of the request rather
555/// than about anything a repository does, and a consumer proving it must meet the
556/// same answer on either side.
557///
558/// **What a provider deliberately does not do to `branch_name` is the rest**, and it
559/// is not approximated: the host's branch prefix is read out of an `onevcs` state
560/// root no provider has, and the first-free suffix is searched against an identity's
561/// checkouts and its origin, which a provider has neither of. So the name is taken as
562/// it was proposed and refused — naming it — where git would refuse it, rather than
563/// being sanitized by a second copy of a grammar that would then have to be held to
564/// the first. A consumer proving what the prefix, the sanitizer and the collision
565/// suffix do drives the real `onevcs`, which is where all three live.
566pub(crate) fn requested_branch(req: &SessionRequest, token: &SessionToken) -> Result<String> {
567 if let (Some(pinned), Some(proposed)) = (&req.branch, &req.branch_name) {
568 return Err(Error::Invalid {
569 reason: format!(
570 "this request names both a branch to continue ({pinned:?}) and a name to cut \
571 ({proposed:?}), which are two answers to one question"
572 ),
573 });
574 }
575 let name = req
576 .branch
577 .clone()
578 .or_else(|| req.branch_name.clone())
579 .unwrap_or_else(|| format!("onevcs/{}", token.0));
580 named_branch(&name, "the branch")?;
581 Ok(name)
582}
583
584/// A branch name, refused here if git would refuse it.
585///
586/// The real implementation asks `git check-ref-format`, which is the parser that
587/// decides; a provider with no git carries `git-check-ref-format(1)`'s rules
588/// instead. That is a restatement, so it is gated rather than trusted:
589/// `refs.rs` in the suite runs both this and git itself over a table of names
590/// and holds them to each other, because a copy of somebody else's grammar with
591/// no gate is a copy that drifts.
592///
593/// One deliberate difference, and the gate knows about it: a leading `-` is
594/// refused here even though git accepts it as a ref, because such a name reaches
595/// a command line as an option rather than as the branch it spells.
596pub(crate) fn named_branch(value: &str, what: &str) -> Result<()> {
597 // Rule 1 is per slash-separated component; the rest are about the whole name.
598 let components_usable = !value.is_empty()
599 && value.split('/').all(|component| {
600 !component.is_empty() && !component.starts_with('.') && !component.ends_with(".lock")
601 });
602 let usable = components_usable
603 && !value.starts_with('-')
604 && !value.contains("..")
605 && !value.contains("@{")
606 && !value.ends_with('.')
607 && !value.ends_with('/')
608 && !value.chars().any(|c| {
609 c.is_whitespace() || c.is_ascii_control() || c == '\u{7f}' || "~^:?*[\\".contains(c)
610 });
611 if !usable {
612 return Err(Error::Invalid {
613 reason: format!("{what} {value:?} is a name git would not accept"),
614 });
615 }
616 Ok(())
617}
618
619/// A label, refused here where the real implementation refuses one: a key is one or
620/// more of `A-Z`, `a-z`, `0-9`, `_` and `-`, and a value is one line. The same rule
621/// spelled twice on purpose, for the reason [`named_branch`] gives — a provider with
622/// no `onevcs` state root carries the grammar, and the journeys over both providers
623/// hold the two to each other.
624pub(crate) fn label_pair(key: &str, value: &str) -> Result<()> {
625 let key_usable = !key.is_empty()
626 && key
627 .chars()
628 .all(|c| c.is_ascii_alphanumeric() || c == '_' || c == '-');
629 if !key_usable {
630 return Err(Error::Invalid {
631 reason: format!(
632 "{key:?} is not a label key; a key is one or more of A-Z, a-z, 0-9, `_` and `-`"
633 ),
634 });
635 }
636 if value.contains('\n') {
637 return Err(Error::Invalid {
638 reason: format!(
639 "the value of label {key:?} holds a newline; a label's value is one line"
640 ),
641 });
642 }
643 Ok(())
644}
645
646/// A seeded repository side is refused if it holds a session nothing could act on.
647impl Checked for VcsState {
648 fn check(&self) -> Result<()> {
649 readable_version(self.version)?;
650 for session in &self.sessions {
651 // The token names a file under the state root, and a branch goes on to
652 // spell a ref; both arrive from whoever wrote the document.
653 if !events::is_safe_name(&session.token.0) {
654 return Err(Error::Invalid {
655 reason: format!("{:?} is not a session token", session.token.0),
656 });
657 }
658 named_branch(&session.branch, "the branch")?;
659 named_branch(&session.base, "the base")?;
660 }
661 for row in &self.preserved {
662 known_identity(self, &row.identity, "preserved work")?;
663 named_branch(&row.branch.branch, "the preserved branch")?;
664 named_branch(&row.branch.base, "the preserved branch's base")?;
665 // The hold names a session, so it is checked like the three below: a row
666 // held by a session nobody opened is the same fiction, and the costly one
667 // — it is the session an operator is told to wait for or close.
668 if let Some(held) = &row.held_by {
669 opened(self, &held.token, "holding preserved work")?;
670 }
671 }
672 // Both of these name a session, so both are checked twice over: the token
673 // has to be a plain name, because it goes on to spell the file its stream is
674 // written in, and it has to name a session this state actually holds. A
675 // document that closes or publishes a session nobody opened describes a run
676 // that could not have happened, and answering `recoverable` or `session`
677 // from it would be answering from a fiction rather than refusing one.
678 for token in &self.closed_sessions {
679 opened(self, token, "closed")?;
680 }
681 for (token, labels) in &self.session_labels {
682 opened(self, token, "labelled")?;
683 for (key, value) in labels {
684 label_pair(key, value)?;
685 }
686 }
687 for (token, origin) in &self.session_identities {
688 opened(self, token, "given an identity")?;
689 // The value as well as the key: this is what `identity_for` answers with,
690 // and it goes on to spell the slug a change request is opened against and
691 // the label every one of that session's events carries. An identity this
692 // provider does not know is one it could not have opened the session for.
693 known_identity(self, origin, &format!("session {:?}", token.0))?;
694 }
695 for publication in &self.publications {
696 let session = opened(self, &publication.session, "published")?;
697 named_branch(&publication.branch, "the published branch")?;
698 // A publication of some other branch than the one the session is on is
699 // the same kind of fiction, and the harder one to spot afterwards: the
700 // branch is what a journey asserts the publication was of.
701 if publication.branch != session.branch {
702 return Err(Error::Invalid {
703 reason: format!(
704 "the publication of session {:?} names branch {:?}, but that session is \
705 on {:?}",
706 publication.session.0, publication.branch, session.branch
707 ),
708 });
709 }
710 }
711 Ok(())
712 }
713
714 /// Every field an older readable document could hold means here what it meant
715 /// there, and the two the repository side gained in version 4 are absent from one
716 /// written before them — which is the answer, since that build held no hold and
717 /// counted no lines.
718 ///
719 /// Version 5's field is the exception, and it is carried rather than left at its
720 /// default: a document written before it *listed preserved work nobody had
721 /// published*, which is the `no` this build spells out. Left at the default it
722 /// would read as "nothing here can say", and a consumer's checked-in scenario
723 /// would start reporting work it had always called unpublished as work that may
724 /// have landed.
725 fn carry_forward(&mut self) {
726 if self.version < 5 {
727 for row in &mut self.preserved {
728 row.landed = Landed::No;
729 }
730 }
731 self.version = STATE_VERSION;
732 }
733}
734
735/// Refuse a record kept about a change request this state does not hold.
736fn opened_change(state: &HostState, id: &ChangeId, what: &str) -> Result<()> {
737 if state.changes.iter().any(|change| change.id == *id) {
738 return Ok(());
739 }
740 Err(Error::Invalid {
741 reason: format!(
742 "{what} is recorded for change request {:?}, but no change request by that \
743 identifier was opened",
744 id.0
745 ),
746 })
747}
748
749/// Refuse an identity key this provider was not seeded with.
750fn known_identity(state: &VcsState, origin: &str, what: &str) -> Result<()> {
751 if state
752 .identities
753 .iter()
754 .any(|identity| identity.origin == origin)
755 {
756 return Ok(());
757 }
758 Err(Error::Invalid {
759 reason: format!(
760 "{what} belongs to identity {origin:?}, which this provider does not know; {}",
761 known(state)
762 ),
763 })
764}
765
766/// A change request's title, refused when it names nothing.
767///
768/// The one thing a real host refuses about a title, and the only one this provider
769/// may: how long a title may be is the host's own rule rather than `onevcs`'s
770/// commit-subject rule, and a provider applying the stricter of the two would
771/// refuse what the host it stands in for accepts.
772pub(crate) fn titled(title: &str) -> Result<()> {
773 if title.trim().is_empty() {
774 return Err(Error::Invalid {
775 reason: "a change request's title is blank, so it names no change".to_owned(),
776 });
777 }
778 Ok(())
779}
780
781/// The session a token names, refused when this state does not hold one.
782fn opened<'a>(state: &'a VcsState, token: &SessionToken, what: &str) -> Result<&'a Session> {
783 if !events::is_safe_name(&token.0) {
784 return Err(Error::Invalid {
785 reason: format!("{:?} is not a session token", token.0),
786 });
787 }
788 session_of(state, token).ok_or_else(|| Error::Invalid {
789 reason: format!(
790 "session {:?} is {what} here, but no session by that token was opened",
791 token.0
792 ),
793 })
794}
795
796/// A seeded host side is refused if it holds a change nothing could address.
797impl Checked for HostState {
798 fn check(&self) -> Result<()> {
799 readable_version(self.version)?;
800 for change in &self.changes {
801 named_branch(&change.base, "the base of a seeded change request")?;
802 if change.id.0.is_empty() {
803 return Err(Error::Invalid {
804 reason: "a seeded change request carries no identifier".to_owned(),
805 });
806 }
807 // The commit a change request's checks are reported against is the whole
808 // evidence that a change reached anything, and the real implementation
809 // refuses a host answer that names none rather than passing a blank one
810 // through. A seeded one is refused for the same reason.
811 if change.head_sha.0.trim().is_empty() {
812 return Err(Error::Invalid {
813 reason: format!(
814 "the seeded change request {:?} names no commit its checks are \
815 reported against",
816 change.id.0
817 ),
818 });
819 }
820 }
821 // Both of these are recorded *about* a change request, by `open_change` and
822 // by nothing else, and both are read back by the id they are keyed under. An
823 // entry for a change nobody opened is one no call could ever reach, so it is
824 // refused rather than carried — unlike the checks, logs, and merge outcomes
825 // below it, which a journey deliberately seeds for a change it has not
826 // opened yet.
827 for (id, head) in &self.heads {
828 opened_change(self, id, "a head")?;
829 named_branch(head, "the head of a seeded change request")?;
830 }
831 for (id, title) in &self.titles {
832 opened_change(self, id, "a title")?;
833 // The real host refuses a title that names nothing, so a seeded one is
834 // refused for the same reason.
835 titled(title)?;
836 }
837 for id in self.bodies.keys() {
838 // Nothing is refused about the body itself: a host places no shape on
839 // prose, and a change request opened with an empty one is a scenario.
840 opened_change(self, id, "a body")?;
841 }
842 for (id, reason) in &self.drafts {
843 opened_change(self, id, "a draft reason")?;
844 // The publication rule the crate next door states, applied rather than
845 // restated: a seeded reason no publication could have carried is refused
846 // where the document is read, not answered from later.
847 reason.checked()?;
848 }
849 for id in &self.made_ready {
850 opened_change(self, id, "a lifted draft")?;
851 }
852 for id in &self.awaiting_checks {
853 opened_change(self, id, "a draft awaiting its checks")?;
854 }
855 for described in &self.described {
856 opened_change(self, &described.id, "a description")?;
857 // The real host refuses a title that names nothing, so a seeded one is
858 // refused for the same reason — and a body is prose, refused for nothing.
859 if let Some(title) = &described.title {
860 titled(title)?;
861 }
862 }
863 Ok(())
864 }
865
866 /// A version 2 document held no bodies, and a version 5 document's checks named
867 /// no commit; each reads as what it was — change requests opened with none, and
868 /// checks whose head that build never recorded. There is nothing to fill in — an
869 /// absent field is already that answer, and a check's commit is the one thing
870 /// that must never be inferred — so this is the version and nothing else. The one
871 /// carry a version 8 document needs, the `kind` its draft reasons lack, is done
872 /// where those are read (`drafts_of_any_version`), because it is a fact about
873 /// one value's shape rather than about the document.
874 fn carry_forward(&mut self) {
875 self.version = STATE_VERSION;
876 }
877}
878
879/// Refuse a document written at a version this build does not read.
880///
881/// Named rather than guessed at: a state whose shape is a later build's reads one
882/// way here and another way where that version is understood, and for a seeded
883/// scenario those two readings are two different tests. The refusal names the
884/// range as well as the version, because "too old" and "too new" are two different
885/// things to do about it — one is a document to re-seed, the other a build to
886/// update.
887fn readable_version(declared: u32) -> Result<()> {
888 if !(OLDEST_READABLE_VERSION..=STATE_VERSION).contains(&declared) {
889 return Err(Error::Invalid {
890 reason: format!(
891 "the document declares version {declared}; this build reads versions \
892 {OLDEST_READABLE_VERSION} to {STATE_VERSION}"
893 ),
894 });
895 }
896 Ok(())
897}