onevcs_testing/state.rs
1//! What a provider knows, in a shape a journey can write down and read back.
2//!
3//! One state type per interface, shared by both flavours of it — the in-memory
4//! provider and the file-backed one differ in where the state lives and in nothing
5//! else, so a scenario seeded for one is the same scenario for the other.
6
7use std::collections::{BTreeMap, BTreeSet};
8
9use serde::{Deserialize, Serialize};
10
11use onevcs::{
12 ChangeId, ChangeRequest, Check, CheckSource, DraftReason, Error, Identity, Landed,
13 MergeOutcome, Recoverable, Result,
14};
15use onevcs::{MergePolicy, Publication, Session, SessionRequest, SessionToken};
16
17use crate::events;
18use crate::store::Checked;
19
20/// The version of the state document this build writes.
21///
22/// A file-backed state outlives the process that wrote it and is read by the next
23/// one, which makes it a stored contract like `onevcs`'s own registry document —
24/// and like that document, the version a document declares decides what is done
25/// with it rather than being guessed at. [`STATE_VERSION`] is the shape the goldens in
26/// `tests/golden/` hold, and those goldens are compared byte for byte, so a change
27/// to the document cannot reach a consumer without the diff saying so.
28///
29/// `2` was what both sides learned when publishing and closing a session came
30/// through the interface: [`VcsState::policy`], [`VcsState::closed_sessions`],
31/// [`VcsState::publications`], and [`HostState::titles`]. `3` is
32/// [`HostState::bodies`], the body a change request was opened with. `4` is the two
33/// fields a `Recoverable` gained inside [`VcsState::preserved`] — the live session
34/// holding a branch, and the lines it would land when it removes more than it adds.
35/// `5` is one more of those: whether the branch's work reached its base, and what
36/// says so. `6` is the two a `Check` gained inside [`HostState::checks`] — the
37/// commit the host attached that check to, and where the check is on the host. `7`
38/// is the two a draft change request needs — [`HostState::drafts`], the reason each
39/// change request was opened as a draft with, and [`HostState::made_ready`], the
40/// `ready_for_review` calls it took. `8` is the two an [`Identity`] inside
41/// [`VcsState::identities`] **lost** — `workflow` and `repo_type`, the registry's
42/// inferences from whether an origin had a host, which every decision they made now
43/// takes from the resolved publication policy instead. `9` is the draft reason inside
44/// [`HostState::drafts`] becoming one of two kinds and saying which — `kind` is
45/// `awaiting-release` or `held` — and [`HostState::described`], the descriptions a
46/// host was handed for a change request after it was opened. `10` is the failure
47/// vocabulary a publication's outcome inside [`VcsState::publications`] may name
48/// widening by one kind, `host-prerequisite` — no field moved, but a document naming
49/// it is one a version 9 build cannot read, and the version is how it says so.
50///
51/// **Every change to the document is versioned, an added field included.** A field
52/// that only ever appears when it holds something is *compatible* — that is what
53/// [`OLDEST_READABLE_VERSION`] is for — but compatible is not the same as
54/// unremarkable: the version is how a consumer's checked-in scenario says which
55/// shape it was written against, and a document that gained a field without saying
56/// so leaves nothing able to tell "this build wrote no body" from "this document
57/// predates bodies". The two answers differ for exactly the journey this crate
58/// exists to support.
59pub const STATE_VERSION: u32 = 10;
60
61/// The oldest document version this build reads.
62///
63/// Every version from here to [`STATE_VERSION`] is read and carried forward on the
64/// way in, which is how `onevcs`'s own registry document treats its older
65/// versions: what separates a readable older version from a refused one is whether
66/// its every field still means here what it meant there. `2` to `3` added a field
67/// and changed none, so a version 2 document reads as one whose change requests
68/// were opened with no body — which is what they were; `3` to `4` added two the same
69/// way, so a version 3 document reads as one whose preserved rows say nothing about a
70/// hold or a line count, which is what they said. `4` to `5` added one that every row
71/// answers rather than one that appears when it holds something, so a version 4
72/// document's rows are carried forward as the answer that list *was*: preserved work
73/// nobody published, which is work that did not land. `5` to `6` added two that
74/// appear only when they hold something, so a version 5 document's checks read as
75/// checks whose commit and address that build never recorded — which is what they
76/// were, and the one thing that must not be filled in from the change request's own
77/// head. `6` to `7` added two more of that kind, so a version 6 document reads as one
78/// whose change requests were opened before this crate could draft one — which is what
79/// they were: no draft reason recorded for any of them, and no lift ever asked for.
80/// `7` to `8` *removed* two from each identity, and a version 7 document reads past
81/// them: an identity is its origin and its gate here as it is in `onevcs`, and the two
82/// keys beside them are ones this build has no opinion on. `8` to `9` gave every
83/// draft reason a `kind`, and a reason written without one is read as the one kind
84/// there was — `awaiting-release`, whose four fields it carries unchanged — which is
85/// `drafts_of_any_version`'s whole job; the descriptions beside it are absent from a
86/// document written before them, which is the answer, since that build could describe
87/// nothing. `9` to `10` changed no field and no meaning: every failure kind a version 9
88/// document can hold is spelled here as it was there and means what it meant, so it
89/// reads unchanged and needs no carrying forward beyond its version.
90///
91/// `1` is refused rather than read for the opposite reason: it describes a provider
92/// that could not publish, and every session in it would read back as open — a
93/// wrong answer where a journey asserting on a session it had closed needs a
94/// refusal.
95pub const OLDEST_READABLE_VERSION: u32 = 2;
96
97/// Everything the repository side of a run knows about itself.
98///
99/// Every field is public and serializable, so a journey both seeds a scenario and
100/// asserts on what a run left behind. Everything but the version is omitted when
101/// it holds nothing, so a hand-written document names only the part of a scenario
102/// that matters — and a document written by a build that knew fewer fields still
103/// reads here.
104#[derive(Debug, Clone, Serialize, Deserialize)]
105#[serde(default)]
106pub struct VcsState {
107 /// The schema version this state was written at. A document that names none is
108 /// the one this build writes.
109 // llmlint: ignore[boundary_inputs_validated] deciding what to do with a version this
110 // build does not read is the whole of the check — and it is in `Checked::check` below,
111 // where a document is read, rather than here where serde only proves the shape.
112 pub version: u32,
113 /// The repository identities this provider can resolve. A
114 /// [`SessionRequest::repo`] naming none of them is refused, the way an
115 /// unregistered repository is.
116 #[serde(skip_serializing_if = "Vec::is_empty")]
117 pub identities: Vec<Identity>,
118 /// Every session opened or seeded, in the order they were opened.
119 #[serde(skip_serializing_if = "Vec::is_empty")]
120 pub sessions: Vec<Session>,
121 /// Which identity each session belongs to.
122 ///
123 /// Beyond the sketch this crate was specified from, and unavoidable: a
124 /// [`Session`] carries no identity, and a [`Recoverable`] must name one — so
125 /// preserving a session's branch could not answer the question `recoverable`
126 /// asks without this. `open_session` records it; nothing else writes it.
127 // llmlint: ignore[invalid_states_unrepresentable] an identity key is a `String`
128 // everywhere the crate this mirrors spells one — `Recoverable.identity`,
129 // `Identity.origin`, the registry document's own map key — and a newtype here would
130 // make a seeded state disagree with the types it is made of. Every value written to
131 // this map came out of `identity_of`, so it names an identity this provider holds.
132 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
133 pub session_identities: BTreeMap<SessionToken, String>,
134 /// Preserved work, newest last, as `recoverable` reports it.
135 ///
136 /// [`Recoverable`] rather than `PreservedBranch` — it *contains* the preserved
137 /// branch and adds the identity, the checkout, why the workstream stopped, and
138 /// the command that lands it, none of which are derivable from the branch
139 /// alone. One list rather than two that could disagree.
140 #[serde(skip_serializing_if = "Vec::is_empty")]
141 pub preserved: Vec<Recoverable>,
142 /// The sessions that have been closed. Every other session here is open.
143 ///
144 /// One way to say closed rather than two, so a scenario written by hand names
145 /// only the sessions whose lifecycle is not the one they were opened in.
146 // llmlint: ignore[invalid_states_unrepresentable] keyed by session token, exactly as
147 // `session_identities` above is and for the same reason: this document is a scenario
148 // somebody writes by hand, and a session is named once under `sessions` with the rest
149 // of the state keyed to it rather than nested inside a shape that could hold only one
150 // arrangement. A token here that names no opened session is refused in
151 // `Checked::check`, where the document is read — the same trust boundary every other
152 // cross-reference in it is checked at.
153 #[serde(skip_serializing_if = "BTreeSet::is_empty")]
154 pub closed_sessions: BTreeSet<SessionToken>,
155 /// The policy this provider publishes under.
156 ///
157 /// The answer a rules file gives the real implementation, which a provider has
158 /// none of — so a journey states it, and unset is the policy the contract's own
159 /// `default:` names ([`DEFAULT_PUBLICATION`](crate::DEFAULT_PUBLICATION)). A
160 /// per-run policy narrows it through [`MergePolicy::narrow`], which is the
161 /// rules system's rule rather than a restatement of it here.
162 #[serde(skip_serializing_if = "Option::is_none")]
163 pub policy: Option<MergePolicy>,
164 /// Every publication this provider performed, in the order it performed them.
165 ///
166 /// Both a record a journey asserts on and the answer to "has this session been
167 /// published already": a second publication of a session that landed has
168 /// nothing the base does not already carry, which is what the real
169 /// implementation reports for the same reason.
170 // llmlint: ignore[invalid_states_unrepresentable] this holds `onevcs::Publication`
171 // verbatim — the value `Vcs::publish` handed back, carrying its own session and branch
172 // — so a journey asserts on exactly what a caller would receive. A shape that made
173 // "this publication is of some other session's branch" unrepresentable could not hold
174 // that type, and would be a second spelling of the answer the crate next door already
175 // has. The cross-reference is checked in `Checked::check` instead, where the document
176 // is read.
177 #[serde(skip_serializing_if = "Vec::is_empty")]
178 pub publications: Vec<Publication>,
179}
180
181/// A repository side that knows nothing, at the version this build writes.
182impl Default for VcsState {
183 fn default() -> Self {
184 Self {
185 version: STATE_VERSION,
186 identities: Vec::new(),
187 sessions: Vec::new(),
188 session_identities: BTreeMap::new(),
189 preserved: Vec::new(),
190 closed_sessions: BTreeSet::new(),
191 policy: None,
192 publications: Vec::new(),
193 }
194 }
195}
196
197/// Everything the remote-host side of a run knows about itself.
198///
199/// Omitted-when-empty and versioned for the same reasons [`VcsState`] is.
200#[derive(Debug, Clone, Serialize, Deserialize)]
201#[serde(default)]
202pub struct HostState {
203 /// The schema version this state was written at. A document that names none is
204 /// the one this build writes.
205 // llmlint: ignore[boundary_inputs_validated] as on `VcsState::version`: the decision
206 // about an unreadable version is made in `Checked::check`, where the document is read.
207 pub version: u32,
208 /// Who the host says is calling. Empty is refused, exactly as a `gh` that
209 /// reports no authenticated user is.
210 // llmlint: ignore[invalid_states_unrepresentable] the interface this satisfies is
211 // `authenticated_user() -> Result<String>`, so the login is a `String` by contract and
212 // the one unusable value — a host that names nobody — is refused where it is read
213 // rather than made unrepresentable in a state a journey writes by hand.
214 pub authenticated_user: String,
215 /// Every change request that has been opened or seeded.
216 #[serde(skip_serializing_if = "Vec::is_empty")]
217 pub changes: Vec<ChangeRequest>,
218 /// The head branch each change request was opened from.
219 ///
220 /// Beyond the sketch, and unavoidable: [`ChangeRequest`] records only the base
221 /// it targets, and `find_changes` matches on the head as well.
222 // llmlint: ignore[invalid_states_unrepresentable] the matching `ChangeSpec.head` and
223 // `ChangeRequest.base` are `String` in the contract this mirrors, and a validated ref
224 // type here would disagree with them. Every value written to this map went through
225 // `addressable` in `open_change` first, which is the same refusal the real
226 // implementation makes at the same point.
227 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
228 pub heads: BTreeMap<ChangeId, String>,
229 /// The title each change request was opened under.
230 ///
231 /// Beyond the sketch, and for the same reason [`heads`](HostState::heads) is:
232 /// [`ChangeRequest`] records neither, and the title is what a publication's
233 /// commit subject becomes — so a journey asserting that the subject it asked
234 /// for is the one the host was given has nowhere else to read it.
235 // llmlint: ignore[invalid_states_unrepresentable] this records the `ChangeSpec.title`
236 // the contract fixes as a `String`, so a validated type here would disagree with the
237 // one it mirrors. `Subject` is not that type: it is `onevcs`'s rule for a *commit
238 // subject*, and a host's own limit is its own — spelling it here would
239 // refuse a seeded title a real host accepts, which is drift in the direction that
240 // looks like rigour. What the host itself refuses is a title that names nothing, and
241 // that is refused below and in `open_change`, at the boundary the value arrives at.
242 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
243 pub titles: BTreeMap<ChangeId, String>,
244 /// The body each change request was opened with, for the change requests that
245 /// were opened with one.
246 ///
247 /// Beside [`titles`](HostState::titles) and for its reason: the body is what a
248 /// caller passes on the `PublishRequest` and nothing else records it, so a
249 /// journey asserting that the body it drafted is the one the host was given has
250 /// nowhere else to read it. A change request with no entry was opened with no
251 /// body at all, which is what a publication nobody gave one does — the two are
252 /// different scenarios, and an empty string is the first rather than the second.
253 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
254 pub bodies: BTreeMap<ChangeId, String>,
255 /// The checks the host reports on each change request. A change with no entry
256 /// has no checks, which is what a repository with no CI reports.
257 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
258 pub checks: BTreeMap<ChangeId, Vec<Check>>,
259 /// The log the host hands over for a check, keyed by change request and then by
260 /// check name. Beyond the sketch: `check_log` is one of the six methods, and
261 /// without this the only log a journey could asssert on is a synthesized one.
262 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
263 pub check_logs: BTreeMap<ChangeId, BTreeMap<String, String>>,
264 /// The reason each change request that was opened as a **draft** was drafted
265 /// with, for the change requests that were.
266 ///
267 /// Beside [`bodies`](HostState::bodies) and for its reason: the reason is what a
268 /// caller passes on the `PublishRequest` and this is where a journey reads back
269 /// that the host was given it. A change with no entry is not a draft, which is
270 /// what every change request opened without one is.
271 ///
272 /// Nothing is refused about the reason itself here. Its shape — that every field
273 /// of it renders as the one line it is printed on — is `onevcs`'s own rule, and
274 /// it is applied where a publication takes one in, before any host is asked.
275 #[serde(
276 skip_serializing_if = "BTreeMap::is_empty",
277 deserialize_with = "drafts_of_any_version"
278 )]
279 pub drafts: BTreeMap<ChangeId, DraftReason>,
280 /// Every `ready_for_review` call this host has taken, in the order it took them
281 /// — the lifts it was asked to perform, never a request for a *reviewer*.
282 ///
283 /// A list rather than a set, and beyond the sketch for a reason a set could not
284 /// serve: lifting a draft is required to be *idempotent*, so what a journey
285 /// asserts is that a second publication asked the host for nothing — and only a
286 /// record of the calls themselves can say that. A change named here is not a
287 /// draft any more, whatever [`drafts`](HostState::drafts) says it was opened as.
288 #[serde(skip_serializing_if = "Vec::is_empty")]
289 pub made_ready: Vec<ChangeId>,
290 /// Every `describe_change` call this host has taken, in the order it took them:
291 /// which change request, the title it was handed when it was handed one, and the
292 /// body.
293 ///
294 /// The calls themselves, for the reason [`made_ready`](HostState::made_ready) is:
295 /// what a journey asks is what a closeout *wrote*, call by call, and the current
296 /// title and body — which each call also writes into
297 /// [`titles`](HostState::titles) and [`bodies`](HostState::bodies), so
298 /// `change_description` answers from the same record `open_change` wrote — can
299 /// only say where the description ended up.
300 #[serde(skip_serializing_if = "Vec::is_empty")]
301 pub described: Vec<Described>,
302 /// Which sources this host answers about its checks from, which is what the
303 /// real implementation reports alongside them.
304 ///
305 /// Unset is a credential allowed to read everything: the whole rollup, exactly
306 /// what a host with nothing to hide reports. A journey states a narrower set to
307 /// be the credential the real one meets in CI — a fine-grained token, which
308 /// cannot read check runs at all and sees GitHub Actions and nothing else — and
309 /// states an *empty* one to be a credential that can read no source at all,
310 /// which is a refusal rather than "no checks". Unset and empty are therefore
311 /// different scenarios, which is why this is an `Option` rather than a set whose
312 /// emptiness means "not stated".
313 #[serde(skip_serializing_if = "Option::is_none")]
314 pub check_sources: Option<BTreeSet<CheckSource>>,
315 /// What merging each change request did.
316 ///
317 /// Both a script and a record: an entry seeded here is what `merge` answers,
318 /// whatever the policy asks for — which is how a journey expresses a host that
319 /// queues or refuses — and a merge the policy decided is written back here.
320 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
321 pub merges: BTreeMap<ChangeId, MergeOutcome>,
322}
323
324/// One description a host was handed for a change request after it was opened.
325///
326/// What `RemoteHost::describe_change` was given, verbatim: the title only where the
327/// call carried one, because a call that replaced the body alone left the title as
328/// it was, and a record that filled it in would say the caller wrote a title nobody
329/// wrote.
330// llmlint: ignore[invalid_states_unrepresentable] the title and body are the `&str`s the
331// seam hands over — a host places no shape on prose, and `onevcs`'s own `Subject` rule
332// was applied where the description was composed, before any host was asked.
333#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
334pub struct Described {
335 /// The change request the description was written to.
336 pub id: ChangeId,
337 /// The title the call replaced the change request's with, when it replaced one.
338 #[serde(default, skip_serializing_if = "Option::is_none")]
339 pub title: Option<String>,
340 /// The body the call replaced the change request's with.
341 pub body: String,
342}
343
344/// The `drafts` map of a document at any readable version.
345///
346/// A document written before version 9 spells a draft reason as the four fields of
347/// the one kind there was and no `kind` beside them; this build's reason is one of
348/// two kinds and says which. So a reason arriving without a `kind` is read as
349/// `awaiting-release` — exactly what it was — rather than refused, which is what
350/// keeps a consumer's checked-in scenario readable across the bump. A reason that
351/// *names* a kind is read as it names it, so nothing written by this build is
352/// reinterpreted.
353fn drafts_of_any_version<'de, D>(
354 deserializer: D,
355) -> std::result::Result<BTreeMap<ChangeId, DraftReason>, D::Error>
356where
357 D: serde::Deserializer<'de>,
358{
359 let raw: BTreeMap<ChangeId, serde_json::Map<String, serde_json::Value>> =
360 Deserialize::deserialize(deserializer)?;
361 raw.into_iter()
362 .map(|(id, mut fields)| {
363 fields
364 .entry("kind")
365 .or_insert_with(|| serde_json::Value::from("awaiting-release"));
366 serde_json::from_value::<DraftReason>(serde_json::Value::Object(fields))
367 .map(|reason| (id, reason))
368 .map_err(serde::de::Error::custom)
369 })
370 .collect()
371}
372
373/// Who a host with nothing seeded says is calling.
374///
375/// A host that answers nobody is refused by the real implementation, so a default
376/// state that answered nobody would be a provider that cannot run a publication
377/// until it is configured.
378pub const DEFAULT_AUTHENTICATED_USER: &str = "onevcs-testing";
379
380impl Default for HostState {
381 fn default() -> Self {
382 Self {
383 version: STATE_VERSION,
384 authenticated_user: DEFAULT_AUTHENTICATED_USER.to_owned(),
385 changes: Vec::new(),
386 heads: BTreeMap::new(),
387 titles: BTreeMap::new(),
388 bodies: BTreeMap::new(),
389 drafts: BTreeMap::new(),
390 made_ready: Vec::new(),
391 described: Vec::new(),
392 checks: BTreeMap::new(),
393 check_logs: BTreeMap::new(),
394 check_sources: None,
395 merges: BTreeMap::new(),
396 }
397 }
398}
399
400/// The identity a session request names, or the reason none of them is it.
401///
402/// Three ways to name one, mirroring what the registry accepts: the identity key
403/// itself, the `owner/name` tail of it, or the bare repository name.
404pub(crate) fn identity_of<'a>(state: &'a VcsState, origin_or_path: &str) -> Option<&'a Identity> {
405 let wanted = origin_or_path.trim_end_matches('/');
406 state
407 .identities
408 .iter()
409 .find(|identity| identity.origin == wanted)
410 .or_else(|| {
411 state.identities.iter().find(|identity| {
412 identity
413 .origin
414 .rsplit('/')
415 .next()
416 .is_some_and(|name| name == wanted)
417 || identity.origin.ends_with(&format!("/{wanted}"))
418 })
419 })
420}
421
422/// The known identities, as a refusal names them.
423pub(crate) fn known(state: &VcsState) -> String {
424 if state.identities.is_empty() {
425 return "this provider was seeded with no identities".to_owned();
426 }
427 let names: Vec<&str> = state
428 .identities
429 .iter()
430 .map(|identity| identity.origin.as_str())
431 .collect();
432 format!("it knows {}", names.join(", "))
433}
434
435/// The identity a session belongs to, or the reason this provider cannot say.
436///
437/// `open_session` records it and nothing else writes it, so a session that arrived
438/// in a hand-written scenario without one is refused here rather than published
439/// against a repository nobody named.
440pub(crate) fn identity_for(state: &VcsState, token: &SessionToken) -> Result<String> {
441 state
442 .session_identities
443 .get(token)
444 .cloned()
445 .ok_or_else(|| Error::Invalid {
446 reason: format!(
447 "this provider has no record of session {:?}, so it cannot say which identity \
448 its work belongs to",
449 token.0
450 ),
451 })
452}
453
454/// The session a token names.
455pub(crate) fn session_of<'a>(state: &'a VcsState, token: &SessionToken) -> Option<&'a Session> {
456 state
457 .sessions
458 .iter()
459 .find(|session| session.token == *token)
460}
461
462/// The branch a request asks for, or the one that is derived from the token.
463pub(crate) fn requested_branch(req: &SessionRequest, token: &SessionToken) -> Result<String> {
464 let name = req
465 .branch
466 .clone()
467 .unwrap_or_else(|| format!("onevcs/{}", token.0));
468 named_branch(&name, "the branch")?;
469 Ok(name)
470}
471
472/// A branch name, refused here if git would refuse it.
473///
474/// The real implementation asks `git check-ref-format`, which is the parser that
475/// decides; a provider with no git carries `git-check-ref-format(1)`'s rules
476/// instead. That is a restatement, so it is gated rather than trusted:
477/// `refs.rs` in the suite runs both this and git itself over a table of names
478/// and holds them to each other, because a copy of somebody else's grammar with
479/// no gate is a copy that drifts.
480///
481/// One deliberate difference, and the gate knows about it: a leading `-` is
482/// refused here even though git accepts it as a ref, because such a name reaches
483/// a command line as an option rather than as the branch it spells.
484pub(crate) fn named_branch(value: &str, what: &str) -> Result<()> {
485 // Rule 1 is per slash-separated component; the rest are about the whole name.
486 let components_usable = !value.is_empty()
487 && value.split('/').all(|component| {
488 !component.is_empty() && !component.starts_with('.') && !component.ends_with(".lock")
489 });
490 let usable = components_usable
491 && !value.starts_with('-')
492 && !value.contains("..")
493 && !value.contains("@{")
494 && !value.ends_with('.')
495 && !value.ends_with('/')
496 && !value.chars().any(|c| {
497 c.is_whitespace() || c.is_ascii_control() || c == '\u{7f}' || "~^:?*[\\".contains(c)
498 });
499 if !usable {
500 return Err(Error::Invalid {
501 reason: format!("{what} {value:?} is a name git would not accept"),
502 });
503 }
504 Ok(())
505}
506
507/// A seeded repository side is refused if it holds a session nothing could act on.
508impl Checked for VcsState {
509 fn check(&self) -> Result<()> {
510 readable_version(self.version)?;
511 for session in &self.sessions {
512 // The token names a file under the state root, and a branch goes on to
513 // spell a ref; both arrive from whoever wrote the document.
514 if !events::is_safe_name(&session.token.0) {
515 return Err(Error::Invalid {
516 reason: format!("{:?} is not a session token", session.token.0),
517 });
518 }
519 named_branch(&session.branch, "the branch")?;
520 named_branch(&session.base, "the base")?;
521 }
522 for row in &self.preserved {
523 known_identity(self, &row.identity, "preserved work")?;
524 named_branch(&row.branch.branch, "the preserved branch")?;
525 named_branch(&row.branch.base, "the preserved branch's base")?;
526 // The hold names a session, so it is checked like the three below: a row
527 // held by a session nobody opened is the same fiction, and the costly one
528 // — it is the session an operator is told to wait for or close.
529 if let Some(held) = &row.held_by {
530 opened(self, &held.token, "holding preserved work")?;
531 }
532 }
533 // Both of these name a session, so both are checked twice over: the token
534 // has to be a plain name, because it goes on to spell the file its stream is
535 // written in, and it has to name a session this state actually holds. A
536 // document that closes or publishes a session nobody opened describes a run
537 // that could not have happened, and answering `recoverable` or `session`
538 // from it would be answering from a fiction rather than refusing one.
539 for token in &self.closed_sessions {
540 opened(self, token, "closed")?;
541 }
542 for (token, origin) in &self.session_identities {
543 opened(self, token, "given an identity")?;
544 // The value as well as the key: this is what `identity_for` answers with,
545 // and it goes on to spell the slug a change request is opened against and
546 // the label every one of that session's events carries. An identity this
547 // provider does not know is one it could not have opened the session for.
548 known_identity(self, origin, &format!("session {:?}", token.0))?;
549 }
550 for publication in &self.publications {
551 let session = opened(self, &publication.session, "published")?;
552 named_branch(&publication.branch, "the published branch")?;
553 // A publication of some other branch than the one the session is on is
554 // the same kind of fiction, and the harder one to spot afterwards: the
555 // branch is what a journey asserts the publication was of.
556 if publication.branch != session.branch {
557 return Err(Error::Invalid {
558 reason: format!(
559 "the publication of session {:?} names branch {:?}, but that session is \
560 on {:?}",
561 publication.session.0, publication.branch, session.branch
562 ),
563 });
564 }
565 }
566 Ok(())
567 }
568
569 /// Every field an older readable document could hold means here what it meant
570 /// there, and the two the repository side gained in version 4 are absent from one
571 /// written before them — which is the answer, since that build held no hold and
572 /// counted no lines.
573 ///
574 /// Version 5's field is the exception, and it is carried rather than left at its
575 /// default: a document written before it *listed preserved work nobody had
576 /// published*, which is the `no` this build spells out. Left at the default it
577 /// would read as "nothing here can say", and a consumer's checked-in scenario
578 /// would start reporting work it had always called unpublished as work that may
579 /// have landed.
580 fn carry_forward(&mut self) {
581 if self.version < 5 {
582 for row in &mut self.preserved {
583 row.landed = Landed::No;
584 }
585 }
586 self.version = STATE_VERSION;
587 }
588}
589
590/// Refuse a record kept about a change request this state does not hold.
591fn opened_change(state: &HostState, id: &ChangeId, what: &str) -> Result<()> {
592 if state.changes.iter().any(|change| change.id == *id) {
593 return Ok(());
594 }
595 Err(Error::Invalid {
596 reason: format!(
597 "{what} is recorded for change request {:?}, but no change request by that \
598 identifier was opened",
599 id.0
600 ),
601 })
602}
603
604/// Refuse an identity key this provider was not seeded with.
605fn known_identity(state: &VcsState, origin: &str, what: &str) -> Result<()> {
606 if state
607 .identities
608 .iter()
609 .any(|identity| identity.origin == origin)
610 {
611 return Ok(());
612 }
613 Err(Error::Invalid {
614 reason: format!(
615 "{what} belongs to identity {origin:?}, which this provider does not know; {}",
616 known(state)
617 ),
618 })
619}
620
621/// A change request's title, refused when it names nothing.
622///
623/// The one thing a real host refuses about a title, and the only one this provider
624/// may: how long a title may be is the host's own rule rather than `onevcs`'s
625/// commit-subject rule, and a provider applying the stricter of the two would
626/// refuse what the host it stands in for accepts.
627pub(crate) fn titled(title: &str) -> Result<()> {
628 if title.trim().is_empty() {
629 return Err(Error::Invalid {
630 reason: "a change request's title is blank, so it names no change".to_owned(),
631 });
632 }
633 Ok(())
634}
635
636/// The session a token names, refused when this state does not hold one.
637fn opened<'a>(state: &'a VcsState, token: &SessionToken, what: &str) -> Result<&'a Session> {
638 if !events::is_safe_name(&token.0) {
639 return Err(Error::Invalid {
640 reason: format!("{:?} is not a session token", token.0),
641 });
642 }
643 session_of(state, token).ok_or_else(|| Error::Invalid {
644 reason: format!(
645 "session {:?} is {what} here, but no session by that token was opened",
646 token.0
647 ),
648 })
649}
650
651/// A seeded host side is refused if it holds a change nothing could address.
652impl Checked for HostState {
653 fn check(&self) -> Result<()> {
654 readable_version(self.version)?;
655 for change in &self.changes {
656 named_branch(&change.base, "the base of a seeded change request")?;
657 if change.id.0.is_empty() {
658 return Err(Error::Invalid {
659 reason: "a seeded change request carries no identifier".to_owned(),
660 });
661 }
662 // The commit a change request's checks are reported against is the whole
663 // evidence that a change reached anything, and the real implementation
664 // refuses a host answer that names none rather than passing a blank one
665 // through. A seeded one is refused for the same reason.
666 if change.head_sha.0.trim().is_empty() {
667 return Err(Error::Invalid {
668 reason: format!(
669 "the seeded change request {:?} names no commit its checks are \
670 reported against",
671 change.id.0
672 ),
673 });
674 }
675 }
676 // Both of these are recorded *about* a change request, by `open_change` and
677 // by nothing else, and both are read back by the id they are keyed under. An
678 // entry for a change nobody opened is one no call could ever reach, so it is
679 // refused rather than carried — unlike the checks, logs, and merge outcomes
680 // below it, which a journey deliberately seeds for a change it has not
681 // opened yet.
682 for (id, head) in &self.heads {
683 opened_change(self, id, "a head")?;
684 named_branch(head, "the head of a seeded change request")?;
685 }
686 for (id, title) in &self.titles {
687 opened_change(self, id, "a title")?;
688 // The real host refuses a title that names nothing, so a seeded one is
689 // refused for the same reason.
690 titled(title)?;
691 }
692 for id in self.bodies.keys() {
693 // Nothing is refused about the body itself: a host places no shape on
694 // prose, and a change request opened with an empty one is a scenario.
695 opened_change(self, id, "a body")?;
696 }
697 for (id, reason) in &self.drafts {
698 opened_change(self, id, "a draft reason")?;
699 // The publication rule the crate next door states, applied rather than
700 // restated: a seeded reason no publication could have carried is refused
701 // where the document is read, not answered from later.
702 reason.checked()?;
703 }
704 for id in &self.made_ready {
705 opened_change(self, id, "a lifted draft")?;
706 }
707 for described in &self.described {
708 opened_change(self, &described.id, "a description")?;
709 // The real host refuses a title that names nothing, so a seeded one is
710 // refused for the same reason — and a body is prose, refused for nothing.
711 if let Some(title) = &described.title {
712 titled(title)?;
713 }
714 }
715 Ok(())
716 }
717
718 /// A version 2 document held no bodies, and a version 5 document's checks named
719 /// no commit; each reads as what it was — change requests opened with none, and
720 /// checks whose head that build never recorded. There is nothing to fill in — an
721 /// absent field is already that answer, and a check's commit is the one thing
722 /// that must never be inferred — so this is the version and nothing else. The one
723 /// carry a version 8 document needs, the `kind` its draft reasons lack, is done
724 /// where those are read (`drafts_of_any_version`), because it is a fact about
725 /// one value's shape rather than about the document.
726 fn carry_forward(&mut self) {
727 self.version = STATE_VERSION;
728 }
729}
730
731/// Refuse a document written at a version this build does not read.
732///
733/// Named rather than guessed at: a state whose shape is a later build's reads one
734/// way here and another way where that version is understood, and for a seeded
735/// scenario those two readings are two different tests. The refusal names the
736/// range as well as the version, because "too old" and "too new" are two different
737/// things to do about it — one is a document to re-seed, the other a build to
738/// update.
739fn readable_version(declared: u32) -> Result<()> {
740 if !(OLDEST_READABLE_VERSION..=STATE_VERSION).contains(&declared) {
741 return Err(Error::Invalid {
742 reason: format!(
743 "the document declares version {declared}; this build reads versions \
744 {OLDEST_READABLE_VERSION} to {STATE_VERSION}"
745 ),
746 });
747 }
748 Ok(())
749}