onevcs_testing/state.rs
1//! What a provider knows, in a shape a journey can write down and read back.
2//!
3//! One state type per interface, shared by both flavours of it — the in-memory
4//! provider and the file-backed one differ in where the state lives and in nothing
5//! else, so a scenario seeded for one is the same scenario for the other.
6
7use std::collections::{BTreeMap, BTreeSet};
8
9use serde::{Deserialize, Serialize};
10
11use onevcs::{
12 ChangeId, ChangeRequest, Check, CheckSource, DraftReason, Error, Identity, Landed,
13 MergeOutcome, Recoverable, Result,
14};
15use onevcs::{MergePolicy, Publication, Session, SessionRequest, SessionToken};
16
17use crate::events;
18use crate::store::Checked;
19
20/// The version of the state document this build writes.
21///
22/// A file-backed state outlives the process that wrote it and is read by the next
23/// one, which makes it a stored contract like `onevcs`'s own registry document —
24/// and like that document, the version a document declares decides what is done
25/// with it rather than being guessed at. [`STATE_VERSION`] is the shape the goldens in
26/// `tests/golden/` hold, and those goldens are compared byte for byte, so a change
27/// to the document cannot reach a consumer without the diff saying so.
28///
29/// `2` was what both sides learned when publishing and closing a session came
30/// through the interface: [`VcsState::policy`], [`VcsState::closed_sessions`],
31/// [`VcsState::publications`], and [`HostState::titles`]. `3` is
32/// [`HostState::bodies`], the body a change request was opened with. `4` is the two
33/// fields a `Recoverable` gained inside [`VcsState::preserved`] — the live session
34/// holding a branch, and the lines it would land when it removes more than it adds.
35/// `5` is one more of those: whether the branch's work reached its base, and what
36/// says so. `6` is the two a `Check` gained inside [`HostState::checks`] — the
37/// commit the host attached that check to, and where the check is on the host. `7`
38/// is the two a draft change request needs — [`HostState::drafts`], the reason each
39/// change request was opened as a draft with, and [`HostState::made_ready`], the
40/// `ready_for_review` calls it took. `8` is the two an [`Identity`] inside
41/// [`VcsState::identities`] **lost** — `workflow` and `repo_type`, the registry's
42/// inferences from whether an origin had a host, which every decision they made now
43/// takes from the resolved publication policy instead.
44///
45/// **Every change to the document is versioned, an added field included.** A field
46/// that only ever appears when it holds something is *compatible* — that is what
47/// [`OLDEST_READABLE_VERSION`] is for — but compatible is not the same as
48/// unremarkable: the version is how a consumer's checked-in scenario says which
49/// shape it was written against, and a document that gained a field without saying
50/// so leaves nothing able to tell "this build wrote no body" from "this document
51/// predates bodies". The two answers differ for exactly the journey this crate
52/// exists to support.
53pub const STATE_VERSION: u32 = 8;
54
55/// The oldest document version this build reads.
56///
57/// Every version from here to [`STATE_VERSION`] is read and carried forward on the
58/// way in, which is how `onevcs`'s own registry document treats its older
59/// versions: what separates a readable older version from a refused one is whether
60/// its every field still means here what it meant there. `2` to `3` added a field
61/// and changed none, so a version 2 document reads as one whose change requests
62/// were opened with no body — which is what they were; `3` to `4` added two the same
63/// way, so a version 3 document reads as one whose preserved rows say nothing about a
64/// hold or a line count, which is what they said. `4` to `5` added one that every row
65/// answers rather than one that appears when it holds something, so a version 4
66/// document's rows are carried forward as the answer that list *was*: preserved work
67/// nobody published, which is work that did not land. `5` to `6` added two that
68/// appear only when they hold something, so a version 5 document's checks read as
69/// checks whose commit and address that build never recorded — which is what they
70/// were, and the one thing that must not be filled in from the change request's own
71/// head. `6` to `7` added two more of that kind, so a version 6 document reads as one
72/// whose change requests were opened before this crate could draft one — which is what
73/// they were: no draft reason recorded for any of them, and no lift ever asked for.
74/// `7` to `8` *removed* two from each identity, and a version 7 document reads past
75/// them: an identity is its origin and its gate here as it is in `onevcs`, and the two
76/// keys beside them are ones this build has no opinion on.
77///
78/// `1` is refused rather than read for the opposite reason: it describes a provider
79/// that could not publish, and every session in it would read back as open — a
80/// wrong answer where a journey asserting on a session it had closed needs a
81/// refusal.
82pub const OLDEST_READABLE_VERSION: u32 = 2;
83
84/// Everything the repository side of a run knows about itself.
85///
86/// Every field is public and serializable, so a journey both seeds a scenario and
87/// asserts on what a run left behind. Everything but the version is omitted when
88/// it holds nothing, so a hand-written document names only the part of a scenario
89/// that matters — and a document written by a build that knew fewer fields still
90/// reads here.
91#[derive(Debug, Clone, Serialize, Deserialize)]
92#[serde(default)]
93pub struct VcsState {
94 /// The schema version this state was written at. A document that names none is
95 /// the one this build writes.
96 // llmlint: ignore[boundary_inputs_validated] deciding what to do with a version this
97 // build does not read is the whole of the check — and it is in `Checked::check` below,
98 // where a document is read, rather than here where serde only proves the shape.
99 pub version: u32,
100 /// The repository identities this provider can resolve. A
101 /// [`SessionRequest::repo`] naming none of them is refused, the way an
102 /// unregistered repository is.
103 #[serde(skip_serializing_if = "Vec::is_empty")]
104 pub identities: Vec<Identity>,
105 /// Every session opened or seeded, in the order they were opened.
106 #[serde(skip_serializing_if = "Vec::is_empty")]
107 pub sessions: Vec<Session>,
108 /// Which identity each session belongs to.
109 ///
110 /// Beyond the sketch this crate was specified from, and unavoidable: a
111 /// [`Session`] carries no identity, and a [`Recoverable`] must name one — so
112 /// preserving a session's branch could not answer the question `recoverable`
113 /// asks without this. `open_session` records it; nothing else writes it.
114 // llmlint: ignore[invalid_states_unrepresentable] an identity key is a `String`
115 // everywhere the crate this mirrors spells one — `Recoverable.identity`,
116 // `Identity.origin`, the registry document's own map key — and a newtype here would
117 // make a seeded state disagree with the types it is made of. Every value written to
118 // this map came out of `identity_of`, so it names an identity this provider holds.
119 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
120 pub session_identities: BTreeMap<SessionToken, String>,
121 /// Preserved work, newest last, as `recoverable` reports it.
122 ///
123 /// [`Recoverable`] rather than `PreservedBranch` — it *contains* the preserved
124 /// branch and adds the identity, the checkout, why the workstream stopped, and
125 /// the command that lands it, none of which are derivable from the branch
126 /// alone. One list rather than two that could disagree.
127 #[serde(skip_serializing_if = "Vec::is_empty")]
128 pub preserved: Vec<Recoverable>,
129 /// The sessions that have been closed. Every other session here is open.
130 ///
131 /// One way to say closed rather than two, so a scenario written by hand names
132 /// only the sessions whose lifecycle is not the one they were opened in.
133 // llmlint: ignore[invalid_states_unrepresentable] keyed by session token, exactly as
134 // `session_identities` above is and for the same reason: this document is a scenario
135 // somebody writes by hand, and a session is named once under `sessions` with the rest
136 // of the state keyed to it rather than nested inside a shape that could hold only one
137 // arrangement. A token here that names no opened session is refused in
138 // `Checked::check`, where the document is read — the same trust boundary every other
139 // cross-reference in it is checked at.
140 #[serde(skip_serializing_if = "BTreeSet::is_empty")]
141 pub closed_sessions: BTreeSet<SessionToken>,
142 /// The policy this provider publishes under.
143 ///
144 /// The answer a rules file gives the real implementation, which a provider has
145 /// none of — so a journey states it, and unset is the policy the contract's own
146 /// `default:` names ([`DEFAULT_PUBLICATION`](crate::DEFAULT_PUBLICATION)). A
147 /// per-run policy narrows it through [`MergePolicy::narrow`], which is the
148 /// rules system's rule rather than a restatement of it here.
149 #[serde(skip_serializing_if = "Option::is_none")]
150 pub policy: Option<MergePolicy>,
151 /// Every publication this provider performed, in the order it performed them.
152 ///
153 /// Both a record a journey asserts on and the answer to "has this session been
154 /// published already": a second publication of a session that landed has
155 /// nothing the base does not already carry, which is what the real
156 /// implementation reports for the same reason.
157 // llmlint: ignore[invalid_states_unrepresentable] this holds `onevcs::Publication`
158 // verbatim — the value `Vcs::publish` handed back, carrying its own session and branch
159 // — so a journey asserts on exactly what a caller would receive. A shape that made
160 // "this publication is of some other session's branch" unrepresentable could not hold
161 // that type, and would be a second spelling of the answer the crate next door already
162 // has. The cross-reference is checked in `Checked::check` instead, where the document
163 // is read.
164 #[serde(skip_serializing_if = "Vec::is_empty")]
165 pub publications: Vec<Publication>,
166}
167
168/// A repository side that knows nothing, at the version this build writes.
169impl Default for VcsState {
170 fn default() -> Self {
171 Self {
172 version: STATE_VERSION,
173 identities: Vec::new(),
174 sessions: Vec::new(),
175 session_identities: BTreeMap::new(),
176 preserved: Vec::new(),
177 closed_sessions: BTreeSet::new(),
178 policy: None,
179 publications: Vec::new(),
180 }
181 }
182}
183
184/// Everything the remote-host side of a run knows about itself.
185///
186/// Omitted-when-empty and versioned for the same reasons [`VcsState`] is.
187#[derive(Debug, Clone, Serialize, Deserialize)]
188#[serde(default)]
189pub struct HostState {
190 /// The schema version this state was written at. A document that names none is
191 /// the one this build writes.
192 // llmlint: ignore[boundary_inputs_validated] as on `VcsState::version`: the decision
193 // about an unreadable version is made in `Checked::check`, where the document is read.
194 pub version: u32,
195 /// Who the host says is calling. Empty is refused, exactly as a `gh` that
196 /// reports no authenticated user is.
197 // llmlint: ignore[invalid_states_unrepresentable] the interface this satisfies is
198 // `authenticated_user() -> Result<String>`, so the login is a `String` by contract and
199 // the one unusable value — a host that names nobody — is refused where it is read
200 // rather than made unrepresentable in a state a journey writes by hand.
201 pub authenticated_user: String,
202 /// Every change request that has been opened or seeded.
203 #[serde(skip_serializing_if = "Vec::is_empty")]
204 pub changes: Vec<ChangeRequest>,
205 /// The head branch each change request was opened from.
206 ///
207 /// Beyond the sketch, and unavoidable: [`ChangeRequest`] records only the base
208 /// it targets, and `find_changes` matches on the head as well.
209 // llmlint: ignore[invalid_states_unrepresentable] the matching `ChangeSpec.head` and
210 // `ChangeRequest.base` are `String` in the contract this mirrors, and a validated ref
211 // type here would disagree with them. Every value written to this map went through
212 // `addressable` in `open_change` first, which is the same refusal the real
213 // implementation makes at the same point.
214 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
215 pub heads: BTreeMap<ChangeId, String>,
216 /// The title each change request was opened under.
217 ///
218 /// Beyond the sketch, and for the same reason [`heads`](HostState::heads) is:
219 /// [`ChangeRequest`] records neither, and the title is what a publication's
220 /// commit subject becomes — so a journey asserting that the subject it asked
221 /// for is the one the host was given has nowhere else to read it.
222 // llmlint: ignore[invalid_states_unrepresentable] this records the `ChangeSpec.title`
223 // the contract fixes as a `String`, so a validated type here would disagree with the
224 // one it mirrors. `Subject` is not that type: it is `onevcs`'s rule for a *commit
225 // subject*, and a host's own limit is its own — spelling it here would
226 // refuse a seeded title a real host accepts, which is drift in the direction that
227 // looks like rigour. What the host itself refuses is a title that names nothing, and
228 // that is refused below and in `open_change`, at the boundary the value arrives at.
229 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
230 pub titles: BTreeMap<ChangeId, String>,
231 /// The body each change request was opened with, for the change requests that
232 /// were opened with one.
233 ///
234 /// Beside [`titles`](HostState::titles) and for its reason: the body is what a
235 /// caller passes on the `PublishRequest` and nothing else records it, so a
236 /// journey asserting that the body it drafted is the one the host was given has
237 /// nowhere else to read it. A change request with no entry was opened with no
238 /// body at all, which is what a publication nobody gave one does — the two are
239 /// different scenarios, and an empty string is the first rather than the second.
240 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
241 pub bodies: BTreeMap<ChangeId, String>,
242 /// The checks the host reports on each change request. A change with no entry
243 /// has no checks, which is what a repository with no CI reports.
244 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
245 pub checks: BTreeMap<ChangeId, Vec<Check>>,
246 /// The log the host hands over for a check, keyed by change request and then by
247 /// check name. Beyond the sketch: `check_log` is one of the six methods, and
248 /// without this the only log a journey could asssert on is a synthesized one.
249 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
250 pub check_logs: BTreeMap<ChangeId, BTreeMap<String, String>>,
251 /// The reason each change request that was opened as a **draft** was drafted
252 /// with, for the change requests that were.
253 ///
254 /// Beside [`bodies`](HostState::bodies) and for its reason: the reason is what a
255 /// caller passes on the `PublishRequest` and this is where a journey reads back
256 /// that the host was given it. A change with no entry is not a draft, which is
257 /// what every change request opened without one is.
258 ///
259 /// Nothing is refused about the reason itself here. Its shape — that every field
260 /// of it renders as the one line it is printed on — is `onevcs`'s own rule, and
261 /// it is applied where a publication takes one in, before any host is asked.
262 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
263 pub drafts: BTreeMap<ChangeId, DraftReason>,
264 /// Every `ready_for_review` call this host has taken, in the order it took them
265 /// — the lifts it was asked to perform, never a request for a *reviewer*.
266 ///
267 /// A list rather than a set, and beyond the sketch for a reason a set could not
268 /// serve: lifting a draft is required to be *idempotent*, so what a journey
269 /// asserts is that a second publication asked the host for nothing — and only a
270 /// record of the calls themselves can say that. A change named here is not a
271 /// draft any more, whatever [`drafts`](HostState::drafts) says it was opened as.
272 #[serde(skip_serializing_if = "Vec::is_empty")]
273 pub made_ready: Vec<ChangeId>,
274 /// Which sources this host answers about its checks from, which is what the
275 /// real implementation reports alongside them.
276 ///
277 /// Unset is a credential allowed to read everything: the whole rollup, exactly
278 /// what a host with nothing to hide reports. A journey states a narrower set to
279 /// be the credential the real one meets in CI — a fine-grained token, which
280 /// cannot read check runs at all and sees GitHub Actions and nothing else — and
281 /// states an *empty* one to be a credential that can read no source at all,
282 /// which is a refusal rather than "no checks". Unset and empty are therefore
283 /// different scenarios, which is why this is an `Option` rather than a set whose
284 /// emptiness means "not stated".
285 #[serde(skip_serializing_if = "Option::is_none")]
286 pub check_sources: Option<BTreeSet<CheckSource>>,
287 /// What merging each change request did.
288 ///
289 /// Both a script and a record: an entry seeded here is what `merge` answers,
290 /// whatever the policy asks for — which is how a journey expresses a host that
291 /// queues or refuses — and a merge the policy decided is written back here.
292 #[serde(skip_serializing_if = "BTreeMap::is_empty")]
293 pub merges: BTreeMap<ChangeId, MergeOutcome>,
294}
295
296/// Who a host with nothing seeded says is calling.
297///
298/// A host that answers nobody is refused by the real implementation, so a default
299/// state that answered nobody would be a provider that cannot run a publication
300/// until it is configured.
301pub const DEFAULT_AUTHENTICATED_USER: &str = "onevcs-testing";
302
303impl Default for HostState {
304 fn default() -> Self {
305 Self {
306 version: STATE_VERSION,
307 authenticated_user: DEFAULT_AUTHENTICATED_USER.to_owned(),
308 changes: Vec::new(),
309 heads: BTreeMap::new(),
310 titles: BTreeMap::new(),
311 bodies: BTreeMap::new(),
312 drafts: BTreeMap::new(),
313 made_ready: Vec::new(),
314 checks: BTreeMap::new(),
315 check_logs: BTreeMap::new(),
316 check_sources: None,
317 merges: BTreeMap::new(),
318 }
319 }
320}
321
322/// The identity a session request names, or the reason none of them is it.
323///
324/// Three ways to name one, mirroring what the registry accepts: the identity key
325/// itself, the `owner/name` tail of it, or the bare repository name.
326pub(crate) fn identity_of<'a>(state: &'a VcsState, origin_or_path: &str) -> Option<&'a Identity> {
327 let wanted = origin_or_path.trim_end_matches('/');
328 state
329 .identities
330 .iter()
331 .find(|identity| identity.origin == wanted)
332 .or_else(|| {
333 state.identities.iter().find(|identity| {
334 identity
335 .origin
336 .rsplit('/')
337 .next()
338 .is_some_and(|name| name == wanted)
339 || identity.origin.ends_with(&format!("/{wanted}"))
340 })
341 })
342}
343
344/// The known identities, as a refusal names them.
345pub(crate) fn known(state: &VcsState) -> String {
346 if state.identities.is_empty() {
347 return "this provider was seeded with no identities".to_owned();
348 }
349 let names: Vec<&str> = state
350 .identities
351 .iter()
352 .map(|identity| identity.origin.as_str())
353 .collect();
354 format!("it knows {}", names.join(", "))
355}
356
357/// The identity a session belongs to, or the reason this provider cannot say.
358///
359/// `open_session` records it and nothing else writes it, so a session that arrived
360/// in a hand-written scenario without one is refused here rather than published
361/// against a repository nobody named.
362pub(crate) fn identity_for(state: &VcsState, token: &SessionToken) -> Result<String> {
363 state
364 .session_identities
365 .get(token)
366 .cloned()
367 .ok_or_else(|| Error::Invalid {
368 reason: format!(
369 "this provider has no record of session {:?}, so it cannot say which identity \
370 its work belongs to",
371 token.0
372 ),
373 })
374}
375
376/// The session a token names.
377pub(crate) fn session_of<'a>(state: &'a VcsState, token: &SessionToken) -> Option<&'a Session> {
378 state
379 .sessions
380 .iter()
381 .find(|session| session.token == *token)
382}
383
384/// The branch a request asks for, or the one that is derived from the token.
385pub(crate) fn requested_branch(req: &SessionRequest, token: &SessionToken) -> Result<String> {
386 let name = req
387 .branch
388 .clone()
389 .unwrap_or_else(|| format!("onevcs/{}", token.0));
390 named_branch(&name, "the branch")?;
391 Ok(name)
392}
393
394/// A branch name, refused here if git would refuse it.
395///
396/// The real implementation asks `git check-ref-format`, which is the parser that
397/// decides; a provider with no git carries `git-check-ref-format(1)`'s rules
398/// instead. That is a restatement, so it is gated rather than trusted:
399/// `refs.rs` in the suite runs both this and git itself over a table of names
400/// and holds them to each other, because a copy of somebody else's grammar with
401/// no gate is a copy that drifts.
402///
403/// One deliberate difference, and the gate knows about it: a leading `-` is
404/// refused here even though git accepts it as a ref, because such a name reaches
405/// a command line as an option rather than as the branch it spells.
406pub(crate) fn named_branch(value: &str, what: &str) -> Result<()> {
407 // Rule 1 is per slash-separated component; the rest are about the whole name.
408 let components_usable = !value.is_empty()
409 && value.split('/').all(|component| {
410 !component.is_empty() && !component.starts_with('.') && !component.ends_with(".lock")
411 });
412 let usable = components_usable
413 && !value.starts_with('-')
414 && !value.contains("..")
415 && !value.contains("@{")
416 && !value.ends_with('.')
417 && !value.ends_with('/')
418 && !value.chars().any(|c| {
419 c.is_whitespace() || c.is_ascii_control() || c == '\u{7f}' || "~^:?*[\\".contains(c)
420 });
421 if !usable {
422 return Err(Error::Invalid {
423 reason: format!("{what} {value:?} is a name git would not accept"),
424 });
425 }
426 Ok(())
427}
428
429/// A seeded repository side is refused if it holds a session nothing could act on.
430impl Checked for VcsState {
431 fn check(&self) -> Result<()> {
432 readable_version(self.version)?;
433 for session in &self.sessions {
434 // The token names a file under the state root, and a branch goes on to
435 // spell a ref; both arrive from whoever wrote the document.
436 if !events::is_safe_name(&session.token.0) {
437 return Err(Error::Invalid {
438 reason: format!("{:?} is not a session token", session.token.0),
439 });
440 }
441 named_branch(&session.branch, "the branch")?;
442 named_branch(&session.base, "the base")?;
443 }
444 for row in &self.preserved {
445 known_identity(self, &row.identity, "preserved work")?;
446 named_branch(&row.branch.branch, "the preserved branch")?;
447 named_branch(&row.branch.base, "the preserved branch's base")?;
448 // The hold names a session, so it is checked like the three below: a row
449 // held by a session nobody opened is the same fiction, and the costly one
450 // — it is the session an operator is told to wait for or close.
451 if let Some(held) = &row.held_by {
452 opened(self, &held.token, "holding preserved work")?;
453 }
454 }
455 // Both of these name a session, so both are checked twice over: the token
456 // has to be a plain name, because it goes on to spell the file its stream is
457 // written in, and it has to name a session this state actually holds. A
458 // document that closes or publishes a session nobody opened describes a run
459 // that could not have happened, and answering `recoverable` or `session`
460 // from it would be answering from a fiction rather than refusing one.
461 for token in &self.closed_sessions {
462 opened(self, token, "closed")?;
463 }
464 for (token, origin) in &self.session_identities {
465 opened(self, token, "given an identity")?;
466 // The value as well as the key: this is what `identity_for` answers with,
467 // and it goes on to spell the slug a change request is opened against and
468 // the label every one of that session's events carries. An identity this
469 // provider does not know is one it could not have opened the session for.
470 known_identity(self, origin, &format!("session {:?}", token.0))?;
471 }
472 for publication in &self.publications {
473 let session = opened(self, &publication.session, "published")?;
474 named_branch(&publication.branch, "the published branch")?;
475 // A publication of some other branch than the one the session is on is
476 // the same kind of fiction, and the harder one to spot afterwards: the
477 // branch is what a journey asserts the publication was of.
478 if publication.branch != session.branch {
479 return Err(Error::Invalid {
480 reason: format!(
481 "the publication of session {:?} names branch {:?}, but that session is \
482 on {:?}",
483 publication.session.0, publication.branch, session.branch
484 ),
485 });
486 }
487 }
488 Ok(())
489 }
490
491 /// Every field an older readable document could hold means here what it meant
492 /// there, and the two the repository side gained in version 4 are absent from one
493 /// written before them — which is the answer, since that build held no hold and
494 /// counted no lines.
495 ///
496 /// Version 5's field is the exception, and it is carried rather than left at its
497 /// default: a document written before it *listed preserved work nobody had
498 /// published*, which is the `no` this build spells out. Left at the default it
499 /// would read as "nothing here can say", and a consumer's checked-in scenario
500 /// would start reporting work it had always called unpublished as work that may
501 /// have landed.
502 fn carry_forward(&mut self) {
503 if self.version < 5 {
504 for row in &mut self.preserved {
505 row.landed = Landed::No;
506 }
507 }
508 self.version = STATE_VERSION;
509 }
510}
511
512/// Refuse a record kept about a change request this state does not hold.
513fn opened_change(state: &HostState, id: &ChangeId, what: &str) -> Result<()> {
514 if state.changes.iter().any(|change| change.id == *id) {
515 return Ok(());
516 }
517 Err(Error::Invalid {
518 reason: format!(
519 "{what} is recorded for change request {:?}, but no change request by that \
520 identifier was opened",
521 id.0
522 ),
523 })
524}
525
526/// Refuse an identity key this provider was not seeded with.
527fn known_identity(state: &VcsState, origin: &str, what: &str) -> Result<()> {
528 if state
529 .identities
530 .iter()
531 .any(|identity| identity.origin == origin)
532 {
533 return Ok(());
534 }
535 Err(Error::Invalid {
536 reason: format!(
537 "{what} belongs to identity {origin:?}, which this provider does not know; {}",
538 known(state)
539 ),
540 })
541}
542
543/// A change request's title, refused when it names nothing.
544///
545/// The one thing a real host refuses about a title, and the only one this provider
546/// may: how long a title may be is the host's own rule rather than `onevcs`'s
547/// commit-subject rule, and a provider applying the stricter of the two would
548/// refuse what the host it stands in for accepts.
549pub(crate) fn titled(title: &str) -> Result<()> {
550 if title.trim().is_empty() {
551 return Err(Error::Invalid {
552 reason: "a change request's title is blank, so it names no change".to_owned(),
553 });
554 }
555 Ok(())
556}
557
558/// The session a token names, refused when this state does not hold one.
559fn opened<'a>(state: &'a VcsState, token: &SessionToken, what: &str) -> Result<&'a Session> {
560 if !events::is_safe_name(&token.0) {
561 return Err(Error::Invalid {
562 reason: format!("{:?} is not a session token", token.0),
563 });
564 }
565 session_of(state, token).ok_or_else(|| Error::Invalid {
566 reason: format!(
567 "session {:?} is {what} here, but no session by that token was opened",
568 token.0
569 ),
570 })
571}
572
573/// A seeded host side is refused if it holds a change nothing could address.
574impl Checked for HostState {
575 fn check(&self) -> Result<()> {
576 readable_version(self.version)?;
577 for change in &self.changes {
578 named_branch(&change.base, "the base of a seeded change request")?;
579 if change.id.0.is_empty() {
580 return Err(Error::Invalid {
581 reason: "a seeded change request carries no identifier".to_owned(),
582 });
583 }
584 // The commit a change request's checks are reported against is the whole
585 // evidence that a change reached anything, and the real implementation
586 // refuses a host answer that names none rather than passing a blank one
587 // through. A seeded one is refused for the same reason.
588 if change.head_sha.0.trim().is_empty() {
589 return Err(Error::Invalid {
590 reason: format!(
591 "the seeded change request {:?} names no commit its checks are \
592 reported against",
593 change.id.0
594 ),
595 });
596 }
597 }
598 // Both of these are recorded *about* a change request, by `open_change` and
599 // by nothing else, and both are read back by the id they are keyed under. An
600 // entry for a change nobody opened is one no call could ever reach, so it is
601 // refused rather than carried — unlike the checks, logs, and merge outcomes
602 // below it, which a journey deliberately seeds for a change it has not
603 // opened yet.
604 for (id, head) in &self.heads {
605 opened_change(self, id, "a head")?;
606 named_branch(head, "the head of a seeded change request")?;
607 }
608 for (id, title) in &self.titles {
609 opened_change(self, id, "a title")?;
610 // The real host refuses a title that names nothing, so a seeded one is
611 // refused for the same reason.
612 titled(title)?;
613 }
614 for id in self.bodies.keys() {
615 // Nothing is refused about the body itself: a host places no shape on
616 // prose, and a change request opened with an empty one is a scenario.
617 opened_change(self, id, "a body")?;
618 }
619 for (id, reason) in &self.drafts {
620 opened_change(self, id, "a draft reason")?;
621 // The publication rule the crate next door states, applied rather than
622 // restated: a seeded reason no publication could have carried is refused
623 // where the document is read, not answered from later.
624 reason.checked()?;
625 }
626 for id in &self.made_ready {
627 opened_change(self, id, "a lifted draft")?;
628 }
629 Ok(())
630 }
631
632 /// A version 2 document held no bodies, and a version 5 document's checks named
633 /// no commit; each reads as what it was — change requests opened with none, and
634 /// checks whose head that build never recorded. There is nothing to fill in — an
635 /// absent field is already that answer, and a check's commit is the one thing
636 /// that must never be inferred — so this is the version and nothing else.
637 fn carry_forward(&mut self) {
638 self.version = STATE_VERSION;
639 }
640}
641
642/// Refuse a document written at a version this build does not read.
643///
644/// Named rather than guessed at: a state whose shape is a later build's reads one
645/// way here and another way where that version is understood, and for a seeded
646/// scenario those two readings are two different tests. The refusal names the
647/// range as well as the version, because "too old" and "too new" are two different
648/// things to do about it — one is a document to re-seed, the other a build to
649/// update.
650fn readable_version(declared: u32) -> Result<()> {
651 if !(OLDEST_READABLE_VERSION..=STATE_VERSION).contains(&declared) {
652 return Err(Error::Invalid {
653 reason: format!(
654 "the document declares version {declared}; this build reads versions \
655 {OLDEST_READABLE_VERSION} to {STATE_VERSION}"
656 ),
657 });
658 }
659 Ok(())
660}