omni_dev/git/

commit.rs

//! Git commit operations and analysis.

use std::fs;

use anyhow::{Context, Result};
use chrono::{DateTime, FixedOffset};
use git2::{Commit, Repository};
use globset::Glob;
use serde::{Deserialize, Serialize};

use crate::data::context::ScopeDefinition;
use crate::git::diff_split::split_by_file;
use crate::git::lint;

/// Commit information structure, generic over analysis type.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CommitInfo<A = CommitAnalysis> {
    /// Full SHA-1 hash of the commit.
    pub hash: String,
    /// Commit author name and email address.
    pub author: String,
    /// Commit date in ISO format with timezone.
    pub date: DateTime<FixedOffset>,
    /// The original commit message as written by the author.
    pub original_message: String,
    /// Array of remote main branches that contain this commit.
    pub in_main_branches: Vec<String>,
    /// Automated analysis of the commit including type detection and proposed message.
    pub analysis: A,
}

/// Commit analysis information.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CommitAnalysis {
    /// Automatically detected conventional commit type (feat, fix, docs, test, chore, etc.).
    pub detected_type: String,
    /// Automatically detected scope based on file paths (cli, git, data, etc.).
    pub detected_scope: String,
    /// AI-generated conventional commit message based on file changes.
    pub proposed_message: String,
    /// Detailed statistics about file changes in this commit.
    pub file_changes: FileChanges,
    /// Git diff --stat output showing lines changed per file.
    pub diff_summary: String,
    /// Path to diff file showing line-by-line changes.
    pub diff_file: String,
    /// Per-file diff references for individual file changes.
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub file_diffs: Vec<FileDiffRef>,
}

/// Reference to a per-file diff stored on disk.
///
/// Tracks the repository-relative file path, the absolute path to the
/// diff file on disk, and the byte length of that diff. Gives consumers
/// per-file size information without loading diff content into memory.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FileDiffRef {
    /// Repository-relative path of the changed file.
    pub path: String,
    /// Absolute path to the per-file diff file on disk.
    pub diff_file: String,
    /// Byte length of the per-file diff content.
    pub byte_len: usize,
}

/// Enhanced commit analysis for AI processing with full diff content.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CommitAnalysisForAI {
    /// Base commit analysis fields.
    #[serde(flatten)]
    pub base: CommitAnalysis,
    /// Full diff content for AI analysis.
    pub diff_content: String,
}

/// Commit information with enhanced analysis for AI processing.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CommitInfoForAI {
    /// Base commit information with AI-enhanced analysis.
    #[serde(flatten)]
    pub base: CommitInfo<CommitAnalysisForAI>,
    /// Deterministic checks already performed; the LLM should treat these as authoritative.
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub pre_validated_checks: Vec<String>,
}

/// File changes statistics.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FileChanges {
    /// Total number of files modified in this commit.
    pub total_files: usize,
    /// Number of new files added in this commit.
    pub files_added: usize,
    /// Number of files deleted in this commit.
    pub files_deleted: usize,
    /// Array of files changed with their git status (M=modified, A=added, D=deleted).
    pub file_list: Vec<FileChange>,
}

/// Individual file change.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FileChange {
    /// Git status code (A=added, M=modified, D=deleted, R=renamed).
    pub status: String,
    /// Path to the file relative to repository root.
    pub file: String,
}

impl CommitInfo {
    /// Creates a `CommitInfo` from a `git2::Commit`.
    ///
    /// `main_tips` is the precomputed set of remote main-branch tips (see
    /// [`crate::git::main_branches::detect_main_branch_tips`]); callers resolve
    /// it once per invocation rather than per commit.
    pub fn from_git_commit(
        repo: &Repository,
        commit: &Commit,
        main_tips: &[crate::git::main_branches::MainBranchTip],
    ) -> Result<Self> {
        let hash = commit.id().to_string();

        let author = format!(
            "{} <{}>",
            commit.author().name().unwrap_or("Unknown"),
            commit.author().email().unwrap_or("unknown@example.com")
        );

        let timestamp = commit.author().when();
        let date = DateTime::from_timestamp(timestamp.seconds(), 0)
            .context("Invalid commit timestamp")?
            .with_timezone(
                #[allow(clippy::unwrap_used)] // Offset 0 is always valid
                &FixedOffset::east_opt(timestamp.offset_minutes() * 60)
                    .unwrap_or_else(|| FixedOffset::east_opt(0).unwrap()),
            );

        let original_message = commit.message().unwrap_or("").to_string();

        let in_main_branches =
            crate::git::main_branches::branches_containing(repo, main_tips, commit.id())?;

        let analysis = CommitAnalysis::analyze_commit(repo, commit)?;

        Ok(Self {
            hash,
            author,
            date,
            original_message,
            in_main_branches,
            analysis,
        })
    }
}

impl CommitAnalysis {
    /// Analyzes a commit and generates analysis information.
    pub fn analyze_commit(repo: &Repository, commit: &Commit) -> Result<Self> {
        // Get file changes
        let file_changes = Self::analyze_file_changes(repo, commit)?;

        // Detect conventional commit type based on files and message
        let detected_type = Self::detect_commit_type(commit, &file_changes);

        // Detect scope based on file paths
        let detected_scope = Self::detect_scope(&file_changes);

        // Generate proposed conventional commit message
        let proposed_message =
            Self::generate_proposed_message(commit, &detected_type, &detected_scope, &file_changes);

        // Get diff summary
        let diff_summary = Self::get_diff_summary(repo, commit)?;

        // Write diff to file and get path
        let (diff_file, file_diffs) = Self::write_diff_to_file(repo, commit)?;

        Ok(Self {
            detected_type,
            detected_scope,
            proposed_message,
            file_changes,
            diff_summary,
            diff_file,
            file_diffs,
        })
    }

    /// Analyzes file changes in the commit.
    fn analyze_file_changes(repo: &Repository, commit: &Commit) -> Result<FileChanges> {
        let mut file_list = Vec::new();
        let mut files_added = 0;
        let mut files_deleted = 0;

        // Get the tree for this commit
        let commit_tree = commit.tree().context("Failed to get commit tree")?;

        // Get parent tree if available
        let parent_tree = if commit.parent_count() > 0 {
            Some(
                commit
                    .parent(0)
                    .context("Failed to get parent commit")?
                    .tree()
                    .context("Failed to get parent tree")?,
            )
        } else {
            None
        };

        // Create diff between parent and commit
        let diff = if let Some(parent_tree) = parent_tree {
            repo.diff_tree_to_tree(Some(&parent_tree), Some(&commit_tree), None)
                .context("Failed to create diff")?
        } else {
            // Initial commit - diff against empty tree
            repo.diff_tree_to_tree(None, Some(&commit_tree), None)
                .context("Failed to create diff for initial commit")?
        };

        // Process each diff delta
        diff.foreach(
            &mut |delta, _progress| {
                let status = match delta.status() {
                    git2::Delta::Added => {
                        files_added += 1;
                        "A"
                    }
                    git2::Delta::Deleted => {
                        files_deleted += 1;
                        "D"
                    }
                    git2::Delta::Modified => "M",
                    git2::Delta::Renamed => "R",
                    git2::Delta::Copied => "C",
                    git2::Delta::Typechange => "T",
                    _ => "?",
                };

                if let Some(path) = delta.new_file().path() {
                    if let Some(path_str) = path.to_str() {
                        file_list.push(FileChange {
                            status: status.to_string(),
                            file: path_str.to_string(),
                        });
                    }
                }

                true
            },
            None,
            None,
            None,
        )
        .context("Failed to process diff")?;

        let total_files = file_list.len();

        Ok(FileChanges {
            total_files,
            files_added,
            files_deleted,
            file_list,
        })
    }

    /// Detects conventional commit type based on files and existing message.
    fn detect_commit_type(commit: &Commit, file_changes: &FileChanges) -> String {
        detect_commit_type_from_message(commit.message().unwrap_or(""), file_changes)
    }

    /// Extracts conventional commit type from an existing message.
    fn extract_conventional_type(message: &str) -> Option<String> {
        let first_line = message.lines().next().unwrap_or("");
        if let Some(colon_pos) = first_line.find(':') {
            let prefix = &first_line[..colon_pos];
            if let Some(paren_pos) = prefix.find('(') {
                let type_part = &prefix[..paren_pos];
                if Self::is_valid_conventional_type(type_part) {
                    return Some(type_part.to_string());
                }
            } else if Self::is_valid_conventional_type(prefix) {
                return Some(prefix.to_string());
            }
        }
        None
    }

    /// Checks if a string is a valid conventional commit type.
    fn is_valid_conventional_type(s: &str) -> bool {
        matches!(
            s,
            "feat"
                | "fix"
                | "docs"
                | "style"
                | "refactor"
                | "test"
                | "chore"
                | "build"
                | "ci"
                | "perf"
        )
    }

    /// Detects scope from file paths.
    fn detect_scope(file_changes: &FileChanges) -> String {
        let files: Vec<&str> = file_changes
            .file_list
            .iter()
            .map(|f| f.file.as_str())
            .collect();

        // Analyze common path patterns
        if files.iter().any(|f| f.starts_with("src/cli/")) {
            "cli".to_string()
        } else if files.iter().any(|f| f.starts_with("src/git/")) {
            "git".to_string()
        } else if files.iter().any(|f| f.starts_with("src/data/")) {
            "data".to_string()
        } else if files.iter().any(|f| f.starts_with("tests/")) {
            "test".to_string()
        } else if files.iter().any(|f| f.starts_with("docs/")) {
            "docs".to_string()
        } else if files
            .iter()
            .any(|f| f.contains("Cargo.toml") || f.contains("deny.toml"))
        {
            "deps".to_string()
        } else {
            String::new()
        }
    }

    /// Re-detects scope using file_patterns from scope definitions.
    ///
    /// More specific patterns (more literal path components) win regardless of
    /// definition order in scopes.yaml. Equally specific matches are joined
    /// with ", ". If no scope definitions match, the existing detected_scope
    /// is kept as a fallback.
    pub fn refine_scope(&mut self, scope_defs: &[ScopeDefinition]) {
        let files: Vec<&str> = self
            .file_changes
            .file_list
            .iter()
            .map(|f| f.file.as_str())
            .collect();

        if let Some(resolved) = resolve_scope(&files, scope_defs) {
            self.detected_scope = resolved;
        }
    }

    /// Builds a deterministic replacement for `original_message` without AI.
    ///
    /// Unlike [`Self::proposed_message`], which is generated before scope
    /// definitions are applied (and covers only the first line), this resolves
    /// the scope from `scope_defs` first, corrects the scope of an
    /// already-conventional subject the way the AI path does, and keeps the
    /// original body verbatim. A commit that already conforms comes back
    /// unchanged.
    #[must_use]
    pub fn suggest_message(
        &self,
        original_message: &str,
        scope_defs: &[ScopeDefinition],
    ) -> String {
        let files: Vec<&str> = self
            .file_changes
            .file_list
            .iter()
            .map(|f| f.file.as_str())
            .collect();
        let scope =
            resolve_scope(&files, scope_defs).unwrap_or_else(|| self.detected_scope.clone());

        let (first_line, body) = original_message
            .split_once('\n')
            .map_or((original_message, None), |(f, r)| (f, Some(r)));

        // Subjects git generates, and ones that already have conventional
        // shape (including `type!:` and any type word), are not ours to
        // reclassify: only their scope may be corrected.
        if is_git_generated_subject(first_line) {
            return original_message.to_string();
        }
        let subject = if lint::parse_subject(first_line).is_some() {
            first_line.to_string()
        } else {
            Self::generate_proposed_message_from(
                first_line,
                &self.detected_type,
                &scope,
                &self.file_changes,
            )
        };
        let subject = refine_message_scope(&subject, &files, scope_defs);

        match body {
            Some(body) => format!("{subject}\n{body}"),
            None => subject,
        }
    }

    /// Generates a proposed conventional commit message.
    fn generate_proposed_message(
        commit: &Commit,
        commit_type: &str,
        scope: &str,
        file_changes: &FileChanges,
    ) -> String {
        let current_message = commit.message().unwrap_or("").lines().next().unwrap_or("");
        Self::generate_proposed_message_from(current_message, commit_type, scope, file_changes)
    }

    /// Pure message generation from the commit's first line and its analysis.
    ///
    /// Separated from [`Self::generate_proposed_message`] so the scope/format branches
    /// can be unit-tested deterministically (the `&Commit` wrapper needs a live
    /// repository).
    fn generate_proposed_message_from(
        current_message: &str,
        commit_type: &str,
        scope: &str,
        file_changes: &FileChanges,
    ) -> String {
        // If already properly formatted, return as-is
        if Self::extract_conventional_type(current_message).is_some() {
            return current_message.to_string();
        }

        // Generate description based on changes
        let description =
            if !current_message.is_empty() && !current_message.eq_ignore_ascii_case("stuff") {
                current_message.to_string()
            } else {
                Self::generate_description(commit_type, file_changes)
            };

        // Format with scope if available
        if scope.is_empty() {
            format!("{commit_type}: {description}")
        } else {
            format!("{commit_type}({scope}): {description}")
        }
    }

    /// Generates a description based on commit type and changes.
    fn generate_description(commit_type: &str, file_changes: &FileChanges) -> String {
        match commit_type {
            "feat" => {
                if file_changes.total_files == 1 {
                    format!("add {}", file_changes.file_list[0].file)
                } else {
                    format!("add {} new features", file_changes.total_files)
                }
            }
            "fix" => "resolve issues".to_string(),
            "docs" => "update documentation".to_string(),
            "test" => "add tests".to_string(),
            "refactor" => "improve code structure".to_string(),
            "chore" => "update project files".to_string(),
            _ => "update project".to_string(),
        }
    }

    /// Returns diff summary statistics.
    fn get_diff_summary(repo: &Repository, commit: &Commit) -> Result<String> {
        let commit_tree = commit.tree().context("Failed to get commit tree")?;

        let parent_tree = if commit.parent_count() > 0 {
            Some(
                commit
                    .parent(0)
                    .context("Failed to get parent commit")?
                    .tree()
                    .context("Failed to get parent tree")?,
            )
        } else {
            None
        };

        let diff = if let Some(parent_tree) = parent_tree {
            repo.diff_tree_to_tree(Some(&parent_tree), Some(&commit_tree), None)
                .context("Failed to create diff")?
        } else {
            repo.diff_tree_to_tree(None, Some(&commit_tree), None)
                .context("Failed to create diff for initial commit")?
        };

        let stats = diff.stats().context("Failed to get diff stats")?;

        let mut summary = String::new();
        for i in 0..stats.files_changed() {
            if let Some(path) = diff
                .get_delta(i)
                .and_then(|d| d.new_file().path())
                .and_then(|p| p.to_str())
            {
                let insertions = stats.insertions();
                let deletions = stats.deletions();
                summary.push_str(&format!(
                    " {} | {} +{} -{}\n",
                    path,
                    insertions + deletions,
                    insertions,
                    deletions
                ));
            }
        }

        Ok(summary)
    }

    /// Writes full diff content to a file and returns the path and per-file refs.
    fn write_diff_to_file(
        repo: &Repository,
        commit: &Commit,
    ) -> Result<(String, Vec<FileDiffRef>)> {
        // Get AI scratch directory, anchored to the opened repository's workdir
        // (#967) so the per-commit diff files land under the same repo the rest
        // of the view reports, rather than the ambient process CWD. `repo` is
        // the already-opened (possibly `--repo`-injected) git2 handle.
        let repo_root = repo.workdir().unwrap_or_else(|| repo.path());
        let ai_scratch_path = crate::utils::ai_scratch::get_ai_scratch_dir_at(repo_root)
            .context("Failed to determine AI scratch directory")?;

        // Create diffs subdirectory
        let diffs_dir = ai_scratch_path.join("diffs");
        fs::create_dir_all(&diffs_dir).context("Failed to create diffs directory")?;

        // Create filename with commit hash
        let commit_hash = commit.id().to_string();
        let diff_filename = format!("{commit_hash}.diff");
        let diff_path = diffs_dir.join(&diff_filename);

        let commit_tree = commit.tree().context("Failed to get commit tree")?;

        let parent_tree = if commit.parent_count() > 0 {
            Some(
                commit
                    .parent(0)
                    .context("Failed to get parent commit")?
                    .tree()
                    .context("Failed to get parent tree")?,
            )
        } else {
            None
        };

        let diff = if let Some(parent_tree) = parent_tree {
            repo.diff_tree_to_tree(Some(&parent_tree), Some(&commit_tree), None)
                .context("Failed to create diff")?
        } else {
            repo.diff_tree_to_tree(None, Some(&commit_tree), None)
                .context("Failed to create diff for initial commit")?
        };

        let mut diff_content = String::new();

        diff.print(git2::DiffFormat::Patch, |_delta, _hunk, line| {
            let content = std::str::from_utf8(line.content()).unwrap_or("<binary>");
            let prefix = match line.origin() {
                '+' => "+",
                '-' => "-",
                ' ' => " ",
                '@' => "@",
                _ => "", // Header, file header, and other origins
            };
            diff_content.push_str(&format!("{prefix}{content}"));
            true
        })
        .context("Failed to format diff")?;

        // Ensure the diff content ends with a newline to encourage literal block style
        if !diff_content.ends_with('\n') {
            diff_content.push('\n');
        }

        // Write flat diff content to file
        fs::write(&diff_path, &diff_content).context("Failed to write diff file")?;

        // Split into per-file diffs and write each to disk
        let per_file_diffs = split_by_file(&diff_content);
        let mut file_diffs = Vec::with_capacity(per_file_diffs.len());

        if !per_file_diffs.is_empty() {
            let per_file_dir = diffs_dir.join(&commit_hash);
            fs::create_dir_all(&per_file_dir)
                .context("Failed to create per-file diffs directory")?;

            for (index, file_diff) in per_file_diffs.iter().enumerate() {
                let per_file_name = format!("{index:04}.diff");
                let per_file_path = per_file_dir.join(&per_file_name);
                fs::write(&per_file_path, &file_diff.content).with_context(|| {
                    format!("Failed to write per-file diff: {}", per_file_path.display())
                })?;

                file_diffs.push(FileDiffRef {
                    path: file_diff.path.clone(),
                    diff_file: per_file_path.to_string_lossy().to_string(),
                    byte_len: file_diff.byte_len,
                });
            }
        }

        Ok((diff_path.to_string_lossy().to_string(), file_diffs))
    }
}

/// Pure type inference from a commit `message` and its `file_changes`.
///
/// Separated from [`CommitAnalysis::detect_commit_type`] so the branch logic
/// can be exercised deterministically by unit tests; the `&Commit`-taking
/// wrapper requires a live repository whose state varies run-to-run (which
/// makes coverage of these branches flicker — see the conventional-type
/// tests below).
///
/// A free function (not an associated one), matching [`resolve_scope`]/
/// [`refine_message_scope`]'s shape — `pub(crate)`, following the precedent
/// set for [`scope_matches_files`] under #1475, so callers outside this
/// module (e.g. `staged.rs`'s `--no-ai`, #1564) can reuse it deterministically
/// without going through a live [`CommitAnalysis`]. An empty `message` (as
/// `staged.rs` passes, since there's no message yet to seed from) simply
/// skips the "already conventional" branch and falls straight through to the
/// file-pattern heuristics below.
pub(crate) fn detect_commit_type_from_message(message: &str, file_changes: &FileChanges) -> String {
    // Check if message already has conventional commit format
    if let Some(existing_type) = CommitAnalysis::extract_conventional_type(message) {
        return existing_type;
    }

    // Analyze file patterns
    let files: Vec<&str> = file_changes
        .file_list
        .iter()
        .map(|f| f.file.as_str())
        .collect();

    // Check for specific patterns
    if files
        .iter()
        .any(|f| f.contains("test") || f.contains("spec"))
    {
        "test".to_string()
    } else if files
        .iter()
        .any(|f| f.ends_with(".md") || f.contains("README") || f.contains("docs/"))
    {
        "docs".to_string()
    } else if files
        .iter()
        .any(|f| f.contains("Cargo.toml") || f.contains("package.json") || f.contains("config"))
    {
        if file_changes.files_added > 0 {
            "feat".to_string()
        } else {
            "chore".to_string()
        }
    } else if file_changes.files_added > 0
        && files
            .iter()
            .any(|f| f.ends_with(".rs") || f.ends_with(".js") || f.ends_with(".py"))
    {
        "feat".to_string()
    } else if message.to_lowercase().contains("fix") || message.to_lowercase().contains("bug") {
        "fix".to_string()
    } else if file_changes.files_deleted > file_changes.files_added {
        "refactor".to_string()
    } else {
        "chore".to_string()
    }
}

impl CommitInfoForAI {
    /// Converts from a basic `CommitInfo` by loading diff content.
    pub fn from_commit_info(commit_info: CommitInfo) -> Result<Self> {
        let analysis = CommitAnalysisForAI::from_commit_analysis(commit_info.analysis)?;

        Ok(Self {
            base: CommitInfo {
                hash: commit_info.hash,
                author: commit_info.author,
                date: commit_info.date,
                original_message: commit_info.original_message,
                in_main_branches: commit_info.in_main_branches,
                analysis,
            },
            pre_validated_checks: Vec::new(),
        })
    }

    /// Creates a partial view of a commit containing only the specified file diffs.
    ///
    /// Convenience wrapper around [`Self::from_commit_info_partial_with_overrides`]
    /// with all-`None` overrides (every file loaded from disk).
    #[cfg(test)]
    pub(crate) fn from_commit_info_partial(
        commit_info: CommitInfo,
        file_paths: &[String],
    ) -> Result<Self> {
        let overrides: Vec<Option<String>> = vec![None; file_paths.len()];
        Self::from_commit_info_partial_with_overrides(commit_info, file_paths, &overrides)
    }

    /// Creates a partial view using pre-sliced diff content where available.
    ///
    /// `file_paths` and `diff_overrides` must be parallel slices. When
    /// `diff_overrides[i]` is `Some(content)`, that content is used directly
    /// instead of reading the full per-file diff from disk. This enables
    /// per-hunk partial views where each chunk receives only its assigned
    /// hunk slices rather than the entire file.
    ///
    /// Entries with `None` overrides fall back to loading from disk via
    /// [`FileDiffRef::diff_file`], deduplicated by path.
    pub(crate) fn from_commit_info_partial_with_overrides(
        commit_info: CommitInfo,
        file_paths: &[String],
        diff_overrides: &[Option<String>],
    ) -> Result<Self> {
        let mut diff_parts = Vec::new();
        let mut included_refs = Vec::new();
        let mut loaded_disk_paths: std::collections::HashSet<String> =
            std::collections::HashSet::new();

        for (path, override_content) in file_paths.iter().zip(diff_overrides.iter()) {
            if let Some(content) = override_content {
                // Pre-sliced hunk content — use directly.
                diff_parts.push(content.clone());
                // Include the FileDiffRef for metadata (deduplicated).
                if let Some(file_ref) = commit_info
                    .analysis
                    .file_diffs
                    .iter()
                    .find(|r| r.path == *path)
                {
                    if !included_refs.iter().any(|r: &FileDiffRef| r.path == *path) {
                        included_refs.push(file_ref.clone());
                    }
                }
            } else {
                // Whole-file item — load from disk (deduplicated).
                if loaded_disk_paths.insert(path.clone()) {
                    if let Some(file_ref) = commit_info
                        .analysis
                        .file_diffs
                        .iter()
                        .find(|r| r.path == *path)
                    {
                        let content =
                            fs::read_to_string(&file_ref.diff_file).with_context(|| {
                                format!("Failed to read per-file diff: {}", file_ref.diff_file)
                            })?;
                        diff_parts.push(content);
                        included_refs.push(file_ref.clone());
                    }
                }
            }
        }

        let diff_content = diff_parts.join("\n");

        let partial_analysis = CommitAnalysisForAI {
            base: CommitAnalysis {
                file_diffs: included_refs,
                ..commit_info.analysis
            },
            diff_content,
        };

        Ok(Self {
            base: CommitInfo {
                hash: commit_info.hash,
                author: commit_info.author,
                date: commit_info.date,
                original_message: commit_info.original_message,
                in_main_branches: commit_info.in_main_branches,
                analysis: partial_analysis,
            },
            pre_validated_checks: Vec::new(),
        })
    }

    /// Runs deterministic pre-validation checks on the commit message.
    /// Passing checks are recorded in pre_validated_checks so the LLM
    /// can skip re-checking them. Failing checks are not recorded.
    ///
    /// Subject parsing and the scope predicates are shared with
    /// [`crate::git::lint::lint_message`] via [`lint::parse_subject`] /
    /// [`lint::scope_comma_format_ok`] / [`lint::scope_parts_all_valid`] —
    /// one implementation, not a second one to drift (#1474).
    pub fn run_pre_validation_checks(&mut self, valid_scopes: &[ScopeDefinition]) {
        let first_line = self.base.original_message.lines().next().unwrap_or("");
        let Some(scope) = lint::parse_subject(first_line).and_then(|p| p.scope) else {
            return;
        };

        if scope.contains(',') && lint::scope_comma_format_ok(scope) {
            self.pre_validated_checks.push(format!(
                "Scope format verified: multi-scope '{scope}' uses commas with at most one trailing space"
            ));
        }

        // Deterministic scope validity check
        if !valid_scopes.is_empty() && lint::scope_parts_all_valid(scope, valid_scopes) {
            self.pre_validated_checks.push(format!(
                "Scope validity verified: '{scope}' is in the valid scopes list"
            ));
        }
    }
}

/// Returns `true` for subjects git or the user's tooling generates
/// (`Merge …`, `Revert "…"`, `fixup!`/`squash!`/`amend!`), which must not be
/// rewritten into conventional form.
fn is_git_generated_subject(first_line: &str) -> bool {
    ["Merge ", "Revert ", "fixup! ", "squash! ", "amend! "]
        .iter()
        .any(|prefix| first_line.starts_with(prefix))
}

/// Resolves the best scope for a set of files using scope definition file patterns.
///
/// More specific patterns (more literal path components) win regardless of
/// definition order in `scopes.yaml`. Equally specific matches are joined
/// with ", ". Returns `None` when `scope_defs` or `files` is empty, or no
/// scope definition matches.
pub fn resolve_scope(files: &[&str], scope_defs: &[ScopeDefinition]) -> Option<String> {
    if scope_defs.is_empty() || files.is_empty() {
        return None;
    }

    let mut matches: Vec<(&str, usize)> = Vec::new();
    for scope_def in scope_defs {
        if let Some(specificity) = scope_matches_files(files, &scope_def.file_patterns) {
            matches.push((&scope_def.name, specificity));
        }
    }

    if matches.is_empty() {
        return None;
    }

    // SAFETY: matches is non-empty (guarded by early return above)
    #[allow(clippy::expect_used)] // Guarded by is_empty() check above
    let max_specificity = matches.iter().map(|(_, s)| *s).max().expect("non-empty");
    let best: Vec<&str> = matches
        .into_iter()
        .filter(|(_, s)| *s == max_specificity)
        .map(|(name, _)| name)
        .collect();

    Some(best.join(", "))
}

/// Replaces the scope in a conventional commit message with the deterministically
/// resolved scope based on the given files and scope definitions.
///
/// If the message does not contain a conventional commit scope, or if no scope
/// can be resolved from the files, the message is returned unchanged.
pub fn refine_message_scope(
    message: &str,
    files: &[&str],
    scope_defs: &[ScopeDefinition],
) -> String {
    let Some(resolved) = resolve_scope(files, scope_defs) else {
        return message.to_string();
    };

    // Split into first line and rest
    let (first_line, rest) = message
        .split_once('\n')
        .map_or((message, ""), |(f, r)| (f, r));

    let Some(existing_scope) = lint::parse_subject(first_line).and_then(|p| p.scope) else {
        return message.to_string();
    };

    if existing_scope == resolved {
        return message.to_string();
    }

    let new_first_line =
        first_line.replacen(&format!("({existing_scope})"), &format!("({resolved})"), 1);

    if rest.is_empty() {
        new_first_line
    } else {
        format!("{new_first_line}\n{rest}")
    }
}

/// Checks if a scope's file patterns match any of the given files.
///
/// Returns `Some(max_specificity)` if at least one file matches the scope
/// (after applying negation patterns), or `None` if no file matches.
///
/// `pub(crate)` so `config scopes lint` (issue #1475) can reuse it
/// per-pattern to detect dead `file_patterns` entries, rather than
/// reimplementing the same globset matching logic.
pub(crate) fn scope_matches_files(files: &[&str], patterns: &[String]) -> Option<usize> {
    let mut positive = Vec::new();
    let mut negative = Vec::new();
    for pat in patterns {
        if let Some(stripped) = pat.strip_prefix('!') {
            negative.push(stripped);
        } else {
            positive.push(pat.as_str());
        }
    }

    // Build negative matchers
    let neg_matchers: Vec<_> = negative
        .iter()
        .filter_map(|p| Glob::new(p).ok().map(|g| g.compile_matcher()))
        .collect();

    let mut max_specificity: Option<usize> = None;
    for pat in &positive {
        let Ok(glob) = Glob::new(pat) else {
            continue;
        };
        let matcher = glob.compile_matcher();
        for file in files {
            if matcher.is_match(file) && !neg_matchers.iter().any(|neg| neg.is_match(file)) {
                let specificity = count_specificity(pat);
                max_specificity =
                    Some(max_specificity.map_or(specificity, |cur| cur.max(specificity)));
            }
        }
    }
    max_specificity
}

/// Counts the number of literal (non-wildcard) path segments in a glob pattern.
///
/// - `docs/adrs/**` → 2 (`docs`, `adrs`)
/// - `docs/**` → 1 (`docs`)
/// - `*.md` → 0
/// - `src/main/scala/**` → 3
fn count_specificity(pattern: &str) -> usize {
    pattern
        .split('/')
        .filter(|segment| !segment.contains('*') && !segment.contains('?'))
        .count()
}

/// One scope name with the number of commits that declared it.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct ScopeCount {
    /// The scope name, e.g. `cli`.
    pub name: String,
    /// Number of commits (within the analyzed subjects) that declared it.
    pub count: usize,
}

/// Report produced by [`tally_scope_usage`]: how declared commit scopes
/// compare against a project's scope taxonomy.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct ScopeUsageReport {
    /// Total commit subjects analyzed (including scope-less ones).
    pub total_commits: usize,
    /// Every declared scope with its count, descending by count then name.
    pub declared: Vec<ScopeCount>,
    /// The subset of `declared` not present in the known-scope set.
    pub unknown: Vec<ScopeCount>,
    /// Scopes present in `unused_candidates` that no subject declared.
    pub unused: Vec<String>,
    /// Commits whose subject carries no conventional-commit scope at all.
    pub scope_less_count: usize,
}

/// Tallies declared conventional-commit scopes across `subjects` (each the
/// commit's first message line) against a project's scope taxonomy.
///
/// Pure and git-free: `subjects` is already-extracted text, so this is safe
/// to unit test with string literals. Multi-scope subjects like
/// `feat(cli,claude): …` count once for each of `cli` and `claude`, matching
/// [`CommitInfoForAI::run_pre_validation_checks`]'s own comma-splitting.
///
/// `known_scopes` decides `unknown` — normally `scopes.yaml` plus ecosystem
/// defaults, or just `scopes.yaml` under `--project-only`. `unused_candidates`
/// is always `scopes.yaml`'s own entries: ecosystem defaults are synthesized
/// by omni-dev rather than written by the project, so they must never be
/// reported as "defined but unused."
pub fn tally_scope_usage(
    subjects: &[&str],
    known_scopes: &[ScopeDefinition],
    unused_candidates: &[ScopeDefinition],
) -> ScopeUsageReport {
    use std::collections::HashMap;

    let mut counts: HashMap<&str, usize> = HashMap::new();
    let mut scope_less_count = 0;

    for subject in subjects {
        match lint::parse_subject(subject).and_then(|p| p.scope) {
            Some(scope_text) => {
                for part in scope_text.split(',').map(str::trim) {
                    if !part.is_empty() {
                        *counts.entry(part).or_default() += 1;
                    }
                }
            }
            None => scope_less_count += 1,
        }
    }

    let mut declared: Vec<ScopeCount> = counts
        .iter()
        .map(|(&name, &count)| ScopeCount {
            name: name.to_string(),
            count,
        })
        .collect();
    declared.sort_by(|a, b| b.count.cmp(&a.count).then_with(|| a.name.cmp(&b.name)));

    let known_names: std::collections::HashSet<&str> =
        known_scopes.iter().map(|s| s.name.as_str()).collect();
    let unknown: Vec<ScopeCount> = declared
        .iter()
        .filter(|sc| !known_names.contains(sc.name.as_str()))
        .cloned()
        .collect();

    let mut unused: Vec<String> = unused_candidates
        .iter()
        .filter(|s| !counts.contains_key(s.name.as_str()))
        .map(|s| s.name.clone())
        .collect();
    unused.sort();

    ScopeUsageReport {
        total_commits: subjects.len(),
        declared,
        unknown,
        unused,
        scope_less_count,
    }
}

impl CommitAnalysisForAI {
    /// Converts from a basic `CommitAnalysis` by loading diff content from file.
    pub fn from_commit_analysis(analysis: CommitAnalysis) -> Result<Self> {
        // Read the actual diff content from the file
        let diff_content = fs::read_to_string(&analysis.diff_file)
            .with_context(|| format!("Failed to read diff file: {}", analysis.diff_file))?;

        Ok(Self {
            base: analysis,
            diff_content,
        })
    }
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::expect_used)]
mod tests {
    use super::*;
    use crate::data::context::ScopeDefinition;

    // ── extract_conventional_type ────────────────────────────────────

    #[test]
    fn conventional_type_feat_with_scope() {
        assert_eq!(
            CommitAnalysis::extract_conventional_type("feat(cli): add flag"),
            Some("feat".to_string())
        );
    }

    #[test]
    fn conventional_type_without_scope() {
        assert_eq!(
            CommitAnalysis::extract_conventional_type("fix: resolve bug"),
            Some("fix".to_string())
        );
    }

    #[test]
    fn conventional_type_invalid_message() {
        assert_eq!(
            CommitAnalysis::extract_conventional_type("random message without colon"),
            None
        );
    }

    #[test]
    fn conventional_type_unknown_type() {
        assert_eq!(
            CommitAnalysis::extract_conventional_type("yolo(scope): stuff"),
            None
        );
    }

    #[test]
    fn conventional_type_all_valid_types() {
        let types = [
            "feat", "fix", "docs", "style", "refactor", "test", "chore", "build", "ci", "perf",
        ];
        for t in types {
            let msg = format!("{t}: description");
            assert_eq!(
                CommitAnalysis::extract_conventional_type(&msg),
                Some(t.to_string()),
                "expected Some for type '{t}'"
            );
        }
    }

    // ── is_valid_conventional_type ───────────────────────────────────

    #[test]
    fn valid_conventional_types() {
        for t in [
            "feat", "fix", "docs", "style", "refactor", "test", "chore", "build", "ci", "perf",
        ] {
            assert!(
                CommitAnalysis::is_valid_conventional_type(t),
                "'{t}' should be valid"
            );
        }
    }

    #[test]
    fn invalid_conventional_types() {
        for t in ["yolo", "Feat", "", "FEAT", "feature", "bugfix"] {
            assert!(
                !CommitAnalysis::is_valid_conventional_type(t),
                "'{t}' should be invalid"
            );
        }
    }

    // ── detect_scope ─────────────────────────────────────────────────

    fn make_file_changes(files: &[(&str, &str)]) -> FileChanges {
        FileChanges {
            total_files: files.len(),
            files_added: files.iter().filter(|(s, _)| *s == "A").count(),
            files_deleted: files.iter().filter(|(s, _)| *s == "D").count(),
            file_list: files
                .iter()
                .map(|(status, file)| FileChange {
                    status: (*status).to_string(),
                    file: (*file).to_string(),
                })
                .collect(),
        }
    }

    #[test]
    fn scope_from_cli_files() {
        let changes = make_file_changes(&[("M", "src/cli/commands.rs")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "cli");
    }

    #[test]
    fn scope_from_git_files() {
        let changes = make_file_changes(&[("M", "src/git/remote.rs")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "git");
    }

    #[test]
    fn scope_from_docs_files() {
        let changes = make_file_changes(&[("M", "docs/README.md")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "docs");
    }

    #[test]
    fn scope_from_data_files() {
        let changes = make_file_changes(&[("M", "src/data/yaml.rs")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "data");
    }

    #[test]
    fn scope_from_test_files() {
        let changes = make_file_changes(&[("A", "tests/new_test.rs")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "test");
    }

    #[test]
    fn scope_from_deps_files() {
        let changes = make_file_changes(&[("M", "Cargo.toml")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "deps");
    }

    #[test]
    fn scope_unknown_files() {
        let changes = make_file_changes(&[("M", "random/path/file.txt")]);
        assert_eq!(CommitAnalysis::detect_scope(&changes), "");
    }

    // ── count_specificity ────────────────────────────────────────────

    #[test]
    fn count_specificity_deep_path() {
        assert_eq!(super::count_specificity("src/main/scala/**"), 3);
    }

    #[test]
    fn count_specificity_shallow() {
        assert_eq!(super::count_specificity("docs/**"), 1);
    }

    #[test]
    fn count_specificity_wildcard_only() {
        assert_eq!(super::count_specificity("*.md"), 0);
    }

    #[test]
    fn count_specificity_no_wildcards() {
        assert_eq!(super::count_specificity("src/lib.rs"), 2);
    }

    // ── scope_matches_files ──────────────────────────────────────────

    #[test]
    fn scope_matches_positive_patterns() {
        let patterns = vec!["src/cli/**".to_string()];
        let files = &["src/cli/commands.rs"];
        assert!(super::scope_matches_files(files, &patterns).is_some());
    }

    #[test]
    fn scope_matches_no_match() {
        let patterns = vec!["src/cli/**".to_string()];
        let files = &["src/git/remote.rs"];
        assert!(super::scope_matches_files(files, &patterns).is_none());
    }

    #[test]
    fn scope_matches_with_negation() {
        let patterns = vec!["src/**".to_string(), "!src/test/**".to_string()];
        // File in src/ but not in src/test/ should match
        let files = &["src/lib.rs"];
        assert!(super::scope_matches_files(files, &patterns).is_some());

        // File in src/test/ should be excluded
        let test_files = &["src/test/helper.rs"];
        assert!(super::scope_matches_files(test_files, &patterns).is_none());
    }

    // ── refine_scope ─────────────────────────────────────────────────

    fn make_scope_def(name: &str, patterns: &[&str]) -> ScopeDefinition {
        ScopeDefinition {
            name: name.to_string(),
            description: String::new(),
            examples: vec![],
            file_patterns: patterns.iter().map(|p| (*p).to_string()).collect(),
        }
    }

    fn make_analysis(detected_type: &str, scope: &str, files: &[(&str, &str)]) -> CommitAnalysis {
        CommitAnalysis {
            detected_type: detected_type.to_string(),
            detected_scope: scope.to_string(),
            proposed_message: String::new(),
            file_changes: make_file_changes(files),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: Vec::new(),
        }
    }

    // ── suggest_message (#1566) ──────────────────────────────────────

    #[test]
    fn suggest_message_adds_type_and_scope_from_defs() {
        let analysis = make_analysis("feat", "stale", &[("M", "src/cli/commands.rs")]);
        let defs = vec![make_scope_def("cli", &["src/cli/**"])];
        assert_eq!(
            analysis.suggest_message("add flag", &defs),
            "feat(cli): add flag"
        );
    }

    #[test]
    fn suggest_message_falls_back_to_detected_scope_without_defs() {
        let analysis = make_analysis("feat", "git", &[("M", "src/git/x.rs")]);
        assert_eq!(
            analysis.suggest_message("add flag", &[]),
            "feat(git): add flag"
        );
    }

    #[test]
    fn suggest_message_omits_scope_when_none_known() {
        let analysis = make_analysis("chore", "", &[("M", "x.txt")]);
        assert_eq!(analysis.suggest_message("tidy", &[]), "chore: tidy");
    }

    #[test]
    fn suggest_message_corrects_scope_of_conventional_subject() {
        let analysis = make_analysis("feat", "", &[("M", "src/cli/commands.rs")]);
        let defs = vec![make_scope_def("cli", &["src/cli/**"])];
        assert_eq!(
            analysis.suggest_message("feat(git): add flag", &defs),
            "feat(cli): add flag"
        );
    }

    #[test]
    fn suggest_message_leaves_conforming_message_unchanged() {
        let analysis = make_analysis("feat", "cli", &[("M", "src/cli/commands.rs")]);
        let defs = vec![make_scope_def("cli", &["src/cli/**"])];
        let message = "feat(cli): add flag\n\nBody line.\n";
        assert_eq!(analysis.suggest_message(message, &defs), message);
    }

    #[test]
    fn suggest_message_preserves_body_verbatim() {
        let analysis = make_analysis("fix", "", &[("M", "src/cli/commands.rs")]);
        let defs = vec![make_scope_def("cli", &["src/cli/**"])];
        assert_eq!(
            analysis.suggest_message("repair thing\n\nWhy it broke.\n\nFixes #1", &defs),
            "fix(cli): repair thing\n\nWhy it broke.\n\nFixes #1"
        );
    }

    #[test]
    fn suggest_message_keeps_conventionally_shaped_subjects() {
        let analysis = make_analysis("chore", "", &[("M", "x.txt")]);
        for message in ["feat!: drop API", "deps: bump serde", "revert: undo thing"] {
            assert_eq!(analysis.suggest_message(message, &[]), message);
        }
    }

    #[test]
    fn suggest_message_leaves_git_generated_subjects_alone() {
        let analysis = make_analysis("chore", "", &[("M", "x.txt")]);
        for message in [
            "Merge branch 'x' into main",
            "Revert \"feat: add flag\"",
            "fixup! feat: add flag",
            "squash! feat: add flag",
        ] {
            assert_eq!(analysis.suggest_message(message, &[]), message);
        }
    }

    #[test]
    fn suggest_message_generates_description_for_placeholder_subject() {
        let analysis = make_analysis("docs", "", &[("M", "README.md")]);
        assert_eq!(
            analysis.suggest_message("stuff", &[]),
            "docs: update documentation"
        );
        assert_eq!(
            analysis.suggest_message("", &[]),
            "docs: update documentation"
        );
    }

    #[test]
    fn refine_scope_empty_defs() {
        let mut analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: "original".to_string(),
            proposed_message: String::new(),
            file_changes: make_file_changes(&[("M", "src/cli/commands.rs")]),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: Vec::new(),
        };
        analysis.refine_scope(&[]);
        assert_eq!(analysis.detected_scope, "original");
    }

    #[test]
    fn refine_scope_most_specific_wins() {
        let scope_defs = vec![
            make_scope_def("lib", &["src/**"]),
            make_scope_def("cli", &["src/cli/**"]),
        ];
        let mut analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: String::new(),
            proposed_message: String::new(),
            file_changes: make_file_changes(&[("M", "src/cli/commands.rs")]),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: Vec::new(),
        };
        analysis.refine_scope(&scope_defs);
        assert_eq!(analysis.detected_scope, "cli");
    }

    #[test]
    fn resolve_scope_specific_pattern_beats_lib_catch_all() {
        // Pins the specificity behaviour issue #1468 depends on: a file
        // covered by a dedicated scope pattern must resolve there, not fall
        // through to the Rust ecosystem `lib` scope's `src/**` catch-all.
        let scope_defs = vec![
            make_scope_def("lib", &["src/lib.rs", "src/**"]),
            make_scope_def("worktrees", &["src/worktrees.rs"]),
        ];
        assert_eq!(
            resolve_scope(&["src/worktrees.rs"], &scope_defs),
            Some("worktrees".to_string())
        );
    }

    #[test]
    fn refine_scope_no_matching_files() {
        let scope_defs = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: "original".to_string(),
            proposed_message: String::new(),
            file_changes: make_file_changes(&[("M", "README.md")]),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: Vec::new(),
        };
        analysis.refine_scope(&scope_defs);
        // No match → keeps original
        assert_eq!(analysis.detected_scope, "original");
    }

    #[test]
    fn refine_scope_equal_specificity_joins() {
        let scope_defs = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("git", &["src/git/**"]),
        ];
        let mut analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: String::new(),
            proposed_message: String::new(),
            file_changes: make_file_changes(&[
                ("M", "src/cli/commands.rs"),
                ("M", "src/git/remote.rs"),
            ]),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: Vec::new(),
        };
        analysis.refine_scope(&scope_defs);
        // Both have specificity 2 and both match → joined
        assert!(
            analysis.detected_scope == "cli, git" || analysis.detected_scope == "git, cli",
            "expected joined scopes, got: {}",
            analysis.detected_scope
        );
    }

    // ── refine_message_scope ───────────────────────────────────────────

    #[test]
    fn refine_message_scope_replaces_less_specific() {
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let result = super::refine_message_scope(
            "chore(ci): bump EmbarkStudios/cargo-deny-action from 2.0.15 to 2.0.17",
            files,
            &scope_defs,
        );
        assert_eq!(
            result,
            "chore(workflows): bump EmbarkStudios/cargo-deny-action from 2.0.15 to 2.0.17"
        );
    }

    #[test]
    fn refine_message_scope_keeps_already_correct() {
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let msg = "chore(workflows): bump something";
        assert_eq!(super::refine_message_scope(msg, files, &scope_defs), msg);
    }

    #[test]
    fn refine_message_scope_no_scope_in_message() {
        let scope_defs = vec![make_scope_def("cli", &["src/cli/**"])];
        let files = &["src/cli/commands.rs"];
        let msg = "chore: do something";
        assert_eq!(super::refine_message_scope(msg, files, &scope_defs), msg);
    }

    #[test]
    fn refine_message_scope_preserves_body() {
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let msg = "chore(ci): bump dep\n\nSome body text\nMore details";
        let result = super::refine_message_scope(msg, files, &scope_defs);
        assert_eq!(
            result,
            "chore(workflows): bump dep\n\nSome body text\nMore details"
        );
    }

    #[test]
    fn refine_message_scope_breaking_change() {
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let result = super::refine_message_scope("feat!(ci): breaking change", files, &scope_defs);
        assert_eq!(result, "feat!(workflows): breaking change");
    }

    /// #1473: the documented breaking-change form puts `!` after the scope
    /// (`type(scope)!:`), not before it — `.omni-dev/commit-guidelines.md`'s
    /// own examples use this form exclusively.
    #[test]
    fn refine_message_scope_breaking_change_documented_form() {
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let result = super::refine_message_scope("feat(ci)!: breaking change", files, &scope_defs);
        assert_eq!(result, "feat(workflows)!: breaking change");
    }

    #[test]
    fn refine_message_scope_canonical_breaking_change_preserves_bang() {
        // #1473: the documented `type(scope)!:` form (bang after the paren)
        // used to never match at all, so refinement silently no-opped.
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let result = super::refine_message_scope("feat(ci)!: breaking change", files, &scope_defs);
        assert_eq!(result, "feat(workflows)!: breaking change");
    }

    #[test]
    fn refine_message_scope_preserves_breaking_marker() {
        let scope_defs = vec![
            make_scope_def("ci", &[".github/**"]),
            make_scope_def("workflows", &[".github/workflows/**"]),
        ];
        let files = &[".github/workflows/ci.yml"];
        let result = super::refine_message_scope("feat(ci)!: breaking change", files, &scope_defs);
        assert_eq!(
            result, "feat(workflows)!: breaking change",
            "the documented `type(scope)!:` form must be refined with its `!` intact"
        );
    }

    #[test]
    fn refine_message_scope_no_matching_scope_defs() {
        let scope_defs = vec![make_scope_def("cli", &["src/cli/**"])];
        let files = &["README.md"];
        let msg = "docs(docs): update readme";
        assert_eq!(super::refine_message_scope(msg, files, &scope_defs), msg);
    }

    // ── run_pre_validation_checks ────────────────────────────────────

    fn make_commit_info_for_ai(message: &str) -> CommitInfoForAI {
        CommitInfoForAI {
            base: CommitInfo {
                hash: "a".repeat(40),
                author: "Test <test@example.com>".to_string(),
                date: chrono::DateTime::parse_from_rfc3339("2024-01-01T00:00:00+00:00").unwrap(),
                original_message: message.to_string(),
                in_main_branches: vec![],
                analysis: CommitAnalysisForAI {
                    base: CommitAnalysis {
                        detected_type: "feat".to_string(),
                        detected_scope: String::new(),
                        proposed_message: String::new(),
                        file_changes: make_file_changes(&[]),
                        diff_summary: String::new(),
                        diff_file: String::new(),
                        file_diffs: Vec::new(),
                    },
                    diff_content: String::new(),
                },
            },
            pre_validated_checks: vec![],
        }
    }

    #[test]
    fn pre_validation_valid_single_scope() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat(cli): add command");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "expected scope validity check, got: {:?}",
            info.pre_validated_checks
        );
    }

    /// #1473: `run_pre_validation_checks` must recognize the documented
    /// `type(scope)!:` breaking-change form, not just the bare `type(scope):`.
    #[test]
    fn pre_validation_breaking_change_documented_form() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat(cli)!: change output format");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "expected scope validity check for breaking-change form, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_multi_scope() {
        let scopes = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("git", &["src/git/**"]),
        ];
        let mut info = make_commit_info_for_ai("feat(cli,git): cross-cutting change");
        info.run_pre_validation_checks(&scopes);
        assert!(info
            .pre_validated_checks
            .iter()
            .any(|c| c.contains("Scope validity verified")),);
        assert!(info
            .pre_validated_checks
            .iter()
            .any(|c| c.contains("multi-scope")),);
    }

    #[test]
    fn pre_validation_breaking_change_single_scope() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat(cli)!: change output format");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "the documented `type(scope)!:` breaking-change form must be pre-validated \
             like any other scoped subject, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_breaking_change_multi_scope() {
        let scopes = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("git", &["src/git/**"]),
        ];
        let mut info = make_commit_info_for_ai("feat(cli,git)!: cross-cutting breaking change");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "expected scope validity check, got: {:?}",
            info.pre_validated_checks
        );
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("multi-scope")),
            "expected multi-scope format check, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_legacy_breaking_change_marker() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat!(cli): change output format");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "the undocumented `type!(scope):` form stays accepted as a lenient fallback, \
             got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_multi_scope_with_spaces() {
        let scopes = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("lib", &["src/lib/**"]),
        ];
        let mut info = make_commit_info_for_ai("feat(cli, lib): add something");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "expected scope validity check for spaced multi-scope, got: {:?}",
            info.pre_validated_checks
        );
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope format verified")),
            "single-space-after-comma multi-scope should pass the format check, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_multi_scope_double_space_not_format_verified() {
        let scopes = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("lib", &["src/lib/**"]),
        ];
        let mut info = make_commit_info_for_ai("feat(cli,  lib): add something");
        info.run_pre_validation_checks(&scopes);
        assert!(
            !info
                .pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope format verified")),
            "double-space-after-comma must NOT be recorded as format-verified, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_multi_scope_space_before_comma_not_format_verified() {
        let scopes = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("lib", &["src/lib/**"]),
        ];
        let mut info = make_commit_info_for_ai("feat(cli ,lib): add something");
        info.run_pre_validation_checks(&scopes);
        assert!(
            !info
                .pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope format verified")),
            "space-before-comma must NOT be recorded as format-verified, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_invalid_scope_not_added() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat(unknown): something");
        info.run_pre_validation_checks(&scopes);
        assert!(
            !info
                .pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "should not validate unknown scope"
        );
    }

    #[test]
    fn pre_validation_no_scope_message() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat: no scope here");
        info.run_pre_validation_checks(&scopes);
        assert!(info.pre_validated_checks.is_empty());
    }

    // #1473: canonical `type(scope)!:` breaking-change form used to record
    // nothing at all (SCOPE_RE never matched it). These four cases pin the
    // fix — the first was failing before it.

    #[test]
    fn pre_validation_canonical_breaking_change_single_scope() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat(cli)!: change output format");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "canonical breaking-change form must record scope validity, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_canonical_breaking_change_multi_scope() {
        let scopes = vec![
            make_scope_def("cli", &["src/cli/**"]),
            make_scope_def("claude", &["src/claude/**"]),
        ];
        let mut info = make_commit_info_for_ai("feat(cli,claude)!: add twiddle contextual options");
        info.run_pre_validation_checks(&scopes);
        assert!(info
            .pre_validated_checks
            .iter()
            .any(|c| c.contains("Scope validity verified")));
        assert!(info
            .pre_validated_checks
            .iter()
            .any(|c| c.contains("multi-scope")));
    }

    #[test]
    fn pre_validation_lenient_legacy_breaking_change_still_records() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat!(cli): add thing");
        info.run_pre_validation_checks(&scopes);
        assert!(
            info.pre_validated_checks
                .iter()
                .any(|c| c.contains("Scope validity verified")),
            "lenient legacy form must still record scope validity, got: {:?}",
            info.pre_validated_checks
        );
    }

    #[test]
    fn pre_validation_non_breaking_unchanged() {
        let scopes = vec![make_scope_def("cli", &["src/cli/**"])];
        let mut info = make_commit_info_for_ai("feat(cli): add command");
        info.run_pre_validation_checks(&scopes);
        assert!(info
            .pre_validated_checks
            .iter()
            .any(|c| c.contains("Scope validity verified")));
    }

    // ── property tests ────────────────────────────────────────────

    mod prop {
        use super::*;
        use proptest::prelude::*;

        fn arb_conventional_type() -> impl Strategy<Value = &'static str> {
            prop_oneof![
                Just("feat"),
                Just("fix"),
                Just("docs"),
                Just("style"),
                Just("refactor"),
                Just("test"),
                Just("chore"),
                Just("build"),
                Just("ci"),
                Just("perf"),
            ]
        }

        proptest! {
            #[test]
            fn valid_conventional_format_extracts_type(
                ctype in arb_conventional_type(),
                scope in "[a-z]{1,10}",
                desc in "[a-zA-Z ]{1,50}",
            ) {
                let message = format!("{ctype}({scope}): {desc}");
                let result = CommitAnalysis::extract_conventional_type(&message);
                prop_assert_eq!(result, Some(ctype.to_string()));
            }

            #[test]
            fn no_colon_returns_none(s in "[^:]{0,100}") {
                let result = CommitAnalysis::extract_conventional_type(&s);
                prop_assert!(result.is_none());
            }

            #[test]
            fn count_specificity_nonnegative(pattern in ".*") {
                // usize is always >= 0; this test catches panics on arbitrary input
                let _ = super::count_specificity(&pattern);
            }

            #[test]
            fn count_specificity_bounded_by_segments(
                segments in proptest::collection::vec("[a-z*?]{1,10}", 1..6),
            ) {
                let pattern = segments.join("/");
                let result = super::count_specificity(&pattern);
                prop_assert!(result <= segments.len());
            }
        }
    }

    // ── conversion tests ────────────────────────────────────────────

    #[test]
    fn from_commit_analysis_loads_diff_content() {
        let dir = tempfile::tempdir().unwrap();
        let diff_path = dir.path().join("test.diff");
        std::fs::write(&diff_path, "+added line\n-removed line\n").unwrap();

        let analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: "cli".to_string(),
            proposed_message: "feat(cli): test".to_string(),
            file_changes: make_file_changes(&[]),
            diff_summary: "file.rs | 2 +-".to_string(),
            diff_file: diff_path.to_string_lossy().to_string(),
            file_diffs: Vec::new(),
        };

        let ai = CommitAnalysisForAI::from_commit_analysis(analysis.clone()).unwrap();
        assert_eq!(ai.diff_content, "+added line\n-removed line\n");
        assert_eq!(ai.base.detected_type, analysis.detected_type);
        assert_eq!(ai.base.diff_file, analysis.diff_file);
    }

    #[test]
    fn from_commit_info_wraps_and_loads_diff() {
        let dir = tempfile::tempdir().unwrap();
        let diff_path = dir.path().join("test.diff");
        std::fs::write(&diff_path, "diff content").unwrap();

        let info = CommitInfo {
            hash: "a".repeat(40),
            author: "Test <test@example.com>".to_string(),
            date: chrono::DateTime::parse_from_rfc3339("2024-01-01T00:00:00+00:00").unwrap(),
            original_message: "feat(cli): add flag".to_string(),
            in_main_branches: vec!["origin/main".to_string()],
            analysis: CommitAnalysis {
                detected_type: "feat".to_string(),
                detected_scope: "cli".to_string(),
                proposed_message: "feat(cli): add flag".to_string(),
                file_changes: make_file_changes(&[("M", "src/cli.rs")]),
                diff_summary: "cli.rs | 1 +".to_string(),
                diff_file: diff_path.to_string_lossy().to_string(),
                file_diffs: Vec::new(),
            },
        };

        let ai = CommitInfoForAI::from_commit_info(info).unwrap();
        assert_eq!(ai.base.analysis.diff_content, "diff content");
        assert_eq!(ai.base.hash, "a".repeat(40));
        assert_eq!(ai.base.original_message, "feat(cli): add flag");
        assert!(ai.pre_validated_checks.is_empty());
    }

    #[test]
    fn file_diffs_default_empty_on_deserialize() {
        let yaml = r#"
detected_type: feat
detected_scope: cli
proposed_message: "feat(cli): test"
file_changes:
  total_files: 0
  files_added: 0
  files_deleted: 0
  file_list: []
diff_summary: ""
diff_file: "/tmp/test.diff"
"#;
        let analysis: CommitAnalysis = serde_yaml::from_str(yaml).unwrap();
        assert!(analysis.file_diffs.is_empty());
    }

    #[test]
    fn file_diffs_omitted_when_empty_on_serialize() {
        let analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: "cli".to_string(),
            proposed_message: "feat(cli): test".to_string(),
            file_changes: make_file_changes(&[]),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: Vec::new(),
        };
        let yaml = serde_yaml::to_string(&analysis).unwrap();
        assert!(!yaml.contains("file_diffs"));
    }

    #[test]
    fn file_diffs_included_when_populated() {
        let analysis = CommitAnalysis {
            detected_type: "feat".to_string(),
            detected_scope: "cli".to_string(),
            proposed_message: "feat(cli): test".to_string(),
            file_changes: make_file_changes(&[]),
            diff_summary: String::new(),
            diff_file: String::new(),
            file_diffs: vec![FileDiffRef {
                path: "src/main.rs".to_string(),
                diff_file: "/tmp/diffs/abc/0000.diff".to_string(),
                byte_len: 42,
            }],
        };
        let yaml = serde_yaml::to_string(&analysis).unwrap();
        assert!(yaml.contains("file_diffs"));
        assert!(yaml.contains("src/main.rs"));
        assert!(yaml.contains("byte_len: 42"));
    }

    // ── from_commit_info_partial ────────────────────────────────────

    /// Helper: creates a `CommitInfo` with N file diffs backed by temp files.
    fn make_commit_with_file_diffs(
        dir: &tempfile::TempDir,
        files: &[(&str, &str)], // (path, diff_content)
    ) -> CommitInfo {
        let file_diffs: Vec<FileDiffRef> = files
            .iter()
            .enumerate()
            .map(|(i, (path, content))| {
                let diff_path = dir.path().join(format!("{i:04}.diff"));
                fs::write(&diff_path, content).unwrap();
                FileDiffRef {
                    path: (*path).to_string(),
                    diff_file: diff_path.to_string_lossy().to_string(),
                    byte_len: content.len(),
                }
            })
            .collect();

        CommitInfo {
            hash: "abc123def456abc123def456abc123def456abc1".to_string(),
            author: "Test Author".to_string(),
            date: DateTime::parse_from_rfc3339("2025-01-01T00:00:00+00:00").unwrap(),
            original_message: "feat(cli): original message".to_string(),
            in_main_branches: vec!["main".to_string()],
            analysis: CommitAnalysis {
                detected_type: "feat".to_string(),
                detected_scope: "cli".to_string(),
                proposed_message: "feat(cli): proposed".to_string(),
                file_changes: make_file_changes(
                    &files.iter().map(|(p, _)| ("M", *p)).collect::<Vec<_>>(),
                ),
                diff_summary: " src/main.rs | 10 ++++\n src/lib.rs | 5 ++\n".to_string(),
                diff_file: dir.path().join("full.diff").to_string_lossy().to_string(),
                file_diffs,
            },
        }
    }

    #[test]
    fn from_commit_info_partial_loads_subset() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[
                ("src/main.rs", "diff --git a/src/main.rs\n+main\n"),
                ("src/lib.rs", "diff --git a/src/lib.rs\n+lib\n"),
                ("src/utils.rs", "diff --git a/src/utils.rs\n+utils\n"),
            ],
        );

        let paths = vec!["src/main.rs".to_string(), "src/utils.rs".to_string()];
        let partial = CommitInfoForAI::from_commit_info_partial(commit, &paths)?;

        // Only requested files in diff_content
        assert!(partial.base.analysis.diff_content.contains("+main"));
        assert!(partial.base.analysis.diff_content.contains("+utils"));
        assert!(!partial.base.analysis.diff_content.contains("+lib"));

        // file_diffs filtered to requested paths
        let ref_paths: Vec<&str> = partial
            .base
            .analysis
            .base
            .file_diffs
            .iter()
            .map(|r| r.path.as_str())
            .collect();
        assert_eq!(ref_paths, &["src/main.rs", "src/utils.rs"]);

        Ok(())
    }

    #[test]
    fn from_commit_info_partial_deduplicates_paths() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[("src/main.rs", "diff --git a/src/main.rs\n+main\n")],
        );

        // Duplicate path (simulates hunk-split scenario)
        let paths = vec!["src/main.rs".to_string(), "src/main.rs".to_string()];
        let partial = CommitInfoForAI::from_commit_info_partial(commit, &paths)?;

        // Content loaded only once (no duplicate)
        assert_eq!(
            partial.base.analysis.diff_content.matches("+main").count(),
            1
        );

        Ok(())
    }

    #[test]
    fn from_commit_info_partial_preserves_metadata() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[("src/main.rs", "diff --git a/src/main.rs\n+main\n")],
        );

        let original_hash = commit.hash.clone();
        let original_author = commit.author.clone();
        let original_date = commit.date;
        let original_message = commit.original_message.clone();
        let original_summary = commit.analysis.diff_summary.clone();

        let paths = vec!["src/main.rs".to_string()];
        let partial = CommitInfoForAI::from_commit_info_partial(commit, &paths)?;

        assert_eq!(partial.base.hash, original_hash);
        assert_eq!(partial.base.author, original_author);
        assert_eq!(partial.base.date, original_date);
        assert_eq!(partial.base.original_message, original_message);
        assert_eq!(partial.base.analysis.base.diff_summary, original_summary);

        Ok(())
    }

    // ── from_commit_info_partial_with_overrides ─────────────────────

    #[test]
    fn with_overrides_uses_override_content() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[(
                "src/big.rs",
                "diff --git a/src/big.rs\n+full-file-content\n",
            )],
        );

        let paths = vec!["src/big.rs".to_string(), "src/big.rs".to_string()];
        let overrides = vec![
            Some("diff --git a/src/big.rs\n@@ -1,3 +1,4 @@\n+hunk1\n".to_string()),
            Some("diff --git a/src/big.rs\n@@ -10,3 +10,4 @@\n+hunk2\n".to_string()),
        ];
        let partial =
            CommitInfoForAI::from_commit_info_partial_with_overrides(commit, &paths, &overrides)?;

        // Should contain hunk content, NOT full file content.
        assert!(partial.base.analysis.diff_content.contains("+hunk1"));
        assert!(partial.base.analysis.diff_content.contains("+hunk2"));
        assert!(
            !partial
                .base
                .analysis
                .diff_content
                .contains("+full-file-content"),
            "should not contain full file content"
        );

        Ok(())
    }

    #[test]
    fn with_overrides_mixed_override_and_disk() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[
                ("src/big.rs", "diff --git a/src/big.rs\n+big-full\n"),
                ("src/small.rs", "diff --git a/src/small.rs\n+small-disk\n"),
            ],
        );

        let paths = vec!["src/big.rs".to_string(), "src/small.rs".to_string()];
        let overrides = vec![
            Some("diff --git a/src/big.rs\n@@ -1,3 +1,4 @@\n+big-hunk\n".to_string()),
            None, // load from disk
        ];
        let partial =
            CommitInfoForAI::from_commit_info_partial_with_overrides(commit, &paths, &overrides)?;

        // big.rs: override content
        assert!(partial.base.analysis.diff_content.contains("+big-hunk"));
        assert!(!partial.base.analysis.diff_content.contains("+big-full"));
        // small.rs: loaded from disk
        assert!(partial.base.analysis.diff_content.contains("+small-disk"));

        // Both files should appear in file_diffs metadata.
        let ref_paths: Vec<&str> = partial
            .base
            .analysis
            .base
            .file_diffs
            .iter()
            .map(|r| r.path.as_str())
            .collect();
        assert!(ref_paths.contains(&"src/big.rs"));
        assert!(ref_paths.contains(&"src/small.rs"));

        Ok(())
    }

    #[test]
    fn with_overrides_deduplicates_disk_reads() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[("src/main.rs", "diff --git a/src/main.rs\n+main\n")],
        );

        // Two None entries for same path (simulates duplicate whole-file items).
        let paths = vec!["src/main.rs".to_string(), "src/main.rs".to_string()];
        let overrides = vec![None, None];
        let partial =
            CommitInfoForAI::from_commit_info_partial_with_overrides(commit, &paths, &overrides)?;

        // Content loaded only once despite two None entries.
        assert_eq!(
            partial.base.analysis.diff_content.matches("+main").count(),
            1
        );

        Ok(())
    }

    #[test]
    fn with_overrides_preserves_metadata() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let commit = make_commit_with_file_diffs(
            &dir,
            &[("src/main.rs", "diff --git a/src/main.rs\n+main\n")],
        );

        let original_hash = commit.hash.clone();
        let original_author = commit.author.clone();
        let original_message = commit.original_message.clone();

        let paths = vec!["src/main.rs".to_string()];
        let overrides = vec![Some("+override-content\n".to_string())];
        let partial =
            CommitInfoForAI::from_commit_info_partial_with_overrides(commit, &paths, &overrides)?;

        assert_eq!(partial.base.hash, original_hash);
        assert_eq!(partial.base.author, original_author);
        assert_eq!(partial.base.original_message, original_message);
        assert!(partial.pre_validated_checks.is_empty());

        Ok(())
    }

    // ── detect_commit_type_from_message (deterministic type inference) ──
    //
    // These pin every branch of the type-inference chain so its coverage no
    // longer depends on whatever commit the live-repo dispatch tests analyze.

    fn infer_type(message: &str, files: &[(&str, &str)]) -> String {
        detect_commit_type_from_message(message, &make_file_changes(files))
    }

    #[test]
    fn commit_type_existing_conventional_wins() {
        assert_eq!(infer_type("feat(cli): add", &[("A", "src/x.rs")]), "feat");
    }

    #[test]
    fn commit_type_test_files() {
        assert_eq!(infer_type("update", &[("A", "tests/foo_test.rs")]), "test");
    }

    #[test]
    fn commit_type_docs_files() {
        assert_eq!(infer_type("update", &[("M", "README.md")]), "docs");
    }

    #[test]
    fn commit_type_config_added_is_feat() {
        assert_eq!(infer_type("update", &[("A", "Cargo.toml")]), "feat");
    }

    #[test]
    fn commit_type_config_modified_is_chore() {
        assert_eq!(infer_type("update", &[("M", "Cargo.toml")]), "chore");
    }

    #[test]
    fn commit_type_added_source_is_feat() {
        assert_eq!(infer_type("add module", &[("A", "src/lib.rs")]), "feat");
    }

    #[test]
    fn commit_type_fix_from_message() {
        // Modified (not added) .rs file ⇒ falls through to the message check.
        assert_eq!(infer_type("fix the bug", &[("M", "src/lib.rs")]), "fix");
    }

    #[test]
    fn commit_type_refactor_when_more_deletions() {
        assert_eq!(
            infer_type("cleanup", &[("D", "src/a.rs"), ("D", "src/b.rs")]),
            "refactor"
        );
    }

    #[test]
    fn commit_type_default_chore() {
        assert_eq!(infer_type("update stuff", &[("M", "src/c.rs")]), "chore");
    }

    // ── generate_proposed_message_from (scope/format branches) ──

    #[test]
    fn proposed_message_with_scope() {
        let fc = make_file_changes(&[("A", "src/x.rs")]);
        let msg = CommitAnalysis::generate_proposed_message_from("do thing", "feat", "cli", &fc);
        assert_eq!(msg, "feat(cli): do thing");
    }

    #[test]
    fn proposed_message_without_scope() {
        let fc = make_file_changes(&[("A", "src/x.rs")]);
        let msg = CommitAnalysis::generate_proposed_message_from("do thing", "feat", "", &fc);
        assert_eq!(msg, "feat: do thing");
    }

    #[test]
    fn proposed_message_keeps_already_conventional() {
        let fc = make_file_changes(&[("A", "src/x.rs")]);
        let msg = CommitAnalysis::generate_proposed_message_from("fix(x): y", "feat", "cli", &fc);
        assert_eq!(msg, "fix(x): y");
    }

    #[test]
    fn proposed_message_generates_description_when_empty() {
        let fc = make_file_changes(&[("A", "src/x.rs")]);
        let msg = CommitAnalysis::generate_proposed_message_from("", "chore", "", &fc);
        assert!(msg.starts_with("chore: "), "got: {msg}");
    }

    // ── analyze_file_changes (Delta arms) ──
    //
    // Exercises the Added/Deleted/Modified arms against a constructed repo, so
    // their coverage is deterministic rather than dependent on the live HEAD
    // commit (which is what made `Delta::Deleted` flicker run-to-run).

    #[test]
    fn analyze_file_changes_covers_delta_arms() -> Result<()> {
        let dir = tempfile::tempdir()?;
        let repo = git2::Repository::init(dir.path())?;
        let sig = git2::Signature::now("T", "t@e.com")?;

        // Commit 1: add a.txt and b.txt.
        for (name, content) in [("a.txt", "a"), ("b.txt", "b")] {
            std::fs::write(dir.path().join(name), content)?;
        }
        let mut index = repo.index()?;
        index.add_path(std::path::Path::new("a.txt"))?;
        index.add_path(std::path::Path::new("b.txt"))?;
        index.write()?;
        let tree1 = repo.find_tree(index.write_tree()?)?;
        let c1 = repo.commit(Some("HEAD"), &sig, &sig, "init", &tree1, &[])?;

        // Commit 2: delete a.txt (Deleted), modify b.txt (Modified), add c.txt (Added).
        std::fs::remove_file(dir.path().join("a.txt"))?;
        std::fs::write(dir.path().join("b.txt"), "b2")?;
        std::fs::write(dir.path().join("c.txt"), "c")?;
        let mut index = repo.index()?;
        index.remove_path(std::path::Path::new("a.txt"))?;
        index.add_path(std::path::Path::new("b.txt"))?;
        index.add_path(std::path::Path::new("c.txt"))?;
        index.write()?;
        let tree2 = repo.find_tree(index.write_tree()?)?;
        let parent = repo.find_commit(c1)?;
        let c2 = repo.commit(Some("HEAD"), &sig, &sig, "change", &tree2, &[&parent])?;

        let commit2 = repo.find_commit(c2)?;
        let changes = CommitAnalysis::analyze_file_changes(&repo, &commit2)?;
        assert_eq!(changes.files_added, 1, "c.txt added");
        assert_eq!(changes.files_deleted, 1, "a.txt deleted");
        Ok(())
    }

    // ── tally_scope_usage (#1476) ────────────────────────────────────

    #[test]
    fn tally_multi_scope_counts_each_name_once() {
        let subjects = ["feat(cli,claude): cross-cutting change"];
        let report = super::tally_scope_usage(&subjects, &[], &[]);
        let names: Vec<&str> = report.declared.iter().map(|sc| sc.name.as_str()).collect();
        assert!(names.contains(&"cli"), "declared: {:?}", report.declared);
        assert!(names.contains(&"claude"), "declared: {:?}", report.declared);
        assert!(
            !names.contains(&"cli,claude"),
            "must not count the literal compound string, declared: {:?}",
            report.declared
        );
        assert_eq!(
            report
                .declared
                .iter()
                .find(|sc| sc.name == "cli")
                .map(|sc| sc.count),
            Some(1)
        );
        assert_eq!(report.scope_less_count, 0);
    }

    #[test]
    fn tally_scope_less_commit_not_a_named_bucket() {
        let subjects = ["docs: update readme"];
        let report = super::tally_scope_usage(&subjects, &[], &[]);
        assert!(
            report.declared.is_empty(),
            "a scope-less subject must not create an empty-named declared entry: {:?}",
            report.declared
        );
        assert_eq!(report.scope_less_count, 1);
        assert_eq!(report.total_commits, 1);
    }

    #[test]
    fn tally_breaking_change_counts_under_scope() {
        // Pins #1473: the documented `type(scope)!:` form must count under
        // its scope, not fall through to scope-less.
        let subjects = ["feat(cli)!: change output format"];
        let report = super::tally_scope_usage(&subjects, &[], &[]);
        assert_eq!(report.scope_less_count, 0);
        assert_eq!(
            report
                .declared
                .iter()
                .find(|sc| sc.name == "cli")
                .map(|sc| sc.count),
            Some(1)
        );
    }

    #[test]
    fn tally_unknown_excludes_known_scopes() {
        let subjects = ["feat(cli): add flag", "fix(lib): patch bug"];
        let known = vec![make_scope_def("cli", &[])];
        let report = super::tally_scope_usage(&subjects, &known, &[]);
        let unknown_names: Vec<&str> = report.unknown.iter().map(|sc| sc.name.as_str()).collect();
        assert_eq!(unknown_names, vec!["lib"]);
    }

    #[test]
    fn tally_unused_lists_scope_never_declared() {
        let subjects = ["feat(cli): add flag"];
        let unused_candidates = vec![make_scope_def("cli", &[]), make_scope_def("workflows", &[])];
        let report = super::tally_scope_usage(&subjects, &unused_candidates, &unused_candidates);
        assert_eq!(report.unused, vec!["workflows".to_string()]);
    }

    #[test]
    fn tally_empty_subjects_all_zero_report() {
        let report = super::tally_scope_usage(&[], &[], &[]);
        assert_eq!(report.total_commits, 0);
        assert!(report.declared.is_empty());
        assert!(report.unknown.is_empty());
        assert!(report.unused.is_empty());
        assert_eq!(report.scope_less_count, 0);
    }

    #[test]
    fn tally_declared_sorted_desc_by_count_then_name() {
        let subjects = [
            "feat(cli): a",
            "feat(git): b",
            "feat(git): c",
            "feat(data): d",
            "feat(data): e",
        ];
        let report = super::tally_scope_usage(&subjects, &[], &[]);
        let names: Vec<&str> = report.declared.iter().map(|sc| sc.name.as_str()).collect();
        // "data" and "git" tie at count 2; "cli" trails at count 1.
        assert_eq!(names, vec!["data", "git", "cli"]);
    }
}