use nu_cmd_base::hook::eval_hook;
use nu_engine::{command_prelude::*, env_to_strings, get_eval_expression};
use nu_path::{dots::expand_ndots, expand_tilde};
use nu_protocol::{did_you_mean, process::ChildProcess, ByteStream, NuGlob, OutDest, Signals};
use nu_system::ForegroundChild;
use nu_utils::IgnoreCaseExt;
use pathdiff::diff_paths;
use std::{
borrow::Cow,
ffi::{OsStr, OsString},
io::Write,
path::{Path, PathBuf},
process::Stdio,
sync::Arc,
thread,
};
#[derive(Clone)]
pub struct External;
impl Command for External {
fn name(&self) -> &str {
"run-external"
}
fn usage(&self) -> &str {
"Runs external command."
}
fn signature(&self) -> nu_protocol::Signature {
Signature::build(self.name())
.input_output_types(vec![(Type::Any, Type::Any)])
.required(
"command",
SyntaxShape::OneOf(vec![SyntaxShape::GlobPattern, SyntaxShape::String]),
"External command to run.",
)
.rest(
"args",
SyntaxShape::OneOf(vec![SyntaxShape::GlobPattern, SyntaxShape::Any]),
"Arguments for external command.",
)
.category(Category::System)
}
fn run(
&self,
engine_state: &EngineState,
stack: &mut Stack,
call: &Call,
input: PipelineData,
) -> Result<PipelineData, ShellError> {
let cwd = engine_state.cwd(Some(stack))?;
let name: Value = call.req(engine_state, stack, 0)?;
let name_str: Cow<str> = match &name {
Value::Glob { val, .. } => Cow::Borrowed(val),
Value::String { val, .. } => Cow::Borrowed(val),
_ => Cow::Owned(name.clone().coerce_into_string()?),
};
let expanded_name = match &name {
Value::Glob { no_expand, .. } if !*no_expand => {
expand_ndots_safe(expand_tilde(&*name_str))
}
_ => Path::new(&*name_str).to_owned(),
};
let executable = if cfg!(windows) && is_cmd_internal_command(&name_str) {
PathBuf::from("cmd.exe")
} else {
let paths = nu_engine::env::path_str(engine_state, stack, call.head)?;
let Some(executable) = which(expanded_name, &paths, cwd.as_ref()) else {
return Err(command_not_found(&name_str, call.head, engine_state, stack));
};
executable
};
let mut command = std::process::Command::new(executable);
command.current_dir(cwd);
let envs = env_to_strings(engine_state, stack)?;
command.env_clear();
command.envs(envs);
let args = eval_arguments_from_call(engine_state, stack, call)?;
#[cfg(windows)]
if is_cmd_internal_command(&name_str) {
use std::os::windows::process::CommandExt;
command.args(["/D", "/C", &name_str]);
for arg in &args {
command.raw_arg(escape_cmd_argument(arg)?);
}
} else {
command.args(args.into_iter().map(|s| s.item));
}
#[cfg(not(windows))]
command.args(args.into_iter().map(|s| s.item));
let stdout = stack.stdout();
let stderr = stack.stderr();
let merged_stream = if matches!(stdout, OutDest::Pipe) && matches!(stderr, OutDest::Pipe) {
let (reader, writer) = os_pipe::pipe()?;
command.stdout(writer.try_clone()?);
command.stderr(writer);
Some(reader)
} else {
command.stdout(Stdio::try_from(stdout)?);
command.stderr(Stdio::try_from(stderr)?);
None
};
let data_to_copy_into_stdin = match input {
PipelineData::ByteStream(stream, metadata) => match stream.into_stdio() {
Ok(stdin) => {
command.stdin(stdin);
None
}
Err(stream) => {
command.stdin(Stdio::piped());
Some(PipelineData::ByteStream(stream, metadata))
}
},
PipelineData::Empty => {
command.stdin(Stdio::inherit());
None
}
value => {
command.stdin(Stdio::piped());
Some(value)
}
};
log::trace!("run-external spawning: {command:?}");
#[cfg(windows)]
let mut child = ForegroundChild::spawn(command)?;
#[cfg(unix)]
let mut child = ForegroundChild::spawn(
command,
engine_state.is_interactive,
&engine_state.pipeline_externals_state,
)?;
if let Some(data) = data_to_copy_into_stdin {
let stdin = child.as_mut().stdin.take().expect("stdin is piped");
let engine_state = engine_state.clone();
let stack = stack.clone();
thread::Builder::new()
.name("external stdin worker".into())
.spawn(move || {
let _ = write_pipeline_data(engine_state, stack, data, stdin);
})
.err_span(call.head)?;
}
let child = ChildProcess::new(
child,
merged_stream,
matches!(stderr, OutDest::Pipe),
call.head,
)?;
Ok(PipelineData::ByteStream(
ByteStream::child(child, call.head),
None,
))
}
fn examples(&self) -> Vec<Example> {
vec![
Example {
description: "Run an external command",
example: r#"run-external "echo" "-n" "hello""#,
result: None,
},
Example {
description: "Redirect stdout from an external command into the pipeline",
example: r#"run-external "echo" "-n" "hello" | split chars"#,
result: None,
},
Example {
description: "Redirect stderr from an external command into the pipeline",
example: r#"run-external "nu" "-c" "print -e hello" e>| split chars"#,
result: None,
},
]
}
}
pub fn eval_arguments_from_call(
engine_state: &EngineState,
stack: &mut Stack,
call: &Call,
) -> Result<Vec<Spanned<OsString>>, ShellError> {
let cwd = engine_state.cwd(Some(stack))?;
let eval_expression = get_eval_expression(engine_state);
let call_args = call.rest_iter_flattened(engine_state, stack, eval_expression, 1)?;
let mut args: Vec<Spanned<OsString>> = Vec::with_capacity(call_args.len());
for arg in call_args {
let span = arg.span();
match arg {
Value::Glob { val, no_expand, .. } if !no_expand => args.extend(
expand_glob(&val, cwd.as_std_path(), span, engine_state.signals())?
.into_iter()
.map(|s| s.into_spanned(span)),
),
other => args
.push(OsString::from(coerce_into_string(engine_state, other)?).into_spanned(span)),
}
}
Ok(args)
}
fn coerce_into_string(engine_state: &EngineState, val: Value) -> Result<String, ShellError> {
match val {
Value::List { .. } => Err(ShellError::CannotPassListToExternal {
arg: String::from_utf8_lossy(engine_state.get_span_contents(val.span())).into_owned(),
span: val.span(),
}),
Value::Glob { val, .. } => Ok(val),
_ => val.coerce_into_string(),
}
}
fn expand_glob(
arg: &str,
cwd: &Path,
span: Span,
signals: &Signals,
) -> Result<Vec<OsString>, ShellError> {
const GLOB_CHARS: &[char] = &['*', '?', '['];
if !arg.contains(GLOB_CHARS) {
let path = expand_ndots_safe(expand_tilde(arg));
return Ok(vec![path.into()]);
}
let glob = NuGlob::Expand(arg.to_owned()).into_spanned(span);
if let Ok((prefix, matches)) = nu_engine::glob_from(&glob, cwd, span, None) {
let mut result: Vec<OsString> = vec![];
for m in matches {
signals.check(span)?;
if let Ok(arg) = m {
let arg = resolve_globbed_path_to_cwd_relative(arg, prefix.as_ref(), cwd);
result.push(arg.into());
} else {
result.push(arg.into());
}
}
if result.is_empty() {
result.push(arg.into());
}
Ok(result)
} else {
Ok(vec![arg.into()])
}
}
fn resolve_globbed_path_to_cwd_relative(
path: PathBuf,
prefix: Option<&PathBuf>,
cwd: &Path,
) -> PathBuf {
if let Some(prefix) = prefix {
if let Ok(remainder) = path.strip_prefix(prefix) {
let new_prefix = if let Some(pfx) = diff_paths(prefix, cwd) {
pfx
} else {
prefix.to_path_buf()
};
new_prefix.join(remainder)
} else {
path
}
} else {
path
}
}
fn write_pipeline_data(
mut engine_state: EngineState,
mut stack: Stack,
data: PipelineData,
mut writer: impl Write,
) -> Result<(), ShellError> {
if let PipelineData::ByteStream(stream, ..) = data {
stream.write_to(writer)?;
} else if let PipelineData::Value(Value::Binary { val, .. }, ..) = data {
writer.write_all(&val)?;
} else {
stack.start_capture();
Arc::make_mut(&mut engine_state.config).use_ansi_coloring = false;
let output =
crate::Table.run(&engine_state, &mut stack, &Call::new(Span::unknown()), data)?;
for value in output {
let bytes = value.coerce_into_binary()?;
writer.write_all(&bytes)?;
}
}
Ok(())
}
pub fn command_not_found(
name: &str,
span: Span,
engine_state: &EngineState,
stack: &mut Stack,
) -> ShellError {
if let Some(hook) = &stack.get_config(engine_state).hooks.command_not_found {
let mut stack = stack.start_capture();
let canary = "ENTERED_COMMAND_NOT_FOUND";
if stack.has_env_var(engine_state, canary) {
return ShellError::ExternalCommand {
label: format!(
"Command {name} not found while running the `command_not_found` hook"
),
help: "Make sure the `command_not_found` hook itself does not use unknown commands"
.into(),
span,
};
}
stack.add_env_var(canary.into(), Value::bool(true, Span::unknown()));
let output = eval_hook(
&mut engine_state.clone(),
&mut stack,
None,
vec![("cmd_name".into(), Value::string(name, span))],
hook,
"command_not_found",
);
stack.remove_env_var(engine_state, canary);
match output {
Ok(PipelineData::Value(Value::String { val, .. }, ..)) => {
return ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: val,
span,
};
}
Err(err) => {
return err;
}
_ => {
}
}
}
if let Some(replacement) = crate::removed_commands().get(&name.to_lowercase()) {
return ShellError::RemovedCommand {
removed: name.to_lowercase(),
replacement: replacement.clone(),
span,
};
}
if let Some(module) = engine_state.which_module_has_decl(name.as_bytes(), &[]) {
let module = String::from_utf8_lossy(module);
let full_name = format!("{module} {name}");
if engine_state.find_decl(full_name.as_bytes(), &[]).is_some() {
return ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: format!("Did you mean `{full_name}`?"),
span,
};
} else {
return ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: format!("A command with that name exists in module `{module}`. Try importing it with `use`"),
span,
};
}
}
let signatures = engine_state.get_signatures(false);
if let Some(sig) = signatures.iter().find(|sig| {
sig.search_terms
.iter()
.any(|term| term.to_folded_case() == name.to_folded_case())
}) {
return ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: format!("Did you mean `{}`?", sig.name),
span,
};
}
if let Some(cmd) = did_you_mean(signatures.iter().map(|sig| &sig.name), name) {
if cmd == name {
return ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: "There is a built-in command with the same name".into(),
span,
};
}
return ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: format!("Did you mean `{cmd}`?"),
span,
};
}
ShellError::ExternalCommand {
label: format!("Command `{name}` not found"),
help: format!("`{name}` is neither a Nushell built-in or a known external command"),
span,
}
}
pub fn which(name: impl AsRef<OsStr>, paths: &str, cwd: &Path) -> Option<PathBuf> {
#[cfg(windows)]
let paths = format!("{};{}", cwd.display(), paths);
which::which_in(name, Some(paths), cwd).ok()
}
fn is_cmd_internal_command(name: &str) -> bool {
const COMMANDS: &[&str] = &[
"ASSOC", "CLS", "ECHO", "FTYPE", "MKLINK", "PAUSE", "START", "VER", "VOL",
];
COMMANDS.iter().any(|cmd| cmd.eq_ignore_ascii_case(name))
}
fn has_cmd_special_character(s: impl AsRef<[u8]>) -> bool {
s.as_ref()
.iter()
.any(|b| matches!(b, b'<' | b'>' | b'&' | b'|' | b'^'))
}
#[cfg_attr(not(windows), allow(dead_code))]
fn escape_cmd_argument(arg: &Spanned<OsString>) -> Result<Cow<'_, OsStr>, ShellError> {
let Spanned { item: arg, span } = arg;
let bytes = arg.as_encoded_bytes();
if bytes.iter().any(|b| matches!(b, b'\r' | b'\n' | b'%')) {
Err(ShellError::ExternalCommand {
label:
"Arguments to CMD internal commands cannot contain new lines or percent signs '%'"
.into(),
help: "some characters currently cannot be securely escaped".into(),
span: *span,
})
} else if bytes.contains(&b'"') {
if bytes.iter().filter(|b| **b == b'"').count() == 2
&& bytes.starts_with(b"\"")
&& bytes.ends_with(b"\"")
{
Ok(Cow::Borrowed(arg))
} else {
Err(ShellError::ExternalCommand {
label: "Arguments to CMD internal commands cannot contain embedded double quotes"
.into(),
help: "this case currently cannot be securely handled".into(),
span: *span,
})
}
} else if bytes.contains(&b' ') || has_cmd_special_character(bytes) {
let mut new_str = OsString::new();
new_str.push("\"");
new_str.push(arg);
new_str.push("\"");
Ok(Cow::Owned(new_str))
} else {
Ok(Cow::Borrowed(arg))
}
}
fn expand_ndots_safe(path: impl AsRef<Path>) -> PathBuf {
let string = path.as_ref().to_string_lossy();
if string.contains("...") && !string.contains("://") {
expand_ndots(path)
} else {
path.as_ref().to_owned()
}
}
#[cfg(test)]
mod test {
use super::*;
use nu_test_support::{fs::Stub, playground::Playground};
#[test]
fn test_expand_glob() {
Playground::setup("test_expand_glob", |dirs, play| {
play.with_files(&[Stub::EmptyFile("a.txt"), Stub::EmptyFile("b.txt")]);
let cwd = dirs.test().as_std_path();
let actual = expand_glob("*.txt", cwd, Span::unknown(), &Signals::empty()).unwrap();
let expected = &["a.txt", "b.txt"];
assert_eq!(actual, expected);
let actual = expand_glob("./*.txt", cwd, Span::unknown(), &Signals::empty()).unwrap();
assert_eq!(actual, expected);
let actual = expand_glob("'*.txt'", cwd, Span::unknown(), &Signals::empty()).unwrap();
let expected = &["'*.txt'"];
assert_eq!(actual, expected);
let actual = expand_glob(".", cwd, Span::unknown(), &Signals::empty()).unwrap();
let expected = &["."];
assert_eq!(actual, expected);
let actual = expand_glob("./a.txt", cwd, Span::unknown(), &Signals::empty()).unwrap();
let expected = &["./a.txt"];
assert_eq!(actual, expected);
let actual = expand_glob("[*.txt", cwd, Span::unknown(), &Signals::empty()).unwrap();
let expected = &["[*.txt"];
assert_eq!(actual, expected);
let actual = expand_glob("~/foo.txt", cwd, Span::unknown(), &Signals::empty()).unwrap();
let home = dirs::home_dir().expect("failed to get home dir");
let expected: Vec<OsString> = vec![home.join("foo.txt").into()];
assert_eq!(actual, expected);
})
}
#[test]
fn test_write_pipeline_data() {
let engine_state = EngineState::new();
let stack = Stack::new();
let mut buf = vec![];
let input = PipelineData::Empty;
write_pipeline_data(engine_state.clone(), stack.clone(), input, &mut buf).unwrap();
assert_eq!(buf, b"");
let mut buf = vec![];
let input = PipelineData::Value(Value::string("foo", Span::unknown()), None);
write_pipeline_data(engine_state.clone(), stack.clone(), input, &mut buf).unwrap();
assert_eq!(buf, b"foo");
let mut buf = vec![];
let input = PipelineData::Value(Value::binary(b"foo", Span::unknown()), None);
write_pipeline_data(engine_state.clone(), stack.clone(), input, &mut buf).unwrap();
assert_eq!(buf, b"foo");
let mut buf = vec![];
let input = PipelineData::ByteStream(
ByteStream::read(
b"foo".as_slice(),
Span::unknown(),
Signals::empty(),
ByteStreamType::Unknown,
),
None,
);
write_pipeline_data(engine_state.clone(), stack.clone(), input, &mut buf).unwrap();
assert_eq!(buf, b"foo");
}
}