morpho_rs_api/

client.rs

//! Vault client implementations for V1 and V2 vaults.

use alloy::primitives::{Address, U256};
use alloy::rpc::types::TransactionReceipt;
use graphql_client::{GraphQLQuery, Response};
use morpho_rs_contracts::{VaultV1TransactionClient, VaultV2TransactionClient};
use reqwest::Client;
use url::Url;

use crate::error::{ApiError, Result};
use crate::filters::{VaultFiltersV1, VaultFiltersV2, VaultQueryOptionsV1, VaultQueryOptionsV2};
use crate::types::ordering::{OrderDirection, VaultOrderByV1, VaultOrderByV2};
use crate::queries::v1::{
    get_vault_v1_by_address, get_vaults_v1, GetVaultV1ByAddress, GetVaultsV1,
};
use crate::queries::user::{
    get_user_account_overview, get_user_vault_positions, GetUserAccountOverview,
    GetUserVaultPositions,
};
use crate::queries::v2::{
    get_vault_v2_by_address, get_vaults_v2, GetVaultV2ByAddress, GetVaultsV2,
};
use crate::types::{
    Asset, MarketInfo, NamedChain, UserAccountOverview, UserMarketPosition, UserState,
    UserVaultPositions, UserVaultV1Position, UserVaultV2Position, Vault, VaultAdapter,
    VaultAllocation, VaultAllocator, VaultInfo, VaultPositionState, VaultReward, VaultStateV1,
    VaultV1, VaultV2, VaultV2Warning, VaultWarning, SUPPORTED_CHAINS,
};

/// Default Morpho GraphQL API endpoint.
pub const DEFAULT_API_URL: &str = "https://api.morpho.org/graphql";

/// Default page size for paginated queries.
pub const DEFAULT_PAGE_SIZE: i64 = 100;

/// Configuration for vault clients.
#[derive(Debug, Clone)]
pub struct ClientConfig {
    /// GraphQL API URL.
    pub api_url: Url,
    /// Default page size for queries.
    pub page_size: i64,
}

impl Default for ClientConfig {
    fn default() -> Self {
        Self {
            api_url: Url::parse(DEFAULT_API_URL).expect("Invalid default API URL"),
            page_size: DEFAULT_PAGE_SIZE,
        }
    }
}

impl ClientConfig {
    /// Create a new configuration with default values.
    pub fn new() -> Self {
        Self::default()
    }

    /// Set a custom API URL.
    pub fn with_api_url(mut self, url: Url) -> Self {
        self.api_url = url;
        self
    }

    /// Set a custom page size.
    pub fn with_page_size(mut self, size: i64) -> Self {
        self.page_size = size;
        self
    }
}

/// Client for querying V1 (MetaMorpho) vaults.
#[derive(Debug, Clone)]
pub struct VaultV1Client {
    http_client: Client,
    config: ClientConfig,
}

impl Default for VaultV1Client {
    fn default() -> Self {
        Self::new()
    }
}

impl VaultV1Client {
    /// Create a new V1 vault client with default configuration.
    pub fn new() -> Self {
        Self {
            http_client: Client::new(),
            config: ClientConfig::default(),
        }
    }

    /// Create a new V1 vault client with custom configuration.
    pub fn with_config(config: ClientConfig) -> Self {
        Self {
            http_client: Client::new(),
            config,
        }
    }

    /// Execute a GraphQL query.
    async fn execute<Q: GraphQLQuery>(
        &self,
        variables: Q::Variables,
    ) -> Result<Q::ResponseData> {
        let request_body = Q::build_query(variables);
        let response = self
            .http_client
            .post(self.config.api_url.as_str())
            .json(&request_body)
            .send()
            .await?;

        let response_body: Response<Q::ResponseData> = response.json().await?;

        if let Some(errors) = response_body.errors {
            if !errors.is_empty() {
                return Err(ApiError::GraphQL(
                    errors
                        .iter()
                        .map(|e| e.message.clone())
                        .collect::<Vec<_>>()
                        .join("; "),
                ));
            }
        }

        response_body
            .data
            .ok_or_else(|| ApiError::Parse("No data in response".to_string()))
    }

    /// Get V1 vaults with optional filters.
    pub async fn get_vaults(&self, filters: Option<VaultFiltersV1>) -> Result<Vec<VaultV1>> {
        let variables = get_vaults_v1::Variables {
            first: Some(self.config.page_size),
            skip: Some(0),
            where_: filters.map(|f| f.to_gql()),
            order_by: Some(VaultOrderByV1::default().to_gql()),
            order_direction: Some(OrderDirection::default().to_gql_v1()),
        };

        let data = self.execute::<GetVaultsV1>(variables).await?;

        let items = match data.vaults.items {
            Some(items) => items,
            None => return Ok(Vec::new()),
        };

        let vaults: Vec<VaultV1> = items
            .into_iter()
            .filter_map(convert_v1_vault)
            .collect();

        Ok(vaults)
    }

    /// Get a single V1 vault by address and chain.
    pub async fn get_vault(&self, address: &str, chain: NamedChain) -> Result<VaultV1> {
        let variables = get_vault_v1_by_address::Variables {
            address: address.to_string(),
            chain_id: u64::from(chain) as i64,
        };

        let data = self.execute::<GetVaultV1ByAddress>(variables).await?;

        convert_v1_vault_single(data.vault_by_address).ok_or_else(|| ApiError::VaultNotFound {
            address: address.to_string(),
            chain_id: u64::from(chain) as i64,
        })
    }

    /// Get V1 vaults on a specific chain.
    pub async fn get_vaults_by_chain(&self, chain: NamedChain) -> Result<Vec<VaultV1>> {
        let filters = VaultFiltersV1::new().chain(chain);
        self.get_vaults(Some(filters)).await
    }

    /// Get V1 vaults by curator address.
    pub async fn get_vaults_by_curator(
        &self,
        curator: &str,
        chain: Option<NamedChain>,
    ) -> Result<Vec<VaultV1>> {
        let mut filters = VaultFiltersV1::new().curators([curator]);
        if let Some(c) = chain {
            filters = filters.chain(c);
        }
        self.get_vaults(Some(filters)).await
    }

    /// Get whitelisted (listed) V1 vaults.
    pub async fn get_whitelisted_vaults(&self, chain: Option<NamedChain>) -> Result<Vec<VaultV1>> {
        let mut filters = VaultFiltersV1::new().listed(true);
        if let Some(c) = chain {
            filters = filters.chain(c);
        }
        self.get_vaults(Some(filters)).await
    }

    /// Get V1 vaults with query options (filters, ordering, and limit).
    ///
    /// This method provides full control over the query parameters including
    /// ordering by various fields like APY, total assets, etc.
    ///
    /// # Example
    ///
    /// ```no_run
    /// use morpho_rs_api::{VaultV1Client, VaultQueryOptionsV1, VaultFiltersV1, VaultOrderByV1, OrderDirection, NamedChain};
    ///
    /// #[tokio::main]
    /// async fn main() -> Result<(), morpho_rs_api::ApiError> {
    ///     let client = VaultV1Client::new();
    ///
    ///     // Get top 10 USDC vaults by APY on Ethereum
    ///     let options = VaultQueryOptionsV1::new()
    ///         .filters(VaultFiltersV1::new()
    ///             .chain(NamedChain::Mainnet)
    ///             .asset_symbols(["USDC"]))
    ///         .order_by(VaultOrderByV1::NetApy)
    ///         .order_direction(OrderDirection::Desc)
    ///         .limit(10);
    ///
    ///     let vaults = client.get_vaults_with_options(options).await?;
    ///     Ok(())
    /// }
    /// ```
    pub async fn get_vaults_with_options(
        &self,
        options: VaultQueryOptionsV1,
    ) -> Result<Vec<VaultV1>> {
        let variables = get_vaults_v1::Variables {
            first: options.limit.or(Some(self.config.page_size)),
            skip: Some(0),
            where_: options.filters.map(|f| f.to_gql()),
            order_by: Some(options.order_by.unwrap_or_default().to_gql()),
            order_direction: Some(options.order_direction.unwrap_or_default().to_gql_v1()),
        };

        let data = self.execute::<GetVaultsV1>(variables).await?;

        let items = match data.vaults.items {
            Some(items) => items,
            None => return Ok(Vec::new()),
        };

        let vaults: Vec<VaultV1> = items
            .into_iter()
            .filter_map(convert_v1_vault)
            .collect();

        Ok(vaults)
    }

    /// Get top N V1 vaults ordered by APY (highest first).
    ///
    /// # Example
    ///
    /// ```no_run
    /// use morpho_rs_api::{VaultV1Client, VaultFiltersV1, NamedChain};
    ///
    /// #[tokio::main]
    /// async fn main() -> Result<(), morpho_rs_api::ApiError> {
    ///     let client = VaultV1Client::new();
    ///
    ///     // Get top 10 vaults by APY on Ethereum
    ///     let filters = VaultFiltersV1::new().chain(NamedChain::Mainnet);
    ///     let vaults = client.get_top_vaults_by_apy(10, Some(filters)).await?;
    ///     Ok(())
    /// }
    /// ```
    pub async fn get_top_vaults_by_apy(
        &self,
        limit: i64,
        filters: Option<VaultFiltersV1>,
    ) -> Result<Vec<VaultV1>> {
        let options = VaultQueryOptionsV1 {
            filters,
            order_by: Some(VaultOrderByV1::NetApy),
            order_direction: Some(OrderDirection::Desc),
            limit: Some(limit),
        };
        self.get_vaults_with_options(options).await
    }

    /// Get V1 vaults for a specific deposit asset.
    ///
    /// # Example
    ///
    /// ```no_run
    /// use morpho_rs_api::{VaultV1Client, NamedChain};
    ///
    /// #[tokio::main]
    /// async fn main() -> Result<(), morpho_rs_api::ApiError> {
    ///     let client = VaultV1Client::new();
    ///
    ///     // Get all USDC vaults
    ///     let vaults = client.get_vaults_by_asset("USDC", None).await?;
    ///     Ok(())
    /// }
    /// ```
    pub async fn get_vaults_by_asset(
        &self,
        asset_symbol: &str,
        chain: Option<NamedChain>,
    ) -> Result<Vec<VaultV1>> {
        let mut filters = VaultFiltersV1::new().asset_symbols([asset_symbol]);
        if let Some(c) = chain {
            filters = filters.chain(c);
        }
        self.get_vaults(Some(filters)).await
    }
}

/// Client for querying V2 vaults.
#[derive(Debug, Clone)]
pub struct VaultV2Client {
    http_client: Client,
    config: ClientConfig,
}

impl Default for VaultV2Client {
    fn default() -> Self {
        Self::new()
    }
}

impl VaultV2Client {
    /// Create a new V2 vault client with default configuration.
    pub fn new() -> Self {
        Self {
            http_client: Client::new(),
            config: ClientConfig::default(),
        }
    }

    /// Create a new V2 vault client with custom configuration.
    pub fn with_config(config: ClientConfig) -> Self {
        Self {
            http_client: Client::new(),
            config,
        }
    }

    /// Execute a GraphQL query.
    async fn execute<Q: GraphQLQuery>(
        &self,
        variables: Q::Variables,
    ) -> Result<Q::ResponseData> {
        let request_body = Q::build_query(variables);
        let response = self
            .http_client
            .post(self.config.api_url.as_str())
            .json(&request_body)
            .send()
            .await?;

        let response_body: Response<Q::ResponseData> = response.json().await?;

        if let Some(errors) = response_body.errors {
            if !errors.is_empty() {
                return Err(ApiError::GraphQL(
                    errors
                        .iter()
                        .map(|e| e.message.clone())
                        .collect::<Vec<_>>()
                        .join("; "),
                ));
            }
        }

        response_body
            .data
            .ok_or_else(|| ApiError::Parse("No data in response".to_string()))
    }

    /// Get V2 vaults with optional filters.
    pub async fn get_vaults(&self, filters: Option<VaultFiltersV2>) -> Result<Vec<VaultV2>> {
        let variables = get_vaults_v2::Variables {
            first: Some(self.config.page_size),
            skip: Some(0),
            where_: filters.map(|f| f.to_gql()),
            order_by: Some(VaultOrderByV2::default().to_gql()),
            order_direction: Some(OrderDirection::default().to_gql_v2()),
        };

        let data = self.execute::<GetVaultsV2>(variables).await?;

        let items = match data.vault_v2s.items {
            Some(items) => items,
            None => return Ok(Vec::new()),
        };

        let vaults: Vec<VaultV2> = items
            .into_iter()
            .filter_map(convert_v2_vault)
            .collect();

        Ok(vaults)
    }

    /// Get a single V2 vault by address and chain.
    pub async fn get_vault(&self, address: &str, chain: NamedChain) -> Result<VaultV2> {
        let variables = get_vault_v2_by_address::Variables {
            address: address.to_string(),
            chain_id: u64::from(chain) as i64,
        };

        let data = self.execute::<GetVaultV2ByAddress>(variables).await?;

        convert_v2_vault_single(data.vault_v2_by_address).ok_or_else(|| ApiError::VaultNotFound {
            address: address.to_string(),
            chain_id: u64::from(chain) as i64,
        })
    }

    /// Get V2 vaults on a specific chain.
    pub async fn get_vaults_by_chain(&self, chain: NamedChain) -> Result<Vec<VaultV2>> {
        let filters = VaultFiltersV2::new().chain(chain);
        self.get_vaults(Some(filters)).await
    }

    /// Get whitelisted (listed) V2 vaults.
    pub async fn get_whitelisted_vaults(&self, chain: Option<NamedChain>) -> Result<Vec<VaultV2>> {
        let mut filters = VaultFiltersV2::new().listed(true);
        if let Some(c) = chain {
            filters = filters.chain(c);
        }
        self.get_vaults(Some(filters)).await
    }

    /// Get V2 vaults with query options (filters, ordering, and limit).
    ///
    /// This method provides full control over the query parameters including
    /// ordering by various fields like APY, total assets, liquidity, etc.
    ///
    /// Note: Asset filtering (by symbol or address) is done client-side since
    /// the Morpho V2 API doesn't support server-side asset filtering.
    ///
    /// # Example
    ///
    /// ```no_run
    /// use morpho_rs_api::{VaultV2Client, VaultQueryOptionsV2, VaultFiltersV2, VaultOrderByV2, OrderDirection, NamedChain};
    ///
    /// #[tokio::main]
    /// async fn main() -> Result<(), morpho_rs_api::ApiError> {
    ///     let client = VaultV2Client::new();
    ///
    ///     // Get top 10 USDC vaults by APY on Ethereum
    ///     let options = VaultQueryOptionsV2::new()
    ///         .filters(VaultFiltersV2::new()
    ///             .chain(NamedChain::Mainnet))
    ///         .order_by(VaultOrderByV2::NetApy)
    ///         .order_direction(OrderDirection::Desc)
    ///         .asset_symbols(["USDC"])  // Client-side filtering
    ///         .limit(10);
    ///
    ///     let vaults = client.get_vaults_with_options(options).await?;
    ///     Ok(())
    /// }
    /// ```
    pub async fn get_vaults_with_options(
        &self,
        options: VaultQueryOptionsV2,
    ) -> Result<Vec<VaultV2>> {
        // When using client-side asset filtering, we may need to fetch more results
        // to ensure we have enough after filtering
        let fetch_limit = if options.has_asset_filter() {
            // Fetch more if we're going to filter client-side
            options.limit.map(|l| l * 3).or(Some(self.config.page_size))
        } else {
            options.limit.or(Some(self.config.page_size))
        };

        let variables = get_vaults_v2::Variables {
            first: fetch_limit,
            skip: Some(0),
            where_: options.filters.map(|f| f.to_gql()),
            order_by: Some(options.order_by.unwrap_or_default().to_gql()),
            order_direction: Some(options.order_direction.unwrap_or_default().to_gql_v2()),
        };

        let data = self.execute::<GetVaultsV2>(variables).await?;

        let items = match data.vault_v2s.items {
            Some(items) => items,
            None => return Ok(Vec::new()),
        };

        let mut vaults: Vec<VaultV2> = items
            .into_iter()
            .filter_map(convert_v2_vault)
            .collect();

        // Apply client-side asset filtering
        if let Some(ref symbols) = options.asset_symbols {
            vaults.retain(|v| symbols.iter().any(|s| s.eq_ignore_ascii_case(&v.asset.symbol)));
        }
        if let Some(ref addresses) = options.asset_addresses {
            vaults.retain(|v| {
                addresses
                    .iter()
                    .any(|a| v.asset.address.to_string().eq_ignore_ascii_case(a))
            });
        }

        // Apply limit after client-side filtering
        if let Some(limit) = options.limit {
            vaults.truncate(limit as usize);
        }

        Ok(vaults)
    }

    /// Get top N V2 vaults ordered by APY (highest first).
    ///
    /// # Example
    ///
    /// ```no_run
    /// use morpho_rs_api::{VaultV2Client, VaultFiltersV2, NamedChain};
    ///
    /// #[tokio::main]
    /// async fn main() -> Result<(), morpho_rs_api::ApiError> {
    ///     let client = VaultV2Client::new();
    ///
    ///     // Get top 10 vaults by APY on Ethereum
    ///     let filters = VaultFiltersV2::new().chain(NamedChain::Mainnet);
    ///     let vaults = client.get_top_vaults_by_apy(10, Some(filters)).await?;
    ///     Ok(())
    /// }
    /// ```
    pub async fn get_top_vaults_by_apy(
        &self,
        limit: i64,
        filters: Option<VaultFiltersV2>,
    ) -> Result<Vec<VaultV2>> {
        let options = VaultQueryOptionsV2 {
            filters,
            order_by: Some(VaultOrderByV2::NetApy),
            order_direction: Some(OrderDirection::Desc),
            limit: Some(limit),
            asset_addresses: None,
            asset_symbols: None,
        };
        self.get_vaults_with_options(options).await
    }

    /// Get V2 vaults for a specific deposit asset.
    ///
    /// Note: This filtering is done client-side since the Morpho V2 API
    /// doesn't support server-side asset filtering.
    ///
    /// # Example
    ///
    /// ```no_run
    /// use morpho_rs_api::{VaultV2Client, NamedChain};
    ///
    /// #[tokio::main]
    /// async fn main() -> Result<(), morpho_rs_api::ApiError> {
    ///     let client = VaultV2Client::new();
    ///
    ///     // Get all USDC vaults
    ///     let vaults = client.get_vaults_by_asset("USDC", None).await?;
    ///     Ok(())
    /// }
    /// ```
    pub async fn get_vaults_by_asset(
        &self,
        asset_symbol: &str,
        chain: Option<NamedChain>,
    ) -> Result<Vec<VaultV2>> {
        let filters = chain.map(|c| VaultFiltersV2::new().chain(c));
        let options = VaultQueryOptionsV2 {
            filters,
            order_by: None,
            order_direction: None,
            limit: None,
            asset_addresses: None,
            asset_symbols: Some(vec![asset_symbol.to_string()]),
        };
        self.get_vaults_with_options(options).await
    }
}

/// Combined client for querying both V1 and V2 vaults via the GraphQL API.
#[derive(Debug, Clone)]
pub struct MorphoApiClient {
    /// V1 vault client.
    pub v1: VaultV1Client,
    /// V2 vault client.
    pub v2: VaultV2Client,
}

impl Default for MorphoApiClient {
    fn default() -> Self {
        Self::new()
    }
}

impl MorphoApiClient {
    /// Create a new combined vault client with default configuration.
    pub fn new() -> Self {
        Self {
            v1: VaultV1Client::new(),
            v2: VaultV2Client::new(),
        }
    }

    /// Create a new combined vault client with custom configuration.
    pub fn with_config(config: ClientConfig) -> Self {
        Self {
            v1: VaultV1Client::with_config(config.clone()),
            v2: VaultV2Client::with_config(config),
        }
    }

    /// Get vaults (V1 and V2) on a specific chain as unified Vault type.
    pub async fn get_vaults_by_chain(&self, chain: NamedChain) -> Result<Vec<Vault>> {
        let (v1_vaults, v2_vaults) = tokio::try_join!(
            self.v1.get_vaults_by_chain(chain),
            self.v2.get_vaults_by_chain(chain),
        )?;

        let mut vaults: Vec<Vault> = Vec::with_capacity(v1_vaults.len() + v2_vaults.len());
        vaults.extend(v1_vaults.into_iter().map(Vault::from));
        vaults.extend(v2_vaults.into_iter().map(Vault::from));

        Ok(vaults)
    }

    /// Get whitelisted vaults (V1 and V2) as unified Vault type.
    pub async fn get_whitelisted_vaults(&self, chain: Option<NamedChain>) -> Result<Vec<Vault>> {
        let (v1_vaults, v2_vaults) = tokio::try_join!(
            self.v1.get_whitelisted_vaults(chain),
            self.v2.get_whitelisted_vaults(chain),
        )?;

        let mut vaults: Vec<Vault> = Vec::with_capacity(v1_vaults.len() + v2_vaults.len());
        vaults.extend(v1_vaults.into_iter().map(Vault::from));
        vaults.extend(v2_vaults.into_iter().map(Vault::from));

        Ok(vaults)
    }

    /// Execute a GraphQL query.
    async fn execute<Q: GraphQLQuery>(&self, variables: Q::Variables) -> Result<Q::ResponseData> {
        let request_body = Q::build_query(variables);
        let response = self
            .v1
            .http_client
            .post(self.v1.config.api_url.as_str())
            .json(&request_body)
            .send()
            .await?;

        let response_body: Response<Q::ResponseData> = response.json().await?;

        if let Some(errors) = response_body.errors {
            if !errors.is_empty() {
                return Err(ApiError::GraphQL(
                    errors
                        .iter()
                        .map(|e| e.message.clone())
                        .collect::<Vec<_>>()
                        .join("; "),
                ));
            }
        }

        response_body
            .data
            .ok_or_else(|| ApiError::Parse("No data in response".to_string()))
    }

    /// Get all vault positions (V1 and V2) for a user.
    ///
    /// If `chain` is `Some`, queries only that chain.
    /// If `chain` is `None`, queries all supported chains and aggregates results.
    pub async fn get_user_vault_positions(
        &self,
        address: &str,
        chain: Option<NamedChain>,
    ) -> Result<UserVaultPositions> {
        match chain {
            Some(c) => self.get_user_vault_positions_single_chain(address, c).await,
            None => self.get_user_vault_positions_all_chains(address).await,
        }
    }

    /// Get vault positions for a user on a single chain.
    async fn get_user_vault_positions_single_chain(
        &self,
        address: &str,
        chain: NamedChain,
    ) -> Result<UserVaultPositions> {
        let variables = get_user_vault_positions::Variables {
            address: address.to_string(),
            chain_id: u64::from(chain) as i64,
        };

        let data = self.execute::<GetUserVaultPositions>(variables).await?;
        let user = data.user_by_address;

        let vault_positions: Vec<UserVaultV1Position> = user
            .vault_positions
            .into_iter()
            .filter_map(convert_user_vault_v1_position)
            .collect();

        let vault_v2_positions: Vec<UserVaultV2Position> = user
            .vault_v2_positions
            .into_iter()
            .filter_map(convert_user_vault_v2_position)
            .collect();

        Ok(UserVaultPositions {
            address: user
                .address
                .parse()
                .map_err(|_| ApiError::Parse("Invalid address".to_string()))?,
            vault_positions,
            vault_v2_positions,
        })
    }

    /// Get vault positions for a user across all chains.
    async fn get_user_vault_positions_all_chains(
        &self,
        address: &str,
    ) -> Result<UserVaultPositions> {
        use futures::future::join_all;

        // Filter chains to those with IDs that fit in GraphQL Int (32-bit signed)
        let valid_chains: Vec<_> = SUPPORTED_CHAINS
            .iter()
            .filter(|chain| u64::from(**chain) <= i32::MAX as u64)
            .copied()
            .collect();

        let futures: Vec<_> = valid_chains
            .iter()
            .map(|chain| self.get_user_vault_positions_single_chain(address, *chain))
            .collect();

        let results = join_all(futures).await;

        let parsed_address = address
            .parse()
            .map_err(|_| ApiError::Parse("Invalid address".to_string()))?;

        let mut all_v1_positions = Vec::new();
        let mut all_v2_positions = Vec::new();

        for result in results {
            match result {
                Ok(positions) => {
                    all_v1_positions.extend(positions.vault_positions);
                    all_v2_positions.extend(positions.vault_v2_positions);
                }
                // Ignore "No results" errors - user just has no positions on that chain
                Err(ApiError::GraphQL(msg)) if msg.contains("No results") => continue,
                Err(e) => return Err(e),
            }
        }

        Ok(UserVaultPositions {
            address: parsed_address,
            vault_positions: all_v1_positions,
            vault_v2_positions: all_v2_positions,
        })
    }

    /// Get complete account overview for a user on a specific chain.
    pub async fn get_user_account_overview(
        &self,
        address: &str,
        chain: NamedChain,
    ) -> Result<UserAccountOverview> {
        let variables = get_user_account_overview::Variables {
            address: address.to_string(),
            chain_id: u64::from(chain) as i64,
        };

        let data = self.execute::<GetUserAccountOverview>(variables).await?;
        let user = data.user_by_address;

        let state = UserState::from_gql(
            user.state.vaults_pnl_usd,
            user.state.vaults_roe_usd,
            user.state.vaults_assets_usd,
            user.state.vault_v2s_pnl_usd,
            user.state.vault_v2s_roe_usd,
            user.state.vault_v2s_assets_usd,
            user.state.markets_pnl_usd,
            user.state.markets_roe_usd,
            user.state.markets_supply_pnl_usd,
            user.state.markets_supply_roe_usd,
            user.state.markets_borrow_pnl_usd,
            user.state.markets_borrow_roe_usd,
            user.state.markets_collateral_pnl_usd,
            user.state.markets_collateral_roe_usd,
            user.state.markets_margin_pnl_usd,
            user.state.markets_margin_roe_usd,
            user.state.markets_collateral_usd,
            user.state.markets_supply_assets_usd,
            user.state.markets_borrow_assets_usd,
            user.state.markets_margin_usd,
        );

        let vault_positions: Vec<UserVaultV1Position> = user
            .vault_positions
            .into_iter()
            .filter_map(convert_user_vault_v1_position_overview)
            .collect();

        let vault_v2_positions: Vec<UserVaultV2Position> = user
            .vault_v2_positions
            .into_iter()
            .filter_map(convert_user_vault_v2_position_overview)
            .collect();

        let market_positions: Vec<UserMarketPosition> = user
            .market_positions
            .into_iter()
            .filter_map(convert_user_market_position)
            .collect();

        Ok(UserAccountOverview {
            address: user
                .address
                .parse()
                .map_err(|_| ApiError::Parse("Invalid address".to_string()))?,
            state,
            vault_positions,
            vault_v2_positions,
            market_positions,
        })
    }
}

/// Configuration for the unified MorphoClient.
#[derive(Debug, Clone)]
pub struct MorphoClientConfig {
    /// API configuration.
    pub api_config: Option<ClientConfig>,
    /// RPC URL for on-chain interactions.
    pub rpc_url: Option<String>,
    /// Private key for signing transactions.
    pub private_key: Option<String>,
    /// Whether to automatically approve tokens before deposit if allowance is insufficient.
    /// When true, approves the exact minimal amount needed for the deposit.
    /// Defaults to true.
    pub auto_approve: bool,
}

impl Default for MorphoClientConfig {
    fn default() -> Self {
        Self {
            api_config: None,
            rpc_url: None,
            private_key: None,
            auto_approve: true,
        }
    }
}

impl MorphoClientConfig {
    /// Create a new configuration with default values.
    pub fn new() -> Self {
        Self::default()
    }

    /// Set the API configuration.
    pub fn with_api_config(mut self, config: ClientConfig) -> Self {
        self.api_config = Some(config);
        self
    }

    /// Set the RPC URL.
    pub fn with_rpc_url(mut self, rpc_url: impl Into<String>) -> Self {
        self.rpc_url = Some(rpc_url.into());
        self
    }

    /// Set the private key.
    pub fn with_private_key(mut self, private_key: impl Into<String>) -> Self {
        self.private_key = Some(private_key.into());
        self
    }

    /// Set whether to automatically approve tokens before deposit.
    /// When true, approves the exact minimal amount needed for the deposit.
    /// Defaults to true.
    pub fn with_auto_approve(mut self, auto_approve: bool) -> Self {
        self.auto_approve = auto_approve;
        self
    }
}

/// Wrapper for V1 vault operations that automatically uses the signer's address.
pub struct VaultV1Operations<'a> {
    client: &'a VaultV1TransactionClient,
    auto_approve: bool,
}

impl<'a> VaultV1Operations<'a> {
    /// Create a new V1 operations wrapper.
    fn new(client: &'a VaultV1TransactionClient, auto_approve: bool) -> Self {
        Self { client, auto_approve }
    }

    /// Deposit assets into a vault, receiving shares to the signer's address.
    ///
    /// If `auto_approve` is enabled (default), this will check the current allowance
    /// and approve the exact minimal amount needed for the deposit if insufficient.
    pub async fn deposit(&self, vault: Address, amount: U256) -> Result<TransactionReceipt> {
        if self.auto_approve {
            let asset = self.client.get_asset(vault).await?;
            let current_allowance = self
                .client
                .get_allowance(asset, self.client.signer_address(), vault)
                .await?;
            if current_allowance < amount {
                let needed = amount - current_allowance;
                self.client.approve_if_needed(asset, vault, needed).await?;
            }
        }

        let receipt = self
            .client
            .deposit(vault, amount, self.client.signer_address())
            .await?;
        Ok(receipt)
    }

    /// Withdraw assets from a vault to the signer's address (withdrawing signer's shares).
    pub async fn withdraw(&self, vault: Address, amount: U256) -> Result<TransactionReceipt> {
        let signer = self.client.signer_address();
        let receipt = self.client.withdraw(vault, amount, signer, signer).await?;
        Ok(receipt)
    }

    /// Get the signer's vault share balance.
    pub async fn balance(&self, vault: Address) -> Result<U256> {
        let balance = self
            .client
            .get_balance(vault, self.client.signer_address())
            .await?;
        Ok(balance)
    }

    /// Approve a vault to spend the signer's tokens if needed.
    /// Returns the transaction receipt if approval was performed, None if already approved.
    pub async fn approve(
        &self,
        vault: Address,
        amount: U256,
    ) -> Result<Option<TransactionReceipt>> {
        let asset = self.client.get_asset(vault).await?;
        let receipt = self.client.approve_if_needed(asset, vault, amount).await?;
        Ok(receipt)
    }

    /// Get the current allowance for the vault to spend the signer's tokens.
    pub async fn get_allowance(&self, vault: Address) -> Result<U256> {
        let asset = self.client.get_asset(vault).await?;
        let allowance = self
            .client
            .get_allowance(asset, self.client.signer_address(), vault)
            .await?;
        Ok(allowance)
    }

    /// Get the underlying asset address of a vault.
    pub async fn get_asset(&self, vault: Address) -> Result<Address> {
        let asset = self.client.get_asset(vault).await?;
        Ok(asset)
    }

    /// Get the decimals of a token.
    pub async fn get_decimals(&self, token: Address) -> Result<u8> {
        let decimals = self.client.get_decimals(token).await?;
        Ok(decimals)
    }

    /// Get the signer's address.
    pub fn signer_address(&self) -> Address {
        self.client.signer_address()
    }

    /// Check if auto_approve is enabled.
    pub fn auto_approve(&self) -> bool {
        self.auto_approve
    }
}

/// Wrapper for V2 vault operations that automatically uses the signer's address.
pub struct VaultV2Operations<'a> {
    client: &'a VaultV2TransactionClient,
    auto_approve: bool,
}

impl<'a> VaultV2Operations<'a> {
    /// Create a new V2 operations wrapper.
    fn new(client: &'a VaultV2TransactionClient, auto_approve: bool) -> Self {
        Self { client, auto_approve }
    }

    /// Deposit assets into a vault, receiving shares to the signer's address.
    ///
    /// If `auto_approve` is enabled (default), this will check the current allowance
    /// and approve the exact minimal amount needed for the deposit if insufficient.
    pub async fn deposit(&self, vault: Address, amount: U256) -> Result<TransactionReceipt> {
        if self.auto_approve {
            let asset = self.client.get_asset(vault).await?;
            let current_allowance = self
                .client
                .get_allowance(asset, self.client.signer_address(), vault)
                .await?;
            if current_allowance < amount {
                let needed = amount - current_allowance;
                self.client.approve_if_needed(asset, vault, needed).await?;
            }
        }

        let receipt = self
            .client
            .deposit(vault, amount, self.client.signer_address())
            .await?;
        Ok(receipt)
    }

    /// Withdraw assets from a vault to the signer's address (withdrawing signer's shares).
    pub async fn withdraw(&self, vault: Address, amount: U256) -> Result<TransactionReceipt> {
        let signer = self.client.signer_address();
        let receipt = self.client.withdraw(vault, amount, signer, signer).await?;
        Ok(receipt)
    }

    /// Get the signer's vault share balance.
    pub async fn balance(&self, vault: Address) -> Result<U256> {
        let balance = self
            .client
            .get_balance(vault, self.client.signer_address())
            .await?;
        Ok(balance)
    }

    /// Approve a vault to spend the signer's tokens if needed.
    /// Returns the transaction receipt if approval was performed, None if already approved.
    pub async fn approve(
        &self,
        vault: Address,
        amount: U256,
    ) -> Result<Option<TransactionReceipt>> {
        let asset = self.client.get_asset(vault).await?;
        let receipt = self.client.approve_if_needed(asset, vault, amount).await?;
        Ok(receipt)
    }

    /// Get the current allowance for the vault to spend the signer's tokens.
    pub async fn get_allowance(&self, vault: Address) -> Result<U256> {
        let asset = self.client.get_asset(vault).await?;
        let allowance = self
            .client
            .get_allowance(asset, self.client.signer_address(), vault)
            .await?;
        Ok(allowance)
    }

    /// Get the underlying asset address of a vault.
    pub async fn get_asset(&self, vault: Address) -> Result<Address> {
        let asset = self.client.get_asset(vault).await?;
        Ok(asset)
    }

    /// Get the decimals of a token.
    pub async fn get_decimals(&self, token: Address) -> Result<u8> {
        let decimals = self.client.get_decimals(token).await?;
        Ok(decimals)
    }

    /// Get the signer's address.
    pub fn signer_address(&self) -> Address {
        self.client.signer_address()
    }

    /// Check if auto_approve is enabled.
    pub fn auto_approve(&self) -> bool {
        self.auto_approve
    }
}

/// Unified Morpho client combining API queries and on-chain transactions.
///
/// This client provides a namespace-style API for interacting with Morpho vaults:
/// - `client.api()` - Access to GraphQL API queries
/// - `client.vault_v1()` - V1 vault transaction operations
/// - `client.vault_v2()` - V2 vault transaction operations
///
/// # Example
///
/// ```no_run
/// use morpho_rs_api::{MorphoClient, MorphoClientConfig, NamedChain};
/// use alloy::primitives::{Address, U256};
///
/// #[tokio::main]
/// async fn main() -> Result<(), morpho_rs_api::ApiError> {
///     // API-only client
///     let client = MorphoClient::new();
///     let vaults = client.get_vaults_by_chain(NamedChain::Mainnet).await?;
///
///     // Full client with transaction support
///     let config = MorphoClientConfig::new()
///         .with_rpc_url("https://eth.llamarpc.com")
///         .with_private_key("0x...");
///     let client = MorphoClient::with_config(config)?;
///
///     // V1 vault operations
///     let vault: Address = "0x...".parse().unwrap();
///     let balance = client.vault_v1()?.balance(vault).await?;
///
///     Ok(())
/// }
/// ```
pub struct MorphoClient {
    api: MorphoApiClient,
    vault_v1_tx: Option<VaultV1TransactionClient>,
    vault_v2_tx: Option<VaultV2TransactionClient>,
    auto_approve: bool,
}

impl Default for MorphoClient {
    fn default() -> Self {
        Self::new()
    }
}

impl MorphoClient {
    /// Create a new MorphoClient with default API configuration (no transaction support).
    pub fn new() -> Self {
        Self {
            api: MorphoApiClient::new(),
            vault_v1_tx: None,
            vault_v2_tx: None,
            auto_approve: true,
        }
    }

    /// Create a MorphoClient with custom configuration.
    ///
    /// If both `rpc_url` and `private_key` are provided, transaction support is enabled.
    pub fn with_config(config: MorphoClientConfig) -> Result<Self> {
        let api = match config.api_config {
            Some(api_config) => MorphoApiClient::with_config(api_config),
            None => MorphoApiClient::new(),
        };

        let (vault_v1_tx, vault_v2_tx) = match (&config.rpc_url, &config.private_key) {
            (Some(rpc_url), Some(private_key)) => {
                let v1 = VaultV1TransactionClient::new(rpc_url, private_key)?;
                let v2 = VaultV2TransactionClient::new(rpc_url, private_key)?;
                (Some(v1), Some(v2))
            }
            _ => (None, None),
        };

        Ok(Self {
            api,
            vault_v1_tx,
            vault_v2_tx,
            auto_approve: config.auto_approve,
        })
    }

    /// Get V1 vault operations.
    ///
    /// Returns an error if transaction support is not configured.
    pub fn vault_v1(&self) -> Result<VaultV1Operations<'_>> {
        match &self.vault_v1_tx {
            Some(client) => Ok(VaultV1Operations::new(client, self.auto_approve)),
            None => Err(ApiError::TransactionNotConfigured),
        }
    }

    /// Get V2 vault operations.
    ///
    /// Returns an error if transaction support is not configured.
    pub fn vault_v2(&self) -> Result<VaultV2Operations<'_>> {
        match &self.vault_v2_tx {
            Some(client) => Ok(VaultV2Operations::new(client, self.auto_approve)),
            None => Err(ApiError::TransactionNotConfigured),
        }
    }

    /// Check if auto_approve is enabled.
    pub fn auto_approve(&self) -> bool {
        self.auto_approve
    }

    /// Get the API client for GraphQL queries.
    pub fn api(&self) -> &MorphoApiClient {
        &self.api
    }

    /// Get vaults (V1 and V2) on a specific chain as unified Vault type.
    pub async fn get_vaults_by_chain(&self, chain: NamedChain) -> Result<Vec<Vault>> {
        self.api.get_vaults_by_chain(chain).await
    }

    /// Get whitelisted vaults (V1 and V2) as unified Vault type.
    pub async fn get_whitelisted_vaults(&self, chain: Option<NamedChain>) -> Result<Vec<Vault>> {
        self.api.get_whitelisted_vaults(chain).await
    }

    /// Get all vault positions (V1 and V2) for a user.
    pub async fn get_user_vault_positions(
        &self,
        address: &str,
        chain: Option<NamedChain>,
    ) -> Result<UserVaultPositions> {
        self.api.get_user_vault_positions(address, chain).await
    }

    /// Get complete account overview for a user on a specific chain.
    pub async fn get_user_account_overview(
        &self,
        address: &str,
        chain: NamedChain,
    ) -> Result<UserAccountOverview> {
        self.api.get_user_account_overview(address, chain).await
    }

    /// Check if transaction support is configured.
    pub fn has_transaction_support(&self) -> bool {
        self.vault_v1_tx.is_some()
    }

    /// Get the signer's address if transaction support is configured.
    pub fn signer_address(&self) -> Option<Address> {
        self.vault_v1_tx.as_ref().map(|c| c.signer_address())
    }
}

// Conversion functions from GraphQL types to our types

fn convert_v1_vault(v: get_vaults_v1::GetVaultsV1VaultsItems) -> Option<VaultV1> {
    let chain_id = v.chain.id;
    let asset = &v.asset;

    VaultV1::from_gql(
        &v.address,
        v.name,
        v.symbol,
        chain_id,
        v.listed,
        v.featured,
        v.whitelisted,
        Asset::from_gql(
            &asset.address,
            asset.symbol.clone(),
            Some(asset.name.clone()),
            asset.decimals,
            asset.price_usd,
        )?,
        v.state.as_ref().and_then(convert_v1_state),
        v.allocators
            .into_iter()
            .filter_map(|a| VaultAllocator::from_gql(&a.address))
            .collect(),
        v.warnings
            .into_iter()
            .map(|w| VaultWarning {
                warning_type: w.type_.clone(),
                level: format!("{:?}", w.level),
            })
            .collect(),
    )
}

fn convert_v1_vault_single(
    v: get_vault_v1_by_address::GetVaultV1ByAddressVaultByAddress,
) -> Option<VaultV1> {
    let chain_id = v.chain.id;
    let asset = &v.asset;

    VaultV1::from_gql(
        &v.address,
        v.name,
        v.symbol,
        chain_id,
        v.listed,
        v.featured,
        v.whitelisted,
        Asset::from_gql(
            &asset.address,
            asset.symbol.clone(),
            Some(asset.name.clone()),
            asset.decimals,
            asset.price_usd,
        )?,
        v.state.as_ref().and_then(convert_v1_state_single),
        v.allocators
            .into_iter()
            .filter_map(|a| VaultAllocator::from_gql(&a.address))
            .collect(),
        v.warnings
            .into_iter()
            .map(|w| VaultWarning {
                warning_type: w.type_.clone(),
                level: format!("{:?}", w.level),
            })
            .collect(),
    )
}

fn convert_v1_state(s: &get_vaults_v1::GetVaultsV1VaultsItemsState) -> Option<VaultStateV1> {
    VaultStateV1::from_gql(
        Some(s.curator.as_str()),
        Some(s.owner.as_str()),
        Some(s.guardian.as_str()),
        &s.total_assets,
        s.total_assets_usd,
        &s.total_supply,
        s.fee,
        &s.timelock,
        s.apy,
        s.net_apy,
        s.share_price.as_deref().unwrap_or("0"),
        s.allocation
            .iter()
            .filter_map(|a| {
                let market = &a.market;
                VaultAllocation::from_gql(
                    market.unique_key.clone(),
                    Some(market.loan_asset.symbol.clone()),
                    Some(market.loan_asset.address.as_str()),
                    market.collateral_asset.as_ref().map(|ca| ca.symbol.clone()),
                    market.collateral_asset.as_ref().map(|ca| ca.address.as_str()),
                    &a.supply_assets,
                    a.supply_assets_usd,
                    &a.supply_cap,
                )
            })
            .collect(),
    )
}

fn convert_v1_state_single(
    s: &get_vault_v1_by_address::GetVaultV1ByAddressVaultByAddressState,
) -> Option<VaultStateV1> {
    VaultStateV1::from_gql(
        Some(s.curator.as_str()),
        Some(s.owner.as_str()),
        Some(s.guardian.as_str()),
        &s.total_assets,
        s.total_assets_usd,
        &s.total_supply,
        s.fee,
        &s.timelock,
        s.apy,
        s.net_apy,
        s.share_price.as_deref().unwrap_or("0"),
        s.allocation
            .iter()
            .filter_map(|a| {
                let market = &a.market;
                VaultAllocation::from_gql(
                    market.unique_key.clone(),
                    Some(market.loan_asset.symbol.clone()),
                    Some(market.loan_asset.address.as_str()),
                    market.collateral_asset.as_ref().map(|ca| ca.symbol.clone()),
                    market.collateral_asset.as_ref().map(|ca| ca.address.as_str()),
                    &a.supply_assets,
                    a.supply_assets_usd,
                    &a.supply_cap,
                )
            })
            .collect(),
    )
}

fn convert_v2_vault(v: get_vaults_v2::GetVaultsV2VaultV2sItems) -> Option<VaultV2> {
    let chain_id = v.chain.id;
    let asset = &v.asset;

    VaultV2::from_gql(
        &v.address,
        v.name,
        v.symbol,
        chain_id,
        v.listed,
        v.whitelisted,
        Asset::from_gql(
            &asset.address,
            asset.symbol.clone(),
            Some(asset.name.clone()),
            asset.decimals,
            asset.price_usd,
        )?,
        Some(v.curator.address.as_str()),
        Some(v.owner.address.as_str()),
        v.total_assets.as_deref().unwrap_or("0"),
        v.total_assets_usd,
        &v.total_supply,
        Some(v.share_price),
        Some(v.performance_fee),
        Some(v.management_fee),
        v.avg_apy,
        v.avg_net_apy,
        v.apy,
        v.net_apy,
        &v.liquidity,
        v.liquidity_usd,
        v.adapters
            .items
            .map(|items| {
                items
                    .into_iter()
                    .filter_map(convert_v2_adapter)
                    .collect()
            })
            .unwrap_or_default(),
        v.rewards
            .into_iter()
            .filter_map(|r| {
                VaultReward::from_gql(
                    &r.asset.address,
                    r.asset.symbol.clone(),
                    r.supply_apr,
                    parse_yearly_supply(&r.yearly_supply_tokens),
                )
            })
            .collect(),
        v.warnings
            .into_iter()
            .map(|w| VaultV2Warning {
                warning_type: w.type_.clone(),
                level: format!("{:?}", w.level),
            })
            .collect(),
    )
}

/// Parse yearly supply tokens from string to f64.
fn parse_yearly_supply(s: &str) -> Option<f64> {
    s.parse::<f64>().ok()
}

fn convert_v2_vault_single(
    v: get_vault_v2_by_address::GetVaultV2ByAddressVaultV2ByAddress,
) -> Option<VaultV2> {
    let chain_id = v.chain.id;
    let asset = &v.asset;

    VaultV2::from_gql(
        &v.address,
        v.name,
        v.symbol,
        chain_id,
        v.listed,
        v.whitelisted,
        Asset::from_gql(
            &asset.address,
            asset.symbol.clone(),
            Some(asset.name.clone()),
            asset.decimals,
            asset.price_usd,
        )?,
        Some(v.curator.address.as_str()),
        Some(v.owner.address.as_str()),
        v.total_assets.as_deref().unwrap_or("0"),
        v.total_assets_usd,
        &v.total_supply,
        Some(v.share_price),
        Some(v.performance_fee),
        Some(v.management_fee),
        v.avg_apy,
        v.avg_net_apy,
        v.apy,
        v.net_apy,
        &v.liquidity,
        v.liquidity_usd,
        v.adapters
            .items
            .map(|items| {
                items
                    .into_iter()
                    .filter_map(convert_v2_adapter_single)
                    .collect()
            })
            .unwrap_or_default(),
        v.rewards
            .into_iter()
            .filter_map(|r| {
                VaultReward::from_gql(
                    &r.asset.address,
                    r.asset.symbol.clone(),
                    r.supply_apr,
                    parse_yearly_supply(&r.yearly_supply_tokens),
                )
            })
            .collect(),
        v.warnings
            .into_iter()
            .map(|w| VaultV2Warning {
                warning_type: w.type_.clone(),
                level: format!("{:?}", w.level),
            })
            .collect(),
    )
}

fn convert_v2_adapter(
    a: get_vaults_v2::GetVaultsV2VaultV2sItemsAdaptersItems,
) -> Option<VaultAdapter> {
    VaultAdapter::from_gql(
        a.id,
        &a.address,
        format!("{:?}", a.type_),
        &a.assets,
        a.assets_usd,
    )
}

fn convert_v2_adapter_single(
    a: get_vault_v2_by_address::GetVaultV2ByAddressVaultV2ByAddressAdaptersItems,
) -> Option<VaultAdapter> {
    VaultAdapter::from_gql(
        a.id,
        &a.address,
        format!("{:?}", a.type_),
        &a.assets,
        a.assets_usd,
    )
}

// User position conversion functions

fn convert_user_vault_v1_position(
    p: get_user_vault_positions::GetUserVaultPositionsUserByAddressVaultPositions,
) -> Option<UserVaultV1Position> {
    let vault = VaultInfo::from_gql(&p.vault.address, p.vault.name, p.vault.symbol, p.vault.chain.id)?;

    let state = p.state.as_ref().and_then(|s| {
        VaultPositionState::from_gql(
            &s.shares,
            s.assets.as_deref(),
            s.assets_usd,
            s.pnl.as_deref(),
            s.pnl_usd,
            s.roe,
            s.roe_usd,
        )
    });

    UserVaultV1Position::from_gql(p.id, &p.shares, &p.assets, p.assets_usd, vault, state)
}

fn convert_user_vault_v2_position(
    p: get_user_vault_positions::GetUserVaultPositionsUserByAddressVaultV2Positions,
) -> Option<UserVaultV2Position> {
    let vault = VaultInfo::from_gql(&p.vault.address, p.vault.name, p.vault.symbol, p.vault.chain.id)?;

    UserVaultV2Position::from_gql(
        p.id,
        &p.shares,
        &p.assets,
        p.assets_usd,
        p.pnl.as_deref(),
        p.pnl_usd,
        p.roe,
        p.roe_usd,
        vault,
    )
}

fn convert_user_vault_v1_position_overview(
    p: get_user_account_overview::GetUserAccountOverviewUserByAddressVaultPositions,
) -> Option<UserVaultV1Position> {
    let vault = VaultInfo::from_gql(&p.vault.address, p.vault.name, p.vault.symbol, p.vault.chain.id)?;

    let state = p.state.as_ref().and_then(|s| {
        VaultPositionState::from_gql(
            &s.shares,
            s.assets.as_deref(),
            s.assets_usd,
            s.pnl.as_deref(),
            s.pnl_usd,
            s.roe,
            s.roe_usd,
        )
    });

    UserVaultV1Position::from_gql(p.id, &p.shares, &p.assets, p.assets_usd, vault, state)
}

fn convert_user_vault_v2_position_overview(
    p: get_user_account_overview::GetUserAccountOverviewUserByAddressVaultV2Positions,
) -> Option<UserVaultV2Position> {
    let vault = VaultInfo::from_gql(&p.vault.address, p.vault.name, p.vault.symbol, p.vault.chain.id)?;

    UserVaultV2Position::from_gql(
        p.id,
        &p.shares,
        &p.assets,
        p.assets_usd,
        p.pnl.as_deref(),
        p.pnl_usd,
        p.roe,
        p.roe_usd,
        vault,
    )
}

fn convert_user_market_position(
    p: get_user_account_overview::GetUserAccountOverviewUserByAddressMarketPositions,
) -> Option<UserMarketPosition> {
    let market = MarketInfo::from_gql(
        p.market.unique_key,
        Some(p.market.loan_asset.symbol),
        Some(p.market.loan_asset.address.as_str()),
        p.market.collateral_asset.as_ref().map(|c| c.symbol.clone()),
        p.market.collateral_asset.as_ref().map(|c| c.address.as_str()),
    );

    UserMarketPosition::from_gql(
        p.id,
        &p.supply_shares,
        &p.supply_assets,
        p.supply_assets_usd,
        &p.borrow_shares,
        &p.borrow_assets,
        p.borrow_assets_usd,
        &p.collateral,
        p.collateral_usd,
        p.health_factor,
        market,
    )
}