mkit_git_bridge/

import.rs

//! The git→mkit import driver (SPEC-GIT-IMPORT §3).
//!
//! Pure translation engine: reads git objects through a [`GitSource`],
//! writes serialized mkit objects through an [`ObjectSink`], signs
//! through caller-supplied callbacks (the crate stays crypto-free —
//! the CLI passes its `CommitSigner`), and records sha1→blake3 pairs
//! plus retained raw commit/tag bytes through caller-supplied hooks.
//!
//! Everything here is deterministic given *(git bytes, signing key,
//! import-spec version)*: deterministic Ed25519 means the engine can
//! be re-run idempotently and the map is a rebuildable cache under
//! the same key (SPEC-GIT-IMPORT §1.2).

use crate::error::{BridgeError, Refusal};
use crate::gitobj::Sha1Id;
use crate::gitparse::{self, ModeMapping};
use crate::gitsrc::{CatFileBatch, GitObjKind};
use mkit_core::object::{
    Blob, ChunkedBlob, Commit, EntryMode, Identity, Object, ObjectType, Tag, Tree, TreeEntry,
};
use mkit_core::{ChunkIterator, FastCdc, Hash};
use std::collections::HashMap;

/// SPEC-GIT-IMPORT §3.1: the normative chunking threshold.
pub const CHUNK_THRESHOLD: u64 = mkit_core::worktree::CHUNK_THRESHOLD;

/// SPEC-GIT-IMPORT §3.4: tag→tag chains beyond this depth refuse.
pub const MAX_TAG_CHAIN: usize = 16;

/// Tree nesting cap, matching mkit-core's `MAX_TREE_DEPTH` defense
/// (the importer is the most untrusted boundary in the system).
pub const MAX_TREE_DEPTH: usize = 128;

/// This implementation's import-spec version (SPEC-GIT-IMPORT §1.2).
pub const IMPORT_SPEC_VERSION: u32 = 1;

/// Where the driver reads git objects from. [`CatFileBatch`] for real
/// repositories; an in-memory map for hermetic tests/vectors.
pub trait GitSource {
    fn read_git(&mut self, id: &Sha1Id) -> Result<(GitObjKind, Vec<u8>), BridgeError>;
}

impl GitSource for CatFileBatch {
    fn read_git(&mut self, id: &Sha1Id) -> Result<(GitObjKind, Vec<u8>), BridgeError> {
        self.read(id)
    }
}

/// In-memory source for tests and golden vectors.
#[derive(Debug, Default)]
pub struct MemGitSource(pub HashMap<Sha1Id, (GitObjKind, Vec<u8>)>);

impl MemGitSource {
    /// Insert a git object body, computing its real sha1 id.
    pub fn put(&mut self, kind: GitObjKind, body: Vec<u8>) -> Sha1Id {
        let id = crate::gitobj::GitObject {
            gtype: kind.into(),
            body: body.clone(),
        }
        .id();
        self.0.insert(id, (kind, body));
        id
    }
}

impl GitSource for MemGitSource {
    fn read_git(&mut self, id: &Sha1Id) -> Result<(GitObjKind, Vec<u8>), BridgeError> {
        self.0
            .get(id)
            .cloned()
            .ok_or_else(|| BridgeError::Source("object missing from memory source".into()))
    }
}

/// Where serialized mkit objects land. Implemented for
/// [`mkit_core::ObjectStore`] (per-object fsync) and the CLI's bulk
/// writer; tests use an in-memory map.
pub trait ObjectSink {
    fn write_object(&mut self, bytes: &[u8]) -> Result<Hash, BridgeError>;

    /// The stored object's type byte, when the sink can answer (used
    /// only to disambiguate blob vs chunked-manifest tag targets).
    fn kind_of(&self, _h: &Hash) -> Option<ObjectType> {
        None
    }
}

impl ObjectSink for mkit_core::ObjectStore {
    fn write_object(&mut self, bytes: &[u8]) -> Result<Hash, BridgeError> {
        self.write(bytes)
            .map_err(|e| BridgeError::Source(format!("store write: {e}")))
    }

    fn kind_of(&self, h: &Hash) -> Option<ObjectType> {
        self.read_object(h).ok().map(|o| o.object_type())
    }
}

/// In-memory sink for tests.
#[derive(Debug, Default)]
pub struct MemSink(pub HashMap<Hash, Vec<u8>>);

impl ObjectSink for MemSink {
    fn write_object(&mut self, bytes: &[u8]) -> Result<Hash, BridgeError> {
        let h = mkit_core::hash::hash(bytes);
        self.0.insert(h, bytes.to_vec());
        Ok(h)
    }

    fn kind_of(&self, h: &Hash) -> Option<ObjectType> {
        self.0
            .get(h)
            .and_then(|b| mkit_core::deserialize(b).ok())
            .map(|o| o.object_type())
    }
}

/// Hook receiving (upstream sha1, framed raw git bytes) for retention.
/// The explicit lifetime keeps the trait object bound to the
/// borrower's scope (a bare `dyn` alias would default to `'static`).
pub type RetainRawFn<'f> = dyn FnMut(&Sha1Id, &[u8]) -> Result<(), BridgeError> + 'f;

/// Signing callbacks: given the unsigned object (zeroed signature),
/// return the 64-byte signature. The signer pubkey is supplied
/// separately so the engine can fill the `signer` field first.
pub struct ImportSigner<'a> {
    pub public: [u8; 32],
    pub sign_commit: &'a mut dyn FnMut(&Commit) -> Result<[u8; 64], BridgeError>,
    pub sign_tag: &'a mut dyn FnMut(&Tag) -> Result<[u8; 64], BridgeError>,
}

impl std::fmt::Debug for ImportSigner<'_> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("ImportSigner")
            .field("public", &crate::gitobj::bytes_hex(&self.public))
            .finish_non_exhaustive()
    }
}

/// Per-run options.
#[derive(Debug, Clone, Copy, Default)]
pub struct ImportOptions {
    /// Recorded state-dir direction is `fork`: historic-mode
    /// normalization must refuse instead (SPEC-GIT-IMPORT §3.3).
    pub fork_mode: bool,
}

/// Outcome of importing one ref tip.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ImportedRef {
    /// The mkit hash of the translated tip object (commit or tag).
    pub head: Hash,
    /// New (sha1, blake3) pairs discovered by this call, in
    /// dependency order — append these to the map cache.
    pub new_pairs: Vec<(Sha1Id, Hash)>,
    /// Whether any historic mode was normalized (declared-lossy warn).
    pub normalized_modes: bool,
}

/// The import engine. `map` is the sha1→blake3 cache (load it from
/// the state dir; pairs accumulate across calls).
///
/// Long unmapped parent chains should go through
/// [`Importer::import_commits`] (parents-first order, recursion depth
/// 1); [`Importer::import_ref`] recurses through unmapped parents.
pub struct Importer<'a, S: GitSource, K: ObjectSink> {
    pub source: &'a mut S,
    pub sink: &'a mut K,
    pub signer: ImportSigner<'a>,
    pub map: &'a mut HashMap<Sha1Id, Hash>,
    /// Retained-raw-bytes hook (commits + tags only); the CLI writes
    /// these sha1-addressed under the state dir (SPEC-GIT-IMPORT §5).
    pub retain_raw: &'a mut RetainRawFn<'a>,
    pub options: ImportOptions,
    /// Per-run scratch for the §3.3/§3.4 composition checks (tree
    /// heights / tag chain lengths measured on map-cache hits).
    pub depth_memo: DepthMemo,
}

/// Memoized tree heights and tag-chain lengths, keyed by git id.
/// Needed because a map hit skips recursion: a previously-imported
/// LEGAL subtree (or tag chain) re-referenced deeper in a new parent
/// could compose past the normative caps without it.
#[derive(Debug, Default)]
pub struct DepthMemo {
    heights: HashMap<Sha1Id, usize>,
    chains: HashMap<Sha1Id, usize>,
}

impl<S: GitSource, K: ObjectSink> std::fmt::Debug for Importer<'_, S, K> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("Importer").finish_non_exhaustive()
    }
}

impl<S: GitSource, K: ObjectSink> Importer<'_, S, K> {
    /// Import the closure of one upstream ref tip (commit or tag
    /// object id, parents-first commit order is derived internally
    /// for the in-memory path; CLI callers pass `rev_list` order via
    /// [`Self::import_commits`] for incremental efficiency).
    pub fn import_ref(&mut self, tip: &Sha1Id) -> Result<ImportedRef, BridgeError> {
        let mut new_pairs = Vec::new();
        let mut normalized = false;
        let head = self.object(tip, 0, 0, &mut new_pairs, &mut normalized)?;
        Ok(ImportedRef {
            head,
            new_pairs,
            normalized_modes: normalized,
        })
    }

    /// Import commits in caller-supplied parents-first order, then
    /// return the map entry for `tip`. More efficient than
    /// [`Self::import_ref`] for long histories (no deep recursion
    /// through parent links).
    ///
    /// `new_pairs` and `normalized` are CALLER-owned and keep every
    /// pair discovered before an error: the sink writes happen
    /// regardless, so on a per-ref refusal the caller must still
    /// persist those pairs — a later ref sharing that history
    /// memo-hits without re-emitting them, and dropping them here
    /// would leave the durable map missing objects that recorded
    /// refs reference.
    pub fn import_commits(
        &mut self,
        order: &[Sha1Id],
        tip: &Sha1Id,
        new_pairs: &mut Vec<(Sha1Id, Hash)>,
        normalized: &mut bool,
    ) -> Result<Hash, BridgeError> {
        for id in order {
            self.object(id, 0, 0, new_pairs, normalized)?;
        }
        self.object(tip, 0, 0, new_pairs, normalized)
    }

    /// Translate one git object (memoized through the map).
    fn object(
        &mut self,
        id: &Sha1Id,
        tag_depth: usize,
        tree_depth: usize,
        new_pairs: &mut Vec<(Sha1Id, Hash)>,
        normalized: &mut bool,
    ) -> Result<Hash, BridgeError> {
        if let Some(h) = self.map.get(id).copied() {
            // A hit skips recursion, so the depth caps must be
            // enforced against the MEASURED shape of what the hit
            // stands for — a legal 120-deep subtree wrapped 50 levels
            // down by a later ref would otherwise compose past the
            // §3.3 cap and store trees mkit's read paths refuse.
            self.check_hit_budget(id, &h, tag_depth, tree_depth)?;
            return Ok(h);
        }
        let (kind, body) = self.source.read_git(id)?;
        let h = match kind {
            GitObjKind::Blob => self.blob(id, &body, new_pairs)?,
            GitObjKind::Tree => {
                if tree_depth >= MAX_TREE_DEPTH {
                    return Err(Refusal::TreeTooDeep { object: hash20(id) }.into());
                }
                self.tree(id, &body, tree_depth, new_pairs, normalized)?
            }
            GitObjKind::Commit => self.commit(id, &body, new_pairs, normalized)?,
            GitObjKind::Tag => {
                if tag_depth >= MAX_TAG_CHAIN {
                    return Err(Refusal::TagChain { object: hash20(id) }.into());
                }
                self.tag(id, &body, tag_depth, new_pairs, normalized)?
            }
        };
        self.map.insert(*id, h);
        new_pairs.push((*id, h));
        Ok(h)
    }

    /// Composition caps on a map-cache hit (no recursion happens, so
    /// measure instead). Best effort by kind: a sink that cannot
    /// answer skips (in-memory test sinks always can).
    fn check_hit_budget(
        &mut self,
        id: &Sha1Id,
        twin: &Hash,
        tag_depth: usize,
        tree_depth: usize,
    ) -> Result<(), BridgeError> {
        if tree_depth == 0 && tag_depth == 0 {
            return Ok(());
        }
        match self.sink.kind_of(twin) {
            Some(ObjectType::Tree) if tree_depth > 0 => {
                let height = self.tree_height(id, MAX_TREE_DEPTH - tree_depth + 1)?;
                if tree_depth + height > MAX_TREE_DEPTH {
                    return Err(Refusal::TreeTooDeep { object: hash20(id) }.into());
                }
            }
            Some(ObjectType::Tag) if tag_depth > 0 => {
                let len = self.tag_chain_len(id, MAX_TAG_CHAIN - tag_depth + 1)?;
                if tag_depth + len > MAX_TAG_CHAIN {
                    return Err(Refusal::TagChain { object: hash20(id) }.into());
                }
            }
            _ => {}
        }
        Ok(())
    }

    /// Height of a git tree (1 = leaf tree), measured via the source,
    /// memoized, and capped: returns early once `budget` is exceeded
    /// (the caller refuses anyway, so exactness past the cap is
    /// pointless and the walk stays bounded).
    fn tree_height(&mut self, id: &Sha1Id, budget: usize) -> Result<usize, BridgeError> {
        if let Some(h) = self.depth_memo.heights.get(id) {
            return Ok(*h);
        }
        if budget == 0 {
            return Ok(MAX_TREE_DEPTH + 1);
        }
        let (kind, body) = self.source.read_git(id)?;
        if kind != GitObjKind::Tree {
            return Ok(0);
        }
        let parsed =
            gitparse::parse_tree(&body).map_err(|e| BridgeError::Source(format!("tree: {e}")))?;
        let mut max_child = 0usize;
        for e in parsed {
            if gitparse::map_mode(&e.mode) == ModeMapping::Canonical(EntryMode::Tree)
                || gitparse::map_mode(&e.mode) == ModeMapping::Normalized(EntryMode::Tree)
            {
                max_child = max_child.max(self.tree_height(&e.id, budget - 1)?);
                if max_child > MAX_TREE_DEPTH {
                    break;
                }
            }
        }
        let h = 1 + max_child;
        if h <= MAX_TREE_DEPTH {
            // Over-cap values are budget-truncated, not exact — memoizing
            // them would falsely refuse a later ref that reuses this
            // subtree at a legal shallower depth.
            self.depth_memo.heights.insert(*id, h);
        }
        Ok(h)
    }

    /// Length of a git tag chain starting at `id` (1 = tag pointing
    /// at a non-tag), measured via the source, memoized, capped.
    fn tag_chain_len(&mut self, id: &Sha1Id, budget: usize) -> Result<usize, BridgeError> {
        if let Some(l) = self.depth_memo.chains.get(id) {
            return Ok(*l);
        }
        if budget == 0 {
            return Ok(MAX_TAG_CHAIN + 1);
        }
        let (kind, body) = self.source.read_git(id)?;
        if kind != GitObjKind::Tag {
            return Ok(0);
        }
        let parsed =
            gitparse::parse_tag(&body).map_err(|e| BridgeError::Source(format!("tag: {e}")))?;
        let len = 1 + self.tag_chain_len(&parsed.object, budget - 1)?;
        if len <= MAX_TAG_CHAIN {
            // Same rule as tree heights: only exact values are memoizable.
            self.depth_memo.chains.insert(*id, len);
        }
        Ok(len)
    }

    /// §3.1: verbatim ≤ threshold, pinned `FastCDC` above it.
    fn blob(
        &mut self,
        id: &Sha1Id,
        body: &[u8],
        new_pairs: &mut Vec<(Sha1Id, Hash)>,
    ) -> Result<Hash, BridgeError> {
        let _ = new_pairs; // chunk blobs are content-addressed extras, not mapped
        if body.len() as u64 > mkit_core::worktree::MAX_FILE_BYTES {
            return Err(Refusal::BlobTooLarge {
                object: hash20(id),
                size: body.len() as u64,
            }
            .into());
        }
        if body.len() as u64 <= CHUNK_THRESHOLD {
            let bytes = ser(
                id,
                &Object::Blob(Blob {
                    data: body.to_vec(),
                }),
            )?;
            return self.sink.write_object(&bytes);
        }
        let mut chunks = Vec::new();
        for b in ChunkIterator::new(FastCdc::v1(), body) {
            let chunk = ser(
                id,
                &Object::Blob(Blob {
                    data: body[b.offset..b.offset + b.length].to_vec(),
                }),
            )?;
            chunks.push(self.sink.write_object(&chunk)?);
        }
        let manifest = ser(
            id,
            &Object::ChunkedBlob(ChunkedBlob {
                total_size: body.len() as u64,
                chunk_size: 0,
                chunks,
            }),
        )?;
        self.sink.write_object(&manifest)
    }

    /// §3.3: re-sort, validate names, map modes.
    fn tree(
        &mut self,
        id: &Sha1Id,
        body: &[u8],
        depth: usize,
        new_pairs: &mut Vec<(Sha1Id, Hash)>,
        normalized: &mut bool,
    ) -> Result<Hash, BridgeError> {
        let fork_mode = self.options.fork_mode;
        let (tree, changed) = translate_tree_metadata(id, body, fork_mode, |child_id| {
            let child = self.object(child_id, 0, depth + 1, new_pairs, normalized)?;
            Ok((child, self.sink.kind_of(&child)))
        })?;
        *normalized |= changed;
        let bytes = ser(id, &Object::Tree(tree))?;
        self.sink.write_object(&bytes)
    }

    /// §3.2: importer-signed commit.
    fn commit(
        &mut self,
        id: &Sha1Id,
        body: &[u8],
        new_pairs: &mut Vec<(Sha1Id, Hash)>,
        normalized: &mut bool,
    ) -> Result<Hash, BridgeError> {
        let parsed = gitparse::parse_commit(body).map_err(|e| {
            BridgeError::from(Refusal::Unparsable {
                object: hash20(id),
                detail: format!("commit: {e}"),
            })
        })?;
        if parsed.committer.timestamp < 0 {
            return Err(Refusal::NegativeTimestamp {
                object: hash20(id),
                timestamp: parsed.committer.timestamp,
            }
            .into());
        }
        if parsed.parents.len() > 1000 {
            return Err(Refusal::TooManyParents { object: hash20(id) }.into());
        }
        if parsed.author.identity.is_empty() || parsed.author.identity.len() > 4096 {
            return Err(Refusal::AuthorPayload { object: hash20(id) }.into());
        }
        let tree = self.object(&parsed.tree, 0, 0, new_pairs, normalized)?;
        let mut parents = Vec::with_capacity(parsed.parents.len());
        for p in &parsed.parents {
            parents.push(self.object(p, 0, 0, new_pairs, normalized)?);
        }
        // Raw bytes: the full git object body (commit framing is
        // recomputable from kind+len).
        let raw = raw_git_bytes(GitObjKind::Commit, body);
        (self.retain_raw)(id, &raw)?;

        let mut commit = unsigned_commit(id, body, self.signer.public, tree, parents)?;
        commit.signature = (self.signer.sign_commit)(&commit)?;
        let bytes = ser(id, &Object::Commit(commit))?;
        self.sink.write_object(&bytes)
    }

    /// §3.4: importer-signed tag.
    fn tag(
        &mut self,
        id: &Sha1Id,
        body: &[u8],
        depth: usize,
        new_pairs: &mut Vec<(Sha1Id, Hash)>,
        normalized: &mut bool,
    ) -> Result<Hash, BridgeError> {
        let parsed = gitparse::parse_tag(body).map_err(|e| {
            BridgeError::from(Refusal::Unparsable {
                object: hash20(id),
                detail: format!("tag: {e}"),
            })
        })?;
        if crate::refname::check_tag_name(&parsed.name).is_err() {
            return Err(Refusal::TagName { object: hash20(id) }.into());
        }
        let target = self.object(&parsed.object, depth + 1, 0, new_pairs, normalized)?;
        let mut tag = unsigned_tag(
            id,
            body,
            self.signer.public,
            target,
            self.sink.kind_of(&target),
        )?;
        let raw = raw_git_bytes(GitObjKind::Tag, body);
        (self.retain_raw)(id, &raw)?;
        tag.signature = (self.signer.sign_tag)(&tag)?;
        let bytes = ser(id, &Object::Tag(tag))?;
        self.sink.write_object(&bytes)
    }
}

/// Translate Tree metadata without writing or signing. The resolver supplies
/// child identities and kinds; callers must authenticate those correspondences.
/// Returns whether a historic Git mode was normalized.
///
/// # Errors
/// Returns the same typed policy refusals as the importer for invalid trees.
pub fn translate_tree_metadata(
    id: &Sha1Id,
    body: &[u8],
    fork_mode: bool,
    mut resolve: impl FnMut(&Sha1Id) -> Result<(Hash, Option<ObjectType>), BridgeError>,
) -> Result<(Tree, bool), BridgeError> {
    let parsed = gitparse::parse_tree(body).map_err(|e| {
        BridgeError::from(Refusal::Unparsable {
            object: hash20(id),
            detail: format!("tree: {e}"),
        })
    })?;
    // Mirror the deserializer's entry-count cap (same pattern as
    // the parents cap on commits): anything larger would store a
    // signed tree the repo can never read back.
    if parsed.len() > mkit_core::serialize::MAX_TREE_ENTRIES as usize {
        return Err(Refusal::TooManyTreeEntries {
            object: hash20(id),
            count: parsed.len(),
        }
        .into());
    }
    let mut normalized = false;
    let mut entries = Vec::with_capacity(parsed.len());
    for e in parsed {
        let mode = match gitparse::map_mode(&e.mode) {
            ModeMapping::Canonical(m) => m,
            ModeMapping::Normalized(m) => {
                if fork_mode {
                    return Err(Refusal::NormalizedModeInFork {
                        object: hash20(id),
                        mode: String::from_utf8_lossy(&e.mode).into_owned(),
                    }
                    .into());
                }
                normalized = true;
                m
            }
            ModeMapping::Gitlink => {
                return Err(Refusal::Gitlink {
                    object: hash20(id),
                    path: String::from_utf8_lossy(&e.name).into_owned(),
                }
                .into());
            }
            ModeMapping::Unknown => {
                return Err(Refusal::UnknownTreeMode {
                    object: hash20(id),
                    mode: String::from_utf8_lossy(&e.mode).into_owned(),
                }
                .into());
            }
        };
        if !TreeEntry::validate_name(&e.name) {
            return Err(Refusal::TreeEntryName {
                object: hash20(id),
                name: String::from_utf8_lossy(&e.name).into_owned(),
            }
            .into());
        }
        let (child, actual_kind) = resolve(&e.id)?;
        // The mode promised one kind; verify the TRANSLATED child
        // actually is that kind (git tolerates e.g. mode 100644 →
        // commit; mkit's model cannot). Best effort: a sink that
        // cannot answer skips the check.
        if let Some(kind) = actual_kind {
            let ok = match mode {
                EntryMode::Tree => kind == ObjectType::Tree,
                _ => matches!(kind, ObjectType::Blob | ObjectType::ChunkedBlob),
            };
            if !ok {
                return Err(Refusal::TreeEntryKind {
                    object: hash20(id),
                    name: String::from_utf8_lossy(&e.name).into_owned(),
                }
                .into());
            }
        }
        entries.push(TreeEntry {
            name: e.name,
            mode,
            object_hash: child,
        });
    }
    // git order → mkit byte-lex order. Duplicate names are
    // git-representable (file `a` + dir `a` sort apart under
    // git's `name+"/"` key) but undecodable in mkit — the
    // serializer does NOT check on write, so refuse here or the
    // store gains a poisoned signed object.
    entries.sort_by(|a, b| a.name.cmp(&b.name));
    if entries.windows(2).any(|w| w[0].name == w[1].name) {
        return Err(Refusal::DuplicateTreeEntry { object: hash20(id) }.into());
    }
    Ok((Tree { entries }, normalized))
}

/// Derive the import-v1 unsigned commit fields from Git bytes and resolved edges.
/// No private key, object writes or mapping-cache mutation is required.
///
/// # Errors
/// Rejects malformed or unrepresentable source fields and incorrect parent count.
pub fn unsigned_commit(
    id: &Sha1Id,
    body: &[u8],
    signer: [u8; 32],
    tree: Hash,
    parents: Vec<Hash>,
) -> Result<Commit, BridgeError> {
    let parsed =
        gitparse::parse_commit(body).map_err(|e| BridgeError::Integrity(format!("commit: {e}")))?;
    if parsed.committer.timestamp < 0 {
        return Err(Refusal::NegativeTimestamp {
            object: hash20(id),
            timestamp: parsed.committer.timestamp,
        }
        .into());
    }
    if parsed.parents.len() > 1000 {
        return Err(Refusal::TooManyParents { object: hash20(id) }.into());
    }
    if parsed.author.identity.is_empty() || parsed.author.identity.len() > 4096 {
        return Err(Refusal::AuthorPayload { object: hash20(id) }.into());
    }
    if parents.len() != parsed.parents.len() {
        return Err(BridgeError::Integrity(
            "incorrect imported parent count".into(),
        ));
    }
    let raw = raw_git_bytes(GitObjKind::Commit, body);
    #[allow(clippy::cast_sign_loss)] // negative refused above
    let timestamp = parsed.committer.timestamp as u64;
    let commit = Commit {
        tree_hash: tree,
        parents,
        author: Identity::opaque(parsed.author.identity),
        signer,
        message: parsed.message,
        timestamp,
        message_hash: mkit_core::hash::ZERO,
        content_digest: mkit_core::hash::hash(&raw),
        signature: [0u8; 64],
    };
    Ok(commit)
}

/// Derive import-v1 unsigned tag fields, including chunked target kinds.
///
/// # Errors
/// Rejects malformed fields, illegal tag names and inconsistent target kinds.
pub fn unsigned_tag(
    id: &Sha1Id,
    body: &[u8],
    signer: [u8; 32],
    target: Hash,
    actual: Option<ObjectType>,
) -> Result<Tag, BridgeError> {
    let parsed =
        gitparse::parse_tag(body).map_err(|e| BridgeError::Integrity(format!("tag: {e}")))?;
    if crate::refname::check_tag_name(&parsed.name).is_err() {
        return Err(Refusal::TagName { object: hash20(id) }.into());
    }
    let target_type = match parsed.target_type.as_slice() {
        b"commit" => ObjectType::Commit,
        b"tree" => ObjectType::Tree,
        b"blob" => ObjectType::Blob,
        b"tag" => ObjectType::Tag,
        other => {
            return Err(Refusal::Unparsable {
                object: hash20(id),
                detail: format!(
                    "tag target type {:?} unknown",
                    String::from_utf8_lossy(other)
                ),
            }
            .into());
        }
    };
    // The mkit target_type must reflect what the TRANSLATED target
    // is: a >1MiB git blob became a chunked manifest. And the
    // DECLARED type must match the actual target — a tag claiming
    // `type commit` over a blob would sign an inconsistent mkit
    // tag (git tolerates the lie; mkit's model must not).
    let target_type = match (target_type, actual) {
        (ObjectType::Blob, Some(ObjectType::ChunkedBlob)) => ObjectType::ChunkedBlob,
        (declared, Some(actual)) if actual != declared => {
            return Err(Refusal::Unparsable {
                object: hash20(id),
                detail: format!(
                    "tag declares target type {declared:?} but the target is {actual:?}"
                ),
            }
            .into());
        }
        (declared, _) => declared,
    };
    let (tagger_identity, timestamp) = match parsed.tagger {
        Some(p) => {
            if p.timestamp < 0 {
                return Err(Refusal::NegativeTimestamp {
                    object: hash20(id),
                    timestamp: p.timestamp,
                }
                .into());
            }
            if p.identity.is_empty() || p.identity.len() > 4096 {
                return Err(Refusal::AuthorPayload { object: hash20(id) }.into());
            }
            #[allow(clippy::cast_sign_loss)]
            let ts = p.timestamp as u64;
            (Identity::opaque(p.identity), ts)
        }
        // Historic tagger-less tags: a pinned sentinel identity
        // and epoch 0 (deterministic; provenance retains truth).
        None => (Identity::opaque(b"(no tagger)".to_vec()), 0),
    };
    let tag = Tag {
        target,
        target_type,
        name: parsed.name,
        tagger: tagger_identity,
        signer,
        message: parsed.message,
        timestamp,
        signature: [0u8; 64],
    };
    Ok(tag)
}

/// Serialize, mapping failure to a per-ref refusal: a serialize error
/// here is always content-derived (a SPEC-OBJECTS cap the upstream
/// object exceeds), never an environment fault — one hostile object
/// must not abort the import of every other ref.
fn ser(id: &Sha1Id, obj: &Object) -> Result<Vec<u8>, BridgeError> {
    mkit_core::serialize(obj).map_err(|e| {
        Refusal::Unrepresentable {
            object: hash20(id),
            detail: e.to_string(),
        }
        .into()
    })
}

/// Rebuild the full `"<type> <len>\0" + body` git object bytes for
/// retention + `content_digest` (SPEC-GIT-IMPORT §5: "raw git commit
/// bytes" are the framed object bytes, matching `git cat-file`'s
/// hashed form). Frames via the canonical [`GitObject::raw`] so the
/// layout-critical header exists in exactly one place.
fn raw_git_bytes(kind: GitObjKind, body: &[u8]) -> Vec<u8> {
    crate::gitobj::GitObject {
        gtype: kind.into(),
        body: body.to_vec(),
    }
    .raw()
}

/// A `Sha1Id` widened into the 32-byte `Hash` slot Refusal uses for
/// display (zero-padded; Display prints the meaningful prefix).
fn hash20(id: &Sha1Id) -> Hash {
    let mut h = [0u8; 32];
    h[..20].copy_from_slice(id);
    h
}