1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
use std::{
collections::{BTreeMap, BTreeSet},
convert::TryFrom,
vec::IntoIter,
};
use thiserror::Error;
use crate::model::{lint, Lint};
#[derive(Debug, Eq, PartialEq, Clone)]
pub struct Lints {
lints: BTreeSet<Lint>,
}
lazy_static! {
static ref AVAILABLE: Lints = {
let set = Lint::all_lints().collect();
Lints::new(set)
};
}
impl Lints {
#[must_use]
pub fn new(lints: BTreeSet<Lint>) -> Lints {
Lints { lints }
}
#[must_use]
pub fn available() -> &'static Lints {
&AVAILABLE
}
#[must_use]
pub fn names(self) -> Vec<&'static str> {
self.lints.iter().map(|lint| lint.name()).collect()
}
#[must_use]
pub fn config_keys(self) -> Vec<String> {
self.lints.iter().map(|lint| lint.config_key()).collect()
}
#[must_use]
pub fn merge(&self, other: &Lints) -> Lints {
Lints::new(self.lints.union(&other.lints).copied().collect())
}
#[must_use]
pub fn subtract(&self, other: &Lints) -> Lints {
Lints::new(self.lints.difference(&other.lints).copied().collect())
}
}
impl std::iter::IntoIterator for Lints {
type IntoIter = IntoIter<Lint>;
type Item = Lint;
fn into_iter(self) -> Self::IntoIter {
self.lints.into_iter().collect::<Vec<_>>().into_iter()
}
}
impl TryFrom<Lints> for String {
type Error = Error;
fn try_from(lints: Lints) -> Result<Self, Self::Error> {
let enabled: Vec<_> = lints.into();
let config: BTreeMap<String, bool> = Lint::all_lints()
.map(|x| (x, enabled.contains(&x)))
.fold(BTreeMap::new(), |mut acc, (lint, state)| {
acc.insert(lint.to_string(), state);
acc
});
let mut inner: BTreeMap<String, BTreeMap<String, bool>> = BTreeMap::new();
inner.insert("lint".into(), config);
let mut output: BTreeMap<String, BTreeMap<String, BTreeMap<String, bool>>> =
BTreeMap::new();
output.insert("mit".into(), inner);
Ok(toml::to_string(&output)?)
}
}
impl From<Vec<Lint>> for Lints {
fn from(lints: Vec<Lint>) -> Self {
Lints::new(lints.into_iter().collect())
}
}
impl From<Lints> for Vec<Lint> {
fn from(lints: Lints) -> Self {
lints.into_iter().collect()
}
}
impl TryFrom<Vec<&str>> for Lints {
type Error = Error;
fn try_from(value: Vec<&str>) -> Result<Self, Self::Error> {
let lints = value
.into_iter()
.try_fold(
vec![],
|lints: Vec<Lint>, item_name| -> Result<Vec<Lint>, Error> {
let lint = Lint::try_from(item_name)?;
Ok(vec![lints, vec![lint]].concat())
},
)
.map(Vec::into_iter)?;
Ok(Lints::new(lints.collect()))
}
}
#[cfg(test)]
mod tests {
use std::{
collections::BTreeSet,
convert::{TryFrom, TryInto},
};
use indoc::indoc;
use crate::model::{
lint::Lint::{
BodyWiderThan72Characters,
DuplicatedTrailers,
JiraIssueKeyMissing,
PivotalTrackerIdMissing,
SubjectLongerThan72Characters,
SubjectNotSeparateFromBody,
},
lints::Error,
Lint,
Lints,
};
#[test]
fn it_returns_an_error_if_one_of_the_names_is_wrong() {
let lints = vec![
"pivotal-tracker-id-missing",
"broken",
"jira-issue-key-missing",
];
let actual: Result<Lints, Error> = lints.try_into();
assert!(actual.is_err());
}
#[test]
fn it_can_construct_itself_from_names() {
let lints = vec!["pivotal-tracker-id-missing", "jira-issue-key-missing"];
let mut expected_lints = BTreeSet::new();
expected_lints.insert(PivotalTrackerIdMissing);
expected_lints.insert(JiraIssueKeyMissing);
let expected = Lints::new(expected_lints);
let actual: Lints = lints.try_into().expect("Lints to have been parsed");
assert_eq!(expected, actual);
}
#[test]
fn it_can_give_me_an_into_iterator() {
let mut lints = BTreeSet::new();
lints.insert(PivotalTrackerIdMissing);
lints.insert(JiraIssueKeyMissing);
let input = Lints::new(lints);
let expected = vec![PivotalTrackerIdMissing, JiraIssueKeyMissing];
let actual = input.into_iter().collect::<Vec<_>>();
assert_eq!(expected, actual);
}
#[test]
fn it_can_convert_into_a_vec() {
let mut lints = BTreeSet::new();
lints.insert(PivotalTrackerIdMissing);
lints.insert(JiraIssueKeyMissing);
let input = Lints::new(lints);
let expected = vec![PivotalTrackerIdMissing, JiraIssueKeyMissing];
let actual: Vec<Lint> = input.into();
assert_eq!(expected, actual);
}
#[test]
fn it_can_give_me_the_names() {
let mut lints = BTreeSet::new();
lints.insert(PivotalTrackerIdMissing);
lints.insert(JiraIssueKeyMissing);
let input = Lints::new(lints);
let expected = vec![PivotalTrackerIdMissing.name(), JiraIssueKeyMissing.name()];
let actual = input.names();
assert_eq!(expected, actual);
}
#[test]
fn it_can_give_me_the_config_keys() {
let mut lints = BTreeSet::new();
lints.insert(PivotalTrackerIdMissing);
lints.insert(JiraIssueKeyMissing);
let input = Lints::new(lints);
let expected = vec![
PivotalTrackerIdMissing.config_key(),
JiraIssueKeyMissing.config_key(),
];
let actual = input.config_keys();
assert_eq!(expected, actual);
}
#[test]
fn can_get_all() {
let actual = Lints::available();
let lints = Lint::all_lints().collect();
let expected = &Lints::new(lints);
assert_eq!(
expected, actual,
"Expected all the lints to be {:?}, instead got {:?}",
expected, actual
);
}
#[test]
fn get_toml() {
let mut lints_on = BTreeSet::new();
lints_on.insert(DuplicatedTrailers);
lints_on.insert(SubjectNotSeparateFromBody);
lints_on.insert(SubjectLongerThan72Characters);
lints_on.insert(BodyWiderThan72Characters);
lints_on.insert(PivotalTrackerIdMissing);
let actual = String::try_from(Lints::new(lints_on)).expect("Failed to serialise");
let expected = indoc!(
"
[mit.lint]
body-wider-than-72-characters = true
duplicated-trailers = true
github-id-missing = false
jira-issue-key-missing = false
not-conventional-commit = false
not-emoji-log = false
pivotal-tracker-id-missing = true
subject-line-ends-with-period = false
subject-line-not-capitalized = false
subject-longer-than-72-characters = true
subject-not-separated-from-body = true
"
);
assert_eq!(
expected, actual,
"Expected the list of lint identifiers to be {:?}, instead got {:?}",
expected, actual
);
}
#[test]
fn two_sets_of_lints_can_be_merged() {
let mut set_a_lints = BTreeSet::new();
set_a_lints.insert(PivotalTrackerIdMissing);
let mut set_b_lints = BTreeSet::new();
set_b_lints.insert(DuplicatedTrailers);
let set_a = Lints::new(set_a_lints);
let set_b = Lints::new(set_b_lints);
let actual = set_a.merge(&set_b);
let mut lints = BTreeSet::new();
lints.insert(DuplicatedTrailers);
lints.insert(PivotalTrackerIdMissing);
let expected = Lints::new(lints);
assert_eq!(
expected, actual,
"Expected the list of lint identifiers to be {:?}, instead got {:?}",
expected, actual
);
}
#[test]
fn when_merging_overlapping_does_not_lead_to_duplication() {
let mut set_a_lints = BTreeSet::new();
set_a_lints.insert(PivotalTrackerIdMissing);
let mut set_b_lints = BTreeSet::new();
set_b_lints.insert(DuplicatedTrailers);
set_b_lints.insert(PivotalTrackerIdMissing);
let set_a = Lints::new(set_a_lints);
let set_b = Lints::new(set_b_lints);
let actual = set_a.merge(&set_b);
let mut lints = BTreeSet::new();
lints.insert(DuplicatedTrailers);
lints.insert(PivotalTrackerIdMissing);
let expected = Lints::new(lints);
assert_eq!(
expected, actual,
"Expected the list of lint identifiers to be {:?}, instead got {:?}",
expected, actual
);
}
#[test]
fn we_can_subtract_lints_from_the_lint_list() {
let mut set_a_lints = BTreeSet::new();
set_a_lints.insert(JiraIssueKeyMissing);
set_a_lints.insert(PivotalTrackerIdMissing);
let mut set_b_lints = BTreeSet::new();
set_b_lints.insert(DuplicatedTrailers);
set_b_lints.insert(PivotalTrackerIdMissing);
let set_a = Lints::new(set_a_lints);
let set_b = Lints::new(set_b_lints);
let actual = set_a.subtract(&set_b);
let mut lints = BTreeSet::new();
lints.insert(JiraIssueKeyMissing);
let expected = Lints::new(lints);
assert_eq!(
expected, actual,
"Expected the list of lint identifiers to be {:?}, instead got {:?}",
expected, actual
);
}
}
#[derive(Error, Debug)]
pub enum Error {
#[error("{0}")]
LintNameUnknown(#[from] lint::Error),
#[error("Failed to parse lint config file: {0}")]
TomlParse(#[from] toml::de::Error),
#[error("Failed to read lint config file: {0}")]
TomlSerialize(#[from] toml::ser::Error),
}