memvid_core/
graph_search.rs

1//! Graph-aware search combining MemoryCards/Logic-Mesh with vector search.
2//!
3//! This module provides hybrid retrieval that can:
4//! 1. Parse natural language queries for relational patterns
5//! 2. Match patterns against entity state (MemoryCards) or graph (Logic-Mesh)
6//! 3. Combine graph-filtered candidates with vector ranking
7
8use std::collections::{HashMap, HashSet};
9
10use crate::types::{
11    GraphMatchResult, GraphPattern, HybridSearchHit, PatternTerm, QueryPlan, SearchRequest,
12    TriplePattern,
13};
14use crate::{FrameId, Memvid, Result};
15
16/// Query planner that analyzes queries and creates execution plans.
17#[derive(Debug, Default)]
18pub struct QueryPlanner {
19    /// Patterns for detecting relational queries
20    entity_patterns: Vec<EntityPattern>,
21}
22
23/// Pattern for detecting entity-related queries.
24#[derive(Debug, Clone)]
25struct EntityPattern {
26    /// Keywords that trigger this pattern
27    keywords: Vec<&'static str>,
28    /// Slot to query
29    slot: &'static str,
30    /// Whether the pattern looks for a specific value
31    needs_value: bool,
32}
33
34impl QueryPlanner {
35    /// Create a new query planner.
36    #[must_use]
37    pub fn new() -> Self {
38        let mut planner = Self::default();
39        planner.init_patterns();
40        planner
41    }
42
43    fn init_patterns(&mut self) {
44        // Location patterns
45        self.entity_patterns.push(EntityPattern {
46            keywords: vec![
47                "who lives in",
48                "people in",
49                "users in",
50                "from",
51                "located in",
52                "based in",
53            ],
54            slot: "location",
55            needs_value: true,
56        });
57
58        // Employer/workplace patterns
59        self.entity_patterns.push(EntityPattern {
60            keywords: vec![
61                "who works at",
62                "employees of",
63                "people at",
64                "works for",
65                "employed by",
66            ],
67            slot: "workplace", // OpenAI enrichment uses "workplace" not "employer"
68            needs_value: true,
69        });
70
71        // Preference patterns
72        self.entity_patterns.push(EntityPattern {
73            keywords: vec![
74                "who likes",
75                "who loves",
76                "fans of",
77                "people who like",
78                "people who love",
79            ],
80            slot: "preference",
81            needs_value: true,
82        });
83
84        // Entity state patterns
85        self.entity_patterns.push(EntityPattern {
86            keywords: vec!["what is", "where does", "who is", "what does"],
87            slot: "",
88            needs_value: false,
89        });
90    }
91
92    /// Analyze a query and produce an execution plan.
93    #[must_use]
94    pub fn plan(&self, query: &str, top_k: usize) -> QueryPlan {
95        let query_lower = query.to_lowercase();
96
97        // Try to detect relational patterns
98        if let Some(pattern) = self.detect_pattern(&query_lower, query) {
99            if pattern.triples.is_empty() {
100                // No specific pattern found, use vector search
101                QueryPlan::vector_only(Some(query.to_string()), None, top_k)
102            } else {
103                // Found relational pattern - use hybrid search
104                QueryPlan::hybrid(pattern, Some(query.to_string()), None, top_k)
105            }
106        } else {
107            // Default to vector-only search
108            QueryPlan::vector_only(Some(query.to_string()), None, top_k)
109        }
110    }
111
112    fn detect_pattern(&self, query_lower: &str, _original: &str) -> Option<GraphPattern> {
113        let mut pattern = GraphPattern::new();
114
115        for ep in &self.entity_patterns {
116            for keyword in &ep.keywords {
117                if query_lower.contains(keyword) {
118                    // Extract the value after the keyword
119                    if let Some(pos) = query_lower.find(keyword) {
120                        let after = &query_lower[pos + keyword.len()..];
121                        let value = extract_value(after);
122
123                        if !value.is_empty() && ep.needs_value {
124                            // Create pattern: ?entity :slot "value"
125                            pattern.add(TriplePattern::any_slot_value("entity", ep.slot, &value));
126                            return Some(pattern);
127                        }
128                    }
129                }
130            }
131        }
132
133        // Check for entity-specific queries like "alice's employer" or "what is alice's job"
134        if let Some((entity, slot)) = extract_possessive_query(query_lower) {
135            pattern.add(TriplePattern::entity_slot_any(&entity, &slot, "value"));
136            return Some(pattern);
137        }
138
139        Some(pattern)
140    }
141}
142
143/// Extract a value from text after a keyword.
144fn extract_value(text: &str) -> String {
145    let trimmed = text.trim();
146    // Take words until we hit a common query continuation
147    let stop_words = ["and", "or", "who", "what", "that", "?"];
148    let mut words = Vec::new();
149
150    for word in trimmed.split_whitespace() {
151        let clean = word.trim_matches(|c: char| !c.is_alphanumeric() && c != '-');
152        if stop_words.contains(&clean.to_lowercase().as_str()) {
153            break;
154        }
155        if !clean.is_empty() {
156            words.push(clean);
157        }
158        // Stop after a few words
159        if words.len() >= 3 {
160            break;
161        }
162    }
163
164    words.join(" ")
165}
166
167/// Extract entity and slot from possessive queries like "alice's employer".
168fn extract_possessive_query(query: &str) -> Option<(String, String)> {
169    // Pattern: "X's Y" or "X's Y is"
170    if let Some(pos) = query.find("'s ") {
171        let entity = query[..pos].split_whitespace().last()?;
172        let after = &query[pos + 3..];
173        let slot = after.split_whitespace().next()?;
174
175        // Map common slot aliases
176        let slot = match slot {
177            "job" | "work" | "employer" | "role" | "company" => "workplace",
178            "home" | "city" | "address" => "location",
179            "favorite" => "preference",
180            "wife" | "husband" | "spouse" | "partner" => "spouse",
181            other => other,
182        };
183
184        return Some((entity.to_string(), slot.to_string()));
185    }
186    None
187}
188
189/// Graph matcher that executes patterns against MemoryCards.
190pub struct GraphMatcher<'a> {
191    memvid: &'a Memvid,
192}
193
194impl<'a> GraphMatcher<'a> {
195    /// Create a new graph matcher.
196    pub fn new(memvid: &'a Memvid) -> Self {
197        Self { memvid }
198    }
199
200    /// Execute a graph pattern and return matching results.
201    pub fn execute(&self, pattern: &GraphPattern) -> Vec<GraphMatchResult> {
202        let mut results = Vec::new();
203
204        for triple in &pattern.triples {
205            let matches = self.match_triple(triple);
206            results.extend(matches);
207        }
208
209        // Deduplicate by entity
210        let mut seen = HashSet::new();
211        results.retain(|r| seen.insert(r.entity.clone()));
212
213        results
214    }
215
216    fn match_triple(&self, triple: &TriplePattern) -> Vec<GraphMatchResult> {
217        let mut results = Vec::new();
218
219        match (&triple.subject, &triple.predicate, &triple.object) {
220            // Pattern: ?entity :slot "value" - find entities with this slot value
221            (
222                PatternTerm::Variable(var),
223                PatternTerm::Literal(slot),
224                PatternTerm::Literal(value),
225            ) => {
226                // Iterate all entities and check for matching slot value
227                for entity in self.memvid.memory_entities() {
228                    let cards = self.memvid.get_entity_memories(&entity);
229                    for card in cards {
230                        if card.slot.to_lowercase() == *slot
231                            && card.value.to_lowercase().contains(&value.to_lowercase())
232                        {
233                            let mut result = GraphMatchResult::new(
234                                entity.clone(),
235                                vec![card.source_frame_id],
236                                1.0,
237                            );
238                            result.bind(var, entity.clone());
239                            results.push(result);
240                            break; // One match per entity
241                        }
242                    }
243                }
244            }
245
246            // Pattern: "entity" :slot ?value - get entity's slot value
247            (
248                PatternTerm::Literal(entity),
249                PatternTerm::Literal(slot),
250                PatternTerm::Variable(var),
251            ) => {
252                if let Some(card) = self.memvid.get_current_memory(entity, slot) {
253                    let mut result =
254                        GraphMatchResult::new(entity.clone(), vec![card.source_frame_id], 1.0);
255                    result.bind(var, card.value.clone());
256                    results.push(result);
257                }
258            }
259
260            // Pattern: "entity" :slot "value" - check if entity has this exact value
261            (
262                PatternTerm::Literal(entity),
263                PatternTerm::Literal(slot),
264                PatternTerm::Literal(value),
265            ) => {
266                if let Some(card) = self.memvid.get_current_memory(entity, slot) {
267                    if card.value.to_lowercase().contains(&value.to_lowercase()) {
268                        let result =
269                            GraphMatchResult::new(entity.clone(), vec![card.source_frame_id], 1.0);
270                        results.push(result);
271                    }
272                }
273            }
274
275            _ => {
276                // Other patterns not yet implemented
277            }
278        }
279
280        results
281    }
282
283    /// Get frame IDs from graph matches for use in vector search filtering.
284    #[must_use]
285    pub fn get_candidate_frames(&self, matches: &[GraphMatchResult]) -> Vec<FrameId> {
286        let mut frame_ids: Vec<FrameId> = matches
287            .iter()
288            .flat_map(|m| m.frame_ids.iter().copied())
289            .collect();
290        frame_ids.sort_unstable();
291        frame_ids.dedup();
292        frame_ids
293    }
294
295    /// Get matched entities for context.
296    #[must_use]
297    pub fn get_matched_entities(&self, matches: &[GraphMatchResult]) -> HashMap<FrameId, String> {
298        let mut map = HashMap::new();
299        for m in matches {
300            for &fid in &m.frame_ids {
301                map.insert(fid, m.entity.clone());
302            }
303        }
304        map
305    }
306}
307
308/// Execute a hybrid search: graph filter + vector ranking.
309pub fn hybrid_search(memvid: &mut Memvid, plan: &QueryPlan) -> Result<Vec<HybridSearchHit>> {
310    match plan {
311        QueryPlan::VectorOnly {
312            query_text, top_k, ..
313        } => {
314            // Fall back to regular lexical search
315            let query = query_text.as_deref().unwrap_or("");
316            let request = SearchRequest {
317                query: query.to_string(),
318                top_k: *top_k,
319                snippet_chars: 200,
320                uri: None,
321                scope: None,
322                cursor: None,
323                #[cfg(feature = "temporal_track")]
324                temporal: None,
325                as_of_frame: None,
326                as_of_ts: None,
327                no_sketch: false,
328            };
329            let response = memvid.search(request)?;
330            Ok(response
331                .hits
332                .iter()
333                .map(|h| {
334                    let score = h.score.unwrap_or(0.0);
335                    HybridSearchHit {
336                        frame_id: h.frame_id,
337                        score,
338                        graph_score: 0.0,
339                        vector_score: score,
340                        matched_entity: None,
341                        preview: Some(h.text.clone()),
342                    }
343                })
344                .collect())
345        }
346
347        QueryPlan::GraphOnly { pattern, limit } => {
348            let matcher = GraphMatcher::new(memvid);
349            let matches = matcher.execute(pattern);
350
351            Ok(matches
352                .into_iter()
353                .take(*limit)
354                .map(|m| HybridSearchHit {
355                    frame_id: m.frame_ids.first().copied().unwrap_or(0),
356                    score: m.confidence,
357                    graph_score: m.confidence,
358                    vector_score: 0.0,
359                    matched_entity: Some(m.entity),
360                    preview: None,
361                })
362                .collect())
363        }
364
365        QueryPlan::Hybrid {
366            graph_filter,
367            query_text,
368            top_k,
369            ..
370        } => {
371            // Step 1: Execute graph pattern to get candidate frames
372            let matcher = GraphMatcher::new(memvid);
373            let matches = matcher.execute(graph_filter);
374            let entity_map = matcher.get_matched_entities(&matches);
375            let candidate_frames = matcher.get_candidate_frames(&matches);
376
377            if candidate_frames.is_empty() {
378                // No graph matches - fall back to lexical search
379                let query = query_text.as_deref().unwrap_or("");
380                let request = SearchRequest {
381                    query: query.to_string(),
382                    top_k: *top_k,
383                    snippet_chars: 200,
384                    uri: None,
385                    scope: None,
386                    cursor: None,
387                    #[cfg(feature = "temporal_track")]
388                    temporal: None,
389                    as_of_frame: None,
390                    as_of_ts: None,
391                    no_sketch: false,
392                };
393                let response = memvid.search(request)?;
394                return Ok(response
395                    .hits
396                    .iter()
397                    .map(|h| {
398                        let score = h.score.unwrap_or(0.0);
399                        HybridSearchHit {
400                            frame_id: h.frame_id,
401                            score,
402                            graph_score: 0.0,
403                            vector_score: score,
404                            matched_entity: None,
405                            preview: Some(h.text.clone()),
406                        }
407                    })
408                    .collect());
409            }
410
411            // Step 2: Return graph matches directly with frame previews
412            // Graph matching already found the relevant frames - return them
413            let mut hybrid_hits: Vec<HybridSearchHit> = Vec::new();
414
415            for &frame_id in &candidate_frames {
416                let matched_entity = entity_map.get(&frame_id).cloned();
417
418                // Get frame preview if possible
419                let preview = memvid.frame_preview_by_id(frame_id).ok();
420
421                hybrid_hits.push(HybridSearchHit {
422                    frame_id,
423                    score: 1.0, // Graph match score
424                    graph_score: 1.0,
425                    vector_score: 0.0,
426                    matched_entity,
427                    preview,
428                });
429            }
430
431            Ok(hybrid_hits.into_iter().take(*top_k).collect())
432        }
433    }
434}
435
436#[cfg(test)]
437mod tests {
438    use super::*;
439
440    #[test]
441    fn test_query_planner_detects_location() {
442        let planner = QueryPlanner::new();
443        let plan = planner.plan("who lives in San Francisco", 10);
444
445        match plan {
446            QueryPlan::Hybrid { graph_filter, .. } => {
447                assert!(!graph_filter.is_empty());
448                let triple = &graph_filter.triples[0];
449                assert!(matches!(&triple.predicate, PatternTerm::Literal(s) if s == "location"));
450            }
451            _ => panic!("Expected hybrid plan for location query"),
452        }
453    }
454
455    #[test]
456    fn test_query_planner_detects_workplace() {
457        let planner = QueryPlanner::new();
458        let plan = planner.plan("who works at Google", 10);
459
460        match plan {
461            QueryPlan::Hybrid { graph_filter, .. } => {
462                assert!(!graph_filter.is_empty());
463                let triple = &graph_filter.triples[0];
464                assert!(matches!(&triple.predicate, PatternTerm::Literal(s) if s == "workplace"));
465            }
466            _ => panic!("Expected hybrid plan for workplace query"),
467        }
468    }
469
470    #[test]
471    fn test_query_planner_possessive() {
472        let planner = QueryPlanner::new();
473        let plan = planner.plan("what is alice's employer", 10);
474
475        match plan {
476            QueryPlan::Hybrid { graph_filter, .. } => {
477                assert!(!graph_filter.is_empty());
478                let triple = &graph_filter.triples[0];
479                assert!(matches!(&triple.subject, PatternTerm::Literal(s) if s == "alice"));
480            }
481            _ => panic!("Expected hybrid plan for possessive query"),
482        }
483    }
484
485    #[test]
486    fn test_extract_value() {
487        assert_eq!(extract_value("San Francisco and"), "San Francisco");
488        assert_eq!(extract_value("Google who"), "Google");
489        assert_eq!(extract_value("New York City"), "New York City");
490    }
491
492    #[test]
493    fn test_extract_possessive() {
494        assert_eq!(
495            extract_possessive_query("what is alice's job"),
496            Some(("alice".to_string(), "workplace".to_string()))
497        );
498        assert_eq!(
499            extract_possessive_query("bob's location"),
500            Some(("bob".to_string(), "location".to_string()))
501        );
502    }
503}