mcpls_core/bridge/translator/

support.rs

//! Advisory per-tool support snapshot behind the `get_tool_support` MCP tool.
//!
//! The snapshot answers "would a call to this tool be dispatched to a server
//! that advertises its capability?" through the same pure decision functions
//! enforcement uses ([`lookup_route`], [`lookup_workspace_route`]) and the
//! same per-capability predicate ([`Capability::is_supported`], folded into a
//! [`CapabilitySet`] per server), so the report and the per-call
//! `require_capability` gate cannot drift apart. `require_capability` stays
//! the authoritative enforcement point.

use std::collections::{HashMap, HashSet};
use std::sync::Arc;

use lsp_types::ServerCapabilities;
use schemars::JsonSchema;
use serde::Serialize;

use super::Translator;
use super::pull_support::PullSupport;
use super::routing::{
    Capability, LanguageCandidates, RouteLookup, WorkspaceRouteLookup, lookup_route,
    lookup_workspace_route,
};
use crate::bridge::ClientPath;
use crate::config::{LanguageId, LanguageMap, ServerId, ToolKind, ToolRouter};
use crate::error::Result;
use crate::util::lock_std;

/// Whether one route of a tool would be dispatched to a capable server.
///
/// `Supported` means "will be dispatched", not "will succeed": push-only
/// diagnostics, respawn backoff and indexing can still fail the call.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, JsonSchema)]
#[serde(tag = "status", rename_all = "snake_case")]
pub enum RouteSupport {
    /// The routed server is registered and advertises the tool's capability.
    Supported {
        /// The server the call would be dispatched to.
        server: ServerId,
    },
    /// Registered and publishing diagnostics, but with no pull provider: answers come from the push cache.
    ///
    /// `get_diagnostics` answers from the push cache.
    PushOnly {
        /// The server the call would be dispatched to.
        server: ServerId,
    },
    /// The routed server is registered but does not advertise the capability.
    CapabilityNotAdvertised {
        /// The server the call would be dispatched to.
        server: ServerId,
        /// The capability the server does not advertise.
        capability: Capability,
    },
    /// The routed server has not finished initializing, or its capabilities
    /// are not known yet.
    Initializing,
    /// No server is routed for this tool.
    NoServer,
}

/// The set of [`Capability`] values one server advertises, one bit each.
///
/// Computed once per snapshot through [`Capability::is_supported`], so the
/// snapshot never clones a server's full `ServerCapabilities`.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
pub struct CapabilitySet(u32);

impl CapabilitySet {
    /// The capabilities `caps` advertises.
    pub fn of(caps: &ServerCapabilities) -> Self {
        Capability::ALL
            .into_iter()
            .filter(|capability| capability.is_supported(caps))
            .fold(Self::default(), |set, capability| {
                Self(set.0 | 1 << capability as u32)
            })
    }

    /// Whether `capability` is in the set.
    pub const fn contains(self, capability: Capability) -> bool {
        self.0 & (1 << capability as u32) != 0
    }
}

/// A point-in-time copy of the registries needed to answer
/// [`RouteSupport`] queries without holding any `Translator` lock.
///
/// Dynamic capability registrations are invisible to both this snapshot and
/// `require_capability`; see `Translator::require_capability`.
#[derive(Debug)]
pub struct ToolSupportSnapshot {
    language_map: Arc<LanguageMap>,
    router: Arc<ToolRouter>,
    expected: HashSet<ServerId>,
    running: HashMap<ServerId, RunningSupport>,
    registered: HashSet<ServerId>,
}

/// What a running server's capabilities and pull behavior allow, read in one
/// pass so an id never has one without the other.
#[derive(Debug, Clone, Copy)]
struct RunningSupport {
    caps: CapabilitySet,
    pull: PullSupport,
}

impl ToolSupportSnapshot {
    /// Every language a file can be detected as that reaches a configured
    /// route, sorted: a mapped language counts when it, or its React base
    /// language, has a server. A configured language no extension or name maps
    /// to is not listed, since no file can be routed to it.
    pub(crate) fn languages(&self) -> Vec<LanguageId> {
        let configured = self.router.configured_languages();
        let mut languages: Vec<LanguageId> = self
            .language_map
            .languages()
            .filter(|language| {
                LanguageCandidates::new((*language).clone())
                    .iter()
                    .any(|candidate| configured.contains(candidate))
            })
            .cloned()
            .collect();
        languages.sort_unstable();
        languages.dedup();
        languages
    }

    /// Support for a per-document `tool` on files of `language`, gated on the
    /// tool's primary capability.
    #[cfg(test)]
    pub(crate) fn document_support(&self, language: &LanguageId, tool: ToolKind) -> RouteSupport {
        self.document_support_gated(language, tool, Capability::for_tool(tool))
    }

    /// Support for a per-document `tool` on files of `language`, gated on
    /// `capability` (`None` for an ungated tool). A tool that shares another
    /// tool's route but needs a different capability, such as `prepare_rename`
    /// on the `Rename` route, passes its own.
    pub(crate) fn document_support_gated(
        &self,
        language: &LanguageId,
        tool: ToolKind,
        capability: Option<Capability>,
    ) -> RouteSupport {
        let lookup = lookup_route(
            &LanguageCandidates::new(language.clone()),
            |lang| self.router.resolve(lang, tool).cloned(),
            |id| self.registered.contains(id).then_some(()),
            |id| self.expected.contains(id),
            |lang| {
                self.router
                    .catch_all_for(lang)
                    .filter(|id| self.expected.contains(*id))
                    .cloned()
            },
            |_| None,
        );
        match lookup {
            RouteLookup::Registered(server, ()) => {
                match (tool, self.registered_support(server, capability)) {
                    (ToolKind::Diagnostics, RouteSupport::Supported { server })
                        if self.answers_from_push_cache(&server) =>
                    {
                        RouteSupport::PushOnly { server }
                    }
                    (_, support) => support,
                }
            }
            RouteLookup::Initializing(_) => RouteSupport::Initializing,
            RouteLookup::Failed(_) | RouteLookup::Dangling { .. } | RouteLookup::Unrouted => {
                RouteSupport::NoServer
            }
        }
    }

    /// Support for a workspace-wide `tool` (no document, hence no language).
    pub(crate) fn workspace_support(&self, tool: ToolKind) -> RouteSupport {
        let lookup = lookup_workspace_route(
            || self.router.resolve_any(tool).cloned(),
            |id| self.registered.contains(id),
            |id| self.expected.contains(id),
            || self.expected.is_empty(),
        );
        match lookup {
            WorkspaceRouteLookup::Registered(server) => {
                self.registered_support(server, Capability::for_tool(tool))
            }
            WorkspaceRouteLookup::Initializing(_) | WorkspaceRouteLookup::AllInitializing => {
                RouteSupport::Initializing
            }
            WorkspaceRouteLookup::Dangling(_)
            | WorkspaceRouteLookup::NothingConfigured
            | WorkspaceRouteLookup::NoClaimant => RouteSupport::NoServer,
        }
    }

    /// Whether `get_diagnostics` reads `server`'s push cache because it
    /// advertises no pull provider and has not shown that it answers pulls.
    fn answers_from_push_cache(&self, server: &ServerId) -> bool {
        matches!(
            self.running.get(server).map(|running| running.pull),
            Some(PullSupport::Probing | PullSupport::Unsupported)
        )
    }

    fn registered_support(&self, server: ServerId, capability: Option<Capability>) -> RouteSupport {
        let Some(RunningSupport { caps, .. }) = self.running.get(&server) else {
            return RouteSupport::Initializing;
        };
        match capability {
            Some(capability) if !caps.contains(capability) => {
                RouteSupport::CapabilityNotAdvertised { server, capability }
            }
            _ => RouteSupport::Supported { server },
        }
    }
}

impl Translator {
    /// Copy the registries `get_tool_support` reads: one `servers` guard, then
    /// one router clone. A server is a single slot, so a healthy server is
    /// seen as registered or expected, never as neither (which would be
    /// misreported as `no_server`), whatever registration or restart is
    /// doing at the same moment.
    pub(crate) fn tool_support_snapshot(&self) -> ToolSupportSnapshot {
        let servers = lock_std(&self.servers);
        let expected = servers.expected();
        let running = servers
            .running_servers()
            .map(|(id, server)| {
                (
                    id.clone(),
                    RunningSupport {
                        caps: CapabilitySet::of(server.capabilities()),
                        pull: servers.pull_support(id),
                    },
                )
            })
            .collect();
        let registered = servers
            .ids()
            .filter(|id| servers.client(id).is_some())
            .cloned()
            .collect();
        drop(servers);
        // Read after the registry: a settlement writes the registry first and
        // the router after, so a router that is newer than the registry only
        // moves routes toward servers that are already registered or expected.
        let router = self.router_snapshot();
        ToolSupportSnapshot {
            language_map: Arc::clone(&self.language_map),
            router,
            expected,
            running,
            registered,
        }
    }

    /// The language of the file at `path`, after workspace-root validation.
    ///
    /// # Errors
    ///
    /// Returns the same path-validation errors as every document tool.
    pub(crate) async fn language_for_path(&self, path: &ClientPath) -> Result<LanguageId> {
        let validated = self.validate_path(path).await?;
        Ok(self
            .language_candidates(validated.as_path())
            .language()
            .clone())
    }
}

#[cfg(test)]
mod tests {
    use tempfile::TempDir;

    use super::super::testing::translator_with_capabilities;
    use super::*;
    use crate::config::FileExtension;
    use crate::test_lsp::client_path;

    fn rust_language_map() -> Arc<LanguageMap> {
        Arc::new(LanguageMap::from(HashMap::from([(
            FileExtension::from_static("rs"),
            LanguageId::from_static("rust"),
        )])))
    }

    fn rust_caps(hover: bool) -> ServerCapabilities {
        ServerCapabilities {
            hover_provider: hover.then_some(lsp_types::HoverProvider::Bool(true)),
            ..Default::default()
        }
    }

    fn snapshot(
        registered: &[&str],
        expected: &[&str],
        caps: &[(&str, ServerCapabilities)],
    ) -> ToolSupportSnapshot {
        let ids = |names: &[&str]| names.iter().map(|n| ServerId::new(*n).unwrap()).collect();
        ToolSupportSnapshot {
            language_map: rust_language_map(),
            router: Arc::new(ToolRouter::catch_all([(
                ServerId::from_static("rust"),
                LanguageId::from_static("rust"),
            )])),
            expected: ids(expected),
            running: caps
                .iter()
                .map(|(id, caps)| {
                    (
                        ServerId::new(*id).unwrap(),
                        RunningSupport {
                            caps: CapabilitySet::of(caps),
                            pull: PullSupport::Advertised,
                        },
                    )
                })
                .collect(),
            registered: ids(registered),
        }
    }

    #[test]
    fn capability_tool_kind_round_trips() {
        for capability in Capability::ALL {
            if capability.is_primary() {
                assert_eq!(
                    Capability::for_tool(capability.tool_kind()),
                    Some(capability)
                );
            } else {
                assert_ne!(
                    Capability::for_tool(capability.tool_kind()),
                    Some(capability)
                );
            }
        }
        assert_eq!(Capability::for_tool(ToolKind::Diagnostics), None);
        for tool in ToolKind::ALL {
            let expected = usize::from(*tool != ToolKind::Diagnostics);
            assert_eq!(
                Capability::ALL
                    .iter()
                    .filter(|c| c.tool_kind() == *tool && c.is_primary())
                    .count(),
                expected,
                "{tool}"
            );
        }
    }

    #[test]
    fn prepare_rename_shares_the_rename_route_with_its_own_capability() {
        let rename_only = ServerCapabilities {
            rename_provider: Some(lsp_types::RenameProvider::Bool(true)),
            ..Default::default()
        };
        let with_prepare = ServerCapabilities {
            rename_provider: Some(lsp_types::RenameProvider::RenameOptions(
                lsp_types::RenameOptions {
                    prepare_provider: Some(true),
                    ..Default::default()
                },
            )),
            ..Default::default()
        };
        let server = ServerId::from_static("rust");
        let snap = snapshot(&["rust"], &[], &[("rust", rename_only)]);
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Rename),
            RouteSupport::Supported {
                server: server.clone()
            }
        );
        assert_eq!(
            snap.document_support_gated(
                &LanguageId::from_static("rust"),
                ToolKind::Rename,
                Some(Capability::PrepareRename)
            ),
            RouteSupport::CapabilityNotAdvertised {
                server: server.clone(),
                capability: Capability::PrepareRename,
            }
        );
        let snap = snapshot(&["rust"], &[], &[("rust", with_prepare)]);
        assert_eq!(
            snap.document_support_gated(
                &LanguageId::from_static("rust"),
                ToolKind::Rename,
                Some(Capability::PrepareRename)
            ),
            RouteSupport::Supported { server }
        );
    }

    #[test]
    fn capability_set_fits_every_capability() {
        assert!(Capability::ALL.len() > 16);
        let caps = ServerCapabilities {
            document_range_formatting_provider: Some(
                lsp_types::DocumentRangeFormattingProvider::Bool(true),
            ),
            ..Default::default()
        };
        assert!(CapabilitySet::of(&caps).contains(Capability::FormatRange));
    }

    #[test]
    fn registered_server_with_capability_is_supported() {
        let snap = snapshot(&["rust"], &[], &[("rust", rust_caps(true))]);
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::Supported {
                server: ServerId::from_static("rust")
            }
        );
    }

    #[test]
    fn registered_server_without_capability_is_not_advertised() {
        let snap = snapshot(&["rust"], &[], &[("rust", rust_caps(false))]);
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::CapabilityNotAdvertised {
                server: ServerId::from_static("rust"),
                capability: Capability::Hover,
            }
        );
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Diagnostics),
            RouteSupport::Supported {
                server: ServerId::from_static("rust")
            }
        );
    }

    fn snapshot_with_pull(pull: PullSupport) -> ToolSupportSnapshot {
        ToolSupportSnapshot {
            language_map: rust_language_map(),
            running: HashMap::from([(
                ServerId::from_static("rust"),
                RunningSupport {
                    caps: CapabilitySet::of(&rust_caps(true)),
                    pull,
                },
            )]),
            ..snapshot(&["rust"], &[], &[("rust", rust_caps(true))])
        }
    }

    /// #666: a server that advertises no pull provider, and has not shown it
    /// answers pulls, is reported as answering `get_diagnostics` from the push
    /// cache; one that advertises or answers is plain supported.
    #[test]
    fn diagnostics_route_is_push_only_unless_pull_is_advertised_or_answered() {
        let language = LanguageId::from_static("rust");
        let server = ServerId::from_static("rust");
        for (pull, push_only) in [
            (PullSupport::Advertised, false),
            (PullSupport::Answers, false),
            (PullSupport::Probing, true),
            (PullSupport::Unsupported, true),
        ] {
            let support =
                snapshot_with_pull(pull).document_support(&language, ToolKind::Diagnostics);
            let expected = if push_only {
                RouteSupport::PushOnly {
                    server: server.clone(),
                }
            } else {
                RouteSupport::Supported {
                    server: server.clone(),
                }
            };
            assert_eq!(support, expected, "{pull:?}");
        }
        assert_eq!(
            snapshot_with_pull(PullSupport::Unsupported)
                .document_support(&language, ToolKind::Hover),
            RouteSupport::Supported { server },
            "only the diagnostics route is affected"
        );
    }

    #[test]
    fn client_without_server_capabilities_is_initializing() {
        let snap = snapshot(&["rust"], &[], &[]);
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::Initializing
        );
    }

    #[test]
    fn expected_but_unregistered_server_is_initializing() {
        let snap = snapshot(&[], &["rust"], &[]);
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::Initializing
        );
        assert_eq!(
            snap.workspace_support(ToolKind::WorkspaceSymbols),
            RouteSupport::Initializing
        );
    }

    #[test]
    fn capability_set_holds_exactly_the_advertised_capabilities() {
        let set = CapabilitySet::of(&rust_caps(true));
        for capability in Capability::ALL {
            assert_eq!(
                set.contains(capability),
                capability == Capability::Hover,
                "{capability:?}"
            );
        }
        assert_eq!(
            CapabilitySet::of(&ServerCapabilities::default()),
            CapabilitySet::default()
        );
    }

    /// A server's whole lifecycle, step by step (expected, registered, taken
    /// out for a restart, restored): at no step does a snapshot read it as
    /// `no_server`, because each step is one slot transition.
    #[tokio::test]
    async fn server_is_never_misreported_across_registration_and_restart_steps() {
        use crate::lsp::LspServer;

        let id = ServerId::from_static("rust");
        let translator = Translator::new().with_router(ToolRouter::catch_all([(
            id.clone(),
            LanguageId::from_static("rust"),
        )]));
        let check = |step: &str| {
            let snap = translator.tool_support_snapshot();
            assert_ne!(
                snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
                RouteSupport::NoServer,
                "document route, {step}"
            );
            assert_ne!(
                snap.workspace_support(ToolKind::WorkspaceSymbols),
                RouteSupport::NoServer,
                "workspace route, {step}"
            );
        };

        translator.set_expected_servers(HashSet::from([id.clone()]));
        check("expected");
        translator.register_server(id.clone(), LspServer::new_for_test(rust_caps(true)));
        check("registered");
        let held = lock_std(&translator.servers).take_for_restart(&id);
        check("taken for restart");
        let refused = lock_std(&translator.servers).restore(&id, held.unwrap());
        assert!(refused.is_none());
        check("restored");
        translator.clear_expected_servers();
        check("expectation cleared");
        assert_eq!(
            translator
                .tool_support_snapshot()
                .document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::Supported { server: id }
        );
    }

    #[test]
    fn language_without_live_route_is_listed_as_no_server() {
        let mut router = ToolRouter::catch_all([(
            ServerId::from_static("rust"),
            LanguageId::from_static("rust"),
        )]);
        router.rebind_to_registered(&HashSet::new());
        let snap = ToolSupportSnapshot {
            language_map: rust_language_map(),
            router: Arc::new(router),
            expected: HashSet::new(),
            running: HashMap::new(),
            registered: HashSet::new(),
        };
        assert_eq!(snap.languages(), ["rust"]);
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::NoServer
        );
    }

    #[test]
    fn test_languages_list_mapped_languages_with_a_route_including_the_react_base() {
        let mut language_map = LanguageMap::from(HashMap::from([
            (
                FileExtension::from_static("ts"),
                LanguageId::from_static("typescript"),
            ),
            (
                FileExtension::from_static("tsx"),
                LanguageId::from_static("typescriptreact"),
            ),
            (
                FileExtension::from_static("py"),
                LanguageId::from_static("python"),
            ),
        ]));
        language_map.insert(
            crate::config::PatternTarget::Name(crate::config::FileName::from_static("Makefile")),
            LanguageId::from_static("make"),
        );
        let snap = ToolSupportSnapshot {
            language_map: Arc::new(language_map),
            router: Arc::new(ToolRouter::catch_all([
                (
                    ServerId::from_static("ts"),
                    LanguageId::from_static("typescript"),
                ),
                (
                    ServerId::from_static("make-lsp"),
                    LanguageId::from_static("make"),
                ),
                (
                    ServerId::from_static("unmapped"),
                    LanguageId::from_static("zig"),
                ),
            ])),
            expected: HashSet::new(),
            running: HashMap::new(),
            registered: HashSet::new(),
        };
        assert_eq!(snap.languages(), ["make", "typescript", "typescriptreact"]);
    }

    #[test]
    fn nothing_configured_workspace_support_is_no_server() {
        let snap = ToolSupportSnapshot {
            language_map: rust_language_map(),
            router: Arc::new(ToolRouter::default()),
            expected: HashSet::new(),
            running: HashMap::new(),
            registered: HashSet::new(),
        };
        assert_eq!(snap.languages().len(), 0);
        assert_eq!(
            snap.workspace_support(ToolKind::WorkspaceSymbols),
            RouteSupport::NoServer
        );
    }

    #[tokio::test]
    async fn translator_snapshot_reflects_registered_capabilities() {
        let dir = TempDir::new().unwrap();
        let id = ServerId::from_static("rust");
        let (translator, _fake) = translator_with_capabilities(&dir, &id, rust_caps(true));
        let snap = translator.tool_support_snapshot();
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Hover),
            RouteSupport::Supported { server: id.clone() }
        );
        assert_eq!(
            snap.document_support(&LanguageId::from_static("rust"), ToolKind::Rename),
            RouteSupport::CapabilityNotAdvertised {
                server: id,
                capability: Capability::Rename,
            }
        );
    }

    #[tokio::test]
    async fn language_for_path_validates_and_detects() {
        let dir = TempDir::new().unwrap();
        let (translator, _fake) = translator_with_capabilities(
            &dir,
            &ServerId::from_static("rust"),
            ServerCapabilities::default(),
        );
        let file = dir.path().join("a.rs");
        std::fs::write(&file, "").unwrap();
        assert_eq!(
            translator
                .language_for_path(&client_path(&file))
                .await
                .unwrap(),
            "rust"
        );
        assert!(
            translator
                .language_for_path(&client_path("/definitely/missing.rs"))
                .await
                .is_err()
        );
    }
}