Skip to main content

Module followup

Module followup 

Source
Expand description

Follow-up tasks for the findings a merged run left open.

A run can hand off after its review budget is spent with findings still open (and, with land_approval off, merge unattended). Those findings live in the pull request body, which nobody reads after the merge. This module files them as queue tasks instead, once the merge is confirmed.

What is filed: every Major-or-above finding of the last review round, and every finding of a seat whose final vote was reject (a vote carries no per-finding reasoning, so the seat’s Minor/Nit findings come along). Other Minor/Nit findings are only listed, in the pull-request comment.

Best-effort by construction, like bump::after_merge: after_merge returns (), records every failure as a run event and never touches status.

Structs§

Outcome
What one pass did.

Constants§

MAX_FOLLOWUP_GENERATION
A task of this generation (or deeper) does not file follow-ups of its own.
NODE
Node name carried by Source::Agent on a filed follow-up.

Functions§

after_merge
File follow-ups for a run that just merged, and comment on the pull request. Never fails: problems become run events.
file
The deterministic half of after_merge: select, group, and file into queue. Records the event and the run’s own bookkeeping; the caller saves the state.