Skip to main content

magi/
report.rs

1//! Terminal rendering.
2//!
3//! A run produces a lot of state; the report exists so the operator can decide
4//! what to do next without opening `run.json`. It leads with the disagreement,
5//! because that is the part that carries information: three judges agreeing
6//! tells you nothing the winner's diff does not.
7//!
8//! Colour is a six-line local implementation rather than a crate. The
9//! alternatives all decide *for* you whether the stream supports colour, which
10//! makes the output untestable — `assert!(text.contains("winner  A"))` fails on
11//! an escape sequence the test never asked for.
12use std::fmt::Write as _;
13use std::sync::atomic::{AtomicBool, Ordering};
14
15use crate::config::{MergeMode, MergeStyle};
16use crate::run::{
17    CommandOutcome, ContinuationOutcome, E2eStatus, GateStatus, JobStatus, Liveness,
18    OperatorFixOutcome, RunState, RunStatus, tail,
19};
20use crate::stats::{RepoStats, Stats};
21use crate::verdict::ReviewVote;
22
23static COLOR: AtomicBool = AtomicBool::new(true);
24
25/// Turn colour on or off for every subsequent render.
26pub fn set_color(on: bool) {
27    COLOR.store(on, Ordering::Relaxed);
28}
29
30fn paint(text: &str, code: &str) -> String {
31    if COLOR.load(Ordering::Relaxed) {
32        format!("\x1b[{code}m{text}\x1b[0m")
33    } else {
34        text.to_owned()
35    }
36}
37
38fn bold(t: &str) -> String {
39    paint(t, "1")
40}
41fn dim(t: &str) -> String {
42    paint(t, "2")
43}
44fn red(t: &str) -> String {
45    paint(t, "31")
46}
47fn green(t: &str) -> String {
48    paint(t, "32")
49}
50fn yellow(t: &str) -> String {
51    paint(t, "33")
52}
53fn cyan(t: &str) -> String {
54    paint(t, "36")
55}
56
57/// Colour for a status word.
58///
59/// `Stalled` is deliberately not green: a run whose judges were taken out by a
60/// rate limit must not look like a healthy `Ready` in a one-line listing.
61///
62/// A `Ready` reached via `[merge] mode = "none"` is a second case that must
63/// not look like a plain `Ready`: that run is done for good, never picked up
64/// by the PR-polling merge watcher or anything else, while an ordinary
65/// `Ready` (a PR closed without merging, an already-concluded re-entry) may
66/// still be a live landing candidate. See [`RunState::unmerged_by_design`].
67fn status_word(state: &RunState) -> String {
68    if state.unmerged_by_design() {
69        return cyan("unmerged (no-op by design)");
70    }
71    let text = state.status.display_label();
72    if state.needs_attention() {
73        return bold(&yellow(&format!("{text} - release needs a human")));
74    }
75    match state.status {
76        RunStatus::Merged => bold(&green(text)),
77        RunStatus::Ready => green(text),
78        RunStatus::Stalled => bold(&yellow(text)),
79        RunStatus::Blocked => yellow(text),
80        RunStatus::Failed => red(text),
81        // Not `Failed`'s red: every candidate agreed, with evidence, that
82        // nothing belongs in this worktree — the opposite of a run that
83        // could not do the work. See `RunStatus::VerifiedNoop`'s own doc.
84        RunStatus::VerifiedNoop => cyan(text),
85        // Muted, not `Blocked`'s yellow: nothing here needs a human's
86        // attention any more, a later attempt already settled the task.
87        RunStatus::Superseded => dim(text),
88        _ => cyan(text),
89    }
90}
91
92/// Colour for a reviewer vote — the same scale a finding's severity gets:
93/// green for no reservations, yellow for proceed-but-look-at-this, red for a
94/// vote that says stop.
95fn vote_tag(vote: ReviewVote) -> String {
96    let text = vote.label();
97    match vote {
98        ReviewVote::Approve => green(text),
99        ReviewVote::ApproveWithFindings => yellow(text),
100        ReviewVote::Reject => red(text),
101    }
102}
103
104/// One-line summary, for `magi list`.
105pub fn line(state: &RunState) -> String {
106    line_with_liveness(state, Liveness::Unknown)
107}
108
109/// [`line`] with the independent process-liveness observation available to
110/// `magi list`.
111pub fn line_with_liveness(state: &RunState, live: Liveness) -> String {
112    let winner = state
113        .tally
114        .as_ref()
115        .map_or("-".to_owned(), |t| t.winner.to_string());
116    let agent = state.winner().map_or("-", |c| c.agent.as_str());
117    // A below-quorum verdict carries an explicit stamp so a row in a listing
118    // reads "stalled" and "2/3 judges" without opening the report.
119    let quorum = match state.tally.as_ref() {
120        Some(t) if !t.met_quorum => format!(
121            "  {}",
122            bold(&red(&format!("quorum {}/{}", t.present, t.judges)))
123        ),
124        Some(t) if t.present > 0 && t.present < t.judges => format!(
125            "  {}",
126            yellow(&format!("judges {}/{}", t.present, t.judges))
127        ),
128        _ => String::new(),
129    };
130    let stale = if !state.status.done() && live == Liveness::Dead {
131        format!(
132            "  {}",
133            bold(&yellow("STALE — driver exited; resume required"))
134        )
135    } else {
136        String::new()
137    };
138    format!(
139        "{}  {:<20}  {:>2}c {:>2}j  win {} ({}){quorum}{stale}  {}",
140        dim(&state.id),
141        status_word(state),
142        state.candidates.len(),
143        state.judgements.len(),
144        winner,
145        agent,
146        first_line(&state.instruction)
147    )
148}
149
150/// A plainly visible verdict for a non-terminal run whose recorded driver is
151/// gone. Kept separate from [`active_seats`] because a process can die at a
152/// node boundary with no active seat left in the saved state.
153pub fn liveness_notice(state: &RunState, live: Liveness) -> String {
154    if !state.status.done() && live == Liveness::Dead {
155        format!(
156            "{}\n\n",
157            yellow("STALE — the process driving this run exited; resume it to continue.")
158        )
159    } else {
160        String::new()
161    }
162}
163
164/// A plainly visible note for a run a later attempt at the same task already
165/// replaced — the terminal counterpart of the web UI's "Superseded by …"
166/// line. `later` is the short id of that later attempt, or `None` when this
167/// run is not superseded at all (the common case).
168///
169/// Kept as its own function, concatenated by the caller, rather than an
170/// argument threaded through [`run`] itself: `run` is called from `bump.rs`,
171/// `tui.rs` and every `magi show`/`magi list` path with no notion of "what
172/// replaced this", and adding a parameter there would mean guessing `None`
173/// at every one of those call sites instead of only at the one that knows.
174pub fn superseded_notice(later: Option<&str>) -> String {
175    match later {
176        Some(later) => format!(
177            "{}\n\n",
178            yellow(&format!(
179                "SUPERSEDED — a later attempt at this task ({later}) replaced it; this record \
180                 is kept but is not the one to act on."
181            ))
182        ),
183        None => String::new(),
184    }
185}
186
187fn first_line(text: &str) -> String {
188    let line = text.lines().next().unwrap_or_default();
189    if line.chars().count() > 68 {
190        format!("{}…", line.chars().take(67).collect::<String>())
191    } else {
192        line.to_owned()
193    }
194}
195
196fn short(commit: &str) -> String {
197    commit.chars().take(7).collect()
198}
199
200/// A short badge for a [`crate::run::ContinuationRecord`], distinguishing
201/// "the seat's own report needed to be resumed" from "there was nothing to
202/// address" — a fixer that has never needed this stays silent here, exactly
203/// as a record predating the feature (`continuation: None`) does too.
204fn continuation_note(c: &crate::run::ContinuationRecord) -> String {
205    match c.outcome {
206        ContinuationOutcome::NotNeeded => String::new(),
207        ContinuationOutcome::Resumed => format!(" [resumed x{}]", c.attempts),
208        ContinuationOutcome::Exhausted => format!(" [continuation exhausted x{}]", c.attempts),
209        ContinuationOutcome::QuotaLost => " [continuation: quota]".to_owned(),
210        ContinuationOutcome::NoSession => " [no session to resume]".to_owned(),
211    }
212}
213
214/// Commands seats' own CLIs reported running, across every node — see
215/// [`crate::run::JobRecord`]. Read-only: renders whatever `run.json` already
216/// holds, does not query anything live and does not spawn an agent.
217///
218/// A CLI this crate has no adapter for (every backend but Codex, as of this
219/// writing) never appears here at all — silence is "no evidence", not "no
220/// jobs ran", which the trailing coverage line exists to say once rather
221/// than per seat.
222///
223/// There is deliberately no "running" state anywhere in this. A command a
224/// CLI never reported finishing has no way to be told apart from one that
225/// never started at all: the CLI that would report it has, by construction,
226/// already stopped talking (killed by a timeout, or a park) by the time that
227/// question matters, so no event — real or guessed at — could ever answer
228/// it. Guessing at an unconfirmed event shape to manufacture a "running"
229/// entry is exactly the fabrication this feature must not do; recording that
230/// limit instead is what the task asks for here. `magi show`'s own
231/// seat-completion state ([`active_seats`]) still answers a related but
232/// different question honestly — "has this seat's own turn answered yet" —
233/// and stays the right place to look for that.
234fn jobs_section(state: &RunState) -> String {
235    let mut s = String::new();
236    if state.jobs.is_empty() {
237        // Not silent when it would matter: a run whose roster can actually
238        // report this (Codex, today) but has not yet says so explicitly, so
239        // "no adapter for this backend" and "nothing reported yet" are never
240        // the same blank space to a reader.
241        if state
242            .config
243            .agents
244            .iter()
245            .any(|a| a.kind == crate::config::AgentKind::Codex)
246        {
247            let _ = writeln!(
248                s,
249                "\n{}",
250                dim(
251                    "background jobs: no completed command evidence yet for this run (see \
252                     active seats above for what is still mid-turn)"
253                )
254            );
255        }
256        return s;
257    }
258    let _ = writeln!(
259        s,
260        "\n{}",
261        bold("background jobs (from each seat's own CLI)")
262    );
263    let mut by_seat: std::collections::BTreeMap<(&str, &str), Vec<&crate::run::JobRecord>> =
264        std::collections::BTreeMap::new();
265    for j in &state.jobs {
266        by_seat
267            .entry((j.node.as_str(), j.seat.as_str()))
268            .or_default()
269            .push(j);
270    }
271    for ((node, seat), records) in by_seat {
272        let _ = writeln!(s, "  {node}/{seat}");
273        for j in records {
274            let status = match j.status {
275                JobStatus::Completed => green("completed"),
276                JobStatus::Failed => red("failed"),
277                JobStatus::Unknown => yellow("unknown"),
278            };
279            let _ = writeln!(
280                s,
281                "    {} {}{}{}  checked {}",
282                dim(&j.id),
283                status,
284                j.exit_code
285                    .map_or(String::new(), |c| format!(" (exit {c})")),
286                j.round.map_or(String::new(), |r| format!("  round {r}")),
287                j.checked_at
288                    .to_zoned(jiff::tz::TimeZone::system())
289                    .strftime("%Y-%m-%d %H:%M:%S")
290            );
291            let desc = first_line(&j.description);
292            if !desc.trim().is_empty() {
293                let _ = writeln!(s, "      $ {desc}");
294            }
295            let summary = first_line(&j.result_summary);
296            if !summary.trim().is_empty() {
297                let _ = writeln!(s, "      {}", dim(&summary));
298            }
299        }
300    }
301    let _ = writeln!(
302        s,
303        "  {}",
304        dim(
305            "(adapter coverage: codex only today; other backends, and a command a CLI never \
306             reported finishing, leave no entry here — that is unknown, never \"nothing ran\")"
307        )
308    );
309    s
310}
311
312/// Full report for one run.
313pub fn run(state: &RunState) -> String {
314    let mut s = String::new();
315    let _ = writeln!(
316        s,
317        "{} {}  {}",
318        bold("magi run"),
319        bold(&state.id),
320        status_word(state)
321    );
322    let _ = writeln!(
323        s,
324        "  repo    {} ({} @ {})",
325        state.repo.display(),
326        state.base_branch,
327        short(&state.base_commit)
328    );
329    let _ = writeln!(s, "  created {}", state.created_local());
330    let _ = writeln!(s, "  task    {}", first_line(&state.instruction));
331    let _ = writeln!(s, "  state   {}", state.dir().display());
332
333    let _ = writeln!(s, "\n{}", bold("candidates"));
334    for c in &state.candidates {
335        let flag = match (&c.failed, c.empty, &c.verified_noop) {
336            (Some(e), _, _) => red(&format!("failed: {e}")),
337            // Neither red (nothing failed) nor plain yellow "no change" (that
338            // reads as an unexplained loss): the candidate gave a reason a
339            // human still has to check, not a claim magi itself confirmed.
340            (None, true, Some(_)) => cyan("agent-verified no-op (unconfirmed)"),
341            (None, true, None) => yellow("no change"),
342            _ => format!("{} files, {} commits", c.files, c.commits),
343        };
344        let crown = if state.tally.as_ref().is_some_and(|t| t.winner == c.label) {
345            bold(&green("  <- winner"))
346        } else {
347            String::new()
348        };
349        let _ = writeln!(
350            s,
351            "  {}  {:<12} {:<30} {:>5}s{}",
352            bold(&c.label.to_string()),
353            c.agent,
354            flag,
355            c.duration_ms / 1000,
356            crown
357        );
358        if let Some(evidence) = &c.verified_noop {
359            let _ = writeln!(s, "      {}", dim(&first_line(evidence)));
360        } else if !c.summary.trim().is_empty() {
361            // The candidate's own account of what it did and why — the
362            // "## SUMMARY" `prompt::implement` asks for — was recorded on
363            // every run but never surfaced here, which left `magi show`
364            // silent about it even when the summary was the whole point (an
365            // implementer explaining *why* it wrote nothing, short of a
366            // verified no-op's own line above). One line, matching the
367            // house style other prose fields get in this report (see the
368            // review findings' `detail` below); the rest is in `run.json`.
369            let _ = writeln!(s, "      {}", dim(&first_line(&c.summary)));
370        }
371    }
372
373    if !state.judgements.is_empty() {
374        let _ = writeln!(s, "\n{}", bold("blind judging"));
375        for j in &state.judgements {
376            match &j.failed {
377                Some(e) => {
378                    let _ = writeln!(
379                        s,
380                        "  judge {}  {}",
381                        j.judge,
382                        red(&format!("no ranking: {e}"))
383                    );
384                }
385                None => {
386                    let _ = writeln!(
387                        s,
388                        "  judge {}  {:<12} {}  confidence {}",
389                        j.judge,
390                        j.agent,
391                        bold(&j.ranking.iter().collect::<String>()),
392                        j.confidence.map_or("-".to_owned(), |c| c.to_string())
393                    );
394                }
395            }
396        }
397    }
398
399    if let Some(t) = &state.tally {
400        if t.deliberated {
401            let _ = writeln!(s, "\n{}", bold("deliberation"));
402            for round in &state.deliberation {
403                for turn in &round.turns {
404                    let _ = writeln!(
405                        s,
406                        "  r{} judge {} -> {}",
407                        round.round,
408                        turn.judge,
409                        turn.tentative.map_or("-".to_owned(), |c| c.to_string())
410                    );
411                }
412            }
413        }
414
415        if !state.votes.is_empty() {
416            let _ = writeln!(s, "\n{}", bold("final votes (collected privately)"));
417            for v in &state.votes {
418                let _ = writeln!(
419                    s,
420                    "  judge {}  {:<12} {}{}",
421                    v.judge,
422                    v.agent,
423                    bold(&v.vote.unwrap_or('?').to_string()),
424                    if v.changed {
425                        yellow("  (changed after deliberation)")
426                    } else {
427                        String::new()
428                    }
429                );
430            }
431        }
432
433        let _ = writeln!(s, "\n{}", bold("tally"));
434        // A tally with no panel (`uncontested`) must not fall through the
435        // judges/first-choice/after-votes lines below: they are written
436        // unconditionally and every one of them reads, in the words a panel
437        // that collapsed would also produce, as a run that lost its judges
438        // rather than one that never needed them.
439        match &t.uncontested {
440            Some(reason) => {
441                let _ = writeln!(
442                    s,
443                    "  judging       {}",
444                    cyan(&format!("not needed — {reason}"))
445                );
446            }
447            None => {
448                let _ = writeln!(
449                    s,
450                    "  judges        {} present{}",
451                    if t.met_quorum {
452                        green(&format!("{}/{}", t.present, t.judges))
453                    } else {
454                        red(&format!("{}/{}", t.present, t.judges))
455                    },
456                    if t.quorum > 0 {
457                        format!(" ({quorum} required)", quorum = t.quorum)
458                    } else {
459                        String::new()
460                    }
461                );
462                if !t.met_quorum {
463                    let _ = writeln!(
464                        s,
465                        "  {}",
466                        bold(&red("BELOW QUORUM — verdict is not trustworthy"))
467                    );
468                }
469                let _ = writeln!(
470                    s,
471                    "  first choice  {}",
472                    t.first_choice
473                        .iter()
474                        .map(|(k, v)| format!("{k}:{v}"))
475                        .collect::<Vec<_>>()
476                        .join("  ")
477                );
478                let _ = writeln!(
479                    s,
480                    "  initial       {}",
481                    match (t.rankings, t.unanimous_initial) {
482                        (0, _) => red("no usable ranking"),
483                        (1, _) => yellow("one usable ranking - not a consensus"),
484                        (_, true) => green("unanimous"),
485                        (_, false) => yellow("split"),
486                    }
487                );
488                let _ = writeln!(
489                    s,
490                    "  after votes   {}  ({} judge(s) moved)",
491                    if t.unanimous_final {
492                        green("unanimous")
493                    } else {
494                        yellow("still split")
495                    },
496                    t.changed_votes
497                );
498                if let Some(tb) = &t.tie_break {
499                    let _ = writeln!(s, "  tie break     {tb}");
500                }
501            }
502        }
503        if !state.quota.is_empty() {
504            let _ = writeln!(
505                s,
506                "  rate limited  {}",
507                state
508                    .quota
509                    .iter()
510                    .map(|q| q.seat.as_str())
511                    .collect::<Vec<_>>()
512                    .join(", ")
513            );
514        }
515        let _ = writeln!(s, "  winner        {}", bold(&green(&t.winner.to_string())));
516    }
517
518    if !state.withheld.is_empty() {
519        let _ = writeln!(s, "\n{}", bold("withheld from commit"));
520        for w in &state.withheld {
521            let _ = writeln!(
522                s,
523                "  {} {}  ({} lockfile; the directory uses {})",
524                yellow("!"),
525                w.path,
526                w.manager,
527                w.kept_by
528            );
529        }
530    }
531
532    if !state.reviews.is_empty() {
533        let _ = writeln!(s, "\n{}", bold("review + verification"));
534        for r in &state.reviews {
535            let raised: usize = r.reviews.iter().map(|x| x.findings.len()).sum();
536            // A build/link failure is not a verdict on the patch (a shared
537            // `CARGO_TARGET_DIR` link race looks exactly like one), so it
538            // must not read the same as a real test failure. And a deferred
539            // round is not a passed one: `e2e.is_empty()` alone cannot tell
540            // "not configured" from "skipped on purpose" apart, which is
541            // exactly why `e2e_status` exists rather than reading `e2e`
542            // directly here.
543            let e2e = match r.e2e_status() {
544                E2eStatus::NotConfigured => dim("no e2e"),
545                E2eStatus::Deferred => yellow(&format!(
546                    "e2e deferred{}",
547                    r.e2e_defer_reason
548                        .as_deref()
549                        .map(|why| format!(" ({why})"))
550                        .unwrap_or_default()
551                )),
552                E2eStatus::Passed => green("e2e green"),
553                E2eStatus::Failed if r.e2e.iter().any(CommandOutcome::build_failed) => {
554                    yellow("e2e could not run (build/link failure)")
555                }
556                E2eStatus::Failed => red("e2e RED"),
557                // Magi's own admission it could not get a command to run —
558                // never the same yellow/red a real attempt earns, since
559                // nothing here is evidence about the patch (see
560                // `E2eStatus::ResourceBlocked`'s own doc).
561                E2eStatus::ResourceBlocked => {
562                    yellow("e2e could not run (shared build cache unavailable)")
563                }
564            };
565            let e2e = if r.verify_retried {
566                format!("{e2e}, retried once")
567            } else {
568                e2e
569            };
570            // Three distinct facts, not two: a round can be *open* (blocking
571            // findings still standing), *incomplete* (a seat never answered,
572            // so what the round says is missing input) or genuinely clean.
573            let status = if r.incomplete() {
574                yellow("incomplete")
575            } else if r.clean {
576                green("clean")
577            } else {
578                yellow("open")
579            };
580            // A missing seat must stay visible even when `warn` policy let
581            // the round gate as clean: the reader should never have to take
582            // "clean" on faith when the panel wasn't full.
583            let panel = if r.incomplete() {
584                let missing: Vec<String> = r
585                    .reviews
586                    .iter()
587                    .filter_map(|x| {
588                        x.failed
589                            .as_ref()
590                            .map(|why| format!("review-{}: {why}", x.reviewer))
591                    })
592                    .collect();
593                format!(
594                    "  {}/{} reviewers answered ({})",
595                    r.answered,
596                    r.expected,
597                    missing.join(", ")
598                )
599            } else {
600                String::new()
601            };
602            // The verdict is the one thing this loop cannot derive from
603            // `blocking`/`e2e` alone: three seats can agree there is nothing
604            // blocking and still split on whether the patch is fine to
605            // proceed as-is, which is exactly the disagreement a vote exists
606            // to surface.
607            let verdict = r.verdict.map_or(String::new(), |v| {
608                format!(
609                    ", verdict {}{}",
610                    vote_tag(v),
611                    if r.vote_split { " (panel split)" } else { "" }
612                )
613            });
614            let _ = writeln!(
615                s,
616                "  round {}  {} @ {}{}{panel}  {raised} finding(s), {} blocking, {e2e}{verdict}{}",
617                r.round,
618                status,
619                short(&r.head),
620                r.verified_head.as_ref().map_or(String::new(), |head| {
621                    format!(
622                        " (verified @ {}{})",
623                        short(head),
624                        r.verified_at.map_or(String::new(), |t| format!(
625                            " on {}",
626                            t.to_zoned(jiff::tz::TimeZone::system())
627                                .strftime("%Y-%m-%d %H:%M:%S")
628                        ))
629                    )
630                }),
631                r.blocking,
632                r.fix.as_ref().map_or(String::new(), |f| {
633                    let tree = if r.progressed {
634                        green("changed")
635                    } else {
636                        yellow("unchanged")
637                    };
638                    let cont = f
639                        .continuation
640                        .as_ref()
641                        .map_or(String::new(), continuation_note);
642                    match &f.failed {
643                        // Never the same shape as "N addressed / M rejected": the
644                        // fixer's diff may well have landed (see the `fix` node's
645                        // own event), but whether it addressed anything is
646                        // unknown, not zero.
647                        Some(reason) => format!(
648                            "  fix: {}, tree {tree}{}{cont}",
649                            yellow(&format!("adoption report lost ({reason})")),
650                            if f.committed {
651                                String::new()
652                            } else {
653                                red(" (NO COMMIT)")
654                            }
655                        ),
656                        None => format!(
657                            "  fix: {} addressed / {} rejected, tree {tree}{}{cont}",
658                            f.addressed.len(),
659                            f.rejected.len(),
660                            if f.committed {
661                                String::new()
662                            } else {
663                                red(" (NO COMMIT)")
664                            }
665                        ),
666                    }
667                })
668            );
669            // The aggregate label above (`e2e`) says the round's overall
670            // verdict; it never named the commands themselves, so a round
671            // with more than one `verify.e2e` command left no way to tell
672            // which one actually failed or was blocked without opening
673            // `run.json` by hand — the same gap `gate`'s own per-command
674            // listing above already closes for the final gate.
675            for o in &r.e2e {
676                let label = if o.resource_blocked {
677                    yellow("blocked")
678                } else if o.ok() {
679                    green("pass")
680                } else {
681                    red("FAIL")
682                };
683                let _ = writeln!(s, "    {label}  {}", o.command);
684                if !o.ok() {
685                    let _ = writeln!(s, "{}", dim(&tail(&o.output_tail, 2_000)));
686                }
687            }
688            for rec in &r.reviews {
689                if let Some(vote) = rec.vote {
690                    let _ = writeln!(s, "      review-{} vote {}", rec.reviewer, vote_tag(vote));
691                }
692                for f in &rec.findings {
693                    let adopted = r
694                        .fix
695                        .as_ref()
696                        .is_some_and(|fix| fix.addressed.contains(&f.id));
697                    let _ = writeln!(
698                        s,
699                        "      {} [{:?}] {}{}",
700                        dim(&f.id),
701                        f.severity,
702                        f.title,
703                        if adopted {
704                            green("  fixed")
705                        } else {
706                            String::new()
707                        }
708                    );
709                }
710            }
711            if let Some(fix) = &r.fix {
712                for rej in &fix.rejected {
713                    let _ = writeln!(
714                        s,
715                        "      {} {}: {}",
716                        dim(&rej.id),
717                        yellow("declined"),
718                        rej.why
719                    );
720                }
721            }
722            // Reconsideration only ever has entries when the round's initial
723            // votes split — an empty list here means the panel agreed the
724            // first time, same as an empty `deliberation` for judges.
725            if !r.reconsideration.is_empty() {
726                let _ = writeln!(s, "      {}", dim("reconsideration:"));
727                for rv in &r.reconsideration {
728                    match rv.vote {
729                        Some(v) => {
730                            let _ = writeln!(
731                                s,
732                                "        review-{} -> {}  {}",
733                                rv.reviewer,
734                                vote_tag(v),
735                                rv.reason
736                            );
737                        }
738                        None => {
739                            let _ = writeln!(
740                                s,
741                                "        review-{} -> {}",
742                                rv.reviewer,
743                                red(&format!(
744                                    "no revote ({})",
745                                    rv.failed.as_deref().unwrap_or("unknown")
746                                ))
747                            );
748                        }
749                    }
750                }
751            }
752        }
753        if state.handed_off_with_open_findings() {
754            let _ = writeln!(
755                s,
756                "\n  {}",
757                yellow(&format!(
758                    "handed off with {} finding(s) still open — gate and e2e were green; \
759                     see above for what a person should still look at",
760                    state.open_findings().len()
761                ))
762            );
763        }
764    }
765
766    if !state.operator_fixes.is_empty() {
767        let _ = writeln!(s, "\n{}", bold("operator fix(es)"));
768        for (i, req) in state.operator_fixes.iter().enumerate() {
769            let _ = writeln!(
770                s,
771                "  [{}] {} finding(s) at {}{}",
772                i + 1,
773                req.findings.len(),
774                req.requested_at
775                    .to_zoned(jiff::tz::TimeZone::system())
776                    .strftime("%Y-%m-%d %H:%M:%S"),
777                if req.stale {
778                    yellow("  stale head, --allow-stale used")
779                } else {
780                    String::new()
781                }
782            );
783            let _ = writeln!(s, "      reason: {}", req.reason);
784            for f in &req.findings {
785                let outcome = match &f.outcome {
786                    OperatorFixOutcome::Pending => yellow("pending"),
787                    OperatorFixOutcome::Addressed => green("addressed"),
788                    OperatorFixOutcome::Rejected { why } => red(&format!("rejected: {why}")),
789                    OperatorFixOutcome::Unreported => {
790                        red("unreported — no adoption report came back")
791                    }
792                };
793                let _ = writeln!(
794                    s,
795                    "      {} [{:?}] {}  {outcome}",
796                    dim(&f.id),
797                    f.severity,
798                    f.title
799                );
800            }
801            match &req.follow_up_review_run {
802                Some(id) => {
803                    let _ = writeln!(s, "      re-verified by run {id}");
804                }
805                None if req.fix.as_ref().is_some_and(|fx| fx.committed) => {
806                    let _ = writeln!(
807                        s,
808                        "      {}",
809                        red("committed, but the follow-up review could not be opened")
810                    );
811                }
812                None => {
813                    let _ = writeln!(s, "      no change committed; nothing to re-verify");
814                }
815            }
816        }
817    }
818
819    if let Some(bs) = &state.base_sync {
820        let _ = writeln!(s, "\n{}", bold("base sync"));
821        let status = if let Some(c) = &bs.conflict {
822            red(&format!("conflict: {}", first_line(c)))
823        } else if bs.behind == 0 {
824            green("in sync")
825        } else {
826            yellow(&format!("{} commit(s) behind, not yet rebased", bs.behind))
827        };
828        let _ = writeln!(
829            s,
830            "  {} @ {}  {status}{}",
831            state.base_branch,
832            short(&bs.tip),
833            if bs.attempts > 0 {
834                format!("  ({} rebase attempt(s))", bs.attempts)
835            } else {
836                String::new()
837            }
838        );
839    }
840
841    if !state.pre_gate.is_empty() {
842        let _ = writeln!(s, "\n{}", bold("pre_gate"));
843        for o in &state.pre_gate {
844            let _ = writeln!(
845                s,
846                "  {}  {}",
847                if o.ok() {
848                    green("pass")
849                } else {
850                    yellow("warn")
851                },
852                o.command
853            );
854            if !o.ok() {
855                let _ = writeln!(s, "{}", dim(&tail(&o.output_tail, 2_000)));
856            }
857        }
858        if let Some(c) = &state.pre_gate_commit {
859            let _ = writeln!(s, "  committed mechanical fixes @ {}", short(c));
860        }
861    }
862
863    // `state.gate.is_empty()` alone cannot tell "never ran" apart from "ran
864    // with nothing configured" — see `RunState::gate_status`'s own doc — so
865    // this reads the accessor rather than the raw list.
866    match state.gate_status() {
867        GateStatus::NotRun => {}
868        GateStatus::PassedWithNoCommands => {
869            let _ = writeln!(s, "\n{}", bold("gate"));
870            let _ = writeln!(s, "  {}  no gate commands configured", green("pass"));
871        }
872        GateStatus::Passed | GateStatus::Failed => {
873            let _ = writeln!(s, "\n{}", bold("gate"));
874            for o in &state.gate {
875                let _ = writeln!(
876                    s,
877                    "  {}  {}",
878                    if o.ok() { green("pass") } else { red("FAIL") },
879                    o.command
880                );
881                if !o.ok() {
882                    let _ = writeln!(s, "{}", dim(&tail(&o.output_tail, 2_000)));
883                }
884            }
885        }
886    }
887
888    if let Some(m) = &state.merge {
889        let _ = writeln!(s, "\n{}", bold("merge"));
890        if m.mode == MergeMode::None {
891            // `ok: true` here means "magi did nothing, as configured", not
892            // "landed" — a green `ok` next to a shell command reads as done,
893            // and the branch is still sitting unmerged.
894            let _ = writeln!(
895                s,
896                "  mode None  {}",
897                cyan("not landed — nothing to do by design")
898            );
899            if let Some(w) = state.winner() {
900                let _ = writeln!(
901                    s,
902                    "  branch {} still exists, unmerged into {}",
903                    w.branch, state.base_branch
904                );
905            }
906            // The squash caveat only applies to that one style: `--no-ff` and
907            // `--ff-only` never inherit a candidate's placeholder subject,
908            // since neither ever discards the pull request body `message`
909            // that `manual_merge_command` (graph.rs) already puts on the
910            // squash commit's `-m`.
911            let _ = writeln!(
912                s,
913                "  rebase onto {} before merging by hand{}",
914                state.base_branch,
915                if state.config.merge.style == MergeStyle::Squash {
916                    ", and pass an explicit commit message — a squash merge \
917                     otherwise inherits the candidate's placeholder subject"
918                } else {
919                    ""
920                }
921            );
922            let _ = writeln!(s, "  {}", m.detail.lines().next().unwrap_or(""));
923        } else {
924            let _ = writeln!(
925                s,
926                "  mode {:?}  {}\n  {}",
927                m.mode,
928                if m.ok {
929                    green("ok")
930                } else {
931                    yellow("not merged")
932                },
933                m.detail.lines().next().unwrap_or("")
934            );
935        }
936        if let Some(pr) = &state.pr
937            && !pr.red_at_merge.is_empty()
938        {
939            let _ = writeln!(
940                s,
941                "  {} {}",
942                yellow("merged with red checks:"),
943                pr.red_at_merge.join(", ")
944            );
945        }
946    }
947
948    if let Some(b) = &state.release_bump {
949        let _ = writeln!(s, "\n{}", bold("release bump"));
950        if let Some(v) = &b.version {
951            let _ = writeln!(s, "  version v{v}");
952        }
953        if let Some(url) = &b.pr_url {
954            let _ = writeln!(s, "  pr {url}");
955        }
956        let _ = writeln!(
957            s,
958            "  automerge {}",
959            if b.automerge_enabled {
960                green("enabled")
961            } else if b.merged_directly {
962                green("not needed (CI was already green; merged directly)")
963            } else if b.problem.is_some() {
964                bold(&red("FAILED"))
965            } else {
966                dim("not enabled")
967            }
968        );
969        if let Some(p) = &b.problem {
970            let _ = writeln!(s, "  {}", p.lines().next().unwrap_or(""));
971        }
972        if let Some(a) = &b.action_required {
973            let _ = writeln!(s, "  {} {a}", bold(&yellow("action required:")));
974        }
975    }
976
977    if !state.leaks.is_empty() {
978        let _ = writeln!(s, "\n{}", bold(&yellow("blindness warnings")));
979        for l in &state.leaks {
980            let _ = writeln!(s, "  {} x{} in {}", l.token, l.count, l.site);
981        }
982    }
983
984    if let Some(w) = state.winner()
985        && !w.folded
986    {
987        let _ = writeln!(
988            s,
989            "\n{} {}\n  branch {}",
990            bold("winner worktree"),
991            w.worktree.display(),
992            w.branch
993        );
994    }
995    s.push_str(&jobs_section(state));
996    s
997}
998
999/// The seats currently mid-answer, for `magi show` and the raw report route.
1000///
1001/// Separate from [`run`] on purpose: [`run`] is printed straight after `magi
1002/// run` / `magi review`'s own `execute()`, and by then this process has
1003/// nothing left in flight to report; the TUI does not track daemon liveness
1004/// either. Only a caller reading someone *else's* run — `magi show <id>`, or
1005/// the web UI's raw-report route — needs this, and both already know how to
1006/// ask whether a daemon is currently driving it.
1007///
1008/// `live` is [`RunState::liveness`]: whether a daemon's heartbeat currently
1009/// names this run, or — absent that claim — whether `driver_pid` still
1010/// answers alive. An [`ActiveSeat`](crate::run::ActiveSeat) left behind by a
1011/// killed process is not lied about as running just because nobody has
1012/// cleared it from disk yet — see that type's own docs for why an entry
1013/// alone is not proof of anything.
1014pub fn active_seats(state: &RunState, live: Liveness) -> String {
1015    if state.active.is_empty() {
1016        return String::new();
1017    }
1018    let mut s = String::new();
1019    let _ = writeln!(s, "\n{}", bold("running now"));
1020    let now = jiff::Timestamp::now();
1021    match live {
1022        Liveness::Live => {}
1023        Liveness::Dead => {
1024            let _ = writeln!(
1025                s,
1026                "  {}",
1027                yellow(
1028                    "no live daemon claims this run right now — likely left behind by a killed process"
1029                )
1030            );
1031        }
1032        Liveness::Unknown => {
1033            // `active_all_overrun` is never treated as proof of death here —
1034            // only ever mentioned alongside "could not confirm", since a
1035            // seat legitimately overrunning its budget while the process
1036            // driving it tears the attempt down looks identical on disk (see
1037            // `RunState::active_all_overrun`'s own doc).
1038            let overrun = if state.active_all_overrun(now) {
1039                " — every active seat has already run past its own timeout budget"
1040            } else {
1041                ""
1042            };
1043            let _ = writeln!(
1044                s,
1045                "  {}",
1046                yellow(&format!(
1047                    "whether a process is still driving this run could not be confirmed{overrun}"
1048                ))
1049            );
1050        }
1051    }
1052    for (seat, a) in state.seats_active() {
1053        let retry = if a.attempt > 0 {
1054            format!(" retry {}", a.attempt)
1055        } else {
1056            String::new()
1057        };
1058        let _ = writeln!(
1059            s,
1060            "  {:<12} {:<12}{retry}  {}s elapsed, {}s left of {}s",
1061            seat,
1062            a.node,
1063            a.elapsed_secs(now),
1064            a.remaining_secs(now),
1065            a.timeout_secs
1066        );
1067    }
1068    for (task, a) in state.tasks_active() {
1069        let retry = if a.attempt > 0 {
1070            format!(" retry {}", a.attempt)
1071        } else {
1072            String::new()
1073        };
1074        let progress = match (a.index, a.total) {
1075            (Some(i), Some(t)) => format!(" ({i}/{t})"),
1076            _ => String::new(),
1077        };
1078        let _ = writeln!(
1079            s,
1080            "  {:<12} {:<12}{retry}{progress}  {}s elapsed, {}s left of {}s",
1081            task,
1082            a.node,
1083            a.elapsed_secs(now),
1084            a.remaining_secs(now),
1085            a.timeout_secs
1086        );
1087        if let Some(command) = &a.command {
1088            let _ = writeln!(s, "               {command}");
1089        }
1090    }
1091    s
1092}
1093
1094/// Render a whole number of seconds as `1h02m`, `3m05s` or `42s`.
1095fn fmt_secs(secs: i64) -> String {
1096    let secs = secs.max(0);
1097    let h = secs / 3600;
1098    let m = (secs % 3600) / 60;
1099    let s = secs % 60;
1100    if h > 0 {
1101        format!("{h}h{m:02}m")
1102    } else if m > 0 {
1103        format!("{m}m{s:02}s")
1104    } else {
1105        format!("{s}s")
1106    }
1107}
1108
1109/// A fixed-width text bar, `value` proportional to `max` out of `width` cells.
1110///
1111/// Any positive value draws at least one cell, so a short-but-nonzero
1112/// duration is never mistaken for an unmeasured one.
1113fn bar(value: f64, max: f64, width: usize) -> String {
1114    if max <= 0.0 || value <= 0.0 {
1115        return String::new();
1116    }
1117    let cells = ((value / max) * width as f64)
1118        .round()
1119        .clamp(1.0, width as f64) as usize;
1120    "█".repeat(cells)
1121}
1122
1123/// Per-repository summary table: repo name, run count, completion rate.
1124///
1125/// `main.rs`'s `Command::Stats` is what decides *whether* to print this —
1126/// only ahead of the plain (no `--repo`) report, and only when `repos.len() >
1127/// 1` — this function only renders whatever it is handed.
1128pub fn repo_summary(repos: &[RepoStats]) -> String {
1129    let mut s = String::new();
1130    let _ = writeln!(s, "{}", bold("repos"));
1131
1132    // Two different checkouts can share a leaf directory name (`magi` under
1133    // two different roots); disambiguate only those with their parent
1134    // directory rather than paying the extra noise on every row.
1135    let mut name_counts: std::collections::HashMap<&str, usize> = std::collections::HashMap::new();
1136    for r in repos {
1137        *name_counts.entry(r.name.as_str()).or_insert(0) += 1;
1138    }
1139
1140    for r in repos {
1141        let label = if name_counts.get(r.name.as_str()).copied().unwrap_or(0) > 1 {
1142            match r.repo.parent().and_then(|p| p.file_name()) {
1143                Some(parent) => format!("{} ({})", r.name, parent.to_string_lossy()),
1144                None => r.name.clone(),
1145            }
1146        } else {
1147            r.name.clone()
1148        };
1149        let _ = writeln!(
1150            s,
1151            "  {}  {} runs  {:.0}% completion",
1152            label,
1153            r.stats.totals.runs,
1154            r.stats.totals.completion_rate()
1155        );
1156    }
1157    s
1158}
1159
1160/// Aggregate tables, for `magi stats`.
1161pub fn stats(stats: &Stats) -> String {
1162    let t = &stats.totals;
1163    let mut s = String::new();
1164    let _ = writeln!(s, "{}", bold("runs"));
1165    let _ = writeln!(
1166        s,
1167        "  {} total - {} merged, {} ready, {} blocked, {} failed ({:.0}% completion)",
1168        t.runs,
1169        t.merged,
1170        t.ready,
1171        t.blocked,
1172        t.failed,
1173        t.completion_rate()
1174    );
1175    if t.tallied > 0 {
1176        let _ = writeln!(
1177            s,
1178            "  {} tallied - {} split on first choice ({:.0}%), {} deliberated, \
1179             {} of those changed a mind, {} converged to unanimous",
1180            t.tallied,
1181            t.split,
1182            t.split_rate(),
1183            t.deliberated,
1184            t.minds_changed,
1185            t.converged
1186        );
1187    }
1188
1189    if !stats.agents.is_empty() {
1190        let _ = writeln!(
1191            s,
1192            "\n{}",
1193            bold("implementation (relative, on this workload)")
1194        );
1195        let _ = writeln!(
1196            s,
1197            "  {:<14}{:>6}{:>8}{:>8}{:>8}",
1198            "agent", "won", "entered", "rate", "empty"
1199        );
1200        for a in &stats.agents {
1201            let _ = writeln!(
1202                s,
1203                "  {:<14}{:>6}{:>8}{:>7.0}%{:>8}",
1204                a.agent,
1205                a.wins,
1206                a.entered,
1207                a.win_rate(),
1208                a.empty
1209            );
1210        }
1211    }
1212
1213    if !stats.reviewers.is_empty() {
1214        let _ = writeln!(s, "\n{}", bold("review"));
1215        let _ = writeln!(
1216            s,
1217            "  {:<14}{:>8}{:>10}{:>11}{:>9}{:>9}{:>9}",
1218            "reviewer", "rounds", "submitted", "adopted/rd", "precision", "unique", "timeout"
1219        );
1220        for r in &stats.reviewers {
1221            let _ = writeln!(
1222                s,
1223                "  {:<14}{:>8}{:>10}{:>11.2}{:>8.0}%{:>8.0}%{:>8.0}%",
1224                r.agent,
1225                r.rounds,
1226                r.submitted,
1227                r.adopted_per_round(),
1228                r.precision(),
1229                r.unique_rate(),
1230                r.timeout_rate()
1231            );
1232        }
1233    }
1234
1235    if !stats.advisors.is_empty() {
1236        let _ = writeln!(
1237            s,
1238            "\n{} {}",
1239            bold("design deliberation"),
1240            dim(
1241                "(approximate: reflection is read off word overlap with the synthesis brief, not a precise attribution)"
1242            )
1243        );
1244        let _ = writeln!(
1245            s,
1246            "  {:<14}{:>7}{:>10}{:>8}{:>8}{:>9}{:>10}",
1247            "advisor", "seats", "proposed", "strong", "faint", "absent", "reflect%"
1248        );
1249        for a in &stats.advisors {
1250            let _ = writeln!(
1251                s,
1252                "  {:<14}{:>7}{:>10}{:>8}{:>8}{:>9}{:>9.0}%",
1253                a.agent,
1254                a.seated,
1255                a.proposed,
1256                a.strong,
1257                a.faint,
1258                a.absent,
1259                a.reflection_rate()
1260            );
1261        }
1262    }
1263
1264    if stats.release_bumps.merged > 0 {
1265        let b = &stats.release_bumps;
1266        let _ = writeln!(s, "\n{}", bold("release bumps"));
1267        let _ = writeln!(
1268            s,
1269            "  {} of {} merged run(s) recorded a bump ({:.0}%)",
1270            b.recorded,
1271            b.merged,
1272            b.coverage_rate()
1273        );
1274        let _ = writeln!(
1275            s,
1276            "  {} release PR(s) opened, {} automerge enabled ({:.0}%), {} merged directly",
1277            b.pr_opened,
1278            b.automerge_enabled,
1279            b.automerge_rate(),
1280            b.merged_directly
1281        );
1282        let _ = writeln!(
1283            s,
1284            "  {} clean, {} needed a human ({:.0}%)",
1285            b.clean(),
1286            b.needs_attention,
1287            b.attention_rate()
1288        );
1289    }
1290
1291    if stats.e2e.rounds > 0 || stats.e2e.deferred > 0 {
1292        let _ = writeln!(s, "\n{}", bold("verification"));
1293        let _ = writeln!(
1294            s,
1295            "  {} rounds ran e2e, {} failed, {} of those with a clean static \
1296             review ({:.0}% sole detections), {} round(s) deferred it to the fixer",
1297            stats.e2e.rounds,
1298            stats.e2e.failures,
1299            stats.e2e.sole_detections,
1300            stats.e2e.sole_rate(),
1301            stats.e2e.deferred
1302        );
1303    }
1304
1305    if !stats.nodes.is_empty() {
1306        let _ = writeln!(
1307            s,
1308            "\n{}",
1309            bold("node durations (first to last event, per run)")
1310        );
1311        let max_mean = stats
1312            .nodes
1313            .iter()
1314            .map(|n| n.mean_secs())
1315            .fold(0.0_f64, f64::max);
1316        for n in &stats.nodes {
1317            let unmeasured = if n.single > 0 {
1318                format!("  {}", dim(&format!("{} unmeasured", n.single)))
1319            } else {
1320                String::new()
1321            };
1322            let _ = writeln!(
1323                s,
1324                "  {:<14}{:>6} runs{:>8} mean{:>8} max  {}{unmeasured}",
1325                n.node,
1326                n.runs,
1327                fmt_secs(n.mean_secs().round() as i64),
1328                fmt_secs(n.max_secs),
1329                bar(n.mean_secs(), max_mean, 20)
1330            );
1331        }
1332    }
1333    s
1334}
1335
1336#[cfg(test)]
1337mod tests {
1338    use super::*;
1339    use crate::config::Config;
1340    use crate::run::{
1341        Candidate, CommandOutcome, FixRecord, MergeOutcome, ReviewRecord, ReviewRound, RunState,
1342        Tally,
1343    };
1344    use std::collections::BTreeMap;
1345    use std::path::PathBuf;
1346    use std::sync::{Mutex, MutexGuard};
1347
1348    /// `COLOR` is process-global, so these tests cannot run concurrently.
1349    static SERIAL: Mutex<()> = Mutex::new(());
1350
1351    fn plain() -> MutexGuard<'static, ()> {
1352        let guard = SERIAL.lock().unwrap_or_else(|e| e.into_inner());
1353        set_color(false);
1354        guard
1355    }
1356
1357    fn state() -> RunState {
1358        // `run()` prints `state.dir()`, which reads the process-global home;
1359        // pinning it here keeps this test off the operator's real one. The
1360        // directory itself is never read, only its path printed, so nothing
1361        // needs to create or clean it up.
1362        crate::run::set_home(std::env::temp_dir().join("magi-report-test-home"));
1363        let mut s = RunState::new(
1364            PathBuf::from("/repo"),
1365            "main".to_owned(),
1366            "abcdef1234".to_owned(),
1367            "add retries to the uploader".to_owned(),
1368            Config::default(),
1369        );
1370        s.candidates = vec![Candidate {
1371            index: 0,
1372            label: 'A',
1373            agent: "opus".to_owned(),
1374            branch: "magi/x/A".to_owned(),
1375            worktree: PathBuf::from("/wt/A"),
1376            summary: String::new(),
1377            stat: String::new(),
1378            files: 3,
1379            commits: 2,
1380            empty: false,
1381            failed: None,
1382            verified_noop: None,
1383            duration_ms: 42_000,
1384            folded: false,
1385        }];
1386        s.tally = Some(Tally {
1387            first_choice: BTreeMap::from([('A', 3)]),
1388            borda: BTreeMap::new(),
1389            winner: 'A',
1390            rankings: 3,
1391            unanimous_initial: true,
1392            deliberated: false,
1393            changed_votes: 0,
1394            unanimous_final: true,
1395            tie_break: None,
1396            judges: 3,
1397            present: 3,
1398            quorum: 2,
1399            met_quorum: true,
1400            uncontested: None,
1401        });
1402        s
1403    }
1404
1405    #[test]
1406    fn run_report_names_the_winner_and_its_author() {
1407        let _guard = plain();
1408        let text = run(&state());
1409        assert!(text.contains("<- winner"), "{text}");
1410        assert!(text.contains("opus"));
1411        assert!(text.contains("3 files, 2 commits"));
1412        assert!(text.contains("winner        A"));
1413        assert!(!text.contains('\x1b'), "colour leaked into a plain render");
1414    }
1415
1416    #[test]
1417    fn a_candidates_own_summary_is_surfaced_not_only_kept_in_run_json() {
1418        // Recorded on every run (`prompt::implement`'s `## SUMMARY`), but
1419        // `run()` used to never print it at all — silent even when the
1420        // summary was the one place an implementer explained itself (e.g.
1421        // an investigation task's findings), and readable only by opening
1422        // `run.json` by hand.
1423        let _guard = plain();
1424        let mut s = state();
1425        s.candidates[0].summary =
1426            "investigated 6c5e/8df3: both already merged, see talk 07fe.\nmore detail below."
1427                .to_owned();
1428        let text = run(&s);
1429        assert!(
1430            text.contains("investigated 6c5e/8df3: both already merged, see talk 07fe."),
1431            "{text}"
1432        );
1433    }
1434
1435    #[test]
1436    fn a_verified_noop_run_does_not_read_as_a_failure() {
1437        // Same spirit as `a_mode_none_merge_does_not_read_as_landed`: a run
1438        // that settled without landing anything must not be misreadable as
1439        // the ordinary failure it is not.
1440        let _guard = plain();
1441        let mut s = state();
1442        s.status = RunStatus::VerifiedNoop;
1443        s.tally = None;
1444        s.candidates = vec![Candidate {
1445            index: 0,
1446            label: 'A',
1447            agent: "opus".to_owned(),
1448            branch: "magi/x/A".to_owned(),
1449            worktree: PathBuf::from("/wt/A"),
1450            summary: String::new(),
1451            stat: String::new(),
1452            files: 0,
1453            commits: 0,
1454            empty: true,
1455            failed: None,
1456            verified_noop: Some("already fixed by b32cfc4, which is on main".to_owned()),
1457            duration_ms: 9_000,
1458            folded: false,
1459        }];
1460        let text = run(&s);
1461        assert!(
1462            text.contains("agent-verified no-op"),
1463            "the status and the candidate flag must both say so: {text}"
1464        );
1465        assert!(
1466            text.contains("already fixed by b32cfc4"),
1467            "the evidence itself must be readable, not just the verdict: {text}"
1468        );
1469        assert!(
1470            !text.to_lowercase().contains("failed"),
1471            "a verified no-op must never read as the failure it is not: {text}"
1472        );
1473    }
1474
1475    #[test]
1476    fn colour_is_emitted_only_when_enabled() {
1477        let _guard = plain();
1478        set_color(true);
1479        let coloured = run(&state());
1480        set_color(false);
1481        let plain = run(&state());
1482        assert!(coloured.contains('\x1b'));
1483        assert!(!plain.contains('\x1b'));
1484        assert!(coloured.len() > plain.len());
1485    }
1486
1487    #[test]
1488    fn list_line_is_single_line() {
1489        let _guard = plain();
1490        let l = line(&state());
1491        assert_eq!(l.lines().count(), 1);
1492        assert!(l.contains("add retries"));
1493        assert!(l.contains("win A (opus)"));
1494    }
1495
1496    #[test]
1497    fn an_uncontested_run_does_not_read_as_a_collapsed_panel() {
1498        let _guard = plain();
1499        let mut s = state();
1500        s.tally = Some(Tally {
1501            first_choice: BTreeMap::from([('A', 0)]),
1502            borda: BTreeMap::new(),
1503            winner: 'A',
1504            rankings: 0,
1505            unanimous_initial: false,
1506            deliberated: false,
1507            changed_votes: 0,
1508            unanimous_final: false,
1509            tie_break: None,
1510            judges: 0,
1511            present: 0,
1512            quorum: 0,
1513            met_quorum: true,
1514            uncontested: Some(
1515                "only candidate A produced a usable change; no panel was asked".to_owned(),
1516            ),
1517        });
1518        let text = run(&s);
1519        assert!(
1520            !text.contains("0/3"),
1521            "no panel sat, so the judges line must not read as one that collapsed: {text}"
1522        );
1523        assert!(!text.contains("no usable ranking"), "{text}");
1524        assert!(!text.contains("still split"), "{text}");
1525        assert!(!text.contains("BELOW QUORUM"), "{text}");
1526        assert!(
1527            text.contains("not needed"),
1528            "the report must say judging was skipped, not silent: {text}"
1529        );
1530        assert!(text.contains("winner        A"));
1531    }
1532
1533    #[test]
1534    fn a_below_quorum_run_still_reads_as_a_collapsed_panel() {
1535        let _guard = plain();
1536        let mut s = state();
1537        s.tally = Some(Tally {
1538            first_choice: BTreeMap::from([('A', 1), ('B', 0)]),
1539            borda: BTreeMap::new(),
1540            winner: 'A',
1541            rankings: 1,
1542            unanimous_initial: false,
1543            deliberated: false,
1544            changed_votes: 0,
1545            unanimous_final: false,
1546            tie_break: None,
1547            judges: 3,
1548            present: 1,
1549            quorum: 2,
1550            met_quorum: false,
1551            uncontested: None,
1552        });
1553        let text = run(&s);
1554        assert!(text.contains("1/3"), "{text}");
1555        assert!(
1556            text.contains("BELOW QUORUM"),
1557            "a real collapse must still be flagged: {text}"
1558        );
1559        assert!(
1560            !text.contains("not needed"),
1561            "a collapsed panel must not be described as one that was never asked: {text}"
1562        );
1563    }
1564
1565    #[test]
1566    fn a_mode_none_merge_does_not_read_as_landed() {
1567        let _guard = plain();
1568        let mut s = state();
1569        s.merge = Some(MergeOutcome {
1570            mode: crate::config::MergeMode::None,
1571            ok: true,
1572            detail: "git -C /repo merge --no-ff magi/x/A".to_owned(),
1573        });
1574        let text = run(&s);
1575        assert!(
1576            !text.contains("  ok"),
1577            "mode none must not be shown as a landed merge: {text}"
1578        );
1579        assert!(text.contains("not landed"), "{text}");
1580        assert!(
1581            text.contains("branch magi/x/A"),
1582            "the report must say what's left behind: {text}"
1583        );
1584        assert!(
1585            text.contains("rebase"),
1586            "the report must point at the hand-landing steps: {text}"
1587        );
1588        assert!(
1589            !text.contains("placeholder subject"),
1590            "the default merge style is `merge`, which never inherits a \
1591             placeholder subject, so the squash caveat must not appear: {text}"
1592        );
1593    }
1594
1595    #[test]
1596    fn a_mode_none_squash_merge_warns_about_the_placeholder_subject() {
1597        let _guard = plain();
1598        let mut s = state();
1599        s.config.merge.style = MergeStyle::Squash;
1600        s.merge = Some(MergeOutcome {
1601            mode: crate::config::MergeMode::None,
1602            ok: true,
1603            detail: "git -C /repo merge --squash magi/x/A && git -C /repo commit -m \"add \
1604                      retries\""
1605                .to_owned(),
1606        });
1607        let text = run(&s);
1608        assert!(
1609            text.contains("placeholder subject"),
1610            "a squash-style manual merge must warn about the missing message: {text}"
1611        );
1612        assert!(text.contains("--squash"), "{text}");
1613    }
1614
1615    #[test]
1616    fn a_ready_run_left_by_merge_mode_none_does_not_read_as_a_plain_ready() {
1617        let _guard = plain();
1618        let mut s = state();
1619        s.status = RunStatus::Ready;
1620        s.merge = Some(MergeOutcome {
1621            mode: crate::config::MergeMode::None,
1622            ok: true,
1623            detail: "git -C /repo merge --no-ff magi/x/A".to_owned(),
1624        });
1625
1626        let list = line(&s);
1627        assert!(
1628            !list.contains(" ready "),
1629            "a mode-none run must not read as a plain ready in `magi list`: {list}"
1630        );
1631        assert!(list.contains("no-op by design"), "{list}");
1632
1633        let full = run(&s);
1634        assert!(
1635            !full.contains("magi run") || !full.lines().next().unwrap().contains(" ready"),
1636            "the header line of `magi show` must not say plain ready either: {full}"
1637        );
1638        assert!(full.contains("no-op by design"), "{full}");
1639    }
1640
1641    #[test]
1642    fn an_ordinary_ready_run_still_reads_as_ready() {
1643        let _guard = plain();
1644        let mut s = state();
1645        s.status = RunStatus::Ready;
1646        // A PR closed without merging also ends at `Ready` (see `land.rs`),
1647        // and unlike the honest mode-none no-op it must keep reading as a
1648        // plain `ready` — the label exists to flag design, not every non-merge.
1649        s.merge = Some(MergeOutcome {
1650            mode: crate::config::MergeMode::Pr,
1651            ok: false,
1652            detail: "https://example.com/pr/1 was closed without merging".to_owned(),
1653        });
1654
1655        let list = line(&s);
1656        assert!(list.contains("ready"), "{list}");
1657        assert!(!list.contains("no-op by design"), "{list}");
1658    }
1659
1660    #[test]
1661    fn the_list_line_does_not_flag_an_uncontested_run_as_short_judges() {
1662        let _guard = plain();
1663        let mut s = state();
1664        s.tally = Some(Tally {
1665            first_choice: BTreeMap::from([('A', 0)]),
1666            borda: BTreeMap::new(),
1667            winner: 'A',
1668            rankings: 0,
1669            unanimous_initial: false,
1670            deliberated: false,
1671            changed_votes: 0,
1672            unanimous_final: false,
1673            tie_break: None,
1674            judges: 0,
1675            present: 0,
1676            quorum: 0,
1677            met_quorum: true,
1678            uncontested: Some("only candidate A produced a usable change".to_owned()),
1679        });
1680        let l = line(&s);
1681        assert!(
1682            !l.contains("judges") && !l.contains("quorum"),
1683            "an uncontested run must not carry the same badge a short panel gets: {l}"
1684        );
1685    }
1686
1687    #[test]
1688    fn long_instructions_are_elided() {
1689        let _guard = plain();
1690        let mut s = state();
1691        s.instruction = "x".repeat(200);
1692        assert!(line(&s).contains('…'));
1693    }
1694
1695    #[test]
1696    fn a_lost_fix_report_reads_differently_from_zero_adoption() {
1697        let _guard = plain();
1698        let mut lost = state();
1699        lost.reviews = vec![ReviewRound {
1700            round: 1,
1701            head: "abc1234".to_owned(),
1702            verified_head: None,
1703            verified_at: None,
1704            reviews: Vec::new(),
1705            e2e: Vec::new(),
1706            verify_retried: false,
1707            e2e_deferred: false,
1708            e2e_defer_reason: None,
1709            fix: Some(FixRecord {
1710                agent: "opus".to_owned(),
1711                addressed: Vec::new(),
1712                rejected: Vec::new(),
1713                notes: String::new(),
1714                committed: true,
1715                failed: Some("timed out".to_owned()),
1716                duration_ms: 0,
1717                continuation: None,
1718            }),
1719            blocking: 3,
1720            answered: 0,
1721            expected: 0,
1722            clean: false,
1723            progressed: false,
1724            vote_split: false,
1725            reconsideration: Vec::new(),
1726            verdict: None,
1727        }];
1728        let text = run(&lost);
1729        assert!(text.contains("adoption report lost (timed out)"), "{text}");
1730        assert!(
1731            !text.contains("0 addressed"),
1732            "a lost report must never read as `0 addressed`: {text}"
1733        );
1734
1735        let mut rejected_all = state();
1736        rejected_all.reviews = vec![ReviewRound {
1737            round: 1,
1738            head: "abc1234".to_owned(),
1739            verified_head: None,
1740            verified_at: None,
1741            reviews: Vec::new(),
1742            e2e: Vec::new(),
1743            verify_retried: false,
1744            e2e_deferred: false,
1745            e2e_defer_reason: None,
1746            fix: Some(FixRecord {
1747                agent: "opus".to_owned(),
1748                addressed: Vec::new(),
1749                rejected: Vec::new(),
1750                notes: String::new(),
1751                committed: true,
1752                failed: None,
1753                duration_ms: 0,
1754                continuation: None,
1755            }),
1756            blocking: 3,
1757            answered: 0,
1758            expected: 0,
1759            clean: false,
1760            progressed: false,
1761            vote_split: false,
1762            reconsideration: Vec::new(),
1763            verdict: None,
1764        }];
1765        let text2 = run(&rejected_all);
1766        assert!(
1767            text2.contains("0 addressed / 0 rejected"),
1768            "a round the fixer actually reported on keeps the count: {text2}"
1769        );
1770    }
1771
1772    #[test]
1773    fn a_split_round_shows_every_seat_vote_and_the_reconsideration() {
1774        use crate::run::ReviewRevoteRecord;
1775        use crate::verdict::ReviewVote;
1776
1777        let _guard = plain();
1778        let mut s = state();
1779        s.reviews = vec![ReviewRound {
1780            round: 1,
1781            head: "abc1234".to_owned(),
1782            verified_head: None,
1783            verified_at: None,
1784            reviews: vec![
1785                ReviewRecord {
1786                    attempts: 0,
1787                    reviewer: 1,
1788                    agent: "alpha".to_owned(),
1789                    summary: String::new(),
1790                    findings: Vec::new(),
1791                    vote: Some(ReviewVote::Approve),
1792                    failed: None,
1793                    duration_ms: 0,
1794                },
1795                ReviewRecord {
1796                    attempts: 0,
1797                    reviewer: 2,
1798                    agent: "beta".to_owned(),
1799                    summary: String::new(),
1800                    findings: Vec::new(),
1801                    vote: Some(ReviewVote::Reject),
1802                    failed: None,
1803                    duration_ms: 0,
1804                },
1805            ],
1806            e2e: Vec::new(),
1807            verify_retried: false,
1808            e2e_deferred: false,
1809            e2e_defer_reason: None,
1810            fix: None,
1811            blocking: 0,
1812            answered: 2,
1813            expected: 2,
1814            clean: false,
1815            progressed: false,
1816            vote_split: true,
1817            reconsideration: vec![ReviewRevoteRecord {
1818                reviewer: 2,
1819                agent: "beta".to_owned(),
1820                vote: Some(ReviewVote::ApproveWithFindings),
1821                reason: "the other seat's read holds up".to_owned(),
1822                failed: None,
1823            }],
1824            verdict: Some(ReviewVote::ApproveWithFindings),
1825        }];
1826        let text = run(&s);
1827        assert!(text.contains("review-1 vote"), "{text}");
1828        assert!(text.contains("review-2 vote"), "{text}");
1829        assert!(text.contains("panel split"), "{text}");
1830        assert!(text.contains("reconsideration"), "{text}");
1831        assert!(text.contains("the other seat's read holds up"), "{text}");
1832    }
1833
1834    #[test]
1835    fn an_incomplete_panel_and_a_lost_fix_report_both_stay_on_the_round_line() {
1836        // Two independent facts share this one line, and each arrived from a
1837        // different change: a seat that never answered, and a fixer whose
1838        // adoption report was lost. Rendering either must not shadow the
1839        // other, and neither may collapse into the plain `clean`/`open`
1840        // pair the line used to carry.
1841        let _guard = plain();
1842        let mut s = state();
1843        s.reviews = vec![ReviewRound {
1844            round: 1,
1845            head: "abc1234".to_owned(),
1846            verified_head: None,
1847            verified_at: None,
1848            reviews: vec![
1849                ReviewRecord {
1850                    attempts: 0,
1851                    reviewer: 1,
1852                    agent: "alpha".to_owned(),
1853                    summary: String::new(),
1854                    findings: Vec::new(),
1855                    vote: None,
1856                    failed: None,
1857                    duration_ms: 0,
1858                },
1859                ReviewRecord {
1860                    attempts: 0,
1861                    reviewer: 2,
1862                    agent: "beta".to_owned(),
1863                    summary: String::new(),
1864                    findings: Vec::new(),
1865                    vote: None,
1866                    failed: Some("agent timed out".to_owned()),
1867                    duration_ms: 0,
1868                },
1869            ],
1870            e2e: Vec::new(),
1871            verify_retried: false,
1872            e2e_deferred: false,
1873            e2e_defer_reason: None,
1874            fix: Some(FixRecord {
1875                agent: "opus".to_owned(),
1876                addressed: Vec::new(),
1877                rejected: Vec::new(),
1878                notes: String::new(),
1879                committed: true,
1880                failed: Some("timed out".to_owned()),
1881                duration_ms: 0,
1882                continuation: None,
1883            }),
1884            blocking: 0,
1885            answered: 1,
1886            expected: 2,
1887            clean: false,
1888            progressed: true,
1889            vote_split: false,
1890            reconsideration: Vec::new(),
1891            verdict: None,
1892        }];
1893        let text = run(&s);
1894        assert!(text.contains("incomplete"), "{text}");
1895        assert!(text.contains("1/2 reviewers answered"), "{text}");
1896        assert!(text.contains("review-2: agent timed out"), "{text}");
1897        assert!(text.contains("adoption report lost (timed out)"), "{text}");
1898        assert!(
1899            !text.contains("clean"),
1900            "a round missing half its panel must never render as clean: {text}"
1901        );
1902    }
1903
1904    #[test]
1905    fn a_build_failure_is_not_reported_as_a_test_failure() {
1906        let _guard = plain();
1907        let mut s = state();
1908        s.reviews = vec![ReviewRound {
1909            round: 1,
1910            head: "abc1234".to_owned(),
1911            verified_head: None,
1912            verified_at: None,
1913            reviews: Vec::new(),
1914            e2e: vec![CommandOutcome {
1915                command: "cargo test".to_owned(),
1916                code: Some(1),
1917                output_tail: "LINK : fatal error LNK1104: cannot open file".to_owned(),
1918                duration_ms: 100,
1919                resource_blocked: false,
1920            }],
1921            verify_retried: true,
1922            e2e_deferred: false,
1923            e2e_defer_reason: None,
1924            fix: None,
1925            blocking: 0,
1926            answered: 0,
1927            expected: 0,
1928            clean: false,
1929            progressed: false,
1930            vote_split: false,
1931            reconsideration: Vec::new(),
1932            verdict: None,
1933        }];
1934        let text = run(&s);
1935        assert!(text.contains("could not run"), "{text}");
1936        assert!(text.contains("retried once"), "{text}");
1937        assert!(!text.contains("e2e RED"), "{text}");
1938    }
1939
1940    #[test]
1941    fn a_resource_blocked_e2e_never_reads_as_red_or_as_a_build_failure() {
1942        let _guard = plain();
1943        let mut s = state();
1944        s.reviews = vec![ReviewRound {
1945            round: 1,
1946            head: "abc1234".to_owned(),
1947            verified_head: None,
1948            verified_at: None,
1949            reviews: Vec::new(),
1950            e2e: vec![CommandOutcome {
1951                command: "(waiting for the shared build cache)".to_owned(),
1952                code: None,
1953                output_tail: "held by run x node e2e seat e2e".to_owned(),
1954                duration_ms: 100,
1955                resource_blocked: true,
1956            }],
1957            verify_retried: false,
1958            e2e_deferred: false,
1959            e2e_defer_reason: None,
1960            fix: None,
1961            blocking: 0,
1962            answered: 0,
1963            expected: 0,
1964            clean: false,
1965            progressed: false,
1966            vote_split: false,
1967            reconsideration: Vec::new(),
1968            verdict: None,
1969        }];
1970        let text = run(&s);
1971        assert!(text.contains("shared build cache unavailable"), "{text}");
1972        assert!(!text.contains("e2e RED"), "{text}");
1973        assert!(!text.contains("build/link failure"), "{text}");
1974    }
1975
1976    #[test]
1977    fn a_round_with_more_than_one_e2e_command_names_each_one() {
1978        // The aggregate `e2e RED` label says the round's overall verdict,
1979        // never which of several `verify.e2e` commands actually failed —
1980        // `magi show` must list each command by name, the same way it
1981        // already does for `gate`.
1982        let _guard = plain();
1983        let mut s = state();
1984        s.reviews = vec![ReviewRound {
1985            round: 1,
1986            head: "abc1234".to_owned(),
1987            verified_head: Some("abc1234".to_owned()),
1988            verified_at: Some(jiff::Timestamp::now()),
1989            reviews: Vec::new(),
1990            e2e: vec![
1991                CommandOutcome {
1992                    command: "cargo test --locked --all-targets".to_owned(),
1993                    code: Some(0),
1994                    output_tail: String::new(),
1995                    duration_ms: 0,
1996                    resource_blocked: false,
1997                },
1998                CommandOutcome {
1999                    command: "cargo make check".to_owned(),
2000                    code: Some(1),
2001                    output_tail: "clippy: unused import".to_owned(),
2002                    duration_ms: 0,
2003                    resource_blocked: false,
2004                },
2005            ],
2006            verify_retried: false,
2007            e2e_deferred: false,
2008            e2e_defer_reason: None,
2009            fix: None,
2010            blocking: 0,
2011            answered: 0,
2012            expected: 0,
2013            clean: false,
2014            progressed: false,
2015            vote_split: false,
2016            reconsideration: Vec::new(),
2017            verdict: None,
2018        }];
2019        let text = run(&s);
2020        assert!(text.contains("cargo test --locked --all-targets"), "{text}");
2021        assert!(text.contains("cargo make check"), "{text}");
2022        assert!(text.contains("clippy: unused import"), "{text}");
2023    }
2024
2025    #[test]
2026    fn a_declined_finding_shows_its_reason() {
2027        use crate::verdict::{Finding, Rejection, Severity};
2028
2029        let _guard = plain();
2030        let mut s = state();
2031        s.status = RunStatus::Ready;
2032        s.reviews = vec![ReviewRound {
2033            round: 1,
2034            head: "deadbee".to_owned(),
2035            verified_head: None,
2036            verified_at: None,
2037            reviews: vec![ReviewRecord {
2038                attempts: 0,
2039                reviewer: 1,
2040                agent: "alpha".to_owned(),
2041                summary: String::new(),
2042                findings: vec![Finding {
2043                    id: "R1-1-1".to_owned(),
2044                    severity: Severity::Major,
2045                    file: None,
2046                    line: None,
2047                    title: "still open".to_owned(),
2048                    detail: String::new(),
2049                }],
2050                vote: None,
2051                failed: None,
2052                duration_ms: 0,
2053            }],
2054            e2e: vec![CommandOutcome {
2055                command: "cargo test".to_owned(),
2056                code: Some(0),
2057                output_tail: String::new(),
2058                duration_ms: 0,
2059                resource_blocked: false,
2060            }],
2061            verify_retried: false,
2062            e2e_deferred: false,
2063            e2e_defer_reason: None,
2064            fix: Some(FixRecord {
2065                agent: "alpha".to_owned(),
2066                addressed: Vec::new(),
2067                rejected: vec![Rejection {
2068                    id: "R1-1-2".to_owned(),
2069                    why: "cannot be triggered from any caller".to_owned(),
2070                }],
2071                notes: String::new(),
2072                committed: true,
2073                failed: None,
2074                duration_ms: 0,
2075                continuation: None,
2076            }),
2077            blocking: 1,
2078            answered: 1,
2079            expected: 1,
2080            clean: false,
2081            progressed: true,
2082            vote_split: false,
2083            reconsideration: Vec::new(),
2084            verdict: None,
2085        }];
2086
2087        let text = run(&s);
2088        assert!(text.contains("R1-1-2"), "{text}");
2089        assert!(text.contains("cannot be triggered"), "{text}");
2090        assert!(text.contains("still open"), "{text}");
2091        assert!(
2092            text.contains("handed off"),
2093            "a mergeable run with an open round must say so: {text}"
2094        );
2095    }
2096
2097    #[test]
2098    fn a_failing_gate_command_shows_its_output() {
2099        let _guard = plain();
2100        let mut s = state();
2101        s.status = RunStatus::Blocked;
2102        s.gate = vec![CommandOutcome {
2103            command: "cargo make check".to_owned(),
2104            code: Some(101),
2105            output_tail: "error[E0308]: mismatched types".to_owned(),
2106            duration_ms: 0,
2107            resource_blocked: false,
2108        }];
2109        s.gate_ran = true;
2110
2111        let text = run(&s);
2112        assert!(text.contains("mismatched types"), "{text}");
2113    }
2114
2115    #[test]
2116    fn a_gate_with_no_commands_configured_shows_a_pass_not_silence() {
2117        let _guard = plain();
2118        let mut s = state();
2119        s.status = RunStatus::Ready;
2120        s.gate_ran = true;
2121        assert!(s.gate.is_empty());
2122
2123        let text = run(&s);
2124        assert!(
2125            text.contains("gate") && text.contains("no gate commands configured"),
2126            "a run gated on nothing must say so, not read as if the gate never ran: {text}"
2127        );
2128    }
2129
2130    #[test]
2131    fn a_gate_that_has_not_run_yet_shows_nothing() {
2132        let _guard = plain();
2133        let s = state();
2134        assert!(!s.gate_ran);
2135        assert!(s.gate.is_empty());
2136
2137        let text = run(&s);
2138        assert!(
2139            !text.contains("no gate commands configured"),
2140            "an unattempted gate must not be shown as a pass: {text}"
2141        );
2142    }
2143
2144    #[test]
2145    fn active_seats_shows_who_has_not_answered_and_how_long_is_left() {
2146        let _guard = plain();
2147        let mut s = state();
2148        s.seat_started("judge", "judge-2", std::time::Duration::from_secs(120), 0);
2149        let text = active_seats(&s, Liveness::Live);
2150        assert!(text.contains("running now"));
2151        assert!(text.contains("judge-2"));
2152        assert!(text.contains("judge"));
2153        assert!(!text.contains("no live daemon"), "{text}");
2154        assert!(!text.contains("could not be confirmed"), "{text}");
2155    }
2156
2157    #[test]
2158    fn active_seats_flags_a_leftover_from_a_dead_process() {
2159        let _guard = plain();
2160        let mut s = state();
2161        s.seat_started("implement", "impl-B", std::time::Duration::from_secs(60), 0);
2162        let text = active_seats(&s, Liveness::Dead);
2163        assert!(
2164            text.contains("no live daemon"),
2165            "a stale entry must not read as running: {text}"
2166        );
2167    }
2168
2169    #[test]
2170    fn superseded_notice_names_the_run_that_replaced_it() {
2171        let _guard = plain();
2172        let text = superseded_notice(Some("bbbb"));
2173        assert!(text.contains("SUPERSEDED"), "{text}");
2174        assert!(text.contains("bbbb"), "{text}");
2175    }
2176
2177    #[test]
2178    fn superseded_notice_is_silent_for_the_latest_attempt() {
2179        let _guard = plain();
2180        assert_eq!(superseded_notice(None), "");
2181    }
2182
2183    #[test]
2184    fn list_line_marks_a_nonterminal_run_with_a_dead_driver_stale() {
2185        let _guard = plain();
2186        let mut s = state();
2187        s.status = RunStatus::Reviewing;
2188        let text = line_with_liveness(&s, Liveness::Dead);
2189        assert!(text.contains("STALE"), "{text}");
2190        assert!(text.contains("resume required"), "{text}");
2191        assert!(liveness_notice(&s, Liveness::Dead).contains("STALE"));
2192    }
2193
2194    /// A manual `magi run` / `magi review` claims no daemon, but its
2195    /// `driver_pid` still answers — this is `Unknown`, never `Dead`: see
2196    /// `RunState::liveness`'s own doc for why an unconfirmed process is never
2197    /// folded into "confirmed dead".
2198    #[test]
2199    fn active_seats_reports_uncertainty_without_claiming_death() {
2200        let _guard = plain();
2201        let mut s = state();
2202        s.seat_started("review", "review-1", std::time::Duration::from_secs(60), 0);
2203        let text = active_seats(&s, Liveness::Unknown);
2204        assert!(
2205            text.contains("could not be confirmed"),
2206            "an unproven state must read as uncertain, not dead: {text}"
2207        );
2208        assert!(!text.contains("no live daemon"), "{text}");
2209    }
2210
2211    #[test]
2212    fn active_seats_is_empty_when_nothing_is_running() {
2213        let _guard = plain();
2214        assert_eq!(active_seats(&state(), Liveness::Live), "");
2215    }
2216
2217    /// A running `verify.e2e` / `verify.gate` task is shown alongside seats,
2218    /// with which command is currently running and how far through the list
2219    /// it is — the gap the addendum's second item names: a review-only run
2220    /// that spends minutes inside `cargo test` between reviewer answers and
2221    /// the fix's own commit had nothing at all to show for it before this.
2222    #[test]
2223    fn active_seats_shows_a_running_verify_task_and_its_command() {
2224        let _guard = plain();
2225        let mut s = state();
2226        s.task_command(
2227            "e2e",
2228            "verify",
2229            0,
2230            "cargo test",
2231            2,
2232            3,
2233            std::time::Duration::from_secs(600),
2234        );
2235        let text = active_seats(&s, Liveness::Live);
2236        assert!(text.contains("e2e"), "{text}");
2237        assert!(text.contains("(2/3)"), "{text}");
2238        assert!(text.contains("cargo test"), "{text}");
2239    }
2240
2241    #[test]
2242    fn no_jobs_section_appears_when_nothing_was_ever_collected() {
2243        let _guard = plain();
2244        // The common case today (every backend but codex): silence, not a
2245        // clutter line repeated on every single `magi show`.
2246        assert!(!run(&state()).contains("background jobs"));
2247    }
2248
2249    #[test]
2250    fn a_codex_roster_with_no_completed_jobs_yet_says_so_instead_of_staying_silent() {
2251        let _guard = plain();
2252        let mut s = state();
2253        s.config.agents.push(crate::config::AgentSpec {
2254            id: "codex-one".to_owned(),
2255            kind: crate::config::AgentKind::Codex,
2256            model: None,
2257            command: vec!["codex".to_owned()],
2258            extra_args: Vec::new(),
2259            env: BTreeMap::new(),
2260            prompt_delivery: None,
2261        });
2262        let text = run(&s);
2263        assert!(
2264            text.contains("background jobs"),
2265            "a run that could report this must not read the same as one that never could: \
2266             {text}"
2267        );
2268        assert!(text.contains("no completed command evidence yet"));
2269    }
2270
2271    #[test]
2272    fn recovered_running_and_unreadable_jobs_are_told_apart() {
2273        let _guard = plain();
2274        let mut s = state();
2275        s.jobs = vec![
2276            crate::run::JobRecord {
2277                node: "implement".to_owned(),
2278                round: None,
2279                seat: "impl-A".to_owned(),
2280                id: "item49".to_owned(),
2281                description: "cargo test --test graph_cached_gate".to_owned(),
2282                checked_at: jiff::Timestamp::now(),
2283                status: crate::run::JobStatus::Completed,
2284                exit_code: Some(0),
2285                result_summary: "test result: 2 passed; 0 failed".to_owned(),
2286                source: "codex".to_owned(),
2287            },
2288            crate::run::JobRecord {
2289                node: "fix".to_owned(),
2290                round: None,
2291                seat: "impl-A".to_owned(),
2292                id: "item52".to_owned(),
2293                description: "cargo test --test graph_split".to_owned(),
2294                checked_at: jiff::Timestamp::now(),
2295                status: crate::run::JobStatus::Failed,
2296                exit_code: Some(101),
2297                result_summary: "test result: 1 passed; 1 failed".to_owned(),
2298                source: "codex".to_owned(),
2299            },
2300            crate::run::JobRecord {
2301                node: "fix".to_owned(),
2302                round: None,
2303                seat: "impl-A".to_owned(),
2304                id: "item60".to_owned(),
2305                description: "cargo build".to_owned(),
2306                checked_at: jiff::Timestamp::now(),
2307                status: crate::run::JobStatus::Unknown,
2308                exit_code: None,
2309                result_summary: String::new(),
2310                source: "codex".to_owned(),
2311            },
2312        ];
2313        let text = run(&s);
2314        assert!(text.contains("background jobs"));
2315        assert!(text.contains("item49"));
2316        assert!(text.contains("item52"));
2317        assert!(text.contains("item60"));
2318        // The three states this run actually has evidence for must read
2319        // differently from one another — never collapsed into a single
2320        // "ran" or "did not run".
2321        assert!(text.contains("completed"));
2322        assert!(text.contains("failed"));
2323        assert!(text.contains("unknown"));
2324        // Coverage limit stated once, not fabricated per seat.
2325        assert!(text.contains("adapter coverage"));
2326    }
2327
2328    #[test]
2329    fn a_jobs_own_round_is_shown_when_known() {
2330        let _guard = plain();
2331        let mut s = state();
2332        s.jobs = vec![crate::run::JobRecord {
2333            node: "review".to_owned(),
2334            round: Some(2),
2335            seat: "review-1".to_owned(),
2336            id: "item9".to_owned(),
2337            description: "cargo test --test graph_cached_gate".to_owned(),
2338            checked_at: jiff::Timestamp::now(),
2339            status: crate::run::JobStatus::Completed,
2340            exit_code: Some(0),
2341            result_summary: "test result: 2 passed; 0 failed".to_owned(),
2342            source: "codex".to_owned(),
2343        }];
2344        let text = run(&s);
2345        assert!(
2346            text.contains("round 2"),
2347            "the round this seat's own command ran in must be visible, distinct from magi's \
2348             own recorded verify: {text}"
2349        );
2350    }
2351
2352    #[test]
2353    fn stats_table_renders_without_runs() {
2354        let _guard = plain();
2355        let text = stats(&Stats::default());
2356        assert!(text.contains("0 total"));
2357        assert!(!text.contains("implementation"));
2358        assert!(!text.contains("node durations"));
2359    }
2360
2361    #[test]
2362    fn repo_summary_lists_run_count_and_completion_rate() {
2363        let _guard = plain();
2364        let a = crate::stats::RepoStats {
2365            repo: PathBuf::from("/repos/a"),
2366            name: "a".to_owned(),
2367            stats: Stats {
2368                totals: crate::stats::Totals {
2369                    runs: 4,
2370                    merged: 2,
2371                    ready: 1,
2372                    ..Default::default()
2373                },
2374                ..Default::default()
2375            },
2376        };
2377        let text = repo_summary(&[a]);
2378        assert!(text.contains("repos"), "{text}");
2379        assert!(text.contains("a  4 runs  75% completion"), "{text}");
2380    }
2381
2382    #[test]
2383    fn repo_summary_disambiguates_colliding_names_with_the_parent_directory() {
2384        let _guard = plain();
2385        let a = crate::stats::RepoStats {
2386            repo: PathBuf::from("/roots/one/magi"),
2387            name: "magi".to_owned(),
2388            stats: Stats::default(),
2389        };
2390        let b = crate::stats::RepoStats {
2391            repo: PathBuf::from("/roots/two/magi"),
2392            name: "magi".to_owned(),
2393            stats: Stats::default(),
2394        };
2395        let text = repo_summary(&[a, b]);
2396        assert!(text.contains("magi (one)"), "{text}");
2397        assert!(text.contains("magi (two)"), "{text}");
2398    }
2399
2400    #[test]
2401    fn stats_table_renders_advisor_reflection() {
2402        let _guard = plain();
2403        let st = Stats {
2404            advisors: vec![crate::stats::AdvisorStats {
2405                agent: "alpha".to_owned(),
2406                seated: 3,
2407                proposed: 2,
2408                absent: 1,
2409                faint: 1,
2410                strong: 1,
2411            }],
2412            ..Default::default()
2413        };
2414        let text = stats(&st);
2415        assert!(text.contains("design deliberation"));
2416        assert!(
2417            text.contains("approximate"),
2418            "must note the heuristic: {text}"
2419        );
2420        assert!(text.contains("alpha"));
2421        assert!(text.contains("50%"));
2422    }
2423
2424    #[test]
2425    fn stats_table_shows_release_bump_coverage_even_when_nothing_was_recorded() {
2426        // A repository that has merged runs but never wired up (or never hit)
2427        // the release-bump step must still show "0 of N merged runs recorded
2428        // a bump" - hiding the whole section on `recorded == 0` would make
2429        // that gap invisible instead of reporting it.
2430        let _guard = plain();
2431        let st = Stats {
2432            release_bumps: crate::stats::ReleaseBumpStats {
2433                merged: 3,
2434                ..Default::default()
2435            },
2436            ..Default::default()
2437        };
2438        let text = stats(&st);
2439        assert!(text.contains("release bumps"), "{text}");
2440        assert!(
2441            text.contains("0 of 3 merged run(s) recorded a bump"),
2442            "{text}"
2443        );
2444    }
2445
2446    #[test]
2447    fn stats_table_renders_release_bump_coverage_and_attention() {
2448        let _guard = plain();
2449        let st = Stats {
2450            release_bumps: crate::stats::ReleaseBumpStats {
2451                merged: 4,
2452                recorded: 2,
2453                pr_opened: 2,
2454                automerge_enabled: 1,
2455                merged_directly: 0,
2456                needs_attention: 1,
2457            },
2458            ..Default::default()
2459        };
2460        let text = stats(&st);
2461        assert!(text.contains("release bumps"), "{text}");
2462        assert!(
2463            text.contains("2 of 4 merged run(s) recorded a bump (50%)"),
2464            "{text}"
2465        );
2466        assert!(text.contains("1 clean, 1 needed a human (50%)"), "{text}");
2467    }
2468
2469    #[test]
2470    fn stats_table_renders_node_durations_with_a_bar_and_unmeasured_count() {
2471        let _guard = plain();
2472        let st = Stats {
2473            nodes: vec![
2474                crate::stats::NodeDuration {
2475                    node: "implement".to_owned(),
2476                    runs: 2,
2477                    total_secs: 200,
2478                    max_secs: 150,
2479                    single: 1,
2480                },
2481                crate::stats::NodeDuration {
2482                    node: "gate".to_owned(),
2483                    runs: 0,
2484                    total_secs: 0,
2485                    max_secs: 0,
2486                    single: 3,
2487                },
2488            ],
2489            ..Default::default()
2490        };
2491        let text = stats(&st);
2492        assert!(text.contains("node durations"));
2493        assert!(text.contains("implement"));
2494        assert!(text.contains("2 runs"));
2495        assert!(text.contains('█'), "the leader must draw a bar: {text}");
2496        assert!(text.contains("1 unmeasured"));
2497        assert!(text.contains("gate"));
2498        assert!(text.contains("3 unmeasured"));
2499        assert!(!text.contains('\x1b'), "colour leaked into a plain render");
2500    }
2501}