Skip to main content

magi/
report.rs

1//! Terminal rendering.
2//!
3//! A run produces a lot of state; the report exists so the operator can decide
4//! what to do next without opening `run.json`. It leads with the disagreement,
5//! because that is the part that carries information: three judges agreeing
6//! tells you nothing the winner's diff does not.
7//!
8//! Colour is a six-line local implementation rather than a crate. The
9//! alternatives all decide *for* you whether the stream supports colour, which
10//! makes the output untestable — `assert!(text.contains("winner  A"))` fails on
11//! an escape sequence the test never asked for.
12use std::fmt::Write as _;
13use std::sync::atomic::{AtomicBool, Ordering};
14
15use crate::config::{MergeMode, MergeStyle};
16use crate::run::{
17    CommandOutcome, ContinuationOutcome, E2eStatus, GateStatus, JobStatus, Liveness,
18    OperatorFixOutcome, RunState, RunStatus, tail,
19};
20use crate::stats::{RepoStats, Stats};
21use crate::verdict::ReviewVote;
22
23static COLOR: AtomicBool = AtomicBool::new(true);
24
25/// Turn colour on or off for every subsequent render.
26pub fn set_color(on: bool) {
27    COLOR.store(on, Ordering::Relaxed);
28}
29
30fn paint(text: &str, code: &str) -> String {
31    if COLOR.load(Ordering::Relaxed) {
32        format!("\x1b[{code}m{text}\x1b[0m")
33    } else {
34        text.to_owned()
35    }
36}
37
38fn bold(t: &str) -> String {
39    paint(t, "1")
40}
41fn dim(t: &str) -> String {
42    paint(t, "2")
43}
44fn red(t: &str) -> String {
45    paint(t, "31")
46}
47fn green(t: &str) -> String {
48    paint(t, "32")
49}
50fn yellow(t: &str) -> String {
51    paint(t, "33")
52}
53fn cyan(t: &str) -> String {
54    paint(t, "36")
55}
56
57/// Colour for a status word.
58///
59/// `Stalled` is deliberately not green: a run whose judges were taken out by a
60/// rate limit must not look like a healthy `Ready` in a one-line listing.
61///
62/// A `Ready` reached via `[merge] mode = "none"` is a second case that must
63/// not look like a plain `Ready`: that run is done for good, never picked up
64/// by the PR-polling merge watcher or anything else, while an ordinary
65/// `Ready` (a PR closed without merging, an already-concluded re-entry) may
66/// still be a live landing candidate. See [`RunState::unmerged_by_design`].
67fn status_word(state: &RunState) -> String {
68    if state.unmerged_by_design() {
69        return cyan("unmerged (no-op by design)");
70    }
71    let text = state.status.display_label();
72    if state.needs_attention() {
73        return bold(&yellow(&format!("{text} - release needs a human")));
74    }
75    match state.status {
76        RunStatus::Merged => bold(&green(text)),
77        RunStatus::Ready => green(text),
78        RunStatus::Stalled => bold(&yellow(text)),
79        RunStatus::Blocked => yellow(text),
80        RunStatus::Failed => red(text),
81        // Not `Failed`'s red: every candidate agreed, with evidence, that
82        // nothing belongs in this worktree — the opposite of a run that
83        // could not do the work. See `RunStatus::VerifiedNoop`'s own doc.
84        RunStatus::VerifiedNoop => cyan(text),
85        // Muted, not `Blocked`'s yellow: nothing here needs a human's
86        // attention any more, a later attempt already settled the task.
87        RunStatus::Superseded => dim(text),
88        _ => cyan(text),
89    }
90}
91
92/// Colour for a reviewer vote — the same scale a finding's severity gets:
93/// green for no reservations, yellow for proceed-but-look-at-this, red for a
94/// vote that says stop.
95fn vote_tag(vote: ReviewVote) -> String {
96    let text = vote.label();
97    match vote {
98        ReviewVote::Approve => green(text),
99        ReviewVote::ApproveWithFindings => yellow(text),
100        ReviewVote::Reject => red(text),
101    }
102}
103
104/// One-line summary, for `magi list`.
105pub fn line(state: &RunState) -> String {
106    line_with_liveness(state, Liveness::Unknown)
107}
108
109/// [`line`] with the independent process-liveness observation available to
110/// `magi list`.
111pub fn line_with_liveness(state: &RunState, live: Liveness) -> String {
112    let winner = state
113        .tally
114        .as_ref()
115        .map_or("-".to_owned(), |t| t.winner.to_string());
116    let agent = state.winner().map_or("-", |c| c.agent.as_str());
117    // A below-quorum verdict carries an explicit stamp so a row in a listing
118    // reads "stalled" and "2/3 judges" without opening the report.
119    let quorum = match state.tally.as_ref() {
120        Some(t) if !t.met_quorum => format!(
121            "  {}",
122            bold(&red(&format!("quorum {}/{}", t.present, t.judges)))
123        ),
124        Some(t) if t.present > 0 && t.present < t.judges => format!(
125            "  {}",
126            yellow(&format!("judges {}/{}", t.present, t.judges))
127        ),
128        _ => String::new(),
129    };
130    let stale = if !state.status.done() && live == Liveness::Dead {
131        format!(
132            "  {}",
133            bold(&yellow("STALE — driver exited; resume required"))
134        )
135    } else {
136        String::new()
137    };
138    format!(
139        "{}  {:<20}  {:>2}c {:>2}j  win {} ({}){quorum}{stale}  {}",
140        dim(&state.id),
141        status_word(state),
142        state.candidates.len(),
143        state.judgements.len(),
144        winner,
145        agent,
146        first_line(&state.instruction)
147    )
148}
149
150/// A plainly visible verdict for a non-terminal run whose recorded driver is
151/// gone. Kept separate from [`active_seats`] because a process can die at a
152/// node boundary with no active seat left in the saved state.
153pub fn liveness_notice(state: &RunState, live: Liveness) -> String {
154    if !state.status.done() && live == Liveness::Dead {
155        format!(
156            "{}\n\n",
157            yellow("STALE — the process driving this run exited; resume it to continue.")
158        )
159    } else {
160        String::new()
161    }
162}
163
164/// A plainly visible note for a run a later attempt at the same task already
165/// replaced — the terminal counterpart of the web UI's "Superseded by …"
166/// line. `later` is the short id of that later attempt, or `None` when this
167/// run is not superseded at all (the common case).
168///
169/// Kept as its own function, concatenated by the caller, rather than an
170/// argument threaded through [`run`] itself: `run` is called from `bump.rs`,
171/// `tui.rs` and every `magi show`/`magi list` path with no notion of "what
172/// replaced this", and adding a parameter there would mean guessing `None`
173/// at every one of those call sites instead of only at the one that knows.
174pub fn superseded_notice(later: Option<&str>) -> String {
175    match later {
176        Some(later) => format!(
177            "{}\n\n",
178            yellow(&format!(
179                "SUPERSEDED — a later attempt at this task ({later}) replaced it; this record \
180                 is kept but is not the one to act on."
181            ))
182        ),
183        None => String::new(),
184    }
185}
186
187fn first_line(text: &str) -> String {
188    let line = text.lines().next().unwrap_or_default();
189    if line.chars().count() > 68 {
190        format!("{}…", line.chars().take(67).collect::<String>())
191    } else {
192        line.to_owned()
193    }
194}
195
196fn short(commit: &str) -> String {
197    commit.chars().take(7).collect()
198}
199
200/// A short badge for a [`crate::run::ContinuationRecord`], distinguishing
201/// "the seat's own report needed to be resumed" from "there was nothing to
202/// address" — a fixer that has never needed this stays silent here, exactly
203/// as a record predating the feature (`continuation: None`) does too.
204fn continuation_note(c: &crate::run::ContinuationRecord) -> String {
205    match c.outcome {
206        ContinuationOutcome::NotNeeded => String::new(),
207        ContinuationOutcome::Resumed => format!(" [resumed x{}]", c.attempts),
208        ContinuationOutcome::Exhausted => format!(" [continuation exhausted x{}]", c.attempts),
209        ContinuationOutcome::QuotaLost => " [continuation: quota]".to_owned(),
210        ContinuationOutcome::NoSession => " [no session to resume]".to_owned(),
211    }
212}
213
214/// Commands seats' own CLIs reported running, across every node — see
215/// [`crate::run::JobRecord`]. Read-only: renders whatever `run.json` already
216/// holds, does not query anything live and does not spawn an agent.
217///
218/// A CLI this crate has no adapter for (every backend but Codex, as of this
219/// writing) never appears here at all — silence is "no evidence", not "no
220/// jobs ran", which the trailing coverage line exists to say once rather
221/// than per seat.
222///
223/// There is deliberately no "running" state anywhere in this. A command a
224/// CLI never reported finishing has no way to be told apart from one that
225/// never started at all: the CLI that would report it has, by construction,
226/// already stopped talking (killed by a timeout, or a park) by the time that
227/// question matters, so no event — real or guessed at — could ever answer
228/// it. Guessing at an unconfirmed event shape to manufacture a "running"
229/// entry is exactly the fabrication this feature must not do; recording that
230/// limit instead is what the task asks for here. `magi show`'s own
231/// seat-completion state ([`active_seats`]) still answers a related but
232/// different question honestly — "has this seat's own turn answered yet" —
233/// and stays the right place to look for that.
234fn jobs_section(state: &RunState) -> String {
235    let mut s = String::new();
236    if state.jobs.is_empty() {
237        // Not silent when it would matter: a run whose roster can actually
238        // report this (Codex, today) but has not yet says so explicitly, so
239        // "no adapter for this backend" and "nothing reported yet" are never
240        // the same blank space to a reader.
241        if state
242            .config
243            .agents
244            .iter()
245            .any(|a| a.kind == crate::config::AgentKind::Codex)
246        {
247            let _ = writeln!(
248                s,
249                "\n{}",
250                dim(
251                    "background jobs: no completed command evidence yet for this run (see \
252                     active seats above for what is still mid-turn)"
253                )
254            );
255        }
256        return s;
257    }
258    let _ = writeln!(
259        s,
260        "\n{}",
261        bold("background jobs (from each seat's own CLI)")
262    );
263    let mut by_seat: std::collections::BTreeMap<(&str, &str), Vec<&crate::run::JobRecord>> =
264        std::collections::BTreeMap::new();
265    for j in &state.jobs {
266        by_seat
267            .entry((j.node.as_str(), j.seat.as_str()))
268            .or_default()
269            .push(j);
270    }
271    for ((node, seat), records) in by_seat {
272        let _ = writeln!(s, "  {node}/{seat}");
273        for j in records {
274            let status = match j.status {
275                JobStatus::Completed => green("completed"),
276                JobStatus::Failed => red("failed"),
277                JobStatus::Unknown => yellow("unknown"),
278            };
279            let _ = writeln!(
280                s,
281                "    {} {}{}{}  checked {}",
282                dim(&j.id),
283                status,
284                j.exit_code
285                    .map_or(String::new(), |c| format!(" (exit {c})")),
286                j.round.map_or(String::new(), |r| format!("  round {r}")),
287                j.checked_at
288                    .to_zoned(jiff::tz::TimeZone::system())
289                    .strftime("%Y-%m-%d %H:%M:%S")
290            );
291            let desc = first_line(&j.description);
292            if !desc.trim().is_empty() {
293                let _ = writeln!(s, "      $ {desc}");
294            }
295            let summary = first_line(&j.result_summary);
296            if !summary.trim().is_empty() {
297                let _ = writeln!(s, "      {}", dim(&summary));
298            }
299        }
300    }
301    let _ = writeln!(
302        s,
303        "  {}",
304        dim(
305            "(adapter coverage: codex only today; other backends, and a command a CLI never \
306             reported finishing, leave no entry here — that is unknown, never \"nothing ran\")"
307        )
308    );
309    s
310}
311
312/// Full report for one run.
313pub fn run(state: &RunState) -> String {
314    let mut s = String::new();
315    let _ = writeln!(
316        s,
317        "{} {}  {}",
318        bold("magi run"),
319        bold(&state.id),
320        status_word(state)
321    );
322    let _ = writeln!(
323        s,
324        "  repo    {} ({} @ {})",
325        state.repo.display(),
326        state.base_branch,
327        short(&state.base_commit)
328    );
329    let _ = writeln!(s, "  created {}", state.created_local());
330    let _ = writeln!(s, "  task    {}", first_line(&state.instruction));
331    let _ = writeln!(s, "  state   {}", state.dir().display());
332
333    let _ = writeln!(s, "\n{}", bold("candidates"));
334    for c in &state.candidates {
335        let flag = match (&c.failed, c.empty, &c.verified_noop) {
336            (Some(e), _, _) => red(&format!("failed: {e}")),
337            // Neither red (nothing failed) nor plain yellow "no change" (that
338            // reads as an unexplained loss): the candidate gave a reason a
339            // human still has to check, not a claim magi itself confirmed.
340            (None, true, Some(_)) => cyan("agent-verified no-op (unconfirmed)"),
341            (None, true, None) => yellow("no change"),
342            _ => format!("{} files, {} commits", c.files, c.commits),
343        };
344        let crown = if state.tally.as_ref().is_some_and(|t| t.winner == c.label) {
345            bold(&green("  <- winner"))
346        } else {
347            String::new()
348        };
349        let _ = writeln!(
350            s,
351            "  {}  {:<12} {:<30} {:>5}s{}",
352            bold(&c.label.to_string()),
353            c.agent,
354            flag,
355            c.duration_ms / 1000,
356            crown
357        );
358        if let Some(evidence) = &c.verified_noop {
359            let _ = writeln!(s, "      {}", dim(&first_line(evidence)));
360        } else if !c.summary.trim().is_empty() {
361            // The candidate's own account of what it did and why — the
362            // "## SUMMARY" `prompt::implement` asks for — was recorded on
363            // every run but never surfaced here, which left `magi show`
364            // silent about it even when the summary was the whole point (an
365            // implementer explaining *why* it wrote nothing, short of a
366            // verified no-op's own line above). One line, matching the
367            // house style other prose fields get in this report (see the
368            // review findings' `detail` below); the rest is in `run.json`.
369            let _ = writeln!(s, "      {}", dim(&first_line(&c.summary)));
370        }
371    }
372
373    if !state.judgements.is_empty() {
374        let _ = writeln!(s, "\n{}", bold("blind judging"));
375        for j in &state.judgements {
376            match &j.failed {
377                Some(e) => {
378                    let _ = writeln!(
379                        s,
380                        "  judge {}  {}",
381                        j.judge,
382                        red(&format!("no ranking: {e}"))
383                    );
384                }
385                None => {
386                    let _ = writeln!(
387                        s,
388                        "  judge {}  {:<12} {}  confidence {}",
389                        j.judge,
390                        j.agent,
391                        bold(&j.ranking.iter().collect::<String>()),
392                        j.confidence.map_or("-".to_owned(), |c| c.to_string())
393                    );
394                }
395            }
396        }
397    }
398
399    if let Some(t) = &state.tally {
400        if t.deliberated {
401            let _ = writeln!(s, "\n{}", bold("deliberation"));
402            for round in &state.deliberation {
403                for turn in &round.turns {
404                    let _ = writeln!(
405                        s,
406                        "  r{} judge {} -> {}",
407                        round.round,
408                        turn.judge,
409                        turn.tentative.map_or("-".to_owned(), |c| c.to_string())
410                    );
411                }
412            }
413        }
414
415        if !state.votes.is_empty() {
416            let _ = writeln!(s, "\n{}", bold("final votes (collected privately)"));
417            for v in &state.votes {
418                let _ = writeln!(
419                    s,
420                    "  judge {}  {:<12} {}{}",
421                    v.judge,
422                    v.agent,
423                    bold(&v.vote.unwrap_or('?').to_string()),
424                    if v.changed {
425                        yellow("  (changed after deliberation)")
426                    } else {
427                        String::new()
428                    }
429                );
430            }
431        }
432
433        let _ = writeln!(s, "\n{}", bold("tally"));
434        // A tally with no panel (`uncontested`) must not fall through the
435        // judges/first-choice/after-votes lines below: they are written
436        // unconditionally and every one of them reads, in the words a panel
437        // that collapsed would also produce, as a run that lost its judges
438        // rather than one that never needed them.
439        match &t.uncontested {
440            Some(reason) => {
441                let _ = writeln!(
442                    s,
443                    "  judging       {}",
444                    cyan(&format!("not needed — {reason}"))
445                );
446            }
447            None => {
448                let _ = writeln!(
449                    s,
450                    "  judges        {} present{}",
451                    if t.met_quorum {
452                        green(&format!("{}/{}", t.present, t.judges))
453                    } else {
454                        red(&format!("{}/{}", t.present, t.judges))
455                    },
456                    if t.quorum > 0 {
457                        format!(" ({quorum} required)", quorum = t.quorum)
458                    } else {
459                        String::new()
460                    }
461                );
462                if !t.met_quorum {
463                    let _ = writeln!(
464                        s,
465                        "  {}",
466                        bold(&red("BELOW QUORUM — verdict is not trustworthy"))
467                    );
468                }
469                let _ = writeln!(
470                    s,
471                    "  first choice  {}",
472                    t.first_choice
473                        .iter()
474                        .map(|(k, v)| format!("{k}:{v}"))
475                        .collect::<Vec<_>>()
476                        .join("  ")
477                );
478                let _ = writeln!(
479                    s,
480                    "  initial       {}",
481                    match (t.rankings, t.unanimous_initial) {
482                        (0, _) => red("no usable ranking"),
483                        (1, _) => yellow("one usable ranking - not a consensus"),
484                        (_, true) => green("unanimous"),
485                        (_, false) => yellow("split"),
486                    }
487                );
488                let _ = writeln!(
489                    s,
490                    "  after votes   {}  ({} judge(s) moved)",
491                    if t.unanimous_final {
492                        green("unanimous")
493                    } else {
494                        yellow("still split")
495                    },
496                    t.changed_votes
497                );
498                if let Some(tb) = &t.tie_break {
499                    let _ = writeln!(s, "  tie break     {tb}");
500                }
501            }
502        }
503        if !state.quota.is_empty() {
504            let _ = writeln!(
505                s,
506                "  rate limited  {}",
507                state
508                    .quota
509                    .iter()
510                    .map(|q| q.seat.as_str())
511                    .collect::<Vec<_>>()
512                    .join(", ")
513            );
514        }
515        let _ = writeln!(s, "  winner        {}", bold(&green(&t.winner.to_string())));
516    }
517
518    if !state.withheld.is_empty() {
519        let _ = writeln!(s, "\n{}", bold("withheld from commit"));
520        for w in &state.withheld {
521            let _ = writeln!(
522                s,
523                "  {} {}  ({} lockfile; the directory uses {})",
524                yellow("!"),
525                w.path,
526                w.manager,
527                w.kept_by
528            );
529        }
530    }
531
532    if !state.reviews.is_empty() {
533        let _ = writeln!(s, "\n{}", bold("review + verification"));
534        for r in &state.reviews {
535            let raised: usize = r.reviews.iter().map(|x| x.findings.len()).sum();
536            // A build/link failure is not a verdict on the patch (a shared
537            // `CARGO_TARGET_DIR` link race looks exactly like one), so it
538            // must not read the same as a real test failure. And a deferred
539            // round is not a passed one: `e2e.is_empty()` alone cannot tell
540            // "not configured" from "skipped on purpose" apart, which is
541            // exactly why `e2e_status` exists rather than reading `e2e`
542            // directly here.
543            let e2e = match r.e2e_status() {
544                E2eStatus::NotConfigured => dim("no e2e"),
545                E2eStatus::Deferred => yellow(&format!(
546                    "e2e deferred{}",
547                    r.e2e_defer_reason
548                        .as_deref()
549                        .map(|why| format!(" ({why})"))
550                        .unwrap_or_default()
551                )),
552                E2eStatus::Passed => green("e2e green"),
553                E2eStatus::Failed if r.e2e.iter().any(CommandOutcome::build_failed) => {
554                    yellow("e2e could not run (build/link failure)")
555                }
556                E2eStatus::Failed => red("e2e RED"),
557                // Magi's own admission it could not get a command to run —
558                // never the same yellow/red a real attempt earns, since
559                // nothing here is evidence about the patch (see
560                // `E2eStatus::ResourceBlocked`'s own doc).
561                E2eStatus::ResourceBlocked => {
562                    yellow("e2e could not run (shared build cache unavailable)")
563                }
564            };
565            let e2e = if r.verify_retried {
566                format!("{e2e}, retried once")
567            } else {
568                e2e
569            };
570            // Three distinct facts, not two: a round can be *open* (blocking
571            // findings still standing), *incomplete* (a seat never answered,
572            // so what the round says is missing input) or genuinely clean.
573            let status = if r.incomplete() {
574                yellow("incomplete")
575            } else if r.clean {
576                green("clean")
577            } else {
578                yellow("open")
579            };
580            // A missing seat must stay visible even when `warn` policy let
581            // the round gate as clean: the reader should never have to take
582            // "clean" on faith when the panel wasn't full.
583            let panel = if r.incomplete() {
584                let missing: Vec<String> = r
585                    .reviews
586                    .iter()
587                    .filter_map(|x| {
588                        x.failed
589                            .as_ref()
590                            .map(|why| format!("review-{}: {why}", x.reviewer))
591                    })
592                    .collect();
593                format!(
594                    "  {}/{} reviewers answered ({})",
595                    r.answered,
596                    r.expected,
597                    missing.join(", ")
598                )
599            } else {
600                String::new()
601            };
602            // The verdict is the one thing this loop cannot derive from
603            // `blocking`/`e2e` alone: three seats can agree there is nothing
604            // blocking and still split on whether the patch is fine to
605            // proceed as-is, which is exactly the disagreement a vote exists
606            // to surface.
607            let verdict = r.verdict.map_or(String::new(), |v| {
608                format!(
609                    ", verdict {}{}",
610                    vote_tag(v),
611                    if r.vote_split { " (panel split)" } else { "" }
612                )
613            });
614            let _ = writeln!(
615                s,
616                "  round {}  {} @ {}{}{panel}  {raised} finding(s), {} blocking, {e2e}{verdict}{}",
617                r.round,
618                status,
619                short(&r.head),
620                r.verified_head.as_ref().map_or(String::new(), |head| {
621                    format!(
622                        " (verified @ {}{})",
623                        short(head),
624                        r.verified_at.map_or(String::new(), |t| format!(
625                            " on {}",
626                            t.to_zoned(jiff::tz::TimeZone::system())
627                                .strftime("%Y-%m-%d %H:%M:%S")
628                        ))
629                    )
630                }),
631                r.blocking,
632                r.fix.as_ref().map_or(String::new(), |f| {
633                    let tree = if r.progressed {
634                        green("changed")
635                    } else {
636                        yellow("unchanged")
637                    };
638                    let cont = f
639                        .continuation
640                        .as_ref()
641                        .map_or(String::new(), continuation_note);
642                    match &f.failed {
643                        // Never the same shape as "N addressed / M rejected": the
644                        // fixer's diff may well have landed (see the `fix` node's
645                        // own event), but whether it addressed anything is
646                        // unknown, not zero.
647                        Some(reason) => format!(
648                            "  fix: {}, tree {tree}{}{cont}",
649                            yellow(&format!("adoption report lost ({reason})")),
650                            if f.committed {
651                                String::new()
652                            } else {
653                                red(" (NO COMMIT)")
654                            }
655                        ),
656                        None => format!(
657                            "  fix: {} addressed / {} rejected, tree {tree}{}{cont}",
658                            f.addressed.len(),
659                            f.rejected.len(),
660                            if f.committed {
661                                String::new()
662                            } else {
663                                red(" (NO COMMIT)")
664                            }
665                        ),
666                    }
667                })
668            );
669            // The aggregate label above (`e2e`) says the round's overall
670            // verdict; it never named the commands themselves, so a round
671            // with more than one `verify.e2e` command left no way to tell
672            // which one actually failed or was blocked without opening
673            // `run.json` by hand — the same gap `gate`'s own per-command
674            // listing above already closes for the final gate.
675            for o in &r.e2e {
676                let label = if o.resource_blocked {
677                    yellow("blocked")
678                } else if o.ok() {
679                    green("pass")
680                } else {
681                    red("FAIL")
682                };
683                let _ = writeln!(s, "    {label}  {}", o.command);
684                if !o.ok() {
685                    let _ = writeln!(s, "{}", dim(&tail(&o.output_tail, 2_000)));
686                }
687            }
688            for rec in &r.reviews {
689                if let Some(vote) = rec.vote {
690                    let _ = writeln!(s, "      review-{} vote {}", rec.reviewer, vote_tag(vote));
691                }
692                for f in &rec.findings {
693                    let adopted = r
694                        .fix
695                        .as_ref()
696                        .is_some_and(|fix| fix.addressed.contains(&f.id));
697                    let _ = writeln!(
698                        s,
699                        "      {} [{:?}] {}{}",
700                        dim(&f.id),
701                        f.severity,
702                        f.title,
703                        if adopted {
704                            green("  fixed")
705                        } else {
706                            String::new()
707                        }
708                    );
709                }
710            }
711            if let Some(fix) = &r.fix {
712                for rej in &fix.rejected {
713                    let _ = writeln!(
714                        s,
715                        "      {} {}: {}",
716                        dim(&rej.id),
717                        yellow("declined"),
718                        rej.why
719                    );
720                }
721            }
722            // Reconsideration only ever has entries when the round's initial
723            // votes split — an empty list here means the panel agreed the
724            // first time, same as an empty `deliberation` for judges.
725            if !r.reconsideration.is_empty() {
726                let _ = writeln!(s, "      {}", dim("reconsideration:"));
727                for rv in &r.reconsideration {
728                    match rv.vote {
729                        Some(v) => {
730                            let _ = writeln!(
731                                s,
732                                "        review-{} -> {}  {}",
733                                rv.reviewer,
734                                vote_tag(v),
735                                rv.reason
736                            );
737                        }
738                        None => {
739                            let _ = writeln!(
740                                s,
741                                "        review-{} -> {}",
742                                rv.reviewer,
743                                red(&format!(
744                                    "no revote ({})",
745                                    rv.failed.as_deref().unwrap_or("unknown")
746                                ))
747                            );
748                        }
749                    }
750                }
751            }
752        }
753        if state.handed_off_with_open_findings() {
754            let _ = writeln!(
755                s,
756                "\n  {}",
757                yellow(&format!(
758                    "handed off with {} finding(s) still open — gate and e2e were green; \
759                     see above for what a person should still look at",
760                    state.open_findings().len()
761                ))
762            );
763        }
764    }
765
766    if !state.operator_fixes.is_empty() {
767        let _ = writeln!(s, "\n{}", bold("operator fix(es)"));
768        for (i, req) in state.operator_fixes.iter().enumerate() {
769            let _ = writeln!(
770                s,
771                "  [{}] {} finding(s) at {}{}",
772                i + 1,
773                req.findings.len(),
774                req.requested_at
775                    .to_zoned(jiff::tz::TimeZone::system())
776                    .strftime("%Y-%m-%d %H:%M:%S"),
777                if req.stale {
778                    yellow("  stale head, --allow-stale used")
779                } else {
780                    String::new()
781                }
782            );
783            let _ = writeln!(s, "      reason: {}", req.reason);
784            for f in &req.findings {
785                let outcome = match &f.outcome {
786                    OperatorFixOutcome::Pending => yellow("pending"),
787                    OperatorFixOutcome::Addressed => green("addressed"),
788                    OperatorFixOutcome::Rejected { why } => red(&format!("rejected: {why}")),
789                    OperatorFixOutcome::Unreported => {
790                        red("unreported — no adoption report came back")
791                    }
792                };
793                let _ = writeln!(
794                    s,
795                    "      {} [{:?}] {}  {outcome}",
796                    dim(&f.id),
797                    f.severity,
798                    f.title
799                );
800            }
801            match &req.follow_up_review_run {
802                Some(id) => {
803                    let _ = writeln!(s, "      re-verified by run {id}");
804                }
805                None if req.fix.as_ref().is_some_and(|fx| fx.committed) => {
806                    let _ = writeln!(
807                        s,
808                        "      {}",
809                        red("committed, but the follow-up review could not be opened")
810                    );
811                }
812                None => {
813                    let _ = writeln!(s, "      no change committed; nothing to re-verify");
814                }
815            }
816        }
817    }
818
819    if let Some(bs) = &state.base_sync {
820        let _ = writeln!(s, "\n{}", bold("base sync"));
821        let status = if let Some(c) = &bs.conflict {
822            red(&format!("conflict: {}", first_line(c)))
823        } else if bs.behind == 0 {
824            green("in sync")
825        } else {
826            yellow(&format!("{} commit(s) behind, not yet rebased", bs.behind))
827        };
828        let _ = writeln!(
829            s,
830            "  {} @ {}  {status}{}",
831            state.base_branch,
832            short(&bs.tip),
833            if bs.attempts > 0 {
834                format!("  ({} rebase attempt(s))", bs.attempts)
835            } else {
836                String::new()
837            }
838        );
839    }
840
841    if !state.pre_gate.is_empty() {
842        let _ = writeln!(s, "\n{}", bold("pre_gate"));
843        for o in &state.pre_gate {
844            let _ = writeln!(
845                s,
846                "  {}  {}",
847                if o.ok() {
848                    green("pass")
849                } else {
850                    yellow("warn")
851                },
852                o.command
853            );
854            if !o.ok() {
855                let _ = writeln!(s, "{}", dim(&tail(&o.output_tail, 2_000)));
856            }
857        }
858        if let Some(c) = &state.pre_gate_commit {
859            let _ = writeln!(s, "  committed mechanical fixes @ {}", short(c));
860        }
861    }
862
863    // `state.gate.is_empty()` alone cannot tell "never ran" apart from "ran
864    // with nothing configured" — see `RunState::gate_status`'s own doc — so
865    // this reads the accessor rather than the raw list.
866    match state.gate_status() {
867        GateStatus::NotRun => {}
868        GateStatus::PassedWithNoCommands => {
869            let _ = writeln!(s, "\n{}", bold("gate"));
870            let _ = writeln!(s, "  {}  no gate commands configured", green("pass"));
871        }
872        GateStatus::Passed | GateStatus::Failed => {
873            let _ = writeln!(s, "\n{}", bold("gate"));
874            for o in &state.gate {
875                let _ = writeln!(
876                    s,
877                    "  {}  {}",
878                    if o.ok() { green("pass") } else { red("FAIL") },
879                    o.command
880                );
881                if !o.ok() {
882                    let _ = writeln!(s, "{}", dim(&tail(&o.output_tail, 2_000)));
883                }
884            }
885        }
886    }
887
888    if let Some(m) = &state.merge {
889        let _ = writeln!(s, "\n{}", bold("merge"));
890        if m.mode == MergeMode::None {
891            // `ok: true` here means "magi did nothing, as configured", not
892            // "landed" — a green `ok` next to a shell command reads as done,
893            // and the branch is still sitting unmerged.
894            let _ = writeln!(
895                s,
896                "  mode None  {}",
897                cyan("not landed — nothing to do by design")
898            );
899            if let Some(w) = state.winner() {
900                let _ = writeln!(
901                    s,
902                    "  branch {} still exists, unmerged into {}",
903                    w.branch, state.base_branch
904                );
905            }
906            // The squash caveat only applies to that one style: `--no-ff` and
907            // `--ff-only` never inherit a candidate's placeholder subject,
908            // since neither ever discards the pull request body `message`
909            // that `manual_merge_command` (graph.rs) already puts on the
910            // squash commit's `-m`.
911            let _ = writeln!(
912                s,
913                "  rebase onto {} before merging by hand{}",
914                state.base_branch,
915                if state.config.merge.style == MergeStyle::Squash {
916                    ", and pass an explicit commit message — a squash merge \
917                     otherwise inherits the candidate's placeholder subject"
918                } else {
919                    ""
920                }
921            );
922            let _ = writeln!(s, "  {}", m.detail.lines().next().unwrap_or(""));
923        } else {
924            let _ = writeln!(
925                s,
926                "  mode {:?}  {}\n  {}",
927                m.mode,
928                if m.ok {
929                    green("ok")
930                } else {
931                    yellow("not merged")
932                },
933                m.detail.lines().next().unwrap_or("")
934            );
935        }
936    }
937
938    if let Some(b) = &state.release_bump {
939        let _ = writeln!(s, "\n{}", bold("release bump"));
940        if let Some(v) = &b.version {
941            let _ = writeln!(s, "  version v{v}");
942        }
943        if let Some(url) = &b.pr_url {
944            let _ = writeln!(s, "  pr {url}");
945        }
946        let _ = writeln!(
947            s,
948            "  automerge {}",
949            if b.automerge_enabled {
950                green("enabled")
951            } else if b.merged_directly {
952                green("not needed (CI was already green; merged directly)")
953            } else if b.problem.is_some() {
954                bold(&red("FAILED"))
955            } else {
956                dim("not enabled")
957            }
958        );
959        if let Some(p) = &b.problem {
960            let _ = writeln!(s, "  {}", p.lines().next().unwrap_or(""));
961        }
962        if let Some(a) = &b.action_required {
963            let _ = writeln!(s, "  {} {a}", bold(&yellow("action required:")));
964        }
965    }
966
967    if !state.leaks.is_empty() {
968        let _ = writeln!(s, "\n{}", bold(&yellow("blindness warnings")));
969        for l in &state.leaks {
970            let _ = writeln!(s, "  {} x{} in {}", l.token, l.count, l.site);
971        }
972    }
973
974    if let Some(w) = state.winner()
975        && !w.folded
976    {
977        let _ = writeln!(
978            s,
979            "\n{} {}\n  branch {}",
980            bold("winner worktree"),
981            w.worktree.display(),
982            w.branch
983        );
984    }
985    s.push_str(&jobs_section(state));
986    s
987}
988
989/// The seats currently mid-answer, for `magi show` and the raw report route.
990///
991/// Separate from [`run`] on purpose: [`run`] is printed straight after `magi
992/// run` / `magi review`'s own `execute()`, and by then this process has
993/// nothing left in flight to report; the TUI does not track daemon liveness
994/// either. Only a caller reading someone *else's* run — `magi show <id>`, or
995/// the web UI's raw-report route — needs this, and both already know how to
996/// ask whether a daemon is currently driving it.
997///
998/// `live` is [`RunState::liveness`]: whether a daemon's heartbeat currently
999/// names this run, or — absent that claim — whether `driver_pid` still
1000/// answers alive. An [`ActiveSeat`](crate::run::ActiveSeat) left behind by a
1001/// killed process is not lied about as running just because nobody has
1002/// cleared it from disk yet — see that type's own docs for why an entry
1003/// alone is not proof of anything.
1004pub fn active_seats(state: &RunState, live: Liveness) -> String {
1005    if state.active.is_empty() {
1006        return String::new();
1007    }
1008    let mut s = String::new();
1009    let _ = writeln!(s, "\n{}", bold("running now"));
1010    let now = jiff::Timestamp::now();
1011    match live {
1012        Liveness::Live => {}
1013        Liveness::Dead => {
1014            let _ = writeln!(
1015                s,
1016                "  {}",
1017                yellow(
1018                    "no live daemon claims this run right now — likely left behind by a killed process"
1019                )
1020            );
1021        }
1022        Liveness::Unknown => {
1023            // `active_all_overrun` is never treated as proof of death here —
1024            // only ever mentioned alongside "could not confirm", since a
1025            // seat legitimately overrunning its budget while the process
1026            // driving it tears the attempt down looks identical on disk (see
1027            // `RunState::active_all_overrun`'s own doc).
1028            let overrun = if state.active_all_overrun(now) {
1029                " — every active seat has already run past its own timeout budget"
1030            } else {
1031                ""
1032            };
1033            let _ = writeln!(
1034                s,
1035                "  {}",
1036                yellow(&format!(
1037                    "whether a process is still driving this run could not be confirmed{overrun}"
1038                ))
1039            );
1040        }
1041    }
1042    for (seat, a) in state.seats_active() {
1043        let retry = if a.attempt > 0 {
1044            format!(" retry {}", a.attempt)
1045        } else {
1046            String::new()
1047        };
1048        let _ = writeln!(
1049            s,
1050            "  {:<12} {:<12}{retry}  {}s elapsed, {}s left of {}s",
1051            seat,
1052            a.node,
1053            a.elapsed_secs(now),
1054            a.remaining_secs(now),
1055            a.timeout_secs
1056        );
1057    }
1058    for (task, a) in state.tasks_active() {
1059        let retry = if a.attempt > 0 {
1060            format!(" retry {}", a.attempt)
1061        } else {
1062            String::new()
1063        };
1064        let progress = match (a.index, a.total) {
1065            (Some(i), Some(t)) => format!(" ({i}/{t})"),
1066            _ => String::new(),
1067        };
1068        let _ = writeln!(
1069            s,
1070            "  {:<12} {:<12}{retry}{progress}  {}s elapsed, {}s left of {}s",
1071            task,
1072            a.node,
1073            a.elapsed_secs(now),
1074            a.remaining_secs(now),
1075            a.timeout_secs
1076        );
1077        if let Some(command) = &a.command {
1078            let _ = writeln!(s, "               {command}");
1079        }
1080    }
1081    s
1082}
1083
1084/// Render a whole number of seconds as `1h02m`, `3m05s` or `42s`.
1085fn fmt_secs(secs: i64) -> String {
1086    let secs = secs.max(0);
1087    let h = secs / 3600;
1088    let m = (secs % 3600) / 60;
1089    let s = secs % 60;
1090    if h > 0 {
1091        format!("{h}h{m:02}m")
1092    } else if m > 0 {
1093        format!("{m}m{s:02}s")
1094    } else {
1095        format!("{s}s")
1096    }
1097}
1098
1099/// A fixed-width text bar, `value` proportional to `max` out of `width` cells.
1100///
1101/// Any positive value draws at least one cell, so a short-but-nonzero
1102/// duration is never mistaken for an unmeasured one.
1103fn bar(value: f64, max: f64, width: usize) -> String {
1104    if max <= 0.0 || value <= 0.0 {
1105        return String::new();
1106    }
1107    let cells = ((value / max) * width as f64)
1108        .round()
1109        .clamp(1.0, width as f64) as usize;
1110    "█".repeat(cells)
1111}
1112
1113/// Per-repository summary table: repo name, run count, completion rate.
1114///
1115/// `main.rs`'s `Command::Stats` is what decides *whether* to print this —
1116/// only ahead of the plain (no `--repo`) report, and only when `repos.len() >
1117/// 1` — this function only renders whatever it is handed.
1118pub fn repo_summary(repos: &[RepoStats]) -> String {
1119    let mut s = String::new();
1120    let _ = writeln!(s, "{}", bold("repos"));
1121
1122    // Two different checkouts can share a leaf directory name (`magi` under
1123    // two different roots); disambiguate only those with their parent
1124    // directory rather than paying the extra noise on every row.
1125    let mut name_counts: std::collections::HashMap<&str, usize> = std::collections::HashMap::new();
1126    for r in repos {
1127        *name_counts.entry(r.name.as_str()).or_insert(0) += 1;
1128    }
1129
1130    for r in repos {
1131        let label = if name_counts.get(r.name.as_str()).copied().unwrap_or(0) > 1 {
1132            match r.repo.parent().and_then(|p| p.file_name()) {
1133                Some(parent) => format!("{} ({})", r.name, parent.to_string_lossy()),
1134                None => r.name.clone(),
1135            }
1136        } else {
1137            r.name.clone()
1138        };
1139        let _ = writeln!(
1140            s,
1141            "  {}  {} runs  {:.0}% completion",
1142            label,
1143            r.stats.totals.runs,
1144            r.stats.totals.completion_rate()
1145        );
1146    }
1147    s
1148}
1149
1150/// Aggregate tables, for `magi stats`.
1151pub fn stats(stats: &Stats) -> String {
1152    let t = &stats.totals;
1153    let mut s = String::new();
1154    let _ = writeln!(s, "{}", bold("runs"));
1155    let _ = writeln!(
1156        s,
1157        "  {} total - {} merged, {} ready, {} blocked, {} failed ({:.0}% completion)",
1158        t.runs,
1159        t.merged,
1160        t.ready,
1161        t.blocked,
1162        t.failed,
1163        t.completion_rate()
1164    );
1165    if t.tallied > 0 {
1166        let _ = writeln!(
1167            s,
1168            "  {} tallied - {} split on first choice ({:.0}%), {} deliberated, \
1169             {} of those changed a mind, {} converged to unanimous",
1170            t.tallied,
1171            t.split,
1172            t.split_rate(),
1173            t.deliberated,
1174            t.minds_changed,
1175            t.converged
1176        );
1177    }
1178
1179    if !stats.agents.is_empty() {
1180        let _ = writeln!(
1181            s,
1182            "\n{}",
1183            bold("implementation (relative, on this workload)")
1184        );
1185        let _ = writeln!(
1186            s,
1187            "  {:<14}{:>6}{:>8}{:>8}{:>8}",
1188            "agent", "won", "entered", "rate", "empty"
1189        );
1190        for a in &stats.agents {
1191            let _ = writeln!(
1192                s,
1193                "  {:<14}{:>6}{:>8}{:>7.0}%{:>8}",
1194                a.agent,
1195                a.wins,
1196                a.entered,
1197                a.win_rate(),
1198                a.empty
1199            );
1200        }
1201    }
1202
1203    if !stats.reviewers.is_empty() {
1204        let _ = writeln!(s, "\n{}", bold("review"));
1205        let _ = writeln!(
1206            s,
1207            "  {:<14}{:>8}{:>10}{:>11}{:>9}{:>9}{:>9}",
1208            "reviewer", "rounds", "submitted", "adopted/rd", "precision", "unique", "timeout"
1209        );
1210        for r in &stats.reviewers {
1211            let _ = writeln!(
1212                s,
1213                "  {:<14}{:>8}{:>10}{:>11.2}{:>8.0}%{:>8.0}%{:>8.0}%",
1214                r.agent,
1215                r.rounds,
1216                r.submitted,
1217                r.adopted_per_round(),
1218                r.precision(),
1219                r.unique_rate(),
1220                r.timeout_rate()
1221            );
1222        }
1223    }
1224
1225    if !stats.advisors.is_empty() {
1226        let _ = writeln!(
1227            s,
1228            "\n{} {}",
1229            bold("design deliberation"),
1230            dim(
1231                "(approximate: reflection is read off word overlap with the synthesis brief, not a precise attribution)"
1232            )
1233        );
1234        let _ = writeln!(
1235            s,
1236            "  {:<14}{:>7}{:>10}{:>8}{:>8}{:>9}{:>10}",
1237            "advisor", "seats", "proposed", "strong", "faint", "absent", "reflect%"
1238        );
1239        for a in &stats.advisors {
1240            let _ = writeln!(
1241                s,
1242                "  {:<14}{:>7}{:>10}{:>8}{:>8}{:>9}{:>9.0}%",
1243                a.agent,
1244                a.seated,
1245                a.proposed,
1246                a.strong,
1247                a.faint,
1248                a.absent,
1249                a.reflection_rate()
1250            );
1251        }
1252    }
1253
1254    if stats.release_bumps.merged > 0 {
1255        let b = &stats.release_bumps;
1256        let _ = writeln!(s, "\n{}", bold("release bumps"));
1257        let _ = writeln!(
1258            s,
1259            "  {} of {} merged run(s) recorded a bump ({:.0}%)",
1260            b.recorded,
1261            b.merged,
1262            b.coverage_rate()
1263        );
1264        let _ = writeln!(
1265            s,
1266            "  {} release PR(s) opened, {} automerge enabled ({:.0}%), {} merged directly",
1267            b.pr_opened,
1268            b.automerge_enabled,
1269            b.automerge_rate(),
1270            b.merged_directly
1271        );
1272        let _ = writeln!(
1273            s,
1274            "  {} clean, {} needed a human ({:.0}%)",
1275            b.clean(),
1276            b.needs_attention,
1277            b.attention_rate()
1278        );
1279    }
1280
1281    if stats.e2e.rounds > 0 || stats.e2e.deferred > 0 {
1282        let _ = writeln!(s, "\n{}", bold("verification"));
1283        let _ = writeln!(
1284            s,
1285            "  {} rounds ran e2e, {} failed, {} of those with a clean static \
1286             review ({:.0}% sole detections), {} round(s) deferred it to the fixer",
1287            stats.e2e.rounds,
1288            stats.e2e.failures,
1289            stats.e2e.sole_detections,
1290            stats.e2e.sole_rate(),
1291            stats.e2e.deferred
1292        );
1293    }
1294
1295    if !stats.nodes.is_empty() {
1296        let _ = writeln!(
1297            s,
1298            "\n{}",
1299            bold("node durations (first to last event, per run)")
1300        );
1301        let max_mean = stats
1302            .nodes
1303            .iter()
1304            .map(|n| n.mean_secs())
1305            .fold(0.0_f64, f64::max);
1306        for n in &stats.nodes {
1307            let unmeasured = if n.single > 0 {
1308                format!("  {}", dim(&format!("{} unmeasured", n.single)))
1309            } else {
1310                String::new()
1311            };
1312            let _ = writeln!(
1313                s,
1314                "  {:<14}{:>6} runs{:>8} mean{:>8} max  {}{unmeasured}",
1315                n.node,
1316                n.runs,
1317                fmt_secs(n.mean_secs().round() as i64),
1318                fmt_secs(n.max_secs),
1319                bar(n.mean_secs(), max_mean, 20)
1320            );
1321        }
1322    }
1323    s
1324}
1325
1326#[cfg(test)]
1327mod tests {
1328    use super::*;
1329    use crate::config::Config;
1330    use crate::run::{
1331        Candidate, CommandOutcome, FixRecord, MergeOutcome, ReviewRecord, ReviewRound, RunState,
1332        Tally,
1333    };
1334    use std::collections::BTreeMap;
1335    use std::path::PathBuf;
1336    use std::sync::{Mutex, MutexGuard};
1337
1338    /// `COLOR` is process-global, so these tests cannot run concurrently.
1339    static SERIAL: Mutex<()> = Mutex::new(());
1340
1341    fn plain() -> MutexGuard<'static, ()> {
1342        let guard = SERIAL.lock().unwrap_or_else(|e| e.into_inner());
1343        set_color(false);
1344        guard
1345    }
1346
1347    fn state() -> RunState {
1348        // `run()` prints `state.dir()`, which reads the process-global home;
1349        // pinning it here keeps this test off the operator's real one. The
1350        // directory itself is never read, only its path printed, so nothing
1351        // needs to create or clean it up.
1352        crate::run::set_home(std::env::temp_dir().join("magi-report-test-home"));
1353        let mut s = RunState::new(
1354            PathBuf::from("/repo"),
1355            "main".to_owned(),
1356            "abcdef1234".to_owned(),
1357            "add retries to the uploader".to_owned(),
1358            Config::default(),
1359        );
1360        s.candidates = vec![Candidate {
1361            index: 0,
1362            label: 'A',
1363            agent: "opus".to_owned(),
1364            branch: "magi/x/A".to_owned(),
1365            worktree: PathBuf::from("/wt/A"),
1366            summary: String::new(),
1367            stat: String::new(),
1368            files: 3,
1369            commits: 2,
1370            empty: false,
1371            failed: None,
1372            verified_noop: None,
1373            duration_ms: 42_000,
1374            folded: false,
1375        }];
1376        s.tally = Some(Tally {
1377            first_choice: BTreeMap::from([('A', 3)]),
1378            borda: BTreeMap::new(),
1379            winner: 'A',
1380            rankings: 3,
1381            unanimous_initial: true,
1382            deliberated: false,
1383            changed_votes: 0,
1384            unanimous_final: true,
1385            tie_break: None,
1386            judges: 3,
1387            present: 3,
1388            quorum: 2,
1389            met_quorum: true,
1390            uncontested: None,
1391        });
1392        s
1393    }
1394
1395    #[test]
1396    fn run_report_names_the_winner_and_its_author() {
1397        let _guard = plain();
1398        let text = run(&state());
1399        assert!(text.contains("<- winner"), "{text}");
1400        assert!(text.contains("opus"));
1401        assert!(text.contains("3 files, 2 commits"));
1402        assert!(text.contains("winner        A"));
1403        assert!(!text.contains('\x1b'), "colour leaked into a plain render");
1404    }
1405
1406    #[test]
1407    fn a_candidates_own_summary_is_surfaced_not_only_kept_in_run_json() {
1408        // Recorded on every run (`prompt::implement`'s `## SUMMARY`), but
1409        // `run()` used to never print it at all — silent even when the
1410        // summary was the one place an implementer explained itself (e.g.
1411        // an investigation task's findings), and readable only by opening
1412        // `run.json` by hand.
1413        let _guard = plain();
1414        let mut s = state();
1415        s.candidates[0].summary =
1416            "investigated 6c5e/8df3: both already merged, see talk 07fe.\nmore detail below."
1417                .to_owned();
1418        let text = run(&s);
1419        assert!(
1420            text.contains("investigated 6c5e/8df3: both already merged, see talk 07fe."),
1421            "{text}"
1422        );
1423    }
1424
1425    #[test]
1426    fn a_verified_noop_run_does_not_read_as_a_failure() {
1427        // Same spirit as `a_mode_none_merge_does_not_read_as_landed`: a run
1428        // that settled without landing anything must not be misreadable as
1429        // the ordinary failure it is not.
1430        let _guard = plain();
1431        let mut s = state();
1432        s.status = RunStatus::VerifiedNoop;
1433        s.tally = None;
1434        s.candidates = vec![Candidate {
1435            index: 0,
1436            label: 'A',
1437            agent: "opus".to_owned(),
1438            branch: "magi/x/A".to_owned(),
1439            worktree: PathBuf::from("/wt/A"),
1440            summary: String::new(),
1441            stat: String::new(),
1442            files: 0,
1443            commits: 0,
1444            empty: true,
1445            failed: None,
1446            verified_noop: Some("already fixed by b32cfc4, which is on main".to_owned()),
1447            duration_ms: 9_000,
1448            folded: false,
1449        }];
1450        let text = run(&s);
1451        assert!(
1452            text.contains("agent-verified no-op"),
1453            "the status and the candidate flag must both say so: {text}"
1454        );
1455        assert!(
1456            text.contains("already fixed by b32cfc4"),
1457            "the evidence itself must be readable, not just the verdict: {text}"
1458        );
1459        assert!(
1460            !text.to_lowercase().contains("failed"),
1461            "a verified no-op must never read as the failure it is not: {text}"
1462        );
1463    }
1464
1465    #[test]
1466    fn colour_is_emitted_only_when_enabled() {
1467        let _guard = plain();
1468        set_color(true);
1469        let coloured = run(&state());
1470        set_color(false);
1471        let plain = run(&state());
1472        assert!(coloured.contains('\x1b'));
1473        assert!(!plain.contains('\x1b'));
1474        assert!(coloured.len() > plain.len());
1475    }
1476
1477    #[test]
1478    fn list_line_is_single_line() {
1479        let _guard = plain();
1480        let l = line(&state());
1481        assert_eq!(l.lines().count(), 1);
1482        assert!(l.contains("add retries"));
1483        assert!(l.contains("win A (opus)"));
1484    }
1485
1486    #[test]
1487    fn an_uncontested_run_does_not_read_as_a_collapsed_panel() {
1488        let _guard = plain();
1489        let mut s = state();
1490        s.tally = Some(Tally {
1491            first_choice: BTreeMap::from([('A', 0)]),
1492            borda: BTreeMap::new(),
1493            winner: 'A',
1494            rankings: 0,
1495            unanimous_initial: false,
1496            deliberated: false,
1497            changed_votes: 0,
1498            unanimous_final: false,
1499            tie_break: None,
1500            judges: 0,
1501            present: 0,
1502            quorum: 0,
1503            met_quorum: true,
1504            uncontested: Some(
1505                "only candidate A produced a usable change; no panel was asked".to_owned(),
1506            ),
1507        });
1508        let text = run(&s);
1509        assert!(
1510            !text.contains("0/3"),
1511            "no panel sat, so the judges line must not read as one that collapsed: {text}"
1512        );
1513        assert!(!text.contains("no usable ranking"), "{text}");
1514        assert!(!text.contains("still split"), "{text}");
1515        assert!(!text.contains("BELOW QUORUM"), "{text}");
1516        assert!(
1517            text.contains("not needed"),
1518            "the report must say judging was skipped, not silent: {text}"
1519        );
1520        assert!(text.contains("winner        A"));
1521    }
1522
1523    #[test]
1524    fn a_below_quorum_run_still_reads_as_a_collapsed_panel() {
1525        let _guard = plain();
1526        let mut s = state();
1527        s.tally = Some(Tally {
1528            first_choice: BTreeMap::from([('A', 1), ('B', 0)]),
1529            borda: BTreeMap::new(),
1530            winner: 'A',
1531            rankings: 1,
1532            unanimous_initial: false,
1533            deliberated: false,
1534            changed_votes: 0,
1535            unanimous_final: false,
1536            tie_break: None,
1537            judges: 3,
1538            present: 1,
1539            quorum: 2,
1540            met_quorum: false,
1541            uncontested: None,
1542        });
1543        let text = run(&s);
1544        assert!(text.contains("1/3"), "{text}");
1545        assert!(
1546            text.contains("BELOW QUORUM"),
1547            "a real collapse must still be flagged: {text}"
1548        );
1549        assert!(
1550            !text.contains("not needed"),
1551            "a collapsed panel must not be described as one that was never asked: {text}"
1552        );
1553    }
1554
1555    #[test]
1556    fn a_mode_none_merge_does_not_read_as_landed() {
1557        let _guard = plain();
1558        let mut s = state();
1559        s.merge = Some(MergeOutcome {
1560            mode: crate::config::MergeMode::None,
1561            ok: true,
1562            detail: "git -C /repo merge --no-ff magi/x/A".to_owned(),
1563        });
1564        let text = run(&s);
1565        assert!(
1566            !text.contains("  ok"),
1567            "mode none must not be shown as a landed merge: {text}"
1568        );
1569        assert!(text.contains("not landed"), "{text}");
1570        assert!(
1571            text.contains("branch magi/x/A"),
1572            "the report must say what's left behind: {text}"
1573        );
1574        assert!(
1575            text.contains("rebase"),
1576            "the report must point at the hand-landing steps: {text}"
1577        );
1578        assert!(
1579            !text.contains("placeholder subject"),
1580            "the default merge style is `merge`, which never inherits a \
1581             placeholder subject, so the squash caveat must not appear: {text}"
1582        );
1583    }
1584
1585    #[test]
1586    fn a_mode_none_squash_merge_warns_about_the_placeholder_subject() {
1587        let _guard = plain();
1588        let mut s = state();
1589        s.config.merge.style = MergeStyle::Squash;
1590        s.merge = Some(MergeOutcome {
1591            mode: crate::config::MergeMode::None,
1592            ok: true,
1593            detail: "git -C /repo merge --squash magi/x/A && git -C /repo commit -m \"add \
1594                      retries\""
1595                .to_owned(),
1596        });
1597        let text = run(&s);
1598        assert!(
1599            text.contains("placeholder subject"),
1600            "a squash-style manual merge must warn about the missing message: {text}"
1601        );
1602        assert!(text.contains("--squash"), "{text}");
1603    }
1604
1605    #[test]
1606    fn a_ready_run_left_by_merge_mode_none_does_not_read_as_a_plain_ready() {
1607        let _guard = plain();
1608        let mut s = state();
1609        s.status = RunStatus::Ready;
1610        s.merge = Some(MergeOutcome {
1611            mode: crate::config::MergeMode::None,
1612            ok: true,
1613            detail: "git -C /repo merge --no-ff magi/x/A".to_owned(),
1614        });
1615
1616        let list = line(&s);
1617        assert!(
1618            !list.contains(" ready "),
1619            "a mode-none run must not read as a plain ready in `magi list`: {list}"
1620        );
1621        assert!(list.contains("no-op by design"), "{list}");
1622
1623        let full = run(&s);
1624        assert!(
1625            !full.contains("magi run") || !full.lines().next().unwrap().contains(" ready"),
1626            "the header line of `magi show` must not say plain ready either: {full}"
1627        );
1628        assert!(full.contains("no-op by design"), "{full}");
1629    }
1630
1631    #[test]
1632    fn an_ordinary_ready_run_still_reads_as_ready() {
1633        let _guard = plain();
1634        let mut s = state();
1635        s.status = RunStatus::Ready;
1636        // A PR closed without merging also ends at `Ready` (see `land.rs`),
1637        // and unlike the honest mode-none no-op it must keep reading as a
1638        // plain `ready` — the label exists to flag design, not every non-merge.
1639        s.merge = Some(MergeOutcome {
1640            mode: crate::config::MergeMode::Pr,
1641            ok: false,
1642            detail: "https://example.com/pr/1 was closed without merging".to_owned(),
1643        });
1644
1645        let list = line(&s);
1646        assert!(list.contains("ready"), "{list}");
1647        assert!(!list.contains("no-op by design"), "{list}");
1648    }
1649
1650    #[test]
1651    fn the_list_line_does_not_flag_an_uncontested_run_as_short_judges() {
1652        let _guard = plain();
1653        let mut s = state();
1654        s.tally = Some(Tally {
1655            first_choice: BTreeMap::from([('A', 0)]),
1656            borda: BTreeMap::new(),
1657            winner: 'A',
1658            rankings: 0,
1659            unanimous_initial: false,
1660            deliberated: false,
1661            changed_votes: 0,
1662            unanimous_final: false,
1663            tie_break: None,
1664            judges: 0,
1665            present: 0,
1666            quorum: 0,
1667            met_quorum: true,
1668            uncontested: Some("only candidate A produced a usable change".to_owned()),
1669        });
1670        let l = line(&s);
1671        assert!(
1672            !l.contains("judges") && !l.contains("quorum"),
1673            "an uncontested run must not carry the same badge a short panel gets: {l}"
1674        );
1675    }
1676
1677    #[test]
1678    fn long_instructions_are_elided() {
1679        let _guard = plain();
1680        let mut s = state();
1681        s.instruction = "x".repeat(200);
1682        assert!(line(&s).contains('…'));
1683    }
1684
1685    #[test]
1686    fn a_lost_fix_report_reads_differently_from_zero_adoption() {
1687        let _guard = plain();
1688        let mut lost = state();
1689        lost.reviews = vec![ReviewRound {
1690            round: 1,
1691            head: "abc1234".to_owned(),
1692            verified_head: None,
1693            verified_at: None,
1694            reviews: Vec::new(),
1695            e2e: Vec::new(),
1696            verify_retried: false,
1697            e2e_deferred: false,
1698            e2e_defer_reason: None,
1699            fix: Some(FixRecord {
1700                agent: "opus".to_owned(),
1701                addressed: Vec::new(),
1702                rejected: Vec::new(),
1703                notes: String::new(),
1704                committed: true,
1705                failed: Some("timed out".to_owned()),
1706                duration_ms: 0,
1707                continuation: None,
1708            }),
1709            blocking: 3,
1710            answered: 0,
1711            expected: 0,
1712            clean: false,
1713            progressed: false,
1714            vote_split: false,
1715            reconsideration: Vec::new(),
1716            verdict: None,
1717        }];
1718        let text = run(&lost);
1719        assert!(text.contains("adoption report lost (timed out)"), "{text}");
1720        assert!(
1721            !text.contains("0 addressed"),
1722            "a lost report must never read as `0 addressed`: {text}"
1723        );
1724
1725        let mut rejected_all = state();
1726        rejected_all.reviews = vec![ReviewRound {
1727            round: 1,
1728            head: "abc1234".to_owned(),
1729            verified_head: None,
1730            verified_at: None,
1731            reviews: Vec::new(),
1732            e2e: Vec::new(),
1733            verify_retried: false,
1734            e2e_deferred: false,
1735            e2e_defer_reason: None,
1736            fix: Some(FixRecord {
1737                agent: "opus".to_owned(),
1738                addressed: Vec::new(),
1739                rejected: Vec::new(),
1740                notes: String::new(),
1741                committed: true,
1742                failed: None,
1743                duration_ms: 0,
1744                continuation: None,
1745            }),
1746            blocking: 3,
1747            answered: 0,
1748            expected: 0,
1749            clean: false,
1750            progressed: false,
1751            vote_split: false,
1752            reconsideration: Vec::new(),
1753            verdict: None,
1754        }];
1755        let text2 = run(&rejected_all);
1756        assert!(
1757            text2.contains("0 addressed / 0 rejected"),
1758            "a round the fixer actually reported on keeps the count: {text2}"
1759        );
1760    }
1761
1762    #[test]
1763    fn a_split_round_shows_every_seat_vote_and_the_reconsideration() {
1764        use crate::run::ReviewRevoteRecord;
1765        use crate::verdict::ReviewVote;
1766
1767        let _guard = plain();
1768        let mut s = state();
1769        s.reviews = vec![ReviewRound {
1770            round: 1,
1771            head: "abc1234".to_owned(),
1772            verified_head: None,
1773            verified_at: None,
1774            reviews: vec![
1775                ReviewRecord {
1776                    attempts: 0,
1777                    reviewer: 1,
1778                    agent: "alpha".to_owned(),
1779                    summary: String::new(),
1780                    findings: Vec::new(),
1781                    vote: Some(ReviewVote::Approve),
1782                    failed: None,
1783                    duration_ms: 0,
1784                },
1785                ReviewRecord {
1786                    attempts: 0,
1787                    reviewer: 2,
1788                    agent: "beta".to_owned(),
1789                    summary: String::new(),
1790                    findings: Vec::new(),
1791                    vote: Some(ReviewVote::Reject),
1792                    failed: None,
1793                    duration_ms: 0,
1794                },
1795            ],
1796            e2e: Vec::new(),
1797            verify_retried: false,
1798            e2e_deferred: false,
1799            e2e_defer_reason: None,
1800            fix: None,
1801            blocking: 0,
1802            answered: 2,
1803            expected: 2,
1804            clean: false,
1805            progressed: false,
1806            vote_split: true,
1807            reconsideration: vec![ReviewRevoteRecord {
1808                reviewer: 2,
1809                agent: "beta".to_owned(),
1810                vote: Some(ReviewVote::ApproveWithFindings),
1811                reason: "the other seat's read holds up".to_owned(),
1812                failed: None,
1813            }],
1814            verdict: Some(ReviewVote::ApproveWithFindings),
1815        }];
1816        let text = run(&s);
1817        assert!(text.contains("review-1 vote"), "{text}");
1818        assert!(text.contains("review-2 vote"), "{text}");
1819        assert!(text.contains("panel split"), "{text}");
1820        assert!(text.contains("reconsideration"), "{text}");
1821        assert!(text.contains("the other seat's read holds up"), "{text}");
1822    }
1823
1824    #[test]
1825    fn an_incomplete_panel_and_a_lost_fix_report_both_stay_on_the_round_line() {
1826        // Two independent facts share this one line, and each arrived from a
1827        // different change: a seat that never answered, and a fixer whose
1828        // adoption report was lost. Rendering either must not shadow the
1829        // other, and neither may collapse into the plain `clean`/`open`
1830        // pair the line used to carry.
1831        let _guard = plain();
1832        let mut s = state();
1833        s.reviews = vec![ReviewRound {
1834            round: 1,
1835            head: "abc1234".to_owned(),
1836            verified_head: None,
1837            verified_at: None,
1838            reviews: vec![
1839                ReviewRecord {
1840                    attempts: 0,
1841                    reviewer: 1,
1842                    agent: "alpha".to_owned(),
1843                    summary: String::new(),
1844                    findings: Vec::new(),
1845                    vote: None,
1846                    failed: None,
1847                    duration_ms: 0,
1848                },
1849                ReviewRecord {
1850                    attempts: 0,
1851                    reviewer: 2,
1852                    agent: "beta".to_owned(),
1853                    summary: String::new(),
1854                    findings: Vec::new(),
1855                    vote: None,
1856                    failed: Some("agent timed out".to_owned()),
1857                    duration_ms: 0,
1858                },
1859            ],
1860            e2e: Vec::new(),
1861            verify_retried: false,
1862            e2e_deferred: false,
1863            e2e_defer_reason: None,
1864            fix: Some(FixRecord {
1865                agent: "opus".to_owned(),
1866                addressed: Vec::new(),
1867                rejected: Vec::new(),
1868                notes: String::new(),
1869                committed: true,
1870                failed: Some("timed out".to_owned()),
1871                duration_ms: 0,
1872                continuation: None,
1873            }),
1874            blocking: 0,
1875            answered: 1,
1876            expected: 2,
1877            clean: false,
1878            progressed: true,
1879            vote_split: false,
1880            reconsideration: Vec::new(),
1881            verdict: None,
1882        }];
1883        let text = run(&s);
1884        assert!(text.contains("incomplete"), "{text}");
1885        assert!(text.contains("1/2 reviewers answered"), "{text}");
1886        assert!(text.contains("review-2: agent timed out"), "{text}");
1887        assert!(text.contains("adoption report lost (timed out)"), "{text}");
1888        assert!(
1889            !text.contains("clean"),
1890            "a round missing half its panel must never render as clean: {text}"
1891        );
1892    }
1893
1894    #[test]
1895    fn a_build_failure_is_not_reported_as_a_test_failure() {
1896        let _guard = plain();
1897        let mut s = state();
1898        s.reviews = vec![ReviewRound {
1899            round: 1,
1900            head: "abc1234".to_owned(),
1901            verified_head: None,
1902            verified_at: None,
1903            reviews: Vec::new(),
1904            e2e: vec![CommandOutcome {
1905                command: "cargo test".to_owned(),
1906                code: Some(1),
1907                output_tail: "LINK : fatal error LNK1104: cannot open file".to_owned(),
1908                duration_ms: 100,
1909                resource_blocked: false,
1910            }],
1911            verify_retried: true,
1912            e2e_deferred: false,
1913            e2e_defer_reason: None,
1914            fix: None,
1915            blocking: 0,
1916            answered: 0,
1917            expected: 0,
1918            clean: false,
1919            progressed: false,
1920            vote_split: false,
1921            reconsideration: Vec::new(),
1922            verdict: None,
1923        }];
1924        let text = run(&s);
1925        assert!(text.contains("could not run"), "{text}");
1926        assert!(text.contains("retried once"), "{text}");
1927        assert!(!text.contains("e2e RED"), "{text}");
1928    }
1929
1930    #[test]
1931    fn a_resource_blocked_e2e_never_reads_as_red_or_as_a_build_failure() {
1932        let _guard = plain();
1933        let mut s = state();
1934        s.reviews = vec![ReviewRound {
1935            round: 1,
1936            head: "abc1234".to_owned(),
1937            verified_head: None,
1938            verified_at: None,
1939            reviews: Vec::new(),
1940            e2e: vec![CommandOutcome {
1941                command: "(waiting for the shared build cache)".to_owned(),
1942                code: None,
1943                output_tail: "held by run x node e2e seat e2e".to_owned(),
1944                duration_ms: 100,
1945                resource_blocked: true,
1946            }],
1947            verify_retried: false,
1948            e2e_deferred: false,
1949            e2e_defer_reason: None,
1950            fix: None,
1951            blocking: 0,
1952            answered: 0,
1953            expected: 0,
1954            clean: false,
1955            progressed: false,
1956            vote_split: false,
1957            reconsideration: Vec::new(),
1958            verdict: None,
1959        }];
1960        let text = run(&s);
1961        assert!(text.contains("shared build cache unavailable"), "{text}");
1962        assert!(!text.contains("e2e RED"), "{text}");
1963        assert!(!text.contains("build/link failure"), "{text}");
1964    }
1965
1966    #[test]
1967    fn a_round_with_more_than_one_e2e_command_names_each_one() {
1968        // The aggregate `e2e RED` label says the round's overall verdict,
1969        // never which of several `verify.e2e` commands actually failed —
1970        // `magi show` must list each command by name, the same way it
1971        // already does for `gate`.
1972        let _guard = plain();
1973        let mut s = state();
1974        s.reviews = vec![ReviewRound {
1975            round: 1,
1976            head: "abc1234".to_owned(),
1977            verified_head: Some("abc1234".to_owned()),
1978            verified_at: Some(jiff::Timestamp::now()),
1979            reviews: Vec::new(),
1980            e2e: vec![
1981                CommandOutcome {
1982                    command: "cargo test --locked --all-targets".to_owned(),
1983                    code: Some(0),
1984                    output_tail: String::new(),
1985                    duration_ms: 0,
1986                    resource_blocked: false,
1987                },
1988                CommandOutcome {
1989                    command: "cargo make check".to_owned(),
1990                    code: Some(1),
1991                    output_tail: "clippy: unused import".to_owned(),
1992                    duration_ms: 0,
1993                    resource_blocked: false,
1994                },
1995            ],
1996            verify_retried: false,
1997            e2e_deferred: false,
1998            e2e_defer_reason: None,
1999            fix: None,
2000            blocking: 0,
2001            answered: 0,
2002            expected: 0,
2003            clean: false,
2004            progressed: false,
2005            vote_split: false,
2006            reconsideration: Vec::new(),
2007            verdict: None,
2008        }];
2009        let text = run(&s);
2010        assert!(text.contains("cargo test --locked --all-targets"), "{text}");
2011        assert!(text.contains("cargo make check"), "{text}");
2012        assert!(text.contains("clippy: unused import"), "{text}");
2013    }
2014
2015    #[test]
2016    fn a_declined_finding_shows_its_reason() {
2017        use crate::verdict::{Finding, Rejection, Severity};
2018
2019        let _guard = plain();
2020        let mut s = state();
2021        s.status = RunStatus::Ready;
2022        s.reviews = vec![ReviewRound {
2023            round: 1,
2024            head: "deadbee".to_owned(),
2025            verified_head: None,
2026            verified_at: None,
2027            reviews: vec![ReviewRecord {
2028                attempts: 0,
2029                reviewer: 1,
2030                agent: "alpha".to_owned(),
2031                summary: String::new(),
2032                findings: vec![Finding {
2033                    id: "R1-1-1".to_owned(),
2034                    severity: Severity::Major,
2035                    file: None,
2036                    line: None,
2037                    title: "still open".to_owned(),
2038                    detail: String::new(),
2039                }],
2040                vote: None,
2041                failed: None,
2042                duration_ms: 0,
2043            }],
2044            e2e: vec![CommandOutcome {
2045                command: "cargo test".to_owned(),
2046                code: Some(0),
2047                output_tail: String::new(),
2048                duration_ms: 0,
2049                resource_blocked: false,
2050            }],
2051            verify_retried: false,
2052            e2e_deferred: false,
2053            e2e_defer_reason: None,
2054            fix: Some(FixRecord {
2055                agent: "alpha".to_owned(),
2056                addressed: Vec::new(),
2057                rejected: vec![Rejection {
2058                    id: "R1-1-2".to_owned(),
2059                    why: "cannot be triggered from any caller".to_owned(),
2060                }],
2061                notes: String::new(),
2062                committed: true,
2063                failed: None,
2064                duration_ms: 0,
2065                continuation: None,
2066            }),
2067            blocking: 1,
2068            answered: 1,
2069            expected: 1,
2070            clean: false,
2071            progressed: true,
2072            vote_split: false,
2073            reconsideration: Vec::new(),
2074            verdict: None,
2075        }];
2076
2077        let text = run(&s);
2078        assert!(text.contains("R1-1-2"), "{text}");
2079        assert!(text.contains("cannot be triggered"), "{text}");
2080        assert!(text.contains("still open"), "{text}");
2081        assert!(
2082            text.contains("handed off"),
2083            "a mergeable run with an open round must say so: {text}"
2084        );
2085    }
2086
2087    #[test]
2088    fn a_failing_gate_command_shows_its_output() {
2089        let _guard = plain();
2090        let mut s = state();
2091        s.status = RunStatus::Blocked;
2092        s.gate = vec![CommandOutcome {
2093            command: "cargo make check".to_owned(),
2094            code: Some(101),
2095            output_tail: "error[E0308]: mismatched types".to_owned(),
2096            duration_ms: 0,
2097            resource_blocked: false,
2098        }];
2099        s.gate_ran = true;
2100
2101        let text = run(&s);
2102        assert!(text.contains("mismatched types"), "{text}");
2103    }
2104
2105    #[test]
2106    fn a_gate_with_no_commands_configured_shows_a_pass_not_silence() {
2107        let _guard = plain();
2108        let mut s = state();
2109        s.status = RunStatus::Ready;
2110        s.gate_ran = true;
2111        assert!(s.gate.is_empty());
2112
2113        let text = run(&s);
2114        assert!(
2115            text.contains("gate") && text.contains("no gate commands configured"),
2116            "a run gated on nothing must say so, not read as if the gate never ran: {text}"
2117        );
2118    }
2119
2120    #[test]
2121    fn a_gate_that_has_not_run_yet_shows_nothing() {
2122        let _guard = plain();
2123        let s = state();
2124        assert!(!s.gate_ran);
2125        assert!(s.gate.is_empty());
2126
2127        let text = run(&s);
2128        assert!(
2129            !text.contains("no gate commands configured"),
2130            "an unattempted gate must not be shown as a pass: {text}"
2131        );
2132    }
2133
2134    #[test]
2135    fn active_seats_shows_who_has_not_answered_and_how_long_is_left() {
2136        let _guard = plain();
2137        let mut s = state();
2138        s.seat_started("judge", "judge-2", std::time::Duration::from_secs(120), 0);
2139        let text = active_seats(&s, Liveness::Live);
2140        assert!(text.contains("running now"));
2141        assert!(text.contains("judge-2"));
2142        assert!(text.contains("judge"));
2143        assert!(!text.contains("no live daemon"), "{text}");
2144        assert!(!text.contains("could not be confirmed"), "{text}");
2145    }
2146
2147    #[test]
2148    fn active_seats_flags_a_leftover_from_a_dead_process() {
2149        let _guard = plain();
2150        let mut s = state();
2151        s.seat_started("implement", "impl-B", std::time::Duration::from_secs(60), 0);
2152        let text = active_seats(&s, Liveness::Dead);
2153        assert!(
2154            text.contains("no live daemon"),
2155            "a stale entry must not read as running: {text}"
2156        );
2157    }
2158
2159    #[test]
2160    fn superseded_notice_names_the_run_that_replaced_it() {
2161        let _guard = plain();
2162        let text = superseded_notice(Some("bbbb"));
2163        assert!(text.contains("SUPERSEDED"), "{text}");
2164        assert!(text.contains("bbbb"), "{text}");
2165    }
2166
2167    #[test]
2168    fn superseded_notice_is_silent_for_the_latest_attempt() {
2169        let _guard = plain();
2170        assert_eq!(superseded_notice(None), "");
2171    }
2172
2173    #[test]
2174    fn list_line_marks_a_nonterminal_run_with_a_dead_driver_stale() {
2175        let _guard = plain();
2176        let mut s = state();
2177        s.status = RunStatus::Reviewing;
2178        let text = line_with_liveness(&s, Liveness::Dead);
2179        assert!(text.contains("STALE"), "{text}");
2180        assert!(text.contains("resume required"), "{text}");
2181        assert!(liveness_notice(&s, Liveness::Dead).contains("STALE"));
2182    }
2183
2184    /// A manual `magi run` / `magi review` claims no daemon, but its
2185    /// `driver_pid` still answers — this is `Unknown`, never `Dead`: see
2186    /// `RunState::liveness`'s own doc for why an unconfirmed process is never
2187    /// folded into "confirmed dead".
2188    #[test]
2189    fn active_seats_reports_uncertainty_without_claiming_death() {
2190        let _guard = plain();
2191        let mut s = state();
2192        s.seat_started("review", "review-1", std::time::Duration::from_secs(60), 0);
2193        let text = active_seats(&s, Liveness::Unknown);
2194        assert!(
2195            text.contains("could not be confirmed"),
2196            "an unproven state must read as uncertain, not dead: {text}"
2197        );
2198        assert!(!text.contains("no live daemon"), "{text}");
2199    }
2200
2201    #[test]
2202    fn active_seats_is_empty_when_nothing_is_running() {
2203        let _guard = plain();
2204        assert_eq!(active_seats(&state(), Liveness::Live), "");
2205    }
2206
2207    /// A running `verify.e2e` / `verify.gate` task is shown alongside seats,
2208    /// with which command is currently running and how far through the list
2209    /// it is — the gap the addendum's second item names: a review-only run
2210    /// that spends minutes inside `cargo test` between reviewer answers and
2211    /// the fix's own commit had nothing at all to show for it before this.
2212    #[test]
2213    fn active_seats_shows_a_running_verify_task_and_its_command() {
2214        let _guard = plain();
2215        let mut s = state();
2216        s.task_command(
2217            "e2e",
2218            "verify",
2219            0,
2220            "cargo test",
2221            2,
2222            3,
2223            std::time::Duration::from_secs(600),
2224        );
2225        let text = active_seats(&s, Liveness::Live);
2226        assert!(text.contains("e2e"), "{text}");
2227        assert!(text.contains("(2/3)"), "{text}");
2228        assert!(text.contains("cargo test"), "{text}");
2229    }
2230
2231    #[test]
2232    fn no_jobs_section_appears_when_nothing_was_ever_collected() {
2233        let _guard = plain();
2234        // The common case today (every backend but codex): silence, not a
2235        // clutter line repeated on every single `magi show`.
2236        assert!(!run(&state()).contains("background jobs"));
2237    }
2238
2239    #[test]
2240    fn a_codex_roster_with_no_completed_jobs_yet_says_so_instead_of_staying_silent() {
2241        let _guard = plain();
2242        let mut s = state();
2243        s.config.agents.push(crate::config::AgentSpec {
2244            id: "codex-one".to_owned(),
2245            kind: crate::config::AgentKind::Codex,
2246            model: None,
2247            command: vec!["codex".to_owned()],
2248            extra_args: Vec::new(),
2249            env: BTreeMap::new(),
2250            prompt_delivery: None,
2251        });
2252        let text = run(&s);
2253        assert!(
2254            text.contains("background jobs"),
2255            "a run that could report this must not read the same as one that never could: \
2256             {text}"
2257        );
2258        assert!(text.contains("no completed command evidence yet"));
2259    }
2260
2261    #[test]
2262    fn recovered_running_and_unreadable_jobs_are_told_apart() {
2263        let _guard = plain();
2264        let mut s = state();
2265        s.jobs = vec![
2266            crate::run::JobRecord {
2267                node: "implement".to_owned(),
2268                round: None,
2269                seat: "impl-A".to_owned(),
2270                id: "item49".to_owned(),
2271                description: "cargo test --test graph_cached_gate".to_owned(),
2272                checked_at: jiff::Timestamp::now(),
2273                status: crate::run::JobStatus::Completed,
2274                exit_code: Some(0),
2275                result_summary: "test result: 2 passed; 0 failed".to_owned(),
2276                source: "codex".to_owned(),
2277            },
2278            crate::run::JobRecord {
2279                node: "fix".to_owned(),
2280                round: None,
2281                seat: "impl-A".to_owned(),
2282                id: "item52".to_owned(),
2283                description: "cargo test --test graph_split".to_owned(),
2284                checked_at: jiff::Timestamp::now(),
2285                status: crate::run::JobStatus::Failed,
2286                exit_code: Some(101),
2287                result_summary: "test result: 1 passed; 1 failed".to_owned(),
2288                source: "codex".to_owned(),
2289            },
2290            crate::run::JobRecord {
2291                node: "fix".to_owned(),
2292                round: None,
2293                seat: "impl-A".to_owned(),
2294                id: "item60".to_owned(),
2295                description: "cargo build".to_owned(),
2296                checked_at: jiff::Timestamp::now(),
2297                status: crate::run::JobStatus::Unknown,
2298                exit_code: None,
2299                result_summary: String::new(),
2300                source: "codex".to_owned(),
2301            },
2302        ];
2303        let text = run(&s);
2304        assert!(text.contains("background jobs"));
2305        assert!(text.contains("item49"));
2306        assert!(text.contains("item52"));
2307        assert!(text.contains("item60"));
2308        // The three states this run actually has evidence for must read
2309        // differently from one another — never collapsed into a single
2310        // "ran" or "did not run".
2311        assert!(text.contains("completed"));
2312        assert!(text.contains("failed"));
2313        assert!(text.contains("unknown"));
2314        // Coverage limit stated once, not fabricated per seat.
2315        assert!(text.contains("adapter coverage"));
2316    }
2317
2318    #[test]
2319    fn a_jobs_own_round_is_shown_when_known() {
2320        let _guard = plain();
2321        let mut s = state();
2322        s.jobs = vec![crate::run::JobRecord {
2323            node: "review".to_owned(),
2324            round: Some(2),
2325            seat: "review-1".to_owned(),
2326            id: "item9".to_owned(),
2327            description: "cargo test --test graph_cached_gate".to_owned(),
2328            checked_at: jiff::Timestamp::now(),
2329            status: crate::run::JobStatus::Completed,
2330            exit_code: Some(0),
2331            result_summary: "test result: 2 passed; 0 failed".to_owned(),
2332            source: "codex".to_owned(),
2333        }];
2334        let text = run(&s);
2335        assert!(
2336            text.contains("round 2"),
2337            "the round this seat's own command ran in must be visible, distinct from magi's \
2338             own recorded verify: {text}"
2339        );
2340    }
2341
2342    #[test]
2343    fn stats_table_renders_without_runs() {
2344        let _guard = plain();
2345        let text = stats(&Stats::default());
2346        assert!(text.contains("0 total"));
2347        assert!(!text.contains("implementation"));
2348        assert!(!text.contains("node durations"));
2349    }
2350
2351    #[test]
2352    fn repo_summary_lists_run_count_and_completion_rate() {
2353        let _guard = plain();
2354        let a = crate::stats::RepoStats {
2355            repo: PathBuf::from("/repos/a"),
2356            name: "a".to_owned(),
2357            stats: Stats {
2358                totals: crate::stats::Totals {
2359                    runs: 4,
2360                    merged: 2,
2361                    ready: 1,
2362                    ..Default::default()
2363                },
2364                ..Default::default()
2365            },
2366        };
2367        let text = repo_summary(&[a]);
2368        assert!(text.contains("repos"), "{text}");
2369        assert!(text.contains("a  4 runs  75% completion"), "{text}");
2370    }
2371
2372    #[test]
2373    fn repo_summary_disambiguates_colliding_names_with_the_parent_directory() {
2374        let _guard = plain();
2375        let a = crate::stats::RepoStats {
2376            repo: PathBuf::from("/roots/one/magi"),
2377            name: "magi".to_owned(),
2378            stats: Stats::default(),
2379        };
2380        let b = crate::stats::RepoStats {
2381            repo: PathBuf::from("/roots/two/magi"),
2382            name: "magi".to_owned(),
2383            stats: Stats::default(),
2384        };
2385        let text = repo_summary(&[a, b]);
2386        assert!(text.contains("magi (one)"), "{text}");
2387        assert!(text.contains("magi (two)"), "{text}");
2388    }
2389
2390    #[test]
2391    fn stats_table_renders_advisor_reflection() {
2392        let _guard = plain();
2393        let st = Stats {
2394            advisors: vec![crate::stats::AdvisorStats {
2395                agent: "alpha".to_owned(),
2396                seated: 3,
2397                proposed: 2,
2398                absent: 1,
2399                faint: 1,
2400                strong: 1,
2401            }],
2402            ..Default::default()
2403        };
2404        let text = stats(&st);
2405        assert!(text.contains("design deliberation"));
2406        assert!(
2407            text.contains("approximate"),
2408            "must note the heuristic: {text}"
2409        );
2410        assert!(text.contains("alpha"));
2411        assert!(text.contains("50%"));
2412    }
2413
2414    #[test]
2415    fn stats_table_shows_release_bump_coverage_even_when_nothing_was_recorded() {
2416        // A repository that has merged runs but never wired up (or never hit)
2417        // the release-bump step must still show "0 of N merged runs recorded
2418        // a bump" - hiding the whole section on `recorded == 0` would make
2419        // that gap invisible instead of reporting it.
2420        let _guard = plain();
2421        let st = Stats {
2422            release_bumps: crate::stats::ReleaseBumpStats {
2423                merged: 3,
2424                ..Default::default()
2425            },
2426            ..Default::default()
2427        };
2428        let text = stats(&st);
2429        assert!(text.contains("release bumps"), "{text}");
2430        assert!(
2431            text.contains("0 of 3 merged run(s) recorded a bump"),
2432            "{text}"
2433        );
2434    }
2435
2436    #[test]
2437    fn stats_table_renders_release_bump_coverage_and_attention() {
2438        let _guard = plain();
2439        let st = Stats {
2440            release_bumps: crate::stats::ReleaseBumpStats {
2441                merged: 4,
2442                recorded: 2,
2443                pr_opened: 2,
2444                automerge_enabled: 1,
2445                merged_directly: 0,
2446                needs_attention: 1,
2447            },
2448            ..Default::default()
2449        };
2450        let text = stats(&st);
2451        assert!(text.contains("release bumps"), "{text}");
2452        assert!(
2453            text.contains("2 of 4 merged run(s) recorded a bump (50%)"),
2454            "{text}"
2455        );
2456        assert!(text.contains("1 clean, 1 needed a human (50%)"), "{text}");
2457    }
2458
2459    #[test]
2460    fn stats_table_renders_node_durations_with_a_bar_and_unmeasured_count() {
2461        let _guard = plain();
2462        let st = Stats {
2463            nodes: vec![
2464                crate::stats::NodeDuration {
2465                    node: "implement".to_owned(),
2466                    runs: 2,
2467                    total_secs: 200,
2468                    max_secs: 150,
2469                    single: 1,
2470                },
2471                crate::stats::NodeDuration {
2472                    node: "gate".to_owned(),
2473                    runs: 0,
2474                    total_secs: 0,
2475                    max_secs: 0,
2476                    single: 3,
2477                },
2478            ],
2479            ..Default::default()
2480        };
2481        let text = stats(&st);
2482        assert!(text.contains("node durations"));
2483        assert!(text.contains("implement"));
2484        assert!(text.contains("2 runs"));
2485        assert!(text.contains('█'), "the leader must draw a bar: {text}");
2486        assert!(text.contains("1 unmeasured"));
2487        assert!(text.contains("gate"));
2488        assert!(text.contains("3 unmeasured"));
2489        assert!(!text.contains('\x1b'), "colour leaked into a plain render");
2490    }
2491}