Skip to main content

magi/
config.rs

1//! Run configuration: the agent roster, the shape of the graph, and the
2//! blindness / verification policy.
3//!
4//! Layers, lowest precedence first: `<config_dir>/magi/config.toml` (machine),
5//! `.magi/config.toml`, `magi.toml`. With none, built-in defaults apply, the
6//! agent roster derived from the agent CLIs actually installed on this
7//! machine. `--config <path>` replaces the whole stack with that one file.
8//!
9//! **The repository layers are read from `<remote>/<base>`, never from the
10//! working tree.** A primary checkout is often stale or on a detached HEAD, so
11//! a gate read from it can be older than the one the branch under review is
12//! cut from (run ce6e failed on a gate step `origin/main` had already
13//! dropped). `git show <sha>:magi.toml` of the remote-tracking ref's commit is
14//! written to a content-addressed directory under the git common dir
15//! (`<common>/magi/config/<sha>-<hash of repo>/`, temp dir when that is not
16//! writable) and loaded from there. Reviewed branches may additionally enable
17//! literal owner-hold switches; these never weaken base policy or load other
18//! branch settings, includes or templates.
19//!
20//! `remote` and `base` are themselves in the file, so they are resolved in a
21//! fixed order, first hit wins:
22//!
23//! 1. `[merge] base` / `remote` of the machine layer, rendered as a real load
24//!    would (env templates, includes);
25//! 2. the same keys, read minimally (only `[merge]`, nothing deserialized into
26//!    `Config`) from the checkout's `magi.toml`, then `.magi/config.toml` -
27//!    only to *locate* the ref; an unreadable file is ignored;
28//! 3. `remote` defaults to `origin`, `base` to what
29//!    `refs/remotes/<remote>/HEAD` points at.
30//!
31//! [`Config::discover`] is synchronous and reads the remote-tracking ref as it
32//! is (`daemon::fetch_loop` keeps it fresh); [`Config::discover_fetched`] runs
33//! `git fetch` first and is what every path that starts work uses. A failed
34//! fetch, a missing ref or an unresolvable base is an **error**, never a
35//! silent fall back to the working tree or a local branch. Two cases are not
36//! that: an explicit `--config`, and a `repo` that is not a git working tree
37//! at all (no branch exists, so nothing can be stale).
38//!
39//! A repository layer that declares `include = [...]` gets the whole tree of
40//! that commit extracted, so relative includes resolve against the same
41//! commit. The directory is built beside its name and renamed in, so a
42//! concurrent `discover` never reads a half-written layer.
43use std::collections::BTreeMap;
44use std::path::{Path, PathBuf};
45
46use anyhow::{Context as _, Result, bail};
47use serde::{Deserialize, Serialize};
48
49/// Independently observed configuration failure boundary and its input target.
50/// Rendered error wording is diagnostic only, never a notification identity.
51#[derive(Debug, thiserror::Error)]
52#[error("{stage}: {target}")]
53pub(crate) struct ConfigFailure {
54    pub(crate) stage: &'static str,
55    pub(crate) target: String,
56}
57
58impl ConfigFailure {
59    fn render(error: &teravars::Error, paths: &[PathBuf]) -> Self {
60        let stage = match error {
61            teravars::Error::Io(_) => "config-read",
62            teravars::Error::Toml(_) | teravars::Error::Extract(_) => "config-parse",
63            teravars::Error::Render(_) => "config-template",
64            teravars::Error::IncludeCycle { .. } | teravars::Error::IncludeConflict { .. } => {
65                "config-include"
66            }
67            _ => "config-render",
68        };
69        Self::layers(stage, paths)
70    }
71
72    fn layers(stage: &'static str, paths: &[PathBuf]) -> Self {
73        let targets: Vec<_> = paths
74            .iter()
75            .map(|path| {
76                // Cache directories include a commit id. The input file, rather
77                // than its extraction location, identifies a loading failure.
78                path.ancestors()
79                    .find(|p| p.join(REPO_MARKER).is_file())
80                    .and_then(|root| path.strip_prefix(root).ok())
81                    .unwrap_or(path)
82                    .to_string_lossy()
83                    .into_owned()
84            })
85            .collect();
86        Self {
87            stage,
88            target: serde_json::to_string(&targets).expect("config paths"),
89        }
90    }
91}
92
93/// Which CLI drives an agent.
94#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
95#[serde(rename_all = "lowercase")]
96pub enum AgentKind {
97    /// Anthropic Claude Code (`claude -p`).
98    Claude,
99    /// opencode (`opencode run`).
100    Opencode,
101    /// Antigravity CLI (`agy -p`). Gemini CLI is deliberately absent: Google
102    /// retired the standalone client for individual accounts in favour of this
103    /// one, so an adapter for it would be dead code on a live machine.
104    Antigravity,
105    /// OpenAI Codex CLI (`codex exec`). The one roster member with a real
106    /// read-only mode: `--sandbox read-only` is enforced by the CLI, not by
107    /// the prompt.
108    Codex,
109    /// oh-my-pi (`omp -p --mode=json`). Another CLI with no read-only mode of
110    /// its own - `--auto-approve` gates reads and writes together - so a
111    /// read-only seat rests on the prompt and on the worktree discipline the
112    /// other non-codex seats already rely on. It is also the roster member that
113    /// reaches DeepSeek, whose models ship in `omp`'s own catalog.
114    Omp,
115    /// Arbitrary command. The escape hatch, and what the test suite drives.
116    Command,
117}
118
119impl AgentKind {
120    /// Executable that must be on `PATH` for this kind, if any.
121    pub fn program(self) -> Option<&'static str> {
122        match self {
123            Self::Claude => Some("claude"),
124            Self::Opencode => Some("opencode"),
125            Self::Antigravity => Some("agy"),
126            Self::Codex => Some("codex"),
127            Self::Omp => Some("omp"),
128            Self::Command => None,
129        }
130    }
131
132    /// Lowercase name as written in the config file.
133    pub fn as_str(self) -> &'static str {
134        match self {
135            Self::Claude => "claude",
136            Self::Opencode => "opencode",
137            Self::Antigravity => "antigravity",
138            Self::Codex => "codex",
139            Self::Omp => "omp",
140            Self::Command => "command",
141        }
142    }
143
144    /// Every kind the roster can name, in display order.
145    ///
146    /// This is what `magi doctor` lists, and it has to be one list rather than
147    /// the same set typed out again wherever a kind is enumerated. The last
148    /// time it was typed out twice, `omp` was added as a roster member and the
149    /// doctor output went on saying the machine had four CLIs - which reads as
150    /// "that agent is not installed" to the person the command exists for.
151    pub const ALL: [Self; 6] = [
152        Self::Claude,
153        Self::Opencode,
154        Self::Antigravity,
155        Self::Codex,
156        Self::Omp,
157        Self::Command,
158    ];
159}
160
161/// How the prompt reaches the agent process.
162#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
163#[serde(rename_all = "lowercase")]
164pub enum Delivery {
165    /// Piped on stdin.
166    Stdin,
167    /// Passed as a positional argument. Beware OS command-line limits.
168    Argv,
169    /// Written to a file; the agent is told to read it. No length limit.
170    File,
171}
172
173/// One addressable agent in the roster.
174#[derive(Debug, Clone, Deserialize, Serialize)]
175#[serde(deny_unknown_fields)]
176pub struct AgentSpec {
177    /// Stable identifier used by `[roles]` and by the stats tables.
178    pub id: String,
179    /// Which CLI to drive.
180    pub kind: AgentKind,
181    /// Model passed through to the CLI (`--model` / `-m`). CLI default if unset.
182    #[serde(default)]
183    pub model: Option<String>,
184    /// `kind = "command"` only: argv. Supports `{prompt_file}`, `{cwd}`,
185    /// `{label}`, `{session}` placeholders.
186    #[serde(default)]
187    pub command: Vec<String>,
188    /// Extra arguments appended to the built command line.
189    #[serde(default)]
190    pub extra_args: Vec<String>,
191    /// Extra environment variables for the child process.
192    #[serde(default)]
193    pub env: BTreeMap<String, String>,
194    /// Override the per-kind prompt delivery default.
195    #[serde(default)]
196    pub prompt_delivery: Option<Delivery>,
197    /// Optional per-invocation cap, in seconds, for this CLI. The caller's
198    /// remaining budget still wins when shorter; successors keep their budget.
199    #[serde(default, skip_serializing_if = "Option::is_none")]
200    pub max_turn_secs: Option<u64>,
201}
202
203impl AgentSpec {
204    /// Limit one CLI turn without extending the caller's remaining budget.
205    pub fn turn_timeout(&self, budget: std::time::Duration) -> std::time::Duration {
206        self.max_turn_secs.map_or(budget, |secs| {
207            budget.min(std::time::Duration::from_secs(secs))
208        })
209    }
210
211    /// Default prompt delivery for this agent.
212    ///
213    /// `opencode` and `agy` take the prompt as an argument, which on Windows
214    /// caps out around 32 KiB — well under a judging prompt carrying three
215    /// patches — so both get a file instead.
216    pub fn delivery(&self) -> Delivery {
217        self.prompt_delivery.unwrap_or(match self.kind {
218            AgentKind::Claude | AgentKind::Command => Delivery::Stdin,
219            // `codex exec -` reads the prompt from stdin, so the whole
220            // instruction arrives without an argv length limit and without a
221            // tool round-trip to open a file.
222            AgentKind::Codex => Delivery::Stdin,
223            // `omp -p` reads the prompt from stdin too, and a judging prompt
224            // carrying three patches is well past the Windows argv cap, so this
225            // is the only delivery that works for every node.
226            AgentKind::Omp => Delivery::Stdin,
227            AgentKind::Opencode | AgentKind::Antigravity => Delivery::File,
228        })
229    }
230
231    /// Human-facing label, e.g. `opus (claude:opus)`.
232    pub fn display(&self) -> String {
233        match &self.model {
234            Some(m) => format!("{} ({}:{m})", self.id, self.kind.as_str()),
235            None => format!("{} ({})", self.id, self.kind.as_str()),
236        }
237    }
238}
239
240/// A standalone seat's agent: one roster id, or an ordered fallback chain.
241///
242/// The string form is what every existing config uses and serializes back as
243/// a string; the array form tries each id at most once, in order, moving on
244/// when a call ends in quota or fails (see [`crate::agent::pick_chain`]).
245/// An empty string or array is the same as unset.
246#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]
247#[serde(untagged)]
248pub enum AgentChoice {
249    /// One agent id.
250    One(String),
251    /// Ordered fallback chain of agent ids.
252    Chain(Vec<String>),
253}
254
255impl AgentChoice {
256    /// The ids named, in order, with blanks dropped. Empty means unset.
257    pub fn ids(&self) -> Vec<&str> {
258        let all: Vec<&str> = match self {
259            Self::One(id) => vec![id.as_str()],
260            Self::Chain(ids) => ids.iter().map(String::as_str).collect(),
261        };
262        all.into_iter()
263            .map(str::trim)
264            .filter(|id| !id.is_empty())
265            .collect()
266    }
267
268    /// The first id named, if any.
269    pub fn primary(&self) -> Option<&str> {
270        self.ids().into_iter().next()
271    }
272}
273
274impl From<&str> for AgentChoice {
275    fn from(id: &str) -> Self {
276        Self::One(id.to_owned())
277    }
278}
279
280/// The first id of an optional choice: what a single-seat caller resolves.
281pub fn primary(choice: Option<&AgentChoice>) -> Option<&str> {
282    choice.and_then(AgentChoice::primary)
283}
284
285/// Explicit role assignment. Empty lists are filled in by
286/// [`Config::resolve_roles`] by rotating the roster.
287#[derive(Debug, Clone, Default, Deserialize, Serialize)]
288#[serde(deny_unknown_fields, default)]
289pub struct Roles {
290    /// Agents that implement the task, one worktree each.
291    pub implementers: Vec<String>,
292    /// Agents that rank the candidates blind.
293    pub judges: Vec<String>,
294    /// Agents that review the winning patch.
295    pub reviewers: Vec<String>,
296    /// Agent that applies review findings. Defaults to the winner's author.
297    ///
298    /// Accepts one id or an ordered array of ids: a fallback chain, see
299    /// [`AgentChoice`]. The review loop, the gate-fix round, `land`'s fix
300    /// rounds and the rebase conflict round move to the next id when one
301    /// errors, hits its quota or answers nothing usable; each id is tried at
302    /// most once per call, and once a fallback answered, the rest of the run
303    /// starts from it (see `crate::fixer`). Unset keeps the winner's author.
304    pub fixer: Option<AgentChoice>,
305    /// Agent that answers the standing chat's turns (`src/talk.rs`).
306    ///
307    /// Unset picks a `claude` seat, else the first runnable agent in roster
308    /// order (see [`crate::agent::pick`]) - which is roster *order*, not a
309    /// judgement about who converses well. Naming one here matters once an
310    /// agent is also sitting as a judge: the chat is opened far more often
311    /// than any single competition, and every open competes with that judge
312    /// seat for the same account's concurrency. A timeout on an ordinary chat
313    /// turn traced to exactly this - `opus` triple-booked as chatter and judge
314    /// - is what this field exists to let an operator break apart.
315    ///
316    /// Accepts one id or an ordered array of ids: a fallback chain, see
317    /// [`AgentChoice`].
318    pub chatter: Option<AgentChoice>,
319    /// Agent that judges duplicate-work claims in [`crate::dupes`].
320    /// Unset inherits [`Self::chatter`], including its default agent selection.
321    /// Accepts a string or an ordered fallback chain, like [`Self::chatter`].
322    pub dupes_judge: Option<AgentChoice>,
323    /// Agent that arranges the queue between polls: `crate::conduct`'s single
324    /// seat, called once per cycle to decide a runnable task's `blocked_by`
325    /// and how a stalled or finished task recovers.
326    ///
327    /// The same precedent as [`Self::chatter`] for a seat that stands alone
328    /// rather than rotating through the roster - resolved through
329    /// [`crate::agent::pick`], so unset falls back to its own default order
330    /// (a claude seat, else the first runnable agent) rather than reusing a
331    /// judge or reviewer seat that the conductor's own poll-cycle cadence
332    /// would otherwise compete with for the same account's concurrency.
333    ///
334    /// Accepts a string or a fallback chain, like [`Self::chatter`].
335    pub conductor: Option<AgentChoice>,
336    /// Seats for the design-deliberation stage `graph::Runner::advise` runs
337    /// before `implement`: independent, read-only design proposals gathered
338    /// once a run has a settled task instruction and before any implementer
339    /// touches the repository.
340    ///
341    /// Empty falls back to `judges` rather than to the whole roster: a panel
342    /// trusted to rank patches independently is exactly the panel worth
343    /// asking to sketch a design independently, and an operator who has
344    /// already thought about judge diversity gets advisor diversity for free
345    /// instead of a fourth roster to maintain.
346    pub advisors: Vec<String>,
347    /// Agent that blends [`Self::advisors`]' proposals into the one design
348    /// brief `graph::Runner::synthesize_brief` carries into every
349    /// implementer's prompt.
350    ///
351    /// The same precedent as [`Self::chatter`] and [`Self::conductor`] for a
352    /// seat that stands alone rather than rotating through the roster -
353    /// resolved through [`crate::agent::pick`], so unset falls back to its
354    /// own default order (a claude seat, else the first runnable agent in
355    /// roster order) - exactly today's behavior, unchanged by leaving this
356    /// field out.
357    ///
358    /// Accepts a string or a fallback chain, like [`Self::chatter`].
359    pub synthesizer: Option<AgentChoice>,
360    /// Agent (normally a `kind = "command"` wrapper around Jev) that decides
361    /// whether a pull request title and prose are English, for
362    /// [`crate::github_text`]'s posting gate.
363    ///
364    /// Unset spawns nothing: the gate keeps its built-in heuristics. Set, a
365    /// failed, timed-out or unparsable call also falls back to them, so the
366    /// gate never depends on this seat being reachable. Accepts a string or a
367    /// fallback chain, like [`Self::chatter`].
368    pub language_judge: Option<AgentChoice>,
369}
370
371/// Graph shape and limits.
372#[derive(Debug, Clone, Deserialize, Serialize)]
373#[serde(deny_unknown_fields, default)]
374pub struct Graph {
375    /// Retired `editing_network` (codex editing seats run unsandboxed since
376    /// v0.208.0). Run records written by v0.205-v0.207 snapshot it in their
377    /// config, so the key is still accepted and ignored; never written.
378    #[serde(rename = "editing_network", skip_serializing)]
379    pub retired_editing_network: Option<serde::de::IgnoredAny>,
380    /// Gate GitHub prose before posting. Secret redaction remains mandatory when disabled.
381    pub github_text_guard: bool,
382    /// Language of pull request / issue titles, bodies and GitHub comments
383    /// (`en` / `ja` / any language name). Default `en`. Anything but English
384    /// switches off the posting gate's English-only language check for those
385    /// texts (secret redaction stays); commit messages are always English.
386    /// Independent of [`Self::language`], which is for the operator.
387    pub github_language: String,
388    /// Parallel implementations of the same task (the number of implementer
389    /// seats; pairs with [`Roles::implementers`]). **One by default.**
390    ///
391    /// Formerly `candidates`, still read as a deprecated alias.
392    ///
393    /// Competition is the thing magi is for, and it is still here - it is just
394    /// no longer what every task buys without being asked. Three days and 13
395    /// runs on this repository, which is the workload these numbers are drawn
396    /// from:
397    ///
398    /// - **0 of 13** competed runs reached a merge. Everything that landed in
399    ///   that window went through `magi review` - the cheap half, no
400    ///   competition - and passed on the first try.
401    /// - The judges' first choices **split 73% of the time** (8 of 11
402    ///   tallies). Candidates that close together make the ranking a weak
403    ///   signal for what it costs to produce.
404    /// - One run's own breakdown: implement 60min, judge 40min, fix 40min,
405    ///   review 28min, **verify 5min** - and verify is the node that caught a
406    ///   defect every reviewer had passed as clean. The cheapest step is the
407    ///   one that earns its place every time.
408    ///
409    /// It is not worthless: `oc` won 3 of those tallies against `sonnet`, so a
410    /// single-seat default would have shipped the worse implementation in
411    /// roughly a quarter of them. That is exactly why this is a *default* and
412    /// not a removal - `magi run --candidates N` and a per-task seat count are
413    /// how a task that deserves a competition gets one.
414    ///
415    /// A single-candidate run needs no special case: `Runner::review`'s doc
416    /// records that `execute` already degrades to implement -> review -> gate
417    /// -> merge, because `judge` skips a one-candidate field, `deliberate` has
418    /// no two first choices to reconcile and `vote` returns early.
419    #[serde(alias = "candidates")]
420    pub implementers: usize,
421    /// Durable owner selection for a replacement implementation. No fallback.
422    #[serde(default)]
423    pub selected_implementer: Option<String>,
424    /// Independent judges.
425    pub judges: usize,
426    /// Deliberation rounds when the judges' first choices disagree.
427    pub deliberate_rounds: usize,
428    /// Reviewers per review round. **Three by default** - the smallest panel
429    /// a lens cycle (see [`crate::prompt::Lens`]) covers exactly once, so the
430    /// default panel reads the patch for spec compliance, regressions, and
431    /// simplicity without repeating an angle. Review is also the one stage
432    /// [`Self::implementers`]'s doc describes as running on every task
433    /// regardless of competition, which is what makes a panel worth its cost
434    /// here even though `implementers` itself defaults to one.
435    pub reviewers: usize,
436    /// Maximum review+fix rounds before the run is declared blocked.
437    pub review_rounds: usize,
438    /// Fix rounds a failing `verify.gate` gets before the run is blocked. The
439    /// fixer is handed the gate's own output; `0` keeps the old behaviour of
440    /// blocking on the first red gate. Independent of [`Self::review_rounds`]
441    /// so a run that spent its review budget can still repair a one-line gate
442    /// failure.
443    pub gate_fix_rounds: usize,
444    /// Maximum agent processes running at once.
445    pub max_parallel: usize,
446    /// Language for the prose the agents write (`en` / `ja` / any language name).
447    pub language: String,
448    /// Keep one CLI conversation per seat, so a judge remembers its own
449    /// argument across deliberation rounds and the fixer remembers its own
450    /// implementation across review rounds.
451    ///
452    /// Sessions are scoped to a *seat*, never to an agent id: the same model
453    /// sitting as implementer and as judge gets two unrelated conversations,
454    /// which is what keeps blind judging blind.
455    pub sessions: bool,
456    /// Per-node timeouts, seconds.
457    pub timeout_implement: u64,
458    /// Per-node timeouts, seconds.
459    pub timeout_judge: u64,
460    /// Per-node timeouts, seconds.
461    pub timeout_review: u64,
462    /// Timeout for `verify.e2e` and `verify.gate`, seconds. Separate from
463    /// [`Self::timeout_review`] so shrinking a reviewer's budget cannot
464    /// silently shrink a real-machine command's budget too — the two used to
465    /// share `timeout_review`, and turning a slow reviewer down cut the
466    /// timeout `cargo test --all-targets` runs under along with it. When
467    /// omitted, preserves legacy configurations by using
468    /// [`Self::timeout_review`]. Set an explicit value to make verification
469    /// independent of later review-seat budget changes.
470    pub timeout_verify: Option<u64>,
471    /// Per-node timeouts, seconds.
472    pub timeout_fix: u64,
473    /// Wall-clock limit for one turn of [`crate::talk`]'s standing
474    /// conversation, seconds.
475    ///
476    /// An hour: the operator is not watching this turn resolve in real time,
477    /// so the budget can match what the work - reading files, running
478    /// commands, checking their output - actually needs rather than what a
479    /// person waiting on a phone can tolerate.
480    pub timeout_talk: u64,
481    /// Longest an agent seat or verification batch may wait for the shared
482    /// build cache's lease before starting, seconds.
483    ///
484    /// A separate clock from every `timeout_*` above: those start when the CLI
485    /// or verification command is spawned and never include this wait.
486    /// Expiry is a resource block (a
487    /// resumable hold that spends no attempt and rotates no agent), not an
488    /// agent timeout.
489    pub timeout_resource_wait: u64,
490    /// Retries for an agent invocation that fails or returns nothing usable.
491    pub retries: usize,
492    /// Root for candidate / judge worktrees. Defaults to `~/wt/magi`.
493    pub worktree_root: Option<PathBuf>,
494    /// After the pull request is open, keep going: watch its checks and
495    /// reviews, run a fix round when they are unhappy, and ask to merge.
496    ///
497    /// On, because stopping at an open pull request left the operator doing
498    /// the watching by hand - six times in the session this was built in - and
499    /// that is the work the loop exists to take. It only engages for
500    /// `merge = "pr"`; every other merge mode ends the run as before.
501    ///
502    /// Turning this on does **not** hand magi the merge button:
503    /// [`Graph::land_approval`] is on too, and nothing merges without an
504    /// explicit answer. Setting both to their non-defaults is the only way to
505    /// get an unattended merge, and it has to be chosen twice.
506    pub land: bool,
507    /// Land rounds - watch, fix, push - before the run is left for a human.
508    pub land_rounds: usize,
509    /// When `land` sees a required check fail on the head it is bound to, rerun
510    /// that check's workflow run once (`gh run rerun <id> --failed`) before
511    /// spending a fix round on it. A run id is rerun at most once, recorded
512    /// before the call, and forgotten when the head moves; the rerun costs no
513    /// fix round and no attempt. A failure with no workflow run (an external
514    /// status) goes straight to the fixer. On; off sends every red check to
515    /// the fixer at once.
516    pub rerun_flaky_checks: bool,
517    /// Ask the owner before merging, showing what is about to land.
518    ///
519    /// On, and it is what makes `land` safe to have on: the question carries a
520    /// rendered panel - the diffstat, the patch, the checks, the review
521    /// comments that were addressed, and the subject the squash will use - so
522    /// the decision is made on evidence rather than on trust, from wherever
523    /// the operator happens to be.
524    ///
525    /// Silence is a hold. An unanswered approval never merges, and neither
526    /// does any answer other than the word `merge`.
527    pub land_approval: bool,
528    /// Ask the owner when open Major-or-above internal findings OR a final
529    /// rejecting reviewer vote remain. Final votes use reconsideration when
530    /// answered, otherwise the initial vote. On by default; even a reject with
531    /// zero Major findings requires approval when this control is enabled.
532    ///
533    /// `land_approval` independently asks about every merge. With both controls
534    /// off, new ordinary approvals are skipped. Neither control bypasses an
535    /// existing question or owner decision, nor the fresh approval required
536    /// after merge repair (including repair that leaves the head unchanged).
537    /// The pull request is opened either way; only the merge waits.
538    pub hold_contested_merge: bool,
539    /// Retired setting accepted for saved config compatibility only. Task
540    /// inquiries always route to chat; this value never selects a workflow.
541    pub question_routing: bool,
542    /// After a run's pull request merges, file the findings its last review
543    /// round left open as follow-up tasks (`crate::followup`) instead of
544    /// letting them vanish with the merge: every Major-or-above finding, and
545    /// every finding of a seat whose final vote was reject. Other Minor/Nit
546    /// findings are only listed in the pull-request comment. Does not affect
547    /// whether the merge happens. On; best-effort, a failure is a run event.
548    pub file_followups: bool,
549    /// After a run's pull request merges, release the follow-up tasks the
550    /// merge approval's deputy filed held for that pull request
551    /// (`crate::followup::settle_deputy_tasks`): only a task the deputy filed
552    /// for this run whose hold reason names this pull request, exactly once,
553    /// and never one that duplicates an automatic follow-up (that one is left
554    /// held with the reason). The generation cap applies. Independent of
555    /// `file_followups`. On; off leaves them held until `magi task release`.
556    pub release_deputy_followups: bool,
557    /// How long to wait for an owner to answer a question before the run is
558    /// abandoned, seconds. A parked run costs nothing, so this is generous;
559    /// it exists so a forgotten question cannot pin a worktree forever.
560    pub answer_timeout: u64,
561    /// What a round does when one or more reviewer seats never answered
562    /// (timeout, crash, unparsable output).
563    pub incomplete_review: IncompleteReviewPolicy,
564    /// Run `verify.e2e` on every round, even one that already has blocking
565    /// findings and another round left to try.
566    ///
567    /// Off by default: a round with a blocking finding and rounds still left
568    /// is going back to the fixer regardless of what `verify.e2e` says, so
569    /// running it first only spends the round's slowest step (minutes, on a
570    /// Rust repo's `cargo test --all-targets`) on a head about to be
571    /// rewritten anyway. `verify.e2e` still runs once a round has no
572    /// blocking findings left (a round cannot go `clean` without it) and the
573    /// final `verify.gate` always runs on the actual tree that would land —
574    /// deferring is about *when* e2e runs mid-loop, never about skipping it.
575    ///
576    /// Set this to restore the old every-round diagnostic behaviour: e2e
577    /// output from a round that still has blocking findings is occasionally
578    /// useful on its own (a runtime failure a reviewer's panel would not
579    /// have caught by reading), and this is the way back to seeing it every
580    /// round instead of only once the panel has nothing left to flag.
581    pub e2e_every_round: bool,
582    /// When `verify.e2e` fails with an ordinary test result (not a build/link
583    /// failure, timeout or resource block), run the failed command once more
584    /// on the same commit, in the same worktree and under the same cache
585    /// lease, before anything is decided from it. A second run that passes
586    /// verifies the head, but the first failure is recorded as a flake
587    /// (`RunState::verify_flakes`, a `verify` event, `magi show`, the web run
588    /// page) and filed once as a queue task asking for the root cause
589    /// (`crate::flake`). A second failure stands exactly as before, with the
590    /// second run's output handed to the fixer. The rerun gets its own full
591    /// `timeout_verify` and spends no review round, fix round or task attempt.
592    /// On; off decides on the first result, as before this existed.
593    pub rerun_failed_e2e: bool,
594    /// Run the design-deliberation stage before `implement`: independent
595    /// advisor seats each sketch a design, and (when at least one produced a
596    /// usable proposal) a synthesis blends them into a brief carried in the
597    /// implementer's prompt. See `graph::Runner::advise`.
598    ///
599    /// On by default. A design sketch is a few paragraphs an agent can write
600    /// without touching the repository, where a full implementation is a
601    /// tool loop that re-reads the codebase on every turn - so three
602    /// sketches, gathered once before `implement` starts, cost a fraction of
603    /// a fourth candidate and buy back a form of the same disagreement
604    /// [`Self::implementers`]'s doc describes moving away from being the
605    /// default, on every run rather than only the ones an operator remembers
606    /// to ask for with `--implementers`.
607    pub advise: bool,
608    /// How many independent design proposals the deliberation stage gathers.
609    /// **Three by default** - the same number [`Self::implementers`]'s doc
610    /// names as the point where a fourth judge's first choice stopped
611    /// changing the tally.
612    pub advisors: usize,
613    /// After the tally picks a winner and before the review loop, a fixer
614    /// round ports the strengths the judges explicitly attributed to the
615    /// losing candidates onto the winner (`graph::Runner::graft`). Skipped
616    /// for a single candidate, a run with no winner or no quorum, and when
617    /// no judge recorded a strength for a loser. Best-effort: a failure, a
618    /// quota hit or no change restores the winner's pre-graft commit and the
619    /// run carries on as if this were off.
620    /// On by default.
621    pub graft_runner_up: bool,
622}
623
624impl Default for Graph {
625    fn default() -> Self {
626        Self {
627            github_text_guard: true,
628            github_language: "en".into(),
629            implementers: 1,
630            selected_implementer: None,
631            retired_editing_network: None,
632            judges: 3,
633            deliberate_rounds: 1,
634            reviewers: 3,
635            review_rounds: 6,
636            gate_fix_rounds: 1,
637            max_parallel: 4,
638            language: "en".to_owned(),
639            sessions: true,
640            timeout_implement: 3600,
641            timeout_judge: 1200,
642            timeout_review: 1200,
643            timeout_verify: None,
644            timeout_fix: 1800,
645            timeout_talk: 3600,
646            timeout_resource_wait: 1800,
647            retries: 1,
648            worktree_root: None,
649            land: true,
650            land_rounds: 4,
651            rerun_flaky_checks: true,
652            land_approval: true,
653            hold_contested_merge: true,
654            question_routing: true,
655            file_followups: true,
656            release_deputy_followups: true,
657            answer_timeout: 86_400,
658            incomplete_review: IncompleteReviewPolicy::Block,
659            e2e_every_round: false,
660            rerun_failed_e2e: true,
661            advise: true,
662            advisors: 3,
663            graft_runner_up: true,
664        }
665    }
666}
667
668impl Graph {
669    /// Effective machine-command budget. Older configuration files had only
670    /// `timeout_review`, which also governed verification, so absence is a
671    /// compatibility fallback rather than a new 1200-second default.
672    pub fn verify_timeout(&self) -> u64 {
673        self.timeout_verify.unwrap_or(self.timeout_review)
674    }
675
676    /// Does the posting gate enforce English on GitHub text? The one place
677    /// that decides it: the guard is on *and* `github_language` is English.
678    pub fn language_gate(&self) -> bool {
679        self.github_text_guard && self.github_english()
680    }
681
682    /// Is GitHub text English (the default), whether or not the gate is on?
683    pub fn github_english(&self) -> bool {
684        crate::lang::is_english(&self.github_language)
685    }
686}
687
688/// What a review round does when a reviewer seat never answered.
689///
690/// A round where half the panel timed out is not evidence of a clean patch —
691/// it is evidence of nothing. The default refuses to call that clean; `warn`
692/// exists for an operator who would rather keep a flaky seat from stalling
693/// every run, and accepts that the gap is on them to read in the report.
694#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
695#[serde(rename_all = "lowercase")]
696pub enum IncompleteReviewPolicy {
697    /// A round with a missing seat is never `clean`: with nothing raised to
698    /// fix, the round is re-reviewed instead of gating; with the max rounds
699    /// exhausted, the run is left `Blocked` rather than declared ready.
700    Block,
701    /// A round with a missing seat can still gate as clean, once every seat
702    /// that *did* answer raised nothing blocking and verification is green.
703    /// The record keeps the gap visible (`magi show`, `magi stats`) even
704    /// though the run does not wait on it.
705    Warn,
706}
707
708/// What to do when vendor-identifying text is found in material shown to judges.
709#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
710#[serde(rename_all = "lowercase")]
711pub enum LeakPolicy {
712    /// Record the leak, show the patch unmodified.
713    Warn,
714    /// Replace the token with `[REDACTED]` in the presented patch.
715    Redact,
716    /// Abort the run.
717    Fail,
718}
719
720/// Blindness policy.
721///
722/// Commit messages and candidate summaries are *always* stripped of
723/// attribution trailers and redacted — that is where signatures actually
724/// appear. [`Blind::on_leak`] governs the patch body only, where blanket
725/// redaction would corrupt the artifact under judgement.
726#[derive(Debug, Clone, Deserialize, Serialize)]
727#[serde(deny_unknown_fields, default)]
728pub struct Blind {
729    /// Install a per-worktree `commit-msg` hook that deletes attribution
730    /// trailers before they can land in a candidate's history.
731    pub commit_msg_hook: bool,
732    /// Literal, case-insensitive substrings. A line containing any of them is
733    /// dropped from commit messages and summaries; the `commit-msg` hook is
734    /// generated from the same list.
735    pub strip_lines: Vec<String>,
736    /// Case-insensitive substrings that identify a vendor or model.
737    pub vendor_tokens: Vec<String>,
738    /// Policy for vendor tokens found in the patch body.
739    pub on_leak: LeakPolicy,
740    /// Seed for label assignment and per-judge presentation order. Derived from
741    /// the run id when unset; set it to make a run reproducible.
742    pub seed: Option<u64>,
743}
744
745impl Default for Blind {
746    fn default() -> Self {
747        Self {
748            commit_msg_hook: true,
749            strip_lines: [
750                "Co-Authored-By:",
751                "Signed-off-by:",
752                "Assisted-by:",
753                "Generated-by:",
754                "Generated with",
755                "\u{1f916}",
756            ]
757            .iter()
758            .map(|s| (*s).to_owned())
759            .collect(),
760            vendor_tokens: [
761                "claude",
762                "anthropic",
763                "codex",
764                "openai",
765                "chatgpt",
766                "gemini",
767                "grok",
768                "xai",
769                "copilot",
770                "opencode",
771                "qoder",
772                "cursor",
773                "\u{1f916}",
774            ]
775            .iter()
776            .map(|s| (*s).to_owned())
777            .collect(),
778            on_leak: LeakPolicy::Warn,
779            seed: None,
780        }
781    }
782}
783
784/// Shell commands that gate the winner.
785#[derive(Debug, Clone, Default, Deserialize, Serialize)]
786#[serde(deny_unknown_fields, default)]
787pub struct Verify {
788    /// Run in the winner's worktree once per review round. Its output is fed
789    /// back to the fixer. This is the "real machine" leg of the review.
790    pub e2e: Vec<String>,
791    /// Final gate. Must all exit 0 before a merge is attempted.
792    pub gate: Vec<String>,
793    /// Mechanical fixers (formatters) run in the winner's worktree before
794    /// `e2e` and again just before `gate`. Anything they change is committed
795    /// as one neutral-identity commit, so e2e, the gate and the PR all see the
796    /// same tree and e2e is not owed a second time for a formatter's diff. A
797    /// command that fails or times out is a warning, never a failed run: the
798    /// gate stays the single arbiter. Empty (the default) turns the feature
799    /// off. Runs under `graph.verify_timeout()` per command, like the gate.
800    /// Meant for light tools: it is not scanned for `CARGO_TARGET_DIR`, and it
801    /// must be idempotent, since it runs more than once per run and a command
802    /// that changes the tree every time makes a commit every time.
803    #[serde(default)]
804    pub pre_gate: Vec<String>,
805    /// Shell used to run the commands above. Defaults to `sh -c`, or
806    /// `cmd /C` when `sh` is not on `PATH`.
807    pub shell: Option<Vec<String>>,
808}
809
810impl Verify {
811    /// The `CARGO_TARGET_DIR=` value of the first rendered command that sets
812    /// one, if any. See [`crate::disk::extract_cargo_target_dir`] for the shape
813    /// this reads back. One rendering is enough - they all set the same
814    /// rendered `{{ vars.cache }}` path via the same shell - and the first e2e
815    /// command is checked before the gate because the e2e rebuilds the crate.
816    pub fn cache_dir(&self) -> Option<PathBuf> {
817        self.e2e
818            .iter()
819            .chain(self.gate.iter())
820            .find_map(|cmd| crate::disk::extract_cargo_target_dir(cmd))
821    }
822
823    /// Every `--manifest-path` the e2e and gate commands pass to cargo, for the
824    /// shared cache's freshness check in repositories with no root manifest.
825    pub fn cargo_manifests(&self) -> Vec<PathBuf> {
826        let all: Vec<String> = self.e2e.iter().chain(self.gate.iter()).cloned().collect();
827        crate::cache::extract_manifest_paths(&all)
828    }
829}
830
831/// Per-repository worktree preparation, run right after magi creates a worktree.
832#[derive(Debug, Clone, Default, PartialEq, Deserialize, Serialize)]
833#[serde(deny_unknown_fields, default)]
834pub struct Worktree {
835    /// Ordered steps. Declare in one layer only. Empty (the default) changes
836    /// nothing. See [`crate::worktree_setup`].
837    pub setup: Vec<SetupStep>,
838    /// Ordered, repeatable commands before owned destructive worktree cleaning.
839    pub pre_clean: Vec<PreCleanStep>,
840}
841
842/// A required shell command; unknown keys and missing commands are errors.
843#[derive(Debug, Clone, PartialEq, Deserialize, Serialize)]
844#[serde(deny_unknown_fields)]
845pub struct PreCleanStep {
846    /// Shell command executed in the target worktree after reset.
847    pub run: String,
848    /// Defaults to the verification timeout.
849    pub timeout_secs: Option<u64>,
850}
851
852/// One setup step: exactly one of `copy` / `run`.
853#[derive(Debug, Clone, Default, PartialEq, Deserialize, Serialize)]
854#[serde(deny_unknown_fields, default)]
855pub struct SetupStep {
856    /// `"src -> dst"` (or just `"path"`): copy from the primary checkout (an
857    /// absolute source is allowed) into the worktree. Never overwrites.
858    pub copy: Option<String>,
859    /// With `copy`: a missing source is skipped instead of an error.
860    pub optional: bool,
861    /// Shell command, run with the worktree as cwd.
862    pub run: Option<String>,
863    /// With `run`: seconds before the command is killed. Defaults to
864    /// `graph.verify_timeout()`.
865    pub timeout_secs: Option<u64>,
866}
867
868impl Worktree {
869    /// Refuse a malformed step at load time rather than in the middle of a run.
870    pub fn validate(&self) -> Result<()> {
871        for (i, step) in self.pre_clean.iter().enumerate() {
872            if step.run.trim().is_empty() || step.timeout_secs == Some(0) {
873                bail!(
874                    "[worktree] pre_clean step {} requires a nonempty run and positive timeout",
875                    i + 1
876                );
877            }
878        }
879        for (i, step) in self.setup.iter().enumerate() {
880            let n = i + 1;
881            match (&step.copy, &step.run) {
882                (Some(c), None) => {
883                    if step.timeout_secs.is_some() {
884                        bail!("[worktree] setup step {n}: `timeout_secs` applies to `run` only");
885                    }
886                    crate::worktree_setup::validate_copy(c)
887                        .with_context(|| format!("[worktree] setup step {n}"))?;
888                }
889                (None, Some(r)) => {
890                    if r.trim().is_empty() {
891                        bail!("[worktree] setup step {n}: `run` is empty");
892                    }
893                    if step.optional {
894                        bail!("[worktree] setup step {n}: `optional` applies to `copy` only");
895                    }
896                }
897                _ => bail!("[worktree] setup step {n} must set exactly one of `copy` and `run`"),
898            }
899        }
900        Ok(())
901    }
902}
903
904/// Disk hygiene: how hard magi is allowed to press on the machine's free space.
905///
906/// The numbers below come from one incident, not from theory: a machine with
907/// 951.8 GB free ran a few competitions and plans and best read 6.7 GB free.
908/// Three multi-gigabyte classes of junk accumulated side by side - per-run
909/// worktrees that end as `Merged`/`Ready`/`Failed`, a shared build cache whose
910/// each verify round and each implementation wave recompiles the derived
911/// section of the project into, and the outputs of runs that were removed but
912/// whose folders nobody deleted.
913#[derive(Debug, Clone, PartialEq, Deserialize, Serialize)]
914#[serde(deny_unknown_fields, default)]
915pub struct Disk {
916    /// Free space, in bytes, below which no new run may start: the daemon and
917    /// the `magi run` gate answer with "the disk is full" instead of letting
918    /// the graph fill it the rest of the way. `0` turns the gate off.
919    ///
920    /// Default 8 GiB. The incident ran down to 6.7 GB free of 951.8 GB total
921    /// before anybody noticed; 8 GiB is enough headroom for the compile a fresh
922    /// competition triggers and small enough that a 1 TB disk with 100 GB free
923    /// is nowhere near the threshold.
924    pub min_free_bytes: u64,
925    /// Fold finished runs without being asked. `Merged`, `Ready` and `Failed`
926    /// runs older than [`fold_grace_secs`](Self::fold_grace_secs) have their
927    /// worktrees removed. `0` turns the janitor off.
928    ///
929    /// Default true.
930    pub auto_fold: bool,
931    /// How old a finished run must be before the janitor folds it, seconds.
932    ///
933    /// Default 6 hours. A run that `Ready` at 8am is the operator's answer; a
934    /// run that `Ready` a week ago is worktrees holding a compile each. Six
935    /// hours is long enough that nobody loses an answer in the gap between
936    /// reading the report and starting from it, and short enough that a backlog
937    /// cannot pile up across two nights.
938    pub fold_grace_secs: u64,
939    /// Ceiling for the shared build cache (`CARGO_TARGET_DIR` in the rendered
940    /// verify commands), in bytes. When the janitor runs and the cache is over
941    /// it, files are dropped oldest-first until it is not. `0` turns pruning
942    /// off - the cache then only ever grows, which is the operator's call.
943    ///
944    /// Default 10 GiB. This is what the incident measured: 30.61 GB sat in the
945    /// shared cache on top of ~16 GB in the primary target directory and 6.7-
946    /// 11.15 GB in each of four per-worktree targets. 10 GiB holds a healthy
947    /// stack of prebuilt dependencies (cargo's per-file fingerprinting means
948    /// pruning only costs the rebuild of the dropped files, not of the world)
949    /// without letting one addled cache swallow the machine.
950    pub cache_limit_bytes: u64,
951    /// Aggregate retained worktree Cargo output cap; 0 disables reclamation.
952    pub worktree_limit_bytes: u64,
953    /// Declared artifact byte budget per pass; 0 disables reclamation.
954    /// The first deletion target may exceed a positive budget to ensure progress,
955    /// increasing deletion volume and pass duration; no later target may exceed it.
956    pub worktree_reclaim_bytes: u64,
957    /// Maximum unretired attempts of one task before another run may be
958    /// created. Resumes do not create worktrees and remain allowed. Automatic
959    /// releases and upstream changes never reset this bound; 0 disables it.
960    pub retained_attempt_limit: usize,
961}
962
963impl Default for Disk {
964    fn default() -> Self {
965        Self {
966            min_free_bytes: 8 * 1024 * 1024 * 1024,
967            auto_fold: true,
968            fold_grace_secs: 6 * 60 * 60,
969            cache_limit_bytes: 10 * 1024 * 1024 * 1024,
970            worktree_limit_bytes: 10 * 1024 * 1024 * 1024,
971            worktree_reclaim_bytes: 16 * 1024 * 1024 * 1024,
972            retained_attempt_limit: 8,
973        }
974    }
975}
976
977/// What to do with the winning branch.
978#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
979#[serde(rename_all = "lowercase")]
980pub enum MergeMode {
981    /// Leave the branch alone and print the merge command matching
982    /// [`Merge::style`].
983    None,
984    /// Merge into the base branch in the primary worktree, using
985    /// [`Merge::style`].
986    Local,
987    /// Push the branch and open a PR with `gh pr create`. Landing this PR
988    /// (`[graph] land`) always squashes — see `land`'s module doc — so
989    /// [`Merge::style`] does not apply here.
990    Pr,
991}
992
993/// How the winning branch is attached to the base branch: what
994/// `mode = "local"` runs, and what `mode = "none"`'s printed guidance tells
995/// the operator to run by hand.
996///
997/// Read from configuration rather than asked of the repository at run time
998/// (e.g. `gh api repos/{owner}/{repo}/rulesets`) for two reasons: it keeps
999/// `mode = "none"`'s guidance a pure function of `RunState`, assertable in a
1000/// unit test the same way `land::decide` is kept pure (see that module's
1001/// doc), and it works for a base branch that is not hosted on GitHub, or not
1002/// reachable at all, at the moment the report is rendered. An operator whose
1003/// base branch enforces a ruleset already knows what it allows; declaring it
1004/// once here is cheaper than magi re-discovering it, with a network call, on
1005/// every render.
1006#[derive(Debug, Clone, Copy, PartialEq, Eq, Default, Deserialize, Serialize)]
1007#[serde(rename_all = "lowercase")]
1008pub enum MergeStyle {
1009    /// `git merge --no-ff`: every candidate commit lands, plus a merge
1010    /// commit that records the merge as its own event in history. Rejected
1011    /// by a base branch whose ruleset requires linear history or forbids
1012    /// merge commits outright.
1013    #[default]
1014    Merge,
1015    /// `git merge --squash` followed by a commit under an explicit message:
1016    /// every candidate commit folds into one, and none of the candidate's
1017    /// own placeholder subjects (`magi: candidate A (uncommitted work)`)
1018    /// reach the base branch. No merge commit, so this satisfies a linear-
1019    /// history ruleset.
1020    Squash,
1021    /// A fast-forward-only merge: every candidate commit lands verbatim, in
1022    /// order, with no merge commit. Only succeeds because the winner was
1023    /// already rebased onto the tracked base tip before this runs (see
1024    /// `Runner::sync_to_base`) — equivalent to GitHub's "rebase and merge"
1025    /// once that has happened.
1026    Rebase,
1027}
1028
1029/// Whether pull request landing requires readable CI results.
1030#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, Deserialize, Serialize)]
1031#[serde(rename_all = "lowercase")]
1032pub enum MergeCi {
1033    /// Wait for readable check results before landing (the default).
1034    #[default]
1035    Expected,
1036    /// Ignore the rollup; repository verification and approval still apply.
1037    None,
1038}
1039
1040impl MergeCi {
1041    /// Translate configuration into the landing decision policy.
1042    pub fn expectation(self) -> crate::land::CiExpectation {
1043        match self {
1044            Self::Expected => crate::land::CiExpectation::Expected,
1045            Self::None => crate::land::CiExpectation::Absent,
1046        }
1047    }
1048}
1049
1050/// Merge policy.
1051#[derive(Debug, Clone, Deserialize, Serialize)]
1052#[serde(deny_unknown_fields, default)]
1053pub struct Merge {
1054    /// Default is [`MergeMode::None`]: magi never touches your base branch
1055    /// unless you ask it to.
1056    pub mode: MergeMode,
1057    /// CI expectation for landing. Opt out only in repositories without CI.
1058    pub ci: MergeCi,
1059    /// Base branch. Defaults to the branch checked out when the run started.
1060    pub base: Option<String>,
1061    /// How the winner is attached to `base`; see [`MergeStyle`]. Ignored by
1062    /// `mode = "pr"`.
1063    pub style: MergeStyle,
1064    /// Remote for `mode = "pr"`.
1065    pub remote: String,
1066    /// After a `mode = "pr"` run lands, open a `chore/release-vX.Y.Z` pull
1067    /// request sized to the change by an agent's own judgement, so a version
1068    /// bump does not depend on a human remembering to cut one.
1069    ///
1070    /// Only acts on Rust repositories (a `Cargo.toml` at the root of the base
1071    /// branch); on any other repository it is a no-op that records one event.
1072    ///
1073    /// On by default. **Turning this off means a merge landed from the phone
1074    /// never becomes a release**, so `POST /api/upgrade` keeps reporting
1075    /// "already on the newest release" against a `main` that has moved past
1076    /// it - the same gap this feature exists to close. Only for a repository
1077    /// that wants to keep cutting releases by hand.
1078    pub release_bump: bool,
1079}
1080
1081impl Default for Merge {
1082    fn default() -> Self {
1083        Self {
1084            mode: MergeMode::None,
1085            ci: MergeCi::Expected,
1086            base: None,
1087            style: MergeStyle::default(),
1088            remote: "origin".to_owned(),
1089            release_bump: true,
1090        }
1091    }
1092}
1093
1094/// How magi keeps itself current.
1095#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
1096#[serde(rename_all = "lowercase")]
1097pub enum UpdateMode {
1098    /// Never check.
1099    Off,
1100    /// Check in the background and print a one-line banner when a newer
1101    /// release exists.
1102    Notify,
1103    /// Check and install silently.
1104    Install,
1105}
1106
1107/// Self-update policy.
1108#[derive(Debug, Clone, Deserialize, Serialize)]
1109#[serde(deny_unknown_fields, default)]
1110pub struct Update {
1111    /// Default is [`UpdateMode::Notify`]: magi tells you, and lets you decide.
1112    pub mode: UpdateMode,
1113    /// Minimum time between checks, e.g. `24h`. kaishin's default when unset.
1114    pub interval: Option<String>,
1115    /// Opt in to idle-only update and restart in `magi web`.
1116    pub auto_restart: bool,
1117}
1118
1119impl Default for Update {
1120    fn default() -> Self {
1121        Self {
1122            mode: UpdateMode::Notify,
1123            interval: None,
1124            auto_restart: false,
1125        }
1126    }
1127}
1128
1129/// Who performs the release after a `chore/release-vX.Y.Z` pull request merges.
1130#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, Deserialize, Serialize)]
1131#[serde(rename_all = "lowercase")]
1132pub enum ReleaseMode {
1133    /// The repository's own workflows do (`auto-tag.yml` then `release.yml`),
1134    /// and the release pull request merges on its checks.
1135    #[default]
1136    Actions,
1137    /// magi does, from this machine: no CI is awaited, the owner approves the
1138    /// merge, and magi then tags and runs [`Release::commands`]. See
1139    /// [`crate::release_local`]. For ordinary pull requests without CI, also set
1140    /// `[merge] ci = "none"` in the repository config.
1141    Local,
1142}
1143
1144/// `[release]`: releasing without GitHub Actions. Opt-in per repository.
1145#[derive(Debug, Clone, Deserialize, Serialize)]
1146#[serde(deny_unknown_fields, default)]
1147pub struct Release {
1148    /// [`ReleaseMode::Actions`] (default: nothing changes) or
1149    /// [`ReleaseMode::Local`].
1150    pub mode: ReleaseMode,
1151    /// Shell commands run in order, from a clean checkout of the merge commit,
1152    /// once the tag is pushed. The first failure stops the list. They see
1153    /// `MAGI_RELEASE_VERSION`, `MAGI_RELEASE_TAG`, `MAGI_RELEASE_COMMIT` and
1154    /// `MAGI_RELEASE_PR` in the environment; `{{ ... }}` cannot carry the
1155    /// version because teravars renders the whole file before any release
1156    /// exists. Only read when `mode = "local"`.
1157    pub commands: Vec<String>,
1158    /// Minutes each command may run before it is killed and counted as failed.
1159    pub timeout_minutes: u64,
1160    /// Files whose version a release bump rewrites, for repositories whose
1161    /// manifest is not a root `Cargo.toml` (a Tauri app keeps it under
1162    /// `src-tauri/`, with the app version repeated in `package.json` and
1163    /// `tauri.conf.json`). Empty (default) means the root `Cargo.toml` and
1164    /// nothing else. The first entry is the version of record - the file the
1165    /// repository's own `auto-tag.yml` reads - and must be `kind = "cargo"`.
1166    /// Never detected: see [`crate::release_manifest`].
1167    pub version_files: Vec<VersionFile>,
1168}
1169
1170/// How a [`VersionFile`] is read and rewritten.
1171#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)]
1172#[serde(rename_all = "lowercase")]
1173pub enum VersionKind {
1174    /// A `Cargo.toml` (`[package]` or `[workspace.package]` `version`).
1175    Cargo,
1176    /// A JSON file with a top-level `"version"` string.
1177    Json,
1178}
1179
1180/// One entry of [`Release::version_files`].
1181#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]
1182#[serde(deny_unknown_fields)]
1183pub struct VersionFile {
1184    /// Path relative to the repository root, `/`-separated.
1185    pub path: String,
1186    /// How to read and rewrite it.
1187    pub kind: VersionKind,
1188}
1189
1190impl Default for Release {
1191    fn default() -> Self {
1192        Self {
1193            mode: ReleaseMode::Actions,
1194            commands: Vec::new(),
1195            timeout_minutes: 30,
1196            version_files: Vec::new(),
1197        }
1198    }
1199}
1200
1201impl Release {
1202    /// Refuse a malformed `version_files` at load time.
1203    pub fn validate(&self) -> Result<()> {
1204        crate::release_manifest::validate(&self.version_files).context("[release] version_files")
1205    }
1206
1207    /// Is this repository released by magi rather than by its workflows?
1208    pub fn is_local(&self) -> bool {
1209        self.mode == ReleaseMode::Local
1210    }
1211}
1212
1213/// Optional contract with an external repository updater.
1214#[derive(Debug, Clone, Deserialize, Serialize)]
1215#[serde(try_from = "CoordinationFields")]
1216pub struct Coordination {
1217    /// Contract file name inside the Git common directory.
1218    pub contract_file: String,
1219    /// Accepted trimmed contract contents.
1220    pub contract_token: String,
1221    /// Shared OS lock file name inside the Git common directory.
1222    pub lock_file: String,
1223}
1224
1225#[derive(Deserialize, Default)]
1226#[serde(deny_unknown_fields, default)]
1227struct CoordinationFields {
1228    contract_file: String,
1229    contract_token: String,
1230    lock_file: String,
1231}
1232
1233impl TryFrom<CoordinationFields> for Coordination {
1234    type Error = anyhow::Error;
1235
1236    fn try_from(fields: CoordinationFields) -> Result<Self> {
1237        for (key, name) in [
1238            ("coordination.contract_file", &fields.contract_file),
1239            ("coordination.lock_file", &fields.lock_file),
1240        ] {
1241            if name.trim().is_empty()
1242                || name != name.trim()
1243                || name == "."
1244                || name.contains("..")
1245                || name.contains(['/', '\\', ':', '\0'])
1246            {
1247                bail!(
1248                    "{key} must be a plain file name inside the Git common directory (no separators or '..')"
1249                );
1250            }
1251        }
1252        let token = &fields.contract_token;
1253        if token.is_empty() || token.trim() != token || token.chars().any(char::is_control) {
1254            bail!(
1255                "coordination.contract_token must be a nonempty single-line token without surrounding whitespace"
1256            );
1257        }
1258        Ok(Self {
1259            contract_file: fields.contract_file,
1260            contract_token: fields.contract_token,
1261            lock_file: fields.lock_file,
1262        })
1263    }
1264}
1265
1266#[cfg(test)]
1267pub(crate) fn test_coordination() -> Option<Coordination> {
1268    Some(Coordination {
1269        contract_file: "updater.contract".into(),
1270        contract_token: "test-protocol-v1".into(),
1271        lock_file: "updater.lock".into(),
1272    })
1273}
1274
1275/// Top-level configuration.
1276#[derive(Debug, Clone, Default, Deserialize, Serialize)]
1277#[serde(deny_unknown_fields, default)]
1278pub struct Config {
1279    /// External repository coordination; absent means disabled.
1280    pub coordination: Option<Coordination>,
1281    /// Agent roster.
1282    pub agents: Vec<AgentSpec>,
1283    /// Role assignment.
1284    pub roles: Roles,
1285    /// Graph shape.
1286    pub graph: Graph,
1287    /// Blindness policy.
1288    pub blind: Blind,
1289    /// Verification commands.
1290    pub verify: Verify,
1291    /// Worktree preparation.
1292    pub worktree: Worktree,
1293    /// Disk hygiene.
1294    pub disk: Disk,
1295    /// Merge policy.
1296    pub merge: Merge,
1297    /// Self-update policy.
1298    pub update: Update,
1299    /// Project-specific text appended to the node prompts.
1300    pub prompts: Prompts,
1301    /// How the operator is told a run is waiting on them.
1302    pub notify: Notify,
1303    /// Local repositories the plan surface can start or derive a conversation
1304    /// against.
1305    pub repos: Repos,
1306    /// Policy for the standing conversation ([`crate::talk`]).
1307    pub talk: Talk,
1308    /// How many runs `magi serve`'s own loop drives at once.
1309    pub daemon: Daemon,
1310    /// Who tags and publishes after a release pull request merges.
1311    pub release: Release,
1312    /// Context-window sizes in tokens, keyed by model name, merged over
1313    /// [`BUILTIN_CONTEXT_WINDOWS`]. See [`Config::context_window`].
1314    pub context_windows: BTreeMap<String, u64>,
1315}
1316
1317/// Context windows of models magi commonly drives, in tokens.
1318///
1319/// A convenience, not a source of truth: vendors resize windows and ship new
1320/// models faster than this table is edited, so an entry that is stale or
1321/// missing is fixed by `[context_windows]` in `magi.toml`, which wins. Matched
1322/// by [`Config::context_window`]: exact name first, then the longest key that
1323/// prefixes the model name (so a dated or suffixed id such as
1324/// `claude-sonnet-4-5-20250929` finds `claude-sonnet-4-5`). A model matching
1325/// nothing has no percentage - the UI shows the raw count.
1326const BUILTIN_CONTEXT_WINDOWS: &[(&str, u64)] = &[
1327    ("claude-opus-4", 200_000),
1328    ("claude-sonnet-4", 200_000),
1329    ("claude-haiku-4", 200_000),
1330    ("claude-3", 200_000),
1331    ("opus", 200_000),
1332    ("sonnet", 200_000),
1333    ("haiku", 200_000),
1334    ("gpt-5", 400_000),
1335    ("gpt-4.1", 1_000_000),
1336    ("gpt-4o", 128_000),
1337    ("o3", 200_000),
1338    ("o4-mini", 200_000),
1339    ("gemini-2.5", 1_000_000),
1340    ("deepseek", 128_000),
1341];
1342
1343impl Config {
1344    /// Context window in tokens for `model`: `[context_windows]` first, then
1345    /// the built-in table; within each, an exact name beats the longest
1346    /// prefix. `None` for an unknown model, which is a deliberate answer -
1347    /// guessing a denominator would print a confident wrong percentage.
1348    pub fn context_window(&self, model: &str) -> Option<u64> {
1349        fn lookup<'a>(model: &str, entries: impl Iterator<Item = (&'a str, u64)>) -> Option<u64> {
1350            let mut best: Option<(usize, u64)> = None;
1351            for (key, window) in entries {
1352                if key == model {
1353                    return Some(window);
1354                }
1355                if model.starts_with(key) && best.is_none_or(|(len, _)| key.len() > len) {
1356                    best = Some((key.len(), window));
1357                }
1358            }
1359            best.map(|(_, w)| w)
1360        }
1361        lookup(
1362            model,
1363            self.context_windows.iter().map(|(k, w)| (k.as_str(), *w)),
1364        )
1365        .or_else(|| lookup(model, BUILTIN_CONTEXT_WINDOWS.iter().copied()))
1366    }
1367}
1368
1369/// How the daemon loop itself behaves, as opposed to what one run does.
1370///
1371/// Machine-layer material in the same sense [`Repos::roots`] is: how many
1372/// competitions this machine's own loop is willing to babysit at once is a
1373/// fact about the machine running `magi serve`, not about any one
1374/// repository's task, so it belongs in `<config_dir>/magi/config.toml`
1375/// rather than a repository's own `magi.toml` - though, like `Repos::roots`,
1376/// nothing stops a repository from setting it too, since a scalar field
1377/// takes whichever layer has the highest precedence.
1378#[derive(Debug, Clone, Deserialize, Serialize)]
1379#[serde(deny_unknown_fields, default)]
1380pub struct Daemon {
1381    /// How many runs `magi serve` may have actively in flight at once.
1382    /// **One by default** - today's behaviour, one run at a time.
1383    ///
1384    /// This is a different knob from [`Graph::max_parallel`], and the two
1385    /// must not be confused: `max_parallel` bounds how many agent *processes*
1386    /// one run starts inside itself (implementers, judges, reviewers -
1387    /// candidates competing on a single task); this field bounds how many
1388    /// *runs* - whole competitions, each with its own `max_parallel` budget -
1389    /// the loop drives side by side, possibly across different tasks and
1390    /// different repositories. Raising `max_parallel` buys a bigger panel for
1391    /// one task; raising this buys more tasks worked at once. A config file
1392    /// that meant one and wrote the other would either starve a competition
1393    /// of judges or leave the rest of the backlog waiting for no reason.
1394    ///
1395    /// A run parked waiting on the operator's land-merge approval - see
1396    /// [`crate::land`] - does not hold one of these slots while it waits: the
1397    /// whole point of parking there is to let the loop spend the slot on
1398    /// something runnable instead of sitting on a decision only a human can
1399    /// make. So even at the default of `1`, an approval that comes back does
1400    /// not queue behind whatever else the loop happens to be running.
1401    pub max_concurrent_runs: usize,
1402    /// Let a task marked [`crate::queue::Task::interrupt`] (`magi task
1403    /// interrupt`) cut ahead of whatever `magi serve` already has in flight,
1404    /// instead of waiting for it to finish.
1405    ///
1406    /// **Off by default.** When enabled, a run that is in flight and is not
1407    /// itself the interrupt candidate may be paused at its next safe node
1408    /// boundary - see [`crate::graph::Runner::park_here`] - so the marked
1409    /// task can run alone; the paused run resumes automatically, through the
1410    /// same path any other parked run does, the moment the interrupting
1411    /// task's own run reaches a terminal status. This is opt-in because it
1412    /// bends the loop's own "one run at a time" principle (see this repository's
1413    /// `magi serve` help) for a specific, explicit operator request, and a
1414    /// repository that never files an interrupt task pays nothing for having
1415    /// it on - but an operator who does not want any run of theirs preempted,
1416    /// ever, should leave this `false`.
1417    pub pause_for_interrupts: bool,
1418    /// How many deputies `magi serve` runs at once. A deputy is the short-lived
1419    /// seat that waits on one open conductor question (see [`crate::deputy`]);
1420    /// each is a live agent conversation, so this is bounded - **two by
1421    /// default**, because the agent CLIs' quota is the scarce resource. A
1422    /// question over the limit keeps its place and starts when a deputy
1423    /// finishes; `0` runs none.
1424    pub max_deputies: usize,
1425    /// Minutes a release-bump pull request may make no progress before
1426    /// `magi serve` raises a notice and asks the owner (see
1427    /// [`crate::release_watch`]). Progress is a change of head commit or of any
1428    /// check's verdict. A required check that stays red after the one rerun the
1429    /// watcher is allowed escalates at once, whatever this says. **Sixty by
1430    /// default**; `0` turns the watcher off.
1431    pub release_stall_minutes: u64,
1432}
1433
1434impl Default for Daemon {
1435    fn default() -> Self {
1436        Self {
1437            max_concurrent_runs: 1,
1438            pause_for_interrupts: false,
1439            max_deputies: 2,
1440            release_stall_minutes: 60,
1441        }
1442    }
1443}
1444
1445/// Where `magi repos` and `GET /api/repos` look for local checkouts.
1446///
1447/// `roots` is one of the array keys [`array_merge_policy`] marks as
1448/// append-across-layers: which checkouts exist in general is a *machine*
1449/// fact in the same way the agent roster is - a repository's own `magi.toml`
1450/// cannot state where its siblings live before magi has resolved which
1451/// repository to read that file from in the first place - but a repository
1452/// that genuinely has an extra root worth scanning is not forced to choose
1453/// between an error and losing the machine's roots outright. Both layers'
1454/// roots are scanned; see [`Config::refuse_split_arrays`] for the keys that
1455/// are still refused.
1456#[derive(Debug, Clone, Deserialize, Serialize)]
1457#[serde(deny_unknown_fields, default)]
1458pub struct Repos {
1459    /// Roots to scan for a ghq-layout checkout: `<root>/<host>/<owner>/<repo>`
1460    /// with a `.git` directory. Empty by default - nothing is scanned unless
1461    /// asked to be.
1462    pub roots: Vec<PathBuf>,
1463    /// Allow explicit owner/repo misses to be confirmed with gh and cloned.
1464    pub auto_clone: bool,
1465    /// Literal argv template; {repo}, {owner}, {name}, {dest} are substituted.
1466    /// Defaults to `gh repo clone https://github.com/{repo}.git {dest}`.
1467    /// Declare in a single layer.
1468    pub clone_command: Option<Vec<String>>,
1469    /// How long a scan is trusted before the next request re-scans it,
1470    /// seconds. `0` means never trust it: scan on every request. Defaults to
1471    /// a day, the same order of magnitude as [`Graph::answer_timeout`] for
1472    /// the same reason - a checkout does not usually appear or vanish inside
1473    /// a session, so there is little to gain from scanning more often than
1474    /// that, and an explicit refresh exists for the moment one does.
1475    pub scan_ttl: u64,
1476    /// How often `magi serve` runs `git fetch origin` in every checkout under
1477    /// `roots`, seconds, so `origin/main` stays fresh whatever state the
1478    /// working tree is in. Fetch only: no branch, HEAD or working tree is
1479    /// touched. `0` disables it.
1480    pub fetch_interval: u64,
1481}
1482
1483impl Default for Repos {
1484    fn default() -> Self {
1485        Self {
1486            roots: Vec::new(),
1487            auto_clone: false,
1488            clone_command: None,
1489            scan_ttl: 86_400,
1490            fetch_interval: 600,
1491        }
1492    }
1493}
1494
1495/// Project-specific text appended to each node's prompt.
1496///
1497/// **Additive by construction.** These fields cannot replace magi's prompts,
1498/// only extend them, and that restriction is the whole design. The built-in
1499/// prompts carry the invariants the competition rests on: a judging prompt
1500/// names no authors, every structured answer must arrive as one fenced `json`
1501/// block, and a judge is told not to speculate about who wrote what. A config
1502/// that could overwrite them would let a typo silently un-blind the panel or
1503/// break the parser, and the symptom would be "the judges got worse" rather
1504/// than an error.
1505///
1506/// Repository-wide context belongs in `AGENTS.md`, which every agent already
1507/// reads from the checkout. Use these fields for the things a *magi node*
1508/// needs to know and a repository file cannot say - for instance that
1509/// reviewers here should ignore formatting because a hook owns it.
1510#[derive(Debug, Clone, Default, Deserialize, Serialize)]
1511#[serde(deny_unknown_fields, default)]
1512pub struct Prompts {
1513    /// Appended to every node's prompt.
1514    pub all: String,
1515    /// Appended for implementers.
1516    pub implement: String,
1517    /// Appended for judges, both ranking and voting.
1518    pub judge: String,
1519    /// Appended for reviewers.
1520    pub review: String,
1521    /// Appended for the fixer.
1522    pub fix: String,
1523}
1524
1525impl Prompts {
1526    /// The overlay for one node, or `None` when nothing is configured.
1527    ///
1528    /// `node` is the graph's own node name, so a new node gets no overlay
1529    /// rather than the wrong one.
1530    pub fn overlay(&self, node: &str) -> Option<String> {
1531        let specific = match node {
1532            "implement" => &self.implement,
1533            "judge" | "vote" | "deliberate" => &self.judge,
1534            "review" => &self.review,
1535            "fix" => &self.fix,
1536            _ => "",
1537        };
1538        let mut parts: Vec<&str> = Vec::new();
1539        for p in [self.all.trim(), specific.trim()] {
1540            if !p.is_empty() {
1541                parts.push(p);
1542            }
1543        }
1544        if parts.is_empty() {
1545            return None;
1546        }
1547        Some(parts.join("\n\n"))
1548    }
1549}
1550
1551/// How the operator is told that a run is waiting on them.
1552///
1553/// A command rather than a built-in integration: magi is one binary with no
1554/// network dependencies, and every operator's notification path is different -
1555/// ntfy, a Slack webhook, a Windows toast, an SSH to a machine that beeps.
1556/// Shelling out keeps all of them possible and none of them magi's problem.
1557#[derive(Debug, Clone, Default, Deserialize, Serialize)]
1558#[serde(deny_unknown_fields, default)]
1559pub struct Notify {
1560    /// Command and arguments. `{summary}`, `{run}` and `{url}` are replaced.
1561    /// Empty means no notification - the web UI is then the only surface.
1562    pub command: Vec<String>,
1563}
1564
1565/// Policy for [`crate::talk`], the standing conversation.
1566#[derive(Debug, Clone, Default, Deserialize, Serialize)]
1567#[serde(deny_unknown_fields, default)]
1568pub struct Talk {
1569    /// Let the conversation's agent edit files in the repository instead of
1570    /// filing a task for one. **Off by default** - see
1571    /// [`crate::talk`]'s module doc for why an edit made mid-conversation is
1572    /// an edit no run and no review can be attributed to, which is exactly
1573    /// the property a repository entered in a competition depends on. A
1574    /// repository that is never judged - dotfiles, a personal config
1575    /// checkout - has nothing to lose by turning this on in its own
1576    /// `magi.toml`, and a one-line fix stops costing a queued task to get.
1577    pub allow_write: bool,
1578    /// Allow bounded recovery on automatic chat turns; only the machine layer can set it.
1579    #[serde(default, skip_serializing_if = "std::ops::Not::not")]
1580    pub standing_authorization: bool,
1581    /// Extra chat personas, `[[talk.personas]]`. They add to the built-ins in
1582    /// [`crate::persona`]; an entry with a built-in's id replaces it. Like every
1583    /// array outside [`array_merge_policy`]'s append list, declaring it in two
1584    /// layers is refused.
1585    pub personas: Vec<PersonaSpec>,
1586    /// What the chat calls the operator: the persona addresses them by this
1587    /// name and the web Chat labels their turns with it instead of `YOU`.
1588    /// Blank is unset; at most [`OPERATOR_NAME_MAX`] characters, one line.
1589    pub operator_name: Option<String>,
1590}
1591
1592/// Longest accepted `[talk] operator_name`, in characters.
1593pub const OPERATOR_NAME_MAX: usize = 64;
1594
1595impl Talk {
1596    /// The trimmed operator name, `None` when unset or blank.
1597    pub fn operator_name(&self) -> Option<&str> {
1598        self.operator_name
1599            .as_deref()
1600            .map(str::trim)
1601            .filter(|n| !n.is_empty())
1602    }
1603}
1604
1605/// One `[[talk.personas]]` entry: a tone for the standing chat, nothing more.
1606#[derive(Debug, Clone, Default, PartialEq, Eq, Deserialize, Serialize)]
1607#[serde(deny_unknown_fields)]
1608pub struct PersonaSpec {
1609    /// Stable id the conversation stores. Not `default`.
1610    pub id: String,
1611    /// What the selector shows. May be omitted when `id` is a built-in's: the
1612    /// built-in's name is kept.
1613    #[serde(default)]
1614    pub name: String,
1615    /// The voice instruction appended to the chat's system prompt. May be
1616    /// omitted when `id` is a built-in's.
1617    #[serde(default)]
1618    pub prompt: String,
1619    /// Optional avatar, display only: a `data:image/(png|jpeg|gif|webp);base64,`
1620    /// URI or an absolute (or `~/`) path to a raster image. See
1621    /// [`crate::persona_icon`]. Never part of the briefing.
1622    #[serde(default, skip_serializing_if = "Option::is_none")]
1623    pub icon: Option<String>,
1624}
1625
1626/// Roles resolved to concrete agent specs for one run.
1627#[derive(Debug, Clone)]
1628pub struct ResolvedRoles {
1629    /// One per candidate.
1630    pub implementers: Vec<AgentSpec>,
1631    /// One per judge.
1632    pub judges: Vec<AgentSpec>,
1633    /// One per reviewer slot.
1634    pub reviewers: Vec<AgentSpec>,
1635    /// The configured fixer chain in order, if `[roles] fixer` is set
1636    /// (resolved like [`crate::agent::pick_chain`]: unknown or uninstalled ids
1637    /// skipped, duplicates keep their first place). `None` means the winner's
1638    /// own author.
1639    pub fixer: Option<Vec<AgentSpec>>,
1640    /// Queue conductor, explicitly selected or resolved by the standalone-seat fallback.
1641    pub conductor: AgentSpec,
1642    /// The full ordered implementer roster, in [`Roles::implementers`]'s own
1643    /// order — or `[[agents]]` in file order, when that list is empty. Unlike
1644    /// [`Self::implementers`], never truncated to `graph.implementers` and
1645    /// never `rotate`d/wrapped: a solo run (`implementers = 1`) resolves
1646    /// `implementers` down to a single slot, but `graph::Runner`'s per-seat
1647    /// quota fallback needs the *whole* list to walk forward through when
1648    /// that one slot's agent runs out of quota mid-run.
1649    pub implementer_roster: Vec<AgentSpec>,
1650    /// [`Self::implementer_roster`]'s counterpart for judge seats: the whole
1651    /// `[roles] judges` list (or every agent), untruncated and unrotated, for
1652    /// the per-seat handover when a judge's agent fails.
1653    pub judge_roster: Vec<AgentSpec>,
1654    /// Likewise for reviewer seats.
1655    pub reviewer_roster: Vec<AgentSpec>,
1656}
1657
1658/// Every array-valued key in a config table, as a dotted path.
1659///
1660/// Dotted so the error names `roles.implementers` rather than `implementers`:
1661/// an operator with three config files needs to know which key, not just that
1662/// there was one. `vars` is skipped because it is teravars' own input, merged
1663/// on purpose and never deserialised into `Config`.
1664fn array_keys(table: &toml::value::Table, prefix: &str) -> Vec<String> {
1665    let mut out = Vec::new();
1666    for (k, v) in table {
1667        if prefix.is_empty() && k == "vars" {
1668            continue;
1669        }
1670        let path = if prefix.is_empty() {
1671            k.clone()
1672        } else {
1673            format!("{prefix}.{k}")
1674        };
1675        match v {
1676            toml::Value::Array(_) => out.push(path),
1677            toml::Value::Table(t) => out.extend(array_keys(t, &path)),
1678            _ => {}
1679        }
1680    }
1681    out
1682}
1683
1684/// How an array key behaves when two config layers both declare it.
1685#[derive(Debug, Clone, Copy, PartialEq, Eq)]
1686enum ArrayMerge {
1687    /// Two layers may both declare it; the composed value is the
1688    /// low-to-high-priority concatenation teravars already produces (see
1689    /// [`Config::load_layers`]'s doc for why that order and no dedup).
1690    Append,
1691    /// Two layers declaring it is refused; see
1692    /// [`Config::refuse_split_arrays`].
1693    Replace,
1694}
1695
1696/// The single place that decides, for a dotted array key (as returned by
1697/// [`array_keys`]), whether declaring it in two config layers is a
1698/// concatenation the operator asked for or a silent accident.
1699///
1700/// Kept as one match so the whole policy is visible in one place - the same
1701/// reason `claude_quota` and `dropped_stream` close their own classification
1702/// in one spot elsewhere in this codebase. Anything not listed defaults to
1703/// [`ArrayMerge::Replace`]: refusing is the safe default for a key nobody has
1704/// reasoned about yet, and a new array key added later has to be added here
1705/// deliberately to become appendable.
1706///
1707/// - `verify.e2e` / `verify.gate` — a "run all of these, all must exit 0"
1708///   gate. Concatenating two of them is exactly the checks both layers
1709///   wanted, which is what lets a common gate (e.g. `editorconfig-checker`)
1710///   live in a shared layer while a repository's own layer adds its own
1711///   command, instead of every repository copying the shared command into
1712///   its own file.
1713/// - `repos.roots` — a set of directories to scan for checkouts. A
1714///   repository adding its own root on top of the machine's is additive by
1715///   nature, not a replacement of where the machine looks; see
1716///   [`Repos::roots`].
1717///
1718/// Left on the refuse side, and why:
1719/// - `roles.implementers` / `roles.judges` / `roles.reviewers` — an ordered
1720///   list of *seats*, not a set. A machine's two implementers plus a
1721///   repository's one is three seats nobody asked for and nobody is paying
1722///   for on purpose.
1723/// - `notify.command` — an argv. Concatenating two argvs does not produce a
1724///   program that runs; it produces `["ntfy", "publish", "curl", "-X"]`.
1725/// - `blind.strip_lines` — technically safe to concatenate (each entry is
1726///   matched as an independent substring, so a longer list only strips
1727///   *more*), but left on the refuse side anyway: the same list also drives
1728///   `commit_msg_hook`'s generated `sed` addresses, where position matters,
1729///   and a silent three-layer merge is exactly the kind of surprise
1730///   `refuse_split_arrays` exists to catch rather than to reason about
1731///   case-by-case. A repository that wants one more stripped phrase restates
1732///   the whole list; that restatement is visible in review, an accidental
1733///   concatenation would not be.
1734fn array_merge_policy(key: &str) -> ArrayMerge {
1735    match key {
1736        "verify.e2e" | "verify.gate" | "verify.pre_gate" | "repos.roots" => ArrayMerge::Append,
1737        _ => ArrayMerge::Replace,
1738    }
1739}
1740
1741impl Config {
1742    /// Load one file through teravars: Tera rendering, `[vars]` resolution,
1743    /// and the `include = [...]` directive.
1744    pub fn load(path: &Path) -> Result<Self> {
1745        Self::load_layers(&[path.to_path_buf()])
1746    }
1747
1748    /// The Tera render context shared by every layer: `system.*` (from
1749    /// teravars), `env` (magi's own addition - a config that names a shared
1750    /// build-cache directory or a machine-specific path needs
1751    /// `{{ env.NAME | default(value='...') }}`), and `repo` / `repo_name`
1752    /// derived from the last (highest-priority) path's parent directory.
1753    ///
1754    /// Factored out so [`Config::array_provenance`] can re-render a single
1755    /// layer under the exact same context [`Config::load_layers`] uses for
1756    /// the joint render, rather than drifting from it by accident.
1757    fn render_ctx(paths: &[PathBuf]) -> teravars::Context {
1758        let mut ctx = teravars::system_context();
1759        let env: std::collections::BTreeMap<String, String> = std::env::vars().collect();
1760        ctx.insert("env", &env);
1761        if let Some(last) = paths.last()
1762            && let Some(dir) = last.parent()
1763        {
1764            // A layer extracted from `<remote>/<base>` records the checkout it
1765            // stands for beside itself; its own directory is a cache path.
1766            let dir = std::fs::read_to_string(dir.join(REPO_MARKER))
1767                .map(|s| PathBuf::from(s.trim()))
1768                .unwrap_or_else(|_| dir.to_path_buf());
1769            ctx.insert("repo", &dir.to_string_lossy());
1770            ctx.insert(
1771                "repo_name",
1772                &dir.file_name().unwrap_or_default().to_string_lossy(),
1773            );
1774        }
1775        ctx
1776    }
1777
1778    /// Load and deep-merge a stack of config files, later files winning.
1779    ///
1780    /// This is why the config is TOML-through-teravars rather than plain serde:
1781    /// the roster is a *machine* fact (which CLIs and plans you pay for) while
1782    /// the gate is a *repository* fact (`cargo make check` here, `pnpm test`
1783    /// there). Picking one file and ignoring the other would force every repo
1784    /// to restate the roster.
1785    pub fn load_layers(paths: &[PathBuf]) -> Result<Self> {
1786        Self::load_layers_with_machine(paths, Self::machine_layer())
1787    }
1788
1789    fn load_layers_with_machine(paths: &[PathBuf], machine: Option<PathBuf>) -> Result<Self> {
1790        let mut engine = teravars::Engine::default();
1791        let ctx = Self::render_ctx(paths);
1792        if paths.len() > 1 {
1793            Self::refuse_split_arrays(paths, &mut engine, &ctx).map_err(|error| {
1794                if error.downcast_ref::<ConfigFailure>().is_some() {
1795                    error
1796                } else {
1797                    // Keep the actionable refusal visible to plain Display
1798                    // callers while retaining the structured failure identity.
1799                    let message = error.to_string();
1800                    error
1801                        .context(ConfigFailure::layers("config-merge", paths))
1802                        .context(message)
1803                }
1804            })?;
1805        }
1806        let merged = teravars::load_merged(paths, &mut engine, &ctx)
1807            .map_err(|error| {
1808                let cause = ConfigFailure::render(&error, paths);
1809                anyhow::Error::new(error).context(cause)
1810            })
1811            .with_context(|| {
1812                format!(
1813                    "rendering config via teravars: {}",
1814                    paths
1815                        .iter()
1816                        .map(|p| p.display().to_string())
1817                        .collect::<Vec<_>>()
1818                        .join(", ")
1819                )
1820            })?;
1821        let mut table = merged.config;
1822        Self::normalize_renamed_keys(paths, &mut engine, &ctx, &mut table)?;
1823        // Repository templates and explicit execution config cannot supply or
1824        // override this authority, including through includes or rendered vars.
1825        let standing = table
1826            .get_mut("talk")
1827            .and_then(toml::Value::as_table_mut)
1828            .and_then(|talk| talk.remove("standing_authorization"));
1829        let standing = if standing.is_some()
1830            && let Some(machine) = machine.filter(|machine| paths.contains(machine))
1831        {
1832            let machine_paths = [machine];
1833            let mut engine = teravars::Engine::default();
1834            let layer = teravars::load_merged(
1835                &machine_paths,
1836                &mut engine,
1837                &Self::render_ctx(&machine_paths),
1838            )
1839            .context("read machine standing authorization")?;
1840            layer
1841                .config
1842                .get("talk")
1843                .and_then(|talk| talk.get("standing_authorization"))
1844                .map(|value| {
1845                    value.as_bool().context(
1846                        "[talk] standing_authorization in the machine layer must be a boolean",
1847                    )
1848                })
1849                .transpose()?
1850                .unwrap_or(false)
1851        } else {
1852            false
1853        };
1854        // `[vars]` is teravars' own input, already resolved into the render
1855        // context; `deny_unknown_fields` must not trip over it.
1856        table.remove("vars");
1857        // No layer says anything about `agents`: the roster is whatever is on
1858        // `PATH` now, exactly as when no layer exists at all. An explicit
1859        // `agents = []` is a statement and is kept.
1860        let detect_agents = !table.contains_key("agents");
1861        let mut cfg: Self = toml::Value::Table(table)
1862            .try_into()
1863            .context("deserializing magi config")
1864            .context(ConfigFailure::layers("config-deserialize", paths))?;
1865        cfg.talk.standing_authorization = standing;
1866        if !cfg.graph.question_routing {
1867            tracing::warn!(
1868                "[graph] question_routing is retired and ignored; task inquiries always use their chat"
1869            );
1870        }
1871        crate::persona::validate(&cfg.talk.personas)?;
1872        cfg.worktree.validate()?;
1873        cfg.release.validate()?;
1874        if let Some(name) = cfg.talk.operator_name() {
1875            if name.chars().count() > OPERATOR_NAME_MAX || name.chars().any(char::is_control) {
1876                bail!(
1877                    "[talk] operator_name must be one line of at most {OPERATOR_NAME_MAX} characters"
1878                );
1879            }
1880        }
1881        if detect_agents {
1882            cfg.agents = Self::autodetected().agents;
1883        }
1884        Ok(cfg)
1885    }
1886
1887    /// `graph.candidates` was renamed `graph.implementers`. Both spellings are
1888    /// read, but the layers are merged into one table before serde sees it, so
1889    /// an old name in a lower layer and the new name in a higher one would
1890    /// arrive together and fail as a duplicate field instead of letting the
1891    /// higher layer win. Resolve it here: a single layer that writes both is
1892    /// refused (naming both keys and the file); otherwise the value from the
1893    /// last layer that wrote either key becomes `implementers`.
1894    fn normalize_renamed_keys(
1895        paths: &[PathBuf],
1896        engine: &mut teravars::Engine,
1897        ctx: &teravars::Context,
1898        table: &mut toml::map::Map<String, toml::Value>,
1899    ) -> Result<()> {
1900        let both = matches!(
1901            table.get("graph"),
1902            Some(toml::Value::Table(g)) if g.contains_key("candidates") && g.contains_key("implementers")
1903        );
1904        if !both {
1905            return Ok(());
1906        }
1907        let mut winner: Option<toml::Value> = None;
1908        for path in paths {
1909            let one = teravars::load_merged([path], engine, ctx)
1910                .map_err(|error| {
1911                    let cause = ConfigFailure::render(&error, std::slice::from_ref(path));
1912                    anyhow::Error::new(error).context(cause)
1913                })
1914                .with_context(|| format!("rendering {}", path.display()))?;
1915            let Some(toml::Value::Table(g)) = one.config.get("graph") else {
1916                continue;
1917            };
1918            if g.contains_key("candidates") && g.contains_key("implementers") {
1919                bail!(
1920                    "`[graph]` sets both `implementers` and its deprecated alias \n                     `candidates` in {}; keep only `implementers`.",
1921                    path.display()
1922                );
1923            }
1924            if let Some(v) = g.get("implementers").or_else(|| g.get("candidates")) {
1925                winner = Some(v.clone());
1926            }
1927        }
1928        if let Some(toml::Value::Table(g)) = table.get_mut("graph") {
1929            g.remove("candidates");
1930            if let Some(v) = winner {
1931                g.insert("implementers".to_owned(), v);
1932            }
1933        }
1934        Ok(())
1935    }
1936
1937    /// Refuse an array that two layers both declare, unless
1938    /// [`array_merge_policy`] says that key is meant to accumulate.
1939    ///
1940    /// teravars **appends** arrays when it merges layers, and that is wrong for
1941    /// most arrays magi has: `implementers` is an ordered list of seats,
1942    /// `notify.command` is an argv. Concatenating two of them yields something
1943    /// nobody wrote - three implementers out of a machine's two and a
1944    /// repository's one, or an argv of `["ntfy", "publish", "curl", "-X"]`.
1945    ///
1946    /// Replacing instead would be the right merge rule for those keys, but the
1947    /// rule lives in teravars, which several other projects depend on;
1948    /// changing it there is a decision for that crate, not something to fake
1949    /// here by re-reading the files with different semantics and hoping the
1950    /// two paths agree.
1951    ///
1952    /// So magi refuses the ambiguity rather than resolving it silently, for
1953    /// every array key except the short, deliberate list
1954    /// [`array_merge_policy`] marks [`ArrayMerge::Append`] - for those, the
1955    /// concatenation teravars already produces *is* what both files say, so
1956    /// there is nothing to refuse. The cost of guessing wrong on the refused
1957    /// keys is a roster the operator did not ask for and is paying for by the
1958    /// token; the append keys carry no such risk because every element runs
1959    /// (or every directory is scanned) regardless of order.
1960    fn refuse_split_arrays(
1961        paths: &[PathBuf],
1962        engine: &mut teravars::Engine,
1963        ctx: &teravars::Context,
1964    ) -> Result<()> {
1965        let mut seen: std::collections::BTreeMap<String, PathBuf> = Default::default();
1966        for path in paths {
1967            let one = teravars::load_merged([path], engine, ctx)
1968                .map_err(|error| {
1969                    let cause = ConfigFailure::render(&error, std::slice::from_ref(path));
1970                    anyhow::Error::new(error).context(cause)
1971                })
1972                .with_context(|| format!("rendering {}", path.display()))?;
1973            for key in array_keys(&one.config, "") {
1974                if array_merge_policy(&key) == ArrayMerge::Append {
1975                    continue;
1976                }
1977                if let Some(first) = seen.get(&key) {
1978                    bail!(
1979                        "`{key}` is an array declared in two config layers:\n  \
1980                         {}\n  {}\nteravars appends arrays when it merges, so \
1981                         magi would run the concatenation of both - which is \
1982                         not what either file says. Declare `{key}` in exactly \
1983                         one of them.",
1984                        first.display(),
1985                        path.display()
1986                    );
1987                }
1988                seen.insert(key, path.clone());
1989            }
1990        }
1991        Ok(())
1992    }
1993
1994    /// Which layers contributed to a composed, appendable array key (e.g.
1995    /// `"verify.gate"`), in the same low-to-high-priority order
1996    /// [`Config::load_layers`] concatenates them in. Layers that do not
1997    /// declare `key` at all are omitted.
1998    ///
1999    /// This is a **display aid for `magi doctor` only.** The command list
2000    /// that actually runs always comes from the one joint
2001    /// [`teravars::load_merged`] call in `load_layers`, never from this
2002    /// function - the exact hazard [`Config::refuse_split_arrays`] warns
2003    /// about is two merge paths that might disagree, so this function must
2004    /// never become a second source of the *composed* value, only of which
2005    /// file wrote which line in it.
2006    ///
2007    /// Re-rendering each layer alone can, in principle, resolve a
2008    /// `{{ vars.x }}` differently than the joint render would, if `x` is
2009    /// defined in one layer and referenced in another - the same caveat
2010    /// `refuse_split_arrays`'s structural, key-only check already lives with.
2011    /// None of magi's own gate commands cross that line, and a doctor listing
2012    /// is read by a human who can compare it against the joint one printed
2013    /// alongside it, so this is judged worth the simplicity of not
2014    /// threading provenance through the real load path.
2015    pub fn array_provenance(paths: &[PathBuf], key: &str) -> Vec<(PathBuf, Vec<String>)> {
2016        let mut engine = teravars::Engine::default();
2017        let ctx = Self::render_ctx(paths);
2018        let mut out = Vec::new();
2019        for path in paths {
2020            let Ok(one) = teravars::load_merged([path], &mut engine, &ctx) else {
2021                continue;
2022            };
2023            let mut cur = &one.config;
2024            let mut found = None;
2025            let parts: Vec<&str> = key.split('.').collect();
2026            for (i, part) in parts.iter().enumerate() {
2027                match cur.get(*part) {
2028                    Some(toml::Value::Array(a)) if i == parts.len() - 1 => {
2029                        found = Some(a);
2030                        break;
2031                    }
2032                    Some(toml::Value::Table(t)) => cur = t,
2033                    _ => break,
2034                }
2035            }
2036            let Some(values) = found else { continue };
2037            let strings: Vec<String> = values
2038                .iter()
2039                .filter_map(|v| v.as_str().map(str::to_owned))
2040                .collect();
2041            if !strings.is_empty() {
2042                out.push((path.clone(), strings));
2043            }
2044        }
2045        out
2046    }
2047
2048    /// Each layer rendered on its own, with the outcome per file: the
2049    /// settings screen's way of saying which layer a value came from and which
2050    /// layer is the one that does not parse. A **display aid only**, for the
2051    /// same reason as [`Config::array_provenance`]: the effective config
2052    /// always comes from the one joint [`Config::load_layers`].
2053    pub(crate) fn layer_tables(paths: &[PathBuf]) -> Vec<(PathBuf, Result<toml::Table>)> {
2054        let mut engine = teravars::Engine::default();
2055        let ctx = Self::render_ctx(paths);
2056        paths
2057            .iter()
2058            .map(|path| {
2059                let one = teravars::load_merged([path], &mut engine, &ctx)
2060                    .map(|m| m.config)
2061                    .with_context(|| format!("rendering {}", path.display()));
2062                (path.clone(), one)
2063            })
2064            .collect()
2065    }
2066
2067    /// Render a composed command list for `magi doctor`: the joined command
2068    /// line the run actually uses, plus - only when more than one layer
2069    /// contributed - which layer wrote which line.
2070    ///
2071    /// A single contributing layer (the common case today) stays the plain
2072    /// one-line summary magi has always printed, `empty` included: that
2073    /// honest "(none — ...)" is what caught a real gate-composition gap
2074    /// before this array could compose at all, and composition should not
2075    /// make the common case noisier.
2076    pub fn describe_composed(
2077        paths: &[PathBuf],
2078        commands: &[String],
2079        key: &str,
2080        empty: &str,
2081    ) -> String {
2082        if commands.is_empty() {
2083            return empty.to_owned();
2084        }
2085        let joined = commands.join(" && ");
2086        let provenance = Self::array_provenance(paths, key);
2087        if provenance.len() <= 1 {
2088            return joined;
2089        }
2090        let mut out = joined;
2091        for (path, cmds) in &provenance {
2092            out.push_str(&format!("\n    [{}] {}", path.display(), cmds.join(" && ")));
2093        }
2094        out
2095    }
2096
2097    /// Resolve the config for `repo`, honouring an explicit `--config` path.
2098    ///
2099    /// Returns the config and the layers it came from, empty for built-in
2100    /// defaults. The repository layers come from the remote-tracking ref as it
2101    /// stands (see the module doc); use [`Config::discover_fetched`] where a
2102    /// stale ref would matter.
2103    pub fn discover(repo: &Path, explicit: Option<&Path>) -> Result<(Self, Vec<PathBuf>)> {
2104        #[cfg(test)]
2105        crate::web::request_cost::discovery();
2106        if let Some(p) = explicit {
2107            let paths = vec![p.to_path_buf()];
2108            return Ok((Self::load_layers(&paths)?, paths));
2109        }
2110        let paths = Self::layers_checked(repo)?;
2111        if paths.is_empty() {
2112            return Ok((Self::autodetected(), paths));
2113        }
2114        Ok((Self::load_layers(&paths)?, paths))
2115    }
2116
2117    /// [`Config::discover`] after `git fetch <remote> <base>`: for every path
2118    /// that is about to start work. A failed fetch is an error.
2119    pub async fn discover_fetched(
2120        repo: &Path,
2121        explicit: Option<&Path>,
2122    ) -> Result<(Self, Vec<PathBuf>)> {
2123        if explicit.is_none() && is_git_worktree(repo) {
2124            // A checkout that was never cloned from the remote has no
2125            // `<remote>/HEAD`; learn it here (refs/remotes only) so an
2126            // ordinary start recovers instead of failing in `discover`.
2127            let (remote, cfg_base) = probe_remote_base(repo);
2128            let base = crate::git::merge_base_branch(repo, &remote, cfg_base.as_deref())
2129                .await
2130                .with_context(|| ConfigFailure {
2131                    stage: "config-base",
2132                    target: remote.clone(),
2133                })?;
2134            let out = crate::git::fetch(repo, &remote, &base)
2135                .await
2136                .with_context(|| format!("fetching {remote}/{base} to read magi.toml"))
2137                .with_context(|| ConfigFailure {
2138                    stage: "config-fetch",
2139                    target: format!("{remote}/{base}"),
2140                })?;
2141            if !out.ok() {
2142                return Err(anyhow::anyhow!(
2143                    "cannot read magi.toml: `git fetch {remote} {base}` failed ({});                      refusing to use the local checkout's copy, which may be stale",
2144                    out.stderr.lines().next().unwrap_or("").trim()
2145                )).context(ConfigFailure { stage: "config-fetch", target: format!("{remote}/{base}") });
2146            }
2147            if cfg_base.is_none() {
2148                crate::git::ensure_remote_head(repo, &remote, &base).await;
2149            }
2150        }
2151        Self::discover(repo, explicit).map_err(|error| {
2152            if error.downcast_ref::<ConfigFailure>().is_some() {
2153                error
2154            } else {
2155                error.context(ConfigFailure {
2156                    stage: "config-load",
2157                    target: explicit.unwrap_or(repo).to_string_lossy().into_owned(),
2158                })
2159            }
2160        })
2161    }
2162
2163    /// [`Config::layers`], but an unreadable remote ref is an error.
2164    fn layers_checked(repo: &Path) -> Result<Vec<PathBuf>> {
2165        if !is_git_worktree(repo) {
2166            return Ok(Self::layers(repo));
2167        }
2168        let mut paths: Vec<PathBuf> = Self::machine_layer()
2169            .into_iter()
2170            .filter(|p| p.is_file())
2171            .collect();
2172        paths.extend(Self::repo_layers(repo)?);
2173        Ok(paths)
2174    }
2175
2176    /// Describe a repository layer without directing the operator to its cache.
2177    pub(crate) fn repo_layer_description(repo: &Path, path: &Path) -> String {
2178        let cached = path.ancestors().find(|p| p.join(REPO_MARKER).is_file());
2179        if let Some(root) = cached {
2180            let relative = path.strip_prefix(root).unwrap_or(path);
2181            let reference = resolve_remote_base(repo)
2182                .map(|(remote, base)| format!("{remote}/{base}"))
2183                .unwrap_or_else(|_| "remote base".to_owned());
2184            format!(
2185                "{} at {reference} (including its includes)",
2186                repo.join(relative).display()
2187            )
2188        } else {
2189            format!("{} (including its includes)", path.display())
2190        }
2191    }
2192
2193    /// Only the repository layers (lowest first), from `<remote>/<base>` in a
2194    /// git working tree and from disk elsewhere.
2195    pub(crate) fn repo_layers(repo: &Path) -> Result<Vec<PathBuf>> {
2196        if !is_git_worktree(repo) {
2197            return Ok([
2198                repo.join(".magi").join("config.toml"),
2199                repo.join("magi.toml"),
2200            ]
2201            .into_iter()
2202            .filter(|p| p.is_file())
2203            .collect());
2204        }
2205        remote_layers(repo)
2206    }
2207
2208    /// Environment variable that relocates the machine-wide config layer.
2209    ///
2210    /// Set it to a directory and magi reads `<dir>/magi/config.toml` instead
2211    /// of the one under [`dirs::config_dir`]; set it to the empty string and
2212    /// magi reads no machine layer at all.
2213    ///
2214    /// This exists because the machine layer is otherwise unavoidable, and a
2215    /// test that builds a config fixture is not asking for the operator's
2216    /// preferences to be merged into it. Adding `[repos] roots` to the real
2217    /// machine config on a development box turned two passing tests red -
2218    /// `repos_list_returns_name_and_path_for_every_configured_root` and
2219    /// `repos_list_only_rescans_within_the_ttl_when_asked_to`, whose fixtures
2220    /// declare `[repos] roots` of their own, which [`Config::layers`] then
2221    /// found in two layers and [`Config::refuse_split_arrays`] correctly
2222    /// refused. CI never saw it: a runner has no machine config, so the suite
2223    /// was green there and red only where somebody actually uses magi.
2224    ///
2225    /// An operator gets the same escape hatch for free: a second machine
2226    /// config, or none, without moving files about.
2227    pub const CONFIG_DIR_ENV: &str = "MAGI_CONFIG_DIR";
2228
2229    /// Every config layer that applies to `repo`, in increasing precedence.
2230    ///
2231    /// The machine layer is whatever [`Config::machine_layer`] resolves to,
2232    /// which is nothing at all in a test build.
2233    pub fn layers(repo: &Path) -> Vec<PathBuf> {
2234        let mut paths = Vec::new();
2235        paths.extend(Self::machine_layer());
2236        paths.push(repo.join(".magi").join("config.toml"));
2237        paths.push(repo.join("magi.toml"));
2238        paths.retain(|p| p.is_file());
2239        paths
2240    }
2241
2242    /// The machine-wide layer's path, when there is one.
2243    ///
2244    /// **A test build has none unless it names one.** A fixture is a complete
2245    /// statement of the config under test, and the operator's own preferences
2246    /// have no business being merged into it - least of all silently, on one
2247    /// machine, in a suite that is green everywhere else.
2248    #[cfg(test)]
2249    pub(crate) fn machine_layer() -> Option<PathBuf> {
2250        std::env::var(Self::CONFIG_DIR_ENV)
2251            .ok()
2252            .filter(|dir| !dir.trim().is_empty())
2253            .map(|dir| PathBuf::from(dir).join("magi").join("config.toml"))
2254    }
2255
2256    /// The machine-wide layer's path, when there is one.
2257    #[cfg(not(test))]
2258    pub(crate) fn machine_layer() -> Option<PathBuf> {
2259        match std::env::var(Self::CONFIG_DIR_ENV) {
2260            // Named, and empty on purpose: no machine layer.
2261            Ok(dir) if dir.trim().is_empty() => None,
2262            Ok(dir) => Some(PathBuf::from(dir).join("magi").join("config.toml")),
2263            Err(_) => dirs::config_dir().map(|dir| dir.join("magi").join("config.toml")),
2264        }
2265    }
2266
2267    /// Built-in config whose roster is the agent CLIs found on `PATH`.
2268    pub fn autodetected() -> Self {
2269        let mut cfg = Self::default();
2270        for (kind, id, model) in [
2271            (AgentKind::Claude, "opus", Some("opus")),
2272            (AgentKind::Claude, "sonnet", Some("sonnet")),
2273            (AgentKind::Antigravity, "antigravity", None),
2274            (AgentKind::Opencode, "opencode", None),
2275            (AgentKind::Codex, "codex", None),
2276            (AgentKind::Omp, "omp", None),
2277        ] {
2278            if kind.program().is_some_and(which) && !cfg.agents.iter().any(|a| a.id == id) {
2279                cfg.agents.push(AgentSpec {
2280                    id: id.to_owned(),
2281                    kind,
2282                    model: model.map(str::to_owned),
2283                    command: Vec::new(),
2284                    extra_args: Vec::new(),
2285                    env: BTreeMap::new(),
2286                    prompt_delivery: None,
2287                    max_turn_secs: None,
2288                });
2289            }
2290        }
2291        cfg
2292    }
2293
2294    /// The shared build cache the verify commands and the agents both build
2295    /// into, when the config declares one. See [`Verify::cache_dir`].
2296    pub fn cache_dir(&self) -> Option<PathBuf> {
2297        self.verify.cache_dir()
2298    }
2299
2300    /// Look an agent up by id.
2301    pub fn agent(&self, id: &str) -> Result<&AgentSpec> {
2302        self.agents
2303            .iter()
2304            .find(|a| a.id == id)
2305            .with_context(|| format!("no agent with id `{id}` in the roster"))
2306    }
2307
2308    /// Rotate `count` seats out of `ids`, or out of the whole roster at
2309    /// `offset` when `ids` is empty.
2310    ///
2311    /// The one rotation rule - explicit ids cycle, an empty list rotates the
2312    /// roster - shared by every seat count [`Config::resolve_roles`] fills in,
2313    /// rather than each seat reimplementing it and drifting apart.
2314    fn rotate(&self, ids: &[String], count: usize, offset: usize) -> Result<Vec<AgentSpec>> {
2315        let mut out = Vec::with_capacity(count);
2316        for i in 0..count {
2317            let spec = if ids.is_empty() {
2318                self.agents[(i + offset) % self.agents.len()].clone()
2319            } else {
2320                self.agent(&ids[i % ids.len()])?.clone()
2321            };
2322            out.push(spec);
2323        }
2324        Ok(out)
2325    }
2326
2327    /// `ids`, resolved to specs in the order named, or the whole `[[agents]]`
2328    /// roster in file order when `ids` is empty — the same "explicit ids
2329    /// stand alone, an empty list means the whole roster" rule [`Self::rotate`]
2330    /// applies, but with no `count` to truncate to and no `offset` to wrap by.
2331    /// See [`ResolvedRoles::implementer_roster`] for why a truncated, rotated
2332    /// list cannot answer the question this exists for.
2333    fn full_roster(&self, ids: &[String]) -> Result<Vec<AgentSpec>> {
2334        if ids.is_empty() {
2335            Ok(self.agents.clone())
2336        } else {
2337            ids.iter().map(|id| self.agent(id).cloned()).collect()
2338        }
2339    }
2340
2341    /// Fill the roles out to the configured widths.
2342    ///
2343    /// An empty role list rotates through the whole roster, so a three-agent
2344    /// roster with `implementers = 3` gives one implementation per agent, and
2345    /// `judges = 3` rotates the judge seats by one so that judge *i* is not the
2346    /// author of candidate *i* whenever the roster has more than one agent.
2347    pub fn resolve_roles(&self) -> Result<ResolvedRoles> {
2348        if self.agents.is_empty() {
2349            bail!(
2350                "agent roster is empty: no agent CLI found on PATH and no \
2351                 [[agents]] in the config. Run `magi init` to write a starter \
2352                 magi.toml."
2353            );
2354        }
2355        let pinned = self
2356            .graph
2357            .selected_implementer
2358            .as_ref()
2359            .map(|id| self.agent(id).cloned())
2360            .transpose()?;
2361        Ok(ResolvedRoles {
2362            implementers: match &pinned {
2363                Some(agent) => vec![agent.clone()],
2364                None => self.rotate(&self.roles.implementers, self.graph.implementers, 0)?,
2365            },
2366            judges: self.rotate(&self.roles.judges, self.graph.judges, 1)?,
2367            reviewers: self.rotate(&self.roles.reviewers, self.graph.reviewers, 0)?,
2368            fixer: match self.roles.fixer.as_ref() {
2369                // Ids are validated against the roster here; whether the CLI
2370                // is installed is left to invocation, like every other seat.
2371                Some(choice) => Some(crate::agent::pick_chain(
2372                    &self.agents,
2373                    Some(choice),
2374                    &|_| true,
2375                    "fixer",
2376                )?),
2377                None => None,
2378            },
2379            // Role resolution validates roster shape, but deliberately does
2380            // not preflight a CLI. The other graph seats have always deferred
2381            // that failure to invocation; doing it only for the conductor
2382            // made otherwise usable graph commands and `doctor` fail as one.
2383            conductor: match self.roles.conductor.as_ref().map(AgentChoice::ids) {
2384                Some(ids) if ids.len() == 1 => self.agent(ids[0])?.clone(),
2385                // A fallback chain: the first id the roster knows. The rest
2386                // are `agent::pick_chain`'s business at invocation.
2387                Some(ids) if !ids.is_empty() => ids
2388                    .iter()
2389                    .find_map(|id| self.agent(id).ok())
2390                    .cloned()
2391                    .with_context(|| {
2392                        format!("[roles] conductor names no agent in the roster: {ids:?}")
2393                    })?,
2394                // Keep the normal standalone-seat preference when something
2395                // is installed, but retain a roster fallback when it is not.
2396                // Invocation then reports the unavailable CLI in the same
2397                // place it does for every other graph role.
2398                _ => crate::agent::pick(&self.agents, None, &crate::agent::installed)
2399                    .unwrap_or_else(|_| self.agents[0].clone()),
2400            },
2401            implementer_roster: match pinned {
2402                Some(agent) => vec![agent],
2403                None => self.full_roster(&self.roles.implementers)?,
2404            },
2405            judge_roster: self.full_roster(&self.roles.judges)?,
2406            reviewer_roster: self.full_roster(&self.roles.reviewers)?,
2407        })
2408    }
2409
2410    /// Advisor seats for the design-deliberation stage (see
2411    /// `graph::Runner::advise`): `[roles] advisors` when set, otherwise the
2412    /// judge roster - see [`Roles::advisors`] for why that fallback and not
2413    /// the whole roster.
2414    ///
2415    /// The fallback rotates with `offset = 1`, matching the judges line in
2416    /// [`Config::resolve_roles`] exactly, `ids` and offset both - not just
2417    /// `roles.judges`, which is empty whenever judges themselves are
2418    /// unconfigured and rotating the whole roster. Falling back with
2419    /// `offset = 0` there would silently hand the advisors a *different*
2420    /// agent set than the judges an unconfigured run would actually get,
2421    /// which is the one thing [`Roles::advisors`]'s doc promises will not
2422    /// happen.
2423    ///
2424    /// Called lazily from the graph node itself rather than folded into
2425    /// [`Config::resolve_roles`]: unlike the other roles, a failure here must
2426    /// not stop a run from starting at all - the deliberation stage is an
2427    /// enrichment `[graph] advise` can turn off, not a seat later nodes
2428    /// cannot proceed without - and at the point `resolve_roles` runs (before
2429    /// [`crate::run::RunState`] exists, on `Runner::start`) there would be no
2430    /// run yet for a resolution failure to be reported against.
2431    pub fn advisors(&self) -> Result<Vec<AgentSpec>> {
2432        if self.agents.is_empty() {
2433            bail!(
2434                "agent roster is empty: no agent CLI found on PATH and no \
2435                 [[agents]] in the config. Run `magi init` to write a starter \
2436                 magi.toml."
2437            );
2438        }
2439        if !self.roles.advisors.is_empty() {
2440            return self.rotate(&self.roles.advisors, self.graph.advisors, 0);
2441        }
2442        self.rotate(&self.roles.judges, self.graph.advisors, 1)
2443    }
2444
2445    /// The untruncated roster advisor seats hand over along: `[roles]
2446    /// advisors` when set, otherwise the judges' roster, exactly as
2447    /// [`Self::advisors`] chooses its own list.
2448    pub fn advisor_roster(&self) -> Result<Vec<AgentSpec>> {
2449        if self.roles.advisors.is_empty() {
2450            self.full_roster(&self.roles.judges)
2451        } else {
2452            self.full_roster(&self.roles.advisors)
2453        }
2454    }
2455
2456    /// Shell prefix for [`Verify`] commands.
2457    pub fn shell(&self) -> Vec<String> {
2458        if let Some(s) = &self.verify.shell {
2459            return s.clone();
2460        }
2461        if which("sh") {
2462            vec!["sh".to_owned(), "-c".to_owned()]
2463        } else {
2464            vec!["cmd".to_owned(), "/C".to_owned()]
2465        }
2466    }
2467
2468    /// Starter config, as written by `magi init`.
2469    pub fn starter_toml() -> String {
2470        let detected = Self::autodetected();
2471        let mut s = String::from(
2472            "# magi — blind multi-agent implementation competition.\n\
2473             # `magi run \"<task>\"` walks: implement (N parallel worktrees)\n\
2474             #   -> blind judging -> deliberation -> private final vote\n\
2475             #   -> fold losers -> review + E2E loop -> gate -> merge.\n\
2476             #\n\
2477             # Rendered by teravars: a `[vars]` table, env\n\
2478             # and system lookups, and `include = [...]` all work. Tera\n\
2479             # braces are live everywhere in this file, but comments are\n\
2480             # stripped before rendering (teravars >= 0.2.2), so a comment\n\
2481             # may quote `{{ ... }}` freely.\n\
2482             #\n\
2483             # Layers deep-merge in increasing\n\
2484             # precedence, so the roster can live once per machine in\n\
2485             # <config_dir>/magi/config.toml and each repo only states its own\n\
2486             # gate:\n\
2487             #   <config_dir>/magi/config.toml  <  .magi/config.toml  <  magi.toml\n\n\
2488             [vars]\n\
2489             # Reference it as vars.cache inside Tera braces, anywhere below.\n\
2490             # Single quotes inside the braces: teravars renders the raw file\n\
2491             # text, so TOML's own \\\" escaping never reaches Tera.\n\
2492             cache = \"{{ env.MAGI_CACHE | default(value='/tmp') }}\"\n\n",
2493        );
2494        if detected.agents.is_empty() {
2495            s.push_str(
2496                "# No agent CLI was found on PATH. Fill this in by hand.\n\
2497                 # kind = claude | opencode | antigravity | codex | command\n\
2498                 [[agents]]\nid = \"opus\"\nkind = \"claude\"\nmodel = \"opus\"\n\n",
2499            );
2500        } else {
2501            for a in &detected.agents {
2502                s.push_str("[[agents]]\n");
2503                s.push_str(&format!("id = {:?}\n", a.id));
2504                s.push_str(&format!("kind = {:?}\n", a.kind.as_str()));
2505                if let Some(m) = &a.model {
2506                    s.push_str(&format!("model = {m:?}\n"));
2507                }
2508                s.push('\n');
2509            }
2510        }
2511        s.push_str(
2512            "# Leave a role list empty to rotate through the roster.\n\
2513             # A non-empty list is also an ordered backup list: seats take entries from the\n\
2514             # front (see [graph] counts) and a failed or out-of-quota seat moves on to the\n\
2515             # next agent to its right, each tried once. Same for judges and reviewers.\n\
2516             # implementers = [\"opus\", \"codex\", \"sonnet\"]  # with implementers = 1 below: opus sits, codex then sonnet are spares\n\
2517             [roles]\n\
2518             implementers = []\n\
2519             judges = []\n\
2520             reviewers = []\n\
2521             # conductor = \"opus\"  # arranges the queue; unset picks a seat like chatter does\n\
2522             # synthesizer = \"opus\"  # blends the advisors into one brief; unset picks a seat like chatter does\n\
2523             # synthesizer = [\"opus\", \"codex\"]  # array form: fallback chain, each tried once on quota or failure\n\
2524             # language_judge = \"jev\"  # kind = \"command\" wrapper deciding if PR text is English; unset keeps the built-in heuristics\n\
2525             # dupes_judge = \"opus\"  # judges duplicate-work claims; unset inherits chatter (string or fallback chain)\n\
2526             # fixer = \"opus\"  # applies review findings; unset keeps the winner's own author\n\
2527             # fixer = [\"opus\", \"codex\"]  # array form: fallback chain, each tried once on quota or failure\n\n\
2528             [graph]\n\
2529             # Gate GitHub prose; secret redaction is always enabled.\n\
2530             github_text_guard = true\n\
2531             # Language of PR / issue titles, bodies and comments; non-English drops the English-only check (commits stay English).\n\
2532             github_language = \"en\"\n\
2533             implementers = 3\n\
2534             judges = 3\n\
2535             deliberate_rounds = 1\n\
2536             reviewers = 3\n\
2537             review_rounds = 6\n\
2538             # Fix rounds a failing verify.gate gets before the run is blocked (0 = none).\n\
2539             gate_fix_rounds = 1\n\
2540             # Rerun a failed required CI check once before a land fix round (flaky tests).\n\
2541             rerun_flaky_checks = true\n\
2542             # Rerun a failed verify.e2e once on the same commit before deciding; a pass is recorded as a flake and filed once as a task.\n\
2543             rerun_failed_e2e = true\n\
2544             # Port the strengths judges named in the losing candidates onto the\n\
2545             # winner before review (best-effort; rolled back on failure or a big diff).\n\
2546             graft_runner_up = true\n\
2547             max_parallel = 4\n\
2548             language = \"en\"\n\
2549             # One CLI conversation per seat: judges keep their own argument\n\
2550             # across deliberation, the fixer keeps its implementation context.\n\
2551             sessions = true\n\
2552             # Reviewer-seat timeout. When timeout_verify is omitted, E2E and\n\
2553             # the final gate inherit this value for compatibility.\n\
2554             timeout_review = 1200\n\
2555             # Optional independent E2E/final-gate timeout; uncomment to keep\n\
2556             # verification independent if timeout_review changes later.\n\
2557             # timeout_verify = 1200\n\
2558             # Longest a seat waits for the shared build cache before it is\n\
2559             # spawned. Never counted against an agent's own timeout; expiry\n\
2560             # holds the run (resumable) instead of failing the agent.\n\
2561             # timeout_resource_wait = 1800\n\n\
2562             # What the chat calls you (persona address and the Chat's turn label).\n\
2563             # [talk]\n\
2564             # standing_authorization = false # machine layer only; bounded chat recovery\n\
2565             # operator_name = \"Commander\"\n\n\
2566             # Chat personas (tone only; the web Chat picks one per conversation).\n\
2567             # Built in: magi, rei, misato, ritsuko, shinji, asuka, kaworu. Entries add to\n\
2568             # them, and one with a built-in's id replaces it. `default` is the plain\n\
2569             # voice and cannot be redefined (it may only set `icon`). Declare this in one\n\
2570             # layer only. `icon` is an optional avatar, display only: an absolute or\n\
2571             # ~/ path to a png/jpg/gif/webp, or a data:image/...;base64 URI, up to\n\
2572             # 256 KiB; a missing or bad one falls back to the built-in avatar.\n\
2573             # [[talk.personas]]\n\
2574             # id = \"gendo\"\n\
2575             # name = \"Gendo Ikari\"\n\
2576             # prompt = \"Speak coldly and tersely, hands folded.\"\n\
2577             # icon = \"~/pictures/gendo.png\"\n\n\
2578             [verify]\n\
2579             # Run once per review round in the winner's worktree; failures are\n\
2580             # fed back to the fixer.\n\
2581             e2e = []\n\
2582             # Final gate. Every command must exit 0 before a merge.\n\
2583             gate = []\n\
2584             # Mechanical fixers (formatters) run in the winner's worktree before\n\
2585             # e2e and before the gate; whatever they change becomes one commit. A\n\
2586             # failing command only warns - the gate stays the arbiter. Same timeout\n\
2587             # as the gate (timeout_verify). Keep it light and idempotent.\n\
2588             # pre_gate = []\n\n\
2589             # Prepare each worktree magi creates (candidates, judges, advisors,\n\
2590             # reviewers, the operator-fix and review-takeover checkouts), in order,\n\
2591             # before any agent or verify command touches it. `copy` reads from the\n\
2592             # primary checkout and never overwrites; `optional` skips a missing\n\
2593             # source. `run` goes through the shell with the worktree as cwd and\n\
2594             # fails the seat on a non-zero exit or timeout (timeout_secs, default\n\
2595             # the verify timeout). Setup must not edit tracked files, and what it\n\
2596             # leaves untracked is kept out of magi's commits. Declare this in one\n\
2597             # layer only.\n\
2598             # [worktree]\n\
2599             # setup = [\n\
2600             #   { copy = \".env.example -> .env\" },\n\
2601             #   { copy = \".env.local\", optional = true },\n\
2602             #   { run = \"pnpm install --frozen-lockfile\", timeout_secs = 900 },\n\
2603             # ]\n\
2604             # pre_clean = [] # Repeatable cleanup before owned clean -fdx.\n\n\
2605             [merge]\n\
2606             # none | local | pr\n\
2607             mode = \"none\"\n\
2608             # expected (default) | none. Set none only in repository config without CI.\n\
2609             # Ignores all check statuses; reviews and approval still apply.\n\
2610             # ci = \"expected\"\n\
2611             # release_bump = true  # Rust (Cargo.toml) repositories only; a no-op elsewhere\n\n\
2612             [update]\n\
2613             # off | notify | install — checked in the background, throttled.\n\
2614             mode = \"notify\"\n\
2615             # interval = \"24h\"\n\n\
2616             # Opt-in: magi web updates and restarts only after runs/chats finish.\n\
2617             # auto_restart = false\n\
2618             # Uses interval above; off / MAGI_NO_AUTOUPDATE disable it.\n\
2619             # Standalone magi serve cannot restart. Busy work waits indefinitely.\n\
2620             # Failed tags are skipped until process restart or a different tag.\n\
2621             # Older binaries reject auto_restart: upgrade before adding the key.\n\n\
2622             [daemon]\n\
2623             # Minutes a release-bump pull request (chore/release-v*) may sit with\n\
2624             # no new commit and no check changing state before `magi serve`\n\
2625             # notices and asks you. A failed check is rerun once on its own;\n\
2626             # still red after that escalates at once. 0 turns the watcher off.\n\
2627             # release_stall_minutes = 60\n\n\
2628             [release]\n\
2629             # actions (default) | local. \"local\" is for repositories whose GitHub\n\
2630             # Actions never run (private, no minutes): the release pull request\n\
2631             # does not wait for CI, you approve the merge in magi, and then\n\
2632             # `magi serve` pushes the vX.Y.Z tag (never over an existing one) and\n\
2633             # runs `commands` from a clean checkout of the merge commit. A\n\
2634             # failure holds the release with a notice; it is never retried blind.\n\
2635             # Needs `magi serve` running and [daemon] release_stall_minutes > 0.\n\
2636             # For ordinary pull requests without CI, also set [merge] ci = \"none\".\n\
2637             # mode = \"actions\"\n\
2638             # Run in order; the first failure stops. They see MAGI_RELEASE_VERSION,\n\
2639             # MAGI_RELEASE_TAG, MAGI_RELEASE_COMMIT and MAGI_RELEASE_PR. Make them\n\
2640             # safe to repeat: a crash mid-command is treated as unfinished.\n\
2641             # commands = [\"cargo build --release\", \"gh release create \\\"$MAGI_RELEASE_TAG\\\" --generate-notes\"]\n\
2642             # timeout_minutes = 30\n\
2643             # Repositories whose Cargo.toml is not at the root (e.g. a Tauri app).\n\
2644             # The first entry is the version of record and must be the file the\n\
2645             # repository's auto-tag.yml reads (kind \"cargo\"); the others are\n\
2646             # rewritten to the same version. Paths are relative to the repository\n\
2647             # root. Cargo.lock beside the first entry follows; package-lock.json\n\
2648             # is not touched.\n\
2649             # version_files = [\n\
2650             #   { path = \"src-tauri/Cargo.toml\", kind = \"cargo\" },\n\
2651             #   { path = \"package.json\", kind = \"json\" },\n\
2652             #   { path = \"src-tauri/tauri.conf.json\", kind = \"json\" },\n\
2653             # ]\n",
2654        );
2655        s
2656    }
2657}
2658
2659/// Is `program` on `PATH`?
2660pub fn which(program: &str) -> bool {
2661    find_program(program).is_some()
2662}
2663
2664/// The file a bare `program` name resolves to on `PATH`, the way the OS shell
2665/// would find it.
2666///
2667/// Spawn agents through this, not by bare name: on Windows Rust's std
2668/// only tries `name.exe`, so a CLI installed as an npm `.cmd` shim (codex
2669/// since its 2026-09-23 reinstall) is "not found" even though a shell runs it.
2670/// On Windows an extensionless file is never a match: npm writes an `sh`
2671/// script beside every `.cmd` shim, and spawning that fails with os error 193.
2672pub fn find_program(program: &str) -> Option<PathBuf> {
2673    find_program_on(program, &std::env::var_os("PATH")?)
2674}
2675
2676/// [`find_program`] against an explicit `PATH`, for a child whose environment
2677/// overrides it.
2678pub fn find_program_on(program: &str, paths: &std::ffi::OsStr) -> Option<PathBuf> {
2679    let pathext = std::env::var("PATHEXT").unwrap_or_else(|_| ".EXE;.CMD;.BAT".into());
2680    find_program_in(program, paths, cfg!(windows).then_some(pathext.as_str()))
2681}
2682
2683fn find_program_in(
2684    program: &str,
2685    paths: &std::ffi::OsStr,
2686    pathext: Option<&str>,
2687) -> Option<PathBuf> {
2688    let p = Path::new(program);
2689    if p.components().count() > 1 {
2690        return p.is_file().then(|| p.to_path_buf());
2691    }
2692    std::env::split_paths(paths).find_map(|dir| match pathext {
2693        Some(exts) => {
2694            let bare = dir.join(program);
2695            if p.extension().is_some() && bare.is_file() {
2696                return Some(bare);
2697            }
2698            exts.split(';')
2699                .filter(|e| !e.is_empty())
2700                .map(|e| dir.join(format!("{program}{}", e.to_lowercase())))
2701                .find(|c| c.is_file())
2702        }
2703        None => Some(dir.join(program)).filter(|c| c.is_file()),
2704    })
2705}
2706
2707/// Sidecar naming the checkout an extracted layer stands for.
2708const REPO_MARKER: &str = ".magi-repo";
2709
2710fn git_out(repo: &Path, args: &[&str]) -> Option<String> {
2711    use crate::proc::Quiet as _;
2712    #[cfg(test)]
2713    crate::web::request_cost::git();
2714    let out = std::process::Command::new("git")
2715        .args(args)
2716        .quiet()
2717        .current_dir(repo)
2718        .stdin(std::process::Stdio::null())
2719        .output()
2720        .ok()?;
2721    out.status
2722        .success()
2723        .then(|| String::from_utf8_lossy(&out.stdout).into_owned())
2724}
2725
2726/// Is `repo` inside a git working tree? A directory that is not has no branch
2727/// to be stale against, so its files are read as they are.
2728fn is_git_worktree(repo: &Path) -> bool {
2729    git_out(repo, &["rev-parse", "--git-dir"]).is_some()
2730}
2731
2732/// Approval switches whose reviewed-branch values can only add owner holds.
2733/// Keep the allowlist and base-value lookup together when adding a switch.
2734#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
2735pub enum OwnerHold {
2736    /// Ask before every merge.
2737    LandApproval,
2738    /// Ask when internal review remains contested.
2739    HoldContestedMerge,
2740}
2741
2742impl OwnerHold {
2743    /// Complete allowlist of additive approval switches.
2744    pub const ALL: [Self; 2] = [Self::LandApproval, Self::HoldContestedMerge];
2745
2746    /// TOML key in the graph table.
2747    pub fn key(self) -> &'static str {
2748        match self {
2749            Self::LandApproval => "land_approval",
2750            Self::HoldContestedMerge => "hold_contested_merge",
2751        }
2752    }
2753
2754    /// Value from the trusted configuration snapshot.
2755    pub fn base_value(self, graph: &Graph) -> bool {
2756        match self {
2757            Self::LandApproval => graph.land_approval,
2758            Self::HoldContestedMerge => graph.hold_contested_merge,
2759        }
2760    }
2761}
2762
2763/// Literal true values only: no defaults, includes, rendering or other config.
2764/// Both repository files contribute monotonically, independent of precedence.
2765pub async fn branch_owner_holds(
2766    repo: &Path,
2767    head: &str,
2768) -> (Vec<(OwnerHold, String)>, Vec<String>) {
2769    let mut holds = Vec::new();
2770    let mut diagnostics = Vec::new();
2771    // Git can report a missing path even when the commit itself is absent.
2772    // Distinguish that read failure before treating missing files as normal.
2773    if let Err(error) =
2774        crate::git::git(repo, &["cat-file", "-e", &format!("{head}^{{commit}}")]).await
2775    {
2776        diagnostics.push(format!("cannot read reviewed commit {head}: {error:#}"));
2777        return (holds, diagnostics);
2778    }
2779    for file in ["magi.toml", ".magi/config.toml"] {
2780        let object = format!("{head}:{file}");
2781        let text = match crate::git::git(repo, &["show", &object]).await {
2782            Ok(text) => text,
2783            Err(error) => {
2784                // Absence is normal; other read failures remain auditable.
2785                let error = format!("{error:#}");
2786                if !error.contains("does not exist in")
2787                    && !error.contains("exists on disk, but not in")
2788                {
2789                    diagnostics.push(format!(
2790                        "cannot read reviewed branch {file} at {head}: {error}"
2791                    ));
2792                }
2793                continue;
2794            }
2795        };
2796        let value = match toml::from_str::<toml::Value>(&text) {
2797            Ok(value) => value,
2798            Err(error) => {
2799                diagnostics.push(format!(
2800                    "cannot parse reviewed branch {file} at {head}: {error}"
2801                ));
2802                continue;
2803            }
2804        };
2805        if value.get("include").is_some() || text.contains("{{") || text.contains("{%") {
2806            diagnostics.push(format!("reviewed branch {file} at {head}: only literal owner holds are read; includes and templates are ignored"));
2807        }
2808        for hold in OwnerHold::ALL {
2809            if value
2810                .get("graph")
2811                .and_then(|g| g.get(hold.key()))
2812                .and_then(toml::Value::as_bool)
2813                == Some(true)
2814            {
2815                holds.push((hold, file.to_owned()));
2816            }
2817        }
2818    }
2819    (holds, diagnostics)
2820}
2821
2822#[derive(Deserialize, Default)]
2823struct ProbeMerge {
2824    base: Option<String>,
2825    remote: Option<String>,
2826}
2827
2828#[derive(Deserialize, Default)]
2829struct Probe {
2830    merge: Option<ProbeMerge>,
2831}
2832
2833/// `[merge]` base / remote from one file, nothing else. The file is rendered
2834/// (env templates, includes) exactly as a real load would, so a machine layer
2835/// saying `base = "{{ env.X }}"` locates the same ref; when rendering fails
2836/// (a checkout file that needs its own repo context) the plain TOML is read
2837/// instead. Unreadable is `None`: the real load reports it.
2838fn probe_merge(path: &Path, repo: &Path) -> Option<ProbeMerge> {
2839    if !path.is_file() {
2840        return None;
2841    }
2842    let paths = [path.to_path_buf()];
2843    let mut engine = teravars::Engine::default();
2844    let mut ctx = Config::render_ctx(&paths);
2845    // The layered load renders every layer for the checkout being resolved;
2846    // so does this, or `{{ repo_name }}` would name the file's own directory.
2847    ctx.insert("repo", &repo.to_string_lossy());
2848    ctx.insert(
2849        "repo_name",
2850        &repo.file_name().unwrap_or_default().to_string_lossy(),
2851    );
2852    if let Ok(merged) = teravars::load_merged(&paths, &mut engine, &ctx)
2853        && let Ok(probe) = toml::Value::Table(merged.config).try_into::<Probe>()
2854    {
2855        return probe.merge;
2856    }
2857    let text = std::fs::read_to_string(path).ok()?;
2858    toml::from_str::<Probe>(&text).ok()?.merge
2859}
2860
2861/// The `[merge] remote` / `base` the layers name, before any git lookup.
2862fn probe_remote_base(repo: &Path) -> (String, Option<String>) {
2863    let mut remote = None;
2864    let mut base = None;
2865    let mut sources: Vec<PathBuf> = Config::machine_layer().into_iter().collect();
2866    sources.push(repo.join("magi.toml"));
2867    sources.push(repo.join(".magi").join("config.toml"));
2868    for path in sources {
2869        if let Some(m) = probe_merge(&path, repo) {
2870            remote = remote.or(m.remote.filter(|s| !s.trim().is_empty()));
2871            base = base.or(m.base.filter(|s| !s.trim().is_empty()));
2872        }
2873    }
2874    (remote.unwrap_or_else(|| "origin".to_owned()), base)
2875}
2876
2877/// Where the remote ref is: see the module doc for the order.
2878fn resolve_remote_base(repo: &Path) -> Result<(String, String)> {
2879    let (remote, base) = probe_remote_base(repo);
2880    let base = match base {
2881        Some(b) => b,
2882        None => {
2883            let head = format!("refs/remotes/{remote}/HEAD");
2884            git_out(repo, &["symbolic-ref", "--quiet", &head])
2885                .and_then(|s| crate::git::remote_head_branch(&remote, &s))
2886                .with_context(|| {
2887                    format!(
2888                        "cannot tell which branch of `{remote}` holds magi.toml: \
2889                         set [merge] base, or run `git remote set-head {remote} -a`"
2890                    )
2891                })?
2892        }
2893    };
2894    Ok((remote, base))
2895}
2896
2897fn fnv_hex(text: &str) -> String {
2898    let mut hash: u64 = 0xcbf2_9ce4_8422_2325;
2899    for b in text.bytes() {
2900        hash ^= u64::from(b);
2901        hash = hash.wrapping_mul(0x0100_0000_01b3);
2902    }
2903    format!("{hash:016x}")
2904}
2905
2906/// Does the text declare an `include` directive in any form teravars accepts
2907/// (root `include`, bare or quoted, or `[teravars] include`, as a table or an
2908/// inline table)? Parsed as TOML when it parses; a templated file that does
2909/// not parse is judged by a plain search for the word, because over-detecting
2910/// only costs an extra extraction while missing one fails the load.
2911fn declares_include(text: &str) -> bool {
2912    match toml::from_str::<toml::Table>(text) {
2913        Ok(table) => {
2914            table.contains_key("include")
2915                || table
2916                    .get("teravars")
2917                    .and_then(toml::Value::as_table)
2918                    .is_some_and(|t| t.contains_key("include"))
2919        }
2920        Err(_) => text.contains("include"),
2921    }
2922}
2923
2924/// Unpack the whole tree of `sha` into `dest`, so relative `include`s of a
2925/// repository layer resolve against the same commit.
2926fn extract_tree(repo: &Path, sha: &str, dest: &Path) -> Result<()> {
2927    use crate::proc::Quiet as _;
2928    #[cfg(test)]
2929    crate::web::request_cost::git();
2930    let mut archive = std::process::Command::new("git")
2931        .args(["archive", "--format=tar", sha])
2932        .quiet()
2933        .current_dir(repo)
2934        .stdin(std::process::Stdio::null())
2935        .stdout(std::process::Stdio::piped())
2936        .stderr(std::process::Stdio::null())
2937        .spawn()
2938        .context("running git archive")?;
2939    let tar = std::process::Command::new("tar")
2940        .arg("-x")
2941        .arg("-C")
2942        .arg(dest)
2943        .quiet()
2944        .stdin(archive.stdout.take().context("git archive has no stdout")?)
2945        .output()
2946        .context("running tar")?;
2947    let status = archive.wait().context("waiting for git archive")?;
2948    if !status.success() || !tar.status.success() {
2949        bail!(
2950            "cannot unpack {sha} for the config's includes: {}",
2951            String::from_utf8_lossy(&tar.stderr).trim()
2952        );
2953    }
2954    Ok(())
2955}
2956
2957/// The repository layers (`.magi/config.toml`, `magi.toml`; lowest first) of
2958/// `<remote>/<base>`, extracted from one commit so both files agree.
2959fn remote_layers(repo: &Path) -> Result<Vec<PathBuf>> {
2960    let (remote, base) = resolve_remote_base(repo)?;
2961    let tracking = format!("refs/remotes/{remote}/{base}");
2962    let spec = format!("{tracking}^{{commit}}");
2963    let sha = git_out(repo, &["rev-parse", "--verify", "--quiet", &spec])
2964        .map(|s| s.trim().to_owned())
2965        .filter(|s| !s.is_empty())
2966        .with_context(|| {
2967            format!(
2968                "`{remote}/{base}` does not exist in this checkout; fetch it \
2969                 (`git fetch {remote} {base}`) or set [merge] base/remote. magi will not read \
2970                 a possibly stale local magi.toml instead"
2971            )
2972        })?;
2973    let key = format!("{sha}-{}", fnv_hex(&repo.to_string_lossy()));
2974    let rels = [".magi/config.toml", "magi.toml"];
2975    let mut texts: Vec<(&str, String)> = Vec::new();
2976    for rel in rels {
2977        let object = format!("{sha}:{rel}");
2978        if git_out(repo, &["cat-file", "-e", &object]).is_none() {
2979            continue;
2980        }
2981        let Some(text) = git_out(repo, &["show", &object]) else {
2982            bail!("cannot read {rel} from {remote}/{base} ({sha})");
2983        };
2984        texts.push((rel, text));
2985    }
2986    let wants_tree = texts.iter().any(|(_, t)| declares_include(t));
2987    // Content-addressed and built beside the final name, then renamed in: a
2988    // concurrent `discover` sees the whole directory or none of it, never a
2989    // half-written file.
2990    let build = |root: &Path| -> Result<PathBuf> {
2991        let final_dir = root.join(&key);
2992        if !final_dir.is_dir() {
2993            std::fs::create_dir_all(root)?;
2994            let tmp = root.join(format!(
2995                "{key}.tmp-{}-{}",
2996                std::process::id(),
2997                std::time::SystemTime::now()
2998                    .duration_since(std::time::UNIX_EPOCH)
2999                    .map(|d| d.as_nanos())
3000                    .unwrap_or_default()
3001            ));
3002            let filled = (|| -> Result<()> {
3003                std::fs::create_dir_all(&tmp)?;
3004                if wants_tree {
3005                    extract_tree(repo, &sha, &tmp)?;
3006                }
3007                for (rel, text) in &texts {
3008                    let file = tmp.join(rel);
3009                    let parent = file.parent().unwrap_or(&tmp);
3010                    std::fs::create_dir_all(parent)?;
3011                    std::fs::write(&file, text)?;
3012                    std::fs::write(parent.join(REPO_MARKER), repo.to_string_lossy().as_bytes())?;
3013                }
3014                Ok(())
3015            })();
3016            if let Err(e) = filled {
3017                let _ = std::fs::remove_dir_all(&tmp);
3018                return Err(e);
3019            }
3020            if std::fs::rename(&tmp, &final_dir).is_err() {
3021                // Lost the race to another process building the same commit.
3022                let _ = std::fs::remove_dir_all(&tmp);
3023                if !final_dir.is_dir() {
3024                    bail!("cannot place {}", final_dir.display());
3025                }
3026            }
3027        }
3028        Ok(final_dir)
3029    };
3030    let common = git_out(
3031        repo,
3032        &["rev-parse", "--path-format=absolute", "--git-common-dir"],
3033    )
3034    .map(|s| PathBuf::from(s.trim()).join("magi").join("config"));
3035    let dir = match common.map(|c| build(&c)) {
3036        Some(Ok(d)) => d,
3037        _ => build(&std::env::temp_dir().join("magi-config"))
3038            .with_context(|| format!("extracting config from {remote}/{base}"))?,
3039    };
3040    Ok(texts.iter().map(|(rel, _)| dir.join(rel)).collect())
3041}
3042
3043#[cfg(test)]
3044mod tests {
3045    #[test]
3046    fn standing_authorization_is_only_from_the_named_machine_layer() {
3047        let dir = tempfile::tempdir().unwrap();
3048        let machine = dir.path().join("machine.toml");
3049        let repo = dir.path().join("magi.toml");
3050        std::fs::write(&machine, "[talk]\nstanding_authorization = false\n").unwrap();
3051        std::fs::write(&repo, "[talk]\nstanding_authorization = true\n").unwrap();
3052        let layers = [machine.clone(), repo.clone()];
3053        let load = |paths| Config::load_layers_with_machine(paths, Some(machine.clone())).unwrap();
3054        assert!(!load(&layers).talk.standing_authorization);
3055        assert!(
3056            !load(std::slice::from_ref(&repo))
3057                .talk
3058                .standing_authorization
3059        );
3060        std::fs::write(&machine, "[talk]\nstanding_authorization = true\n").unwrap();
3061        std::fs::write(&repo, "[talk]\nstanding_authorization = false\n").unwrap();
3062        assert!(load(&layers).talk.standing_authorization);
3063    }
3064
3065    #[test]
3066    fn run_records_with_the_retired_editing_network_key_still_load() {
3067        // Run records from v0.205-v0.207 carry it in their config snapshot.
3068        for value in ["enabled", "restricted"] {
3069            let mut graph = serde_json::to_value(Graph::default()).unwrap();
3070            graph["editing_network"] = serde_json::json!(value);
3071            let back: Graph = serde_json::from_value(graph).unwrap();
3072            assert!(
3073                serde_json::to_value(&back)
3074                    .unwrap()
3075                    .get("editing_network")
3076                    .is_none()
3077            );
3078            let from_toml: Graph = toml::from_str(&format!("editing_network = {value:?}")).unwrap();
3079            assert!(
3080                !toml::to_string(&from_toml)
3081                    .unwrap()
3082                    .contains("editing_network")
3083            );
3084        }
3085    }
3086
3087    #[test]
3088    fn coordination_defaults_off_and_validates_rendered_layer_values() {
3089        let dir = tempfile::tempdir().unwrap();
3090        let machine = dir.path().join("machine.toml");
3091        let repo = dir.path().join("repo.toml");
3092        std::fs::write(&machine, "").unwrap();
3093        assert!(Config::default().coordination.is_none());
3094        assert!(Config::load(&machine).unwrap().coordination.is_none());
3095        std::fs::write(
3096            &machine,
3097            r#"
3098[vars]
3099contract = "updater.contract"
3100[coordination]
3101contract_file = "{{ vars.contract }}"
3102contract_token = "protocol-v1"
3103lock_file = "updater.lock"
3104"#,
3105        )
3106        .unwrap();
3107        let cfg = Config::load(&machine).unwrap();
3108        let policy = cfg.coordination.unwrap();
3109        assert_eq!(policy.contract_file, "updater.contract");
3110        assert_eq!(policy.contract_token, "protocol-v1");
3111        assert_eq!(policy.lock_file, "updater.lock");
3112        std::fs::write(&repo, "[coordination]\nlock_file = 'repository.lock'\n").unwrap();
3113        let cfg = Config::load_layers(&[machine.clone(), repo.clone()]).unwrap();
3114        let policy = cfg.coordination.unwrap();
3115        assert_eq!(policy.contract_file, "updater.contract");
3116        assert_eq!(policy.lock_file, "repository.lock");
3117        std::fs::write(
3118            &repo,
3119            r#"
3120[vars]
3121bad = "../escape"
3122[coordination]
3123lock_file = "{{ vars.bad }}"
3124"#,
3125        )
3126        .unwrap();
3127        let error = Config::load_layers(&[machine, repo]).unwrap_err();
3128        assert!(format!("{error:#}").contains("coordination.lock_file"));
3129    }
3130
3131    #[test]
3132    fn coordination_rejects_invalid_names_tokens_and_incomplete_sections() {
3133        let dir = tempfile::tempdir().unwrap();
3134        let path = dir.path().join("config.toml");
3135        let valid = toml::toml! {
3136            [coordination]
3137            contract_file = "updater.contract"
3138            contract_token = "protocol-v1"
3139            lock_file = "updater.lock"
3140        };
3141        for key in ["contract_file", "lock_file"] {
3142            for bad in [
3143                "",
3144                " ",
3145                " file",
3146                "file ",
3147                "\tfile",
3148                "file\t",
3149                ".",
3150                "..",
3151                "file..name",
3152                "../escape",
3153                "a/b",
3154                "a\\b",
3155                "/absolute",
3156                "C:drive",
3157                "C:\\absolute",
3158                "nul\0name",
3159            ] {
3160                let mut table = valid.clone();
3161                table["coordination"][key] = bad.into();
3162                std::fs::write(&path, toml::to_string(&table).unwrap()).unwrap();
3163                let error = Config::load(&path).unwrap_err();
3164                assert!(
3165                    format!("{error:#}").contains(&format!("coordination.{key}")),
3166                    "{bad:?}: {error:#}"
3167                );
3168            }
3169        }
3170        for bad in ["", " ", " token", "token ", "two\nlines", "two\rlines"] {
3171            let mut table = valid.clone();
3172            table["coordination"]["contract_token"] = bad.into();
3173            std::fs::write(&path, toml::to_string(&table).unwrap()).unwrap();
3174            let error = Config::load(&path).unwrap_err();
3175            assert!(
3176                format!("{error:#}").contains("coordination.contract_token"),
3177                "{error:#}"
3178            );
3179        }
3180        for key in ["contract_file", "contract_token", "lock_file"] {
3181            let mut table = valid.clone();
3182            table["coordination"].as_table_mut().unwrap().remove(key);
3183            std::fs::write(&path, toml::to_string(&table).unwrap()).unwrap();
3184            let error = Config::load(&path).unwrap_err();
3185            assert!(
3186                format!("{error:#}").contains(&format!("coordination.{key}")),
3187                "{error:#}"
3188            );
3189        }
3190        let mut table = valid;
3191        table["coordination"]
3192            .as_table_mut()
3193            .unwrap()
3194            .insert("typo".into(), "value".into());
3195        std::fs::write(&path, toml::to_string(&table).unwrap()).unwrap();
3196        assert!(format!("{:#}", Config::load(&path).unwrap_err()).contains("typo"));
3197    }
3198
3199    #[test]
3200    fn context_window_prefers_exact_then_longest_prefix_and_user_over_builtin() {
3201        let mut cfg = Config::default();
3202        assert_eq!(
3203            cfg.context_window("claude-sonnet-4-5-20250929"),
3204            Some(200_000)
3205        );
3206        assert_eq!(cfg.context_window("gpt-4.1-mini"), Some(1_000_000));
3207        assert_eq!(cfg.context_window("mystery-model"), None);
3208        cfg.context_windows
3209            .insert("claude-sonnet-4-5".into(), 1_000_000);
3210        cfg.context_windows.insert("claude-sonnet-4".into(), 5);
3211        cfg.context_windows.insert("mystery".into(), 32_768);
3212        // Longest user prefix beats a shorter one and the built-in table.
3213        assert_eq!(
3214            cfg.context_window("claude-sonnet-4-5-20250929"),
3215            Some(1_000_000)
3216        );
3217        // An exact name beats any prefix.
3218        cfg.context_windows
3219            .insert("claude-sonnet-4-5-20250929".into(), 7);
3220        assert_eq!(cfg.context_window("claude-sonnet-4-5-20250929"), Some(7));
3221        assert_eq!(cfg.context_window("mystery-model"), Some(32_768));
3222    }
3223
3224    use super::*;
3225
3226    /// npm writes an extensionless `sh` script beside `codex.cmd`; on Windows
3227    /// the `.cmd` is the spawnable one (os error 193 otherwise, 2026-09-23).
3228    #[test]
3229    fn windows_lookup_picks_the_cmd_shim_over_the_extensionless_script() {
3230        let dir = tempfile::tempdir().unwrap();
3231        std::fs::write(dir.path().join("codex"), "#!/bin/sh\n").unwrap();
3232        std::fs::write(dir.path().join("codex.cmd"), "@echo off\n").unwrap();
3233        let paths = dir.path().as_os_str();
3234        assert_eq!(
3235            find_program_in("codex", paths, Some(".EXE;.CMD")),
3236            Some(dir.path().join("codex.cmd"))
3237        );
3238        assert_eq!(
3239            find_program_in("codex", paths, None),
3240            Some(dir.path().join("codex"))
3241        );
3242        assert_eq!(find_program_in("claude", paths, Some(".EXE;.CMD")), None);
3243    }
3244
3245    fn spec(id: &str) -> AgentSpec {
3246        AgentSpec {
3247            id: id.to_owned(),
3248            kind: AgentKind::Command,
3249            model: None,
3250            command: vec!["true".to_owned()],
3251            extra_args: Vec::new(),
3252            env: BTreeMap::new(),
3253            prompt_delivery: None,
3254            max_turn_secs: None,
3255        }
3256    }
3257
3258    #[test]
3259    fn merge_ci_defaults_expected_and_requires_an_explicit_valid_opt_out() {
3260        let default: Merge = toml::from_str("").unwrap();
3261        assert_eq!(default.ci, MergeCi::Expected);
3262        let config = layered("", "[merge]\nci = \"none\"\n").unwrap();
3263        assert_eq!(
3264            config.merge.ci.expectation(),
3265            crate::land::CiExpectation::Absent
3266        );
3267        assert!(toml::from_str::<Merge>("ci = \"typo\"").is_err());
3268        assert!(Config::starter_toml().contains("# ci = \"expected\""));
3269    }
3270
3271    #[test]
3272    fn github_text_guard_defaults_on_and_can_be_disabled() {
3273        let default: Graph = toml::from_str("").unwrap();
3274        assert!(default.github_text_guard);
3275        let disabled: Graph = toml::from_str("github_text_guard = false").unwrap();
3276        assert!(!disabled.github_text_guard);
3277        let config = layered("", "[graph]\ngithub_text_guard = false\n").unwrap();
3278        assert!(!config.graph.github_text_guard);
3279        assert!(Config::starter_toml().contains("github_text_guard = true"));
3280    }
3281
3282    #[test]
3283    fn rerun_flaky_checks_defaults_on_and_is_in_the_starter() {
3284        assert!(Graph::default().rerun_flaky_checks);
3285        let off: Graph = toml::from_str("rerun_flaky_checks = false").unwrap();
3286        assert!(!off.rerun_flaky_checks);
3287        assert!(Config::starter_toml().contains("rerun_flaky_checks = true"));
3288    }
3289
3290    #[test]
3291    fn timeout_verify_omitted_from_old_toml_inherits_timeout_review() {
3292        // `timeout_verify` used to not exist: `verify.e2e`/`verify.gate` ran
3293        // under `timeout_review`. A config written before this field existed
3294        // must run exactly as before, which means its default has to be the
3295        // same 1200s `timeout_review` has always defaulted to.
3296        let g: Graph = toml::from_str("timeout_review = 3600").expect("parse");
3297        assert_eq!(g.timeout_verify, None);
3298        assert_eq!(g.verify_timeout(), 3600);
3299    }
3300
3301    #[test]
3302    fn shrinking_timeout_review_does_not_shrink_timeout_verify() {
3303        // The bug this field exists to close: `[graph] timeout_review = 45`
3304        // used to shrink the real-machine `verify.e2e`/`verify.gate` budget
3305        // along with the reviewer seats' own timeout, because both read the
3306        // same field.
3307        let g: Graph = toml::from_str("timeout_review = 45").expect("parse");
3308        assert_eq!(g.timeout_review, 45);
3309        assert_eq!(
3310            g.verify_timeout(),
3311            45,
3312            "an omitted legacy value follows review"
3313        );
3314        let explicit: Graph = toml::from_str("timeout_review = 45\ntimeout_verify = 1200")
3315            .expect("parse explicit override");
3316        assert_eq!(explicit.verify_timeout(), 1200);
3317    }
3318
3319    #[test]
3320    fn graph_implementers_new_key_loads_and_old_key_is_an_alias() {
3321        let g: Graph = toml::from_str("implementers = 4\n").unwrap();
3322        assert_eq!(g.implementers, 4);
3323        let g: Graph = toml::from_str("candidates = 5\n").unwrap();
3324        assert_eq!(g.implementers, 5);
3325    }
3326
3327    fn layered(lower: &str, upper: &str) -> Result<Config> {
3328        let dir = tempfile::tempdir().unwrap();
3329        let a = dir.path().join("a.toml");
3330        let b = dir.path().join("b.toml");
3331        std::fs::write(&a, lower).unwrap();
3332        std::fs::write(&b, upper).unwrap();
3333        Config::load_layers(&[a, b])
3334    }
3335
3336    #[test]
3337    fn graph_implementers_higher_layer_wins_across_spellings() {
3338        let c = layered("[graph]\ncandidates = 2\n", "[graph]\nimplementers = 5\n").unwrap();
3339        assert_eq!(c.graph.implementers, 5);
3340        let c = layered("[graph]\nimplementers = 2\n", "[graph]\ncandidates = 5\n").unwrap();
3341        assert_eq!(c.graph.implementers, 5);
3342        let c = layered("[graph]\ncandidates = 2\n", "[graph]\njudges = 3\n").unwrap();
3343        assert_eq!(c.graph.implementers, 2);
3344    }
3345
3346    #[test]
3347    fn graph_implementers_both_keys_in_one_layer_is_refused() {
3348        let err = layered("", "[graph]\ncandidates = 2\nimplementers = 3\n")
3349            .unwrap_err()
3350            .to_string();
3351        assert!(
3352            err.contains("candidates") && err.contains("implementers"),
3353            "{err}"
3354        );
3355        assert!(err.contains("b.toml"), "{err}");
3356    }
3357
3358    #[test]
3359    fn a_toml_layer_written_before_these_fields_existed_still_parses() {
3360        // `deny_unknown_fields` cuts both ways: a config from before
3361        // `timeout_verify`/`e2e_every_round` existed must still parse, with
3362        // both defaulted rather than refused as unknown-in-reverse.
3363        let g: Graph =
3364            toml::from_str("candidates = 1\nreviewers = 3\nreview_rounds = 6\nmax_parallel = 4\n")
3365                .expect("an old-shaped [graph] table must still parse");
3366        assert_eq!(g.verify_timeout(), Graph::default().timeout_review);
3367        assert!(
3368            !g.e2e_every_round,
3369            "off by default, same as before this field existed"
3370        );
3371    }
3372
3373    #[test]
3374    fn empty_roles_rotate_judges_off_their_own_candidate() {
3375        // Three seats, said out loud: this is a test about *rotation*, and it
3376        // has nothing to say about how many candidates a task buys by default.
3377        let cfg = Config {
3378            agents: vec![spec("a"), spec("b"), spec("c")],
3379            graph: Graph {
3380                implementers: 3,
3381                ..Graph::default()
3382            },
3383            ..Config::default()
3384        };
3385        let roles = cfg.resolve_roles().unwrap();
3386        let impls: Vec<&str> = roles.implementers.iter().map(|a| a.id.as_str()).collect();
3387        let judges: Vec<&str> = roles.judges.iter().map(|a| a.id.as_str()).collect();
3388        assert_eq!(impls, ["a", "b", "c"]);
3389        assert_eq!(judges, ["b", "c", "a"]);
3390        for (i, j) in judges.iter().enumerate() {
3391            assert_ne!(*j, impls[i], "judge {i} must not sit on its own candidate");
3392        }
3393    }
3394
3395    #[test]
3396    fn single_agent_roster_fills_every_seat() {
3397        let cfg = Config {
3398            agents: vec![spec("solo")],
3399            graph: Graph {
3400                implementers: 3,
3401                ..Graph::default()
3402            },
3403            ..Config::default()
3404        };
3405        let roles = cfg.resolve_roles().unwrap();
3406        assert_eq!(roles.implementers.len(), 3);
3407        assert!(roles.judges.iter().all(|a| a.id == "solo"));
3408    }
3409
3410    #[test]
3411    fn implementer_roster_is_the_whole_agent_list_untruncated_when_unset() {
3412        // `implementers = 1` (a solo run) still resolves `implementers` down to
3413        // one slot, but `implementer_roster` must carry every agent in the
3414        // roster, in file order, for `graph::Runner`'s quota fallback to walk
3415        // forward through once that one slot's agent runs out of quota.
3416        let cfg = Config {
3417            agents: vec![spec("a"), spec("b"), spec("c")],
3418            graph: Graph {
3419                implementers: 1,
3420                ..Graph::default()
3421            },
3422            ..Config::default()
3423        };
3424        let roles = cfg.resolve_roles().unwrap();
3425        assert_eq!(roles.implementers.len(), 1);
3426        let roster: Vec<&str> = roles
3427            .implementer_roster
3428            .iter()
3429            .map(|a| a.id.as_str())
3430            .collect();
3431        assert_eq!(roster, ["a", "b", "c"]);
3432    }
3433
3434    #[test]
3435    fn implementer_roster_follows_explicit_ids_in_the_order_named() {
3436        let cfg = Config {
3437            agents: vec![spec("a"), spec("b"), spec("c")],
3438            roles: Roles {
3439                implementers: vec!["c".to_owned(), "a".to_owned()],
3440                ..Roles::default()
3441            },
3442            graph: Graph {
3443                implementers: 1,
3444                ..Graph::default()
3445            },
3446            ..Config::default()
3447        };
3448        let roles = cfg.resolve_roles().unwrap();
3449        // Unaffected by the new field: still just the first named id.
3450        assert_eq!(roles.implementers.len(), 1);
3451        assert_eq!(roles.implementers[0].id, "c");
3452        let roster: Vec<&str> = roles
3453            .implementer_roster
3454            .iter()
3455            .map(|a| a.id.as_str())
3456            .collect();
3457        assert_eq!(roster, ["c", "a"]);
3458    }
3459
3460    #[test]
3461    fn explicit_roles_win() {
3462        let cfg = Config {
3463            agents: vec![spec("a"), spec("b")],
3464            roles: Roles {
3465                implementers: vec!["b".to_owned()],
3466                judges: vec!["a".to_owned()],
3467                reviewers: Vec::new(),
3468                fixer: Some("a".into()),
3469                ..Roles::default()
3470            },
3471            ..Config::default()
3472        };
3473        let roles = cfg.resolve_roles().unwrap();
3474        assert!(roles.implementers.iter().all(|a| a.id == "b"));
3475        assert!(roles.judges.iter().all(|a| a.id == "a"));
3476        let fixer = roles.fixer.unwrap();
3477        assert_eq!(fixer.len(), 1);
3478        assert_eq!(fixer[0].id, "a");
3479        assert_eq!(roles.conductor.id, "a");
3480    }
3481
3482    #[test]
3483    fn fixer_takes_a_string_or_an_ordered_chain() {
3484        let one: Roles = toml::from_str("fixer = \"a\"").unwrap();
3485        assert_eq!(one.fixer.as_ref().unwrap().ids(), ["a"]);
3486        let chain: Roles = toml::from_str("fixer = [\"b\", \"a\"]").unwrap();
3487        assert_eq!(chain.fixer.as_ref().unwrap().ids(), ["b", "a"]);
3488
3489        let resolve = |fixer: Option<AgentChoice>| {
3490            Config {
3491                agents: vec![spec("a"), spec("b"), spec("c")],
3492                roles: Roles {
3493                    fixer,
3494                    ..Roles::default()
3495                },
3496                ..Config::default()
3497            }
3498            .resolve_roles()
3499        };
3500        let ids = |r: &ResolvedRoles| -> Vec<String> {
3501            r.fixer
3502                .as_ref()
3503                .unwrap()
3504                .iter()
3505                .map(|s| s.id.clone())
3506                .collect()
3507        };
3508        // The string form is a chain of one; unset stays unset (the winner's author).
3509        assert_eq!(ids(&resolve(Some("c".into())).unwrap()), ["c"]);
3510        assert!(resolve(None).unwrap().fixer.is_none());
3511        // Order kept, an unknown id skipped, a duplicate keeps its first place.
3512        let chain = AgentChoice::Chain(vec!["b".into(), "zzz".into(), "a".into(), "b".into()]);
3513        assert_eq!(ids(&resolve(Some(chain)).unwrap()), ["b", "a"]);
3514        // Nothing resolving names the role.
3515        let err = resolve(Some(AgentChoice::Chain(vec!["zzz".into()]))).unwrap_err();
3516        assert!(format!("{err:#}").contains("fixer"), "{err:#}");
3517    }
3518
3519    #[test]
3520    fn unknown_agent_id_is_an_error() {
3521        let cfg = Config {
3522            agents: vec![spec("a")],
3523            roles: Roles {
3524                judges: vec!["nope".to_owned()],
3525                ..Roles::default()
3526            },
3527            ..Config::default()
3528        };
3529        assert!(cfg.resolve_roles().is_err());
3530    }
3531
3532    #[test]
3533    fn conductor_role_is_resolved_validated_and_has_a_fallback() {
3534        let mut cfg = Config {
3535            agents: vec![spec("a"), spec("b")],
3536            ..Config::default()
3537        };
3538        assert_eq!(cfg.resolve_roles().unwrap().conductor.id, "a");
3539
3540        cfg.roles.conductor = Some("b".into());
3541        assert_eq!(cfg.resolve_roles().unwrap().conductor.id, "b");
3542
3543        cfg.roles.conductor = Some("missing".into());
3544        assert!(cfg.resolve_roles().is_err());
3545    }
3546
3547    #[test]
3548    fn a_standalone_role_takes_a_string_or_an_array_and_round_trips() {
3549        let one: Roles = toml::from_str("synthesizer = \"opus\"").unwrap();
3550        assert_eq!(one.synthesizer, Some(AgentChoice::One("opus".to_owned())));
3551        assert_eq!(primary(one.synthesizer.as_ref()), Some("opus"));
3552
3553        let chain: Roles = toml::from_str("chatter = [\"opus\", \"codex\"]").unwrap();
3554        assert_eq!(chain.chatter.as_ref().unwrap().ids(), ["opus", "codex"]);
3555        assert_eq!(primary(chain.chatter.as_ref()), Some("opus"));
3556
3557        for roles in [one, chain] {
3558            let text = toml::to_string(&roles).unwrap();
3559            let back: Roles = toml::from_str(&text).unwrap();
3560            assert_eq!(back.synthesizer, roles.synthesizer);
3561            assert_eq!(back.chatter, roles.chatter);
3562        }
3563        let text = toml::to_string(&Roles {
3564            conductor: Some("x".into()),
3565            ..Roles::default()
3566        })
3567        .unwrap();
3568        assert!(
3569            text.contains("conductor = \"x\""),
3570            "string stays a string: {text}"
3571        );
3572        assert!(toml::from_str::<Roles>("synthesizer = 3").is_err());
3573    }
3574
3575    #[test]
3576    fn dupes_judge_role_accepts_strings_and_chains_and_round_trips() {
3577        for (text, ids) in [
3578            (r#"dupes_judge = "dedicated""#, vec!["dedicated"]),
3579            (
3580                r#"dupes_judge = ["first", "second"]"#,
3581                vec!["first", "second"],
3582            ),
3583            ("dupes_judge = []", vec![]),
3584        ] {
3585            let roles: Roles = toml::from_str(text).unwrap();
3586            assert_eq!(roles.dupes_judge.as_ref().unwrap().ids(), ids);
3587            let serialized = toml::to_string(&roles).unwrap();
3588            let back: Roles = toml::from_str(&serialized).unwrap();
3589            assert_eq!(back.dupes_judge, roles.dupes_judge);
3590            assert!(serialized.contains(text));
3591        }
3592        assert!(toml::from_str::<Roles>("dupes_judge = 3").is_err());
3593        assert!(Roles::default().dupes_judge.is_none());
3594        assert!(Config::starter_toml().contains("# dupes_judge ="));
3595
3596        // Standalone roles are resolved lazily, just like chatter.
3597        let mut cfg = Config {
3598            agents: vec![spec("a")],
3599            ..Config::default()
3600        };
3601        cfg.roles.dupes_judge = Some("missing".into());
3602        assert!(cfg.resolve_roles().is_ok());
3603    }
3604
3605    #[test]
3606    fn an_empty_choice_counts_as_unset() {
3607        assert!(AgentChoice::Chain(Vec::new()).ids().is_empty());
3608        assert!(AgentChoice::One("  ".to_owned()).ids().is_empty());
3609        assert_eq!(primary(Some(&AgentChoice::Chain(vec![]))), None);
3610    }
3611
3612    #[test]
3613    fn synthesizer_role_is_a_lazy_lookup_with_the_same_fallback_as_chatter() {
3614        // Unlike `conductor`, `synthesizer` is never validated by
3615        // `resolve_roles` — it is looked up lazily by
3616        // `graph::Runner::synthesize_brief` the same way `[roles] chatter`
3617        // is looked up by `talk::begin`, so this exercises `agent::pick`
3618        // directly instead of going through `resolve_roles`.
3619        let mut cfg = Config {
3620            agents: vec![spec("a"), spec("b")],
3621            ..Config::default()
3622        };
3623        let want = primary(cfg.roles.synthesizer.as_ref());
3624        assert_eq!(
3625            crate::agent::pick(&cfg.agents, want, &crate::agent::installed)
3626                .unwrap()
3627                .id,
3628            "a",
3629            "unset falls back to agent::pick's own default order"
3630        );
3631
3632        cfg.roles.synthesizer = Some("b".into());
3633        let want = primary(cfg.roles.synthesizer.as_ref());
3634        assert_eq!(
3635            crate::agent::pick(&cfg.agents, want, &crate::agent::installed)
3636                .unwrap()
3637                .id,
3638            "b",
3639            "the named agent wins over the default order"
3640        );
3641    }
3642
3643    #[test]
3644    fn empty_roster_is_an_error() {
3645        assert!(Config::default().resolve_roles().is_err());
3646    }
3647
3648    #[test]
3649    fn advise_defaults_to_on_with_three_proposals() {
3650        let g = Graph::default();
3651        assert!(g.advise);
3652        assert!(g.graft_runner_up, "graft is on by default");
3653        assert_eq!(g.advisors, 3);
3654    }
3655
3656    #[test]
3657    fn unset_advisors_falls_back_to_the_judge_roster() {
3658        let cfg = Config {
3659            agents: vec![spec("a"), spec("b")],
3660            roles: Roles {
3661                judges: vec!["b".to_owned()],
3662                ..Roles::default()
3663            },
3664            graph: Graph {
3665                advisors: 2,
3666                ..Graph::default()
3667            },
3668            ..Config::default()
3669        };
3670        let advisors = cfg.advisors().expect("advisors resolve");
3671        assert_eq!(advisors.len(), 2);
3672        assert!(
3673            advisors.iter().all(|a| a.id == "b"),
3674            "an unset [roles] advisors must fall back to [roles] judges: {advisors:?}"
3675        );
3676    }
3677
3678    #[test]
3679    fn an_explicit_advisor_roster_wins_over_the_judge_fallback() {
3680        let cfg = Config {
3681            agents: vec![spec("a"), spec("b")],
3682            roles: Roles {
3683                judges: vec!["b".to_owned()],
3684                advisors: vec!["a".to_owned()],
3685                ..Roles::default()
3686            },
3687            graph: Graph {
3688                advisors: 2,
3689                ..Graph::default()
3690            },
3691            ..Config::default()
3692        };
3693        let advisors = cfg.advisors().expect("advisors resolve");
3694        assert!(advisors.iter().all(|a| a.id == "a"));
3695    }
3696
3697    /// Neither `[roles] advisors` nor `[roles] judges` set: an unconfigured
3698    /// advisor roster must resolve to the exact same agents an unconfigured
3699    /// judge panel would get - same ids, same rotation offset - or the
3700    /// promise in [`Roles::advisors`]'s doc ("advisor diversity for free")
3701    /// does not actually hold.
3702    #[test]
3703    fn an_unconfigured_advisor_and_judge_roster_resolve_to_the_same_agents() {
3704        let cfg = Config {
3705            agents: vec![spec("a"), spec("b"), spec("c")],
3706            graph: Graph {
3707                advisors: 3,
3708                judges: 3,
3709                ..Graph::default()
3710            },
3711            ..Config::default()
3712        };
3713        let advisors = cfg.advisors().expect("advisors resolve");
3714        let judges = cfg.resolve_roles().expect("roles resolve").judges;
3715        let advisor_ids: Vec<&str> = advisors.iter().map(|a| a.id.as_str()).collect();
3716        let judge_ids: Vec<&str> = judges.iter().map(|a| a.id.as_str()).collect();
3717        assert_eq!(
3718            advisor_ids, judge_ids,
3719            "an unconfigured advisor roster must be the same seats an unconfigured judge panel gets"
3720        );
3721    }
3722
3723    #[test]
3724    fn an_unresolvable_advisor_seat_is_an_error_naming_the_id() {
3725        let cfg = Config {
3726            agents: vec![spec("a")],
3727            roles: Roles {
3728                advisors: vec!["nope".to_owned()],
3729                ..Roles::default()
3730            },
3731            graph: Graph {
3732                advisors: 1,
3733                ..Graph::default()
3734            },
3735            ..Config::default()
3736        };
3737        let err = cfg.advisors().expect_err("`nope` is not in the roster");
3738        assert!(format!("{err:#}").contains("nope"));
3739    }
3740
3741    #[test]
3742    fn repos_default_to_no_roots_and_a_day_of_trust() {
3743        assert_eq!(Config::default().repos.roots, Vec::<PathBuf>::new());
3744        assert_eq!(Config::default().repos.scan_ttl, 86_400);
3745        assert_eq!(Config::default().repos.fetch_interval, 600);
3746        assert!(!Config::default().repos.auto_clone);
3747        assert!(Config::default().repos.clone_command.is_none());
3748    }
3749
3750    #[test]
3751    fn a_config_file_with_no_repos_table_still_loads() {
3752        let dir = tempfile::tempdir().unwrap();
3753        let path = dir.path().join("magi.toml");
3754        std::fs::write(&path, "[graph]\ncandidates = 2\n").unwrap();
3755        let cfg = Config::load(&path).expect("must load without [repos]");
3756        assert_eq!(cfg.repos.roots, Vec::<PathBuf>::new());
3757        assert_eq!(cfg.repos.scan_ttl, 86_400);
3758    }
3759
3760    /// A fixture is the whole config under test.
3761    ///
3762    /// `layers` used to reach for `dirs::config_dir()` unconditionally, so on
3763    /// a machine where somebody had written `<config_dir>/magi/config.toml`
3764    /// the suite silently loaded it as the lowest layer. Adding `[repos]
3765    /// roots` there turned two web tests red - their fixtures declare
3766    /// `[repos] roots` too, and `refuse_split_arrays` rightly refuses one
3767    /// array key spread across two layers. CI stayed green throughout,
3768    /// because a runner has no such file: the suite failed only where magi is
3769    /// actually used.
3770    ///
3771    /// So a test build has no machine layer unless it asks for one, and this
3772    /// is that promise. Written against a real file at the real location so
3773    /// it fails if `machine_layer` starts reading it again.
3774    #[test]
3775    fn a_test_build_does_not_read_the_operators_machine_config() {
3776        let repo = tempfile::tempdir().unwrap();
3777        std::fs::write(repo.path().join("magi.toml"), "[graph]\ncandidates = 2\n").unwrap();
3778
3779        let layers = Config::layers(repo.path());
3780        assert_eq!(
3781            layers,
3782            vec![repo.path().join("magi.toml")],
3783            "only the fixture's own file may be a layer"
3784        );
3785        if let Some(real) = dirs::config_dir() {
3786            let machine = real.join("magi").join("config.toml");
3787            assert!(
3788                !layers.contains(&machine),
3789                "the operator's {} must not be a layer in a test build",
3790                machine.display()
3791            );
3792        }
3793    }
3794
3795    #[test]
3796    fn auto_upgrade_config_defaults_and_opt_in() {
3797        let default: Update = toml::from_str("").unwrap();
3798        assert!(!default.auto_restart);
3799        assert_eq!(default.mode, UpdateMode::Notify);
3800        let enabled: Update = toml::from_str("auto_restart = true\ninterval = \"2h\"\n").unwrap();
3801        assert!(enabled.auto_restart);
3802        assert_eq!(enabled.interval.as_deref(), Some("2h"));
3803        assert!(toml::from_str::<Update>("auto_restart = \"yes\"").is_err());
3804    }
3805
3806    #[test]
3807    fn starter_toml_loads_through_teravars() {
3808        let dir = tempfile::tempdir().unwrap();
3809        let path = dir.path().join("magi.toml");
3810        std::fs::write(&path, Config::starter_toml()).unwrap();
3811        let parsed = Config::load(&path).expect("starter config must load");
3812        assert_eq!(parsed.graph.implementers, 3);
3813        assert_eq!(parsed.merge.mode, MergeMode::None);
3814        assert_eq!(parsed.merge.style, MergeStyle::Merge);
3815        assert!(parsed.graph.sessions);
3816        assert!(parsed.graph.github_text_guard);
3817        assert_eq!(parsed.graph.timeout_review, 1200);
3818        assert_eq!(parsed.graph.verify_timeout(), 1200);
3819        assert_eq!(parsed.update.mode, UpdateMode::Notify);
3820    }
3821
3822    #[test]
3823    fn release_defaults_to_actions_and_the_starter_documents_it() {
3824        let dir = tempfile::tempdir().unwrap();
3825        let path = dir.path().join("magi.toml");
3826        std::fs::write(&path, Config::starter_toml()).unwrap();
3827        let r = Config::load(&path).unwrap().release;
3828        assert_eq!(r.mode, ReleaseMode::Actions);
3829        assert!(!r.is_local());
3830        assert!(r.commands.is_empty());
3831        assert_eq!(r.timeout_minutes, 30);
3832        assert!(Config::starter_toml().contains("# mode = \"actions\""));
3833    }
3834
3835    #[test]
3836    fn release_local_parses_and_unknown_keys_are_refused() {
3837        let dir = tempfile::tempdir().unwrap();
3838        let path = dir.path().join("magi.toml");
3839        std::fs::write(
3840            &path,
3841            "[release]\nmode = \"local\"\ncommands = [\"true\", \"echo $MAGI_RELEASE_TAG\"]\ntimeout_minutes = 5\n",
3842        )
3843        .unwrap();
3844        let r = Config::load(&path).unwrap().release;
3845        assert!(r.is_local());
3846        assert_eq!(r.commands.len(), 2);
3847        assert_eq!(r.timeout_minutes, 5);
3848        std::fs::write(&path, "[release]\nmode = \"local\"\nbogus = 1\n").unwrap();
3849        assert!(Config::load(&path).is_err());
3850        std::fs::write(&path, "[release]\nmode = \"gha\"\n").unwrap();
3851        assert!(Config::load(&path).is_err());
3852    }
3853
3854    #[test]
3855    fn pre_gate_defaults_to_empty_and_the_starter_documents_it() {
3856        let dir = tempfile::tempdir().unwrap();
3857        let path = dir.path().join("magi.toml");
3858        std::fs::write(&path, Config::starter_toml()).unwrap();
3859        assert!(Config::load(&path).unwrap().verify.pre_gate.is_empty());
3860        assert!(Config::starter_toml().contains("# pre_gate = []"));
3861    }
3862
3863    #[test]
3864    fn release_version_files_parse_default_empty_and_are_validated() {
3865        let dir = tempfile::tempdir().unwrap();
3866        let path = dir.path().join("magi.toml");
3867        std::fs::write(&path, "").unwrap();
3868        assert!(
3869            Config::load(&path)
3870                .unwrap()
3871                .release
3872                .version_files
3873                .is_empty()
3874        );
3875        std::fs::write(
3876            &path,
3877            "[release]\nversion_files = [\n{ path = \"src-tauri/Cargo.toml\", kind = \"cargo\" },\n{ path = \"package.json\", kind = \"json\" },\n]\n",
3878        )
3879        .unwrap();
3880        let files = Config::load(&path).unwrap().release.version_files;
3881        assert_eq!(files.len(), 2);
3882        assert_eq!(files[1].kind, VersionKind::Json);
3883        for bad in [
3884            "{ path = \"package.json\", kind = \"json\" }",
3885            "{ path = \"../Cargo.toml\", kind = \"cargo\" }",
3886            "{ path = \"Cargo.toml\", kind = \"cargo\", extra = 1 }",
3887            "{ path = \"Cargo.toml\", kind = \"yaml\" }",
3888        ] {
3889            std::fs::write(&path, format!("[release]\nversion_files = [{bad}]\n")).unwrap();
3890            assert!(Config::load(&path).is_err(), "{bad}");
3891        }
3892        assert!(Config::starter_toml().contains("# version_files = ["));
3893    }
3894
3895    #[test]
3896    fn starter_toml_explains_inherited_and_explicit_verify_timeouts() {
3897        let starter = Config::starter_toml();
3898        assert!(starter.contains("When timeout_verify is omitted, E2E and"));
3899        assert!(starter.contains("verification independent if timeout_review changes later"));
3900        assert!(starter.contains("# timeout_verify = 1200"));
3901    }
3902
3903    #[test]
3904    fn starter_toml_documents_chat_personas() {
3905        let starter = Config::starter_toml();
3906        assert!(starter.contains("# [[talk.personas]]"));
3907        assert!(starter.contains("tone only"));
3908    }
3909
3910    #[test]
3911    fn talk_personas_parse_and_are_validated() {
3912        let dir = tempfile::tempdir().unwrap();
3913        let path = dir.path().join("magi.toml");
3914        std::fs::write(
3915            &path,
3916            "[[talk.personas]]\nid = \"rei\"\nname = \"Quiet\"\nprompt = \"Be brief.\"\n\n\
3917             [[talk.personas]]\nid = \"gendo\"\nname = \"Gendo\"\nprompt = \"Be cold.\"\n",
3918        )
3919        .unwrap();
3920        let cfg = Config::load(&path).expect("loads");
3921        assert_eq!(cfg.talk.personas.len(), 2);
3922        let catalog = crate::persona::catalog(&cfg.talk.personas);
3923        let rei = catalog.iter().find(|p| p.id == "rei").unwrap();
3924        assert_eq!(
3925            (rei.name.as_str(), rei.prompt.as_str()),
3926            ("Quiet", "Be brief.")
3927        );
3928        assert_eq!(catalog.last().unwrap().id, "gendo");
3929
3930        for (body, needle) in [
3931            (
3932                "[[talk.personas]]\nid = \"\"\nname = \"n\"\nprompt = \"p\"\n",
3933                "empty `id`",
3934            ),
3935            (
3936                "[[talk.personas]]\nid = \"a\"\nname = \"n\"\nprompt = \" \"\n",
3937                "empty `prompt`",
3938            ),
3939            (
3940                "[[talk.personas]]\nid = \"a\"\nname = \"n\"\nprompt = \"p\"\n\
3941                 [[talk.personas]]\nid = \"a\"\nname = \"m\"\nprompt = \"q\"\n",
3942                "more than once",
3943            ),
3944            (
3945                "[[talk.personas]]\nid = \"default\"\nname = \"n\"\nprompt = \"p\"\n",
3946                "cannot be redefined",
3947            ),
3948        ] {
3949            std::fs::write(&path, body).unwrap();
3950            let err = format!("{:#}", Config::load(&path).unwrap_err());
3951            assert!(err.contains(needle), "{needle}: {err}");
3952        }
3953    }
3954
3955    #[test]
3956    fn talk_operator_name_is_trimmed_and_validated() {
3957        let dir = tempfile::tempdir().unwrap();
3958        let path = dir.path().join("magi.toml");
3959        let load = |body: &str| {
3960            std::fs::write(&path, body).unwrap();
3961            Config::load(&path)
3962        };
3963        let ok = load("[talk]\noperator_name = \"  Commander \"\n").expect("ok");
3964        assert_eq!(ok.talk.operator_name(), Some("Commander"));
3965        let blank = load("[talk]\noperator_name = \"   \"\n").expect("blank");
3966        assert_eq!(blank.talk.operator_name(), None);
3967        assert!(load("[talk]\noperator_name = \"a\\nb\"\n").is_err());
3968        let long = "x".repeat(65);
3969        assert!(load(&format!("[talk]\noperator_name = \"{long}\"\n")).is_err());
3970    }
3971
3972    #[test]
3973    fn talk_persona_icon_parses_and_a_bad_shape_keeps_config_usable() {
3974        let dir = tempfile::tempdir().unwrap();
3975        let load = |body: &str| {
3976            let path = dir.path().join("c.toml");
3977            std::fs::write(&path, body).unwrap();
3978            Config::load(&path)
3979        };
3980        let ok = load(
3981            "[[talk.personas]]\nid = \"rei\"\nicon = \"~/rei.png\"\n\n\
3982             [[talk.personas]]\nid = \"default\"\nicon = \"data:image/png;base64,AAAA\"\n",
3983        )
3984        .unwrap();
3985        let c = crate::persona::catalog(&ok.talk.personas);
3986        assert_eq!(c[0].icon.as_deref(), Some("data:image/png;base64,AAAA"));
3987        assert_eq!(c[2].icon.as_deref(), Some("~/rei.png"));
3988        assert!(c[2].prompt.contains("Rei"), "built-in voice kept");
3989        let oversized = format!(
3990            "data:image/png;base64,{}",
3991            "A".repeat(crate::persona_icon::ICON_MAX_BYTES)
3992        );
3993        for bad in ["", "rei.png", "/a/b.svg", "/a/../b.png", &oversized] {
3994            for (id, fields) in [
3995                ("rei", ""),
3996                ("default", ""),
3997                ("custom", "name = \"Custom\"\nprompt = \"Keep calm\"\n"),
3998            ] {
3999                let body = format!("[[talk.personas]]\nid = \"{id}\"\nicon = \"{bad}\"\n{fields}");
4000                let cfg = load(&body).expect("bad icon must not invalidate config");
4001                let persona = crate::persona::find(&cfg.talk.personas, id).unwrap();
4002                assert_eq!(persona.id, id);
4003                assert!(crate::persona_icon::load(bad).is_err());
4004            }
4005        }
4006        let doc = Config::starter_toml();
4007        assert!(doc.contains("# icon = "));
4008    }
4009
4010    #[test]
4011    fn talk_personas_in_two_layers_are_refused() {
4012        let dir = tempfile::tempdir().unwrap();
4013        let machine = dir.path().join("machine.toml");
4014        let repo = dir.path().join("repo.toml");
4015        let one = "[[talk.personas]]\nid = \"a\"\nname = \"n\"\nprompt = \"p\"\n";
4016        std::fs::write(&machine, one).unwrap();
4017        std::fs::write(&repo, one.replace("\"a\"", "\"b\"")).unwrap();
4018        let err = format!("{:#}", Config::load_layers(&[machine, repo]).unwrap_err());
4019        assert!(err.contains("talk.personas"), "{err}");
4020    }
4021
4022    #[test]
4023    fn starter_toml_documents_role_lists_as_backup_order() {
4024        let starter = Config::starter_toml();
4025        assert!(starter.contains("also an ordered backup list"));
4026        assert!(starter.contains("codex then sonnet are spares"));
4027    }
4028
4029    /// A repository whose ruleset forbids merge commits declares that once,
4030    /// here, rather than magi asking GitHub about it on every render (see
4031    /// [`MergeStyle`]'s own doc for why).
4032    #[test]
4033    fn a_repository_can_declare_a_linear_history_merge_style() {
4034        let dir = tempfile::tempdir().unwrap();
4035        let path = dir.path().join("magi.toml");
4036        std::fs::write(&path, "[merge]\nmode = \"none\"\nstyle = \"squash\"\n").unwrap();
4037        let parsed = Config::load(&path).expect("config must load");
4038        assert_eq!(parsed.merge.style, MergeStyle::Squash);
4039    }
4040
4041    #[test]
4042    fn later_layers_win_and_vars_render() {
4043        let dir = tempfile::tempdir().unwrap();
4044        let machine = dir.path().join("machine.toml");
4045        let project = dir.path().join("magi.toml");
4046        // The machine layer owns the roster...
4047        std::fs::write(
4048            &machine,
4049            "[[agents]]\nid = \"opus\"\nkind = \"claude\"\nmodel = \"opus\"\n\n\
4050             [graph]\ncandidates = 3\nmax_parallel = 8\n",
4051        )
4052        .unwrap();
4053        // ...and the project layer only states what is repo-specific, plus a
4054        // `[vars]` value interpolated into a command.
4055        std::fs::write(
4056            &project,
4057            "[vars]\ncache = \"/shared\"\n\n\
4058             [graph]\ncandidates = 2\n\n\
4059             [verify]\ngate = [\"CARGO_TARGET_DIR={{ vars.cache }}/t cargo test\"]\n",
4060        )
4061        .unwrap();
4062
4063        let cfg = Config::load_layers(&[machine, project]).expect("layered load");
4064        assert_eq!(cfg.agents.len(), 1, "roster comes from the machine layer");
4065        assert_eq!(cfg.graph.implementers, 2, "project layer wins");
4066        assert_eq!(cfg.graph.max_parallel, 8, "machine layer survives");
4067        assert_eq!(
4068            cfg.verify.gate,
4069            ["CARGO_TARGET_DIR=/shared/t cargo test".to_owned()]
4070        );
4071        // The rendered command is where the cache path is read back from.
4072        assert_eq!(cfg.cache_dir(), Some(PathBuf::from("/shared/t")));
4073    }
4074
4075    #[test]
4076    fn talk_defaults_to_an_hour_and_an_unwritten_config_still_gets_it() {
4077        // An operator who writes no `[graph]` timeout keys at all must still
4078        // land on the hour, not on the five/fifteen minutes this turn used
4079        // to hardcode before it read from config.
4080        let g = Graph::default();
4081        assert_eq!(g.timeout_talk, 3600);
4082
4083        let dir = tempfile::tempdir().unwrap();
4084        let path = dir.path().join("magi.toml");
4085        std::fs::write(&path, "[graph]\ncandidates = 2\n").unwrap();
4086        let cfg = Config::load(&path).expect("must load without timeout_talk set");
4087        assert_eq!(cfg.graph.timeout_talk, 3600);
4088    }
4089
4090    #[test]
4091    fn an_overridden_talk_timeout_reaches_the_loaded_config() {
4092        let dir = tempfile::tempdir().unwrap();
4093        let path = dir.path().join("magi.toml");
4094        std::fs::write(&path, "[graph]\ntimeout_talk = 120\n").unwrap();
4095        let cfg = Config::load(&path).expect("must load");
4096        assert_eq!(cfg.graph.timeout_talk, 120);
4097    }
4098
4099    #[test]
4100    fn the_disk_defaults_are_the_measurements_made_up_front() {
4101        let cfg = Config::default();
4102        assert_eq!(cfg.disk.min_free_bytes, 8 * 1024 * 1024 * 1024);
4103        assert!(cfg.disk.auto_fold);
4104        assert_eq!(cfg.disk.fold_grace_secs, 6 * 60 * 60);
4105        assert_eq!(cfg.disk.cache_limit_bytes, 10 * 1024 * 1024 * 1024);
4106    }
4107
4108    #[test]
4109    fn an_unset_disk_section_is_the_safe_default() {
4110        let dir = tempfile::tempdir().unwrap();
4111        std::fs::write(dir.path().join("magi.toml"), "[graph]\ncandidates = 1\n").unwrap();
4112        let cfg = Config::load(&dir.path().join("magi.toml")).expect("load");
4113        assert_eq!(cfg.disk, Disk::default());
4114    }
4115
4116    #[test]
4117    fn env_is_available_to_templates_with_a_default() {
4118        let dir = tempfile::tempdir().unwrap();
4119        let path = dir.path().join("magi.toml");
4120        // teravars ships no `env`; magi adds it, and the `default` filter has
4121        // to cover the unset case or every machine would need the variable.
4122        //
4123        // Deliberately no named variable: `env` is keyed by the exact spelling
4124        // the OS reports, and Windows says `Path` where POSIX says `PATH`, so a
4125        // test asserting `env.PATH` passes on one runner and fails on another.
4126        // The map's non-emptiness is the platform-neutral claim.
4127        std::fs::write(
4128            &path,
4129            "[verify]\n\
4130             gate = [\"cache={{ env.MAGI_TEST_UNSET_XYZ | default(value='fallback') }}\", \
4131             \"populated={{ env | length > 0 }}\"]\n",
4132        )
4133        .unwrap();
4134        let cfg = Config::load(&path).expect("env lookup must render");
4135        assert_eq!(cfg.verify.gate[0], "cache=fallback");
4136        assert_eq!(cfg.verify.gate[1], "populated=true");
4137    }
4138
4139    #[test]
4140    fn a_broken_template_names_the_file() {
4141        let dir = tempfile::tempdir().unwrap();
4142        let path = dir.path().join("magi.toml");
4143        std::fs::write(&path, "[graph]\nlanguage = \"{{ nope.\"\n").unwrap();
4144        let err = Config::load(&path).expect_err("must not silently ignore");
4145        assert!(err.to_string().contains("teravars"), "{err}");
4146    }
4147
4148    #[test]
4149    fn tera_syntax_in_comments_is_inert() {
4150        // teravars >= 0.2.2 strips `#` comments before Tera sees the file, so a
4151        // comment may quote template syntax without rendering. Before 0.2.2 this
4152        // load failed: the commented-out braces reached the template parser.
4153        let dir = tempfile::tempdir().unwrap();
4154        let path = dir.path().join("magi.toml");
4155        std::fs::write(
4156            &path,
4157            "# a comment may quote templates: `{{ env.NOPE | default(value='x') }}` and `{% if %}`\n\
4158             [graph]\ncandidates = 2\n",
4159        )
4160        .unwrap();
4161        let cfg = Config::load(&path).expect("comments must be inert, not rendered");
4162        assert_eq!(cfg.graph.implementers, 2);
4163    }
4164
4165    #[test]
4166    fn agent_turn_cap_round_trips_and_never_extends_the_budget() {
4167        use std::time::Duration;
4168
4169        let mut s: AgentSpec =
4170            toml::from_str("id = 'slow'\nkind = 'command'\ncommand = ['true']\n").unwrap();
4171        let budget = Duration::from_millis(1500);
4172        assert_eq!(s.max_turn_secs, None);
4173        assert_eq!(s.turn_timeout(budget), budget);
4174        assert!(!toml::to_string(&s).unwrap().contains("max_turn_secs"));
4175        for (cap, expected) in [
4176            (1, Duration::from_secs(1)),
4177            (2, budget),
4178            (0, Duration::ZERO),
4179        ] {
4180            s.max_turn_secs = Some(cap);
4181            let saved = toml::to_string(&s).unwrap();
4182            let loaded: AgentSpec = toml::from_str(&saved).unwrap();
4183            assert_eq!(loaded.max_turn_secs, Some(cap));
4184            assert_eq!(loaded.turn_timeout(budget), expected);
4185        }
4186    }
4187
4188    #[test]
4189    fn opencode_defaults_to_file_delivery() {
4190        let mut s = spec("oc");
4191        s.kind = AgentKind::Opencode;
4192        assert_eq!(s.delivery(), Delivery::File);
4193        s.prompt_delivery = Some(Delivery::Argv);
4194        assert_eq!(s.delivery(), Delivery::Argv);
4195    }
4196    #[test]
4197    fn the_land_loop_is_on_but_it_cannot_merge_without_being_asked() {
4198        // Both default on, and that pair is the safety property: `land` takes
4199        // over the watching an operator was doing by hand, `land_approval`
4200        // keeps the irreversible step a human decision. An unattended merge
4201        // needs BOTH flipped, which has to be chosen deliberately twice.
4202        let g = Graph::default();
4203        assert!(
4204            g.land,
4205            "stopping at an open PR left the watching to a human"
4206        );
4207        assert!(
4208            g.land_approval,
4209            "on-by-default land is only defensible while this is also on"
4210        );
4211        assert!(g.land_rounds > 0, "a loop with no budget never terminates");
4212        assert!(
4213            g.hold_contested_merge,
4214            "a contested hand-off must still reach a human when approvals are off"
4215        );
4216    }
4217    #[test]
4218    fn an_array_declared_in_two_layers_is_refused_instead_of_concatenated() {
4219        // teravars appends arrays. For an ordered list of seats, or an argv,
4220        // the concatenation is something neither file says - and the operator
4221        // pays for the extra seats by the token.
4222        let dir = tempfile::tempdir().unwrap();
4223        let machine = dir.path().join("machine.toml");
4224        let repo = dir.path().join("magi.toml");
4225        std::fs::write(&machine, "[roles]\nimplementers = [\"a\", \"b\"]\n").unwrap();
4226        std::fs::write(&repo, "[roles]\nimplementers = [\"oc\"]\n").unwrap();
4227
4228        let err = Config::load_layers(&[machine.clone(), repo.clone()])
4229            .expect_err("two layers naming one array must not merge silently");
4230        assert_eq!(
4231            err.downcast_ref::<ConfigFailure>().unwrap().stage,
4232            "config-merge"
4233        );
4234        let err = err.to_string();
4235        assert!(err.contains("roles.implementers"), "{err}");
4236        // Both files are named: the fix is to delete one of them, and the
4237        // operator has to know which two to choose between.
4238        assert!(err.contains("machine.toml"), "{err}");
4239        assert!(err.contains("magi.toml"), "{err}");
4240    }
4241
4242    #[test]
4243    fn a_scalar_in_one_layer_and_an_array_in_another_still_merges() {
4244        // The split the layering exists for: state a preference machine-wide,
4245        // let the repository own its own lists.
4246        let dir = tempfile::tempdir().unwrap();
4247        let machine = dir.path().join("machine.toml");
4248        let repo = dir.path().join("magi.toml");
4249        std::fs::write(&machine, "[roles]\nchatter = \"opus\"\n").unwrap();
4250        std::fs::write(
4251            &repo,
4252            "[[agents]]\nid = \"oc\"\nkind = \"opencode\"\n\n\
4253             [roles]\nimplementers = [\"oc\"]\n",
4254        )
4255        .unwrap();
4256
4257        let cfg = Config::load_layers(&[machine, repo]).expect("layers merge");
4258        assert_eq!(primary(cfg.roles.chatter.as_ref()), Some("opus"));
4259        assert_eq!(cfg.roles.implementers, ["oc"]);
4260        assert_eq!(cfg.agents.len(), 1, "the roster is not doubled");
4261    }
4262
4263    #[test]
4264    fn two_layers_declaring_verify_gate_run_both_in_priority_order() {
4265        // The `editorconfig-checker` distribution problem: a shared layer
4266        // wants to add a gate command without erasing the repository's own.
4267        let dir = tempfile::tempdir().unwrap();
4268        let machine = dir.path().join("machine.toml");
4269        let repo = dir.path().join("magi.toml");
4270        std::fs::write(&machine, "[verify]\ngate = [\"editorconfig-checker\"]\n").unwrap();
4271        std::fs::write(&repo, "[verify]\ngate = [\"cargo make check\"]\n").unwrap();
4272
4273        let cfg = Config::load_layers(&[machine, repo]).expect("appendable arrays must merge");
4274        assert_eq!(
4275            cfg.verify.gate,
4276            [
4277                "editorconfig-checker".to_owned(),
4278                "cargo make check".to_owned()
4279            ],
4280            "low-priority (machine) command first, high-priority (repo) command after"
4281        );
4282    }
4283
4284    fn load_one(body: &str) -> Result<Config> {
4285        let dir = tempfile::tempdir().unwrap();
4286        let path = dir.path().join("magi.toml");
4287        std::fs::write(&path, body).unwrap();
4288        Config::load_layers(&[path])
4289    }
4290
4291    #[test]
4292    fn pre_clean_config_is_strict_and_single_layer() {
4293        assert!(Config::default().worktree.pre_clean.is_empty());
4294        let good = load_one("[worktree]\npre_clean = [{run = 'cleanup', timeout_secs = 60}]\n");
4295        assert_eq!(good.unwrap().worktree.pre_clean[0].timeout_secs, Some(60));
4296        for bad in [
4297            "{}",
4298            "{run = ''}",
4299            "{run = ' ', timeout_secs = 2}",
4300            "{run = 'x', timeout_secs = 0}",
4301            "{run = 'x', timeout_secs = -1}",
4302            "{copy = 'cache'}",
4303            "{run = 'x', optional = true}",
4304            "'x'",
4305        ] {
4306            assert!(
4307                load_one(&format!("[worktree]\npre_clean = [{bad}]\n")).is_err(),
4308                "{bad}"
4309            );
4310        }
4311        let dir = tempfile::tempdir().unwrap();
4312        let a = dir.path().join("a.toml");
4313        let b = dir.path().join("b.toml");
4314        for path in [&a, &b] {
4315            std::fs::write(path, "[worktree]\npre_clean = [{run = 'cleanup'}]\n").unwrap();
4316        }
4317        assert!(
4318            Config::load_layers(&[a, b])
4319                .unwrap_err()
4320                .to_string()
4321                .contains("worktree.pre_clean")
4322        );
4323    }
4324
4325    #[test]
4326    fn worktree_setup_defaults_to_empty_and_parses_steps() {
4327        assert!(Config::default().worktree.setup.is_empty());
4328        let cfg = load_one(
4329            "[worktree]\nsetup = [\n  { copy = \".env.example -> .env\" },\n  \
4330             { copy = \"x\", optional = true },\n  { run = \"true\", timeout_secs = 5 },\n]\n",
4331        )
4332        .unwrap();
4333        assert_eq!(cfg.worktree.setup.len(), 3);
4334        assert!(cfg.worktree.setup[1].optional);
4335        assert_eq!(cfg.worktree.setup[2].timeout_secs, Some(5));
4336    }
4337
4338    #[test]
4339    fn worktree_setup_rejects_malformed_steps() {
4340        for bad in [
4341            "{ copy = \"a\", run = \"b\" }",
4342            "{ optional = true }",
4343            "{ copy = \"a -> ../b\" }",
4344            "{ copy = \"a -> /abs\" }",
4345            "{ copy = \"a -> .git/config\" }",
4346            "{ run = \"b\", optional = true }",
4347            "{ copy = \"a\", timeout_secs = 3 }",
4348            "{ run = \"b\", bogus = 1 }",
4349        ] {
4350            let body = format!("[worktree]\nsetup = [{bad}]\n");
4351            assert!(load_one(&body).is_err(), "{bad}");
4352        }
4353    }
4354
4355    #[test]
4356    fn worktree_setup_in_two_layers_is_refused() {
4357        let dir = tempfile::tempdir().unwrap();
4358        let machine = dir.path().join("machine.toml");
4359        let repo = dir.path().join("magi.toml");
4360        std::fs::write(&machine, "[worktree]\nsetup = [{ run = \"a\" }]\n").unwrap();
4361        std::fs::write(&repo, "[worktree]\nsetup = [{ run = \"b\" }]\n").unwrap();
4362        assert!(Config::load_layers(&[machine, repo]).is_err());
4363    }
4364
4365    #[test]
4366    fn starter_toml_documents_worktree_setup() {
4367        let starter = Config::starter_toml();
4368        assert!(starter.contains("# [worktree]") && starter.contains("setup = ["));
4369        // The commented example must be valid once uncommented.
4370        let body = starter.replace("# [worktree]", "[worktree]");
4371        let mut out = String::new();
4372        let mut live = false;
4373        for line in body.lines() {
4374            if line == "[worktree]" {
4375                live = true;
4376            } else if live && !line.starts_with("# ") {
4377                live = false;
4378            }
4379            out.push_str(&if live {
4380                line.replacen("# ", "", 1)
4381            } else {
4382                line.to_owned()
4383            });
4384            out.push('\n');
4385        }
4386        let cfg = load_one(&out).expect("uncommented example loads");
4387        assert_eq!(cfg.worktree.setup.len(), 3);
4388    }
4389
4390    #[test]
4391    fn two_layers_declaring_verify_e2e_run_both_in_priority_order() {
4392        let dir = tempfile::tempdir().unwrap();
4393        let machine = dir.path().join("machine.toml");
4394        let repo = dir.path().join("magi.toml");
4395        std::fs::write(&machine, "[verify]\ne2e = [\"shared-smoke-test\"]\n").unwrap();
4396        std::fs::write(&repo, "[verify]\ne2e = [\"cargo test\"]\n").unwrap();
4397
4398        let cfg = Config::load_layers(&[machine, repo]).expect("appendable arrays must merge");
4399        assert_eq!(
4400            cfg.verify.e2e,
4401            ["shared-smoke-test".to_owned(), "cargo test".to_owned()]
4402        );
4403    }
4404
4405    #[test]
4406    fn two_layers_declaring_repos_roots_are_both_scanned() {
4407        let dir = tempfile::tempdir().unwrap();
4408        let machine = dir.path().join("machine.toml");
4409        let repo = dir.path().join("magi.toml");
4410        std::fs::write(&machine, "[repos]\nroots = [\"/machine/root\"]\n").unwrap();
4411        std::fs::write(&repo, "[repos]\nroots = [\"/repo/root\"]\n").unwrap();
4412
4413        let cfg = Config::load_layers(&[machine, repo]).expect("appendable arrays must merge");
4414        assert_eq!(
4415            cfg.repos.roots,
4416            [PathBuf::from("/machine/root"), PathBuf::from("/repo/root")]
4417        );
4418    }
4419
4420    #[test]
4421    fn duplicate_gate_commands_across_layers_both_run() {
4422        // Dropping the duplicate would be a silent surprise; the operator
4423        // sees a slower gate, never a missing one.
4424        let dir = tempfile::tempdir().unwrap();
4425        let machine = dir.path().join("machine.toml");
4426        let repo = dir.path().join("magi.toml");
4427        std::fs::write(&machine, "[verify]\ngate = [\"same-command\"]\n").unwrap();
4428        std::fs::write(&repo, "[verify]\ngate = [\"same-command\"]\n").unwrap();
4429
4430        let cfg = Config::load_layers(&[machine, repo]).expect("appendable arrays must merge");
4431        assert_eq!(
4432            cfg.verify.gate,
4433            ["same-command".to_owned(), "same-command".to_owned()]
4434        );
4435    }
4436
4437    #[test]
4438    fn notify_command_is_still_refused_across_two_layers() {
4439        // An argv, not a set: concatenating two of them is not a program.
4440        let dir = tempfile::tempdir().unwrap();
4441        let machine = dir.path().join("machine.toml");
4442        let repo = dir.path().join("magi.toml");
4443        std::fs::write(&machine, "[notify]\ncommand = [\"ntfy\", \"publish\"]\n").unwrap();
4444        std::fs::write(&repo, "[notify]\ncommand = [\"curl\", \"-X\"]\n").unwrap();
4445
4446        let err = Config::load_layers(&[machine.clone(), repo.clone()])
4447            .expect_err("an argv split across layers must not concatenate");
4448        assert_eq!(
4449            err.downcast_ref::<ConfigFailure>().unwrap().stage,
4450            "config-merge"
4451        );
4452        let err = err.to_string();
4453        assert!(err.contains("notify.command"), "{err}");
4454        assert!(err.contains("machine.toml"), "{err}");
4455        assert!(err.contains("magi.toml"), "{err}");
4456    }
4457
4458    #[test]
4459    fn one_layer_declaring_verify_gate_runs_unchanged() {
4460        // The classification must not change behaviour for the configuration
4461        // this very repository has today: exactly one layer names the gate.
4462        let dir = tempfile::tempdir().unwrap();
4463        let path = dir.path().join("magi.toml");
4464        std::fs::write(&path, "[verify]\ngate = [\"cargo make check\"]\n").unwrap();
4465
4466        let cfg = Config::load(&path).expect("single layer must still load");
4467        assert_eq!(cfg.verify.gate, ["cargo make check".to_owned()]);
4468    }
4469
4470    #[test]
4471    fn layered_parse_failures_name_the_failing_input() {
4472        let dir = tempfile::tempdir().unwrap();
4473        let a = dir.path().join("a.toml");
4474        let b = dir.path().join("b.toml");
4475        std::fs::write(&a, "[graph").unwrap();
4476        std::fs::write(&b, "[verify").unwrap();
4477        let paths = [a.clone(), b.clone()];
4478        let first = Config::load_layers(&paths).unwrap_err();
4479        let first_cause = first.downcast_ref::<ConfigFailure>().unwrap();
4480        assert_eq!(first_cause.stage, "config-parse");
4481        assert_eq!(first_cause.target, serde_json::to_string(&[&a]).unwrap());
4482        std::fs::write(&a, "").unwrap();
4483        let second = Config::load_layers(&paths).unwrap_err();
4484        let second_cause = second.downcast_ref::<ConfigFailure>().unwrap();
4485        assert_eq!(second_cause.stage, "config-parse");
4486        assert_eq!(second_cause.target, serde_json::to_string(&[&b]).unwrap());
4487        assert_ne!(first_cause.target, second_cause.target);
4488    }
4489
4490    #[test]
4491    fn describe_composed_names_the_contributing_layers_only_when_there_are_two() {
4492        let dir = tempfile::tempdir().unwrap();
4493        let machine = dir.path().join("machine.toml");
4494        let repo = dir.path().join("magi.toml");
4495        std::fs::write(&machine, "[verify]\ngate = [\"editorconfig-checker\"]\n").unwrap();
4496        std::fs::write(&repo, "[verify]\ngate = [\"cargo make check\"]\n").unwrap();
4497        let paths = vec![machine.clone(), repo.clone()];
4498
4499        let cfg = Config::load_layers(&paths).expect("appendable arrays must merge");
4500        let described =
4501            Config::describe_composed(&paths, &cfg.verify.gate, "verify.gate", "(none)");
4502        assert!(described.contains("editorconfig-checker && cargo make check"));
4503        assert!(
4504            described.contains(&machine.display().to_string()),
4505            "{described}"
4506        );
4507        assert!(
4508            described.contains(&repo.display().to_string()),
4509            "{described}"
4510        );
4511
4512        // A single contributing layer stays the plain one-line summary.
4513        let single = vec![repo.clone()];
4514        let solo_cfg = Config::load_layers(&single).expect("single layer loads");
4515        let solo_described =
4516            Config::describe_composed(&single, &solo_cfg.verify.gate, "verify.gate", "(none)");
4517        assert_eq!(solo_described, "cargo make check");
4518    }
4519
4520    mod remote_layers {
4521        use super::*;
4522
4523        fn git(dir: &Path, args: &[&str]) {
4524            use crate::proc::Quiet as _;
4525            let out = std::process::Command::new("git")
4526                .args(args)
4527                .quiet()
4528                .current_dir(dir)
4529                .output()
4530                .unwrap();
4531            assert!(out.status.success(), "git {args:?}: {out:?}");
4532        }
4533
4534        /// A checkout whose origin/main carries `remote` as magi.toml and whose
4535        /// working tree carries `disk`.
4536        fn fixture(remote: &str, disk: &str) -> (tempfile::TempDir, PathBuf) {
4537            let tmp = tempfile::tempdir().unwrap();
4538            let bare = tmp.path().join("o.git");
4539            git(tmp.path(), &["init", "--bare", "-b", "trunk", "o.git"]);
4540            let repo = tmp.path().join("repo");
4541            std::fs::create_dir_all(&repo).unwrap();
4542            git(&repo, &["init", "-b", "trunk"]);
4543            git(&repo, &["config", "user.name", "t"]);
4544            git(&repo, &["config", "user.email", "t@example.com"]);
4545            std::fs::write(repo.join("magi.toml"), remote).unwrap();
4546            git(&repo, &["add", "-A"]);
4547            git(&repo, &["commit", "-m", "x"]);
4548            git(&repo, &["remote", "add", "origin", &bare.to_string_lossy()]);
4549            git(&repo, &["push", "origin", "trunk"]);
4550            git(&repo, &["fetch", "origin"]);
4551            git(&repo, &["remote", "set-head", "origin", "trunk"]);
4552            std::fs::write(repo.join("magi.toml"), disk).unwrap();
4553            (tmp, repo)
4554        }
4555
4556        #[tokio::test]
4557        async fn branch_owner_holds_only_add_literal_true_values() {
4558            for (text, expected) in [
4559                ("[graph]\nland_approval = true\n", true),
4560                ("[graph]\nland_approval = false\n", false),
4561                ("[graph]\nland = true\n", false),
4562                ("[graph\n", false),
4563                ("[graph]\nland_approval = \"yes\"\n", false),
4564                ("[graph]\nland_approval = 1\n", false),
4565            ] {
4566                let (_tmp, repo) = fixture(text, "[graph]\nland_approval = false\n");
4567                let head = crate::git::rev_parse(&repo, "HEAD").await.unwrap();
4568                let (holds, _) = branch_owner_holds(&repo, &head).await;
4569                assert_eq!(
4570                    holds.contains(&(OwnerHold::LandApproval, "magi.toml".into())),
4571                    expected
4572                );
4573                assert!(
4574                    !holds
4575                        .iter()
4576                        .any(|(h, _)| *h == OwnerHold::HoldContestedMerge)
4577                );
4578                for base in [false, true] {
4579                    let mut cfg = Config::default();
4580                    cfg.graph.land_approval = base;
4581                    let mut state = crate::run::RunState::new(
4582                        repo.clone(),
4583                        "trunk".into(),
4584                        head.clone(),
4585                        "review".into(),
4586                        cfg,
4587                    );
4588                    state.observe_branch_owner_holds(&head).await;
4589                    assert!(
4590                        state.branch_owner_holds.is_empty(),
4591                        "competition candidates are excluded"
4592                    );
4593                    state.reviewed_commits = Some(Vec::new());
4594                    state.observe_branch_owner_holds(&head).await;
4595                    assert_eq!(state.owner_hold(OwnerHold::LandApproval), base || expected);
4596                }
4597            }
4598        }
4599
4600        #[tokio::test]
4601        async fn branch_owner_holds_missing_and_unreadable_preserve_base() {
4602            let (_tmp, repo) = fixture(
4603                "[graph]\nland_approval = true\n",
4604                "[graph]\nland_approval = true\n",
4605            );
4606            git(&repo, &["rm", "magi.toml"]);
4607            std::fs::create_dir(repo.join(".magi")).unwrap();
4608            std::fs::write(
4609                repo.join(".magi/config.toml"),
4610                "[graph]\nhold_contested_merge = true\n",
4611            )
4612            .unwrap();
4613            git(&repo, &["add", "."]);
4614            git(&repo, &["commit", "-m", "nested hold"]);
4615            let head = crate::git::rev_parse(&repo, "HEAD").await.unwrap();
4616            let (holds, _) = branch_owner_holds(&repo, &head).await;
4617            assert_eq!(
4618                holds,
4619                [(OwnerHold::HoldContestedMerge, ".magi/config.toml".into())]
4620            );
4621            let (holds, diagnostics) =
4622                branch_owner_holds(&repo, "0000000000000000000000000000000000000000").await;
4623            assert!(holds.is_empty());
4624            assert!(!diagnostics.is_empty());
4625            let (holds, diagnostics) = branch_owner_holds(&repo, "").await;
4626            assert!(holds.is_empty());
4627            assert!(!diagnostics.is_empty());
4628            for base in [false, true] {
4629                let mut cfg = Config::default();
4630                cfg.graph.land_approval = base;
4631                let mut state = crate::run::RunState::new(
4632                    repo.clone(),
4633                    "trunk".into(),
4634                    head.clone(),
4635                    "review".into(),
4636                    cfg,
4637                );
4638                state.reviewed_commits = Some(Vec::new());
4639                state.observe_branch_owner_holds(&head).await;
4640                assert_eq!(state.owner_hold(OwnerHold::LandApproval), base);
4641                state
4642                    .observe_branch_owner_holds("0000000000000000000000000000000000000000")
4643                    .await;
4644                assert_eq!(state.owner_hold(OwnerHold::LandApproval), base);
4645            }
4646        }
4647
4648        #[test]
4649        fn reads_the_remote_blob_not_the_working_tree() {
4650            let (_t, repo) = fixture("[graph]\ncandidates = 2\n", "[graph]\ncandidates = 5\n");
4651            let (cfg, _) = Config::discover(&repo, None).unwrap();
4652            assert_eq!(cfg.graph.implementers, 2);
4653        }
4654
4655        #[test]
4656        fn detached_head_still_reads_the_remote() {
4657            let (_t, repo) = fixture("[graph]\ncandidates = 2\n", "[graph]\ncandidates = 5\n");
4658            git(&repo, &["checkout", "--detach"]);
4659            let (cfg, _) = Config::discover(&repo, None).unwrap();
4660            assert_eq!(cfg.graph.implementers, 2);
4661        }
4662
4663        #[test]
4664        fn a_missing_ref_is_an_error_not_a_fallback() {
4665            let (_t, repo) = fixture("[graph]\ncandidates = 2\n", "[graph]\ncandidates = 5\n");
4666            git(&repo, &["update-ref", "-d", "refs/remotes/origin/trunk"]);
4667            let err = format!("{:#}", Config::discover(&repo, None).unwrap_err());
4668            assert!(err.contains("origin"), "{err}");
4669        }
4670
4671        #[test]
4672        fn merge_base_in_the_checkout_locates_the_ref() {
4673            let (_t, repo) = fixture("[graph]\ncandidates = 2\n", "[merge]\nbase = \"nope\"\n");
4674            assert!(Config::discover(&repo, None).is_err());
4675        }
4676
4677        #[test]
4678        fn the_magi_dir_layer_is_read_too() {
4679            let (_t, repo) = fixture("[graph]\ncandidates = 2\n", "");
4680            std::fs::write(repo.join("magi.toml"), "[graph]\ncandidates = 2\n").unwrap();
4681            std::fs::create_dir_all(repo.join(".magi")).unwrap();
4682            std::fs::write(repo.join(".magi/config.toml"), "[graph]\njudges = 3\n").unwrap();
4683            git(&repo, &["add", "-A"]);
4684            git(&repo, &["commit", "-m", "y"]);
4685            git(&repo, &["push", "origin", "trunk"]);
4686            git(&repo, &["fetch", "origin"]);
4687            let (cfg, layers) = Config::discover(&repo, None).unwrap();
4688            assert_eq!((cfg.graph.implementers, cfg.graph.judges), (2, 3));
4689            assert_eq!(layers.len(), 2);
4690        }
4691
4692        #[test]
4693        fn an_include_in_a_repository_layer_resolves_against_the_same_commit() {
4694            let (_t, repo) = fixture("include = [\"gate.toml\"]\n", "");
4695            std::fs::write(repo.join("magi.toml"), "include = [\"gate.toml\"]\n").unwrap();
4696            std::fs::write(repo.join("gate.toml"), "[graph]\ncandidates = 2\n").unwrap();
4697            git(&repo, &["add", "-A"]);
4698            git(&repo, &["commit", "-m", "inc"]);
4699            git(&repo, &["push", "origin", "trunk"]);
4700            git(&repo, &["fetch", "origin"]);
4701            // The working tree's copy differs and must not be used.
4702            std::fs::write(repo.join("gate.toml"), "[graph]\ncandidates = 9\n").unwrap();
4703            let (cfg, _) = Config::discover(&repo, None).unwrap();
4704            assert_eq!(cfg.graph.implementers, 2);
4705        }
4706
4707        #[test]
4708        fn a_machine_layer_base_is_rendered_before_locating_the_ref() {
4709            let (t, repo) = fixture("[graph]\ncandidates = 2\n", "[merge]\nbase = \"nope\"\n");
4710            let m = t.path().join("machine.toml");
4711            std::fs::write(
4712                &m,
4713                "[merge]\nbase = \"{{ env.MAGI_TEST_NO_SUCH | default(value='trunk') }}\"\n",
4714            )
4715            .unwrap();
4716            let (remote, base) = {
4717                let probe = probe_merge(&m, &repo).unwrap();
4718                (probe.remote, probe.base)
4719            };
4720            assert_eq!((remote, base), (None, Some("trunk".to_owned())));
4721        }
4722
4723        #[test]
4724        fn a_machine_layer_base_sees_the_checkouts_repo_name() {
4725            let (t, repo) = fixture("[graph]\ncandidates = 2\n", "");
4726            let m = t.path().join("machine.toml");
4727            std::fs::write(&m, "[merge]\nbase = \"{{ repo_name }}\"\n").unwrap();
4728            let probe = probe_merge(&m, &repo).unwrap();
4729            assert_eq!(probe.base.as_deref(), Some("repo"));
4730        }
4731
4732        #[test]
4733        fn every_include_form_is_recognised() {
4734            assert!(declares_include("include = [\"a.toml\"]\n"));
4735            assert!(declares_include("\"include\" = [\"a.toml\"]\n"));
4736            assert!(declares_include("teravars = { include = [\"a.toml\"] }\n"));
4737            assert!(declares_include("[teravars]\ninclude = [\"a.toml\"]\n"));
4738            assert!(!declares_include("[graph]\ncandidates = 2\n"));
4739        }
4740
4741        #[test]
4742        fn an_explicit_config_is_read_as_named() {
4743            let (t, repo) = fixture("[graph]\ncandidates = 2\n", "");
4744            let own = t.path().join("own.toml");
4745            std::fs::write(&own, "[graph]\ncandidates = 4\n").unwrap();
4746            let (cfg, _) = Config::discover(&repo, Some(&own)).unwrap();
4747            assert_eq!(cfg.graph.implementers, 4);
4748        }
4749
4750        #[test]
4751        fn discover_fetched_fails_when_the_fetch_does() {
4752            let (t, repo) = fixture("[graph]\ncandidates = 2\n", "");
4753            std::fs::remove_dir_all(t.path().join("o.git")).unwrap();
4754            let rt = tokio::runtime::Builder::new_current_thread()
4755                .enable_all()
4756                .build()
4757                .unwrap();
4758            let err = rt
4759                .block_on(Config::discover_fetched(&repo, None))
4760                .unwrap_err();
4761            assert!(format!("{err:#}").contains("fetch"), "{err:#}");
4762        }
4763
4764        #[test]
4765        fn fetch_and_remote_parse_failures_have_distinct_verified_causes() {
4766            let (tmp, repo) = fixture("[graph\ncandidates = 2\n", "");
4767            let remote = tmp.path().join("o.git");
4768            let offline = tmp.path().join("offline.git");
4769            std::fs::rename(&remote, &offline).unwrap();
4770            let rt = tokio::runtime::Builder::new_current_thread()
4771                .enable_all()
4772                .build()
4773                .unwrap();
4774            let fetch = rt
4775                .block_on(Config::discover_fetched(&repo, None))
4776                .unwrap_err();
4777            let fetch_cause = fetch.downcast_ref::<ConfigFailure>().unwrap();
4778            assert_eq!(fetch_cause.stage, "config-fetch");
4779            assert_eq!(fetch_cause.target, "origin/trunk");
4780
4781            std::fs::rename(&offline, &remote).unwrap();
4782            let parse = rt
4783                .block_on(Config::discover_fetched(&repo, None))
4784                .unwrap_err();
4785            let parse_cause = parse.downcast_ref::<ConfigFailure>().unwrap();
4786            assert_eq!(parse_cause.stage, "config-parse");
4787            assert!(parse_cause.target.contains("magi.toml"));
4788            assert!(
4789                !parse_cause.target.contains("/magi/config/"),
4790                "cache commit paths are incidental"
4791            );
4792            assert_ne!(fetch_cause.stage, parse_cause.stage);
4793        }
4794
4795        #[test]
4796        fn discover_fetched_survives_a_fetch_that_leaves_no_origin_head() {
4797            // Never-fetched remote + followRemoteHEAD=never: fetch creates
4798            // origin/trunk but not origin/HEAD, which discovery then re-reads.
4799            let (_t, repo) = fixture("[graph]\ncandidates = 2\n", "");
4800            git(&repo, &["remote", "set-head", "origin", "-d"]);
4801            git(&repo, &["update-ref", "-d", "refs/remotes/origin/trunk"]);
4802            git(
4803                &repo,
4804                &["config", "remote.origin.followRemoteHEAD", "never"],
4805            );
4806            let rt = tokio::runtime::Builder::new_current_thread()
4807                .enable_all()
4808                .build()
4809                .unwrap();
4810            let (cfg, _) = rt.block_on(Config::discover_fetched(&repo, None)).unwrap();
4811            assert_eq!(cfg.graph.implementers, 2);
4812        }
4813
4814        #[test]
4815        fn a_non_git_directory_reads_its_files() {
4816            let dir = tempfile::tempdir().unwrap();
4817            std::fs::write(dir.path().join("magi.toml"), "[graph]\ncandidates = 4\n").unwrap();
4818            let (cfg, _) = Config::discover(dir.path(), None).unwrap();
4819            assert_eq!(cfg.graph.implementers, 4);
4820        }
4821    }
4822
4823    #[test]
4824    fn github_language_defaults_to_english_and_accepts_japanese() {
4825        let default: Graph = toml::from_str("").unwrap();
4826        assert_eq!(default.github_language, "en");
4827        assert!(default.github_english() && default.language_gate());
4828        let ja: Graph = toml::from_str("github_language = \"ja\"").unwrap();
4829        assert!(!ja.github_english() && !ja.language_gate());
4830        // Independent of the operator-facing language.
4831        let only_ops: Graph = toml::from_str("language = \"ja\"").unwrap();
4832        assert!(only_ops.language_gate());
4833        let off: Graph = toml::from_str("github_text_guard = false").unwrap();
4834        assert!(!off.language_gate() && off.github_english());
4835        assert!(Config::starter_toml().contains("github_language = \"en\""));
4836    }
4837}