Skip to main content

magi/
waiter.rs

1//! The waiter: something that keeps waiting on a question after the process
2//! that asked it is gone.
3//!
4//! `magi ask` blocks in the agent's own shell tool, and that tool kills a wait
5//! that runs long (see `ask::WAIT_SLICE`). An agent can also background the
6//! call and simply finish. Either way the question outlives the only process
7//! that would have read the owner's answer, and the owner's reply lands in a
8//! file nobody is polling - the phone then says "waiting for the agent" while
9//! there is no agent to wait for.
10//!
11//! This module is the guarantee that something is always on the other end. It
12//! runs inside `magi serve`, on its own cadence rather than the queue's, and
13//! for every question a `magi ask` filed it decides one of three things:
14//!
15//! - **the asker is still there** (its [`Lease`] is fresh): do nothing. A
16//!   second agent must never be started while the first is blocked;
17//! - **the asker is gone and the owner has said or answered something the agent
18//!   has not read**: resume the *same seat's* CLI session with the question,
19//!   the thread so far and the owner's words, so the agent that holds the
20//!   context carries on;
21//! - **nobody answered before `answer_timeout`**: abandon it, in the same words
22//!   the asker would have used.
23//!
24//! # Shape
25//!
26//! Same split as [`crate::queue`] and [`crate::ask`]: [`decide`] is pure - a
27//! question, a lease, a clock and a bool in, an [`Action`] out - and every
28//! filesystem or process effect is in [`Waiter::tick`]. State lives on disk (the
29//! question record and its lease), so a restarted daemon picks up exactly where
30//! the last one stopped, including an answer nobody has read yet.
31//!
32//! # What it will not do
33//!
34//! It never starts a fresh consultant. If the seat's session cannot be resumed
35//! (`agent::has_session` says no, the working directory is gone, the run is
36//! over, the agent left the roster) the question stays as it is, the owner
37//! gets a notification saying why, and nothing else runs. A new agent would
38//! have to be caught up on everything the first one knew, and would act on the
39//! owner's words without the context they were written against.
40//!
41//! It never assumes a resume worked either: a turn that fails or times out
42//! leaves the word undelivered, and a later tick tries again.
43
44use std::collections::HashMap;
45use std::path::PathBuf;
46use std::time::{Duration, Instant};
47
48use anyhow::Result;
49use jiff::Timestamp;
50
51use crate::agent::{self, Invocation, SeatState};
52use crate::ask::{Lease, Question, QuestionStatus, Questions, Waiter as Note, WaiterKind, Who};
53use crate::config::{AgentSpec, Config};
54use crate::notices::{self, Notice};
55use crate::prompt;
56use crate::run::RunState;
57
58/// How often the waiter looks at the store.
59pub const TICK: Duration = Duration::from_secs(5);
60
61/// Wall-clock limit for one resumed turn. A resumed agent may go on to do real
62/// work once it has the owner's word, but it is one conversation turn, not a
63/// whole node.
64const DELIVERY_TIMEOUT: Duration = Duration::from_secs(15 * 60);
65
66/// How long a failed or refused delivery is left alone before the same input
67/// is tried again. Long enough not to hammer a seat that is out of quota,
68/// short enough that a fixed problem does not wait a day.
69const RETRY_AFTER: Duration = Duration::from_secs(10 * 60);
70
71/// What the agent has not read yet.
72#[derive(Debug, Clone, PartialEq, Eq)]
73pub enum Word {
74    /// The owner spoke back without deciding.
75    Said(String),
76    /// The owner decided.
77    Answered(String),
78}
79
80/// What to do about one question, this tick.
81#[derive(Debug, Clone, PartialEq, Eq)]
82pub enum Action {
83    /// Nothing: not ours, someone is waiting, or nothing new to hand over.
84    Idle,
85    /// The deadline passed with no answer and nobody waiting.
86    Expire,
87    /// Resume the asking seat with this.
88    Deliver(Word),
89}
90
91/// The whole decision, with no I/O.
92///
93/// `seat_busy` is whether the asking seat's CLI is still mid-turn - the agent
94/// that exited its `magi ask` may not have exited itself, and resuming a
95/// conversation that is running would fork it.
96///
97/// Order matters: a word the owner gave before the deadline is delivered even
98/// if the deadline has passed by the time the waiter looks, and only then does
99/// an unanswered question expire.
100pub fn decide(
101    q: &Question,
102    lease: Option<&Lease>,
103    seat_busy: bool,
104    default_timeout: u64,
105    now: Timestamp,
106) -> Action {
107    decide_owned(q, lease, seat_busy, default_timeout, now, false)
108}
109
110/// [`decide`], told whether the daemon owns the answer's action.
111///
112/// `daemon_owns_action` is true when the daemon will apply the action (the
113/// task exists and is in a state `daemon::decide_action` acts on). An answer
114/// that carries a [`crate::ask::ChoiceAction`] is then the daemon's alone
115/// (`daemon::apply_choice_actions`, idempotent through `Task::actions_applied`
116/// under the task's claim): resuming the dead seat here as well would run the
117/// same seat twice when the action is a resume or a requeue. With no task
118/// there is no one to apply it, so the words are delivered as before.
119pub fn decide_owned(
120    q: &Question,
121    lease: Option<&Lease>,
122    seat_busy: bool,
123    default_timeout: u64,
124    now: Timestamp,
125    daemon_owns_action: bool,
126) -> Action {
127    if q.cwd.is_none() || lease.is_some_and(|l| l.fresh(now)) {
128        return Action::Idle;
129    }
130    match q.status {
131        QuestionStatus::Abandoned => Action::Idle,
132        QuestionStatus::Answered => match q.resolution() {
133            _ if daemon_owns_action && q.chosen_action().is_some() => Action::Idle,
134            Some(a) if !q.answer_delivered && !seat_busy => Action::Deliver(Word::Answered(a)),
135            _ => Action::Idle,
136        },
137        QuestionStatus::Open => {
138            if let Some(said) = q.unread_from_owner() {
139                if seat_busy {
140                    return Action::Idle;
141                }
142                return Action::Deliver(Word::Said(said));
143            }
144            let secs = if q.answer_timeout > 0 {
145                q.answer_timeout
146            } else {
147                default_timeout
148            };
149            let deadline = q.last_activity().saturating_add(secs as i64);
150            if now.as_second() > deadline {
151                Action::Expire
152            } else {
153                Action::Idle
154            }
155        }
156    }
157}
158
159/// Everything needed to resume one seat.
160struct Target {
161    coordination: Option<crate::config::Coordination>,
162    spec: AgentSpec,
163    seat: SeatState,
164    cwd: PathBuf,
165    sessions: bool,
166    allow_write: bool,
167    language: String,
168}
169
170/// The waiter's state: the store it watches and what it must remember between
171/// ticks (only which inputs it has already failed on).
172pub struct Waiter {
173    store: Questions,
174    home: PathBuf,
175    /// The config the conductor runs under, for a question the conductor asked
176    /// (it has no run whose snapshot could say).
177    conduct_cfg: Option<Config>,
178    /// `answer_timeout` for a question that did not record its own.
179    default_timeout: u64,
180    /// Inputs already tried and failed, by question id: `(key, until)`.
181    memo: HashMap<String, (String, Instant)>,
182}
183
184impl Waiter {
185    /// A waiter over `store`, with `home` as the magi home its runs live under.
186    pub fn new(store: Questions, home: PathBuf, conduct_cfg: Option<Config>) -> Self {
187        let default_timeout = conduct_cfg
188            .as_ref()
189            .map_or(Config::default().graph.answer_timeout, |c| {
190                c.graph.answer_timeout
191            });
192        Self {
193            store,
194            home,
195            conduct_cfg,
196            default_timeout,
197            memo: HashMap::new(),
198        }
199    }
200
201    /// Is this question's asking seat still mid-turn?
202    fn seat_busy(&self, q: &Question, now: Timestamp) -> bool {
203        if q.run == crate::conduct::NODE {
204            return crate::conduct::busy(&self.home);
205        }
206        RunState::load_under(&q.run, &self.home).is_ok_and(|s| {
207            s.seats_active()
208                .any(|(k, a)| *k == q.seat && a.remaining_secs(now) > 0)
209        })
210    }
211
212    /// Whether the daemon applies this question's chosen action, so the
213    /// waiter must not deliver the answer (see [`decide_owned`]).
214    fn daemon_owns_action(&self, q: &Question) -> bool {
215        crate::daemon::task_of_question(&crate::queue::Queue::at(self.home.join("queue")).list(), q)
216            .is_some_and(|t| crate::daemon::action_standing(t, q).daemon_owns())
217    }
218
219    /// Look at every question once and act on what needs acting on. `halt` is
220    /// asked between questions and during a delivery: true means the daemon is
221    /// parking, and whatever is in flight is dropped, undelivered and
222    /// resumable.
223    pub async fn tick(&mut self, now: Timestamp, halt: &(dyn Fn() -> bool + Sync)) {
224        for q in self.store.list() {
225            if halt() {
226                return;
227            }
228            let lease = self.store.read_lease(&q.id);
229            let owned = self.daemon_owns_action(&q);
230            match decide_owned(&q, lease.as_ref(), false, self.default_timeout, now, owned) {
231                Action::Idle => {}
232                Action::Expire => self.expire(&q),
233                Action::Deliver(word) => {
234                    // A question with a deputy is the deputy's to read
235                    // (`crate::deputy`); resuming the conductor's own seat
236                    // here would fork a conversation that is not its own.
237                    if q.deputy.is_some() {
238                        // Unless that deputy is spent: then nobody will read
239                        // the word, and the deadline still has to retire the
240                        // question.
241                        if crate::deputy::exhausted_past_deadline(
242                            &q,
243                            crate::deputy::can_start(
244                                self.conduct_cfg.as_ref(),
245                                crate::deputy::agent_of(&q),
246                            ),
247                            self.default_timeout,
248                            now,
249                        ) {
250                            self.expire(&q);
251                        }
252                        continue;
253                    }
254                    if self.seat_busy(&q, now) {
255                        continue;
256                    }
257                    let key = format!("{}:{:?}", q.thread.len(), word);
258                    if matches!(self.memo.get(&q.id), Some((k, until)) if *k == key && Instant::now() < *until)
259                    {
260                        continue;
261                    }
262                    if let Err(e) = self.deliver(&q, &word, halt).await {
263                        tracing::warn!("question {}: {e:#}", q.short());
264                    }
265                }
266            }
267        }
268    }
269
270    /// Abandon an unanswered question whose deadline passed with nobody
271    /// waiting - the words the asker's own wait would have used.
272    fn expire(&self, q: &Question) {
273        let secs = if q.answer_timeout > 0 {
274            q.answer_timeout
275        } else {
276            self.default_timeout
277        };
278        let startable =
279            crate::deputy::can_start(self.conduct_cfg.as_ref(), crate::deputy::agent_of(q));
280        let why = format!("no answer within {}s of asking", secs.max(1));
281        let done = self.store.update(&q.id, |r| {
282            // Decided again on the record as it is now: the owner may have
283            // spoken since the tick read it, and a word given in time is
284            // delivered, not abandoned.
285            let now = Timestamp::now();
286            let lease = self.store.read_lease(&r.id);
287            if decide(r, lease.as_ref(), false, self.default_timeout, now) != Action::Expire
288                && !(lease.as_ref().is_none_or(|l| !l.fresh(now))
289                    && crate::deputy::exhausted_past_deadline(
290                        r,
291                        startable,
292                        self.default_timeout,
293                        now,
294                    ))
295            {
296                return Ok(false);
297            }
298            r.abandon(&why);
299            r.waiter = None;
300            Ok(true)
301        });
302        match done {
303            Ok((_, false)) => {}
304            Ok((_, true)) => {
305                self.store.drop_lease(&q.id);
306                tracing::warn!(
307                    "question {} went unanswered for {secs}s with nobody waiting; \
308                     it stays as the record of it",
309                    q.short()
310                );
311            }
312            Err(e) => tracing::warn!("could not expire question {}: {e:#}", q.short()),
313        }
314    }
315
316    /// Admission uses the very same target resolution as actual delivery.
317    pub fn can_resume(&self, q: &Question) -> bool {
318        self.target(q).is_ok()
319    }
320
321    /// Work out how to resume the seat, or why it cannot be.
322    fn target(&self, q: &Question) -> std::result::Result<Target, String> {
323        let cwd = q
324            .cwd
325            .as_deref()
326            .map(PathBuf::from)
327            .filter(|p| p.is_dir())
328            .ok_or("the directory the agent was working in is gone")?;
329        let (cfg, seat, allow_write) = if q.run == crate::conduct::NODE {
330            let cfg = self
331                .conduct_cfg
332                .clone()
333                .ok_or("the conductor's configuration is not available")?;
334            let seat = crate::conduct::load_seat(&self.home)
335                .ok_or("the conductor has no recorded session")?;
336            (cfg, seat, false)
337        } else {
338            let state = RunState::load_under(&q.run, &self.home)
339                .map_err(|_| "the run that asked is gone".to_owned())?;
340            if !state.status.resumable() {
341                return Err(format!(
342                    "the run that asked has already {}",
343                    state.status.as_str()
344                ));
345            }
346            let seat = state
347                .seats
348                .get(&q.seat)
349                .cloned()
350                .ok_or("the run has no record of the asking seat")?;
351            let write = matches!(q.node.as_str(), "implement" | "fix");
352            (state.config, seat, write)
353        };
354        let spec = cfg
355            .agent(&seat.agent)
356            .map_err(|_| format!("agent `{}` is no longer in the roster", seat.agent))?
357            .clone();
358        if !agent::has_session(spec.kind, &seat, cfg.graph.sessions) {
359            return Err("the seat has no session to resume".to_owned());
360        }
361        Ok(Target {
362            coordination: cfg.coordination.clone(),
363            spec,
364            seat,
365            cwd,
366            sessions: cfg.graph.sessions,
367            allow_write,
368            language: cfg.graph.language.clone(),
369        })
370    }
371
372    /// Say why the owner's word cannot reach anybody, once per input.
373    fn refuse(&mut self, q: &Question, key: String, why: &str) {
374        tracing::warn!("question {} cannot be delivered: {why}", q.short());
375        notices::raise_in(
376            &self.home,
377            Notice::warn(
378                &format!("question:{}", q.id),
379                format!(
380                    "Question {} \"{}\": what you said cannot reach the agent \
381                     ({why}). It is recorded, but nothing will read it.",
382                    q.short(),
383                    q.summary
384                ),
385            ),
386        );
387        let _ = self.store.update(&q.id, |r| {
388            r.waiter = None;
389            Ok(())
390        });
391        self.memo
392            .insert(q.id.clone(), (key, Instant::now() + RETRY_AFTER));
393    }
394
395    /// Resume the asking seat with the owner's word.
396    async fn deliver(
397        &mut self,
398        q: &Question,
399        word: &Word,
400        halt: &(dyn Fn() -> bool + Sync),
401    ) -> Result<()> {
402        let key = format!("{}:{:?}", q.thread.len(), word);
403        let mut target = match self.target(q) {
404            Ok(t) => t,
405            Err(why) => {
406                self.refuse(q, key, &why);
407                return Ok(());
408            }
409        };
410
411        let claim = self.store.root().join(format!("{}.claim", q.id));
412        if !take_claim(&claim, DELIVERY_TIMEOUT + Duration::from_secs(60)) {
413            return Ok(());
414        }
415        let _release = Release(claim);
416
417        // Re-read under the claim: the asker may have come back, or the owner
418        // may have said more, since the tick's copy was taken.
419        let q = self.store.get(&q.id)?;
420        let now = Timestamp::now();
421        let lease = self.store.read_lease(&q.id);
422        let owned = self.daemon_owns_action(&q);
423        let Action::Deliver(word) =
424            decide_owned(&q, lease.as_ref(), false, self.default_timeout, now, owned)
425        else {
426            return Ok(());
427        };
428        let snapshot = q.thread.len();
429
430        // Ownership of an action answer is settled against the daemon's task
431        // claim: hold it while the lease goes up, so the daemon either sees the
432        // fresh lease or has already applied the action (and we step aside).
433        // A claim held by a running competition is not the daemon applying an
434        // action; that case is delivered, with the re-check below.
435        let queue = crate::queue::Queue::at(self.home.join("queue"));
436        let task_id = crate::daemon::task_of_question(&queue.list(), &q).map(|t| t.id.clone());
437        // Never go on without the claim: a failed claim means an attempt (or
438        // the daemon) holds the task, and whatever it does next decides who
439        // owns this answer. Step aside; the next tick judges it afresh.
440        let _task_claim = match (&task_id, q.chosen_action()) {
441            (Some(id), Some(_)) => match queue.claim(id) {
442                Ok(c) => Some(c),
443                Err(e) => {
444                    tracing::debug!(
445                        "question {}: task claim not available ({e:#}), deferring delivery",
446                        q.short()
447                    );
448                    return Ok(());
449                }
450            },
451            _ => None,
452        };
453        // Applied, stale and pending are all stop conditions; only a busy task
454        // (or no action at all) is delivered to.
455        let task_still_ours = || match &task_id {
456            Some(id) => queue
457                .get(id)
458                .map(|t| !crate::daemon::action_standing(&t, &q).daemon_owns())
459                .unwrap_or(true),
460            None => true,
461        };
462        if !task_still_ours() {
463            return Ok(());
464        }
465
466        self.store.beat(&q.id, WaiterKind::Daemon);
467        // Re-check after the lease is up: a daemon that decided before it
468        // existed has by now written its mark (or is blocked on our claim).
469        if !task_still_ours() {
470            return Ok(());
471        }
472        self.store.update(&q.id, |r| {
473            r.waiter = Some(Note {
474                kind: WaiterKind::Daemon,
475                since: now,
476            });
477            Ok(())
478        })?;
479        tracing::info!(
480            "question {}: the asker is gone, resuming seat {} with the owner's word",
481            q.short(),
482            q.seat
483        );
484
485        let thread: Vec<(&str, &str)> = q
486            .thread
487            .iter()
488            .map(|t| {
489                (
490                    if t.who == Who::Operator {
491                        "operator"
492                    } else {
493                        "agent"
494                    },
495                    t.body.as_str(),
496                )
497            })
498            .collect();
499        // What the owner said and the agent has not read has its own section in
500        // the prompt, so the recap stops at what it already read.
501        let shown = match word {
502            Word::Said(_) => &thread[..q.delivered_turns.min(thread.len())],
503            Word::Answered(_) => &thread[..],
504        };
505        let owner_word = match &word {
506            Word::Said(s) => prompt::OwnerWord::Said(s),
507            Word::Answered(a) => prompt::OwnerWord::Answered(a),
508        };
509        let body = prompt::question_resumed(
510            &q.id,
511            &q.summary,
512            &q.detail,
513            shown,
514            &owner_word,
515            &target.language,
516        );
517
518        let artifacts = self.store.root().join(format!("{}.delivery", q.id));
519        let stem = format!("deliver-{}", now.as_second());
520        let cache_dir = None;
521        let inv = Invocation {
522            coordination: target.coordination.as_ref(),
523            cwd: &target.cwd,
524            prompt: &body,
525            timeout: DELIVERY_TIMEOUT,
526            allow_write: target.allow_write,
527            unsandboxed: false,
528            sessions: target.sessions,
529            artifacts: &artifacts,
530            stem: &stem,
531            run: &q.run,
532            node: &q.node,
533            cache_dir,
534            attachments: &[],
535            writable: &[],
536        };
537
538        let store = self.store.clone();
539        let id = q.id.clone();
540        let out = {
541            let fut = agent::invoke(&target.spec, &mut target.seat, &inv);
542            tokio::pin!(fut);
543            let mut beat = tokio::time::interval(Duration::from_secs(1));
544            let mut beats = 0u32;
545            loop {
546                tokio::select! {
547                    r = &mut fut => break Some(r),
548                    _ = beat.tick() => {
549                        if halt() {
550                            break None;
551                        }
552                        beats += 1;
553                        if beats % 20 == 0 {
554                            store.beat(&id, WaiterKind::Daemon);
555                        }
556                    }
557                }
558            }
559        };
560
561        let Some(out) = out else {
562            // Parking: leave everything as it was, resumable.
563            let _ = self.store.update(&q.id, |r| {
564                r.waiter = None;
565                Ok(())
566            });
567            return Ok(());
568        };
569        let out = match out {
570            Ok(o) if o.usable() => o,
571            other => {
572                let why = match other {
573                    Ok(o) if o.timed_out => "the resumed turn timed out".to_owned(),
574                    Ok(o) if o.quota_exhausted() => "the agent is out of quota".to_owned(),
575                    Ok(o) => format!(
576                        "the resumed turn failed ({})",
577                        notices::exit_status(o.exit_code)
578                    ),
579                    Err(e) => format!("the agent could not be started: {e:#}"),
580                };
581                self.refuse(&q, key, &why);
582                return Ok(());
583            }
584        };
585
586        let text = out.text.trim().to_owned();
587        self.store.update(&q.id, |r| {
588            r.waiter = None;
589            match &word {
590                Word::Answered(_) => r.answer_delivered = true,
591                Word::Said(_) => {
592                    r.delivered_turns = r.delivered_turns.max(snapshot);
593                    // An agent that answered in prose instead of calling
594                    // `magi ask --thread` still spoke; keep it on the record so
595                    // the owner reads it. If it did use --thread, or the owner
596                    // said more meanwhile, the record already moved on.
597                    let agent_spoke = r.thread[snapshot.min(r.thread.len())..]
598                        .iter()
599                        .any(|t| t.who == Who::Agent);
600                    if !agent_spoke && r.thread.len() == snapshot && r.status.open() {
601                        let choices = r.choices.clone();
602                        r.reply(text, choices)?;
603                    }
604                }
605            }
606            Ok(())
607        })?;
608        self.memo.remove(&q.id);
609        Ok(())
610    }
611}
612
613/// Take the delivery claim, so two waiters (`magi serve` twice, or a stray
614/// second daemon) cannot resume the same seat at once. A claim older than a
615/// whole delivery plus slack was left by a process that died.
616pub(crate) fn take_claim(path: &std::path::Path, stale_after: Duration) -> bool {
617    let attempt = || {
618        std::fs::OpenOptions::new()
619            .write(true)
620            .create_new(true)
621            .open(path)
622            .is_ok()
623    };
624    if attempt() {
625        return true;
626    }
627    let stale = std::fs::metadata(path)
628        .and_then(|m| m.modified())
629        .ok()
630        .and_then(|t| t.elapsed().ok())
631        .is_some_and(|age| age > stale_after);
632    if stale {
633        let _ = std::fs::remove_file(path);
634        return attempt();
635    }
636    false
637}
638
639/// Removes the delivery claim when the delivery ends, however it ends.
640pub(crate) struct Release(pub(crate) PathBuf);
641
642impl Drop for Release {
643    fn drop(&mut self) {
644        let _ = std::fs::remove_file(&self.0);
645    }
646}
647
648/// The waiter's loop, until `stop` is asked for.
649///
650/// A stop ends the loop between ticks; a park also drops a delivery in flight.
651/// Neither writes anything to a question: the lease just ages out and the next
652/// waiter - this daemon restarted, or another - reads the same state off disk.
653pub async fn run(mut waiter: Waiter, stop: crate::daemon::Stop) {
654    let halt = {
655        let stop = stop.clone();
656        move || stop.parking()
657    };
658    while !stop.stopped() {
659        waiter.tick(Timestamp::now(), &halt).await;
660        tokio::time::sleep(TICK).await;
661    }
662}
663
664#[cfg(test)]
665mod tests {
666    use super::*;
667
668    fn ts(secs: i64) -> Timestamp {
669        Timestamp::from_second(secs).unwrap()
670    }
671
672    fn asked(at: i64) -> Question {
673        let mut q = Question::new(
674            "run".into(),
675            "implement".into(),
676            "impl-A".into(),
677            "which?".into(),
678            String::new(),
679            vec![],
680        );
681        q.cwd = Some("/tmp".into());
682        q.asked_at = ts(at);
683        q.answer_timeout = 1000;
684        q
685    }
686
687    fn lease(at: i64) -> Lease {
688        Lease {
689            kind: WaiterKind::Asker,
690            pid: 1,
691            beat_at: ts(at),
692        }
693    }
694
695    #[test]
696    fn a_fresh_lease_means_nobody_else_acts() {
697        let mut q = asked(0);
698        q.say("why?").unwrap();
699        assert_eq!(
700            decide(&q, Some(&lease(95)), false, 86_400, ts(100)),
701            Action::Idle
702        );
703    }
704
705    #[test]
706    fn a_stale_lease_delivers_what_the_owner_said() {
707        let mut q = asked(0);
708        q.say("why?").unwrap();
709        assert_eq!(
710            decide(&q, Some(&lease(0)), false, 86_400, ts(500)),
711            Action::Deliver(Word::Said("why?".into()))
712        );
713        assert_eq!(
714            decide(&q, None, true, 86_400, ts(500)),
715            Action::Idle,
716            "a seat still mid-turn is not resumed"
717        );
718    }
719
720    #[test]
721    fn an_answer_nobody_read_is_delivered_once() {
722        let mut q = asked(0);
723        q.choices = vec!["A".into()];
724        q.answer(crate::ask::Answer::Choice("A".into())).unwrap();
725        assert_eq!(
726            decide(&q, None, false, 86_400, ts(10)),
727            Action::Deliver(Word::Answered("A".into()))
728        );
729        q.answer_delivered = true;
730        assert_eq!(decide(&q, None, false, 86_400, ts(10)), Action::Idle);
731    }
732
733    #[test]
734    fn only_asked_questions_and_only_before_the_deadline() {
735        let mut q = asked(0);
736        assert_eq!(decide(&q, None, false, 86_400, ts(999)), Action::Idle);
737        assert_eq!(decide(&q, None, false, 86_400, ts(1001)), Action::Expire);
738        q.cwd = None;
739        assert_eq!(decide(&q, None, false, 86_400, ts(1001)), Action::Idle);
740    }
741
742    #[test]
743    fn the_deadline_runs_from_the_last_turn_not_from_asking() {
744        let mut q = asked(0);
745        q.thread.push(crate::ask::Turn {
746            who: Who::Agent,
747            body: "context".into(),
748            at: ts(4000),
749            note: None,
750        });
751        q.delivered_turns = 1;
752        assert_eq!(decide(&q, None, false, 86_400, ts(4500)), Action::Idle);
753        assert_eq!(decide(&q, None, false, 86_400, ts(5001)), Action::Expire);
754    }
755
756    #[test]
757    fn a_word_given_in_time_is_delivered_after_the_deadline() {
758        let mut q = asked(0);
759        q.say("wait").unwrap();
760        assert!(matches!(
761            decide(&q, None, false, 86_400, ts(5000)),
762            Action::Deliver(_)
763        ));
764    }
765
766    #[test]
767    fn an_action_answer_is_left_to_the_daemon() {
768        let mut q = asked(0);
769        q.choices = vec!["A".into()];
770        q.actions
771            .insert("A".into(), crate::ask::ChoiceAction::Requeue);
772        q.answer(crate::ask::Answer::Choice("A".into())).unwrap();
773        assert_eq!(
774            decide_owned(&q, None, false, 86_400, ts(10), true),
775            Action::Idle,
776            "the daemon applies the action; the waiter must not also resume the seat"
777        );
778        // Delivered or not, a stale lease changes nothing.
779        q.answer_delivered = true;
780        assert_eq!(
781            decide_owned(&q, None, false, 86_400, ts(10), true),
782            Action::Idle
783        );
784        // No task to apply it: the words are delivered as before.
785        q.answer_delivered = false;
786        assert_eq!(
787            decide_owned(&q, None, false, 86_400, ts(10), false),
788            Action::Deliver(Word::Answered("A".into()))
789        );
790        // No action: delivered even when a task exists.
791        let mut plain = asked(0);
792        plain.choices = vec!["A".into()];
793        plain
794            .answer(crate::ask::Answer::Choice("A".into()))
795            .unwrap();
796        assert_eq!(
797            decide_owned(&plain, None, false, 86_400, ts(10), true),
798            Action::Deliver(Word::Answered("A".into()))
799        );
800    }
801}