liminal_bus_protocol/

codec.rs

mod known;
mod payload;

#[cfg(test)]
mod tests_support;

use super::causal::MessageId;
use super::envelope::{MessageEnvelope, SchemaId};
use super::error::ProtocolError;
use super::frame::{
    DISCONNECT_REASON_BODY_VERSION, DeliveredId, Frame, FrameType, HEADER_LEN, LINK_END_EXPORT,
    LINK_END_IMPORT, LINK_MACHINE_LEN, LINK_OPEN_ACK_HELD, LINK_OPEN_ACK_OPENED,
    LINK_OPEN_ACK_REFUSED, LinkEnd, LinkOffer, LinkOpenOutcome, WORKER_REGISTER_ACK_ACCEPTED,
    WORKER_REGISTER_ACK_REJECTED, WorkerActivityDescriptor, WorkerRegisterOutcome,
    WorkerRegistration, validate_stream,
};
use super::version::ProtocolVersion;
use known::decode_known_payload;
use payload::{
    PayloadReader, PayloadWriter, U16_LEN, U32_LEN, U64_LEN, bytes_field_len, checked_u32_len,
    option_string_len, option_u16_len, schema_ids_field_len, string_field_len,
    string_vec_field_len, sum_lengths,
};

/// Wire length of the one-byte fields the worker-registration frames use (the
/// optional-node presence byte folds into [`option_string_len`]; this covers the
/// ack's status byte).
const U8_FIELD_LEN: usize = 1;

/// Return the number of bytes needed to encode a frame.
///
/// # Errors
///
/// Returns [`ProtocolError`] when the frame violates stream invariants or its
/// payload cannot fit in the protocol's `u32` length fields.
pub fn encoded_len(frame: &Frame) -> Result<usize, ProtocolError> {
    frame.validate()?;
    let payload_len = encoded_payload_len(frame)?;
    HEADER_LEN
        .checked_add(payload_len)
        .ok_or_else(|| ProtocolError::codec("encoded frame length overflowed usize"))
}

/// Encode a frame into the provided byte buffer, returning bytes written.
///
/// The buffer must be at least [`encoded_len`] bytes long. Encoding writes the
/// fixed 10-byte header followed by the serialized payload and performs no heap
/// allocation.
///
/// # Errors
///
/// Returns [`ProtocolError`] when the frame violates stream invariants, its
/// payload cannot fit in the protocol's length fields, or the provided buffer is
/// too small.
pub fn encode(frame: &Frame, buffer: &mut [u8]) -> Result<usize, ProtocolError> {
    frame.validate()?;
    let payload_len = encoded_payload_len(frame)?;
    let payload_length = u32::try_from(payload_len)
        .map_err(|_| ProtocolError::codec("payload length exceeded u32::MAX"))?;
    let total_len = HEADER_LEN
        .checked_add(payload_len)
        .ok_or_else(|| ProtocolError::codec("encoded frame length overflowed usize"))?;

    if buffer.len() < total_len {
        return Err(ProtocolError::codec("output buffer is too small"));
    }

    let Some(header) = buffer.get_mut(..HEADER_LEN) else {
        return Err(ProtocolError::codec(
            "output buffer is too small for header",
        ));
    };
    write_header(frame, payload_length, header)?;

    let Some(payload) = buffer.get_mut(HEADER_LEN..total_len) else {
        return Err(ProtocolError::codec(
            "output buffer is too small for payload",
        ));
    };
    write_payload(frame, payload)?;

    Ok(total_len)
}

/// Decode one complete frame from a byte buffer.
///
/// Returns the decoded frame and the number of bytes consumed. Unknown frame
/// types are length-delimited and returned as [`Frame::Unknown`] without
/// producing an error.
///
/// # Errors
///
/// Returns [`ProtocolError::IncompleteHeader`] for buffers shorter than the
/// fixed header, [`ProtocolError::TruncatedPayload`] when the declared payload
/// is not fully present, and [`ProtocolError`] for malformed known-frame
/// payloads or invalid stream placement.
pub fn decode(buffer: &[u8]) -> Result<(Frame, usize), ProtocolError> {
    if buffer.len() < HEADER_LEN {
        return Err(ProtocolError::IncompleteHeader {
            message: Some("buffer shorter than fixed frame header".to_owned()),
        });
    }

    let Some(header) = buffer.get(..HEADER_LEN) else {
        return Err(ProtocolError::IncompleteHeader {
            message: Some("buffer shorter than fixed frame header".to_owned()),
        });
    };
    let mut header_reader = PayloadReader::new(header);
    let type_id = header_reader.read_u8()?;
    let flags = header_reader.read_u8()?;
    let stream_id = header_reader.read_u32()?;
    let payload_length = header_reader.read_u32()?;
    header_reader.finish()?;

    let payload_len = usize::try_from(payload_length)
        .map_err(|_| ProtocolError::codec("payload length cannot fit usize"))?;
    let total_len = HEADER_LEN
        .checked_add(payload_len)
        .ok_or_else(|| ProtocolError::codec("decoded frame length overflowed usize"))?;

    if buffer.len() < total_len {
        return Err(ProtocolError::TruncatedPayload {
            message: Some("buffer shorter than declared payload length".to_owned()),
        });
    }

    let Some(payload) = buffer.get(HEADER_LEN..total_len) else {
        return Err(ProtocolError::TruncatedPayload {
            message: Some("buffer shorter than declared payload length".to_owned()),
        });
    };

    let frame_type = FrameType::from(type_id);
    let frame = decode_payload(frame_type, flags, stream_id, payload)?;
    Ok((frame, total_len))
}

fn write_header(
    frame: &Frame,
    payload_length: u32,
    buffer: &mut [u8],
) -> Result<(), ProtocolError> {
    let mut writer = PayloadWriter::new(buffer);
    writer.write_u8(u8::from(frame.frame_type()))?;
    writer.write_u8(frame.wire_flags())?;
    writer.write_u32(frame.stream_id())?;
    writer.write_u32(payload_length)?;
    writer.finish()
}

fn encoded_payload_len(frame: &Frame) -> Result<usize, ProtocolError> {
    match frame {
        Frame::Connect { auth_token, .. } => sum_lengths(&[
            ProtocolVersion::WIRE_LEN,
            ProtocolVersion::WIRE_LEN,
            bytes_field_len(auth_token)?,
        ]),
        Frame::ConnectAck { .. } => sum_lengths(&[ProtocolVersion::WIRE_LEN, U32_LEN]),
        Frame::ConnectError { message, .. }
        | Frame::SubscribeError { message, .. }
        | Frame::PublishError { message, .. } => {
            sum_lengths(&[U16_LEN, option_string_len(message.as_deref())?])
        }
        Frame::Disconnect { .. } | Frame::Ping { .. } | Frame::Pong { .. } => Ok(0),
        Frame::DisconnectReason { reason, .. } => {
            sum_lengths(&[U8_FIELD_LEN, U16_LEN, string_field_len(reason.name())?])
        }
        Frame::Subscribe {
            channel,
            accepted_schemas,
            ..
        } => sum_lengths(&[
            string_field_len(channel)?,
            schema_ids_field_len(accepted_schemas)?,
            U32_LEN,
        ]),
        Frame::SubscribeAck { .. } => sum_lengths(&[U64_LEN, SchemaId::WIRE_LEN]),
        Frame::Unsubscribe { .. } | Frame::DeliverAck { .. } => Ok(U64_LEN),
        Frame::PublishAck {
            durable_position,
            boot,
            ..
        } => sum_lengths(&[
            U64_LEN,
            durable_position.map_or(0, |_| U64_LEN),
            boot.map_or(0, |_| U64_LEN),
        ]),
        Frame::Publish {
            channel,
            envelope,
            idempotency_key,
            ..
        } => {
            let mut parts = vec![
                string_field_len(channel)?,
                envelope_bytes_field_len(envelope.encoded_len()?)?,
            ];
            if let Some(key) = idempotency_key {
                parts.push(string_field_len(key)?);
            }
            sum_lengths(&parts)
        }
        Frame::ConversationOpen { .. }
        | Frame::ConversationMessage { .. }
        | Frame::ConversationClose { .. }
        | Frame::ConversationError { .. } => conversation_payload_len(frame),
        // Conversation-message and delivery frames share a wire shape: a `u64`
        // prefix (conversation id / delivery seq) followed by a length-prefixed
        // envelope. A delivery carrying its message id adds the boot and the id.
        Frame::Deliver {
            envelope,
            message,
            position,
            ..
        } => sum_lengths(&[
            U64_LEN,
            envelope_bytes_field_len(envelope.encoded_len()?)?,
            message.map_or(0, |_| U64_LEN + U64_LEN),
            position.map_or(0, |_| U64_LEN),
        ]),
        Frame::LinkOpen { offer, .. } => link_open_payload_len(offer),
        Frame::LinkOpenAck { outcome, .. } => link_open_ack_payload_len(outcome),
        Frame::LinkMessage {
            subject, sealed, ..
        } => sum_lengths(&[string_field_len(subject)?, bytes_field_len(sealed)?]),
        Frame::Accept {
            referenced_message_id,
            ..
        } => message_id_field_len(referenced_message_id),
        Frame::Defer {
            referenced_message_id,
            reason,
            ..
        }
        | Frame::Reject {
            referenced_message_id,
            reason,
            ..
        } => sum_lengths(&[
            message_id_field_len(referenced_message_id)?,
            option_string_len(reason.as_deref())?,
        ]),
        Frame::Push { payload, .. } | Frame::PushReply { payload, .. } => {
            sum_lengths(&[U64_LEN, bytes_field_len(payload)?])
        }
        Frame::WorkerRegister { registration, .. } => worker_register_payload_len(registration),
        Frame::WorkerRegisterAck { outcome, .. } => worker_register_ack_payload_len(outcome),
        Frame::Unknown { payload, .. } => checked_u32_len(payload.len()).map(|()| payload.len()),
    }
}

fn envelope_bytes_field_len(envelope_len: usize) -> Result<usize, ProtocolError> {
    checked_u32_len(envelope_len)?;
    sum_lengths(&[U32_LEN, envelope_len])
}

fn message_id_field_len(message_id: &MessageId) -> Result<usize, ProtocolError> {
    string_field_len(message_id.as_str())
}

fn conversation_payload_len(frame: &Frame) -> Result<usize, ProtocolError> {
    match frame {
        Frame::ConversationOpen { subject, .. } => {
            sum_lengths(&[U64_LEN, string_field_len(subject)?])
        }
        // A conversation message shares the delivery frame's wire shape: a
        // `u64` conversation id followed by a length-prefixed envelope.
        Frame::ConversationMessage { envelope, .. } => {
            sum_lengths(&[U64_LEN, envelope_bytes_field_len(envelope.encoded_len()?)?])
        }
        Frame::ConversationClose {
            reason_code,
            message,
            ..
        } => sum_lengths(&[
            U64_LEN,
            option_u16_len(*reason_code),
            option_string_len(message.as_deref())?,
        ]),
        Frame::ConversationError { message, .. } => {
            sum_lengths(&[U64_LEN, U16_LEN, option_string_len(message.as_deref())?])
        }
        _ => Err(ProtocolError::codec(
            "frame type was not a conversation frame",
        )),
    }
}

fn link_open_payload_len(offer: &LinkOffer) -> Result<usize, ProtocolError> {
    sum_lengths(&[
        string_field_len(&offer.link_id)?,
        U8_FIELD_LEN,
        LINK_MACHINE_LEN,
        bytes_field_len(&offer.handshake)?,
    ])
}

fn link_open_ack_payload_len(outcome: &LinkOpenOutcome) -> Result<usize, ProtocolError> {
    match outcome {
        LinkOpenOutcome::Opened { handshake } => {
            sum_lengths(&[U8_FIELD_LEN, bytes_field_len(handshake)?])
        }
        LinkOpenOutcome::Held { grant, draft } => sum_lengths(&[
            U8_FIELD_LEN,
            string_field_len(grant)?,
            string_field_len(draft)?,
        ]),
        LinkOpenOutcome::Refused { reason } => {
            sum_lengths(&[U8_FIELD_LEN, string_field_len(reason)?])
        }
    }
}

fn worker_register_payload_len(registration: &WorkerRegistration) -> Result<usize, ProtocolError> {
    sum_lengths(&[
        string_vec_field_len(&registration.namespaces)?,
        string_field_len(&registration.task_queue)?,
        option_string_len(registration.node.as_deref())?,
        string_vec_field_len(&registration.activity_types)?,
        string_field_len(&registration.identity)?,
        activity_descriptors_field_len(&registration.activities)?,
    ])
}

fn activity_descriptors_field_len(
    activities: &[WorkerActivityDescriptor],
) -> Result<usize, ProtocolError> {
    checked_u32_len(activities.len())?;
    let mut total = U32_LEN;
    for activity in activities {
        total = sum_lengths(&[
            total,
            string_field_len(&activity.name)?,
            string_field_len(&activity.input_schema_json)?,
            string_field_len(&activity.output_schema_json)?,
        ])?;
    }
    Ok(total)
}

fn worker_register_ack_payload_len(
    outcome: &WorkerRegisterOutcome,
) -> Result<usize, ProtocolError> {
    match outcome {
        WorkerRegisterOutcome::Accepted => Ok(U8_FIELD_LEN),
        WorkerRegisterOutcome::Rejected { reason } => {
            sum_lengths(&[U8_FIELD_LEN, string_field_len(reason)?])
        }
    }
}

fn write_handshake_payload(
    frame: &Frame,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    match frame {
        Frame::Connect {
            min_version,
            max_version,
            auth_token,
            ..
        } => {
            writer.write_slice(&min_version.to_wire_bytes())?;
            writer.write_slice(&max_version.to_wire_bytes())?;
            writer.write_bytes_field(auth_token)
        }
        Frame::ConnectAck {
            selected_version,
            capabilities,
            ..
        } => {
            writer.write_slice(&selected_version.to_wire_bytes())?;
            writer.write_u32(*capabilities)
        }
        _ => Err(ProtocolError::codec("frame type was not a handshake frame")),
    }
}

fn write_pressure_payload(
    frame: &Frame,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    match frame {
        Frame::Accept {
            referenced_message_id,
            ..
        } => writer.write_string_field(referenced_message_id.as_str()),
        Frame::Defer {
            referenced_message_id,
            reason,
            ..
        }
        | Frame::Reject {
            referenced_message_id,
            reason,
            ..
        } => {
            writer.write_string_field(referenced_message_id.as_str())?;
            writer.write_optional_string(reason.as_deref())
        }
        _ => Err(ProtocolError::codec("frame type was not a pressure frame")),
    }
}

fn write_publish(frame: &Frame, writer: &mut PayloadWriter<'_>) -> Result<(), ProtocolError> {
    match frame {
        Frame::Publish {
            channel,
            envelope,
            idempotency_key,
            ..
        } => {
            writer.write_string_field(channel)?;
            writer.write_bytes_field(&envelope.serialize()?)?;
            // The trailing key is written ONLY when present (its flag bit tells the
            // decoder), so a no-key publish stays byte-identical to pre-13-L1.
            if let Some(key) = idempotency_key {
                writer.write_string_field(key)?;
            }
            Ok(())
        }
        Frame::PublishAck {
            message_id,
            durable_position,
            boot,
            ..
        } => {
            writer.write_u64(*message_id)?;
            writer.write_flagged_u64(*durable_position)?;
            writer.write_flagged_u64(*boot)
        }
        _ => Err(ProtocolError::codec("frame type was not a publish frame")),
    }
}

fn write_conversation_payload(
    frame: &Frame,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    match frame {
        Frame::ConversationOpen {
            conversation_id,
            subject,
            ..
        } => {
            writer.write_u64(*conversation_id)?;
            writer.write_string_field(subject)
        }
        Frame::ConversationMessage {
            conversation_id,
            envelope,
            ..
        } => write_u64_prefixed_envelope(writer, *conversation_id, envelope),
        Frame::ConversationClose {
            conversation_id,
            reason_code,
            message,
            ..
        } => {
            writer.write_u64(*conversation_id)?;
            writer.write_optional_u16(*reason_code)?;
            writer.write_optional_string(message.as_deref())
        }
        Frame::ConversationError {
            conversation_id,
            reason_code,
            message,
            ..
        } => {
            writer.write_u64(*conversation_id)?;
            writer.write_u16(*reason_code)?;
            writer.write_optional_string(message.as_deref())
        }
        _ => Err(ProtocolError::codec(
            "frame type was not a conversation frame",
        )),
    }
}

/// Writes a `u64` prefix followed by a length-prefixed serialized envelope — the
/// shared body of conversation-message and delivery frames.
fn write_u64_prefixed_envelope(
    writer: &mut PayloadWriter<'_>,
    value: u64,
    envelope: &MessageEnvelope,
) -> Result<(), ProtocolError> {
    writer.write_u64(value)?;
    writer.write_bytes_field(&envelope.serialize()?)
}

/// Writes a delivery's body: the `u64` delivery sequence and the envelope, then
/// the boot and the id ONLY when present (its flag bit tells the decoder), so a
/// Deliver without them stays byte-identical to 1.1.
fn write_deliver_payload(
    writer: &mut PayloadWriter<'_>,
    delivery_seq: u64,
    envelope: &MessageEnvelope,
    message: Option<DeliveredId>,
    position: Option<u64>,
) -> Result<(), ProtocolError> {
    write_u64_prefixed_envelope(writer, delivery_seq, envelope)?;
    if let Some(DeliveredId { boot, id }) = message {
        writer.write_u64(boot)?;
        writer.write_u64(id)?;
    }
    writer.write_flagged_u64(position)?;
    Ok(())
}

fn write_push_payload(frame: &Frame, writer: &mut PayloadWriter<'_>) -> Result<(), ProtocolError> {
    match frame {
        Frame::Push {
            correlation_id,
            payload,
            ..
        }
        | Frame::PushReply {
            correlation_id,
            payload,
            ..
        } => {
            writer.write_u64(*correlation_id)?;
            writer.write_bytes_field(payload)
        }
        _ => Err(ProtocolError::codec("frame type was not a push frame")),
    }
}

fn write_worker_register_payload(
    registration: &WorkerRegistration,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    writer.write_string_vec_field(&registration.namespaces)?;
    writer.write_string_field(&registration.task_queue)?;
    // `node` is optional locality: a presence byte distinguishes `None` from
    // `Some("")` so an absent node never collapses to an empty string.
    writer.write_optional_string(registration.node.as_deref())?;
    writer.write_string_vec_field(&registration.activity_types)?;
    writer.write_string_field(&registration.identity)?;
    let count = u32::try_from(registration.activities.len())
        .map_err(|_| ProtocolError::codec("activity descriptor count exceeded u32::MAX"))?;
    writer.write_u32(count)?;
    for activity in &registration.activities {
        writer.write_string_field(&activity.name)?;
        writer.write_string_field(&activity.input_schema_json)?;
        writer.write_string_field(&activity.output_schema_json)?;
    }
    Ok(())
}

fn write_worker_register_ack_payload(
    outcome: &WorkerRegisterOutcome,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    match outcome {
        WorkerRegisterOutcome::Accepted => writer.write_u8(WORKER_REGISTER_ACK_ACCEPTED),
        WorkerRegisterOutcome::Rejected { reason } => {
            writer.write_u8(WORKER_REGISTER_ACK_REJECTED)?;
            writer.write_string_field(reason)
        }
    }
}

/// The wire byte of a link end.
const fn link_end_byte(end: LinkEnd) -> u8 {
    match end {
        LinkEnd::Export => LINK_END_EXPORT,
        LinkEnd::Import => LINK_END_IMPORT,
    }
}

fn write_link_open_payload(
    offer: &LinkOffer,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    writer.write_string_field(&offer.link_id)?;
    writer.write_u8(link_end_byte(offer.end))?;
    // The machine key is fixed-length: raw, no length prefix.
    writer.write_slice(&offer.machine)?;
    writer.write_bytes_field(&offer.handshake)
}

fn write_link_open_ack_payload(
    outcome: &LinkOpenOutcome,
    writer: &mut PayloadWriter<'_>,
) -> Result<(), ProtocolError> {
    match outcome {
        LinkOpenOutcome::Opened { handshake } => {
            writer.write_u8(LINK_OPEN_ACK_OPENED)?;
            writer.write_bytes_field(handshake)
        }
        LinkOpenOutcome::Held { grant, draft } => {
            writer.write_u8(LINK_OPEN_ACK_HELD)?;
            writer.write_string_field(grant)?;
            writer.write_string_field(draft)
        }
        LinkOpenOutcome::Refused { reason } => {
            writer.write_u8(LINK_OPEN_ACK_REFUSED)?;
            writer.write_string_field(reason)
        }
    }
}

fn write_payload(frame: &Frame, buffer: &mut [u8]) -> Result<(), ProtocolError> {
    let mut writer = PayloadWriter::new(buffer);
    match frame {
        Frame::Connect { .. } | Frame::ConnectAck { .. } => {
            write_handshake_payload(frame, &mut writer)?;
        }
        Frame::ConnectError {
            reason_code,
            message,
            ..
        }
        | Frame::SubscribeError {
            reason_code,
            message,
            ..
        }
        | Frame::PublishError {
            reason_code,
            message,
            ..
        } => {
            writer.write_u16(*reason_code)?;
            writer.write_optional_string(message.as_deref())?;
        }
        Frame::Disconnect { .. } | Frame::Ping { .. } | Frame::Pong { .. } => {}
        Frame::DisconnectReason { reason, .. } => {
            // ACCESS-005 R5: body version, then the reason's code and name.
            // The typed reason makes a code/name disagreement unwritable.
            writer.write_u8(DISCONNECT_REASON_BODY_VERSION)?;
            writer.write_u16(reason.code())?;
            writer.write_string_field(reason.name())?;
        }
        Frame::Subscribe {
            channel,
            accepted_schemas,
            max_in_flight,
            ..
        } => {
            writer.write_string_field(channel)?;
            writer.write_schema_ids_field(accepted_schemas)?;
            writer.write_u32(*max_in_flight)?;
        }
        Frame::SubscribeAck {
            subscription_id,
            selected_schema,
            ..
        } => {
            writer.write_u64(*subscription_id)?;
            writer.write_schema_id(*selected_schema)?;
        }
        Frame::DeliverAck { position, .. } => writer.write_u64(*position)?,
        Frame::Unsubscribe {
            subscription_id, ..
        } => writer.write_u64(*subscription_id)?,
        Frame::Publish { .. } | Frame::PublishAck { .. } => write_publish(frame, &mut writer)?,
        Frame::ConversationOpen { .. }
        | Frame::ConversationMessage { .. }
        | Frame::ConversationClose { .. }
        | Frame::ConversationError { .. } => write_conversation_payload(frame, &mut writer)?,
        Frame::Accept { .. } | Frame::Defer { .. } | Frame::Reject { .. } => {
            write_pressure_payload(frame, &mut writer)?;
        }
        Frame::Push { .. } | Frame::PushReply { .. } => {
            write_push_payload(frame, &mut writer)?;
        }
        Frame::Deliver {
            delivery_seq,
            envelope,
            message,
            position,
            ..
        } => write_deliver_payload(&mut writer, *delivery_seq, envelope, *message, *position)?,
        Frame::WorkerRegister { registration, .. } => {
            write_worker_register_payload(registration, &mut writer)?;
        }
        Frame::WorkerRegisterAck { outcome, .. } => {
            write_worker_register_ack_payload(outcome, &mut writer)?;
        }
        Frame::LinkOpen { offer, .. } => write_link_open_payload(offer, &mut writer)?,
        Frame::LinkOpenAck { outcome, .. } => write_link_open_ack_payload(outcome, &mut writer)?,
        Frame::LinkMessage {
            subject, sealed, ..
        } => {
            writer.write_string_field(subject)?;
            writer.write_bytes_field(sealed)?;
        }
        Frame::Unknown { payload, .. } => writer.write_slice(payload)?,
    }
    writer.finish()
}

fn decode_payload(
    frame_type: FrameType,
    flags: u8,
    stream_id: u32,
    payload: &[u8],
) -> Result<Frame, ProtocolError> {
    if let FrameType::Unknown(type_id) = frame_type {
        return Ok(Frame::Unknown {
            type_id,
            flags,
            stream_id,
            payload: payload.to_vec(),
        });
    }

    validate_stream(frame_type, stream_id)?;
    decode_known_payload(frame_type, flags, stream_id, payload)
}

#[cfg(test)]
mod tests;