layer_shika_adapters/wayland/surfaces/

app_state.rs

use super::event_context::SharedPointerSerial;
use super::keyboard_state::KeyboardState;
use super::surface_state::SurfaceState;
use crate::errors::{LayerShikaError, RenderingError, Result};
use crate::rendering::egl::context_factory::RenderContextFactory;
use crate::rendering::femtovg::renderable_window::RenderableWindow;
use crate::rendering::slint_integration::platform::CustomSlintPlatform;
use crate::wayland::globals::context::GlobalContext;
use crate::wayland::input::KeyboardInputState;
use crate::wayland::managed_proxies::{ManagedWlKeyboard, ManagedWlPointer};
use crate::wayland::outputs::{OutputManager, OutputMapping};
use crate::wayland::rendering::RenderableSet;
use crate::wayland::session_lock::lock_context::SessionLockContext;
use crate::wayland::session_lock::manager::callbacks::{
    create_lock_callback, create_lock_callback_with_output_filter,
};
use crate::wayland::session_lock::{
    LockCallback, LockPropertyOperation, OutputFilter, SessionLockManager,
};
use layer_shika_domain::entities::output_registry::OutputRegistry;
use layer_shika_domain::value_objects::handle::SurfaceHandle;
use layer_shika_domain::value_objects::lock_config::LockConfig;
use layer_shika_domain::value_objects::lock_state::LockState;
use layer_shika_domain::value_objects::output_handle::OutputHandle;
use layer_shika_domain::value_objects::output_info::OutputInfo;
use slint_interpreter::{CompilationResult, ComponentDefinition, Value};
use std::cell::RefCell;
use std::collections::HashMap;
use std::os::fd::BorrowedFd;
use std::rc::Rc;
use wayland_client::Proxy;
use wayland_client::backend::ObjectId;
use wayland_client::protocol::wl_keyboard;
use wayland_client::protocol::{wl_output::WlOutput, wl_surface::WlSurface};
use xkbcommon::xkb;

pub type PerOutputSurface = SurfaceState;
type SessionLockCallback = Rc<dyn Fn(&[Value]) -> Value>;

#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct ShellSurfaceKey {
    pub output_handle: OutputHandle,
    pub surface_handle: SurfaceHandle,
}

impl ShellSurfaceKey {
    pub const fn new(output_handle: OutputHandle, surface_handle: SurfaceHandle) -> Self {
        Self {
            output_handle,
            surface_handle,
        }
    }
}

pub struct AppState {
    global_context: Option<Rc<GlobalContext>>,
    known_outputs: Vec<WlOutput>,
    slint_platform: Option<Rc<CustomSlintPlatform>>,
    compilation_result: Option<Rc<CompilationResult>>,
    output_registry: OutputRegistry,
    output_mapping: OutputMapping,
    surfaces: HashMap<ShellSurfaceKey, PerOutputSurface>,
    surface_to_key: HashMap<ObjectId, ShellSurfaceKey>,
    surface_handle_to_name: HashMap<SurfaceHandle, String>,
    _pointer: ManagedWlPointer,
    _keyboard: ManagedWlKeyboard,
    shared_pointer_serial: Rc<SharedPointerSerial>,
    output_manager: Option<Rc<RefCell<OutputManager>>>,
    registry_name_to_output_id: HashMap<u32, ObjectId>,
    active_surface_key: Option<ShellSurfaceKey>,
    keyboard_focus_key: Option<ShellSurfaceKey>,
    keyboard_input_state: KeyboardInputState,
    keyboard_state: KeyboardState,
    lock_manager: Option<SessionLockManager>,
    lock_callbacks: Vec<LockCallback>,
    lock_property_operations: Vec<LockPropertyOperation>,
    queue_handle: Option<wayland_client::QueueHandle<AppState>>,
}

impl AppState {
    pub fn new(
        pointer: ManagedWlPointer,
        keyboard: ManagedWlKeyboard,
        shared_serial: Rc<SharedPointerSerial>,
    ) -> Self {
        Self {
            global_context: None,
            known_outputs: Vec::new(),
            slint_platform: None,
            compilation_result: None,
            output_registry: OutputRegistry::new(),
            output_mapping: OutputMapping::new(),
            surfaces: HashMap::new(),
            surface_to_key: HashMap::new(),
            surface_handle_to_name: HashMap::new(),
            _pointer: pointer,
            _keyboard: keyboard,
            shared_pointer_serial: shared_serial,
            output_manager: None,
            registry_name_to_output_id: HashMap::new(),
            active_surface_key: None,
            keyboard_focus_key: None,
            keyboard_input_state: KeyboardInputState::new(),
            keyboard_state: KeyboardState::new(),
            lock_manager: None,
            lock_callbacks: Vec::new(),
            lock_property_operations: Vec::new(),
            queue_handle: None,
        }
    }

    pub fn set_global_context(&mut self, context: Rc<GlobalContext>) {
        self.known_outputs.clone_from(&context.outputs);
        self.global_context = Some(context);
    }

    pub fn set_slint_platform(&mut self, platform: Rc<CustomSlintPlatform>) {
        self.slint_platform = Some(platform);
    }

    pub fn set_compilation_result(&mut self, compilation_result: Rc<CompilationResult>) {
        self.compilation_result = Some(compilation_result);
    }

    pub fn set_queue_handle(&mut self, queue_handle: wayland_client::QueueHandle<AppState>) {
        self.queue_handle = Some(queue_handle);
    }

    pub fn lock_manager(&self) -> Option<&SessionLockManager> {
        self.lock_manager.as_ref()
    }

    pub fn lock_manager_mut(&mut self) -> Option<&mut SessionLockManager> {
        self.lock_manager.as_mut()
    }

    pub fn clear_lock_manager(&mut self) {
        self.lock_manager = None;
    }

    pub fn is_session_lock_available(&self) -> bool {
        self.global_context
            .as_ref()
            .and_then(|ctx| ctx.session_lock_manager.as_ref())
            .is_some()
    }

    pub fn current_lock_state(&self) -> Option<LockState> {
        self.lock_manager.as_ref().map(SessionLockManager::state)
    }

    pub fn register_session_lock_callback(
        &mut self,
        callback_name: impl Into<String>,
        handler: SessionLockCallback,
    ) {
        let callback = create_lock_callback(callback_name, handler);
        if let Some(manager) = self.lock_manager.as_mut() {
            manager.register_callback(callback.clone());
        }
        self.lock_callbacks.push(callback);
    }

    pub fn register_session_lock_callback_with_filter(
        &mut self,
        callback_name: impl Into<String>,
        handler: SessionLockCallback,
        filter: OutputFilter,
    ) {
        let callback = create_lock_callback_with_output_filter(
            callback_name,
            handler,
            move |component_name, output_handle, output_info, primary, active| {
                filter(component_name, output_handle, output_info, primary, active)
            },
        );
        if let Some(manager) = self.lock_manager.as_mut() {
            manager.register_callback(callback.clone());
        }
        self.lock_callbacks.push(callback);
    }

    pub fn register_session_lock_property_operation(
        &mut self,
        property_operation: LockPropertyOperation,
    ) {
        if let Some(manager) = self.lock_manager.as_mut() {
            manager.register_property_operation(property_operation.clone());
        }
        self.lock_property_operations.push(property_operation);
    }

    pub fn activate_session_lock(
        &mut self,
        component_name: &str,
        config: LockConfig,
    ) -> Result<()> {
        if self.lock_manager.is_some() {
            return Err(LayerShikaError::InvalidInput {
                message: "Session lock already active".to_string(),
            });
        }

        let queue_handle =
            self.queue_handle
                .as_ref()
                .ok_or_else(|| LayerShikaError::InvalidInput {
                    message: "Queue handle not initialized".to_string(),
                })?;

        let context = self.create_lock_context()?;
        let (definition, compilation_result) = self.resolve_lock_component(component_name)?;
        let platform =
            self.slint_platform
                .as_ref()
                .ok_or_else(|| LayerShikaError::InvalidInput {
                    message: "Slint platform not initialized".to_string(),
                })?;
        let mut manager = SessionLockManager::new(
            context,
            definition,
            compilation_result,
            Rc::clone(platform),
            config,
        );
        for callback in self.lock_callbacks.iter().cloned() {
            manager.register_callback(callback);
        }
        for property_op in self.lock_property_operations.iter().cloned() {
            manager.register_property_operation(property_op);
        }

        let outputs = self.collect_session_lock_outputs();
        manager.activate(outputs, queue_handle)?;

        self.lock_manager = Some(manager);
        Ok(())
    }

    pub fn deactivate_session_lock(&mut self) -> Result<()> {
        let Some(mut manager) = self.lock_manager.take() else {
            return Err(LayerShikaError::InvalidInput {
                message: "No session lock active".to_string(),
            });
        };

        manager.deactivate()?;
        Ok(())
    }

    pub fn session_lock_component_name(&self) -> Option<String> {
        self.lock_manager
            .as_ref()
            .map(|manager| manager.component_name().name().to_string())
    }

    pub fn iter_lock_surfaces(
        &self,
        f: &mut dyn FnMut(OutputHandle, &slint_interpreter::ComponentInstance),
    ) {
        if let Some(manager) = self.lock_manager.as_ref() {
            manager.iter_lock_surfaces(&mut |output_id, component| {
                if let Some(handle) = self.output_mapping.get(output_id) {
                    f(handle, component);
                }
            });
        }
    }

    pub fn count_lock_surfaces(&self) -> usize {
        self.lock_manager
            .as_ref()
            .map_or(0, SessionLockManager::count_lock_surfaces)
    }

    fn resolve_lock_component(
        &self,
        component_name: &str,
    ) -> Result<(ComponentDefinition, Option<Rc<CompilationResult>>)> {
        let compilation_result = self
            .compilation_result
            .clone()
            .or_else(|| {
                self.primary_output()
                    .and_then(SurfaceState::compilation_result)
            })
            .ok_or_else(|| LayerShikaError::InvalidInput {
                message: "No compilation result available for session lock".to_string(),
            })?;

        let definition = compilation_result
            .component(component_name)
            .ok_or_else(|| LayerShikaError::InvalidInput {
                message: format!("Component '{component_name}' not found in compilation result"),
            })?;

        Ok((definition, Some(compilation_result)))
    }

    fn create_lock_context(&self) -> Result<Rc<SessionLockContext>> {
        let Some(global_ctx) = self.global_context.as_ref() else {
            return Err(LayerShikaError::InvalidInput {
                message: "Global context not available for session lock".to_string(),
            });
        };

        let Some(lock_manager) = global_ctx.session_lock_manager.as_ref() else {
            return Err(LayerShikaError::InvalidInput {
                message: "Session lock protocol not available".to_string(),
            });
        };

        let render_factory =
            RenderContextFactory::new(Rc::clone(&global_ctx.render_context_manager));

        Ok(Rc::new(SessionLockContext::new(
            global_ctx.compositor.clone(),
            lock_manager.clone(),
            global_ctx.seat.clone(),
            global_ctx.fractional_scale_manager.clone(),
            global_ctx.viewporter.clone(),
            render_factory,
        )))
    }

    fn collect_session_lock_outputs(&self) -> Vec<WlOutput> {
        self.known_outputs.clone()
    }

    pub fn handle_output_added_for_lock(
        &mut self,
        output: &WlOutput,
        queue_handle: &wayland_client::QueueHandle<AppState>,
    ) -> Result<()> {
        if !self
            .known_outputs
            .iter()
            .any(|known| known.id() == output.id())
        {
            self.known_outputs.push(output.clone());
        }

        let Some(manager) = self.lock_manager.as_mut() else {
            return Ok(());
        };

        if manager.state() == LockState::Locked {
            manager.add_output(output, queue_handle)?;
        }

        Ok(())
    }

    pub fn handle_output_removed_for_lock(&mut self, output_id: &ObjectId) {
        self.known_outputs
            .retain(|output| output.id() != *output_id);
        if let Some(manager) = self.lock_manager.as_mut() {
            manager.remove_output(output_id);
        }
    }

    pub fn set_output_manager(&mut self, manager: Rc<RefCell<OutputManager>>) {
        self.output_manager = Some(manager);
    }

    pub fn output_manager(&self) -> Option<Rc<RefCell<OutputManager>>> {
        self.output_manager.as_ref().map(Rc::clone)
    }

    pub fn register_registry_name(&mut self, name: u32, output_id: ObjectId) {
        self.registry_name_to_output_id.insert(name, output_id);
    }

    pub fn find_output_id_by_registry_name(&self, name: u32) -> Option<ObjectId> {
        self.registry_name_to_output_id.get(&name).cloned()
    }

    pub fn unregister_registry_name(&mut self, name: u32) -> Option<ObjectId> {
        self.registry_name_to_output_id.remove(&name)
    }

    pub fn add_shell_surface(
        &mut self,
        output_id: &ObjectId,
        surface_handle: SurfaceHandle,
        surface_name: &str,
        main_surface_id: ObjectId,
        surface_state: PerOutputSurface,
    ) {
        let handle = self.output_mapping.get(output_id).unwrap_or_else(|| {
            let h = self.output_mapping.insert(output_id.clone());
            let is_primary = self.output_registry.is_empty();
            let mut info = OutputInfo::new(h);
            info.set_primary(is_primary);
            self.output_registry.add(info);
            h
        });

        let key = ShellSurfaceKey::new(handle, surface_handle);
        self.surface_to_key.insert(main_surface_id, key.clone());
        self.surfaces.insert(key, surface_state);
        self.surface_handle_to_name
            .insert(surface_handle, surface_name.to_string());
    }

    pub fn add_output(
        &mut self,
        output_id: &ObjectId,
        surface_handle: SurfaceHandle,
        surface_name: &str,
        main_surface_id: ObjectId,
        surface_state: PerOutputSurface,
    ) {
        self.add_shell_surface(
            output_id,
            surface_handle,
            surface_name,
            main_surface_id,
            surface_state,
        );
    }

    pub fn remove_output(&mut self, handle: OutputHandle) -> Vec<PerOutputSurface> {
        self.output_registry.remove(handle);

        let keys_to_remove: Vec<_> = self
            .surfaces
            .keys()
            .filter(|k| k.output_handle == handle)
            .cloned()
            .collect();

        let mut removed = Vec::new();
        for key in keys_to_remove {
            if let Some(surface) = self.surfaces.remove(&key) {
                removed.push(surface);
            }
        }

        self.surface_to_key.retain(|_, k| k.output_handle != handle);

        removed
    }

    pub fn get_surface_by_key(&self, key: &ShellSurfaceKey) -> Option<&PerOutputSurface> {
        self.surfaces.get(key)
    }

    pub fn get_surface_by_key_mut(
        &mut self,
        key: &ShellSurfaceKey,
    ) -> Option<&mut PerOutputSurface> {
        self.surfaces.get_mut(key)
    }

    pub fn get_surface_by_instance(
        &self,
        surface_handle: SurfaceHandle,
        output_handle: OutputHandle,
    ) -> Option<&PerOutputSurface> {
        let key = ShellSurfaceKey::new(output_handle, surface_handle);
        self.surfaces.get(&key)
    }

    pub fn get_surface_by_instance_mut(
        &mut self,
        surface_handle: SurfaceHandle,
        output_handle: OutputHandle,
    ) -> Option<&mut PerOutputSurface> {
        let key = ShellSurfaceKey::new(output_handle, surface_handle);
        self.surfaces.get_mut(&key)
    }

    pub fn get_output_by_output_id(&self, output_id: &ObjectId) -> Option<&PerOutputSurface> {
        self.output_mapping
            .get(output_id)
            .and_then(|handle| self.get_first_surface_for_output(handle))
    }

    pub fn get_output_by_output_id_mut(
        &mut self,
        output_id: &ObjectId,
    ) -> Option<&mut PerOutputSurface> {
        self.output_mapping
            .get(output_id)
            .and_then(|handle| self.get_first_surface_for_output_mut(handle))
    }

    fn get_first_surface_for_output(&self, handle: OutputHandle) -> Option<&PerOutputSurface> {
        self.surfaces
            .iter()
            .find(|(k, _)| k.output_handle == handle)
            .map(|(_, v)| v)
    }

    fn get_first_surface_for_output_mut(
        &mut self,
        handle: OutputHandle,
    ) -> Option<&mut PerOutputSurface> {
        self.surfaces
            .iter_mut()
            .find(|(k, _)| k.output_handle == handle)
            .map(|(_, v)| v)
    }

    pub fn get_output_by_surface(&self, surface_id: &ObjectId) -> Option<&PerOutputSurface> {
        self.surface_to_key
            .get(surface_id)
            .and_then(|key| self.surfaces.get(key))
    }

    pub fn get_output_by_surface_mut(
        &mut self,
        surface_id: &ObjectId,
    ) -> Option<&mut PerOutputSurface> {
        self.surface_to_key
            .get(surface_id)
            .and_then(|key| self.surfaces.get_mut(key))
    }

    pub fn get_output_by_layer_surface_mut(
        &mut self,
        layer_surface_id: &ObjectId,
    ) -> Option<&mut PerOutputSurface> {
        self.surfaces
            .values_mut()
            .find(|surface| surface.layer_surface().as_ref().id() == *layer_surface_id)
    }

    pub fn get_surface_name(&self, surface_handle: SurfaceHandle) -> Option<&str> {
        self.surface_handle_to_name
            .get(&surface_handle)
            .map(String::as_str)
    }

    pub fn get_key_by_surface(&self, surface_id: &ObjectId) -> Option<&ShellSurfaceKey> {
        self.surface_to_key.get(surface_id)
    }

    pub fn get_handle_by_surface(&self, surface_id: &ObjectId) -> Option<OutputHandle> {
        self.surface_to_key
            .get(surface_id)
            .map(|key| key.output_handle)
    }

    pub fn get_handle_by_output_id(&self, output_id: &ObjectId) -> Option<OutputHandle> {
        self.output_mapping.get(output_id)
    }

    pub fn ensure_output_registered(&mut self, output_id: &ObjectId) -> OutputHandle {
        self.output_mapping.get(output_id).unwrap_or_else(|| {
            let h = self.output_mapping.insert(output_id.clone());
            let is_primary = self.output_registry.is_empty();
            let mut info = OutputInfo::new(h);
            info.set_primary(is_primary);
            self.output_registry.add(info);
            h
        })
    }

    pub fn set_active_output_handle(&mut self, handle: Option<OutputHandle>) {
        self.output_registry.set_active(handle);
    }

    pub fn active_output_handle(&self) -> Option<OutputHandle> {
        self.output_registry.active_handle()
    }

    pub fn set_active_surface_key(&mut self, key: Option<ShellSurfaceKey>) {
        if let Some(ref k) = key {
            self.output_registry.set_active(Some(k.output_handle));
        } else {
            self.output_registry.set_active(None);
        }
        self.active_surface_key = key;
    }

    pub fn active_surface_key(&self) -> Option<&ShellSurfaceKey> {
        self.active_surface_key.as_ref()
    }

    pub fn active_surface_mut(&mut self) -> Option<&mut PerOutputSurface> {
        let key = self.active_surface_key.clone()?;
        self.surfaces.get_mut(&key)
    }

    pub fn primary_output(&self) -> Option<&PerOutputSurface> {
        self.output_registry
            .primary_handle()
            .and_then(|handle| self.get_first_surface_for_output(handle))
    }

    pub fn primary_output_handle(&self) -> Option<OutputHandle> {
        self.output_registry.primary_handle()
    }

    pub fn active_output(&self) -> Option<&PerOutputSurface> {
        self.output_registry
            .active_handle()
            .and_then(|handle| self.get_first_surface_for_output(handle))
    }

    pub fn all_outputs(&self) -> impl Iterator<Item = &PerOutputSurface> {
        self.surfaces.values()
    }

    pub fn all_outputs_mut(&mut self) -> impl Iterator<Item = &mut PerOutputSurface> {
        self.surfaces.values_mut()
    }

    pub fn surfaces_for_output(
        &self,
        handle: OutputHandle,
    ) -> impl Iterator<Item = (&str, &PerOutputSurface)> + '_ {
        self.surfaces
            .iter()
            .filter(move |(k, _)| k.output_handle == handle)
            .map(|(k, v)| {
                let name = self
                    .surface_handle_to_name
                    .get(&k.surface_handle)
                    .map_or("unknown", String::as_str);
                (name, v)
            })
    }

    pub fn surfaces_with_keys(
        &self,
    ) -> impl Iterator<Item = (&ShellSurfaceKey, &PerOutputSurface)> {
        self.surfaces.iter()
    }

    pub const fn shared_pointer_serial(&self) -> &Rc<SharedPointerSerial> {
        &self.shared_pointer_serial
    }

    pub fn handle_keymap(&mut self, fd: BorrowedFd<'_>, size: u32) {
        let Ok(fd) = fd.try_clone_to_owned() else {
            return;
        };

        let keymap = unsafe {
            xkb::Keymap::new_from_fd(
                &self.keyboard_state.xkb_context,
                fd,
                size as usize,
                xkb::KEYMAP_FORMAT_TEXT_V1,
                xkb::KEYMAP_COMPILE_NO_FLAGS,
            )
        };

        if let Ok(Some(keymap)) = keymap {
            self.keyboard_state.set_keymap(keymap);
        }
    }

    pub fn handle_keyboard_enter(&mut self, _serial: u32, surface: &WlSurface, _keys: &[u8]) {
        if let Some(manager) = self.lock_manager.as_mut() {
            if manager.handle_keyboard_enter(surface) {
                self.set_keyboard_focus(None);
                return;
            }
        }

        let surface_id = surface.id();
        if let Some(key) = self.get_key_by_surface(&surface_id).cloned() {
            self.keyboard_input_state
                .set_focused_surface(Some(surface_id.clone()));
            self.set_keyboard_focus(Some(key));
            return;
        }

        if let Some(key) = self.get_key_by_popup(&surface_id).cloned() {
            self.keyboard_input_state
                .set_focused_surface(Some(surface_id));
            self.set_keyboard_focus(Some(key));
        }
    }

    pub fn handle_keyboard_leave(&mut self, _serial: u32, surface: &WlSurface) {
        if let Some(manager) = self.lock_manager.as_mut() {
            if manager.handle_keyboard_leave(surface) {
                return;
            }
        }

        let surface_id = surface.id();
        if self.keyboard_input_state.focused_surface_id() == Some(&surface_id) {
            self.keyboard_input_state.reset();
            self.set_keyboard_focus(None);
        }
    }

    pub fn handle_key(&mut self, _serial: u32, _time: u32, key: u32, state: wl_keyboard::KeyState) {
        if let Some(manager) = self.lock_manager.as_mut() {
            if manager.handle_keyboard_key(key, state, &mut self.keyboard_state) {
                return;
            }
        }

        let Some(focus_key) = self.keyboard_focus_key.clone() else {
            return;
        };
        let Some(surface_id) = self.keyboard_input_state.focused_surface_id().cloned() else {
            return;
        };

        if let Some(surface) = self.surfaces.get_mut(&focus_key) {
            surface.handle_keyboard_key(&surface_id, key, state, &mut self.keyboard_state);
        }
    }

    pub fn handle_modifiers(
        &mut self,
        _serial: u32,
        mods_depressed: u32,
        mods_latched: u32,
        mods_locked: u32,
        group: u32,
    ) {
        if let Some(state) = self.keyboard_state.xkb_state.as_mut() {
            state.update_mask(mods_depressed, mods_latched, mods_locked, 0, 0, group);
        }
    }

    pub fn handle_repeat_info(&mut self, rate: i32, delay: i32) {
        self.keyboard_state.repeat_rate = rate;
        self.keyboard_state.repeat_delay = delay;
    }

    fn set_keyboard_focus(&mut self, key: Option<ShellSurfaceKey>) {
        if let Some(ref k) = key {
            self.output_registry.set_active(Some(k.output_handle));
        }
        self.keyboard_focus_key = key;
    }

    pub fn find_output_by_popup(&self, popup_surface_id: &ObjectId) -> Option<&PerOutputSurface> {
        self.surfaces.values().find(|surface| {
            surface
                .popup_manager()
                .as_ref()
                .and_then(|pm| pm.find_by_surface(popup_surface_id))
                .is_some()
        })
    }

    pub fn find_output_by_popup_mut(
        &mut self,
        popup_surface_id: &ObjectId,
    ) -> Option<&mut PerOutputSurface> {
        self.surfaces.values_mut().find(|surface| {
            surface
                .popup_manager()
                .as_ref()
                .and_then(|pm| pm.find_by_surface(popup_surface_id))
                .is_some()
        })
    }

    pub fn get_key_by_popup(&self, popup_surface_id: &ObjectId) -> Option<&ShellSurfaceKey> {
        self.surfaces.iter().find_map(|(key, surface)| {
            surface
                .popup_manager()
                .as_ref()
                .and_then(|pm| pm.find_by_surface(popup_surface_id))
                .map(|_| key)
        })
    }

    pub fn get_handle_by_popup(&self, popup_surface_id: &ObjectId) -> Option<OutputHandle> {
        self.get_key_by_popup(popup_surface_id)
            .map(|key| key.output_handle)
    }

    pub fn get_output_by_handle_mut(
        &mut self,
        handle: OutputHandle,
    ) -> Option<&mut PerOutputSurface> {
        self.get_first_surface_for_output_mut(handle)
    }

    pub fn get_output_info(&self, handle: OutputHandle) -> Option<&OutputInfo> {
        self.output_registry.get(handle)
    }

    pub fn get_output_info_mut(&mut self, handle: OutputHandle) -> Option<&mut OutputInfo> {
        self.output_registry.get_mut(handle)
    }

    pub fn all_output_info(&self) -> impl Iterator<Item = &OutputInfo> {
        self.output_registry.all_info()
    }

    pub const fn output_registry(&self) -> &OutputRegistry {
        &self.output_registry
    }

    pub fn shell_surface_names(&self) -> Vec<&str> {
        let mut names: Vec<_> = self
            .surface_handle_to_name
            .values()
            .map(String::as_str)
            .collect();
        names.sort_unstable();
        names.dedup();
        names
    }

    pub fn surfaces_by_name(&self, surface_name: &str) -> Vec<&PerOutputSurface> {
        let matching_handles: Vec<SurfaceHandle> = self
            .surface_handle_to_name
            .iter()
            .filter(|(_, n)| n.as_str() == surface_name)
            .map(|(h, _)| *h)
            .collect();

        self.surfaces
            .iter()
            .filter(|(k, _)| matching_handles.contains(&k.surface_handle))
            .map(|(_, v)| v)
            .collect()
    }

    pub fn surfaces_by_name_mut(&mut self, surface_name: &str) -> Vec<&mut PerOutputSurface> {
        let matching_handles: Vec<SurfaceHandle> = self
            .surface_handle_to_name
            .iter()
            .filter(|(_, n)| n.as_str() == surface_name)
            .map(|(h, _)| *h)
            .collect();

        self.surfaces
            .iter_mut()
            .filter(|(k, _)| matching_handles.contains(&k.surface_handle))
            .map(|(_, v)| v)
            .collect()
    }

    pub fn surfaces_by_handle(&self, handle: SurfaceHandle) -> Vec<&PerOutputSurface> {
        self.surfaces
            .iter()
            .filter(|(k, _)| k.surface_handle == handle)
            .map(|(_, v)| v)
            .collect()
    }

    pub fn surfaces_by_handle_mut(&mut self, handle: SurfaceHandle) -> Vec<&mut PerOutputSurface> {
        self.surfaces
            .iter_mut()
            .filter(|(k, _)| k.surface_handle == handle)
            .map(|(_, v)| v)
            .collect()
    }

    pub fn surfaces_by_name_and_output(
        &self,
        name: &str,
        output: OutputHandle,
    ) -> Vec<&PerOutputSurface> {
        let matching_handles: Vec<SurfaceHandle> = self
            .surface_handle_to_name
            .iter()
            .filter(|(_, n)| n.as_str() == name)
            .map(|(h, _)| *h)
            .collect();

        self.surfaces
            .iter()
            .filter(|(k, _)| {
                k.output_handle == output && matching_handles.contains(&k.surface_handle)
            })
            .map(|(_, v)| v)
            .collect()
    }

    pub fn surfaces_by_name_and_output_mut(
        &mut self,
        name: &str,
        output: OutputHandle,
    ) -> Vec<&mut PerOutputSurface> {
        let matching_handles: Vec<SurfaceHandle> = self
            .surface_handle_to_name
            .iter()
            .filter(|(_, n)| n.as_str() == name)
            .map(|(h, _)| *h)
            .collect();

        self.surfaces
            .iter_mut()
            .filter(|(k, _)| {
                k.output_handle == output && matching_handles.contains(&k.surface_handle)
            })
            .map(|(_, v)| v)
            .collect()
    }

    pub fn get_output_by_handle(&self, handle: OutputHandle) -> Option<&PerOutputSurface> {
        self.get_first_surface_for_output(handle)
    }

    pub fn outputs_with_handles(&self) -> impl Iterator<Item = (OutputHandle, &PerOutputSurface)> {
        self.surfaces
            .iter()
            .map(|(key, surface)| (key.output_handle, surface))
    }

    pub fn outputs_with_info(&self) -> impl Iterator<Item = (&OutputInfo, &PerOutputSurface)> {
        self.output_registry.all_info().filter_map(|info| {
            let handle = info.handle();
            self.get_first_surface_for_output(handle)
                .map(|surface| (info, surface))
        })
    }

    pub fn all_surfaces_for_output_mut(
        &mut self,
        output_id: &ObjectId,
    ) -> Vec<&mut PerOutputSurface> {
        let Some(handle) = self.output_mapping.get(output_id) else {
            return Vec::new();
        };

        self.surfaces
            .iter_mut()
            .filter(|(k, _)| k.output_handle == handle)
            .map(|(_, v)| v)
            .collect()
    }

    pub fn remove_surfaces_by_name(&mut self, surface_name: &str) -> Vec<PerOutputSurface> {
        let matching_handles: Vec<SurfaceHandle> = self
            .surface_handle_to_name
            .iter()
            .filter(|(_, n)| n.as_str() == surface_name)
            .map(|(h, _)| *h)
            .collect();

        let keys_to_remove: Vec<_> = self
            .surfaces
            .keys()
            .filter(|k| matching_handles.contains(&k.surface_handle))
            .cloned()
            .collect();

        let mut removed = Vec::new();
        for key in keys_to_remove {
            if let Some(surface) = self.surfaces.remove(&key) {
                removed.push(surface);
            }
        }

        self.surface_to_key
            .retain(|_, k| !matching_handles.contains(&k.surface_handle));

        removed
    }
}

impl RenderableSet for AppState {
    fn render_all_dirty(&self) -> Result<()> {
        for surface in self.all_outputs() {
            surface
                .window()
                .render_frame_if_dirty()
                .map_err(|e| RenderingError::Operation {
                    message: e.to_string(),
                })?;
        }
        Ok(())
    }
}