Skip to main content

kcl_lib/execution/
fn_call.rs

1use async_recursion::async_recursion;
2use indexmap::IndexMap;
3use kcl_api::Group;
4use kcl_api::OpArg;
5
6use crate::CompilationIssue;
7use crate::NodePath;
8use crate::NodePathExt;
9use crate::SourceRange;
10use crate::errors::KclError;
11use crate::errors::KclErrorDetails;
12use crate::execution::BodyType;
13use crate::execution::ExecState;
14use crate::execution::ExecutorContext;
15use crate::execution::Geometry;
16use crate::execution::KclValue;
17use crate::execution::KclValueControlFlow;
18use crate::execution::Metadata;
19use crate::execution::Solid;
20use crate::execution::StatementKind;
21use crate::execution::TagEngineInfo;
22use crate::execution::TagIdentifier;
23use crate::execution::annotations;
24use crate::execution::cad_op::Operation;
25use crate::execution::cad_op::op_from_kcl_value;
26use crate::execution::control_continue;
27use crate::execution::kcl_value::FunctionBody;
28use crate::execution::kcl_value::FunctionSource;
29use crate::execution::kcl_value::NamedParam;
30use crate::execution::kcl_value::ParamUnavailable;
31use crate::execution::memory;
32use crate::execution::types::CoercionMode;
33use crate::execution::types::RuntimeType;
34use crate::parsing::ast::types::CallExpressionKw;
35use crate::parsing::ast::types::Node;
36use crate::parsing::ast::types::Type;
37use crate::std::ConsumedSolidArgCheck;
38use crate::std::RegionBehavior;
39use crate::std::StaleRegionPolicy;
40use crate::std::region_consumption::PendingRegionConsumption;
41use crate::std::region_consumption::prepare_region_consumption;
42use crate::std::region_consumption::record_consumed_regions;
43use crate::std::region_consumption::validate_region_args_not_consumed;
44use crate::std::region_consumption::warn_if_region_args_consumed;
45use crate::std::solid_consumption::validate_value_not_consumed;
46use crate::std::solid_consumption::warn_if_value_consumed_for_deprecated_call;
47
48#[derive(Debug, Clone)]
49pub struct Args<Status: ArgsStatus = Desugared> {
50    /// Name of the function these args are being passed into.
51    pub fn_name: Option<String>,
52    /// Unlabeled keyword args. Currently only the first formal arg can be unlabeled.
53    /// If the argument was a local variable, then the first element of the tuple is its name
54    /// which may be used to treat this arg as a labelled arg.
55    pub unlabeled: Vec<(Option<String>, Arg)>,
56    /// Labeled args.
57    pub labeled: IndexMap<String, Arg>,
58    pub source_range: SourceRange,
59    pub node_path: Option<NodePath>,
60    pub ctx: ExecutorContext,
61    /// If this call happens inside a pipe (|>) expression, this holds the LHS of that |>.
62    /// Otherwise it's None.
63    pub pipe_value: Option<Arg>,
64    _status: std::marker::PhantomData<Status>,
65}
66
67pub trait ArgsStatus: std::fmt::Debug + Clone {}
68
69#[derive(Debug, Clone)]
70pub struct Sugary;
71impl ArgsStatus for Sugary {}
72
73// Invariants guaranteed by the `Desugared` status:
74// - There is either 0 or 1 unlabeled arguments
75// - Any lableled args are in the labeled map, and not the unlabeled Vec.
76// - The arguments match the type signature of the function exactly
77// - pipe_value.is_none()
78#[derive(Debug, Clone)]
79pub struct Desugared;
80impl ArgsStatus for Desugared {}
81
82impl Args<Sugary> {
83    /// Collect the given keyword arguments.
84    pub fn new(
85        labeled: IndexMap<String, Arg>,
86        unlabeled: Vec<(Option<String>, Arg)>,
87        source_range: SourceRange,
88        node_path: Option<NodePath>,
89        exec_state: &mut ExecState,
90        ctx: ExecutorContext,
91        fn_name: Option<String>,
92    ) -> Args<Sugary> {
93        Args {
94            fn_name,
95            labeled,
96            unlabeled,
97            source_range,
98            node_path,
99            ctx,
100            pipe_value: exec_state.pipe_value().map(|v| Arg::new(v.clone(), source_range)),
101            _status: std::marker::PhantomData,
102        }
103    }
104}
105
106impl<Status: ArgsStatus> Args<Status> {
107    /// How many arguments are there?
108    pub fn len(&self) -> usize {
109        self.labeled.len() + self.unlabeled.len()
110    }
111
112    /// Are there no arguments?
113    pub fn is_empty(&self) -> bool {
114        self.labeled.is_empty() && self.unlabeled.is_empty()
115    }
116}
117
118impl Args<Desugared> {
119    pub fn new_no_args(
120        source_range: SourceRange,
121        node_path: Option<NodePath>,
122        ctx: ExecutorContext,
123        fn_name: Option<String>,
124    ) -> Args {
125        Args {
126            fn_name,
127            unlabeled: Default::default(),
128            labeled: Default::default(),
129            source_range,
130            node_path,
131            ctx,
132            pipe_value: None,
133            _status: std::marker::PhantomData,
134        }
135    }
136
137    /// Get the unlabeled keyword argument. If not set, returns None.
138    pub(crate) fn unlabeled_kw_arg_unconverted(&self) -> Option<&Arg> {
139        self.unlabeled.first().map(|(_, a)| a)
140    }
141}
142
143#[derive(Debug, Clone)]
144pub struct Arg {
145    /// The evaluated argument.
146    pub value: KclValue,
147    /// The source range of the unevaluated argument.
148    pub source_range: SourceRange,
149}
150
151impl Arg {
152    pub fn new(value: KclValue, source_range: SourceRange) -> Self {
153        Self { value, source_range }
154    }
155
156    pub fn synthetic(value: KclValue) -> Self {
157        Self {
158            value,
159            source_range: SourceRange::synthetic(),
160        }
161    }
162
163    pub fn source_ranges(&self) -> Vec<SourceRange> {
164        vec![self.source_range]
165    }
166}
167
168impl Node<CallExpressionKw> {
169    #[async_recursion]
170    pub(super) async fn execute(
171        &self,
172        exec_state: &mut ExecState,
173        ctx: &ExecutorContext,
174    ) -> Result<KclValueControlFlow, KclError> {
175        let fn_name = &self.callee;
176        let callsite: SourceRange = self.into();
177
178        // Resolve the function before evaluating arguments so calls can mutate
179        // exec_state without holding a memory borrow.
180        let func: KclValue = fn_name.get_result(exec_state, ctx).await?;
181
182        let Some(fn_src) = func.as_function() else {
183            return Err(KclError::new_semantic(KclErrorDetails::new(
184                "cannot call this because it isn't a function".to_string(),
185                vec![callsite],
186            )));
187        };
188
189        // Build a hashmap from argument labels to the final evaluated values.
190        let mut fn_args = IndexMap::with_capacity(self.arguments.len());
191        let mut unlabeled = Vec::new();
192
193        // Evaluate the unlabeled first param, if any exists.
194        if let Some(ref arg_expr) = self.unlabeled {
195            let source_range = SourceRange::from(arg_expr.clone());
196            let metadata = Metadata { source_range };
197            let value_cf = ctx
198                .execute_expr(arg_expr, exec_state, &metadata, &[], StatementKind::Expression)
199                .await?;
200            let value = control_continue!(value_cf);
201
202            let label = arg_expr.ident_name().map(str::to_owned);
203
204            unlabeled.push((label, Arg::new(value, source_range)))
205        }
206
207        for arg_expr in &self.arguments {
208            let source_range = SourceRange::from(arg_expr.arg.clone());
209            let metadata = Metadata { source_range };
210            let value_cf = ctx
211                .execute_expr(&arg_expr.arg, exec_state, &metadata, &[], StatementKind::Expression)
212                .await?;
213            let value = control_continue!(value_cf);
214            let arg = Arg::new(value, source_range);
215            match &arg_expr.label {
216                Some(l) => {
217                    fn_args.insert(l.name.clone(), arg);
218                }
219                None => {
220                    unlabeled.push((arg_expr.arg.ident_name().map(str::to_owned), arg));
221                }
222            }
223        }
224
225        let args = Args::new(
226            fn_args,
227            unlabeled,
228            callsite,
229            self.node_path.clone(),
230            exec_state,
231            ctx.clone(),
232            Some(fn_name.name.name.clone()),
233        );
234
235        let return_value = fn_src
236            .call_kw(Some(fn_name.to_string()), exec_state, ctx, args, callsite)
237            .await
238            .map_err(|e| {
239                // Add the call expression to the source ranges.
240                //
241                // TODO: Use the name that the function was defined
242                // with, not the identifier it was used with.
243                e.add_unwind_location(Some(fn_name.to_string()), callsite)
244            })?;
245
246        let result = return_value.ok_or_else(move || {
247            let mut source_ranges: Vec<SourceRange> = vec![callsite];
248            // We want to send the source range of the original function.
249            if let KclValue::Function { meta, .. } = func {
250                source_ranges = meta.iter().map(|m| m.source_range).collect();
251            };
252            KclError::new_undefined_value(
253                KclErrorDetails::new(
254                    format!("Result of user-defined function {fn_name} is undefined"),
255                    source_ranges,
256                ),
257                None,
258            )
259        })?;
260
261        Ok(result)
262    }
263}
264
265/// Guidance included in deprecation warnings for sketch v1 stdlib functions.
266/// The warning must stand on its own: a human or AI agent reading it should
267/// learn what replaces the function and where to find conversion examples
268/// without any other context.
269const SKETCH_V1_MIGRATION_HELP: &str = "It is part of the legacy sketch API (sketch v1), which is replaced by the sketch-solve API.
270
271See https://zoo.dev/docs/kcl-book/sketch2d_constraints.html for an introduction to sketch-solve with examples.
272
273Draw profiles inside a `sketch(on = XY) { ... }` block using segment functions with absolute points, e.g. `line(start = [0, 0], end = [4, 3])`, optionally marking values as adjustable with `var` and constraining them with constraint functions like `coincident()` or `horizontal()`. ";
274
275/// Migration guidance for a deprecated stdlib function, when it has a
276/// dedicated replacement story beyond its docs page.
277fn migration_help(fn_src: &FunctionSource) -> Option<&'static str> {
278    let name = &fn_src.std_props.as_ref()?.name;
279    // Every deprecated function in std::sketch is part of sketch v1, which
280    // sketch-solve replaces in KCL 2.0.
281    name.starts_with("std::sketch::").then_some(SKETCH_V1_MIGRATION_HELP)
282}
283
284impl FunctionSource {
285    pub(crate) async fn call_kw(
286        &self,
287        fn_name: Option<String>,
288        exec_state: &mut ExecState,
289        ctx: &ExecutorContext,
290        args: Args<Sugary>,
291        callsite: SourceRange,
292    ) -> Result<Option<KclValueControlFlow>, KclError> {
293        exec_state.inc_call_stack_size(callsite)?;
294
295        let result = self.inner_call_kw(fn_name, exec_state, ctx, args, callsite).await;
296
297        exec_state.dec_call_stack_size(callsite)?;
298        result
299    }
300
301    async fn inner_call_kw(
302        &self,
303        fn_name: Option<String>,
304        exec_state: &mut ExecState,
305        ctx: &ExecutorContext,
306        args: Args<Sugary>,
307        callsite: SourceRange,
308    ) -> Result<Option<KclValueControlFlow>, KclError> {
309        let (state, args) = self.call_setup(&fn_name, exec_state, args, callsite)?;
310        // Do not early return via ? or something until we've called
311        // call_finish (or call_abort_on_arg_binding_failure), so that the
312        // ambient flags are restored and the callee env is popped.
313        let result = match &self.body {
314            FunctionBody::Rust(f) => f(exec_state, args).await.map(Some),
315            FunctionBody::Kcl(_) => {
316                if let Err(e) = assign_args_to_params_kw(self, args, exec_state) {
317                    return Err(Self::call_abort_on_arg_binding_failure(state, e, exec_state));
318                }
319
320                let block_result = ctx.exec_block(&self.ast.body, exec_state, BodyType::Block).await;
321                self.kcl_body_result(block_result, exec_state)
322            }
323        };
324        self.call_finish(state, result, exec_state)
325    }
326
327    /// The first half of a function call: warnings, argument type checking,
328    /// operation setup, pushing the callee environment, and stdlib
329    /// ambient-flag tracking. After this succeeds, the callee environment is
330    /// pushed and the ambient flags are set, so every path must reach
331    /// [`Self::call_finish`] (or [`Self::call_abort_on_arg_binding_failure`])
332    /// to balance them. The recursive executor keeps the returned [`CallState`]
333    /// across the body await; the machine executor parks it in a call-boundary
334    /// continuation.
335    pub(super) fn call_setup(
336        &self,
337        fn_name: &Option<String>,
338        exec_state: &mut ExecState,
339        args: Args<Sugary>,
340        callsite: SourceRange,
341    ) -> Result<(CallState, Args), KclError> {
342        // The KCL stdlib is allowed to use deprecated sketch1 functions inside.
343        let warn_on_deprecated_usage = !exec_state.mod_local.inside_stdlib;
344        if warn_on_deprecated_usage {
345            let subject = match &fn_name {
346                Some(n) => format!("`{n}`"),
347                None => "This function".to_owned(),
348            };
349            let message = if self.deprecated {
350                Some(match migration_help(self) {
351                    Some(help) => format!("{subject} is deprecated. {help}"),
352                    None => format!("{subject} is deprecated, see the docs for a recommended replacement"),
353                })
354            } else if let Some(since) = &self.deprecated_since
355                && annotations::version_ge(exec_state.deprecation_version(), since)
356            {
357                Some(match migration_help(self) {
358                    Some(help) => format!("{subject} is deprecated as of KCL {since}. {help}"),
359                    None => {
360                        format!(
361                            "{subject} is deprecated as of KCL {since}. See the docs for a recommended replacement."
362                        )
363                    }
364                })
365            } else {
366                None
367            };
368            if let Some(message) = message {
369                let mut issue = CompilationIssue::err(callsite, message);
370                issue.tag = crate::errors::Tag::Deprecated;
371                exec_state.warn(issue, annotations::WARN_DEPRECATED);
372            }
373        }
374        if self.experimental {
375            exec_state.warn_experimental(
376                &match &fn_name {
377                    Some(n) => format!("`{n}`"),
378                    None => "This function".to_owned(),
379                },
380                callsite,
381            );
382        }
383
384        let args = type_check_params_kw(fn_name.as_deref(), self, args, exec_state)?;
385        let face_tag_names = face_tag_names_for_call(self, &args);
386        let pending_region_consumption = prepare_region_consumption(
387            self.std_props
388                .as_ref()
389                .map_or(RegionBehavior::WarnOnConsumed, |props| props.region_behavior),
390            &args,
391            exec_state,
392        )?;
393
394        // Warn if experimental or deprecated arguments are used after desugaring.
395        for (label, arg) in &args.labeled {
396            let Some(param) = self.named_args.get(label.as_str()) else {
397                continue;
398            };
399            if param.experimental {
400                exec_state.warn_experimental(
401                    &match &fn_name {
402                        Some(f) => format!("`{f}({label})`"),
403                        None => label.to_owned(),
404                    },
405                    arg.source_range,
406                );
407            }
408            // `deprecated` deprecates the parameter for all versions, whereas
409            // `deprecated_since` only deprecates it at or after a given version.
410            let deprecation_suffix = if !warn_on_deprecated_usage {
411                None
412            } else if param.deprecated {
413                Some("is deprecated, see the docs for a recommended replacement".to_owned())
414            } else if let Some(since) = &param.deprecated_since
415                && annotations::version_ge(exec_state.deprecation_version(), since)
416            {
417                Some(format!(
418                    "is deprecated as of KCL {since}. See the docs for a recommended replacement."
419                ))
420            } else {
421                None
422            };
423            if let Some(suffix) = deprecation_suffix {
424                let qualified = match &fn_name {
425                    Some(f) => format!("`{f}({label})`"),
426                    None => format!("`{label}`"),
427                };
428                let mut issue = CompilationIssue::err(arg.source_range, format!("{qualified} {suffix}"));
429                issue.tag = crate::errors::Tag::Deprecated;
430                exec_state.warn(issue, annotations::WARN_DEPRECATED);
431            }
432        }
433
434        // Don't early return until the stack frame is popped!
435        self.body.prep_mem(exec_state)?;
436
437        // Some function calls might get added to the feature tree.
438        // We do this by adding an "operation".
439
440        // Don't add operations if the KCL code being executed is
441        // just the KCL stdlib calling other KCL stdlib,
442        // because the stdlib internals aren't relevant to users,
443        // that would just be pointless noise.
444        //
445        // Do add operations if the KCL being executed is
446        // user-defined, or the calling code is user-defined,
447        // because that's relevant to the user.
448        let would_trace_stdlib_internals = exec_state.mod_local.inside_stdlib && self.is_std();
449        // self.include_in_feature_tree is set by the KCL annotation `@(feature_tree = true)`.
450        let should_track_operation = !would_trace_stdlib_internals && self.include_in_feature_tree;
451        let op = if should_track_operation {
452            let op_labeled_args = args
453                .labeled
454                .iter()
455                .map(|(k, arg)| (k.clone(), OpArg::new(op_from_kcl_value(&arg.value), arg.source_range)))
456                .collect();
457
458            // If you're calling a stdlib function, track that call as an operation.
459            if self.is_std() {
460                Some(Operation::StdLibCall {
461                    name: fn_name.clone().unwrap_or_else(|| "unknown function".to_owned()),
462                    unlabeled_arg: args
463                        .unlabeled_kw_arg_unconverted()
464                        .map(|arg| OpArg::new(op_from_kcl_value(&arg.value), arg.source_range)),
465                    labeled_args: op_labeled_args,
466                    node_path: NodePath::placeholder(),
467                    source_range: callsite,
468                    stdlib_entry_source_range: exec_state.mod_local.stdlib_entry_source_range,
469                    is_error: false,
470                })
471            } else {
472                // Otherwise, you're calling a user-defined function, track that call as an operation.
473                exec_state.push_op(Operation::GroupBegin {
474                    group: Group::FunctionCall {
475                        name: fn_name.clone(),
476                        function_source_range: self.ast.as_source_range(),
477                        unlabeled_arg: args
478                            .unlabeled_kw_arg_unconverted()
479                            .map(|arg| OpArg::new(op_from_kcl_value(&arg.value), arg.source_range)),
480                        labeled_args: op_labeled_args,
481                    },
482                    node_path: NodePath::placeholder(),
483                    source_range: callsite,
484                });
485
486                None
487            }
488        } else {
489            None
490        };
491
492        let is_calling_into_stdlib = match &self.body {
493            FunctionBody::Rust(_) => true,
494            FunctionBody::Kcl(_) => self.is_std(),
495        };
496        let is_crossing_into_stdlib = is_calling_into_stdlib && !exec_state.mod_local.inside_stdlib;
497        let is_crossing_out_of_stdlib = !is_calling_into_stdlib && exec_state.mod_local.inside_stdlib;
498        let stdlib_entry_source_range = if is_crossing_into_stdlib {
499            // When we're calling into the stdlib, for example calling hole(),
500            // track the location so that any further stdlib calls like
501            // subtract() can point to the hole() call. The frontend needs this.
502            Some(callsite)
503        } else if is_crossing_out_of_stdlib {
504            // When map() calls a user-defined function, and it calls extrude()
505            // for example, we want it to point the the extrude() call, not
506            // the map() call.
507            None
508        } else {
509            // When we're not crossing the stdlib boundary, keep the previous
510            // value.
511            exec_state.mod_local.stdlib_entry_source_range
512        };
513
514        let prev_inside_stdlib = std::mem::replace(&mut exec_state.mod_local.inside_stdlib, is_calling_into_stdlib);
515        let prev_stdlib_entry_source_range = std::mem::replace(
516            &mut exec_state.mod_local.stdlib_entry_source_range,
517            stdlib_entry_source_range,
518        );
519
520        Ok((
521            CallState {
522                prev_inside_stdlib,
523                prev_stdlib_entry_source_range,
524                op,
525                should_track_operation,
526                is_calling_into_stdlib,
527                face_tag_names,
528                pending_region_consumption,
529            },
530            args,
531        ))
532    }
533
534    /// Compute a KCL function body's result while the callee environment is
535    /// still pushed: an `Exit` or `Return` passes through untouched;
536    /// otherwise the function's result is the `__return` value recorded in
537    /// the callee environment, if any.
538    ///
539    /// NOTE: under a pre-KCL-3.0 entry point, a `return` statement does NOT
540    /// stop the body -- it records `__return` and execution continues to the
541    /// following statements (see exec_block's ReturnStatement arm). The block's
542    /// own trailing value is deliberately ignored here; only `__return` counts.
543    /// Under KCL 3.0, `return` stops the body and arrives here as a `Return`
544    /// control flow instead; `__return` is never written.
545    pub(super) fn kcl_body_result(
546        &self,
547        block_result: Result<Option<KclValueControlFlow>, KclError>,
548        exec_state: &mut ExecState,
549    ) -> Result<Option<KclValueControlFlow>, KclError> {
550        block_result.map(|cf| {
551            if let Some(cf) = cf
552                && cf.is_some_return()
553            {
554                return Some(cf);
555            }
556            // Ignore the block's value and extract the return value
557            // from memory.
558            exec_state
559                .stack()
560                .get(memory::RETURN_NAME, self.ast.as_source_range())
561                .ok()
562                .map(KclValue::continue_)
563        })
564    }
565
566    /// The failure path when binding a KCL function's arguments fails, before
567    /// the body ran: restore `inside_stdlib` and pop the callee environment.
568    /// Deliberately asymmetric with [`Self::call_finish`] -- it does not
569    /// restore `stdlib_entry_source_range` and does not finalize the
570    /// operation -- preserving the recursive executor's historical behavior
571    /// exactly.
572    pub(super) fn call_abort_on_arg_binding_failure(
573        state: CallState,
574        e: KclError,
575        exec_state: &mut ExecState,
576    ) -> KclError {
577        exec_state.mod_local.inside_stdlib = state.prev_inside_stdlib;
578        match exec_state.mut_stack().pop_env() {
579            Ok(_) => e,
580            Err(pop_err) => pop_err,
581        }
582    }
583
584    /// The second half of a function call: restore the ambient stdlib flags,
585    /// pop the callee environment, finalize the operation, and then -- for
586    /// normal completions only -- apply tag updates and return-type coercion.
587    /// `Exit` control flow bypasses tags and coercion (it terminates the whole
588    /// evaluation rather than completing this function normally), and errors
589    /// skip them too; both still restore ambient state and finalize the
590    /// operation. `Return` control flow (a KCL 3.0 early return) is absorbed
591    /// here: it completes this function normally, so tags and coercion apply to
592    /// it exactly as they do to a `__return` value.
593    pub(super) fn call_finish(
594        &self,
595        state: CallState,
596        result: Result<Option<KclValueControlFlow>, KclError>,
597        exec_state: &mut ExecState,
598    ) -> Result<Option<KclValueControlFlow>, KclError> {
599        let CallState {
600            prev_inside_stdlib,
601            prev_stdlib_entry_source_range,
602            op,
603            should_track_operation,
604            is_calling_into_stdlib,
605            face_tag_names,
606            pending_region_consumption,
607        } = state;
608        exec_state.mod_local.inside_stdlib = prev_inside_stdlib;
609        exec_state.mod_local.stdlib_entry_source_range = prev_stdlib_entry_source_range;
610        exec_state.mut_stack().pop_env()?;
611
612        if result.is_ok()
613            && let Some(pending_region_consumption) = pending_region_consumption
614        {
615            record_consumed_regions(exec_state, pending_region_consumption);
616        }
617
618        if should_track_operation {
619            if let Some(mut op) = op {
620                op.set_std_lib_call_is_error(result.is_err());
621                // Track call operation.  We do this after the call
622                // since things like patternTransform may call user code
623                // before running, and we will likely want to use the
624                // return value. The call takes ownership of the args,
625                // so we need to build the op before the call.
626                exec_state.push_op(op);
627            } else if !is_calling_into_stdlib {
628                exec_state.push_op(Operation::GroupEnd);
629            }
630        }
631
632        let mut result = match result {
633            Ok(Some(value)) => {
634                if value.is_exit() {
635                    // `Exit` terminates the whole evaluation rather than completing this
636                    // function normally, so it bypasses return-type validation, including
637                    // the `never` contract.
638                    return Ok(Some(value));
639                } else {
640                    // `Continue` and `Return` both complete this function
641                    // normally.
642                    Ok(Some(value.into_value()))
643                }
644            }
645            Ok(None) => Ok(None),
646            Err(e) => Err(e),
647        };
648
649        if self.is_std()
650            && let Ok(Some(result)) = &mut result
651        {
652            update_memory_for_tags_of_geometry(result, exec_state)?;
653            if !face_tag_names.is_empty() {
654                attach_face_tags_to_geometry(result, exec_state, &face_tag_names);
655            }
656        }
657
658        coerce_result_type(result, self, exec_state).map(|r| r.map(KclValue::continue_))
659    }
660}
661
662/// State captured by [`FunctionSource::call_setup`] that
663/// [`FunctionSource::call_finish`] needs to complete the call: the ambient
664/// flags to restore, the deferred operation, and details of what was called.
665#[derive(Debug)]
666pub(super) struct CallState {
667    prev_inside_stdlib: bool,
668    prev_stdlib_entry_source_range: Option<SourceRange>,
669    /// Deferred stdlib-call operation, pushed by call_finish.
670    op: Option<Operation>,
671    should_track_operation: bool,
672    is_calling_into_stdlib: bool,
673    face_tag_names: Vec<String>,
674    pending_region_consumption: Option<PendingRegionConsumption>,
675}
676
677impl FunctionBody {
678    fn prep_mem(&self, exec_state: &mut ExecState) -> Result<(), KclError> {
679        match self {
680            FunctionBody::Rust(_) => exec_state.mut_stack().push_new_root_env(true),
681            FunctionBody::Kcl(memory) => exec_state.mut_stack().push_new_env_for_call(*memory),
682        }
683    }
684}
685
686/// Whether `value` may have come from a legacy (v1) sketch rather than a
687/// sketch block, which is what gates the legacy tag-memory updates in
688/// `update_memory_for_tags_of_geometry`.
689///
690/// Anything that is not a sketch or a solid answers `false`: a number or an
691/// enum variant is not a sketch of either generation, so it must not pull in
692/// legacy behavior. The match stays exhaustive so that adding a `KclValue`
693/// variant forces an explicit answer here instead of inheriting one.
694fn might_be_legacy_sketch(value: &KclValue) -> bool {
695    match value {
696        KclValue::Uuid { .. } => false,
697        KclValue::Bool { .. } => false,
698        KclValue::Number { .. } => false,
699        KclValue::String { .. } => false,
700        KclValue::Enum { .. } => false,
701        KclValue::SketchVar { .. } => false,
702        KclValue::SketchConstraint { .. } => false,
703        KclValue::Tuple { value, .. } => value.iter().any(might_be_legacy_sketch),
704        KclValue::HomArray { value, .. } => value.iter().any(might_be_legacy_sketch),
705        // TODO: sketch block result should return false.
706        KclValue::Object { value, .. } => value.values().any(might_be_legacy_sketch),
707        KclValue::TagIdentifier(_) => false,
708        KclValue::TagDeclarator(_) => false,
709        KclValue::GdtAnnotation { .. } => false,
710        KclValue::CameraView { .. } => false,
711        KclValue::NamedView { .. } => false,
712        KclValue::Plane { .. } => false,
713        KclValue::Face { .. } => false,
714        KclValue::BoundedEdge { .. } => false,
715        KclValue::Segment { .. } => false,
716        KclValue::Sketch { value: sketch } => sketch.origin_sketch_id.is_none(),
717        // A solid with no sketch has no tag container, so the caller returns
718        // early without consulting this answer; `true` keeps it the exact
719        // negation of the previous `originates_from_sketch_block`.
720        KclValue::Solid { value: solid } => solid
721            .sketch()
722            .map(|sketch| sketch.origin_sketch_id.is_none())
723            .unwrap_or(true),
724        KclValue::Helix { .. } => false,
725        KclValue::ImportedGeometry(_) => false,
726        KclValue::Function { .. } => false,
727        KclValue::Module { .. } => false,
728        KclValue::Type { .. } => false,
729        KclValue::KclNone { .. } => false,
730    }
731}
732
733fn face_tag_names_for_call(fn_def: &FunctionSource, args: &Args<Desugared>) -> Vec<String> {
734    let Some(std_props) = &fn_def.std_props else {
735        return Vec::new();
736    };
737
738    if !std_function_allows_face_tags(&std_props.name) {
739        return Vec::new();
740    }
741
742    args.labeled
743        .iter()
744        .filter(|(label, _)| matches!(label.as_str(), "tag" | "tagStart" | "tagEnd"))
745        .filter_map(|(_, arg)| match &arg.value {
746            KclValue::TagDeclarator(tag) => Some(tag.name.clone()),
747            _ => None,
748        })
749        .collect()
750}
751
752fn std_function_allows_face_tags(std_fn_name: &str) -> bool {
753    matches!(
754        std_fn_name,
755        "std::sketch::extrude"
756            | "std::solid::chamfer"
757            | "std::solid::fillet"
758            | "std::sketch::sweep"
759            | "std::sketch::loft"
760            | "std::sketch::revolve"
761    )
762}
763
764fn attach_face_tags_to_geometry(result: &mut KclValue, exec_state: &ExecState, tag_names: &[String]) {
765    match result {
766        KclValue::Solid { value } => attach_face_tags_to_solid(value, exec_state, tag_names),
767        KclValue::Tuple { value, .. } | KclValue::HomArray { value, .. } => {
768            for v in value {
769                attach_face_tags_to_geometry(v, exec_state, tag_names);
770            }
771        }
772        _ => {}
773    }
774}
775
776fn attach_face_tags_to_solid(solid: &mut Solid, exec_state: &ExecState, tag_names: &[String]) {
777    let surfaces = solid.value.clone();
778    for surface in surfaces {
779        let Some(tag) = surface.get_tag() else {
780            continue;
781        };
782        if !tag_names.iter().any(|tag_name| tag_name == &tag.name) {
783            continue;
784        }
785
786        let tag_id = solid
787            .sketch()
788            .and_then(|sketch| sketch.tags.get(&tag.name))
789            .cloned()
790            .unwrap_or_else(|| {
791                let mut solid_copy = solid.clone();
792                clear_tags_from_solid_copy(&mut solid_copy);
793                TagIdentifier {
794                    value: tag.name.clone(),
795                    info: vec![(
796                        exec_state.stack().current_epoch(),
797                        TagEngineInfo {
798                            id: surface.get_id(),
799                            surface: Some(surface.clone()),
800                            path: None,
801                            geometry: Geometry::Solid(solid_copy),
802                        },
803                    )],
804                    meta: vec![Metadata {
805                        source_range: tag.clone().into(),
806                    }],
807                }
808            });
809
810        match solid.faces.get_mut(&tag.name) {
811            Some(existing_tag) => existing_tag.merge_info(&tag_id),
812            None => {
813                solid.faces.insert(tag.name.clone(), tag_id);
814            }
815        }
816    }
817}
818
819fn clear_tags_from_solid_copy(solid: &mut Solid) {
820    if let Some(sketch) = solid.sketch_mut() {
821        sketch.tags.clear(); // Avoid recursive tags.
822    }
823    solid.faces.clear();
824}
825
826fn update_memory_for_tags_of_geometry(result: &mut KclValue, exec_state: &mut ExecState) -> Result<(), KclError> {
827    let might_be_legacy = might_be_legacy_sketch(&*result);
828    // If the return result is a sketch or solid, we want to update the
829    // memory for the tags of the group.
830    // TODO: This could probably be done in a better way, but as of now this was my only idea
831    // and it works.
832    match result {
833        KclValue::Sketch { value } if might_be_legacy => {
834            for (name, tag) in value.tags.iter() {
835                if exec_state.stack().cur_frame_contains(name)? {
836                    exec_state.mut_stack().update(name, |v, _| {
837                        if let Some(existing_tag) = v.as_mut_tag() {
838                            existing_tag.merge_info(tag);
839                        }
840                    })?;
841                } else {
842                    exec_state.mut_stack().add(
843                        name.to_owned(),
844                        KclValue::TagIdentifier(Box::new(tag.clone())),
845                        SourceRange::default(),
846                    )?;
847                }
848            }
849        }
850        KclValue::Solid { value } => {
851            if value.sketch().is_none() {
852                // If the solid isn't based on a sketch, then it doesn't have a tag container,
853                // so there's nothing to do here.
854                return Ok(());
855            };
856            // Only tagged surfaces need solid snapshots. Copying the entire solid for every
857            // untagged surface would take quadratic time and memory in the number of surfaces.
858            let surfaces: Vec<_> = value
859                .value
860                .iter()
861                .filter(|surface| surface.get_tag().is_some())
862                .cloned()
863                .collect();
864            // Capture all snapshots before updating tags so they refer to the same original solid.
865            let solid_copies: Vec<Box<Solid>> = surfaces.iter().map(|_| value.clone()).collect();
866            // Get the tag container. We expect it to always succeed because we already checked
867            // for a tag container above.
868            let Some(sketch) = value.sketch_mut() else {
869                return Ok(());
870            };
871            for (v, mut solid_copy) in surfaces.iter().zip(solid_copies) {
872                clear_tags_from_solid_copy(&mut solid_copy);
873                if let Some(tag) = v.get_tag() {
874                    // Get the past tag and update it.
875                    let mut is_part_of_sketch = false;
876                    let tag_id = if let Some(t) = sketch.tags.get(&tag.name) {
877                        is_part_of_sketch = true;
878                        let mut t = t.clone();
879                        let Some(info) = t.get_cur_info() else {
880                            return Err(KclError::new_internal(KclErrorDetails::new(
881                                format!("Tag {} does not have path info", tag.name),
882                                vec![tag.into()],
883                            )));
884                        };
885
886                        let mut info = info.clone();
887                        info.id = v.get_id();
888                        info.surface = Some(v.clone());
889                        info.geometry = Geometry::Solid(*solid_copy);
890                        t.info.push((exec_state.stack().current_epoch(), info));
891                        t
892                    } else {
893                        // It's probably a fillet or a chamfer.
894                        // Initialize it.
895                        TagIdentifier {
896                            value: tag.name.clone(),
897                            info: vec![(
898                                exec_state.stack().current_epoch(),
899                                TagEngineInfo {
900                                    id: v.get_id(),
901                                    surface: Some(v.clone()),
902                                    path: None,
903                                    geometry: Geometry::Solid(*solid_copy),
904                                },
905                            )],
906                            meta: vec![Metadata {
907                                source_range: tag.clone().into(),
908                            }],
909                        }
910                    };
911
912                    // update the sketch tags.
913                    sketch.merge_tags(Some(&tag_id).into_iter());
914
915                    if exec_state.stack().cur_frame_contains(&tag.name)? {
916                        exec_state.mut_stack().update(&tag.name, |v, _| {
917                            if let Some(existing_tag) = v.as_mut_tag() {
918                                existing_tag.merge_info(&tag_id);
919                            }
920                        })?;
921                    } else if might_be_legacy || !is_part_of_sketch {
922                        // The above condition is saying that we add a tag to
923                        // the stack in either of these cases:
924                        //
925                        // 1. It originates from a legacy sketch v1.
926                        //
927                        // 2. It originates from a sketch block and it's not
928                        // part of the sketch. Instead, it's part of the solid,
929                        // as in tagging a cap face `extrude(tagEnd, tagStart)`
930                        // or chamfer face `chamfer(tag)`.
931                        exec_state.mut_stack().add(
932                            tag.name.clone(),
933                            KclValue::TagIdentifier(Box::new(tag_id)),
934                            SourceRange::default(),
935                        )?;
936                    }
937                }
938            }
939
940            // Find the stale sketch in memory and update it.
941            if let Some(sketch) = value.sketch() {
942                if sketch.tags.is_empty() {
943                    return Ok(());
944                }
945                let sketch_tags: Vec<_> = sketch.tags.values().cloned().collect();
946                let sketches_to_update: Vec<_> = exec_state.stack().find_keys_in_current_env(|v| match v {
947                    KclValue::Sketch { value: sk } => sk.original_id == sketch.original_id,
948                    _ => false,
949                })?;
950
951                for k in sketches_to_update {
952                    exec_state.mut_stack().update(&k, |v, _| {
953                        if let Some(sketch) = v.as_mut_sketch() {
954                            sketch.merge_tags(sketch_tags.iter());
955                        }
956                    })?;
957                }
958            }
959        }
960        KclValue::Tuple { value, .. } | KclValue::HomArray { value, .. } => {
961            for v in value {
962                update_memory_for_tags_of_geometry(v, exec_state)?;
963            }
964        }
965        _ => {}
966    }
967    Ok(())
968}
969
970fn type_err_str(expected: &Type, found: &KclValue, source_range: &SourceRange, exec_state: &mut ExecState) -> String {
971    fn strip_backticks(s: &str) -> &str {
972        let mut result = s;
973        if s.starts_with('`') {
974            result = &result[1..]
975        }
976        if s.ends_with('`') {
977            result = &result[..result.len() - 1]
978        }
979        result
980    }
981
982    let expected_human = expected.human_friendly_type();
983    let expected_ty = expected.to_string();
984    let expected_str =
985        if expected_human == expected_ty || expected_human == format!("a value with type `{expected_ty}`") {
986            format!("a value with type `{expected_ty}`")
987        } else {
988            format!("{expected_human} (`{expected_ty}`)")
989        };
990    let found_human = found.human_friendly_type();
991    let found_ty = found.principal_type_string();
992    let found_str = if found_human == found_ty || found_human == format!("a {}", strip_backticks(&found_ty)) {
993        format!("a value with type {found_ty}")
994    } else {
995        format!("{found_human} (with type {found_ty})")
996    };
997
998    let mut result = format!("{expected_str}, but found {found_str}.");
999
1000    if found.is_unknown_number() {
1001        exec_state.clear_units_warnings(source_range);
1002        result.push_str("\nThe found value is a number but has incomplete units information. You can probably fix this error by specifying the units using type ascription, e.g., `len: mm` or `(a * b): deg`.");
1003    }
1004
1005    result
1006}
1007
1008/// Build the error message for a labeled argument whose label doesn't match any
1009/// parameter of the callee. Shared between keyword function calls and sketch
1010/// blocks so the wording stays consistent.
1011pub(crate) fn unexpected_kw_arg_message(label: &str, callee_name: Option<&str>) -> String {
1012    format!(
1013        "`{label}` is not an argument of {}",
1014        callee_name
1015            .map(|n| format!("`{n}`"))
1016            .unwrap_or_else(|| "this function".to_owned()),
1017    )
1018}
1019
1020/// Build the error message for a labeled argument whose parameter the callee
1021/// declares, but not on the KCL version governing this execution. Extends
1022/// [`unexpected_kw_arg_message`] with the version that made the parameter
1023/// unavailable and the version this program uses, so the user can tell a
1024/// version mismatch apart from a typo.
1025fn unavailable_kw_arg_message(
1026    label: &str,
1027    callee_name: Option<&str>,
1028    reason: ParamUnavailable<'_>,
1029    program_version: &str,
1030) -> String {
1031    let base = unexpected_kw_arg_message(label, callee_name);
1032    match reason {
1033        ParamUnavailable::NotYetAdded(added) => {
1034            format!("{base}; it was added in KCL {added}, but this program uses KCL {program_version}")
1035        }
1036        ParamUnavailable::Removed(removed) => {
1037            format!("{base}; it was removed in KCL {removed}, but this program uses KCL {program_version}")
1038        }
1039    }
1040}
1041
1042/// Fetch the definition-time resolution of a type written in a function
1043/// signature.
1044///
1045/// [`FunctionSource::resolve_signature_types`] runs whenever a function
1046/// declaration executes, so a written type without a stored resolution is a
1047/// bug in KCL, not in the user's program.
1048fn resolved_signature_type<'a>(
1049    resolved: Option<&'a RuntimeType>,
1050    written: &Type,
1051    source_range: SourceRange,
1052) -> Result<&'a RuntimeType, KclError> {
1053    resolved.ok_or_else(|| {
1054        KclError::new_internal(KclErrorDetails::new(
1055            format!(
1056                "The type `{written}` in this function's signature was not resolved when the function was declared. This is a bug in KCL and not in your code, please report this to Zoo."
1057            ),
1058            vec![source_range],
1059        ))
1060    })
1061}
1062
1063fn type_check_params_kw(
1064    fn_name: Option<&str>,
1065    fn_def: &FunctionSource,
1066    mut args: Args<Sugary>,
1067    exec_state: &mut ExecState,
1068) -> Result<Args<Desugared>, KclError> {
1069    let fn_name = fn_name.or(args.fn_name.as_deref());
1070    let mut result = Args::new_no_args(
1071        args.source_range,
1072        args.node_path.clone(),
1073        args.ctx,
1074        fn_name.map(|f| f.to_string()).or_else(|| args.fn_name.clone()),
1075    );
1076
1077    // If it's possible the input arg was meant to be labelled and we probably don't want to use
1078    // it as the input arg, then treat it as labelled.
1079    if let Some((Some(label), _)) = args.unlabeled.first()
1080        && args.unlabeled.len() == 1
1081        && (fn_def.input_arg.is_none() || args.pipe_value.is_some())
1082        && fn_def.active_named_arg(label, exec_state).is_some()
1083        && !args.labeled.contains_key(label)
1084    {
1085        let Some((label, arg)) = args.unlabeled.pop() else {
1086            let message = "Expected unlabeled arg to be present".to_owned();
1087            debug_assert!(false, "{}", &message);
1088            return Err(KclError::new_internal(KclErrorDetails::new(
1089                message,
1090                vec![args.source_range],
1091            )));
1092        };
1093        args.labeled.insert(label.unwrap(), arg);
1094    }
1095
1096    // Apply the `a == a: a` shorthand by desugaring unlabeled args into labeled ones.
1097    let (labeled_unlabeled, unlabeled_unlabeled) = args.unlabeled.into_iter().partition(|(l, _)| {
1098        if let Some(l) = l
1099            && fn_def.active_named_arg(l, exec_state).is_some()
1100            && !args.labeled.contains_key(l)
1101        {
1102            true
1103        } else {
1104            false
1105        }
1106    });
1107    args.unlabeled = unlabeled_unlabeled;
1108    for (l, arg) in labeled_unlabeled {
1109        let previous = args.labeled.insert(l.unwrap(), arg);
1110        debug_assert!(previous.is_none());
1111    }
1112
1113    if let Some((name, ty)) = &fn_def.input_arg {
1114        // Expecting an input arg
1115
1116        if args.unlabeled.is_empty() {
1117            // No args provided
1118
1119            if let Some(pipe) = args.pipe_value {
1120                // But there is a pipeline
1121                result.unlabeled = vec![(None, pipe)];
1122            } else if let Some(arg) = args.labeled.swap_remove(name) {
1123                // Mistakenly labelled
1124                exec_state.err(CompilationIssue::err(
1125                    arg.source_range,
1126                    format!(
1127                        "{} expects an unlabeled first argument (`@{name}`), but it is labelled in the call. You might try removing the `{name} = `",
1128                        fn_name
1129                            .map(|n| format!("The function `{n}`"))
1130                            .unwrap_or_else(|| "This function".to_owned()),
1131                    ),
1132                ));
1133                result.unlabeled = vec![(Some(name.clone()), arg)];
1134            } else {
1135                // Just missing
1136                return Err(KclError::new_argument(KclErrorDetails::new(
1137                    "This function expects an unlabeled first parameter, but you haven't passed it one.".to_owned(),
1138                    fn_def.ast.as_source_ranges(),
1139                )));
1140            }
1141        } else if args.unlabeled.len() == 1
1142            && let Some(unlabeled_arg) = args.unlabeled.pop()
1143        {
1144            let mut arg = unlabeled_arg.1;
1145            if let Some(ty) = ty {
1146                let rty = resolved_signature_type(fn_def.resolved_input_ty.as_ref(), ty, arg.source_range)?;
1147                arg.value = arg
1148                    .value
1149                    .coerce(rty, CoercionMode::implicit(), exec_state)
1150                    .map_err(|_| {
1151                        KclError::new_argument(KclErrorDetails::new(
1152                            format!(
1153                                "The input argument of {} requires {}",
1154                                fn_name
1155                                    .map(|n| format!("`{n}`"))
1156                                    .unwrap_or_else(|| "this function".to_owned()),
1157                                type_err_str(ty, &arg.value, &arg.source_range, exec_state),
1158                            ),
1159                            vec![arg.source_range],
1160                        ))
1161                    })?;
1162            }
1163            result.unlabeled = vec![(None, arg)]
1164        } else {
1165            // Multiple unlabelled args
1166
1167            // Try to un-spread args into an array
1168            if let Some(Type::Array { len, .. }) = ty {
1169                if len.satisfied(args.unlabeled.len(), false).is_none() {
1170                    exec_state.err(CompilationIssue::err(
1171                        args.source_range,
1172                        format!(
1173                            "{} expects an array input argument with {} elements",
1174                            fn_name
1175                                .map(|n| format!("The function `{n}`"))
1176                                .unwrap_or_else(|| "This function".to_owned()),
1177                            len.human_friendly_type(),
1178                        ),
1179                    ));
1180                }
1181
1182                let source_range = SourceRange::merge(args.unlabeled.iter().map(|(_, a)| a.source_range));
1183                exec_state.warn_experimental("array input arguments", source_range);
1184                result.unlabeled = vec![(
1185                    None,
1186                    Arg {
1187                        source_range,
1188                        value: KclValue::HomArray {
1189                            value: args.unlabeled.drain(..).map(|(_, a)| a.value).collect(),
1190                            ty: RuntimeType::any(),
1191                        },
1192                    },
1193                )]
1194            }
1195        }
1196    }
1197
1198    // Either we didn't move the arg above, or we're not expecting one.
1199    if !args.unlabeled.is_empty() {
1200        // Not expecting an input arg, but found one or more
1201        let actuals = args.labeled.keys();
1202        let formals: Vec<_> = fn_def
1203            .active_named_args(exec_state)
1204            .filter_map(|(name, _)| {
1205                if actuals.clone().any(|a| a == name) {
1206                    return None;
1207                }
1208
1209                Some(format!("`{name}`"))
1210            })
1211            .collect();
1212
1213        let suggestion = if formals.is_empty() {
1214            String::new()
1215        } else {
1216            format!("; suggested labels: {}", formals.join(", "))
1217        };
1218
1219        let mut errors = args.unlabeled.iter().map(|(_, arg)| {
1220            CompilationIssue::err(
1221                arg.source_range,
1222                format!("This argument needs a label, but it doesn't have one{suggestion}"),
1223            )
1224        });
1225
1226        let first = errors.next().unwrap();
1227        errors.for_each(|e| exec_state.err(e));
1228
1229        return Err(KclError::new_argument(first.into()));
1230    }
1231
1232    for (label, mut arg) in args.labeled {
1233        let param = fn_def.named_args.get(&label);
1234        match param.map(|param| (param, param.unavailable_reason(exec_state))) {
1235            Some((
1236                NamedParam {
1237                    experimental: _,
1238                    added_in: _,
1239                    deprecated: _,
1240                    deprecated_since: _,
1241                    removed_in: _,
1242                    default_value: def,
1243                    ty,
1244                    resolved_ty,
1245                },
1246                None,
1247            )) => {
1248                // For optional args, passing None should be the same as not passing an arg.
1249                if !(def.is_some() && matches!(arg.value, KclValue::KclNone { .. })) {
1250                    if let Some(ty) = ty {
1251                        let rty = resolved_signature_type(resolved_ty.as_ref(), ty, arg.source_range)?;
1252                        arg.value = arg
1253                                .value
1254                                .coerce(
1255                                    rty,
1256                                    CoercionMode::implicit(),
1257                                    exec_state,
1258                                )
1259                                .map_err(|e| {
1260                                    let mut message = format!(
1261                                        "{label} requires {}",
1262                                        type_err_str(ty, &arg.value, &arg.source_range, exec_state),
1263                                    );
1264                                    if let Some(ty) = e.explicit_coercion {
1265                                        // TODO if we have access to the AST for the argument we could choose which example to suggest.
1266                                        message = format!("{message}\n\nYou may need to add information about the type of the argument, for example:\n  using a numeric suffix: `42{ty}`\n  or using type ascription: `foo(): {ty}`");
1267                                    }
1268                                    KclError::new_argument(KclErrorDetails::new(
1269                                        message,
1270                                        vec![arg.source_range],
1271                                    ))
1272                                })?;
1273                    }
1274                    result.labeled.insert(label, arg);
1275                }
1276            }
1277            Some((_, Some(reason))) => {
1278                let message = unavailable_kw_arg_message(&label, fn_name, reason, exec_state.kcl_version().as_str());
1279                exec_state.err(CompilationIssue::err(arg.source_range, message));
1280            }
1281            None => {
1282                exec_state.err(CompilationIssue::err(
1283                    arg.source_range,
1284                    unexpected_kw_arg_message(&label, fn_name),
1285                ));
1286            }
1287        }
1288    }
1289
1290    let consumed_solid_arg_check = fn_def
1291        .std_props
1292        .as_ref()
1293        .map_or(ConsumedSolidArgCheck::Error, |props| props.consumed_solid_arg_check);
1294    if matches!(fn_def.body, FunctionBody::Rust(_))
1295        && let Some(props) = fn_def.std_props.as_ref()
1296    {
1297        match props.region_behavior.stale_region_policy() {
1298            Some(StaleRegionPolicy::Error) => validate_region_args_not_consumed(&result, exec_state)?,
1299            Some(StaleRegionPolicy::Warning) => {
1300                warn_if_region_args_consumed(&result, exec_state, &props.name)?;
1301            }
1302            None => {}
1303        }
1304    }
1305    match consumed_solid_arg_check {
1306        ConsumedSolidArgCheck::Error => {
1307            result
1308                .unlabeled
1309                .iter()
1310                .map(|(_, arg)| arg)
1311                .chain(result.labeled.values())
1312                .try_for_each(|arg| validate_value_not_consumed(&arg.value, exec_state, arg.source_range))?;
1313        }
1314        ConsumedSolidArgCheck::WarnDeprecated => {
1315            let std_fn_name = fn_def
1316                .std_props
1317                .as_ref()
1318                .map(|props| props.name.as_str())
1319                .unwrap_or("function");
1320            for arg in result
1321                .unlabeled
1322                .iter()
1323                .map(|(_, arg)| arg)
1324                .chain(result.labeled.values())
1325            {
1326                warn_if_value_consumed_for_deprecated_call(&arg.value, exec_state, arg.source_range, std_fn_name)?;
1327            }
1328        }
1329    }
1330
1331    Ok(result)
1332}
1333
1334pub(super) fn assign_args_to_params_kw(
1335    fn_def: &FunctionSource,
1336    args: Args<Desugared>,
1337    exec_state: &mut ExecState,
1338) -> Result<(), KclError> {
1339    // Add the arguments to the memory.  A new call frame should have already
1340    // been created.
1341    let source_ranges = fn_def.ast.as_source_ranges();
1342
1343    for (name, param) in fn_def.named_args.iter() {
1344        let arg = args.labeled.get(name);
1345        match arg {
1346            Some(arg) => {
1347                exec_state.mut_stack().add(
1348                    name.clone(),
1349                    arg.value.clone(),
1350                    arg.source_ranges().pop().unwrap_or(SourceRange::synthetic()),
1351                )?;
1352            }
1353            None => match &param.default_value {
1354                Some(default_val) => {
1355                    let value = KclValue::from_default_param(default_val.clone(), exec_state);
1356                    exec_state
1357                        .mut_stack()
1358                        .add(name.clone(), value, default_val.source_range())?;
1359                }
1360                None => {
1361                    return Err(KclError::new_argument(KclErrorDetails::new(
1362                        format!("This function requires a parameter {name}, but you haven't passed it one."),
1363                        source_ranges,
1364                    )));
1365                }
1366            },
1367        }
1368    }
1369
1370    if let Some((param_name, _)) = &fn_def.input_arg {
1371        let Some(unlabeled) = args.unlabeled_kw_arg_unconverted() else {
1372            debug_assert!(false, "Bad args");
1373            return Err(KclError::new_internal(KclErrorDetails::new(
1374                "Desugared arguments are inconsistent".to_owned(),
1375                source_ranges,
1376            )));
1377        };
1378        exec_state.mut_stack().add(
1379            param_name.clone(),
1380            unlabeled.value.clone(),
1381            unlabeled.source_ranges().pop().unwrap_or(SourceRange::synthetic()),
1382        )?;
1383    }
1384
1385    Ok(())
1386}
1387
1388fn coerce_result_type(
1389    result: Result<Option<KclValue>, KclError>,
1390    fn_def: &FunctionSource,
1391    exec_state: &mut ExecState,
1392) -> Result<Option<KclValue>, KclError> {
1393    let result = result?;
1394
1395    let Some(ret_ty) = &fn_def.return_type else {
1396        return Ok(result);
1397    };
1398
1399    let ty = resolved_signature_type(
1400        fn_def.resolved_return_ty.as_ref(),
1401        &ret_ty.inner,
1402        ret_ty.as_source_range(),
1403    )?;
1404
1405    // `never` describes the absence of normal completion, so either successful
1406    // result shape violates the function's declared contract.
1407    if ty.subtype(&RuntimeType::never()) {
1408        let message = if result.is_some() {
1409            "This function returned a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1410        } else {
1411            "This function completed without returning a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1412        };
1413        return Err(KclError::new_type(KclErrorDetails::new(
1414            message.to_owned(),
1415            ret_ty.as_source_ranges(),
1416        )));
1417    }
1418
1419    let Some(val) = result else {
1420        return Ok(None);
1421    };
1422
1423    let val = val.coerce(ty, CoercionMode::implicit(), exec_state).map_err(|_| {
1424        KclError::new_type(KclErrorDetails::new(
1425            format!(
1426                "This function requires its result to be {}",
1427                type_err_str(ret_ty, &val, &(&val).into(), exec_state)
1428            ),
1429            ret_ty.as_source_ranges(),
1430        ))
1431    })?;
1432    Ok(Some(val))
1433}
1434
1435#[cfg(test)]
1436mod test {
1437    use std::sync::Arc;
1438
1439    use super::*;
1440    use crate::engine::engine_manager::EngineManager;
1441    use crate::errors::Severity;
1442    use crate::execution::ContextType;
1443    use crate::execution::EnvironmentRef;
1444    use crate::execution::ExecTestResults;
1445    use crate::execution::memory::Stack;
1446    use crate::execution::parse_execute;
1447    use crate::execution::types::NumericType;
1448    use crate::execution::types::NumericTypeExt;
1449    use crate::parsing::ast::types::DefaultParamVal;
1450    use crate::parsing::ast::types::FunctionExpression;
1451    use crate::parsing::ast::types::Identifier;
1452    use crate::parsing::ast::types::Parameter;
1453    use crate::parsing::ast::types::Program;
1454
1455    fn source_texts<'a>(program: &'a str, error: &KclError) -> Vec<&'a str> {
1456        error
1457            .source_ranges()
1458            .into_iter()
1459            .map(|range| &program[range.start()..range.end()])
1460            .collect()
1461    }
1462
1463    fn get_var(result: &ExecTestResults, name: &str) -> KclValue {
1464        result
1465            .exec_state
1466            .stack()
1467            .memory
1468            .get_from_owned(name, result.mem_env, SourceRange::default(), 0)
1469            .unwrap_or_else(|err| panic!("expected variable `{name}` to exist: {err:?}"))
1470    }
1471
1472    fn var_exists(result: &ExecTestResults, name: &str) -> bool {
1473        result
1474            .exec_state
1475            .stack()
1476            .memory
1477            .get_from_owned(name, result.mem_env, SourceRange::default(), 0)
1478            .is_ok()
1479    }
1480
1481    fn assert_vars_are_tags(result: &ExecTestResults, names: &[&str]) {
1482        for name in names {
1483            assert!(
1484                matches!(get_var(result, name), KclValue::TagIdentifier(_)),
1485                "expected variable `{name}` to be a tag identifier"
1486            );
1487        }
1488    }
1489
1490    fn assert_vars_are_missing(result: &ExecTestResults, names: &[&str]) {
1491        for name in names {
1492            assert!(!var_exists(result, name), "expected variable `{name}` to be absent");
1493        }
1494    }
1495
1496    fn assert_body_face_tags(result: &ExecTestResults, expected: &[&str], unexpected: &[&str]) {
1497        let body = get_var(result, "body");
1498        let KclValue::Solid { value: body } = body else {
1499            panic!("expected `body` to be a solid");
1500        };
1501
1502        for tag in expected {
1503            assert!(body.faces.contains_key(*tag), "expected body.faces to contain `{tag}`");
1504        }
1505
1506        for tag in unexpected {
1507            assert!(
1508                !body.faces.contains_key(*tag),
1509                "expected body.faces not to contain sketch tag `{tag}`"
1510            );
1511        }
1512    }
1513
1514    fn deprecated_solid_tag_access_warnings(result: &ExecTestResults) -> Vec<&CompilationIssue> {
1515        result
1516            .exec_state
1517            .issues()
1518            .iter()
1519            .filter(|issue| issue.message.contains("Accessing solid-created face"))
1520            .collect()
1521    }
1522
1523    #[tokio::test(flavor = "multi_thread")]
1524    async fn test_assign_args_to_params() {
1525        // Set up a little framework for this test.
1526        fn mem(number: usize) -> KclValue {
1527            KclValue::Number {
1528                value: number as f64,
1529                ty: NumericType::count(),
1530                meta: Default::default(),
1531            }
1532        }
1533        fn ident(s: &'static str) -> Node<Identifier> {
1534            Node::no_src(Identifier {
1535                name: s.to_owned(),
1536                digest: None,
1537            })
1538        }
1539        fn opt_param(s: &'static str) -> Parameter {
1540            Parameter {
1541                experimental: false,
1542                added_in: None,
1543                deprecated: false,
1544                deprecated_since: None,
1545                removed_in: None,
1546                identifier: ident(s),
1547                param_type: None,
1548                default_value: Some(DefaultParamVal::none()),
1549                labeled: true,
1550                digest: None,
1551            }
1552        }
1553        fn req_param(s: &'static str) -> Parameter {
1554            Parameter {
1555                experimental: false,
1556                added_in: None,
1557                deprecated: false,
1558                deprecated_since: None,
1559                removed_in: None,
1560                identifier: ident(s),
1561                param_type: None,
1562                default_value: None,
1563                labeled: true,
1564                digest: None,
1565            }
1566        }
1567        fn additional_program_memory(items: &[(String, KclValue)]) -> Stack {
1568            let mut program_memory = Stack::new_for_tests();
1569            for (name, item) in items {
1570                program_memory
1571                    .add(name.clone(), item.clone(), SourceRange::default())
1572                    .unwrap();
1573            }
1574            program_memory
1575        }
1576        // Declare the test cases.
1577        for (test_name, params, args, expected) in [
1578            ("empty", Vec::new(), Vec::new(), Ok(additional_program_memory(&[]))),
1579            (
1580                "all params required, and all given, should be OK",
1581                vec![req_param("x")],
1582                vec![("x", mem(1))],
1583                Ok(additional_program_memory(&[("x".to_owned(), mem(1))])),
1584            ),
1585            (
1586                "all params required, none given, should error",
1587                vec![req_param("x")],
1588                vec![],
1589                Err(KclError::new_argument(KclErrorDetails::new(
1590                    "This function requires a parameter x, but you haven't passed it one.".to_owned(),
1591                    vec![SourceRange::default()],
1592                ))),
1593            ),
1594            (
1595                "all params optional, none given, should be OK",
1596                vec![opt_param("x")],
1597                vec![],
1598                Ok(additional_program_memory(&[("x".to_owned(), KclValue::none())])),
1599            ),
1600            (
1601                "mixed params, too few given",
1602                vec![req_param("x"), opt_param("y")],
1603                vec![],
1604                Err(KclError::new_argument(KclErrorDetails::new(
1605                    "This function requires a parameter x, but you haven't passed it one.".to_owned(),
1606                    vec![SourceRange::default()],
1607                ))),
1608            ),
1609            (
1610                "mixed params, minimum given, should be OK",
1611                vec![req_param("x"), opt_param("y")],
1612                vec![("x", mem(1))],
1613                Ok(additional_program_memory(&[
1614                    ("x".to_owned(), mem(1)),
1615                    ("y".to_owned(), KclValue::none()),
1616                ])),
1617            ),
1618            (
1619                "mixed params, maximum given, should be OK",
1620                vec![req_param("x"), opt_param("y")],
1621                vec![("x", mem(1)), ("y", mem(2))],
1622                Ok(additional_program_memory(&[
1623                    ("x".to_owned(), mem(1)),
1624                    ("y".to_owned(), mem(2)),
1625                ])),
1626            ),
1627        ] {
1628            // Run each test.
1629            let func_expr = Node::no_src(FunctionExpression {
1630                name: None,
1631                params,
1632                body: Program::empty(),
1633                return_type: None,
1634                digest: None,
1635            });
1636            let func_src = FunctionSource::kcl(
1637                crate::parsing::ast::types::BoxNode::new(func_expr),
1638                EnvironmentRef::dummy(),
1639                crate::execution::kcl_value::KclFunctionSourceParams {
1640                    std_props: None,
1641                    experimental: false,
1642                    include_in_feature_tree: false,
1643                },
1644            );
1645            let labeled = args
1646                .iter()
1647                .map(|(name, value)| {
1648                    let arg = Arg::new(value.clone(), SourceRange::default());
1649                    ((*name).to_owned(), arg)
1650                })
1651                .collect::<IndexMap<_, _>>();
1652            let exec_ctxt = ExecutorContext {
1653                engine: Arc::new(EngineManager::new_mock()),
1654                engine_batch: crate::engine::EngineBatchContext::default(),
1655                fs: crate::fs::new_file_system_handle(crate::fs::FileManager::new()),
1656                settings: Default::default(),
1657                context_type: ContextType::Mock,
1658                execution_callbacks: Default::default(),
1659                executor_kind: crate::execution::machine::ExecutorKind::resolve(),
1660                machine_call_depth_limit: crate::execution::machine::DEFAULT_MACHINE_CALL_DEPTH_LIMIT,
1661            };
1662            let mut exec_state = ExecState::new(&exec_ctxt);
1663            exec_state.mod_local.stack = Stack::new_for_tests();
1664
1665            let args = Args {
1666                fn_name: Some("test".to_owned()),
1667                labeled,
1668                unlabeled: Vec::new(),
1669                source_range: SourceRange::default(),
1670                node_path: None,
1671                ctx: exec_ctxt,
1672                pipe_value: None,
1673                _status: std::marker::PhantomData,
1674            };
1675
1676            let actual = assign_args_to_params_kw(&func_src, args, &mut exec_state).map(|_| exec_state.mod_local.stack);
1677            assert_eq!(
1678                actual, expected,
1679                "failed test '{test_name}':\ngot {actual:?}\nbut expected\n{expected:?}"
1680            );
1681        }
1682    }
1683
1684    #[tokio::test(flavor = "multi_thread")]
1685    async fn type_check_user_args() {
1686        let program = r#"fn makeMessage(prefix: string, suffix: string) {
1687  return prefix + suffix
1688}
1689
1690msg1 = makeMessage(prefix = "world", suffix = " hello")
1691msg2 = makeMessage(prefix = 1, suffix = 3)"#;
1692        let err = parse_execute(program).await.unwrap_err();
1693        assert_eq!(
1694            err.message(),
1695            "prefix requires a value with type `string`, but found a value with type `number`.\nThe found value is a number but has incomplete units information. You can probably fix this error by specifying the units using type ascription, e.g., `len: mm` or `(a * b): deg`."
1696        )
1697    }
1698
1699    #[tokio::test(flavor = "multi_thread")]
1700    async fn never_function_cannot_return_a_value() {
1701        let program = r#"@settings(kclVersion = "3.0-preview")
1702fn bad(): never {
1703  return 42
1704}
1705
1706bad()
1707"#;
1708        let err = parse_execute(program).await.unwrap_err();
1709
1710        assert!(matches!(&err, KclError::Type { .. }));
1711        assert_eq!(
1712            err.message(),
1713            "This function returned a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1714        );
1715    }
1716
1717    #[tokio::test(flavor = "multi_thread")]
1718    async fn never_function_cannot_fall_through() {
1719        let program = r#"@settings(kclVersion = "3.0-preview")
1720fn alsoBad(): never {
1721  x = 42
1722}
1723
1724alsoBad()
1725"#;
1726        let err = parse_execute(program).await.unwrap_err();
1727
1728        assert!(matches!(&err, KclError::Type { .. }));
1729        assert_eq!(
1730            err.message(),
1731            "This function completed without returning a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1732        );
1733    }
1734
1735    #[tokio::test(flavor = "multi_thread")]
1736    async fn never_union_function_cannot_return_a_value() {
1737        let program = r#"@settings(kclVersion = "3.0-preview")
1738fn bad(): never | never {
1739  return 42
1740}
1741
1742bad()
1743"#;
1744        let err = parse_execute(program).await.unwrap_err();
1745
1746        assert!(matches!(&err, KclError::Type { .. }));
1747        assert_eq!(
1748            err.message(),
1749            "This function returned a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1750        );
1751    }
1752
1753    #[tokio::test(flavor = "multi_thread")]
1754    async fn never_union_function_cannot_fall_through() {
1755        let program = r#"@settings(kclVersion = "3.0-preview")
1756fn alsoBad(): never | never {
1757  x = 42
1758}
1759
1760alsoBad()
1761"#;
1762        let err = parse_execute(program).await.unwrap_err();
1763
1764        assert!(matches!(&err, KclError::Type { .. }));
1765        assert_eq!(
1766            err.message(),
1767            "This function completed without returning a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1768        );
1769    }
1770
1771    #[tokio::test(flavor = "multi_thread")]
1772    async fn never_function_contract_is_path_dependent() {
1773        let function = r#"@settings(kclVersion = "3.0-preview")
1774fn failOrReturn(@shouldFail: bool): never {
1775  return if shouldFail {
1776    fail("requested failure")
1777  } else {
1778    42
1779  }
1780}
1781"#;
1782
1783        let err = parse_execute(&format!("{function}\nfailOrReturn(true)\n"))
1784            .await
1785            .unwrap_err();
1786        assert!(matches!(&err, KclError::UserDefined { .. }));
1787        assert_eq!(err.message(), "requested failure");
1788
1789        let err = parse_execute(&format!("{function}\nfailOrReturn(false)\n"))
1790            .await
1791            .unwrap_err();
1792        assert!(matches!(&err, KclError::Type { .. }));
1793        assert_eq!(
1794            err.message(),
1795            "This function returned a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1796        );
1797    }
1798
1799    #[tokio::test(flavor = "multi_thread")]
1800    async fn never_type_alias_contract_is_path_dependent() {
1801        let function = r#"@settings(kclVersion = "3.0-preview")
1802type impossible = never
1803fn failOrReturn(@shouldFail: bool): impossible {
1804  return if shouldFail {
1805    fail("requested failure")
1806  } else {
1807    42
1808  }
1809}
1810"#;
1811
1812        let err = parse_execute(&format!("{function}\nfailOrReturn(true)\n"))
1813            .await
1814            .unwrap_err();
1815        assert!(matches!(&err, KclError::UserDefined { .. }));
1816        assert_eq!(err.message(), "requested failure");
1817
1818        let err = parse_execute(&format!("{function}\nfailOrReturn(false)\n"))
1819            .await
1820            .unwrap_err();
1821        assert!(matches!(&err, KclError::Type { .. }));
1822        assert_eq!(
1823            err.message(),
1824            "This function returned a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1825        );
1826    }
1827
1828    #[tokio::test(flavor = "multi_thread")]
1829    async fn union_with_never_can_return_a_value_or_fail() {
1830        let function = r#"@settings(kclVersion = "3.0-preview")
1831fn stringOrFail(@shouldFail: bool): string | never {
1832  return if shouldFail {
1833    fail("requested failure")
1834  } else {
1835    "ok"
1836  }
1837}
1838"#;
1839
1840        let result = parse_execute(&format!("{function}\nresult = stringOrFail(false)\n"))
1841            .await
1842            .unwrap();
1843        let KclValue::String { value, .. } = get_var(&result, "result") else {
1844            panic!("expected `result` to be a string")
1845        };
1846        assert_eq!(value, "ok");
1847
1848        let err = parse_execute(&format!("{function}\nstringOrFail(true)\n"))
1849            .await
1850            .unwrap_err();
1851        assert!(matches!(&err, KclError::UserDefined { .. }));
1852        assert_eq!(err.message(), "requested failure");
1853    }
1854
1855    #[tokio::test(flavor = "multi_thread")]
1856    async fn fail_reports_user_defined_message_and_callsite_once() {
1857        let program = r#"@settings(kclVersion = "3.0-preview")
1858fail("custom failure")
1859"#;
1860
1861        let err = parse_execute(program).await.unwrap_err();
1862
1863        assert!(matches!(&err, KclError::UserDefined { .. }));
1864        assert_eq!(err.message(), "custom failure");
1865        assert_eq!(err.get_message(), "user-defined: custom failure");
1866        assert_eq!(serde_json::to_value(&err).unwrap()["kind"], "user_defined");
1867        assert_eq!(source_texts(program, &err), [r#"fail("custom failure")"#]);
1868        assert_eq!(err.backtrace().len(), 1);
1869    }
1870
1871    #[tokio::test(flavor = "multi_thread")]
1872    async fn fail_is_unavailable_before_v3_even_with_experimental_opt_in() {
1873        for version in ["1.0", "2.0"] {
1874            for opt_in in ["", ", experimentalFeatures = allow"] {
1875                let program = format!("@settings(kclVersion = {version}{opt_in})\nfail(\"custom failure\")\n");
1876                let err = parse_execute(&program).await.unwrap_err();
1877                assert!(
1878                    err.message()
1879                        .contains("it was added in KCL 3.0, but this program uses KCL"),
1880                    "{program}: {err:#?}"
1881                );
1882            }
1883        }
1884    }
1885
1886    #[tokio::test(flavor = "multi_thread")]
1887    async fn fail_unwinds_through_nested_never_functions_once() {
1888        let program = r#"@settings(kclVersion = "3.0-preview")
1889fn inner(): never {
1890  fail("nested failure")
1891}
1892
1893fn outer(): never {
1894  inner()
1895}
1896
1897outer()
1898"#;
1899
1900        let err = parse_execute(program).await.unwrap_err();
1901
1902        assert!(matches!(&err, KclError::UserDefined { .. }));
1903        assert_eq!(err.message(), "nested failure");
1904        assert_eq!(
1905            source_texts(program, &err),
1906            [r#"fail("nested failure")"#, "inner()", "outer()"]
1907        );
1908        assert_eq!(
1909            err.backtrace()
1910                .iter()
1911                .map(|item| item.fn_name.as_deref())
1912                .collect::<Vec<_>>(),
1913            [Some("inner"), Some("outer"), None]
1914        );
1915    }
1916
1917    #[tokio::test(flavor = "multi_thread")]
1918    async fn fail_is_valid_in_a_function_with_a_value_return_type() {
1919        let function = r#"@settings(kclVersion = "3.0-preview")
1920fn valueOrFail(@shouldFail: bool): number {
1921  return if shouldFail {
1922    fail("no value")
1923  } else {
1924    42
1925  }
1926}
1927"#;
1928
1929        parse_execute(&format!("{function}\nresult = valueOrFail(false)\n"))
1930            .await
1931            .unwrap();
1932
1933        let err = parse_execute(&format!("{function}\nvalueOrFail(true)\n"))
1934            .await
1935            .unwrap_err();
1936        assert!(matches!(&err, KclError::UserDefined { .. }));
1937        assert_eq!(err.message(), "no value");
1938    }
1939
1940    #[tokio::test(flavor = "multi_thread")]
1941    async fn never_function_with_fail_or_fallthrough_is_path_dependent() {
1942        let function = r#"@settings(kclVersion = "3.0-preview")
1943fn failOrFallThrough(@shouldFail: bool): never {
1944  result = if shouldFail {
1945    fail("requested failure")
1946  } else {
1947    42
1948  }
1949}
1950"#;
1951
1952        let err = parse_execute(&format!("{function}\nfailOrFallThrough(true)\n"))
1953            .await
1954            .unwrap_err();
1955        assert!(matches!(&err, KclError::UserDefined { .. }));
1956        assert_eq!(err.message(), "requested failure");
1957
1958        let err = parse_execute(&format!("{function}\nfailOrFallThrough(false)\n"))
1959            .await
1960            .unwrap_err();
1961        assert!(matches!(&err, KclError::Type { .. }));
1962        assert_eq!(
1963            err.message(),
1964            "This function completed without returning a value, but its return type is `never`. A function with return type `never` must stop evaluation abnormally. You may want to use `fail(...)` to stop evaluation and provide a message."
1965        );
1966    }
1967
1968    #[tokio::test(flavor = "multi_thread")]
1969    async fn fail_argument_evaluation_errors_take_precedence() {
1970        let program = r#"@settings(kclVersion = "3.0-preview")
1971fn stop(): never {
1972  fail(missingMessage)
1973}
1974
1975stop()
1976"#;
1977
1978        let err = parse_execute(program).await.unwrap_err();
1979
1980        assert!(matches!(&err, KclError::UndefinedValue { .. }));
1981        assert_eq!(err.message(), "`missingMessage` is not defined");
1982        assert_eq!(source_texts(program, &err), ["missingMessage", "stop()"]);
1983    }
1984
1985    #[tokio::test(flavor = "multi_thread")]
1986    async fn fail_rejects_invalid_message_arguments_before_invocation() {
1987        for program in [
1988            "@settings(kclVersion = \"3.0-preview\")\nfail()\n",
1989            "@settings(kclVersion = \"3.0-preview\")\nfail(42)\n",
1990        ] {
1991            let err = parse_execute(program).await.unwrap_err();
1992            assert!(matches!(&err, KclError::Argument { .. }), "{err:?}");
1993        }
1994    }
1995
1996    #[tokio::test(flavor = "multi_thread")]
1997    async fn map_closure_error_mentions_fn_name() {
1998        let program = r#"
1999arr = ["hello"]
2000map(array = arr, f = fn(@item: number) { return item })
2001"#;
2002        let err = parse_execute(program).await.unwrap_err();
2003        assert!(
2004            err.message().contains("map closure"),
2005            "expected map closure errors to include the closure name, got: {}",
2006            err.message()
2007        );
2008    }
2009
2010    #[tokio::test(flavor = "multi_thread")]
2011    async fn array_input_arg() {
2012        let ast = r#"fn f(@input: [mm]) { return 1 }
2013f([1, 2, 3])
2014f(1, 2, 3)
2015"#;
2016        parse_execute(ast).await.unwrap();
2017    }
2018
2019    #[tokio::test(flavor = "multi_thread")]
2020    async fn extrude_tagged_body_gets_face_tags_and_keeps_legacy_bindings() {
2021        let program = r#"@settings(kclVersion = 2.0)
2022profile = sketch(on = XY) {
2023  line1 = line(start = [var 0mm, var 0mm], end = [var 10mm, var 0mm])
2024  line2 = line(start = [var 10mm, var 0mm], end = [var 10mm, var 10mm])
2025  line3 = line(start = [var 10mm, var 10mm], end = [var 0mm, var 10mm])
2026  line4 = line(start = [var 0mm, var 10mm], end = [var 0mm, var 0mm])
2027  coincident([line1.end, line2.start])
2028  coincident([line2.end, line3.start])
2029  coincident([line3.end, line4.start])
2030  coincident([line4.end, line1.start])
2031}
2032region1 = region(point = [5mm, 5mm], sketch = profile)
2033
2034body = extrude(region1, length = 5mm, tagStart = $bottom, tagEnd = $top)
2035bottomFromBody = body.faces.bottom
2036topFromBody = body.faces.top
2037lineFromSketch = region1.tags.line1
2038legacyBottom = bottom
2039legacyTop = top
2040"#;
2041
2042        let result = parse_execute(program).await.unwrap();
2043        assert_body_face_tags(&result, &["bottom", "top"], &["line1"]);
2044        assert_vars_are_tags(
2045            &result,
2046            &[
2047                "bottom",
2048                "top",
2049                "bottomFromBody",
2050                "topFromBody",
2051                "lineFromSketch",
2052                "legacyBottom",
2053                "legacyTop",
2054            ],
2055        );
2056        assert_vars_are_missing(&result, &["line1"]);
2057    }
2058
2059    #[tokio::test(flavor = "multi_thread")]
2060    async fn extrude_without_tag_arguments_does_not_get_face_tags() {
2061        let program = r#"@settings(kclVersion = 2.0)
2062profile = sketch(on = XY) {
2063  line1 = line(start = [var 0mm, var 0mm], end = [var 10mm, var 0mm])
2064  line2 = line(start = [var 10mm, var 0mm], end = [var 10mm, var 10mm])
2065  line3 = line(start = [var 10mm, var 10mm], end = [var 0mm, var 10mm])
2066  line4 = line(start = [var 0mm, var 10mm], end = [var 0mm, var 0mm])
2067  coincident([line1.end, line2.start])
2068  coincident([line2.end, line3.start])
2069  coincident([line3.end, line4.start])
2070  coincident([line4.end, line1.start])
2071}
2072region1 = region(point = [5mm, 5mm], sketch = profile)
2073
2074body = extrude(region1, length = 5mm)
2075"#;
2076
2077        let result = parse_execute(program).await.unwrap();
2078        let body = get_var(&result, "body");
2079        let KclValue::Solid { value: body } = body else {
2080            panic!("expected `body` to be a solid");
2081        };
2082
2083        assert!(
2084            body.faces.is_empty(),
2085            "body faces should only be populated for tagged calls"
2086        );
2087    }
2088
2089    #[tokio::test(flavor = "multi_thread")]
2090    async fn revolve_tagged_body_gets_face_tags() {
2091        let program = r#"@settings(kclVersion = 2.0)
2092profile = sketch(on = XY) {
2093  side = line(start = [var 5mm, var 0mm], end = [var 5mm, var 10mm])
2094  line2 = line(start = [var 5mm, var 10mm], end = [var 6mm, var 10mm])
2095  line3 = line(start = [var 6mm, var 10mm], end = [var 6mm, var 0mm])
2096  line4 = line(start = [var 6mm, var 0mm], end = [var 5mm, var 0mm])
2097  coincident([side.end, line2.start])
2098  coincident([line2.end, line3.start])
2099  coincident([line3.end, line4.start])
2100  coincident([line4.end, side.start])
2101}
2102region1 = region(point = [5.5mm, 5mm], sketch = profile)
2103
2104body = revolve(region1, axis = Y, angle = 90deg, tagStart = $startCap, tagEnd = $endCap)
2105startFromBody = body.faces.startCap
2106endFromBody = body.faces.endCap
2107sideFromSketch = region1.tags.side
2108legacyStart = startCap
2109legacyEnd = endCap
2110"#;
2111
2112        let result = parse_execute(program).await.unwrap();
2113        assert_body_face_tags(&result, &["startCap", "endCap"], &["side"]);
2114        assert_vars_are_tags(
2115            &result,
2116            &[
2117                "startCap",
2118                "endCap",
2119                "startFromBody",
2120                "endFromBody",
2121                "sideFromSketch",
2122                "legacyStart",
2123                "legacyEnd",
2124            ],
2125        );
2126        assert_vars_are_missing(&result, &["side"]);
2127    }
2128
2129    #[tokio::test(flavor = "multi_thread")]
2130    async fn sweep_tagged_body_gets_face_tags() {
2131        let program = r#"@settings(kclVersion = 2.0)
2132profile = sketch(on = XZ) {
2133  edge1 = line(start = [var 0mm, var 0mm], end = [var 2mm, var 0mm])
2134  edge2 = line(start = [var 2mm, var 0mm], end = [var 2mm, var 2mm])
2135  edge3 = line(start = [var 2mm, var 2mm], end = [var 0mm, var 2mm])
2136  edge4 = line(start = [var 0mm, var 2mm], end = [var 0mm, var 0mm])
2137  coincident([edge1.end, edge2.start])
2138  coincident([edge2.end, edge3.start])
2139  coincident([edge3.end, edge4.start])
2140  coincident([edge4.end, edge1.start])
2141}
2142profileRegion = region(point = [1mm, 1mm], sketch = profile)
2143
2144pathSketch = sketch(on = offsetPlane(YZ, offset = -2mm)) {
2145  pathLine = line(start = [var 0mm, var 0mm], end = [var 0mm, var 5mm])
2146}
2147
2148body = sweep(profileRegion, path = pathSketch.pathLine, tagStart = $startCap, tagEnd = $endCap)
2149startFromBody = body.faces.startCap
2150endFromBody = body.faces.endCap
2151edgeFromSketch = profileRegion.tags.edge1
2152pathFromSketch = pathSketch.pathLine
2153legacyStart = startCap
2154legacyEnd = endCap
2155"#;
2156
2157        let result = parse_execute(program).await.unwrap();
2158        assert_body_face_tags(&result, &["startCap", "endCap"], &["edge1", "pathLine"]);
2159        assert_vars_are_tags(
2160            &result,
2161            &[
2162                "startCap",
2163                "endCap",
2164                "startFromBody",
2165                "endFromBody",
2166                "edgeFromSketch",
2167                "legacyStart",
2168                "legacyEnd",
2169            ],
2170        );
2171        assert_vars_are_missing(&result, &["edge1", "pathLine"]);
2172    }
2173
2174    #[tokio::test(flavor = "multi_thread")]
2175    async fn loft_tagged_body_gets_face_tags() {
2176        let program = r#"@settings(kclVersion = 2.0)
2177lowerProfile = sketch(on = XY) {
2178  edge1 = line(start = [var 0mm, var 0mm], end = [var 6mm, var 0mm])
2179  edge2 = line(start = [var 6mm, var 0mm], end = [var 6mm, var 4mm])
2180  edge3 = line(start = [var 6mm, var 4mm], end = [var 0mm, var 4mm])
2181  edge4 = line(start = [var 0mm, var 4mm], end = [var 0mm, var 0mm])
2182  coincident([edge1.end, edge2.start])
2183  coincident([edge2.end, edge3.start])
2184  coincident([edge3.end, edge4.start])
2185  coincident([edge4.end, edge1.start])
2186}
2187lowerRegion = region(point = [3mm, 2mm], sketch = lowerProfile)
2188
2189upperProfile = sketch(on = offsetPlane(XY, offset = 8mm)) {
2190  edge5 = line(start = [var 1mm, var 1mm], end = [var 5mm, var 1mm])
2191  edge6 = line(start = [var 5mm, var 1mm], end = [var 4mm, var 3mm])
2192  edge7 = line(start = [var 4mm, var 3mm], end = [var 2mm, var 3mm])
2193  edge8 = line(start = [var 2mm, var 3mm], end = [var 1mm, var 1mm])
2194  coincident([edge5.end, edge6.start])
2195  coincident([edge6.end, edge7.start])
2196  coincident([edge7.end, edge8.start])
2197  coincident([edge8.end, edge5.start])
2198}
2199upperRegion = region(point = [3mm, 2mm], sketch = upperProfile)
2200
2201body = loft([lowerRegion, upperRegion], tagStart = $startCap, tagEnd = $endCap)
2202startFromBody = body.faces.startCap
2203endFromBody = body.faces.endCap
2204edgeFromSketch = lowerRegion.tags.edge1
2205legacyStart = startCap
2206legacyEnd = endCap
2207"#;
2208
2209        let result = parse_execute(program).await.unwrap();
2210        assert_body_face_tags(&result, &["startCap", "endCap"], &["edge1"]);
2211        assert_vars_are_tags(
2212            &result,
2213            &[
2214                "startCap",
2215                "endCap",
2216                "startFromBody",
2217                "endFromBody",
2218                "edgeFromSketch",
2219                "legacyStart",
2220                "legacyEnd",
2221            ],
2222        );
2223        assert_vars_are_missing(&result, &["edge1"]);
2224    }
2225
2226    #[tokio::test(flavor = "multi_thread")]
2227    async fn chamfer_tagged_body_gets_face_tags() {
2228        let program = r#"@settings(kclVersion = 2.0)
2229profile = sketch(on = XY) {
2230  edge1 = line(start = [var 0mm, var 0mm], end = [var 10mm, var 0mm])
2231  edge2 = line(start = [var 10mm, var 0mm], end = [var 10mm, var 10mm])
2232  edge3 = line(start = [var 10mm, var 10mm], end = [var 0mm, var 10mm])
2233  edge4 = line(start = [var 0mm, var 10mm], end = [var 0mm, var 0mm])
2234  coincident([edge1.end, edge2.start])
2235  coincident([edge2.end, edge3.start])
2236  coincident([edge3.end, edge4.start])
2237  coincident([edge4.end, edge1.start])
2238}
2239profileRegion = region(point = [5mm, 5mm], sketch = profile)
2240
2241base = extrude(profileRegion, length = 5mm, tagEnd = $top)
2242body = chamfer(base, tags = getCommonEdge(faces = [profileRegion.tags.edge1, top]), length = 1mm, tag = $chamferFace)
2243chamferFromBody = body.faces.chamferFace
2244topFromBody = body.faces.top
2245edgeFromSketch = profileRegion.tags.edge1
2246legacyChamfer = chamferFace
2247legacyTop = top
2248"#;
2249
2250        let result = parse_execute(program).await.unwrap();
2251        assert_body_face_tags(&result, &["top", "chamferFace"], &["edge1"]);
2252        assert_vars_are_tags(
2253            &result,
2254            &[
2255                "top",
2256                "chamferFace",
2257                "chamferFromBody",
2258                "topFromBody",
2259                "edgeFromSketch",
2260                "legacyChamfer",
2261                "legacyTop",
2262            ],
2263        );
2264        assert_vars_are_missing(&result, &["edge1"]);
2265    }
2266
2267    #[tokio::test(flavor = "multi_thread")]
2268    async fn fillet_tagged_body_gets_face_tags() {
2269        let program = r#"@settings(kclVersion = 2.0)
2270profile = sketch(on = XY) {
2271  edge1 = line(start = [var 0mm, var 0mm], end = [var 10mm, var 0mm])
2272  edge2 = line(start = [var 10mm, var 0mm], end = [var 10mm, var 10mm])
2273  edge3 = line(start = [var 10mm, var 10mm], end = [var 0mm, var 10mm])
2274  edge4 = line(start = [var 0mm, var 10mm], end = [var 0mm, var 0mm])
2275  coincident([edge1.end, edge2.start])
2276  coincident([edge2.end, edge3.start])
2277  coincident([edge3.end, edge4.start])
2278  coincident([edge4.end, edge1.start])
2279}
2280profileRegion = region(point = [5mm, 5mm], sketch = profile)
2281
2282base = extrude(profileRegion, length = 5mm, tagEnd = $top)
2283body = fillet(base, tags = getCommonEdge(faces = [profileRegion.tags.edge1, top]), radius = 1mm, tag = $filletFace)
2284filletFromBody = body.faces.filletFace
2285topFromBody = body.faces.top
2286edgeFromSketch = profileRegion.tags.edge1
2287legacyFillet = filletFace
2288legacyTop = top
2289"#;
2290
2291        let result = parse_execute(program).await.unwrap();
2292        assert_body_face_tags(&result, &["top", "filletFace"], &["edge1"]);
2293        assert_vars_are_tags(
2294            &result,
2295            &[
2296                "top",
2297                "filletFace",
2298                "filletFromBody",
2299                "topFromBody",
2300                "edgeFromSketch",
2301                "legacyFillet",
2302                "legacyTop",
2303            ],
2304        );
2305        assert_vars_are_missing(&result, &["edge1"]);
2306    }
2307
2308    #[tokio::test(flavor = "multi_thread")]
2309    async fn accessing_body_tag_through_body_sketch_tags_warns() {
2310        let program = r#"@settings(kclVersion = 2.0)
2311profile = startSketchOn(XY)
2312  |> startProfile(at = [0, 0])
2313  |> line(end = [10, 0], tag = $line1)
2314  |> line(end = [0, 10])
2315  |> line(end = [-10, 0])
2316  |> close()
2317
2318body = extrude(profile, length = 5, tagEnd = $top)
2319topFromSketch = body.sketch.tags.top
2320topFromBody = body.faces.top
2321"#;
2322
2323        let result = parse_execute(program).await.unwrap();
2324        assert!(matches!(get_var(&result, "topFromSketch"), KclValue::TagIdentifier(_)));
2325        assert!(matches!(get_var(&result, "topFromBody"), KclValue::TagIdentifier(_)));
2326
2327        let warnings = deprecated_solid_tag_access_warnings(&result);
2328        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2329        assert_eq!(warnings[0].severity, Severity::Warning);
2330        assert!(warnings[0].message.contains("`top`"), "found {}", warnings[0].message);
2331        assert!(
2332            warnings[0].message.contains("Accessing solid-created face `top` through sketch tags is deprecated. Use the body's faces instead, e.g. `body.faces.top`."),
2333            "found {}",
2334            warnings[0].message
2335        );
2336    }
2337
2338    #[tokio::test(flavor = "multi_thread")]
2339    async fn accessing_sketch_path_tag_through_body_sketch_tags_does_not_warn() {
2340        let program = r#"@settings(kclVersion = 2.0)
2341profile = startSketchOn(XY)
2342  |> startProfile(at = [0, 0])
2343  |> line(end = [10, 0], tag = $line1)
2344  |> line(end = [0, 10])
2345  |> line(end = [-10, 0])
2346  |> close()
2347
2348body = extrude(profile, length = 5, tagEnd = $top)
2349lineFromSketch = body.sketch.tags.line1
2350"#;
2351
2352        let result = parse_execute(program).await.unwrap();
2353        assert!(matches!(get_var(&result, "lineFromSketch"), KclValue::TagIdentifier(_)));
2354        let warnings = deprecated_solid_tag_access_warnings(&result);
2355        assert!(
2356            warnings.is_empty(),
2357            "sketch path tags should not get body-tag deprecation warnings: {warnings:#?}"
2358        );
2359    }
2360
2361    #[tokio::test(flavor = "multi_thread")]
2362    async fn accessing_body_tag_through_sketch_block_region_tags_warns() {
2363        let program = r#"@settings(kclVersion = 2.0)
2364profile = sketch(on = XY) {
2365  line1 = line(start = [0, 0], end = [10, 0])
2366  line2 = line(start = [10, 0], end = [10, 10])
2367  line3 = line(start = [10, 10], end = [0, 10])
2368  line4 = line(start = [0, 10], end = [0, 0])
2369}
2370
2371profileRegion = region(point = [1, 1], sketch = profile)
2372body = extrude(profileRegion, length = 5, tagEnd = $top)
2373topFromRegion = profileRegion.tags.top
2374"#;
2375
2376        let result = parse_execute(program).await.unwrap();
2377        assert!(matches!(get_var(&result, "topFromRegion"), KclValue::TagIdentifier(_)));
2378
2379        let warnings = deprecated_solid_tag_access_warnings(&result);
2380        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2381        assert_eq!(warnings[0].severity, Severity::Warning);
2382        assert!(warnings[0].message.contains("`top`"), "found {}", warnings[0].message);
2383    }
2384
2385    fn deprecation_warnings(result: &ExecTestResults) -> Vec<&CompilationIssue> {
2386        result
2387            .exec_state
2388            .issues()
2389            .iter()
2390            .filter(|issue| issue.message.contains("is deprecated"))
2391            .collect()
2392    }
2393
2394    #[tokio::test(flavor = "multi_thread")]
2395    async fn passing_param_deprecated_for_all_versions_warns() {
2396        // `@(deprecated = true)` deprecates the parameter regardless of the KCL
2397        // version, so even on the latest version the call should warn.
2398        let program = r#"@settings(kclVersion = 2.0)
2399fn f(
2400  @a: number,
2401  @(deprecated = true)
2402  oldArg?: number,
2403) {
2404  return a
2405}
2406x = f(1, oldArg = 2)
2407"#;
2408
2409        let result = parse_execute(program).await.unwrap();
2410        let warnings = deprecation_warnings(&result);
2411        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2412        assert_eq!(warnings[0].severity, Severity::Warning);
2413        assert_eq!(warnings[0].tag, crate::errors::Tag::Deprecated);
2414        assert!(
2415            warnings[0].message.contains("`f(oldArg)` is deprecated"),
2416            "found {}",
2417            warnings[0].message
2418        );
2419    }
2420
2421    #[tokio::test(flavor = "multi_thread")]
2422    async fn not_passing_deprecated_param_does_not_warn() {
2423        let program = r#"fn f(
2424  @a: number,
2425  @(deprecated = true)
2426  oldArg?: number,
2427) {
2428  return a
2429}
2430x = f(1)
2431"#;
2432
2433        let result = parse_execute(program).await.unwrap();
2434        let warnings = deprecation_warnings(&result);
2435        assert!(
2436            warnings.is_empty(),
2437            "unused deprecated parameter should not warn: {warnings:#?}"
2438        );
2439    }
2440
2441    fn unexpected_arg_errors(result: &ExecTestResults) -> Vec<&CompilationIssue> {
2442        result
2443            .exec_state
2444            .issues()
2445            .iter()
2446            .filter(|issue| issue.message.contains("is not an argument of"))
2447            .collect()
2448    }
2449
2450    #[tokio::test(flavor = "multi_thread")]
2451    async fn passing_removed_param_on_removed_version_errors_like_unknown_arg() {
2452        // "3.0-preview" is a pre-release of 3.0, so a parameter removed in
2453        // 3.0 is already gone there.
2454        let program = r#"@settings(kclVersion = "3.0-preview")
2455fn f(
2456  @a: number,
2457  @(deprecated_since = "2.0", removed_in = "3.0")
2458  oldArg?: number,
2459) {
2460  return a
2461}
2462x = f(1, oldArg = 2)
2463"#;
2464
2465        let result = parse_execute(program).await.unwrap();
2466        let errors = unexpected_arg_errors(&result);
2467        assert_eq!(
2468            errors.len(),
2469            1,
2470            "expected one unknown-argument error, got {:#?}",
2471            result.issues()
2472        );
2473        assert_eq!(errors[0].severity, Severity::Error);
2474        // Same path as an unknown argument, plus the two versions that explain
2475        // the mismatch.
2476        assert_eq!(
2477            errors[0].message,
2478            "`oldArg` is not an argument of `f`; it was removed in KCL 3.0, but this program uses KCL 3.0-preview"
2479        );
2480        // The error replaces the deprecation warning rather than adding to it.
2481        assert!(
2482            deprecation_warnings(&result).is_empty(),
2483            "removed parameter should not also warn: {:#?}",
2484            result.issues()
2485        );
2486        // Execution continues as if the argument had not been passed.
2487        assert!(matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 1.0));
2488    }
2489
2490    #[tokio::test(flavor = "multi_thread")]
2491    async fn passing_removed_param_before_removed_version_still_works() {
2492        let program = r#"@settings(kclVersion = 2.0)
2493fn f(
2494  @a: number,
2495  @(deprecated_since = "2.0", removed_in = "3.0")
2496  oldArg?: number,
2497) {
2498  return oldArg
2499}
2500x = f(1, oldArg = 2)
2501"#;
2502
2503        let result = parse_execute(program).await.unwrap();
2504        assert!(
2505            unexpected_arg_errors(&result).is_empty(),
2506            "parameter is not removed until 3.0: {:#?}",
2507            result.issues()
2508        );
2509        let warnings = deprecation_warnings(&result);
2510        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2511        assert!(
2512            warnings[0].message.contains("`f(oldArg)` is deprecated as of KCL 2.0"),
2513            "found {}",
2514            warnings[0].message
2515        );
2516        assert!(matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 2.0));
2517    }
2518
2519    #[tokio::test(flavor = "multi_thread")]
2520    async fn removed_optional_param_binds_its_default() {
2521        let program = r#"@settings(kclVersion = "3.0-preview")
2522fn f(
2523  @(removed_in = "3.0")
2524  oldArg?: number = 7,
2525) {
2526  return oldArg
2527}
2528x = f()
2529"#;
2530
2531        let result = parse_execute(program).await.unwrap();
2532        assert!(result.issues().is_empty(), "unexpected issues: {:#?}", result.issues());
2533        assert!(matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 7.0));
2534    }
2535
2536    #[tokio::test(flavor = "multi_thread")]
2537    async fn removed_param_is_not_matched_by_label_shorthand() {
2538        // Before 3.0, `f(oldArg)` desugars to `f(oldArg = oldArg)`. Once the
2539        // parameter is removed, the argument is just an unlabeled argument the
2540        // function does not accept, and the removed parameter must not be
2541        // suggested as a label.
2542        let program = r#"@settings(kclVersion = "3.0-preview")
2543fn f(
2544  @(removed_in = "3.0")
2545  oldArg?: number,
2546) {
2547  return 1
2548}
2549oldArg = 2
2550x = f(oldArg)
2551"#;
2552
2553        let err = parse_execute(program).await.unwrap_err();
2554        assert_eq!(err.message(), "This argument needs a label, but it doesn't have one");
2555    }
2556
2557    #[tokio::test(flavor = "multi_thread")]
2558    async fn passing_not_yet_added_param_errors_like_unknown_arg() {
2559        let program = r#"@settings(kclVersion = 2.0)
2560fn f(
2561  @a: number,
2562  @(added_in = "3.0")
2563  newArg?: number,
2564) {
2565  return a
2566}
2567x = f(1, newArg = 2)
2568"#;
2569
2570        let result = parse_execute(program).await.unwrap();
2571        let errors = unexpected_arg_errors(&result);
2572        assert_eq!(
2573            errors.len(),
2574            1,
2575            "expected one unknown-argument error, got {:#?}",
2576            result.issues()
2577        );
2578        assert_eq!(errors[0].severity, Severity::Error);
2579        assert_eq!(
2580            errors[0].message,
2581            "`newArg` is not an argument of `f`; it was added in KCL 3.0, but this program uses KCL 2.0"
2582        );
2583        // Execution continues as if the argument had not been passed.
2584        assert!(matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 1.0));
2585    }
2586
2587    #[tokio::test(flavor = "multi_thread")]
2588    async fn not_yet_added_param_error_reports_default_kcl_version() {
2589        // No `@settings(kclVersion = ...)`, so the program runs on the
2590        // default version, and the message says which one that is.
2591        let program = r#"fn f(
2592  @(added_in = "2.0")
2593  newArg?: number,
2594) {
2595  return 1
2596}
2597x = f(newArg = 2)
2598"#;
2599
2600        let result = parse_execute(program).await.unwrap();
2601        let errors = unexpected_arg_errors(&result);
2602        assert_eq!(errors.len(), 1, "got {:#?}", result.issues());
2603        assert_eq!(
2604            errors[0].message,
2605            "`newArg` is not an argument of `f`; it was added in KCL 2.0, but this program uses KCL 1.0"
2606        );
2607    }
2608
2609    #[tokio::test(flavor = "multi_thread")]
2610    async fn passing_added_param_on_or_after_added_version_works() {
2611        // The boundary is inclusive, and a pre-release such as "3.0-preview"
2612        // counts as the release it precedes.
2613        for (kcl_version, added_in) in [("2.0", "1.0"), ("2.0", "2.0"), ("\"3.0-preview\"", "3.0")] {
2614            let program = format!(
2615                r#"@settings(kclVersion = {kcl_version})
2616fn f(
2617  @(added_in = "{added_in}")
2618  newArg?: number,
2619) {{
2620  return newArg
2621}}
2622x = f(newArg = 2)
2623"#
2624            );
2625
2626            let result = parse_execute(&program).await.unwrap();
2627            assert!(
2628                result.issues().is_empty(),
2629                "kclVersion {kcl_version}, added_in {added_in}: {:#?}",
2630                result.issues()
2631            );
2632            assert!(
2633                matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 2.0),
2634                "kclVersion {kcl_version}, added_in {added_in}"
2635            );
2636        }
2637    }
2638
2639    #[tokio::test(flavor = "multi_thread")]
2640    async fn not_yet_added_optional_param_binds_its_default() {
2641        let program = r#"@settings(kclVersion = 2.0)
2642fn f(
2643  @(added_in = "3.0")
2644  newArg?: number = 7,
2645) {
2646  return newArg
2647}
2648x = f()
2649"#;
2650
2651        let result = parse_execute(program).await.unwrap();
2652        assert!(result.issues().is_empty(), "unexpected issues: {:#?}", result.issues());
2653        assert!(matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 7.0));
2654    }
2655
2656    #[tokio::test(flavor = "multi_thread")]
2657    async fn not_yet_added_param_is_not_matched_by_label_shorthand() {
2658        // Once the parameter exists, `f(newArg)` desugars to
2659        // `f(newArg = newArg)`. Before that, the argument is just an unlabeled
2660        // argument the function does not accept, and the parameter must not
2661        // be suggested as a label.
2662        let program = r#"@settings(kclVersion = 2.0)
2663fn f(
2664  @(added_in = "3.0")
2665  newArg?: number,
2666) {
2667  return 1
2668}
2669newArg = 2
2670x = f(newArg)
2671"#;
2672
2673        let err = parse_execute(program).await.unwrap_err();
2674        assert_eq!(err.message(), "This argument needs a label, but it doesn't have one");
2675    }
2676
2677    #[tokio::test(flavor = "multi_thread")]
2678    async fn param_lifecycle_added_then_deprecated_then_removed() {
2679        let body = r#"fn f(
2680  @(added_in = "2.0", deprecated_since = "2.0", removed_in = "3.0")
2681  arg?: number,
2682) {
2683  return arg
2684}
2685x = f(arg = 2)
2686"#;
2687        for (kcl_version, expected_error) in [
2688            (
2689                "1.0",
2690                Some("`arg` is not an argument of `f`; it was added in KCL 2.0, but this program uses KCL 1.0"),
2691            ),
2692            ("2.0", None),
2693            (
2694                "\"3.0-preview\"",
2695                Some(
2696                    "`arg` is not an argument of `f`; it was removed in KCL 3.0, but this program uses KCL 3.0-preview",
2697                ),
2698            ),
2699        ] {
2700            let program = format!("@settings(kclVersion = {kcl_version})\n{body}");
2701            let result = parse_execute(&program).await.unwrap();
2702            let errors = unexpected_arg_errors(&result);
2703            match expected_error {
2704                Some(message) => {
2705                    assert_eq!(errors.len(), 1, "kclVersion {kcl_version}: {:#?}", result.issues());
2706                    assert_eq!(errors[0].message, message, "kclVersion {kcl_version}");
2707                    assert!(
2708                        deprecation_warnings(&result).is_empty(),
2709                        "kclVersion {kcl_version}: an unavailable parameter should not also warn: {:#?}",
2710                        result.issues()
2711                    );
2712                }
2713                None => {
2714                    assert!(errors.is_empty(), "kclVersion {kcl_version}: {:#?}", result.issues());
2715                    // Available and deprecated on this version.
2716                    assert_eq!(
2717                        deprecation_warnings(&result).len(),
2718                        1,
2719                        "kclVersion {kcl_version}: {:#?}",
2720                        result.issues()
2721                    );
2722                    assert!(
2723                        matches!(get_var(&result, "x"), KclValue::Number { value, .. } if value == 2.0),
2724                        "kclVersion {kcl_version}"
2725                    );
2726                }
2727            }
2728        }
2729    }
2730
2731    #[tokio::test(flavor = "multi_thread")]
2732    async fn stdlib_legacy_method_is_removed_in_kcl_3() {
2733        let solids = r#"left = startSketchOn(XY)
2734  |> circle(center = [0, 0], radius = 2)
2735  |> extrude(length = 1)
2736right = startSketchOn(XY)
2737  |> circle(center = [1, 0], radius = 2)
2738  |> extrude(length = 1)
2739both = union([left, right], legacyMethod = true)
2740"#;
2741
2742        let program = format!("@settings(kclVersion = \"3.0-preview\")\n{solids}");
2743        let result = parse_execute(&program).await.unwrap();
2744        let errors = unexpected_arg_errors(&result);
2745        assert_eq!(errors.len(), 1, "got {:#?}", result.issues());
2746        assert_eq!(
2747            errors[0].message,
2748            "`legacyMethod` is not an argument of `union`; it was removed in KCL 3.0, but this program uses KCL 3.0-preview"
2749        );
2750
2751        // Still accepted, with a deprecation warning, before KCL 3.0.
2752        let program = format!("@settings(kclVersion = 2.0)\n{solids}");
2753        let result = parse_execute(&program).await.unwrap();
2754        assert!(unexpected_arg_errors(&result).is_empty(), "got {:#?}", result.issues());
2755        assert!(
2756            deprecation_warnings(&result)
2757                .iter()
2758                .any(|w| w.message.contains("`union(legacyMethod)` is deprecated as of KCL 2.0")),
2759            "got {:#?}",
2760            result.issues()
2761        );
2762    }
2763
2764    #[tokio::test(flavor = "multi_thread")]
2765    async fn deprecated_calls_inside_kcl_stdlib_do_not_warn() {
2766        let program = include_str!("../../tests/cube_with_hole/input.kcl");
2767
2768        let result = parse_execute(program).await.unwrap();
2769        let warnings = deprecation_warnings(&result);
2770        assert!(
2771            warnings.is_empty(),
2772            "KCL stdlib internals should not emit deprecation warnings: {warnings:#?}"
2773        );
2774    }
2775
2776    #[tokio::test(flavor = "multi_thread")]
2777    async fn deprecated_stdlib_call_from_user_code_still_warns() {
2778        let program = r#"@settings(kclVersion = 2.0)
2779plane = startSketchOn(XY)
2780"#;
2781
2782        let result = parse_execute(program).await.unwrap();
2783        let warnings = deprecation_warnings(&result);
2784        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2785        assert!(
2786            warnings[0].message.contains("`startSketchOn` is deprecated"),
2787            "found {}",
2788            warnings[0].message
2789        );
2790        assert_eq!(warnings[0].tag, crate::errors::Tag::Deprecated);
2791    }
2792
2793    #[tokio::test(flavor = "multi_thread")]
2794    async fn deprecated_since_warns_for_prerelease_kcl_version() {
2795        let program = r#"@settings(kclVersion = "3.0-preview")
2796plane = startSketchOn(XY)
2797"#;
2798
2799        let result = parse_execute(program).await.unwrap();
2800        let warnings = deprecation_warnings(&result);
2801        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2802        assert_eq!(warnings[0].severity, Severity::Warning);
2803        assert_eq!(warnings[0].tag, crate::errors::Tag::Deprecated);
2804        assert!(
2805            warnings[0]
2806                .message
2807                .contains("`startSketchOn` is deprecated as of KCL 2.0"),
2808            "found {}",
2809            warnings[0].message
2810        );
2811    }
2812
2813    #[tokio::test(flavor = "multi_thread")]
2814    async fn deprecation_version_override_does_not_change_program_version() {
2815        let program = crate::Program::parse_no_errs(
2816            r#"@settings(kclVersion = 1.0)
2817plane = startSketchOn(XY)
2818"#,
2819        )
2820        .unwrap();
2821        let exec_ctxt = ExecutorContext {
2822            engine: Arc::new(EngineManager::new_mock()),
2823            engine_batch: crate::engine::EngineBatchContext::default(),
2824            fs: crate::fs::new_file_system_handle(crate::fs::FileManager::new()),
2825            settings: Default::default(),
2826            context_type: ContextType::Mock,
2827            execution_callbacks: Default::default(),
2828            executor_kind: crate::execution::machine::ExecutorKind::resolve(),
2829            machine_call_depth_limit: crate::execution::machine::DEFAULT_MACHINE_CALL_DEPTH_LIMIT,
2830        };
2831        let mut exec_state = ExecState::new(&exec_ctxt);
2832        exec_state.set_deprecation_version_override(Some("2.0"));
2833
2834        exec_ctxt.run(&program, &mut exec_state).await.unwrap();
2835
2836        assert_eq!(exec_state.mod_local.settings.kcl_version, crate::KclVersion::V1);
2837        let warnings = exec_state
2838            .issues()
2839            .iter()
2840            .filter(|issue| issue.tag == crate::errors::Tag::Deprecated)
2841            .collect::<Vec<_>>();
2842        assert_eq!(warnings.len(), 1, "expected one deprecation warning, got {warnings:#?}");
2843    }
2844
2845    #[tokio::test(flavor = "multi_thread")]
2846    async fn deprecated_sketch_v1_warning_explains_sketch_solve() {
2847        // Sketch v1 deprecation warnings must be self-contained: they should
2848        // say what replaces the function and link the conversion docs so both
2849        // humans and AI agents can act on the warning alone.
2850        let program = r#"@settings(kclVersion = 2.0)
2851exampleSketch = startSketchOn(XZ)
2852  |> startProfile(at = [0, 0])
2853  |> line(end = [10, 0])
2854"#;
2855
2856        let result = parse_execute(program).await.unwrap();
2857        let warnings = deprecation_warnings(&result);
2858        assert_eq!(
2859            warnings.len(),
2860            3,
2861            "expected one warning per sketch v1 call, got {warnings:#?}"
2862        );
2863        for warning in warnings {
2864            assert!(
2865                warning.message.contains("sketch-solve"),
2866                "expected sketch-solve context in {}",
2867                warning.message
2868            );
2869            assert!(
2870                warning
2871                    .message
2872                    .contains("https://zoo.dev/docs/kcl-book/sketch2d_constraints.html"),
2873                "expected docs URL in {}",
2874                warning.message
2875            );
2876        }
2877    }
2878}