kanade_shared/

kv.rs

//! NATS KV bucket name + key helpers (spec §2.3.2).
//!
//! NATS KV bucket names must be domain-safe ASCII (a-z, A-Z, 0-9, _, -),
//! so the spec's dotted names (`script.current`, `script.status`) are
//! flattened to underscore form here.

pub const BUCKET_SCRIPT_CURRENT: &str = "script_current";
pub const BUCKET_SCRIPT_STATUS: &str = "script_status";
pub const BUCKET_AGENTS_STATE: &str = "agents_state";
pub const BUCKET_AGENT_CONFIG: &str = "agent_config";
pub const BUCKET_AGENT_GROUPS: &str = "agent_groups";

/// `agent_meta` — per-PC operator-managed free-form key/value
/// annotations (the primary user's name / email / department, an ad-hoc
/// note), keyed by `pc_id`, value JSON
/// [`AgentMeta`](crate::wire::AgentMeta). Durable operator metadata —
/// distinct from the volatile `agents` heartbeat projection and from
/// `agent_groups` membership. Edited via the SPA agent detail page or the
/// `kanade meta` CLI (and typically bulk-populated by an operator AD-sync
/// job that resolves the last-logon user's directory attributes).
pub const BUCKET_AGENT_META: &str = "agent_meta";

/// `group_contacts` — per-group notification email addresses, keyed by
/// group name, value JSON [`GroupContacts`](crate::wire::GroupContacts).
/// Operator-managed via the SPA Groups page. Distinct from
/// `agent_groups` (per-PC membership) and `agent_config`'s `groups.*`
/// scopes (agent config pushed to machines): this is operator contact
/// info, read backend-side to fan a compliance alert out to email.
pub const BUCKET_GROUP_CONTACTS: &str = "group_contacts";

pub const BUCKET_SCHEDULES: &str = "schedules";

/// Job catalog (v0.15) — operator-registered Manifests, keyed by
/// `manifest.id`. Schedules and ad-hoc `kanade run --job-id ...` look
/// jobs up here; the wire never round-trips an inline Manifest body
/// through a Schedule again. Editing a job in-place retroactively
/// changes what future schedule fires deploy.
pub const BUCKET_JOBS: &str = "jobs";

/// Parallel "operator source-of-truth YAML" stores keyed identically
/// to `BUCKET_JOBS` / `BUCKET_SCHEDULES`. The agent / scheduler /
/// projector all keep reading the JSON KVs above — these buckets
/// exist only so the SPA's YAML editor can round-trip operator
/// comments + script indentation + block-scalar style exactly.
///
/// Population is opportunistic: any `POST` with a
/// `Content-Type: application/yaml` body stores the raw bytes here
/// alongside the parsed JSON; JSON-content-type POSTs fall back to a
/// `serde_yaml` dump so the buckets stay in lockstep with the JSON
/// store (operator just loses comments on that path).
pub const BUCKET_JOBS_YAML: &str = "jobs_yaml";
pub const BUCKET_SCHEDULES_YAML: &str = "schedules_yaml";

/// View catalog (#743) — operator-registered [`View`](crate::manifest::View)
/// resources, keyed by `view.id`. A view is a pure, declarative
/// read/aggregation over stored fleet data (`obs_events`, …) for the
/// Analytics page — no `execute`, no schedule. The backend reads these at
/// query time and merges their widgets with the co-located `aggregate:`
/// hints on jobs. Distinct from `BUCKET_JOBS` so a cross-cutting dashboard
/// doesn't need a noop job carrier.
pub const BUCKET_VIEWS: &str = "views";
/// Operator source-of-truth YAML mirror for `BUCKET_VIEWS` (same role as
/// `BUCKET_JOBS_YAML`): keeps comments/formatting for the SPA editor.
pub const BUCKET_VIEWS_YAML: &str = "views_yaml";

/// Fleet-wide singleton settings that aren't per-agent (so they don't
/// belong in `agent_config`'s layered scopes) and aren't per-schedule
/// (so they don't belong in `schedules`). First and only key so far is
/// [`KEY_FREEZE`] (#418 Phase 5 global change-freeze). One small bucket
/// both the backend scheduler and every agent's local scheduler watch.
pub const BUCKET_FLEET_CONFIG: &str = "fleet_config";

/// Backend-side, operator-editable server settings that aren't per-agent
/// (so they don't belong in `agent_config`'s layered scopes) and aren't a
/// fleet-wide switch every agent watches (so they don't belong in
/// `fleet_config`). A single JSON document under [`KEY_SERVER_SETTINGS`]
/// holding [`crate::wire::ServerSettings`], managed via the SPA Settings
/// page's "server settings" tab. Deliberately generic: future server-side
/// knobs join the same document rather than spawning a bucket each. First
/// consumer is the cleanup task's dead-agent prune window
/// (`ServerSettings::agent_prune_days`). `history: 1` — only the current
/// state matters; nothing replays its history.
pub const BUCKET_SERVER_SETTINGS: &str = "server_settings";

/// Singleton key in [`BUCKET_SERVER_SETTINGS`] holding the JSON-encoded
/// [`crate::wire::ServerSettings`]. **Key absent ⇒ all-default settings**
/// (e.g. `agent_prune_days = 0`, pruning disabled), so a fresh deployment
/// behaves exactly as it did before the bucket existed.
pub const KEY_SERVER_SETTINGS: &str = "current";

/// `notifications_read` — per-user read/ack state for end-user
/// notifications (SPEC §2.3.2 / Phase E). Key shape
/// `{pc_id}.{user_sid}.{notification_id}`, value JSON
/// `{"acked_at": ..., "acked_by": "<sid>"}`. The agent writes a row
/// when it handles a KLP `notifications.ack`, stamping the connecting
/// user's OS-derived SID — so a shared PC tracks each user's reads
/// independently. The `{pc_id}.{user_sid}.` prefix lets
/// `notifications.list` fetch one user's read set with a single prefix
/// walk. `history: 1` — only the latest ack per key matters.
pub const BUCKET_NOTIFICATIONS_READ: &str = "notifications_read";

/// KV key in [`BUCKET_NOTIFICATIONS_READ`] for one user's ack of one
/// notification: `{pc_id}.{user_sid}.{notification_id}` (SPEC §2.3.2).
///
/// The components are joined with `.` per the spec's documented key
/// shape. In practice none of them contain a `.` — `pc_id` is a
/// hostname, `user_sid` is `S-1-5-…` (hyphen-delimited), and the
/// backend mints `notification_id` as a UUID (operator-supplied
/// manifest ids are kebab-case) — so the join stays unambiguous and
/// the `{pc_id}.{user_sid}.` prefix (see
/// [`notifications_read_prefix`]) cleanly selects exactly one user's
/// read set for `notifications.list`.
pub fn notifications_read_key(pc_id: &str, user_sid: &str, notification_id: &str) -> String {
    format!("{pc_id}.{user_sid}.{notification_id}")
}

/// Prefix selecting every ack row for one `(pc_id, user_sid)` in
/// [`BUCKET_NOTIFICATIONS_READ`] — `{pc_id}.{user_sid}.`.
/// `notifications.list` walks the bucket keys and keeps those carrying
/// this prefix to compute the caller's unread set. Pairs with
/// [`notifications_read_key`].
pub fn notifications_read_prefix(pc_id: &str, user_sid: &str) -> String {
    format!("{pc_id}.{user_sid}.")
}

/// Singleton key in [`BUCKET_FLEET_CONFIG`] holding the JSON-encoded
/// [`crate::manifest::Freeze`]. **Key absent ⇒ not frozen** (clearing
/// the freeze is a KV delete), so readers treat a missing key as "fire
/// normally" and only evaluate `Freeze::is_active` when the key exists.
pub const KEY_FREEZE: &str = "freeze";

/// KV bucket holding **per-(schedule, pc) last-dispatch marks** for the
/// backend scheduler's in-flight suppression.
///
/// The per-pc / per-target dedup ([`crate::manifest::ExecMode`]) only
/// sees *completed* runs (`execution_results`, exit_code = 0). Since
/// #418 the reconcile poll runs every minute ([`crate::manifest::POLL_CRON`]),
/// but a dispatched Command doesn't land a completion until
/// `jitter (agent-side) + run + outbox drain` later — frequently
/// several minutes with a 3–5 min jitter. Without a dispatch record the
/// poll re-fires the same PC (or whole target) every tick across that
/// gap. This bucket records "I dispatched (schedule, pc) at T" so the
/// scheduler can suppress re-fire for a bounded window without waiting
/// on the completion round-trip.
///
/// Values are the dispatch instant as an RFC3339 string. A bucket-wide
/// `max_age` GCs marks once they're well past any suppression window,
/// so the bucket can't grow unbounded; the suppression-window check
/// itself lives in `scheduler::policy::suppress_dispatched`.
pub const BUCKET_SCHEDULER_DISPATCH: &str = "scheduler_dispatch";

/// Per-pc dispatch-mark key (OncePerPc).
///
/// The `pc.` / `target.` kind prefix keeps the two namespaces apart,
/// and each component is **length-prefixed** (`<len>.<value>`) so no two
/// distinct `(schedule_id, pc_id)` pairs can ever collide — even when an
/// id contains the `.` separator: `("a.b", "c")` → `pc.3.a.b.1.c`,
/// `("a", "b.c")` → `pc.1.a.3.b.c`. (Percent-/base64-encoding isn't an
/// option: NATS KV keys only allow `[-/_=.a-zA-Z0-9]`, so the
/// self-delimiting length prefix is the cheapest injective encoding that
/// stays in-charset.)
pub fn dispatch_mark_pc_key(schedule_id: &str, pc_id: &str) -> String {
    format!(
        "pc.{}.{}.{}.{}",
        schedule_id.len(),
        schedule_id,
        pc_id.len(),
        pc_id
    )
}

/// Whole-target dispatch-mark key (OncePerTarget). One key per
/// schedule — a per-target fire dispatches the whole target at once, so
/// there's nothing per-pc to record. Length-prefixed for symmetry with
/// [`dispatch_mark_pc_key`].
pub fn dispatch_mark_target_key(schedule_id: &str) -> String {
    format!("target.{}.{}", schedule_id.len(), schedule_id)
}

/// Object Store bucket holding raw agent binaries (one object per
/// version, e.g. `0.2.0` → file bytes).
pub const OBJECT_AGENT_RELEASES: &str = "agent_releases";

/// Object Store holding **generic application packages** — anything
/// the agent / kitting scripts pull down + install on endpoints.
/// First consumer is the kanade-client app, but the bucket is
/// intentionally generic: third-party installers (Webex, Teams,
/// custom MSI bundles), upgrade scripts, configuration archives,
/// etc. all live here.
///
/// Object keys are `<name>/<version>` — operator picks `<name>`
/// once per package family (e.g. `kanade-client`,
/// `webex-meetings`), then `<version>` per release (e.g.
/// `0.41.0`, `2025.03`). Slashes are explicitly allowed by NATS
/// Object Store key rules; the SPA / CLI / HTTP routes all carry
/// the pair as two path segments.
///
/// Why a separate bucket from `agent_releases`:
/// - `agent_releases` is fleet-critical (the agent's own self-
///   update path). Keeping it small + audited matters.
/// - `app_packages` is operator-curated user-space content. The
///   lifecycle is different (operators add/remove packages
///   freely; agent releases follow the release.yml pipeline).
pub const OBJECT_APP_PACKAGES: &str = "app_packages";

/// Object Store holding **manifest script bodies** referenced by
/// `Execute::script_object` (SPEC §2.4.1's alternative to inline
/// `script:` / repo-local `script_file:`). Per yukimemi/kanade
/// issue #210, this is the "Plan B 4-bucket layout" sibling of
/// `app_packages` — separated because scripts have a different
/// lifecycle than installer binaries:
///
/// - Smaller (typical KB-to-low-MB, vs MB-to-hundreds-of-MB
///   installers).
/// - Coupled to manifest versions (script lifecycle = manifest
///   lifecycle; the `script_current` / `script_status` KV gates
///   in SPEC §2.6.2 already track manifest versions, so a
///   matching dedicated bucket keeps the audit story aligned).
/// - Different access pattern (every Command execute potentially
///   fetches; vs installer fetched once per fleet deploy).
///
/// Object keys follow the same `<name>/<version>` shape as
/// `app_packages` so the SPA / operator tooling stays uniform.
/// For manifest-driven scripts `<name>` is the manifest id and
/// `<version>` is the manifest version, but the bucket itself
/// imposes no semantics on the pair — operator-uploaded
/// ad-hoc scripts can use any `<name>/<version>` they like.
pub const OBJECT_SCRIPTS: &str = "scripts";

/// Object Store holding **overflow stdout / stderr blobs** for the
/// `ExecResult` wire kind (#227). The default NATS `max_payload` is
/// 1 MB; a result whose stdout / stderr exceeds it would reject the
/// publish and pin the agent's outbox in a reconnect loop. The agent
/// uploads any stdout / stderr larger than `STDOUT_INLINE_THRESHOLD`
/// (256 KB, picked at 1/4 of the default max_payload so the rest of
/// the ExecResult fields fit alongside) into this bucket and replaces
/// the inline field with [`crate::wire::ExecResult::stdout_object`] /
/// `stderr_object` pointers. Backend's results projector derefs the
/// pointers before INSERT so downstream consumers (SQLite, SPA
/// Activity, inventory projector) see the full text the same way
/// they always have.
///
/// Object keys follow the shape `<request_id>/{stdout,stderr}` so
/// stdout + stderr for the same execution share a sibling prefix —
/// makes `kanade jetstream` listings group naturally and keeps the
/// per-key namespace tight against duplicate uploads.
///
/// Per-bucket retention (not a stream-wide TTL since async-nats
/// object_store inherits stream config): matches `STREAM_RESULTS`'s
/// 30-day retention so an operator who can still query the result
/// row in SQLite can also fetch the original blob if the inline
/// copy ever needs re-projection.
pub const OBJECT_RESULT_OUTPUT: &str = "result_output";

/// Object Store holding **collected file bundles** (#219). A job
/// carrying a `collect:` manifest hint prints a JSON list of file
/// paths on stdout; the agent zips them and uploads the archive here,
/// recording the key in [`crate::wire::ExecResult::collect_object`].
/// The SPA Collect page lists / downloads bundles straight from this
/// bucket. Object keys follow `<pc_id>/<job_id>/<rfc3339>.zip`, or
/// `<pc_id>/<job_id>/<label>__<rfc3339>.zip` when a run emits multiple
/// labeled bundles (e.g. one zip per day), so a listing groups by host
/// then job. Per-bucket retention is 30 days
/// (bundles are debugging/audit artifacts, not curated config like
/// `app_packages` / `scripts`, so they auto-expire) — see
/// `kanade-shared::bootstrap`.
pub const OBJECT_COLLECTIONS: &str = "collections";

/// Inline threshold for `ExecResult.stdout` / `.stderr`. Larger
/// payloads overflow into [`OBJECT_RESULT_OUTPUT`]. 256 KB = 1/4 of
/// the NATS default `max_payload` (1 MB) so the rest of the
/// ExecResult JSON (request_id, exec_id, etc.) easily fits below the
/// publish-reject ceiling.
///
/// Lives next to the bucket constant rather than on the agent side
/// so the SPA / future operator tooling can quote the same threshold
/// when explaining "why this result has no inline stdout".
pub const STDOUT_INLINE_THRESHOLD: usize = 256 * 1024;

/// Key inside [`BUCKET_AGENT_CONFIG`] carrying the broadcast target
/// version. Agents watch this key and self-update when their running
/// version drifts.
pub const KEY_AGENT_TARGET_VERSION: &str = "target_version";

/// Sprint 6 layered-config keys inside [`BUCKET_AGENT_CONFIG`]:
///   * `global`        — fleet-wide default ConfigScope JSON
///   * `groups.<name>` — per-group override (partial ConfigScope)
///   * `pcs.<pc_id>`   — per-pc override (partial ConfigScope)
///
/// The `groups.` / `pcs.` prefixes let a `kv.keys()` walk pick out
/// just the rows in one scope when listing.
pub const KEY_AGENT_CONFIG_GLOBAL: &str = "global";
pub const PREFIX_AGENT_CONFIG_GROUPS: &str = "groups.";
pub const PREFIX_AGENT_CONFIG_PCS: &str = "pcs.";

pub fn agent_config_group_key(group: &str) -> String {
    format!("{PREFIX_AGENT_CONFIG_GROUPS}{group}")
}

pub fn agent_config_pc_key(pc_id: &str) -> String {
    format!("{PREFIX_AGENT_CONFIG_PCS}{pc_id}")
}

/// Inverse of [`agent_config_group_key`] — returns the bare group
/// name if `key` carries the groups-scope prefix, else `None`.
pub fn parse_agent_config_group_key(key: &str) -> Option<&str> {
    key.strip_prefix(PREFIX_AGENT_CONFIG_GROUPS)
}

/// Inverse of [`agent_config_pc_key`].
pub fn parse_agent_config_pc_key(key: &str) -> Option<&str> {
    key.strip_prefix(PREFIX_AGENT_CONFIG_PCS)
}

pub const SCRIPT_STATUS_ACTIVE: &str = "ACTIVE";
pub const SCRIPT_STATUS_REVOKED: &str = "REVOKED";

pub const STREAM_INVENTORY: &str = "INVENTORY";
pub const STREAM_RESULTS: &str = "RESULTS";
pub const STREAM_EXEC: &str = "EXEC";
pub const STREAM_EVENTS: &str = "EVENTS";
pub const STREAM_AUDIT: &str = "AUDIT";

/// JetStream stream retaining end-user notification history (SPEC
/// §2.3.1 / Phase E). Catches every `notifications.{all|group.X|pc.Y}`
/// publish the backend fans out, so a Client App that connects after
/// a notification was sent can still fetch it via KLP
/// `notifications.list`. 90-day window — long enough for "what did I
/// miss while on leave" without unbounded growth. Unlike `EXEC`,
/// retains all messages per subject (no `max_messages_per_subject`):
/// each notification is its own history entry, not a latest-only state.
pub const STREAM_NOTIFICATIONS: &str = "NOTIFICATIONS";

/// JetStream stream backing the per-PC observability event pipeline
/// (Issue #246). Distinct from [`STREAM_EVENTS`] (in-flight script
/// lifecycle) — `STREAM_OBS_EVENTS` carries the timeline data the
/// SPA's Events page consumes: sign-in/out, power on/off, sleep/
/// resume, agent milestones, diagnostic bundle pointers. The agent
/// publishes on `obs.<pc_id>` (see [`crate::subject::obs`]) and
/// this stream catches everything matching [`crate::subject::OBS_FILTER`]
/// so a backend that boots after the agent doesn't miss any
/// already-emitted events.
pub const STREAM_OBS_EVENTS: &str = "OBS_EVENTS";

/// Canonical list of every JetStream resource
/// [`crate::bootstrap::ensure_jetstream_resources`] creates. The health
/// rollup (`/api/health/fleet`) and the status snapshot
/// (`/api/jetstream/status`) both iterate these so the dashboard reports
/// the *complete* resource set — previously each kept its own hand-
/// maintained subset that drifted behind bootstrap (e.g. only 1 of the 5
/// object stores showed up). Keep in lockstep with `bootstrap.rs`: a new
/// stream / bucket / store added there must be appended here too. The
/// `canonical_resource_lists_are_sane` test below guards the easy
/// mistakes (dots, dupes, empties); keeping the *set* aligned with
/// bootstrap stays a manual discipline (bootstrap needs per-resource
/// config, so it can't be derived from a name list alone).
pub const ALL_STREAMS: &[&str] = &[
    STREAM_INVENTORY,
    STREAM_RESULTS,
    STREAM_EXEC,
    STREAM_EVENTS,
    STREAM_AUDIT,
    STREAM_OBS_EVENTS,
    STREAM_NOTIFICATIONS,
];

/// Every KV bucket `ensure_jetstream_resources` creates. The `*_yaml`
/// source-of-truth buckets and the operator-managed singletons
/// (`fleet_config`, `group_contacts`) are included — they're part of the
/// bootstrap contract, so a missing one is a genuine degradation. Lazily-
/// created buckets that bootstrap does NOT guarantee (e.g. `views`,
/// `scheduler_dispatch`) are deliberately excluded so a fresh fleet that
/// never used them doesn't read as degraded.
pub const ALL_KV_BUCKETS: &[&str] = &[
    BUCKET_SCRIPT_CURRENT,
    BUCKET_SCRIPT_STATUS,
    BUCKET_AGENTS_STATE,
    BUCKET_AGENT_CONFIG,
    BUCKET_AGENT_GROUPS,
    BUCKET_AGENT_META,
    BUCKET_GROUP_CONTACTS,
    BUCKET_SCHEDULES,
    BUCKET_JOBS,
    BUCKET_FLEET_CONFIG,
    BUCKET_NOTIFICATIONS_READ,
    BUCKET_JOBS_YAML,
    BUCKET_SCHEDULES_YAML,
];

/// Every Object Store `ensure_jetstream_resources` creates. The status
/// probe used to list only `agent_releases`, which is why the dashboard's
/// "Object stores" column looked suspiciously empty.
pub const ALL_OBJECT_STORES: &[&str] = &[
    OBJECT_AGENT_RELEASES,
    OBJECT_APP_PACKAGES,
    OBJECT_SCRIPTS,
    OBJECT_RESULT_OUTPUT,
    OBJECT_COLLECTIONS,
];

#[cfg(test)]
mod tests {
    use super::*;

    /// NATS KV bucket names must be domain-safe ASCII (a-z, A-Z, 0-9, _, -).
    /// Lock the constants down so a future edit doesn't introduce a `.` and
    /// break create_key_value silently on the broker side.
    #[test]
    fn bucket_names_are_domain_safe() {
        for name in [
            BUCKET_SCRIPT_CURRENT,
            BUCKET_SCRIPT_STATUS,
            BUCKET_AGENTS_STATE,
            BUCKET_AGENT_CONFIG,
            BUCKET_AGENT_GROUPS,
            BUCKET_AGENT_META,
            BUCKET_GROUP_CONTACTS,
            BUCKET_SCHEDULES,
            BUCKET_JOBS,
            BUCKET_JOBS_YAML,
            BUCKET_SCHEDULES_YAML,
            BUCKET_VIEWS,
            BUCKET_VIEWS_YAML,
            BUCKET_FLEET_CONFIG,
            BUCKET_SERVER_SETTINGS,
            BUCKET_NOTIFICATIONS_READ,
            BUCKET_SCHEDULER_DISPATCH,
            OBJECT_AGENT_RELEASES,
            OBJECT_APP_PACKAGES,
            OBJECT_SCRIPTS,
            OBJECT_RESULT_OUTPUT,
            OBJECT_COLLECTIONS,
        ] {
            assert!(
                !name.contains('.'),
                "bucket name {name:?} contains a dot, which NATS KV rejects"
            );
            assert!(
                name.chars()
                    .all(|c| c.is_ascii_alphanumeric() || c == '_' || c == '-'),
                "bucket name {name:?} has non-domain-safe characters"
            );
        }
    }

    #[test]
    fn stream_names_are_unique() {
        let names = [
            STREAM_INVENTORY,
            STREAM_RESULTS,
            STREAM_EXEC,
            STREAM_EVENTS,
            STREAM_AUDIT,
            STREAM_OBS_EVENTS,
            STREAM_NOTIFICATIONS,
        ];
        let mut deduped = names.to_vec();
        deduped.sort_unstable();
        deduped.dedup();
        assert_eq!(
            deduped.len(),
            names.len(),
            "stream constants collide: {names:?}"
        );
    }

    /// The canonical lists the health + status probes iterate must be
    /// non-empty, dup-free, and domain-safe (the same charset rule the
    /// broker enforces). Catches a copy-paste dupe or a stray `.` before
    /// it turns into a phantom "missing resource" on the dashboard.
    #[test]
    fn canonical_resource_lists_are_sane() {
        for (label, list) in [
            ("ALL_STREAMS", ALL_STREAMS),
            ("ALL_KV_BUCKETS", ALL_KV_BUCKETS),
            ("ALL_OBJECT_STORES", ALL_OBJECT_STORES),
        ] {
            assert!(!list.is_empty(), "{label} is empty");
            let mut deduped = list.to_vec();
            deduped.sort_unstable();
            deduped.dedup();
            assert_eq!(
                deduped.len(),
                list.len(),
                "{label} has duplicates: {list:?}"
            );
            for name in list {
                assert!(
                    name.chars()
                        .all(|c| c.is_ascii_alphanumeric() || c == '_' || c == '-'),
                    "{label} entry {name:?} has non-domain-safe characters"
                );
            }
        }
    }

    #[test]
    fn notifications_read_key_and_prefix_align() {
        let key = notifications_read_key("PC1234", "S-1-5-21-1001", "notif-9f3a");
        assert_eq!(key, "PC1234.S-1-5-21-1001.notif-9f3a");
        let prefix = notifications_read_prefix("PC1234", "S-1-5-21-1001");
        assert_eq!(prefix, "PC1234.S-1-5-21-1001.");
        // The list path selects a user's read set by this prefix — the
        // key for any of that user's notifications must carry it.
        assert!(key.starts_with(&prefix));
        // A different user's key must NOT match the prefix.
        let other = notifications_read_key("PC1234", "S-1-5-21-1002", "notif-9f3a");
        assert!(!other.starts_with(&prefix));
    }

    #[test]
    fn script_status_strings() {
        assert_eq!(SCRIPT_STATUS_ACTIVE, "ACTIVE");
        assert_eq!(SCRIPT_STATUS_REVOKED, "REVOKED");
        assert_ne!(SCRIPT_STATUS_ACTIVE, SCRIPT_STATUS_REVOKED);
    }

    #[test]
    fn key_agent_target_version_constant() {
        assert_eq!(KEY_AGENT_TARGET_VERSION, "target_version");
    }

    #[test]
    fn agent_config_group_key_round_trips() {
        let k = agent_config_group_key("canary");
        assert_eq!(k, "groups.canary");
        assert_eq!(parse_agent_config_group_key(&k), Some("canary"));
    }

    #[test]
    fn agent_config_pc_key_round_trips() {
        let k = agent_config_pc_key("PC-01");
        assert_eq!(k, "pcs.PC-01");
        assert_eq!(parse_agent_config_pc_key(&k), Some("PC-01"));
    }

    #[test]
    fn dispatch_mark_keys_are_distinct_by_kind() {
        // The whole-target key for one schedule must never equal the
        // per-pc key for another — the `pc.` / `target.` prefixes keep
        // the two namespaces apart even when ids look alike.
        let per_pc = dispatch_mark_pc_key("collect-winlog-events", "PC-01");
        let target = dispatch_mark_target_key("collect-winlog-events");
        assert_eq!(per_pc, "pc.21.collect-winlog-events.5.PC-01");
        assert_eq!(target, "target.21.collect-winlog-events");
        assert_ne!(per_pc, target);
        // A schedule literally named "collect-winlog-events.PC-01"
        // still can't collide with the per-pc key above.
        assert_ne!(
            dispatch_mark_target_key("collect-winlog-events.PC-01"),
            per_pc,
        );
    }

    #[test]
    fn dispatch_mark_pc_key_has_no_dot_collision() {
        // Length-prefixing makes the encoding injective: a dotted
        // schedule_id can't borrow a leading segment from the pc_id (or
        // vice versa) to forge a colliding key. (CodeRabbit / claude #444.)
        assert_ne!(
            dispatch_mark_pc_key("a.b", "c"),
            dispatch_mark_pc_key("a", "b.c"),
        );
        assert_ne!(
            dispatch_mark_pc_key("x", "y.z"),
            dispatch_mark_pc_key("x.y", "z"),
        );
        // Same components, swapped roles — also distinct.
        assert_ne!(
            dispatch_mark_pc_key("foo", "bar"),
            dispatch_mark_pc_key("bar", "foo"),
        );
    }

    #[test]
    fn agent_config_scope_keys_do_not_collide() {
        // Belt + braces: make sure no pc id starting with "groups." would
        // be misparsed (or vice versa). The prefixes are distinct because
        // they each end in `.` and the parent buckets disagree on what
        // comes after — pcs holds host names, groups holds membership
        // names — but locking the invariant in a test stops a future
        // rename from breaking it.
        assert_ne!(PREFIX_AGENT_CONFIG_GROUPS, PREFIX_AGENT_CONFIG_PCS);
        assert!(parse_agent_config_group_key("pcs.someone").is_none());
        assert!(parse_agent_config_pc_key("groups.someone").is_none());
        assert_eq!(parse_agent_config_group_key("global"), None);
        assert_eq!(parse_agent_config_pc_key("global"), None);
    }
}