1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
#![doc = include_str!("../README.md")]
#![warn(missing_docs)]
use std::collections::{BTreeMap, BTreeSet};

use jsonref::JsonRef;
use serde::{de::Error as _, Deserialize, Deserializer, Serialize};
use serde_json::Value;
use thiserror::Error;

/// An "atomic" change made to the JSON schema in question, going from LHS to RHS.
///
/// Just a wrapper container for `ChangeKind`
#[derive(Debug, Eq, PartialEq, Serialize)]
pub struct Change {
    /// JSON path for the given change. `""` for "root schema". `".foo"` for property foo.
    pub path: String,
    /// Data specific to the kind of change.
    pub change: ChangeKind,
}

/// The kind of change + data relevant to the change.
#[derive(Debug, Eq, PartialEq, Serialize)]
pub enum ChangeKind {
    /// A type has been added and is now additionally allowed.
    TypeAdd {
        /// The type in question.
        added: SimpleJsonSchemaType,
    },
    /// A type has been removed and is no longer allowed.
    TypeRemove {
        /// The type in question.
        removed: SimpleJsonSchemaType,
    },
    /// A property has been added and (depending on additionalProperties) is now additionally
    /// allowed.
    PropertyAdd {
        /// The value of additionalProperties within the current JSON object.
        lhs_additional_properties: bool,
        /// The name of the added property.
        added: String,
    },
    /// A property has been removed and (depending on additionalProperties) might now no longer be
    /// allowed.
    PropertyRemove {
        /// The value of additionalProperties within the current JSON object.
        lhs_additional_properties: bool,
        /// The name of the added property.
        removed: String,
    },
}

impl ChangeKind {
    /// Whether the change is breaking.
    ///
    /// What is considered breaking is WIP. Changes are intentionally exposed as-is in public API
    /// so that the user can develop their own logic as to what they consider breaking.
    ///
    /// Currently the rule of thumb is, a change is breaking if it would cause messages that used
    /// to validate fine under RHS to no longer validate under LHS.
    pub fn is_breaking(&self) -> bool {
        match self {
            Self::TypeAdd { .. } => false,
            Self::TypeRemove { .. } => true,
            Self::PropertyAdd {
                lhs_additional_properties,
                ..
            } => *lhs_additional_properties,
            Self::PropertyRemove {
                lhs_additional_properties,
                ..
            } => !*lhs_additional_properties,
        }
    }
}

/// The errors that can happen in this crate.
#[derive(Error, Debug)]
pub enum Error {
    /// Failed to resolve references upfront.
    ///
    /// We invoke the `jsonref` crate upfront to flatten out the schema. Any errors during that
    /// stage end up here.
    #[error("failed to find references")]
    JsonRef(#[from] Box<jsonref::Error>),

    /// Failed to parse the JSON schema.
    ///
    /// Any deserialization errors from serde that happen while converting the value into our AST
    /// end up here.
    #[error("failed to parse schema")]
    Serde(#[from] serde_json::Error),
}

#[derive(Deserialize, Clone, Ord, Eq, PartialEq, PartialOrd, Debug)]
#[serde(untagged)]
enum JsonSchemaType {
    Simple(SimpleJsonSchemaType),
    Any,
    Never,
    Multiple(Vec<SimpleJsonSchemaType>),
}

/// All primitive types defined in JSON schema.
#[derive(Serialize, Deserialize, Clone, Ord, Eq, PartialEq, PartialOrd, Debug)]
#[allow(missing_docs)]
pub enum SimpleJsonSchemaType {
    #[serde(rename = "string")]
    String,
    #[serde(rename = "number")]
    Number,
    #[serde(rename = "integer")]
    Integer,
    #[serde(rename = "object")]
    Object,
    #[serde(rename = "array")]
    Array,
    #[serde(rename = "boolean")]
    Boolean,
    #[serde(rename = "null")]
    Null,
}

impl From<SimpleJsonSchemaType> for JsonSchemaType {
    fn from(other: SimpleJsonSchemaType) -> Self {
        JsonSchemaType::Simple(other)
    }
}

impl JsonSchemaType {
    fn into_set(self) -> BTreeSet<SimpleJsonSchemaType> {
        self.explode().into_iter().collect()
    }

    fn explode(self) -> Vec<SimpleJsonSchemaType> {
        match self {
            Self::Simple(SimpleJsonSchemaType::Number) => {
                vec![SimpleJsonSchemaType::Integer, SimpleJsonSchemaType::Number]
            }
            Self::Any => vec![
                SimpleJsonSchemaType::String,
                SimpleJsonSchemaType::Number,
                SimpleJsonSchemaType::Integer,
                SimpleJsonSchemaType::Object,
                SimpleJsonSchemaType::Array,
                SimpleJsonSchemaType::Boolean,
                SimpleJsonSchemaType::Null,
            ],
            Self::Never => vec![],
            Self::Simple(x) => vec![x],
            Self::Multiple(xs) => xs
                .into_iter()
                .map(JsonSchemaType::from)
                .flat_map(Self::explode)
                .collect(),
        }
    }
}

#[derive(Default, Eq, PartialEq)]
struct JsonSchema {
    ty: Option<JsonSchemaType>,
    constant: Option<Value>,
    additional_properties: Option<Box<JsonSchema>>,
    properties: BTreeMap<String, JsonSchema>,
}

impl JsonSchema {
    fn is_true(&self) -> bool {
        *self == JsonSchema::default()
    }
}

impl<'de> Deserialize<'de> for JsonSchema {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        // perhaps catch this error as well, if needed
        let value = Value::deserialize(deserializer)?;
        if let Value::Bool(boolean) = value {
            if boolean {
                Ok(JsonSchema {
                    ty: Some(JsonSchemaType::Any),
                    ..Default::default()
                })
            } else {
                Ok(JsonSchema {
                    ty: Some(JsonSchemaType::Never),
                    ..Default::default()
                })
            }
        } else {
            Ok(JsonSchemaRaw::deserialize(value)
                .map_err(D::Error::custom)?
                .into())
        }
    }
}

#[derive(Deserialize, Default)]
#[serde(rename_all = "camelCase")]
#[serde(default)]
struct JsonSchemaRaw {
    #[serde(rename = "type")]
    ty: Option<JsonSchemaType>,
    #[serde(rename = "const")]
    constant: Option<Value>,
    additional_properties: Option<Box<JsonSchema>>,
    properties: BTreeMap<String, JsonSchema>,
}

impl From<JsonSchemaRaw> for JsonSchema {
    fn from(raw: JsonSchemaRaw) -> Self {
        let JsonSchemaRaw {
            ty,
            constant,
            additional_properties,
            properties,
        } = raw;
        JsonSchema {
            ty,
            constant,
            additional_properties,
            properties,
        }
    }
}

impl JsonSchema {
    fn effective_type(&self) -> JsonSchemaType {
        if let Some(ref ty) = self.ty {
            ty.clone()
        } else if let Some(ref constant) = self.constant {
            SimpleJsonSchemaType::from(constant).into()
        } else if !self.properties.is_empty() {
            SimpleJsonSchemaType::Object.into()
        } else {
            JsonSchemaType::Any
        }
    }
}

impl From<&Value> for SimpleJsonSchemaType {
    fn from(val: &Value) -> SimpleJsonSchemaType {
        match val {
            Value::Number(_) => SimpleJsonSchemaType::Number,
            Value::Null => SimpleJsonSchemaType::Null,
            Value::String(_) => SimpleJsonSchemaType::String,
            Value::Bool(_) => SimpleJsonSchemaType::Boolean,
            Value::Array(_) => SimpleJsonSchemaType::Array,
            Value::Object(_) => SimpleJsonSchemaType::Object,
        }
    }
}

/// Take two JSON schemas, and compare them.
///
/// `lhs` (left-hand side) is the old schema, `rhs` (right-hand side) is the new schema.
pub fn diff(mut lhs: Value, mut rhs: Value) -> Result<Vec<Change>, Error> {
    let mut jsonref = JsonRef::new();
    jsonref.deref_value(&mut lhs).map_err(Box::new)?;
    jsonref.deref_value(&mut rhs).map_err(Box::new)?;
    let mut rv = Vec::new();

    let json_path = String::new();

    let lhs: JsonSchema = serde_json::from_value(lhs)?;
    let rhs: JsonSchema = serde_json::from_value(rhs)?;

    diff_inner(&mut rv, json_path, &lhs, &rhs)?;

    Ok(rv)
}

fn diff_inner(
    rv: &mut Vec<Change>,
    json_path: String,
    lhs: &JsonSchema,
    rhs: &JsonSchema,
) -> Result<(), Error> {
    let lhs_ty = lhs.effective_type().into_set();
    let rhs_ty = rhs.effective_type().into_set();

    for removed in lhs_ty.difference(&rhs_ty) {
        rv.push(Change {
            path: json_path.clone(),
            change: ChangeKind::TypeRemove {
                removed: removed.clone(),
            },
        });
    }

    for added in rhs_ty.difference(&lhs_ty) {
        rv.push(Change {
            path: json_path.clone(),
            change: ChangeKind::TypeAdd {
                added: added.clone(),
            },
        });
    }

    let lhs_props: BTreeSet<_> = lhs.properties.keys().collect();
    let rhs_props: BTreeSet<_> = rhs.properties.keys().collect();

    for &removed in lhs_props.difference(&rhs_props) {
        rv.push(Change {
            path: json_path.clone(),
            change: ChangeKind::PropertyRemove {
                lhs_additional_properties: lhs
                    .additional_properties
                    .as_deref()
                    .map_or(true, JsonSchema::is_true),
                removed: removed.to_owned(),
            },
        });
    }

    for &added in rhs_props.difference(&lhs_props) {
        rv.push(Change {
            path: json_path.clone(),
            change: ChangeKind::PropertyAdd {
                lhs_additional_properties: lhs
                    .additional_properties
                    .as_deref()
                    .map_or(true, JsonSchema::is_true),
                added: added.to_owned(),
            },
        });
    }

    for common in rhs_props.intersection(&lhs_props) {
        let lhs_child = lhs.properties.get(common.as_str()).unwrap();
        let rhs_child = rhs.properties.get(common.as_str()).unwrap();

        let mut new_path = json_path.clone();
        new_path.push('.');
        new_path.push_str(common);

        diff_inner(rv, new_path, lhs_child, rhs_child)?;
    }

    if let (Some(ref lhs_additional_properties), Some(ref rhs_additional_properties)) =
        (&lhs.additional_properties, &rhs.additional_properties)
    {
        if rhs_additional_properties != lhs_additional_properties {
            let mut new_path = json_path;
            new_path.push_str(".<additional properties>");

            diff_inner(
                rv,
                new_path,
                lhs_additional_properties,
                rhs_additional_properties,
            )?;
        }
    }

    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;

    use serde_json::json;

    use insta::assert_debug_snapshot;

    #[test]
    fn nothing() {
        let lhs = json! {{ "type": "string" }};
        let rhs = json! {{ "type": "string" }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @"[]"
        );
    }

    #[test]
    fn basic() {
        let lhs = json! {{ "type": "string" }};
        let rhs = json! {{ "type": "number" }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: "",
                change: TypeRemove {
                    removed: String,
                },
            },
            Change {
                path: "",
                change: TypeAdd {
                    added: Number,
                },
            },
            Change {
                path: "",
                change: TypeAdd {
                    added: Integer,
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn extend_type() {
        let lhs = json! {{ "type": "string" }};
        let rhs = json! {{ "type": ["string", "number"] }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: "",
                change: TypeAdd {
                    added: Number,
                },
            },
            Change {
                path: "",
                change: TypeAdd {
                    added: Integer,
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn extend_from_const() {
        let lhs = json! {{ "const": "hello" }};
        let rhs = json! {{ "type": ["string"] }};

        let diff = diff(lhs, rhs).unwrap();

        // TODO: better support for const
        assert_debug_snapshot!(
            diff,
            @"[]"
        );
    }

    #[test]
    fn restrict_to_const() {
        let lhs = json! {{ "type": ["string"] }};
        let rhs = json! {{ "const": "hello" }};

        let diff = diff(lhs, rhs).unwrap();

        // TODO: better support for const
        assert_debug_snapshot!(
            diff,
            @"[]"
        );
    }

    #[test]
    fn additional_properties_extend() {
        let lhs = json! {{ "additionalProperties": false }};
        let rhs = json! {{ "additionalProperties": true }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: String,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: Number,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: Integer,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: Object,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: Array,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: Boolean,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeAdd {
                    added: Null,
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn additional_properties_restrict() {
        let lhs = json! {{ "additionalProperties": true }};
        let rhs = json! {{ "additionalProperties": false }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: String,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: Number,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: Integer,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: Object,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: Array,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: Boolean,
                },
            },
            Change {
                path: ".<additional properties>",
                change: TypeRemove {
                    removed: Null,
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn integer_to_number() {
        let lhs = json! {{ "type": "integer" }};
        let rhs = json! {{ "type": "number" }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: "",
                change: TypeAdd {
                    added: Number,
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn number_to_integer() {
        let lhs = json! {{ "type": "number" }};
        let rhs = json! {{ "type": "integer" }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: "",
                change: TypeRemove {
                    removed: Number,
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn add_property() {
        let lhs = json! {{
            "type": "object",
            "properties": {
                "hello": {"type": "string"},
            }
        }};
        let rhs = json! {{
            "type": "object",
            "properties": {
                "hello": {"type": "string"},
                "world": {"type": "string"},
            }
        }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: "",
                change: PropertyAdd {
                    lhs_additional_properties: true,
                    added: "world",
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn remove_property() {
        let lhs = json! {{
            "type": "object",
            "properties": {
                "hello": {"type": "string"},
                "world": {"type": "string"},
            }
        }};
        let rhs = json! {{
            "type": "object",
            "properties": {
                "hello": {"type": "string"},
            }
        }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: "",
                change: PropertyRemove {
                    lhs_additional_properties: true,
                    removed: "world",
                },
            },
        ]
        "###
        );
    }

    #[test]
    fn change_property() {
        let lhs = json! {{
            "type": "object",
            "properties": {
                "hello": {"type": "string"},
            }
        }};
        let rhs = json! {{
            "type": "object",
            "properties": {
                "hello": {"type": "number"},
            }
        }};

        let diff = diff(lhs, rhs).unwrap();

        assert_debug_snapshot!(
            diff,
            @r###"
        [
            Change {
                path: ".hello",
                change: TypeRemove {
                    removed: String,
                },
            },
            Change {
                path: ".hello",
                change: TypeAdd {
                    added: Number,
                },
            },
            Change {
                path: ".hello",
                change: TypeAdd {
                    added: Integer,
                },
            },
        ]
        "###
        );
    }
}