json_eval_rs/jsoneval/

validation.rs

use super::JSONEval;
use crate::jsoneval::cancellation::CancellationToken;
use crate::jsoneval::json_parser;
use crate::jsoneval::path_utils;
use crate::jsoneval::types::{ValidationError, ValidationResult};

use crate::time_block;

use indexmap::IndexMap;
use serde_json::Value;

impl JSONEval {
    /// Invalidate the validation cache
    pub(crate) fn invalidate_validation_cache(&self) {
        let mut cache = match self.validation_cache.write() {
            Ok(c) => c,
            Err(poisoned) => poisoned.into_inner(),
        };
        cache.clear();
    }

    /// Validate data against schema rules
    pub fn validate(
        &mut self,
        data: &str,
        context: Option<&str>,
        paths: Option<&[String]>,
        token: Option<&CancellationToken>,
        validate_readonly: Option<bool>,
        include_subforms: Option<bool>,
    ) -> Result<ValidationResult, String> {
        let validate_ro = validate_readonly.unwrap_or(false);
        let inc_subforms = include_subforms.unwrap_or(false);
        if let Some(t) = token {
            if t.is_cancelled() {
                return Err("Cancelled".to_string());
            }
        }

        // Fast path: if no path filtering and data/context are identical to last validation,
        // return cached full result immediately.
        if paths.is_none() || paths.is_some_and(|p| p.is_empty()) {
            if let Ok(cache) = self.validation_cache.read() {
                if let Some(cached) =
                    cache.get_cached_full_result(data, context, validate_ro, inc_subforms)
                {
                    return Ok(cached);
                }
            }
        }

        time_block!("validate() [total]", {
            // Acquire lock for synchronous execution
            let _lock = self.eval_lock.lock().unwrap();
            let _static_guard = self
                .engine
                .bind_static_arrays_scope(std::sync::Arc::clone(&self.static_arrays));

            // Parse and update data
            let (data_value, context_value) = time_block!("  parse data & context", {
                let d = json_parser::parse_json_str(data)?;
                let c = if let Some(ctx) = context {
                    json_parser::parse_json_str(ctx)?
                } else {
                    Value::Object(serde_json::Map::new())
                };
                Ok::<_, String>((d, c))
            })?;

            // Update context
            self.context = context_value.clone();

            // Update eval_data with new data/context
            time_block!("  replace_data_and_context", {
                self.eval_data
                    .replace_data_and_context(data_value.clone(), context_value.clone());
            });

            // Drop lock before calling evaluate_others which needs mutable access
            drop(_lock);

            // Re-evaluate rule evaluations to ensure fresh values
            // This ensures all rule.$evaluation expressions are re-computed
            time_block!("  evaluate_others", {
                self.evaluate_others(paths, token);
            });

            time_block!("  ensure_layout_resolved", {
                self.ensure_layout_resolved();
            });

            let mut errors: IndexMap<String, ValidationError> = IndexMap::new();

            let layout_state = self.layout_state.read().unwrap();
            let layout_hidden_refs = &layout_state.layout_hidden_refs;
            let layout_disabled_refs = &layout_state.layout_disabled_refs;
            let mut hidden_cache =
                std::collections::HashMap::with_capacity(self.fields_with_rules.len());
            let mut readonly_cache =
                std::collections::HashMap::with_capacity(self.fields_with_rules.len());

            // Use pre-parsed fields_with_rules from schema parsing (no runtime collection needed)
            // This list was collected during schema parse and contains all fields with rules
            time_block!("  fields_with_rules loop", {
                for field_path in self.fields_with_rules.iter() {
                    // Check if we should validate this path (path filtering)
                    if let Some(filter_paths) = paths {
                        if !filter_paths.is_empty()
                            && !filter_paths.iter().any(|p| {
                                field_path.starts_with(p.as_str())
                                    || p.starts_with(field_path.as_str())
                            })
                        {
                            continue;
                        }
                    }

                    if let Some(t) = token {
                        if t.is_cancelled() {
                            return Err("Cancelled".to_string());
                        }
                    }

                    self.validate_field_cached(
                        field_path,
                        &data_value,
                        layout_hidden_refs,
                        layout_disabled_refs,
                        &mut hidden_cache,
                        &mut readonly_cache,
                        validate_ro,
                        &mut errors,
                    );
                }
            });

            drop(layout_state);

            if inc_subforms {
                let initial_eval_cache = self.eval_cache.clone();
                let initial_static_arrays = std::sync::Arc::clone(&self.static_arrays);
                let subform_keys: Vec<String> = self.subforms.keys().cloned().collect();

                for subform_path in subform_keys {
                    if let Some(t) = token {
                        if t.is_cancelled() {
                            return Err("Cancelled".to_string());
                        }
                    }

                    let data_ptr = path_utils::schema_path_to_data_pointer(&subform_path);
                    let subform_dot_path = data_ptr.trim_start_matches('/').replace('/', ".");

                    let schema_pointer = if subform_path.starts_with("#/") {
                        &subform_path[1..]
                    } else if subform_path.starts_with('#') {
                        &subform_path[1..]
                    } else {
                        &subform_path
                    };

                    let original_field_key = subform_path
                        .split('/')
                        .filter(|seg| !seg.is_empty() && *seg != "properties")
                        .last()
                        .unwrap_or(&subform_path)
                        .to_string();

                    let root_key = path_utils::get_value_by_pointer(&self.schema, schema_pointer)
                        .and_then(|node| node.get("itemsRootKey"))
                        .and_then(|v| v.as_str())
                        .unwrap_or(&original_field_key)
                        .to_string();

                    let item_count = self
                        .eval_data
                        .data()
                        .pointer(&data_ptr)
                        .and_then(Value::as_array)
                        .map(|a| a.len())
                        .unwrap_or(0);

                    if item_count == 0 {
                        continue;
                    }

                    for idx in 0..item_count {
                        if let Some(t) = token {
                            if t.is_cancelled() {
                                return Err("Cancelled".to_string());
                            }
                        }

                        let item_prefix = format!("{}.{}.", subform_dot_path, idx);
                        let item_path_exact = format!("{}.{}", subform_dot_path, idx);

                        let sub_paths: Option<Vec<String>> = if let Some(filter_paths) = paths {
                            if filter_paths.is_empty() {
                                None
                            } else {
                                let applies = filter_paths.iter().any(|p| {
                                    p == &item_path_exact
                                        || p == &subform_dot_path
                                        || p.starts_with(&item_prefix)
                                        || subform_dot_path.starts_with(p.as_str())
                                });
                                if !applies {
                                    continue;
                                }

                                let has_whole_match = filter_paths.iter().any(|p| {
                                    p == &item_path_exact
                                        || p == &subform_dot_path
                                        || subform_dot_path.starts_with(p.as_str())
                                });

                                if has_whole_match {
                                    None
                                } else {
                                    let mapped: Vec<String> = filter_paths
                                        .iter()
                                        .filter_map(|p| {
                                            p.strip_prefix(&item_prefix)
                                                .map(|sub| format!("{}.{}", root_key, sub))
                                        })
                                        .collect();

                                    if mapped.is_empty() {
                                        continue;
                                    }
                                    Some(mapped)
                                }
                            }
                        } else {
                            None
                        };

                        let sub_paths_ref = sub_paths.as_deref();

                        let sub_result = self.with_item_cache_swap(
                            &subform_path,
                            idx,
                            data_value.clone(),
                            context_value.clone(),
                            false,
                            |sf| {
                                sf.validate_pre_set(
                                    None,
                                    sub_paths_ref,
                                    token,
                                    validate_readonly,
                                    true,
                                )
                            },
                        )?;

                        let root_prefix = format!("{}.", root_key);
                        for (field_name, mut error) in sub_result.errors {
                            let sub_field =
                                if let Some(stripped) = field_name.strip_prefix(&root_prefix) {
                                    stripped
                                } else if field_name == root_key {
                                    ""
                                } else {
                                    &field_name
                                };

                            let parent_path = if sub_field.is_empty() {
                                format!("{}.{}", subform_dot_path, idx)
                            } else {
                                format!("{}.{}.{}", subform_dot_path, idx, sub_field)
                            };

                            if let Some(ref c) = error.code {
                                if c == &format!("{}.{}", field_name, error.rule_type)
                                    || c == &format!("{}.{}", sub_field, error.rule_type)
                                {
                                    error.code =
                                        Some(format!("{}.{}", parent_path, error.rule_type));
                                }
                            }

                            errors.insert(parent_path, error);
                        }
                    }
                }

                // Reset scratch subforms state to avoid holding duplicate trees in memory
                for subform in self.subforms.values_mut() {
                    subform.eval_data = crate::jsoneval::eval_data::EvalData::new(Value::Null);
                    subform.evaluated_schema = (*subform.schema).clone();
                    subform.eval_cache.clear();
                    subform.static_arrays = std::sync::Arc::new(IndexMap::new());
                    subform
                        .engine
                        .set_static_arrays(std::sync::Arc::clone(&subform.static_arrays));
                    subform.invalidate_layout_cache();
                    subform.invalidate_validation_cache();
                }
                self.eval_cache = initial_eval_cache;
                self.static_arrays = initial_static_arrays;
                self.engine
                    .set_static_arrays(std::sync::Arc::clone(&self.static_arrays));
                self.invalidate_layout_cache();
            }

            let has_error = !errors.is_empty();
            let result = ValidationResult { has_error, errors };

            if paths.is_none() || paths.is_some_and(|p| p.is_empty()) {
                if let Ok(mut cache) = self.validation_cache.write() {
                    cache.save_full_result(
                        data.to_string(),
                        context.map(|s| s.to_string()),
                        validate_ro,
                        inc_subforms,
                        result.clone(),
                    );
                }
            } else if let Ok(mut cache) = self.validation_cache.write() {
                cache.invalidate_full_result();
            }

            Ok(result)
        })
    }

    /// Validate using the data already present in `eval_data` (set by `with_item_cache_swap`).
    ///
    /// Skips JSON parsing and `replace_data_and_context` — use this inside the
    /// cache-swap closure to avoid redundant work when the subform data is already set.
    pub(crate) fn validate_pre_set(
        &mut self,
        data_value: Option<&Value>,
        paths: Option<&[String]>,
        token: Option<&CancellationToken>,
        validate_readonly: Option<bool>,
        re_evaluate_others: bool,
    ) -> Result<crate::ValidationResult, String> {
        let validate_ro = validate_readonly.unwrap_or(false);
        let _static_guard = self
            .engine
            .bind_static_arrays_scope(std::sync::Arc::clone(&self.static_arrays));
        if re_evaluate_others {
            // Re-evaluate rule evaluations with the current (already-set) data.
            self.evaluate_others(paths, token);
        }

        self.ensure_layout_resolved();

        let mut errors: IndexMap<String, ValidationError> = IndexMap::new();

        let layout_state = self.layout_state.read().unwrap();
        let layout_hidden_refs = &layout_state.layout_hidden_refs;
        let layout_disabled_refs = &layout_state.layout_disabled_refs;
        let mut hidden_cache =
            std::collections::HashMap::with_capacity(self.fields_with_rules.len());
        let mut readonly_cache =
            std::collections::HashMap::with_capacity(self.fields_with_rules.len());

        let target_data = if let Some(dv) = data_value {
            if dv.is_object()
                && self.fields_with_rules.iter().any(|f| {
                    let root = f.split('.').next().unwrap_or(f);
                    dv.get(root).is_some()
                })
            {
                dv
            } else {
                self.eval_data.data()
            }
        } else {
            self.eval_data.data()
        };

        for field_path in self.fields_with_rules.iter() {
            if let Some(filter_paths) = paths {
                if !filter_paths.is_empty()
                    && !filter_paths.iter().any(|p| {
                        field_path.starts_with(p.as_str()) || p.starts_with(field_path.as_str())
                    })
                {
                    continue;
                }
            }
            if let Some(t) = token {
                if t.is_cancelled() {
                    return Err("Cancelled".to_string());
                }
            }
            self.validate_field_cached(
                field_path,
                target_data,
                layout_hidden_refs,
                layout_disabled_refs,
                &mut hidden_cache,
                &mut readonly_cache,
                validate_ro,
                &mut errors,
            );
        }

        drop(layout_state);

        let has_error = !errors.is_empty();
        Ok(crate::ValidationResult { has_error, errors })
    }

    /// Validate a single field that has rules (convenience wrapper without external cache)
    #[allow(dead_code)]
    pub(crate) fn validate_field(
        &self,
        field_path: &str,
        data: &Value,
        validate_readonly: bool,
        errors: &mut IndexMap<String, ValidationError>,
    ) {
        let layout_state = self.layout_state.read().unwrap();
        let mut hidden_cache = std::collections::HashMap::new();
        let mut readonly_cache = std::collections::HashMap::new();
        self.validate_field_cached(
            field_path,
            data,
            &layout_state.layout_hidden_refs,
            &layout_state.layout_disabled_refs,
            &mut hidden_cache,
            &mut readonly_cache,
            validate_readonly,
            errors,
        );
    }

    /// Validate a single field that has rules, with pre-acquired layout refs and caches
    #[allow(clippy::too_many_arguments)]
    pub(crate) fn validate_field_cached(
        &self,
        field_path: &str,
        data: &Value,
        layout_hidden_refs: &indexmap::IndexSet<String>,
        layout_disabled_refs: &indexmap::IndexSet<String>,
        hidden_cache: &mut std::collections::HashMap<String, bool>,
        readonly_cache: &mut std::collections::HashMap<String, bool>,
        validate_readonly: bool,
        errors: &mut IndexMap<String, ValidationError>,
    ) {
        // Skip if already has error
        if errors.contains_key(field_path) {
            return;
        }

        // Resolve schema for this field
        let schema_path = path_utils::dot_notation_to_schema_pointer(field_path);
        let pointer_path = schema_path.trim_start_matches('#');

        // Try to get schema, if not found, try with /properties/ prefix for standard JSON Schema
        let (field_schema, resolved_path) = match self.evaluated_schema.pointer(pointer_path) {
            Some(s) => (s, pointer_path.to_string()),
            None => {
                let alt_path = format!("/properties{}", pointer_path);
                match self.evaluated_schema.pointer(&alt_path) {
                    Some(s) => (s, alt_path),
                    None => return,
                }
            }
        };

        // Skip hidden fields using cached layout & schema lookup
        let is_hidden =
            self.is_effective_hidden_with_cache(&resolved_path, layout_hidden_refs, hidden_cache);
        if is_hidden {
            if let Ok(mut cache) = self.validation_cache.write() {
                cache.update_field(
                    field_path.to_string(),
                    Value::Null,
                    true,
                    validate_readonly,
                    Value::Null,
                    None,
                );
            }
            return;
        }

        // Skip readonly / disabled fields unless validate_readonly is true
        if !validate_readonly {
            let is_readonly = self.is_effective_readonly_with_cache(
                &resolved_path,
                layout_disabled_refs,
                readonly_cache,
            );
            if is_readonly {
                if let Ok(mut cache) = self.validation_cache.write() {
                    cache.update_field(
                        field_path.to_string(),
                        Value::Null,
                        false,
                        false,
                        Value::Null,
                        None,
                    );
                }
                return;
            }
        }

        if let Value::Object(schema_map) = field_schema {
            // Get rules object
            let rules_val = match schema_map.get("rules") {
                Some(r @ Value::Object(_)) => r,
                _ => return,
            };
            let rules = rules_val.as_object().unwrap();

            // Get field data
            let field_data = self.get_field_data(field_path, data);

            // Check field cache
            let cached_lookup = if let Ok(cache) = self.validation_cache.read() {
                cache.check_field_cache(
                    field_path,
                    &field_data,
                    false,
                    validate_readonly,
                    rules_val,
                )
            } else {
                None
            };

            if let Some(cached_error) = cached_lookup {
                if let Some(err) = cached_error {
                    errors.insert(field_path.to_string(), err);
                }
                return;
            }

            // Validate each rule
            let mut field_error: Option<ValidationError> = None;
            time_block!("    validate_rules loop", {
                for (rule_name, rule_value) in rules {
                    self.validate_rule(
                        field_path,
                        rule_name,
                        rule_value,
                        &field_data,
                        schema_map,
                        field_schema,
                        errors,
                    );
                    if let Some(err) = errors.get(field_path) {
                        field_error = Some(err.clone());
                        break;
                    }
                }
            });

            if let Ok(mut cache) = self.validation_cache.write() {
                cache.update_field(
                    field_path.to_string(),
                    field_data,
                    false,
                    validate_readonly,
                    rules_val.clone(),
                    field_error,
                );
            }
        }
    }

    /// Get data value for a field path
    pub(crate) fn get_field_data(&self, field_path: &str, data: &Value) -> Value {
        let mut current = data;

        for part in field_path.split('.') {
            match current {
                Value::Object(map) => {
                    current = map.get(part).unwrap_or(&Value::Null);
                }
                _ => return Value::Null,
            }
        }

        current.clone()
    }

    /// Validate a single rule
    #[allow(clippy::too_many_arguments)]
    pub(crate) fn validate_rule(
        &self,
        field_path: &str,
        rule_name: &str,
        rule_value: &Value,
        field_data: &Value,
        schema_map: &serde_json::Map<String, Value>,
        _schema: &Value,
        errors: &mut IndexMap<String, ValidationError>,
    ) {
        // Skip if already has error
        if errors.contains_key(field_path) {
            return;
        }

        let schema_type = schema_map
            .get("type")
            .and_then(|t| t.as_str())
            .unwrap_or("");

        // The rule_value passed in already reflects the evaluated rule from evaluated_schema
        let evaluated_rule = rule_value;

        // Extract rule active status, message, etc
        // Logic depends on rule structure (object with value/message or direct value)
        let (rule_active, rule_message, rule_code, rule_data) = match evaluated_rule {
            Value::Object(rule_obj) => {
                let active = rule_obj.get("value").unwrap_or(&Value::Bool(false));

                // Handle message - could be string or object with "value"
                let message = match rule_obj.get("message") {
                    Some(Value::String(s)) => s.clone(),
                    Some(Value::Object(msg_obj)) if msg_obj.contains_key("value") => msg_obj
                        .get("value")
                        .and_then(|v| v.as_str())
                        .unwrap_or("Validation failed")
                        .to_string(),
                    Some(msg_val) => msg_val.as_str().unwrap_or("Validation failed").to_string(),
                    None => "Validation failed".to_string(),
                };

                let code = rule_obj
                    .get("code")
                    .and_then(|c| c.as_str())
                    .map(|s| s.to_string());

                // Handle data - extract "value" from objects with $evaluation
                let data = rule_obj.get("data").map(|d| {
                    if let Value::Object(data_obj) = d {
                        let mut cleaned_data = serde_json::Map::new();
                        for (key, value) in data_obj {
                            // If value is an object with only "value" key, extract it
                            if let Value::Object(val_obj) = value {
                                if val_obj.len() == 1 && val_obj.contains_key("value") {
                                    cleaned_data.insert(key.clone(), val_obj["value"].clone());
                                } else {
                                    cleaned_data.insert(key.clone(), value.clone());
                                }
                            } else {
                                cleaned_data.insert(key.clone(), value.clone());
                            }
                        }
                        Value::Object(cleaned_data)
                    } else {
                        d.clone()
                    }
                });

                (active.clone(), message, code, data)
            }
            _ => (
                evaluated_rule.clone(),
                "Validation failed".to_string(),
                None,
                None,
            ),
        };

        // Generate default code if not provided
        let error_code = rule_code.or_else(|| Some(format!("{}.{}", field_path, rule_name)));

        let is_empty = matches!(field_data, Value::Null)
            || (field_data.is_string() && field_data.as_str().unwrap_or("").is_empty())
            || (field_data.is_array() && field_data.as_array().unwrap().is_empty());

        match rule_name {
            "required" => {
                if rule_active == Value::Bool(true) {
                    if is_empty {
                        errors.insert(
                            field_path.to_string(),
                            ValidationError {
                                rule_type: "required".to_string(),
                                message: rule_message,
                                code: error_code,
                                pattern: None,
                                field_value: None,
                                data: build_error_data(
                                    rule_name,
                                    &rule_active,
                                    rule_data,
                                    schema_map,
                                ),
                            },
                        );
                    }
                }
            }
            "minLength" | "maxLength" | "minValue" | "maxValue" => {
                if rule_value_fails(rule_name, &rule_active, field_data, is_empty, schema_type) {
                    errors.insert(
                        field_path.to_string(),
                        ValidationError {
                            rule_type: rule_name.to_string(),
                            message: rule_message,
                            code: error_code,
                            pattern: None,
                            field_value: None,
                            data: build_error_data(rule_name, &rule_active, rule_data, schema_map),
                        },
                    );
                }
            }

            "pattern" => {
                if !is_empty {
                    if let Some(pattern) = rule_active.as_str() {
                        if let Some(text) = field_data.as_str() {
                            let cached_regex = if let Ok(cache) = self.regex_cache.read() {
                                cache.get(pattern).cloned()
                            } else {
                                None
                            };
                            let regex = match cached_regex {
                                Some(r) => r,
                                None => {
                                    let mut cache = self.regex_cache.write().unwrap();
                                    cache
                                        .entry(pattern.to_string())
                                        .or_insert_with(|| {
                                            regex::Regex::new(pattern).unwrap_or_else(|_| {
                                                regex::Regex::new("(?:)").unwrap()
                                            })
                                        })
                                        .clone()
                                }
                            };
                            if !regex.is_match(text) {
                                errors.insert(
                                    field_path.to_string(),
                                    ValidationError {
                                        rule_type: "pattern".to_string(),
                                        message: rule_message,
                                        code: error_code,
                                        pattern: Some(pattern.to_string()),
                                        field_value: Some(text.to_string()),
                                        data: build_error_data(
                                            rule_name,
                                            &rule_active,
                                            rule_data,
                                            schema_map,
                                        ),
                                    },
                                );
                            }
                        }
                    }
                }
            }
            "evaluation" => {
                // Handle array of evaluation rules
                // Format: "evaluation": [{ "code": "...", "message": "...", "$evaluation": {...} }]
                if let Value::Array(eval_array) = evaluated_rule {
                    for (idx, eval_item) in eval_array.iter().enumerate() {
                        if let Value::Object(eval_obj) = eval_item {
                            // Get the evaluated value (should be in "value" key after evaluation)
                            let eval_result = eval_obj.get("value").unwrap_or(&Value::Bool(true));

                            // Check if result is falsy
                            let is_falsy = match eval_result {
                                Value::Bool(false) => true,
                                Value::Null => true,
                                Value::Number(n) => n.as_f64() == Some(0.0),
                                Value::String(s) => s.is_empty(),
                                Value::Array(a) => a.is_empty(),
                                _ => false,
                            };

                            if is_falsy {
                                let eval_code = eval_obj
                                    .get("code")
                                    .and_then(|c| c.as_str())
                                    .map(|s| s.to_string())
                                    .or_else(|| Some(format!("{}.evaluation.{}", field_path, idx)));

                                let eval_message = eval_obj
                                    .get("message")
                                    .and_then(|m| m.as_str())
                                    .unwrap_or("Validation failed")
                                    .to_string();

                                let eval_data = eval_obj.get("data").cloned();

                                errors.insert(
                                    field_path.to_string(),
                                    ValidationError {
                                        rule_type: "evaluation".to_string(),
                                        message: eval_message,
                                        code: eval_code,
                                        pattern: None,
                                        field_value: None,
                                        data: build_error_data(
                                            "evaluation",
                                            &Value::Null,
                                            eval_data,
                                            schema_map,
                                        ),
                                    },
                                );

                                // Stop at first failure
                                break;
                            }
                        }
                    }
                }
            }
            _ => {
                if rule_value_fails(rule_name, &rule_active, field_data, is_empty, schema_type) {
                    errors.insert(
                        field_path.to_string(),
                        ValidationError {
                            rule_type: "evaluation".to_string(),
                            message: rule_message,
                            code: error_code,
                            pattern: None,
                            field_value: None,
                            data: build_error_data(rule_name, &rule_active, rule_data, schema_map),
                        },
                    );
                }
            }
        }
    }

    /// Returns `true` if `field_data` fails any of the dep field's schema rules.
    ///
    /// Rules are evaluated on-demand: compiled `LogicId`s from `self.evaluations` (set at
    /// construction time) are executed directly against `scope_data`, completely bypassing
    /// `evaluated_schema`. This avoids stale-cache issues during table dependency checks.
    /// Unlike `validate_field`, this also evaluates the `required` rule on-demand.
    pub(crate) fn dep_fails_schema_rules(
        &self,
        field_path: &str,
        field_data: &Value,
        scope_data: &Value,
    ) -> bool {
        let schema_pointer = path_utils::dot_notation_to_schema_pointer(field_path);
        let pointer = schema_pointer.trim_start_matches('#');

        let field_schema = match self.schema.pointer(pointer) {
            Some(s) => s,
            None => {
                let alt_pointer = format!("/properties{}", pointer);
                match self.schema.pointer(&alt_pointer) {
                    Some(s) => s,
                    None => return false,
                }
            }
        };

        let schema_map = match field_schema.as_object() {
            Some(m) => m,
            None => return false,
        };

        let rules = match schema_map.get("rules") {
            Some(Value::Object(r)) => r,
            _ => return false,
        };

        let schema_type = schema_map
            .get("type")
            .and_then(|t| t.as_str())
            .unwrap_or("");

        let is_empty = matches!(field_data, Value::Null)
            || field_data.as_str().map_or(false, |s| s.is_empty())
            || field_data.as_array().map_or(false, |a| a.is_empty());

        for (rule_name, rule_value) in rules {
            // Resolve the rule's active value on-demand.
            // If a compiled LogicId exists in self.evaluations for this rule path, run it fresh
            // against scope_data. Otherwise fall back to the static "value" from the raw schema.
            let rule_eval_key = format!("#{}/rules/{}", pointer, rule_name);
            let rule_active: Value = if let Some(logic_id) = self.evaluations.get(&rule_eval_key) {
                let empty_ctx = Value::Object(serde_json::Map::new());
                self.engine
                    .run_with_context(logic_id, scope_data, &empty_ctx)
                    .unwrap_or(Value::Null)
            } else {
                match rule_value {
                    Value::Object(obj) => obj.get("value").cloned().unwrap_or(Value::Null),
                    other => other.clone(),
                }
            };

            if rule_value_fails(rule_name, &rule_active, field_data, is_empty, schema_type) {
                return true;
            }
        }

        false
    }
}

/// Pure rule-check: returns `true` if `rule_active` indicates `field_data` fails the rule.
///
/// This is the shared comparison kernel used by both `validate_rule` (full validation path)
/// and `dep_fails_schema_rules` (on-demand dep checking). It is intentionally free of any
/// schema/cache lookups — callers are responsible for resolving `rule_active` beforehand.
///
/// Handles: `required`, `minLength`, `maxLength`, `minValue`, `maxValue`, and custom/dynamic.
/// Does NOT handle: `pattern` (needs regex cache), `evaluation` array format (complex structure).
fn rule_value_fails(
    rule_name: &str,
    rule_active: &Value,
    field_data: &Value,
    is_empty: bool,
    schema_type: &str,
) -> bool {
    let coerce_num = |v: &Value| -> Option<f64> {
        if let Some(n) = v.as_f64() {
            return Some(n);
        }
        if matches!(schema_type, "number" | "integer") {
            if let Some(s) = v.as_str() {
                return s.trim().parse::<f64>().ok();
            }
        }
        None
    };

    match rule_name {
        "required" => is_empty && matches!(rule_active, Value::Bool(true)),
        "minLength" => {
            if is_empty {
                false
            } else if let Some(min) = rule_active.as_u64() {
                let len = match field_data {
                    Value::String(s) => s.len(),
                    Value::Array(a) => a.len(),
                    _ => 0,
                };
                len < min as usize
            } else {
                false
            }
        }
        "maxLength" => {
            if is_empty {
                false
            } else if let Some(max) = rule_active.as_u64() {
                let len = match field_data {
                    Value::String(s) => s.len(),
                    Value::Array(a) => a.len(),
                    _ => 0,
                };
                len > max as usize
            } else {
                false
            }
        }
        "minValue" => {
            if is_empty {
                false
            } else if let Some(min) = rule_active.as_f64() {
                coerce_num(field_data).map_or(false, |v| v < min)
            } else {
                false
            }
        }
        "maxValue" => {
            if is_empty {
                false
            } else if let Some(max) = rule_active.as_f64() {
                coerce_num(field_data).map_or(false, |v| v > max)
            } else {
                false
            }
        }
        // pattern and evaluation array are handled by their specific callers
        "pattern" | "evaluation" => false,
        _ => {
            // Custom/dynamic rule: falsy rule_active = constraint not met = field invalid
            if is_empty {
                false
            } else {
                matches!(rule_active, Value::Bool(false) | Value::Null)
                    || rule_active.as_f64() == Some(0.0)
                    || rule_active.as_str().map_or(false, |s| s.is_empty())
                    || rule_active.as_array().map_or(false, |a| a.is_empty())
            }
        }
    }
}

/// Helper to construct and merge the `data` property of a `ValidationError`.
///
/// Populates:
/// - Field metadata: `title` and `description` from the field schema
/// - Rule constraints: `minValue`, `maxValue`, `minLength`, `maxLength` for the failing rule and companion rules
/// - Merged schema evaluation data from `rule_data`
fn build_error_data(
    rule_name: &str,
    rule_active: &Value,
    rule_data: Option<Value>,
    schema_map: &serde_json::Map<String, Value>,
) -> Option<Value> {
    let mut data_map = serde_json::Map::new();

    // 1. Field metadata (title and description)
    if let Some(title) = schema_map.get("title") {
        if !title.is_null() {
            data_map.insert("title".to_string(), title.clone());
        }
    }
    if let Some(description) = schema_map.get("description") {
        if !description.is_null() {
            data_map.insert("description".to_string(), description.clone());
        }
    }

    let get_rule_val = |r: &Value| -> Option<Value> {
        match r {
            Value::Object(obj) => obj.get("value").cloned(),
            other if !other.is_null() => Some(other.clone()),
            _ => None,
        }
    };

    // 2. Error rule constraints based on the failing rule
    match rule_name {
        "required" => {
            data_map.insert("required".to_string(), Value::Bool(true));
        }
        "minValue" => {
            data_map.insert("minValue".to_string(), rule_active.clone());
        }
        "maxValue" => {
            data_map.insert("maxValue".to_string(), rule_active.clone());
        }
        "minLength" => {
            data_map.insert("minLength".to_string(), rule_active.clone());
        }
        "maxLength" => {
            data_map.insert("maxLength".to_string(), rule_active.clone());
        }
        _ => {}
    }

    // 3. Companion rules from schema_map["rules"]
    if matches!(
        rule_name,
        "minValue" | "maxValue" | "minLength" | "maxLength"
    ) {
        if let Some(Value::Object(rules)) = schema_map.get("rules") {
            match rule_name {
                "minValue" => {
                    if let Some(max_rule) = rules.get("maxValue") {
                        if let Some(val) = get_rule_val(max_rule) {
                            data_map.insert("maxValue".to_string(), val);
                        }
                    }
                }
                "maxValue" => {
                    if let Some(min_rule) = rules.get("minValue") {
                        if let Some(val) = get_rule_val(min_rule) {
                            data_map.insert("minValue".to_string(), val);
                        }
                    }
                }
                "minLength" => {
                    if let Some(max_rule) = rules.get("maxLength") {
                        if let Some(val) = get_rule_val(max_rule) {
                            data_map.insert("maxLength".to_string(), val);
                        }
                    }
                }
                "maxLength" => {
                    if let Some(min_rule) = rules.get("minLength") {
                        if let Some(val) = get_rule_val(min_rule) {
                            data_map.insert("minLength".to_string(), val);
                        }
                    }
                }
                _ => {}
            }
        }
    }

    // 4. Merge schema evaluation data from rule_data
    if let Some(rule_d) = rule_data {
        if let Value::Object(schema_data) = rule_d {
            for (k, v) in schema_data {
                data_map.insert(k, v);
            }
        } else if data_map.is_empty() {
            return Some(rule_d);
        }
    }

    if data_map.is_empty() {
        None
    } else {
        Some(Value::Object(data_map))
    }
}