imp_core/

config.rs

use std::collections::{HashMap, HashSet};
use std::path::{Path, PathBuf};

use imp_llm::ThinkingLevel;
use serde::{Deserialize, Serialize};

use crate::error::Result;
use crate::guardrails::GuardrailConfig;
use crate::hooks::HookDef;
use crate::personality::PersonalityConfig;
use crate::roles::RoleDef;
use crate::storage;
use crate::tools::web::types::WebConfig;

/// Agent mode — controls which tools and mana actions the agent may use.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
#[serde(rename_all = "kebab-case")]
pub enum AgentMode {
    /// Default. Full access to all tools. No filtering.
    #[default]
    Full,
    /// Unit executor. Read + write + bash. No mana create/run.
    Worker,
    /// Plans and executes via mana. Cannot touch files directly.
    Orchestrator,
    /// Decomposes work. Can read and create mana units. Cannot run them.
    Planner,
    /// Read-only inspector. No mutations, no mana.
    Reviewer,
    /// Batch inspector. Reads code and mana state, produces reports.
    Auditor,
}

const WORKER_TOOLS: &[&str] = &[
    "read", "scan", "web", "recall", "write", "edit", "bash", "git", "mana", "ask_user",
];
const ORCHESTRATOR_TOOLS: &[&str] = &["read", "scan", "web", "recall", "mana", "git", "ask_user"];
const PLANNER_TOOLS: &[&str] = &["read", "scan", "web", "recall", "git", "mana", "ask_user"];
const REVIEWER_TOOLS: &[&str] = &["read", "scan", "web", "recall", "git", "ask_user"];
const AUDITOR_TOOLS: &[&str] = &["read", "scan", "web", "recall", "git", "mana"];

const WORKER_MANA_ACTIONS: &[&str] = &[
    "show",
    "update",
    "status",
    "list",
    "logs",
    "next",
    "verify",
    "notes_append",
];
const ORCHESTRATOR_MANA_ACTIONS: &[&str] = &[
    "status",
    "list",
    "show",
    "create",
    "close",
    "update",
    "run",
    "run_state",
    "evaluate",
    "claim",
    "release",
    "logs",
    "agents",
    "next",
    "tree",
    "reopen",
    "verify",
    "fail",
    "delete",
    "dep_add",
    "dep_remove",
    "fact_create",
    "fact_verify",
    "notes_append",
    "decision_add",
    "decision_resolve",
];
const PLANNER_MANA_ACTIONS: &[&str] = &[
    "status",
    "list",
    "show",
    "create",
    "update",
    "next",
    "tree",
    "dep_add",
    "dep_remove",
    "fact_create",
    "notes_append",
    "decision_add",
    "decision_resolve",
];
const AUDITOR_MANA_ACTIONS: &[&str] = &[
    "status",
    "list",
    "show",
    "logs",
    "agents",
    "next",
    "tree",
    "verify",
    "fact_verify",
];

impl AgentMode {
    /// Tool names this mode permits. An empty slice means "allow all" (Full).
    pub fn allowed_tool_names(&self) -> &'static [&'static str] {
        match self {
            AgentMode::Full => &[],
            AgentMode::Worker => WORKER_TOOLS,
            AgentMode::Orchestrator => ORCHESTRATOR_TOOLS,
            AgentMode::Planner => PLANNER_TOOLS,
            AgentMode::Reviewer => REVIEWER_TOOLS,
            AgentMode::Auditor => AUDITOR_TOOLS,
        }
    }

    /// Returns true if the mode allows the named tool.
    pub fn allows_tool(&self, name: &str) -> bool {
        match self {
            AgentMode::Full => true,
            _ => self.allowed_tool_names().contains(&name),
        }
    }

    /// Mana sub-actions this mode permits. An empty slice means "allow all" (Full).
    pub fn allowed_mana_actions(&self) -> &'static [&'static str] {
        match self {
            AgentMode::Full | AgentMode::Reviewer => &[],
            AgentMode::Worker => WORKER_MANA_ACTIONS,
            AgentMode::Orchestrator => ORCHESTRATOR_MANA_ACTIONS,
            AgentMode::Planner => PLANNER_MANA_ACTIONS,
            AgentMode::Auditor => AUDITOR_MANA_ACTIONS,
        }
    }

    /// Returns true if the mode allows the named mana action.
    pub fn allows_mana_action(&self, action: &str) -> bool {
        match self {
            AgentMode::Full => true,
            AgentMode::Reviewer => false,
            _ => self.allowed_mana_actions().contains(&action),
        }
    }

    /// Parse a mode from a string name (e.g. `"worker"`, `"full"`).
    ///
    /// Returns `None` for unrecognised names. Used to read `IMP_MODE` from the
    /// environment without requiring a full `FromStr` implementation.
    pub fn from_name(s: &str) -> Option<Self> {
        match s.to_lowercase().as_str() {
            "full" => Some(AgentMode::Full),
            "worker" => Some(AgentMode::Worker),
            "orchestrator" => Some(AgentMode::Orchestrator),
            "planner" => Some(AgentMode::Planner),
            "reviewer" => Some(AgentMode::Reviewer),
            "auditor" => Some(AgentMode::Auditor),
            _ => None,
        }
    }

    /// Mode-specific behavioral instruction for the system prompt, if any.
    pub fn instructions(&self) -> Option<&'static str> {
        match self {
            AgentMode::Full => None,
            AgentMode::Worker => Some(
                "You are a worker agent. Your job is to implement the assigned unit as specified and stay within its scope. \
                You may read files, write files, and run shell commands. Inspect the relevant files before making claims or changes, \
                use fast scoped checks for local feedback while implementing, and record meaningful progress or failure context with `mana update`. \
                Do not declare success if commands or checks fail; report the exact blocker and the next useful action. \
                Treat mana units as execution contracts: use their scope, dependencies, acceptance criteria, and verify gate before broadening the work. \
                You may not create, run, or close mana units — final verification and closure belong to the orchestrator workflow.",
            ),
            AgentMode::Orchestrator => Some(
                "You are an orchestrator agent. Use mana as your primary execution substrate for non-trivial work. \
                Inspect mana state before making claims about work status, avoid duplicating or fragmenting existing units, and enrich existing units when that is cleaner than creating new ones. \
                Write detailed units, split larger efforts into child units with dependencies, dispatch workers through mana, and own the final verification, retry, and closure workflow. \
                Use the full mana unit vocabulary when it helps: acceptance criteria, labels, dependencies, paths, requires, produces, decisions, and feature boundaries. \
                Encode unresolved questions as decisions instead of burying ambiguity in prose. \
                When the conversation itself is producing durable plans, architecture, migrations, or implementation structure, externalize that structure into mana during the conversation rather than waiting until the end. \
                Prefer native mana actions, including scope-aware and append-style updates, over shell or direct file edits for maintaining the work graph. \
                You may not read or write files directly — create and dispatch mana units for all file work. \
                Update units with concrete failure context and do not retry unchanged failed plans. \
                You are responsible for unit structure, completeness, and verify quality.",
            ),
            AgentMode::Planner => Some(
                "You are a planner agent. Your job is to decompose work into mana units. \
                Read enough code and context to ground the plan, cite concrete files or constraints when they matter, \
                and make dependencies, sequencing, acceptance criteria, and verify commands explicit. \
                Write worker-ready unit descriptions that include current state, concrete steps, file paths with intent, embedded context, scope boundaries, and what not to do. \
                Record unresolved questions as decisions when autonomous execution would otherwise require guessing. \
                Externalize durable planning structure into mana during the conversation, not only after the plan is complete. \
                Prefer append-style mana updates to keep the graph current as ideas sharpen. \
                You may read files and create units, but you may not run them — \
                a human or orchestrator will approve execution.",
            ),
            AgentMode::Reviewer => Some(
                "You are a reviewer agent. Your job is to read code and report findings. \
                Ground findings in inspected code, cite exact files or symbols when useful, and distinguish confirmed issues from possible concerns. \
                You may not write files, run commands, or use mana.",
            ),
            AgentMode::Auditor => Some(
                "You are an auditor agent. Your job is to inspect code and mana state \
                and produce structured reports. Ground conclusions in inspected evidence, cite the relevant files or mana objects, \
                and clearly separate facts, risks, and open questions. You may read files and mana status, \
                but you may not modify anything.",
            ),
        }
    }
}

/// Write tool overwrite safety policy.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
#[serde(rename_all = "snake_case")]
pub enum WriteOverwritePolicy {
    /// Allow overwrites but return warnings for unread/stale files.
    #[default]
    Warn,
    /// Block overwrites unless the file was read in this session and is not stale.
    RequireRead,
    /// Block only stale overwrites; unread overwrites still warn.
    BlockStale,
    /// Block all overwrites. New file creation is still allowed.
    Deny,
}

/// File write tool settings.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Default)]
pub struct WriteConfig {
    #[serde(default)]
    pub overwrite_policy: WriteOverwritePolicy,
}

/// Shell backend selection for the Bash tool.
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize, Default)]
#[serde(rename_all = "kebab-case")]
pub enum ShellBackend {
    /// Use a POSIX-compatible shell command. Defaults to `bash -c`.
    #[default]
    Sh,
    /// Use the rush library API (`rush::run`). Falls back to the configured shell if
    /// the `rush-backend` feature is not compiled in.
    Rush,
    /// Connect to a running rush daemon over Unix socket. Falls back to the configured shell
    /// if the daemon is not reachable.
    RushDaemon,
}

/// Shell-related configuration for the Bash tool.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct ShellConfig {
    /// Which shell backend to use. Defaults to the standard command shell.
    #[serde(default)]
    pub backend: ShellBackend,
    /// Shell executable used for command execution. Defaults to `bash`.
    #[serde(default)]
    pub command: Option<String>,
}

impl Default for ShellConfig {
    fn default() -> Self {
        Self {
            backend: ShellBackend::Sh,
            command: None,
        }
    }
}

/// Concrete capability policy for the shipped Lua extension runtime.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct LuaCapabilityPolicy {
    pub allow_native_tool_calls: bool,
    pub allow_shell_exec: bool,
    pub allow_http: bool,
    pub allow_secrets: bool,
    pub allowed_env: HashSet<String>,
}

impl Default for LuaCapabilityPolicy {
    fn default() -> Self {
        Self {
            allow_native_tool_calls: true,
            allow_shell_exec: false,
            allow_http: false,
            allow_secrets: false,
            allowed_env: HashSet::new(),
        }
    }
}

/// Configuration for the shipped Lua extension runtime.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Default)]
pub struct LuaConfig {
    /// Whether `imp.tool()` calls from Lua are allowed.
    pub allow_native_tool_calls: Option<bool>,
    /// Whether `imp.exec()` is allowed.
    pub allow_shell_exec: Option<bool>,
    /// Whether `imp.http.*` is allowed.
    pub allow_http: Option<bool>,
    /// Whether `imp.secret()` / `imp.secret_fields()` are allowed.
    pub allow_secrets: Option<bool>,
    /// Env vars Lua extensions may read through `imp.env()`.
    pub allowed_env: Option<Vec<String>>,
}

impl LuaConfig {
    #[must_use]
    pub fn resolve_policy(&self, mode: AgentMode) -> LuaCapabilityPolicy {
        let mut policy = LuaCapabilityPolicy::default();
        // Worker agents inherit the user's explicit Lua secret capability so
        // agent-invoked extension tools behave the same as the parent session.
        if matches!(mode, AgentMode::Worker) {
            policy.allow_secrets = self.allow_secrets.unwrap_or(false);
        }
        if let Some(value) = self.allow_native_tool_calls {
            policy.allow_native_tool_calls = value;
        }
        if let Some(value) = self.allow_shell_exec {
            policy.allow_shell_exec = value;
        }
        if let Some(value) = self.allow_http {
            policy.allow_http = value;
        }
        if let Some(value) = self.allow_secrets {
            policy.allow_secrets = value;
        }
        if let Some(values) = &self.allowed_env {
            policy.allowed_env = values.iter().cloned().collect();
        }
        policy
    }
}

/// Native command secret-injection policy.
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
pub struct SecretsConfig {
    #[serde(default)]
    pub commands: CommandSecretsConfig,
}

#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
pub struct CommandSecretsConfig {
    #[serde(default)]
    pub enabled: bool,
    #[serde(default)]
    pub allowed: Vec<AllowedCommandSecret>,
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct AllowedCommandSecret {
    pub name: String,
}

#[derive(Debug, Clone, Copy, Default, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "kebab-case")]
pub enum ManaScopePreference {
    #[default]
    Project,
    Root,
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct ManaRunConfig {
    /// Whether native mana runs should return immediately by default.
    #[serde(default = "default_enabled")]
    pub background: bool,
    /// Number of units to run in parallel by default.
    #[serde(default = "default_mana_run_jobs")]
    pub max_workers: u32,
    /// Continue running other ready units after one unit fails.
    #[serde(default)]
    pub continue_after_failure: bool,
    /// Review or evaluate units after a native run completes.
    #[serde(default)]
    pub review_after_run: bool,
}

impl Default for ManaRunConfig {
    fn default() -> Self {
        Self {
            background: true,
            max_workers: 4,
            continue_after_failure: false,
            review_after_run: false,
        }
    }
}

impl ManaRunConfig {
    fn is_default(&self) -> bool {
        self == &Self::default()
    }
}

fn default_enabled() -> bool {
    true
}

fn default_mana_run_jobs() -> u32 {
    4
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct ManaConfig {
    /// Default mana graph selection for native mana calls.
    #[serde(default)]
    pub scope: ManaScopePreference,
    /// Whether successful mana close operations should auto-commit mana changes.
    #[serde(default)]
    pub auto_commit: bool,
    /// Whether mana should close completed parent units after closing a child.
    #[serde(default = "default_true")]
    pub auto_close_parent: bool,
    /// Default verify timeout, in seconds, for close/create/verify flows.
    #[serde(default)]
    pub verify_timeout: Option<u64>,
    /// Native mana run defaults.
    #[serde(default, skip_serializing_if = "ManaRunConfig::is_default")]
    pub run: ManaRunConfig,
}

impl Default for ManaConfig {
    fn default() -> Self {
        Self {
            scope: ManaScopePreference::Project,
            auto_commit: false,
            auto_close_parent: true,
            verify_timeout: None,
            run: ManaRunConfig::default(),
        }
    }
}

/// Top-level configuration.
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
pub struct Config {
    /// Default model (alias or full ID).
    pub model: Option<String>,

    /// Default thinking level.
    pub thinking: Option<ThinkingLevel>,

    /// Default max output tokens per response.
    pub max_tokens: Option<u32>,

    /// Maximum agent turns.
    pub max_turns: Option<u32>,

    /// Active tool names (None = all).
    pub tools: Option<Vec<String>>,

    /// Named roles.
    #[serde(default)]
    pub roles: HashMap<String, RoleDef>,

    /// Hook definitions.
    #[serde(default)]
    pub hooks: Vec<HookDef>,

    /// Context management settings.
    #[serde(default)]
    pub context: ContextConfig,

    /// Shell backend settings.
    #[serde(default)]
    pub shell: ShellConfig,

    /// Write tool settings.
    #[serde(default)]
    pub write: WriteConfig,

    /// Engineering guardrails — profile-aware guidance and post-write checks.
    #[serde(default)]
    pub guardrails: GuardrailConfig,

    /// Agent mode — controls tool and mana action access.
    #[serde(default)]
    pub mode: AgentMode,

    /// Enabled models for the model selector (None = show all).
    /// Entries can be canonical IDs or aliases (e.g. "sonnet", "claude-sonnet-4-6").
    #[serde(default)]
    pub enabled_models: Option<Vec<String>>,

    /// Theme name ("default", "light", or custom).
    pub theme: Option<String>,

    /// Learning loop settings (memory, skill nudges).
    #[serde(default)]
    pub learning: LearningConfig,

    /// UI display settings.
    #[serde(default)]
    pub ui: UiConfig,

    /// Web tool settings.
    #[serde(default)]
    pub web: WebConfig,

    /// Mana tool settings.
    #[serde(default)]
    pub mana: ManaConfig,

    /// Shipped Lua extension runtime policy.
    #[serde(default)]
    pub lua: LuaConfig,

    /// Secret injection policy for native command execution.
    #[serde(default)]
    pub secrets: SecretsConfig,

    /// Personality settings, including identity sentence and saved profiles.
    #[serde(default)]
    pub personality: PersonalityConfig,
}

// ── UI configuration ────────────────────────────────────────────

/// How the sidebar displays tool calls.
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum SidebarStyle {
    /// Contextual inspector for the selected tool call.
    #[default]
    Inspector,
    /// Chronological stream of tool calls with inline results.
    Stream,
    /// Master-detail split: tool list (top) + selected output (bottom).
    Split,
}

/// How much tool output to show per tool call.
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum ToolOutputDisplay {
    /// Show all output lines (scrollable).
    Full,
    /// Show first N lines per tool (configurable via `tool_output_lines`).
    #[default]
    Compact,
    /// Headers only — expand on click/enter.
    Collapsed,
}

/// How tool calls appear inside the chat transcript.
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum ChatToolDisplay {
    /// Show tool calls inline where they occurred, preserving chronological order.
    Interleaved,
    /// Show a compact header in chat and leave details to the sidebar.
    #[default]
    Summary,
    /// Hide tool calls in chat entirely.
    Hidden,
}

/// UI animation intensity.
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum AnimationLevel {
    /// No animated motion; show static state labels only.
    None,
    /// Basic spinner-only motion.
    Spinner,
    /// Restrained motion with concise state-specific labels.
    #[default]
    #[serde(alias = "full")]
    Minimal,
}

/// Auto-continue policy for imp-local follow-on work.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
#[serde(rename_all = "kebab-case")]
pub enum ContinuePolicy {
    /// Never auto-continue on imp's own.
    #[default]
    Disabled,
    /// Only auto-continue when the runtime evidence is especially strong.
    Conservative,
    /// Auto-continue on clear, visible, mana-backed next steps.
    Balanced,
    /// More willing to auto-continue when the local heuristic says confidence is high.
    Aggressive,
}

/// UI display configuration.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct UiConfig {
    /// Sidebar layout style.
    #[serde(default)]
    pub sidebar_style: SidebarStyle,

    /// How much tool output to show.
    #[serde(default)]
    pub tool_output: ToolOutputDisplay,

    /// Max lines per tool in compact mode. Default: 10.
    #[serde(default = "default_tool_output_lines")]
    pub tool_output_lines: usize,

    /// Max lines the read tool returns before truncating. 0 disables line
    /// truncation for file reads. Default: 500.
    #[serde(default = "default_read_max_lines")]
    pub read_max_lines: usize,

    /// Sidebar width as percentage of screen (20-80). Default: 40.
    #[serde(default = "default_sidebar_width")]
    pub sidebar_width: u16,

    /// Word-wrap long lines in tool output. Default: true.
    #[serde(default = "default_true")]
    pub word_wrap: bool,

    /// Animation intensity for the TUI. Default: minimal.
    #[serde(default)]
    pub animations: AnimationLevel,

    /// Legacy compatibility flag for older configs. Prefer `chat_tool_display`.
    #[serde(default)]
    pub hide_tools_in_chat: bool,

    /// How tool calls should appear in the chat transcript.
    #[serde(default)]
    pub chat_tool_display: ChatToolDisplay,

    /// Auto-open the sidebar on the first tool call. Default: true.
    #[serde(default = "default_true")]
    pub auto_open_sidebar: bool,

    /// Minimum terminal width to auto-open sidebar. Default: 120.
    #[serde(default = "default_sidebar_auto_open_width")]
    pub sidebar_auto_open_width: u16,

    /// Number of thinking lines to show in the rolling tail. Default: 5.
    #[serde(default = "default_thinking_lines")]
    pub thinking_lines: usize,

    /// Number of streaming tool output lines to retain. Default: 5.
    #[serde(default = "default_streaming_lines")]
    pub streaming_lines: usize,

    /// Mouse wheel scroll speed in lines. Default: 3.
    #[serde(default = "default_mouse_scroll_lines")]
    pub mouse_scroll_lines: usize,

    /// Keyboard/page scroll speed in lines. Default: 20.
    #[serde(default = "default_keyboard_scroll_lines")]
    pub keyboard_scroll_lines: usize,

    /// Deprecated: mouse capture is now always enabled. This field is retained
    /// only for backwards-compatible deserialization of existing config files.
    #[serde(default)]
    #[doc(hidden)]
    pub mouse_capture: bool,

    /// Show timestamps in chat. Default: false.
    #[serde(default)]
    pub show_timestamps: bool,

    /// Show cost in the top bar. Default: true.
    #[serde(default = "default_true")]
    pub show_cost: bool,

    /// Show context usage in the top bar. Default: true.
    #[serde(default = "default_true")]
    pub show_context_usage: bool,

    /// Emit a terminal bell when an agent run fully completes in the TUI.
    /// Default: true.
    #[serde(default = "default_true")]
    pub notify_on_agent_complete: bool,

    /// Policy for imp-local automatic continuation after a visible, high-confidence turn.
    /// Default: disabled.
    #[serde(default)]
    pub continue_policy: ContinuePolicy,

    /// Maximum number of automatic Build-mode task turns before pausing.
    /// Default: 20.
    #[serde(default = "default_build_auto_turn_budget")]
    pub build_auto_turn_budget: u32,

    /// Maximum number of automatic Improve-mode research turns before pausing.
    /// Default: 5.
    #[serde(default = "default_improve_auto_turn_budget")]
    pub improve_auto_turn_budget: u32,

    /// Maximum number of `/loop` automatic turns before pausing.
    /// 0 disables the imp-level loop cap. Default: 0.
    #[serde(default)]
    pub loop_turn_budget: u32,
}

fn default_tool_output_lines() -> usize {
    10
}
fn default_read_max_lines() -> usize {
    500
}
fn default_sidebar_width() -> u16 {
    40
}
fn default_sidebar_auto_open_width() -> u16 {
    120
}
fn default_thinking_lines() -> usize {
    5
}
fn default_streaming_lines() -> usize {
    5
}
fn default_mouse_scroll_lines() -> usize {
    3
}
fn default_keyboard_scroll_lines() -> usize {
    20
}
fn default_build_auto_turn_budget() -> u32 {
    20
}
fn default_improve_auto_turn_budget() -> u32 {
    5
}

impl Default for UiConfig {
    fn default() -> Self {
        Self {
            sidebar_style: SidebarStyle::default(),
            tool_output: ToolOutputDisplay::default(),
            tool_output_lines: default_tool_output_lines(),
            read_max_lines: default_read_max_lines(),
            sidebar_width: default_sidebar_width(),
            word_wrap: default_true(),
            animations: AnimationLevel::default(),
            hide_tools_in_chat: false,
            chat_tool_display: ChatToolDisplay::default(),
            auto_open_sidebar: default_true(),
            sidebar_auto_open_width: default_sidebar_auto_open_width(),
            thinking_lines: default_thinking_lines(),
            streaming_lines: default_streaming_lines(),
            mouse_scroll_lines: default_mouse_scroll_lines(),
            keyboard_scroll_lines: default_keyboard_scroll_lines(),
            mouse_capture: false,
            show_timestamps: false,
            show_cost: true,
            show_context_usage: true,
            notify_on_agent_complete: true,
            continue_policy: ContinuePolicy::Disabled,
            build_auto_turn_budget: default_build_auto_turn_budget(),
            improve_auto_turn_budget: default_improve_auto_turn_budget(),
            loop_turn_budget: 0,
        }
    }
}

impl UiConfig {
    pub fn effective_chat_tool_display(&self) -> ChatToolDisplay {
        if self.hide_tools_in_chat && self.sidebar_style != SidebarStyle::Inspector {
            ChatToolDisplay::Hidden
        } else if self.sidebar_style == SidebarStyle::Inspector {
            ChatToolDisplay::Summary
        } else {
            self.chat_tool_display
        }
    }
}

/// Learning loop configuration.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct LearningConfig {
    /// Master switch for memory + skill nudges. Default: true.
    #[serde(default = "default_true")]
    pub enabled: bool,

    /// Tool call count before suggesting skill creation. Default: 8.
    #[serde(default = "default_nudge_threshold")]
    pub skill_nudge_threshold: u32,

    /// Character limit for memory.md. Default: 2200.
    #[serde(default = "default_memory_limit")]
    pub memory_char_limit: usize,

    /// Character limit for user.md. Default: 1400.
    #[serde(default = "default_user_limit")]
    pub user_char_limit: usize,
}

fn default_true() -> bool {
    true
}
fn default_nudge_threshold() -> u32 {
    8
}
fn default_memory_limit() -> usize {
    2200
}
fn default_user_limit() -> usize {
    1400
}

impl Default for LearningConfig {
    fn default() -> Self {
        Self {
            enabled: default_true(),
            skill_nudge_threshold: default_nudge_threshold(),
            memory_char_limit: default_memory_limit(),
            user_char_limit: default_user_limit(),
        }
    }
}

#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, Default)]
#[serde(rename_all = "kebab-case")]
pub enum AutoCompactionMode {
    /// Automatic context compaction is disabled; manual `/compact` only.
    #[default]
    Disabled,
    /// Reserved placeholder for future near-threshold auto-compaction.
    NearThreshold,
    /// Reserved placeholder for future aggressive auto-compaction.
    Aggressive,
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct AutoCompactionConfig {
    /// Placeholder mode selection for future auto-compaction design.
    #[serde(default)]
    pub mode: AutoCompactionMode,
}

impl Default for AutoCompactionConfig {
    fn default() -> Self {
        Self {
            mode: AutoCompactionMode::Disabled,
        }
    }
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct ContextConfig {
    /// Mask old tool outputs at this ratio (default: 0.6).
    pub observation_mask_threshold: f64,

    /// Keep last N turns unmasked (default: 10).
    pub mask_window: usize,

    /// Placeholder auto-compaction settings. Disabled by default.
    #[serde(default)]
    pub auto_compaction: AutoCompactionConfig,
}

impl Default for ContextConfig {
    fn default() -> Self {
        Self {
            observation_mask_threshold: 0.6,
            mask_window: 10,
            auto_compaction: AutoCompactionConfig::default(),
        }
    }
}

impl Config {
    /// Load config from a TOML file.
    pub fn load(path: &Path) -> Result<Self> {
        if !path.exists() {
            return Ok(Self::default());
        }
        let content = std::fs::read_to_string(path)?;
        let config: Config = toml::from_str(&content)?;
        Ok(config)
    }

    /// Resolve the full config by merging: defaults < user < project < env < CLI.
    pub fn resolve(user_config_dir: &Path, project_dir: Option<&Path>) -> Result<Self> {
        let mut config = Self::default();

        // User config
        let user_path = user_config_dir.join("config.toml");
        if user_path.exists() {
            let user = Self::load(&user_path)?;
            config.merge(user);
        }

        // Project config
        if let Some(project) = project_dir {
            let project_path = project.join(".imp").join("config.toml");
            if project_path.exists() {
                let project = Self::load(&project_path)?;
                config.merge(project);
            }
        }

        // Env overrides
        if let Ok(model) = std::env::var("IMP_MODEL") {
            config.model = Some(model);
        }
        if let Ok(thinking) = std::env::var("IMP_THINKING") {
            config.thinking = parse_thinking_level(&thinking);
        }
        if let Ok(max_tokens) = std::env::var("IMP_MAX_TOKENS") {
            if let Ok(parsed) = max_tokens.parse::<u32>() {
                config.max_tokens = Some(parsed);
            }
        }
        if let Ok(mode) = std::env::var("IMP_MODE") {
            if let Some(m) = parse_agent_mode(&mode) {
                config.mode = m;
            }
        }
        if let Ok(provider) = std::env::var("IMP_WEB_PROVIDER") {
            config.web.search_provider = match provider.to_lowercase().as_str() {
                "tavily" => Some(crate::tools::web::types::SearchProvider::Tavily),
                "exa" => Some(crate::tools::web::types::SearchProvider::Exa),
                "linkup" => Some(crate::tools::web::types::SearchProvider::Linkup),
                "perplexity" => Some(crate::tools::web::types::SearchProvider::Perplexity),
                _ => config.web.search_provider,
            };
        }

        Ok(config)
    }

    fn merge(&mut self, other: Config) {
        if other.model.is_some() {
            self.model = other.model;
        }
        if other.thinking.is_some() {
            self.thinking = other.thinking;
        }
        if other.max_tokens.is_some() {
            self.max_tokens = other.max_tokens;
        }
        if other.max_turns.is_some() {
            self.max_turns = other.max_turns;
        }
        if other.tools.is_some() {
            self.tools = other.tools;
        }
        if other.context != ContextConfig::default() {
            self.context = other.context;
        }
        if other.shell != ShellConfig::default() {
            self.shell = other.shell;
        }
        self.guardrails.merge(other.guardrails);
        if other.mode != AgentMode::default() {
            self.mode = other.mode;
        }
        if other.enabled_models.is_some() {
            self.enabled_models = other.enabled_models;
        }
        if other.theme.is_some() {
            self.theme = other.theme;
        }
        if other.learning != LearningConfig::default() {
            self.learning = other.learning;
        }
        if other.ui != UiConfig::default() {
            self.ui = other.ui;
        }
        if other.web != WebConfig::default() {
            self.web = other.web;
        }
        if other.mana != ManaConfig::default() {
            self.mana = other.mana;
        }
        if other.lua != LuaConfig::default() {
            self.lua = other.lua;
        }
        if other.secrets != SecretsConfig::default() {
            self.secrets = other.secrets;
        }
        if other.personality != PersonalityConfig::default() {
            self.personality.merge(other.personality);
        }
        self.roles.extend(other.roles);
        self.hooks.extend(other.hooks);
    }

    /// Default user config directory.
    pub fn user_config_dir() -> PathBuf {
        storage::global_root()
    }

    /// Default session directory.
    pub fn session_dir() -> PathBuf {
        storage::global_sessions_dir()
    }

    /// Save config to a TOML file. Creates parent directories if needed.
    pub fn save(&self, path: &Path) -> Result<()> {
        if let Some(parent) = path.parent() {
            std::fs::create_dir_all(parent)?;
        }
        let content =
            toml::to_string_pretty(self).map_err(|e| crate::error::Error::Config(e.to_string()))?;
        std::fs::write(path, content)?;
        Ok(())
    }

    /// Path to the user config.toml file.
    pub fn user_config_path() -> PathBuf {
        storage::global_config_path()
    }
}

fn parse_agent_mode(s: &str) -> Option<AgentMode> {
    AgentMode::from_name(s)
}

fn parse_thinking_level(s: &str) -> Option<ThinkingLevel> {
    match s.to_lowercase().as_str() {
        "off" => Some(ThinkingLevel::Off),
        "minimal" => Some(ThinkingLevel::Minimal),
        "low" => Some(ThinkingLevel::Low),
        "medium" => Some(ThinkingLevel::Medium),
        "high" => Some(ThinkingLevel::High),
        "xhigh" => Some(ThinkingLevel::XHigh),
        _ => None,
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::fs;
    use tempfile::TempDir;

    #[test]
    fn config_default_values() {
        let config = Config::default();
        assert!(config.model.is_none());
        assert!(config.thinking.is_none());
        assert!(config.max_tokens.is_none());
        assert!(config.max_turns.is_none());
        assert!(config.tools.is_none());
        assert_eq!(config.ui.read_max_lines, 500);
        assert_eq!(config.ui.sidebar_style, SidebarStyle::Inspector);
        assert_eq!(config.ui.chat_tool_display, ChatToolDisplay::Summary);
        assert_eq!(config.ui.tool_output, ToolOutputDisplay::Compact);
        assert_eq!(config.web, WebConfig::default());
        assert_eq!(config.personality, PersonalityConfig::default());
        assert!(config.roles.is_empty());
        assert!(config.hooks.is_empty());
        assert!((config.context.observation_mask_threshold - 0.6).abs() < f64::EPSILON);
        assert_eq!(config.context.mask_window, 10);
        assert_eq!(
            config.context.auto_compaction.mode,
            AutoCompactionMode::Disabled
        );
        assert_eq!(config.guardrails, GuardrailConfig::default());
    }

    #[test]
    fn inspector_sidebar_keeps_tool_calls_in_chat_summary() {
        let mut ui = UiConfig {
            sidebar_style: SidebarStyle::Inspector,
            chat_tool_display: ChatToolDisplay::Interleaved,
            ..Default::default()
        };
        assert_eq!(ui.effective_chat_tool_display(), ChatToolDisplay::Summary);

        ui.chat_tool_display = ChatToolDisplay::Hidden;
        ui.hide_tools_in_chat = true;
        assert_eq!(ui.effective_chat_tool_display(), ChatToolDisplay::Summary);

        ui.sidebar_style = SidebarStyle::Stream;
        assert_eq!(ui.effective_chat_tool_display(), ChatToolDisplay::Hidden);
    }

    #[test]
    fn config_load_from_toml() {
        let dir = TempDir::new().unwrap();
        let config_path = dir.path().join("config.toml");
        fs::write(
            &config_path,
            r#"
model = "sonnet"
thinking = "high"
max_tokens = 2048
max_turns = 50
tools = ["read", "write", "bash"]

[guardrails]
enabled = true
level = "enforce"
profile = "zig"
critical_paths = ["src/**"]
after_write = ["zig fmt --check ."]

[context]
observation_mask_threshold = 0.5
mask_window = 5

[shell]
command = "zsh"

[web]
search_provider = "exa"
"#,
        )
        .unwrap();

        let config = Config::load(&config_path).unwrap();
        assert_eq!(config.model.as_deref(), Some("sonnet"));
        assert_eq!(config.thinking, Some(ThinkingLevel::High));
        assert_eq!(config.max_tokens, Some(2048));
        assert_eq!(config.max_turns, Some(50));
        assert_eq!(config.tools.as_ref().unwrap().len(), 3);
        assert_eq!(config.guardrails.enabled, Some(true));
        assert_eq!(config.ui.read_max_lines, 500);
        assert_eq!(
            config.guardrails.profile,
            Some(crate::guardrails::GuardrailProfile::Zig)
        );
        assert_eq!(
            config.guardrails.after_write,
            Some(vec!["zig fmt --check .".into()])
        );
        assert_eq!(config.shell.command.as_deref(), Some("zsh"));
        assert_eq!(
            config.web.search_provider,
            Some(crate::tools::web::types::SearchProvider::Exa)
        );
        assert!((config.context.observation_mask_threshold - 0.5).abs() < f64::EPSILON);
        assert_eq!(config.context.mask_window, 5);
        assert_eq!(
            config.context.auto_compaction.mode,
            AutoCompactionMode::Disabled
        );
    }

    #[test]
    fn config_load_missing_file_returns_default() {
        let dir = TempDir::new().unwrap();
        let config_path = dir.path().join("nonexistent.toml");
        let config = Config::load(&config_path).unwrap();
        assert!(config.model.is_none());
    }

    #[test]
    fn config_loads_personality_section() {
        let dir = TempDir::new().unwrap();
        let config_path = dir.path().join("config.toml");
        fs::write(
            &config_path,
            r#"
[personality.profile.identity]
name = "Nova"
work_style = "careful"
voice = "clear"
focus = "research"
role = "assistant"

[personality.profile.sliders]
autonomy = "low"
verbosity = "high"
caution = "very-high"
warmth = "high"
planning_depth = "very-high"

[personality.profiles]
active = "researcher"

[personality.profiles.saved.researcher.identity]
name = "Nova"
work_style = "careful"
voice = "clear"
focus = "research"
role = "assistant"
"#,
        )
        .unwrap();

        let config = Config::load(&config_path).unwrap();
        assert_eq!(config.personality.profile.identity.name, "Nova");
        assert_eq!(
            config.personality.profile.identity.render_sentence(),
            "You are Nova, a careful, clear, research assistant."
        );
        assert_eq!(
            config.personality.profiles.active.as_deref(),
            Some("researcher")
        );
        assert!(config.personality.profiles.saved.contains_key("researcher"));
    }

    #[test]
    fn config_merge_personality_project_overrides_user_and_keeps_saved_profiles() {
        let mut user = Config::default();
        user.personality.profile.identity.name = "imp".into();
        user.personality.profiles.active = Some("builder".into());
        user.personality.profiles.saved.insert(
            "builder".into(),
            crate::personality::PersonalityProfile::default(),
        );

        let mut project = Config::default();
        project.personality.profile.identity.name = "Patch".into();
        project.personality.profiles.active = Some("reviewer".into());
        project.personality.profiles.saved.insert(
            "reviewer".into(),
            crate::personality::PersonalityProfile::default(),
        );

        user.merge(project);

        assert_eq!(user.personality.profile.identity.name, "Patch");
        assert_eq!(
            user.personality.profiles.active.as_deref(),
            Some("reviewer")
        );
        assert!(user.personality.profiles.saved.contains_key("builder"));
        assert!(user.personality.profiles.saved.contains_key("reviewer"));
    }

    #[test]
    fn config_merge_project_overrides_user() {
        let mut user = Config {
            model: Some("haiku".into()),
            max_tokens: Some(1024),
            max_turns: Some(20),
            ..Default::default()
        };

        let project = Config {
            model: Some("sonnet".into()),
            max_tokens: None,
            max_turns: None, // not set → user value preserved
            ..Default::default()
        };

        user.merge(project);
        assert_eq!(user.model.as_deref(), Some("sonnet"));
        assert_eq!(user.max_tokens, Some(1024));
        assert_eq!(user.max_turns, Some(20));
    }

    #[test]
    fn config_merge_roles_extend() {
        let mut base = Config::default();
        base.roles.insert(
            "worker".into(),
            RoleDef {
                model: Some("haiku".into()),
                thinking: None,
                tools: None,
                readonly: false,
                instructions: None,
            },
        );

        let overlay = Config {
            roles: {
                let mut m = HashMap::new();
                m.insert(
                    "reviewer".into(),
                    RoleDef {
                        model: Some("sonnet".into()),
                        thinking: Some(ThinkingLevel::High),
                        tools: None,
                        readonly: true,
                        instructions: None,
                    },
                );
                m
            },
            ..Default::default()
        };

        base.merge(overlay);
        assert!(base.roles.contains_key("worker"));
        assert!(base.roles.contains_key("reviewer"));
    }

    #[test]
    fn config_merge_hooks_extend() {
        let mut base = Config::default();
        base.hooks.push(HookDef {
            event: "after_file_write".into(),
            match_pattern: None,
            action: "log".into(),
            command: None,
            blocking: false,
            threshold: None,
        });

        let overlay = Config {
            hooks: vec![HookDef {
                event: "before_tool_call".into(),
                match_pattern: None,
                action: "block".into(),
                command: None,
                blocking: true,
                threshold: None,
            }],
            ..Default::default()
        };

        base.merge(overlay);
        assert_eq!(base.hooks.len(), 2);
    }

    #[test]
    fn config_merge_context_overrides_default() {
        let mut base = Config::default();

        let overlay = Config {
            context: ContextConfig {
                observation_mask_threshold: 0.5,
                mask_window: 5,
                auto_compaction: AutoCompactionConfig {
                    mode: AutoCompactionMode::NearThreshold,
                },
            },
            ..Default::default()
        };

        base.merge(overlay);
        assert!((base.context.observation_mask_threshold - 0.5).abs() < f64::EPSILON);
        assert_eq!(base.context.mask_window, 5);
        assert_eq!(
            base.context.auto_compaction.mode,
            AutoCompactionMode::NearThreshold
        );
    }

    #[test]
    fn config_merge_includes_theme_learning_and_lua() {
        let mut base = Config::default();
        let overlay = Config {
            theme: Some("light".into()),
            learning: LearningConfig {
                enabled: false,
                skill_nudge_threshold: 3,
                memory_char_limit: 1000,
                user_char_limit: 700,
            },
            lua: LuaConfig {
                allow_native_tool_calls: Some(false),
                allow_shell_exec: Some(true),
                allow_http: None,
                allow_secrets: None,
                allowed_env: Some(vec!["HOME".into()]),
            },
            ..Default::default()
        };

        base.merge(overlay);

        assert_eq!(base.theme.as_deref(), Some("light"));
        assert_eq!(base.learning.skill_nudge_threshold, 3);
        assert!(!base.learning.enabled);
        assert_eq!(base.lua.allow_native_tool_calls, Some(false));
        assert_eq!(base.lua.allow_shell_exec, Some(true));
        assert_eq!(base.lua.allowed_env, Some(vec!["HOME".into()]));
    }

    #[test]
    fn config_merge_guardrails_preserves_unspecified_fields() {
        let mut base = Config::default();
        base.guardrails.enabled = Some(true);
        base.guardrails.profile = Some(crate::guardrails::GuardrailProfile::Rust);
        base.guardrails.critical_paths = Some(vec!["src/**".into()]);

        let mut overlay = Config::default();
        overlay.guardrails.level = Some(crate::guardrails::GuardrailLevel::Enforce);
        overlay.guardrails.after_write = Some(vec!["cargo test".into()]);

        base.merge(overlay);

        assert_eq!(base.guardrails.enabled, Some(true));
        assert_eq!(
            base.guardrails.profile,
            Some(crate::guardrails::GuardrailProfile::Rust)
        );
        assert_eq!(base.guardrails.critical_paths, Some(vec!["src/**".into()]));
        assert_eq!(
            base.guardrails.level,
            Some(crate::guardrails::GuardrailLevel::Enforce)
        );
        assert_eq!(base.guardrails.after_write, Some(vec!["cargo test".into()]));
    }

    #[test]
    fn config_resolve_user_then_project() {
        // Clean env to avoid interference from parallel tests
        std::env::remove_var("IMP_MODEL");
        std::env::remove_var("IMP_THINKING");

        let dir = TempDir::new().unwrap();
        let user_dir = dir.path().join("user");
        let project_dir = dir.path().join("project");
        fs::create_dir_all(&user_dir).unwrap();
        fs::create_dir_all(project_dir.join(".imp")).unwrap();

        // User config: model=haiku, max_turns=20, custom context
        fs::write(
            user_dir.join("config.toml"),
            r#"
model = "haiku"
max_turns = 20

[context]
observation_mask_threshold = 0.55
mask_window = 9

[context.auto_compaction]
mode = "disabled"
"#,
        )
        .unwrap();

        // Project config: model=sonnet (overrides user), custom context overrides user context
        fs::write(
            project_dir.join(".imp").join("config.toml"),
            r#"
model = "sonnet"

[context]
observation_mask_threshold = 0.5
mask_window = 5

[context.auto_compaction]
mode = "disabled"
"#,
        )
        .unwrap();

        let config = Config::resolve(&user_dir, Some(&project_dir)).unwrap();
        assert_eq!(config.model.as_deref(), Some("sonnet"));
        assert_eq!(config.max_turns, Some(20));
        assert!((config.context.observation_mask_threshold - 0.5).abs() < f64::EPSILON);
        assert_eq!(config.context.mask_window, 5);
    }

    #[test]
    fn config_resolve_env_overrides() {
        // Test env override logic without relying on process-global state
        // (env vars are inherently racy in parallel tests).
        // We test that the override *mechanism* works by simulating it.
        let mut config = Config {
            model: Some("haiku".into()),
            thinking: Some(ThinkingLevel::Low),
            max_tokens: Some(2048),
            ..Default::default()
        };

        // Simulate IMP_MODEL override
        let env_model = "opus";
        config.model = Some(env_model.into());

        // Simulate IMP_THINKING override
        let env_thinking = "high";
        config.thinking = parse_thinking_level(env_thinking);

        // Simulate IMP_MAX_TOKENS override
        let env_max_tokens = "1024";
        config.max_tokens = env_max_tokens.parse::<u32>().ok();

        assert_eq!(config.model.as_deref(), Some("opus"));
        assert_eq!(config.thinking, Some(ThinkingLevel::High));
        assert_eq!(config.max_tokens, Some(1024));
    }

    #[test]
    fn config_resolve_missing_files_uses_defaults() {
        let dir = TempDir::new().unwrap();
        let config = Config::resolve(dir.path(), None).unwrap();
        assert!(config.model.is_none());
        assert!(config.thinking.is_none());
        assert!(config.max_tokens.is_none());
        assert!(config.max_turns.is_none());
    }

    #[test]
    fn config_load_with_roles_and_hooks() {
        let dir = TempDir::new().unwrap();
        let config_path = dir.path().join("config.toml");
        fs::write(
            &config_path,
            r#"
model = "sonnet"

[roles.coder]
model = "opus"
thinking = "high"
readonly = false

[roles.reader]
readonly = true

[[hooks]]
event = "after_file_write"
action = "log"
blocking = false
"#,
        )
        .unwrap();

        let config = Config::load(&config_path).unwrap();
        assert_eq!(config.roles.len(), 2);
        assert!(config.roles.contains_key("coder"));
        assert!(config.roles.contains_key("reader"));
        assert_eq!(config.roles["coder"].model.as_deref(), Some("opus"));
        assert!(config.roles["reader"].readonly);
        assert_eq!(config.hooks.len(), 1);
        assert_eq!(config.hooks[0].event, "after_file_write");
    }

    #[test]
    fn config_parse_thinking_levels() {
        assert_eq!(parse_thinking_level("off"), Some(ThinkingLevel::Off));
        assert_eq!(
            parse_thinking_level("minimal"),
            Some(ThinkingLevel::Minimal)
        );
        assert_eq!(parse_thinking_level("low"), Some(ThinkingLevel::Low));
        assert_eq!(parse_thinking_level("medium"), Some(ThinkingLevel::Medium));
        assert_eq!(parse_thinking_level("high"), Some(ThinkingLevel::High));
        assert_eq!(parse_thinking_level("xhigh"), Some(ThinkingLevel::XHigh));
        assert_eq!(parse_thinking_level("OFF"), Some(ThinkingLevel::Off));
        assert_eq!(parse_thinking_level("High"), Some(ThinkingLevel::High));
        assert_eq!(parse_thinking_level("invalid"), None);
        assert_eq!(parse_thinking_level(""), None);
    }

    #[test]
    fn config_partial_toml_fills_defaults() {
        let dir = TempDir::new().unwrap();
        let config_path = dir.path().join("config.toml");
        fs::write(
            &config_path,
            r#"
model = "sonnet"
"#,
        )
        .unwrap();

        let config = Config::load(&config_path).unwrap();
        assert_eq!(config.model.as_deref(), Some("sonnet"));
        // Unspecified fields use defaults
        assert!(config.thinking.is_none());
        assert!(config.max_tokens.is_none());
        assert!(config.max_turns.is_none());
        assert!((config.context.observation_mask_threshold - 0.6).abs() < f64::EPSILON);
    }

    // --- AgentMode tests ---

    #[test]
    fn agent_mode_default_is_full() {
        let config = Config::default();
        assert_eq!(config.mode, AgentMode::Full);
        assert_eq!(AgentMode::default(), AgentMode::Full);
    }

    #[test]
    fn lua_config_resolves_capability_policy() {
        let config = LuaConfig {
            allow_native_tool_calls: Some(false),
            allow_shell_exec: Some(true),
            allow_http: Some(true),
            allow_secrets: Some(true),
            allowed_env: Some(vec!["OPENAI_API_KEY".to_string(), "HOME".to_string()]),
        };

        let policy = config.resolve_policy(AgentMode::Worker);
        assert!(!policy.allow_native_tool_calls);
        assert!(policy.allow_shell_exec);
        assert!(policy.allow_http);
        assert!(policy.allow_secrets);
        assert!(policy.allowed_env.contains("OPENAI_API_KEY"));
        assert!(policy.allowed_env.contains("HOME"));
    }

    #[test]
    fn worker_lua_policy_preserves_configured_secret_access() {
        let enabled = LuaConfig {
            allow_secrets: Some(true),
            ..Default::default()
        };
        assert!(enabled.resolve_policy(AgentMode::Worker).allow_secrets);

        let disabled = LuaConfig {
            allow_secrets: Some(false),
            ..Default::default()
        };
        assert!(!disabled.resolve_policy(AgentMode::Worker).allow_secrets);

        assert!(
            !LuaConfig::default()
                .resolve_policy(AgentMode::Worker)
                .allow_secrets
        );
    }

    #[test]
    fn agent_mode_full_allows_all_tools() {
        let mode = AgentMode::Full;
        assert!(mode.allows_tool("anything"));
        assert!(mode.allows_tool("read"));
        assert!(mode.allows_tool("bash"));
        assert!(mode.allows_tool("nonexistent_future_tool"));
        assert_eq!(mode.allowed_tool_names(), &[] as &[&str]);
    }

    #[test]
    fn agent_mode_orchestrator_allows_read() {
        let mode = AgentMode::Orchestrator;
        assert!(mode.allows_tool("read"));
        assert!(mode.allows_tool("scan"));
        assert!(mode.allows_tool("web"));
        assert!(mode.allows_tool("git"));
        assert!(mode.allows_tool("recall"));
        assert!(mode.allows_tool("mana"));
        assert!(mode.allows_tool("ask_user"));
    }

    #[test]
    fn agent_mode_orchestrator_blocks_write() {
        let mode = AgentMode::Orchestrator;
        assert!(!mode.allows_tool("write"));
        assert!(!mode.allows_tool("edit"));
        assert!(!mode.allows_tool("bash"));
    }

    #[test]
    fn non_full_modes_block_removed_ask_agent() {
        for mode in [
            AgentMode::Worker,
            AgentMode::Orchestrator,
            AgentMode::Planner,
            AgentMode::Reviewer,
            AgentMode::Auditor,
        ] {
            assert!(
                !mode.allows_tool("ask_agent"),
                "mode {mode:?} should block removed ask_agent"
            );
        }
    }

    #[test]
    fn agent_mode_planner_allows_mana_create() {
        let mode = AgentMode::Planner;
        assert!(mode.allows_mana_action("create"));
        assert!(mode.allows_mana_action("status"));
        assert!(mode.allows_mana_action("list"));
        assert!(mode.allows_mana_action("show"));
        assert!(mode.allows_tool("git"));
    }

    #[test]
    fn agent_mode_planner_blocks_mana_close_and_run() {
        let mode = AgentMode::Planner;
        assert!(!mode.allows_mana_action("close"));
        assert!(!mode.allows_mana_action("run"));
        assert!(mode.allows_mana_action("update"));
        assert!(mode.allows_tool("git"));
    }

    #[test]
    fn agent_mode_worker_blocks_mana_create() {
        let mode = AgentMode::Worker;
        assert!(!mode.allows_mana_action("create"));
        assert!(!mode.allows_mana_action("run"));
        assert!(!mode.allows_mana_action("close"));
        assert!(mode.allows_tool("git"));
    }

    #[test]
    fn agent_mode_worker_allows_mana_update() {
        let mode = AgentMode::Worker;
        assert!(mode.allows_mana_action("update"));
        assert!(mode.allows_mana_action("show"));
        assert!(mode.allows_mana_action("status"));
        assert!(mode.allows_mana_action("list"));
    }

    #[test]
    fn agent_mode_reviewer_no_mana() {
        let mode = AgentMode::Reviewer;
        assert!(!mode.allows_mana_action("status"));
        assert!(!mode.allows_mana_action("list"));
        assert!(!mode.allows_mana_action("show"));
        assert!(!mode.allows_mana_action("create"));
        assert!(!mode.allows_mana_action("run"));
        // Reviewer also has no mana tool access
        assert!(!mode.allows_tool("mana"));
        assert!(mode.allows_tool("git"));
    }

    #[test]
    fn agent_mode_auditor_mana_readonly() {
        let mode = AgentMode::Auditor;
        assert!(mode.allows_mana_action("status"));
        assert!(mode.allows_mana_action("list"));
        assert!(mode.allows_mana_action("show"));
        assert!(!mode.allows_mana_action("create"));
        assert!(!mode.allows_mana_action("close"));
        assert!(!mode.allows_mana_action("run"));
        assert!(!mode.allows_mana_action("update"));
        assert!(mode.allows_tool("git"));
    }

    #[test]
    fn agent_mode_config_deserialize() {
        let dir = TempDir::new().unwrap();
        let config_path = dir.path().join("config.toml");
        fs::write(&config_path, r#"mode = "orchestrator""#).unwrap();
        let config = Config::load(&config_path).unwrap();
        assert_eq!(config.mode, AgentMode::Orchestrator);
    }

    #[test]
    fn agent_mode_instructions() {
        assert!(AgentMode::Full.instructions().is_none());
        assert!(AgentMode::Worker.instructions().is_some());
        assert!(AgentMode::Orchestrator.instructions().is_some());
        assert!(AgentMode::Planner.instructions().is_some());
        assert!(AgentMode::Reviewer.instructions().is_some());
        assert!(AgentMode::Auditor.instructions().is_some());

        // Spot-check content is mode-specific
        let worker = AgentMode::Worker.instructions().unwrap();
        assert!(worker.contains("worker"));
        assert!(worker.contains("implement the assigned unit as specified"));
        assert!(
            worker.contains("final verification and closure belong to the orchestrator workflow")
        );

        let orchestrator = AgentMode::Orchestrator.instructions().unwrap();
        assert!(orchestrator.contains("orchestrator agent"));
        assert!(orchestrator.contains("primary execution substrate"));
        assert!(orchestrator.contains("final verification, retry, and closure workflow"));

        let reviewer = AgentMode::Reviewer.instructions().unwrap();
        assert!(reviewer.contains("reviewer") || reviewer.contains("read"));
    }
}