1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
use crate::storage::{ArtifactLoadOp, ArtifactStorage, HandleOp, IndirectIdentifier};
use crate::ArtifactTypeId;
use crossbeam_channel::{Receiver, Sender};
use hydrate_base::handle::{
    ArtifactRef, LoadState, LoadStateProvider, LoaderInfoProvider, ResolvedLoadHandle,
};
use hydrate_base::hashing::{HashMap, HashSet};
use hydrate_base::ArtifactId;
use hydrate_base::{ArtifactManifestData, LoadHandle, StringHash};
use std::fmt::Formatter;
use std::hash::Hash;
use std::sync::atomic::Ordering;
use std::sync::{Arc, Mutex};

//
// Interface for IO
//
// Data about artifacts is stored in three places:
// - Manifest: full list of all artifacts, always in-memory
// - Metadata: stored usually at the head of the artifact data itself. Requires an IO operation to read
//   but is lightweight in terms of bytes
// - Data: The actual payload of the artifact
//
// The primary use of metadata is to get a list of other artifacts that must be loaded in order to
// a particular artifact. We will fire off requests for those other artifacts and wait for them to
// complete before requesting payload data
//

// Data about an artifact that is not in the manifest
#[derive(Debug)]
pub struct ArtifactMetadata {
    pub dependencies: Vec<ArtifactId>,
    pub artifact_type_id: ArtifactTypeId,
    pub hash: u64,
    // size?
}

// The actual payload data of an artifact
pub struct ArtifactData {
    pub data: Vec<u8>,
}

impl std::fmt::Debug for ArtifactData {
    fn fmt(
        &self,
        f: &mut std::fmt::Formatter<'_>,
    ) -> std::fmt::Result {
        f.debug_struct("ArtifactData")
            .field("data_length", &self.data.len())
            .finish()
    }
}

// When IO completes a request for artifact metadata, it will send us a loader event containing this
#[derive(Debug)]
pub struct RequestMetadataResult {
    pub artifact_id: ArtifactId,
    pub load_handle: LoadHandle,
    //pub hash: u64,
    pub result: std::io::Result<ArtifactMetadata>,
}

// When IO completes a request for artifact payload data, it will send us a loader event containing this
#[derive(Debug)]
pub struct RequestDataResult {
    pub artifact_id: ArtifactId,
    pub load_handle: LoadHandle,
    //pub hash: u64,
    //pub subresource: Option<u32>,
    pub result: std::io::Result<ArtifactData>,
}

// A hash of a particular data build. This encompasses everything that was in a single manifest.
// If it changes, we need to check for artifacts that have changed, load them, and update indirect
// handles to point at them. The LoaderIO will provide a new build hash to indicate this has occurred.
#[derive(Copy, Clone, PartialEq, Eq)]
pub struct ManifestBuildHash(pub u64);

impl std::fmt::Debug for ManifestBuildHash {
    fn fmt(
        &self,
        f: &mut Formatter<'_>,
    ) -> std::fmt::Result {
        write!(f, "ManifestBuildHash({:0>16x})", self.0)
    }
}

// Represents a data source from which we can load content
pub trait LoaderIO: Sync + Send {
    fn update(&mut self);

    // Returns the latest known build hash that we are currently able to read from
    fn current_build_hash(&self) -> ManifestBuildHash;

    // Build hash that we are prepared to switch to
    fn pending_build_hash(&self) -> Option<ManifestBuildHash>;

    // Switches to using the new manifest for future requests
    fn activate_pending_build_hash(
        &mut self,
        new_build_hash: ManifestBuildHash,
    );

    // Provide manifest data for a particular artifact by ID
    fn manifest_entry(
        &self,
        artifact_id: ArtifactId,
    ) -> Option<&ArtifactManifestData>;

    // Provide manifest data for an artifact, determined by indirect identifier (for example a
    // symbol name)
    fn resolve_indirect(
        &self,
        indirect_identifier: &IndirectIdentifier,
    ) -> Option<&ArtifactManifestData>;

    // Load the metadata for an artifact.
    // This results in a RequestMetadataResult being sent to the loader
    fn request_metadata(
        &self,
        build_hash: ManifestBuildHash,
        load_handle: LoadHandle,
        artifact_id: ArtifactId,
    );

    // Load the payload for an artifact.
    // This results in a RequestDataResult being sent to the loader
    fn request_data(
        &self,
        build_hash: ManifestBuildHash,
        load_handle: LoadHandle,
        artifact_id: ArtifactId,
        hash: u64,
    );
}

//
// Loader events which drive state changes for loaded artifacts
//
#[derive(Debug)]
pub enum LoaderEvent {
    // Sent when artifact ref count goes from 0 to 1
    TryLoad(LoadHandle),
    // Sent when artifact ref count goes from 1 to 0
    TryUnload(LoadHandle),
    // Sent by LoaderIO when metadata request succeeds or fails
    MetadataRequestComplete(RequestMetadataResult),
    // Sent when all dependencies that were blocking a load have completed loading
    DependenciesLoaded(LoadHandle),
    // Sent by LoaderIO when data request succeeds or fails
    DataRequestComplete(RequestDataResult),
    // Sent by engine code to indicate success or failure at loading an artifact
    LoadResult(HandleOp),
    // Sent by LoaderIO when there are new versions available of the given artifacts.
    //ArtifactsUpdated(ManifestBuildHash),
}

// Information about indirect load handles that have been requested
#[derive(Debug)]
struct IndirectLoad {
    // Identifies what this indirect load refers to. This could be a symbol, and artifact, etc.
    id: IndirectIdentifier,
    // The artifact that the identifier currently maps to. This could change if we reload data.
    //TODO: Update this on reload
    resolved_id_and_hash: Option<ArtifactIdAndHash>,
    // The reference count of external handles (i.e. explicitly requested references, not references
    // due to other artifacts depending on this artifact) matching this indirect identifier
    external_ref_count_indirect: u32,
}

// Information about direct load handles that are currently loaded or were loaded at some point in
// the past. A load handle points to a particular version of an artifact, uniquely identified by
// an artifact ID and the hash.
struct LoadHandleInfo {
    artifact_id: ArtifactId,
    artifact_type_id: ArtifactTypeId,

    // Used to uniquely identify a version of this artifact.
    hash: u64,
    // State this particular artifact is in
    load_state: LoadState,

    // This will be set to true if we reload and this artifact is no longer the latest version of
    // the artifact. Already loaded objects may stay loaded, but we would cancel any further attempts
    // to load this object. (Additionally the currently available manifest data won't be compatible
    // with this artifact, so we would not be able to continue loading it)
    //replaced_by_newer_version: bool,

    // The reference count of external handles (i.e. explicitly requested references, not references
    // due to other artifacts depending on this artifact) for this artifact. Indirect handles will
    // count here and it may be that this artifact is referenced by multiple unique indirect handles.
    external_ref_count_direct: u32,

    // Number of references to this artifact, including explicitly via indirect handles or implicitly
    // due to other requested artifacts requiring this artifact to be loaded first. This reference
    // count is the primary determinent of when it's safe to free an artifact from in-memory storage
    internal_ref_count: u32,

    // Number of artifacts that need to finish loading before this artifact can request data and load
    blocking_dependency_count: u32,

    // load handles for any artifacts that are waiting on this artifact to load in order to continue
    blocked_loads: Vec<LoadHandle>,

    // load handles for any artifacts that need to be released when this is unloaded. This artifact
    // implicitly requires these artifacts to load fully before this artifact can finish loading.
    dependencies: Vec<LoadHandle>,

    // for debugging/convenience, not actually required
    symbol: Option<StringHash>,
    // for debugging/convenience, not actually required
    debug_name: Option<Arc<String>>,
}

//TODO: This may need to track the changed artifacts to wait for them to load before updating
// indirect handles and removing ref counts from the direct handles they used to be associated with?
struct ReloadAction {
    // old direct handles, there is no new corresponding handle
    //load_handles_to_unload: Vec<LoadHandle>,
    // new direct handles, we don't need the old handle here because ref count changes will
    // eventually cause the old handle to be dropped
    load_handles_to_reload: Vec<LoadHandle>,
}

#[derive(Copy, Clone, Debug, Hash, PartialEq, Eq)]
struct ArtifactIdAndHash {
    id: ArtifactId,
    hash: u64,
}

struct LoaderInner {
    next_handle_index: u64,

    // All direct load handles that are currently loaded or were loaded in the past
    // This should only contain direct handles
    load_handle_infos: HashMap<LoadHandle, LoadHandleInfo>,
    // The direct handle for a given artifact ID
    // This should only contain direct handles
    //TODO: This will get updated on reload
    artifact_id_to_handle: HashMap<ArtifactIdAndHash, LoadHandle>,

    // The data source we will load content from
    loader_io: Box<dyn LoaderIO>,

    // The event queue that drives artifact load states changing. Events are produced by API calls
    // from the game, LoaderIO results, significant changes in reference counts, etc.
    events_tx: Sender<LoaderEvent>,
    events_rx: Receiver<LoaderEvent>,

    // All indirect load handles that exist or previously existed
    indirect_states: HashMap<LoadHandle, IndirectLoad>,
    // All indirect identifiers that exist or previously existed, along with the indirect and direct
    // load handles associated with them
    //TODO: The direct handles will be updated on a reload
    indirect_to_load: HashMap<IndirectIdentifier, Arc<ResolvedLoadHandle>>,

    // Update-specific state, mainly to do with reload detection/handling
    current_build_hash: ManifestBuildHash,
    current_reload_action: Option<ReloadAction>,
}

impl LoaderInner {
    pub fn log_load_state_recursive(
        &self,
        load_handle: LoadHandle,
        indent: usize,
    ) {
        let load_handle_info = self.load_handle_infos.get(&load_handle).unwrap();
        log::debug!(
            "{:indent$}{:?} {:?} {:?}",
            "",
            load_handle_info.artifact_id,
            load_handle_info.debug_name,
            load_handle_info.load_state,
            indent = indent
        );
        for dependency in &load_handle_info.dependencies {
            self.log_load_state_recursive(*dependency, indent + 2);
        }
    }

    // Process all events, possibly changing load status of artifacts
    // Also commit reload of artifact data if needed
    #[profiling::function]
    fn update(
        &mut self,
        artifact_storage: &mut dyn ArtifactStorage,
    ) {
        self.loader_io.update();

        if let Some(current_reload_action) = &self.current_reload_action {
            //
            // Check that the load handles we are waiting on to complete a reload are in a committed
            // state. These are all the resolved/direct load handles that were pointed at by at least
            // on indirect handle when we started the reload.
            //
            let mut reload_complete = true;
            for &load_handle in &current_reload_action.load_handles_to_reload {
                let load_handle_info = self.load_handle_infos.get(&load_handle).unwrap();
                if load_handle_info.load_state != LoadState::Loaded {
                    //log::debug!("Reloading waiting for {:?} {:?} {:?} to load, it's in state {:?}", load_handle, load_handle_info.artifact_id, load_handle_info.debug_name, load_handle_info.load_state);
                    //self.log_load_state_recursive(load_handle, 2);
                    reload_complete = false;
                    break;
                }
            }

            if reload_complete {
                //
                // New versions of artifacts for indirect handles have loaded, switch over to using them now
                //
                log::info!("All artifacts we need to reload are ready, updating indirect handles to point at new data");

                // Update any indirect handles to point at new data
                for (_, indirect_load) in &mut self.indirect_states {
                    // Resolve the indirect handle under the new manifest
                    let new_manifest_entry = self.loader_io.resolve_indirect(&indirect_load.id);
                    let new_id_and_hash = new_manifest_entry.map(|x| ArtifactIdAndHash {
                        id: x.artifact_id,
                        hash: x.combined_build_hash,
                    });
                    let old_id_and_hash = indirect_load.resolved_id_and_hash;

                    // If the resolved UUID changes, we need to point the indirect load at the new
                    // version of the artifact (or None) and update ref counts accordingly
                    let artifact_changed = old_id_and_hash != new_id_and_hash;
                    if artifact_changed {
                        // Get the new direct load handle (and add a ref count to it if it is valid)
                        let new_load_handle_direct = if let Some(new_id_and_hash) = new_id_and_hash
                        {
                            let new_load_handle_direct =
                                *self.artifact_id_to_handle.get(&new_id_and_hash).unwrap();
                            let new_load_handle_info = self
                                .load_handle_infos
                                .get_mut(&new_load_handle_direct)
                                .unwrap();

                            // Add indirect references to the new load handle. Each indirect ref
                            // count represents an external ref count and an internal ref count on the
                            // direct load handle
                            //TODO: Cleaner way to do this using self.add_engine_ref_by_handle_direct?
                            new_load_handle_info.external_ref_count_direct +=
                                indirect_load.external_ref_count_indirect;
                            for _ in 0..indirect_load.external_ref_count_indirect {
                                Self::add_internal_ref(
                                    &self.events_tx,
                                    new_load_handle_direct,
                                    new_load_handle_info,
                                );
                            }
                            new_load_handle_direct
                        } else {
                            // The artifact doesn't exist in the new manifest
                            LoadHandle(0)
                        };

                        // Point the indirect load to the new version
                        indirect_load.resolved_id_and_hash = new_id_and_hash;
                        let old_load_handle_direct = self
                            .indirect_to_load
                            .get(&indirect_load.id)
                            .unwrap()
                            .direct_load_handle
                            .swap(new_load_handle_direct.0, Ordering::Relaxed);
                        log::info!(
                            "Update indirect handle {:?} => {:?} -> {:?}",
                            indirect_load.id,
                            LoadHandle(old_load_handle_direct),
                            new_load_handle_direct
                        );

                        // Drop ref count to old version, if it existed
                        if let Some(old_id_and_hash) = &old_id_and_hash {
                            let old_load_handle_direct =
                                *self.artifact_id_to_handle.get(&old_id_and_hash).unwrap();
                            let old_load_handle_info = self
                                .load_handle_infos
                                .get_mut(&old_load_handle_direct)
                                .unwrap();

                            // Remove the indirect references to the old load handle. Each indirect ref
                            // count represents an external ref count and an internal ref count on the
                            // direct load handle
                            //TODO: Cleaner way to do this using self.remove_engine_ref_direct?
                            old_load_handle_info.external_ref_count_direct -=
                                indirect_load.external_ref_count_indirect;
                            for _ in 0..indirect_load.external_ref_count_indirect {
                                Self::remove_internal_ref(
                                    &self.events_tx,
                                    old_load_handle_direct,
                                    old_load_handle_info,
                                );
                            }
                        }
                    }
                }

                //remove temporary ref count added when we started the reload
                for &load_handle in &current_reload_action.load_handles_to_reload {
                    let load_handle_info = self.load_handle_infos.get_mut(&load_handle).unwrap();
                    log::info!("Remove temporary load handle ref for {:?}", load_handle);
                    Self::remove_internal_ref(&self.events_tx, load_handle, load_handle_info);
                }

                // indicate that the reload is complete
                log::info!(
                    "Finished artifact reload, now on manifest build hash {:?}",
                    self.current_build_hash
                );
                self.current_reload_action = None;
            }
        } else if let Some(pending_build_hash) = self.loader_io.pending_build_hash() {
            //
            // See if there is a new build hash available. If there is, we may need to reload/unload
            // some artifacts.
            //

            // Switch to the new manifest
            let old_build_hash = self.current_build_hash;
            self.loader_io
                .activate_pending_build_hash(pending_build_hash);
            self.current_build_hash = self.loader_io.current_build_hash();

            log::info!(
                "Begin artifact reload {:?} -> {:?}",
                old_build_hash,
                self.current_build_hash
            );

            // Iterate indirect handles and see if what they are pointing at has changed
            let mut artifacts_to_reload = HashSet::default();
            for (_, indirect_load) in &self.indirect_states {
                // Resolve the indirect handle under the new manifest
                let new_manifest_entry = self.loader_io.resolve_indirect(&indirect_load.id);
                let new_id_and_hash = new_manifest_entry.map(|x| ArtifactIdAndHash {
                    id: x.artifact_id,
                    hash: x.combined_build_hash,
                });
                let old_id_and_hash = indirect_load.resolved_id_and_hash;

                // If it has changed (and exists), add it to the list of artifacts that need to load
                // before we update
                let artifact_changed = old_id_and_hash != new_id_and_hash;
                if artifact_changed {
                    log::info!("indirect load {:?} is in the new manifest but has changed, hash {:?} -> {:?}", indirect_load.id, old_id_and_hash, new_id_and_hash);
                    // Either add the artifact to the reload or unload list
                    if let Some(new_manifest_entry) = &new_manifest_entry {
                        artifacts_to_reload.insert(ArtifactIdAndHash {
                            id: new_manifest_entry.artifact_id,
                            hash: new_manifest_entry.combined_build_hash,
                        });
                    }
                }
            }

            // Add temporary ref counts to new version of anything that has changed (causing it to load)
            let mut load_handles_to_reload = vec![];
            for new_handle in artifacts_to_reload {
                let new_load_handle = self.get_or_insert_direct(new_handle);
                let new_load_handle_info =
                    self.load_handle_infos.get_mut(&new_load_handle).unwrap();

                // This reference is temporary and will be removed when we finish the reload
                log::info!("Add temporary load handle ref for {:?}", new_load_handle);
                Self::add_internal_ref(&self.events_tx, new_load_handle, new_load_handle_info);
                load_handles_to_reload.push(new_load_handle);
            }

            self.current_reload_action = Some(ReloadAction {
                load_handles_to_reload,
            });
        }

        while let Ok(loader_event) = self.events_rx.try_recv() {
            log::debug!("handle event {:?}", loader_event);
            match loader_event {
                LoaderEvent::TryLoad(load_handle) => {
                    self.handle_try_load(self.current_build_hash, load_handle)
                }
                LoaderEvent::TryUnload(load_handle) => {
                    self.handle_try_unload(load_handle, artifact_storage)
                }
                LoaderEvent::MetadataRequestComplete(result) => {
                    self.handle_request_metadata_result(self.current_build_hash, result)
                }
                LoaderEvent::DependenciesLoaded(load_handle) => {
                    self.handle_dependencies_loaded(self.current_build_hash, load_handle)
                }
                LoaderEvent::DataRequestComplete(result) => {
                    self.handle_request_data_result(result, artifact_storage)
                }
                LoaderEvent::LoadResult(load_result) => {
                    self.handle_load_result(load_result, artifact_storage)
                }
            }
        }
    }

    fn handle_try_load(
        &mut self,
        build_hash: ManifestBuildHash,
        load_handle: LoadHandle,
    ) {
        // Should always exist, we don't delete load handles
        let load_state_info = self.load_handle_infos.get_mut(&load_handle).unwrap();

        log::debug!(
            "handle_try_load {:?} {:?} {:?} {:0>16x}",
            load_handle,
            load_state_info.debug_name,
            load_state_info.artifact_id,
            load_state_info.hash
        );

        // We expect any try_load requests to be for the latest version. If this ends up not being a
        // valid assertion, perhaps we should just load the most recent version.
        let artifact_id = load_state_info.artifact_id;
        if load_state_info.load_state == LoadState::Unloaded {
            // We have not started to load this artifact, so we can potentially start it now
            if load_state_info.internal_ref_count > 0 {
                // The engine is still referencing it, so we should start loading it now
                self.loader_io
                    .request_metadata(build_hash, load_handle, artifact_id);
                load_state_info.load_state = LoadState::WaitingForMetadata;
            } else {
                // it's not referenced anymore, don't bother loading it. If it becomes
                // referenced again later, we will get another TryLoad event
            }
        } else {
            // If we are in any other state, then we are loading or already loaded.
            // We don't need to do anything in this case.
        }
    }

    fn handle_try_unload(
        &mut self,
        load_handle: LoadHandle,
        artifact_storage: &mut dyn ArtifactStorage,
    ) {
        // Should always exist, we don't delete load handles
        let load_state_info = self.load_handle_infos.get_mut(&load_handle).unwrap();

        log::debug!(
            "handle_try_unload {:?} {:?} {:?} {:0>16x}",
            load_handle,
            load_state_info.debug_name,
            load_state_info.artifact_id,
            load_state_info.hash
        );

        let mut dependencies = vec![];

        if load_state_info.load_state != LoadState::Unloaded {
            // We are somewhere in the state machine to load the artifact, we can stop loading it now
            // if it's no longer referenced
            if load_state_info.internal_ref_count > 0 {
                // It's referenced, don't unload it
            } else {
                // It's not referenced, so go ahead and unloaded it...

                // If it's been loaded, tell artifact storage to drop it
                if load_state_info.load_state == LoadState::Loading
                    || load_state_info.load_state == LoadState::Loaded
                {
                    artifact_storage.free_artifact(load_state_info.artifact_type_id, load_handle);
                }

                std::mem::swap(&mut dependencies, &mut load_state_info.dependencies);

                load_state_info.load_state = LoadState::Unloaded;
            }
        } else {
            // We are already unloaded and don't need to do anything
        }

        // Remove dependency refs, we do this after we finish mutating the load info so that we don't
        // take multiple locks, which risks deadlock
        for depenency_load_handle in dependencies {
            let depenency_load_handle_info = self
                .load_handle_infos
                .get_mut(&depenency_load_handle)
                .unwrap();
            Self::remove_internal_ref(
                &self.events_tx,
                depenency_load_handle,
                depenency_load_handle_info,
            );
        }
    }

    fn handle_request_metadata_result(
        &mut self,
        build_hash: ManifestBuildHash,
        result: RequestMetadataResult,
    ) {
        if let Some(load_state_info) = self.load_handle_infos.get(&result.load_handle) {
            log::debug!(
                "handle_request_metadata_result {:?} {:?} {:?} {:0>16x}",
                result.load_handle,
                load_state_info.debug_name,
                load_state_info.artifact_id,
                load_state_info.hash
            );
            let load_state = load_state_info.load_state;
            // Bail if the artifact is unloaded
            if load_state == LoadState::Unloaded {
                return;
            }

            assert_eq!(load_state, LoadState::WaitingForMetadata);
        } else {
            // We don't recognize the load_handle.. we currently never delete them so this shouldn't happen
            unreachable!();
        }

        // add references for other artifacts, either wait for dependents metadata or start loading
        let metadata = result.result.unwrap();

        let mut blocking_dependency_count = 0;

        let mut dependency_load_handles = vec![];
        for dependency in &metadata.dependencies {
            let dependency_manifest_entry = self.loader_io.manifest_entry(*dependency).unwrap();

            let dependency_load_handle = self.get_or_insert_direct(ArtifactIdAndHash {
                id: *dependency,
                hash: dependency_manifest_entry.combined_build_hash,
            });
            let dependency_load_handle_info = self
                .load_handle_infos
                .get_mut(&dependency_load_handle)
                .unwrap();

            dependency_load_handles.push(dependency_load_handle);

            Self::add_internal_ref(
                &self.events_tx,
                dependency_load_handle,
                dependency_load_handle_info,
            );

            let load_state = dependency_load_handle_info.load_state;
            if load_state != LoadState::Loaded {
                blocking_dependency_count += 1;

                dependency_load_handle_info
                    .blocked_loads
                    .push(result.load_handle);
            }
        }

        if let Some(load_state_info) = self.load_handle_infos.get_mut(&result.load_handle) {
            let artifact_id = load_state_info.artifact_id;
            load_state_info.artifact_type_id = metadata.artifact_type_id;
            load_state_info.hash = metadata.hash;
            load_state_info.dependencies = dependency_load_handles;

            if blocking_dependency_count == 0 {
                log::debug!("load handle {:?} has no dependencies", result.load_handle);
                self.loader_io.request_data(
                    build_hash,
                    result.load_handle,
                    artifact_id,
                    metadata.hash,
                    //None,
                );
                assert_eq!(load_state_info.blocking_dependency_count, 0);
                load_state_info.load_state = LoadState::WaitingForData;
            } else {
                log::debug!(
                    "load handle {:?} has {} dependencies",
                    result.load_handle,
                    blocking_dependency_count
                );
                load_state_info.blocking_dependency_count = blocking_dependency_count;
                load_state_info.load_state = LoadState::WaitingForDependencies;
                // Processing for this artifact will continue with dependencies load and our
                // blocking_dependency_count hits 0. (It will be decremented as dependencies are
                // loaded in)
            }
        } else {
            // We don't recognize the load_handle.. we currently never delete them so this shouldn't happen
            unreachable!();
        }
    }

    fn handle_dependencies_loaded(
        &mut self,
        build_hash: ManifestBuildHash,
        load_handle: LoadHandle,
    ) {
        //are we still in the correct state?
        let load_state_info = self.load_handle_infos.get_mut(&load_handle).unwrap();
        log::debug!(
            "handle_dependencies_loaded {:?} {:?} {:?} {:0>16x}",
            load_handle,
            load_state_info.debug_name,
            load_state_info.artifact_id,
            load_state_info.hash,
        );
        if load_state_info.load_state == LoadState::Unloaded {
            return;
        }

        assert_eq!(
            load_state_info.load_state,
            LoadState::WaitingForDependencies
        );

        self.loader_io.request_data(
            build_hash,
            load_handle,
            load_state_info.artifact_id,
            load_state_info.hash,
            //None,
        );
        load_state_info.load_state = LoadState::WaitingForData;
    }

    fn handle_request_data_result(
        &mut self,
        result: RequestDataResult,
        artifact_storage: &mut dyn ArtifactStorage,
    ) {
        // if self.artifact_id_to_handle.get(&result.artifact_id).unwrap() != result.artifact_id {
        //     assert!(version.load_state == LoadState::
        //     // This
        //     // let load_state_info = self.load_handle_infos.get_mut(&result.load_handle).unwrap();
        //     // let version = &mut load_state_info.version;
        //     // version.load_state = LoadState::Unloaded
        // }

        // Should always exist, we don't delete load handles
        let (load_op, load_state_info, data) = {
            let load_state_info = self.load_handle_infos.get(&result.load_handle).unwrap();
            log::debug!(
                "handle_request_data_result {:?} {:?} {:?} {:0>16x}",
                result.load_handle,
                load_state_info.debug_name,
                load_state_info.artifact_id,
                load_state_info.hash
            );
            // Bail if the artifact is unloaded
            if load_state_info.load_state == LoadState::Unloaded {
                return;
            }

            assert_eq!(load_state_info.load_state, LoadState::WaitingForData);

            // start loading
            let data = result.result.unwrap();

            let load_op = ArtifactLoadOp::new(self.events_tx.clone(), result.load_handle);

            (load_op, load_state_info, data)
        };

        let info_provider = LoadHandleInfoProviderImpl {
            artifact_id_to_handle: &self.artifact_id_to_handle,
            load_handle_infos: &self.load_handle_infos,
            loader_io: &*self.loader_io,
        };

        // We dropped the load_state_info lock before calling this because the serde deserializer may query for artifact
        // references, which can cause deadlocks if we are still holding a lock
        artifact_storage
            .load_artifact(
                &info_provider,
                &load_state_info.artifact_type_id,
                load_state_info.artifact_id,
                data.data,
                result.load_handle,
                load_op,
            )
            .unwrap();

        // Should always exist, we don't delete load handles
        let load_state_info = self.load_handle_infos.get_mut(&result.load_handle).unwrap();
        load_state_info.load_state = LoadState::Loading;
    }

    fn handle_load_result(
        &mut self,
        load_result: HandleOp,
        artifact_storage: &mut dyn ArtifactStorage,
    ) {
        //while let Ok(handle_op) = self.handle_op_rx.try_recv() {
        // Handle the operation
        match load_result {
            HandleOp::Error(load_handle, error) => {
                let load_handle_info = self.load_handle_infos.get(&load_handle).unwrap();
                log::debug!(
                    "handle_load_result error {:?} {:?} {:?} {:0>16x}",
                    load_handle,
                    load_handle_info.debug_name,
                    load_handle_info.artifact_id,
                    load_handle_info.hash
                );
                //TODO: How to handle errors?
                log::error!("load error {}", error);
                panic!("load error {}", error);
            }
            HandleOp::Complete(load_handle) => {
                // Advance state... maybe we can commit now, otherwise we have to wait until other
                // dependencies are ready

                // Flag any loads that were waiting on this load to proceed
                let mut blocked_loads = Vec::default();
                let artifact_type_id = {
                    let load_handle_info = self.load_handle_infos.get_mut(&load_handle).unwrap();
                    log::debug!(
                        "handle_load_result complete {:?} {:?} {:?} {:0>16x}",
                        load_handle,
                        load_handle_info.debug_name,
                        load_handle_info.artifact_id,
                        load_handle_info.hash
                    );
                    std::mem::swap(&mut blocked_loads, &mut load_handle_info.blocked_loads);
                    load_handle_info.load_state = LoadState::Loaded;
                    load_handle_info.artifact_type_id
                };

                for blocked_load_handle in blocked_loads {
                    log::trace!("blocked load {:?}", blocked_load_handle);
                    let blocked_load = self
                        .load_handle_infos
                        .get_mut(&blocked_load_handle)
                        .unwrap();
                    blocked_load.blocking_dependency_count -= 1;
                    if blocked_load.blocking_dependency_count == 0 {
                        // Kick off the blocked load
                        self.events_tx
                            .send(LoaderEvent::DependenciesLoaded(blocked_load_handle))
                            .unwrap();
                    }
                }

                artifact_storage.commit_artifact(artifact_type_id, load_handle);
            }
            HandleOp::Drop(load_handle) => {
                log::debug!("handle_load_result drop {:?}", load_handle);
                log::error!(
                    "load op dropped without calling complete/error, handle {:?}",
                    load_handle,
                );
                panic!(
                    "load op dropped without calling complete/error, handle {:?}",
                    load_handle
                )
            }
        }
    }

    // This returns a ResolvedLoadHandle which is either already pointing at a direct load or will need
    // to be populated with a direct load
    fn get_or_insert_indirect(
        &mut self,
        indirect_id: &IndirectIdentifier,
    ) -> Arc<ResolvedLoadHandle> {
        let next_handle_index = &mut self.next_handle_index;
        let indirect_states = &mut self.indirect_states;
        let loader_io = &mut self.loader_io;
        self.indirect_to_load
            .entry(indirect_id.clone())
            .or_insert_with(|| {
                let indirect_load_handle = LoadHandle::new(*next_handle_index, true);
                *next_handle_index += 1;

                let resolved = loader_io.resolve_indirect(indirect_id);
                if resolved.is_none() {
                    panic!("Couldn't find artifact {:?}", indirect_id);
                }

                let manifest_entry = resolved.unwrap();
                log::debug!(
                    "Allocate indirect load handle {:?} for indirect id {:?} -> {:?}",
                    indirect_load_handle,
                    &indirect_id,
                    manifest_entry.artifact_id
                );

                let resolved_load_handle =
                    ResolvedLoadHandle::new(indirect_load_handle, LoadHandle(0));

                indirect_states.insert(
                    indirect_load_handle,
                    IndirectLoad {
                        id: indirect_id.clone(),
                        resolved_id_and_hash: Some(ArtifactIdAndHash {
                            id: manifest_entry.artifact_id,
                            hash: manifest_entry.combined_build_hash,
                        }),
                        external_ref_count_indirect: 0,
                    },
                );
                resolved_load_handle
            })
            .clone()
    }

    fn get_or_insert_direct(
        &mut self,
        artifact_id_and_hash: ArtifactIdAndHash,
    ) -> LoadHandle {
        let next_handle_index = &mut self.next_handle_index;
        let load_handle_infos = &mut self.load_handle_infos;
        let loader_io = &mut self.loader_io;
        *self
            .artifact_id_to_handle
            .entry(artifact_id_and_hash)
            .or_insert_with(|| {
                let direct_load_handle = LoadHandle::new(*next_handle_index, false);
                *next_handle_index += 1;
                let manifest_entry = loader_io.manifest_entry(artifact_id_and_hash.id).unwrap();
                assert_eq!(
                    manifest_entry.combined_build_hash,
                    artifact_id_and_hash.hash
                );

                log::debug!(
                    "Allocate load handle {:?} for artifact id {:?}",
                    direct_load_handle,
                    artifact_id_and_hash,
                );

                load_handle_infos.insert(
                    direct_load_handle,
                    LoadHandleInfo {
                        artifact_id: artifact_id_and_hash.id,
                        external_ref_count_direct: 0,
                        load_state: LoadState::Unloaded,
                        artifact_type_id: ArtifactTypeId::default(),
                        hash: artifact_id_and_hash.hash,
                        //replaced_by_newer_version: false,
                        internal_ref_count: 0,
                        blocking_dependency_count: 0,
                        blocked_loads: vec![],
                        dependencies: vec![],
                        symbol: manifest_entry.symbol_hash.clone(),
                        debug_name: manifest_entry.debug_name.clone(),
                    },
                );

                direct_load_handle
            })
    }

    fn add_engine_ref_indirect(
        &mut self,
        id: IndirectIdentifier,
    ) -> Arc<ResolvedLoadHandle> {
        let indirect_load_handle = self.get_or_insert_indirect(&id);

        // It's possible this has already been resolved, but we still need to add a ref count.
        let direct_load_handle = self.add_engine_ref_by_handle_indirect(indirect_load_handle.id);

        // We expect that the direct handle in the ResolvedLoadHandle is either unset (0) or
        // is consistent with the direct handle returned by add_engine_ref_by_handle_indirect().
        // If it's unset, we need to set it.
        let direct_load_test = indirect_load_handle
            .direct_load_handle
            .swap(direct_load_handle.0, Ordering::Relaxed);
        assert!(direct_load_test == 0 || direct_load_test == direct_load_handle.0);

        indirect_load_handle
    }

    // Returns the direct load handle
    fn add_engine_ref_by_handle_indirect(
        &mut self,
        indirect_load_handle: LoadHandle,
    ) -> LoadHandle {
        assert!(indirect_load_handle.is_indirect());
        let state = self.indirect_states.get_mut(&indirect_load_handle).unwrap();
        state.external_ref_count_indirect += 1;

        let resolved_id_and_hash = state.resolved_id_and_hash;
        if let Some(resolved_id_and_hash) = resolved_id_and_hash {
            let direct_load_handle = self.get_or_insert_direct(resolved_id_and_hash);
            self.add_engine_ref_by_handle_direct(direct_load_handle);
            direct_load_handle
        } else {
            LoadHandle(0)
        }
    }

    // Returns the direct load handle
    fn add_engine_ref_by_handle_direct(
        &mut self,
        direct_load_handle: LoadHandle,
    ) -> LoadHandle {
        assert!(!direct_load_handle.is_indirect());
        let load_handle_info = self.load_handle_infos.get_mut(&direct_load_handle).unwrap();
        load_handle_info.external_ref_count_direct += 1;

        Self::add_internal_ref(&self.events_tx, direct_load_handle, load_handle_info);

        direct_load_handle
    }

    fn remove_engine_ref_indirect(
        &mut self,
        indirect_load_handle: LoadHandle,
    ) {
        assert!(indirect_load_handle.is_indirect());
        let state = self.indirect_states.get_mut(&indirect_load_handle).unwrap();
        state.external_ref_count_indirect -= 1;
        if let Some(resolved_id_and_hash) = &state.resolved_id_and_hash {
            let direct_load_handle = *self
                .artifact_id_to_handle
                .get(resolved_id_and_hash)
                .unwrap();
            self.remove_engine_ref_direct(direct_load_handle);
        }
    }

    fn remove_engine_ref_direct(
        &mut self,
        direct_load_handle: LoadHandle,
    ) {
        assert!(!direct_load_handle.is_indirect());
        let load_handle_info = self.load_handle_infos.get_mut(&direct_load_handle).unwrap();
        load_handle_info.external_ref_count_direct -= 1;

        // Engine always adjusts the latest version count
        Self::remove_internal_ref(&self.events_tx, direct_load_handle, load_handle_info);
    }

    // Internal references are only to direct load handles
    fn add_internal_ref(
        events_tx: &Sender<LoaderEvent>,
        direct_load_handle: LoadHandle,
        load_handle_info: &mut LoadHandleInfo,
    ) {
        assert!(!direct_load_handle.is_indirect());
        load_handle_info.internal_ref_count += 1;

        // If this is the first reference to the artifact, put it in the queue to be loaded
        if load_handle_info.internal_ref_count == 1 {
            events_tx
                .send(LoaderEvent::TryLoad(direct_load_handle))
                .unwrap();
        }
    }

    // Internal references are only to direct load handles
    fn remove_internal_ref(
        events_tx: &Sender<LoaderEvent>,
        direct_load_handle: LoadHandle,
        load_handle_info: &mut LoadHandleInfo,
    ) {
        assert!(!direct_load_handle.is_indirect());
        load_handle_info.internal_ref_count -= 1;
        // If this was the last reference to the artifact, put it in queue to be dropped
        if load_handle_info.internal_ref_count == 0 {
            events_tx
                .send(LoaderEvent::TryUnload(direct_load_handle))
                .unwrap();
        }
    }

    pub fn get_load_info(
        &self,
        handle: LoadHandle,
    ) -> Option<LoadInfo> {
        let handle = if handle.is_indirect() {
            let indirect_id = self.indirect_states.get(&handle).unwrap().id.clone();
            self.indirect_to_load
                .get(&indirect_id)
                .unwrap()
                .direct_load_handle()
        } else {
            handle
        };

        let load_info = self.load_handle_infos.get(&handle)?;
        Some(LoadInfo {
            artifact_id: load_info.artifact_id,
            refs: load_info.external_ref_count_direct,
            symbol: load_info.symbol.clone(),
            debug_name: load_info.debug_name.clone(),
            //path: load_info.versions.last().unwrap().
        })
    }
}

/// Information about an artifact load operation.
///
/// **Note:** The information is true at the time the `LoadInfo` is retrieved. The actual number of
/// references may change.
#[derive(Debug)]
pub struct LoadInfo {
    /// UUID of the artifact.
    pub artifact_id: ArtifactId,
    /// Number of references to the artifact.
    pub refs: u32,
    pub symbol: Option<StringHash>,
    pub debug_name: Option<Arc<String>>,
    // Path to artifact's source file. Not guaranteed to always be available.
    //pub path: Option<String>,
    // Name of artifact's source file. Not guaranteed to always be available.
    //pub file_name: Option<String>,
    // Asset name. Not guaranteed to always be available.
    //pub asset_name: Option<String>,
}

//
// The Loader acts as a semi-public interface for LoaderInner.
//
#[derive(Clone)]
pub struct Loader {
    inner: Arc<Mutex<LoaderInner>>,
}

impl Loader {
    pub(crate) fn new(
        loader_io: Box<dyn LoaderIO>,
        events_tx: Sender<LoaderEvent>,
        events_rx: Receiver<LoaderEvent>,
    ) -> Self {
        let build_hash = loader_io.current_build_hash();

        let inner = LoaderInner {
            // start at 1 because 0 means null
            next_handle_index: 1,
            artifact_id_to_handle: Default::default(),
            load_handle_infos: Default::default(),
            loader_io,
            events_tx,
            events_rx,
            indirect_states: Default::default(),
            indirect_to_load: Default::default(),
            current_build_hash: build_hash,
            current_reload_action: None,
        };

        Loader {
            inner: Arc::new(Mutex::new(inner)),
        }
    }

    pub(crate) fn update(
        &self,
        artifact_storage: &mut dyn ArtifactStorage,
    ) {
        self.inner.lock().unwrap().update(artifact_storage);
    }

    pub(crate) fn add_engine_ref_indirect(
        &self,
        id: IndirectIdentifier,
    ) -> Arc<ResolvedLoadHandle> {
        self.inner.lock().unwrap().add_engine_ref_indirect(id)
    }

    pub(crate) fn add_engine_ref_by_handle(
        &self,
        load_handle: LoadHandle,
    ) -> LoadHandle {
        if load_handle.is_indirect() {
            self.inner
                .lock()
                .unwrap()
                .add_engine_ref_by_handle_indirect(load_handle)
        } else {
            self.inner
                .lock()
                .unwrap()
                .add_engine_ref_by_handle_direct(load_handle)
        }
    }

    // from remove_refs
    pub(crate) fn remove_engine_ref(
        &self,
        load_handle: LoadHandle,
    ) {
        if load_handle.is_indirect() {
            self.inner
                .lock()
                .unwrap()
                .remove_engine_ref_indirect(load_handle);
        } else {
            self.inner
                .lock()
                .unwrap()
                .remove_engine_ref_direct(load_handle);
        }
    }

    /// Returns handles to all active artifact loads.
    pub fn get_active_loads(&self) -> Vec<LoadHandle> {
        let mut loading_handles = Vec::default();
        let inner = self.inner.lock().unwrap();
        for k in inner.load_handle_infos.keys() {
            loading_handles.push(k.clone());
        }

        loading_handles
    }

    pub fn get_load_info(
        &self,
        handle: LoadHandle,
    ) -> Option<LoadInfo> {
        self.inner.lock().unwrap().get_load_info(handle)
    }

    pub fn log_load_state_recursive(
        &self,
        load_handle: LoadHandle,
    ) {
        self.inner
            .lock()
            .unwrap()
            .log_load_state_recursive(load_handle, 0);
    }
}

//
// This impl allows a handle in hydrate_base to implement load_state and artifact_id on handle itself,
// proxying the call to this loader
//
impl LoadStateProvider for Loader {
    fn load_state(
        &self,
        load_handle: &Arc<ResolvedLoadHandle>,
    ) -> LoadState {
        self.inner
            .lock()
            .unwrap()
            .load_handle_infos
            .get(&load_handle.direct_load_handle())
            .unwrap()
            .load_state
    }

    fn artifact_id(
        &self,
        load_handle: &Arc<ResolvedLoadHandle>,
    ) -> ArtifactId {
        self.inner
            .lock()
            .unwrap()
            .load_handle_infos
            .get(&load_handle.direct_load_handle())
            .unwrap()
            .artifact_id
    }
}

//
// This is used by SerdeContext to handle serializing/deserializing artifact references. We always
// provide direct handles when an artifact references another artifact. We ensure that if an artifact
// is loading that references another artifact, that artifact is already loaded. So generally we
// should not fail to find the requested artifact id
//
#[derive(Copy, Clone)]
struct LoadHandleInfoProviderImpl<'a> {
    artifact_id_to_handle: &'a HashMap<ArtifactIdAndHash, LoadHandle>,
    load_handle_infos: &'a HashMap<LoadHandle, LoadHandleInfo>,
    loader_io: &'a dyn LoaderIO,
}

impl<'a> LoaderInfoProvider for LoadHandleInfoProviderImpl<'a> {
    // Used when deserializing to convert an artifact id into the load handle of the already-loaded
    // artifact
    fn resolved_load_handle(
        &self,
        id: &ArtifactRef,
    ) -> Option<Arc<ResolvedLoadHandle>> {
        let artifact_id = ArtifactId::from_uuid(id.0.as_uuid());
        let build_hash = self
            .loader_io
            .manifest_entry(artifact_id)
            .unwrap()
            .combined_build_hash;

        let load_handle = self
            .artifact_id_to_handle
            .get(&ArtifactIdAndHash {
                id: artifact_id,
                hash: build_hash,
            })
            .map(|l| *l)?;
        Some(ResolvedLoadHandle::new(load_handle, load_handle))
    }

    // Used when serializing to convert a load handle to an artifact id
    fn artifact_id(
        &self,
        load: LoadHandle,
    ) -> Option<ArtifactId> {
        self.load_handle_infos.get(&load).map(|l| l.artifact_id)
    }
}