1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962
//! # Nest CFGs
//!
//! Identify Single-Entry-Single-Exit (SESE) regions in the CFG.
//! These are pairs of edges (a,b) where
//! * a dominates b
//! * b postdominates a
//! * there are no other edges in/out of the nodes inbetween
//! (this last condition is necessary because loop backedges do not affect (post)dominance).
//!
//! # Algorithm
//! See paper: <https://doi.org/10.1145/178243.178258>, approximately:
//! 1. those three conditions are equivalent to:
//! *a and b are cycle-equivalent in the CFG with an extra edge from the exit node to the entry*
//! where cycle-equivalent means every cycle has either both a and b, or neither
//! 2. cycle equivalence is unaffected if all edges are considered *un*directed
//! (not obvious, see paper for proof)
//! 3. take undirected CFG, perform depth-first traversal
//! => all edges are either *tree edges*, or *backedges* where one endpoint is an ancestor of the other
//! 4. identify the "bracketlist" of each tree edge - the set of backedges going from a descendant of that edge to an ancestor
//! -- post-order traversal, merging bracketlists of children,
//! then delete backedges from below to here, add backedges from here to above
//! => tree edges with the same bracketlist are cycle-equivalent;
//! + a tree edge with a single-element bracketlist is cycle-equivalent with that single element
//! 5. this would be expensive (comparing large sets of backedges) - so to optimize,
//! - the backedge most recently added (at the top) of the bracketlist, plus the size of the bracketlist,
//! is sufficient to identify the set *when the UDFS tree is linear*;
//! - when UDFS is treelike, any ancestor with brackets from >1 subtree cannot be cycle-equivalent with any descendant
//! (as the brackets of said descendant come from beneath it to its ancestors, not from any sibling/etc. in the other subtree).
//! So, add (onto top of bracketlist) a fake "capping" backedge from here to the highest ancestor reached by >1 subtree.
//! (Thus, edges from here up to that ancestor, cannot be cycle-equivalent with any edges elsewhere.)
//!
//! # Restrictions
//! * The paper assumes that all CFG nodes are on paths from entry to exit, i.e. no loops without exits.
//! HUGR assumes only that they are all reachable from entry, so we do a backward traversal from exit node
//! first and restrict to the CFG nodes in the reachable set. (This means we will not discover SESE regions
//! in exit-free loops, but that doesn't seem a major concern.)
//! * Multiple edges in the same direction between the same BBs will "confuse" the algorithm in the paper.
//! However it is straightforward for us to treat successors and predecessors as sets. (Two edges between
//! the same BBs but in opposite directions must be distinct!)
use std::collections::{HashMap, HashSet, LinkedList, VecDeque};
use std::hash::Hash;
use itertools::Itertools;
use thiserror::Error;
use hugr_core::hugr::rewrite::outline_cfg::OutlineCfg;
use hugr_core::hugr::views::sibling::SiblingMut;
use hugr_core::hugr::views::{HierarchyView, HugrView, SiblingGraph};
use hugr_core::hugr::{hugrmut::HugrMut, Rewrite, RootTagged};
use hugr_core::ops::handle::{BasicBlockID, CfgID};
use hugr_core::ops::OpTag;
use hugr_core::ops::OpTrait;
use hugr_core::{Direction, Hugr, Node};
/// A "view" of a CFG in a Hugr which allows basic blocks in the underlying CFG to be split into
/// multiple blocks in the view (or merged together).
/// `T` is the type of basic block; this can just be a BasicBlock (e.g. [`Node`]) in the Hugr,
/// or an [IdentityCfgMap] if the extra level of indirection is not required. However, since
/// SESE regions are bounded by edges between pairs of such `T`, such splitting may allow the
/// algorithm to identify more regions than existed in the underlying CFG, without mutating the
/// underlying CFG just for the analysis - the splitting (and/or merging) can then be performed by
/// [CfgNester::nest_sese_region] only as necessary for regions actually nested.
pub trait CfgNodeMap<T> {
/// The unique entry node of the CFG. It may any n>=0 of incoming edges; we assume control arrives here from "outside".
fn entry_node(&self) -> T;
/// The unique exit node of the CFG. The only node to have no successors.
fn exit_node(&self) -> T;
/// Allows the trait implementor to define a type of iterator it will return from
/// `successors` and `predecessors`.
type Iterator<'c>: Iterator<Item = T>
where
Self: 'c;
/// Returns an iterator over the successors of the specified basic block.
fn successors(&self, node: T) -> Self::Iterator<'_>;
/// Returns an iterator over the predecessors of the specified basic block.
fn predecessors(&self, node: T) -> Self::Iterator<'_>;
}
/// Extension of [CfgNodeMap] to that can perform (mutable/destructive)
/// nesting of regions detected.
pub trait CfgNester<T>: CfgNodeMap<T> {
/// Given an entry edge and exit edge defining a SESE region, mutates the
/// Hugr such that all nodes between these edges are placed in a nested CFG.
/// Returns the newly-constructed block (containing a nested CFG).
///
/// # Panics
/// May panic if the two edges do not constitute a SESE region.
fn nest_sese_region(&mut self, entry_edge: (T, T), exit_edge: (T, T)) -> T;
}
/// Transforms a CFG into as much-nested a form as possible.
pub fn transform_cfg_to_nested<T: Copy + Eq + Hash + std::fmt::Debug>(
view: &mut impl CfgNester<T>,
) {
let edge_classes = EdgeClassifier::get_edge_classes(view);
let mut rem_edges: HashMap<usize, HashSet<(T, T)>> = HashMap::new();
for (e, cls) in edge_classes.iter() {
rem_edges.entry(*cls).or_default().insert(*e);
}
// Traverse. Any traversal will encounter edges in SESE-respecting order.
fn traverse<T: Copy + Eq + Hash + std::fmt::Debug>(
view: &mut impl CfgNester<T>,
n: T,
edge_classes: &HashMap<(T, T), usize>,
rem_edges: &mut HashMap<usize, HashSet<(T, T)>>,
stop_at: Option<usize>,
) -> Option<(T, T)> {
let mut seen = HashSet::new();
let mut stack = Vec::new();
let mut exit_edges = Vec::new();
stack.push(n);
while let Some(n) = stack.pop() {
if !seen.insert(n) {
continue;
}
let (exit, rest): (Vec<_>, Vec<_>) = view
.successors(n)
.map(|s| (n, s))
.partition(|e| stop_at.is_some() && edge_classes.get(e).copied() == stop_at);
exit_edges.extend(exit.into_iter().at_most_one().unwrap());
for mut e in rest {
if let Some(cls) = edge_classes.get(&e) {
assert!(rem_edges.get_mut(cls).unwrap().remove(&e));
// While there are more edges in that same class, we can traverse the entire
// subregion between pairs of edges in that class in a single step
// (as these are strictly nested in any outer region)
while !rem_edges.get_mut(cls).unwrap().is_empty() {
let prev_e = e;
// Traverse to the next edge in the same class - we know it exists in the set
e = traverse(view, e.1, edge_classes, rem_edges, Some(*cls)).unwrap();
assert!(rem_edges.get_mut(cls).unwrap().remove(&e));
// Skip trivial regions of a single node, unless the node has other edges
// (non-exiting, but e.g. a backedge to a loop header, ending that loop)
if prev_e.1 != e.0 || view.successors(e.0).count() > 1 {
// Traversal and nesting of the subregion's *contents* were completed in the
// recursive call above, so only processed nodes are moved into descendant CFGs
e = (view.nest_sese_region(prev_e, e), e.1)
};
}
}
stack.push(e.1);
}
}
exit_edges.into_iter().unique().at_most_one().unwrap()
}
traverse(view, view.entry_node(), &edge_classes, &mut rem_edges, None);
// TODO we should probably now try to merge consecutive basic blocks
// (i.e. where a BB has a single successor, that has a single predecessor)
// and thus convert CF dependencies into (parallelizable) dataflow.
}
/// Search the entire Hugr looking for CFGs, and transform each
/// into as deeply-nested form as possible (as per [transform_cfg_to_nested]).
/// This search may be expensive, although if it finds much/many CFGs,
/// the analysis/transformation on them is likely to be more expensive still!
pub fn transform_all_cfgs(h: &mut Hugr) {
let mut node_stack = Vec::from([h.root()]);
while let Some(n) = node_stack.pop() {
if let Ok(s) = SiblingMut::<CfgID>::try_new(h, n) {
transform_cfg_to_nested(&mut IdentityCfgMap::new(s));
}
node_stack.extend(h.children(n))
}
}
/// Directed edges in a Cfg - i.e. along which control flows from first to second only.
type CfgEdge<T> = (T, T);
// The next enum + few functions allow to abstract over the edge directions
// in a CfgView.
#[derive(Copy, Clone, PartialEq, Eq, Hash)]
enum EdgeDest<T> {
Forward(T),
Backward(T),
}
impl<T: Copy + Clone + PartialEq + Eq + Hash> EdgeDest<T> {
pub fn target(&self) -> T {
match self {
EdgeDest::Forward(i) => *i,
EdgeDest::Backward(i) => *i,
}
}
}
fn all_edges<'a, T: Copy + Clone + PartialEq + Eq + Hash + 'a>(
cfg: &'a impl CfgNodeMap<T>,
n: T,
) -> impl Iterator<Item = EdgeDest<T>> + '_ {
let extra = if n == cfg.exit_node() {
vec![cfg.entry_node()]
} else {
vec![]
};
cfg.successors(n)
.chain(extra)
.map(EdgeDest::Forward)
.chain(cfg.predecessors(n).map(EdgeDest::Backward))
.unique()
}
fn flip<T: Copy + Clone + PartialEq + Eq + Hash>(src: T, d: EdgeDest<T>) -> (T, EdgeDest<T>) {
match d {
EdgeDest::Forward(tgt) => (tgt, EdgeDest::Backward(src)),
EdgeDest::Backward(tgt) => (tgt, EdgeDest::Forward(src)),
}
}
fn cfg_edge<T: Copy + Clone + PartialEq + Eq + Hash>(s: T, d: EdgeDest<T>) -> CfgEdge<T> {
match d {
EdgeDest::Forward(t) => (s, t),
EdgeDest::Backward(t) => (t, s),
}
}
/// A straightforward view of a Cfg as it appears in a Hugr
pub struct IdentityCfgMap<H> {
h: H,
entry: Node,
exit: Node,
}
impl<H: RootTagged<RootHandle = CfgID>> IdentityCfgMap<H> {
/// Creates an [IdentityCfgMap] for the specified CFG
pub fn new(h: H) -> Self {
// Panic if malformed enough not to have two children
let (entry, exit) = h.children(h.root()).take(2).collect_tuple().unwrap();
debug_assert_eq!(h.get_optype(exit).tag(), OpTag::BasicBlockExit);
Self { h, entry, exit }
}
}
impl<H: HugrView> CfgNodeMap<Node> for IdentityCfgMap<H> {
fn entry_node(&self) -> Node {
self.entry
}
fn exit_node(&self) -> Node {
self.exit
}
type Iterator<'c> = <H as HugrView>::Neighbours<'c>
where
Self: 'c;
fn successors(&self, node: Node) -> Self::Iterator<'_> {
self.h.neighbours(node, Direction::Outgoing)
}
fn predecessors(&self, node: Node) -> Self::Iterator<'_> {
self.h.neighbours(node, Direction::Incoming)
}
}
impl<H: HugrMut> CfgNester<Node> for IdentityCfgMap<H> {
fn nest_sese_region(&mut self, entry_edge: (Node, Node), exit_edge: (Node, Node)) -> Node {
// The algorithm only calls with entry/exit edges for a SESE region; panic if they don't
let blocks = region_blocks(self, entry_edge, exit_edge).unwrap();
assert!([entry_edge.0, entry_edge.1, exit_edge.0, exit_edge.1]
.iter()
.all(|n| self.h.get_parent(*n) == Some(self.h.root())));
let (new_block, new_cfg) = OutlineCfg::new(blocks).apply(&mut self.h).unwrap();
debug_assert!([entry_edge.0, exit_edge.1]
.iter()
.all(|n| self.h.get_parent(*n) == Some(self.h.root())));
debug_assert!({
let new_block_view = SiblingGraph::<BasicBlockID>::try_new(&self.h, new_block).unwrap();
let new_cfg_view = SiblingGraph::<CfgID>::try_new(&new_block_view, new_cfg).unwrap();
[entry_edge.1, exit_edge.0]
.iter()
.all(|n| new_cfg_view.get_parent(*n) == Some(new_cfg))
});
new_block
}
}
/// An error trying to get the blocks of a SESE (single-entry-single-exit) region
#[derive(Clone, Debug, Error)]
#[non_exhaustive]
pub enum RegionBlocksError<T> {
/// The specified exit edge did not exist in the CFG
ExitEdgeNotPresent(T, T),
/// The specified entry edge did not exist in the CFG
EntryEdgeNotPresent(T, T),
/// The source of the entry edge was in the region
/// (reachable from the target of the entry edge without using the exit edge)
EntryEdgeSourceInRegion(T),
/// The target of the entry edge had other predecessors (given)
/// that were outside the region (i.e. not reachable from the target)
UnexpectedEntryEdges(Vec<T>),
}
/// Given entry and exit edges for a SESE region, identify all the blocks in it.
pub fn region_blocks<T: Copy + Eq + Hash + std::fmt::Debug>(
v: &impl CfgNodeMap<T>,
entry_edge: (T, T),
exit_edge: (T, T),
) -> Result<HashSet<T>, RegionBlocksError<T>> {
let mut blocks = HashSet::new();
let mut queue = VecDeque::new();
queue.push_back(entry_edge.1);
while let Some(n) = queue.pop_front() {
if blocks.insert(n) {
if n == exit_edge.0 {
let succs: Vec<T> = v.successors(n).collect();
let n_succs = succs.len();
let internal_succs: Vec<T> =
succs.into_iter().filter(|s| *s != exit_edge.1).collect();
if internal_succs.len() == n_succs {
return Err(RegionBlocksError::ExitEdgeNotPresent(
exit_edge.0,
exit_edge.1,
));
}
queue.extend(internal_succs)
} else {
queue.extend(v.successors(n));
}
}
}
if blocks.contains(&entry_edge.0) {
return Err(RegionBlocksError::EntryEdgeSourceInRegion(entry_edge.0));
}
let ext_preds = v
.predecessors(entry_edge.1)
.unique()
.filter(|p| !blocks.contains(p));
let (expected, extra): (Vec<T>, Vec<T>) = ext_preds.partition(|i| *i == entry_edge.0);
if expected != vec![entry_edge.0] {
return Err(RegionBlocksError::EntryEdgeNotPresent(
entry_edge.0,
entry_edge.1,
));
};
if !extra.is_empty() {
return Err(RegionBlocksError::UnexpectedEntryEdges(extra));
}
// We could check for other nodes in the region having predecessors outside it, but that would be more expensive
Ok(blocks)
}
/// Records an undirected Depth First Search over a CfgView,
/// restricted to nodes forwards-reachable from the entry.
/// That is, the DFS traversal goes both ways along the edges of the CFG.
/// *Undirected* DFS classifies all edges into *only two* categories
/// * tree edges, which on their own (with the nodes) form a tree (minimum spanning tree);
/// * backedges, i.e. those for which, when DFS tried to traverse them, the other endpoint was an ancestor
/// Moreover, we record *which way* along the underlying CFG edge we went.
struct UndirectedDFSTree<T> {
/// Pre-order traversal numbering
dfs_num: HashMap<T, usize>,
/// For each node, the edge along which it was reached from its parent
dfs_parents: HashMap<T, EdgeDest<T>>,
}
impl<T: Copy + Clone + PartialEq + Eq + Hash> UndirectedDFSTree<T> {
fn new(cfg: &impl CfgNodeMap<T>) -> Self {
//1. Traverse backwards-only from exit building bitset of reachable nodes
let mut reachable = HashSet::new();
{
let mut pending = VecDeque::new();
pending.push_back(cfg.exit_node());
while let Some(n) = pending.pop_front() {
if reachable.insert(n) {
pending.extend(cfg.predecessors(n));
}
}
}
//2. Traverse undirected from entry node, building dfs_num and setting dfs_parents
let mut dfs_num = HashMap::new();
let mut dfs_parents = HashMap::new();
{
// Node, and directed edge along which reached
let mut pending = vec![(cfg.entry_node(), EdgeDest::Backward(cfg.exit_node()))];
while let Some((n, p_edge)) = pending.pop() {
if !dfs_num.contains_key(&n) && reachable.contains(&n) {
dfs_num.insert(n, dfs_num.len());
dfs_parents.insert(n, p_edge);
for e in all_edges(cfg, n) {
pending.push(flip(n, e));
}
}
}
dfs_parents.remove(&cfg.entry_node()).unwrap();
}
UndirectedDFSTree {
dfs_num,
dfs_parents,
}
}
}
#[derive(Clone, PartialEq, Eq, Hash)]
enum Bracket<T> {
Real(CfgEdge<T>),
Capping(usize, T),
}
/// Manages a list of brackets. The goal here is to allow constant-time deletion
/// out of the middle of the list - which isn't really possible, so instead we
/// track deleted items (in an external set) and the remaining number (here).
///
/// Note - we could put the items deleted from *this* BracketList here, and merge in concat().
/// That would be cleaner, but repeated set-merging would be slower than adding the
/// deleted items to a single set in the `TraversalState`
struct BracketList<T> {
items: LinkedList<Bracket<T>>, // Allows O(1) `append` of two lists.
size: usize, // Not counting deleted items.
}
impl<T: Copy + Clone + PartialEq + Eq + Hash> BracketList<T> {
pub fn new() -> Self {
BracketList {
items: LinkedList::new(),
size: 0,
}
}
pub fn tag(&mut self, deleted: &HashSet<Bracket<T>>) -> Option<(Bracket<T>, usize)> {
while let Some(e) = self.items.front() {
// Pop deleted elements to save time (and memory)
if deleted.contains(e) {
self.items.pop_front();
//deleted.remove(e); // Would only save memory, so keep as immutable
} else {
return Some((e.clone(), self.size));
}
}
None
}
pub fn concat(&mut self, other: BracketList<T>) {
let BracketList { mut items, size } = other;
self.items.append(&mut items);
assert!(items.is_empty());
self.size += size;
}
pub fn delete(&mut self, b: &Bracket<T>, deleted: &mut HashSet<Bracket<T>>) {
// Ideally, here we would also assert that no *other* BracketList contains b.
debug_assert!(self.items.contains(b)); // Makes operation O(n), otherwise O(1)
let was_new = deleted.insert(b.clone());
assert!(was_new);
self.size -= 1;
}
pub fn push(&mut self, e: Bracket<T>) {
self.items.push_back(e);
self.size += 1;
}
}
/// Mutable state updated during traversal of the UndirectedDFSTree by the cycle equivalence algorithm.
pub struct EdgeClassifier<T> {
/// Edges we have marked as deleted, allowing constant-time deletion without searching BracketList
deleted_backedges: HashSet<Bracket<T>>,
/// Key is DFS num of highest ancestor
/// to which backedges reached from >1 sibling subtree;
/// Value is the LCA i.e. parent of those siblings.
capping_edges: HashMap<usize, Vec<T>>,
/// Result of traversal - accumulated here, entries should never be overwritten
edge_classes: HashMap<CfgEdge<T>, Option<(Bracket<T>, usize)>>,
}
impl<T: Copy + Clone + PartialEq + Eq + Hash> EdgeClassifier<T> {
/// Computes equivalence class of each edge, i.e. two edges with the same value
/// are cycle-equivalent. Any two consecutive edges in the same class define a SESE region
/// (where "consecutive" means on any path in the original directed CFG, as the edges
/// in a class all dominate + postdominate each other as part of defn of cycle equivalence).
pub fn get_edge_classes(cfg: &impl CfgNodeMap<T>) -> HashMap<CfgEdge<T>, usize> {
let tree = UndirectedDFSTree::new(cfg);
let mut s = Self {
deleted_backedges: HashSet::new(),
capping_edges: HashMap::new(),
edge_classes: HashMap::new(),
};
s.traverse(cfg, &tree, cfg.entry_node());
assert!(s.capping_edges.is_empty());
s.edge_classes.remove(&(cfg.exit_node(), cfg.entry_node()));
let mut cycle_class_idxs = HashMap::new();
s.edge_classes
.into_iter()
.map(|(k, v)| {
let l = cycle_class_idxs.len();
(k, *cycle_class_idxs.entry(v).or_insert(l))
})
.collect()
}
/// Returns the lowest DFS num (highest ancestor) reached by any bracket leaving
/// the subtree, and the list of said brackets.
fn traverse(
&mut self,
cfg: &impl CfgNodeMap<T>,
tree: &UndirectedDFSTree<T>,
n: T,
) -> (usize, BracketList<T>) {
let n_dfs = *tree.dfs_num.get(&n).unwrap(); // should only be called for nodes on path to exit
let (children, non_capping_backedges): (Vec<_>, Vec<_>) = all_edges(cfg, n)
.filter(|e| tree.dfs_num.contains_key(&e.target()))
.partition(|e| {
// The tree edges are those whose *targets* list the edge as parent-edge
let (tgt, from) = flip(n, *e);
tree.dfs_parents.get(&tgt) == Some(&from)
});
let child_results: Vec<_> = children
.iter()
.map(|c| self.traverse(cfg, tree, c.target()))
.collect();
let mut min_dfs_target: [Option<usize>; 2] = [None, None]; // We want highest-but-one
let mut bs = BracketList::new();
for (tgt, brs) in child_results {
if tgt < min_dfs_target[0].unwrap_or(usize::MAX) {
min_dfs_target = [Some(tgt), min_dfs_target[0]]
} else if tgt < min_dfs_target[1].unwrap_or(usize::MAX) {
min_dfs_target[1] = Some(tgt)
}
bs.concat(brs);
}
// Add capping backedge
if let Some(min1dfs) = min_dfs_target[1] {
if min1dfs < n_dfs {
bs.push(Bracket::Capping(min1dfs, n));
// mark capping edge to be removed when we return out to the other end
self.capping_edges.entry(min1dfs).or_default().push(n);
}
}
let parent_edge = tree.dfs_parents.get(&n);
let (be_up, be_down): (Vec<_>, Vec<_>) = non_capping_backedges
.into_iter()
.map(|e| (*tree.dfs_num.get(&e.target()).unwrap(), e))
.partition(|(dfs, _)| *dfs < n_dfs);
// Remove edges to here from beneath
for (_, e) in be_down {
let e = cfg_edge(n, e);
let b = Bracket::Real(e);
bs.delete(&b, &mut self.deleted_backedges);
// Last chance to assign an edge class! This will be a singleton class,
// but assign for consistency with other singletons.
self.edge_classes.entry(e).or_insert_with(|| Some((b, 0)));
}
// And capping backedges
for src in self.capping_edges.remove(&n_dfs).unwrap_or_default() {
bs.delete(&Bracket::Capping(n_dfs, src), &mut self.deleted_backedges)
}
// Add backedges from here to ancestors (not the parent edge, but perhaps other edges to the same node)
be_up
.iter()
.filter(|(_, e)| Some(e) != parent_edge)
.for_each(|(_, e)| bs.push(Bracket::Real(cfg_edge(n, *e))));
// Now calculate edge classes
let class = bs.tag(&self.deleted_backedges);
if let Some((Bracket::Real(e), 1)) = &class {
self.edge_classes.insert(*e, class.clone());
}
if let Some(parent_edge) = tree.dfs_parents.get(&n) {
self.edge_classes.insert(cfg_edge(n, *parent_edge), class);
}
let highest_target = be_up
.into_iter()
.map(|(dfs, _)| dfs)
.chain(min_dfs_target[0]);
(highest_target.min().unwrap_or(usize::MAX), bs)
}
}
#[cfg(test)]
pub(crate) mod test {
use super::*;
use hugr_core::builder::{
BuildError, CFGBuilder, Container, DataflowSubContainer, HugrBuilder,
};
use hugr_core::extension::PRELUDE_REGISTRY;
use hugr_core::extension::{prelude::USIZE_T, ExtensionSet};
use hugr_core::hugr::rewrite::insert_identity::{IdentityInsertion, IdentityInsertionError};
use hugr_core::hugr::views::RootChecked;
use hugr_core::ops::handle::{ConstID, NodeHandle};
use hugr_core::ops::Value;
use hugr_core::type_row;
use hugr_core::types::{EdgeKind, FunctionType, Type};
use hugr_core::utils::depth;
const NAT: Type = USIZE_T;
pub fn group_by<E: Eq + Hash + Ord, V: Eq + Hash>(h: HashMap<E, V>) -> HashSet<Vec<E>> {
let mut res = HashMap::new();
for (k, v) in h.into_iter() {
res.entry(v).or_insert_with(Vec::new).push(k);
}
res.into_values().map(sorted).collect()
}
pub fn sorted<E: Ord>(items: impl IntoIterator<Item = E>) -> Vec<E> {
let mut v: Vec<_> = items.into_iter().collect();
v.sort();
v
}
#[test]
fn test_cond_then_loop_separate() -> Result<(), BuildError> {
// /-> left --\
// entry -> split > merge -> head -> tail -> exit
// \-> right -/ \-<--<-/
let mut cfg_builder = CFGBuilder::new(FunctionType::new_endo(NAT))?;
let pred_const = cfg_builder.add_constant(Value::unit_sum(0, 2).expect("0 < 2"));
let const_unit = cfg_builder.add_constant(Value::unary_unit_sum());
let entry = n_identity(
cfg_builder.simple_entry_builder(type_row![NAT], 1, ExtensionSet::new())?,
&const_unit,
)?;
let (split, merge) = build_if_then_else_merge(&mut cfg_builder, &pred_const, &const_unit)?;
cfg_builder.branch(&entry, 0, &split)?;
let head = n_identity(
cfg_builder.simple_block_builder(FunctionType::new_endo(NAT), 1)?,
&const_unit,
)?;
let tail = n_identity(
cfg_builder.simple_block_builder(FunctionType::new_endo(NAT), 2)?,
&pred_const,
)?;
cfg_builder.branch(&tail, 1, &head)?;
cfg_builder.branch(&head, 0, &tail)?; // trivial "loop body"
cfg_builder.branch(&merge, 0, &head)?;
let exit = cfg_builder.exit_block();
cfg_builder.branch(&tail, 0, &exit)?;
let mut h = cfg_builder.finish_prelude_hugr()?;
let rc = RootChecked::<_, CfgID>::try_new(&mut h).unwrap();
let (entry, exit) = (entry.node(), exit.node());
let (split, merge, head, tail) = (split.node(), merge.node(), head.node(), tail.node());
let edge_classes = EdgeClassifier::get_edge_classes(&IdentityCfgMap::new(rc.borrow()));
let [&left, &right] = edge_classes
.keys()
.filter(|(s, _)| *s == split)
.map(|(_, t)| t)
.collect::<Vec<_>>()[..]
else {
panic!("Split node should have two successors");
};
let classes = group_by(edge_classes);
assert_eq!(
classes,
HashSet::from([
sorted([(split, left), (left, merge)]), // Region containing single BB 'left'.
sorted([(split, right), (right, merge)]), // Region containing single BB 'right'.
Vec::from([(head, tail)]), // Loop body and backedges are in their own classes because
Vec::from([(tail, head)]), // the path executing the loop exactly once skips the backedge.
sorted([(entry, split), (merge, head), (tail, exit)]), // Two regions, conditional and then loop.
])
);
transform_cfg_to_nested(&mut IdentityCfgMap::new(rc));
h.update_validate(&PRELUDE_REGISTRY).unwrap();
assert_eq!(1, depth(&h, entry));
assert_eq!(1, depth(&h, exit));
for n in [split, left, right, merge, head, tail] {
assert_eq!(3, depth(&h, n));
}
let first = [split, left, right, merge]
.iter()
.map(|n| h.get_parent(*n).unwrap())
.unique()
.exactly_one()
.unwrap();
let second = [head, tail]
.iter()
.map(|n| h.get_parent(*n).unwrap())
.unique()
.exactly_one()
.unwrap();
assert_ne!(first, second);
Ok(())
}
#[test]
fn test_cond_then_loop_combined() -> Result<(), BuildError> {
// Here we would like two consecutive regions, but there is no *edge* between
// the conditional and the loop to indicate the boundary, so we cannot separate them.
let (h, merge, tail) = build_cond_then_loop_cfg()?;
let (merge, tail) = (merge.node(), tail.node());
let [entry, exit]: [Node; 2] = h
.children(h.root())
.take(2)
.collect_vec()
.try_into()
.unwrap();
let v = IdentityCfgMap::new(RootChecked::try_new(&h).unwrap());
let edge_classes = EdgeClassifier::get_edge_classes(&v);
let [&left, &right] = edge_classes
.keys()
.filter(|(s, _)| *s == entry)
.map(|(_, t)| t)
.collect::<Vec<_>>()[..]
else {
panic!("Entry node should have two successors");
};
let classes = group_by(edge_classes);
assert_eq!(
classes,
HashSet::from([
sorted([(entry, left), (left, merge)]), // Region containing single BB 'left'.
sorted([(entry, right), (right, merge)]), // Region containing single BB 'right'.
Vec::from([(tail, exit)]), // The only edge in neither conditional nor loop.
Vec::from([(merge, tail)]), // Loop body (at least once per execution).
Vec::from([(tail, merge)]), // Loop backedge (0 or more times per execution).
])
);
Ok(())
}
#[test]
fn test_cond_in_loop_separate_headers() -> Result<(), BuildError> {
let (mut h, head, tail) = build_conditional_in_loop_cfg(true)?;
let head = head.node();
let tail = tail.node();
// /-> left --\
// entry -> head -> split > merge -> tail -> exit
// | \-> right -/ |
// \---<---<---<---<---<---<---<---<---/
// split is unique successor of head
let split = h.output_neighbours(head).exactly_one().unwrap();
// merge is unique predecessor of tail
let merge = h.input_neighbours(tail).exactly_one().unwrap();
// There's no need to use a view of a region here but we do so just to check
// that we *can* (as we'll need to for "real" module Hugr's)
let v = IdentityCfgMap::new(SiblingGraph::try_new(&h, h.root()).unwrap());
let edge_classes = EdgeClassifier::get_edge_classes(&v);
let IdentityCfgMap { h: _, entry, exit } = v;
let [&left, &right] = edge_classes
.keys()
.filter(|(s, _)| *s == split)
.map(|(_, t)| t)
.collect::<Vec<_>>()[..]
else {
panic!("Split node should have two successors");
};
let classes = group_by(edge_classes);
assert_eq!(
classes,
HashSet::from([
sorted([(split, left), (left, merge)]), // Region containing single BB 'left'
sorted([(split, right), (right, merge)]), // Region containing single BB 'right'
sorted([(head, split), (merge, tail)]), // "Conditional" region containing split+merge choosing between left/right
sorted([(entry, head), (tail, exit)]), // "Loop" region containing body (conditional) + back-edge
Vec::from([(tail, head)]) // The loop back-edge
])
);
// Again, there's no need for a view of a region here, but check that the
// transformation still works when we can only directly mutate the top level
let root = h.root();
let m = SiblingMut::<CfgID>::try_new(&mut h, root).unwrap();
transform_cfg_to_nested(&mut IdentityCfgMap::new(m));
h.update_validate(&PRELUDE_REGISTRY).unwrap();
assert_eq!(1, depth(&h, entry));
assert_eq!(3, depth(&h, head));
for n in [split, left, right, merge] {
assert_eq!(5, depth(&h, n));
}
assert_eq!(3, depth(&h, tail));
assert_eq!(1, depth(&h, exit));
Ok(())
}
#[test]
fn test_cond_in_loop_combined_headers() -> Result<(), BuildError> {
let (h, head, tail) = build_conditional_in_loop_cfg(false)?;
let head = head.node();
let tail = tail.node();
// /-> left --\
// entry -> head > merge -> tail -> exit
// | \-> right -/ |
// \---<---<---<---<---<--<---/
// Here we would like an indication that we can make two nested regions,
// but there is no edge to act as entry to a region containing just the conditional :-(.
let v = IdentityCfgMap::new(RootChecked::try_new(&h).unwrap());
let edge_classes = EdgeClassifier::get_edge_classes(&v);
let IdentityCfgMap { h: _, entry, exit } = v;
// merge is unique predecessor of tail
let merge = *edge_classes
.keys()
.filter(|(_, t)| *t == tail)
.map(|(s, _)| s)
.exactly_one()
.unwrap();
let [&left, &right] = edge_classes
.keys()
.filter(|(s, _)| *s == head)
.map(|(_, t)| t)
.collect::<Vec<_>>()[..]
else {
panic!("Loop header should have two successors");
};
let classes = group_by(edge_classes);
assert_eq!(
classes,
HashSet::from([
sorted([(head, left), (left, merge)]), // Region containing single BB 'left'
sorted([(head, right), (right, merge)]), // Region containing single BB 'right'
Vec::from([(merge, tail)]), // The edge "in the loop", but no other edge in its class to define SESE region
sorted([(entry, head), (tail, exit)]), // "Loop" region containing body (conditional) + back-edge
Vec::from([(tail, head)]) // The loop back-edge
])
);
Ok(())
}
#[test]
fn incorrect_insertion() {
let (mut h, _, tail) = build_conditional_in_loop_cfg(false).unwrap();
let final_node = tail.node();
let final_node_input = h.node_inputs(final_node).next().unwrap();
let rw = IdentityInsertion::new(final_node, final_node_input);
let apply_result = h.apply_rewrite(rw);
assert_eq!(
apply_result,
Err(IdentityInsertionError::InvalidPortKind(Some(
EdgeKind::ControlFlow
)))
);
}
fn n_identity<T: DataflowSubContainer>(
mut dataflow_builder: T,
pred_const: &ConstID,
) -> Result<T::ContainerHandle, BuildError> {
let w = dataflow_builder.input_wires();
let u = dataflow_builder.load_const(pred_const);
dataflow_builder.finish_with_outputs([u].into_iter().chain(w))
}
fn build_if_then_else_merge<T: AsMut<Hugr> + AsRef<Hugr>>(
cfg: &mut CFGBuilder<T>,
const_pred: &ConstID,
unit_const: &ConstID,
) -> Result<(BasicBlockID, BasicBlockID), BuildError> {
let split = n_identity(
cfg.simple_block_builder(FunctionType::new_endo(NAT), 2)?,
const_pred,
)?;
let merge = build_then_else_merge_from_if(cfg, unit_const, split)?;
Ok((split, merge))
}
fn build_then_else_merge_from_if<T: AsMut<Hugr> + AsRef<Hugr>>(
cfg: &mut CFGBuilder<T>,
unit_const: &ConstID,
split: BasicBlockID,
) -> Result<BasicBlockID, BuildError> {
let merge = n_identity(
cfg.simple_block_builder(FunctionType::new_endo(NAT), 1)?,
unit_const,
)?;
let left = n_identity(
cfg.simple_block_builder(FunctionType::new_endo(NAT), 1)?,
unit_const,
)?;
let right = n_identity(
cfg.simple_block_builder(FunctionType::new_endo(NAT), 1)?,
unit_const,
)?;
cfg.branch(&split, 0, &left)?;
cfg.branch(&split, 1, &right)?;
cfg.branch(&left, 0, &merge)?;
cfg.branch(&right, 0, &merge)?;
Ok(merge)
}
// /-> left --\
// entry > merge -> tail -> exit
// \-> right -/ \-<--<-/
// Result is Hugr plus merge and tail blocks
fn build_cond_then_loop_cfg() -> Result<(Hugr, BasicBlockID, BasicBlockID), BuildError> {
let mut cfg_builder = CFGBuilder::new(FunctionType::new_endo(NAT))?;
let pred_const = cfg_builder.add_constant(Value::unit_sum(0, 2).expect("0 < 2"));
let const_unit = cfg_builder.add_constant(Value::unary_unit_sum());
let entry = n_identity(
cfg_builder.simple_entry_builder(type_row![NAT], 2, ExtensionSet::new())?,
&pred_const,
)?;
let merge = build_then_else_merge_from_if(&mut cfg_builder, &const_unit, entry)?;
// The merge block is also the loop header (so it merges three incoming control-flow edges)
let tail = n_identity(
cfg_builder.simple_block_builder(FunctionType::new_endo(NAT), 2)?,
&pred_const,
)?;
cfg_builder.branch(&tail, 1, &merge)?;
cfg_builder.branch(&merge, 0, &tail)?; // trivial "loop body"
let exit = cfg_builder.exit_block();
cfg_builder.branch(&tail, 0, &exit)?;
let h = cfg_builder.finish_prelude_hugr()?;
Ok((h, merge, tail))
}
// Build a CFG, returning the Hugr
pub(crate) fn build_conditional_in_loop_cfg(
separate_headers: bool,
) -> Result<(Hugr, BasicBlockID, BasicBlockID), BuildError> {
let mut cfg_builder = CFGBuilder::new(FunctionType::new_endo(NAT))?;
let (head, tail) = build_conditional_in_loop(&mut cfg_builder, separate_headers)?;
let h = cfg_builder.finish_prelude_hugr()?;
Ok((h, head, tail))
}
pub(crate) fn build_conditional_in_loop<T: AsMut<Hugr> + AsRef<Hugr>>(
cfg_builder: &mut CFGBuilder<T>,
separate_headers: bool,
) -> Result<(BasicBlockID, BasicBlockID), BuildError> {
let pred_const = cfg_builder.add_constant(Value::unit_sum(0, 2).expect("0 < 2"));
let const_unit = cfg_builder.add_constant(Value::unary_unit_sum());
let entry = n_identity(
cfg_builder.simple_entry_builder(type_row![NAT], 1, ExtensionSet::new())?,
&const_unit,
)?;
let (split, merge) = build_if_then_else_merge(cfg_builder, &pred_const, &const_unit)?;
let head = if separate_headers {
let head = n_identity(
cfg_builder.simple_block_builder(FunctionType::new_endo(NAT), 1)?,
&const_unit,
)?;
cfg_builder.branch(&head, 0, &split)?;
head
} else {
// Combine loop header with split.
split
};
let tail = n_identity(
cfg_builder.simple_block_builder(FunctionType::new_endo(NAT), 2)?,
&pred_const,
)?;
cfg_builder.branch(&tail, 1, &head)?;
cfg_builder.branch(&merge, 0, &tail)?;
let exit = cfg_builder.exit_block();
cfg_builder.branch(&entry, 0, &head)?;
cfg_builder.branch(&tail, 0, &exit)?;
Ok((head, tail))
}
}