hatchery_node/

server.rs

use crate::git_worktree::{
    create_worktree as create_git_worktree,
    create_worktree_with_timeout as create_git_worktree_with_timeout,
    list_worktrees as list_git_worktrees,
    list_worktrees_with_deadline as list_git_worktrees_with_deadline,
    paths_equal as worktree_paths_equal, remove_worktree as remove_git_worktree,
    removal_lookup_path as normalize_worktree_removal_target,
    resolve_base_commit_with_timeout,
    run_git_read_bounded, GitCommandOutput, GitWorktreeError, GitWorktreeErrorKind,
    NativeGitWorktreeSnapshot,
};
use crate::host_directory_browser::{
    browse_host_directories, HostDirectoryBrowseError, HostDirectoryBrowseErrorKind,
};
use crate::environment_profiles::{
    EnvironmentProfileBinding, NodeEnvironmentProfile, MAX_NODE_ENVIRONMENT_PROFILES,
};
use crate::bundle_catalog::{BundleCatalog, NodeBundle};
use self::bundle_delivery::{DeliveryStore, DeliveryStoreError};
use self::context_pack_store::ContextPackStore;
use crate::bundle_provider::{
    bundle_launch_arguments, validate_bundle_binding, BundleProviderLayout,
};
use crate::context_pack::{
    ContextPackCatalog, ContextPackRepository, ContextPackRepositoryFileSource,
    ContextPackSelectedFileSkipReason, NodeContextPack, CONTEXT_PACK_SELECTED_FILES,
};
use crate::harness_mcp_proxy::{
    HarnessMcpProxyError, HarnessMcpProxyRegistry, PreparedHarnessMcpSpawn,
    ReviewedHarnessMcpProgram,
};
use crate::session_environment::{
    MaterializationId, MaterializationOwner, MaterializationOwnershipRecord,
    MaterializationState, NodeSecretResolver, NodeSessionMaterializationProfile,
    SessionEnvironmentMaterializeError, SessionEnvironmentMaterializer,
};
use crate::worktree_service::{
    exact_created_worktree, exact_owned_worktree, ManagedWorktreeLeaseRecord,
    ManagedWorktreeProfile, ManagedWorktreeRegistry, ManagedWorktreeSessionHolder,
};
use crate::session_registry::{
    self, validate_display_name, LoadedNodeState, ManagedWorktreeSpawnReplayRecordV10,
    ManagedWorktreeSpawnReplayStateV10, MAX_MANAGED_SESSION_RECORDS,
    MAX_MANAGED_WORKTREE_SPAWN_REPLAYS,
};
#[cfg(unix)]
use crate::workspace_file_unix::{
    create_workspace_directory as create_workspace_directory_on_disk,
    create_workspace_file as create_workspace_file_on_disk,
    read_workspace_file as read_workspace_file_from_disk,
    write_workspace_file as write_workspace_file_to_disk, WorkspaceFileBytes,
    WorkspaceFileReadError, WorkspaceFileReadErrorKind,
    WORKSPACE_ENTRY_CREATE_CANCELED, WORKSPACE_ENTRY_CREATE_COMMITTING,
    WORKSPACE_ENTRY_CREATE_PENDING,
};
#[cfg(windows)]
use crate::workspace_file_windows::{
    create_workspace_directory as create_workspace_directory_on_disk,
    create_workspace_file as create_workspace_file_on_disk,
    read_workspace_file as read_workspace_file_from_disk,
    write_workspace_file as write_workspace_file_to_disk, WorkspaceFileBytes,
    WorkspaceFileReadError, WorkspaceFileReadErrorKind,
    WORKSPACE_ENTRY_CREATE_CANCELED, WORKSPACE_ENTRY_CREATE_COMMITTING,
    WORKSPACE_ENTRY_CREATE_PENDING,
};
use crate::platform;
use crate::provider_runtime::{
    require_policy, ProviderRuntimeAdmissionError, ProviderRuntimeMonitor,
    ProviderRuntimeRequirement,
};
use crate::spawn_spec::SpawnProfileRegistry;
use crate::standalone_workspace::{
    prepare_standalone_workspace, StandaloneWorkspaceError, StandaloneWorkspaceErrorKind,
};
use crate::protocol::{
    read_json_frame_limited_body_timeout, write_json_frame, write_json_frame_limited,
    validate_node_negotiated_handshake_capacity, validate_provider_contract_manifest,
    provider_id_is_legacy, AdapterContractRevision, AgentStreamChunkKindV1, AgentStreamChunkV1,
    AgentStreamInteractionOptionV1, AgentStreamNamedIdV1,
    CapabilityId, ClientFrame, ClientRole,
    ControllerState, DeliveryBlobChunkHexV1, DeliveryBlobDigestV1,
    DeliveryBundleManifestV2, DeliveryCommitReceiptV1, DeliveryStageId,
    AgentProgressAttentionKindV1, AgentProgressAttentionV1, AgentProgressCurrentV1,
    AgentProgressEventKindV1, AgentProgressUsageV1, AgentProgressV1, FrameError,
    GitCommitDetails, GitDiff, GitDiffMode, GitDiffRequest, GitHistoryPage,
    GitObjectId, GitCommitSummary, GitSignatureStatus, GitSnapshot, GitStatusEntry,
    GitWorktreeSnapshot, HarnessMcpActivationDigest, HarnessMcpReservationId,
    HostDirectoryListing,
    NodeCompatibilitySupport, NodeEvent,
    NodeEventEnvelope, NodeFailure, NodeFailureCode, NodeHello, NodeId, NodeIncarnationId,
    NegotiatedNodeCompatibility, NodeRequest, NodeResponse, NodeSnapshot, OpaqueHostPath,
    ProtocolRange,
    ProviderAdapterContractSupport,
    ProviderContractRevision, ProviderContractSupport, RepositoryPath, RequestEnvelope,
    ProviderRuntimeStatuses, ResolvedBundleReceipt, ResolvedEnvironmentProfileReceipt,
    ContextPackLineageReceipt, ContextPackBytesRead, ResolvedContextPackReceipt,
    ResolvedHarnessMcpProxyReceiptV1, ResolvedSpawnReceipt,
    ResolvedSpawnSpec, ResponseEnvelope,
    ServerChallenge, ServerFrame, SessionAddress, SessionAgentProgress, SessionKey, SessionMode,
    ManagedSessionRecord,
    ManagedSessionState, ManagedWorktreeCleanupFailure, ManagedWorktreeLeaseId,
    SessionRecordRetentionConfig,
    ManagedWorktreeLeaseSnapshot, ManagedWorktreeLeaseState, ManagedWorktreeRetention,
    ManagedWorktreeSpawnReceipt, ManagedWorktreeSpawnRequest,
    ManagedWorktreeSpawnRequestV2, SessionRecordId,
    NativeSessionCatalogRoute, NativeSessionSelection, SessionTaskBindingV1,
    SessionTaskTargetV1, TaskId,
    BlockAuthorityV1, HarnessMcpLaunchV1, SessionHistorySummaryV1, MAX_ACP_BLOCKED_HELP_BYTES, MAX_ACP_BLOCKED_REASON_BYTES,
    StateSchemaSupport, WorkspaceEntry, WorkspaceEntryKind, WorktreeProfileId,
    SpawnContextId, SpawnEnvironmentProfileId, SpawnIdempotencyKey,
    SpawnProfileDefaults, SpawnRequiredCapabilities, SpawnSpec, SpawnSpecResolveError,
    WorkspaceFileContent, WorkspaceFileRevision,
    WorkspaceFileRead, WorkspaceId, WorkspaceInspection, WorkspaceInspectionTruncationV1,
    WorkspaceSnapshot,
    WorktreeServiceMode,
    LaunchInventory, ManagedWorktreeProfileSummary, SpawnProfileSummary,
    WorktreeProfileInventory, MAX_MANAGED_WORKTREE_PROFILES_PER_WORKSPACE,
    DEFAULT_CONTROLLER_LEASE_MS,
    MAX_CONTROLLER_LEASE_MS, MIN_CONTROLLER_LEASE_MS, NODE_COMPATIBILITY_METADATA_CAPABILITY,
    CAPABILITY_HOST_DIRECTORY_BROWSE_V1,
    NODE_PROVIDER_CONTRACT_MANIFEST_CAPABILITY, NODE_REPOSITORY_PATH_CAPABILITY,
    NODE_PROVIDER_ID_OPEN_CAPABILITY,
    NODE_PROVIDER_SESSION_REFERENCE_INDEX_CAPABILITY,
    NODE_PROVIDER_RUNTIME_STATUS_CAPABILITY, NODE_CHILD_ENVIRONMENT_PROFILE_CAPABILITY,
    NODE_HISTORY_CONTEXT_PACK_CAPABILITY, NODE_SESSION_RECORD_CONTEXT_EXPORT_CAPABILITY,
    NODE_NATIVE_SESSION_CATALOG_CAPABILITY, NODE_NATIVE_SESSION_CATALOG_PAGING_CAPABILITY,
    NODE_NATIVE_SESSION_INDEX_CAPABILITY, NODE_NATIVE_SESSION_PREVIEW_CAPABILITY,
    NODE_AGENT_PROGRESS_SNAPSHOT_CAPABILITY,
    NODE_DELIVERY_BUNDLE_V2_STAGE_COMMIT_CAPABILITY,
    NODE_HARNESS_MCP_READ_PROXY_CAPABILITY,
    NODE_SESSION_TASK_CORRELATION_CAPABILITY,
    NODE_STANDALONE_WORKSPACE_LIFECYCLE_CAPABILITY,
    NODE_SESSION_BUNDLE_MATERIALIZATION_CAPABILITY,
    NODE_MANAGED_WORKTREE_LIFECYCLE_CAPABILITY,
    NODE_MANAGED_WORKTREE_SPAWN_V2_CAPABILITY,
    NODE_SPAWN_PROFILE_REVISION_CAPABILITY, NODE_SPAWN_SPEC_DEFAULTS_OVERRIDES_CAPABILITY,
    NODE_TERMINAL_FRAME_EVENTS_CAPABILITY,
    NODE_AGENT_STREAM_EVENTS_CAPABILITY, NODE_ACP_CONTROL_CAPABILITY,
    NODE_GIT_READ_CAPABILITY, NODE_WORKSPACE_FILE_READ_CAPABILITY,
    NODE_WORKSPACE_FILE_WRITE_CAPABILITY, NODE_WORKSPACE_ENTRY_CREATE_CAPABILITY,
    NODE_WORKTREE_SELECTION_CAPABILITY,
    BUILD_STAMP, MAX_NODE_CLIENT_FRAME_BYTES, MAX_NODE_HELLO_FRAME_BYTES,
    MAX_AGENT_PROGRESS_ACTIVE_TOOL_LABELS, MAX_AGENT_PROGRESS_ENTRY_BYTES,
    MAX_NODE_TERMINAL_BYTES, MAX_NODE_TEXT_BYTES,
    MAX_REPOSITORY_PATH_BYTES,
    MAX_GIT_DIFF_BYTES, MAX_GIT_HISTORY_COMMITS, MAX_WORKSPACE_FILE_BYTES,
    MAX_HARNESS_MCP_PENDING_CALLS_PER_NODE,
    MAX_WORKSPACE_ROOT_BYTES, NODE_STATE_SCHEMA_V1, NODE_STATE_SCHEMA_V10,
    SPAWN_RUNTIME_PROVIDER_SESSION_IDENTITY, SPAWN_RUNTIME_RAW_PTY_LIFECYCLE,
    SPAWN_RUNTIME_SEMANTIC_READINESS, SPAWN_RUNTIME_SEMANTIC_RESUME,
    SPAWN_RUNTIME_STRUCTURED_PROMPT,
};
#[cfg(test)]
use crate::protocol::WorktreeProfileRevision;
use ring::digest::{digest, SHA256};
use crate::protocol::correlation::{
    interaction_correlation, sanitize_progress_tool_label, tool_class_label, tool_correlation,
    truncate_text,
};
use gate4agent_catalog::{builtin_registry, AgentRegistry};
use gate4agent_handle::{EventSubscription, Gate4AgentHandle, PortDispatchError};
use gate4agent_runtime_native::{
    NativeMcpServerLaunchOverlay, NativeInstanceLaunchOverlay,
    NativeLaunchEnvironmentOverlay,
    NativeHistoryConfig, NativeLaunchProfileControl, NativeRuntime, NativeRuntimeConfig,
    NativeSessionCatalogAuthority, NativeSessionCatalogError, NativeSessionPreviewError,
    ScopedNativeSessionCatalogEntry,
};
use gate4agent_runtime_native::shell_efficiency::ShellEfficiencyProfile;
use std::sync::OnceLock;
use gate4agent_runtime_native::tick_profile::TickProfileSnapshot;
use drive_loop_profile::DriveLoopProfiler;
#[cfg(test)]
use gate4agent_runtime_native::{HistorySourceLayout, NativeHistoryRoot};
use gate4agent_node_wire::{
    auth_proof, negotiated_auth_proof, proofs_match, random_incarnation_id, random_nonce,
    AuthDirection, OwnerOnlyLocalListener,
};
use gate4agent_types::{
    AdapterBinding, AdapterFamily, AgentAdapterCapabilities, AgentCapabilities, AgentId,
    AgentInstanceId, AgentReadinessSpec, AgentSpec, AgentTransportCapabilities, ApprovalLevel,
    DetectionSpec, InitialPromptMode, LaunchSpec, ProcessMatcher, PromptSpec, SpecVerification,
    CommandEnvelope, CommandId,
    validate_candidate_id, ControlCommand, ControlEvent, ControlEventKind,
    HistoryCandidateSummary, HistoryOperation, HistoryQuery, HistorySessionRecord,
    HostDecisionAuthority as ProviderHostDecisionAuthority,
    HostRequestDecision as ProviderHostRequestDecision,
    InputAction,
    PromptFraming, PromptPayload, ResumeLaunchRequest,
    ProviderActivity, ProviderEvent, ProviderInteractionKind, ProviderInteractionStatus,
    ProviderRuntimeCapability, ProviderRuntimePolicy, ProviderSessionIdentity, ProviderSessionKey,
    ProviderSnapshot, ProviderStopReason,
    ResumeTarget,
    SessionGeneration, StartRequest,
    TerminalControl, TerminalText,
    SessionStatus, TerminalFrame, TransportKind, CONTROL_SESSIONS_MAX,
    HISTORY_DISCOVERY_LIMIT_MAX, WORKING_DIRECTORY_MAX_BYTES,
};
use std::collections::{BTreeMap, VecDeque};
use std::ffi::OsString;
use std::io;
use std::path::{Path, PathBuf};
use std::sync::atomic::{AtomicBool, AtomicU8, AtomicU64, AtomicUsize, Ordering};
use std::sync::{Arc, Mutex, RwLock};
use std::time::{Duration, Instant};
use thiserror::Error;
use tokio::sync::{broadcast, mpsc, Mutex as AsyncMutex, Notify, OwnedSemaphorePermit, Semaphore};
use tokio::task::{AbortHandle, JoinSet};
use tokio::time::{sleep, timeout};

mod http_api;
pub mod backend_paths;
pub mod node_wake;

/// Model of the spawn in progress (for the m4a auto-nick), if the request named one.
pub fn spawn_model() -> Option<String> {
    SPAWN_SESSION_OPTIONS.try_with(|o| o.as_ref().map(|o| o.model.clone())).ok().flatten().filter(|m| !m.is_empty())
        .or_else(|| SPAWN_NICK_MODEL.try_with(|m| m.clone()).ok().flatten().filter(|m| !m.is_empty()))
}

tokio::task_local! {
    /// Model named by the spawn request (any launch path, ACP included), for the m4a auto-nick
    /// that is registered before the ACP options are applied.
    static SPAWN_NICK_MODEL: Option<String>;
    /// Launch options (model / effort) of a `SpawnWithOptions` request, scoped around that
    /// spawn so the provider's start carries them (g4a maps them to the CLI's own flags).
    static SPAWN_SESSION_OPTIONS: Option<gate4agent_types::SessionOptionSelection>;
    /// Provider session id to resume (node-start restore of journalled sessions).
    static RESUME_PROVIDER_SESSION: Option<String>;
    /// Origin (`human`/`agent`) and optional parent signature for the node session registry.
    static SPAWN_ORIGIN: Option<String>;
    static SPAWN_PARENT: Option<String>;
}

/// `SpawnSessionOptions` -> g4a selection. Effort needs a model (g4a options hang off a model).
fn spawn_selection(
    options: &gate4agent_node_protocol::SpawnSessionOptions,
) -> Result<Option<gate4agent_types::SessionOptionSelection>, NodeFailure> {
    options.validate().map_err(|e| failure(NodeFailureCode::InvalidRequest, e))?;
    match (&options.model, &options.effort) {
        (None, None) => Ok(None),
        (None, Some(_)) => Err(failure(NodeFailureCode::InvalidRequest, "spawn effort needs a model")),
        (Some(model), effort) => {
            let mut sel = gate4agent_types::SessionOptionSelection::new(model.clone());
            if let Some(e) = effort {
                sel = sel.with_value("effort", e.clone());
            }
            Ok(Some(sel))
        }
    }
}

mod browser_bridge;

use gate4agent_node_core::drive_loop_profile;

#[path = "bundle_delivery.rs"]
mod bundle_delivery;

#[path = "context_pack_store.rs"]
mod context_pack_store;

#[cfg(windows)]
pub use crate::platform::DEFAULT_NODE_ENDPOINT;

const NODE_EVENT_HISTORY_MAX: usize = 4_096;
const NODE_BROADCAST_CAPACITY: usize = 1_024;
const NODE_TERMINAL_BROADCAST_CAPACITY: usize = 1;
/// Unlike `NODE_TERMINAL_BROADCAST_CAPACITY`'s single replaceable slot (a
/// terminal frame is a full-screen snapshot; only the latest ever matters),
/// an `AgentStreamChunkV1` is one delta in an ordered sequence -- collapsing
/// two pending sends into one would silently drop content a subscriber can
/// never recover. This needs headroom for a burst instead.
const NODE_AGENT_STREAM_BROADCAST_CAPACITY: usize = 256;
/// The node never has more than `MAX_HARNESS_MCP_PENDING_CALLS_PER_NODE`
/// `NodeEvent::HarnessMcpReadCall`s in flight at once (`begin_call`'s own
/// admission check), and `publish_transient` sends each exactly once as a
/// single-envelope batch -- so this many slots covers the entire pending
/// set without ever lagging the one subscriber that matters, the harness's
/// own connection, the way sharing the durable `event_tx`'s bus could.
const NODE_HARNESS_MCP_PROXY_BROADCAST_CAPACITY: usize = MAX_HARNESS_MCP_PENDING_CALLS_PER_NODE;
const NODE_CONNECTION_EVENT_BURST_MAX: usize = 16;
const CONTROL_EVENT_SUBSCRIPTION_CAPACITY: usize = 1_024;
const MAX_PREAUTH_CONNECTIONS: usize = 32;
const MAX_AUTHENTICATED_CONNECTIONS: usize = 16;
const AUTH_FRAME_TIMEOUT_MS: u64 = 5_000;
const FRAME_BODY_TIMEOUT_MS: u64 = 5_000;
const CONNECTION_SHUTDOWN_GRACE_MS: u64 = 250;
const SPAWN_DISPATCH_TIMEOUT_MS: u64 = 2_000;
/// Fresh Spawn stays provisional until HQ successfully attaches (first Resize /
/// TerminalBytes). This is an *attach-never-arrived* timeout from spawn time —
/// not the disconnect reconnect grace (HQ owns that, starting only on a real
/// client WS close). A provider conversation id is a session; a PTY with no
/// attached HQ view is still a draft and is reaped here if attach never lands.
const PROVISIONAL_SPAWN_GRACE_MS: u64 = 90_000;
/// How often `drive_runtime_until_shutdown`'s loop re-evaluates the session
/// record retention policy (`NodeServerConfig::session_record_retention`).
/// A sweep cadence, not a policy value -- the policy itself lives entirely
/// in the operator-configured age/keep-N flags; this just bounds how stale
/// the in-memory view of dead `Unavailable` records can get between sweeps
/// on an otherwise-idle node, mirroring the once-per-startup sweep that
/// also runs alongside `reconcile_managed_worktrees`.
const SESSION_RECORD_RETENTION_SWEEP_PERIOD: Duration = Duration::from_secs(5 * 60);
/// TTL for `NodeShared::rejected_command_reasons` entries -- see that
/// field's own doc for why a spawn waiter needs this at all. Must outlive
/// the longest a waiter can still be polling for this exact command's
/// outcome: `gate4agent_node_protocol::MAX_SPAWN_DEADLINE_MS` (120s) is the
/// largest `deadline_ms` any caller may request, and the margin on top
/// absorbs the waiter's own poll cadence plus clock skew between the drive
/// loop (writer) and the waiter (reader).
const REJECTED_COMMAND_REASON_TTL_MS: u64 = 150_000;
/// Bounds `NodeShared::rejected_command_reasons` against an unbounded
/// backlog of asynchronously-rejected commands nobody ever collects (a
/// waiter that stops polling, or a burst of always-rejected commands from a
/// misbehaving caller): once at capacity, the oldest entry is evicted to
/// make room for the newest, mirroring the eviction rule already used by
/// `spawn_idempotency`.
const REJECTED_COMMAND_REASON_MAX_ENTRIES: usize = 256;
/// How long `wait_until_removed` waits between two `Remove` re-dispatches
/// for the same session. The presence poll runs far faster (2ms); this
/// only paces the sending, so an accepted `Remove` still in flight is not
/// piled on by a dozen more that land on an already-dropped instance.
const REMOVE_REDISPATCH_INTERVAL_MS: u64 = 100;
const SPAWN_IDEMPOTENCY_MAX_ENTRIES: usize = 256;
const SPAWN_IDEMPOTENCY_TTL_MS: u64 = 15 * 60 * 1_000;
const PROVIDER_RUNTIME_ADMISSION_TIMEOUT_MS: u64 = 2_500;
const MUTATION_SETTLE_TIMEOUT_MS: u64 = 5_000;
const READINESS_SETTLE_HEADROOM_MS: u64 = 2_000;
const MANAGED_RESUME_SETTLE_TIMEOUT_MS: u64 = 30_000;
const WORKSPACE_INSPECTION_MAX_CONCURRENCY: usize = 4;
const WORKSPACE_FILE_READ_TIMEOUT_MS: u64 = 2_000;
const HOST_DIRECTORY_BROWSE_TIMEOUT_MS: u64 = 2_000;
const NATIVE_SESSION_CATALOG_TIMEOUT_MS: u64 = 30_000;
const WORKSPACE_TREE_MAX_DEPTH: usize = 6;
const WORKSPACE_TREE_MAX_ENTRIES: usize = 512;
/// Default total wall-clock budget for `inspect_workspace`'s walk+git
/// chain, overridable via `GATE4AGENT_NODE_WORKSPACE_INSPECTION_BUDGET_MS`.
const WORKSPACE_INSPECTION_TIME_BUDGET_MS_DEFAULT: u64 = 8_000;
/// The harness relay enforces its own flat response deadline
/// (`HOST_RUN_READ_RESPONSE_DEADLINE`, `hatchery-harness-service::runtime`,
/// 12s) above this node-side budget. The two constants live in different
/// crates with no shared definition, so clamp any override here comfortably
/// below that external ceiling — a misconfigured value above it would
/// reopen the exact deadline race this budget exists to close.
const WORKSPACE_INSPECTION_TIME_BUDGET_MS_MAX: u64 = 11_000;
/// Default cap on directory entries visited (not just returned) by one
/// walk, overridable via `GATE4AGENT_NODE_WORKSPACE_INSPECTION_ENTRY_CAP`.
const WORKSPACE_INSPECTION_ENTRY_CAP_DEFAULT: usize = 50_000;
const WORKSPACE_INSPECTION_ENTRY_CAP_MAX: usize = 1_000_000;
const GIT_STATUS_MAX_ENTRIES: usize = 128;
const GIT_COMMIT_MAX_ENTRIES: usize = 12;
const GIT_OUTPUT_MAX_BYTES: usize = 64 * 1_024;
const GIT_DIAGNOSTIC_MAX_BYTES: usize = 1_024;
const WORKSPACE_FILE_WRITE_TIMEOUT_MS: u64 = 5_000;
const WORKSPACE_ENTRY_CREATE_TIMEOUT_MS: u64 = 5_000;
const GIT_COMMAND_TIMEOUT_MS: u64 = 1_500;
const WORKSPACE_UNAVAILABLE_ERROR: &str = "workspace-unavailable";
const PROVIDER_SESSION_SCOPE_CONFLICT_ERROR: &str = "provider-session-scope-conflict";
const PROVIDER_SESSION_LIVE_CONFLICT_ERROR: &str = "provider-session-live-conflict";
const MANAGED_SESSION_CAPACITY_ERROR: &str = "managed-session-capacity";
const PROVIDER_IDENTITY_ALLOCATION_ERROR: &str =
    "provider-session-identity-allocation-failed";
const PROVIDER_RESUME_REJECTED_ERROR: &str = "provider-resume-rejected";
const DURABLE_STATE_COMMIT_FAILED_ERROR: &str = "durable-state-commit-failed";
const DURABLE_STATE_LOCK_FAILED_ERROR: &str = "durable-state-lock-failed";
const DURABLE_STATE_LOAD_FAILED_ERROR: &str = "durable-state-load-failed";
const DURABLE_STATE_CONFLICT_ERROR: &str = "durable-state-conflict";
const DURABLE_STATE_SCHEMA_UNSUPPORTED_ERROR: &str = "durable-state-schema-unsupported";
const DURABLE_STATE_PATH_SEMANTICS_UNSUPPORTED_ERROR: &str =
    "durable-state-path-semantics-unsupported";

fn opaque_windows_path(value: String) -> OpaqueHostPath {
    OpaqueHostPath::utf8(value).expect("validated Windows node path must remain wire-safe")
}

fn agent_progress_from_provider_snapshot(
    address: SessionAddress,
    provider: &ProviderSnapshot,
) -> Option<SessionAgentProgress> {
    let mut truncated = false;
    let active_tool_count = bounded_progress_count(provider.active_tools.len(), &mut truncated);
    let mut active_tool_labels = Vec::with_capacity(
        provider
            .active_tools
            .len()
            .min(MAX_AGENT_PROGRESS_ACTIVE_TOOL_LABELS),
    );
    for tool in &provider.active_tools {
        if active_tool_labels.len() == MAX_AGENT_PROGRESS_ACTIVE_TOOL_LABELS {
            truncated = true;
            break;
        }
        if let Some(label) = sanitize_progress_tool_label(&tool.name, &mut truncated) {
            active_tool_labels.push(label);
        }
    }
    let attention = provider
        .interactions
        .iter()
        .find(|interaction| {
            matches!(
                interaction.status,
                ProviderInteractionStatus::Pending | ProviderInteractionStatus::Resolving { .. }
            )
        })
        .map(|interaction| AgentProgressAttentionV1 {
            kind: match interaction.interaction_kind {
                ProviderInteractionKind::Approval => AgentProgressAttentionKindV1::Approval,
                ProviderInteractionKind::Question => AgentProgressAttentionKindV1::Question,
            },
            tool_label: sanitize_progress_tool_label(&interaction.tool_name, &mut truncated),
        });
    let subagent_count = bounded_progress_count(provider.subagents.len(), &mut truncated);
    let usage = (provider.completed_turns > 0
        || provider.usage.input_tokens > 0
        || provider.usage.output_tokens > 0
        || provider.usage.cache_read_tokens > 0
        || provider.usage.cache_write_tokens > 0
        || provider.usage.reasoning_tokens > 0)
        .then_some(AgentProgressUsageV1 {
            input_tokens: provider.usage.input_tokens,
            output_tokens: provider.usage.output_tokens,
            cache_read_tokens: provider.usage.cache_read_tokens,
            cache_write_tokens: provider.usage.cache_write_tokens,
            reasoning_tokens: provider.usage.reasoning_tokens,
        });
    let progress = AgentProgressV1 {
        provider_sequence: provider.sequence,
        activity: provider.activity,
        completed_turns: provider.completed_turns,
        usage,
        current: AgentProgressCurrentV1::from(provider.activity),
        active_tool_labels,
        active_tool_count,
        attention,
        subagent_count,
        last_event_kind: provider.last_event.as_ref().and_then(agent_progress_event_kind),
        gap_count: provider.gap_count,
        stale: provider.stale,
        truncated,
    };
    let entry = SessionAgentProgress { address, progress };
    serde_json::to_vec(&entry)
        .ok()
        .filter(|encoded| encoded.len() <= MAX_AGENT_PROGRESS_ENTRY_BYTES)
        .map(|_| entry)
}

fn bounded_progress_count(count: usize, truncated: &mut bool) -> u32 {
    match u32::try_from(count) {
        Ok(count) => count,
        Err(_) => {
            *truncated = true;
            u32::MAX
        }
    }
}

fn agent_progress_event_kind(event: &ProviderEvent) -> Option<AgentProgressEventKindV1> {
    if matches!(event, ProviderEvent::ContextWindowUsage { .. }) {
        return None;
    }
    Some(match event {
        ProviderEvent::SessionStarted { .. } => AgentProgressEventKindV1::SessionStarted,
        ProviderEvent::SessionIdentityObserved { .. } => {
            AgentProgressEventKindV1::SessionIdentityObserved
        }
        ProviderEvent::TurnStarted { .. } => AgentProgressEventKindV1::TurnStarted,
        ProviderEvent::WorkingObserved => AgentProgressEventKindV1::WorkingObserved,
        ProviderEvent::Text { .. } => AgentProgressEventKindV1::Text,
        ProviderEvent::Thinking { .. } => AgentProgressEventKindV1::Thinking,
        ProviderEvent::ToolStarted { .. } => AgentProgressEventKindV1::ToolStarted,
        ProviderEvent::ToolCompleted { .. } => AgentProgressEventKindV1::ToolCompleted,
        ProviderEvent::TurnCompleted { .. } => AgentProgressEventKindV1::TurnCompleted,
        ProviderEvent::TurnInterrupted => AgentProgressEventKindV1::TurnInterrupted,
        ProviderEvent::SessionEnded { .. } => AgentProgressEventKindV1::SessionEnded,
        ProviderEvent::Error { .. } => AgentProgressEventKindV1::Error,
        ProviderEvent::Ready => AgentProgressEventKindV1::Ready,
        ProviderEvent::InteractionRequested { .. } => {
            AgentProgressEventKindV1::InteractionRequested
        }
        ProviderEvent::InteractionResolved { .. } => AgentProgressEventKindV1::InteractionResolved,
        ProviderEvent::SubagentStarted { .. } => AgentProgressEventKindV1::SubagentStarted,
        ProviderEvent::SubagentStopped { .. } => AgentProgressEventKindV1::SubagentStopped,
        ProviderEvent::RateLimited { .. } => AgentProgressEventKindV1::RateLimited,
        ProviderEvent::HostRequestObserved { .. } => AgentProgressEventKindV1::HostRequestObserved,
        ProviderEvent::UnrecognizedNotification { .. } => {
            AgentProgressEventKindV1::UnrecognizedNotification
        }
        ProviderEvent::ContextWindowUsage { .. } => unreachable!("handled above"),
        // ACP session/update coverage beyond text/tool/turn streaming
        // (`plan`, `available_commands_update`, `current_mode_update`,
        // `session_info_update`, `usage_update`, `config_option_update`,
        // `user_message_chunk`). `AgentProgressEventKindV1` is a versioned
        // wire enum without a `#[serde(other)]` fallback; minting new
        // variants for it is a deliberate wire-contract decision for
        // whoever owns this protocol, not a side effect of parsing more of
        // ACP's own wire -- until that decision is made, these fold into
        // the same "we saw something, no dedicated kind for it yet" bucket
        // as `UnrecognizedNotification`.
        ProviderEvent::UserMessage { .. }
        | ProviderEvent::Plan { .. }
        | ProviderEvent::AvailableCommandsUpdated { .. }
        | ProviderEvent::ModeChanged { .. }
        | ProviderEvent::SessionInfoUpdated { .. }
        | ProviderEvent::UsageUpdated { .. }
        | ProviderEvent::ConfigOptionsUpdated { .. } => {
            AgentProgressEventKindV1::UnrecognizedNotification
        }
    })
}

/// Maps this harness's own `HostDecisionAuthority` onto the wider
/// Maps a host request decider onto the `BlockAuthorityV1` a `Blocked` stream
/// chunk carries -- the four authorities a `Denied` decision is ever made
/// under, one-for-one. The remaining `BlockAuthorityV1` variants
/// (`ProviderClassifier`, `ProviderPermissionRule`, `ProviderSandbox`,
/// `ProviderRefusal`, `UserRejected`, `ProviderQuota`, `Unknown`) describe a
/// block the PROVIDER side of the wire reported -- this function never
/// produces one, because `ProviderHostDecisionAuthority` has no vocabulary for
/// them; the provider-side blocks below mint those directly from typed fields.
/// Whether a provider source is a live session transport -- the only kind
/// whose events reach the agent stream. History, resume, session-option and
/// capability-probe sources are not sessions and stream nothing.
fn provider_family_is_live(family: AdapterFamily) -> bool {
    match family {
        AdapterFamily::PtySemantic
        | AdapterFamily::Hook
        | AdapterFamily::ManagedHook
        | AdapterFamily::Pipe
        | AdapterFamily::OneShot
        | AdapterFamily::Acp => true,
        AdapterFamily::History
        | AdapterFamily::Resume
        | AdapterFamily::SessionOptions
        | AdapterFamily::CapabilityProbe => false,
    }
}

fn block_authority(by: ProviderHostDecisionAuthority) -> BlockAuthorityV1 {
    match by {
        ProviderHostDecisionAuthority::Gate => BlockAuthorityV1::HostGate,
        ProviderHostDecisionAuthority::Policy => BlockAuthorityV1::HostPolicy,
        ProviderHostDecisionAuthority::Operator => BlockAuthorityV1::Operator,
        ProviderHostDecisionAuthority::DeadlinePolicy => BlockAuthorityV1::HostDeadline,
    }
}

/// The `Blocked::reason` for a `Denied` decision this build's own
/// `AgentEvent::RpcIncomingRequest::reason` did not attach text to --
/// reachable today for `Operator`/`HostDeadline`: a deferred `session/
/// request_permission` request resolved by `AcpSession::
/// resolve_pending_request`/`expire_deadlines` (`src/acp/session.rs`),
/// neither of which computes free text (an operator answers approve/reject,
/// never a comment; an unattended deadline asks nobody anything). `reason`
/// is a REQUIRED field on the wire (see `AgentStreamChunkKindV1::Blocked`)
/// -- a categorical fallback naming the authority is the
/// honest minimum, never a placeholder standing in for detail nobody
/// reported.
fn action_blocked_fallback_reason(authority: BlockAuthorityV1) -> &'static str {
    match authority {
        BlockAuthorityV1::HostGate => "denied by the dangerous-command gate",
        BlockAuthorityV1::HostPolicy => "denied by host policy",
        BlockAuthorityV1::HostDeadline => {
            "denied by host policy after the operator deadline expired"
        }
        BlockAuthorityV1::Operator => "declined by the operator",
        BlockAuthorityV1::ProviderClassifier => "denied by the provider's classifier",
        BlockAuthorityV1::ProviderPermissionRule => "denied by a provider permission rule",
        BlockAuthorityV1::ProviderSandbox => "denied by the provider's sandbox",
        BlockAuthorityV1::ProviderRefusal => "refused by the provider",
        BlockAuthorityV1::UserRejected => "rejected by the user",
        BlockAuthorityV1::ProviderQuota => "the provider's quota or rate limit was exhausted",
        BlockAuthorityV1::Unknown => "blocked; no reason was reported",
    }
}

/// Computes `AgentStreamChunkKindV1::Blocked`'s `tool_class`/`authority`/`reason`
/// for a `HostRequestObserved` `Denied` decision.
fn host_request_denied_block(
    method: &str,
    by: ProviderHostDecisionAuthority,
    reason: Option<&str>,
) -> (String, BlockAuthorityV1, String) {
    let authority = block_authority(by);
    let reason_source = reason.unwrap_or_else(|| action_blocked_fallback_reason(authority));
    // `AgentStreamChunkKindV1::validate` REJECTS an over-long reason outright
    // rather than truncating -- this cut happens here, at the producer, before
    // the validator ever sees the text.
    let (reason_text, _) =
        truncate_text(reason_source, MAX_ACP_BLOCKED_REASON_BYTES);
    (tool_class_label(method), authority, reason_text)
}

// ---------------------------------------------------------------------------
// K2 -- provider-side blocks read off ACP `tool_call_update._meta.
// nonExecutionKind` (`ProviderEvent::ToolCompleted::non_execution_kind`) and
// `SessionEnded::stop_reason` (`stopReason: "refusal"`, or a `session/
// prompt` RPC error whose vendor code names a quota/limit/rate
// exhaustion). See
// `docs/gate4agent/plans/gate4agent-blocked-action-event-2026-09-02.md`
// §3 slice K2.
// ---------------------------------------------------------------------------

/// Classifies ACP's `nonExecutionKind` into the typed authority a block
/// this build mints under, or `None` when the tool truly did not run for a
/// reason that is NOT a block -- `"interrupted"`/`"cancelled"` mean the
/// TURN stopped (session closed, the operator cancelled), not that a
/// policy/classifier/rule refused the call, so those (and any unrecognized
/// future value) stay a plain `ToolCompleted { success: false }` only, per
/// this plan's own rule that a tool failure is never inflated into a block
/// this build cannot actually attribute.
fn provider_tool_block_authority(kind: Option<&str>) -> Option<(BlockAuthorityV1, &'static str)> {
    match kind? {
        "user-rejected" => Some((BlockAuthorityV1::UserRejected, "user-rejected")),
        "permission-rule" => Some((BlockAuthorityV1::ProviderPermissionRule, "permission-rule")),
        _ => None,
    }
}

/// Splits a provider's own denial sentence into `reason`/`help`, when it
/// matches the fixed shape Claude Code's classifier/permission-rule denial
/// uses -- verified live, the owner's sample fixture
/// (`docs/gate4agent/research/gate4agent-blocked-action-signals-2026-09-02.md`
/// appendix): "...denied by <authority>. Reason: <reason>. <help...>".
/// `authority` is NEVER derived from this text (see this module's own rule
/// that authority comes only from a typed field) -- only `reason`/`help`
/// are. Falls back to the full text as `reason` with no `help` when the
/// shape does not match (a provider whose text does not carry this exact
/// wording) -- the honest minimum: the tool truly did not run, so SOME
/// reason is always reported, never fabricated detail beyond what arrived.
fn split_provider_denial_text(text: &str) -> (String, Option<String>) {
    let trimmed = text.trim();
    let Some((_, after_reason)) = trimmed.split_once("Reason:") else {
        return (trimmed.to_owned(), None);
    };
    let tail = after_reason.trim_start();
    let Some((reason, help)) = tail.split_once(". ") else {
        // "Reason:" present but no ". " to split help off -- the whole
        // tail is the reason, e.g. "Reason: Blocked by classifier." with
        // no help text following on some providers/versions.
        let reason = tail.strip_suffix('.').unwrap_or(tail).trim();
        return (reason.to_owned(), None);
    };
    let help = help.trim();
    if help.is_empty() {
        (reason.trim().to_owned(), None)
    } else {
        (reason.trim().to_owned(), Some(help.to_owned()))
    }
}

/// `tool_class` for a provider-side `ActionBlocked` this build has no typed
/// tool name for -- `ProviderEvent::ToolCompleted` carries only `id`, never
/// `name` (see `ProviderEvent::ToolStarted`, which does, but a tool's own
/// name is never threaded through to its completion). Reads the class off
/// the guidance tail's own "add a <Class> permission rule" sentence when
/// present (the shape the owner's sample fixture uses) -- text matching
/// fills `tool_class` here, same as `reason`/`help`, NEVER `authority` (see
/// this module's own rule). Falls back to the same generic `"Tool"` class
/// `ToolCompleted`'s own observation already uses when nothing names one.
fn tool_class_from_denial_help(help: Option<&str>) -> String {
    help.and_then(|text| text.split("add a ").nth(1))
        .and_then(|tail| tail.split(' ').next())
        .filter(|word| !word.is_empty())
        .map(str::to_owned)
        .unwrap_or_else(|| "Tool".to_owned())
}

/// Whether a `session/prompt` RPC error's vendor code (or, absent one, its
/// message) names a quota/rate-limit exhaustion -- Codex's
/// `data.codexErrorInfo: "usageLimitExceeded"` (measured live 2026-09-05)
/// contains "limit", the word this build actually keys on; "quota"/"rate"
/// are kept for whichever OTHER vendor's own code names one of those
/// instead, never confirmed live, but the honest generalization of the
/// one confirmed sample.
fn provider_error_is_quota(vendor_code: Option<&str>, message: &str) -> bool {
    fn names_quota(s: &str) -> bool {
        let lower = s.to_ascii_lowercase();
        lower.contains("limit") || lower.contains("quota") || lower.contains("rate")
    }
    vendor_code.is_some_and(names_quota) || names_quota(message)
}

/// The `Blocked` chunk this build mints when a turn stopped via a
/// typed provider fact rather than a tool call -- `stopReason: "refusal"`
/// (`authority: ProviderRefusal`) or a `session/prompt` RPC error whose
/// vendor code (or message) names a quota/limit/rate exhaustion
/// (`authority: ProviderQuota`, `reason` = the error message verbatim,
/// `reason_kind` = the vendor code). `None` for every other stop --
/// `end_turn`, `max_tokens`, `max_turn_requests`, `cancelled`, an untagged
/// `Other`, or an RPC error whose vendor code/message names none of the
/// three words: `SessionEnded` stays a plain `Exited`/turn-end fact for
/// those, never inflated into a block this build cannot actually
/// attribute. `ProviderRefusal`'s `reason` has no source text to read on
/// `SessionEnded` itself (ACP's `refusal` stopReason carries none) -- the
/// honest minimum names the fact that happened, never invented detail; a
/// later slice that threads the turn's last agent text chunk through can
/// replace it without changing this function's contract.
fn provider_session_end_block(
    stop_reason: &ProviderStopReason,
) -> Option<(BlockAuthorityV1, String, String)> {
    match stop_reason {
        ProviderStopReason::Refusal => Some((
            BlockAuthorityV1::ProviderRefusal,
            "refusal".to_owned(),
            "the provider ended the turn with stopReason: refusal".to_owned(),
        )),
        ProviderStopReason::ProviderError { message, vendor_code, .. }
            if provider_error_is_quota(vendor_code.as_deref(), message) =>
        {
            let reason_kind = vendor_code.clone().unwrap_or_else(|| "provider-error".to_owned());
            Some((BlockAuthorityV1::ProviderQuota, reason_kind, message.clone()))
        }
        _ => None,
    }
}

/// Builds the `AgentStreamChunkV1` `event`'s `ProviderEvent` carries onto the
/// `agent-stream-events-v1` channel -- see
/// `docs/gate4agent/plans/gate4agent-acp-control-plane-on-the-wire-2026-09-02.md`
/// §5. Two invariants keep the chunk correlatable with the `NodeEvent::Control`
/// event it derives from, so a client joining the two sees one id and one
/// ordering:
///
/// - `source_sequence` on the chunk is the `source_sequence` the provider
///   event itself carries.
/// - `InteractionPrompt::correlation_id` is minted by
///   `correlation::interaction_correlation` with the
///   `(instance_id, generation, provider_sequence)` triple -- never the
///   provider's own `request_id`, whose opacity on the wire is pinned by a
///   dedicated test.
///
/// Returns `None` for every `ControlEventKind` other than `ProviderEvent`
/// (nothing else carries stream content), for a source that is not a live
/// session transport, and for the `ProviderEvent` variants below with no
/// declared chunk kind to carry them, or whose declared chunk kind this build
/// has no source for yet:
///
/// - `ModelCatalog { current, available }` has no `ProviderEvent` source at
///   all -- grok's vendor model switch is not bridged into `ProviderEvent`
///   yet, the same gap the plan names explicitly.
/// - `UserMessage { text, is_delta }` is an echo of the OPERATOR's own
///   prompt, replayed on session resume -- `Text`/`Thinking` are documented
///   as "what the agent is saying", so mapping the operator's words onto
///   `Text` would misrepresent whose content it is. No dedicated
///   user-message kind is declared, so this stays unproduced rather than
///   mislabeled.
///
/// `HostRequestObserved { .. }` is its own arm below: a `Granted`/`Deferred`
/// decision returns `None` (nothing for the operator to react to), a `Denied`
/// decision returns `Some(Blocked { .. })`.
///
/// `ToolCompleted { .. }`/`SessionEnded { .. }` are likewise their own arms
/// below (K2): each returns `None` unless
/// `provider_tool_block_authority`/`provider_session_end_block` classifies the
/// event as an actual block (ACP's `_meta.nonExecutionKind`, or `stopReason`/an
/// RPC error naming a quota).
fn agent_stream_chunk(event: &ControlEvent) -> Option<AgentStreamChunkV1> {
    let ControlEventKind::ProviderEvent {
        sequence: provider_sequence,
        source,
        source_sequence,
        event: provider_event,
    } = &event.event
    else {
        return None;
    };
    if !provider_family_is_live(source.family) {
        return None;
    }
    let kind = match provider_event {
        ProviderEvent::Text { text, is_delta } => AgentStreamChunkKindV1::Text {
            text: text.clone(),
            is_delta: *is_delta,
        },
        ProviderEvent::Thinking { text } => {
            AgentStreamChunkKindV1::Thinking { text: text.clone() }
        }
        ProviderEvent::InteractionRequested {
            interaction_kind,
            tool_name,
            title,
            prompt,
            options,
            ..
        } => AgentStreamChunkKindV1::InteractionPrompt {
            correlation_id: interaction_correlation(
                event.instance_id,
                event.generation,
                *provider_sequence,
            ),
            interaction_kind: *interaction_kind,
            tool_name: tool_name.clone(),
            // `title`/`options` are carried straight through from
            // `ProviderEvent::InteractionRequested`, as the agent itself
            // gave them on `session/request_permission`'s `PermissionTool
            // Call.title`/`options` (see `gate4agent-shell-native`'s
            // `provider_event`, the only ACP-transport producer). A PTY- or
            // hook-sourced interaction carries `title: None` and
            // `options: []` from its own producer because that source has
            // none to offer, never because this mapping dropped one.
            title: title.clone(),
            prompt: prompt.clone(),
            options: options
                .iter()
                .map(|option| AgentStreamInteractionOptionV1 {
                    option_id: option.option_id.clone(),
                    name: option.name.clone(),
                    kind: option.kind.clone(),
                })
                .collect(),
        },
        ProviderEvent::ConfigOptionsUpdated { options } => {
            AgentStreamChunkKindV1::ConfigOptions { options: options.clone() }
        }
        // `available` is the mode catalogue `AcpSession::available_modes()`
        // read back at `session/new` and threaded through by
        // `gate4agent-shell-native`'s `provider_event` (see that crate's
        // `ProviderEvent::ModeChanged` arm) -- an empty list here is the
        // agent's own honest "no modes announced", never "not read": ACP
        // orders `session/new` before any `session/update`, and the
        // catalogue is fixed at handshake, so a `ModeChanged` event cannot
        // exist before the same session object's catalogue is already
        // populated (see `gate4agent_types::ProviderEvent::ModeChanged`'s
        // own doc comment for the ordering argument in full).
        ProviderEvent::ModeChanged { mode_id, available } => AgentStreamChunkKindV1::ModeCatalog {
            current: Some(mode_id.clone()),
            available: available
                .iter()
                .map(|mode| AgentStreamNamedIdV1 {
                    id: mode.id.clone(),
                    name: mode.name.clone(),
                    description: mode.description.clone(),
                })
                .collect(),
        },
        // A denied host request is a block -- see this function's own doc
        // comment for why `HostRequestObserved` is not in the exclusion list
        // below.
        ProviderEvent::HostRequestObserved { method, decision, reason, .. } => {
            let ProviderHostRequestDecision::Denied { by } = decision else {
                return None;
            };
            let (tool_class, authority, reason_text) =
                host_request_denied_block(method, *by, reason.as_deref());
            AgentStreamChunkKindV1::Blocked {
                correlation_id: None,
                tool_class,
                authority,
                reason_kind: None,
                reason: reason_text,
                help: None,
            }
        }
        // Same relationship as `HostRequestObserved` above, driven by ACP's
        // own `_meta.nonExecutionKind` instead of the host's
        // `HostRequestDecision`.
        ProviderEvent::ToolCompleted { id, output, non_execution_kind, .. } => {
            let (authority, reason_kind) =
                provider_tool_block_authority(non_execution_kind.as_deref())?;
            let (reason, help) = split_provider_denial_text(output);
            let (reason, _) =
                truncate_text(&reason, MAX_ACP_BLOCKED_REASON_BYTES);
            let help = help.map(|help| {
                truncate_text(&help, MAX_ACP_BLOCKED_HELP_BYTES).0
            });
            AgentStreamChunkKindV1::Blocked {
                correlation_id: Some(tool_correlation(event, source, id)),
                tool_class: tool_class_from_denial_help(help.as_deref()),
                authority,
                reason_kind: Some(reason_kind.to_owned()),
                reason,
                help,
            }
        }
        // Same relationship, driven by `stopReason: "refusal"` or a
        // `session/prompt` RPC error naming a quota/limit/rate exhaustion
        // instead of a tool-level fact.
        ProviderEvent::SessionEnded { stop_reason, .. } => {
            let (authority, reason_kind, reason) =
                stop_reason.as_ref().and_then(provider_session_end_block)?;
            let (reason, _) =
                truncate_text(&reason, MAX_ACP_BLOCKED_REASON_BYTES);
            AgentStreamChunkKindV1::Blocked {
                correlation_id: None,
                tool_class: "Session".to_owned(),
                authority,
                reason_kind: Some(reason_kind),
                reason,
                help: None,
            }
        }
        ProviderEvent::SessionStarted { .. }
        | ProviderEvent::SessionIdentityObserved { .. }
        | ProviderEvent::TurnStarted { .. }
        | ProviderEvent::WorkingObserved
        | ProviderEvent::ToolStarted { .. }
        | ProviderEvent::TurnCompleted { .. }
        | ProviderEvent::ContextWindowUsage { .. }
        | ProviderEvent::TurnInterrupted
        | ProviderEvent::Error { .. }
        | ProviderEvent::Ready
        | ProviderEvent::InteractionResolved { .. }
        | ProviderEvent::SubagentStarted { .. }
        | ProviderEvent::SubagentStopped { .. }
        | ProviderEvent::RateLimited { .. }
        | ProviderEvent::UnrecognizedNotification { .. }
        | ProviderEvent::UserMessage { .. }
        | ProviderEvent::Plan { .. }
        | ProviderEvent::AvailableCommandsUpdated { .. }
        | ProviderEvent::SessionInfoUpdated { .. }
        | ProviderEvent::UsageUpdated { .. } => return None,
    };
    Some(AgentStreamChunkV1 { source_sequence: *source_sequence, kind })
}

async fn run_native_session_catalog_operation<T, E, F>(
    catalog: Arc<Mutex<NativeSessionCatalogAuthority>>,
    operation: &'static str,
    execute: F,
) -> Result<T, NodeFailure>
where
    T: Send + 'static,
    E: std::fmt::Display + Send + 'static,
    F: FnOnce(&mut NativeSessionCatalogAuthority) -> Result<T, E> + Send + 'static,
{
    let task = tokio::task::spawn_blocking(move || {
        let mut catalog = match catalog.try_lock() {
            Ok(catalog) => catalog,
            Err(std::sync::TryLockError::Poisoned(poisoned)) => poisoned.into_inner(),
            Err(std::sync::TryLockError::WouldBlock) => {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    "native session catalog operation is already running",
                ));
            }
        };
        execute(&mut catalog).map_err(|error| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                &format!("{operation} failed: {error}"),
            )
        })
    });
    timeout(Duration::from_millis(NATIVE_SESSION_CATALOG_TIMEOUT_MS), task)
        .await
        .map_err(|_| {
            failure(
                NodeFailureCode::BackendBusy,
                &format!("{operation} exceeded its bounded deadline"),
            )
        })?
        .map_err(|_| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                &format!("{operation} task failed"),
            )
        })?
}

fn windows_path_text(path: &OpaqueHostPath) -> &str {
    path.as_utf8()
        .expect("Windows node only creates UTF-8 opaque host paths")
}

fn require_windows_path(path: OpaqueHostPath) -> Result<String, NodeFailure> {
    path.as_utf8()
        .map(str::to_owned)
        .ok_or_else(|| failure(
            NodeFailureCode::InvalidRequest,
            "this node requires UTF-8 host paths",
        ))
}

fn protocol_worktree(mut worktree: NativeGitWorktreeSnapshot) -> GitWorktreeSnapshot {
    GitWorktreeSnapshot {
        path: opaque_windows_path(worktree.path),
        head: worktree.head,
        branch: worktree.branch,
        is_bare: worktree.is_bare,
        is_main: worktree.is_main,
        locked: worktree.locked,
        lock_reason: worktree.lock_reason,
        prunable: worktree.prunable,
        prunable_reason: worktree.prunable_reason,
        workspace_id: worktree.workspace_id.take(),
    }
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct WorkspaceConfig {
    workspace_id: WorkspaceId,
    canonical_root: String,
    worktree_service_mode: WorktreeServiceMode,
    managed_worktree_profiles: BTreeMap<WorktreeProfileId, ManagedWorktreeProfile>,
}

impl WorkspaceConfig {
    pub fn new(
        workspace_id: WorkspaceId,
        root: impl AsRef<Path>,
    ) -> Result<Self, NodeServerError> {
        let root = root.as_ref();
        if !root.is_absolute() {
            return Err(NodeServerError::InvalidWorkspaceRoot {
                workspace_id,
                path: root.to_string_lossy().into_owned(),
                message: "path is not absolute".to_owned(),
            });
        }
        let canonical = std::fs::canonicalize(root).map_err(|error| {
            NodeServerError::InvalidWorkspaceRoot {
                workspace_id: workspace_id.clone(),
                path: root.to_string_lossy().into_owned(),
                message: error.to_string(),
            }
        })?;
        if !canonical.is_dir() {
            return Err(NodeServerError::InvalidWorkspaceRoot {
                workspace_id,
                path: root.to_string_lossy().into_owned(),
                message: "path is not a directory".to_owned(),
            });
        }
        let canonical_root = canonical.into_os_string().into_string().map_err(|path| {
            NodeServerError::InvalidWorkspaceRoot {
                workspace_id: workspace_id.clone(),
                path: path.to_string_lossy().into_owned(),
                message: "canonical path is not valid Unicode".to_owned(),
            }
        })?;
        let canonical_root = platform::normalize_canonical_root(canonical_root);
        validate_workspace_root(&workspace_id, &canonical_root)?;
        Ok(Self {
            workspace_id,
            canonical_root,
            worktree_service_mode: WorktreeServiceMode::Manual,
            managed_worktree_profiles: BTreeMap::new(),
        })
    }

    pub fn workspace_id(&self) -> &WorkspaceId {
        &self.workspace_id
    }

    pub fn canonical_root(&self) -> &str {
        &self.canonical_root
    }

    pub fn with_worktree_service_mode(mut self, mode: WorktreeServiceMode) -> Self {
        self.worktree_service_mode = mode;
        self
    }

    pub fn with_managed_worktree_profile(
        mut self,
        profile: ManagedWorktreeProfile,
    ) -> Result<Self, NodeServerError> {
        profile.validate_for_workspace(&self.canonical_root).map_err(|message| {
            NodeServerError::InvalidManagedWorktreeProfile {
                workspace_id: self.workspace_id.clone(),
                profile_id: profile.profile_id().clone(),
                message,
            }
        })?;
        if self.managed_worktree_profiles.contains_key(profile.profile_id()) {
            return Err(NodeServerError::DuplicateManagedWorktreeProfile {
                workspace_id: self.workspace_id,
                profile_id: profile.profile_id().clone(),
            });
        }
        if self.managed_worktree_profiles.len()
            == MAX_MANAGED_WORKTREE_PROFILES_PER_WORKSPACE
        {
            return Err(NodeServerError::ManagedWorktreeProfileCapacity {
                workspace_id: self.workspace_id,
                max: MAX_MANAGED_WORKTREE_PROFILES_PER_WORKSPACE,
            });
        }
        self.managed_worktree_profiles
            .insert(profile.profile_id().clone(), profile);
        Ok(self)
    }
}

#[derive(Clone)]
pub struct NodeServerConfig {
    pub endpoint: String,
    api_listen: Option<std::net::SocketAddr>,
    /// Opt-in node-envelope HTTP+WS browser bridge (separate from `--api-listen`
    /// ops HTTP and from framed C2). Loopback only; default `None` = off.
    bridge_listen: Option<std::net::SocketAddr>,
    /// Optional bridge shared secret (`GATE4AGENT_BRIDGE_TOKEN`). Distinct from
    /// NODE_TOKEN; never logged. `None` = loopback bind is the only gate.
    bridge_token: Option<String>,
    /// Tip 6: optional mesh underlay UDP bind that relays to local `--bridge-listen`.
    /// Requires bridge_listen + bridge_token. HQ never accepts (NodePeer).
    bridge_underlay: Option<browser_bridge::BridgeUnderlayAccept>,
    /// A relay to CALL, rather than wait to be called by. `None` keeps the
    /// node purely a listener, which is what it has always been.
    call_home: Option<std::net::SocketAddr>,
    /// When set, call-home authenticates by signing the relay's challenge with this
    /// identity (enrolled node) and falls back to the token handshake against a relay
    /// that sends no challenge.
    call_home_identity: Option<Arc<hatchery_enroll::NodeIdentity>>,
    pub node_id: NodeId,
    pub workspaces: Vec<WorkspaceConfig>,
    access_token: String,
    pub runtime: NativeRuntimeConfig,
    session_record_retention: SessionRecordRetentionConfig,
    state_path: Option<PathBuf>,
    spawn_profiles: SpawnProfileRegistry,
    session_environment: Option<NodeSessionEnvironmentConfig>,
    history: Option<NativeHistoryConfig>,
    harness_mcp_helper: Option<ReviewedHarnessMcpProgram>,
    /// Station network allowlist catalog (opaque ids). Empty default.
    /// Loaded at startup from `--network-allowlist-catalog` / env
    /// `GATE4AGENT_NODE_NETWORK_ALLOWLIST_CATALOG` file. Never secrets.
    network_allowlist_catalog: crate::network_allowlist_catalog::NetworkAllowlistCatalog,
    #[cfg(feature = "fixture")]
    fixture_raw_pty_runtime: bool,
}

#[derive(Clone)]
struct NodeSessionEnvironmentConfig {
    root: PathBuf,
    resolver: Arc<dyn NodeSecretResolver>,
}

impl NodeServerConfig {
    pub fn new(
        endpoint: impl Into<String>,
        access_token: impl Into<String>,
        node_id: NodeId,
        workspaces: impl IntoIterator<Item = WorkspaceConfig>,
    ) -> Result<Self, NodeServerError> {
        let endpoint = endpoint.into();
        let access_token = access_token.into();
        if !platform::validate_endpoint(&endpoint) {
            return Err(NodeServerError::InvalidEndpoint);
        }
        if access_token.is_empty() || access_token.len() > 4_096 {
            return Err(NodeServerError::InvalidAccessToken);
        }
        let workspaces = workspaces.into_iter().collect::<Vec<_>>();
        if workspaces.is_empty() {
            return Err(NodeServerError::NoWorkspaces);
        }
        let mut workspace_ids = BTreeMap::new();
        let mut workspace_roots = BTreeMap::new();
        for workspace in &workspaces {
            if workspace.worktree_service_mode == WorktreeServiceMode::Managed
                && workspace.managed_worktree_profiles.is_empty()
            {
                return Err(NodeServerError::ManagedWorktreeProfileRequired(
                    workspace.workspace_id.clone(),
                ));
            }
            if workspace.worktree_service_mode != WorktreeServiceMode::Managed
                && !workspace.managed_worktree_profiles.is_empty()
            {
                return Err(NodeServerError::ManagedWorktreeProfileModeMismatch(
                    workspace.workspace_id.clone(),
                ));
            }
            if workspace_ids
                .insert(workspace.workspace_id.clone(), ())
                .is_some()
            {
                return Err(NodeServerError::DuplicateWorkspaceId(
                    workspace.workspace_id.clone(),
                ));
            }
            let root_key = platform::root_identity(&workspace.canonical_root);
            if let Some(existing) = workspace_roots.insert(
                root_key,
                workspace.workspace_id.clone(),
            ) {
                return Err(NodeServerError::DuplicateWorkspaceRoot {
                    first: existing,
                    second: workspace.workspace_id.clone(),
                    root: workspace.canonical_root.clone(),
                });
            }
        }
        Ok(Self {
            endpoint,
            api_listen: None,
            bridge_listen: None,
            bridge_token: None,
            bridge_underlay: None,
            call_home: None,
            call_home_identity: None,
            node_id,
            workspaces,
            access_token,
            // PTY output is polled by the runtime's effect worker; the upstream
            // default (20ms) added ~10-20ms to every keystroke echo.
            runtime: NativeRuntimeConfig {
                worker_poll_interval_ms: 4,
                ..NativeRuntimeConfig::default()
            },
            session_record_retention: SessionRecordRetentionConfig::default(),
            state_path: None,
            spawn_profiles: SpawnProfileRegistry::default(),
            session_environment: None,
            history: None,
            harness_mcp_helper: None,
            network_allowlist_catalog: crate::network_allowlist_catalog::NetworkAllowlistCatalog::new(),
            #[cfg(feature = "fixture")]
            fixture_raw_pty_runtime: false,
        })
    }

    pub fn with_api_listen(
        mut self,
        api_listen: std::net::SocketAddr,
    ) -> Result<Self, NodeServerError> {
        if !api_listen.ip().is_loopback() {
            return Err(NodeServerError::InvalidApiListen(api_listen));
        }
        self.api_listen = Some(api_listen);
        Ok(self)
    }

    /// Opt-in node-envelope HTTP+WS bridge listener. Loopback only (same spirit
    /// as `with_api_listen`). Does not enable by default — libraries and the
    /// binary leave this `None` until `--bridge-listen` / `with_bridge_listen`.
    pub fn with_bridge_listen(
        mut self,
        bridge_listen: std::net::SocketAddr,
    ) -> Result<Self, NodeServerError> {
        if !bridge_listen.ip().is_loopback() {
            return Err(NodeServerError::InvalidBridgeListen(bridge_listen));
        }
        self.bridge_listen = Some(bridge_listen);
        Ok(self)
    }

    /// Optional bridge shared secret, distinct from the C2/node access token.
    /// Never log the value. Empty / oversize refused.
    pub fn with_bridge_token(
        mut self,
        bridge_token: impl Into<String>,
    ) -> Result<Self, NodeServerError> {
        let bridge_token = bridge_token.into();
        if bridge_token.is_empty() || bridge_token.len() > 4_096 {
            return Err(NodeServerError::InvalidBridgeToken);
        }
        self.bridge_token = Some(bridge_token);
        Ok(self)
    }

    /// Tip 6: point bridge reachability over mesh underlay (UDP+AEAD relay to
    /// local loopback `--bridge-listen`). Requires bridge listen + bridge token
    /// already configured. Transport key is 32 raw bytes (never logged).
    /// Underlay auth token is distinct from BRIDGE_TOKEN (crypto ≠ auth).
    pub fn with_bridge_underlay(
        mut self,
        bind: std::net::SocketAddr,
        transport_key: [u8; 32],
        underlay_token: impl Into<String>,
    ) -> Result<Self, NodeServerError> {
        if self.bridge_listen.is_none() {
            return Err(NodeServerError::BridgeUnderlayRequiresBridgeListen);
        }
        if self.bridge_token.is_none() {
            return Err(NodeServerError::BridgeUnderlayRequiresBridgeToken);
        }
        let underlay_token = underlay_token.into();
        if underlay_token.is_empty() || underlay_token.len() > 4_096 {
            return Err(NodeServerError::InvalidBridgeUnderlayToken);
        }
        // Port 0 is allowed (ephemeral). Role lock (no HQ accept) lives in underlay.
        self.bridge_underlay = Some(browser_bridge::BridgeUnderlayAccept {
            bind,
            transport_key,
            underlay_token,
        });
        Ok(self)
    }

    /// Also dial `relay` and serve this wire over the connection, in
    /// addition to accepting on the local endpoint.
    ///
    /// Who opens the socket and who is the protocol's server are separate
    /// questions, and this is the node's half of separating them. The node
    /// stays the server either way -- it answers `NodeRequest`s and emits
    /// `NodeEvent`s exactly as it does for a relay that dialled it. All
    /// that changes is that a node with no address anyone can reach makes
    /// the connection itself, and names itself once it arrives (see
    /// `gate4agent_node_wire::write_call_home_announce`).
    ///
    /// Loopback only, and that is not an oversight to be flagged and
    /// worked around. This wire carries terminal contents, keystrokes and
    /// file bytes as plaintext JSON; its mutual challenge-response
    /// authenticates both ends and encrypts nothing. Every listener in
    /// this stack is loopback-guarded for that reason, and a dialler must
    /// hold the same line -- a node calling a public relay would put the
    /// whole control plane on the wire in the clear. Reaching a relay on
    /// another host is a transport question, and it stays unanswered here
    /// on purpose: this change is about direction, not distance.
    pub fn with_call_home(
        mut self,
        relay: std::net::SocketAddr,
    ) -> Result<Self, NodeServerError> {
        // Loopback, or the concrete C2 WireGuard tunnel address. Unspecified
        // and port 0 refused — plaintext wire must not dial every interface.
        if relay.port() == 0 || relay.ip().is_unspecified() {
            return Err(NodeServerError::InvalidCallHome(relay));
        }
        self.call_home = Some(relay);
        Ok(self)
    }

    /// Authenticate call-home with a node-held identity instead of a standing token.
    pub fn with_call_home_identity(mut self, identity: Arc<hatchery_enroll::NodeIdentity>) -> Self {
        self.call_home_identity = Some(identity);
        self
    }

    pub fn with_state_path(
        mut self,
        state_path: impl Into<PathBuf>,
    ) -> Result<Self, NodeServerError> {
        let state_path = state_path.into();
        if !state_path.is_absolute() || state_path.file_name().is_none() {
            return Err(NodeServerError::InvalidStatePath(
                state_path.to_string_lossy().into_owned(),
            ));
        }
        self.state_path = Some(state_path);
        Ok(self)
    }

    pub fn with_spawn_profiles(mut self, spawn_profiles: SpawnProfileRegistry) -> Self {
        self.spawn_profiles = spawn_profiles;
        self
    }

    /// Sets the age/keep-N policy the drive loop's retention sweep uses to
    /// retire dead `ManagedSessionState::Unavailable` records. Both fields
    /// default to `0` (disabled) via `SessionRecordRetentionConfig::default`
    /// when this is never called -- a node never deletes a durable record
    /// until an operator opts in with a real value.
    pub fn with_session_record_retention(
        mut self,
        retention: SessionRecordRetentionConfig,
    ) -> Self {
        self.session_record_retention = retention;
        self
    }

    pub fn with_session_environment_materialization(
        mut self,
        root: impl Into<PathBuf>,
        resolver: Arc<dyn NodeSecretResolver>,
    ) -> Result<Self, NodeServerError> {
        let root = root.into();
        if !root.is_absolute() {
            return Err(NodeServerError::InvalidSessionEnvironmentRoot);
        }
        self.session_environment = Some(NodeSessionEnvironmentConfig { root, resolver });
        Ok(self)
    }

    /// Enables bounded provider-history discovery and loading from explicit
    /// host-owned roots. Ambient vendor homes are never inferred here.
    pub fn with_history(mut self, history: NativeHistoryConfig) -> Self {
        self.history = Some(history);
        self
    }

    /// Enables the H3B read proxy with one exact operator-reviewed helper file.
    /// Linux/macOS use owner-only UDS; Windows uses owner-only named pipes.
    /// Both platforms review the helper the same way (absolute regular file +
    /// identity hash) — the old `cfg(not(windows))` hard-refuse was a leftover
    /// gate after Unix listener/peer-cred support landed.
    pub fn with_harness_mcp_helper(
        mut self,
        helper_program: impl Into<PathBuf>,
    ) -> Result<Self, NodeServerError> {
        self.harness_mcp_helper = Some(
            ReviewedHarnessMcpProgram::review(helper_program.into())
                .map_err(|_| NodeServerError::InvalidHarnessMcpHelper)?,
        );
        Ok(self)
    }

    /// Install an in-memory station network allowlist catalog (opaque ids +
    /// optional node-local permits / provider-native mapping). Empty remains
    /// the default — unknown spawn ids refuse at resolve. Never cookies /
    /// OAuth / proxy credentials. C2 / inventory still list ids only.
    pub fn with_network_allowlist_catalog(
        mut self,
        catalog: crate::network_allowlist_catalog::NetworkAllowlistCatalog,
    ) -> Result<Self, NodeServerError> {
        if catalog.len() > crate::network_allowlist_catalog::MAX_NETWORK_ALLOWLIST_CATALOG_ENTRIES {
            return Err(NodeServerError::NetworkAllowlistCatalogCapacity {
                max: crate::network_allowlist_catalog::MAX_NETWORK_ALLOWLIST_CATALOG_ENTRIES,
            });
        }
        self.network_allowlist_catalog = catalog;
        Ok(self)
    }

    /// Load station network allowlist catalog from an absolute regular file
    /// (v1 id-list or v2 JSON schema). Unset path is not used here — callers
    /// that want env fallback use `resolve_network_allowlist_catalog`.
    pub fn with_network_allowlist_catalog_file(
        self,
        path: impl AsRef<std::path::Path>,
    ) -> Result<Self, NodeServerError> {
        let catalog = crate::network_allowlist_catalog::load_network_allowlist_catalog_file(path)
            .map_err(NodeServerError::from)?;
        self.with_network_allowlist_catalog(catalog)
    }
}

pub fn default_state_path(node_id: &NodeId) -> Result<PathBuf, NodeServerError> {
    platform::default_state_path(node_id.as_str())
        .ok_or(NodeServerError::LocalStateDirectoryUnavailable)
}

pub fn default_node_endpoint() -> Result<PathBuf, NodeServerError> {
    platform::default_node_endpoint().ok_or(NodeServerError::LocalRuntimeDirectoryUnavailable)
}

fn delivery_store_root_for_state_path(state_path: &Path) -> Option<PathBuf> {
    let parent = state_path.parent()?;
    let mut name = state_path.file_name()?.to_os_string();
    name.push(".delivery-store");
    Some(parent.join(name))
}

fn context_pack_store_root_for_state_path(state_path: &Path) -> Option<PathBuf> {
    let parent = state_path.parent()?;
    let mut name = state_path.file_name()?.to_os_string();
    name.push(".context-pack-store");
    Some(parent.join(name))
}

pub struct NodeServer {
    config: NodeServerConfig,
    runtime: NativeRuntime,
    shared: Arc<NodeShared>,
    events: EventSubscription,
    state_path_lock: Option<session_registry::StatePathLock>,
}

#[cfg(feature = "fixture")]
#[derive(Clone, Default)]
pub struct SpawnManagedWorktreeV2FailureProbe {
    latest_code: Arc<Mutex<Option<NodeFailureCode>>>,
}

#[cfg(feature = "fixture")]
impl SpawnManagedWorktreeV2FailureProbe {
    pub fn latest_code(&self) -> Option<NodeFailureCode> {
        *self
            .latest_code
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
    }

    fn record(&self, code: Option<NodeFailureCode>) {
        *self
            .latest_code
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) = code;
    }
}

#[cfg(all(feature = "fixture", windows))]
struct IsolatedCodexHomeFixtureEnvironment;

#[cfg(all(feature = "fixture", windows))]
impl gate4agent_runtime_native::NativeChildEnvironmentResolver
    for IsolatedCodexHomeFixtureEnvironment
{
    fn resolve_child_environment(
        &self,
    ) -> Result<
        Vec<gate4agent_catalog::EnvMutation>,
        gate4agent_runtime_native::NativeChildEnvironmentResolveError,
    > {
        Ok(vec![gate4agent_catalog::EnvMutation {
            key: OsString::from("USERPROFILE"),
            value: None,
        }])
    }
}

impl NodeServer {
    /// The letter-wake handle for the door, when m4a accounts are on. `token` is what callers
    /// must present.
    /// Turn on the m4a signer proxy for PTY spawns (replaces `M4A_SESSION_CAP`).
    #[cfg(unix)]
    pub fn set_signer_proxy(&self, proxy: Arc<crate::keystore_proxy::SignerProxy>) -> bool {
        self.shared.signer_proxy.set(proxy).is_ok()
    }

    pub fn wake_handle(&self, token: String, policy: Arc<crate::wake_pipeline::WakePolicy>) -> Option<node_wake::NodeWake> {
        self.shared.m4a_accounts.as_ref()?;
        Some(node_wake::NodeWake::new(Arc::clone(&self.shared), token, policy))
    }

    pub fn new(config: NodeServerConfig) -> Result<Self, NodeServerError> {
        let catalog = active_registry()?;
        Self::new_with_registry(config, catalog)
    }

    #[cfg(feature = "fixture")]
    pub fn new_fixture(config: NodeServerConfig) -> Result<Self, NodeServerError> {
        let mut spec = gate4agent_testkit::interactive_agent_spec();
        spec.id = AgentId::new("claude").map_err(|error| NodeServerError::Registry(error.to_string()))?;
        spec.display_name = "Controlled Claude PTY fixture".to_owned();
        Self::new_fixture_with_spec(config, spec)
    }

    #[cfg(feature = "fixture")]
    pub fn new_clean_exit_fixture(
        config: NodeServerConfig,
        fixture_root: PathBuf,
        started_marker: PathBuf,
        release_signal: PathBuf,
    ) -> Result<Self, NodeServerError> {
        let mut spec = gate4agent_testkit::controlled_clean_exit_agent_spec(
            &fixture_root,
            &started_marker,
            &release_signal,
        )
        .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        spec.id = AgentId::new("claude")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        spec.display_name = "Controlled Claude clean-exit fixture".to_owned();
        Self::new_fixture_with_spec(config, spec)
    }

    /// A `claude` source whose session establishes a verified provider
    /// identity via an early `SessionStart` Hook post (so it is eligible for
    /// auto-export-at-exit and its native history is independently
    /// loadable), waits for `release_signal`, then exits cleanly — paired
    /// on the same Node with a plain `codex` target that never validates
    /// anything about what it receives. Built for A2 durable ContextPack
    /// E2E coverage: the test itself inspects materialized files and
    /// managed-session-record fields directly, rather than having the
    /// target script self-validate.
    #[cfg(all(feature = "fixture", windows))]
    pub fn new_durable_context_pack_clean_exit_fixture(
        config: NodeServerConfig,
        fixture_root: PathBuf,
        started_marker: PathBuf,
        release_signal: PathBuf,
        session_id: &str,
    ) -> Result<Self, NodeServerError> {
        let mut source_spec = gate4agent_testkit::identified_clean_exit_agent_spec(
            &fixture_root,
            &started_marker,
            &release_signal,
            session_id,
        )
        .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let source_id = AgentId::new("claude")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let source_provider = builtin_registry().get(&source_id).ok_or_else(|| {
            NodeServerError::Registry(
                "durable context pack clean-exit fixture source adapter is unavailable"
                    .to_owned(),
            )
        })?;
        source_spec.capabilities.adapters.history =
            source_provider.capabilities.adapters.history.clone();
        source_spec.id = source_id;
        source_spec.display_name =
            "Controlled Claude durable context-pack clean-exit fixture".to_owned();
        // Both specs launch via `powershell.exe`; the registry's ambiguity
        // check keys on `detection.command` (+ aliases), not `launch.program`
        // -- give each a distinct detection identity, same precedent as
        // `context_pack_fixture_catalog`'s per-provider
        // `gate4agent-{provider}-context-fixture.cmd` commands.
        source_spec.detection.command =
            "gate4agent-claude-durable-context-pack-fixture.cmd".to_owned();
        source_spec.detection.aliases.clear();

        let mut target_spec = gate4agent_testkit::interactive_agent_spec();
        target_spec.id = AgentId::new("codex")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        target_spec.display_name =
            "Controlled Codex durable context-pack target fixture".to_owned();
        target_spec.detection.command =
            "gate4agent-codex-durable-context-pack-fixture.cmd".to_owned();
        target_spec.detection.aliases.clear();

        let catalog = AgentRegistry::new([source_spec, target_spec])
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let mut server = Self::new_with_registry(config, catalog)?;
        Arc::get_mut(&mut server.shared)
            .expect("fixture Node shared state must remain uniquely owned before run")
            .fixture_semantic_hook_policy = true;
        Ok(server)
    }

    #[cfg(feature = "fixture")]
    pub fn new_monitoring_hook_fixture(
        config: NodeServerConfig,
    ) -> Result<Self, NodeServerError> {
        let mut spec = gate4agent_testkit::monitoring_hook_agent_spec();
        spec.id = AgentId::new("claude")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let mut server = Self::new_fixture_with_spec(config, spec)?;
        Arc::get_mut(&mut server.shared)
            .expect("fixture Node shared state must remain uniquely owned before run")
            .fixture_semantic_hook_policy = true;
        Ok(server)
    }

    #[cfg(all(feature = "fixture", windows))]
    pub fn new_provider_bundle_argv_fixture(
        config: NodeServerConfig,
        agent_id: AgentId,
        proof_path: PathBuf,
    ) -> Result<Self, NodeServerError> {
        let spec = Self::provider_bundle_argv_fixture_spec(agent_id, proof_path, None)?;
        Self::new_fixture_with_spec(config, spec)
    }

    #[cfg(all(feature = "fixture", windows))]
    pub fn new_provider_bundle_argv_hold_fixture(
        config: NodeServerConfig,
        agent_id: AgentId,
        proof_path: PathBuf,
        release_signal: PathBuf,
    ) -> Result<Self, NodeServerError> {
        let spec = Self::provider_bundle_argv_fixture_spec(
            agent_id,
            proof_path,
            Some(release_signal),
        )?;
        Self::new_fixture_with_spec(config, spec)
    }

    #[cfg(all(feature = "fixture", windows))]
    fn provider_bundle_argv_fixture_spec(
        agent_id: AgentId,
        proof_path: PathBuf,
        release_signal: Option<PathBuf>,
    ) -> Result<gate4agent_types::AgentSpec, NodeServerError> {
        if !matches!(agent_id.as_str(), "claude" | "codex" | "kimi") {
            return Err(NodeServerError::Registry(
                "provider bundle argv fixture requires Claude, Codex, or Kimi".to_owned(),
            ));
        }
        let mut spec = gate4agent_testkit::interactive_agent_spec();
        spec.id = agent_id.clone();
        spec.display_name = format!("Controlled {agent_id} bundle argv fixture");
        let provider = builtin_registry()
            .get(&agent_id)
            .ok_or_else(|| {
                NodeServerError::Registry(
                    "provider bundle argv fixture adapter is unavailable".to_owned(),
                )
            })?;
        spec.capabilities.adapters.history = provider.capabilities.adapters.history.clone();
        if !proof_path.is_absolute()
            || !proof_path
                .parent()
                .is_some_and(|parent| parent.is_dir())
        {
            return Err(NodeServerError::Registry(
                "provider bundle argv proof path requires an existing absolute parent"
                    .to_owned(),
            ));
        }
        if let Some(release_signal) = release_signal.as_ref() {
            if !release_signal.is_absolute()
                || !release_signal
                    .parent()
                    .is_some_and(|parent| parent.is_dir())
            {
                return Err(NodeServerError::Registry(
                    "provider bundle argv release path requires an existing absolute parent"
                        .to_owned(),
                ));
            }
            if release_signal.exists() {
                return Err(NodeServerError::Registry(
                    "provider bundle argv release path must not exist".to_owned(),
                ));
            }
            let proof_parent = std::fs::canonicalize(
                proof_path
                    .parent()
                    .expect("validated provider bundle proof parent"),
            )
            .map_err(|_| {
                NodeServerError::Registry(
                    "provider bundle argv proof parent is unavailable".to_owned(),
                )
            })?;
            let release_parent = std::fs::canonicalize(
                release_signal
                    .parent()
                    .expect("validated provider bundle release parent"),
            )
            .map_err(|_| {
                NodeServerError::Registry(
                    "provider bundle argv release parent is unavailable".to_owned(),
                )
            })?;
            if proof_parent != release_parent {
                return Err(NodeServerError::Registry(
                    "provider bundle argv release path must share the proof parent".to_owned(),
                ));
            }
        }
        let proof_path = proof_path.into_os_string().into_string().map_err(|_| {
            NodeServerError::Registry(
                "provider bundle argv proof path is not valid Unicode".to_owned(),
            )
        })?;
        let release_signal = release_signal.map(|release_signal| {
            release_signal.into_os_string().into_string().map_err(|_| {
                NodeServerError::Registry(
                    "provider bundle argv release path is not valid Unicode".to_owned(),
                )
            })
        }).transpose()?;
        let script = spec
            .launch
            .fixed_args
            .pop()
            .ok_or_else(|| NodeServerError::Registry("PTY fixture script is unavailable".to_owned()))?;
        let bundle_validation = if agent_id.as_str() == "codex" {
            "if ($bundleArgs.Count -ne 0) { exit 91 }; $codexHome = [Environment]::GetEnvironmentVariable('CODEX_HOME', 'Process'); $cwd = (Get-Location).ProviderPath; if ([string]::IsNullOrEmpty($codexHome)) { [IO.File]::WriteAllLines($proofPath, [string[]]@('unbundled', $cwd)); [Console]::Out.WriteLine('F63_CODEX_UNBUNDLED_VALIDATED') } elseif (-not [IO.Path]::IsPathRooted($codexHome) -or -not (Test-Path -LiteralPath $codexHome -PathType Container)) { exit 92 } else { $skillPath = Join-Path $codexHome 'skills/review-code/SKILL.md'; if (-not (Test-Path -LiteralPath $skillPath -PathType Leaf)) { exit 93 }; $files = @(Get-ChildItem -LiteralPath $codexHome -Recurse -Force -File); if ($files.Count -ne 1 -or [IO.Path]::GetFullPath($files[0].FullName) -ine [IO.Path]::GetFullPath($skillPath)) { exit 94 }; $sha = [Security.Cryptography.SHA256]::Create(); try { $skillHash = ([BitConverter]::ToString($sha.ComputeHash([IO.File]::ReadAllBytes($skillPath)))).Replace('-', '').ToLowerInvariant() } finally { $sha.Dispose() }; if ($skillHash -cne 'd78fe03be106b673fcf5415c8359e99f0298b5071cd11822c58ebcb27e52a68d') { exit 95 }; [IO.File]::WriteAllLines($proofPath, [string[]]@('bundled', $codexHome, $cwd, $skillHash)); [Console]::Out.WriteLine('F63_CODEX_BUNDLE_HOME_VALIDATED') }"
        } else if agent_id.as_str() == "claude" {
            "if ($bundleArgs.Count -eq 0) { [IO.File]::WriteAllLines($proofPath, [string[]]@()); [Console]::Out.WriteLine('F62_NO_BUNDLE_ARGV') } elseif ($bundleArgs.Count -eq 2 -and $bundleArgs[0] -ceq '--plugin-dir' -and [IO.Path]::IsPathRooted($bundleArgs[1]) -and (Test-Path -LiteralPath $bundleArgs[1] -PathType Container)) { if (-not (Test-Path -LiteralPath (Join-Path $bundleArgs[1] '.claude-plugin/plugin.json') -PathType Leaf)) { exit 92 }; [IO.File]::WriteAllLines($proofPath, [string[]]@($bundleArgs[0], $bundleArgs[1])); [Console]::Out.WriteLine('F62_BUNDLE_ARGV_VALIDATED') } else { exit 91 }"
        } else {
            "if ($bundleArgs.Count -eq 0) { [IO.File]::WriteAllLines($proofPath, [string[]]@()); [Console]::Out.WriteLine('F62_NO_BUNDLE_ARGV') } elseif ($bundleArgs.Count -eq 2 -and $bundleArgs[0] -ceq '--skills-dir' -and [IO.Path]::IsPathRooted($bundleArgs[1]) -and (Test-Path -LiteralPath $bundleArgs[1] -PathType Container)) { if ((Split-Path -Leaf $bundleArgs[1]) -ne 'skills') { exit 93 }; [IO.File]::WriteAllLines($proofPath, [string[]]@($bundleArgs[0], $bundleArgs[1])); [Console]::Out.WriteLine('F62_BUNDLE_ARGV_VALIDATED') } else { exit 91 }"
        };
        if let Some(release_signal) = release_signal {
            spec.launch.fixed_args.push(format!(
                "& {{ param([string]$proofPath, [string]$releaseSignal, [Parameter(ValueFromRemainingArguments=$true)][string[]]$bundleArgs) {bundle_validation}; $deadline = [DateTime]::UtcNow.AddSeconds(45); while (-not (Test-Path -LiteralPath $releaseSignal -PathType Leaf)) {{ if ([DateTime]::UtcNow -ge $deadline) {{ exit 96 }}; Start-Sleep -Milliseconds 20 }}; {script} }}",
            ));
            spec.launch.fixed_args.push(proof_path);
            spec.launch.fixed_args.push(release_signal);
        } else {
            spec.launch.fixed_args.push(format!(
                "& {{ param([string]$proofPath, [Parameter(ValueFromRemainingArguments=$true)][string[]]$bundleArgs) {bundle_validation}; {script} }}",
            ));
            spec.launch.fixed_args.push(proof_path);
        }
        Ok(spec)
    }

    #[cfg(all(feature = "fixture", windows))]
    pub fn new_context_pack_fixture(
        config: NodeServerConfig,
        proof_path: PathBuf,
    ) -> Result<Self, NodeServerError> {
        let catalog = Self::context_pack_fixture_catalog(proof_path, None, false)?;
        Self::new_with_registry(config, catalog)
    }

    #[cfg(all(feature = "fixture", windows))]
    pub fn new_monitoring_context_pack_fixture(
        config: NodeServerConfig,
        proof_path: PathBuf,
    ) -> Result<Self, NodeServerError> {
        let catalog = Self::context_pack_fixture_catalog(proof_path, None, true)?;
        let mut server = Self::new_with_registry(config, catalog)?;
        Arc::get_mut(&mut server.shared)
            .expect("fixture Node shared state must remain uniquely owned before run")
            .fixture_semantic_hook_policy = true;
        Ok(server)
    }

    #[cfg(all(feature = "fixture", windows))]
    pub fn install_isolated_codex_home_environment_fixture(
        &mut self,
        profile_id: SpawnEnvironmentProfileId,
        profile_revision: crate::protocol::SpawnEnvironmentProfileRevision,
    ) -> Result<(), NodeServerError> {
        let provider = AgentId::new("codex")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let native_profile = gate4agent_runtime_native::NativeLaunchProfile::new(
            gate4agent_runtime_native::NativeLaunchProfileId::new(format!(
                "{}-pty",
                profile_id.as_str(),
            ))
            .map_err(|error| NodeServerError::Registry(error.to_string()))?,
            provider.clone(),
            TransportKind::Pty,
            vec![OsString::from("USERPROFILE")],
            Arc::new(IsolatedCodexHomeFixtureEnvironment),
        )
        .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let materialization = NodeSessionMaterializationProfile::new(
            Vec::new(),
            vec![crate::session_environment::NodeSessionPathBinding::new(
                "CODEX_HOME",
                crate::session_environment::NodeSessionPathClass::ProviderHome,
            )
            .map_err(|error| NodeServerError::Registry(error.to_string()))?],
            Vec::new(),
        )
        .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        self.install_environment_profile(
            NodeEnvironmentProfile::new_with_materialization(
                profile_id,
                profile_revision,
                provider,
                [native_profile],
                Some(materialization),
            )
            .map_err(|error| NodeServerError::Registry(error.to_string()))?,
        )
    }

    #[cfg(all(feature = "fixture", windows))]
    pub fn new_context_only_proof_fixture(
        config: NodeServerConfig,
        target_provider: AgentId,
        proof_path: PathBuf,
    ) -> Result<Self, NodeServerError> {
        if target_provider.as_str() != "kimi" {
            return Err(NodeServerError::Registry(
                "context-only proof fixture requires Kimi".to_owned(),
            ));
        }
        let catalog = Self::context_pack_fixture_catalog(
            proof_path,
            Some(&target_provider),
            false,
        )?;
        Self::new_with_registry(config, catalog)
    }

    #[cfg(all(feature = "fixture", windows))]
    fn context_pack_fixture_catalog(
        proof_path: PathBuf,
        context_only_target: Option<&AgentId>,
        monitoring_claude_source: bool,
    ) -> Result<AgentRegistry, NodeServerError> {
        if !proof_path.is_absolute()
            || !proof_path
                .parent()
                .is_some_and(|parent| parent.is_dir())
        {
            return Err(NodeServerError::Registry(
                "context pack proof path requires an existing absolute parent".to_owned(),
            ));
        }
        let proof_path = proof_path.into_os_string().into_string().map_err(|_| {
            NodeServerError::Registry(
                "context pack proof path is not valid Unicode".to_owned(),
            )
        })?;
        let providers = ["claude", "codex", "grok", "kimi"];
        let builtins = builtin_registry();
        let mut specs = Vec::with_capacity(providers.len());
        for provider_id in providers {
            let agent_id = AgentId::new(provider_id)
                .map_err(|error| NodeServerError::Registry(error.to_string()))?;
            let provider = builtins.get(&agent_id).ok_or_else(|| {
                NodeServerError::Registry(
                    "context pack fixture provider adapter is unavailable".to_owned(),
                )
            })?;
            let monitored_provider =
                monitoring_claude_source && matches!(provider_id, "claude" | "codex");
            let mut spec = if monitored_provider {
                gate4agent_testkit::monitoring_hook_agent_spec()
            } else {
                gate4agent_testkit::interactive_agent_spec()
            };
            spec.id = agent_id.clone();
            spec.display_name = format!("Controlled {agent_id} context pack fixture");
            spec.detection.command = format!("gate4agent-{provider_id}-context-fixture.cmd");
            spec.detection.aliases.clear();
            spec.capabilities.adapters.history = provider.capabilities.adapters.history.clone();
            if provider_id == "codex" {
                let script = spec.launch.fixed_args.pop().ok_or_else(|| {
                    NodeServerError::Registry("PTY fixture script is unavailable".to_owned())
                })?;
                let validation = r#"
$bundleArgs = @($bundleArgs)
if ($bundleArgs.Count -ne 0) { exit 91 }
$codexHome = [Environment]::GetEnvironmentVariable('CODEX_HOME', 'Process')
$contextRoot = [Environment]::GetEnvironmentVariable('GATE4AGENT_CONTEXT_ROOT', 'Process')
$cwd = (Get-Location).ProviderPath
if ([string]::IsNullOrEmpty($codexHome) -or -not [IO.Path]::IsPathRooted($codexHome) -or -not (Test-Path -LiteralPath $codexHome -PathType Container)) { exit 92 }
$skillPath = Join-Path $codexHome 'skills/review-code/SKILL.md'
if (-not (Test-Path -LiteralPath $skillPath -PathType Leaf)) { exit 93 }
$homeFiles = @(Get-ChildItem -LiteralPath $codexHome -Recurse -Force -File)
if ($homeFiles.Count -ne 1 -or [IO.Path]::GetFullPath($homeFiles[0].FullName) -ine [IO.Path]::GetFullPath($skillPath)) { exit 94 }
$sha = [Security.Cryptography.SHA256]::Create()
try { $skillHash = ([BitConverter]::ToString($sha.ComputeHash([IO.File]::ReadAllBytes($skillPath)))).Replace('-', '').ToLowerInvariant() } finally { $sha.Dispose() }
if ($skillHash -cne 'd78fe03be106b673fcf5415c8359e99f0298b5071cd11822c58ebcb27e52a68d') { exit 95 }
if ([string]::IsNullOrEmpty($contextRoot) -or -not [IO.Path]::IsPathRooted($contextRoot) -or -not (Test-Path -LiteralPath $contextRoot -PathType Container)) { exit 96 }
$contextPath = Join-Path $contextRoot 'context-pack.json'
if (-not (Test-Path -LiteralPath $contextPath -PathType Leaf)) { exit 97 }
$contextFiles = @(Get-ChildItem -LiteralPath $contextRoot -Recurse -Force -File)
if ($contextFiles.Count -ne 1 -or [IO.Path]::GetFullPath($contextFiles[0].FullName) -ine [IO.Path]::GetFullPath($contextPath)) { exit 98 }
$contextFull = [IO.Path]::GetFullPath($contextRoot).TrimEnd([IO.Path]::DirectorySeparatorChar, [IO.Path]::AltDirectorySeparatorChar)
$codexFull = [IO.Path]::GetFullPath($codexHome).TrimEnd([IO.Path]::DirectorySeparatorChar, [IO.Path]::AltDirectorySeparatorChar)
$cwdFull = [IO.Path]::GetFullPath($cwd).TrimEnd([IO.Path]::DirectorySeparatorChar, [IO.Path]::AltDirectorySeparatorChar)
$separator = [IO.Path]::DirectorySeparatorChar
if ($contextFull.Equals($codexFull, [StringComparison]::OrdinalIgnoreCase) -or $contextFull.StartsWith($codexFull + $separator, [StringComparison]::OrdinalIgnoreCase)) { exit 99 }
if ($contextFull.Equals($cwdFull, [StringComparison]::OrdinalIgnoreCase) -or $contextFull.StartsWith($cwdFull + $separator, [StringComparison]::OrdinalIgnoreCase)) { exit 100 }
$rawContext = [IO.File]::ReadAllText($contextPath)
if ($rawContext.Contains('g4a-private-provider-session-canary') -or $rawContext.Contains('private-provider-login-identity')) { exit 101 }
try { $document = $rawContext | ConvertFrom-Json -ErrorAction Stop } catch { exit 102 }
$allowedTopLevel = @('schema', 'source_provider', 'source_message_count', 'retained_messages', 'repository', 'truncated')
$requiredTopLevel = @('schema', 'source_provider', 'source_message_count', 'retained_messages', 'truncated')
foreach ($property in @($document.PSObject.Properties.Name)) {
    if ($allowedTopLevel -cnotcontains [string]$property) { exit 103 }
}
foreach ($property in $requiredTopLevel) {
    if ($null -eq $document.PSObject.Properties[$property]) { exit 104 }
}
if ($document.schema -cne 'g4a-context-pack-v1' -or $null -ne $document.PSObject.Properties['cwd']) { exit 105 }
if (@('claude', 'codex', 'grok', 'kimi') -cnotcontains [string]$document.source_provider) { exit 106 }
$messages = @($document.retained_messages)
if ($messages.Count -eq 0) { exit 107 }
foreach ($message in $messages) {
    $messageProperties = @($message.PSObject.Properties.Name)
    foreach ($property in $messageProperties) {
        if (@('role', 'text') -cnotcontains [string]$property) { exit 108 }
    }
    if ($messageProperties.Count -ne 2 -or @('user', 'assistant') -cnotcontains [string]$message.role -or [string]::IsNullOrEmpty([string]$message.text)) { exit 109 }
}
$sha = [Security.Cryptography.SHA256]::Create()
try { $contextHash = ([BitConverter]::ToString($sha.ComputeHash([IO.File]::ReadAllBytes($contextPath)))).Replace('-', '').ToLowerInvariant() } finally { $sha.Dispose() }
[IO.File]::WriteAllLines($proofPath, [string[]]@('contextual', $codexHome, $cwd, $skillHash, $contextRoot, $contextHash, [string]$document.schema, [string]$document.source_provider, [string]$messages.Count, [string]$messages[0].text, [string]$messages[$messages.Count - 1].text))
$rawProof = [IO.File]::ReadAllText($proofPath)
if ($rawProof.Contains('g4a-private-provider-session-canary') -or $rawProof.Contains('private-provider-login-identity')) { exit 110 }
[Console]::Out.WriteLine('F7_CODEX_BUNDLE_CONTEXT_VALIDATED')
"#;
                spec.launch.fixed_args.push(format!(
                    "& {{ param([string]$proofPath, [Parameter(ValueFromRemainingArguments=$true)][string[]]$bundleArgs) {validation}; {script} }}",
                ));
                spec.launch.fixed_args.push(proof_path.clone());
            } else if context_only_target.map(AgentId::as_str) == Some(provider_id) {
                let script = spec.launch.fixed_args.pop().ok_or_else(|| {
                    NodeServerError::Registry("PTY fixture script is unavailable".to_owned())
                })?;
                let validation = r#"
$bundleArgs = @($bundleArgs)
if ($bundleArgs.Count -ne 0) { exit 91 }
$contextRoot = [Environment]::GetEnvironmentVariable('GATE4AGENT_CONTEXT_ROOT', 'Process')
$cwd = (Get-Location).ProviderPath
if ([string]::IsNullOrEmpty($contextRoot) -or -not [IO.Path]::IsPathRooted($contextRoot) -or -not (Test-Path -LiteralPath $contextRoot -PathType Container)) { exit 92 }
$contextPath = Join-Path $contextRoot 'context-pack.json'
if (-not (Test-Path -LiteralPath $contextPath -PathType Leaf)) { exit 93 }
$entries = @(Get-ChildItem -LiteralPath $contextRoot -Force)
if ($entries.Count -ne 1 -or $entries[0] -isnot [IO.FileInfo] -or [IO.Path]::GetFullPath($entries[0].FullName) -ine [IO.Path]::GetFullPath($contextPath)) { exit 94 }
$contextFull = [IO.Path]::GetFullPath($contextRoot).TrimEnd([IO.Path]::DirectorySeparatorChar, [IO.Path]::AltDirectorySeparatorChar)
$cwdFull = [IO.Path]::GetFullPath($cwd).TrimEnd([IO.Path]::DirectorySeparatorChar, [IO.Path]::AltDirectorySeparatorChar)
$separator = [IO.Path]::DirectorySeparatorChar
if ($contextFull.Equals($cwdFull, [StringComparison]::OrdinalIgnoreCase) -or $contextFull.StartsWith($cwdFull + $separator, [StringComparison]::OrdinalIgnoreCase) -or $cwdFull.StartsWith($contextFull + $separator, [StringComparison]::OrdinalIgnoreCase)) { exit 95 }
try { $document = [IO.File]::ReadAllText($contextPath) | ConvertFrom-Json -ErrorAction Stop } catch { exit 96 }
if ($document.schema -cne 'g4a-context-pack-v1' -or $null -ne $document.PSObject.Properties['cwd']) { exit 97 }
if (@('claude', 'codex', 'grok', 'kimi') -cnotcontains [string]$document.source_provider) { exit 98 }
$messages = @($document.retained_messages)
if ($messages.Count -eq 0) { exit 99 }
$hasUser = $false
$hasAssistant = $false
foreach ($message in $messages) {
    if ([string]::IsNullOrWhiteSpace([string]$message.text)) { exit 100 }
    if ([string]$message.role -ceq 'user') { $hasUser = $true }
    elseif ([string]$message.role -ceq 'assistant') { $hasAssistant = $true }
    else { exit 101 }
}
if (-not $hasUser -or -not $hasAssistant) { exit 102 }
$sha = [Security.Cryptography.SHA256]::Create()
try { $contextHash = ([BitConverter]::ToString($sha.ComputeHash([IO.File]::ReadAllBytes($contextPath)))).Replace('-', '').ToLowerInvariant() } finally { $sha.Dispose() }
[IO.File]::WriteAllLines($proofPath, [string[]]@('context-only', $contextRoot, $cwd, $contextHash, [string]$document.schema, [string]$document.source_provider, [string]$messages.Count))
[Console]::Out.WriteLine('F7_KIMI_CONTEXT_ONLY_VALIDATED')
"#;
                spec.launch.fixed_args.push(format!(
                    "& {{ param([string]$proofPath, [Parameter(ValueFromRemainingArguments=$true)][string[]]$bundleArgs) {validation}; {script} }}",
                ));
                spec.launch.fixed_args.push(proof_path.clone());
            }
            specs.push(spec);
        }
        let catalog = AgentRegistry::new(specs)
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        Ok(catalog)
    }

    #[cfg(feature = "fixture")]
    pub fn new_exact_launcher_fixture(
        config: NodeServerConfig,
        agent_id: AgentId,
        launcher: String,
    ) -> Result<Self, NodeServerError> {
        if !matches!(agent_id.as_str(), "claude" | "codex" | "grok" | "kimi") {
            return Err(NodeServerError::Registry(
                "exact launcher fixture requires a supported provider".to_owned(),
            ));
        }
        if launcher.contains('\0') {
            return Err(NodeServerError::Registry(
                "exact launcher fixture path contains NUL".to_owned(),
            ));
        }
        let launcher_path = Path::new(&launcher);
        if !launcher_path.is_absolute() {
            return Err(NodeServerError::Registry(
                "exact launcher fixture path must be absolute".to_owned(),
            ));
        }
        let metadata = std::fs::metadata(launcher_path).map_err(|_| {
            NodeServerError::Registry("exact launcher fixture path is unavailable".to_owned())
        })?;
        if !metadata.is_file() {
            return Err(NodeServerError::Registry(
                "exact launcher fixture path must be a regular file".to_owned(),
            ));
        }
        let mut spec = builtin_registry()
            .get(&agent_id)
            .ok_or_else(|| {
                NodeServerError::Registry(
                    "exact launcher fixture provider is unavailable".to_owned(),
                )
            })?
            .clone();
        spec.launch.program = launcher;
        Self::new_fixture_with_spec(config, spec)
    }

    /// Shared H3B validation and spec construction for
    /// `new_harness_mcp_proxy_fixture` and
    /// `new_harness_mcp_acp_launcher_fixture`: an absolute, exact-regular-
    /// file provider launcher plus at most 32 Unicode, NUL-free fixed
    /// arguments (65,536 bytes total), replacing `spec.launch` on a clone of
    /// the named builtin catalog entry -- detection command and expected
    /// process matcher rebased on the launcher's own basename, exactly the
    /// same shape `new_harness_mcp_proxy_fixture` always built.
    #[cfg(feature = "fixture")]
    fn h3b_provider_spec_with_program_and_args(
        agent_id: AgentId,
        provider_program: PathBuf,
        fixed_args: Vec<OsString>,
    ) -> Result<AgentSpec, NodeServerError> {
        if !provider_program.is_absolute() || fixed_args.len() > 32 {
            return Err(NodeServerError::Registry(
                "H3B fixture requires an absolute provider and at most 32 arguments".to_owned(),
            ));
        }
        let metadata = std::fs::symlink_metadata(&provider_program).map_err(|_| {
            NodeServerError::Registry("H3B fixture provider is unavailable".to_owned())
        })?;
        if !metadata.file_type().is_file() || metadata.file_type().is_symlink() {
            return Err(NodeServerError::Registry(
                "H3B fixture provider must be an exact regular file".to_owned(),
            ));
        }
        let program = provider_program.into_os_string().into_string().map_err(|_| {
            NodeServerError::Registry("H3B fixture provider path is not Unicode".to_owned())
        })?;
        let fixed_args = fixed_args.into_iter().map(|argument| {
            argument.into_string().map_err(|_| NodeServerError::Registry(
                "H3B fixture argument is not Unicode".to_owned(),
            ))
        }).collect::<Result<Vec<_>, _>>()?;
        let argument_bytes = fixed_args.iter()
            .try_fold(0usize, |total, argument| total.checked_add(argument.len()));
        if program.contains('\0')
            || fixed_args.iter().any(|argument| argument.contains('\0'))
            || !matches!(argument_bytes, Some(total) if total <= 65_536)
        {
            return Err(NodeServerError::Registry(
                "H3B fixture provider or arguments are invalid".to_owned(),
            ));
        }
        let mut spec = builtin_registry().get(&agent_id).ok_or_else(|| {
            NodeServerError::Registry("H3B fixture provider is unavailable".to_owned())
        })?.clone();
        let process_name = Path::new(&program).file_name().and_then(|name| name.to_str())
            .ok_or_else(|| NodeServerError::Registry(
                "H3B fixture provider basename is unavailable".to_owned(),
            ))?.to_owned();
        spec.detection.command = process_name.clone();
        spec.expected_processes = vec![gate4agent_types::ProcessMatcher::Exact {
            name: process_name,
        }];
        spec.launch.program = program;
        spec.launch.fixed_args = fixed_args;
        Ok(spec)
    }

    #[cfg(feature = "fixture")]
    pub fn new_harness_mcp_proxy_fixture(
        config: NodeServerConfig,
        provider_program: PathBuf,
        fixed_args: Vec<OsString>,
        harness_mcp_program: PathBuf,
    ) -> Result<Self, NodeServerError> {
        let mut config = config.with_harness_mcp_helper(harness_mcp_program)?;
        let agent_id = AgentId::new("codex")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let mut spec =
            Self::h3b_provider_spec_with_program_and_args(agent_id, provider_program, fixed_args)?;
        spec.display_name = "Controlled H3B MCP proxy fixture".to_owned();
        config.fixture_raw_pty_runtime = true;
        Self::new_fixture_with_spec(config, spec)
    }

    /// The ACP-mode sibling of `new_harness_mcp_proxy_fixture`: the same
    /// `--harness-mcp-helper` wiring and the same absolute-program-plus-
    /// fixed-args launcher replacement as `new_exact_launcher_fixture`, but
    /// admitting `ProviderRuntimeRequirement::Acp` the honest way instead of
    /// hardcoding it. `new_harness_mcp_proxy_fixture` forces `config.
    /// fixture_raw_pty_runtime = true`, which tears out the live
    /// `ProviderRuntimeMonitor` entirely (`NodeServer::new_with_registry`)
    /// and makes `NodeShared::admit_provider_runtime`'s no-monitor branch
    /// hardcode `acp_transport = false` for every provider, refusing
    /// `ProviderRuntimeRequirement::Acp` unconditionally regardless of what
    /// the catalog declares. This constructor leaves `fixture_raw_pty_
    /// runtime` at its default `false`, so a real `ProviderRuntimeMonitor`
    /// is built from the (cloned, launcher-replaced) catalog spec, and
    /// `ProviderRuntimeMonitor::supports_acp_transport` reads the honest,
    /// unmodified catalog fact: every builtin provider this accepts
    /// (`claude`, `codex`, `grok`, `kimi`) already declares `capabilities.
    /// transports.acp` in `gate4agent-catalog::builtin`, so no capability is
    /// invented here -- this constructor only removes the fixture-only
    /// bypass standing in its way. `provider_runtime::policy_for_transport`'s
    /// `TransportKind::Acp` arm (applied unconditionally at spawn-prep time
    /// for every ACP session, fixture or not) is what actually grants the
    /// ACP-shaped `ProviderRuntimePolicy` downstream of that admission --
    /// this constructor never calls it directly, and does not need to.
    #[cfg(feature = "fixture")]
    pub fn new_harness_mcp_acp_launcher_fixture(
        config: NodeServerConfig,
        helper_program: PathBuf,
        provider: AgentId,
        program: PathBuf,
        args: Vec<OsString>,
    ) -> Result<Self, NodeServerError> {
        if !matches!(provider.as_str(), "claude" | "codex" | "grok" | "kimi") {
            return Err(NodeServerError::Registry(
                "ACP harness-MCP launcher fixture requires a supported provider".to_owned(),
            ));
        }
        let config = config.with_harness_mcp_helper(helper_program)?;
        let mut spec = Self::h3b_provider_spec_with_program_and_args(provider, program, args)?;
        let launch = spec.launch.clone();
        let acp = spec.capabilities.transports.acp.as_mut().ok_or_else(|| {
            NodeServerError::Registry(
                "ACP harness-MCP launcher fixture provider does not declare an ACP transport"
                    .to_owned(),
            )
        })?;
        // Routes the ACP spawn itself through the exact replaced launcher
        // (`AcpSession::spawn_with_launch` -> a bare `Command::new(&launch.
        // program)`, `gate4agent`'s `src/acp/spawn.rs`) instead of the
        // catalog's own vendor-npm resolution (`acp_command`, same file) --
        // without this the ACP transport ignores `spec.launch` entirely and
        // tries to spawn the real vendor CLI (e.g. `npx -y @agentclientprotocol/
        // codex-acp@1.10.0`), which this fixture must never reach.
        acp.launch_override = Some(launch);
        spec.display_name = "Controlled ACP harness-MCP launcher fixture".to_owned();
        Self::new_fixture_with_spec(config, spec)
    }

    #[cfg(feature = "fixture")]
    pub fn new_resume_fixture(config: NodeServerConfig) -> Result<Self, NodeServerError> {
        let mut spec = gate4agent_testkit::interactive_agent_spec();
        let claude_id = AgentId::new("claude")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        let claude = builtin_registry()
            .get(&claude_id)
            .ok_or_else(|| NodeServerError::Registry("Claude fixture adapter is unavailable".to_owned()))?;
        spec.id = claude_id;
        spec.display_name = "Resumable Claude PTY fixture".to_owned();
        spec.expected_processes = vec![gate4agent_types::ProcessMatcher::Exact {
            name: "claude".to_owned(),
        }];
        spec.capabilities.transports.pty_adapter = claude
            .capabilities
            .transports
            .pty_adapter
            .clone();
        spec.capabilities.adapters.resume = claude
            .capabilities
            .adapters
            .resume
            .clone();
        let script = spec
            .launch
            .fixed_args
            .pop()
            .ok_or_else(|| NodeServerError::Registry("PTY fixture script is unavailable".to_owned()))?;
        spec.launch.fixed_args.push(format!(
            "& {{ param([Parameter(ValueFromRemainingArguments=$true)][string[]]$ignored) {script} }}",
        ));
        Self::new_fixture_with_spec(config, spec)
    }

    #[cfg(feature = "fixture")]
    pub fn new_cmd_cwd_fixture(
        config: NodeServerConfig,
        command: String,
    ) -> Result<Self, NodeServerError> {
        let mut spec = gate4agent_testkit::interactive_agent_spec();
        spec.id = AgentId::new("claude")
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        spec.display_name = "Controlled cmd cwd fixture".to_owned();
        spec.detection.command = "gate4agent-cwd-fixture.cmd".to_owned();
        spec.launch.program = command;
        spec.launch.fixed_args.clear();
        Self::new_fixture_with_spec(config, spec)
    }

    #[cfg(feature = "fixture")]
    fn new_fixture_with_spec(
        config: NodeServerConfig,
        spec: gate4agent_types::AgentSpec,
    ) -> Result<Self, NodeServerError> {
        let catalog = AgentRegistry::new([spec])
            .map_err(|error| NodeServerError::Registry(error.to_string()))?;
        Self::new_with_registry(config, catalog)
    }

    fn new_with_registry(
        config: NodeServerConfig,
        catalog: AgentRegistry,
    ) -> Result<Self, NodeServerError> {
        for profile in config.spawn_profiles.iter() {
            if catalog.get(&profile.provider).is_none() {
                return Err(NodeServerError::Registry(
                    "spawn profile references an unavailable provider".to_owned(),
                ));
            }
        }
        let input_settle_timeout_ms = catalog
            .iter()
            .map(|spec| spec.readiness.timeout_ms)
            .max()
            .unwrap_or(MUTATION_SETTLE_TIMEOUT_MS)
            .saturating_add(READINESS_SETTLE_HEADROOM_MS)
            .max(MUTATION_SETTLE_TIMEOUT_MS);
        let (provider_contracts, provider_adapter_contracts) =
            provider_contract_manifest(&catalog)?;
        let compatibility_support = node_compatibility_support_for_manifest(
            &provider_contracts,
            &provider_adapter_contracts,
        )?;
        validate_node_negotiated_handshake_capacity(&compatibility_support)
            .map_err(|error| NodeServerError::ProviderContractManifest(error.to_string()))?;
        let enabled_providers = provider_contracts
            .iter()
            .map(|contract| contract.provider.clone())
            .collect();
        #[cfg(feature = "fixture")]
        let fixture_raw_pty_runtime = config.fixture_raw_pty_runtime;
        #[cfg(not(feature = "fixture"))]
        let fixture_raw_pty_runtime = false;
        let (provider_runtime_monitor, provider_runtime_statuses) = if fixture_raw_pty_runtime {
            let statuses = ProviderRuntimeStatuses::new(catalog.iter().map(|spec| {
                crate::protocol::ProviderRuntimeStatus::raw_passthrough(spec.id.clone(), None)
            })).expect("fixture provider catalog remains bounded");
            (None, statuses)
        } else {
            let monitor = Arc::new(ProviderRuntimeMonitor::new(&catalog));
            let statuses = monitor.collect();
            (Some(monitor), statuses)
        };
        let state_path_lock =
            session_registry::StatePathLock::acquire(config.state_path.as_deref())
                .map_err(|error| {
                    durable_state_server_error(error, DURABLE_STATE_LOCK_FAILED_ERROR)
                })?;
        let (delivery_store, delivered_bundles) = match config.state_path.as_ref() {
            Some(state_path) => {
                let delivery_root = delivery_store_root_for_state_path(state_path)
                    .ok_or_else(|| {
                        NodeServerError::DeliveryStore(
                            "delivery store root could not be derived from state path".to_owned(),
                        )
                    })?;
                let (store, bundles) = DeliveryStore::open(delivery_root).map_err(|error| {
                    let detail = match &error {
                        DeliveryStoreError::Storage(io_error) => {
                            format!("{error}: {io_error}")
                        }
                        _ => error.to_string(),
                    };
                    NodeServerError::DeliveryStore(detail)
                })?;
                (Some(store), bundles)
            }
            None => (None, Vec::new()),
        };
        let delivered_catalog = BundleCatalog::new(delivered_bundles).map_err(|error| {
            NodeServerError::DeliveryStore(format!("bundle catalog: {error}"))
        })?;
        let (context_pack_store, durable_context_packs) = match config.state_path.as_ref() {
            Some(state_path) => {
                let context_pack_root = context_pack_store_root_for_state_path(state_path)
                    .ok_or(NodeServerError::ContextPackStore)?;
                let (store, packs) = ContextPackStore::open(context_pack_root)
                    .map_err(|_| NodeServerError::ContextPackStore)?;
                (Some(store), packs)
            }
            None => (None, Vec::new()),
        };
        let mut durable_context_catalog = ContextPackCatalog::default();
        for pack in durable_context_packs {
            durable_context_catalog
                .insert(pack)
                .map_err(|_| NodeServerError::ContextPackStore)?;
        }
        let session_environment_materializer = config
            .session_environment
            .as_ref()
            .map(|environment| {
                SessionEnvironmentMaterializer::new(
                    environment.root.clone(),
                    Arc::clone(&environment.resolver),
                )
                .map_err(|_| NodeServerError::SessionEnvironmentMaterializer)
            })
            .transpose()?;
        // Session launchers go through the unprivileged `exec-as` wrapper when run-as is set
        // (the provider version probe above already used the original catalog).
        #[cfg(unix)]
        let catalog = crate::isolation::wrap_registry(catalog).map_err(NodeServerError::Registry)?;
        let native_session_catalog = config.history.clone().map(|history| {
            Arc::new(Mutex::new(NativeSessionCatalogAuthority::new(history)))
        });
        let (handle, runtime) = match config.history.clone() {
            Some(history) => NativeRuntime::new_with_history(catalog, config.runtime, history),
            None => NativeRuntime::new(catalog, config.runtime),
        };
        let native_launch_profile_control = runtime.native_launch_profile_control();
        let harness_mcp_registry = config
            .harness_mcp_helper
            .clone()
            .map(HarnessMcpProxyRegistry::new);
        let events = handle.subscribe(CONTROL_EVENT_SUBSCRIPTION_CAPACITY);
        let incarnation_id = random_incarnation_id()
            .map_err(NodeServerError::IncarnationIdentity)?;
        let mut loaded = session_registry::load(config.state_path.as_deref(), &config.node_id)
            .map_err(durable_state_load_error)?;
        let managed_worktrees = std::mem::take(&mut loaded.managed_worktrees);
        let managed_worktree_tombstones =
            std::mem::take(&mut loaded.managed_worktree_tombstones);
        let materializations = std::mem::take(&mut loaded.materializations);
        let managed_spawn_replays = std::mem::take(&mut loaded.managed_spawn_replays);
        let (workspaces, records, persistence_warning) =
            merge_durable_state(&config.workspaces, loaded)?;
        let mut shared = NodeShared::new_with_incarnation(
            handle,
            config.access_token.clone(),
            config.node_id.clone(),
            incarnation_id,
            workspaces,
            enabled_providers,
            provider_runtime_statuses,
            provider_runtime_monitor,
            provider_contracts,
            provider_adapter_contracts,
            config.spawn_profiles.clone(),
            Some(native_launch_profile_control),
            native_session_catalog,
            session_environment_materializer,
            config.state_path.clone(),
            records,
            managed_worktrees,
            managed_worktree_tombstones,
            materializations,
            persistence_warning,
            input_settle_timeout_ms,
        );
        shared.harness_mcp_registry = harness_mcp_registry.clone();
        shared.session_record_retention = config.session_record_retention;
        shared.network_allowlist_catalog =
            RwLock::new(config.network_allowlist_catalog.clone());
        shared.bundle_catalog = RwLock::new(delivered_catalog);
        shared.delivery_store = Mutex::new(delivery_store);
        shared.context_catalog = RwLock::new(durable_context_catalog);
        shared.context_pack_store = Mutex::new(context_pack_store);
        shared.managed_spawn_replays = Mutex::new(
            managed_spawn_replays
                .into_iter()
                .map(|record| (record.idempotency_key.clone(), record))
                .collect(),
        );
        let shared = Arc::new(shared);
        if let Some(registry) = harness_mcp_registry {
            let weak = Arc::downgrade(&shared);
            registry.set_event_sink(Arc::new(move |event| match weak.upgrade() {
                Some(shared) => shared.publish_transient(event),
                None => false,
            }));
        }
        if shared.persistence_error().is_none() {
            shared.persist_state().map_err(|error| {
                durable_state_server_error(error, DURABLE_STATE_COMMIT_FAILED_ERROR)
            })?;
        }
        Ok(Self {
            config,
            runtime,
            shared,
            events,
            state_path_lock,
        })
    }

    pub fn shutdown_handle(&self) -> NodeShutdownHandle {
        NodeShutdownHandle {
            shared: Arc::clone(&self.shared),
        }
    }

    #[cfg(feature = "fixture")]
    pub fn spawn_managed_worktree_v2_failure_probe_fixture(
        &self,
    ) -> SpawnManagedWorktreeV2FailureProbe {
        self.shared
            .fixture_spawn_managed_worktree_v2_failure_probe
            .clone()
    }

    /// Installs one immutable host-local environment profile before the server runs.
    ///
    /// Native resolvers remain inside the runtime; the shared node registry keeps
    /// only public IDs, revisions, provider bindings, and opaque native profile IDs.
    pub fn install_environment_profile(
        &mut self,
        profile: NodeEnvironmentProfile,
    ) -> Result<(), NodeServerError> {
        if !self.shared.enabled_providers.contains(profile.provider()) {
            return Err(NodeServerError::EnvironmentProfileProviderUnavailable(
                profile.provider().clone(),
            ));
        }
        let (binding, native_profiles, materialization) = profile.into_parts();
        if materialization.is_some() && self.shared.session_environment_materializer.is_none() {
            return Err(NodeServerError::SessionEnvironmentMaterializerRequired);
        }
        let mut profiles = self
            .shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if profiles.contains_key(&binding.id) {
            return Err(NodeServerError::DuplicateEnvironmentProfile(
                binding.id.clone(),
            ));
        }
        if profiles.len() >= MAX_NODE_ENVIRONMENT_PROFILES {
            return Err(NodeServerError::EnvironmentProfileCapacity {
                max: MAX_NODE_ENVIRONMENT_PROFILES,
            });
        }
        for native_id in binding.native_profile_ids() {
            if profiles.values().any(|current| {
                current.native_profile_ids().any(|current_id| current_id == native_id)
            }) {
                return Err(NodeServerError::DuplicateNativeEnvironmentProfile(
                    native_id.to_string(),
                ));
            }
        }

        let mut installed = Vec::with_capacity(native_profiles.len());
        for native_profile in native_profiles {
            let native_id = native_profile.id().clone();
            if let Err(error) = self.runtime.upsert_native_launch_profile(native_profile) {
                for installed_id in installed.into_iter().rev() {
                    let _ = self.runtime.remove_native_launch_profile(&installed_id);
                }
                return Err(NodeServerError::NativeEnvironmentProfile(error.to_string()));
            }
            installed.push(native_id);
        }
        if let Some(materialization) = materialization {
            self.shared
                .environment_materialization_profiles
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(binding.id.clone(), materialization);
        }
        profiles.insert(binding.id.clone(), binding);
        Ok(())
    }

    /// Installs one immutable host-local bundle before the server runs.
    pub fn install_bundle(&mut self, bundle: NodeBundle) -> Result<(), NodeServerError> {
        if self.shared.session_environment_materializer.is_none() {
            return Err(NodeServerError::SessionEnvironmentMaterializerRequired);
        }
        let mut catalog = self
            .shared
            .bundle_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        catalog
            .insert_idempotent(bundle)
            .map_err(|error| NodeServerError::BundleCatalog(error.to_string()))?;
        Ok(())
    }

    pub async fn run_until_ctrl_signal(self) -> Result<(), NodeServerError> {
        let shutdown = self.shutdown_handle();
        let run = self.run();
        tokio::pin!(run);
        tokio::select! {
            result = &mut run => result,
            signal = wait_for_ctrl_signal() => {
                signal?;
                let shutdown_result = shutdown.request_shutdown().await;
                let run_result = run.await;
                shutdown_result.and(run_result)
            }
        }
    }

    pub async fn run(self) -> Result<(), NodeServerError> {
        let NodeServer {
            config,
            mut runtime,
            shared,
            events,
            state_path_lock: _state_path_lock,
        } = self;
        shared.reconcile_materializations();
        shared.reconcile_managed_worktrees().await;
        shared.retire_unavailable_session_records().await;
        shared.reconcile_context_pack_exports().await;
        {
            let restore = Arc::clone(&shared);
            tokio::spawn(async move {
                sleep(Duration::from_secs(3)).await;
                restore.restore_journalled_sessions().await;
                loop {
                    restore.refresh_session_journal();
                    if restore.shutdown.load(Ordering::Acquire) { break; }
                    sleep(Duration::from_secs(10)).await;
                }
            });
        }
        // Lifecycle hooks are retired (owner ruling 2026-09-25): the node
        // observes sessions through ACP where a provider has it; there is no
        // hook ingress.
        let endpoint = config.endpoint.clone();
        let call_home = config.call_home;
        let call_home_identity = config.call_home_identity.clone();
        let api_listen = config.api_listen;
        let bridge_listen = config.bridge_listen;
        let bridge_underlay = config.bridge_underlay;
        let bridge_auth = browser_bridge::BridgeAuth::from_optional(config.bridge_token)
            .map_err(|_| NodeServerError::InvalidBridgeToken)?;
        let accept_shared = Arc::clone(&shared);
        let api_shared = Arc::clone(&shared);
        let bridge_shared = Arc::clone(&shared);
        let shutdown_shared = Arc::clone(&shared);
        let shutdown_timeout = Duration::from_millis(
            config.runtime.provider_shutdown_timeout_ms.max(1),
        );
        let result = {
            let runtime_loop = drive_runtime_until_shutdown(
                &mut runtime,
                events,
                Arc::clone(&shared),
                shutdown_timeout,
            );
            let accept_loop = accept_connections(&endpoint, call_home, call_home_identity, accept_shared);
            let api_loop = http_api::run(api_listen, api_shared);
            let bridge_loop = browser_bridge::run(bridge_listen, bridge_auth, bridge_shared, bridge_underlay);
            tokio::pin!(runtime_loop);
            tokio::pin!(accept_loop);
            tokio::pin!(api_loop);
            tokio::pin!(bridge_loop);
            tokio::select! {
                runtime_result = &mut runtime_loop => {
                    let shutdown_result = shutdown_shared
                        .begin_shutdown()
                        .await
                        .map_err(NodeServerError::ShutdownDispatch);
                    let (accept_result, api_result, bridge_result) =
                        tokio::join!(&mut accept_loop, &mut api_loop, &mut bridge_loop);
                    match runtime_result {
                        Err(error) => Err(error),
                        Ok(()) => shutdown_result
                            .and(accept_result)
                            .and(api_result.map_err(NodeServerError::HttpApi))
                            .and(bridge_result.map_err(NodeServerError::BridgeApi)),
                    }
                }
                accept_result = &mut accept_loop => {
                    let shutdown_result = shutdown_shared
                        .begin_shutdown()
                        .await
                        .map_err(NodeServerError::ShutdownDispatch);
                    let (runtime_result, api_result, bridge_result) =
                        tokio::join!(&mut runtime_loop, &mut api_loop, &mut bridge_loop);
                    match accept_result {
                        Err(error) => Err(error),
                        Ok(()) => shutdown_result
                            .and(runtime_result)
                            .and(api_result.map_err(NodeServerError::HttpApi))
                            .and(bridge_result.map_err(NodeServerError::BridgeApi)),
                    }
                }
                api_result = &mut api_loop => {
                    let shutdown_result = shutdown_shared
                        .begin_shutdown()
                        .await
                        .map_err(NodeServerError::ShutdownDispatch);
                    let (runtime_result, accept_result, bridge_result) =
                        tokio::join!(&mut runtime_loop, &mut accept_loop, &mut bridge_loop);
                    match api_result {
                        Err(error) => Err(NodeServerError::HttpApi(error)),
                        Ok(()) => shutdown_result
                            .and(runtime_result)
                            .and(accept_result)
                            .and(bridge_result.map_err(NodeServerError::BridgeApi)),
                    }
                }
                bridge_result = &mut bridge_loop => {
                    let shutdown_result = shutdown_shared
                        .begin_shutdown()
                        .await
                        .map_err(NodeServerError::ShutdownDispatch);
                    let (runtime_result, accept_result, api_result) =
                        tokio::join!(&mut runtime_loop, &mut accept_loop, &mut api_loop);
                    match bridge_result {
                        Err(error) => Err(NodeServerError::BridgeApi(error)),
                        Ok(()) => shutdown_result
                            .and(runtime_result)
                            .and(accept_result)
                            .and(api_result.map_err(NodeServerError::HttpApi)),
                    }
                }
            }
        };
        // Persistence gap fix: durable DeliveryStore / ContextPackStore hold
        // exclusive flock (Unix) / share-mode locks (Windows) inside NodeShared.
        // NodeShutdownHandle also clones that Arc, so without an explicit release
        // here a supervisor that keeps the shutdown handle cannot reopen the same
        // state path after run() returns (EAGAIN / Resource temporarily unavailable).
        // StatePathLock already drops with this stack frame (`_state_path_lock`).
        if let Ok(mut guard) = shared.delivery_store.lock() {
            *guard = None;
        }
        if let Ok(mut guard) = shared.context_pack_store.lock() {
            *guard = None;
        }
        result
    }
}

async fn drive_runtime_until_shutdown(
    runtime: &mut NativeRuntime,
    events: EventSubscription,
    shared: Arc<NodeShared>,
    shutdown_timeout: Duration,
) -> Result<(), NodeServerError> {
    // Published once, never per iteration. The worker loops inside
    // `NativeRuntime` fold into this profile continuously; turning it into
    // percentiles is what costs, and that is `GET /metrics`'s bill to pay.
    let _ = shared
        .shell_efficiency_profile
        .set(runtime.shell_efficiency_profile());
    let mut shutdown_started = None;
    let mut last_retention_sweep = Instant::now();
    let mut last_provisional_reap = Instant::now();
    loop {
        // Every phase below is timed unconditionally -- see
        // `drive_loop_profile`'s own doc comment for why an always-on,
        // allocation-free ring is cheap enough to never need a feature
        // flag. This is the only place these numbers can be taken: the
        // phases are calls made directly from this loop, not something a
        // callee could time on our behalf.
        let runtime_tick_start = Instant::now();
        let tick_result = runtime.tick().await;
        let runtime_tick_elapsed = runtime_tick_start.elapsed();

        let event_drain_start = Instant::now();
        // Every command the kernel refused, named. `NativeRuntimeTick`
        // has carried these outcomes all along and nothing read them, so a
        // rejected command -- a hook event denied by runtime policy, a
        // stale generation, an unsupported capability -- vanished at the
        // last step of the loop that produced it. A refusal the operator
        // cannot see is indistinguishable from an event that never arrived,
        // and telling those two apart is most of debugging this stack.
        for outcome in &tick_result.command_outcomes {
            if let Err(error) = &outcome.result {
                shared.rejected_commands_total.fetch_add(1, Ordering::Relaxed);
                tracing::warn!(
                    command_id = outcome.command_id.0,
                    cause = %error,
                    "control command rejected"
                );
                shared.record_rejected_command(
                    outcome.command_id,
                    error.to_string(),
                    error.is_unsupported_transport(),
                );
            }
        }
        let mut events_drained: u64 = 0;
        while let Ok(event) = events.try_recv() {
            events_drained += 1;
            let clean_exit = matches!(
                event.event,
                ControlEventKind::Exited { exit_code: Some(0), forced: false },
            );
            let instance_id = event.instance_id;
            let generation = event.generation;
            // Resolve and spawn before publish_control: publish_control's own
            // managed-record bookkeeping (reconcile_managed_record) downgrades
            // this exact record from Live to Dormant and clears
            // active_session for every Exited event, inside the same
            // synchronous call. Capturing (record_id, session) here — before
            // that runs — is the only way to observe them still Live and
            // still populated; the export itself must still run on its own
            // detached task (never awaited inline on this loop) because it
            // needs NativeRuntime::tick() to keep running to ever settle, and
            // tick() is only ever driven by this same loop. See
            // reconcile_context_pack_export_for_record's doc comment.
            if clean_exit {
                if let Some((record_id, session)) =
                    shared.managed_record_export_target_for_instance(instance_id, generation)
                {
                    let export_shared = Arc::clone(&shared);
                    tokio::spawn(async move {
                        export_shared
                            .reconcile_context_pack_export_for_record(&record_id, session)
                            .await;
                    });
                }
            }
            shared.publish_control(event);
        }
        let event_drain_elapsed = event_drain_start.elapsed();

        let publish_terminal_frames_start = Instant::now();
        shared.publish_terminal_frames();
        shared.run_due_provider_retries();
        let publish_terminal_frames_elapsed = publish_terminal_frames_start.elapsed();

        // Physical PTY count and the runtime's own per-phase tick timings
        // both live inside `NativeRuntime`, which `GET /metrics` (reading
        // only `NodeShared`) cannot reach directly -- this loop is the one
        // place holding `&mut NativeRuntime`, so it is the only place that
        // can copy either out.
        shared
            .native_session_gauge
            .store(runtime.active_native_sessions(), Ordering::Relaxed);
        *shared
            .runtime_tick_profile
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) = runtime.tick_profile_snapshot();

        let remainder_start = Instant::now();
        if shared.shutdown.load(Ordering::Acquire) {
            let started = *shutdown_started.get_or_insert_with(Instant::now);
            let snapshot = shared.handle.snapshot();
            let sessions_settled = snapshot.sessions.iter().all(|session| {
                !matches!(
                    session.status,
                    gate4agent_types::SessionStatus::Starting
                        | gate4agent_types::SessionStatus::Running
                        | gate4agent_types::SessionStatus::Stopping
                )
            });
            if runtime.active_native_sessions() == 0 && sessions_settled {
                return Ok(());
            }
            if started.elapsed() >= shutdown_timeout {
                return Err(NodeServerError::ShutdownTimedOut {
                    active_native_sessions: runtime.active_native_sessions(),
                });
            }
        }
        let remainder_elapsed = remainder_start.elapsed();

        {
            let mut profile = shared
                .drive_loop_profile
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            profile.record_runtime_tick(runtime_tick_elapsed);
            profile.record_event_drain(event_drain_elapsed);
            profile.record_publish_terminal_frames(publish_terminal_frames_elapsed);
            profile.record_remainder(remainder_elapsed);
            profile.note_iteration(Instant::now());
        }

        // "Produced nothing" means this iteration's `NativeRuntime::tick`
        // applied zero observations (`tick_result.observations_applied`,
        // which already folds in any terminal frames collected -- see
        // `NativeEffectDispatcher::drain_observations`) AND the
        // control-event subscription drained above forwarded zero events.
        // Command ingress and dispatched effects are deliberately NOT part
        // of this definition: an idle node still runs `step_control_plane`
        // and every provider supervisor's `tick` regardless, every 10ms --
        // so "nothing" here means nothing OBSERVABLE left this iteration,
        // matching what a reader would assume from `drive_loop_iterations`'s
        // own field name, not that the tick itself was free of work.
        shared.drive_loop_iterations_total.fetch_add(1, Ordering::Relaxed);
        if tick_result.observations_applied == 0 && events_drained == 0 {
            shared.drive_loop_iterations_idle.fetch_add(1, Ordering::Relaxed);
        }

        // A sweep cadence, not a policy value -- see
        // `SESSION_RECORD_RETENTION_SWEEP_PERIOD`'s own doc comment. The
        // policy itself (whether this does anything at all) lives entirely
        // in `NodeShared::session_record_retention`.
        if last_retention_sweep.elapsed() >= SESSION_RECORD_RETENTION_SWEEP_PERIOD {
            shared.retire_unavailable_session_records().await;
            last_retention_sweep = Instant::now();
        }
        // Provisional Spawn grace: kill PTYs that never got an HQ attach.
        if last_provisional_reap.elapsed() >= Duration::from_secs(2) {
            for address in shared.take_due_provisional_spawns() {
                shared.reap_provisional_spawn(address).await;
            }
            last_provisional_reap = Instant::now();
        }

        // Fast-poll for 300ms after PTY input so its echo is read and published
        // within ~1ms; otherwise nap 10ms but wake at once on new input.
        let hot = shared
            .pty_input_marks
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .any(|(at, _)| at.elapsed() < Duration::from_millis(300));
        if hot {
            sleep(Duration::from_millis(1)).await;
        } else {
            tokio::select! {
                _ = sleep(Duration::from_millis(10)) => {}
                _ = shared.pty_input_wake.notified() => {}
            }
        }
    }
}

#[derive(Clone)]
pub struct NodeShutdownHandle {
    shared: Arc<NodeShared>,
}

impl NodeShutdownHandle {
    pub async fn request_shutdown(&self) -> Result<(), NodeServerError> {
        self.shared
            .begin_shutdown()
            .await
            .map_err(NodeServerError::ShutdownDispatch)
    }
}

async fn wait_for_ctrl_signal() -> Result<(), NodeServerError> {
    #[cfg(windows)]
    {
    let mut ctrl_c = tokio::signal::windows::ctrl_c()?;
    let mut ctrl_break = tokio::signal::windows::ctrl_break()?;
    return tokio::select! {
        signal = ctrl_c.recv() => signal.ok_or(NodeServerError::SignalStreamClosed),
        signal = ctrl_break.recv() => signal.ok_or(NodeServerError::SignalStreamClosed),
    };
    }
    #[cfg(unix)]
    {
        let mut interrupt = tokio::signal::unix::signal(tokio::signal::unix::SignalKind::interrupt())?;
        let mut terminate = tokio::signal::unix::signal(tokio::signal::unix::SignalKind::terminate())?;
        tokio::select! {
            signal = interrupt.recv() => signal.ok_or(NodeServerError::SignalStreamClosed),
            signal = terminate.recv() => signal.ok_or(NodeServerError::SignalStreamClosed),
        }
    }
}

/// The providers this node actually runs.
///
/// `builtin_registry()` is a reference catalog of everything the project has
/// ever described; the fleet is this list, and it is deliberately short. A
/// provider only belongs here if it can be exercised for real -- there is a
/// subscription behind it and a failure in it can be reproduced and
/// debugged. Carrying one that cannot is carrying code nobody can verify,
/// which is worse than not supporting it: it looks supported.
///
/// A provider dropped from the fleet by this rule is removed outright, not
/// carried dark: no catalog entry, no adapter, no dead code claiming support
/// for something nobody can verify runs.
/// Host interactive shell for HQ terminal attach (no provider CLI, no network).
fn shell_host_spec() -> AgentSpec {
    // Windows nodes (incl. MSYS-hosted) have no `/bin/bash` for Win32 Path::is_file;
    // fleet inventory on op-box resolves `bash` to the WSL stub at
    // `/c/Windows/system32/bash`, which is not a host shell. Use ComSpec/cmd.
    #[cfg(windows)]
    let (detect_command, program, fixed_args, process_name) = {
        let program = std::env::var("ComSpec").unwrap_or_else(|_| {
            r"C:\Windows\System32\cmd.exe".to_owned()
        });
        ("cmd".to_owned(), program, Vec::<String>::new(), "cmd".to_owned())
    };
    #[cfg(not(windows))]
    let (detect_command, program, fixed_args, process_name) = (
        "bash".to_owned(),
        "/bin/bash".to_owned(),
        vec!["-i".to_owned()],
        "bash".to_owned(),
    );
    AgentSpec {
        id: AgentId::new("shell").expect("shell agent id"),
        revision: "hatchery:shell-pty-1".to_owned(),
        display_name: "Host shell".to_owned(),
        detection: DetectionSpec {
            command: detect_command,
            aliases: vec!["sh".to_owned(), "shell".to_owned(), "cmd".to_owned()],
            required_commands: Vec::new(),
            unsupported_platforms: Vec::new(),
        },
        launch: LaunchSpec {
            program,
            fixed_args,
        },
        expected_processes: vec![ProcessMatcher::Exact {
            name: process_name,
        }],
        prompt: PromptSpec {
            initial: InitialPromptMode::None,
            native_draft: None,
        },
        readiness: AgentReadinessSpec::default(),
        capabilities: AgentCapabilities {
            agent_commands: None,
            transports: AgentTransportCapabilities {
                pty: true,
                pty_adapter: None,
                pipe: None,
                acp: None,
            },
            adapters: AgentAdapterCapabilities::default(),
        },
        verification: SpecVerification::Gate4AgentVerified,
    }
}

fn active_registry() -> Result<AgentRegistry, NodeServerError> {
    let mut specs = vec![shell_host_spec()];
    specs.extend(
        builtin_registry()
            .iter()
            .filter(|spec| matches!(spec.id.as_str(), "claude" | "codex" | "grok" | "kimi"))
            .cloned(),
    );
    AgentRegistry::new(specs).map_err(|error| NodeServerError::Registry(error.to_string()))
}

fn provider_contract_manifest(
    catalog: &AgentRegistry,
) -> Result<
    (
        Vec<ProviderContractSupport>,
        Vec<ProviderAdapterContractSupport>,
    ),
    NodeServerError,
> {
    let mut provider_contracts = Vec::new();
    let mut provider_adapter_contracts = Vec::new();
    for spec in catalog.iter() {
        let provider = spec.id.clone();
        let revision = ProviderContractRevision::new(spec.revision.clone())
            .map_err(|error| NodeServerError::ProviderContractManifest(error.to_string()))?;
        provider_contracts.push(ProviderContractSupport {
            provider: provider.clone(),
            revision,
        });
        for (family, binding) in declared_adapter_bindings(spec)? {
            let revision = AdapterContractRevision::new(binding.revision.clone())
                .map_err(|error| NodeServerError::ProviderContractManifest(error.to_string()))?;
            provider_adapter_contracts.push(ProviderAdapterContractSupport {
                provider: provider.clone(),
                family,
                adapter_id: binding.id.clone(),
                revision,
            });
        }
    }
    validate_provider_contract_manifest(&provider_contracts, &provider_adapter_contracts)
        .map_err(|error| NodeServerError::ProviderContractManifest(error.to_string()))?;
    Ok((provider_contracts, provider_adapter_contracts))
}

fn declared_adapter_bindings(
    spec: &AgentSpec,
) -> Result<Vec<(AdapterFamily, &AdapterBinding)>, NodeServerError> {
    let mut bindings = Vec::new();
    push_declared_binding(
        &mut bindings,
        AdapterFamily::PtySemantic,
        spec.capabilities.transports.pty_adapter.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::Pipe,
        spec.capabilities.adapters.pty_sidecar.as_ref(),
    )?;
    let pipe_transport = spec.capabilities.transports.pipe.as_ref();
    let pipe_family = pipe_transport.map(|transport| match transport.protocol {
        gate4agent_types::PipeProtocol::SemanticNdjson
        | gate4agent_types::PipeProtocol::StructuredJsonl => AdapterFamily::Pipe,
        gate4agent_types::PipeProtocol::OneShotText => AdapterFamily::OneShot,
    });
    push_declared_binding(
        &mut bindings,
        AdapterFamily::Pipe,
        pipe_transport
            .filter(|_| pipe_family == Some(AdapterFamily::Pipe))
            .map(|transport| &transport.adapter),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::Acp,
        spec.capabilities
            .transports
            .acp
            .as_ref()
            .map(|transport| &transport.adapter),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::Hook,
        spec.capabilities.adapters.hook.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::ManagedHook,
        spec.capabilities.adapters.managed_hook.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::OneShot,
        pipe_transport
            .filter(|_| pipe_family == Some(AdapterFamily::OneShot))
            .map(|transport| &transport.adapter),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::OneShot,
        spec.capabilities.adapters.one_shot.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::History,
        spec.capabilities.adapters.history.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::Resume,
        spec.capabilities.adapters.resume.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::SessionOptions,
        spec.capabilities.adapters.session_options.as_ref(),
    )?;
    push_declared_binding(
        &mut bindings,
        AdapterFamily::CapabilityProbe,
        spec.capabilities.adapters.capability_probe.as_ref(),
    )?;
    Ok(bindings)
}

fn push_declared_binding<'a>(
    bindings: &mut Vec<(AdapterFamily, &'a AdapterBinding)>,
    family: AdapterFamily,
    binding: Option<&'a AdapterBinding>,
) -> Result<(), NodeServerError> {
    let Some(binding) = binding else {
        return Ok(());
    };
    if let Some((_, existing)) = bindings
        .iter()
        .find(|(existing_family, _)| *existing_family == family)
    {
        if *existing == binding {
            return Ok(());
        }
        return Err(NodeServerError::ProviderContractManifest(format!(
            "provider declares conflicting {family:?} adapter bindings"
        )));
    }
    bindings.push((family, binding));
    Ok(())
}

fn merge_durable_state(
    configured: &[WorkspaceConfig],
    mut loaded: LoadedNodeState,
) -> Result<(Vec<WorkspaceConfig>, Vec<ManagedSessionRecord>, Option<String>), NodeServerError> {
    let mut workspaces = configured
        .iter()
        .cloned()
        .map(|workspace| (workspace.workspace_id.clone(), workspace))
        .collect::<BTreeMap<_, _>>();
    let mut roots = workspaces
        .values()
        .map(|workspace| {
            (
                platform::root_identity(&workspace.canonical_root),
                workspace.workspace_id.clone(),
            )
        })
        .collect::<BTreeMap<_, _>>();
    let mut warning = loaded
        .warning
        .take()
        .map(|message| session_registry::sanitized_persistence_summary(&message));

    for (workspace_id, canonical_root) in loaded.workspaces {
        if let Some(existing) = workspaces.get(&workspace_id) {
            if !platform::roots_equal(&existing.canonical_root, &canonical_root) {
                return Err(NodeServerError::DurableState(io::Error::new(
                    io::ErrorKind::InvalidData,
                    DURABLE_STATE_CONFLICT_ERROR,
                )));
            }
            continue;
        }
        if roots.get(&platform::root_identity(&canonical_root)).is_some() {
            return Err(NodeServerError::DurableState(io::Error::new(
                io::ErrorKind::InvalidData,
                DURABLE_STATE_CONFLICT_ERROR,
            )));
        }
        if !Path::new(&canonical_root).is_dir() {
            warning.get_or_insert_with(|| {
                session_registry::DURABLE_STATE_WORKSPACE_WARNING.to_owned()
            });
            continue;
        }
        let workspace = WorkspaceConfig::new(workspace_id.clone(), &canonical_root).map_err(|_| {
            NodeServerError::DurableState(io::Error::new(
                io::ErrorKind::InvalidData,
                DURABLE_STATE_CONFLICT_ERROR,
            ))
        })?;
        roots.insert(
            platform::root_identity(&workspace.canonical_root),
            workspace.workspace_id.clone(),
        );
        workspaces.insert(workspace_id, workspace);
    }

    for record in &mut loaded.records {
        match workspaces.get(&record.workspace_id) {
            Some(workspace)
                if platform::roots_equal(
                    &workspace.canonical_root,
                    windows_path_text(&record.canonical_root),
                ) => {}
            Some(_) => {
                return Err(NodeServerError::DurableState(io::Error::new(
                    io::ErrorKind::InvalidData,
                    DURABLE_STATE_CONFLICT_ERROR,
                )));
            }
            None => {
                record.state = ManagedSessionState::Unavailable;
                record.active_session = None;
                record.last_error = Some(WORKSPACE_UNAVAILABLE_ERROR.to_owned());
            }
        }
    }
    Ok((workspaces.into_values().collect(), loaded.records, warning))
}

/// One entry of `NodeShared::rejected_command_reasons` -- see that field's
/// own doc for the mechanism this exists to close.
struct RejectedCommandReason {
    message: String,
    /// True when the kernel refused this command specifically because the
    /// agent does not declare the requested transport (`KernelCommandError::
    /// UnsupportedTransport`) -- lets the reader choose the named
    /// `NodeFailureCode::UnsupportedTransport` over the generic
    /// `BackendOperationFailed` bucket, so this one well-known rejection
    /// keeps its identity all the way to the operator wire.
    unsupported_transport: bool,
    expires_at: Instant,
}

struct NodeShared {
    handle: Gate4AgentHandle,
    access_token: String,
    node_id: NodeId,
    incarnation_id: NodeIncarnationId,
    started_at_unix_ms: u64,
    workspaces: RwLock<BTreeMap<WorkspaceId, String>>,
    worktree_service_modes: BTreeMap<WorkspaceId, WorktreeServiceMode>,
    managed_worktree_profiles:
        BTreeMap<WorkspaceId, BTreeMap<WorktreeProfileId, ManagedWorktreeProfile>>,
    managed_worktrees: Mutex<ManagedWorktreeRegistry>,
    enabled_providers: Vec<AgentId>,
    provider_runtime_statuses: ProviderRuntimeStatuses,
    provider_runtime_status_updates:
        RwLock<BTreeMap<AgentId, crate::protocol::ProviderRuntimeStatus>>,
    provider_runtime_monitor: Option<Arc<ProviderRuntimeMonitor>>,
    provider_contracts: Vec<ProviderContractSupport>,
    provider_adapter_contracts: Vec<ProviderAdapterContractSupport>,
    spawn_profiles: SpawnProfileRegistry,
    environment_profiles:
        RwLock<BTreeMap<SpawnEnvironmentProfileId, EnvironmentProfileBinding>>,
    environment_materialization_profiles:
        RwLock<BTreeMap<SpawnEnvironmentProfileId, NodeSessionMaterializationProfile>>,
    /// Station **network** allowlist catalog (opaque policy ids only).
    /// Empty by default — any `network_allowlist` on spawn must be registered
    /// here or resolve refuses with `UnknownNetworkAllowlist`. Optional
    /// startup load via `NodeServerConfig::with_network_allowlist_catalog(_file)`
    /// / env `GATE4AGENT_NODE_NETWORK_ALLOWLIST_CATALOG`. Plan
    /// `station-network-and-browser-profile-knobs-2026-10-02.md` §2.1 / §4.
    /// Never holds cookies / OAuth / proxy credentials.
    network_allowlist_catalog: RwLock<crate::network_allowlist_catalog::NetworkAllowlistCatalog>,
    /// Node-local exclusive dig2browser station profile leases (feature
    /// `dig2-station-probe`). Opaque `browser_profile_id` ↔ session holder;
    /// cleared on session end. Never ImportSession / cookies on C2.
    #[cfg(feature = "dig2-station-probe")]
    browser_station_leases: crate::dig2_station_lease::BrowserStationLeaseTable,
    bundle_catalog: RwLock<BundleCatalog>,
    delivery_store: Mutex<Option<DeliveryStore>>,
    context_pack_store: Mutex<Option<ContextPackStore>>,
    context_catalog: RwLock<ContextPackCatalog>,
    native_launch_profile_control: Option<NativeLaunchProfileControl>,
    harness_mcp_registry: Option<HarnessMcpProxyRegistry>,
    native_session_catalog: Option<Arc<Mutex<NativeSessionCatalogAuthority>>>,
    session_environment_materializer: Option<SessionEnvironmentMaterializer>,
    /// Per-session m4a accounts assigned at spawn (see [`crate::m4a_accounts`]).
    m4a_accounts: Option<crate::m4a_accounts::M4aSessionAccounts>,
    /// nick -> the session that holds that m4a account (for letter wakes).
    m4a_live: Mutex<BTreeMap<String, (AgentInstanceId, AgentId)>>,
    /// m4a session key per runtime this node gave an account.
    m4a_keys: Mutex<BTreeMap<AgentInstanceId, String>>,
    /// Keys a resume hands to its new runtime (same nick and mailbox).
    m4a_reuse_keys: Mutex<BTreeMap<AgentInstanceId, String>>,
    /// Per-session grok leader sockets (never the operator's shared leader).
    grok_leaders: Mutex<BTreeMap<AgentInstanceId, std::path::PathBuf>>,
    /// m4a signer proxy (option A): when set, PTY sessions get a process-bound handle
    /// instead of a bearer capability.
    #[cfg(unix)]
    signer_proxy: std::sync::OnceLock<Arc<crate::keystore_proxy::SignerProxy>>,
    materializations: Mutex<BTreeMap<MaterializationId, MaterializationOwnershipRecord>>,
    spawn_idempotency: Mutex<SpawnIdempotencyCache>,
    managed_spawn_replays:
        Mutex<BTreeMap<SpawnIdempotencyKey, ManagedWorktreeSpawnReplayRecordV10>>,
    controller: Mutex<Option<ControllerLease>>,
    /// Fresh spawns waiting for their first successful HQ attach. Removed on
    /// Resize/TerminalBytes (sessionize) or when the grace reaper stops them.
    provisional_spawns: Mutex<BTreeMap<AgentInstanceId, (SessionAddress, Instant)>>,
    /// ACP launch options waiting for the agent to advertise its config options.
    pending_acp_options: Mutex<BTreeMap<AgentInstanceId, (Option<String>, Option<String>)>>,
    history: Mutex<NodeEventHistory>,
    event_tx: broadcast::Sender<NodeEventEnvelope>,
    terminal_event_tx: broadcast::Sender<Arc<Vec<NodeEventEnvelope>>>,
    /// The outbound `NodeEvent::AgentStream` push channel -- its own
    /// dedicated, capability-gated broadcast, mirroring `terminal_event_tx`
    /// exactly rather than riding the durable `event_tx` history (see
    /// `publish`'s own assertion): a subscriber who never negotiated
    /// `NODE_AGENT_STREAM_EVENTS_CAPABILITY` must never receive one of
    /// these, the same guarantee `include_terminal_frame_events` already
    /// gives terminal frames.
    agent_stream_event_tx: broadcast::Sender<Arc<Vec<NodeEventEnvelope>>>,
    /// The outbound `NodeEvent::HarnessMcpReadCall` push channel -- mirrors
    /// `agent_stream_event_tx` exactly, its own dedicated, capability-gated
    /// broadcast rather than a ride on the durable `event_tx` history. A
    /// `HarnessMcpReadCall` is a request/response call a live proxy call is
    /// waiting on (`harness_mcp_proxy.rs`'s `begin_call`); the shared bus's
    /// finite capacity and its willingness to silently evict a lagging
    /// subscriber's backlog is exactly how the call vanished with neither
    /// side ever logging it (see `publish_transient`'s own doc).
    harness_mcp_proxy_event_tx: broadcast::Sender<Arc<Vec<NodeEventEnvelope>>>,
    terminal_frame_watermarks:
        Mutex<BTreeMap<AgentInstanceId, (SessionAddress, u64)>>,
    /// Wakes the drive loop as soon as PTY input is queued (no 10ms nap).
    pty_input_wake: tokio::sync::Notify,
    /// Per session: when the last PTY input was dispatched (latency probe +
    /// a short fast-poll window so the echo is published within ~1ms).
    pty_input_marks: Mutex<BTreeMap<AgentInstanceId, (Instant, bool)>>,
    /// Provider error classifier + retry state per session (see `provider_error`).
    provider_errors: Mutex<crate::provider_error::Tracker>,
    next_connection_id: AtomicU64,
    next_instance_id: AtomicU64,
    next_command_id: AtomicU64,
    shutdown: AtomicBool,
    shutdown_notify: Notify,
    preauth_slots: Arc<Semaphore>,
    authenticated_slots: Arc<Semaphore>,
    inspection_slots: Arc<Semaphore>,
    mutation_gate: AsyncMutex<()>,
    session_bindings: Mutex<BTreeMap<AgentInstanceId, SessionBinding>>,
    session_records: Mutex<SessionRecords>,
    state_path: Option<PathBuf>,
    persistence_error: RwLock<Option<String>>,
    state_transaction: Mutex<()>,
    input_settle_timeout_ms: u64,
    /// Drive-loop phase/rate timings -- see `drive_loop_profile`'s own doc
    /// comment. Written once per iteration by
    /// `drive_runtime_until_shutdown`, read by `GET /metrics`.
    drive_loop_profile: Mutex<DriveLoopProfiler>,
    /// Latest copy of `NativeRuntime::tick_profile_snapshot()` -- `Copy`,
    /// so an overwrite each iteration is cheap. The runtime itself is not
    /// reachable from here (it is owned locally by
    /// `drive_runtime_until_shutdown`), so this is how its own per-phase
    /// tick timings reach `GET /metrics`.
    runtime_tick_profile: Mutex<TickProfileSnapshot>,
    /// The live shell-efficiency profile, shared with the per-instance
    /// worker loops that fold into it.
    ///
    /// Deliberately NOT the per-iteration snapshot copy `runtime_tick_
    /// profile` above keeps: producing a snapshot sorts every ring behind
    /// it, and that sort belongs on the read. A `OnceLock` rather than a
    /// field set at construction because `NodeShared` is built before the
    /// `NativeRuntime` that owns the profile exists -- the drive loop
    /// publishes it once, before its first iteration. Unset means the
    /// runtime has not started driving yet, which `GET /metrics` reports as
    /// empty series rather than as zeroes it never measured.
    shell_efficiency_profile: OnceLock<Arc<Mutex<ShellEfficiencyProfile>>>,
    /// Physical PTY sessions the native runtime currently owns
    /// (`NativeRuntime::active_native_sessions`), refreshed once per drive
    /// loop iteration -- deliberately a separate count from
    /// `handle.snapshot().sessions.len()` (the control-plane kernel's own
    /// session bookkeeping), since the two can disagree and the gap is
    /// itself a diagnostic signal `GET /metrics` exposes.
    native_session_gauge: AtomicUsize,
    /// Lifetime totals for the per-connection serve loop, summed across
    /// every live connection.
    ///
    /// The drive loop's own phase timings account for about ten
    /// microseconds an iteration on an idle node, yet the process burns a
    /// quarter of a core — and burns it ONLY while a c2 is attached (0.5%
    /// with none, 23% with two, measured). That gap is somewhere in
    /// serving a connection, and there was no way to see it: iterations
    /// says whether the loop is spinning rather than sleeping, and events
    /// says whether it is spinning over real work or over nothing.
    connection_loop_iterations: AtomicU64,
    connection_events_sent: AtomicU64,
    /// Lifetime totals for `drive_runtime_until_shutdown`'s own iterations
    /// -- `drive_loop_iterations_idle` counts iterations that applied zero
    /// `NativeRuntime::tick` observations AND forwarded zero control
    /// events; see the exact "produced nothing" definition at the site in
    /// `drive_runtime_until_shutdown` that increments these. Read twice
    /// and divide by the interval, same rule as `connections` above --
    /// `idle / total` is backlog item 5's "wake on work" number.
    /// Lifetime count of control commands the kernel refused.
    rejected_commands_total: AtomicU64,
    /// The named reason behind a recent kernel rejection, by the
    /// `CommandId` `dispatch_bounded` handed back when it enqueued that
    /// command -- populated by `drive_runtime_until_shutdown` for every
    /// `Err` in a tick's `command_outcomes`, and drained by whichever
    /// spawn-dispatch waiter recognizes its own `Register`/`Start`
    /// `CommandId` among them.
    ///
    /// A `ControlCommand` only ever fails synchronously (a `NodeFailure`
    /// out of `dispatch`/`dispatch_bounded` itself) for a port-level ingress
    /// problem -- full or disconnected -- never for the kernel refusing the
    /// command's content (an unsupported transport, an unknown agent, ...);
    /// that verdict exists only once `NativeRuntime::tick` has processed the
    /// command, one drive-loop iteration later, in a different task than
    /// whichever caller is awaiting the spawn. Without this map, a spawn
    /// wait loop that polls `self.handle.snapshot()` for a session that
    /// will now never appear has no way to learn why -- it can only spin
    /// until its own commit deadline and report a generic "did not commit"
    /// timeout, discarding a reason the kernel already named precisely (see
    /// `KernelCommandError`'s variants, e.g. `UnsupportedTransport`).
    rejected_command_reasons: Mutex<BTreeMap<CommandId, RejectedCommandReason>>,
    drive_loop_iterations_total: AtomicU64,
    drive_loop_iterations_idle: AtomicU64,
    /// The operator-chosen age/keep-N policy the retention sweep applies to
    /// `ManagedSessionState::Unavailable` records. Both `0` by default --
    /// see `SessionRecordRetentionConfig`'s own doc comment.
    session_record_retention: SessionRecordRetentionConfig,
    /// Lifetime count of managed session records the retention sweep has
    /// retired. Same tier as `rejected_commands_total` above: a live,
    /// process-lifetime instrument, never persisted and never reloaded from
    /// `state-v1.json` -- a restart legitimately resets it, matching every
    /// other `*_total` counter here.
    retired_records_total: AtomicU64,
    #[cfg(feature = "fixture")]
    fixture_semantic_hook_policy: bool,
    #[cfg(feature = "fixture")]
    fixture_spawn_managed_worktree_v2_failure_probe: SpawnManagedWorktreeV2FailureProbe,
}

impl Drop for NodeShared {
    fn drop(&mut self) {
        SessionLifecycleHook::on_shutdown(self);
    }
}

#[derive(Clone, Debug, Eq, PartialEq)]
struct SessionBinding {
    workspace_id: WorkspaceId,
    generation: SessionGeneration,
    runtime_policy: ProviderRuntimePolicy,
    pending_resume: Option<(SessionGeneration, CommandId, ProviderRuntimePolicy)>,
    record_id: Option<SessionRecordId>,
    managed_worktree_lease_id: Option<ManagedWorktreeLeaseId>,
    environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
    bundle: Option<ResolvedBundleReceipt>,
    context: Option<ResolvedContextPackReceipt>,
    materialization_id: Option<MaterializationId>,
}

#[derive(Clone, Copy, Debug, Eq, PartialEq)]
enum SpawnRecordPolicy {
    ProviderIdentityOnly,
    Always,
}

struct NativeEnvironmentSelectionGuard {
    control: Option<NativeLaunchProfileControl>,
    instance_id: AgentInstanceId,
}

struct NativeInstanceOverlayGuard {
    control: Option<NativeLaunchProfileControl>,
    instance_id: AgentInstanceId,
}

struct NativeHarnessMcpOverlayGuard {
    control: NativeLaunchProfileControl,
    instance_id: AgentInstanceId,
}

impl NativeHarnessMcpOverlayGuard {
    fn retain(self) { std::mem::forget(self); }
}

impl Drop for NativeHarnessMcpOverlayGuard {
    fn drop(&mut self) {
        self.control
            .clear_native_mcp_server_launch_overlay(self.instance_id);
    }
}

impl NativeInstanceOverlayGuard {
    fn retain(mut self) {
        self.control = None;
    }
}

impl Drop for NativeInstanceOverlayGuard {
    fn drop(&mut self) {
        if let Some(control) = self.control.as_ref() {
            control.clear_native_instance_launch_overlay(self.instance_id);
        }
    }
}

enum PreparedNativeLaunchOverlay {
    Environment(NativeLaunchEnvironmentOverlay),
    Instance(NativeInstanceLaunchOverlay),
}

impl NativeEnvironmentSelectionGuard {
    fn retain(mut self) {
        self.control = None;
    }
}

impl Drop for NativeEnvironmentSelectionGuard {
    fn drop(&mut self) {
        if let Some(control) = self.control.as_ref() {
            control.clear_native_launch_profile_selection(self.instance_id);
        }
    }
}

struct SessionMaterializationGuard<'a> {
    shared: &'a NodeShared,
    id: Option<MaterializationId>,
    /// Absolute ProviderHome (`home/`) under the session materialization root.
    /// Used for Claude station network `--settings` sidecar writes.
    provider_home: Option<PathBuf>,
}

impl SessionMaterializationGuard<'_> {
    fn id(&self) -> Option<&MaterializationId> {
        self.id.as_ref()
    }

    fn provider_home(&self) -> Option<&Path> {
        self.provider_home.as_deref()
    }

    fn retain(mut self) {
        self.id = None;
    }
}

impl Drop for SessionMaterializationGuard<'_> {
    fn drop(&mut self) {
        if let Some(id) = self.id.take() {
            let _ = self.shared.cleanup_materialization(&id);
        }
    }
}


/// Port: product-side reactions to session lifecycle transitions
/// (station lease, harness MCP overlay/registry, environment launch overlays).
trait SessionLifecycleHook {
    /// A binding was removed (unbind or spawn rollback).
    fn on_binding_removed(&self, address: &SessionAddress, removed: Option<&SessionBinding>);
    /// A session reached a terminal control event that revokes its harness MCP door.
    fn on_session_ended(&self, address: &SessionAddress);
    /// Node shutdown (or drop): revoke every harness MCP reservation.
    fn on_shutdown(&self);
    /// A harness MCP reservation was aborted before activation.
    fn on_harness_reservation_aborted(&self, instance_id: AgentInstanceId);
    /// Release session-owned materialization for a removed binding.
    fn cleanup_session_materialization(
        &self,
        address: &SessionAddress,
        binding: &SessionBinding,
    ) -> Result<(), NodeFailure>;
}

impl SessionLifecycleHook for NodeShared {
    fn on_session_ended(&self, address: &SessionAddress) {
        self.retire_session_grok_leader(address.session.instance_id);
        if !self.shutdown.load(Ordering::Acquire) {
            if let Some(file) = self.session_resume_journal() {
                crate::pty_resume::remove(&file, address.session.instance_id.0);
            }
        }
        if let Some(accounts) = self.m4a_accounts.as_ref() {
            let instance = address.session.instance_id;
            let live = self.m4a_live.lock().unwrap_or_else(|p| p.into_inner());
            for (nick, _) in live.iter().filter(|(_, (i, _))| *i == instance) {
                accounts.remove_session_file(nick);
            }
        }
        if let Some(registry) = self.harness_mcp_registry.as_ref() {
            registry.revoke_session(address);
        }
        if let Some(control) = self.native_launch_profile_control.as_ref() {
            control.clear_native_mcp_server_launch_overlay(address.session.instance_id);
        }
    }

    fn on_shutdown(&self) {
        let leaders: Vec<_> = std::mem::take(&mut *self.grok_leaders.lock().unwrap_or_else(|p| p.into_inner()))
            .into_values()
            .collect();
        for socket in leaders {
            crate::grok_leader::retire(&socket);
        }
        if let Some(registry) = self.harness_mcp_registry.as_ref() {
            let instances = registry.shutdown();
            if let Some(control) = self.native_launch_profile_control.as_ref() {
                for instance_id in instances {
                    control.clear_native_mcp_server_launch_overlay(instance_id);
                }
            }
        }
    }

    fn on_harness_reservation_aborted(&self, instance_id: AgentInstanceId) {
        if let Some(control) = self.native_launch_profile_control.as_ref() {
            control.clear_native_mcp_server_launch_overlay(instance_id);
        }
    }

    fn cleanup_session_materialization(
        &self,
        address: &SessionAddress,
        binding: &SessionBinding,
    ) -> Result<(), NodeFailure> {
        self.cleanup_session_owned_materialization(address, binding)
    }

    fn on_binding_removed(&self, address: &SessionAddress, removed: Option<&SessionBinding>) {
        // Exclusive dig2browser station profile lease is node-local; clear
        // on every session unbind / rollback. Never ImportSession/cookies.
        #[cfg(feature = "dig2-station-probe")]
        {
            crate::dig2_station_lease::release_lease_for_holder(
                &self.browser_station_leases,
                address.session.instance_id,
            );
        }
        if let Some(control) = self.native_launch_profile_control.as_ref() {
            control.clear_native_mcp_server_launch_overlay(
                address.session.instance_id,
            );
        }
        if let Some(registry) = self.harness_mcp_registry.as_ref() {
            registry.revoke_session(address);
        }
        if removed
            .is_some_and(|binding| {
                binding.environment_profile.is_some()
                    || binding.bundle.is_some()
                    || binding.context.is_some()
            })
        {
            if let Some(control) = self.native_launch_profile_control.as_ref() {
                control.clear_native_launch_profile_selection(
                    address.session.instance_id,
                );
                control.clear_native_instance_launch_overlay(
                    address.session.instance_id,
                );
            }
        }
    }
}

struct SpawnPrepareRequest<'r> {
    instance_id: AgentInstanceId,
    address: &'r SessionAddress,
    provider: &'r AgentId,
    mode: SessionMode,
    environment_profile: Option<&'r ResolvedEnvironmentProfileReceipt>,
    bundle: Option<&'r ResolvedBundleReceipt>,
    context: Option<&'r ResolvedContextPackReceipt>,
    managed_authority: Option<&'r ManagedWorktreeLeaseId>,
    harness_mcp: Option<&'r PreparedHarnessMcpSpawn>,
    approval_level: ApprovalLevel,
    network_allowlist: Option<&'r crate::protocol::SpawnNetworkAllowlistId>,
    browser_profile_id: Option<crate::protocol::SpawnBrowserProfileId>,
}

/// Guards held between "session identity minted" and "launch committed".
/// Field order is the drop order and matches the pre-refactor local order
/// (instance overlay, environment selection, materialization, harness, station lease).
struct PreparedSpawn<'a> {
    instance_overlay: Option<NativeInstanceOverlayGuard>,
    environment_selection: Option<NativeEnvironmentSelectionGuard>,
    materialization_guard: Option<SessionMaterializationGuard<'a>>,
    harness_mcp_overlay: Option<NativeHarnessMcpOverlayGuard>,
    #[cfg(feature = "dig2-station-probe")]
    browser_station_lease_guard: Option<crate::dig2_station_lease::BrowserStationLeaseGuard>,
    materialization_id: Option<MaterializationId>,
}

impl PreparedSpawn<'_> {
    /// Session-owned launch state now belongs to the binding.
    fn retain_session_guards(&mut self) {
        if let Some(selection) = self.environment_selection.take() {
            selection.retain();
        }
        if let Some(overlay) = self.instance_overlay.take() {
            overlay.retain();
        }
        if let Some(guard) = self.materialization_guard.take() {
            guard.retain();
        }
    }

    /// Launch committed: keep harness overlay and station lease for the session lifetime.
    fn retain_launch_guards(&mut self) {
        if let Some(overlay) = self.harness_mcp_overlay.take() {
            overlay.retain();
        }
        #[cfg(feature = "dig2-station-probe")]
        if let Some(guard) = self.browser_station_lease_guard.take() {
            guard.retain();
        }
    }
}

/// Port: everything product-side that must be prepared before a session is
/// bound and started (station lease, harness MCP overlay, materialization,
/// environment selection, network overlays, launch overlay).
trait SpawnPreparer {
    fn prepare<'a>(&'a self, request: SpawnPrepareRequest<'_>) -> Result<PreparedSpawn<'a>, NodeFailure>;
    /// Select the native launch profile for an environment-profile session.
    fn select_environment(
        &self,
        instance_id: AgentInstanceId,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
    ) -> Result<Option<NativeEnvironmentSelectionGuard>, NodeFailure>;
    /// Install a prepared launch overlay for the instance.
    fn install_launch_overlay(
        &self,
        instance_id: AgentInstanceId,
        overlay: PreparedNativeLaunchOverlay,
    ) -> Result<Option<NativeInstanceOverlayGuard>, NodeFailure>;
}

impl NodeShared {
    /// m4a session key of a new runtime: a resume reuses the key (and so the nick and mailbox)
    /// of the runtime it replaces; a fresh spawn gets `<incarnation>-<instance>`.
    fn m4a_session_key(&self, instance_id: AgentInstanceId) -> String {
        let reused = self.m4a_reuse_keys.lock().unwrap_or_else(|p| p.into_inner()).remove(&instance_id);
        let key = reused.unwrap_or_else(|| format!("{}-{}", self.incarnation_id, instance_id.0));
        self.m4a_keys.lock().unwrap_or_else(|p| p.into_inner()).insert(instance_id, key.clone());
        if let Some(file) = self.session_resume_journal() {
            crate::pty_resume::set_session_key(&file, instance_id.0, &key);
        }
        key
    }

    fn session_workdir(&self, root: &std::path::Path, instance_id: AgentInstanceId, provider: &AgentId) -> Option<std::path::PathBuf> {
        let accounts = self.m4a_accounts.as_ref()?;
        let nick = self.m4a_nick_of(instance_id)?;
        match accounts.session_workdir(root, provider.as_str(), &nick) {
            Ok(dir) => dir,
            Err(error) => {
                tracing::warn!(%nick, %error, "session folder not prepared; the session runs in the workspace root");
                None
            }
        }
    }

    fn m4a_nick_of(&self, instance_id: AgentInstanceId) -> Option<String> {
        self.m4a_live.lock().unwrap_or_else(|p| p.into_inner()).iter().find(|(_, (i, _))| *i == instance_id).map(|(n, _)| n.clone())
    }

    /// The managed record of a node session carries its m4a nick as its name (HQ shows it,
    /// `/api/spawn` returns it).
    fn name_record_after_nick(&self, instance_id: AgentInstanceId, nick: &str) {
        let mut records = self.session_records.lock().unwrap_or_else(|p| p.into_inner());
        for record in records.records.values_mut() {
            if record.active_session.as_ref().is_some_and(|a| a.session.instance_id == instance_id) {
                record.display_name = nick.to_owned();
            }
        }
    }

    /// Gives a node session its own m4a account: identity env, session file, MCP entry and
    /// the mailbox listener that wakes it.
    fn m4a_session_overlay(
        &self,
        accounts: &crate::m4a_accounts::M4aSessionAccounts,
        m4a_provider: &str,
        provider: &AgentId,
        instance_id: AgentInstanceId,
        environment_overlay: Option<PreparedNativeLaunchOverlay>,
        session_key: &str,
        mode: SessionMode,
    ) -> Result<Option<PreparedNativeLaunchOverlay>, NodeFailure> {
        let session_key = session_key.to_owned();
        if mode == SessionMode::Acp {
            return self.m4a_acp_mcp_overlay(accounts, m4a_provider, provider, instance_id, environment_overlay, &session_key);
        }
        Ok(                match accounts.provision(m4a_provider, &session_key) {
                    Ok(account) => {
                        crate::pty_resume::note_account_ref(&session_key, &account.session_id);
                        let mut identity = account.env_mutations();
                        identity.extend(crate::m4a_accounts::provider_session_env(provider.as_str()));
                        let merged = match environment_overlay {
                            None => NativeInstanceLaunchOverlay::new_session_identity(provider.clone(), identity)
                                .map(PreparedNativeLaunchOverlay::Instance),
                            Some(PreparedNativeLaunchOverlay::Instance(mut overlay)) => {
                                overlay.append_session_identity(identity).map(|()| PreparedNativeLaunchOverlay::Instance(overlay))
                            }
                            Some(PreparedNativeLaunchOverlay::Environment(mut overlay)) => {
                                overlay.append_session_identity(identity).map(|()| PreparedNativeLaunchOverlay::Environment(overlay))
                            }
                        }
                        .map_err(|_| failure(NodeFailureCode::BackendOperationFailed, "m4a session account overlay is invalid"))?;
                        tracing::info!(provider = %provider, instance_id = ?instance_id, nick = %account.nick, "m4a session account assigned at spawn");
                        let mut merged = merged;
                        match accounts.write_session_file(&account) {
                            Err(error) => tracing::warn!(nick = %account.nick, %error, "m4a session file not written"),
                            Ok(_) => match accounts.mcp_launch_args(provider.as_str(), &account.nick) {
                                Ok(args) if !args.is_empty() => {
                                    merged = match merged {
                                        PreparedNativeLaunchOverlay::Instance(mut overlay) => overlay
                                            .append_extra_args(args)
                                            .map(|()| PreparedNativeLaunchOverlay::Instance(overlay))
                                            .map_err(|_| failure(NodeFailureCode::BackendOperationFailed, "m4a mcp overlay is invalid"))?,
                                        PreparedNativeLaunchOverlay::Environment(overlay) => overlay
                                            .into_instance_with_extra_args(args)
                                            .map(PreparedNativeLaunchOverlay::Instance)
                                            .map_err(|_| failure(NodeFailureCode::BackendOperationFailed, "m4a mcp overlay is invalid"))?,
                                    };
                                    tracing::info!(nick = %account.nick, "m4a mcp server delivered at spawn");
                                }
                                Ok(_) => {}
                                Err(error) => tracing::warn!(nick = %account.nick, %error, "m4a mcp server not delivered"),
                            },
                        }
                        self.m4a_live
                            .lock()
                            .unwrap_or_else(|p| p.into_inner())
                            .insert(account.nick.clone(), (instance_id, provider.clone()));
                        self.name_record_after_nick(instance_id, &account.nick);
                        tracing::info!(nick = %account.nick, instance = instance_id.0, "m4a nick bound to session");
                        // Letters to this account wake the session: the node listens on its mailbox.
                        crate::m4a_wake::watch_spawned(provider.as_str(), &account.nick, &account.session_id, account.store_root.as_deref(), None);
                        Some(merged)
                    }
                    Err(error) => {
                        tracing::warn!(provider = %provider, instance_id = ?instance_id, %error, "m4a session account not assigned");
                        environment_overlay
                    }
                })
    }
}

impl NodeShared {
    /// ACP has no env/argv overlay for this: the session's m4a account rides as an MCP server
    /// handed to the agent in session/new, with the account env on that server only.
    fn m4a_acp_mcp_overlay(
        &self,
        accounts: &crate::m4a_accounts::M4aSessionAccounts,
        m4a_provider: &str,
        provider: &AgentId,
        instance_id: AgentInstanceId,
        environment_overlay: Option<PreparedNativeLaunchOverlay>,
        session_key: &str,
    ) -> Result<Option<PreparedNativeLaunchOverlay>, NodeFailure> {
        let Some(control) = self.native_launch_profile_control.as_ref() else {
            tracing::warn!(%provider, "m4a acp account not assigned: no launch profile control");
            return Ok(environment_overlay);
        };
        let account = match accounts.provision(m4a_provider, session_key) {
            Ok(a) => a,
            Err(error) => {
                tracing::warn!(%provider, instance_id = ?instance_id, %error, "m4a session account not assigned");
                return Ok(environment_overlay);
            }
        };
        let session_file = match accounts.write_session_file(&account) {
            Ok(p) => p,
            Err(error) => {
                tracing::warn!(nick = %account.nick, %error, "m4a session file not written");
                return Ok(environment_overlay);
            }
        };
        let env_entries: Vec<(OsString, OsString)> = account
            .env_mutations()
            .into_iter()
            .chain(crate::m4a_accounts::provider_session_env(provider.as_str()))
            .filter_map(|m| m.value.map(|v| (m.key, v)))
            .collect();
        let args: Vec<OsString> = vec![
            "--session-file".into(),
            session_file.into_os_string(),
            "mcp".into(),
            "--provider".into(),
            provider.as_str().into(),
        ];
        let overlay = NativeMcpServerLaunchOverlay::new(
            provider.clone(),
            crate::m4a_accounts::mcp_server_name(provider.as_str()).as_str(),
            accounts.bin().as_os_str().to_os_string(),
            args,
            env_entries,
            Vec::new(),
        );
        match overlay.map_err(|e| e.to_string()).and_then(|o| control.install_native_mcp_server_launch_overlay(instance_id, o).map_err(|e| e.to_string())) {
            Ok(_) => tracing::info!(nick = %account.nick, instance = instance_id.0, "m4a mcp server delivered over acp"),
            Err(error) => {
                tracing::warn!(nick = %account.nick, %error, "m4a acp mcp server not delivered");
                return Ok(environment_overlay);
            }
        }
        self.m4a_live
            .lock()
            .unwrap_or_else(|p| p.into_inner())
            .insert(account.nick.clone(), (instance_id, provider.clone()));
        self.name_record_after_nick(instance_id, &account.nick);
        crate::m4a_wake::watch_spawned(provider.as_str(), &account.nick, &account.session_id, account.store_root.as_deref(), None);
        Ok(environment_overlay)
    }
}

impl SpawnPreparer for NodeShared {
    fn select_environment(
        &self,
        instance_id: AgentInstanceId,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
    ) -> Result<Option<NativeEnvironmentSelectionGuard>, NodeFailure> {
        self.select_environment_profile(instance_id, provider, mode, environment_profile)
    }

    fn install_launch_overlay(
        &self,
        instance_id: AgentInstanceId,
        overlay: PreparedNativeLaunchOverlay,
    ) -> Result<Option<NativeInstanceOverlayGuard>, NodeFailure> {
        self.install_prepared_launch_overlay(instance_id, overlay)
    }

    fn prepare<'a>(&'a self, request: SpawnPrepareRequest<'_>) -> Result<PreparedSpawn<'a>, NodeFailure> {
        let SpawnPrepareRequest {
            instance_id,
            address,
            provider,
            mode,
            environment_profile,
            bundle,
            context,
            managed_authority,
            harness_mcp,
            approval_level,
            network_allowlist,
            browser_profile_id,
        } = request;
        // Track A follow-on: exclusive node-local BrowserStationLease after
        // dig2 probe (feature dig2-station-probe). Opaque profile id only —
        // never ImportSession / cookies on C2. Linux/feature-off: probe
        // already refused or stub; this block is cfg'd out when feature off.
        #[cfg(feature = "dig2-station-probe")]
        let mut browser_station_lease_guard = if let Some(profile_id) = browser_profile_id {
            use crate::dig2_station_lease::{acquire_lease, BrowserStationLeaseError};
            match acquire_lease(
                &self.browser_station_leases,
                profile_id,
                instance_id,
                unix_time_ms(),
            ) {
                Ok(guard) => Some(guard),
                Err(BrowserStationLeaseError::ProfileBusy { .. }) => {
                    return Err(failure(
                        NodeFailureCode::BrowserStationProfileBusy,
                        "dig2browser station profile is already leased by another session",
                    ));
                }
                Err(BrowserStationLeaseError::CapacityExceeded) => {
                    return Err(failure(
                        NodeFailureCode::BrowserStationProfileBusy,
                        "dig2browser station profile lease capacity exhausted",
                    ));
                }
                Err(BrowserStationLeaseError::HolderAlreadyLeased) => {
                    return Err(failure(
                        NodeFailureCode::BrowserStationProfileBusy,
                        "session already holds a dig2browser station profile lease",
                    ));
                }
            }
        } else {
            None
        };
        #[cfg(not(feature = "dig2-station-probe"))]
        let _ = browser_profile_id;
        let mut harness_mcp_overlay = if let Some(prepared) = harness_mcp {
            // Slice A(ii) of gate4agent-arc-mailbox-and-task-layer: the door
            // exists for PTY (env vars) and ACP (`session/new.mcpServers`,
            // `gate4agent-shell-native`'s `mcp_server_acp_entry`) alike --
            // both read the identical overlay resolved below, one as child
            // environment, the other translated into one stdio MCP server
            // entry. `Inline`/`Pipe` stays refused: this arc's proof is ACP
            // only, and nothing downstream reads a harness-MCP overlay for
            // that transport yet.
            if !matches!(mode, SessionMode::Pty | SessionMode::Acp) || prepared.provider != *provider
            {
                return Err(failure(
                    NodeFailureCode::BindingMismatch,
                    "harness MCP reservation does not match the exact PTY/ACP provider",
                ));
            }
            prepared.verify_helper_program().map_err(harness_mcp_failure)?;
            let control = self.native_launch_profile_control.clone().ok_or_else(|| {
                failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP launch control is unavailable")
            })?;
            // Every name below is the caller's, carried in the reservation's
            // launch description: which environment variables receive the
            // endpoint, token and helper program, what the MCP server is called,
            // which argv it gets and which stale variables are erased.
            let launch = prepared.launch();
            let mut env_entries = vec![
                (
                    OsString::from(launch.endpoint_env.as_str()),
                    prepared.endpoint().as_os_str().to_os_string(),
                ),
                (
                    OsString::from(launch.token_env.as_str()),
                    prepared.token().expose().into(),
                ),
                (
                    OsString::from(launch.program_env.as_str()),
                    prepared.helper_program().as_os_str().to_os_string(),
                ),
            ];
            if let Some(trace_entry) = harness_mcp_trace_env_entry(launch) {
                env_entries.push(trace_entry);
            }
            if let Some(door) = crate::door::door_listen_addr() {
                env_entries.push((
                    OsString::from("HATCHERY_NODE_DOOR"),
                    OsString::from(door.to_string()),
                ));
                // Same key shape as HQ browser/draft ids:
                // `pty-{incarnation}-{workspace}-{instance}` — never reuse a
                // slot across node boots when the instance counter resets.
                let session_key = format!(
                    "pty-{}-{}-{}",
                    self.incarnation_id,
                    address.workspace_id.as_str(),
                    address.session.instance_id.0
                );
                env_entries.push((
                    OsString::from("HATCHERY_LOCAL_SERVER_SESSION"),
                    OsString::from(session_key),
                ));
            }
            let overlay = NativeMcpServerLaunchOverlay::new(
                provider.clone(),
                launch.server_name.as_str(),
                prepared.helper_program().as_os_str().to_os_string(),
                launch.args.iter().map(OsString::from).collect(),
                env_entries,
                launch.scrub_env.iter().map(OsString::from).collect(),
            ).map_err(|_| failure(
                NodeFailureCode::HarnessMcpUnavailable,
                "harness MCP launch overlay is unavailable",
            ))?;
            control
                .install_native_mcp_server_launch_overlay(instance_id, overlay)
                .map_err(|_| failure(
                    NodeFailureCode::HarnessMcpUnavailable,
                    "harness MCP launch overlay could not be installed",
                ))?;
            // State-change line: the overlay is installed and will be read
            // back by the PTY child's environment or, for ACP,
            // `gate4agent-shell-native`'s `mcp_server_acp_entry` at spawn
            // time -- no secrets here, only which instance/provider/mode
            // now carries a harness-MCP door.
            tracing::info!(
                node_id = %self.node_id,
                instance_id = ?instance_id,
                provider = %provider,
                mode = ?mode,
                "harness MCP overlay installed for spawn",
            );
            Some(NativeHarnessMcpOverlayGuard { control, instance_id })
        } else {
            None
        };
        let prepared_materialization = self.prepare_session_materialization(
            &address,
            &provider,
            mode,
            environment_profile,
            bundle,
            context,
            managed_authority.cloned(),
        )?;
        let (environment_overlay, mut materialization_guard) = match prepared_materialization {
            Some((overlay, guard)) => (Some(overlay), Some(guard)),
            None => (None, None),
        };
        let materialization_id = materialization_guard
            .as_ref()
            .and_then(SessionMaterializationGuard::id)
            .cloned();
        let mut environment_selection = SpawnPreparer::select_environment(self, 
            instance_id,
            &provider,
            mode,
            environment_profile,
        )?;
        // Station network overlays: Codex `-c network_access` and/or Claude
        // ProviderHome `--settings` sidecar (permits → allowedDomains).
        let provider_home = materialization_guard
            .as_ref()
            .and_then(SessionMaterializationGuard::provider_home);
        let network_overlay_args = self.resolve_network_allowlist_overlay_args(
            &provider,
            mode,
            approval_level,
            network_allowlist,
            provider_home,
        )?;
        let mut network_overlay_args = network_overlay_args;
        // Auto-permit (default on): pre-trust cwd / onboarding in provider config + auto/yolo flags.
        {
            let cwd = self.workspace_root(&address.workspace_id).ok().map(PathBuf::from);
            let mut homes: Vec<PathBuf> = std::env::var_os("HOME").map(PathBuf::from).into_iter().collect();
            if let Some(extra) = std::env::var_os("HATCHERY_PROVIDER_HOMES") {
                homes.extend(std::env::split_paths(&extra));
            }
            if let Some(h) = provider_home { homes.push(h.to_path_buf()); }
            crate::auto_permit::prepare(provider.as_str(), &homes, cwd.as_deref());
            network_overlay_args.extend(crate::auto_permit::launch_args(provider.as_str(), mode));
        }
        if mode == SessionMode::Acp && crate::auto_permit::acp_auto_approve(provider.as_str()) {
            crate::auto_permit::register_acp(instance_id.0, provider.as_str());
        }
        // Session registry: journal the session so it is resumed after a node restart.
        if matches!(mode, SessionMode::Pty | SessionMode::Acp) && crate::pty_resume::enabled() && crate::pty_resume::supported(provider.as_str()) {
            if let Some(file) = self.session_resume_journal() {
                crate::pty_resume::upsert(&file, crate::pty_resume::Entry {
                    instance_id: instance_id.0,
                    provider: provider.as_str().to_owned(),
                    workspace_id: address.workspace_id.as_str().to_owned(),
                    provider_session_id: String::new(),
                    session_key: self.m4a_keys.lock().unwrap_or_else(|p| p.into_inner()).get(&instance_id).cloned()
                        .or_else(|| self.m4a_reuse_keys.lock().unwrap_or_else(|p| p.into_inner()).get(&instance_id).cloned())
                        .unwrap_or_else(|| format!("{}-{}", self.incarnation_id, instance_id.0)),
                    cwd: String::new(),
                    acp: mode == SessionMode::Acp,
                    options: SPAWN_SESSION_OPTIONS.try_with(|o| o.clone()).ok().flatten(),
                    cols: 0,
                    rows: 0,
                    origin: SPAWN_ORIGIN.try_with(|o| o.clone()).ok().flatten(),
                    parent_session_id: SPAWN_PARENT.try_with(|o| o.clone()).ok().flatten(),
                });
                if let Some(dir) = file.parent() {
                    crate::session_meta::upsert(dir, instance_id.0, crate::session_meta::Meta {
                        origin: SPAWN_ORIGIN.try_with(|o| o.clone()).ok().flatten(),
                        parent_session_id: SPAWN_PARENT.try_with(|o| o.clone()).ok().flatten(),
                        provider: Some(provider.as_str().to_owned()),
                        ..crate::session_meta::Meta::default()
                    });
                    crate::session_meta::revive(dir, instance_id.0);
                }
                tracing::info!(instance_id = instance_id.0, provider = %provider, "session journalled for restart resume");
            }
        }
        if let Some(socket) = self.session_grok_leader_socket(&provider, mode, instance_id) {
            network_overlay_args.extend(crate::grok_leader::leader_socket_args(&socket));
        }
        let environment_overlay = match (environment_overlay.flatten(), network_overlay_args) {
            (prepared, args) if args.is_empty() => prepared,
            (Some(PreparedNativeLaunchOverlay::Instance(mut overlay)), args) => {
                overlay.append_extra_args(args).map_err(|_| {
                    failure(
                        NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                        "network allowlist overlay could not merge with instance launch args",
                    )
                })?;
                Some(PreparedNativeLaunchOverlay::Instance(overlay))
            }
            (Some(PreparedNativeLaunchOverlay::Environment(overlay)), args) => {
                Some(PreparedNativeLaunchOverlay::Instance(
                    overlay
                        .into_instance_with_extra_args(args)
                        .map_err(|_| {
                            failure(
                                NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                                "network allowlist overlay could not merge with environment overlay",
                            )
                        })?,
                ))
            }
            (None, args) => Some(PreparedNativeLaunchOverlay::Instance(
                NativeInstanceLaunchOverlay::new(
                    provider.clone(),
                    match mode {
                        SessionMode::Pty => TransportKind::Pty,
                        SessionMode::Acp => TransportKind::Acp,
                        SessionMode::Inline => TransportKind::Pipe,
                    },
                    Vec::new(),
                    args,
                )
                .map_err(|_| {
                    failure(
                        NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                        "network allowlist overlay is invalid for this transport",
                    )
                })?,
            )),
        };
        // Per-session m4a account: own nick + capability for this PTY child only, on its own
        // overlay or appended to the overlay the spawn already carries.
        #[cfg(unix)]
        // `HATCHERY_M4A_SIGNER_SHELL=1` also gives operator shells an identity (live canaries).
        let signer_provider = crate::m4a_accounts::m4a_provider(provider.as_str()).or_else(|| {
            (provider.as_str() == "shell" && std::env::var_os("HATCHERY_M4A_SIGNER_SHELL").is_some_and(|v| v == "1")).then_some("shell")
        });
        #[cfg(unix)]
        // A provider session with its own m4a account (MCP server + cap) takes that path; the
        // signer handle is for sessions without one (operator shells).
        let signer_provider = signer_provider.filter(|p| *p == "shell" || self.m4a_accounts.is_none());
        #[cfg(unix)]
        let signer_identity = match (mode, self.signer_proxy.get(), signer_provider) {
            (SessionMode::Pty, Some(proxy), Some(m4a_provider)) => {
                let session_key = format!("{}-{}", self.incarnation_id, instance_id.0);
                let uid = unsafe { libc_geteuid() };
                let handle = proxy.reserve(&session_key, m4a_provider, uid);
                let sock = std::env::var_os(crate::keystore_proxy::SOCKET_ENV).unwrap_or_default();
                tracing::info!(provider = %provider, instance_id = ?instance_id, "m4a signer handle reserved at spawn");
                Some(vec![
                    gate4agent_catalog::EnvMutation { key: std::ffi::OsString::from(crate::keystore_proxy::HANDLE_ENV), value: Some(std::ffi::OsString::from(handle)) },
                    gate4agent_catalog::EnvMutation { key: std::ffi::OsString::from(crate::keystore_proxy::SOCKET_ENV), value: Some(sock) },
                    gate4agent_catalog::EnvMutation { key: std::ffi::OsString::from("M4A_SESSION_ID"), value: Some(std::ffi::OsString::from(session_key)) },
                ])
            }
            _ => None,
        };
        #[cfg(not(unix))]
        let signer_identity: Option<Vec<gate4agent_catalog::EnvMutation>> = None;
        let environment_overlay = match (mode, self.m4a_accounts.as_ref(), crate::m4a_accounts::m4a_provider(provider.as_str()), signer_identity) {
            (SessionMode::Pty, _, _, Some(identity)) => {
                let merged = match environment_overlay {
                    None => NativeInstanceLaunchOverlay::new_session_identity(provider.clone(), identity).map(PreparedNativeLaunchOverlay::Instance),
                    Some(PreparedNativeLaunchOverlay::Instance(mut overlay)) => {
                        overlay.append_session_identity(identity).map(|()| PreparedNativeLaunchOverlay::Instance(overlay))
                    }
                    Some(PreparedNativeLaunchOverlay::Environment(mut overlay)) => {
                        overlay.append_session_identity(identity).map(|()| PreparedNativeLaunchOverlay::Environment(overlay))
                    }
                }
                .map_err(|_| failure(NodeFailureCode::BackendOperationFailed, "m4a signer handle overlay is invalid"))?;
                Some(merged)
            }
            (SessionMode::Pty | SessionMode::Acp, Some(accounts), Some(m4a_provider), None) => {
                let session_key = self.m4a_session_key(instance_id);
                self.m4a_session_overlay(accounts, m4a_provider, provider, instance_id, environment_overlay, &session_key, mode)?
            }
            (SessionMode::Pty, Some(_), None, _) => {
                tracing::warn!(provider = %provider, instance_id = ?instance_id, "m4a session account not assigned: provider has no m4a mapping");
                environment_overlay
            }
            _ => environment_overlay,
        };
        let mut instance_overlay = environment_overlay
            .map(|overlay| SpawnPreparer::install_launch_overlay(self, instance_id, overlay))
            .transpose()?
            .flatten();
        Ok(PreparedSpawn {
            instance_overlay,
            environment_selection,
            materialization_guard,
            harness_mcp_overlay,
            #[cfg(feature = "dig2-station-probe")]
            browser_station_lease_guard,
            materialization_id,
        })
    }
}

struct SessionRecords {
    records: BTreeMap<SessionRecordId, ManagedSessionRecord>,
}

struct SpawnIdempotencyCache {
    entries: BTreeMap<SpawnIdempotencyKey, SpawnIdempotencyEntry>,
}

struct SpawnIdempotencyEntry {
    value: SpawnIdempotencyValue,
    expires_at: Instant,
}

enum SpawnIdempotencyValue {
    Standard {
        spec: SpawnSpec,
        result: Result<ResolvedSpawnReceipt, NodeFailure>,
    },
    Managed {
        request: ManagedWorktreeSpawnRequest,
        result: Result<ManagedWorktreeSpawnReceipt, NodeFailure>,
    },
    HarnessMcp,
}

enum DurableManagedSpawnReplayDecision {
    Reserved,
    PendingLinked,
    Committed(ManagedWorktreeSpawnReceipt),
}

impl SpawnIdempotencyValue {
    fn references_context(&self, context_id: &SpawnContextId) -> bool {
        match self {
            Self::Standard { result, .. } => result
                .as_ref()
                .ok()
                .and_then(|receipt| receipt.context.as_ref()),
            Self::Managed { result, .. } => result
                .as_ref()
                .ok()
                .and_then(|receipt| receipt.spawn.context.as_ref()),
            Self::HarnessMcp => None,
        }
        .is_some_and(|receipt| &receipt.id == context_id)
    }
}

#[derive(Clone, Copy)]
struct ControllerLease {
    connection_id: u64,
    expires_at: Instant,
}

struct NodeEventHistory {
    last_sequence: u64,
    replay_floor_sequence: u64,
    events: VecDeque<NodeEventEnvelope>,
    record_providers: BTreeMap<SessionRecordId, AgentId>,
    removed_record_providers: BTreeMap<u64, AgentId>,
}

impl NodeEventHistory {
    fn new(record_providers: BTreeMap<SessionRecordId, AgentId>) -> Self {
        Self {
            last_sequence: 0,
            replay_floor_sequence: 1,
            events: VecDeque::with_capacity(NODE_EVENT_HISTORY_MAX),
            record_providers,
            removed_record_providers: BTreeMap::new(),
        }
    }
}

impl NodeShared {
    /// A node-spawned grok PTY session gets its own leader socket, so its agent backend runs
    /// as a descendant of this session's process (with the session's own environment) and
    /// never attaches to an operator's shared leader. Same grok home, same login.
    fn session_resume_journal(&self) -> Option<PathBuf> {
        self.state_path.as_ref().and_then(|p| p.parent()).map(crate::pty_resume::path)
    }

    /// Node start: resume every journalled session through its provider's resume path,
    /// under its old instance number, so HQ shows the same chat.
    async fn restore_journalled_sessions(&self) {
        let Some(file) = self.session_resume_journal() else { return };
        if !crate::pty_resume::enabled() { return; }
        for e in crate::pty_resume::load(&file) {
            crate::pty_resume::remove(&file, e.instance_id);
            // Same m4a session key as before the restart: the session keeps its account and nick.
            if !e.session_key.is_empty() {
                self.m4a_reuse_keys.lock().unwrap_or_else(|p| p.into_inner()).insert(AgentInstanceId(e.instance_id), e.session_key.clone());
            }
            let (Ok(ws), Ok(provider)) = (WorkspaceId::new(e.workspace_id.clone()), AgentId::new(e.provider.clone())) else { continue };
            if e.acp {
                let record_id = {
                    let records = self.session_records.lock().unwrap_or_else(|p| p.into_inner());
                    records.records.values().find(|r| r.mode == SessionMode::Acp && r.provider_session.as_ref().is_some_and(|i| !e.provider_session_id.is_empty() && i.id == e.provider_session_id)).map(|r| r.record_id.clone())
                };
                let cur = self.next_instance_id.load(Ordering::Acquire);
                if e.instance_id >= cur { self.next_instance_id.store(e.instance_id, Ordering::Release); }
                let size = gate4agent_types::TerminalSize { rows: 40, columns: 120 };
                let resumed = match record_id {
                    Some(rid) => SPAWN_SESSION_OPTIONS.scope(e.options.clone(), self.resume_session_record(&rid, size, None)).await.map(|(_, a)| a),
                    None => Err(failure(NodeFailureCode::SessionRecordNotResumable, "no record")),
                };
                // An agent without ACP session/load (claude) cannot resume: same number, fresh chat.
                let r = match resumed {
                    Ok(a) => Ok(a),
                    Err(err) => {
                        tracing::info!(instance_id = e.instance_id, message = %err.message, "acp resume unavailable; starting fresh under the same number");
                        self.next_instance_id.store(e.instance_id.max(self.next_instance_id.load(Ordering::Acquire).min(e.instance_id)), Ordering::Release);
                        SPAWN_SESSION_OPTIONS.scope(e.options.clone(), self.spawn_session(ws, provider, SessionMode::Acp, size, None)).await
                    }
                };
                match r {
                    Ok(addr) => tracing::info!(instance_id = addr.session.instance_id.0, provider = %e.provider, "journalled acp session restored"),
                    Err(err) => tracing::warn!(instance_id = e.instance_id, provider = %e.provider, message = %err.message, "journalled acp session restore failed"),
                }
                continue;
            }
            if e.provider_session_id.is_empty() || !provider_session_exists(&e.provider, &e.provider_session_id) {
                // Nothing said yet in that chat: start it fresh under the same number.
                let cur = self.next_instance_id.load(Ordering::Acquire);
                if e.instance_id >= cur { self.next_instance_id.store(e.instance_id, Ordering::Release); }
                let size = gate4agent_types::TerminalSize { rows: 40, columns: 120 };
                match SPAWN_SESSION_OPTIONS.scope(e.options.clone(), self.spawn_session(ws, provider, SessionMode::Pty, size, None)).await {
                    Ok(addr) => tracing::info!(instance_id = addr.session.instance_id.0, provider = %e.provider, "journalled session had no transcript; started fresh"),
                    Err(err) => tracing::warn!(instance_id = e.instance_id, provider = %e.provider, message = %err.message, "journalled session restart failed"),
                }
                continue;
            }
            let folder = std::path::Path::new(&e.cwd);
            let in_session_dir = folder.parent().and_then(|p| p.file_name()).is_some_and(|n| n == ".hatchery-sessions");
            let name = match (in_session_dir, folder.file_name()) {
                (true, Some(n)) => n.to_string_lossy().into_owned(),
                _ => format!("{} #{}", e.provider, e.instance_id),
            };
            let identity = ProviderSessionIdentity { key: gate4agent_types::ProviderSessionKey::SessionId, id: e.provider_session_id.clone(), transcript_path: None };
            let record = match self.index_provider_session(ws, provider, identity, name) {
                Ok(r) => r,
                Err(err) => { tracing::warn!(instance_id = e.instance_id, message = %err.message, "journalled session not indexed"); continue; }
            };
            let cur = self.next_instance_id.load(Ordering::Acquire);
            if e.instance_id >= cur { self.next_instance_id.store(e.instance_id, Ordering::Release); }
            let size = gate4agent_types::TerminalSize { rows: if e.rows > 0 { e.rows } else { 40 }, columns: if e.cols > 0 { e.cols } else { 120 } };
            let r = SPAWN_SESSION_OPTIONS.scope(e.options.clone(), self.resume_session_record(&record.record_id, size, None)).await;
            match r {
                Ok((_, addr)) => tracing::info!(instance_id = addr.session.instance_id.0, provider = %e.provider, "journalled session resumed"),
                Err(err) => tracing::warn!(instance_id = e.instance_id, provider = %e.provider, message = %err.message, "journalled session resume failed"),
            }
        }
    }

    fn refresh_session_journal(&self) {
        let Some(file) = self.session_resume_journal() else { return };
        let mut homes: Vec<PathBuf> = std::env::var_os("HOME").map(PathBuf::from).into_iter().collect();
        if let Some(extra) = std::env::var_os("HATCHERY_PROVIDER_HOMES") { homes.extend(std::env::split_paths(&extra)); }
        crate::pty_resume::refresh(&file, &homes);
        let ids: Vec<(u64, String)> = {
            let records = self.session_records.lock().unwrap_or_else(|p| p.into_inner());
            records.records.values().filter_map(|r| Some((r.active_session.as_ref()?.session.instance_id.0, r.provider_session.as_ref()?.id.clone()))).collect()
        };
        for (inst, sid) in ids {
            crate::pty_resume::set_session_id(&file, inst, &sid);
        }
    }

    fn session_grok_leader_socket(
        &self,
        provider: &AgentId,
        mode: SessionMode,
        instance_id: AgentInstanceId,
    ) -> Option<std::path::PathBuf> {
        if provider.as_str() != "grok" || mode != SessionMode::Pty || crate::grok_leader::disabled() {
            return None;
        }
        let root = self
            .m4a_accounts
            .as_ref()
            .and_then(|a| a.base().parent().map(std::path::Path::to_path_buf))
            .unwrap_or_else(std::env::temp_dir);
        let socket = crate::grok_leader::socket_path(&root, &format!("{}-{}", self.incarnation_id, instance_id.0));
        if let Some(previous) = self
            .grok_leaders
            .lock()
            .unwrap_or_else(|p| p.into_inner())
            .insert(instance_id, socket.clone())
        {
            crate::grok_leader::retire(&previous);
        }
        Some(socket)
    }

    /// Stops this session's own grok leader, if it had one. Never touches any other leader.
    fn retire_session_grok_leader(&self, instance_id: AgentInstanceId) {
        let socket = self.grok_leaders.lock().unwrap_or_else(|p| p.into_inner()).remove(&instance_id);
        if let Some(socket) = socket {
            crate::grok_leader::retire(&socket);
        }
    }

    fn new_with_incarnation(
        handle: Gate4AgentHandle,
        access_token: String,
        node_id: NodeId,
        incarnation_id: NodeIncarnationId,
        workspaces: Vec<WorkspaceConfig>,
        enabled_providers: Vec<AgentId>,
        provider_runtime_statuses: ProviderRuntimeStatuses,
        provider_runtime_monitor: Option<Arc<ProviderRuntimeMonitor>>,
        provider_contracts: Vec<ProviderContractSupport>,
        provider_adapter_contracts: Vec<ProviderAdapterContractSupport>,
        spawn_profiles: SpawnProfileRegistry,
        native_launch_profile_control: Option<NativeLaunchProfileControl>,
        native_session_catalog: Option<Arc<Mutex<NativeSessionCatalogAuthority>>>,
        session_environment_materializer: Option<SessionEnvironmentMaterializer>,
        state_path: Option<PathBuf>,
        records: Vec<ManagedSessionRecord>,
        managed_worktrees: Vec<ManagedWorktreeLeaseRecord>,
        managed_worktree_tombstones: Vec<ManagedWorktreeLeaseRecord>,
        materializations: Vec<MaterializationOwnershipRecord>,
        persistence_warning: Option<String>,
        input_settle_timeout_ms: u64,
    ) -> Self {
        let (event_tx, _) = broadcast::channel(NODE_BROADCAST_CAPACITY);
        let (terminal_event_tx, _) = broadcast::channel(NODE_TERMINAL_BROADCAST_CAPACITY);
        let (agent_stream_event_tx, _) = broadcast::channel(NODE_AGENT_STREAM_BROADCAST_CAPACITY);
        let (harness_mcp_proxy_event_tx, _) =
            broadcast::channel(NODE_HARNESS_MCP_PROXY_BROADCAST_CAPACITY);
        let record_providers = records
            .iter()
            .map(|record| (record.record_id.clone(), record.provider.clone()))
            .collect();
        let mut worktree_service_modes: BTreeMap<WorkspaceId, WorktreeServiceMode> = workspaces
            .iter()
            .map(|workspace| {
                (workspace.workspace_id.clone(), workspace.worktree_service_mode)
            })
            .collect();
        for lease in &managed_worktrees {
            worktree_service_modes.insert(lease.workspace_id.clone(), WorktreeServiceMode::Off);
        }
        let managed_worktree_profiles = workspaces.iter()
            .map(|workspace| (
                workspace.workspace_id.clone(),
                workspace.managed_worktree_profiles.clone(),
            ))
            .collect();
        let mut managed_worktrees = ManagedWorktreeRegistry::from_records(
            managed_worktrees,
            managed_worktree_tombstones,
        ).expect("durable managed worktree registry was validated while loading");
        managed_worktrees.clear_stale_session_holders(incarnation_id, unix_time_ms());
        managed_worktrees.reattach_record_holders(
            &managed_worktree_record_holders(&records),
            unix_time_ms(),
        );
        Self {
            handle,
            access_token,
            node_id,
            incarnation_id,
            started_at_unix_ms: std::time::SystemTime::now()
                .duration_since(std::time::UNIX_EPOCH)
                .unwrap_or_default()
                .as_millis()
                .min(u64::MAX as u128) as u64,
            workspaces: RwLock::new(
                workspaces
                    .into_iter()
                    .map(|workspace| (workspace.workspace_id, workspace.canonical_root))
                    .collect(),
            ),
            worktree_service_modes,
            managed_worktree_profiles,
            managed_worktrees: Mutex::new(managed_worktrees),
            enabled_providers,
            provider_runtime_statuses,
            provider_runtime_status_updates: RwLock::new(BTreeMap::new()),
            provider_runtime_monitor,
            provider_contracts,
            provider_adapter_contracts,
            spawn_profiles,
            environment_profiles: RwLock::new(BTreeMap::new()),
            environment_materialization_profiles: RwLock::new(BTreeMap::new()),
            network_allowlist_catalog: RwLock::new(crate::network_allowlist_catalog::NetworkAllowlistCatalog::new()),
            #[cfg(feature = "dig2-station-probe")]
            browser_station_leases: crate::dig2_station_lease::new_lease_table(),
            bundle_catalog: RwLock::new(BundleCatalog::default()),
            delivery_store: Mutex::new(None),
            context_pack_store: Mutex::new(None),
            context_catalog: RwLock::new(ContextPackCatalog::default()),
            native_launch_profile_control,
            harness_mcp_registry: None,
            native_session_catalog,
            session_environment_materializer,
            m4a_accounts: crate::m4a_accounts::M4aSessionAccounts::from_env(),
            m4a_live: Mutex::new(BTreeMap::new()),
            m4a_keys: Mutex::new(BTreeMap::new()),
            m4a_reuse_keys: Mutex::new(BTreeMap::new()),
            grok_leaders: Mutex::new(BTreeMap::new()),
            #[cfg(unix)]
            #[cfg(unix)]
            signer_proxy: std::sync::OnceLock::new(),
            materializations: Mutex::new(
                materializations
                    .into_iter()
                    .map(|record| (record.id().clone(), record))
                    .collect(),
            ),
            spawn_idempotency: Mutex::new(SpawnIdempotencyCache {
                entries: BTreeMap::new(),
            }),
            managed_spawn_replays: Mutex::new(BTreeMap::new()),
            controller: Mutex::new(None),
            provisional_spawns: Mutex::new(BTreeMap::new()),
            pending_acp_options: Mutex::new(BTreeMap::new()),
            history: Mutex::new(NodeEventHistory::new(record_providers)),
            event_tx,
            terminal_event_tx,
            agent_stream_event_tx,
            harness_mcp_proxy_event_tx,
            terminal_frame_watermarks: Mutex::new(BTreeMap::new()),
            pty_input_wake: tokio::sync::Notify::new(),
            pty_input_marks: Mutex::new(BTreeMap::new()),
            provider_errors: Mutex::new(crate::provider_error::Tracker::default()),
            next_connection_id: AtomicU64::new(1),
            next_instance_id: AtomicU64::new(1),
            next_command_id: AtomicU64::new(1),
            shutdown: AtomicBool::new(false),
            shutdown_notify: Notify::new(),
            preauth_slots: Arc::new(Semaphore::new(MAX_PREAUTH_CONNECTIONS)),
            authenticated_slots: Arc::new(Semaphore::new(MAX_AUTHENTICATED_CONNECTIONS)),
            inspection_slots: Arc::new(Semaphore::new(WORKSPACE_INSPECTION_MAX_CONCURRENCY)),
            mutation_gate: AsyncMutex::new(()),
            session_bindings: Mutex::new(BTreeMap::new()),
            session_records: Mutex::new(SessionRecords {
                records: records
                    .into_iter()
                    .map(|record| (record.record_id.clone(), record))
                    .collect(),
            }),
            state_path,
            persistence_error: RwLock::new(
                persistence_warning
                    .map(|message| session_registry::sanitized_persistence_summary(&message)),
            ),
            state_transaction: Mutex::new(()),
            input_settle_timeout_ms,
            drive_loop_profile: Mutex::new(DriveLoopProfiler::default()),
            runtime_tick_profile: Mutex::new(TickProfileSnapshot::default()),
            shell_efficiency_profile: OnceLock::new(),
            native_session_gauge: AtomicUsize::new(0),
            connection_loop_iterations: AtomicU64::new(0),
            connection_events_sent: AtomicU64::new(0),
            rejected_commands_total: AtomicU64::new(0),
            rejected_command_reasons: Mutex::new(BTreeMap::new()),
            drive_loop_iterations_total: AtomicU64::new(0),
            drive_loop_iterations_idle: AtomicU64::new(0),
            session_record_retention: SessionRecordRetentionConfig::default(),
            retired_records_total: AtomicU64::new(0),
            #[cfg(feature = "fixture")]
            fixture_semantic_hook_policy: false,
            #[cfg(feature = "fixture")]
            fixture_spawn_managed_worktree_v2_failure_probe:
                SpawnManagedWorktreeV2FailureProbe::default(),
        }
    }

    #[cfg(test)]
    fn new(
        handle: Gate4AgentHandle,
        access_token: String,
        node_id: NodeId,
        workspaces: Vec<WorkspaceConfig>,
        enabled_providers: Vec<AgentId>,
    ) -> Self {
        Self::new_with_incarnation(
            handle,
            access_token,
            node_id,
            NodeIncarnationId::from_bytes([0; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            workspaces,
            enabled_providers,
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            None,
            None,
            None,
            None,
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        )
    }

    fn persistence_error(&self) -> Option<String> {
        self.persistence_error
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clone()
    }

    async fn admit_provider_runtime(
        &self,
        provider: &AgentId,
        requirement: ProviderRuntimeRequirement,
    ) -> Result<ProviderRuntimePolicy, NodeFailure> {
        let admission = if let Some(monitor) = self.provider_runtime_monitor.clone() {
            let pipe_transport = monitor.supports_pipe_transport(provider);
            let acp_transport = monitor.supports_acp_transport(provider);
            let provider = provider.clone();
            let refresh = tokio::task::spawn_blocking(move || monitor.evaluate(&provider));
            let (status, admission) = timeout(
                Duration::from_millis(PROVIDER_RUNTIME_ADMISSION_TIMEOUT_MS),
                refresh,
            )
            .await
            .map_err(|_| failure(
                NodeFailureCode::BackendBusy,
                "provider runtime probe exceeded its bounded deadline",
            ))?
            .map_err(|_| failure(
                NodeFailureCode::BackendOperationFailed,
                "provider runtime probe task failed",
            ))?;
            if let Some(status) = status {
                self
                    .provider_runtime_status_updates
                    .write()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .insert(status.provider().clone(), status);
            }
            admission.and_then(|policy| {
                require_policy(policy, pipe_transport, acp_transport, requirement).map(|()| policy)
            })
        } else {
            // No live monitor means no catalog to consult -- there is
            // nothing here to confirm this provider declares a Pipe or ACP
            // transport, so Inline/Acp are rejected the same conservative
            // way an undeclared provider always was, rather than admitted
            // on trust.
            crate::provider_runtime::admit_status(
                &self.provider_runtime_statuses,
                provider,
                false,
                false,
                requirement,
            )
        };
        let admission = admission.map(|policy| self.admit_declared_hook_semantics(provider, policy));
        admission.map_err(|error| match error {
            ProviderRuntimeAdmissionError::LauncherUnavailable => failure(
                NodeFailureCode::BackendOperationFailed,
                "provider launcher is unavailable",
            ),
            ProviderRuntimeAdmissionError::SemanticCapabilityUnverified => failure(
                NodeFailureCode::UnsupportedCapability,
                "provider semantic capability is not verified",
            ),
            ProviderRuntimeAdmissionError::ProbeBusy => failure(
                NodeFailureCode::BackendBusy,
                "provider runtime probe is already in progress",
            ),
        })
    }

    /// Whether the catalog declares a Pipe transport for `provider` --
    /// the fact `require_policy` needs to admit or reject
    /// `ProviderRuntimeRequirement::Inline`. With no live monitor there is no
    /// catalog to consult, so this stays conservative and rejects, matching
    /// `admit_provider_runtime`'s own no-monitor branch.
    fn provider_supports_pipe_transport(&self, provider: &AgentId) -> bool {
        match self.provider_runtime_monitor.as_deref() {
            Some(monitor) => monitor.supports_pipe_transport(provider),
            None => false,
        }
    }

    /// Whether the catalog declares an ACP transport for `provider` -- the
    /// fact `require_policy` needs to admit or reject
    /// `ProviderRuntimeRequirement::Acp`. Mirrors
    /// `provider_supports_pipe_transport` exactly, including the
    /// conservative no-monitor default.
    fn provider_supports_acp_transport(&self, provider: &AgentId) -> bool {
        match self.provider_runtime_monitor.as_deref() {
            Some(monitor) => monitor.supports_acp_transport(provider),
            None => false,
        }
    }

    /// Grants hook ingestion to a provider whose catalog entry declares a
    /// Hook adapter, whatever runtime mode its launcher probe landed in.
    ///
    /// `admit_status`'s `RawPassthrough` arm hands back
    /// `ProviderRuntimePolicy::raw_pty()`, which grants nothing semantic --
    /// correct for everything it was written to answer, and wrong for hooks
    /// specifically. A hook event is not inferred from terminal behaviour,
    /// so it has nothing to do with whether a launcher probe verified this
    /// CLI version's PTY contract; the authority is the catalog declaring
    /// the adapter plus the ingress authenticating the route. Without this
    /// the node installs a provider's hooks, the CLI faithfully calls them,
    /// and every event is refused -- which is exactly the state grok was in.
    ///
    /// Applied to both admission paths so the monitor's own derivation and
    /// this coarse fallback cannot disagree about the same provider.
    fn admit_declared_hook_semantics(
        &self,
        provider: &AgentId,
        policy: ProviderRuntimePolicy,
    ) -> ProviderRuntimePolicy {
        if policy.hook_semantics || !policy.raw_pty_lifecycle {
            return policy;
        }
        let declares_hook = self.provider_adapter_contracts.iter().any(|contract| {
            contract.provider == *provider && contract.family == AdapterFamily::Hook
        });
        if !declares_hook {
            return policy;
        }
        ProviderRuntimePolicy::new(
            policy.raw_pty_lifecycle,
            policy.semantic_readiness,
            policy.structured_prompt,
            policy.provider_session_identity,
            policy.semantic_resume,
            true,
        )
        .expect("granting hook semantics over a raw-PTY policy is internally valid")
    }

    /// Station network allowlist → provider launch overlay argv.
    ///
    /// - **Codex**: first-slice `-c sandbox_workspace_write.network_access` from
    ///   `provider_native` under Moderate (PTY or ACP).
    /// - **Claude**: catalog `permits` → ProviderHome sidecar settings JSON +
    ///   documented `--settings <path>` on **PTY** only (Linux/macOS/WSL2).
    ///   ACP refuses (no measured ACP settings-path surface). Native Windows
    ///   refuses (no vendor Bash sandbox). Membership-only (empty permits) =
    ///   no overlay.
    /// - **Kimi / Grok**: no first-party settings/argv network surface here —
    ///   empty overlay when no `provider_native`; invented native keys already
    ///   refuse at load / resolve.
    ///
    /// Empty when no allowlist / nothing to map. Never cookies / secrets.
    fn resolve_network_allowlist_overlay_args(
        &self,
        provider: &AgentId,
        mode: SessionMode,
        approval_level: ApprovalLevel,
        network_allowlist: Option<&crate::protocol::SpawnNetworkAllowlistId>,
        provider_home: Option<&Path>,
    ) -> Result<Vec<std::ffi::OsString>, NodeFailure> {
        let Some(allowlist_id) = network_allowlist else {
            return Ok(Vec::new());
        };
        let catalog = self
            .network_allowlist_catalog
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let Some(entry) = catalog.get(allowlist_id) else {
            return Err(failure(
                NodeFailureCode::UnknownNetworkAllowlist,
                "spawn network allowlist is unavailable on this node",
            ));
        };

        // Claude: settings-shaped overlay from permits (not provider_native).
        if provider.as_str() == "claude" && !entry.permits.is_empty() {
            crate::network_allowlist_catalog::claude_bash_sandbox_network_os_supported().map_err(
                |message| {
                    failure(
                        NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                        &message,
                    )
                },
            )?;
            if !matches!(mode, SessionMode::Pty) {
                return Err(failure(
                    NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                    "Claude sandbox.network --settings overlay requires PTY transport; ACP has no measured settings-path surface (refuse rather than invent RPC)",
                ));
            }
            let Some(home) = provider_home else {
                return Err(failure(
                    NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                    "Claude sandbox.network --settings overlay requires ProviderHome materialization (CLAUDE_CONFIG_DIR)",
                ));
            };
            let domains =
                crate::network_allowlist_catalog::claude_allowed_domains_from_permits(&entry.permits);
            if domains.is_empty() {
                return Err(failure(
                    NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                    "Claude sandbox.network overlay could not map catalog permits to allowedDomains",
                ));
            }
            let settings_path = home.join(
                crate::network_allowlist_catalog::CLAUDE_STATION_NETWORK_SETTINGS_FILE,
            );
            let json =
                crate::network_allowlist_catalog::claude_station_network_settings_json(&domains);
            crate::session_environment::secure_create_file(&settings_path, json.as_bytes()).map_err(
                |_| {
                    failure(
                        NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                        "Claude station network settings sidecar could not be written under ProviderHome",
                    )
                },
            )?;
            let overlay =
                crate::network_allowlist_catalog::claude_settings_network_overlay_args(&settings_path);
            return Ok(overlay.into_iter().map(std::ffi::OsString::from).collect());
        }

        let Some(native) = entry.provider_native.as_ref() else {
            return Ok(Vec::new());
        };
        let overlay = crate::network_allowlist_catalog::resolve_provider_native_launch_overlay(
            provider.as_str(),
            approval_level,
            native,
        )
        .map_err(|message| {
            failure(
                NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                &message,
            )
        })?;
        if overlay.is_empty() {
            return Ok(Vec::new());
        }
        if !matches!(mode, SessionMode::Pty | SessionMode::Acp) {
            return Err(failure(
                NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                "Codex network_access -c overlay requires PTY or ACP transport",
            ));
        }
        Ok(overlay.into_iter().map(std::ffi::OsString::from).collect())
    }

    /// Backward-compatible alias used by Codex-focused unit tests.
    fn resolve_codex_network_access_overlay_args(
        &self,
        provider: &AgentId,
        mode: SessionMode,
        approval_level: ApprovalLevel,
        network_allowlist: Option<&crate::protocol::SpawnNetworkAllowlistId>,
    ) -> Result<Vec<std::ffi::OsString>, NodeFailure> {
        self.resolve_network_allowlist_overlay_args(
            provider,
            mode,
            approval_level,
            network_allowlist,
            None,
        )
    }

    fn resolve_environment_profile(
        &self,
        resolved: &ResolvedSpawnSpec,
    ) -> Result<Option<ResolvedEnvironmentProfileReceipt>, NodeFailure> {
        // Station network allowlist catalog enforce (plan
        // station-network-and-browser-profile-knobs §2.1 / §4): empty-default
        // catalog — unknown ids refuse rather than silent ambient. Runs even
        // when no environment_profile_id is present so a bare allowlist still
        // cannot bypass the catalog. Never cookies / OAuth / proxy credentials.
        if let Some(allowlist_id) = resolved.network_allowlist.as_ref() {
            let catalog = self
                .network_allowlist_catalog
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(entry) = catalog.get(allowlist_id) else {
                return Err(failure(
                    NodeFailureCode::UnknownNetworkAllowlist,
                    "spawn network allowlist is unavailable on this node",
                ));
            };
            // Track B: refuse provider-native mappings this provider cannot
            // honor (e.g. codex_network_access on Claude). Never silent ambient.
            if let Some(native) = entry.provider_native.as_ref() {
                if let Err(message) = crate::network_allowlist_catalog::provider_native_mapping_supported(
                    resolved.provider.as_str(),
                    resolved.approval_level,
                    native,
                ) {
                    return Err(failure(
                        NodeFailureCode::UnsupportedNetworkAllowlistMapping,
                        &message,
                    ));
                }
            }
        }
        // Station knobs Track A (dig2browser-station-probe-and-network-permit-set):
        // when feature `dig2-station-probe` is on and browser_profile_id is set,
        // cheap named-pipe path reachability must succeed (Windows
        // `\\.\pipe\{suffix}`); platform-unsupported or unreachable → clear
        // NodeFailureCode. Runs even without environment_profile_id (same
        // placement spirit as allowlist catalog). Feature off keeps stub echo.
        // Never cookies / OAuth / proxy credentials. Exclusive lease is
        // acquired later in spawn_session_with_deadline (after instance id).
        #[cfg(feature = "dig2-station-probe")]
        if resolved.browser_profile_id.is_some() {
            use crate::dig2_station_probe::{probe_station_reachable, StationProbeError};
            match probe_station_reachable() {
                Ok(()) => {}
                Err(StationProbeError::UnsupportedPlatform)
                | Err(StationProbeError::InvalidPipeSuffix) => {
                    return Err(failure(
                        NodeFailureCode::BrowserStationProbeUnavailable,
                        "dig2browser station probe unavailable on this platform",
                    ));
                }
                Err(StationProbeError::Unreachable) => {
                    return Err(failure(
                        NodeFailureCode::BrowserStationUnreachable,
                        "dig2browser station named-pipe is unreachable",
                    ));
                }
            }
        }
        let Some(profile_id) = resolved.environment_profile_id.as_ref() else {
            return Ok(None);
        };
        let profiles = self
            .environment_profiles
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let binding = profiles.get(profile_id).ok_or_else(|| {
            failure(
                NodeFailureCode::UnknownEnvironmentProfile,
                "spawn environment profile is unavailable on this node",
            )
        })?;
        if binding.provider != resolved.provider
            || binding.native_profile_id(resolved.mode).is_none()
        {
            return Err(failure(
                NodeFailureCode::EnvironmentProfileBindingMismatch,
                "spawn environment profile does not match the provider and mode",
            ));
        }
        // Echo opaque network_allowlist / browser_profile_id onto the receipt
        // after catalog + optional dig2 probe above. Empty/whitespace ids
        // already refuse at Spawn*Id construction.
        Ok(Some(ResolvedEnvironmentProfileReceipt {
            profile_id: binding.id.clone(),
            profile_revision: binding.revision.clone(),
            network_allowlist: resolved.network_allowlist.clone(),
            browser_profile_id: resolved.browser_profile_id.clone(),
        }))
    }

    fn resolve_bundle(
        &self,
        resolved: &ResolvedSpawnSpec,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
    ) -> Result<Option<ResolvedBundleReceipt>, NodeFailure> {
        let Some(bundle_id) = resolved.bundle_id.as_ref() else {
            return Ok(None);
        };
        let catalog = self.bundle_catalog
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let bundle = catalog.get(bundle_id).ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownBundle,
                    "spawn bundle is unavailable on this node",
                )
            })?;
        self.bundle_layout(
            &resolved.provider,
            resolved.mode,
            environment_profile,
            bundle,
        )?;
        Ok(Some(bundle.receipt()))
    }

    fn begin_delivery_stage(
        &self,
        manifest: DeliveryBundleManifestV2,
    ) -> Result<NodeResponse, NodeFailure> {
        let mut store = self
            .delivery_store
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let store = store.as_mut().ok_or_else(|| {
            failure(
                NodeFailureCode::DeliveryStageStorageFailed,
                "node delivery store is unavailable",
            )
        })?;
        let begun = store.begin(manifest).map_err(delivery_failure)?;
        Ok(NodeResponse::DeliveryStageBegun {
            stage_id: begun.stage_id,
            manifest_digest: begun.manifest_digest,
            missing_blobs: begun.missing_blobs,
        })
    }

    fn put_delivery_blob_chunk(
        &self,
        stage_id: DeliveryStageId,
        blob_digest: DeliveryBlobDigestV1,
        offset: u64,
        chunk_hex: DeliveryBlobChunkHexV1,
    ) -> Result<NodeResponse, NodeFailure> {
        let mut store = self
            .delivery_store
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let store = store.as_mut().ok_or_else(|| {
            failure(
                NodeFailureCode::DeliveryStageStorageFailed,
                "node delivery store is unavailable",
            )
        })?;
        let accepted = store
            .put_chunk(&stage_id, &blob_digest, offset, &chunk_hex.decode())
            .map_err(delivery_failure)?;
        Ok(NodeResponse::DeliveryBlobChunkAccepted {
            stage_id: accepted.stage_id,
            blob_digest: accepted.blob_digest,
            next_offset: accepted.next_offset,
        })
    }

    fn commit_delivery_stage(
        &self,
        stage_id: DeliveryStageId,
    ) -> Result<DeliveryCommitReceiptV1, NodeFailure> {
        let mut store = self
            .delivery_store
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let store = store.as_mut().ok_or_else(|| {
            failure(
                NodeFailureCode::DeliveryStageStorageFailed,
                "node delivery store is unavailable",
            )
        })?;
        let prepared = store.prepare_commit(&stage_id).map_err(delivery_failure)?;
        let mut catalog = self
            .bundle_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut next_catalog = catalog.clone();
        next_catalog
            .insert_idempotent(prepared.bundle().clone())
            .map_err(|_| {
                failure(
                    NodeFailureCode::DeliveryStageConflict,
                    "delivery bundle identity conflicts with installed content",
                )
            })?;
        let receipt = store.publish_commit(prepared).map_err(delivery_failure)?;
        *catalog = next_catalog;
        Ok(receipt)
    }

    fn abort_delivery_stage(
        &self,
        stage_id: &DeliveryStageId,
    ) -> Result<(), NodeFailure> {
        let mut store = self
            .delivery_store
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let store = store.as_mut().ok_or_else(|| {
            failure(
                NodeFailureCode::DeliveryStageStorageFailed,
                "node delivery store is unavailable",
            )
        })?;
        store.abort(stage_id).map_err(delivery_failure)
    }

    fn resolve_context(
        &self,
        resolved: &ResolvedSpawnSpec,
    ) -> Result<Option<ResolvedContextPackReceipt>, NodeFailure> {
        let Some(context_id) = resolved.context_id.as_ref() else {
            return Ok(None);
        };
        self.context_catalog
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(context_id)
            .map(|context| context.receipt().clone())
            .ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownContextPack,
                    "spawn context pack is unavailable on this node",
                )
            })
            .map(Some)
    }

    fn bundle_layout(
        &self,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
        bundle: &NodeBundle,
    ) -> Result<BundleProviderLayout, NodeFailure> {
        let layout = validate_bundle_binding(provider, mode, bundle).map_err(|_| {
            failure(
                NodeFailureCode::BundleBindingMismatch,
                "spawn bundle does not match the provider and mode",
            )
        })?;
        if layout != BundleProviderLayout::Codex {
            return Ok(layout);
        }
        let profile = environment_profile.and_then(|receipt| {
            let profiles = self
                .environment_profiles
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let binding = profiles.get(&receipt.profile_id)?;
            if binding.revision != receipt.profile_revision
                || &binding.provider != provider
                || binding.native_profile_id(mode).is_none()
            {
                return None;
            }
            self.environment_materialization_profiles
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&receipt.profile_id)
                .cloned()
        });
        if !profile.is_some_and(|profile| profile.supports_bundle_layout(layout)) {
            return Err(failure(
                NodeFailureCode::BundleBindingMismatch,
                "Codex bundle requires an exact isolated CODEX_HOME profile",
            ));
        }
        Ok(layout)
    }

    fn select_environment_profile(
        &self,
        instance_id: AgentInstanceId,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
    ) -> Result<Option<NativeEnvironmentSelectionGuard>, NodeFailure> {
        let Some(environment_profile) = environment_profile else {
            return Ok(None);
        };
        let native_profile_id = {
            let profiles = self
                .environment_profiles
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let binding = profiles
                .get(&environment_profile.profile_id)
                .ok_or_else(|| {
                    failure(
                        NodeFailureCode::UnknownEnvironmentProfile,
                        "session environment profile is unavailable on this node",
                    )
                })?;
            if &binding.revision != &environment_profile.profile_revision
                || &binding.provider != provider
            {
                return Err(failure(
                    NodeFailureCode::EnvironmentProfileBindingMismatch,
                    "session environment profile revision or provider changed",
                ));
            }
            binding.native_profile_id(mode).cloned().ok_or_else(|| {
                failure(
                    NodeFailureCode::EnvironmentProfileBindingMismatch,
                    "session environment profile does not support this mode",
                )
            })?
        };
        let control = self.native_launch_profile_control.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                "native environment profile controller is unavailable",
            )
        })?;
        control
            .select_native_launch_profile(instance_id, native_profile_id)
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendOperationFailed,
                    "native environment profile selection failed",
                )
            })?;
        Ok(Some(NativeEnvironmentSelectionGuard {
            control: Some(control),
            instance_id,
        }))
    }

    fn install_prepared_launch_overlay(
        &self,
        instance_id: AgentInstanceId,
        overlay: PreparedNativeLaunchOverlay,
    ) -> Result<Option<NativeInstanceOverlayGuard>, NodeFailure> {
        let control = self.native_launch_profile_control.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                "native launch profile controller is unavailable",
            )
        })?;
        match overlay {
            PreparedNativeLaunchOverlay::Environment(overlay) => {
                control
                    .install_native_launch_environment_overlay(instance_id, overlay)
                    .map_err(|_| failure(
                        NodeFailureCode::BackendOperationFailed,
                        "session environment overlay installation failed",
                    ))?;
                Ok(None)
            }
            PreparedNativeLaunchOverlay::Instance(overlay) => {
                control
                    .install_native_instance_launch_overlay(instance_id, overlay)
                    .map_err(|_| failure(
                        NodeFailureCode::BundleBindingMismatch,
                        "session bundle launch overlay installation failed",
                    ))?;
                Ok(Some(NativeInstanceOverlayGuard {
                    control: Some(control),
                    instance_id,
                }))
            }
        }
    }

    fn environment_materialization_profile(
        &self,
        environment_profile: &ResolvedEnvironmentProfileReceipt,
    ) -> Option<NodeSessionMaterializationProfile> {
        self.environment_materialization_profiles
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&environment_profile.profile_id)
            .cloned()
    }

    fn materialization_profile(
        &self,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
        bundle: Option<&ResolvedBundleReceipt>,
        context: Option<&ResolvedContextPackReceipt>,
    ) -> Result<Option<(
        NodeSessionMaterializationProfile,
        bool,
        Option<BundleProviderLayout>,
    )>, NodeFailure> {
        let environment = environment_profile
            .and_then(|receipt| self.environment_materialization_profile(receipt));
        let (bundle, bundle_layout) = match bundle {
            Some(receipt) => {
                let catalog = self.bundle_catalog.read()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let installed = catalog.get(&receipt.id).ok_or_else(|| failure(
                    NodeFailureCode::UnknownBundle,
                    "session bundle is unavailable on this node",
                ))?;
                if installed.receipt() != *receipt {
                    return Err(failure(
                        NodeFailureCode::BundleBindingMismatch,
                        "session bundle revision or digest changed",
                    ));
                }
                let layout = self.bundle_layout(
                    provider,
                    mode,
                    environment_profile,
                    installed,
                )?;
                (Some(installed.clone()), Some(layout))
            }
            None => (None, None),
        };
        let has_environment_overlay = environment.is_some() || context.is_some();
        let profile = match (environment, bundle.as_ref(), bundle_layout) {
            (None, None, None) => None,
            (Some(profile), None, None) => Some(Ok(profile)),
            (None, Some(bundle), Some(layout)) => {
                Some(NodeSessionMaterializationProfile::from_bundle(bundle, layout))
            }
            (Some(profile), Some(bundle), Some(layout)) => {
                Some(profile.with_bundle(bundle, layout))
            }
            _ => {
                return Err(failure(
                    NodeFailureCode::BundleBindingMismatch,
                    "session bundle provider layout is unavailable",
                ));
            }
        };
        let profile = profile
            .transpose()
            .map_err(|_| failure(
                NodeFailureCode::BundleMaterializationFailed,
                "session bundle materialization profile is invalid",
            ))?;
        let profile = match (profile, context) {
            (Some(profile), Some(receipt)) => {
                let catalog = self.context_catalog
                    .read()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let pack = catalog.get(&receipt.id).ok_or_else(|| failure(
                    NodeFailureCode::UnknownContextPack,
                    "session context pack is unavailable on this node",
                ))?;
                if pack.receipt() != receipt {
                    return Err(failure(
                        NodeFailureCode::ContextPackMaterializationFailed,
                        "session context pack identity changed",
                    ));
                }
                profile.with_context(pack)
            }
            (None, Some(receipt)) => {
                let catalog = self.context_catalog
                    .read()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let pack = catalog.get(&receipt.id).ok_or_else(|| failure(
                    NodeFailureCode::UnknownContextPack,
                    "session context pack is unavailable on this node",
                ))?;
                if pack.receipt() != receipt {
                    return Err(failure(
                        NodeFailureCode::ContextPackMaterializationFailed,
                        "session context pack identity changed",
                    ));
                }
                NodeSessionMaterializationProfile::from_context(pack)
            }
            (Some(profile), None) => Ok(profile),
            (None, None) => return Ok(None),
        }
        .map_err(|_| failure(
            NodeFailureCode::ContextPackMaterializationFailed,
            "session context pack materialization profile is invalid",
        ))?;
        Ok(Some((profile, has_environment_overlay, bundle_layout)))
    }

    fn prepare_session_materialization<'a>(
        &'a self,
        address: &SessionAddress,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
        bundle: Option<&ResolvedBundleReceipt>,
        context: Option<&ResolvedContextPackReceipt>,
        managed_lease_id: Option<ManagedWorktreeLeaseId>,
    ) -> Result<Option<(Option<PreparedNativeLaunchOverlay>, SessionMaterializationGuard<'a>)>, NodeFailure> {
        let Some((profile, has_environment_overlay, bundle_layout)) =
            self.materialization_profile(provider, mode, environment_profile, bundle, context)?
        else {
            return Ok(None);
        };
        let materializer = self.session_environment_materializer.as_ref().ok_or_else(|| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                "session environment materializer is unavailable",
            )
        })?;
        let materialization_failure_code = if context.is_some() {
            NodeFailureCode::ContextPackMaterializationFailed
        } else if bundle.is_some() {
            NodeFailureCode::BundleMaterializationFailed
        } else {
            NodeFailureCode::BackendOperationFailed
        };
        let id = MaterializationId::new(format!(
            "mat-{}-{}-{}",
            self.incarnation_id,
            address.session.instance_id.0,
            address.session.generation.0,
        ))
        .map_err(|_| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                "session environment materialization identity failed",
            )
        })?;
        let owner = MaterializationOwner::Session {
            incarnation_id: self.incarnation_id,
            instance_id: address.session.instance_id,
            generation: address.session.generation,
        };
        let mut ownership = materializer
            .begin(
                id.clone(),
                environment_profile.cloned(),
                bundle.cloned(),
                context.cloned(),
                owner,
                managed_lease_id,
                &profile,
                unix_time_ms(),
            )
            .map_err(|_| {
                failure(
                    materialization_failure_code,
                    "session materialization preparation failed",
                )
            })?;
        {
            let _transaction = self
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let duplicate = self
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), ownership.clone());
            if duplicate.is_some() {
                return Err(failure(
                    NodeFailureCode::BackendOperationFailed,
                    "session environment materialization identity conflict",
                ));
            }
            if let Err(error) = self.persist_state_locked() {
                self.materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .remove(&id);
                return Err(persistence_failure(error));
            }
        }
        let environment = match materializer.materialize(&mut ownership, &profile, unix_time_ms()) {
            Ok(environment) => environment,
            Err(_) => {
                let transaction = self
                    .state_transaction
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                self.materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .insert(id.clone(), ownership.clone());
                if self.persist_state_locked().is_err() {
                    self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
                }
                drop(transaction);
                if ownership.state() == MaterializationState::CleanupRequired {
                    let _ = self.cleanup_materialization(&id);
                }
                return Err(failure(
                    materialization_failure_code,
                    "session materialization failed",
                ));
            }
        };
        {
            let _transaction = self
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            self.materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), ownership.clone());
            if let Err(error) = self.persist_state_locked() {
                drop(_transaction);
                let _ = self.cleanup_materialization(&id);
                return Err(persistence_failure(error));
            }
        }
        let guard = SessionMaterializationGuard {
            shared: self,
            id: Some(id),
            provider_home: Some(ownership.provider_home().to_path_buf()),
        };
        let bundle_arguments = match bundle {
            Some(receipt) => {
                let catalog = self.bundle_catalog.read()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let installed = catalog.get(&receipt.id).ok_or_else(|| failure(
                    NodeFailureCode::UnknownBundle,
                    "session bundle is unavailable on this node",
                ))?;
                if installed.receipt() != *receipt {
                    return Err(failure(
                        NodeFailureCode::BundleBindingMismatch,
                        "session bundle revision or digest changed",
                    ));
                }
                let layout = bundle_layout.ok_or_else(|| failure(
                    NodeFailureCode::BundleBindingMismatch,
                    "materialized bundle provider layout is unavailable",
                ))?;
                materializer.revalidate_bundle(&ownership, installed, layout).map_err(|_| {
                    failure(
                        NodeFailureCode::BundleMaterializationFailed,
                        "session bundle byte revalidation failed",
                    )
                })?;
                Some(bundle_launch_arguments(
                    layout,
                    ownership.bundle_root(),
                    ownership.provider_home(),
                ).map_err(|_| failure(
                    NodeFailureCode::BundleBindingMismatch,
                    "session bundle launch binding is invalid",
                ))?)
            }
            None => None,
        };
        if let Some(receipt) = context {
            materializer
                .revalidate_context(&ownership, receipt)
                .map_err(|_| failure(
                    NodeFailureCode::ContextPackMaterializationFailed,
                    "session context pack byte revalidation failed",
                ))?;
        }
        let transport = match mode {
            SessionMode::Pty => TransportKind::Pty,
            SessionMode::Inline => TransportKind::Pipe,
            SessionMode::Acp => TransportKind::Acp,
        };
        let overlay = if let Some(extra_args) = bundle_arguments {
            Some(PreparedNativeLaunchOverlay::Instance(
                NativeInstanceLaunchOverlay::new(
                    provider.clone(),
                    transport,
                    if has_environment_overlay {
                        environment
                    } else {
                        Vec::new()
                    },
                    extra_args,
                )
                .map_err(|_| {
                    failure(
                        NodeFailureCode::BundleBindingMismatch,
                        "session bundle launch overlay is invalid",
                    )
                })?,
            ))
        } else if has_environment_overlay {
            let context_only = environment_profile.is_none()
                && bundle.is_none()
                && context.is_some();
            let overlay = if context_only {
                NativeLaunchEnvironmentOverlay::new_context_root(
                    provider.clone(),
                    transport,
                    environment,
                )
                .map_err(|_| {
                    failure(
                        NodeFailureCode::ContextPackMaterializationFailed,
                        "context-only launch overlay is invalid",
                    )
                })?
            } else {
                NativeLaunchEnvironmentOverlay::new(
                    provider.clone(),
                    transport,
                    environment,
                )
                .map_err(|_| {
                    failure(
                        NodeFailureCode::BackendOperationFailed,
                        "session environment overlay is invalid",
                    )
                })?
            };
            Some(PreparedNativeLaunchOverlay::Environment(overlay))
        } else {
            None
        };
        Ok(Some((overlay, guard)))
    }

    fn cleanup_materialization(&self, id: &MaterializationId) -> Result<(), NodeFailure> {
        let Some(mut ownership) = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(id)
            .cloned()
        else {
            return Ok(());
        };
        if ownership.state() != MaterializationState::CleanupRequired {
            ownership.mark_cleanup_required(unix_time_ms()).map_err(|_| {
                failure(
                    NodeFailureCode::BackendOperationFailed,
                    "session environment cleanup state is invalid",
                )
            })?;
        }
        {
            let _transaction = self
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let previous = self
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), ownership.clone());
            if let Err(error) = self.persist_state_locked() {
                let mut materializations = self
                    .materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                if let Some(previous) = previous {
                    materializations.insert(id.clone(), previous);
                }
                return Err(persistence_failure(error));
            }
        }
        let cleanup = self
            .session_environment_materializer
            .as_ref()
            .ok_or(())
            .and_then(|materializer| materializer.cleanup(&ownership).map_err(|_| ()));
        if cleanup.is_err() {
            let _ = ownership.mark_recovery_required(unix_time_ms());
            self.materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), ownership);
            if self.persist_state().is_err() {
                self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
            }
            return Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "session environment cleanup requires recovery",
            ));
        }
        let _transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        self.materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .remove(id);
        if let Err(error) = self.persist_state_locked() {
            self.materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), ownership);
            return Err(persistence_failure(error));
        }
        Ok(())
    }

    fn resolve_record_materialization(
        &self,
        record_id: &SessionRecordId,
        provider: &AgentId,
        mode: SessionMode,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
        bundle: Option<&ResolvedBundleReceipt>,
        context: Option<&ResolvedContextPackReceipt>,
    ) -> Result<Option<(MaterializationId, Option<PreparedNativeLaunchOverlay>)>, NodeFailure> {
        let ownership = {
            let materializations = self
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let mut matches = materializations.values().filter(|record| {
                record.owner()
                    == &MaterializationOwner::Record {
                        record_id: record_id.clone(),
                    }
            });
            let ownership = matches.next().cloned();
            if matches.next().is_some() {
                return Err(failure(
                    NodeFailureCode::BackendOperationFailed,
                    "managed session has conflicting environment ownership",
                ));
            }
            ownership
        };
        if let (Some(ownership), Some(receipt)) = (ownership.as_ref(), context) {
            let materializer = self.session_environment_materializer.as_ref().ok_or_else(|| {
                failure(
                    NodeFailureCode::ContextPackMaterializationFailed,
                    "session context materializer is unavailable",
                )
            })?;
            let pack = materializer
                .revalidate_context(ownership, receipt)
                .map_err(|_| {
                    self.mark_materialization_recovery_required(ownership.id());
                    failure(
                        NodeFailureCode::ContextPackMaterializationFailed,
                        "managed session context pack revalidation failed",
                    )
                })?;
            self.context_catalog
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(pack)
                .map_err(|_| failure(
                    NodeFailureCode::ContextPackMaterializationFailed,
                    "managed session context pack catalog restore failed",
                ))?;
        }
        let materialization = self.materialization_profile(
            provider,
            mode,
            environment_profile,
            bundle,
            context,
        )?;
        match (ownership, materialization) {
            (None, None) => Ok(None),
            (None, Some(_)) | (Some(_), None) => Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "managed session materialization is unavailable",
            )),
            (Some(ownership), Some((profile, has_environment_materialization, bundle_layout))) => {
                if ownership.environment_profile() != environment_profile
                    || ownership.bundle() != bundle
                    || ownership.context() != context
                    || ownership.state() != MaterializationState::Ready
                {
                    self.mark_materialization_recovery_required(ownership.id());
                    return Err(failure(
                        NodeFailureCode::BackendOperationFailed,
                        "managed session environment ownership requires recovery",
                    ));
                }
                let materializer = self.session_environment_materializer.as_ref().ok_or_else(|| {
                    failure(
                        NodeFailureCode::BackendOperationFailed,
                        "session environment materializer is unavailable",
                    )
                })?;
                if materializer.revalidate(&ownership).is_err() {
                    self.mark_materialization_recovery_required(ownership.id());
                    return Err(failure(
                        NodeFailureCode::BackendOperationFailed,
                        "managed session environment revalidation failed",
                    ));
                }
                let bundle_arguments = if let Some(bundle_receipt) = bundle {
                    let catalog = self.bundle_catalog.read()
                        .unwrap_or_else(|poisoned| poisoned.into_inner());
                    let Some(installed) = catalog.get(&bundle_receipt.id) else {
                        return Err(failure(
                            NodeFailureCode::UnknownBundle,
                            "managed session bundle is unavailable",
                        ));
                    };
                    let layout = bundle_layout.ok_or_else(|| failure(
                        NodeFailureCode::BundleBindingMismatch,
                        "record bundle provider layout is unavailable",
                    ))?;
                    if materializer.revalidate_bundle(&ownership, installed, layout).is_err() {
                        drop(catalog);
                        self.mark_materialization_recovery_required(ownership.id());
                        return Err(failure(
                            NodeFailureCode::BundleMaterializationFailed,
                            "managed session bundle revalidation failed",
                        ));
                    }
                    Some(bundle_launch_arguments(
                        layout,
                        ownership.bundle_root(),
                        ownership.provider_home(),
                    ).map_err(|_| failure(
                        NodeFailureCode::BundleBindingMismatch,
                        "managed session bundle launch binding is invalid",
                    ))?)
                } else {
                    None
                };
                if !has_environment_materialization {
                    let overlay = bundle_arguments.map(|extra_args| {
                        NativeInstanceLaunchOverlay::new(
                            provider.clone(),
                            TransportKind::Pty,
                            Vec::new(),
                            extra_args,
                        )
                        .map(PreparedNativeLaunchOverlay::Instance)
                        .map_err(|_| failure(
                            NodeFailureCode::BundleBindingMismatch,
                            "managed session bundle launch overlay is invalid",
                        ))
                    }).transpose()?;
                    return Ok(Some((ownership.id().clone(), overlay)));
                }
                let environment = match materializer.resolve_environment(&ownership, &profile) {
                    Ok(environment) => environment,
                    Err(
                        SessionEnvironmentMaterializeError::SecretUnavailable
                        | SessionEnvironmentMaterializeError::SecretDenied
                        | SessionEnvironmentMaterializeError::InvalidSecretValue,
                    ) => {
                        return Err(failure(
                            NodeFailureCode::BackendOperationFailed,
                            "managed session environment resolution failed",
                        ));
                    }
                    Err(
                        SessionEnvironmentMaterializeError::InvalidRoot
                        | SessionEnvironmentMaterializeError::OwnershipMismatch
                        | SessionEnvironmentMaterializeError::Filesystem(_)
                        | SessionEnvironmentMaterializeError::Record(_),
                    ) => {
                        self.mark_materialization_recovery_required(ownership.id());
                        return Err(failure(
                            NodeFailureCode::BackendOperationFailed,
                            "managed session environment resolution failed",
                        ));
                    }
                };
                let transport = match mode {
                    SessionMode::Pty => TransportKind::Pty,
                    SessionMode::Inline => TransportKind::Pipe,
                    SessionMode::Acp => TransportKind::Acp,
                };
                let overlay = match bundle_arguments {
                    Some(extra_args) => PreparedNativeLaunchOverlay::Instance(
                        NativeInstanceLaunchOverlay::new(
                            provider.clone(),
                            transport,
                            environment,
                            extra_args,
                        )
                        .map_err(|_| failure(
                            NodeFailureCode::BundleBindingMismatch,
                            "managed session bundle launch overlay is invalid",
                        ))?,
                    ),
                    None => PreparedNativeLaunchOverlay::Environment(
                        NativeLaunchEnvironmentOverlay::new(
                            provider.clone(),
                            transport,
                            environment,
                        )
                        .map_err(|_| {
                            failure(
                                NodeFailureCode::BackendOperationFailed,
                                "managed session environment overlay is invalid",
                            )
                        })?,
                    ),
                };
                Ok(Some((ownership.id().clone(), Some(overlay))))
            }
        }
    }

    fn destroy_record_materialization(
        &self,
        record_id: &SessionRecordId,
    ) -> Result<bool, NodeFailure> {
        let ids = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .filter_map(|record| {
                (record.owner()
                    == &MaterializationOwner::Record {
                        record_id: record_id.clone(),
                    })
                .then(|| record.id().clone())
            })
            .collect::<Vec<_>>();
        if ids.len() > 1 {
            return Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "managed session has conflicting environment ownership",
            ));
        }
        let Some(id) = ids.first().cloned() else {
            return Ok(false);
        };
        let (terminal_record, mut cleanup_ownership) = {
            let _transaction = self
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let original_record = self.record(record_id)?;
            let mut terminal_record = original_record.clone();
            terminal_record.provider_session = None;
            terminal_record.active_session = None;
            terminal_record.state = ManagedSessionState::Unavailable;
            terminal_record.last_error = Some("environment-profile-unavailable".to_owned());
            terminal_record.updated_at_unix_ms = unix_time_ms();
            let original_ownership = self
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&id)
                .cloned()
                .ok_or_else(|| {
                    failure(
                        NodeFailureCode::BackendOperationFailed,
                        "managed session environment ownership disappeared during cleanup",
                    )
                })?;
            let mut cleanup_ownership = original_ownership.clone();
            if cleanup_ownership.state() != MaterializationState::CleanupRequired {
                cleanup_ownership.mark_cleanup_required(unix_time_ms()).map_err(|_| {
                    failure(
                        NodeFailureCode::BackendOperationFailed,
                        "managed session environment cleanup state is invalid",
                    )
                })?;
            }
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .insert(record_id.clone(), terminal_record.clone());
            self.materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), cleanup_ownership.clone());
            if let Err(error) = self.persist_state_locked() {
                self.session_records
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .records
                    .insert(record_id.clone(), original_record);
                self.materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .insert(id.clone(), original_ownership);
                return Err(persistence_failure(error));
            }
            (terminal_record, cleanup_ownership)
        };
        let cleanup = self
            .session_environment_materializer
            .as_ref()
            .ok_or(())
            .and_then(|materializer| materializer.cleanup(&cleanup_ownership).map_err(|_| ()));
        if cleanup.is_err() {
            let _ = cleanup_ownership.mark_recovery_required(unix_time_ms());
            self.materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id.clone(), cleanup_ownership);
            if self.persist_state().is_err() {
                self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
            }
            return Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "managed session environment cleanup requires recovery",
            ));
        }
        let _transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        self.remove_record_memory(record_id);
        self.materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .remove(&id);
        if let Err(error) = self.persist_state_locked() {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .insert(record_id.clone(), terminal_record);
            self.materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(id, cleanup_ownership);
            return Err(persistence_failure(error));
        }
        Ok(true)
    }

    fn mark_materialization_recovery_required(&self, id: &MaterializationId) {
        let changed = {
            let mut materializations = self
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(ownership) = materializations.get_mut(id) else {
                return;
            };
            ownership.mark_recovery_required(unix_time_ms()).is_ok()
        };
        if changed && self.persist_state().is_err() {
            self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
        }
    }

    fn reconcile_materializations(&self) {
        let records = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .cloned()
            .collect::<Vec<_>>();
        for mut ownership in records {
            let result = match (ownership.state(), ownership.owner()) {
                (MaterializationState::Preparing, _)
                | (MaterializationState::CleanupRequired, _) => {
                    self.cleanup_materialization(ownership.id())
                }
                (MaterializationState::Ready, MaterializationOwner::Session { .. }) => {
                    if ownership.mark_recovery_required(unix_time_ms()).is_ok() {
                        self.materializations
                            .lock()
                            .unwrap_or_else(|poisoned| poisoned.into_inner())
                            .insert(ownership.id().clone(), ownership.clone());
                        self.persist_state().map_err(persistence_failure)
                    } else {
                        Err(failure(
                            NodeFailureCode::BackendOperationFailed,
                            "session environment reconciliation failed",
                        ))
                    }
                }
                (MaterializationState::Ready, MaterializationOwner::Record { record_id }) => self
                    .session_environment_materializer
                    .as_ref()
                    .ok_or_else(|| {
                        failure(
                            NodeFailureCode::BackendOperationFailed,
                            "session environment materializer is unavailable",
                        )
                    })
                    .and_then(|materializer| {
                        materializer.revalidate(&ownership).map_err(|_| failure(
                            NodeFailureCode::BackendOperationFailed,
                            "session materialization revalidation failed",
                        ))?;
                        let record = self.record(record_id)?;
                        if record.environment_profile.as_ref() != ownership.environment_profile()
                            || record.bundle.as_ref() != ownership.bundle()
                            || record.context.as_ref() != ownership.context()
                        {
                            return Err(failure(
                                NodeFailureCode::BackendOperationFailed,
                                "session materialization ownership changed after restart",
                            ));
                        }
                        if let Some(receipt) = ownership.bundle() {
                            let catalog = self.bundle_catalog.read()
                                .unwrap_or_else(|poisoned| poisoned.into_inner());
                            let bundle = catalog.get(&receipt.id).ok_or_else(|| failure(
                                NodeFailureCode::UnknownBundle,
                                "session bundle is unavailable after restart",
                            ))?;
                            if bundle.receipt() != *receipt {
                                return Err(failure(
                                    NodeFailureCode::BundleBindingMismatch,
                                    "session bundle changed after restart",
                                ));
                            }
                            let layout = self.bundle_layout(
                                &record.provider,
                                record.mode,
                                record.environment_profile.as_ref(),
                                bundle,
                            )?;
                            materializer
                                .revalidate_bundle(&ownership, bundle, layout)
                                .map_err(|_| failure(
                                    NodeFailureCode::BundleMaterializationFailed,
                                    "session bundle revalidation failed",
                                ))?;
                        }
                        if let Some(receipt) = ownership.context() {
                            let pack = materializer
                                .revalidate_context(&ownership, receipt)
                                .map_err(|_| {
                                    failure(
                                        NodeFailureCode::ContextPackMaterializationFailed,
                                        "session context revalidation failed",
                                    )
                                })?;
                            self.context_catalog
                                .write()
                                .unwrap_or_else(|poisoned| poisoned.into_inner())
                                .insert(pack)
                                .map_err(|_| {
                                    failure(
                                        NodeFailureCode::ContextPackMaterializationFailed,
                                        "session context catalog restore failed",
                                    )
                                })?;
                        }
                        Ok(())
                    }),
                (MaterializationState::RecoveryRequired, _) => Ok(()),
            };
            if result.is_err() && ownership.state() != MaterializationState::RecoveryRequired {
                let _ = ownership.mark_recovery_required(unix_time_ms());
                self.materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .insert(ownership.id().clone(), ownership);
                if self.persist_state().is_err() {
                    self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
                }
            }
        }
        let materialized_profiles = self
            .environment_materialization_profiles
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .keys()
            .cloned()
            .collect::<Vec<_>>();
        let ownership = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .cloned()
            .collect::<Vec<_>>();
        let changed = {
            let mut session_records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let mut changed = false;
            for record in session_records.records.values_mut() {
                let environment_profile = record.environment_profile.as_ref();
                if environment_profile.is_none()
                    && record.bundle.is_none()
                    && record.context.is_none()
                {
                    continue;
                }
                if record.bundle.is_none()
                    && environment_profile.is_some_and(|profile| {
                        !materialized_profiles.contains(&profile.profile_id)
                    })
                {
                    continue;
                }
                let has_exact_ownership = ownership.iter().any(|candidate| {
                    candidate.state() == MaterializationState::Ready
                        && candidate.environment_profile() == environment_profile
                        && candidate.bundle() == record.bundle.as_ref()
                        && candidate.context() == record.context.as_ref()
                        && candidate.owner()
                            == &MaterializationOwner::Record {
                                record_id: record.record_id.clone(),
                            }
                });
                if !has_exact_ownership {
                    record.provider_session = None;
                    record.active_session = None;
                    record.state = ManagedSessionState::Unavailable;
                    record.last_error = Some(if record.bundle.is_some() {
                        "bundle-unavailable".to_owned()
                    } else if record.context.is_some() {
                        "context-unavailable".to_owned()
                    } else {
                        "environment-profile-unavailable".to_owned()
                    });
                    record.updated_at_unix_ms = unix_time_ms();
                    changed = true;
                }
            }
            changed
        };
        if changed && self.persist_state().is_err() {
            self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
        }
    }

    fn replay_spawn_spec(
        &self,
        spec: &SpawnSpec,
        now: Instant,
    ) -> Result<Option<Result<ResolvedSpawnReceipt, NodeFailure>>, NodeFailure> {
        let mut cache = self
            .spawn_idempotency
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        cache.entries.retain(|_, entry| entry.expires_at > now);
        if let Some(entry) = cache.entries.get(&spec.idempotency_key) {
            let SpawnIdempotencyValue::Standard { spec: existing, result } = &entry.value else {
                return Err(failure(
                    NodeFailureCode::SpawnIdempotencyConflict,
                    "spawn idempotency key was reused across spawn kinds",
                ));
            };
            if existing != spec {
                return Err(failure(
                    NodeFailureCode::SpawnIdempotencyConflict,
                    "spawn idempotency key was reused with a different specification",
                ));
            }
            return Ok(Some(result.clone()));
        }
        if cache.entries.len() >= SPAWN_IDEMPOTENCY_MAX_ENTRIES {
            return Err(failure(
                NodeFailureCode::SpawnIdempotencyCapacity,
                "spawn idempotency cache reached its bounded capacity",
            ));
        }
        Ok(None)
    }

    fn remember_spawn_spec(
        &self,
        spec: SpawnSpec,
        result: Result<ResolvedSpawnReceipt, NodeFailure>,
        accepted_at: Instant,
    ) {
        self
            .spawn_idempotency
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .entries
            .insert(
                spec.idempotency_key.clone(),
                SpawnIdempotencyEntry {
                    value: SpawnIdempotencyValue::Standard { spec, result },
                    expires_at: accepted_at + Duration::from_millis(SPAWN_IDEMPOTENCY_TTL_MS),
                },
            );
    }

    fn claim_harness_mcp_spawn(
        &self,
        _reservation_id: &HarnessMcpReservationId,
        _activation_digest: &HarnessMcpActivationDigest,
        spec: &SpawnSpec,
        now: Instant,
    ) -> Result<(), NodeFailure> {
        let mut cache = self.spawn_idempotency.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        cache.entries.retain(|_, entry| entry.expires_at > now);
        if cache.entries.contains_key(&spec.idempotency_key) {
            return Err(failure(
                NodeFailureCode::SpawnIdempotencyConflict,
                "spawn idempotency key was reused across spawn kinds",
            ));
        }
        if cache.entries.len() >= SPAWN_IDEMPOTENCY_MAX_ENTRIES {
            return Err(failure(
                NodeFailureCode::SpawnIdempotencyCapacity,
                "spawn idempotency cache reached its bounded capacity",
            ));
        }
        cache.entries.insert(spec.idempotency_key.clone(), SpawnIdempotencyEntry {
            value: SpawnIdempotencyValue::HarnessMcp,
            expires_at: now + Duration::from_millis(SPAWN_IDEMPOTENCY_TTL_MS),
        });
        Ok(())
    }

    fn replay_managed_spawn(
        &self,
        request: &ManagedWorktreeSpawnRequest,
        now: Instant,
    ) -> Result<Option<Result<ManagedWorktreeSpawnReceipt, NodeFailure>>, NodeFailure> {
        let mut cache = self.spawn_idempotency.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        cache.entries.retain(|_, entry| entry.expires_at > now);
        if let Some(entry) = cache.entries.get(&request.spawn_spec.idempotency_key) {
            let SpawnIdempotencyValue::Managed { request: existing, result } = &entry.value else {
                return Err(failure(
                    NodeFailureCode::SpawnIdempotencyConflict,
                    "spawn idempotency key was reused across spawn kinds",
                ));
            };
            if existing != request {
                return Err(failure(
                    NodeFailureCode::SpawnIdempotencyConflict,
                    "spawn idempotency key was reused with a different managed specification",
                ));
            }
            return Ok(Some(result.clone()));
        }
        if cache.entries.len() >= SPAWN_IDEMPOTENCY_MAX_ENTRIES {
            return Err(failure(
                NodeFailureCode::SpawnIdempotencyCapacity,
                "spawn idempotency cache reached its bounded capacity",
            ));
        }
        Ok(None)
    }

    fn remember_managed_spawn(
        &self,
        request: ManagedWorktreeSpawnRequest,
        result: Result<ManagedWorktreeSpawnReceipt, NodeFailure>,
        accepted_at: Instant,
    ) {
        self.spawn_idempotency.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .entries
            .insert(
                request.spawn_spec.idempotency_key.clone(),
                SpawnIdempotencyEntry {
                    value: SpawnIdempotencyValue::Managed { request, result },
                    expires_at: accepted_at + Duration::from_millis(SPAWN_IDEMPOTENCY_TTL_MS),
                },
            );
    }

    fn remember_managed_spawn_attempt(
        &self,
        durable_v2_key: Option<&SpawnIdempotencyKey>,
        request: ManagedWorktreeSpawnRequest,
        result: Result<ManagedWorktreeSpawnReceipt, NodeFailure>,
        accepted_at: Instant,
    ) {
        if durable_v2_key.is_none() {
            self.remember_managed_spawn(request, result, accepted_at);
        }
    }

    fn acquire_durable_managed_spawn_v2(
        &self,
        request: &ManagedWorktreeSpawnRequestV2,
        request_digest: String,
    ) -> Result<DurableManagedSpawnReplayDecision, NodeFailure> {
        if self.state_path.is_none() {
            return Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "managed worktree V2 requires durable node state",
            ));
        }
        let _transaction = self.state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let key = request.spawn_spec.idempotency_key.clone();
        let mut previous = None;
        {
            let mut replays = self.managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if let Some(record) = replays.get_mut(&key) {
                if record.request_digest != request_digest {
                    return Err(failure(
                        NodeFailureCode::SpawnIdempotencyConflict,
                        "managed worktree V2 idempotency key was reused with a different request",
                    ));
                }
                match &record.state {
                    ManagedWorktreeSpawnReplayStateV10::Pending {
                        owner_incarnation_id,
                        lease_id: None,
                    } if owner_incarnation_id != &self.incarnation_id => {
                        previous = Some(record.clone());
                        record.state = ManagedWorktreeSpawnReplayStateV10::Pending {
                            owner_incarnation_id: self.incarnation_id,
                            lease_id: None,
                        };
                        record.updated_at_unix_ms = unix_time_ms();
                    }
                    ManagedWorktreeSpawnReplayStateV10::Pending {
                        lease_id: None,
                        ..
                    } => {
                        return Err(failure(
                            NodeFailureCode::BackendBusy,
                            "managed worktree V2 reservation is already active",
                        ));
                    }
                    ManagedWorktreeSpawnReplayStateV10::Pending {
                        lease_id: Some(_),
                        ..
                    } => {
                        return Ok(DurableManagedSpawnReplayDecision::PendingLinked);
                    }
                    ManagedWorktreeSpawnReplayStateV10::Committed { receipt } => {
                        return Ok(DurableManagedSpawnReplayDecision::Committed(
                            receipt.clone(),
                        ));
                    }
                }
            } else if replays.len() >= MAX_MANAGED_WORKTREE_SPAWN_REPLAYS {
                return Err(failure(
                    NodeFailureCode::SpawnIdempotencyCapacity,
                    "durable managed worktree replay ledger reached its bounded capacity",
                ));
            } else {
                let now = unix_time_ms();
                replays.insert(key.clone(), ManagedWorktreeSpawnReplayRecordV10 {
                    idempotency_key: key.clone(),
                    request_digest,
                    source_workspace_id: request.spawn_spec.target.workspace_id.clone(),
                    profile_id: request.worktree_profile_id.clone(),
                    expected_profile_revision: request.expected_profile_revision.clone(),
                    state: ManagedWorktreeSpawnReplayStateV10::Pending {
                        owner_incarnation_id: self.incarnation_id,
                        lease_id: None,
                    },
                    created_at_unix_ms: now,
                    updated_at_unix_ms: now,
                });
            }
        }
        if let Err(error) = self.persist_state_locked() {
            let mut replays = self.managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            match previous {
                Some(previous) => {
                    replays.insert(key, previous);
                }
                None => {
                    replays.remove(&key);
                }
            }
            return Err(persistence_failure(error));
        }
        Ok(DurableManagedSpawnReplayDecision::Reserved)
    }

    fn link_durable_managed_spawn_v2_lease_locked(
        &self,
        key: &SpawnIdempotencyKey,
        lease_id: &ManagedWorktreeLeaseId,
    ) -> Result<ManagedWorktreeSpawnReplayRecordV10, NodeFailure> {
        let mut replays = self.managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let record = replays.get_mut(key).ok_or_else(|| {
            failure(
                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                "managed worktree V2 reservation disappeared before allocation",
            )
        })?;
        let previous = record.clone();
        match &mut record.state {
            ManagedWorktreeSpawnReplayStateV10::Pending {
                lease_id: current,
                ..
            }
                if current.is_none() =>
            {
                *current = Some(lease_id.clone());
                record.updated_at_unix_ms = unix_time_ms();
                Ok(previous)
            }
            _ => Err(failure(
                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                "managed worktree V2 reservation is not allocation-ready",
            )),
        }
    }

    fn restore_durable_managed_spawn_v2_locked(
        &self,
        key: &SpawnIdempotencyKey,
        previous: ManagedWorktreeSpawnReplayRecordV10,
    ) {
        self.managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(key.clone(), previous);
    }

    fn commit_durable_managed_spawn_v2(
        &self,
        request: &ManagedWorktreeSpawnRequestV2,
        receipt: ManagedWorktreeSpawnReceipt,
    ) -> Result<(), NodeFailure> {
        let _transaction = self.state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let key = &request.spawn_spec.idempotency_key;
        let previous = {
            let mut replays = self.managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let record = replays.get_mut(key).ok_or_else(|| {
                failure(
                    NodeFailureCode::ManagedWorktreeRecoveryRequired,
                    "managed worktree V2 reservation disappeared before commit",
                )
            })?;
            let previous = record.clone();
            match &record.state {
                ManagedWorktreeSpawnReplayStateV10::Pending {
                    lease_id: Some(lease_id),
                    ..
                } if lease_id == &receipt.lease.lease_id => {}
                _ => {
                    return Err(failure(
                        NodeFailureCode::ManagedWorktreeRecoveryRequired,
                        "managed worktree V2 reservation is not linked to the spawned lease",
                    ));
                }
            }
            record.state = ManagedWorktreeSpawnReplayStateV10::Committed { receipt };
            record.updated_at_unix_ms = unix_time_ms();
            previous
        };
        if let Err(error) = self.persist_state_locked() {
            self.restore_durable_managed_spawn_v2_locked(key, previous);
            return Err(persistence_failure(error));
        }
        Ok(())
    }

    fn remove_unallocated_durable_managed_spawn_v2(
        &self,
        request: &ManagedWorktreeSpawnRequestV2,
    ) -> Result<(), NodeFailure> {
        let _transaction = self.state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let key = &request.spawn_spec.idempotency_key;
        let removed = {
            let mut replays = self.managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            match replays.get(key).map(|record| &record.state) {
                Some(ManagedWorktreeSpawnReplayStateV10::Pending {
                    lease_id: None,
                    ..
                }) => {
                    replays.remove(key)
                }
                _ => None,
            }
        };
        let Some(removed) = removed else {
            return Ok(());
        };
        if let Err(error) = self.persist_state_locked() {
            self.managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(key.clone(), removed);
            return Err(persistence_failure(error));
        }
        Ok(())
    }

    fn resolve_spawn_spec(&self, spec: &SpawnSpec) -> Result<ResolvedSpawnSpec, NodeFailure> {
        if spec.target.node_id != self.node_id {
            return Err(failure(
                NodeFailureCode::SpawnTargetMismatch,
                "spawn target does not match this node",
            ));
        }
        let defaults = self.spawn_profiles.get(&spec.profile_id).ok_or_else(|| {
            failure(
                NodeFailureCode::UnknownSpawnProfile,
                "spawn profile is unavailable on this node",
            )
        })?;
        let resolved = spec.resolve(defaults).map_err(|error| match error {
            SpawnSpecResolveError::ProfileRevisionMismatch { .. } => failure(
                NodeFailureCode::SpawnProfileRevisionMismatch,
                "spawn profile revision does not match the loaded profile",
            ),
            _ => failure(
                NodeFailureCode::InvalidRequest,
                "spawn specification could not be resolved",
            ),
        })?;
        if resolved.target.worktree_id.is_some() {
            self.require_worktree_service(&resolved.target.workspace_id)?;
        }
        let environment_profile = self.resolve_environment_profile(&resolved)?;
        self.resolve_bundle(&resolved, environment_profile.as_ref())?;
        self.resolve_context(&resolved)?;
        Ok(resolved)
    }

    async fn resolve_spawn_workspace(
        &self,
        resolved: &ResolvedSpawnSpec,
        deadline: Instant,
    ) -> Result<WorkspaceId, NodeFailure> {
        let Some(worktree_id) = resolved.target.worktree_id.as_ref() else {
            return Ok(resolved.target.workspace_id.clone());
        };
        if self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .lease_for_workspace(worktree_id)
            .is_some()
        {
            return Err(failure(
                NodeFailureCode::ManagedWorktreeOwnershipConflict,
                "managed worktree targets may only be spawned through their lease request",
            ));
        }
        self.require_worktree_service(&resolved.target.workspace_id)?;
        let source_root = self.workspace_root(&resolved.target.workspace_id)?;
        let selected_root = self.workspace_root(worktree_id)?;
        let remaining = spawn_deadline_remaining(deadline)?;
        let worktrees = timeout(remaining, list_git_worktrees(&source_root))
            .await
            .map_err(|_| {
                failure(
                    NodeFailureCode::SpawnDeadlineExceeded,
                    "Git worktree selection exceeded the spawn deadline",
                )
            })?
            .map_err(git_worktree_failure)?;
        validate_selected_worktree(&source_root, &selected_root, &worktrees)?;
        Ok(worktree_id.clone())
    }

    async fn spawn_from_spec(
        &self,
        spec: SpawnSpec,
    ) -> Result<ResolvedSpawnReceipt, NodeFailure> {
        self.spawn_from_spec_with_proxy(spec, None).await
    }

    async fn spawn_from_spec_with_proxy(
        &self,
        spec: SpawnSpec,
        harness_mcp: Option<&PreparedHarnessMcpSpawn>,
    ) -> Result<ResolvedSpawnReceipt, NodeFailure> {
        let accepted_at = Instant::now();
        if harness_mcp.is_none() {
            if let Some(replayed) = self.replay_spawn_spec(&spec, accepted_at)? {
                return replayed;
            }
        }
        let resolved = self.resolve_spawn_spec(&spec)?;
        let environment_profile = self.resolve_environment_profile(&resolved)?;
        let bundle = self.resolve_bundle(&resolved, environment_profile.as_ref())?;
        let context = self.resolve_context(&resolved)?;
        let required_capabilities = spawn_runtime_capabilities(&resolved.required_capabilities)?;
        let deadline = accepted_at + Duration::from_millis(resolved.deadline_ms.get());
        let spawn_workspace_id = self.resolve_spawn_workspace(&resolved, deadline).await;
        let spawn_workspace_id = match spawn_workspace_id {
            Ok(workspace_id) => workspace_id,
            Err(error) => {
                let result = Err(error);
                if harness_mcp.is_none() {
                    self.remember_spawn_spec(spec, result.clone(), accepted_at);
                }
                return result;
            }
        };
        if self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .lease_for_workspace(&spawn_workspace_id)
            .is_some()
        {
            let result = Err(failure(
                NodeFailureCode::ManagedWorktreeOwnershipConflict,
                "managed worktree targets may only be spawned through their lease request",
            ));
            if harness_mcp.is_none() {
                self.remember_spawn_spec(spec, result.clone(), accepted_at);
            }
            return result;
        }
        let result = self
            .spawn_session_with_deadline(
                spawn_workspace_id,
                resolved.provider.clone(),
                resolved.mode,
                resolved.terminal_size,
                resolved.prompt.as_ref().map(|prompt| prompt.as_str().to_owned()),
                environment_profile.clone(),
                bundle.clone(),
                context.clone(),
                None,
                None,
                SpawnRecordPolicy::Always,
                Some(deadline),
                &required_capabilities,
                harness_mcp,
                resolved.approval_level,
                resolved.network_allowlist.clone(),
                resolved.browser_profile_id.clone(),
            )
            .await
            .map(|(session, _runtime_policy)| {
                resolved.receipt_with_materialization(
                    self.incarnation_id,
                    session,
                    environment_profile,
                    bundle,
                    context,
                )
            });
        if harness_mcp.is_none() {
            self.remember_spawn_spec(spec, result.clone(), accepted_at);
        }
        result
    }

    async fn spawn_from_spec_with_harness_mcp(
        &self,
        reservation_id: HarnessMcpReservationId,
        activation_digest: HarnessMcpActivationDigest,
        spec: SpawnSpec,
        deadline_unix_ms: u64,
    ) -> Result<ResolvedSpawnReceipt, NodeFailure> {
        let registry = self.harness_mcp_registry.as_ref().ok_or_else(|| {
            failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP proxy is not configured")
        })?;
        if let Some(receipt) = registry
            .replay_spawn(&reservation_id, &activation_digest, &spec)
            .map_err(harness_mcp_failure)?
        {
            return Ok(receipt);
        }
        let resolved = self.resolve_spawn_spec(&spec)?;
        let prepared = registry
            .prepare_spawn(
                &reservation_id,
                &activation_digest,
                &spec,
                deadline_unix_ms,
                resolved.provider.clone(),
            )
            .map_err(harness_mcp_failure)?;
        self.claim_harness_mcp_spawn(
            &reservation_id,
            &activation_digest,
            &spec,
            Instant::now(),
        )?;
        let spawn = self.spawn_from_spec_with_proxy(spec, Some(&prepared)).await;
        let mut receipt = match spawn {
            Ok(receipt) => receipt,
            Err(error) => {
                let _ = registry.abort(&reservation_id, &activation_digest);
                return Err(error);
            }
        };
        let record_id = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&receipt.session.session.instance_id)
            .and_then(|binding| binding.record_id.clone());
        let record_id = match record_id {
            Some(record_id) => record_id,
            None => {
                let rollback = self.remove_session(&receipt.session).await;
                let _ = registry.abort(&reservation_id, &activation_digest);
                if let Err(rollback_error) = rollback {
                    return Err(rollback_error);
                }
                return Err(failure(
                    NodeFailureCode::BindingMismatch,
                    "harness MCP spawn did not retain its exact managed record",
                ));
            }
        };
        receipt.harness_mcp_proxy = Some(ResolvedHarnessMcpProxyReceiptV1 {
            reservation_id: reservation_id.clone(),
            activation_digest: activation_digest.clone(),
        });
        if let Err(error) = registry.mark_spawned(
            &prepared,
            receipt.session.clone(),
            record_id,
            receipt.clone(),
        ) {
            let rollback = self.remove_session(&receipt.session).await;
            let _ = registry.abort(&reservation_id, &activation_digest);
            if let Err(rollback_error) = rollback {
                return Err(rollback_error);
            }
            return Err(harness_mcp_failure(error));
        }
        Ok(receipt)
    }

    async fn spawn_managed_worktree(
        &self,
        request: ManagedWorktreeSpawnRequest,
    ) -> Result<ManagedWorktreeSpawnReceipt, NodeFailure> {
        self.spawn_managed_worktree_inner(request, None).await
    }

    async fn spawn_managed_worktree_inner(
        &self,
        request: ManagedWorktreeSpawnRequest,
        durable_v2_key: Option<&SpawnIdempotencyKey>,
    ) -> Result<ManagedWorktreeSpawnReceipt, NodeFailure> {
        let accepted_at = Instant::now();
        if durable_v2_key.is_none() {
            if let Some(replayed) = self.replay_managed_spawn(&request, accepted_at)? {
                return replayed;
            }
        }
        let resolved = self.resolve_spawn_spec(&request.spawn_spec)?;
        if request.spawn_spec.target.worktree_id.is_some() {
            let result = Err(failure(
                NodeFailureCode::InvalidRequest,
                "managed worktree spawn must not select a caller-provided worktree",
            ));
            self.remember_managed_spawn_attempt(
                durable_v2_key,
                request,
                result.clone(),
                accepted_at,
            );
            return result;
        }
        let environment_profile = self.resolve_environment_profile(&resolved)?;
        let bundle = self.resolve_bundle(&resolved, environment_profile.as_ref())?;
        let context = self.resolve_context(&resolved)?;
        let source_workspace_id = resolved.target.workspace_id.clone();
        let profile = self.managed_profile(&source_workspace_id, &request.worktree_profile_id)?;
        let deadline = accepted_at + Duration::from_millis(resolved.deadline_ms.get());
        let required_capabilities = spawn_runtime_capabilities(&resolved.required_capabilities)?;
        let runtime_requirement = match (resolved.mode, resolved.prompt.is_some()) {
            (SessionMode::Pty, false) => ProviderRuntimeRequirement::RawPty,
            (SessionMode::Pty, true) => ProviderRuntimeRequirement::SemanticPrompt,
            (SessionMode::Inline, _) => ProviderRuntimeRequirement::Inline,
            (SessionMode::Acp, _) => ProviderRuntimeRequirement::Acp,
        };
        let runtime_policy = timeout(
            spawn_deadline_remaining(deadline)?,
            self.admit_provider_runtime(&resolved.provider, runtime_requirement),
        ).await.map_err(|_| failure(
            NodeFailureCode::SpawnDeadlineExceeded,
            "provider admission exceeded the managed spawn deadline",
        ))??;
        if required_capabilities.iter().any(|capability| !runtime_policy.admits(*capability)) {
            return Err(failure(
                NodeFailureCode::UnsupportedSpawnCapability,
                "provider runtime does not admit a required spawn capability",
            ));
        }
        self.ensure_binding_capacity()?;
        let source_root = self.workspace_root(&source_workspace_id)?;
        profile.validate_for_workspace(&source_root)
            .map_err(|message| failure(NodeFailureCode::ManagedWorktreeOwnershipConflict, &message))?;
        let base_timeout_ms = u64::try_from(
            spawn_deadline_remaining(deadline)?.as_millis(),
        ).unwrap_or(u64::MAX).max(1);
        let base_commit = resolve_base_commit_with_timeout(
            &source_root,
            profile.base(),
            base_timeout_ms,
        ).await.map_err(|error| {
            if Instant::now() >= deadline || error.message.contains("timed out") {
                failure(
                    NodeFailureCode::SpawnDeadlineExceeded,
                    "managed worktree base resolution exceeded the spawn deadline",
                )
            } else {
                managed_git_worktree_failure(error)
            }
        })?;

        let lease = {
            let _transaction = self.state_transaction.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let previous = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner()).clone();
            let lease = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .allocate(source_workspace_id.clone(), &profile, base_commit.clone(), unix_time_ms())
                .map_err(|message| failure(NodeFailureCode::BackendBusy, &message))?;
            let previous_replay = match durable_v2_key
                .map(|key| self.link_durable_managed_spawn_v2_lease_locked(key, &lease.lease_id))
                .transpose()
            {
                Ok(previous) => previous,
                Err(error) => {
                    *self.managed_worktrees.lock()
                        .unwrap_or_else(|poisoned| poisoned.into_inner()) = previous;
                    return Err(error);
                }
            };
            if let Err(error) = self.persist_state_locked() {
                *self.managed_worktrees.lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner()) = previous;
                if let (Some(key), Some(previous_replay)) =
                    (durable_v2_key, previous_replay)
                {
                    self.restore_durable_managed_spawn_v2_locked(key, previous_replay);
                }
                return Err(persistence_failure(error));
            }
            lease
        };
        self.publish(NodeEvent::ManagedWorktreeUpserted { lease: lease.snapshot() });
        if let Err(message) = profile.validate_target_authority(&lease.lease_id, &lease.target_root) {
            self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .remove_unmutated(&lease.lease_id);
            if self.persist_state().is_err() {
                self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
            }
            let result = Err(failure(NodeFailureCode::ManagedWorktreeOwnershipConflict, &message));
            self.remember_managed_spawn_attempt(
                durable_v2_key,
                request,
                result.clone(),
                accepted_at,
            );
            return result;
        }
        let mutation_timeout_ms = match spawn_deadline_remaining(deadline) {
            Ok(remaining) => u64::try_from(remaining.as_millis()).unwrap_or(u64::MAX).max(1),
            Err(error) => {
                self.reconcile_failed_allocation(&lease, &source_root).await;
                let result = Err(error);
                self.remember_managed_spawn_attempt(
                    durable_v2_key,
                    request,
                    result.clone(),
                    accepted_at,
                );
                return result;
            }
        };
        let created = match create_git_worktree_with_timeout(
                &source_root,
                &lease.target_root,
                &lease.branch,
                Some(&base_commit),
                mutation_timeout_ms,
            ).await {
            Ok(created) => created,
            Err(error) => {
                self.reconcile_failed_allocation(&lease, &source_root).await;
                let result = Err(if Instant::now() >= deadline
                    || error.message.contains("timed out")
                    || error.message.contains("deadline")
                {
                    failure(
                        NodeFailureCode::SpawnDeadlineExceeded,
                        "managed worktree creation exceeded the spawn deadline",
                    )
                } else {
                    managed_git_worktree_failure(error)
                });
                self.remember_managed_spawn_attempt(
                    durable_v2_key,
                    request,
                    result.clone(),
                    accepted_at,
                );
                return result;
            }
        };
        if !exact_created_worktree(&lease, &created.path, created.branch.as_deref(), &created.head) {
            self.mark_managed_recovery_required(&lease.lease_id, ManagedWorktreeCleanupFailure::OwnershipConflict);
            let result = Err(failure(
                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                "created worktree identity did not match its durable lease",
            ));
            self.remember_managed_spawn_attempt(
                durable_v2_key,
                request,
                result.clone(),
                accepted_at,
            );
            return result;
        }
        {
            let mut registry = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let current = registry.get_mut(&lease.lease_id)
                .expect("allocated managed worktree lease remains present");
            current.expected_head = Some(created.head.clone());
            current.state = ManagedWorktreeLeaseState::Ready;
            current.updated_at_unix_ms = unix_time_ms();
        }
        if let Err(error) = self.persist_state() {
            self.mark_managed_recovery_required(
                &lease.lease_id,
                ManagedWorktreeCleanupFailure::Backend,
            );
            let result = Err(persistence_failure(error));
            self.remember_managed_spawn_attempt(
                durable_v2_key,
                request,
                result.clone(),
                accepted_at,
            );
            return result;
        }
        let ready = self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&lease.lease_id)
            .expect("ready managed worktree lease remains present")
            .snapshot();
        self.publish(NodeEvent::ManagedWorktreeUpserted { lease: ready });
        if let Err(error) = self.register_workspace(lease.workspace_id.clone(), created.path.clone()).await {
            let _ = self.cleanup_managed_worktree(&lease.lease_id, true).await;
            let result = Err(error);
            self.remember_managed_spawn_attempt(
                durable_v2_key,
                request,
                result.clone(),
                accepted_at,
            );
            return result;
        }
        let spawn = self.spawn_session_with_deadline(
            lease.workspace_id.clone(),
            resolved.provider.clone(),
            resolved.mode,
            resolved.terminal_size,
            resolved.prompt.as_ref().map(|prompt| prompt.as_str().to_owned()),
            environment_profile.clone(),
            bundle.clone(),
            context.clone(),
            Some(lease.lease_id.clone()),
            Some(runtime_policy),
            SpawnRecordPolicy::Always,
            Some(deadline),
            &required_capabilities,
            None,
            resolved.approval_level,
            resolved.network_allowlist.clone(),
            resolved.browser_profile_id.clone(),
        ).await;
        let (session, effective_runtime_policy) = match spawn {
            Ok(spawned) => spawned,
            Err(error) => {
                if self
                    .cleanup_managed_worktree(&lease.lease_id, true)
                    .await
                    .is_err()
                {
                    self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::Backend,
                    );
                }
                let result = Err(error);
                self.remember_managed_spawn_attempt(
                    durable_v2_key,
                    request,
                    result.clone(),
                    accepted_at,
                );
                return result;
            }
        };
        let (record_id, raw_inventory_record_id) = {
            let mut bindings = self.session_bindings.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let binding = bindings.get_mut(&session.session.instance_id)
                .expect("successful spawn retains its session binding");
            binding.managed_worktree_lease_id = Some(lease.lease_id.clone());
            managed_spawn_record_ownership(binding, effective_runtime_policy)
        };
        let bound = self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .bind_session(
                &lease.lease_id,
                ManagedWorktreeSessionHolder {
                    incarnation_id: self.incarnation_id,
                    instance_id: session.session.instance_id,
                    generation: session.session.generation,
                },
                record_id,
                unix_time_ms(),
            )
            .map_err(|message| failure(NodeFailureCode::ManagedWorktreeRecoveryRequired, &message));
        let snapshot = match bound {
            Ok(snapshot) => snapshot,
            Err(error) => {
                if raw_inventory_record_id
                    .as_ref()
                    .is_some_and(|record_id| self.discard_record(record_id).is_err())
                {
                    self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::Backend,
                    );
                }
                let _ = self.remove_session(&session).await;
                self.mark_managed_recovery_required(
                    &lease.lease_id,
                    ManagedWorktreeCleanupFailure::Backend,
                );
                let result = Err(error);
                self.remember_managed_spawn_attempt(
                    durable_v2_key,
                    request,
                    result.clone(),
                    accepted_at,
                );
                return result;
            }
        };
        if let Err(error) = self.persist_state() {
            if raw_inventory_record_id
                .as_ref()
                .is_some_and(|record_id| self.discard_record(record_id).is_err())
            {
                self.mark_managed_recovery_required(
                    &lease.lease_id,
                    ManagedWorktreeCleanupFailure::Backend,
                );
            }
            let _ = self.remove_session(&session).await;
            if self
                .cleanup_managed_worktree(&lease.lease_id, true)
                .await
                .is_err()
            {
                self.mark_managed_recovery_required(
                    &lease.lease_id,
                    ManagedWorktreeCleanupFailure::Backend,
                );
            }
            let result = Err(persistence_failure(error));
            self.remember_managed_spawn_attempt(
                durable_v2_key,
                request,
                result.clone(),
                accepted_at,
            );
            return result;
        }
        self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot.clone() });
        let receipt = managed_spawn_receipt(
            &resolved,
            self.incarnation_id,
            session,
            snapshot,
            environment_profile,
            bundle,
            context,
        );
        let result = Ok(receipt);
        self.remember_managed_spawn_attempt(
            durable_v2_key,
            request,
            result.clone(),
            accepted_at,
        );
        result
    }

    async fn spawn_managed_worktree_v2(
        &self,
        request: ManagedWorktreeSpawnRequestV2,
    ) -> Result<ManagedWorktreeSpawnReceipt, NodeFailure> {
        if request.spawn_spec.target.node_id != self.node_id {
            return Err(failure(
                NodeFailureCode::SpawnTargetMismatch,
                "spawn target does not match this node",
            ));
        }
        if request.spawn_spec.target.worktree_id.is_some() {
            return Err(failure(
                NodeFailureCode::InvalidRequest,
                "managed worktree spawn must not select a caller-provided worktree",
            ));
        }
        let request_digest = managed_spawn_request_digest_v2(&request)?;
        let replay = self.acquire_durable_managed_spawn_v2(&request, request_digest)?;
        match replay {
            DurableManagedSpawnReplayDecision::Committed(receipt) => return Ok(receipt),
            DurableManagedSpawnReplayDecision::PendingLinked => {
                return Err(failure(
                    NodeFailureCode::ManagedWorktreeRecoveryRequired,
                    "managed worktree V2 reservation has an incomplete durable allocation",
                ));
            }
            DurableManagedSpawnReplayDecision::Reserved => {}
        }
        let validated = (|| {
            let resolved = self.resolve_spawn_spec(&request.spawn_spec)?;
            let profile = self.managed_profile(
                &resolved.target.workspace_id,
                &request.worktree_profile_id,
            )?;
            if profile.revision() != &request.expected_profile_revision {
                return Err(failure(
                    NodeFailureCode::ManagedWorktreeProfileRevisionMismatch,
                    "managed worktree profile revision does not match the loaded profile",
                ));
            }
            Ok(())
        })();
        match validated {
            Ok(()) => {}
            Err(error) => {
                self.remove_unallocated_durable_managed_spawn_v2(&request)?;
                return Err(error);
            }
        }
        let legacy = ManagedWorktreeSpawnRequest {
            spawn_spec: request.spawn_spec.clone(),
            worktree_profile_id: request.worktree_profile_id.clone(),
        };
        match self
            .spawn_managed_worktree_inner(
                legacy,
                Some(&request.spawn_spec.idempotency_key),
            )
            .await
        {
            Ok(receipt) => {
                self.commit_durable_managed_spawn_v2(&request, receipt.clone())?;
                Ok(receipt)
            }
            Err(error) => {
                self.remove_unallocated_durable_managed_spawn_v2(&request)?;
                Err(error)
            }
        }
    }

    fn managed_profile(
        &self,
        workspace_id: &WorkspaceId,
        profile_id: &WorktreeProfileId,
    ) -> Result<ManagedWorktreeProfile, NodeFailure> {
        if self.worktree_service_modes.get(workspace_id).copied()
            != Some(WorktreeServiceMode::Managed)
        {
            return Err(failure(
                NodeFailureCode::UnsupportedSpawnCapability,
                "workspace does not enable managed worktrees",
            ));
        }
        self.managed_worktree_profiles.get(workspace_id)
            .and_then(|profiles| profiles.get(profile_id))
            .cloned()
            .ok_or_else(|| failure(
                NodeFailureCode::InvalidRequest,
                "managed worktree profile is unavailable for this workspace",
            ))
    }

    async fn reconcile_failed_allocation(
        &self,
        lease: &ManagedWorktreeLeaseRecord,
        source_root: &str,
    ) {
        match list_git_worktrees(source_root).await {
            Ok(worktrees) => {
                match worktrees.iter().find(|item| worktree_paths_equal(&item.path, &lease.target_root)) {
                    None => {
                        match std::fs::symlink_metadata(&lease.target_root) {
                            Err(error) if error.kind() == io::ErrorKind::NotFound => {
                                self.managed_worktrees.lock()
                                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                                    .remove_unmutated(&lease.lease_id);
                                let _ = self.persist_state();
                            }
                            _ => self.mark_managed_recovery_required(
                                &lease.lease_id,
                                ManagedWorktreeCleanupFailure::OwnershipConflict,
                            ),
                        }
                    }
                    Some(item) if exact_owned_worktree(
                        lease,
                        &item.path,
                        item.branch.as_deref(),
                        &item.head,
                    ) => {
                        let _ = self.cleanup_managed_worktree(&lease.lease_id, true).await;
                    }
                    Some(_) => self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::OwnershipConflict,
                    ),
                }
            }
            Err(_) => self.mark_managed_recovery_required(
                &lease.lease_id,
                ManagedWorktreeCleanupFailure::Backend,
            ),
        }
    }

    async fn reconcile_managed_worktrees(&self) {
        let leases = self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .active_records()
            .cloned()
            .collect::<Vec<_>>();
        for lease in leases {
            let profile = match self.managed_profile(&lease.source_workspace_id, &lease.profile_id) {
                Ok(profile) if profile.revision() == &lease.profile_revision => profile,
                _ => {
                    self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::OwnershipConflict,
                    );
                    continue;
                }
            };
            if profile.validate_target_authority(&lease.lease_id, &lease.target_root).is_err() {
                self.mark_managed_recovery_required(
                    &lease.lease_id,
                    ManagedWorktreeCleanupFailure::OwnershipConflict,
                );
                continue;
            }
            let source_root = match self.workspace_root(&lease.source_workspace_id) {
                Ok(root) => root,
                Err(_) => {
                    self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::OwnershipConflict,
                    );
                    continue;
                }
            };
            let worktrees = match list_git_worktrees(&source_root).await {
                Ok(worktrees) => worktrees,
                Err(_) => {
                    self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::Backend,
                    );
                    continue;
                }
            };
            let listed = worktrees.iter()
                .find(|item| worktree_paths_equal(&item.path, &lease.target_root));
            let Some(listed) = listed else {
                match std::fs::symlink_metadata(&lease.target_root) {
                    Err(error) if error.kind() == io::ErrorKind::NotFound
                        && lease.state == ManagedWorktreeLeaseState::Allocating
                        && !lease.has_holders() => {
                            let removed = self.managed_worktrees.lock()
                                .unwrap_or_else(|poisoned| poisoned.into_inner())
                                .tombstone(&lease.lease_id, unix_time_ms());
                            if self.persist_state().is_ok() && removed.is_some() {
                                self.publish(NodeEvent::ManagedWorktreeRemoved {
                                    lease_id: lease.lease_id.clone(),
                                });
                            }
                        }
                    _ => self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::OwnershipConflict,
                    ),
                }
                continue;
            };
            if listed.is_main || listed.is_bare || !exact_owned_worktree(
                &lease,
                &listed.path,
                listed.branch.as_deref(),
                &listed.head,
            ) {
                self.mark_managed_recovery_required(
                    &lease.lease_id,
                    ManagedWorktreeCleanupFailure::OwnershipConflict,
                );
                continue;
            }
            if !self.workspaces.read()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .contains_key(&lease.workspace_id)
            {
                if self.register_workspace(lease.workspace_id.clone(), listed.path.clone()).await.is_err() {
                    self.mark_managed_recovery_required(
                        &lease.lease_id,
                        ManagedWorktreeCleanupFailure::Backend,
                    );
                    continue;
                }
            }
            let snapshot = {
                let mut registry = self.managed_worktrees.lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let current = registry.get_mut(&lease.lease_id)
                    .expect("reconciled managed lease remains present");
                current.expected_head = Some(listed.head.clone());
                current.cleanup_failure = None;
                current.state = if current.has_holders() {
                    ManagedWorktreeLeaseState::InUse
                } else if current.retention == ManagedWorktreeRetention::Retain {
                    ManagedWorktreeLeaseState::Retained
                } else {
                    ManagedWorktreeLeaseState::Ready
                };
                current.updated_at_unix_ms = unix_time_ms();
                current.snapshot()
            };
            if self.persist_state().is_err() {
                self.mark_managed_recovery_required(
                    &lease.lease_id,
                    ManagedWorktreeCleanupFailure::Backend,
                );
                continue;
            }
            self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot.clone() });
            if snapshot.state == ManagedWorktreeLeaseState::Ready {
                let _ = self.cleanup_managed_worktree(&lease.lease_id, false).await;
            }
        }
    }

    /// Crash-recovery startup sweep: durably capture the pack for every
    /// `Live` managed record whose most recent session has not yet produced
    /// one (recovers a session whose `Exited{0}` event was observed but the
    /// Node crashed before the export finished). The reactive fast path for
    /// a single just-exited record does not go through this — see
    /// `drive_runtime_until_shutdown`, which resolves and spawns directly so
    /// it can capture the exact `SessionAddress` before `publish_control`
    /// clears it, rather than re-deriving it from (by then likely already
    /// `Dormant`) record state the way a rescan naturally would.
    ///
    /// Returns as soon as every eligible record's export has been *spawned*,
    /// not completed — each one runs on its own detached task (see
    /// `reconcile_context_pack_export_for_record`'s own doc comment for why:
    /// `NativeRuntime::tick()` has not even started its own loop yet at the
    /// point this is called from `NodeServer::run()`, so nothing could ever
    /// drain the history round trip if this awaited it inline here either).
    /// Best-effort throughout: never panics, no unwrap/expect; every failure
    /// is a silent skip for THIS record — an unusable source or a racing
    /// record is not surfaced to any caller.
    async fn reconcile_context_pack_exports(self: &Arc<Self>) {
        let candidates: Vec<(SessionRecordId, SessionAddress)> = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .values()
            .filter(|record| {
                record.state == ManagedSessionState::Live
                    && record.exported_context.is_none()
                    && record.provider_session.is_some()
            })
            .filter_map(|record| {
                record
                    .active_session
                    .clone()
                    .map(|session| (record.record_id.clone(), session))
            })
            .collect();
        for (record_id, session) in candidates {
            let shared = Arc::clone(self);
            tokio::spawn(async move {
                shared
                    .reconcile_context_pack_export_for_record(&record_id, session)
                    .await;
            });
        }
    }

    /// Runs on its own detached task (`tokio::spawn`, see both call sites),
    /// never inline on `drive_runtime_until_shutdown`'s own task: the history
    /// round trip this performs (`discover_history`/`load_history`, via
    /// `export_context_pack_for_session_record`) can only ever settle once
    /// `NativeRuntime::tick()` runs again to drain the authority worker's
    /// completion — and `tick()` is exclusively owned by, and only ever
    /// called from, that same drive-loop task. Awaiting this inline there
    /// would starve `tick()` and this call could never observe its own
    /// command complete.
    ///
    /// Because this now genuinely races the drive loop's own
    /// `publish_control` (which downgrades this exact record from `Live` to
    /// `Dormant`, clearing `active_session`, for the very `Exited` event that
    /// triggered this reconcile), the record legitimately may already be
    /// `Dormant` by the time this reads it, or may transition mid-flight —
    /// `allow_clean_detachment: true` on the downstream export call is what
    /// tolerates exactly that transition (and only that transition; see
    /// `session_record_export_target_matches`).
    async fn reconcile_context_pack_export_for_record(
        &self,
        record_id: &SessionRecordId,
        session: SessionAddress,
    ) {
        let Ok(record) = self.record(record_id) else {
            return;
        };
        if !matches!(
            record.state,
            ManagedSessionState::Live | ManagedSessionState::Dormant
        ) || record.exported_context.is_some()
            || record.provider_session.is_none()
        {
            return;
        }
        // Pack bytes are already durably committed inside this call, via
        // commit_context_pack_for_session_record's own durable
        // write-through (context_pack_store) — no separate step here.
        // Unclean exits (non-zero/forced/no loadable history) are already
        // rejected by context_pack_source_status_is_usable inside
        // materialize_context_pack: this simply returns Err and is skipped.
        let Ok(receipt) = self
            .export_context_pack_for_session_record(&record.record_id, &session, true)
            .await
        else {
            return;
        };
        self.set_exported_context(&record.record_id, receipt);
    }

    /// Records the record's most recent clean-exit pack. No-op (not an
    /// error) if the record disappeared, or if it already carries an
    /// `exported_context` — first-write-wins, matching the harness-side
    /// idempotent reconciliation that consumes this field.
    fn set_exported_context(&self, record_id: &SessionRecordId, receipt: ResolvedContextPackReceipt) {
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let (previous, updated) = {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(record) = records.records.get_mut(record_id) else {
                return;
            };
            if record.exported_context.is_some() {
                return;
            }
            let previous = record.clone();
            record.exported_context = Some(receipt);
            record.updated_at_unix_ms = unix_time_ms().max(record.updated_at_unix_ms);
            (previous, record.clone())
        };
        if self.persist_state_locked().is_err() {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .insert(record_id.clone(), previous);
            return;
        }
        drop(transaction);
        self.publish_record(updated);
    }

    /// Resolves the managed record and its exact `SessionAddress` currently
    /// bound to `instance_id` at exactly `generation`, used by the reactive
    /// `Exited{0}` hook in `drive_runtime_until_shutdown` to target a single
    /// record without a full rescan. Mirrors the lookup already inlined in
    /// `publish_control`. Captured synchronously, before `publish_control`
    /// for the same event clears the record's own `active_session` — the
    /// caller passes the resolved address through to a detached
    /// reconciliation task rather than re-deriving it from the record later,
    /// after that race has necessarily already happened.
    fn managed_record_export_target_for_instance(
        &self,
        instance_id: AgentInstanceId,
        generation: SessionGeneration,
    ) -> Option<(SessionRecordId, SessionAddress)> {
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let binding = bindings.get(&instance_id).filter(|binding| binding.generation == generation)?;
        let record_id = binding.record_id.clone()?;
        Some((
            record_id,
            SessionAddress {
                workspace_id: binding.workspace_id.clone(),
                session: SessionKey { instance_id, generation },
            },
        ))
    }

    fn mark_managed_recovery_required(
        &self,
        lease_id: &ManagedWorktreeLeaseId,
        failure_kind: ManagedWorktreeCleanupFailure,
    ) {
        let snapshot = {
            let mut registry = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(lease) = registry.get_mut(lease_id) else { return };
            lease.state = ManagedWorktreeLeaseState::RecoveryRequired;
            lease.cleanup_failure = Some(failure_kind);
            lease.updated_at_unix_ms = unix_time_ms();
            lease.snapshot()
        };
        let _ = self.persist_state();
        self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot });
    }

    fn set_persistence_error(&self, error: Option<String>) {
        *self
            .persistence_error
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) = error
            .map(|message| session_registry::sanitized_persistence_summary(&message));
    }

    fn persist_state(&self) -> io::Result<()> {
        let _transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        self.persist_state_locked()
    }

    fn persist_state_locked(&self) -> io::Result<()> {
        let workspaces = self
            .workspaces
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clone();
        let records = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .values()
            .cloned()
            .collect::<Vec<_>>();
        let mut managed = self.managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        managed.reattach_record_holders(
            &managed_worktree_record_holders(&records),
            unix_time_ms(),
        );
        let materializations = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .cloned()
            .collect::<Vec<_>>();
        let managed_spawn_replays = self.managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .cloned()
            .collect::<Vec<_>>();
        let result = session_registry::save_v10(
            self.state_path.as_deref(),
            &self.node_id,
            &workspaces,
            &records,
            &managed.records(),
            &managed.tombstones(),
            &materializations,
            &managed_spawn_replays,
        );
        match &result {
            Ok(warning) => self.set_persistence_error(warning.clone()),
            Err(_) => self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned())),
        }
        result.map(|_| ())
    }

    async fn begin_shutdown(&self) -> Result<(), NodeFailure> {
        let _mutation_guard = self.mutation_gate.lock().await;
        self.begin_shutdown_locked().await
    }

    async fn begin_shutdown_locked(&self) -> Result<(), NodeFailure> {
        if self.shutdown.swap(true, Ordering::AcqRel) {
            return Ok(());
        }
        SessionLifecycleHook::on_shutdown(self);
        let deadline = Instant::now() + Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS);
        let mut first_error = None;
        for session in &self.handle.snapshot().sessions {
            let remaining = deadline.saturating_duration_since(Instant::now());
            if remaining.is_zero() {
                first_error.get_or_insert_with(|| {
                    failure(NodeFailureCode::BackendBusy, "stop-all dispatch exceeded its bounded deadline")
                });
                break;
            }
            if let Err(error) = self
                .dispatch_bounded(
                    ControlCommand::Stop {
                        instance_id: session.instance_id,
                        force: true,
                    },
                    remaining,
                )
                .await
            {
                first_error.get_or_insert(error);
            }
        }
        self.shutdown_notify.notify_waiters();
        match first_error {
            Some(error) => Err(error),
            None => Ok(()),
        }
    }

    fn ensure_binding_capacity(&self) -> Result<(), NodeFailure> {
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if bindings.len() >= CONTROL_SESSIONS_MAX {
            Err(failure(
                NodeFailureCode::BackendBusy,
                "node session-binding capacity is full; remove an existing session first",
            ))
        } else {
            Ok(())
        }
    }

    /// One-owner workspace/env collision guard: a live session on
    /// `workspace_id` with a different `environment_profile` (option
    /// equality on the resolved receipt, including Some vs None) blocks
    /// another spawn on that same cwd. Same profile may still share the
    /// workspace; distinct profiles need distinct workspace ids (managed
    /// worktree).
    fn ensure_workspace_environment_profile_compatible(
        &self,
        workspace_id: &WorkspaceId,
        environment_profile: Option<&ResolvedEnvironmentProfileReceipt>,
    ) -> Result<(), NodeFailure> {
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        for binding in bindings.values() {
            if &binding.workspace_id != workspace_id {
                continue;
            }
            if binding.environment_profile.as_ref() != environment_profile {
                return Err(failure(
                    NodeFailureCode::WorkspaceBusy,
                    "workspace already has a live session with a different environment profile; use a managed worktree for concurrent distinct ProviderHome/env bindings on one repo",
                ));
            }
        }
        Ok(())
    }

    #[cfg(test)]
    fn bind_session(
        &self,
        instance_id: AgentInstanceId,
        workspace_id: WorkspaceId,
        generation: SessionGeneration,
    ) {
        self.bind_session_with_policy(
            &SessionAddress {
                workspace_id,
                session: SessionKey { instance_id, generation },
            },
            ProviderRuntimePolicy::raw_pty(),
            None,
        );
    }

    #[cfg(test)]
    fn bind_session_with_policy(
        &self,
        address: &SessionAddress,
        runtime_policy: ProviderRuntimePolicy,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
    ) {
        self.bind_session_with_materialization(
            address,
            runtime_policy,
            environment_profile,
            None,
            None,
            None,
        );
    }

    fn bind_session_with_materialization(
        &self,
        address: &SessionAddress,
        runtime_policy: ProviderRuntimePolicy,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
        bundle: Option<ResolvedBundleReceipt>,
        context: Option<ResolvedContextPackReceipt>,
        materialization_id: Option<MaterializationId>,
    ) {
        let mut bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        debug_assert!(bindings.len() < CONTROL_SESSIONS_MAX);
        debug_assert!(!bindings.contains_key(&address.session.instance_id));
        bindings.insert(address.session.instance_id, SessionBinding {
            workspace_id: address.workspace_id.clone(),
            generation: address.session.generation,
            runtime_policy,
            pending_resume: None,
            record_id: None,
            managed_worktree_lease_id: None,
            environment_profile,
            bundle,
            context,
            materialization_id,
        });
    }

    #[cfg(test)]
    fn bind_managed_session(
        &self,
        address: &SessionAddress,
        record_id: SessionRecordId,
        runtime_policy: ProviderRuntimePolicy,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
    ) {
        self.bind_managed_session_with_materialization(
            address,
            record_id,
            runtime_policy,
            environment_profile,
            None,
            None,
            None,
        );
    }

    fn bind_managed_session_with_materialization(
        &self,
        address: &SessionAddress,
        record_id: SessionRecordId,
        runtime_policy: ProviderRuntimePolicy,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
        bundle: Option<ResolvedBundleReceipt>,
        context: Option<ResolvedContextPackReceipt>,
        materialization_id: Option<MaterializationId>,
    ) {
        let mut bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        debug_assert!(bindings.len() < CONTROL_SESSIONS_MAX);
        debug_assert!(!bindings.contains_key(&address.session.instance_id));
        bindings.insert(
            address.session.instance_id,
            SessionBinding {
                workspace_id: address.workspace_id.clone(),
                generation: address.session.generation,
                runtime_policy,
                pending_resume: None,
                record_id: Some(record_id),
                managed_worktree_lease_id: None,
                environment_profile,
                bundle,
                context,
                materialization_id,
            },
        );
    }

    #[cfg(test)]
    fn bind_spawn_session(
        &self,
        address: &SessionAddress,
        provider: AgentId,
        mode: SessionMode,
        runtime_policy: ProviderRuntimePolicy,
        record_policy: SpawnRecordPolicy,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
    ) -> Result<Option<SessionRecordId>, NodeFailure> {
        self.bind_spawn_session_with_materialization(
            address,
            provider,
            mode,
            runtime_policy,
            record_policy,
            environment_profile,
            None,
            None,
            None,
        )
    }

    fn bind_spawn_session_with_materialization(
        &self,
        address: &SessionAddress,
        provider: AgentId,
        mode: SessionMode,
        runtime_policy: ProviderRuntimePolicy,
        record_policy: SpawnRecordPolicy,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
        bundle: Option<ResolvedBundleReceipt>,
        context: Option<ResolvedContextPackReceipt>,
        materialization_id: Option<MaterializationId>,
    ) -> Result<Option<SessionRecordId>, NodeFailure> {
        if record_policy == SpawnRecordPolicy::ProviderIdentityOnly
            && !runtime_policy.provider_session_identity
        {
            self.bind_session_with_materialization(
                address,
                runtime_policy,
                environment_profile,
                bundle,
                context,
                materialization_id,
            );
            return Ok(None);
        }
        let record_owns_lifecycle = runtime_policy.provider_session_identity;
        let record = self.new_record(
            address,
            provider,
            mode,
            active_record_state(runtime_policy.provider_session_identity, false),
            None,
            record_owns_lifecycle.then(|| environment_profile.clone()).flatten(),
            record_owns_lifecycle.then(|| bundle.clone()).flatten(),
            record_owns_lifecycle.then(|| context.clone()).flatten(),
        )?;
        let record_id = record.record_id.clone();
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        self.insert_record(record.clone())?;
        let previous_materialization = if record_owns_lifecycle {
            if let Some(materialization_id) = materialization_id.as_ref() {
                let mut materializations = self
                    .materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let Some(ownership) = materializations.get_mut(materialization_id) else {
                    drop(materializations);
                    self.remove_record_memory(&record_id);
                    return Err(failure(
                        NodeFailureCode::BackendOperationFailed,
                        "session environment ownership disappeared before binding",
                    ));
                };
                let previous = ownership.clone();
                if ownership
                    .transfer_to_record(record_id.clone(), unix_time_ms())
                    .is_err()
                {
                    drop(materializations);
                    self.remove_record_memory(&record_id);
                    return Err(failure(
                        NodeFailureCode::BackendOperationFailed,
                        "session environment ownership transfer failed",
                    ));
                }
                Some(previous)
            } else {
                None
            }
        } else {
            None
        };
        self.bind_managed_session_with_materialization(
            address,
            record_id.clone(),
            runtime_policy,
            environment_profile,
            bundle,
            context,
            materialization_id.clone(),
        );
        if let Err(error) = self.persist_state_locked() {
            self.remove_binding(address);
            self.remove_record_memory(&record_id);
            if let (Some(materialization_id), Some(previous)) =
                (materialization_id.as_ref(), previous_materialization)
            {
                self.materializations
                    .lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner())
                    .insert(materialization_id.clone(), previous);
            }
            return Err(persistence_failure(error));
        }
        drop(transaction);
        self.publish_record(record);
        Ok(Some(record_id))
    }

    fn allocate_record_id(&self) -> Result<SessionRecordId, NodeFailure> {
        for _ in 0..8 {
            let bytes = random_nonce().map_err(|error| {
                failure(
                    NodeFailureCode::BackendOperationFailed,
                    &format!("session record identity generation failed: {error}"),
                )
            })?;
            let mut value = String::with_capacity(27);
            value.push_str("sr-");
            for byte in &bytes[..12] {
                use std::fmt::Write as _;
                let _ = write!(&mut value, "{byte:02x}");
            }
            let record_id = SessionRecordId::new(value).map_err(|error| {
                failure(NodeFailureCode::BackendOperationFailed, &error.to_string())
            })?;
            let records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if !records.records.contains_key(&record_id) {
                return Ok(record_id);
            }
        }
        Err(failure(
            NodeFailureCode::BackendBusy,
            "could not allocate a unique session record ID",
        ))
    }

    fn allocate_task_id(&self) -> Result<TaskId, NodeFailure> {
        for _ in 0..8 {
            let bytes = random_nonce().map_err(|error| {
                failure(
                    NodeFailureCode::BackendOperationFailed,
                    &format!("task identity generation failed: {error}"),
                )
            })?;
            let mut nonce = [0_u8; 12];
            nonce.copy_from_slice(&bytes[..12]);
            let task_id = TaskId::from_nonce(nonce);
            let records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if !records.records.values().any(|record| {
                record.task_binding.as_ref().and_then(|binding| binding.task_id.as_ref())
                    == Some(&task_id)
            }) {
                return Ok(task_id);
            }
        }
        Err(failure(
            NodeFailureCode::BackendBusy,
            "could not allocate a unique task ID",
        ))
    }

    fn default_record_name(&self, provider: &AgentId) -> String {
        let records = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let ordinal = records
            .records
            .values()
            .filter(|record| &record.provider == provider)
            .count()
            .saturating_add(1);
        format!("{} #{ordinal}", provider.as_str())
    }

    fn new_record(
        &self,
        address: &SessionAddress,
        provider: AgentId,
        mode: SessionMode,
        state: ManagedSessionState,
        provider_session: Option<gate4agent_types::ProviderSessionIdentity>,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
        bundle: Option<ResolvedBundleReceipt>,
        context: Option<ResolvedContextPackReceipt>,
    ) -> Result<ManagedSessionRecord, NodeFailure> {
        let canonical_root = self.workspace_root(&address.workspace_id)?;
        let now = unix_time_ms();
        Ok(ManagedSessionRecord {
            record_id: self.allocate_record_id()?,
            display_name: self.m4a_nick_of(address.session.instance_id).unwrap_or_else(|| self.default_record_name(&provider)),
            provider,
            mode,
            state,
            workspace_id: address.workspace_id.clone(),
            canonical_root: opaque_windows_path(canonical_root),
            provider_session,
            active_session: Some(address.clone()),
            environment_profile,
            bundle,
            context_id: context.as_ref().map(|receipt| receipt.id.clone()),
            context,
            exported_context: None,
            task_binding: None,
            created_at_unix_ms: now,
            updated_at_unix_ms: now,
            last_error: None,
        })
    }

    fn insert_record(&self, record: ManagedSessionRecord) -> Result<(), NodeFailure> {
        let mut records = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if records.records.len() >= MAX_MANAGED_SESSION_RECORDS {
            return Err(failure(
                NodeFailureCode::BackendBusy,
                "managed session record capacity is full; forget an inactive record first",
            ));
        }
        if let Some(identity) = record.provider_session.as_ref() {
            if records.records.values().any(|candidate| {
                candidate.provider_session.as_ref().is_some_and(|candidate_identity| {
                    session_registry::same_provider_session(
                        &candidate.provider,
                        candidate_identity,
                        &record.provider,
                        identity,
                    )
                })
            }) {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "provider session is already represented by another managed record",
                ));
            }
        }
        match records.records.entry(record.record_id.clone()) {
            std::collections::btree_map::Entry::Vacant(entry) => {
                entry.insert(record);
            }
            std::collections::btree_map::Entry::Occupied(_) => {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "session record ID collision",
                ));
            }
        }
        Ok(())
    }

    fn record(&self, record_id: &SessionRecordId) -> Result<ManagedSessionRecord, NodeFailure> {
        self.session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .get(record_id)
            .cloned()
            .ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownSessionRecord,
                    "managed session record does not exist",
                )
            })
    }

    fn revalidate_session_record_preview(
        &self,
        expected: &ManagedSessionRecord,
        identity: &ProviderSessionIdentity,
    ) -> Result<(), NodeFailure> {
        let current = self.record(&expected.record_id)?;
        let current_root = self.workspace_root(&current.workspace_id)?;
        if current.provider != expected.provider
            || current.workspace_id != expected.workspace_id
            || current.canonical_root != expected.canonical_root
            || current.provider_session.as_ref() != Some(identity)
            || !platform::roots_equal(
                &current_root,
                windows_path_text(&current.canonical_root),
            )
        {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session changed while its preview was loading",
            ));
        }
        Ok(())
    }

    fn revalidate_session_record_context_export(
        &self,
        expected: &ManagedSessionRecord,
        identity: Option<&ProviderSessionIdentity>,
        session: &SessionAddress,
        allow_clean_detachment: bool,
    ) -> Result<(), NodeFailure> {
        let current = self.record(&expected.record_id)?;
        let current_root = self.workspace_root(&current.workspace_id)?;
        let snapshot = self.internal_session_snapshot(session)?;
        let binding = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&session.session.instance_id)
            .cloned()
            .ok_or_else(|| {
                failure(
                    NodeFailureCode::SessionRecordConflict,
                    "managed session runtime binding disappeared during context export",
                )
            })?;
        if !session_record_context_export_binding_is_exact(
            expected,
            &current,
            identity,
            session,
            &binding,
            &snapshot.agent_id,
            &current_root,
            allow_clean_detachment,
        ) || !session_record_context_export_source_is_usable(
            &current,
            &snapshot.status,
            allow_clean_detachment,
        ) {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session binding changed during context export",
            ));
        }
        Ok(())
    }

    fn revalidate_loaded_history(
        &self,
        session: &SessionAddress,
        candidate_id: &str,
        loaded: &HistorySessionRecord,
    ) -> Result<(), NodeFailure> {
        let snapshot = self.internal_session_snapshot(session)?;
        if snapshot.history.pending.is_some()
            || snapshot.history.loaded_candidate_id.as_deref() != Some(candidate_id)
            || snapshot.history.loaded.as_ref() != Some(loaded)
        {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session history changed during context export",
            ));
        }
        Ok(())
    }

    fn remove_record_memory(&self, record_id: &SessionRecordId) -> Option<ManagedSessionRecord> {
        self.session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .remove(record_id)
    }

    fn discard_record(&self, record_id: &SessionRecordId) -> Result<(), NodeFailure> {
        if self.destroy_record_materialization(record_id)? {
            self.publish(NodeEvent::SessionRecordRemoved {
                record_id: record_id.clone(),
            });
            return Ok(());
        }
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let Some(removed) = self.remove_record_memory(record_id) else {
            return Ok(());
        };
        if let Err(error) = self.persist_state_locked() {
            let _ = self.insert_record(removed);
            return Err(persistence_failure(error));
        }
        drop(transaction);
        self.publish(NodeEvent::SessionRecordRemoved {
            record_id: record_id.clone(),
        });
        Ok(())
    }

    fn publish_record(&self, record: ManagedSessionRecord) {
        self.publish(NodeEvent::SessionRecordUpserted { record });
    }

    fn mark_record_error(
        &self,
        record_id: &SessionRecordId,
        message: &str,
    ) -> Result<(), NodeFailure> {
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let previous = {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(record) = records.records.get_mut(record_id) else {
                return Ok(());
            };
            let previous = record.clone();
            record.state = ManagedSessionState::Unavailable;
            record.last_error = Some(session_registry::sanitized_record_error_summary(message));
            record.updated_at_unix_ms = unix_time_ms();
            previous
        };
        if let Err(error) = self.persist_state_locked() {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .insert(record_id.clone(), previous);
            return Err(persistence_failure(error));
        }
        let record = self.record(record_id)?;
        drop(transaction);
        self.publish_record(record);
        Ok(())
    }

    fn rename_session_record(
        &self,
        record_id: &SessionRecordId,
        display_name: String,
    ) -> Result<ManagedSessionRecord, NodeFailure> {
        validate_display_name(&display_name)
            .map_err(|error| failure(NodeFailureCode::InvalidRequest, &error.to_string()))?;
        let _transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let previous = {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let record = records.records.get_mut(record_id).ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownSessionRecord,
                    "managed session record does not exist",
                )
            })?;
            let previous = record.clone();
            record.display_name = display_name;
            record.updated_at_unix_ms = unix_time_ms();
            previous
        };
        if let Err(error) = self.persist_state_locked() {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .insert(record_id.clone(), previous);
            return Err(persistence_failure(error));
        }
        let updated = self.record(record_id)?;
        self.publish_record(updated.clone());
        Ok(updated)
    }

    fn set_session_task(
        &self,
        record_id: &SessionRecordId,
        expected_revision: u64,
        target: SessionTaskTargetV1,
    ) -> Result<ManagedSessionRecord, NodeFailure> {
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let current = self.record(record_id)?;
        let current_task_id = current
            .task_binding
            .as_ref()
            .and_then(|binding| binding.task_id.as_ref());
        let current_revision = current
            .task_binding
            .as_ref()
            .map_or(0, |binding| binding.revision);
        if expected_revision != current_revision {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session task binding revision changed",
            ));
        }
        let exact = match &target {
            SessionTaskTargetV1::Existing { task_id } => current_task_id == Some(task_id),
            SessionTaskTargetV1::Clear => current_task_id.is_none(),
            SessionTaskTargetV1::New => false,
        };
        if exact {
            return Ok(current);
        }
        let revision = current_revision.checked_add(1).ok_or_else(|| {
            failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session task binding revision is exhausted",
            )
        })?;
        let task_id = match target {
            SessionTaskTargetV1::New => Some(self.allocate_task_id()?),
            SessionTaskTargetV1::Existing { task_id } => Some(task_id),
            SessionTaskTargetV1::Clear => None,
        };
        let changed_at_unix_ms = unix_time_ms()
            .max(current.updated_at_unix_ms.checked_add(1).ok_or_else(|| {
                failure(
                    NodeFailureCode::SessionRecordConflict,
                    "managed session record timestamp is exhausted",
                )
            })?);
        let updated = {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let record = records.records.get_mut(record_id).ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownSessionRecord,
                    "managed session record does not exist",
                )
            })?;
            record.task_binding = Some(SessionTaskBindingV1 {
                revision,
                task_id,
                changed_at_unix_ms,
            });
            record.updated_at_unix_ms = changed_at_unix_ms;
            record.clone()
        };
        if let Err(error) = self.persist_state_locked() {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .insert(record_id.clone(), current);
            return Err(persistence_failure(error));
        }
        drop(transaction);
        self.publish_record(updated.clone());
        Ok(updated)
    }

    fn index_provider_session(
        &self,
        workspace_id: WorkspaceId,
        provider: AgentId,
        identity: ProviderSessionIdentity,
        display_name: String,
    ) -> Result<ManagedSessionRecord, NodeFailure> {
        self.index_provider_session_with_policy(
            workspace_id,
            provider,
            identity,
            display_name,
            false,
        )
    }

    fn index_provider_session_with_policy(
        &self,
        workspace_id: WorkspaceId,
        provider: AgentId,
        identity: ProviderSessionIdentity,
        display_name: String,
        allow_validated_transcript_path: bool,
    ) -> Result<ManagedSessionRecord, NodeFailure> {
        validate_display_name(&display_name)
            .map_err(|error| failure(NodeFailureCode::InvalidRequest, &error.to_string()))?;
        identity
            .validate()
            .map_err(|error| failure(NodeFailureCode::InvalidRequest, &error.to_string()))?;
        if identity.transcript_path.is_some() && !allow_validated_transcript_path {
            return Err(failure(
                NodeFailureCode::InvalidRequest,
                "provider session reference index v1 does not accept transcript paths",
            ));
        }
        let canonical_root = self.workspace_root(&workspace_id)?;
        if !self.enabled_providers.contains(&provider) {
            return Err(failure(
                NodeFailureCode::InvalidRequest,
                "provider is not enabled on this node",
            ));
        }

        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        {
            let records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if let Some(existing) = records.records.values().find(|candidate| {
                candidate.provider_session.as_ref().is_some_and(|candidate_identity| {
                    candidate_identity.key == identity.key && candidate_identity.id == identity.id
                })
            }) {
                if existing.provider == provider && existing.workspace_id == workspace_id {
                    return Ok(existing.clone());
                }
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "provider session reference conflicts with another provider or workspace",
                ));
            }
            if records.records.len() >= MAX_MANAGED_SESSION_RECORDS {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    "managed session record capacity is full; forget an inactive record first",
                ));
            }
        }

        let now = unix_time_ms();
        let record = ManagedSessionRecord {
            record_id: self.allocate_record_id()?,
            display_name,
            provider,
            mode: SessionMode::Pty,
            state: ManagedSessionState::Dormant,
            workspace_id,
            canonical_root: opaque_windows_path(canonical_root),
            provider_session: Some(identity),
            active_session: None,
            environment_profile: None,
            bundle: None,
            context_id: None,
            context: None,
            exported_context: None,
            task_binding: None,
            created_at_unix_ms: now,
            updated_at_unix_ms: now,
            last_error: None,
        };
        self.insert_record(record.clone())?;
        if let Err(error) = self.persist_state_locked() {
            self.remove_record_memory(&record.record_id);
            return Err(persistence_failure(error));
        }
        drop(transaction);
        self.publish_record(record.clone());
        Ok(record)
    }

    fn bound_address_for_record(&self, record_id: &SessionRecordId) -> Option<SessionAddress> {
        self.session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .iter()
            .find_map(|(instance_id, binding)| {
                (binding.record_id.as_ref() == Some(record_id)).then(|| SessionAddress {
                    workspace_id: binding.workspace_id.clone(),
                    session: SessionKey {
                        instance_id: *instance_id,
                        generation: binding.generation,
                    },
                })
            })
    }

    async fn forget_session_record(
        &self,
        record_id: &SessionRecordId,
    ) -> Result<(), NodeFailure> {
        let record = self.record(record_id)?;
        if record.active_session.is_some()
            || matches!(
                record.state,
                ManagedSessionState::Live | ManagedSessionState::IdentityPending
            )
        {
            return Err(failure(
                NodeFailureCode::SessionRecordBusy,
                "stop the managed session before forgetting it",
            ));
        }
        if let Some(address) = self.bound_address_for_record(record_id) {
            self.remove_session(&address).await?;
        }
        self.remove_managed_session_record(record_id, &record.workspace_id).await
    }

    /// Removes one managed session record from durable state and notifies
    /// every listener -- the shared transaction body behind both
    /// `forget_session_record`'s operator-driven path (busy-checked above
    /// it, and clears any still-live session binding before calling in
    /// here) and the retention sweep (`retire_unavailable_session_records`,
    /// which only ever selects `ManagedSessionState::Unavailable` records
    /// that are already known never-busy and never bound, so it calls
    /// straight into this with neither check). Cleans a managed-worktree
    /// lease if the record held one, removes the record's environment
    /// materialization (or, absent one, removes it from memory directly),
    /// persists under `state_transaction` with rollback on persist failure,
    /// then publishes `NodeEvent::SessionRecordRemoved` so c2's own
    /// legacy-provider bookkeeping (`record_is_legacy`) stays in sync
    /// exactly as it does for an operator-driven forget.
    async fn remove_managed_session_record(
        &self,
        record_id: &SessionRecordId,
        workspace_id: &WorkspaceId,
    ) -> Result<(), NodeFailure> {
        let managed_lease_id = self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .lease_for_workspace(workspace_id);
        if !self.destroy_record_materialization(record_id)? {
            let transaction = self
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let removed = self.remove_record_memory(record_id).ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownSessionRecord,
                    "managed session record does not exist",
                )
            })?;
            if let Err(error) = self.persist_state_locked() {
                let _ = self.insert_record(removed);
                return Err(persistence_failure(error));
            }
            drop(transaction);
        }
        self.publish(NodeEvent::SessionRecordRemoved {
            record_id: record_id.clone(),
        });
        if let Some(lease_id) = managed_lease_id {
            if let Some(snapshot) = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&lease_id)
                .map(ManagedWorktreeLeaseRecord::snapshot)
            {
                self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot });
            }
            let _ = self.cleanup_managed_worktree(&lease_id, false).await;
        }
        Ok(())
    }

    /// Retires `ManagedSessionState::Unavailable` records against the
    /// node's configured `session_record_retention` age/keep-N policy.
    /// Never touches `Live`, `IdentityPending`, or `Dormant` records --
    /// `Dormant` is resumable and folding it into this sweep would delete
    /// records a caller can still act on. Both policy fields default to
    /// `0` (disabled); when both are `0` this is a no-op. When both are
    /// set, a record is retired only if it fails BOTH tests (older than
    /// `age_ms` AND beyond the newest `keep_per_workspace` in its
    /// workspace); when only one is set, that one alone decides. Called
    /// once at startup (alongside `reconcile_managed_worktrees`) and then
    /// on a `SESSION_RECORD_RETENTION_SWEEP_PERIOD` cadence from the drive
    /// loop -- see both call sites.
    async fn retire_unavailable_session_records(&self) {
        let policy = self.session_record_retention;
        let age_enabled = policy.age_ms > 0;
        let keep_enabled = policy.keep_per_workspace > 0;
        if !age_enabled && !keep_enabled {
            return;
        }
        let now = unix_time_ms();
        let candidates: Vec<(SessionRecordId, WorkspaceId, AgentId, u64)> = {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .values()
                .filter(|record| record.state == ManagedSessionState::Unavailable)
                .map(|record| {
                    (
                        record.record_id.clone(),
                        record.workspace_id.clone(),
                        record.provider.clone(),
                        record.updated_at_unix_ms,
                    )
                })
                .collect()
        };
        if candidates.is_empty() {
            return;
        }
        let mut by_workspace: BTreeMap<WorkspaceId, Vec<(SessionRecordId, AgentId, u64)>> =
            BTreeMap::new();
        for (record_id, workspace_id, provider, updated_at_unix_ms) in candidates {
            by_workspace
                .entry(workspace_id)
                .or_default()
                .push((record_id, provider, updated_at_unix_ms));
        }
        let reason = if age_enabled && keep_enabled {
            "age+keep-n"
        } else if age_enabled {
            "age"
        } else {
            "keep-n"
        };
        let mut retired: u64 = 0;
        for (workspace_id, mut records) in by_workspace {
            // Newest `updated_at_unix_ms` first, so index `>=
            // keep_per_workspace` names exactly "beyond the newest N".
            records.sort_by(|left, right| right.2.cmp(&left.2));
            for (index, (record_id, provider, updated_at_unix_ms)) in
                records.into_iter().enumerate()
            {
                let record_age_ms = now.saturating_sub(updated_at_unix_ms);
                let age_hit = age_enabled && record_age_ms >= policy.age_ms;
                let keep_hit = keep_enabled && index >= policy.keep_per_workspace as usize;
                let should_retire = if age_enabled && keep_enabled {
                    age_hit && keep_hit
                } else {
                    age_hit || keep_hit
                };
                if !should_retire {
                    continue;
                }
                match self.remove_managed_session_record(&record_id, &workspace_id).await {
                    Ok(()) => {
                        self.retired_records_total.fetch_add(1, Ordering::Relaxed);
                        retired += 1;
                        tracing::info!(
                            node_id = %self.node_id,
                            record_id = %record_id,
                            workspace_id = %workspace_id,
                            provider = %provider,
                            age_ms = record_age_ms,
                            reason,
                            "managed session record retired"
                        );
                    }
                    Err(error) => tracing::warn!(
                        node_id = %self.node_id,
                        record_id = %record_id,
                        workspace_id = %workspace_id,
                        code = ?error.code,
                        cause = %error.message,
                        "session record retention sweep failed to retire a record"
                    ),
                }
            }
        }
        if retired > 0 {
            let remaining_unavailable = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .values()
                .filter(|record| record.state == ManagedSessionState::Unavailable)
                .count();
            tracing::info!(
                node_id = %self.node_id,
                retired,
                remaining_unavailable,
                "session record retention sweep completed"
            );
        }
    }

    async fn resume_session_record(
        &self,
        record_id: &SessionRecordId,
        terminal_size: gate4agent_types::TerminalSize,
        initial_prompt: Option<String>,
    ) -> Result<(ManagedSessionRecord, SessionAddress), NodeFailure> {
        let mut record = self.record(record_id)?;
        // claude's ACP agent has no session/load: an ACP claude conversation whose transcript
        // is on disk is resumed as a PTY `claude --resume <id>` of that same transcript.
        if record.mode == SessionMode::Acp
            && record.provider.as_str() == "claude"
            && record.provider_session.as_ref().is_some_and(|i| provider_session_exists("claude", &i.id))
        {
            record.mode = SessionMode::Pty;
            if let Some(r) = self.session_records.lock().unwrap_or_else(|p| p.into_inner()).records.get_mut(record_id) {
                r.mode = SessionMode::Pty;
            }
            tracing::info!(record = %record_id, "acp claude record resumed over pty (--resume of its transcript)");
        }
        if record.active_session.is_some()
            || matches!(
                record.state,
                ManagedSessionState::Live | ManagedSessionState::IdentityPending
            )
        {
            return Err(failure(
                NodeFailureCode::SessionRecordBusy,
                "managed session already has a live runtime binding",
            ));
        }
        let identity = record.provider_session.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::SessionRecordNotResumable,
                "managed session has no verified provider session identity",
            )
        })?;
        let working_directory = self.workspace_root(&record.workspace_id)?;
        if !platform::roots_equal(
            &working_directory,
            windows_path_text(&record.canonical_root),
        ) {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session workspace root changed; refusing to resume in another directory",
            ));
        }
        {
            let records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if records.records.values().any(|candidate| {
                candidate.record_id != *record_id
                    && candidate.provider_session.as_ref().is_some_and(|candidate_identity| {
                        session_registry::same_provider_session(
                            &candidate.provider,
                            candidate_identity,
                            &record.provider,
                            &identity,
                        )
                    })
                    && (candidate.active_session.is_some()
                        || matches!(
                            candidate.state,
                            ManagedSessionState::Live | ManagedSessionState::IdentityPending
                        ))
            }) {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "provider session is already active through another managed record",
                ));
            }
        }
        let runtime_requirement = if initial_prompt.is_some() {
            ProviderRuntimeRequirement::ResumeWithPrompt
        } else {
            ProviderRuntimeRequirement::Resume
        };
        let runtime_policy = self.admit_provider_runtime(
            &record.provider,
            runtime_requirement,
        )
        .await?;
        // The resumed runtime runs in the session folder its record was named after.
        let working_directory = match self.m4a_accounts.as_ref() {
            Some(_) => {
                let dir = std::path::Path::new(&working_directory).join(".hatchery-sessions").join(&record.display_name);
                if !record.display_name.contains(' ') && dir.is_dir() { dir.to_string_lossy().into_owned() } else { working_directory }
            }
            None => working_directory,
        };
        let request = ResumeLaunchRequest {
            working_directory,
            terminal_size,
            initial_prompt,
        };
        request
            .validate()
            .map_err(|error| failure(NodeFailureCode::InvalidRequest, &error.to_string()))?;
        self.ensure_binding_capacity()?;
        let resolved_materialization = match self.resolve_record_materialization(
            record_id,
            &record.provider,
            record.mode,
            record.environment_profile.as_ref(),
            record.bundle.as_ref(),
            record.context.as_ref(),
        ) {
            Ok(materialization) => materialization,
            Err(error) => {
                let label = match error.code {
                    NodeFailureCode::UnknownBundle => "bundle-unavailable",
                    NodeFailureCode::BundleBindingMismatch => "bundle-binding-mismatch",
                    NodeFailureCode::BundleMaterializationFailed => "bundle-materialization-failed",
                    _ => "environment-profile-unavailable",
                };
                self.mark_record_error(record_id, label)?;
                return Err(error);
            }
        };
        let (materialization_id, environment_overlay) = match resolved_materialization {
            Some((id, overlay)) => (Some(id), overlay),
            None => (None, None),
        };
        let instance_id = AgentInstanceId(self.next_instance_id.fetch_add(1, Ordering::AcqRel));
        // Resumed runtime: same auto-permit flags and launch options (model / effort) as a spawn.
        let environment_overlay = {
            let mut args: Vec<OsString> = Vec::new();
            if let Ok(cwd) = self.workspace_root(&record.workspace_id) {
                let mut homes: Vec<PathBuf> = std::env::var_os("HOME").map(PathBuf::from).into_iter().collect();
                if let Some(extra) = std::env::var_os("HATCHERY_PROVIDER_HOMES") { homes.extend(std::env::split_paths(&extra)); }
                crate::auto_permit::prepare(record.provider.as_str(), &homes, Some(std::path::Path::new(&cwd)));
            }
            args.extend(crate::auto_permit::launch_args(record.provider.as_str(), record.mode));
            let options = SPAWN_SESSION_OPTIONS.try_with(|o| o.clone()).ok().flatten();
            if record.mode == SessionMode::Pty && record.provider.as_str() == "claude" {
                if let Some(sel) = options.as_ref() {
                    args.push("--model".into()); args.push(sel.model.clone().into());
                    if let Some(effort) = sel.values.get("effort").and_then(|v| v.as_str()) {
                        args.push("--effort".into()); args.push(effort.to_owned().into());
                    }
                }
            }
            if matches!(record.mode, SessionMode::Pty | SessionMode::Acp) && crate::pty_resume::supported(record.provider.as_str()) {
                if let (Some(file), Some(identity)) = (self.session_resume_journal(), record.provider_session.as_ref()) {
                    crate::pty_resume::upsert(&file, crate::pty_resume::Entry {
                        instance_id: instance_id.0,
                        provider: record.provider.as_str().to_owned(),
                        workspace_id: record.workspace_id.as_str().to_owned(),
                        provider_session_id: identity.id.clone(),
                        session_key: self.m4a_reuse_keys.lock().unwrap_or_else(|p| p.into_inner()).get(&instance_id).cloned().unwrap_or_default(),
                        cwd: String::new(),
                        acp: record.mode == SessionMode::Acp,
                        options,
                        cols: 0,
                        rows: 0,
                        origin: SPAWN_ORIGIN.try_with(|o| o.clone()).ok().flatten(),
                        parent_session_id: SPAWN_PARENT.try_with(|o| o.clone()).ok().flatten(),
                    });
                }
            }
            overlay_with_extra_args(&record.provider, record.mode, environment_overlay, args)?
        };
        // The resumed runtime keeps the m4a account of the runtime it replaces.
        let environment_overlay = match (self.m4a_accounts.as_ref(), crate::m4a_accounts::m4a_provider(record.provider.as_str())) {
            (Some(accounts), Some(m4a_provider)) if matches!(record.mode, SessionMode::Pty | SessionMode::Acp) => {
                if let Some(old) = self.bound_address_for_record(record_id) {
                    if let Some(key) = self.m4a_keys.lock().unwrap_or_else(|p| p.into_inner()).get(&old.session.instance_id).cloned() {
                        self.m4a_reuse_keys.lock().unwrap_or_else(|p| p.into_inner()).insert(instance_id, key);
                    }
                }
                let session_key = self.m4a_session_key(instance_id);
                self.m4a_session_overlay(accounts, m4a_provider, &record.provider, instance_id, environment_overlay, &session_key, record.mode)?
            }
            _ => environment_overlay,
        };
        let mut environment_selection = match SpawnPreparer::select_environment(self, 
            instance_id,
            &record.provider,
            record.mode,
            record.environment_profile.as_ref(),
        ) {
            Ok(selection) => selection,
            Err(error) => {
                self.mark_record_error(record_id, "environment-profile-unavailable")?;
                return Err(error);
            }
        };
        let mut instance_overlay = environment_overlay
            .map(|overlay| SpawnPreparer::install_launch_overlay(self, instance_id, overlay))
            .transpose()?
            .flatten();
        if let Some(stale_address) = self.bound_address_for_record(record_id) {
            self.remove_session(&stale_address).await?;
        }
        let address = SessionAddress {
            workspace_id: record.workspace_id.clone(),
            session: SessionKey {
                instance_id,
                generation: SessionGeneration(1),
            },
        };
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let current = self.record(record_id)?;
        if current.active_session.is_some()
            || matches!(
                current.state,
                ManagedSessionState::Live | ManagedSessionState::IdentityPending
            )
        {
            return Err(failure(
                NodeFailureCode::SessionRecordBusy,
                "managed session became active while resume was being prepared",
            ));
        }
        self.bind_managed_session_with_materialization(
            &address,
            record_id.clone(),
            runtime_policy,
            record.environment_profile.clone(),
            record.bundle.clone(),
            record.context.clone(),
            materialization_id,
        );
        if let Some(selection) = environment_selection.take() {
            selection.retain();
        }
        if let Some(overlay) = instance_overlay.take() {
            overlay.retain();
        }
        drop(transaction);

        let transport = match record.mode {
            SessionMode::Pty => TransportKind::Pty,
            SessionMode::Inline => TransportKind::Pipe,
            SessionMode::Acp => TransportKind::Acp,
        };
        let agent_id = record.provider.clone();
        let dispatch_timeout = Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS);
        if let Err(error) = self
            .dispatch_bounded(
                ControlCommand::Register {
                    instance_id,
                    agent_id,
                    transport,
                },
                dispatch_timeout,
            )
            .await
        {
            if let Some(binding) = self.remove_binding(&address) {
                SessionLifecycleHook::cleanup_session_materialization(self, &address, &binding)?;
            }
            return Err(error);
        }
        let command = self.prepare_command(ControlCommand::Resume {
            instance_id,
            target: ResumeTarget::ProviderSession { identity },
            runtime_policy,
            request,
        });
        let started_after = self.current_sequence();
        if let Err(error) = self.arm_resume(&address, command.id, runtime_policy) {
            self.rollback_spawn(&address, dispatch_timeout).await?;
            return Err(error);
        }
        if let Err(error) = self.dispatch_envelope(command) {
            self.clear_armed_resume(&address);
            self.rollback_spawn(&address, dispatch_timeout).await?;
            return Err(error);
        }
        match self
            .wait_for_record_resume(&address, started_after)
            .await
        {
            Ok(settled_address) => {
                let managed_lease_id = {
                    self.managed_worktrees.lock()
                        .unwrap_or_else(|poisoned| poisoned.into_inner())
                        .lease_for_workspace(&record.workspace_id)
                };
                if let Some(lease_id) = managed_lease_id {
                    {
                        let mut bindings = self.session_bindings.lock()
                            .unwrap_or_else(|poisoned| poisoned.into_inner());
                        let binding = bindings.get_mut(&settled_address.session.instance_id)
                            .ok_or_else(|| failure(
                                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                                "resumed managed session lost its exact binding",
                            ))?;
                        if binding.generation != settled_address.session.generation {
                            return Err(failure(
                                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                                "resumed managed session generation diverged",
                            ));
                        }
                        binding.managed_worktree_lease_id = Some(lease_id.clone());
                    }
                    let snapshot = self.managed_worktrees.lock()
                        .unwrap_or_else(|poisoned| poisoned.into_inner())
                        .bind_session(
                            &lease_id,
                            ManagedWorktreeSessionHolder {
                                incarnation_id: self.incarnation_id,
                                instance_id: settled_address.session.instance_id,
                                generation: settled_address.session.generation,
                            },
                            Some(record_id.clone()),
                            unix_time_ms(),
                        ).map_err(|message| failure(
                            NodeFailureCode::ManagedWorktreeRecoveryRequired,
                            &message,
                        ))?;
                    if let Err(error) = self.persist_state() {
                        let _ = self.remove_session(&settled_address).await;
                        return Err(persistence_failure(error));
                    }
                    self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot });
                }
                Ok((self.record(record_id)?, settled_address))
            }
            Err(error) => {
                if matches!(
                    error.code,
                    NodeFailureCode::SessionRecordNotResumable
                        | NodeFailureCode::BackendOperationFailed
                ) {
                    if let Some(bound) = self.bound_address_for_record(record_id) {
                        let _ = self.remove_session(&bound).await;
                    }
                }
                Err(error)
            }
        }
    }

    async fn wait_for_record_resume(
        &self,
        initial_address: &SessionAddress,
        after_sequence: u64,
    ) -> Result<SessionAddress, NodeFailure> {
        let deadline = Instant::now()
            + Duration::from_millis(MANAGED_RESUME_SETTLE_TIMEOUT_MS);
        let mut scan_after = after_sequence;
        loop {
            let events = self
                .history
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .events
                .iter()
                .filter(|event| event.sequence > scan_after)
                .cloned()
                .collect::<Vec<_>>();
            for envelope in events {
                scan_after = scan_after.max(envelope.sequence);
                let NodeEvent::Control { address, event } = envelope.event else {
                    continue;
                };
                if address.session.instance_id != initial_address.session.instance_id {
                    continue;
                }
                match event.event {
                    ControlEventKind::Resumed { .. } => return Ok(address),
                    ControlEventKind::ResumeDenied { reason } => {
                        return Err(failure(
                            NodeFailureCode::SessionRecordNotResumable,
                            &reason,
                        ));
                    }
                    ControlEventKind::ResumeFailed { message }
                    | ControlEventKind::CommandRejected { message } => {
                        return Err(failure(
                            NodeFailureCode::BackendOperationFailed,
                            &message,
                        ));
                    }
                    _ => {}
                }
            }
            if Instant::now() >= deadline {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    "managed resume did not settle before the bounded deadline",
                ));
            }
            sleep(Duration::from_millis(5)).await;
        }
    }

    fn workspace_root(&self, workspace_id: &WorkspaceId) -> Result<String, NodeFailure> {
        self.workspaces
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(workspace_id)
            .cloned()
            .ok_or_else(|| failure(NodeFailureCode::UnknownWorkspace, "workspace does not exist"))
    }

    fn workspace_roots(&self) -> Vec<PathBuf> {
        self.workspaces
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .map(PathBuf::from)
            .collect()
    }

    async fn inspect_workspace(
        &self,
        workspace_id: WorkspaceId,
    ) -> Result<WorkspaceInspection, NodeFailure> {
        let _permit = self
            .inspection_slots
            .clone()
            .try_acquire_owned()
            .map_err(|_| {
                tracing::warn!(
                    workspace_id = %workspace_id,
                    "workspace inspection rejected: inspection capacity is busy",
                );
                failure(
                    NodeFailureCode::BackendBusy,
                    "workspace inspection capacity is busy",
                )
            })?;
        let canonical_root = self.workspace_root(&workspace_id).map_err(|error| {
            tracing::warn!(
                workspace_id = %workspace_id,
                code = ?error.code,
                "workspace inspection rejected: workspace is not registered",
            );
            error
        })?;
        let tree_root = canonical_root.clone();
        let started_at = Instant::now();
        let time_budget_ms = workspace_inspection_time_budget_ms();
        let entry_cap = workspace_inspection_entry_cap();
        let deadline = started_at + Duration::from_millis(time_budget_ms);
        let (entries, tree_truncated, walk_budget) = tokio::task::spawn_blocking(move || {
            collect_workspace_entries(Path::new(&tree_root), deadline, entry_cap)
        })
        .await
        .map_err(|error| {
            tracing::warn!(
                workspace_id = %workspace_id,
                error = %error,
                "workspace inspection rejected: walk task failed",
            );
            failure(
                NodeFailureCode::BackendOperationFailed,
                &format!("workspace inspection task failed: {error}"),
            )
        })?;
        let (mut git, git_time_budget_exceeded) =
            inspect_git_workspace(&canonical_root, deadline).await;
        if !git.worktrees.is_empty() {
            let registered = self
                .workspaces
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .iter()
                .map(|(workspace_id, root)| (workspace_id.clone(), root.clone()))
                .collect::<Vec<_>>();
            for worktree in &mut git.worktrees {
                worktree.workspace_id = registered
                    .iter()
                    .find(|(_, root)| {
                        worktree_paths_equal(root, windows_path_text(&worktree.path))
                    })
                    .map(|(workspace_id, _)| workspace_id.clone());
            }
        }
        if git.is_repository {
            git.managed_worktree = self
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .git_scope(&workspace_id, git.branch.as_deref());
        }
        let truncation = workspace_inspection_truncation(
            &walk_budget,
            git_time_budget_exceeded,
            started_at.elapsed(),
        );
        if let Some(truncation) = &truncation {
            tracing::info!(
                workspace_id = %workspace_id,
                walk_time_budget_exceeded = truncation.walk_time_budget_exceeded,
                walk_entry_cap_exceeded = truncation.walk_entry_cap_exceeded,
                git_time_budget_exceeded = truncation.git_time_budget_exceeded,
                entries_visited = truncation.entries_visited,
                elapsed_ms = truncation.elapsed_ms,
                "workspace inspection truncated by its inner budget",
            );
        }
        Ok(WorkspaceInspection {
            workspace_id,
            entries,
            tree_truncated,
            git,
            truncation,
        })
    }

    async fn browse_host_directories(
        &self,
        directory: Option<OpaqueHostPath>,
        after: Option<OpaqueHostPath>,
    ) -> Result<HostDirectoryListing, NodeFailure> {
        let permit = self
            .inspection_slots
            .clone()
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "host directory browse capacity is busy",
                )
            })?;
        let task = tokio::task::spawn_blocking(move || {
            let _permit = permit;
            browse_host_directories(directory, after)
        });
        timeout(Duration::from_millis(HOST_DIRECTORY_BROWSE_TIMEOUT_MS), task)
            .await
            .map_err(|_| {
                failure(
                    NodeFailureCode::HostDirectoryReadTimedOut,
                    "host directory browse exceeded its bounded deadline",
                )
            })?
            .map_err(|_| {
                failure(
                    NodeFailureCode::HostDirectoryReadFailed,
                    "host directory browse task failed",
                )
            })?
            .map_err(host_directory_failure)
    }

    async fn read_workspace_file(
        &self,
        workspace_id: WorkspaceId,
        path: RepositoryPath,
    ) -> Result<WorkspaceFileRead, NodeFailure> {
        let canonical_root = self.workspace_root(&workspace_id)?;
        let permit = self
            .inspection_slots
            .clone()
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "workspace file read capacity is busy",
                )
            })?;
        let path_to_read = path.clone();
        let task = tokio::task::spawn_blocking(move || {
            let _permit = permit;
            read_workspace_file_from_disk(Path::new(&canonical_root), &path_to_read)
        });
        let content = timeout(
            Duration::from_millis(WORKSPACE_FILE_READ_TIMEOUT_MS),
            task,
        )
        .await
        .map_err(|_| {
            failure(
                NodeFailureCode::RepositoryFileReadTimedOut,
                "repository file read exceeded its bounded deadline",
            )
        })?
        .map_err(|_| {
            failure(
                NodeFailureCode::RepositoryFileReadFailed,
                "repository file read task failed",
            )
        })?
        .map_err(workspace_file_failure)?;
        let content = match content {
            WorkspaceFileBytes::Utf8(text) => {
                let revision = Some(workspace_file_revision(text.as_bytes()));
                return Ok(WorkspaceFileRead {
                    workspace_id,
                    path,
                    content: WorkspaceFileContent::Utf8 {
                        byte_len: u32::try_from(text.len())
                            .expect("bounded workspace text length must fit u32"),
                        text,
                    },
                    revision,
                });
            }
            WorkspaceFileBytes::NonUtf8 { byte_length } => {
                WorkspaceFileContent::NonUtf8 {
                    byte_len: u32::try_from(byte_length)
                        .expect("bounded workspace file length must fit u32"),
                }
            }
            WorkspaceFileBytes::TooLarge => WorkspaceFileContent::TooLarge {
                limit_bytes: MAX_WORKSPACE_FILE_BYTES as u32,
            },
        };
        Ok(WorkspaceFileRead {
            workspace_id,
            path,
            content,
            revision: None,
        })
    }

    async fn write_workspace_file(
        &self,
        workspace_id: WorkspaceId,
        path: RepositoryPath,
        expected_revision: WorkspaceFileRevision,
        text: String,
    ) -> Result<WorkspaceFileRead, NodeFailure> {
        let canonical_root = self.workspace_root(&workspace_id)?;
        let permit = self.inspection_slots.clone().try_acquire_owned().map_err(|_| {
            failure(NodeFailureCode::BackendBusy, "workspace file write capacity is busy")
        })?;
        let path_to_write = path.clone();
        let expected = expected_revision.as_str().to_owned();
        let text_to_write = text.clone();
        let task = tokio::task::spawn_blocking(move || {
            let _permit = permit;
            write_workspace_file_to_disk(
                Path::new(&canonical_root),
                &path_to_write,
                &expected,
                &text_to_write,
            )
        });
        let revision = timeout(Duration::from_millis(WORKSPACE_FILE_WRITE_TIMEOUT_MS), task)
            .await
            .map_err(|_| failure(NodeFailureCode::RepositoryFileWriteTimedOut, "repository file write exceeded its bounded deadline"))?
            .map_err(|_| failure(NodeFailureCode::RepositoryFileWriteFailed, "repository file write task failed"))?
            .map_err(workspace_file_write_failure)?;
        Ok(WorkspaceFileRead {
            workspace_id,
            path,
            content: WorkspaceFileContent::Utf8 {
                byte_len: u32::try_from(text.len()).expect("bounded workspace text length must fit u32"),
                text,
            },
            revision: Some(WorkspaceFileRevision::new(revision)
                .expect("workspace writer returns a valid SHA-256 revision")),
        })
    }

    async fn create_workspace_file(
        &self,
        workspace_id: WorkspaceId,
        path: RepositoryPath,
    ) -> Result<WorkspaceFileRead, NodeFailure> {
        let canonical_root = self.workspace_root(&workspace_id)?;
        let permit = self.inspection_slots.clone().try_acquire_owned().map_err(|_| {
            failure(NodeFailureCode::BackendBusy, "workspace entry create capacity is busy")
        })?;
        let path_to_create = path.clone();
        let commit_state = Arc::new(AtomicU8::new(WORKSPACE_ENTRY_CREATE_PENDING));
        let task_commit_state = Arc::clone(&commit_state);
        let task = tokio::task::spawn_blocking(move || {
            let _permit = permit;
            create_workspace_file_on_disk(
                Path::new(&canonical_root),
                &path_to_create,
                &task_commit_state,
            )
        });
        let revision = settle_workspace_entry_create(
            task,
            commit_state,
            Duration::from_millis(WORKSPACE_ENTRY_CREATE_TIMEOUT_MS),
            "repository file create exceeded its bounded deadline",
            "repository file create task failed",
        )
        .await?;
        Ok(WorkspaceFileRead {
            workspace_id,
            path,
            content: WorkspaceFileContent::Utf8 {
                text: String::new(),
                byte_len: 0,
            },
            revision: Some(WorkspaceFileRevision::new(revision)
                .expect("workspace creator returns a valid SHA-256 revision")),
        })
    }

    async fn create_workspace_directory(
        &self,
        workspace_id: WorkspaceId,
        path: RepositoryPath,
    ) -> Result<WorkspaceEntry, NodeFailure> {
        let canonical_root = self.workspace_root(&workspace_id)?;
        let permit = self.inspection_slots.clone().try_acquire_owned().map_err(|_| {
            failure(NodeFailureCode::BackendBusy, "workspace entry create capacity is busy")
        })?;
        let path_to_create = path.clone();
        let commit_state = Arc::new(AtomicU8::new(WORKSPACE_ENTRY_CREATE_PENDING));
        let task_commit_state = Arc::clone(&commit_state);
        let task = tokio::task::spawn_blocking(move || {
            let _permit = permit;
            create_workspace_directory_on_disk(
                Path::new(&canonical_root),
                &path_to_create,
                &task_commit_state,
            )
        });
        settle_workspace_entry_create(
            task,
            commit_state,
            Duration::from_millis(WORKSPACE_ENTRY_CREATE_TIMEOUT_MS),
            "repository directory create exceeded its bounded deadline",
            "repository directory create task failed",
        )
        .await?;
        Ok(WorkspaceEntry {
            relative_path: path,
            kind: WorkspaceEntryKind::Directory,
        })
    }

    async fn read_git_history(
        &self,
        workspace_id: WorkspaceId,
        path: Option<RepositoryPath>,
        before: Option<GitObjectId>,
        limit: u16,
    ) -> Result<GitHistoryPage, NodeFailure> {
        let _permit = self.inspection_slots.clone().try_acquire_owned().map_err(|_| {
            failure(NodeFailureCode::BackendBusy, "git history capacity is busy")
        })?;
        let root = self.workspace_root(&workspace_id)?;
        read_git_history_bounded(&root, path.as_ref(), before.as_ref(), limit).await
    }

    async fn read_git_diff(
        &self,
        workspace_id: WorkspaceId,
        request: GitDiffRequest,
    ) -> Result<GitDiff, NodeFailure> {
        let _permit = self.inspection_slots.clone().try_acquire_owned().map_err(|_| {
            failure(NodeFailureCode::BackendBusy, "git diff capacity is busy")
        })?;
        let root = self.workspace_root(&workspace_id)?;
        read_git_diff_bounded(&root, request).await
    }

    fn native_session_route_root(
        &self,
        route: &NativeSessionCatalogRoute,
    ) -> Result<Option<String>, NodeFailure> {
        route
            .validate()
            .map_err(|message| failure(NodeFailureCode::InvalidRequest, message))?;
        match route.scope {
            gate4agent_types::NativeSessionCatalogScope::Workspace => route
                .workspace_id
                .as_ref()
                .map(|workspace_id| self.workspace_root(workspace_id))
                .transpose(),
            gate4agent_types::NativeSessionCatalogScope::Unregistered => Ok(None),
        }
    }

    fn project_native_session_entries(
        &self,
        route: &NativeSessionCatalogRoute,
        entries: Vec<ScopedNativeSessionCatalogEntry>,
    ) -> Vec<crate::protocol::NativeSessionCatalogEntry> {
        let current_root = route
            .workspace_id
            .as_ref()
            .and_then(|workspace_id| self.workspace_root(workspace_id).ok());
        let records = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut seen_records = std::collections::HashSet::new();
        entries
            .into_iter()
            .map(|entry| {
                let record_id = route.workspace_id.as_ref().and_then(|workspace_id| {
                    let matches = records
                        .records
                        .values()
                        .filter(|record| {
                            record.provider == route.provider
                                && record.workspace_id == *workspace_id
                                && current_root.as_deref().is_some_and(|root| {
                                    platform::roots_equal(
                                        root,
                                        windows_path_text(&record.canonical_root),
                                    )
                                })
                                && record.provider_session.as_ref().is_some_and(|identity| {
                                    session_registry::same_provider_session(
                                        &record.provider,
                                        identity,
                                        &route.provider,
                                        &entry.provider_session,
                                    )
                                })
                        })
                        .map(|record| record.record_id.clone())
                        .collect::<Vec<_>>();
                    (matches.len() == 1
                        && seen_records.insert(matches[0].clone()))
                        .then(|| matches[0].clone())
                });
                let metadata = entry.metadata;
                crate::protocol::NativeSessionCatalogEntry {
                    selection_id: metadata.selection_id,
                    title: metadata.title,
                    modified_at_unix_ms: metadata.modified_at_unix_ms,
                    model: metadata.model,
                    message_count: metadata.message_count,
                    completed_turn_count: metadata.completed_turn_count,
                    external_group: entry.external_group,
                    record_id,
                }
            })
            .collect()
    }

    async fn catalog_native_sessions(
        &self,
        route: NativeSessionCatalogRoute,
        limit: u16,
    ) -> Result<(
        Vec<crate::protocol::NativeSessionCatalogEntry>,
        crate::protocol::NativeSessionCatalogSummary,
    ), NodeFailure> {
        let canonical_root = self.native_session_route_root(&route)?;
        let registered_workspace_roots = self.workspace_roots();
        let provider = route.provider.clone();
        let scope = route.scope;
        let catalog = self.native_session_catalog.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::InvalidRequest,
                "native session catalog is not configured",
            )
        })?;
        let _permit = Arc::clone(&self.inspection_slots)
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "native session catalog capacity is busy",
                )
            })?;
        let page = run_native_session_catalog_operation(
            catalog,
            "native session catalog",
            move |catalog| {
                catalog.catalog_initial_for_scope(
                    &provider,
                    scope,
                    canonical_root.as_deref().map(Path::new),
                    &registered_workspace_roots,
                    limit,
                )
            },
        )
        .await?;
        let summary = crate::protocol::NativeSessionCatalogSummary {
            catalog_revision: page.revision,
            recent_cutoff_unix_ms: page.cutoff_unix_ms,
            recent_total_count: page.recent_total_count,
            older_total_count: page.older_total_count,
            recent_next_after_selection_id: page.next_after_selection_id,
            recent_has_more: page.remaining_count > 0,
        };
        Ok((self.project_native_session_entries(&route, page.entries), summary))
    }

    async fn page_native_sessions(
        &self,
        route: NativeSessionCatalogRoute,
        window: crate::protocol::NativeSessionCatalogWindow,
        catalog_revision: u64,
        recent_cutoff_unix_ms: u64,
        after_selection_id: Option<String>,
        limit: u16,
    ) -> Result<crate::protocol::NativeSessionCatalogPage, NodeFailure> {
        let canonical_root = self.native_session_route_root(&route)?;
        let registered_workspace_roots = self.workspace_roots();
        let provider = route.provider.clone();
        let scope = route.scope;
        let catalog = self.native_session_catalog.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::InvalidRequest,
                "native session catalog is not configured",
            )
        })?;
        let _permit = Arc::clone(&self.inspection_slots)
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "native session catalog capacity is busy",
                )
            })?;
        let page = run_native_session_catalog_operation(
            catalog,
            "native session catalog page",
            move |catalog| {
                Ok::<_, std::convert::Infallible>(catalog.catalog_page_for_scope(
                    &provider,
                    scope,
                    canonical_root.as_deref().map(Path::new),
                    &registered_workspace_roots,
                    window,
                    catalog_revision,
                    recent_cutoff_unix_ms,
                    after_selection_id.as_deref(),
                    limit,
                ))
            },
        )
        .await?;
        let page = page.map_err(|error| match error {
            NativeSessionCatalogError::StaleCatalog => failure(
                NodeFailureCode::StaleNativeSessionCatalog,
                "native session catalog revision or cursor is stale",
            ),
            _ => failure(
                NodeFailureCode::BackendOperationFailed,
                "native session catalog page failed",
            ),
        })?;
        let entries = self.project_native_session_entries(&route, page.entries);
        Ok(crate::protocol::NativeSessionCatalogPage {
            window: page.window,
            revision: page.revision,
            entries,
            next_after_selection_id: page.next_after_selection_id,
            remaining_count: page.remaining_count,
            has_more: page.remaining_count > 0,
        })
    }

    async fn preview_native_session(
        &self,
        selection: NativeSessionSelection,
        message_limit: u16,
    ) -> Result<crate::protocol::NativeSessionPreview, NodeFailure> {
        selection
            .validate()
            .map_err(|message| failure(NodeFailureCode::InvalidRequest, message))?;
        let canonical_root = self.native_session_route_root(&selection.route)?;
        let registered_workspace_roots = self.workspace_roots();
        let provider = selection.route.provider.clone();
        let scope = selection.route.scope;
        let catalog_revision = selection.catalog_revision;
        let recent_cutoff_unix_ms = selection.recent_cutoff_unix_ms;
        let selection_id = selection.selection_id.clone();
        let catalog = self.native_session_catalog.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::InvalidRequest,
                "native session preview is not configured",
            )
        })?;
        let _permit = Arc::clone(&self.inspection_slots)
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "native session preview capacity is busy",
                )
            })?;
        let preview = run_native_session_catalog_operation(
            catalog,
            "native session preview",
            move |catalog| {
                Ok::<_, std::convert::Infallible>(catalog.preview_for_scope(
                    &provider,
                    scope,
                    canonical_root.as_deref().map(Path::new),
                    &registered_workspace_roots,
                    catalog_revision,
                    recent_cutoff_unix_ms,
                    &selection_id,
                    message_limit,
                ))
            },
        )
        .await?;
        preview
            .map(Into::into)
            .map_err(native_session_preview_failure)
    }

    async fn index_native_session(
        &self,
        selection: NativeSessionSelection,
        display_name: String,
    ) -> Result<ManagedSessionRecord, NodeFailure> {
        selection
            .validate()
            .map_err(|message| failure(NodeFailureCode::InvalidRequest, message))?;
        if selection.route.scope
            != gate4agent_types::NativeSessionCatalogScope::Workspace
        {
            return Err(failure(
                NodeFailureCode::WorkspaceRegistrationRequired,
                "register the external project as a workspace before indexing or resuming it",
            ));
        }
        let workspace_id = selection
            .route
            .workspace_id
            .clone()
            .ok_or_else(|| failure(NodeFailureCode::InvalidRequest, "workspace route is incomplete"))?;
        let canonical_root = self
            .native_session_route_root(&selection.route)?
            .ok_or_else(|| failure(NodeFailureCode::InvalidRequest, "workspace route is incomplete"))?;
        let registered_workspace_roots = self.workspace_roots();
        let provider = selection.route.provider.clone();
        let catalog_revision = selection.catalog_revision;
        let recent_cutoff_unix_ms = selection.recent_cutoff_unix_ms;
        let selection_id = selection.selection_id.clone();
        let catalog = self.native_session_catalog.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::InvalidRequest,
                "native session index is not configured",
            )
        })?;
        let _permit = Arc::clone(&self.inspection_slots)
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "native session index capacity is busy",
                )
            })?;
        let resolved = run_native_session_catalog_operation(
            catalog,
            "native session index resolution",
            move |catalog| {
                Ok::<_, std::convert::Infallible>(catalog.resolve_selection_for_scope(
                    &provider,
                    gate4agent_types::NativeSessionCatalogScope::Workspace,
                    Some(Path::new(&canonical_root)),
                    &registered_workspace_roots,
                    catalog_revision,
                    recent_cutoff_unix_ms,
                    &selection_id,
                ))
            },
        )
        .await?
        .map_err(native_session_preview_failure)?;
        self.index_provider_session_with_policy(
            workspace_id,
            selection.route.provider,
            resolved.identity,
            display_name,
            true,
        )
    }

    async fn preview_native_session_by_session_id(
        &self,
        workspace_id: WorkspaceId,
        provider: AgentId,
        session_id: String,
        message_limit: u16,
    ) -> Result<gate4agent_types::NativeSessionPreview, NodeFailure> {
        let canonical_root = self.workspace_root(&workspace_id)?;
        let registered_workspace_roots = self.workspace_roots();
        let catalog = self.native_session_catalog.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::InvalidRequest,
                "native session preview is not configured",
            )
        })?;
        let _permit = Arc::clone(&self.inspection_slots)
            .try_acquire_owned()
            .map_err(|_| {
                failure(
                    NodeFailureCode::BackendBusy,
                    "native session preview capacity is busy",
                )
            })?;
        run_native_session_catalog_operation(
            catalog,
            "native session preview",
            move |catalog| {
                catalog.preview_session_id_for_workspace(
                    &provider,
                    Path::new(&canonical_root),
                    &registered_workspace_roots,
                    &session_id,
                    message_limit,
                )
            },
        )
        .await
    }

    async fn register_workspace(
        &self,
        workspace_id: WorkspaceId,
        root: String,
    ) -> Result<WorkspaceSnapshot, NodeFailure> {
        validate_workspace_request_root(&root)?;
        let canonicalize_workspace_id = workspace_id.clone();
        let workspace = tokio::task::spawn_blocking(move || {
            WorkspaceConfig::new(canonicalize_workspace_id, root)
        })
        .await
        .map_err(|error| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                &format!("workspace canonicalization task failed: {error}"),
            )
        })?
        .map_err(|error| failure(NodeFailureCode::InvalidWorkspaceRoot, &error.to_string()))?;
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut workspaces = self
            .workspaces
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if workspaces.contains_key(&workspace_id) {
            return Err(failure(
                NodeFailureCode::DuplicateWorkspaceId,
                "workspace ID is already registered",
            ));
        }
        if let Some((existing_id, _)) = workspaces.iter().find(|(_, existing_root)| {
            platform::roots_equal(existing_root, workspace.canonical_root())
        }) {
            return Err(failure(
                NodeFailureCode::DuplicateWorkspaceRoot,
                &format!("workspace root is already registered as '{existing_id}'"),
            ));
        }
        {
            let records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if let Some(record) = records.records.values().find(|record| {
                record.workspace_id == workspace_id
                    && !record
                        .canonical_root
                        .as_utf8()
                        .is_some_and(|root| platform::roots_equal(root, workspace.canonical_root()))
            }) {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    &format!(
                        "workspace ID is retained by session record '{}' at another root",
                        record.record_id,
                    ),
                ));
            }
        }
        let snapshot = WorkspaceSnapshot {
            workspace_id: workspace_id.clone(),
            canonical_root: opaque_windows_path(workspace.canonical_root().to_owned()),
            sessions: Vec::new(),
            worktree_service_mode: Some(WorktreeServiceMode::Manual),
            managed_worktree_profiles: Some(WorktreeProfileInventory {
                profiles: Vec::new(),
            }),
        };
        workspaces.insert(workspace_id.clone(), workspace.canonical_root().to_owned());
        drop(workspaces);
        let previous_records = {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let previous = records.records.clone();
            for record in records.records.values_mut().filter(|record| {
                record.workspace_id == workspace_id
                    && record
                        .canonical_root
                        .as_utf8()
                        .is_some_and(|root| platform::roots_equal(root, workspace.canonical_root()))
            }) {
                if record.active_session.is_none() {
                    record.state = detached_record_state(record);
                }
                if record.last_error.as_deref() == Some(WORKSPACE_UNAVAILABLE_ERROR) {
                    record.last_error = None;
                }
                record.updated_at_unix_ms = unix_time_ms();
            }
            previous
        };
        if let Err(error) = self.persist_state_locked() {
            self.workspaces
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .remove(&workspace_id);
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records = previous_records;
            return Err(persistence_failure(error));
        }
        let restored = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .values()
            .filter(|record| record.workspace_id == workspace_id)
            .cloned()
            .collect::<Vec<_>>();
        drop(transaction);
        self.publish(NodeEvent::WorkspaceAdded {
            workspace: snapshot.clone(),
        });
        for record in restored {
            self.publish_record(record);
        }
        Ok(snapshot)
    }

    async fn create_standalone_workspace(
        &self,
        workspace_id: WorkspaceId,
        root: String,
        initial_branch: Option<String>,
    ) -> Result<WorkspaceSnapshot, NodeFailure> {
        validate_workspace_request_root(&root)?;
        validate_git_revision("initial branch", initial_branch.as_deref())?;
        let preflight_workspace_id = workspace_id.clone();
        let preflight_root = root.clone();
        let canonical_candidate = tokio::task::spawn_blocking(move || {
            canonical_standalone_workspace_candidate(&preflight_workspace_id, &preflight_root)
        })
        .await
        .map_err(|_| failure(
            NodeFailureCode::BackendOperationFailed,
            "standalone workspace root preflight task failed",
        ))?
        .map_err(|error| failure(NodeFailureCode::InvalidWorkspaceRoot, &error.to_string()))?;
        {
            let workspaces = self
                .workspaces
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if workspaces.contains_key(&workspace_id) {
                return Err(failure(
                    NodeFailureCode::DuplicateWorkspaceId,
                    "workspace ID is already registered",
                ));
            }
            if let Some((existing_id, _)) = workspaces.iter().find(|(_, existing_root)| {
                platform::roots_equal(existing_root, &canonical_candidate)
            }) {
                return Err(failure(
                    NodeFailureCode::DuplicateWorkspaceRoot,
                    &format!("workspace root is already registered as '{existing_id}'"),
                ));
            }
        }
        let prepared = prepare_standalone_workspace(root, initial_branch.as_deref())
            .await
            .map_err(standalone_workspace_failure)?;
        prepared
            .verify_for_registration()
            .await
            .map_err(standalone_workspace_failure)?;
        match self
            .register_workspace(workspace_id, prepared.root().to_owned())
            .await
        {
            Ok(workspace) => Ok(workspace),
            Err(registration_error) => {
                if prepared.compensate_registration_failure().await {
                    Err(registration_error)
                } else {
                    Err(failure(
                        NodeFailureCode::StandaloneWorkspaceRecoveryRequired,
                        "standalone workspace initialization succeeded but registration failed; recovery is required",
                    ))
                }
            }
        }
    }

    fn unregister_workspace(&self, workspace_id: &WorkspaceId) -> Result<(), NodeFailure> {
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if bindings.values().any(|binding| &binding.workspace_id == workspace_id) {
            return Err(failure(
                NodeFailureCode::WorkspaceBusy,
                "workspace retains a bound session; remove every session before unregistering it",
            ));
        }
        drop(bindings);
        let transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut workspaces = self
            .workspaces
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if !workspaces.contains_key(workspace_id) {
            return Err(failure(NodeFailureCode::UnknownWorkspace, "workspace does not exist"));
        }
        if workspaces.len() == 1 {
            return Err(failure(
                NodeFailureCode::LastWorkspace,
                "node must retain at least one workspace",
            ));
        }
        let removed_root = workspaces
            .remove(workspace_id)
            .expect("workspace presence was validated");
        drop(workspaces);
        let previous_records = {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let previous = records.records.clone();
            for record in records
                .records
                .values_mut()
                .filter(|record| &record.workspace_id == workspace_id)
            {
                record.active_session = None;
                record.state = ManagedSessionState::Unavailable;
                record.last_error = Some(WORKSPACE_UNAVAILABLE_ERROR.to_owned());
                record.updated_at_unix_ms = unix_time_ms();
            }
            previous
        };
        if let Err(error) = self.persist_state_locked() {
            self.workspaces
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(workspace_id.clone(), removed_root);
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records = previous_records;
            return Err(persistence_failure(error));
        }
        let unavailable = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .values()
            .filter(|record| &record.workspace_id == workspace_id)
            .cloned()
            .collect::<Vec<_>>();
        drop(transaction);
        self.publish(NodeEvent::WorkspaceRemoved {
            workspace_id: workspace_id.clone(),
        });
        for record in unavailable {
            self.publish_record(record);
        }
        Ok(())
    }

    async fn create_worktree(
        &self,
        source_workspace_id: WorkspaceId,
        workspace_id: WorkspaceId,
        target_root: String,
        branch: String,
        base: Option<String>,
    ) -> Result<(GitWorktreeSnapshot, WorkspaceSnapshot), NodeFailure> {
        self.require_worktree_service(&source_workspace_id)?;
        validate_workspace_request_root(&target_root)?;
        validate_git_revision("worktree base", base.as_deref())?;
        let source_root = self.workspace_root(&source_workspace_id)?;
        {
            let workspaces = self
                .workspaces
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if workspaces.contains_key(&workspace_id) {
                return Err(failure(
                    NodeFailureCode::DuplicateWorkspaceId,
                    "workspace ID is already registered",
                ));
            }
            if let Some((existing_id, _)) = workspaces
                .iter()
                .find(|(_, root)| worktree_paths_equal(root, &target_root))
            {
                return Err(failure(
                    NodeFailureCode::DuplicateWorkspaceRoot,
                    &format!("workspace root is already registered as '{existing_id}'"),
                ));
            }
        }
        let mut worktree = create_git_worktree(
            &source_root,
            &target_root,
            &branch,
            base.as_deref(),
        )
        .await
        .map_err(git_worktree_failure)?;
        let workspace = match self
            .register_workspace(workspace_id, worktree.path.clone())
            .await
        {
            Ok(workspace) => workspace,
            Err(registration_error) => {
                if remove_git_worktree(&source_root, &worktree.path).await.is_err() {
                    return Err(failure(
                        NodeFailureCode::ManagedWorktreeRecoveryRequired,
                        "worktree registration failed and compensation requires recovery",
                    ));
                }
                return Err(failure(
                    registration_error.code,
                    &registration_error.message,
                ));
            }
        };
        worktree.workspace_id = Some(workspace.workspace_id.clone());
        Ok((protocol_worktree(worktree), workspace))
    }

    async fn remove_worktree(
        &self,
        source_workspace_id: WorkspaceId,
        target_root: String,
    ) -> Result<Option<WorkspaceId>, NodeFailure> {
        self.require_worktree_service(&source_workspace_id)?;
        validate_workspace_request_root(&target_root)?;
        let source_root = self.workspace_root(&source_workspace_id)?;
        let target_root = normalize_worktree_removal_target(&target_root)
            .map_err(git_worktree_failure)?;
        let target = list_git_worktrees(&source_root)
            .await
            .map_err(git_worktree_failure)?
            .into_iter()
            .find(|worktree| worktree_paths_equal(&worktree.path, &target_root))
            .ok_or_else(|| {
                failure(
                    NodeFailureCode::WorktreeProtected,
                    "refusing to remove a path that is not in Git's worktree listing",
                )
            })?;
        let registered_workspace_id = {
            let workspaces = self
                .workspaces
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let matched = workspaces
                .iter()
                .find(|(_, root)| worktree_paths_equal(root, &target.path))
                .map(|(workspace_id, _)| workspace_id.clone());
            if matched.is_some() && workspaces.len() == 1 {
                return Err(failure(
                    NodeFailureCode::LastWorkspace,
                    "node must retain at least one workspace",
                ));
            }
            matched
        };
        if let Some(workspace_id) = registered_workspace_id.as_ref() {
            let bindings = self
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            if bindings
                .values()
                .any(|binding| &binding.workspace_id == workspace_id)
            {
                return Err(failure(
                    NodeFailureCode::WorkspaceBusy,
                    "worktree workspace retains a bound session; remove every session first",
                ));
            }
        }
        remove_git_worktree(&source_root, &target.path)
            .await
            .map_err(git_worktree_failure)?;
        if let Some(workspace_id) = registered_workspace_id.as_ref() {
            self.unregister_workspace(workspace_id)
                .map_err(|error| failure(error.code, &error.message))?;
        }
        Ok(registered_workspace_id)
    }

    async fn cleanup_managed_worktree(
        &self,
        lease_id: &ManagedWorktreeLeaseId,
        explicit: bool,
    ) -> Result<ManagedWorktreeLeaseSnapshot, NodeFailure> {
        let lease = self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(lease_id)
            .cloned()
            .ok_or_else(|| failure(
                NodeFailureCode::UnknownManagedWorktreeLease,
                "managed worktree lease does not exist",
            ))?;
        if lease.state == ManagedWorktreeLeaseState::Removed {
            return Ok(lease.snapshot());
        }
        if lease.has_holders() {
            return Err(failure(
                NodeFailureCode::ManagedWorktreeBusy,
                "managed worktree lease still has a session or durable-record holder",
            ));
        }
        if self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .any(|record| record.managed_lease_id() == Some(lease_id))
        {
            return Err(failure(
                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                "managed worktree cleanup is blocked by session environment ownership",
            ));
        }
        if !explicit && lease.retention == ManagedWorktreeRetention::Retain {
            let snapshot = {
                let mut registry = self.managed_worktrees.lock()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                let current = registry.get_mut(lease_id)
                    .expect("managed worktree lease remains present");
                current.state = ManagedWorktreeLeaseState::Retained;
                current.cleanup_failure = None;
                current.updated_at_unix_ms = unix_time_ms();
                current.snapshot()
            };
            if self.persist_state().is_err() {
                self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
            }
            self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot.clone() });
            return Ok(snapshot);
        }
        let profile = self.managed_profile(&lease.source_workspace_id, &lease.profile_id)?;
        if profile.revision() != &lease.profile_revision {
            self.mark_managed_recovery_required(
                lease_id,
                ManagedWorktreeCleanupFailure::OwnershipConflict,
            );
            return Err(failure(
                NodeFailureCode::ManagedWorktreeRecoveryRequired,
                "managed worktree profile revision changed",
            ));
        }
        profile.validate_target_authority(&lease.lease_id, &lease.target_root).map_err(|message| {
            self.mark_managed_recovery_required(
                lease_id,
                ManagedWorktreeCleanupFailure::OwnershipConflict,
            );
            failure(NodeFailureCode::ManagedWorktreeOwnershipConflict, &message)
        })?;
        let source_root = self.workspace_root(&lease.source_workspace_id)?;
        let listed = list_git_worktrees(&source_root).await.map_err(|error| {
            self.mark_managed_cleanup_blocked(lease_id, ManagedWorktreeCleanupFailure::Backend);
            managed_git_worktree_failure(error)
        })?;
        let target = listed.iter()
            .find(|item| worktree_paths_equal(&item.path, &lease.target_root));
        if let Some(target) = target {
            if target.is_main || target.is_bare || !exact_owned_worktree(
                &lease,
                &target.path,
                target.branch.as_deref(),
                &target.head,
            ) {
                self.mark_managed_recovery_required(
                    lease_id,
                    ManagedWorktreeCleanupFailure::OwnershipConflict,
                );
                return Err(failure(
                    NodeFailureCode::ManagedWorktreeOwnershipConflict,
                    "Git worktree identity no longer matches the managed lease",
                ));
            }
            if target.prunable {
                self.mark_managed_cleanup_blocked(
                    lease_id,
                    ManagedWorktreeCleanupFailure::Prunable,
                );
                return Err(failure(
                    NodeFailureCode::ManagedWorktreeRecoveryRequired,
                    "managed worktree is prunable and requires recovery",
                ));
            }
            if let Err(error) = remove_git_worktree(&source_root, &target.path).await {
                let failure_kind = match error.kind {
                    GitWorktreeErrorKind::Dirty => ManagedWorktreeCleanupFailure::Dirty,
                    GitWorktreeErrorKind::Locked => ManagedWorktreeCleanupFailure::Locked,
                    GitWorktreeErrorKind::Protected => ManagedWorktreeCleanupFailure::OwnershipConflict,
                    GitWorktreeErrorKind::Conflict => ManagedWorktreeCleanupFailure::Busy,
                    GitWorktreeErrorKind::Invalid | GitWorktreeErrorKind::NotRepository
                    | GitWorktreeErrorKind::Failed => ManagedWorktreeCleanupFailure::Backend,
                };
                if failure_kind == ManagedWorktreeCleanupFailure::OwnershipConflict {
                    self.mark_managed_recovery_required(lease_id, failure_kind);
                } else {
                    self.mark_managed_cleanup_blocked(lease_id, failure_kind);
                }
                return Err(managed_git_worktree_failure(error));
            }
        } else {
            match std::fs::symlink_metadata(&lease.target_root) {
                Err(error) if error.kind() == io::ErrorKind::NotFound => {}
                Ok(_) => {
                    self.mark_managed_recovery_required(
                        lease_id,
                        ManagedWorktreeCleanupFailure::OwnershipConflict,
                    );
                    return Err(failure(
                        NodeFailureCode::ManagedWorktreeOwnershipConflict,
                        "managed target exists but is not owned by Git",
                    ));
                }
                Err(_) => {
                    self.mark_managed_cleanup_blocked(
                        lease_id,
                        ManagedWorktreeCleanupFailure::Backend,
                    );
                    return Err(failure(
                        NodeFailureCode::BackendOperationFailed,
                        "managed target identity could not be inspected",
                    ));
                }
            }
        }
        let registered = self.workspaces.read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .contains_key(&lease.workspace_id);
        if registered {
            self.unregister_workspace(&lease.workspace_id)?;
        }
        let removed = {
            self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .tombstone(lease_id, unix_time_ms())
                .expect("managed worktree lease remains present during cleanup")
        };
        self.persist_state().map_err(persistence_failure)?;
        self.publish(NodeEvent::ManagedWorktreeRemoved { lease_id: lease_id.clone() });
        Ok(removed.snapshot())
    }

    fn mark_managed_cleanup_blocked(
        &self,
        lease_id: &ManagedWorktreeLeaseId,
        failure_kind: ManagedWorktreeCleanupFailure,
    ) {
        let snapshot = {
            let mut registry = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(lease) = registry.get_mut(lease_id) else { return };
            lease.state = ManagedWorktreeLeaseState::CleanupBlocked;
            lease.cleanup_failure = Some(failure_kind);
            lease.updated_at_unix_ms = unix_time_ms();
            lease.snapshot()
        };
        let _ = self.persist_state();
        self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot });
    }

    fn require_worktree_service(
        &self,
        source_workspace_id: &WorkspaceId,
    ) -> Result<(), NodeFailure> {
        if self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .lease_for_workspace(source_workspace_id)
            .is_some()
        {
            return Err(failure(
                NodeFailureCode::ManagedWorktreeOwnershipConflict,
                "managed worktree targets are internal-only workspaces",
            ));
        }
        match self
            .worktree_service_modes
            .get(source_workspace_id)
            .copied()
            .unwrap_or(WorktreeServiceMode::Manual)
        {
            WorktreeServiceMode::Manual => Ok(()),
            WorktreeServiceMode::Managed | WorktreeServiceMode::Off => Err(failure(
                NodeFailureCode::UnsupportedSpawnCapability,
                "Git worktree service mode is unavailable in this node build",
            )),
        }
    }

    fn managed_reservation_conflict(
        &self,
        workspace_id: Option<&WorkspaceId>,
        root: Option<&str>,
    ) -> bool {
        self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .active_records()
            .any(|lease| {
                workspace_id.is_some_and(|workspace_id| {
                    workspace_id == &lease.source_workspace_id
                        || workspace_id == &lease.workspace_id
                }) || root.is_some_and(|root| worktree_paths_equal(root, &lease.target_root))
            })
    }

    fn reject_managed_reservation(
        &self,
        workspace_id: Option<&WorkspaceId>,
        root: Option<&str>,
    ) -> Result<(), NodeFailure> {
        if self.managed_reservation_conflict(workspace_id, root) {
            Err(failure(
                NodeFailureCode::ManagedWorktreeOwnershipConflict,
                "managed worktree ownership may only be mutated through its lease cleanup",
            ))
        } else {
            Ok(())
        }
    }

    fn bound_workspace_root(&self, address: &SessionAddress) -> Result<String, NodeFailure> {
        self.validate_address(address)?;
        self.workspace_root(&address.workspace_id)
    }

    /// `Resume`/`ResumeWithPrompt` are always a raw-PTY relaunch (see
    /// `require_policy`'s own doc on those two requirements), so they keep
    /// gating on `binding.runtime_policy`'s PTY-terminal-text-inference
    /// flags exactly as before; `pipe_transport`/`acp_transport` stay
    /// `false` on the `require_policy` call below for them because a PTY
    /// resume never needs those facts, not because this method cannot look
    /// them up.
    ///
    /// `SemanticPrompt` -- the requirement `Prompt`/`Paste` share -- reads
    /// the SAME `binding.runtime_policy` every other requirement reads here
    /// (one computed policy, read by every gate). That policy is no longer
    /// PTY-terminal-verification-shaped for an ACP session --
    /// `spawn_session_with_deadline` computes it BY TRANSPORT now, through
    /// `provider_runtime::policy_for_transport` -- so consulting it for
    /// `Prompt`/`Paste` on ACP is sound where it used to gate the wrong fact
    /// (this is what made an ACP `Prompt` come back `UnsupportedCapability`
    /// even though a prompt is an ACP session's only interface). Pipe keeps
    /// reading the same PTY-probe-derived value it always has --
    /// `policy_for_transport` passes Pipe through unchanged this pass (see
    /// its own doc for why).
    ///
    /// What this method still adds on top, for ACP/Pipe only, is a
    /// turn-in-flight PRECONDITION ahead of that policy check: a session
    /// takes one turn at a time, so a `Prompt`/`Paste` is refused by name
    /// (`NodeFailureCode::TurnInFlight`) while a turn is already running,
    /// read off the same live `SessionSnapshot` state `require_acp_session`
    /// already reads for the ACP control verbs -- `TurnStarted` observed
    /// with no matching `TurnCompleted` yet is exactly `ProviderSnapshot::
    /// lead_activity != Idle`. Sending a second prompt mid-turn would put
    /// its fate in vendor-specific behaviour this node cannot observe (one
    /// agent may queue it, another drop it, another interleave it), so this
    /// refuses it outright rather than gambling on that -- a rule with no
    /// PTY analogue, which is why PTY does not take this extra precondition.
    fn require_session_runtime_policy(
        &self,
        address: &SessionAddress,
        requirement: ProviderRuntimeRequirement,
    ) -> Result<ProviderRuntimePolicy, NodeFailure> {
        let runtime_policy = {
            let bindings = self
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let binding = bindings
                .get(&address.session.instance_id)
                .ok_or_else(|| failure(NodeFailureCode::UnknownSession, "session instance does not exist"))?;
            if binding.workspace_id != address.workspace_id {
                return Err(failure(
                    NodeFailureCode::SessionWorkspaceMismatch,
                    "session belongs to another workspace",
                ));
            }
            if binding.generation != address.session.generation {
                return Err(failure(NodeFailureCode::StaleGeneration, "session generation is stale"));
            }
            binding.runtime_policy
        };
        if requirement == ProviderRuntimeRequirement::SemanticPrompt {
            let snapshot = self.internal_session_snapshot(address)?;
            if matches!(snapshot.transport, TransportKind::Acp | TransportKind::Pipe)
                && snapshot.provider.lead_activity != ProviderActivity::Idle
            {
                return Err(failure(
                    NodeFailureCode::TurnInFlight,
                    "session already has a turn in flight; wait for it to complete before sending another prompt",
                ));
            }
        }
        require_policy(runtime_policy, false, false, requirement)
            .map(|()| runtime_policy)
            .map_err(|_| failure(
                NodeFailureCode::UnsupportedCapability,
                "session runtime policy does not admit this semantic operation",
            ))
    }

    fn remove_binding(&self, address: &SessionAddress) -> Option<SessionBinding> {
        let mut bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if bindings.get(&address.session.instance_id).is_some_and(|binding| {
            binding.workspace_id == address.workspace_id
                && binding.generation == address.session.generation
        }) {
            let removed = bindings.remove(&address.session.instance_id);
            self.clear_terminal_frame_watermark(address);
            SessionLifecycleHook::on_binding_removed(self, address, removed.as_ref());
            return removed;
        }
        None
    }

    fn cleanup_session_owned_materialization(
        &self,
        address: &SessionAddress,
        binding: &SessionBinding,
    ) -> Result<(), NodeFailure> {
        let Some(id) = binding.materialization_id.as_ref() else {
            return Ok(());
        };
        let owner = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(id)
            .map(|record| record.owner().clone());
        match owner {
            None | Some(MaterializationOwner::Record { .. }) => Ok(()),
            Some(MaterializationOwner::Session {
                incarnation_id,
                instance_id,
                generation,
            }) if incarnation_id == self.incarnation_id
                && instance_id == address.session.instance_id
                && generation == address.session.generation =>
            {
                self.cleanup_materialization(id)
            }
            Some(MaterializationOwner::Session { .. }) => Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "session environment ownership requires recovery",
            )),
        }
    }

    fn clear_terminal_frame_watermark(&self, address: &SessionAddress) {
        let mut watermarks = self
            .terminal_frame_watermarks
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if watermarks
            .get(&address.session.instance_id)
            .is_some_and(|(current, _)| current == address)
        {
            watermarks.remove(&address.session.instance_id);
        }
    }

    #[cfg(test)]
    fn address_for(
        &self,
        instance_id: AgentInstanceId,
        generation: SessionGeneration,
    ) -> Option<SessionAddress> {
        let binding = self.session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&instance_id)
            .cloned()?;
        (binding.generation == generation).then_some(SessionAddress {
            workspace_id: binding.workspace_id,
            session: SessionKey { instance_id, generation },
        })
    }

    fn arm_resume(
        &self,
        address: &SessionAddress,
        command_id: CommandId,
        runtime_policy: ProviderRuntimePolicy,
    ) -> Result<(), NodeFailure> {
        let mut bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let binding = bindings
            .get_mut(&address.session.instance_id)
            .ok_or_else(|| failure(NodeFailureCode::UnknownSession, "session instance does not exist"))?;
        if binding.workspace_id != address.workspace_id {
            return Err(failure(
                NodeFailureCode::SessionWorkspaceMismatch,
                "session belongs to another workspace",
            ));
        }
        if binding.generation != address.session.generation {
            return Err(failure(NodeFailureCode::StaleGeneration, "session generation is stale"));
        }
        binding.pending_resume = Some((binding.generation, command_id, runtime_policy));
        Ok(())
    }

    fn clear_armed_resume(&self, address: &SessionAddress) {
        let mut bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if let Some(binding) = bindings.get_mut(&address.session.instance_id) {
            if binding.workspace_id == address.workspace_id
                && binding.generation == address.session.generation
            {
                binding.pending_resume = None;
            }
        }
    }

    fn publish_control(&self, event: ControlEvent) {
        let revokes_harness_mcp = matches!(
            &event.event,
            ControlEventKind::Exited { .. }
                | ControlEventKind::Failed { .. }
                | ControlEventKind::Removed
        );
        let (address, previous_address, record_id, identity_admitted, resume_command_rejected) = {
            let mut bindings = self
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let Some(binding) = bindings.get_mut(&event.instance_id) else {
                return;
            };
            let previous_address = SessionAddress {
                workspace_id: binding.workspace_id.clone(),
                session: SessionKey {
                    instance_id: event.instance_id,
                    generation: binding.generation,
                },
            };
            let mut resume_command_rejected = false;
            if binding.generation == event.generation {
                if let Some((pending_generation, pending_command_id, _)) = binding.pending_resume {
                    let rejected_resume = matches!(
                        &event.event,
                        ControlEventKind::CommandRejected { .. }
                    ) && event.command_id == Some(pending_command_id);
                    let resume_failed = matches!(
                        &event.event,
                        ControlEventKind::ResumeDenied { .. }
                            | ControlEventKind::ResumeFailed { .. }
                    );
                    if pending_generation == binding.generation
                        && (rejected_resume || resume_failed)
                    {
                        resume_command_rejected = rejected_resume;
                        binding.pending_resume = None;
                    }
                }
            } else {
                let expected = binding.generation.0.checked_add(1);
                let authorized = matches!(&event.event, ControlEventKind::ResumeAuthorized { .. });
                if !binding.pending_resume.is_some_and(|(generation, _, _)| {
                    generation == binding.generation
                })
                    || expected != Some(event.generation.0)
                    || !authorized
                {
                    return;
                }
                let (_, _, runtime_policy) = binding
                    .pending_resume
                    .expect("authorized resume retains its pending runtime policy");
                binding.generation = event.generation;
                binding.runtime_policy = runtime_policy;
                binding.pending_resume = None;
            }
            (
                SessionAddress {
                    workspace_id: binding.workspace_id.clone(),
                    session: SessionKey {
                        instance_id: event.instance_id,
                        generation: event.generation,
                    },
                },
                (previous_address.session.generation != event.generation)
                    .then_some(previous_address),
                binding.record_id.clone(),
                binding.runtime_policy.provider_session_identity,
                resume_command_rejected,
            )
        };
        if let Some(previous_address) = previous_address.as_ref() {
            self.clear_terminal_frame_watermark(previous_address);
        }
        if let Some(record_id) = record_id {
            self.reconcile_managed_record(
                &record_id,
                &address,
                &event,
                identity_admitted,
                resume_command_rejected,
            );
        }
        // Every state change a session's process lifecycle can reach gets a
        // line here: this is the single chokepoint every `ControlEventKind`
        // passes through regardless of transport (PTY/pipe/ACP) or whether it
        // came from a fresh spawn or a resume. Per-message provider chatter
        // (`ProviderEvent`/`ProviderGap`/terminal frames) is deliberately not
        // matched here -- that is exactly the per-frame noise this crate
        // family's level discipline forbids at INFO.
        match &event.event {
            ControlEventKind::Running { process_id } => {
                if let Some(pid) = process_id {
                    crate::git_watch::running(address.workspace_id.as_str(), address.session.instance_id.0, "", *pid);
                }
                #[cfg(unix)]
                if let (Some(proxy), Some(pid)) = (self.signer_proxy.get(), process_id) {
                    proxy.attach_pid(&format!("{}-{}", self.incarnation_id, address.session.instance_id.0), *pid);
                }
                tracing::info!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    pid = ?process_id,
                    "session process is running",
                );
            }
            ControlEventKind::Exited { exit_code, forced } => {
                crate::git_watch::exited(address.workspace_id.as_str(), address.session.instance_id.0);
                #[cfg(unix)]
                if let Some(proxy) = self.signer_proxy.get().cloned() {
                    let key = format!("{}-{}", self.incarnation_id, address.session.instance_id.0);
                    if proxy.has_session(&key) {
                        // Revoke at core off the event path (blocking uplink call).
                        std::thread::spawn(move || proxy.release(&key));
                    }
                }
                tracing::info!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    exit_code = ?exit_code,
                    forced = forced,
                    "session process exited",
                );
            }
            ControlEventKind::Failed { message } => {
                tracing::warn!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    cause = %message,
                    "session failed",
                );
            }
            ControlEventKind::CommandRejected { message } => {
                tracing::warn!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    cause = %message,
                    "session command rejected",
                );
            }
            ControlEventKind::Removed => {
                tracing::info!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    "session removed",
                );
            }
            ControlEventKind::ResumeAuthorized { session: provider_session } => {
                tracing::info!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    provider_session = ?provider_session,
                    "session resume authorized",
                );
            }
            ControlEventKind::Resumed { session: provider_session, process_id } => {
                tracing::info!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    provider_session = ?provider_session,
                    pid = ?process_id,
                    "session resumed",
                );
            }
            ControlEventKind::ResumeDenied { reason } => {
                tracing::warn!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    cause = %reason,
                    "session resume denied",
                );
            }
            ControlEventKind::ResumeFailed { message } => {
                tracing::warn!(
                    node_id = %self.node_id,
                    workspace_id = %address.workspace_id,
                    session = ?address.session,
                    cause = %message,
                    "session resume failed",
                );
            }
            _ => {}
        }
        self.apply_pending_acp_options(&address, &event);
        self.apply_acp_auto_permit(&address, &event);
        trace_acp_turn(&address, &event);
        self.observe_acp_provider_error(&address, &event);
        let stream_chunk = agent_stream_chunk(&event);
        self.publish(NodeEvent::Control {
            address: address.clone(),
            event,
        });
        if let Some(chunk) = stream_chunk {
            self.publish_agent_stream_chunk(address.clone(), chunk);
        }
        if revokes_harness_mcp {
            SessionLifecycleHook::on_session_ended(self, &address);
        }
    }

    fn reconcile_managed_record(
        &self,
        record_id: &SessionRecordId,
        address: &SessionAddress,
        event: &ControlEvent,
        identity_admitted: bool,
        resume_command_rejected: bool,
    ) {
        let _transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let observed_identity = match &event.event {
            ControlEventKind::ProviderEvent {
                event: gate4agent_types::ProviderEvent::SessionIdentityObserved { identity },
                ..
            } if identity_admitted => Some(identity.clone()),
            _ => None,
        };
        let identity_was_observed = observed_identity.is_some();
        let replacement_id = observed_identity
            .as_ref()
            .and_then(|_| self.allocate_record_id().ok());
        let mut upserts = Vec::new();
        let mut removals = Vec::new();
        let mut rebind = None;
        let original_records;
        let original_materializations = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clone();
        {
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            original_records = records.records.clone();
            let Some(current_snapshot) = records.records.get(record_id).cloned() else {
                return;
            };
            if let Some(identity) = observed_identity {
                let existing_id = records
                    .records
                    .values()
                    .find(|record| {
                        record.record_id != *record_id
                            && record.provider_session.as_ref().is_some_and(|record_identity| {
                                session_registry::same_provider_session(
                                    &record.provider,
                                    record_identity,
                                    &current_snapshot.provider,
                                    &identity,
                                )
                            })
                    })
                    .map(|record| record.record_id.clone());
                if let Some(existing_id) = existing_id {
                    let scope_matches = records.records.get(&existing_id).is_some_and(|record| {
                        record.mode == current_snapshot.mode
                            && record.workspace_id == current_snapshot.workspace_id
                            && record.environment_profile == current_snapshot.environment_profile
                            && record.bundle == current_snapshot.bundle
                            && record.context_id == current_snapshot.context_id
                            && record.context == current_snapshot.context
                            && record
                                .canonical_root
                                .as_utf8()
                                .zip(current_snapshot.canonical_root.as_utf8())
                                .is_some_and(|(left, right)| platform::roots_equal(left, right))
                    });
                    if !scope_matches {
                        if let Some(current) = records.records.get_mut(record_id) {
                            current.state = ManagedSessionState::Unavailable;
                            current.last_error =
                                Some(PROVIDER_SESSION_SCOPE_CONFLICT_ERROR.to_owned());
                            current.updated_at_unix_ms = unix_time_ms();
                            upserts.push(current.clone());
                        }
                    } else {
                        let existing_is_active = records
                            .records
                            .get(&existing_id)
                            .is_some_and(|record| record.active_session.is_some());
                        if existing_is_active {
                            if let Some(current) = records.records.get_mut(record_id) {
                                current.state = ManagedSessionState::Unavailable;
                                current.last_error =
                                    Some(PROVIDER_SESSION_LIVE_CONFLICT_ERROR.to_owned());
                                current.updated_at_unix_ms = unix_time_ms();
                                upserts.push(current.clone());
                            }
                        } else {
                            if current_snapshot.provider_session.is_some() {
                                if let Some(current) = records.records.get_mut(record_id) {
                                    current.active_session = None;
                                    current.state = ManagedSessionState::Dormant;
                                    current.updated_at_unix_ms = unix_time_ms();
                                    upserts.push(current.clone());
                                }
                            } else {
                                records.records.remove(record_id);
                                removals.push(record_id.clone());
                            }
                            if let Some(existing) = records.records.get_mut(&existing_id) {
                                existing.provider_session = Some(identity.clone());
                                existing.active_session = Some(address.clone());
                                existing.state = ManagedSessionState::Live;
                                existing.updated_at_unix_ms = unix_time_ms();
                                existing.last_error = None;
                                upserts.push(existing.clone());
                            }
                            rebind = Some(existing_id);
                        }
                    }
                } else if current_snapshot
                    .provider_session
                    .as_ref()
                    .is_some_and(|current| {
                        !session_registry::same_provider_session(
                            &current_snapshot.provider,
                            current,
                            &current_snapshot.provider,
                            &identity,
                        )
                    })
                {
                    if let Some(current) = records.records.get_mut(record_id) {
                        current.active_session = None;
                        if current.bundle.is_some() || current.context.is_some() {
                            let had_bundle = current.bundle.is_some();
                            current.provider_session = None;
                            current.bundle = None;
                            current.context_id = None;
                            current.context = None;
                            current.state = ManagedSessionState::Unavailable;
                            current.last_error = Some(if had_bundle {
                                "bundle-unavailable".to_owned()
                            } else {
                                "context-unavailable".to_owned()
                            });
                        } else {
                            current.state = ManagedSessionState::Dormant;
                        }
                        current.updated_at_unix_ms = unix_time_ms();
                        upserts.push(current.clone());
                    }
                    if records.records.len() >= MAX_MANAGED_SESSION_RECORDS {
                        if let Some(current) = records.records.get_mut(record_id) {
                            current.state = ManagedSessionState::Unavailable;
                            current.last_error =
                                Some(MANAGED_SESSION_CAPACITY_ERROR.to_owned());
                            current.updated_at_unix_ms = unix_time_ms();
                            upserts.push(current.clone());
                        }
                    } else if let Some(new_record_id) = replacement_id {
                        let now = unix_time_ms();
                        let replacement = ManagedSessionRecord {
                            record_id: new_record_id.clone(),
                            display_name: format!(
                                "{} #{}",
                                current_snapshot.provider.as_str(),
                                records
                                    .records
                                    .values()
                                    .filter(|record| {
                                        record.provider == current_snapshot.provider
                                    })
                                    .count()
                                    .saturating_add(1),
                            ),
                            provider: current_snapshot.provider.clone(),
                            mode: current_snapshot.mode,
                            state: ManagedSessionState::Live,
                            workspace_id: current_snapshot.workspace_id,
                            canonical_root: current_snapshot.canonical_root,
                            provider_session: Some(identity),
                            active_session: Some(address.clone()),
                            environment_profile: current_snapshot.environment_profile,
                            bundle: current_snapshot.bundle,
                            context_id: current_snapshot.context_id,
                            context: current_snapshot.context,
                            // This is a fresh record_id representing the session under its
                            // newly-observed identity; it has not yet produced any clean
                            // exit of its own, so it starts with no exported pack (the old
                            // record, still addressable under its own record_id, keeps
                            // whatever exported_context it already had).
                            exported_context: None,
                            task_binding: current_snapshot.task_binding,
                            created_at_unix_ms: now,
                            updated_at_unix_ms: now,
                            last_error: None,
                        };
                        records
                            .records
                            .insert(new_record_id.clone(), replacement.clone());
                        upserts.push(replacement);
                        rebind = Some(new_record_id);
                    } else if let Some(current) = records.records.get_mut(record_id) {
                        current.state = ManagedSessionState::Unavailable;
                        current.last_error =
                            Some(PROVIDER_IDENTITY_ALLOCATION_ERROR.to_owned());
                        upserts.push(current.clone());
                    }
                } else if let Some(current) = records.records.get_mut(record_id) {
                    current.provider_session = Some(identity);
                    current.active_session = Some(address.clone());
                    current.state = ManagedSessionState::Live;
                    current.updated_at_unix_ms = unix_time_ms();
                    current.last_error = None;
                    upserts.push(current.clone());
                }
            } else if let Some(current) = records.records.get_mut(record_id) {
                if resume_command_rejected {
                    current.active_session = None;
                    current.state = detached_record_state(current);
                    current.updated_at_unix_ms = unix_time_ms();
                    current.last_error =
                        Some(PROVIDER_RESUME_REJECTED_ERROR.to_owned());
                    upserts.push(current.clone());
                } else {
                    match &event.event {
                    ControlEventKind::Running { .. }
                    | ControlEventKind::ResumeAuthorized { .. }
                    | ControlEventKind::Resumed { .. } => {
                        current.active_session = Some(address.clone());
                        current.state = active_record_state(
                            identity_admitted,
                            current.provider_session.is_some(),
                        );
                        current.updated_at_unix_ms = unix_time_ms();
                        current.last_error = None;
                        upserts.push(current.clone());
                    }
                    ControlEventKind::Exited { .. } | ControlEventKind::Removed => {
                        current.active_session = None;
                        current.state = detached_record_state(current);
                        current.updated_at_unix_ms = unix_time_ms();
                        upserts.push(current.clone());
                    }
                    ControlEventKind::Failed { message }
                    | ControlEventKind::ResumeFailed { message } => {
                        current.active_session = None;
                        current.state = detached_record_state(current);
                        current.updated_at_unix_ms = unix_time_ms();
                        current.last_error = Some(
                            session_registry::sanitized_record_error_summary(message),
                        );
                        upserts.push(current.clone());
                    }
                    ControlEventKind::ResumeDenied { reason } => {
                        current.active_session = None;
                        current.state = detached_record_state(current);
                        current.updated_at_unix_ms = unix_time_ms();
                        current.last_error = Some(
                            session_registry::sanitized_record_error_summary(reason),
                        );
                        upserts.push(current.clone());
                    }
                        _ => {}
                    }
                }
            }
        }
        let materialization_owner_record = identity_was_observed.then(|| {
            rebind.clone().unwrap_or_else(|| record_id.clone())
        }).and_then(|candidate| {
            self.session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .get(&candidate)
                .filter(|record| {
                    record.provider_session.is_some()
                        && record.active_session.as_ref() == Some(address)
                })
                .map(|_| candidate)
        });
        if let Some(owner_record_id) = materialization_owner_record {
            let materialization_id = self
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&address.session.instance_id)
                .and_then(|binding| binding.materialization_id.clone());
            if let Some(materialization_id) = materialization_id {
                let mut transfer_failed = false;
                {
                    let mut materializations = self
                        .materializations
                        .lock()
                        .unwrap_or_else(|poisoned| poisoned.into_inner());
                    if let Some(ownership) = materializations.get_mut(&materialization_id) {
                        match ownership.owner() {
                            MaterializationOwner::Session {
                                incarnation_id,
                                instance_id,
                                generation,
                            } if *incarnation_id == self.incarnation_id
                                && *instance_id == address.session.instance_id
                                && *generation == address.session.generation =>
                            {
                                transfer_failed = ownership
                                    .transfer_to_record(owner_record_id.clone(), unix_time_ms())
                                    .is_err();
                            }
                            MaterializationOwner::Record { record_id }
                                if record_id == &owner_record_id => {}
                            MaterializationOwner::Record { record_id } => {
                                let expected = record_id.clone();
                                transfer_failed = ownership
                                    .transfer_record_owner(
                                        &expected,
                                        owner_record_id.clone(),
                                        unix_time_ms(),
                                    )
                                    .is_err();
                            }
                            _ => transfer_failed = true,
                        }
                        if transfer_failed {
                            let _ = ownership.mark_recovery_required(unix_time_ms());
                        }
                    } else {
                        transfer_failed = true;
                    }
                }
                if transfer_failed {
                    if let Some(record) = self
                        .session_records
                        .lock()
                        .unwrap_or_else(|poisoned| poisoned.into_inner())
                        .records
                        .get_mut(&owner_record_id)
                    {
                        record.state = ManagedSessionState::Unavailable;
                        record.last_error = Some("environment-profile-unavailable".to_owned());
                        record.updated_at_unix_ms = unix_time_ms();
                        upserts.push(record.clone());
                    }
                }
            }
        }
        if let Some(new_record_id) = rebind.clone() {
            if let Some(binding) = self
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get_mut(&address.session.instance_id)
            {
                binding.record_id = Some(new_record_id);
            }
        }
        if upserts.is_empty() && removals.is_empty() {
            return;
        }
        if self.persist_state_locked().is_err() {
            self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
            let mut records = self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            records.records = original_records;
            *self
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner()) = original_materializations;
            if let Some(current) = records.records.get_mut(record_id) {
                current.state = ManagedSessionState::Unavailable;
                current.last_error = Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned());
                current.updated_at_unix_ms = unix_time_ms();
                upserts = vec![current.clone()];
            } else {
                upserts.clear();
            }
            removals.clear();
            drop(records);
            if let Some(binding) = self
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get_mut(&address.session.instance_id)
            {
                binding.record_id = Some(record_id.clone());
            }
            eprintln!("gate4agent-node: {DURABLE_STATE_COMMIT_FAILED_ERROR}");
        }
        for record in upserts {
            self.publish_record(record);
        }
        for record_id in removals {
            self.publish(NodeEvent::SessionRecordRemoved { record_id });
        }
    }

    fn snapshot(&self) -> NodeSnapshot {
        let control = self.handle.snapshot();
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clone();
        let workspace_roots = self
            .workspaces
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clone();
        let environment_profiles = self
            .environment_profiles
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut workspaces = workspace_roots
            .iter()
            .map(|(workspace_id, canonical_root)| {
                (
                    workspace_id.clone(),
                    WorkspaceSnapshot {
                        workspace_id: workspace_id.clone(),
                        canonical_root: opaque_windows_path(canonical_root.clone()),
                        sessions: Vec::new(),
                        worktree_service_mode: Some(
                            self.worktree_service_modes
                                .get(workspace_id)
                                .copied()
                                .unwrap_or(WorktreeServiceMode::Manual),
                        ),
                        managed_worktree_profiles: Some(WorktreeProfileInventory {
                            profiles: self
                                .managed_worktree_profiles
                                .get(workspace_id)
                                .into_iter()
                                .flat_map(BTreeMap::values)
                                .map(|profile| ManagedWorktreeProfileSummary {
                                    id: profile.profile_id().clone(),
                                    revision: profile.revision().clone(),
                                    retention: profile.retention(),
                                })
                                .collect(),
                        }),
                    },
                )
            })
            .collect::<BTreeMap<_, _>>();
        let mut agent_progress = Vec::new();
        for session in &control.sessions {
            let Some(binding) = bindings.get(&session.instance_id) else {
                continue;
            };
            if binding.generation != session.generation {
                continue;
            }
            if let Some(workspace) = workspaces.get_mut(&binding.workspace_id) {
                let address = SessionAddress {
                    workspace_id: binding.workspace_id.clone(),
                    session: SessionKey {
                        instance_id: session.instance_id,
                        generation: session.generation,
                    },
                };
                if let Some(progress) =
                    agent_progress_from_provider_snapshot(address, &session.provider)
                {
                    agent_progress.push(progress);
                }
                workspace.sessions.push(session.clone());
            }
        }
        NodeSnapshot {
            node_id: self.node_id.clone(),
            enabled_providers: self.enabled_providers.clone(),
            provider_runtime_statuses: {
                let updates = self
                    .provider_runtime_status_updates
                    .read()
                    .unwrap_or_else(|poisoned| poisoned.into_inner());
                ProviderRuntimeStatuses::new(
                    self.provider_runtime_statuses
                        .iter()
                        .filter(|status| !updates.contains_key(status.provider()))
                        .cloned()
                        .chain(updates.values().cloned()),
                )
                .expect("refreshed provider runtime inventory remains bounded and unique")
            },
            workspaces: workspaces.into_values().collect(),
            session_records: self
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records
                .values()
                .cloned()
                .collect(),
            managed_worktrees: self.managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .snapshots(),
            launch_inventory: Some(LaunchInventory {
                spawn_profiles: Some(
                    self.spawn_profiles
                        .iter()
                        .filter_map(|profile| {
                            resolved_spawn_profile_summary(profile, &environment_profiles)
                        })
                        .collect(),
                ),
                bundles: Some(
                    self.bundle_catalog
                        .read()
                        .unwrap_or_else(|poisoned| poisoned.into_inner())
                        .iter()
                        .map(NodeBundle::receipt)
                        .collect(),
                ),
                // Opaque station allowlist ids from empty-default catalog /
                // optional startup loader. Never secrets. Dig2 probe stays stub.
                network_allowlists: {
                    let catalog = self
                        .network_allowlist_catalog
                        .read()
                        .unwrap_or_else(|poisoned| poisoned.into_inner());
                    if catalog.is_empty() {
                        None
                    } else {
                        Some(catalog.ids().cloned().collect())
                    }
                },
            }),
            agent_progress,
        }
    }

    fn publish(&self, event: NodeEvent) -> NodeEventEnvelope {
        assert!(
            !matches!(
                &event,
                NodeEvent::TerminalFrame { .. } | NodeEvent::AgentStream { .. }
            ),
            "terminal frame and agent stream events must use their own dedicated live channel",
        );
        let mut history = self.history.lock().unwrap_or_else(|poisoned| poisoned.into_inner());
        let sequence = history
            .last_sequence
            .checked_add(1)
            .expect("node event sequence exhausted");
        if history.events.len() == NODE_EVENT_HISTORY_MAX {
            if let Some(evicted) = history.events.pop_front() {
                history.replay_floor_sequence = evicted
                    .sequence
                    .checked_add(1)
                    .expect("node replay floor sequence exhausted");
                history.removed_record_providers.remove(&evicted.sequence);
            }
        }
        match &event {
            NodeEvent::HarnessMcpReadCall { .. } => {
                panic!("transient harness MCP calls must not enter durable event history")
            }
            NodeEvent::SessionRecordUpserted { record } => {
                history
                    .record_providers
                    .insert(record.record_id.clone(), record.provider.clone());
            }
            NodeEvent::SessionRecordRemoved { record_id } => {
                if let Some(provider) = history.record_providers.remove(record_id) {
                    history.removed_record_providers.insert(sequence, provider);
                }
            }
            NodeEvent::ManagedWorktreeUpserted { .. }
            | NodeEvent::ManagedWorktreeRemoved { .. }
            | NodeEvent::Control { .. }
            | NodeEvent::ControllerChanged { .. }
            | NodeEvent::SessionRecordHistorySummarized { .. }
            | NodeEvent::WorkspaceAdded { .. }
            | NodeEvent::WorkspaceRemoved { .. }
            | NodeEvent::ResyncRequired { .. }
            | NodeEvent::AgentStream { .. }
            | NodeEvent::TerminalFrame { .. } => {}
        }
        let envelope = NodeEventEnvelope { sequence, event };
        history.events.push_back(envelope.clone());
        history.last_sequence = sequence;
        let _ = self.event_tx.send(envelope.clone());
        drop(history);
        envelope
    }

    /// Publishes a transient (never durable) `NodeEvent` -- today only
    /// `NodeEvent::HarnessMcpReadCall` -- onto the dedicated
    /// `harness_mcp_proxy_event_tx` broadcast (see that field's own doc for
    /// why this must never ride the shared `event_tx` bus). Returns whether
    /// the send reached at least one subscriber: `broadcast::Sender::send`
    /// fails in exactly one way, no active receiver at that instant, and
    /// the caller (`HarnessMcpProxyRegistry::begin_call`) uses a `false`
    /// return to fail the pending call immediately rather than leave it to
    /// expire silently at `LOCAL_READ_TIMEOUT`/
    /// `MAX_HARNESS_MCP_CALL_DEADLINE_MS`.
    fn publish_transient(&self, event: NodeEvent) -> bool {
        assert!(event.requires_harness_mcp_proxy_capability());
        assert!(event.harness_mcp_contract_is_valid_at(unix_time_ms()));
        let envelope = NodeEventEnvelope { sequence: 0, event };
        match self.harness_mcp_proxy_event_tx.send(Arc::new(vec![envelope])) {
            Ok(_) => true,
            Err(broadcast::error::SendError(undelivered)) => {
                if let Some(NodeEventEnvelope {
                    event: NodeEvent::HarnessMcpReadCall { call_id, request, .. },
                    ..
                }) = undelivered.first() {
                    // `request.content_type` only, never a per-tool label --
                    // this crate does not decode `request.body` and does not
                    // hold `hatchery-harness-api` (Nested Control Plane
                    // doctrine, Law 3; see this crate's dependency on
                    // `gate4agent-node-protocol`'s own `Forbidden:` line).
                    tracing::warn!(
                        call_id = call_id.as_str(),
                        content_type = ?request.content_type,
                        cause = "no-subscribers",
                        "harness MCP proxy event could not be published",
                    );
                }
                false
            }
        }
    }

    fn publish_terminal_frames(&self) {
        let snapshot = self.handle.snapshot();
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let candidates = snapshot
            .sessions
            .iter()
            .filter_map(|session| {
                let binding = bindings.get(&session.instance_id)?;
                if binding.generation != session.generation {
                    return None;
                }
                let frame = session.terminal_frame.clone()?;
                crate::session_signals::feed(
                    binding.workspace_id.as_str(),
                    session.instance_id.0,
                    session.agent_id.as_str(),
                    &frame.contents,
                );
                crate::provider_limits::observe_screen(session.agent_id.as_str(), &frame.contents);
                let act = self.provider_errors.lock().unwrap_or_else(|p| p.into_inner()).observe_screen(session.instance_id.0, &frame.contents, Instant::now());
                if let Some(act) = act {
                    provider_error_act(binding.workspace_id.as_str(), session.instance_id.0, session.agent_id.as_str(), "pty", act);
                }
                crate::git_watch::provider_hint(binding.workspace_id.as_str(), session.instance_id.0, session.agent_id.as_str());
                Some((
                    SessionAddress {
                        workspace_id: binding.workspace_id.clone(),
                        session: SessionKey {
                            instance_id: session.instance_id,
                            generation: session.generation,
                        },
                    },
                    frame,
                ))
            })
            .collect();
        drop(bindings);
        self.publish_terminal_frame_candidates(candidates);
    }

    fn publish_terminal_frame_candidates(
        &self,
        candidates: Vec<(SessionAddress, TerminalFrame)>,
    ) {
        let mut watermarks = self
            .terminal_frame_watermarks
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut events = Vec::with_capacity(candidates.len());
        for (address, frame) in candidates {
            let is_first_frame = !watermarks.contains_key(&address.session.instance_id);
            let advanced = watermarks
                .get(&address.session.instance_id)
                .map_or(true, |(current_address, sequence)| {
                    current_address != &address || frame.sequence > *sequence
                });
            if !advanced {
                continue;
            }
            if is_first_frame {
                // Do NOT sessionize on first PTY output: a session is a
                // provider conversation id, not bytes on the wire. Drafts
                // leave the provisional map only when HQ attaches
                // (Resize / TerminalBytes). The attach-never-arrived timer
                // (PROVISIONAL_SPAWN_GRACE_MS) covers deploy lag; HQ's
                // disconnect grace starts only on a real client WS close.
                // This is the first PTY output this node has observed for
                // this session -- a one-time event per spawn, not per-frame
                // chatter (the watermark makes sure of that). A session that
                // reaches this line with no controller attached anywhere on
                // the node is running unobserved: exactly how processes from
                // repeated spawn attempts went orphaned for hours without a
                // single line about it.
                if self.controller_state().is_none() {
                    tracing::warn!(
                        node_id = %self.node_id,
                        workspace_id = %address.workspace_id,
                        session = ?address.session,
                        terminal_size = ?frame.size,
                        "session producing output with no controller attached",
                    );
                } else {
                    tracing::info!(
                        node_id = %self.node_id,
                        workspace_id = %address.workspace_id,
                        session = ?address.session,
                        terminal_size = ?frame.size,
                        "session produced its first output",
                    );
                }
            }
            watermarks.insert(
                address.session.instance_id,
                (address.clone(), frame.sequence),
            );
            if let Some((at, reported)) = self
                .pty_input_marks
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get_mut(&address.session.instance_id)
            {
                // First frame after an input: PTY write -> output published.
                if !*reported && at.elapsed() < Duration::from_secs(5) {
                    *reported = true;
                    tracing::debug!(target: "pty_lat", instance_id = address.session.instance_id.0, node_us = at.elapsed().as_micros() as u64, "pty input to frame published");
                }
            }
            events.push(NodeEvent::TerminalFrame { address, frame });
        }
        drop(watermarks);
        if events.is_empty() {
            return;
        }
        let mut history = self
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let mut envelopes = Vec::with_capacity(events.len());
        for event in events {
            let sequence = history
                .last_sequence
                .checked_add(1)
                .expect("node event sequence exhausted");
            history.last_sequence = sequence;
            envelopes.push(NodeEventEnvelope { sequence, event });
        }
        let _ = self.terminal_event_tx.send(Arc::new(envelopes));
        drop(history);
    }

    /// Publishes one `AgentStreamChunkV1` onto the dedicated agent-stream
    /// channel, mirroring `publish_terminal_frame_candidates` above: the
    /// envelope's `sequence` is drawn from the same `history.last_sequence`
    /// counter every other event kind shares, never a counter of its own --
    /// `queue_connection_event`/`queue_connection_event_batch` compare
    /// `envelope.sequence` against one `discard_events_through` watermark
    /// regardless of which broadcast channel it arrived on, so a
    /// per-channel counter would desynchronize that comparison.
    fn publish_agent_stream_chunk(&self, address: SessionAddress, chunk: AgentStreamChunkV1) {
        let mut history = self
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let sequence = history
            .last_sequence
            .checked_add(1)
            .expect("node event sequence exhausted");
        history.last_sequence = sequence;
        drop(history);
        // Debug, not info/warn -- this fires on every single chunk, but it
        // is exactly the counter the next drop-measurement pass needs: what
        // the node actually emitted (`source_sequence`, `kind`) versus what
        // a harness subscriber's own forwarder later logs having received
        // (`hatchery-harness-service::runtime`'s "forwarding agent stream
        // event"), so a gap between the two logs names itself instead of
        // needing a new counter added ad hoc.
        tracing::debug!(
            source_sequence = chunk.source_sequence,
            kind = agent_stream_chunk_kind_label(&chunk.kind),
            envelope_sequence = sequence,
            "publishing agent stream chunk",
        );
        let envelope = NodeEventEnvelope {
            sequence,
            event: NodeEvent::AgentStream { address, chunk },
        };
        let _ = self.agent_stream_event_tx.send(Arc::new(vec![envelope]));
    }

    fn current_sequence(&self) -> u64 {
        self.history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .last_sequence
    }

    fn controller_state(&self) -> Option<ControllerState> {
        let mut controller = self.controller.lock().unwrap_or_else(|poisoned| poisoned.into_inner());
        let lease = controller.as_ref().copied()?;
        let remaining = lease.expires_at.saturating_duration_since(Instant::now());
        if remaining.is_zero() {
            *controller = None;
            return None;
        }
        Some(ControllerState {
            connection_id: lease.connection_id,
            lease_remaining_ms: remaining.as_millis().min(u64::MAX as u128) as u64,
        })
    }

    fn acquire_controller(&self, connection_id: u64, role: ClientRole, lease_ms: u64) -> Result<ControllerState, NodeFailure> {
        if role != ClientRole::Operator {
            tracing::warn!(
                node_id = %self.node_id,
                connection_id,
                "controller lease rejected: observer connections cannot acquire control",
            );
            return Err(failure(NodeFailureCode::ObserverReadOnly, "observer connections cannot acquire control"));
        }
        let lease_ms = if lease_ms == 0 {
            DEFAULT_CONTROLLER_LEASE_MS
        } else {
            lease_ms.clamp(MIN_CONTROLLER_LEASE_MS, MAX_CONTROLLER_LEASE_MS)
        };
        let now = Instant::now();
        let mut controller = self.controller.lock().unwrap_or_else(|poisoned| poisoned.into_inner());
        if let Some(active) = controller.as_ref() {
            if active.connection_id != connection_id && active.expires_at > now {
                tracing::warn!(
                    node_id = %self.node_id,
                    connection_id,
                    holder_connection_id = active.connection_id,
                    "controller lease rejected: another operator holds it",
                );
                return Err(failure(NodeFailureCode::ControllerBusy, "another operator holds the controller lease"));
            }
        }
        // A reconnect (this connection already holds the lease, renewing
        // before expiry) happens on a periodic cadence; logging it at INFO
        // every renewal would be exactly the heartbeat chatter this crate
        // family's level discipline forbids. A genuine attach -- the
        // controller identity actually changing -- is a state change and
        // gets INFO; a same-connection renewal gets DEBUG.
        let is_new_attach = match controller.as_ref() {
            Some(active) => active.connection_id != connection_id,
            None => true,
        };
        *controller = Some(ControllerLease {
            connection_id,
            expires_at: now + Duration::from_millis(lease_ms),
        });
        drop(controller);
        let state = ControllerState { connection_id, lease_remaining_ms: lease_ms };
        if is_new_attach {
            tracing::info!(
                node_id = %self.node_id,
                connection_id,
                lease_ms,
                "controller lease acquired",
            );
        } else {
            tracing::debug!(
                node_id = %self.node_id,
                connection_id,
                lease_ms,
                "controller lease renewed",
            );
        }
        self.publish(NodeEvent::ControllerChanged { controller: Some(state.clone()) });
        Ok(state)
    }

    fn release_controller(&self, connection_id: u64) -> bool {
        let mut controller = self.controller.lock().unwrap_or_else(|poisoned| poisoned.into_inner());
        let released = controller.as_ref().is_some_and(|active| active.connection_id == connection_id);
        if released {
            *controller = None;
        }
        drop(controller);
        if released {
            tracing::info!(
                node_id = %self.node_id,
                connection_id,
                "controller lease released",
            );
            self.publish(NodeEvent::ControllerChanged { controller: None });
        }
        released
    }

    /// Mark a fresh Spawn as provisional and arm the attach-never-arrived
    /// reaper (PROVISIONAL_SPAWN_GRACE_MS from spawn). Removed from this map
    /// only when HQ attaches (Resize / TerminalBytes) — that is *not* a
    /// provider session; it only cancels the orphan timer. Disconnect/reload
    /// draft kills are owned by HQ and arm only on a real client WS close.
    /// ACP path of launch options: once the agent advertises its config options, write the
    /// pending model / effort through session/set_config_option (session/set_model when the
    /// agent has no model option). Gaps are logged, never forced.
    fn apply_pending_acp_options(&self, address: &SessionAddress, event: &ControlEvent) {
        let ControlEventKind::ProviderEvent { event: ProviderEvent::ConfigOptionsUpdated { options }, .. } = &event.event else {
            return;
        };
        let id = address.session.instance_id;
        let Some((model, effort)) = self.pending_acp_options.lock().unwrap_or_else(|p| p.into_inner()).remove(&id) else {
            return;
        };
        let advertised: Vec<(String, Option<String>, Vec<String>)> = options
            .iter()
            .map(|o| (o.id.clone(), o.category.clone(), o.choices.iter().map(|c| c.value_json.clone()).collect()))
            .collect();
        let (writes, set_model, effort_gap) =
            backend_paths::acp_option_writes(&advertised, model.as_deref(), effort.as_deref());
        if set_model {
            if let Some(model_id) = model.clone() {
                if let Err(e) = self.dispatch(ControlCommand::SetSessionModel { instance_id: id, model_id }) {
                    tracing::warn!(instance_id = id.0, message = %e.message, "acp set_model failed");
                }
            }
        }
        for (option_id, value_json) in writes {
            if let Err(e) = self.dispatch(ControlCommand::SetSessionConfigOption { instance_id: id, option_id, value_json }) {
                tracing::warn!(instance_id = id.0, message = %e.message, "acp set_config_option failed");
            }
        }
        if effort_gap {
            tracing::warn!(instance_id = id.0, effort = ?effort, "acp agent advertises no matching thought_level option; effort not applied");
        }
        tracing::info!(instance_id = id.0, model = ?model, effort = ?effort, "launch options applied over acp");
    }

    /// ACP auto-permit: switch to the provider's no-ask mode once modes are advertised, and
    /// answer every session/request_permission with approve.
    fn apply_acp_auto_permit(&self, address: &SessionAddress, event: &ControlEvent) {
        let id = address.session.instance_id;
        let Some(provider) = crate::auto_permit::acp_provider(id.0) else { return };
        if matches!(&event.event, ControlEventKind::Exited { .. } | ControlEventKind::Failed { .. } | ControlEventKind::Removed) {
            crate::auto_permit::forget_acp(id.0);
            return;
        }
        let ControlEventKind::ProviderEvent { sequence, event: provider_event, .. } = &event.event else { return };
        if let ProviderEvent::InteractionRequested { request_id, interaction_kind, options, .. } = provider_event {
            tracing::debug!(instance_id = id.0, sequence = *sequence, request_id = ?request_id, kind = ?interaction_kind, options = options.len(), "acp interaction requested");
        }
        match provider_event {
            ProviderEvent::ModeChanged { mode_id, available } => {
                if let Some(want) = crate::auto_permit::pick_acp_mode(provider, mode_id, available.iter().map(|m| m.id.as_str())) {
                    match self.dispatch(ControlCommand::SetSessionMode { instance_id: id, mode_id: want.clone() }) {
                        Ok(_) => tracing::info!(instance_id = id.0, provider, mode = %want, "acp auto-permit mode set"),
                        Err(e) => tracing::warn!(instance_id = id.0, provider, message = %e.message, "acp auto-permit set_mode failed"),
                    }
                }
            }
            ProviderEvent::InteractionRequested { interaction_kind: gate4agent_types::ProviderInteractionKind::Approval, tool_name, options, .. } if !options.is_empty() => {
                match self.dispatch(ControlCommand::ResolveInteraction {
                    instance_id: id,
                    generation: address.session.generation,
                    interaction_id: gate4agent_types::ProviderInteractionId(*sequence),
                    response: gate4agent_types::ProviderInteractionResponse::ApproveOnce,
                }) {
                    Ok(_) => tracing::info!(instance_id = id.0, provider, tool = %tool_name, "acp permission auto-approved"),
                    Err(e) => tracing::warn!(instance_id = id.0, provider, message = %e.message, "acp auto-approve failed"),
                }
            }
            // NB: ACP emits SessionEnded at the end of every *turn* (prompt stopReason), so it
            // must not drop the auto-permit registration; that happens on process exit below.
            _ => {}
        }
    }

    /// ACP side of the provider error classifier: remember the turn's prompt, reset on a clean
    /// end, classify a turn that ended with a provider error (or a provider `Error` event).
    fn observe_acp_provider_error(&self, address: &SessionAddress, event: &ControlEvent) {
        let id = address.session.instance_id.0;
        let found = match &event.event {
            ControlEventKind::Exited { .. } | ControlEventKind::Removed => {
                self.provider_errors.lock().unwrap_or_else(|p| p.into_inner()).forget(id);
                return;
            }
            ControlEventKind::ProviderEvent { event: e, .. } => match e {
                ProviderEvent::TurnStarted { prompt } => {
                    self.provider_errors.lock().unwrap_or_else(|p| p.into_inner()).turn_started(id, prompt.as_deref());
                    return;
                }
                ProviderEvent::SessionEnded { is_error: false, .. } => {
                    self.provider_errors.lock().unwrap_or_else(|p| p.into_inner()).turn_ok(id);
                    return;
                }
                ProviderEvent::SessionEnded { stop_reason: Some(ProviderStopReason::ProviderError { message, vendor_code, .. }), .. } => crate::provider_error::classify_message(message, vendor_code.as_deref()),
                ProviderEvent::Error { message } => crate::provider_error::classify_message(message, None),
                _ => return,
            },
            _ => return,
        };
        let provider = crate::auto_permit::acp_provider(id).map(|p| p.to_string()).unwrap_or_else(|| "acp".into());
        let act = self.provider_errors.lock().unwrap_or_else(|p| p.into_inner()).observe_acp_error(id, found, Instant::now());
        if let Some(act) = act {
            provider_error_act(address.workspace_id.as_str(), id, &provider, "acp", act);
        }
    }

    /// Run provider-error retries whose backoff is over (called from the drive loop).
    fn run_due_provider_retries(&self) {
        let due = self.provider_errors.lock().unwrap_or_else(|p| p.into_inner()).take_due(Instant::now());
        for (id, how, attempt) in due {
            let instance_id = AgentInstanceId(id);
            let r = match how {
                crate::provider_error::Retry::Pty => self
                    .dispatch(ControlCommand::SendInput { instance_id, action: InputAction::TerminalText(TerminalText { text: "continue".to_owned() }) })
                    .and_then(|_| self.dispatch(ControlCommand::SendInput { instance_id, action: InputAction::TerminalControl(TerminalControl::Enter) })),
                crate::provider_error::Retry::Acp { prompt } => self.dispatch(ControlCommand::SendInput {
                    instance_id,
                    action: InputAction::SubmitPrompt(PromptPayload { text: prompt, framing: PromptFraming::BracketedPaste }),
                }),
            };
            match r {
                Ok(_) => tracing::info!(target: "provider_retry", instance_id = id, attempt, "provider error: turn retried"),
                Err(e) => tracing::warn!(target: "provider_retry", instance_id = id, attempt, message = %e.message, "provider error: retry not sent"),
            }
        }
    }

    fn mark_spawn_provisional(&self, address: SessionAddress) {
        let id = address.session.instance_id;
        self.provisional_spawns
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(id, (address, Instant::now()));
        tracing::info!(
            node_id = %self.node_id,
            instance_id = id.0,
            grace_ms = PROVISIONAL_SPAWN_GRACE_MS,
            "draft spawn; waiting for HQ view",
        );
    }

    fn sessionize_spawn(&self, instance_id: AgentInstanceId) {
        let removed = self
            .provisional_spawns
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .remove(&instance_id);
        if removed.is_some() {
            tracing::info!(
                node_id = %self.node_id,
                instance_id = instance_id.0,
                "draft spawn claimed by HQ view",
            );
        }
    }

    fn take_due_provisional_spawns(&self) -> Vec<SessionAddress> {
        let grace = Duration::from_millis(PROVISIONAL_SPAWN_GRACE_MS);
        let mut map = self
            .provisional_spawns
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let due: Vec<AgentInstanceId> = map
            .iter()
            .filter(|(_, (_, at))| at.elapsed() >= grace)
            .map(|(id, _)| *id)
            .collect();
        due.into_iter()
            .filter_map(|id| map.remove(&id).map(|(addr, _)| addr))
            .collect()
    }

    async fn reap_provisional_spawn(&self, address: SessionAddress) {
        let instance_id = address.session.instance_id;
        tracing::warn!(
            node_id = %self.node_id,
            instance_id = instance_id.0,
            workspace = %address.workspace_id,
            reason = "attach_never_arrived",
            grace_ms = PROVISIONAL_SPAWN_GRACE_MS,
            "draft spawn never viewed; stopping PTY",
        );
        let _ = self.dispatch(ControlCommand::Stop {
            instance_id,
            force: true,
        });
        let _ = self.remove_session(&address).await;
    }

    fn require_controller(&self, connection_id: u64, role: ClientRole) -> Result<(), NodeFailure> {
        if role != ClientRole::Operator {
            return Err(failure(NodeFailureCode::ObserverReadOnly, "observer connections are read-only"));
        }
        let mut controller = self.controller.lock().unwrap_or_else(|poisoned| poisoned.into_inner());
        let now = Instant::now();
        match controller.as_ref().copied() {
            Some(active) if active.connection_id == connection_id && active.expires_at > now => Ok(()),
            Some(active) if active.expires_at <= now => {
                *controller = None;
                Err(failure(NodeFailureCode::ControllerRequired, "controller lease expired"))
            }
            _ => Err(failure(NodeFailureCode::ControllerRequired, "controller lease is required")),
        }
    }

    fn validate_address(&self, address: &SessionAddress) -> Result<AgentId, NodeFailure> {
        if !self
            .workspaces
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .contains_key(&address.workspace_id)
        {
            return Err(failure(NodeFailureCode::UnknownWorkspace, "workspace does not exist"));
        }
        let binding = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&address.session.instance_id)
            .cloned()
            .ok_or_else(|| failure(NodeFailureCode::UnknownSession, "session instance does not exist"))?;
        if binding.workspace_id != address.workspace_id {
            return Err(failure(
                NodeFailureCode::SessionWorkspaceMismatch,
                "session belongs to another workspace",
            ));
        }
        if binding.generation != address.session.generation {
            return Err(failure(
                NodeFailureCode::StaleGeneration,
                &format!(
                    "stale session generation: expected {}, received {}",
                    binding.generation.0,
                    address.session.generation.0,
                ),
            ));
        }
        let snapshot = self.handle.snapshot();
        let Some(current) = snapshot
            .sessions
            .iter()
            .find(|item| item.instance_id == address.session.instance_id)
        else {
            return Err(failure(NodeFailureCode::UnknownSession, "session instance does not exist"));
        };
        if current.generation != address.session.generation {
            return Err(failure(
                NodeFailureCode::StaleGeneration,
                &format!(
                    "stale session generation: expected {}, received {}",
                    current.generation.0,
                    address.session.generation.0,
                ),
            ));
        }
        Ok(current.agent_id.clone())
    }

    fn dispatch(&self, command: ControlCommand) -> Result<CommandId, NodeFailure> {
        self.dispatch_envelope(self.prepare_command(command))
    }

    fn prepare_command(&self, command: ControlCommand) -> CommandEnvelope {
        let id = self.next_command_id.fetch_add(1, Ordering::AcqRel);
        CommandEnvelope {
            id: CommandId(id),
            command,
        }
    }

    fn dispatch_envelope(&self, envelope: CommandEnvelope) -> Result<CommandId, NodeFailure> {
        let command_id = envelope.id;
        self.handle
            .dispatch(envelope)
            .map_err(|error| match error {
                PortDispatchError::Full => failure(NodeFailureCode::BackendBusy, "backend command ingress is full"),
                PortDispatchError::Disconnected => failure(NodeFailureCode::BackendDisconnected, "backend command ingress is disconnected"),
            })?;
        Ok(command_id)
    }

    /// Records the kernel's own reason for asynchronously refusing
    /// `command_id` -- see `rejected_command_reasons`'s doc for why a
    /// spawn-dispatch waiter otherwise has no way to learn it. Bounded by
    /// `REJECTED_COMMAND_REASON_MAX_ENTRIES`: expired entries are swept
    /// first, and if the map is still at capacity after that, the single
    /// oldest surviving entry is evicted -- `CommandId` is monotonically
    /// assigned (`next_command_id.fetch_add`), so the `BTreeMap`'s first key
    /// is always the oldest.
    fn record_rejected_command(
        &self,
        command_id: CommandId,
        message: String,
        unsupported_transport: bool,
    ) {
        let now = Instant::now();
        let mut reasons = self.rejected_command_reasons.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        reasons.retain(|_, reason| reason.expires_at > now);
        if reasons.len() >= REJECTED_COMMAND_REASON_MAX_ENTRIES {
            if let Some(&oldest) = reasons.keys().next() {
                reasons.remove(&oldest);
            }
        }
        reasons.insert(
            command_id,
            RejectedCommandReason {
                message,
                unsupported_transport,
                expires_at: now + Duration::from_millis(REJECTED_COMMAND_REASON_TTL_MS),
            },
        );
    }

    /// Removes and returns the kernel's reason for refusing `command_id`,
    /// if the drive loop has recorded one and it has not expired -- see
    /// `rejected_command_reasons`'s doc. Consumed at most once: a spawn
    /// wait loop calls this instead of blindly polling out its whole
    /// deadline when the command it is waiting on turns out to have been
    /// refused rather than merely slow.
    fn take_rejected_command_reason(&self, command_id: CommandId) -> Option<RejectedCommandReason> {
        let now = Instant::now();
        let mut reasons = self.rejected_command_reasons.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        match reasons.remove(&command_id) {
            Some(reason) if reason.expires_at > now => Some(reason),
            _ => None,
        }
    }

    async fn dispatch_bounded(
        &self,
        command: ControlCommand,
        timeout_duration: Duration,
    ) -> Result<CommandId, NodeFailure> {
        let deadline = Instant::now() + timeout_duration;
        loop {
            match self.dispatch(command.clone()) {
                Ok(command_id) => return Ok(command_id),
                Err(error) if error.code == NodeFailureCode::BackendBusy && Instant::now() < deadline => {
                    sleep(Duration::from_millis(2)).await;
                }
                Err(error) => return Err(error),
            }
        }
    }

    fn internal_session_snapshot(
        &self,
        address: &SessionAddress,
    ) -> Result<gate4agent_types::SessionSnapshot, NodeFailure> {
        self.validate_address(address)?;
        self.handle
            .snapshot()
            .sessions
            .clone()
            .into_iter()
            .find(|session| {
                session.instance_id == address.session.instance_id
                    && session.generation == address.session.generation
            })
            .ok_or_else(|| {
                failure(
                    NodeFailureCode::UnknownSession,
                    "session snapshot is unavailable",
                )
            })
    }

    /// Confirms `address` names a live session spawned over the ACP
    /// transport and returns its current snapshot -- the gate every
    /// `acp-control-v1` verb shares. `require_session_runtime_policy`
    /// cannot answer this by itself: `ProviderRuntimePolicy` carries no
    /// transport bit for `Acp`/`Inline` (see that method's own doc), only
    /// the session's own recorded `TransportKind` does, and that lives on
    /// the live snapshot, not the binding.
    fn require_acp_session(
        &self,
        address: &SessionAddress,
    ) -> Result<gate4agent_types::SessionSnapshot, NodeFailure> {
        let snapshot = self.internal_session_snapshot(address)?;
        if snapshot.transport != TransportKind::Acp {
            return Err(failure(
                NodeFailureCode::UnsupportedTransport,
                "this verb requires a session spawned over the ACP transport",
            ));
        }
        Ok(snapshot)
    }

    async fn dispatch_history_bounded(
        &self,
        address: &SessionAddress,
        command: ControlCommand,
        operation: HistoryOperation,
    ) -> Result<gate4agent_types::SessionSnapshot, NodeFailure> {
        self.validate_address(address)?;
        let started_after = self.current_sequence();
        let command_id = self
            .dispatch_bounded(
                command,
                Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
            )
            .await?;
        let deadline = Instant::now() + Duration::from_millis(MUTATION_SETTLE_TIMEOUT_MS);
        let mut scan_after = started_after;
        let mut accepted_after = None;
        loop {
            let events = self
                .history
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .events
                .iter()
                .filter(|envelope| envelope.sequence > scan_after)
                .cloned()
                .collect::<Vec<_>>();
            for envelope in events {
                scan_after = scan_after.max(envelope.sequence);
                let NodeEvent::Control {
                    address: event_address,
                    event,
                } = envelope.event
                else {
                    continue;
                };
                if event_address != *address {
                    continue;
                }
                if event.command_id == Some(command_id) {
                    match &event.event {
                        ControlEventKind::CommandRejected { .. } => {
                            return Err(failure(
                                NodeFailureCode::InvalidRequest,
                                "history request was rejected",
                            ));
                        }
                        ControlEventKind::HistoryRequested {
                            operation: requested,
                            ..
                        } if requested == &operation => {
                            accepted_after = Some(envelope.sequence);
                            continue;
                        }
                        _ => {}
                    }
                }
                if accepted_after.is_some_and(|sequence| envelope.sequence > sequence) {
                    match (&operation, &event.event) {
                        (
                            HistoryOperation::Discover { .. },
                            ControlEventKind::HistoryDiscovered { .. },
                        )
                        | (
                            HistoryOperation::Load { .. },
                            ControlEventKind::HistoryLoaded { .. },
                        ) => return self.internal_session_snapshot(address),
                        (_, ControlEventKind::HistoryFailed { .. }) => {
                            return Err(failure(
                                NodeFailureCode::BackendOperationFailed,
                                "history operation failed",
                            ));
                        }
                        _ => {}
                    }
                }
            }
            if Instant::now() >= deadline {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    if accepted_after.is_some() {
                        "history operation did not settle before the bounded deadline"
                    } else {
                        "history operation was not accepted before the bounded deadline"
                    },
                ));
            }
            sleep(Duration::from_millis(2)).await;
        }
    }

    async fn discover_history(
        &self,
        address: &SessionAddress,
        limit: u16,
    ) -> Result<Vec<HistoryCandidateSummary>, NodeFailure> {
        let query = HistoryQuery {
            working_directory: Some(self.workspace_root(&address.workspace_id)?),
            limit,
        };
        query
            .validate()
            .map_err(|_| failure(NodeFailureCode::InvalidRequest, "invalid history query"))?;
        let snapshot = self
            .dispatch_history_bounded(
                address,
                ControlCommand::DiscoverHistory {
                    instance_id: address.session.instance_id,
                    query: query.clone(),
                },
                HistoryOperation::Discover { query },
            )
            .await?;
        if snapshot.history.pending.is_some() || snapshot.history.loaded.is_some() {
            return Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "history discovery settled into an invalid state",
            ));
        }
        Ok(snapshot.history.candidates)
    }

    async fn load_history(
        &self,
        address: &SessionAddress,
        candidate_id: String,
    ) -> Result<HistorySessionRecord, NodeFailure> {
        validate_candidate_id(&candidate_id)
            .map_err(|_| failure(NodeFailureCode::InvalidRequest, "invalid history candidate"))?;
        let snapshot = self
            .dispatch_history_bounded(
                address,
                ControlCommand::LoadHistory {
                    instance_id: address.session.instance_id,
                    candidate_id: candidate_id.clone(),
                },
                HistoryOperation::Load {
                    candidate_id: candidate_id.clone(),
                },
            )
            .await?;
        if snapshot.history.pending.is_some()
            || snapshot.history.loaded_candidate_id.as_ref() != Some(&candidate_id)
        {
            return Err(failure(
                NodeFailureCode::BackendOperationFailed,
                "history load settled into an invalid state",
            ));
        }
        snapshot.history.loaded.ok_or_else(|| {
            failure(
                NodeFailureCode::BackendOperationFailed,
                "history load produced no bounded session",
            )
        })
    }

    /// `allow_clean_detachment`: `false` for the on-demand
    /// `NodeRequest::ExportContextPackForSessionRecord` API path (the
    /// managed record must stay untouched, still live, for the whole call);
    /// `true` only for the reactive auto-export-at-exit path (`§2.1`), which
    /// reacts to the very clean-exit event that detaches the record out from
    /// under this same call — see `session_record_export_target_matches`.
    async fn export_context_pack_for_session_record(
        &self,
        record_id: &SessionRecordId,
        session: &SessionAddress,
        allow_clean_detachment: bool,
    ) -> Result<ResolvedContextPackReceipt, NodeFailure> {
        // C2 replaces a relayed failure's prose with a canned per-code
        // string (`C2NodeFailure`'s own `From`), so this path's dozen
        // distinct refusals are indistinguishable to anyone downstream --
        // and a refusal here expires a continuation, which keeps no field
        // for why. The prose stays on the node, where it was written.
        let outcome = self
            .export_context_pack_for_session_record_inner(record_id, session, allow_clean_detachment)
            .await;
        if let Err(failure) = &outcome {
            tracing::warn!(
                record = %record_id,
                code = ?failure.code,
                reason = %failure.message,
                "session-record context-pack export refused",
            );
        }
        outcome
    }

    async fn export_context_pack_for_session_record_inner(
        &self,
        record_id: &SessionRecordId,
        session: &SessionAddress,
        allow_clean_detachment: bool,
    ) -> Result<ResolvedContextPackReceipt, NodeFailure> {
        // Several steps here refuse with the same BackendOperationFailed
        // code and no prose of their own, so which step failed is
        // otherwise unrecoverable -- and a refusal here expires a
        // continuation.
        let step = |name: &'static str| move |failure: NodeFailure| {
            tracing::warn!(step = name, code = ?failure.code, "context-pack export step refused");
            failure
        };
        let record = self.record(record_id).map_err(step("record-lookup"))?;
        // `provider_session` is `Some` only for a provider whose resolved
        // runtime policy admits live identity verification (raw PTY plus a
        // semantic PTY adapter -- `provider_runtime::policy_from_capability_flags`).
        // The PTY-sidecar-observation shape (no fleet provider today, but
        // capability-keyed rather than vendor-locked) hardcodes
        // `provider_session_identity: false` in `provider_runtime::evaluate`,
        // so its records go straight to `Live` with `provider_session: None`
        // and stay that way for the record's entire life -- that is this
        // shape's permanent resting state, not a race with observation, and
        // `discover_history`/`load_history` below do not need an identity to
        // do their job for it. `IdentityPending` is the actual race (an
        // identity-admitted provider whose observation has not landed yet):
        // it keeps refusing here rather than falling back, because that
        // provider's own history the fallback would otherwise trust is not
        // guaranteed to be exact without the identity it is still waiting on.
        let identity = match record.provider_session.clone() {
            Some(identity) => {
                if identity.key != ProviderSessionKey::SessionId {
                    return Err(step("provider-identity-key")(failure(
                        NodeFailureCode::BackendOperationFailed,
                        "managed session provider identity cannot bind history exactly",
                    )));
                }
                Some(identity)
            }
            None if record.state == ManagedSessionState::IdentityPending => {
                return Err(step("provider-session-identity")(failure(
                    NodeFailureCode::BackendOperationFailed,
                    "managed session has not yet observed its provider session identity",
                )));
            }
            None => None,
        };
        self.revalidate_session_record_context_export(
            &record,
            identity.as_ref(),
            session,
            allow_clean_detachment,
        ).map_err(step("revalidate-before-discovery"))?;
        let candidates = self
            .discover_history(session, HISTORY_DISCOVERY_LIMIT_MAX)
            .await
            .map_err(step("discover-history"))?;
        // With no verified identity to filter by, the discovered set must
        // still resolve to exactly one candidate: the same ambiguity refusal
        // an identity filter would otherwise produce is the only safety
        // property left available for this shape.
        let candidate_id = select_history_candidate(
            &candidates,
            identity.as_ref().map(|identity| identity.id.as_str()),
        ).map_err(step("unique-candidate"))?;
        let loaded = self.load_history(session, candidate_id.clone()).await
            .map_err(step("load-history"))?;
        if let Some(identity) = identity.as_ref() {
            if loaded.session_id != identity.id {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "loaded history identity does not match the managed session record",
                ));
            }
        }
        self.revalidate_session_record_context_export(
            &record,
            identity.as_ref(),
            session,
            allow_clean_detachment,
        )?;
        self.revalidate_loaded_history(session, &candidate_id, &loaded)
            .map_err(step("revalidate-loaded-history"))?;
        let pack = self.materialize_context_pack(session).await
            .map_err(step("materialize-context-pack"))?;
        self.commit_context_pack_for_session_record(
            &record,
            identity.as_ref(),
            session,
            &candidate_id,
            &loaded,
            pack,
            allow_clean_detachment,
        )
    }

    async fn export_context_pack(
        &self,
        address: &SessionAddress,
    ) -> Result<ResolvedContextPackReceipt, NodeFailure> {
        let pack = self.materialize_context_pack(address).await?;
        self.commit_context_pack(pack)
    }

    async fn materialize_context_pack(
        &self,
        address: &SessionAddress,
    ) -> Result<NodeContextPack, NodeFailure> {
        let snapshot = self.internal_session_snapshot(address)?;
        if !context_pack_source_status_is_usable(&snapshot.status) {
            return Err(failure(
                NodeFailureCode::InvalidRequest,
                "context export requires a running or successfully exited source session",
            ));
        }
        if snapshot.history.pending.is_some()
            || snapshot.history.loaded_candidate_id.is_none()
        {
            return Err(failure(
                NodeFailureCode::InvalidRequest,
                "context export requires settled loaded history",
            ));
        }
        let loaded = snapshot.history.loaded.clone().ok_or_else(|| {
            failure(
                NodeFailureCode::InvalidRequest,
                "context export requires settled loaded history",
            )
        })?;
        let source_provider = snapshot.agent_id.clone();
        let loaded_candidate_id = snapshot.history.loaded_candidate_id.clone();
        let repository = self
            .context_pack_repository(&address.workspace_id)
            .await?;
        let current = self.internal_session_snapshot(address)?;
        if !context_pack_source_status_is_usable(&current.status)
            || current.agent_id != source_provider
            || current.history.pending.is_some()
            || current.history.loaded_candidate_id != loaded_candidate_id
            || current.history.loaded.as_ref() != Some(&loaded)
        {
            return Err(failure(
                NodeFailureCode::ContextPackMaterializationFailed,
                "context source changed during bounded repository capture",
            ));
        }
        NodeContextPack::export_with_repository(
            ContextPackLineageReceipt {
                source_node_id: self.node_id.clone(),
                source_session: address.clone(),
                source_provider,
            },
            &loaded,
            Some(repository),
        )
        .map_err(|_| {
            failure(
                NodeFailureCode::ContextPackMaterializationFailed,
                "bounded context pack export failed",
            )
        })
    }

    /// Write-through to the durable [`ContextPackStore`], if one is
    /// configured (`state_path` is `Some`). A node with no durable state
    /// path — fixtures, tests, ephemeral runs — has no `ContextPackStore`
    /// open at all and this is a no-op, matching `persist_state`'s own
    /// "durability optional, degrade gracefully when unconfigured" idiom.
    fn commit_context_pack_durably(&self, pack: &NodeContextPack) -> Result<(), NodeFailure> {
        let mut store = self
            .context_pack_store
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let Some(store) = store.as_mut() else {
            return Ok(());
        };
        store.commit(pack).map_err(|_| {
            failure(
                NodeFailureCode::ContextPackMaterializationFailed,
                "durable context pack commit failed",
            )
        })
    }

    fn commit_context_pack(
        &self,
        pack: NodeContextPack,
    ) -> Result<ResolvedContextPackReceipt, NodeFailure> {
        self.commit_context_pack_durably(&pack)?;
        self.context_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(pack)
            .map_err(|_| {
                failure(
                    NodeFailureCode::ContextPackMaterializationFailed,
                    "context pack catalog is full",
                )
            })
    }

    fn commit_context_pack_for_session_record(
        &self,
        expected: &ManagedSessionRecord,
        identity: Option<&ProviderSessionIdentity>,
        session: &SessionAddress,
        candidate_id: &str,
        loaded: &HistorySessionRecord,
        pack: NodeContextPack,
        allow_clean_detachment: bool,
    ) -> Result<ResolvedContextPackReceipt, NodeFailure> {
        let current_root = self.workspace_root(&expected.workspace_id)?;
        let _transaction = self
            .state_transaction
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let records = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let current = records.records.get(&expected.record_id).ok_or_else(|| {
            failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session record disappeared during context export",
            )
        })?;
        if !session_record_export_target_matches(expected, current, session, allow_clean_detachment) {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session record changed during context export",
            ));
        }
        let bindings = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let binding = bindings.get(&session.session.instance_id).ok_or_else(|| {
            failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session runtime binding disappeared during context export",
            )
        })?;
        let runtime = self
            .handle
            .snapshot()
            .sessions
            .iter()
            .find(|snapshot| {
                snapshot.instance_id == session.session.instance_id
                    && snapshot.generation == session.session.generation
            })
            .cloned()
            .ok_or_else(|| {
                failure(
                    NodeFailureCode::SessionRecordConflict,
                    "managed session runtime disappeared during context export",
                )
            })?;
        let receipt = pack.receipt();
        if !session_record_context_export_binding_is_exact(
            expected,
            current,
            identity,
            session,
            binding,
            &runtime.agent_id,
            &current_root,
            allow_clean_detachment,
        ) || !session_record_context_export_source_is_usable(
            current,
            &runtime.status,
            allow_clean_detachment,
        ) || runtime.history.pending.is_some()
            || runtime.history.loaded_candidate_id.as_deref() != Some(candidate_id)
            || runtime.history.loaded.as_ref() != Some(loaded)
            || receipt.lineage.source_node_id != self.node_id
            || receipt.lineage.source_session != *session
            || receipt.lineage.source_provider != current.provider
            || receipt.source_message_count != loaded.message_count
        {
            return Err(failure(
                NodeFailureCode::SessionRecordConflict,
                "managed session source changed before context catalog commit",
            ));
        }
        self.commit_context_pack_durably(&pack)?;
        self.context_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(pack)
            .map_err(|_| {
                failure(
                    NodeFailureCode::ContextPackMaterializationFailed,
                    "context pack catalog is full",
                )
            })
    }

    async fn context_pack_repository(
        &self,
        workspace_id: &WorkspaceId,
    ) -> Result<ContextPackRepository, NodeFailure> {
        let first = self
            .context_pack_repository_observation(workspace_id)
            .await?;
        let second = self
            .context_pack_repository_observation(workspace_id)
            .await?;
        stable_context_pack_repository(first, second)
    }

    async fn context_pack_repository_observation(
        &self,
        workspace_id: &WorkspaceId,
    ) -> Result<ContextPackRepositoryObservation, NodeFailure> {
        let git = self.inspect_workspace(workspace_id.clone()).await?.git;
        let head = if git.is_repository {
            let root = self.workspace_root(workspace_id)?;
            match resolve_base_commit_with_timeout(
                &root,
                "HEAD",
                GIT_COMMAND_TIMEOUT_MS,
            )
            .await
            {
                Ok(commit) => ContextPackRepositoryHead::Commit(commit),
                Err(error) if error.kind == GitWorktreeErrorKind::Conflict => {
                    ContextPackRepositoryHead::Unborn
                }
                Err(_) => {
                    return Err(failure(
                        NodeFailureCode::ContextPackMaterializationFailed,
                        "context pack HEAD observation failed",
                    ));
                }
            }
        } else {
            ContextPackRepositoryHead::NotRepository
        };
        let mut files = Vec::with_capacity(CONTEXT_PACK_SELECTED_FILES.len());
        for selected_path in CONTEXT_PACK_SELECTED_FILES {
            let path = RepositoryPath::utf8(selected_path.to_owned()).map_err(|_| {
                failure(
                    NodeFailureCode::InvalidRepositoryPath,
                    "context pack selected file path is invalid",
                )
            })?;
            match self.read_workspace_file(workspace_id.clone(), path).await {
                Ok(WorkspaceFileRead {
                    content: WorkspaceFileContent::Utf8 { text, byte_len },
                    ..
                }) => files.push(ContextPackRepositoryFileSource::utf8(
                    selected_path,
                    text,
                    byte_len,
                )),
                Ok(WorkspaceFileRead {
                    content: WorkspaceFileContent::NonUtf8 { byte_len },
                    ..
                }) => files.push(ContextPackRepositoryFileSource::skipped(
                    selected_path,
                    ContextPackSelectedFileSkipReason::NonUtf8,
                    Some(byte_len),
                )),
                Ok(WorkspaceFileRead {
                    content: WorkspaceFileContent::TooLarge { .. },
                    ..
                }) => files.push(ContextPackRepositoryFileSource::skipped(
                    selected_path,
                    ContextPackSelectedFileSkipReason::TooLarge,
                    None,
                )),
                Err(error) => {
                    let reason = if matches!(
                        error.code,
                        NodeFailureCode::InvalidRepositoryPath
                            | NodeFailureCode::RepositoryFileNotRegular
                            | NodeFailureCode::RepositoryPathUnsafe
                    ) {
                        ContextPackSelectedFileSkipReason::Unsafe
                    } else {
                        ContextPackSelectedFileSkipReason::Unavailable
                    };
                    files.push(ContextPackRepositoryFileSource::skipped(
                        selected_path,
                        reason,
                        None,
                    ));
                }
            }
        }
        Ok(ContextPackRepositoryObservation { head, git, files })
    }

    fn forget_context_pack(&self, context_id: &SpawnContextId) -> Result<(), NodeFailure> {
        let referenced_by_binding = self
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .any(|binding| {
                binding.context.as_ref().map(|receipt| &receipt.id) == Some(context_id)
            });
        let referenced_by_record = self
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .values()
            .any(|record| record.context_id.as_ref() == Some(context_id));
        let referenced_by_materialization = self
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .values()
            .any(|ownership| {
                ownership.context().map(|receipt| &receipt.id) == Some(context_id)
            });
        if referenced_by_binding
            || referenced_by_record
            || referenced_by_materialization
        {
            return Err(failure(
                NodeFailureCode::ContextPackBusy,
                "context pack is still referenced",
            ));
        }
        let mut catalog = self.context_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        if catalog.get(context_id).is_none() {
            return Err(failure(
                NodeFailureCode::UnknownContextPack,
                "context pack is unavailable",
            ));
        }
        self.spawn_idempotency
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .entries
            .retain(|_, entry| !entry.value.references_context(context_id));
        let removed = catalog.remove(context_id);
        debug_assert!(removed.is_some(), "validated context pack remains present");
        Ok(())
    }

    async fn dispatch_input_bounded(
        &self,
        address: &SessionAddress,
        action: InputAction,
    ) -> Result<(), NodeFailure> {
        let started_after = self.current_sequence();
        self.pty_input_marks
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(address.session.instance_id, (Instant::now(), false));
        self.pty_input_wake.notify_one();
        let command_id = self
            .dispatch_bounded(
                ControlCommand::SendInput {
                    instance_id: address.session.instance_id,
                    action,
                },
                Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
            )
            .await?;
        // A semantic prompt may spend the provider's full readiness budget before
        // the runtime emits InputCompleted. Keep the node request deadline bounded,
        // but strictly beyond every readiness policy in this node's catalog.
        let deadline = Instant::now() + Duration::from_millis(self.input_settle_timeout_ms);
        let mut scan_after = started_after;
        let mut accepted_after = None;
        loop {
            let events = self
                .history
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .events
                .iter()
                .filter(|envelope| envelope.sequence > scan_after)
                .cloned()
                .collect::<Vec<_>>();
            for envelope in events {
                scan_after = scan_after.max(envelope.sequence);
                let NodeEvent::Control {
                    address: event_address,
                    event,
                } = envelope.event
                else {
                    continue;
                };
                if event_address != *address {
                    continue;
                }
                if event.command_id == Some(command_id) {
                    match &event.event {
                        ControlEventKind::CommandRejected { message } => {
                            return Err(failure(NodeFailureCode::InvalidRequest, message));
                        }
                        ControlEventKind::InputRequested { .. } => {
                            accepted_after = Some(envelope.sequence);
                            continue;
                        }
                        _ => {}
                    }
                }
                if accepted_after.is_some_and(|sequence| envelope.sequence > sequence) {
                    match &event.event {
                        ControlEventKind::InputCompleted { .. } => return Ok(()),
                        ControlEventKind::InputFailed { message, .. } => {
                            return Err(failure(
                                NodeFailureCode::BackendOperationFailed,
                                message,
                            ));
                        }
                        _ => {}
                    }
                }
            }
            if Instant::now() >= deadline {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    if accepted_after.is_some() {
                        "input was accepted but did not settle before the bounded deadline"
                    } else {
                        "input was not accepted before the bounded deadline"
                    },
                ));
            }
            sleep(Duration::from_millis(2)).await;
        }
    }

    async fn dispatch_resize_bounded(
        &self,
        address: &SessionAddress,
        size: gate4agent_types::TerminalSize,
    ) -> Result<(), NodeFailure> {
        let started_after = self.current_sequence();
        let command_id = self
            .dispatch_bounded(
                ControlCommand::Resize {
                    instance_id: address.session.instance_id,
                    size,
                },
                Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
            )
            .await?;
        let deadline = Instant::now() + Duration::from_millis(MUTATION_SETTLE_TIMEOUT_MS);
        let mut scan_after = started_after;
        let mut accepted_after = None;
        loop {
            let events = self
                .history
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .events
                .iter()
                .filter(|envelope| envelope.sequence > scan_after)
                .cloned()
                .collect::<Vec<_>>();
            for envelope in events {
                scan_after = scan_after.max(envelope.sequence);
                let NodeEvent::Control {
                    address: event_address,
                    event,
                } = envelope.event
                else {
                    continue;
                };
                if event_address != *address {
                    continue;
                }
                if event.command_id == Some(command_id) {
                    match &event.event {
                        ControlEventKind::CommandRejected { message } => {
                            return Err(failure(NodeFailureCode::InvalidRequest, message));
                        }
                        ControlEventKind::ResizeRequested {
                            size: requested_size,
                            ..
                        } if *requested_size == size => {
                            accepted_after = Some(envelope.sequence);
                            continue;
                        }
                        _ => {}
                    }
                }
                if accepted_after.is_some_and(|sequence| envelope.sequence > sequence) {
                    match &event.event {
                        ControlEventKind::Resized { size: settled_size }
                            if *settled_size == size =>
                        {
                            return Ok(());
                        }
                        ControlEventKind::ResizeFailed { message } => {
                            return Err(failure(
                                NodeFailureCode::BackendOperationFailed,
                                message,
                            ));
                        }
                        _ => {}
                    }
                }
            }
            if Instant::now() >= deadline {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    if accepted_after.is_some() {
                        "resize was accepted but did not settle before the bounded deadline"
                    } else {
                        "resize was not accepted before the bounded deadline"
                    },
                ));
            }
            sleep(Duration::from_millis(2)).await;
        }
    }

    async fn spawn_session(
        &self,
        workspace_id: WorkspaceId,
        provider: AgentId,
        mode: SessionMode,
        terminal_size: gate4agent_types::TerminalSize,
        initial_prompt: Option<String>,
    ) -> Result<SessionAddress, NodeFailure> {
        if self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .lease_for_workspace(&workspace_id)
            .is_some()
        {
            return Err(failure(
                NodeFailureCode::ManagedWorktreeOwnershipConflict,
                "managed worktree targets may only be spawned through their lease request",
            ));
        }
        self
            .spawn_session_with_deadline(
                workspace_id,
                provider.clone(),
                mode,
                terminal_size,
                initial_prompt,
                None,
                None,
                None,
                None,
                None,
                SpawnRecordPolicy::ProviderIdentityOnly,
                None,
                &[],
                None,
                // `NodeRequest::Spawn` (this method's only caller) carries no
                // approval-level selection of its own -- see
                // `HarnessOperatorRequestV1::SpawnSession`'s own field for
                // the one operator-wire path that can choose something other
                // than the axis default. Auto-permit may lower it where the agent
                // cannot offer its full-auto mode (claude ACP under root).
                crate::auto_permit::spawn_approval_level(provider.as_str(), mode).unwrap_or_default(),
                None,
                None,
            )
            .await
            .map(|(session, _runtime_policy)| session)
    }

    async fn spawn_session_with_deadline(
        &self,
        workspace_id: WorkspaceId,
        provider: AgentId,
        mode: SessionMode,
        terminal_size: gate4agent_types::TerminalSize,
        initial_prompt: Option<String>,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
        bundle: Option<ResolvedBundleReceipt>,
        context: Option<ResolvedContextPackReceipt>,
        managed_authority: Option<ManagedWorktreeLeaseId>,
        admitted_runtime_policy: Option<ProviderRuntimePolicy>,
        record_policy: SpawnRecordPolicy,
        deadline: Option<Instant>,
        required_capabilities: &[ProviderRuntimeCapability],
        harness_mcp: Option<&PreparedHarnessMcpSpawn>,
        approval_level: ApprovalLevel,
        network_allowlist: Option<crate::protocol::SpawnNetworkAllowlistId>,
        // Opaque dig2browser station profile id (ids only). Feature
        // `dig2-station-probe`: after probe at resolve, spawn takes an
        // exclusive node-local lease; cleared on session end. Never
        // ImportSession / cookies on C2. Feature off: ignored (stub echo
        // already happened on the receipt path).
        browser_profile_id: Option<crate::protocol::SpawnBrowserProfileId>,
    ) -> Result<(SessionAddress, ProviderRuntimePolicy), NodeFailure> {
        let reserved_lease = self.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .lease_for_workspace(&workspace_id);
        match (reserved_lease.as_ref(), managed_authority.as_ref()) {
            (Some(expected), Some(provided)) if expected == provided => {}
            (None, None) => {}
            _ => {
                return Err(failure(
                    NodeFailureCode::ManagedWorktreeOwnershipConflict,
                    "spawn lacks exact managed worktree lease authority",
                ));
            }
        }
        // Refuse concurrent distinct environment profiles (incl. ProviderHome
        // bindings) on the same workspace cwd. Parallel path: managed worktree
        // spawn so each profile gets its own workspace_id.
        self.ensure_workspace_environment_profile_compatible(
            &workspace_id,
            environment_profile.as_ref(),
        )?;
        let runtime_requirement = match (mode, initial_prompt.is_some()) {
            (SessionMode::Pty, false) => ProviderRuntimeRequirement::RawPty,
            (SessionMode::Pty, true) => ProviderRuntimeRequirement::SemanticPrompt,
            (SessionMode::Inline, _) => ProviderRuntimeRequirement::Inline,
            (SessionMode::Acp, _) => ProviderRuntimeRequirement::Acp,
        };
        // This session's own transport -- computed once, here, from `mode`,
        // and reused both to admit spawn (below) and, further down, to
        // compute the final `runtime_policy` this session actually operates
        // under (`provider_runtime::policy_for_transport`). Registration
        // reuses this exact value rather than recomputing it a second time.
        let transport = match mode {
            SessionMode::Pty => TransportKind::Pty,
            SessionMode::Inline => TransportKind::Pipe,
            SessionMode::Acp => TransportKind::Acp,
        };
        let pipe_transport = self.provider_supports_pipe_transport(&provider);
        let acp_transport = self.provider_supports_acp_transport(&provider);
        let runtime_policy = if let Some(runtime_policy) = admitted_runtime_policy {
            require_policy(runtime_policy, pipe_transport, acp_transport, runtime_requirement).map_err(|_| failure(
                NodeFailureCode::UnsupportedSpawnCapability,
                "pre-admitted provider runtime no longer satisfies spawn requirements",
            ))?;
            runtime_policy
        } else if let Some(deadline) = deadline {
            let remaining = spawn_deadline_remaining(deadline)?;
            timeout(
                remaining,
                self.admit_provider_runtime(&provider, runtime_requirement),
            )
            .await
            .map_err(|_| {
                failure(
                    NodeFailureCode::SpawnDeadlineExceeded,
                    "provider admission exceeded the spawn deadline",
                )
            })??
        } else {
            self.admit_provider_runtime(&provider, runtime_requirement).await?
        };
        let runtime_policy = self.effective_spawn_runtime_policy(runtime_policy);
        // The single point where this session's `runtime_policy` becomes
        // transport-correct: `admit_provider_runtime` (and the pre-admitted
        // branch above) only ever compute a PTY-terminal-verification-shaped
        // value, sound outright only for `TransportKind::Pty` (Pipe still
        // relies on that same value downstream -- see `policy_for_transport`'s
        // own doc for why). `policy_for_transport` is the explicit,
        // exhaustive match Item 1 asks for -- this is the ONE place its
        // output becomes the session's `runtime_policy`, so every later
        // reader (`ControlCommand::Start`, `session_bindings`, and every
        // engine gate that reads `state.runtime_policy`) sees the same,
        // correctly-computed value.
        let runtime_policy =
            crate::provider_runtime::policy_for_transport(transport, runtime_policy);
        if required_capabilities
            .iter()
            .any(|capability| !runtime_policy.admits(*capability))
        {
            return Err(failure(
                NodeFailureCode::UnsupportedSpawnCapability,
                "provider runtime does not admit a required spawn capability",
            ));
        }
        if let Some(deadline) = deadline {
            spawn_deadline_remaining(deadline)?;
        }
        self.ensure_binding_capacity()?;
        let mut working_directory = self.workspace_root(&workspace_id)?;
        let instance_id = AgentInstanceId(self.next_instance_id.fetch_add(1, Ordering::AcqRel));
        let session = SessionKey {
            instance_id,
            generation: SessionGeneration(1),
        };
        let address = SessionAddress {
            workspace_id: workspace_id.clone(),
            session,
        };
        // This is the request-accepted checkpoint: admission (managed
        // worktree authority, runtime capability, dispatch deadline) already
        // passed and a concrete session identity is minted. It is a distinct
        // state from the process actually running (`ControlEventKind::Running`,
        // logged in `publish_control`) or the terminal outcome (`Exited`/
        // `Failed`, logged there too) -- this line exists so that gap is no
        // longer silent.
        tracing::info!(
            node_id = %self.node_id,
            workspace_id = %workspace_id,
            provider = %provider,
            environment_profile = ?environment_profile.as_ref().map(|receipt| &receipt.profile_id),
            session = ?address.session,
            "session spawn request accepted",
        );
        let mut prepared_spawn = SpawnPreparer::prepare(
            self,
            SpawnPrepareRequest {
                instance_id,
                address: &address,
                provider: &provider,
                mode,
                environment_profile: environment_profile.as_ref(),
                bundle: bundle.as_ref(),
                context: context.as_ref(),
                managed_authority: managed_authority.as_ref(),
                harness_mcp,
                approval_level,
                network_allowlist: network_allowlist.as_ref(),
                browser_profile_id,
            },
        )?;
        let materialization_id = prepared_spawn.materialization_id.take();
        let dispatch_timeout = spawn_dispatch_timeout(deadline)?;
        let record_id = self.bind_spawn_session_with_materialization(
            &address,
            provider.clone(),
            mode,
            runtime_policy,
            record_policy,
            environment_profile,
            bundle,
            context,
            materialization_id,
        )?;
        prepared_spawn.retain_session_guards();
        // `transport` was already computed above, alongside this session's
        // `runtime_policy`; reused here for `Register` rather than derived a
        // second time.
        let session_provider = provider.clone();
        let agent_id = provider;
        let register_command_id = match self.dispatch_bounded(
            ControlCommand::Register {
                instance_id,
                agent_id,
                transport,
            },
            dispatch_timeout,
        )
        .await {
            Ok(command_id) => command_id,
            Err(error) => {
                if let Some(binding) = self.remove_binding(&address) {
                    SessionLifecycleHook::cleanup_session_materialization(self, &address, &binding)?;
                }
                if let Some(record_id) = record_id.as_ref() {
                    self.discard_record(record_id)?;
                }
                return Err(spawn_dispatch_error(error, deadline));
            }
        };
        let start_timeout = match spawn_dispatch_timeout(deadline) {
            Ok(timeout) => timeout,
            Err(error) => {
                let recovery = self
                    .rollback_spawn(
                        &address,
                        Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
                    )
                    .await;
                return match recovery {
                    Ok(()) => {
                        if let Some(record_id) = record_id.as_ref() {
                            self.discard_record(record_id)?;
                        }
                        Err(error)
                    }
                    Err(recovery_error) => {
                        if let Some(record_id) = record_id.as_ref() {
                            self.mark_record_error(
                                record_id,
                                "spawn deadline elapsed and registration recovery failed",
                            )?;
                        }
                        Err(recovery_error)
                    }
                };
            }
        };
        if let Err(start_error) = self.verify_harness_mcp_before_start(harness_mcp) {
            if let Err(recovery_error) = self
                .rollback_spawn(&address, Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS))
                .await
            {
                return Err(recovery_error);
            }
            if let Some(record_id) = record_id.as_ref() {
                self.discard_record(record_id)?;
            }
            return Err(start_error);
        }
        // A session with its own m4a account runs in its own folder inside the workspace.
        if let Some(dir) = self.session_workdir(std::path::Path::new(&working_directory), instance_id, &session_provider) {
            working_directory = dir.to_string_lossy().into_owned();
        }
        let start_result = self
            .dispatch_bounded(
                ControlCommand::Start {
                    instance_id,
                    runtime_policy,
                    request: StartRequest {
                        working_directory,
                        terminal_size,
                        initial_prompt,
                        session_options: SPAWN_SESSION_OPTIONS.try_with(|o| o.clone()).ok().flatten(),
                        approval_level,
                    },
                },
                start_timeout,
            )
            .await;
        let start_command_id = match start_result {
            Ok(command_id) => command_id,
            Err(start_error) => {
                let start_error = spawn_dispatch_error(start_error, deadline);
                let recovery = self
                    .rollback_spawn(
                        &address,
                        Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
                    )
                    .await;
                return match recovery {
                    Ok(()) => {
                        if let Some(record_id) = record_id.as_ref() {
                            self.discard_record(record_id)?;
                        }
                        Err(start_error)
                    }
                    Err(recovery_error) => {
                        let diagnostic = format!(
                            "start failed and registration recovery failed: {}",
                            recovery_error.message,
                        );
                        if let Some(record_id) = record_id.as_ref() {
                            self.mark_record_error(record_id, &diagnostic)?;
                        }
                        Err(failure(recovery_error.code, &diagnostic))
                    }
                };
            }
        };

        let commit_deadline = deadline.unwrap_or_else(|| Instant::now() + dispatch_timeout);
        loop {
            // `Register`/`Start` only fail synchronously for a port-level
            // ingress problem (see `dispatch_bounded`); the kernel refusing
            // either command's content -- an unsupported transport, an
            // unknown agent -- lands one drive-loop tick later, and no
            // session ever appears in `self.handle.snapshot()` for it to
            // notice below. Check for that named reason before falling
            // through to the blind presence poll, so a rejected spawn
            // reports why instead of just timing out.
            if let Some(reason) = self.take_rejected_command_reason(register_command_id)
                .or_else(|| self.take_rejected_command_reason(start_command_id))
            {
                self.rollback_spawn(
                    &address,
                    Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
                ).await.map_err(|error| {
                        failure(
                            error.code,
                            &format!(
                                "spawn was rejected ({}) and registration recovery failed: {}",
                                reason.message, error.message
                            ),
                        )
                    })?;
                if let Some(record_id) = record_id.as_ref() {
                    self.discard_record(record_id)?;
                }
                let code = if reason.unsupported_transport {
                    NodeFailureCode::UnsupportedTransport
                } else {
                    NodeFailureCode::BackendOperationFailed
                };
                return Err(failure(code, &reason.message));
            }
            if let Some(current) = self
                .handle
                .snapshot()
                .sessions
                .iter()
                .find(|current| current.instance_id == instance_id)
            {
                if current.generation != session.generation {
                    let divergence = failure(
                        NodeFailureCode::StaleGeneration,
                        "spawn generation diverged",
                    );
                    return match self
                        .rollback_spawn(
                            &address,
                            Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
                        )
                        .await
                    {
                        Ok(()) => {
                            if let Some(record_id) = record_id.as_ref() {
                                self.discard_record(record_id)?;
                            }
                            Err(divergence)
                        }
                        Err(recovery_error) => {
                            if let Some(record_id) = record_id.as_ref() {
                                self.mark_record_error(
                                    record_id,
                                    "spawn generation diverged and recovery failed",
                                )?;
                            }
                            Err(recovery_error)
                        }
                    };
                }
                if !matches!(current.status, gate4agent_types::SessionStatus::Registered) {
                    prepared_spawn.retain_launch_guards();
                    return Ok((address, runtime_policy));
                }
            }
            if Instant::now() >= commit_deadline {
                self.rollback_spawn(
                    &address,
                    Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS),
                ).await.map_err(|error| {
                        failure(
                            error.code,
                            &format!(
                                "start did not commit and registration recovery failed: {}",
                                error.message
                            ),
                        )
                    })?;
                if let Some(record_id) = record_id.as_ref() {
                    self.discard_record(record_id)?;
                }
                return Err(failure(
                    if deadline.is_some() {
                        NodeFailureCode::SpawnDeadlineExceeded
                    } else {
                        NodeFailureCode::BackendBusy
                    },
                    "start did not commit before the bounded deadline; registration was removed",
                ));
            }
            sleep(Duration::from_millis(2)).await;
        }
    }

    fn effective_spawn_runtime_policy(
        &self,
        runtime_policy: ProviderRuntimePolicy,
    ) -> ProviderRuntimePolicy {
        #[cfg(feature = "fixture")]
        let runtime_policy = if self.fixture_semantic_hook_policy {
            ProviderRuntimePolicy::new(true, true, true, true, false, true)
                .expect("monitoring Hook fixture policy is internally valid")
        } else {
            runtime_policy
        };
        runtime_policy
    }

    fn verify_harness_mcp_before_start(
        &self,
        prepared: Option<&PreparedHarnessMcpSpawn>,
    ) -> Result<(), NodeFailure> {
        prepared
            .map(PreparedHarnessMcpSpawn::verify_helper_program)
            .transpose()
            .map(|_| ())
            .map_err(harness_mcp_failure)
    }

    async fn rollback_spawn(
        &self,
        address: &SessionAddress,
        commit_timeout: Duration,
    ) -> Result<(), NodeFailure> {
        self.dispatch_bounded(
            ControlCommand::Remove {
                instance_id: address.session.instance_id,
            },
            commit_timeout,
        )
        .await?;
        self.wait_until_removed(address, commit_timeout).await?;
        if let Some(binding) = self.remove_binding(address) {
            SessionLifecycleHook::cleanup_session_materialization(self, address, &binding)?;
        }
        Ok(())
    }

    async fn remove_session(&self, address: &SessionAddress) -> Result<(), NodeFailure> {
        let commit_timeout = Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS);
        self.dispatch_bounded(
            ControlCommand::Remove {
                instance_id: address.session.instance_id,
            },
            commit_timeout,
        )
            .await?;
        self.wait_until_removed(address, commit_timeout).await?;
        let removed = self.remove_binding(address);
        if let Some(binding) = removed.as_ref() {
            SessionLifecycleHook::cleanup_session_materialization(self, address, binding)?;
        }
        if let Some(lease_id) = removed.and_then(|binding| binding.managed_worktree_lease_id) {
            let snapshot = self.managed_worktrees.lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .release_session(
                    &lease_id,
                    self.incarnation_id,
                    address.session.instance_id,
                    address.session.generation,
                    unix_time_ms(),
                );
            if self.persist_state().is_err() {
                self.set_persistence_error(Some(DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned()));
            }
            if let Some(snapshot) = snapshot {
                self.publish(NodeEvent::ManagedWorktreeUpserted { lease: snapshot });
            }
            let _ = self.cleanup_managed_worktree(&lease_id, false).await;
        }
        Ok(())
    }

    /// Polls until `address`'s session leaves the engine's own session map,
    /// or the bounded deadline expires.
    ///
    /// A `Remove` sent while the session is not yet in a terminal status
    /// (e.g. still `Stopping`, mid-effect right after a `Stop`) is rejected
    /// once by the engine (`SessionStatus::allows_remove`) and
    /// then discarded -- nothing re-issues it on its own, so the removal
    /// that would satisfy this wait never arrives and the caller was
    /// guaranteed to time out even though the session settles microseconds
    /// later. So this re-dispatches on every poll tick: a session that
    /// settles mid-wait -- the common case right after a `Stop` -- still
    /// gets removed inside the same bounded deadline.
    ///
    /// It re-dispatches only once the status will ACCEPT the command. A
    /// rejected re-dispatch is not the harmless no-op this loop first
    /// assumed: every rejection publishes a `ControlEventKind::Command
    /// Rejected` to every subscriber and writes a WARN line. Ungated, one
    /// ordinary teardown produced 241 of them in 1.6 seconds -- the whole
    /// `Stopping` window at one known-doomed dispatch per 2ms tick, fanned
    /// out to the harness and every attached client. Gated, the same
    /// teardown sends exactly one `Remove`, at the first tick the engine
    /// can act on it.
    ///
    /// The status is read from the snapshot this loop already takes, so
    /// the gate costs nothing extra. It races -- the status can move
    /// between the read and the dispatch -- and that is fine: a rare lost
    /// race is one rejection, and the next tick retries.
    ///
    /// Re-dispatch is separately rate-limited to
    /// [`REMOVE_REDISPATCH_INTERVAL_MS`], because the status gate alone
    /// leaves a second burst behind it. Once the session settles, every
    /// 2ms tick sent another `Remove` while the accepted one was still in
    /// flight, and each of those landed on an instance the engine had
    /// already dropped -- `agent instance … is not registered`, observed
    /// live as a tail of rejections immediately after the `session
    /// removed` line. The presence poll stays at 2ms so the wait still
    /// exits promptly; only the sending slows down.
    ///
    /// Rate-limited rather than once-only on purpose: the status gate
    /// covers the status precondition, but `Gate4AgentEngine::remove` has
    /// others (a pending operation, an in-flight capability probe or
    /// history request) that clear on their own. A single shot would turn
    /// those into a guaranteed `BackendBusy` timeout; at 10Hz they still
    /// get their retries, just twenty of them across the deadline instead
    /// of a thousand.
    async fn wait_until_removed(
        &self,
        address: &SessionAddress,
        commit_timeout: Duration,
    ) -> Result<(), NodeFailure> {
        let deadline = Instant::now() + commit_timeout;
        let mut next_dispatch = Instant::now();
        loop {
            let snapshot = self.handle.snapshot();
            let status = snapshot
                .sessions
                .iter()
                .find(|session| session.instance_id == address.session.instance_id)
                .map(|session| session.status.clone());
            let Some(status) = status else {
                return Ok(());
            };
            let now = Instant::now();
            if now >= deadline {
                return Err(failure(
                    NodeFailureCode::BackendBusy,
                    "remove did not commit before the bounded deadline; session binding was retained",
                ));
            }
            if status.allows_remove() && now >= next_dispatch {
                let _ = self.dispatch(ControlCommand::Remove {
                    instance_id: address.session.instance_id,
                });
                next_dispatch = now + Duration::from_millis(REMOVE_REDISPATCH_INTERVAL_MS);
            }
            sleep(Duration::from_millis(2)).await;
        }
    }

    fn resync(&self, after_sequence: u64) -> NodeResponse {
        let history = self.history.lock().unwrap_or_else(|poisoned| poisoned.into_inner());
        let event_sequence = history.last_sequence;
        let oldest_available_sequence = history.replay_floor_sequence;
        let events = history
            .events
            .iter()
            .filter(|event| event.sequence > after_sequence)
            .cloned()
            .collect();
        drop(history);
        NodeResponse::Resync {
            event_sequence,
            oldest_available_sequence,
            snapshot: self.snapshot(),
            events,
        }
    }
}

/// Coarse label for one `AgentStreamChunkKindV1`, used only by
/// `NodeShared::publish_agent_stream_chunk`'s own debug log -- mirrors
/// `hatchery-harness-service`'s `agent_stream_event_kind_label` (same
/// "name what crossed this boundary" reasoning, one layer upstream of it).
fn agent_stream_chunk_kind_label(kind: &AgentStreamChunkKindV1) -> &'static str {
    match kind {
        AgentStreamChunkKindV1::Text { .. } => "text",
        AgentStreamChunkKindV1::Thinking { .. } => "thinking",
        AgentStreamChunkKindV1::InteractionPrompt { .. } => "interaction-prompt",
        AgentStreamChunkKindV1::ModeCatalog { .. } => "mode-catalog",
        AgentStreamChunkKindV1::ConfigOptions { .. } => "config-options",
        AgentStreamChunkKindV1::ModelCatalog { .. } => "model-catalog",
        AgentStreamChunkKindV1::Blocked { .. } => "blocked",
    }
}

/// Serves this wire on the local endpoint, and -- when `call_home` names a
/// relay -- over an outbound connection to it as well.
///
/// The two live in one future rather than a fourth arm of `run`'s own
/// `select!` because they are one concern: this is where the node's wire
/// is served, and the direction a given connection was opened in does not
/// change what happens on it. It also means the existing graceful drain
/// below covers both without being duplicated.
///
/// Either side finishing ends the pair, which is correct: the listener
/// only returns on shutdown or a bind failure, and `call_home_loop` only
/// returns on shutdown -- a failed relay connection is retried inside it,
/// never propagated out.
async fn accept_connections(
    endpoint: &str,
    call_home: Option<std::net::SocketAddr>,
    identity: Option<Arc<hatchery_enroll::NodeIdentity>>,
    shared: Arc<NodeShared>,
) -> Result<(), NodeServerError> {
    let mut connections = JoinSet::new();
    let result = match call_home {
        None => accept_connections_inner(endpoint, shared, &mut connections).await,
        Some(relay) => {
            let listener =
                accept_connections_inner(endpoint, Arc::clone(&shared), &mut connections);
            let dialler = call_home_loop(relay, identity, Arc::clone(&shared));
            tokio::pin!(listener);
            tokio::pin!(dialler);
            tokio::select! {
                result = &mut listener => result,
                result = &mut dialler => result,
            }
        }
    };
    let graceful_deadline = Instant::now() + Duration::from_millis(CONNECTION_SHUTDOWN_GRACE_MS);
    while !connections.is_empty() {
        let remaining = graceful_deadline.saturating_duration_since(Instant::now());
        if remaining.is_zero()
            || timeout(remaining, connections.join_next()).await.is_err()
        {
            break;
        }
    }
    connections.abort_all();
    while connections.join_next().await.is_some() {}
    result
}

/// Backoff ladder for a relay that will not answer, capped rather than
/// unbounded: a node whose relay is down is not broken and should keep
/// trying forever, but it should not spend a core doing it.
const CALL_HOME_BACKOFFS_MS: [u64; 5] = [500, 1_000, 2_000, 4_000, 8_000];

/// Dials the relay, serves this wire over the connection, and does it
/// again when the connection ends.
///
/// The node is the SERVER on the socket it just opened. That inversion is
/// the whole point: `serve_connection` is the same function the local
/// listener feeds, and it neither knows nor cares which end placed the
/// call. The one thing this direction adds is the preface -- the relay
/// accepted a socket and cannot know whose it is, so the node says its
/// name before the handshake it would otherwise begin with.
///
/// Never returns an error. A relay that is down, refusing, or speaking a
/// different protocol is a condition to retry, not a reason to take the
/// node's local endpoint down with it; the only way out is shutdown.
async fn call_home_loop(
    relay: std::net::SocketAddr,
    identity: Option<Arc<hatchery_enroll::NodeIdentity>>,
    shared: Arc<NodeShared>,
) -> Result<(), NodeServerError> {
    let mut failures = 0_usize;
    loop {
        if shared.shutdown.load(Ordering::Acquire) {
            return Ok(());
        }
        let permit = tokio::select! {
            permit = Arc::clone(&shared.preauth_slots).acquire_owned() => {
                permit.map_err(|_| NodeServerError::PreauthClosed)?
            }
            _ = shared.shutdown_notify.notified() => return Ok(()),
        };
        match dial_relay_and_serve(relay, identity.as_deref(), Arc::clone(&shared), permit).await {
            Ok(()) => {
                // A clean end is the relay hanging up, which it does on
                // its own restart. Reconnect immediately rather than
                // serving the backoff a peer that is plainly there.
                failures = 0;
                tracing::info!(node_id = %shared.node_id, %relay, "call-home connection closed; redialling");
            }
            Err(error) => {
                failures = failures.saturating_add(1);
                tracing::warn!(
                    node_id = %shared.node_id,
                    %relay,
                    cause = %error,
                    attempt = failures,
                    "call-home connection failed",
                );
                let backoff = call_home_backoff(failures);
                tokio::select! {
                    _ = sleep(backoff) => {}
                    _ = shared.shutdown_notify.notified() => return Ok(()),
                }
            }
        }
    }
}

/// Idle time before the first keepalive probe on a call-home socket.
const CALL_HOME_KEEPALIVE_IDLE: Duration = Duration::from_secs(15);
/// Interval between keepalive probes once the link has gone quiet.
const CALL_HOME_KEEPALIVE_INTERVAL: Duration = Duration::from_secs(5);

fn call_home_keepalive() -> socket2::TcpKeepalive {
    let keepalive = socket2::TcpKeepalive::new()
        .with_time(CALL_HOME_KEEPALIVE_IDLE)
        .with_interval(CALL_HOME_KEEPALIVE_INTERVAL);
    #[cfg(not(windows))]
    let keepalive = keepalive.with_retries(3);
    keepalive
}

fn enable_call_home_keepalive(stream: &tokio::net::TcpStream) -> std::io::Result<()> {
    socket2::SockRef::from(stream).set_tcp_keepalive(&call_home_keepalive())
}

/// Same keepalive profile for any node->relay socket (restream uplink).
pub(crate) fn enable_tcp_keepalive(stream: &std::net::TcpStream) -> std::io::Result<()> {
    socket2::SockRef::from(stream).set_tcp_keepalive(&call_home_keepalive())
}

/// Backoff for the `attempt`-th consecutive failure (1-based), capped.
fn call_home_backoff(attempt: usize) -> Duration {
    Duration::from_millis(
        CALL_HOME_BACKOFFS_MS[attempt.saturating_sub(1).min(CALL_HOME_BACKOFFS_MS.len() - 1)],
    )
}


/// Dial the call-home relay. Tunnel addresses go through the in-process
/// WireGuard dialer when the userspace session is up.
async fn dial_call_home(relay: std::net::SocketAddr) -> Result<tokio::net::TcpStream, NodeServerError> {
    #[cfg(feature = "wireguard")]
    {
        let std_stream = tokio::task::spawn_blocking(move || {
            gate4agent_node_core::kit_wireguard::tcp_connect(relay)
        })
        .await
        .map_err(|e| NodeServerError::CallHomeTransport(std::io::Error::other(e.to_string())))?
        .map_err(NodeServerError::CallHomeTransport)?;
        std_stream
            .set_nonblocking(true)
            .map_err(NodeServerError::CallHomeTransport)?;
        return tokio::net::TcpStream::from_std(std_stream).map_err(NodeServerError::CallHomeTransport);
    }
    #[cfg(not(feature = "wireguard"))]
    {
        tokio::net::TcpStream::connect(relay)
            .await
            .map_err(NodeServerError::CallHomeTransport)
    }
}

/// One call-home attempt: connect, name this node, then serve.
async fn dial_relay_and_serve(
    relay: std::net::SocketAddr,
    identity: Option<&hatchery_enroll::NodeIdentity>,
    shared: Arc<NodeShared>,
    preauth_permit: OwnedSemaphorePermit,
) -> Result<(), NodeServerError> {
    let mut stream = dial_call_home(relay).await?;
    // Nagle off for the same reason the rest of this wire wants it off:
    // the traffic is small request/response frames, and coalescing them
    // adds latency to every one.
    let _ = stream.set_nodelay(true);
    // A relay that vanishes without a FIN/RST reaching us (tunnel drop,
    // relay-side socket kill whose RST was lost) would otherwise leave this
    // socket ESTABLISHED forever: the node mostly reads, so nothing ever
    // fails and the reconnect loop never runs. Kernel keepalive turns that
    // half-open link into a read error within a bounded time.
    if let Err(error) = enable_call_home_keepalive(&stream) {
        tracing::warn!(cause = %error, "could not enable TCP keepalive on the call-home socket");
    }
    gate4agent_node_wire::write_call_home_announce(&mut stream, &shared.node_id)
        .await
        .map_err(|error| NodeServerError::Handshake(error.to_string()))?;
    tracing::info!(node_id = %shared.node_id, %relay, "announced this node to the relay");
    let mut session_token = None;
    if let Some(identity) = identity {
        // An enrolled relay answers the announce with a signed-call-home challenge; a
        // token-mode relay sends its wire hello instead. Peek to tell them apart
        // without consuming either.
        let mut magic = [0_u8; 4];
        let peeked = timeout(Duration::from_secs(10), stream.peek(&mut magic))
            .await
            .map_err(|_| NodeServerError::Handshake("relay sent nothing after the announce".to_owned()))?
            .map_err(NodeServerError::CallHomeTransport)?;
        if peeked == 4 && &magic == hatchery_enroll::CHALLENGE_MAGIC {
            let mut frame = [0_u8; hatchery_enroll::CHALLENGE_LEN];
            timeout(Duration::from_secs(5), tokio::io::AsyncReadExt::read_exact(&mut stream, &mut frame))
                .await
                .map_err(|_| NodeServerError::Handshake("relay challenge timed out".to_owned()))?
                .map_err(NodeServerError::CallHomeTransport)?;
            let (answer, token) = identity
                .answer_challenge(shared.node_id.as_str(), &frame)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))?;
            tokio::io::AsyncWriteExt::write_all(&mut stream, &answer).await.map_err(NodeServerError::CallHomeTransport)?;
            tracing::info!(node_id = %shared.node_id, "answered the relay's signed call-home challenge");
            session_token = Some(token);
        }
    }
    serve_connection(stream, shared, session_token, preauth_permit).await
}

async fn accept_connections_inner(
    endpoint: &str,
    shared: Arc<NodeShared>,
    connections: &mut JoinSet<Result<(), NodeServerError>>,
) -> Result<(), NodeServerError> {
    let mut listener = OwnerOnlyLocalListener::bind(endpoint).await?;
    loop {
        while connections.try_join_next().is_some() {}
        if shared.shutdown.load(Ordering::Acquire) {
            return Ok(());
        }
        let preauth_permit = tokio::select! {
            permit = Arc::clone(&shared.preauth_slots).acquire_owned() => {
                permit.map_err(|_| NodeServerError::PreauthClosed)?
            }
            _ = shared.shutdown_notify.notified() => return Ok(()),
        };
        let server = tokio::select! {
            result = listener.accept() => result?,
            _ = shared.shutdown_notify.notified() => return Ok(()),
        };
        let connection_shared = Arc::clone(&shared);
        connections.spawn(async move {
            serve_connection(server, connection_shared, None, preauth_permit).await
        });
        if shared.shutdown.load(Ordering::Acquire) {
            return Ok(());
        }
    }
}

/// Serves one connection, whichever end opened it.
///
/// Generic over the stream rather than typed to `LocalServerStream`
/// because a call-home connection arrives on a `TcpStream` the node itself
/// dialled. Nothing in the body ever depended on the concrete type -- it
/// reads and writes framed JSON and then `tokio::io::split`s -- so this is
/// the whole of what welding "who dials" to "who serves" was costing.
async fn serve_connection<S>(
    mut pipe: S,
    shared: Arc<NodeShared>,
    session_token: Option<String>,
    preauth_permit: OwnedSemaphorePermit,
) -> Result<(), NodeServerError>
where
    S: tokio::io::AsyncRead + tokio::io::AsyncWrite + Unpin + Send + 'static,
{
    // A signed call-home connection authenticates with its own per-connection token.
    let auth_token: &[u8] = session_token.as_deref().map_or(shared.access_token.as_bytes(), str::as_bytes);
    let hello_frame = timeout(
        Duration::from_millis(AUTH_FRAME_TIMEOUT_MS),
        read_json_frame_limited_body_timeout(
            &mut pipe,
            MAX_NODE_HELLO_FRAME_BYTES,
            Duration::from_millis(FRAME_BODY_TIMEOUT_MS),
        ),
    )
    .await
    .map_err(|_| NodeServerError::AuthenticationTimedOut)??;
    let ClientFrame::Hello(hello) = hello_frame else {
        return Err(NodeServerError::Handshake("first frame must be hello".to_owned()));
    };
    if hello.build_stamp != BUILD_STAMP {
        return Err(NodeServerError::Handshake(format!(
            "build stamp mismatch: local={BUILD_STAMP} remote={}",
            hello.build_stamp,
        )));
    }
    let compatibility = match hello.compatibility.as_ref() {
        Some(offer) => {
            let mut selected = node_compatibility_support(&shared)?
                .negotiate(offer)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))?;
            project_negotiated_provider_ids(&mut selected);
            Some(selected)
        }
        None => None,
    };
    let server_nonce = random_nonce().map_err(NodeServerError::Authentication)?;
    let server_proof = match (hello.compatibility.as_ref(), compatibility.as_ref()) {
        (Some(offer), Some(selected)) => negotiated_auth_proof(
            auth_token,
            AuthDirection::Server,
            hello.role,
            &hello.client_nonce,
            &server_nonce,
            offer,
            selected,
        ),
        (None, None) => auth_proof(
            auth_token,
            AuthDirection::Server,
            hello.role,
            &hello.client_nonce,
            &server_nonce,
        ),
        _ => Err("node compatibility authentication state is inconsistent".to_owned()),
    }
    .map_err(NodeServerError::Authentication)?;
    write_json_frame_limited(
        &mut pipe,
        &ServerFrame::Challenge(ServerChallenge {
            build_stamp: BUILD_STAMP.to_owned(),
            server_nonce,
            server_proof,
            compatibility: compatibility.clone(),
        }),
        MAX_NODE_HELLO_FRAME_BYTES,
    )
    .await?;
    let authentication = timeout(
        Duration::from_millis(AUTH_FRAME_TIMEOUT_MS),
        read_json_frame_limited_body_timeout(
            &mut pipe,
            MAX_NODE_HELLO_FRAME_BYTES,
            Duration::from_millis(FRAME_BODY_TIMEOUT_MS),
        ),
    )
    .await
    .map_err(|_| NodeServerError::AuthenticationTimedOut)??;
    let ClientFrame::Authenticate(authentication) = authentication else {
        return Err(NodeServerError::Handshake("second frame must authenticate the challenge".to_owned()));
    };
    let expected_client_proof = match (hello.compatibility.as_ref(), compatibility.as_ref()) {
        (Some(offer), Some(selected)) => negotiated_auth_proof(
            auth_token,
            AuthDirection::Client,
            hello.role,
            &hello.client_nonce,
            &server_nonce,
            offer,
            selected,
        ),
        (None, None) => auth_proof(
            auth_token,
            AuthDirection::Client,
            hello.role,
            &hello.client_nonce,
            &server_nonce,
        ),
        _ => Err("node compatibility authentication state is inconsistent".to_owned()),
    }
    .map_err(NodeServerError::Authentication)?;
    if !proofs_match(&authentication.client_proof, &expected_client_proof) {
        return Err(NodeServerError::Handshake("access denied".to_owned()));
    }
    let selected_capabilities = compatibility
        .as_ref()
        .map(|selected| selected.capabilities.clone())
        .unwrap_or_default();
    let include_provider_runtime_status = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_PROVIDER_RUNTIME_STATUS_CAPABILITY
    });
    let include_open_provider_ids = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_PROVIDER_ID_OPEN_CAPABILITY
    });
    let include_terminal_frame_events = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_TERMINAL_FRAME_EVENTS_CAPABILITY
    });
    let include_agent_stream_events = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_AGENT_STREAM_EVENTS_CAPABILITY
    });
    let include_spawn_profiles = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_SPAWN_SPEC_DEFAULTS_OVERRIDES_CAPABILITY
    });
    let include_managed_worktrees = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_MANAGED_WORKTREE_LIFECYCLE_CAPABILITY
    }) && selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_WORKTREE_SELECTION_CAPABILITY
    });
    let include_child_environment_profiles = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_CHILD_ENVIRONMENT_PROFILE_CAPABILITY
    });
    let include_session_bundles = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_SESSION_BUNDLE_MATERIALIZATION_CAPABILITY
    });
    let include_history_context_packs = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_HISTORY_CONTEXT_PACK_CAPABILITY
    });
    let include_agent_progress = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_AGENT_PROGRESS_SNAPSHOT_CAPABILITY
    });
    let include_session_task_correlation = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_SESSION_TASK_CORRELATION_CAPABILITY
    });
    let include_harness_mcp_proxy = selected_capabilities.iter().any(|capability| {
        capability.as_str() == NODE_HARNESS_MCP_READ_PROXY_CAPABILITY
    });
    let authenticated_permit = Arc::clone(&shared.authenticated_slots)
        .try_acquire_owned()
        .map_err(|_| NodeServerError::AuthenticatedConnectionLimit)?;
    let connection_id = shared.next_connection_id.fetch_add(1, Ordering::AcqRel);
    let _release_guard = ControllerReleaseGuard {
        shared: Arc::clone(&shared),
        connection_id,
    };
    drop(preauth_permit);
    let _authenticated_permit = authenticated_permit;
    let mut event_rx = shared.event_tx.subscribe();
    let mut terminal_event_rx = terminal_event_subscription(
        &shared,
        include_terminal_frame_events,
    );
    let mut agent_stream_event_rx = agent_stream_event_subscription(
        &shared,
        include_agent_stream_events,
    );
    let mut harness_mcp_proxy_event_rx = harness_mcp_proxy_event_subscription(
        &shared,
        include_harness_mcp_proxy,
    );
    write_json_frame(
        &mut pipe,
        &ServerFrame::Hello(NodeHello {
            build_stamp: BUILD_STAMP.to_owned(),
            incarnation_id: shared.incarnation_id,
            connection_id,
            role: hello.role,
            event_sequence: shared.current_sequence(),
            controller: shared.controller_state(),
            snapshot: snapshot_for_wire(
                &shared,
                include_provider_runtime_status,
                include_open_provider_ids,
                include_spawn_profiles,
                include_managed_worktrees,
                include_child_environment_profiles,
                include_session_bundles,
                include_history_context_packs,
                include_agent_progress,
                include_session_task_correlation,
            ),
            compatibility,
        }),
    )
    .await?;
    let (mut reader, mut writer) = tokio::io::split(pipe);
    let (frame_tx, mut frame_rx) = mpsc::channel(16);
    let reader_task = tokio::spawn(async move {
        loop {
            let frame = read_json_frame_limited_body_timeout::<_, ClientFrame>(
                &mut reader,
                MAX_NODE_CLIENT_FRAME_BYTES,
                Duration::from_millis(FRAME_BODY_TIMEOUT_MS),
            )
            .await;
            let terminal = frame.is_err();
            if frame_tx.send(frame).await.is_err() || terminal {
                break;
            }
        }
    });
    let _reader_abort = AbortTaskOnDrop(reader_task.abort_handle());
    let mut pending_events = Vec::new();
    let mut resync_required = false;
    let mut discard_events_through = 0_u64;
    loop {
        // One tick of the serve loop, whether or not it had anything to do.
        // Against `connection_events_sent` this separates "busy" from
        // "spinning": a loop turning over thousands of times a second while
        // sending nothing is not serving, it is burning a core.
        shared.connection_loop_iterations.fetch_add(1, Ordering::Relaxed);
        let durable_drain_budget = NODE_CONNECTION_EVENT_BURST_MAX
            .saturating_sub(pending_events.len().min(NODE_CONNECTION_EVENT_BURST_MAX));
        for _ in 0..durable_drain_budget {
            match event_rx.try_recv() {
                Ok(event) => queue_connection_event(
                    &mut pending_events,
                    event,
                    discard_events_through,
                ),
                Err(broadcast::error::TryRecvError::Empty) => break,
                Err(broadcast::error::TryRecvError::Lagged(_)) => {
                    resync_required = true;
                    break;
                }
                Err(broadcast::error::TryRecvError::Closed) => return Ok(()),
            }
        }
        if let Some(receiver) = terminal_event_rx.as_mut() {
            match receiver.try_recv() {
                Ok(events) => queue_connection_event_batch(
                    &mut pending_events,
                    &events,
                    discard_events_through,
                ),
                Err(broadcast::error::TryRecvError::Empty) => {}
                Err(broadcast::error::TryRecvError::Lagged(_)) => {
                    resync_required = true;
                }
                Err(broadcast::error::TryRecvError::Closed) => return Ok(()),
            }
        }
        if let Some(receiver) = agent_stream_event_rx.as_mut() {
            // Loops up to the same remaining-room budget the durable
            // `event_rx` drain above uses, rather than one `try_recv` per
            // tick: each successful receive here is itself only ONE
            // `NodeEventEnvelope` batch (`publish_agent_stream_chunk` always
            // sends `vec![envelope]`, never more), so a single-shot drain
            // caps this connection's agent-stream throughput at one chunk
            // per outer-loop tick regardless of how many are already queued
            // -- exactly the kind of self-inflicted stall this crate's own
            // durable-event budget exists to avoid.
            let agent_stream_drain_budget = NODE_CONNECTION_EVENT_BURST_MAX
                .saturating_sub(pending_events.len().min(NODE_CONNECTION_EVENT_BURST_MAX));
            for _ in 0..agent_stream_drain_budget {
                match receiver.try_recv() {
                    Ok(events) => queue_connection_event_batch(
                        &mut pending_events,
                        &events,
                        discard_events_through,
                    ),
                    Err(broadcast::error::TryRecvError::Empty) => break,
                    Err(broadcast::error::TryRecvError::Lagged(dropped)) => {
                        tracing::warn!(
                            connection_id,
                            dropped,
                            "agent stream event subscription lagged; forcing a resync",
                        );
                        resync_required = true;
                        break;
                    }
                    Err(broadcast::error::TryRecvError::Closed) => return Ok(()),
                }
            }
        }
        if let Some(receiver) = harness_mcp_proxy_event_rx.as_mut() {
            // Mirrors the agent-stream drain immediately above: each
            // successful receive is one single-envelope batch
            // (`publish_transient` always sends `vec![envelope]`), so this
            // loops up to the same remaining-room budget rather than
            // stopping after one `try_recv`.
            let harness_mcp_proxy_drain_budget = NODE_CONNECTION_EVENT_BURST_MAX
                .saturating_sub(pending_events.len().min(NODE_CONNECTION_EVENT_BURST_MAX));
            for _ in 0..harness_mcp_proxy_drain_budget {
                match receiver.try_recv() {
                    Ok(events) => queue_connection_event_batch(
                        &mut pending_events,
                        &events,
                        discard_events_through,
                    ),
                    Err(broadcast::error::TryRecvError::Empty) => break,
                    Err(broadcast::error::TryRecvError::Lagged(dropped)) => {
                        tracing::warn!(
                            connection_id,
                            dropped,
                            "harness MCP proxy event subscription lagged; forcing a resync",
                        );
                        resync_required = true;
                        break;
                    }
                    Err(broadcast::error::TryRecvError::Closed) => return Ok(()),
                }
            }
        }
        if resync_required {
            let event = resync_required_event(&shared);
            apply_connection_resync_watermark(
                &mut pending_events,
                &mut discard_events_through,
                event.sequence,
            );
            write_json_frame(&mut writer, &ServerFrame::Event(event)).await?;
            resync_required = false;
            continue;
        }
        if !pending_events.is_empty() {
            pending_events.sort_unstable_by_key(|event| event.sequence);
            let burst_len = connection_event_burst_len(pending_events.len());
            shared
                .connection_events_sent
                .fetch_add(burst_len as u64, Ordering::Relaxed);
            for event in pending_events.drain(..burst_len) {
                let event = if include_managed_worktrees {
                    Some(event)
                } else {
                    project_event_without_managed_worktrees(event)
                };
                let event = event.and_then(|event| if include_open_provider_ids {
                    Some(event)
                } else {
                    project_event_legacy_provider_ids(&shared, event)
                });
                let event = event.map(|event| if include_child_environment_profiles {
                    event
                } else {
                    project_event_without_child_environment_profile(event)
                });
                let event = event.map(|event| if include_session_bundles {
                    event
                } else {
                    project_event_without_session_bundle(event)
                });
                let event = event.map(|event| {
                    project_event_history_for_wire(event, include_history_context_packs)
                });
                let event = event.map(|event| if include_history_context_packs {
                    event
                } else {
                    project_event_without_context_pack(event)
                });
                let event = event.map(|event| if include_session_task_correlation {
                    event
                } else {
                    project_event_without_session_task_binding(event)
                });
                let exact_harness_controller = hello.role == ClientRole::Operator
                    && shared.controller_state().is_some_and(|controller| {
                        controller.connection_id == connection_id
                    });
                let event = event.and_then(|event| {
                    if include_harness_mcp_proxy && exact_harness_controller {
                        Some(event)
                    } else {
                        project_event_without_harness_mcp_proxy(event)
                    }
                });
                if let Some(event) = event {
                    write_json_frame(&mut writer, &ServerFrame::Event(event)).await?;
                }
            }
        }
        tokio::select! {
            biased;
            frame = frame_rx.recv() => {
                let frame = match frame {
                    Some(frame) => frame,
                    None => break,
                };
                let frame = match frame {
                    Ok(frame) => frame,
                    Err(FrameError::Io(error)) if matches!(error.kind(), io::ErrorKind::BrokenPipe | io::ErrorKind::UnexpectedEof) => break,
                    Err(error) => return Err(error.into()),
                };
                let ClientFrame::Request(request) = frame else {
                    return Err(NodeServerError::Handshake("hello may only be sent once".to_owned()));
                };
                #[cfg(feature = "fixture")]
                let probe_spawn_managed_worktree_v2 = matches!(
                    &request.request,
                    NodeRequest::SpawnManagedWorktreeV2 { .. }
                );
                let requires_open_provider_ids =
                    request_requires_open_provider_ids(&shared, &request.request);
                let requires_child_environment_profile =
                    request_requires_child_environment_profile(&shared, &request.request);
                let requires_session_bundle =
                    request_requires_session_bundle(&shared, &request.request);
                let requires_history_context_pack =
                    request_requires_history_context_pack(&shared, &request.request);
                let mut reply = if requires_open_provider_ids && !include_open_provider_ids {
                    ResponseEnvelope {
                        request_id: request.request_id,
                        result: Err(failure(
                            NodeFailureCode::UnsupportedCapability,
                            "open provider IDs were not negotiated",
                        )),
                    }
                } else if requires_child_environment_profile
                    && !include_child_environment_profiles
                {
                    ResponseEnvelope {
                        request_id: request.request_id,
                        result: Err(failure(
                            NodeFailureCode::UnsupportedCapability,
                            "child environment profiles were not negotiated",
                        )),
                    }
                } else if requires_session_bundle && !include_session_bundles {
                    ResponseEnvelope {
                        request_id: request.request_id,
                        result: Err(failure(
                            NodeFailureCode::UnsupportedCapability,
                            "session bundles were not negotiated",
                        )),
                    }
                } else if requires_history_context_pack && !include_history_context_packs {
                    ResponseEnvelope {
                        request_id: request.request_id,
                        result: Err(failure(
                            NodeFailureCode::UnsupportedCapability,
                            "history context packs were not negotiated",
                        )),
                    }
                } else if request_uses_unnegotiated_capability(
                    &request.request,
                    &selected_capabilities,
                )
                {
                    ResponseEnvelope {
                        request_id: request.request_id,
                        result: Err(failure(
                            NodeFailureCode::UnsupportedCapability,
                            "request capability was not negotiated",
                        )),
                    }
                } else {
                    process_request(&shared, connection_id, hello.role, request).await
                };
                #[cfg(feature = "fixture")]
                if probe_spawn_managed_worktree_v2 {
                    shared
                        .fixture_spawn_managed_worktree_v2_failure_probe
                        .record(reply.result.as_ref().err().map(|failure| failure.code));
                }
                if !include_provider_runtime_status {
                    clear_response_provider_runtime_status(&mut reply);
                }
                if !include_managed_worktrees {
                    project_response_without_managed_worktrees(&mut reply);
                }
                if !include_open_provider_ids {
                    project_response_legacy_provider_ids(&shared, &mut reply);
                }
                if !include_child_environment_profiles {
                    project_response_without_child_environment_profile(&mut reply);
                }
                if !include_session_bundles {
                    project_response_without_session_bundle(&mut reply);
                }
                project_response_history_for_wire(
                    &mut reply,
                    include_history_context_packs,
                );
                if !include_history_context_packs {
                    project_response_without_context_pack(&mut reply);
                }
                if !include_agent_progress {
                    project_response_without_agent_progress(&mut reply);
                }
                if !include_session_task_correlation {
                    project_response_without_session_task_binding(&mut reply);
                }
                write_json_frame(&mut writer, &ServerFrame::Reply(reply)).await?;
            }
            _ = tokio::task::yield_now(), if !pending_events.is_empty() => {}
            event = event_rx.recv() => {
                match event {
                    Ok(event) => queue_connection_event(
                        &mut pending_events,
                        event,
                        discard_events_through,
                    ),
                    Err(broadcast::error::RecvError::Lagged(_)) => resync_required = true,
                    Err(broadcast::error::RecvError::Closed) => break,
                }
            }
            events = receive_terminal_event_batch(&mut terminal_event_rx) => {
                match events {
                    Ok(events) => queue_connection_event_batch(
                        &mut pending_events,
                        &events,
                        discard_events_through,
                    ),
                    Err(broadcast::error::RecvError::Lagged(_)) => resync_required = true,
                    Err(broadcast::error::RecvError::Closed) => break,
                }
            }
            events = receive_terminal_event_batch(&mut agent_stream_event_rx) => {
                match events {
                    Ok(events) => queue_connection_event_batch(
                        &mut pending_events,
                        &events,
                        discard_events_through,
                    ),
                    Err(broadcast::error::RecvError::Lagged(_)) => resync_required = true,
                    Err(broadcast::error::RecvError::Closed) => break,
                }
            }
            events = receive_terminal_event_batch(&mut harness_mcp_proxy_event_rx) => {
                match events {
                    Ok(events) => queue_connection_event_batch(
                        &mut pending_events,
                        &events,
                        discard_events_through,
                    ),
                    Err(broadcast::error::RecvError::Lagged(_)) => resync_required = true,
                    Err(broadcast::error::RecvError::Closed) => break,
                }
            }
            _ = shared.shutdown_notify.notified() => break,
        }
    }
    Ok(())
}

async fn receive_terminal_event_batch(
    receiver: &mut Option<broadcast::Receiver<Arc<Vec<NodeEventEnvelope>>>>,
) -> Result<Arc<Vec<NodeEventEnvelope>>, broadcast::error::RecvError> {
    match receiver {
        Some(receiver) => receiver.recv().await,
        None => std::future::pending().await,
    }
}

fn terminal_event_subscription(
    shared: &NodeShared,
    enabled: bool,
) -> Option<broadcast::Receiver<Arc<Vec<NodeEventEnvelope>>>> {
    enabled.then(|| shared.terminal_event_tx.subscribe())
}

/// Mirrors `terminal_event_subscription` exactly, over the agent stream's
/// own channel -- see `NodeShared::agent_stream_event_tx`'s own doc for why
/// this needs a dedicated channel rather than a flag on the terminal one.
fn agent_stream_event_subscription(
    shared: &NodeShared,
    enabled: bool,
) -> Option<broadcast::Receiver<Arc<Vec<NodeEventEnvelope>>>> {
    enabled.then(|| shared.agent_stream_event_tx.subscribe())
}

/// Mirrors `agent_stream_event_subscription` exactly, over the harness MCP
/// proxy's own channel -- see `NodeShared::harness_mcp_proxy_event_tx`'s
/// own doc for why this needs a dedicated channel rather than a ride on
/// the durable `event_tx`.
fn harness_mcp_proxy_event_subscription(
    shared: &NodeShared,
    enabled: bool,
) -> Option<broadcast::Receiver<Arc<Vec<NodeEventEnvelope>>>> {
    enabled.then(|| shared.harness_mcp_proxy_event_tx.subscribe())
}

fn queue_connection_event(
    pending: &mut Vec<NodeEventEnvelope>,
    event: NodeEventEnvelope,
    discard_through: u64,
) {
    if event.sequence <= discard_through
        && !event.event.requires_harness_mcp_proxy_capability()
    {
        return;
    }
    if let NodeEvent::TerminalFrame { address, .. } = &event.event {
        if let Some(index) = pending.iter().position(|current| {
            matches!(
                &current.event,
                NodeEvent::TerminalFrame {
                    address: current_address,
                    ..
                } if current_address == address
            )
        }) {
            pending.remove(index);
        }
    }
    pending.push(event);
}

fn project_event_without_harness_mcp_proxy(
    envelope: NodeEventEnvelope,
) -> Option<NodeEventEnvelope> {
    (!envelope.event.requires_harness_mcp_proxy_capability()).then_some(envelope)
}

fn queue_connection_event_batch(
    pending: &mut Vec<NodeEventEnvelope>,
    events: &[NodeEventEnvelope],
    discard_through: u64,
) {
    for event in events {
        queue_connection_event(pending, event.clone(), discard_through);
    }
}

fn apply_connection_resync_watermark(
    pending: &mut Vec<NodeEventEnvelope>,
    discard_through: &mut u64,
    marker_sequence: u64,
) {
    *discard_through = (*discard_through).max(marker_sequence);
    pending.retain(|event| event.sequence > *discard_through);
}

fn connection_event_burst_len(pending_len: usize) -> usize {
    pending_len.min(NODE_CONNECTION_EVENT_BURST_MAX)
}

fn resync_required_event(shared: &NodeShared) -> NodeEventEnvelope {
    let history = shared
        .history
        .lock()
        .unwrap_or_else(|poisoned| poisoned.into_inner());
    let sequence = history.last_sequence;
    let oldest_available_sequence = history.replay_floor_sequence;
    NodeEventEnvelope {
        sequence,
        event: NodeEvent::ResyncRequired {
            oldest_available_sequence,
        },
    }
}

fn node_compatibility_support(
    shared: &NodeShared,
) -> Result<NodeCompatibilitySupport, NodeServerError> {
    let mut support = node_compatibility_support_for_manifest(
        &shared.provider_contracts,
        &shared.provider_adapter_contracts,
    )?;
    if shared
        .delivery_store
        .lock()
        .unwrap_or_else(|poisoned| poisoned.into_inner())
        .is_some()
    {
        support.capabilities.push(
            CapabilityId::new(NODE_DELIVERY_BUNDLE_V2_STAGE_COMMIT_CAPABILITY)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))?,
        );
    }
    if shared.harness_mcp_registry.is_some() {
        support.capabilities.push(
            CapabilityId::new(NODE_HARNESS_MCP_READ_PROXY_CAPABILITY)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))?,
        );
    }
    Ok(support)
}

fn node_compatibility_support_for_manifest(
    provider_contracts: &[ProviderContractSupport],
    provider_adapter_contracts: &[ProviderAdapterContractSupport],
) -> Result<NodeCompatibilitySupport, NodeServerError> {
    Ok(NodeCompatibilitySupport {
        build_stamp: BUILD_STAMP.to_owned(),
        capabilities: baseline_capabilities()?,
        host: platform::host_descriptor().map_err(NodeServerError::Handshake)?,
        path_semantics: platform::path_semantics(),
        local_transport: platform::local_transport(),
        state_schema: StateSchemaSupport {
            versions: ProtocolRange::new(NODE_STATE_SCHEMA_V1, NODE_STATE_SCHEMA_V10)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))?,
        },
        provider_contracts: provider_contracts.to_vec(),
        provider_adapter_contracts: provider_adapter_contracts.to_vec(),
    })
}

fn baseline_capabilities() -> Result<Vec<CapabilityId>, NodeServerError> {
    let capabilities = [
        NODE_COMPATIBILITY_METADATA_CAPABILITY,
        CAPABILITY_HOST_DIRECTORY_BROWSE_V1,
        NODE_REPOSITORY_PATH_CAPABILITY,
        NODE_WORKSPACE_FILE_READ_CAPABILITY,
        NODE_WORKSPACE_FILE_WRITE_CAPABILITY,
        NODE_WORKSPACE_ENTRY_CREATE_CAPABILITY,
        NODE_GIT_READ_CAPABILITY,
        NODE_PROVIDER_CONTRACT_MANIFEST_CAPABILITY,
        NODE_PROVIDER_ID_OPEN_CAPABILITY,
        NODE_PROVIDER_SESSION_REFERENCE_INDEX_CAPABILITY,
        NODE_PROVIDER_RUNTIME_STATUS_CAPABILITY,
        NODE_TERMINAL_FRAME_EVENTS_CAPABILITY,
        NODE_AGENT_STREAM_EVENTS_CAPABILITY,
        NODE_ACP_CONTROL_CAPABILITY,
        NODE_SPAWN_SPEC_DEFAULTS_OVERRIDES_CAPABILITY,
        NODE_SPAWN_PROFILE_REVISION_CAPABILITY,
        NODE_WORKTREE_SELECTION_CAPABILITY,
        NODE_MANAGED_WORKTREE_LIFECYCLE_CAPABILITY,
        NODE_MANAGED_WORKTREE_SPAWN_V2_CAPABILITY,
        NODE_CHILD_ENVIRONMENT_PROFILE_CAPABILITY,
        NODE_SESSION_BUNDLE_MATERIALIZATION_CAPABILITY,
        NODE_HISTORY_CONTEXT_PACK_CAPABILITY,
        NODE_SESSION_RECORD_CONTEXT_EXPORT_CAPABILITY,
        NODE_NATIVE_SESSION_CATALOG_CAPABILITY,
        NODE_NATIVE_SESSION_CATALOG_PAGING_CAPABILITY,
        NODE_NATIVE_SESSION_INDEX_CAPABILITY,
        NODE_NATIVE_SESSION_PREVIEW_CAPABILITY,
        NODE_AGENT_PROGRESS_SNAPSHOT_CAPABILITY,
        NODE_SESSION_TASK_CORRELATION_CAPABILITY,
    ]
        .into_iter()
        .map(|capability| {
            CapabilityId::new(capability)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))
        })
        .collect::<Result<Vec<_>, _>>()?;
    #[cfg(windows)]
    let capabilities = {
        let mut capabilities = capabilities;
        capabilities.push(
            CapabilityId::new(NODE_STANDALONE_WORKSPACE_LIFECYCLE_CAPABILITY)
                .map_err(|error| NodeServerError::Handshake(error.to_string()))?,
        );
        capabilities
    };
    Ok(capabilities)
}

fn request_uses_unnegotiated_capability(
    request: &NodeRequest,
    selected_capabilities: &[CapabilityId],
) -> bool {
    let selected = |required: &str| {
        selected_capabilities
            .iter()
            .any(|capability| capability.as_str() == required)
    };
    request
        .required_capability()
        .is_some_and(|required| !selected(required))
        || (request.requires_worktree_selection_capability()
            && !selected(NODE_WORKTREE_SELECTION_CAPABILITY))
        || (request.requires_spawn_spec_defaults_overrides_capability()
            && !selected(NODE_SPAWN_SPEC_DEFAULTS_OVERRIDES_CAPABILITY))
        || (request.requires_spawn_profile_revision_capability()
            && !selected(NODE_SPAWN_PROFILE_REVISION_CAPABILITY))
        || (request.requires_child_environment_profile_capability()
            && !selected(NODE_CHILD_ENVIRONMENT_PROFILE_CAPABILITY))
        || (request.requires_session_bundle_materialization_capability()
            && !selected(NODE_SESSION_BUNDLE_MATERIALIZATION_CAPABILITY))
        || (request.requires_history_context_pack_capability()
            && !selected(NODE_HISTORY_CONTEXT_PACK_CAPABILITY))
}

fn snapshot_for_wire(
    shared: &NodeShared,
    include_provider_runtime_status: bool,
    include_open_provider_ids: bool,
    include_spawn_profiles: bool,
    include_managed_worktrees: bool,
    include_child_environment_profiles: bool,
    include_session_bundles: bool,
    include_history_context_packs: bool,
    include_agent_progress: bool,
    include_session_task_correlation: bool,
) -> NodeSnapshot {
    let mut snapshot = shared.snapshot();
    if !include_provider_runtime_status {
        snapshot.provider_runtime_statuses.clear();
    }
    if !include_open_provider_ids {
        project_snapshot_legacy_provider_ids(&mut snapshot);
    }
    if !include_managed_worktrees {
        snapshot.managed_worktrees.clear();
        for workspace in &mut snapshot.workspaces {
            workspace.managed_worktree_profiles = None;
        }
    }
    if let Some(inventory) = snapshot.launch_inventory.as_mut() {
        if !include_spawn_profiles {
            inventory.spawn_profiles = None;
        }
        if !include_session_bundles {
            inventory.bundles = None;
        }
        if inventory.spawn_profiles.is_none()
            && inventory.bundles.is_none()
            && inventory.network_allowlists.is_none()
        {
            snapshot.launch_inventory = None;
        }
    }
    if !include_child_environment_profiles {
        clear_snapshot_child_environment_profiles(&mut snapshot);
    }
    if !include_session_bundles {
        clear_snapshot_session_bundles(&mut snapshot);
    }
    project_snapshot_history_for_wire(&mut snapshot, include_history_context_packs);
    if !include_history_context_packs {
        clear_snapshot_context_packs(&mut snapshot);
    }
    if !include_agent_progress {
        snapshot.agent_progress.clear();
    }
    if !include_session_task_correlation {
        clear_snapshot_session_task_bindings(&mut snapshot);
    }
    snapshot
}

fn clear_snapshot_session_task_bindings(snapshot: &mut NodeSnapshot) {
    for record in &mut snapshot.session_records {
        record.task_binding = None;
    }
}

fn project_event_without_session_task_binding(
    mut envelope: NodeEventEnvelope,
) -> NodeEventEnvelope {
    if let NodeEvent::SessionRecordUpserted { record } = &mut envelope.event {
        record.task_binding = None;
    }
    envelope
}

fn project_response_without_session_task_binding(reply: &mut ResponseEnvelope) {
    let Ok(response) = reply.result.as_mut() else { return };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => {
            clear_snapshot_session_task_bindings(snapshot);
        }
        NodeResponse::Resync { snapshot, events, .. } => {
            clear_snapshot_session_task_bindings(snapshot);
            for event in events {
                if let NodeEvent::SessionRecordUpserted { record } = &mut event.event {
                    record.task_binding = None;
                }
            }
        }
        NodeResponse::SessionRecordUpdated { record }
        | NodeResponse::ProviderSessionIndexed { record }
        | NodeResponse::NativeSessionIndexed { record, .. }
        | NodeResponse::SessionRecordResumed { record, .. } => {
            record.task_binding = None;
        }
        _ => {}
    }
}

fn project_response_without_agent_progress(reply: &mut ResponseEnvelope) {
    let Ok(response) = reply.result.as_mut() else { return };
    match response {
        NodeResponse::Snapshot { snapshot, .. } | NodeResponse::Resync { snapshot, .. } => {
            snapshot.agent_progress.clear();
        }
        _ => {}
    }
}

fn project_event_without_managed_worktrees(
    mut envelope: NodeEventEnvelope,
) -> Option<NodeEventEnvelope> {
    if matches!(
        envelope.event,
        NodeEvent::ManagedWorktreeUpserted { .. }
            | NodeEvent::ManagedWorktreeRemoved { .. }
    ) {
        return None;
    }
    if let NodeEvent::WorkspaceAdded { workspace } = &mut envelope.event {
        workspace.managed_worktree_profiles = None;
    }
    Some(envelope)
}

fn project_response_without_managed_worktrees(reply: &mut ResponseEnvelope) {
    if matches!(
        reply.result,
        Ok(NodeResponse::ManagedWorktreeSpawnAccepted { .. })
            | Ok(NodeResponse::ManagedWorktreeCleanup { .. })
    ) {
        reply.result = Err(failure(
            NodeFailureCode::UnsupportedCapability,
            "managed worktree capability was not negotiated",
        ));
        return;
    }
    let Ok(response) = reply.result.as_mut() else { return };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => {
            snapshot.managed_worktrees.clear();
            for workspace in &mut snapshot.workspaces {
                workspace.managed_worktree_profiles = None;
            }
        }
        NodeResponse::Resync { snapshot, events, .. } => {
            snapshot.managed_worktrees.clear();
            for workspace in &mut snapshot.workspaces {
                workspace.managed_worktree_profiles = None;
            }
            *events = std::mem::take(events)
                .into_iter()
                .filter_map(project_event_without_managed_worktrees)
                .collect();
        }
        NodeResponse::WorkspaceRegistered { workspace }
        | NodeResponse::StandaloneWorkspaceCreated { workspace }
        | NodeResponse::WorktreeCreated { workspace, .. } => {
            workspace.managed_worktree_profiles = None;
        }
        NodeResponse::WorkspaceInspected { inspection } => {
            inspection.git.managed_worktree = None;
        }
        _ => {}
    }
}

fn project_negotiated_provider_ids(compatibility: &mut NegotiatedNodeCompatibility) {
    let includes_open_provider_ids = compatibility.capabilities.iter().any(|capability| {
        capability.as_str() == NODE_PROVIDER_ID_OPEN_CAPABILITY
    });
    if includes_open_provider_ids {
        return;
    }
    compatibility
        .provider_contracts
        .retain(|contract| provider_id_is_legacy(&contract.provider));
    compatibility
        .provider_adapter_contracts
        .retain(|contract| provider_id_is_legacy(&contract.provider));
}

fn request_requires_open_provider_ids(shared: &NodeShared, request: &NodeRequest) -> bool {
    if let Some(spec) = match request {
        NodeRequest::SpawnSpec { spec }
        | NodeRequest::SpawnSpecWithHarnessMcp { spec, .. }
        | NodeRequest::ArmHarnessMcpReservation { spawn_spec: spec, .. } => Some(spec),
        NodeRequest::SpawnManagedWorktree { request } => Some(&request.spawn_spec),
        NodeRequest::SpawnManagedWorktreeV2 { request } => Some(&request.spawn_spec),
        _ => None,
    } {
        return shared
            .resolve_spawn_spec(spec)
            .is_ok_and(|resolved| !provider_id_is_legacy(&resolved.provider));
    }
    request_requires_open_provider_ids_with(
        request,
        |session| shared.validate_address(session).ok(),
        |record_id| shared.record(record_id).ok().map(|record| record.provider),
    )
}

fn request_requires_child_environment_profile(
    shared: &NodeShared,
    request: &NodeRequest,
) -> bool {
    if let Some(spec) = match request {
        NodeRequest::SpawnSpec { spec }
        | NodeRequest::SpawnSpecWithHarnessMcp { spec, .. }
        | NodeRequest::ArmHarnessMcpReservation { spawn_spec: spec, .. } => Some(spec),
        NodeRequest::SpawnManagedWorktree { request } => Some(&request.spawn_spec),
        NodeRequest::SpawnManagedWorktreeV2 { request } => Some(&request.spawn_spec),
        _ => None,
    } {
        return shared
            .resolve_spawn_spec(spec)
            .is_ok_and(|resolved| resolved.environment_profile_id.is_some());
    }
    match request {
        NodeRequest::Resume { session, .. }
        | NodeRequest::Prompt { session, .. }
        | NodeRequest::Paste { session, .. }
        | NodeRequest::Input { session, .. }
        | NodeRequest::TerminalBytes { session, .. }
        | NodeRequest::TerminalControl { session, .. }
        | NodeRequest::Resize { session, .. }
        | NodeRequest::Interrupt { session }
        | NodeRequest::Stop { session, .. }
        | NodeRequest::Remove { session }
        | NodeRequest::ResolveInteraction { session, .. }
        | NodeRequest::SetSessionMode { session, .. }
        | NodeRequest::SetSessionConfigOption { session, .. }
        | NodeRequest::SetSessionModel { session, .. }
        | NodeRequest::DiscoverHistory { session, .. }
        | NodeRequest::LoadHistory { session, .. }
        | NodeRequest::ExportContextPackForSessionRecord { session, .. }
        | NodeRequest::ExportContextPack { session } => shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&session.session.instance_id)
            .filter(|binding| {
                binding.workspace_id == session.workspace_id
                    && binding.generation == session.session.generation
            })
            .map_or(true, |binding| binding.environment_profile.is_some()),
        NodeRequest::RenameSessionRecord { record_id, .. }
        | NodeRequest::SetSessionTask { record_id, .. }
        | NodeRequest::ResumeSessionRecord { record_id, .. }
        | NodeRequest::ForgetSessionRecord { record_id } => shared
            .record(record_id)
            .map_or(true, |record| record.environment_profile.is_some()),
        NodeRequest::ArmHarnessMcpReservation { .. }
        | NodeRequest::SpawnSpecWithHarnessMcp { .. }
        | NodeRequest::ActivateHarnessMcpReservation { .. }
        | NodeRequest::AbortHarnessMcpReservation { .. }
        | NodeRequest::PutHarnessMcpReplyChunk { .. }
        | NodeRequest::RejectHarnessMcpCall { .. }
        | NodeRequest::Snapshot
        | NodeRequest::Resync { .. }
        | NodeRequest::BeginDeliveryStage { .. }
        | NodeRequest::PutDeliveryBlobChunk { .. }
        | NodeRequest::CommitDeliveryStage { .. }
        | NodeRequest::AbortDeliveryStage { .. }
        | NodeRequest::BrowseHostDirectories { .. }
        | NodeRequest::InspectWorkspace { .. }
        | NodeRequest::ReadWorkspaceFile { .. }
        | NodeRequest::WriteWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceDirectory { .. }
        | NodeRequest::ReadGitHistory { .. }
        | NodeRequest::ReadGitDiff { .. }
        | NodeRequest::AcquireController { .. }
        | NodeRequest::ReleaseController
        | NodeRequest::Spawn { .. }
        | NodeRequest::SpawnWithOptions { .. }
        | NodeRequest::SpawnSpec { .. }
        | NodeRequest::RegisterWorkspace { .. }
        | NodeRequest::CreateStandaloneWorkspace { .. }
        | NodeRequest::UnregisterWorkspace { .. }
        | NodeRequest::CreateWorktree { .. }
        | NodeRequest::RemoveWorktree { .. }
        | NodeRequest::SpawnManagedWorktree { .. }
        | NodeRequest::SpawnManagedWorktreeV2 { .. }
        | NodeRequest::CleanupManagedWorktree { .. }
        | NodeRequest::IndexProviderSession { .. }
        | NodeRequest::IndexNativeSession { .. }
        | NodeRequest::CatalogNativeSessions { .. }
        | NodeRequest::PageNativeSessions { .. }
        | NodeRequest::PreviewNativeSession { .. }
        | NodeRequest::PreviewSessionRecord { .. }
        | NodeRequest::ForgetContextPack { .. }
        | NodeRequest::ResolveDurableContextPack { .. }
        | NodeRequest::ReadContextPack { .. }
        | NodeRequest::Shutdown => false,
    }
}

fn request_requires_session_bundle(shared: &NodeShared, request: &NodeRequest) -> bool {
    if let Some(spec) = match request {
        NodeRequest::SpawnSpec { spec }
        | NodeRequest::SpawnSpecWithHarnessMcp { spec, .. }
        | NodeRequest::ArmHarnessMcpReservation { spawn_spec: spec, .. } => Some(spec),
        NodeRequest::SpawnManagedWorktree { request } => Some(&request.spawn_spec),
        NodeRequest::SpawnManagedWorktreeV2 { request } => Some(&request.spawn_spec),
        _ => None,
    } {
        return shared
            .resolve_spawn_spec(spec)
            .is_ok_and(|resolved| resolved.bundle_id.is_some());
    }
    match request {
        NodeRequest::Resume { session, .. }
        | NodeRequest::Prompt { session, .. }
        | NodeRequest::Paste { session, .. }
        | NodeRequest::Input { session, .. }
        | NodeRequest::TerminalBytes { session, .. }
        | NodeRequest::TerminalControl { session, .. }
        | NodeRequest::Resize { session, .. }
        | NodeRequest::Interrupt { session }
        | NodeRequest::Stop { session, .. }
        | NodeRequest::Remove { session }
        | NodeRequest::ResolveInteraction { session, .. }
        | NodeRequest::SetSessionMode { session, .. }
        | NodeRequest::SetSessionConfigOption { session, .. }
        | NodeRequest::SetSessionModel { session, .. }
        | NodeRequest::DiscoverHistory { session, .. }
        | NodeRequest::LoadHistory { session, .. }
        | NodeRequest::ExportContextPackForSessionRecord { session, .. }
        | NodeRequest::ExportContextPack { session } => shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&session.session.instance_id)
            .filter(|binding| {
                binding.workspace_id == session.workspace_id
                    && binding.generation == session.session.generation
            })
            .map_or(true, |binding| binding.bundle.is_some()),
        NodeRequest::RenameSessionRecord { record_id, .. }
        | NodeRequest::SetSessionTask { record_id, .. }
        | NodeRequest::ResumeSessionRecord { record_id, .. }
        | NodeRequest::ForgetSessionRecord { record_id } => shared
            .record(record_id)
            .map_or(true, |record| record.bundle.is_some()),
        NodeRequest::ArmHarnessMcpReservation { .. }
        | NodeRequest::SpawnSpecWithHarnessMcp { .. }
        | NodeRequest::ActivateHarnessMcpReservation { .. }
        | NodeRequest::AbortHarnessMcpReservation { .. }
        | NodeRequest::PutHarnessMcpReplyChunk { .. }
        | NodeRequest::RejectHarnessMcpCall { .. }
        | NodeRequest::Snapshot
        | NodeRequest::Resync { .. }
        | NodeRequest::BeginDeliveryStage { .. }
        | NodeRequest::PutDeliveryBlobChunk { .. }
        | NodeRequest::CommitDeliveryStage { .. }
        | NodeRequest::AbortDeliveryStage { .. }
        | NodeRequest::BrowseHostDirectories { .. }
        | NodeRequest::InspectWorkspace { .. }
        | NodeRequest::ReadWorkspaceFile { .. }
        | NodeRequest::WriteWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceDirectory { .. }
        | NodeRequest::ReadGitHistory { .. }
        | NodeRequest::ReadGitDiff { .. }
        | NodeRequest::AcquireController { .. }
        | NodeRequest::ReleaseController
        | NodeRequest::Spawn { .. }
        | NodeRequest::SpawnWithOptions { .. }
        | NodeRequest::SpawnSpec { .. }
        | NodeRequest::RegisterWorkspace { .. }
        | NodeRequest::CreateStandaloneWorkspace { .. }
        | NodeRequest::UnregisterWorkspace { .. }
        | NodeRequest::CreateWorktree { .. }
        | NodeRequest::RemoveWorktree { .. }
        | NodeRequest::SpawnManagedWorktree { .. }
        | NodeRequest::SpawnManagedWorktreeV2 { .. }
        | NodeRequest::CleanupManagedWorktree { .. }
        | NodeRequest::IndexProviderSession { .. }
        | NodeRequest::IndexNativeSession { .. }
        | NodeRequest::CatalogNativeSessions { .. }
        | NodeRequest::PageNativeSessions { .. }
        | NodeRequest::PreviewNativeSession { .. }
        | NodeRequest::PreviewSessionRecord { .. }
        | NodeRequest::ForgetContextPack { .. }
        | NodeRequest::ResolveDurableContextPack { .. }
        | NodeRequest::ReadContextPack { .. }
        | NodeRequest::Shutdown => false,
    }
}

fn request_requires_history_context_pack(shared: &NodeShared, request: &NodeRequest) -> bool {
    if request.requires_history_context_pack_capability() {
        return true;
    }
    if let Some(spec) = match request {
        NodeRequest::SpawnSpec { spec }
        | NodeRequest::SpawnSpecWithHarnessMcp { spec, .. }
        | NodeRequest::ArmHarnessMcpReservation { spawn_spec: spec, .. } => Some(spec),
        NodeRequest::SpawnManagedWorktree { request } => Some(&request.spawn_spec),
        NodeRequest::SpawnManagedWorktreeV2 { request } => Some(&request.spawn_spec),
        _ => None,
    } {
        return shared
            .resolve_spawn_spec(spec)
            .map_or(true, |resolved| resolved.context_id.is_some());
    }
    match request {
        NodeRequest::Resume { session, .. }
        | NodeRequest::Prompt { session, .. }
        | NodeRequest::Paste { session, .. }
        | NodeRequest::Input { session, .. }
        | NodeRequest::TerminalBytes { session, .. }
        | NodeRequest::TerminalControl { session, .. }
        | NodeRequest::Resize { session, .. }
        | NodeRequest::Interrupt { session }
        | NodeRequest::Stop { session, .. }
        | NodeRequest::Remove { session }
        | NodeRequest::ResolveInteraction { session, .. }
        | NodeRequest::SetSessionMode { session, .. }
        | NodeRequest::SetSessionConfigOption { session, .. }
        | NodeRequest::SetSessionModel { session, .. } => shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&session.session.instance_id)
            .filter(|binding| {
                binding.workspace_id == session.workspace_id
                    && binding.generation == session.session.generation
            })
            .map_or(true, |binding| binding.context.is_some()),
        NodeRequest::RenameSessionRecord { record_id, .. }
        | NodeRequest::SetSessionTask { record_id, .. }
        | NodeRequest::ResumeSessionRecord { record_id, .. }
        | NodeRequest::ForgetSessionRecord { record_id } => shared
            .record(record_id)
            .map_or(true, |record| record.context.is_some()),
        NodeRequest::ArmHarnessMcpReservation { .. }
        | NodeRequest::SpawnSpecWithHarnessMcp { .. }
        | NodeRequest::ActivateHarnessMcpReservation { .. }
        | NodeRequest::AbortHarnessMcpReservation { .. }
        | NodeRequest::PutHarnessMcpReplyChunk { .. }
        | NodeRequest::RejectHarnessMcpCall { .. }
        | NodeRequest::Snapshot
        | NodeRequest::Resync { .. }
        | NodeRequest::BeginDeliveryStage { .. }
        | NodeRequest::PutDeliveryBlobChunk { .. }
        | NodeRequest::CommitDeliveryStage { .. }
        | NodeRequest::AbortDeliveryStage { .. }
        | NodeRequest::BrowseHostDirectories { .. }
        | NodeRequest::InspectWorkspace { .. }
        | NodeRequest::ReadWorkspaceFile { .. }
        | NodeRequest::WriteWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceDirectory { .. }
        | NodeRequest::ReadGitHistory { .. }
        | NodeRequest::ReadGitDiff { .. }
        | NodeRequest::AcquireController { .. }
        | NodeRequest::ReleaseController
        | NodeRequest::Spawn { .. }
        | NodeRequest::SpawnWithOptions { .. }
        | NodeRequest::SpawnSpec { .. }
        | NodeRequest::RegisterWorkspace { .. }
        | NodeRequest::CreateStandaloneWorkspace { .. }
        | NodeRequest::UnregisterWorkspace { .. }
        | NodeRequest::CreateWorktree { .. }
        | NodeRequest::RemoveWorktree { .. }
        | NodeRequest::SpawnManagedWorktree { .. }
        | NodeRequest::SpawnManagedWorktreeV2 { .. }
        | NodeRequest::CleanupManagedWorktree { .. }
        | NodeRequest::IndexProviderSession { .. }
        | NodeRequest::IndexNativeSession { .. }
        | NodeRequest::CatalogNativeSessions { .. }
        | NodeRequest::PageNativeSessions { .. }
        | NodeRequest::PreviewNativeSession { .. }
        | NodeRequest::PreviewSessionRecord { .. }
        | NodeRequest::DiscoverHistory { .. }
        | NodeRequest::LoadHistory { .. }
        | NodeRequest::ExportContextPackForSessionRecord { .. }
        | NodeRequest::ExportContextPack { .. }
        | NodeRequest::ForgetContextPack { .. }
        | NodeRequest::ResolveDurableContextPack { .. }
        | NodeRequest::ReadContextPack { .. }
        | NodeRequest::Shutdown => false,
    }
}

fn request_requires_open_provider_ids_with(
    request: &NodeRequest,
    provider_for_session: impl Fn(&SessionAddress) -> Option<AgentId>,
    provider_for_record: impl Fn(&SessionRecordId) -> Option<AgentId>,
) -> bool {
    match request {
        NodeRequest::Spawn { provider, .. } | NodeRequest::SpawnWithOptions { provider, .. } => !provider_id_is_legacy(provider),
        NodeRequest::IndexProviderSession { provider, .. } => !provider_id_is_legacy(provider),
        NodeRequest::CatalogNativeSessions { route, .. }
        | NodeRequest::PageNativeSessions { route, .. } => {
            !provider_id_is_legacy(&route.provider)
        }
        NodeRequest::PreviewNativeSession { selection, .. }
        | NodeRequest::IndexNativeSession { selection, .. } => {
            !provider_id_is_legacy(&selection.route.provider)
        }
        NodeRequest::SpawnSpec { .. }
        | NodeRequest::SpawnSpecWithHarnessMcp { .. } => false,
        NodeRequest::SpawnManagedWorktree { .. }
        | NodeRequest::SpawnManagedWorktreeV2 { .. } => false,
        NodeRequest::Resume { session, .. }
        | NodeRequest::Prompt { session, .. }
        | NodeRequest::Paste { session, .. }
        | NodeRequest::Input { session, .. }
        | NodeRequest::TerminalBytes { session, .. }
        | NodeRequest::TerminalControl { session, .. }
        | NodeRequest::Resize { session, .. }
        | NodeRequest::Interrupt { session }
        | NodeRequest::Stop { session, .. }
        | NodeRequest::Remove { session }
        | NodeRequest::ResolveInteraction { session, .. }
        | NodeRequest::SetSessionMode { session, .. }
        | NodeRequest::SetSessionConfigOption { session, .. }
        | NodeRequest::SetSessionModel { session, .. }
        | NodeRequest::DiscoverHistory { session, .. }
        | NodeRequest::LoadHistory { session, .. }
        | NodeRequest::ExportContextPackForSessionRecord { session, .. }
        | NodeRequest::ExportContextPack { session } => provider_for_session(session)
            .map_or(true, |provider| !provider_id_is_legacy(&provider)),
        NodeRequest::RenameSessionRecord { record_id, .. }
        | NodeRequest::SetSessionTask { record_id, .. }
        | NodeRequest::ResumeSessionRecord { record_id, .. }
        | NodeRequest::ForgetSessionRecord { record_id } => provider_for_record(record_id)
            .map_or(true, |provider| !provider_id_is_legacy(&provider)),
        NodeRequest::PreviewSessionRecord { record_id, .. } => provider_for_record(record_id)
            .map_or(true, |provider| !provider_id_is_legacy(&provider)),
        NodeRequest::ArmHarnessMcpReservation { .. }
        | NodeRequest::ActivateHarnessMcpReservation { .. }
        | NodeRequest::AbortHarnessMcpReservation { .. }
        | NodeRequest::PutHarnessMcpReplyChunk { .. }
        | NodeRequest::RejectHarnessMcpCall { .. }
        | NodeRequest::Snapshot
        | NodeRequest::Resync { .. }
        | NodeRequest::BeginDeliveryStage { .. }
        | NodeRequest::PutDeliveryBlobChunk { .. }
        | NodeRequest::CommitDeliveryStage { .. }
        | NodeRequest::AbortDeliveryStage { .. }
        | NodeRequest::BrowseHostDirectories { .. }
        | NodeRequest::InspectWorkspace { .. }
        | NodeRequest::ReadWorkspaceFile { .. }
        | NodeRequest::WriteWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceFile { .. }
        | NodeRequest::CreateWorkspaceDirectory { .. }
        | NodeRequest::ReadGitHistory { .. }
        | NodeRequest::ReadGitDiff { .. }
        | NodeRequest::AcquireController { .. }
        | NodeRequest::ReleaseController
        | NodeRequest::RegisterWorkspace { .. }
        | NodeRequest::CreateStandaloneWorkspace { .. }
        | NodeRequest::UnregisterWorkspace { .. }
        | NodeRequest::CreateWorktree { .. }
        | NodeRequest::RemoveWorktree { .. }
        | NodeRequest::CleanupManagedWorktree { .. }
        | NodeRequest::Shutdown => false,
        NodeRequest::ForgetContextPack { .. } => true,
        // No session/record to cheaply resolve a provider from here either;
        // the resolved receipt can carry an open-id provider, so require the
        // same capability as ForgetContextPack unconditionally. `ReadContextPack`
        // is the same digest-keyed lookup one step further into the same
        // catalog, so it inherits the same conservative answer.
        NodeRequest::ResolveDurableContextPack { .. }
        | NodeRequest::ReadContextPack { .. } => true,
    }
}

fn project_snapshot_legacy_provider_ids(snapshot: &mut NodeSnapshot) {
    snapshot.enabled_providers.retain(provider_id_is_legacy);
    snapshot.provider_runtime_statuses = ProviderRuntimeStatuses::new(
        snapshot
            .provider_runtime_statuses
            .as_slice()
            .iter()
            .filter(|status| provider_id_is_legacy(status.provider()))
            .cloned(),
    )
    .expect("a filtered provider runtime projection remains valid");
    snapshot
        .session_records
        .retain(|record| provider_id_is_legacy(&record.provider));
    for workspace in &mut snapshot.workspaces {
        workspace
            .sessions
            .retain(|session| provider_id_is_legacy(&session.agent_id));
    }
}

fn clear_snapshot_child_environment_profiles(snapshot: &mut NodeSnapshot) {
    for record in &mut snapshot.session_records {
        record.environment_profile = None;
    }
    if let Some(profiles) = snapshot
        .launch_inventory
        .as_mut()
        .and_then(|inventory| inventory.spawn_profiles.as_mut())
    {
        for profile in profiles {
            profile.environment_profile = None;
        }
    }
}

fn project_event_without_child_environment_profile(
    mut envelope: NodeEventEnvelope,
) -> NodeEventEnvelope {
    if let NodeEvent::SessionRecordUpserted { record } = &mut envelope.event {
        record.environment_profile = None;
    }
    envelope
}

fn project_response_without_child_environment_profile(reply: &mut ResponseEnvelope) {
    let contains_environment_profile = match reply.result.as_ref() {
        Ok(NodeResponse::SpawnSpecAccepted { receipt }) => {
            receipt.environment_profile.is_some()
        }
        Ok(NodeResponse::ManagedWorktreeSpawnAccepted { receipt }) => {
            receipt.spawn.environment_profile.is_some()
        }
        _ => false,
    };
    if contains_environment_profile {
        reply.result = Err(failure(
            NodeFailureCode::UnsupportedCapability,
            "child environment profiles were not negotiated",
        ));
        return;
    }
    let Ok(response) = reply.result.as_mut() else {
        return;
    };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => {
            clear_snapshot_child_environment_profiles(snapshot);
        }
        NodeResponse::Resync { snapshot, events, .. } => {
            clear_snapshot_child_environment_profiles(snapshot);
            for event in events {
                if let NodeEvent::SessionRecordUpserted { record } = &mut event.event {
                    record.environment_profile = None;
                }
            }
        }
        NodeResponse::SessionRecordUpdated { record }
        | NodeResponse::ProviderSessionIndexed { record }
        | NodeResponse::NativeSessionIndexed { record, .. }
        | NodeResponse::SessionRecordResumed { record, .. } => {
            record.environment_profile = None;
        }
        NodeResponse::Armed { .. }
        | NodeResponse::Spawned { .. }
        | NodeResponse::Activated { .. }
        | NodeResponse::Aborted { .. }
        | NodeResponse::ReplyChunkAccepted { .. }
        | NodeResponse::CallRejected { .. }
        | NodeResponse::DeliveryStageBegun { .. }
        | NodeResponse::DeliveryBlobChunkAccepted { .. }
        | NodeResponse::DeliveryCommitted { .. }
        | NodeResponse::DeliveryStageAborted { .. }
        | NodeResponse::WorkspaceInspected { .. }
        | NodeResponse::HostDirectoriesBrowsed { .. }
        | NodeResponse::WorkspaceFileRead { .. }
        | NodeResponse::WorkspaceFileWritten { .. }
        | NodeResponse::WorkspaceFileCreated { .. }
        | NodeResponse::WorkspaceDirectoryCreated { .. }
        | NodeResponse::GitHistoryRead { .. }
        | NodeResponse::GitDiffRead { .. }
        | NodeResponse::Controller { .. }
        | NodeResponse::SpawnAccepted { .. }
        | NodeResponse::SpawnSpecAccepted { .. }
        | NodeResponse::ManagedWorktreeSpawnAccepted { .. }
        | NodeResponse::ManagedWorktreeCleanup { .. }
        | NodeResponse::NativeSessionsCataloged { .. }
        | NodeResponse::NativeSessionsPaged { .. }
        | NodeResponse::NativeSessionPreviewed { .. }
        | NodeResponse::SessionRecordPreviewed { .. }
        | NodeResponse::HistoryDiscovered { .. }
        | NodeResponse::HistoryLoaded { .. }
        | NodeResponse::ContextPackForSessionRecordExported { .. }
        | NodeResponse::ContextPackExported { .. }
        | NodeResponse::ContextPackForgotten { .. }
        | NodeResponse::DurableContextPackResolved { .. }
        | NodeResponse::ContextPackBytesRead { .. }
        | NodeResponse::SessionRecordForgotten { .. }
        | NodeResponse::WorkspaceRegistered { .. }
        | NodeResponse::StandaloneWorkspaceCreated { .. }
        | NodeResponse::WorkspaceUnregistered { .. }
        | NodeResponse::WorktreeCreated { .. }
        | NodeResponse::WorktreeRemoved { .. }
        | NodeResponse::Accepted
        | NodeResponse::ShuttingDown => {}
    }
}

fn clear_snapshot_session_bundles(snapshot: &mut NodeSnapshot) {
    for record in &mut snapshot.session_records {
        record.bundle = None;
    }
}

fn project_event_without_session_bundle(
    mut envelope: NodeEventEnvelope,
) -> NodeEventEnvelope {
    if let NodeEvent::SessionRecordUpserted { record } = &mut envelope.event {
        record.bundle = None;
    }
    envelope
}

fn project_response_without_session_bundle(reply: &mut ResponseEnvelope) {
    let contains_bundle = match reply.result.as_ref() {
        Ok(NodeResponse::SpawnSpecAccepted { receipt }) => receipt.bundle.is_some(),
        Ok(NodeResponse::ManagedWorktreeSpawnAccepted { receipt }) => {
            receipt.spawn.bundle.is_some()
        }
        _ => false,
    };
    if contains_bundle {
        reply.result = Err(failure(
            NodeFailureCode::UnsupportedCapability,
            "session bundles were not negotiated",
        ));
        return;
    }
    let Ok(response) = reply.result.as_mut() else {
        return;
    };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => clear_snapshot_session_bundles(snapshot),
        NodeResponse::Resync { snapshot, events, .. } => {
            clear_snapshot_session_bundles(snapshot);
            for event in events {
                if let NodeEvent::SessionRecordUpserted { record } = &mut event.event {
                    record.bundle = None;
                }
            }
        }
        NodeResponse::SessionRecordUpdated { record }
        | NodeResponse::ProviderSessionIndexed { record }
        | NodeResponse::NativeSessionIndexed { record, .. }
        | NodeResponse::SessionRecordResumed { record, .. } => record.bundle = None,
        NodeResponse::Armed { .. }
        | NodeResponse::Spawned { .. }
        | NodeResponse::Activated { .. }
        | NodeResponse::Aborted { .. }
        | NodeResponse::ReplyChunkAccepted { .. }
        | NodeResponse::CallRejected { .. }
        | NodeResponse::DeliveryStageBegun { .. }
        | NodeResponse::DeliveryBlobChunkAccepted { .. }
        | NodeResponse::DeliveryCommitted { .. }
        | NodeResponse::DeliveryStageAborted { .. }
        | NodeResponse::WorkspaceInspected { .. }
        | NodeResponse::HostDirectoriesBrowsed { .. }
        | NodeResponse::WorkspaceFileRead { .. }
        | NodeResponse::WorkspaceFileWritten { .. }
        | NodeResponse::WorkspaceFileCreated { .. }
        | NodeResponse::WorkspaceDirectoryCreated { .. }
        | NodeResponse::GitHistoryRead { .. }
        | NodeResponse::GitDiffRead { .. }
        | NodeResponse::Controller { .. }
        | NodeResponse::SpawnAccepted { .. }
        | NodeResponse::SpawnSpecAccepted { .. }
        | NodeResponse::ManagedWorktreeSpawnAccepted { .. }
        | NodeResponse::ManagedWorktreeCleanup { .. }
        | NodeResponse::NativeSessionsCataloged { .. }
        | NodeResponse::NativeSessionsPaged { .. }
        | NodeResponse::NativeSessionPreviewed { .. }
        | NodeResponse::SessionRecordPreviewed { .. }
        | NodeResponse::HistoryDiscovered { .. }
        | NodeResponse::HistoryLoaded { .. }
        | NodeResponse::ContextPackForSessionRecordExported { .. }
        | NodeResponse::ContextPackExported { .. }
        | NodeResponse::ContextPackForgotten { .. }
        | NodeResponse::DurableContextPackResolved { .. }
        | NodeResponse::ContextPackBytesRead { .. }
        | NodeResponse::SessionRecordForgotten { .. }
        | NodeResponse::WorkspaceRegistered { .. }
        | NodeResponse::StandaloneWorkspaceCreated { .. }
        | NodeResponse::WorkspaceUnregistered { .. }
        | NodeResponse::WorktreeCreated { .. }
        | NodeResponse::WorktreeRemoved { .. }
        | NodeResponse::Accepted
        | NodeResponse::ShuttingDown => {}
    }
}

fn project_snapshot_history_for_wire(
    snapshot: &mut NodeSnapshot,
    include_history_metadata: bool,
) {
    for workspace in &mut snapshot.workspaces {
        for session in &mut workspace.sessions {
            if include_history_metadata {
                session.history.loaded = None;
            } else {
                session.history = Default::default();
            }
        }
    }
}

fn project_event_history_for_wire(
    mut envelope: NodeEventEnvelope,
    include_history_metadata: bool,
) -> NodeEventEnvelope {
    if let NodeEvent::WorkspaceAdded { workspace } = &mut envelope.event {
        for session in &mut workspace.sessions {
            if include_history_metadata {
                session.history.loaded = None;
            } else {
                session.history = Default::default();
            }
        }
    }
    envelope
}

fn project_response_history_for_wire(
    reply: &mut ResponseEnvelope,
    include_history_metadata: bool,
) {
    let Ok(response) = reply.result.as_mut() else {
        return;
    };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => {
            project_snapshot_history_for_wire(snapshot, include_history_metadata);
        }
        NodeResponse::Resync {
            snapshot, events, ..
        } => {
            project_snapshot_history_for_wire(snapshot, include_history_metadata);
            for event in events {
                *event = project_event_history_for_wire(
                    event.clone(),
                    include_history_metadata,
                );
            }
        }
        NodeResponse::WorkspaceRegistered { workspace }
        | NodeResponse::StandaloneWorkspaceCreated { workspace }
        | NodeResponse::WorktreeCreated { workspace, .. } => {
            for session in &mut workspace.sessions {
                if include_history_metadata {
                    session.history.loaded = None;
                } else {
                    session.history = Default::default();
                }
            }
        }
        _ => {}
    }
}

fn clear_snapshot_context_packs(snapshot: &mut NodeSnapshot) {
    for record in &mut snapshot.session_records {
        record.context_id = None;
        record.context = None;
        record.exported_context = None;
    }
}

fn project_event_without_context_pack(
    mut envelope: NodeEventEnvelope,
) -> NodeEventEnvelope {
    if let NodeEvent::SessionRecordUpserted { record } = &mut envelope.event {
        record.context_id = None;
        record.context = None;
        record.exported_context = None;
    }
    envelope
}

fn project_response_without_context_pack(reply: &mut ResponseEnvelope) {
    let contains_context = match reply.result.as_ref() {
        Ok(NodeResponse::SpawnSpecAccepted { receipt }) => receipt.context.is_some(),
        Ok(NodeResponse::ManagedWorktreeSpawnAccepted { receipt }) => {
            receipt.spawn.context.is_some()
        }
        Ok(NodeResponse::HistoryDiscovered { .. })
        | Ok(NodeResponse::HistoryLoaded { .. })
        | Ok(NodeResponse::ContextPackForSessionRecordExported { .. })
        | Ok(NodeResponse::ContextPackExported { .. })
        | Ok(NodeResponse::ContextPackForgotten { .. })
        | Ok(NodeResponse::DurableContextPackResolved { .. }) => true,
        _ => false,
    };
    if contains_context {
        reply.result = Err(failure(
            NodeFailureCode::UnsupportedCapability,
            "history context packs were not negotiated",
        ));
        return;
    }
    let Ok(response) = reply.result.as_mut() else {
        return;
    };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => clear_snapshot_context_packs(snapshot),
        NodeResponse::Resync {
            snapshot, events, ..
        } => {
            clear_snapshot_context_packs(snapshot);
            for event in events {
                if let NodeEvent::SessionRecordUpserted { record } = &mut event.event {
                    record.context_id = None;
                    record.context = None;
                    record.exported_context = None;
                }
            }
        }
        NodeResponse::SessionRecordUpdated { record }
        | NodeResponse::ProviderSessionIndexed { record }
        | NodeResponse::NativeSessionIndexed { record, .. }
        | NodeResponse::SessionRecordResumed { record, .. } => {
            record.context_id = None;
            record.context = None;
            record.exported_context = None;
        }
        _ => {}
    }
}

fn project_response_legacy_provider_ids(shared: &NodeShared, reply: &mut ResponseEnvelope) {
    let contains_open_record = match reply.result.as_ref() {
        Ok(NodeResponse::SessionRecordUpdated { record })
        | Ok(NodeResponse::ProviderSessionIndexed { record })
        | Ok(NodeResponse::SessionRecordResumed { record, .. }) => {
            !provider_id_is_legacy(&record.provider)
        }
        Ok(NodeResponse::NativeSessionIndexed { selection, record }) => {
            !provider_id_is_legacy(&selection.route.provider)
                || !provider_id_is_legacy(&record.provider)
        }
        Ok(NodeResponse::SpawnSpecAccepted { receipt }) => {
            !provider_id_is_legacy(&receipt.provider)
        }
        Ok(NodeResponse::ManagedWorktreeSpawnAccepted { receipt }) => {
            !provider_id_is_legacy(&receipt.spawn.provider)
        }
        Ok(NodeResponse::NativeSessionsCataloged { route, .. })
        | Ok(NodeResponse::NativeSessionsPaged { route, .. }) => {
            !provider_id_is_legacy(&route.provider)
        }
        Ok(NodeResponse::NativeSessionPreviewed { selection, .. }) => {
            !provider_id_is_legacy(&selection.route.provider)
        }
        _ => false,
    };
    if contains_open_record {
        reply.result = Err(failure(
            NodeFailureCode::UnsupportedCapability,
            "open provider IDs were not negotiated",
        ));
        return;
    }
    let Ok(response) = reply.result.as_mut() else {
        return;
    };
    match response {
        NodeResponse::Snapshot { snapshot, .. } => {
            project_snapshot_legacy_provider_ids(snapshot);
        }
        NodeResponse::Resync { snapshot, events, .. } => {
            project_snapshot_legacy_provider_ids(snapshot);
            *events = std::mem::take(events)
                .into_iter()
                .filter_map(|event| project_event_legacy_provider_ids(shared, event))
                .collect();
        }
        NodeResponse::WorkspaceRegistered { workspace }
        | NodeResponse::StandaloneWorkspaceCreated { workspace }
        | NodeResponse::WorktreeCreated { workspace, .. } => {
            workspace
                .sessions
                .retain(|session| provider_id_is_legacy(&session.agent_id));
        }
        NodeResponse::Armed { .. }
        | NodeResponse::Spawned { .. }
        | NodeResponse::Activated { .. }
        | NodeResponse::Aborted { .. }
        | NodeResponse::ReplyChunkAccepted { .. }
        | NodeResponse::CallRejected { .. }
        | NodeResponse::DeliveryStageBegun { .. }
        | NodeResponse::DeliveryBlobChunkAccepted { .. }
        | NodeResponse::DeliveryCommitted { .. }
        | NodeResponse::DeliveryStageAborted { .. }
        | NodeResponse::WorkspaceInspected { .. }
        | NodeResponse::HostDirectoriesBrowsed { .. }
        | NodeResponse::WorkspaceFileRead { .. }
        | NodeResponse::WorkspaceFileWritten { .. }
        | NodeResponse::WorkspaceFileCreated { .. }
        | NodeResponse::WorkspaceDirectoryCreated { .. }
        | NodeResponse::GitHistoryRead { .. }
        | NodeResponse::GitDiffRead { .. }
        | NodeResponse::Controller { .. }
        | NodeResponse::SpawnAccepted { .. }
        | NodeResponse::SpawnSpecAccepted { .. }
        | NodeResponse::ManagedWorktreeSpawnAccepted { .. }
        | NodeResponse::ManagedWorktreeCleanup { .. }
        | NodeResponse::NativeSessionsCataloged { .. }
        | NodeResponse::NativeSessionsPaged { .. }
        | NodeResponse::NativeSessionPreviewed { .. }
        | NodeResponse::SessionRecordPreviewed { .. }
        | NodeResponse::HistoryDiscovered { .. }
        | NodeResponse::HistoryLoaded { .. }
        | NodeResponse::ContextPackForSessionRecordExported { .. }
        | NodeResponse::ContextPackExported { .. }
        | NodeResponse::ContextPackForgotten { .. }
        | NodeResponse::DurableContextPackResolved { .. }
        | NodeResponse::ContextPackBytesRead { .. }
        | NodeResponse::SessionRecordUpdated { .. }
        | NodeResponse::ProviderSessionIndexed { .. }
        | NodeResponse::NativeSessionIndexed { .. }
        | NodeResponse::SessionRecordResumed { .. }
        | NodeResponse::SessionRecordForgotten { .. }
        | NodeResponse::WorkspaceUnregistered { .. }
        | NodeResponse::WorktreeRemoved { .. }
        | NodeResponse::Accepted
        | NodeResponse::ShuttingDown => {}
    }
}

fn project_event_legacy_provider_ids(
    shared: &NodeShared,
    mut envelope: NodeEventEnvelope,
) -> Option<NodeEventEnvelope> {
    let include = match &mut envelope.event {
        NodeEvent::HarnessMcpReadCall { .. } => true,
        NodeEvent::Control { address, .. }
        | NodeEvent::AgentStream { address, .. }
        | NodeEvent::TerminalFrame { address, .. } => shared
            .validate_address(address)
            .is_ok_and(|provider| provider_id_is_legacy(&provider)),
        NodeEvent::WorkspaceAdded { workspace } => {
            workspace
                .sessions
                .retain(|session| provider_id_is_legacy(&session.agent_id));
            true
        }
        NodeEvent::SessionRecordUpserted { record } => {
            provider_id_is_legacy(&record.provider)
        }
        NodeEvent::SessionRecordHistorySummarized { .. } => false,
        NodeEvent::SessionRecordRemoved { .. } => shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .removed_record_providers
            .get(&envelope.sequence)
            .is_some_and(provider_id_is_legacy),
        NodeEvent::ControllerChanged { .. }
        | NodeEvent::ManagedWorktreeUpserted { .. }
        | NodeEvent::ManagedWorktreeRemoved { .. }
        | NodeEvent::WorkspaceRemoved { .. }
        | NodeEvent::ResyncRequired { .. } => true,
    };
    include.then_some(envelope)
}

fn clear_response_provider_runtime_status(reply: &mut ResponseEnvelope) {
    let Ok(response) = reply.result.as_mut() else {
        return;
    };
    match response {
        NodeResponse::Snapshot { snapshot, .. } | NodeResponse::Resync { snapshot, .. } => {
            snapshot.provider_runtime_statuses.clear();
        }
        NodeResponse::Armed { .. }
        | NodeResponse::Spawned { .. }
        | NodeResponse::Activated { .. }
        | NodeResponse::Aborted { .. }
        | NodeResponse::ReplyChunkAccepted { .. }
        | NodeResponse::CallRejected { .. }
        | NodeResponse::DeliveryStageBegun { .. }
        | NodeResponse::DeliveryBlobChunkAccepted { .. }
        | NodeResponse::DeliveryCommitted { .. }
        | NodeResponse::DeliveryStageAborted { .. }
        | NodeResponse::WorkspaceInspected { .. }
        | NodeResponse::HostDirectoriesBrowsed { .. }
        | NodeResponse::WorkspaceFileRead { .. }
        | NodeResponse::WorkspaceFileWritten { .. }
        | NodeResponse::WorkspaceFileCreated { .. }
        | NodeResponse::WorkspaceDirectoryCreated { .. }
        | NodeResponse::GitHistoryRead { .. }
        | NodeResponse::GitDiffRead { .. }
        | NodeResponse::Controller { .. }
        | NodeResponse::SpawnAccepted { .. }
        | NodeResponse::SpawnSpecAccepted { .. }
        | NodeResponse::ManagedWorktreeSpawnAccepted { .. }
        | NodeResponse::ManagedWorktreeCleanup { .. }
        | NodeResponse::NativeSessionsCataloged { .. }
        | NodeResponse::NativeSessionsPaged { .. }
        | NodeResponse::NativeSessionPreviewed { .. }
        | NodeResponse::SessionRecordPreviewed { .. }
        | NodeResponse::HistoryDiscovered { .. }
        | NodeResponse::HistoryLoaded { .. }
        | NodeResponse::ContextPackForSessionRecordExported { .. }
        | NodeResponse::ContextPackExported { .. }
        | NodeResponse::ContextPackForgotten { .. }
        | NodeResponse::DurableContextPackResolved { .. }
        | NodeResponse::ContextPackBytesRead { .. }
        | NodeResponse::SessionRecordUpdated { .. }
        | NodeResponse::ProviderSessionIndexed { .. }
        | NodeResponse::NativeSessionIndexed { .. }
        | NodeResponse::SessionRecordResumed { .. }
        | NodeResponse::SessionRecordForgotten { .. }
        | NodeResponse::WorkspaceRegistered { .. }
        | NodeResponse::StandaloneWorkspaceCreated { .. }
        | NodeResponse::WorkspaceUnregistered { .. }
        | NodeResponse::WorktreeCreated { .. }
        | NodeResponse::WorktreeRemoved { .. }
        | NodeResponse::Accepted
        | NodeResponse::ShuttingDown => {}
    }
}

struct ControllerReleaseGuard {
    shared: Arc<NodeShared>,
    connection_id: u64,
}

impl Drop for ControllerReleaseGuard {
    fn drop(&mut self) {
        self.shared.release_controller(self.connection_id);
    }
}

struct AbortTaskOnDrop(AbortHandle);

impl Drop for AbortTaskOnDrop {
    fn drop(&mut self) {
        self.0.abort();
    }
}

/// Reads an unsigned env-config override, following the pattern of every
/// other bounded knob in this module: missing/unparsable/zero falls back to
/// `default`, and the resolved value is always clamped to `max` so a bad
/// override cannot reopen a bound this budget exists to enforce.
fn env_config_bounded(name: &str, default: u64, max: u64) -> u64 {
    std::env::var(name)
        .ok()
        .and_then(|value| value.parse::<u64>().ok())
        .filter(|value| *value > 0)
        .unwrap_or(default)
        .min(max)
}

fn workspace_inspection_time_budget_ms() -> u64 {
    env_config_bounded(
        "GATE4AGENT_NODE_WORKSPACE_INSPECTION_BUDGET_MS",
        WORKSPACE_INSPECTION_TIME_BUDGET_MS_DEFAULT,
        WORKSPACE_INSPECTION_TIME_BUDGET_MS_MAX,
    )
}

fn workspace_inspection_entry_cap() -> usize {
    env_config_bounded(
        "GATE4AGENT_NODE_WORKSPACE_INSPECTION_ENTRY_CAP",
        WORKSPACE_INSPECTION_ENTRY_CAP_DEFAULT as u64,
        WORKSPACE_INSPECTION_ENTRY_CAP_MAX as u64,
    ) as usize
}

/// Tracks the shared walk-side budget across the whole recursive walk: a
/// wall-clock deadline (shared with the git phase that runs after the walk)
/// and a cap on directory entries visited, whether or not they were pushed
/// to the response. Cheap to check per entry — one `Instant::now()` and one
/// integer compare.
struct WorkspaceWalkBudget {
    deadline: Instant,
    entry_cap: usize,
    entries_visited: u64,
    time_budget_exceeded: bool,
    entry_cap_exceeded: bool,
}

impl WorkspaceWalkBudget {
    fn new(deadline: Instant, entry_cap: usize) -> Self {
        Self {
            deadline,
            entry_cap,
            entries_visited: 0,
            time_budget_exceeded: false,
            entry_cap_exceeded: false,
        }
    }

    fn is_exhausted(&self) -> bool {
        self.time_budget_exceeded || self.entry_cap_exceeded
    }

    /// Records one visited directory entry (pushed to the response or not)
    /// and reports whether the walk must stop now.
    fn record_visit(&mut self) -> bool {
        self.entries_visited += 1;
        if self.entries_visited as usize >= self.entry_cap {
            self.entry_cap_exceeded = true;
        }
        if Instant::now() >= self.deadline {
            self.time_budget_exceeded = true;
        }
        self.is_exhausted()
    }
}

fn collect_workspace_entries(
    root: &Path,
    deadline: Instant,
    entry_cap: usize,
) -> (Vec<WorkspaceEntry>, bool, WorkspaceWalkBudget) {
    let mut entries = Vec::new();
    let mut truncated = false;
    let mut budget = WorkspaceWalkBudget::new(deadline, entry_cap);
    walk_workspace_directory(root, None, 0, &mut entries, &mut truncated, &mut budget);
    // DFS pre-order emits `x/child` between prefix-named siblings `x` and
    // `x-y` ('-' sorts below '/'), while the bounded operator projections
    // require strict global byte order over relative paths.
    entries.sort_by(|left, right| left.relative_path.as_utf8().cmp(&right.relative_path.as_utf8()));
    (entries, truncated, budget)
}

/// Builds the additive `WorkspaceInspectionTruncationV1` for an
/// `inspect_workspace` response — `None` once the walk and git phase both
/// completed inside their shared budget.
fn workspace_inspection_truncation(
    walk_budget: &WorkspaceWalkBudget,
    git_time_budget_exceeded: bool,
    elapsed: Duration,
) -> Option<WorkspaceInspectionTruncationV1> {
    if !walk_budget.time_budget_exceeded
        && !walk_budget.entry_cap_exceeded
        && !git_time_budget_exceeded
    {
        return None;
    }
    Some(WorkspaceInspectionTruncationV1 {
        walk_time_budget_exceeded: walk_budget.time_budget_exceeded,
        walk_entry_cap_exceeded: walk_budget.entry_cap_exceeded,
        git_time_budget_exceeded,
        entries_visited: walk_budget.entries_visited,
        elapsed_ms: u64::try_from(elapsed.as_millis()).unwrap_or(u64::MAX),
    })
}

fn walk_workspace_directory(
    directory: &Path,
    relative_directory: Option<&RepositoryPath>,
    depth: usize,
    entries: &mut Vec<WorkspaceEntry>,
    truncated: &mut bool,
    budget: &mut WorkspaceWalkBudget,
) {
    if budget.is_exhausted() {
        *truncated = true;
        return;
    }
    let read_dir = match std::fs::read_dir(directory) {
        Ok(read_dir) => read_dir,
        Err(_) => {
            *truncated = true;
            return;
        }
    };
    let mut children = Vec::new();
    for child in read_dir {
        match child {
            Ok(child) => children.push(child),
            Err(_) => *truncated = true,
        }
    }
    children.sort_by_key(|child| child.file_name());
    for child in children {
        if budget.record_visit() {
            *truncated = true;
            return;
        }
        if entries.len() >= WORKSPACE_TREE_MAX_ENTRIES {
            *truncated = true;
            return;
        }
        let file_type = match child.file_type() {
            Ok(file_type) => file_type,
            Err(_) => {
                *truncated = true;
                continue;
            }
        };
        if file_type.is_symlink() {
            continue;
        }
        let name = match child.file_name().into_string() {
            Ok(name) => name,
            Err(_) => {
                *truncated = true;
                continue;
            }
        };
        if file_type.is_dir() && is_skipped_workspace_directory(&name, &child.path()) {
            continue;
        }
        let relative_path = match relative_directory {
            None => windows_repository_path(name),
            Some(parent) => parent
                .as_utf8()
                .and_then(|parent| windows_repository_path(format!("{parent}/{name}"))),
        };
        let Some(relative_path) = relative_path else {
            *truncated = true;
            continue;
        };
        let kind = if file_type.is_dir() {
            WorkspaceEntryKind::Directory
        } else if file_type.is_file() {
            WorkspaceEntryKind::File
        } else {
            continue;
        };
        entries.push(WorkspaceEntry {
            relative_path: relative_path.clone(),
            kind,
        });
        if file_type.is_dir() {
            if depth + 1 < WORKSPACE_TREE_MAX_DEPTH {
                walk_workspace_directory(
                    &child.path(),
                    Some(&relative_path),
                    depth + 1,
                    entries,
                    truncated,
                    budget,
                );
            } else {
                *truncated = true;
            }
        }
    }
}

fn windows_repository_path(value: String) -> Option<RepositoryPath> {
    if value.contains('\\') {
        return None;
    }
    RepositoryPath::utf8(value).ok()
}

fn windows_repository_path_from_bytes(value: &[u8]) -> Option<RepositoryPath> {
    windows_repository_path(std::str::from_utf8(value).ok()?.to_owned())
}

/// Excludes a directory from the workspace tree walk. The three literal
/// names are the common convention-based cases; the `CACHEDIR.TAG` check
/// beneath them catches every build-output directory regardless of name
/// (cargo writes `CACHEDIR.TAG` into every `--target-dir` it creates, so
/// this covers `target-a2`, `target-a2-tui`, and any future renamed build
/// directory without maintaining a name heuristic list). The name check
/// runs first and returns early so a directory rejected by name never pays
/// for the extra `CACHEDIR.TAG` stat.
fn is_skipped_workspace_directory(name: &str, path: &Path) -> bool {
    if name.eq_ignore_ascii_case(".git")
        || name.eq_ignore_ascii_case("target")
        || name.eq_ignore_ascii_case("node_modules")
    {
        return true;
    }
    path.join("CACHEDIR.TAG").is_file()
}

fn context_pack_source_status_is_usable(status: &SessionStatus) -> bool {
    matches!(
        status,
        SessionStatus::Running | SessionStatus::Exited { exit_code: Some(0) }
    )
}

#[derive(Clone, Debug, Eq, PartialEq)]
enum ContextPackRepositoryHead {
    NotRepository,
    Unborn,
    Commit(String),
}

#[derive(Clone, Debug, Eq, PartialEq)]
struct ContextPackRepositoryObservation {
    head: ContextPackRepositoryHead,
    git: GitSnapshot,
    files: Vec<ContextPackRepositoryFileSource>,
}

fn stable_context_pack_repository(
    first: ContextPackRepositoryObservation,
    second: ContextPackRepositoryObservation,
) -> Result<ContextPackRepository, NodeFailure> {
    if first != second {
        return Err(failure(
            NodeFailureCode::ContextPackMaterializationFailed,
            "context repository changed during bounded capture",
        ));
    }
    Ok(ContextPackRepository::from_sources(
        &second.git,
        second.files,
    ))
}

/// Appends a "skipped: budget exhausted" diagnostic and returns `true` once
/// (and only once) the shared walk+git `deadline` has already passed. Every
/// remaining phase in `inspect_git_workspace` checks this immediately
/// before issuing its own git call, so a budget spent by the walk (or by an
/// earlier git call) skips the rest of the chain instead of paying for it
/// anyway.
fn git_budget_exhausted(snapshot: &mut GitSnapshot, deadline: Instant, stage: &str) -> bool {
    if Instant::now() < deadline {
        return false;
    }
    append_git_diagnostic(
        snapshot,
        &format!("{stage} skipped: workspace inspection time budget exhausted"),
    );
    true
}

/// Deadline-aware sibling of `run_git_bounded`, used only by
/// `inspect_git_workspace`'s six-call chain: caps the per-call timeout to
/// whatever remains of the shared `deadline` (never more than
/// `GIT_COMMAND_TIMEOUT_MS`), so a slow walk phase that already spent most
/// of the budget cannot still hand a full per-call timeout to every git
/// probe behind it. `inspect_git_workspace` already guards each call site
/// with `git_budget_exhausted`, so `deadline` is guaranteed not to have
/// passed yet here.
async fn run_git_bounded_with_deadline(
    root: &str,
    arguments: &[&str],
    output_limit: usize,
    deadline: Instant,
) -> io::Result<GitCommandOutput> {
    let remaining = deadline.checked_duration_since(Instant::now());
    let timeout_ms = remaining
        .and_then(|remaining| u64::try_from(remaining.as_millis()).ok())
        .unwrap_or(0)
        .clamp(1, GIT_COMMAND_TIMEOUT_MS);
    run_git_read_bounded(root, arguments, output_limit, timeout_ms).await
}

/// Runs the bounded six-call git probe chain used by `inspect_workspace`.
/// `deadline` is the same absolute instant the preceding directory walk was
/// bounded by, so time already spent walking counts against what remains
/// for git enrichment. Returns the resulting `GitSnapshot` plus whether the
/// shared budget (not an individual per-call timeout) is what cut the git
/// phase short.
async fn inspect_git_workspace(root: &str, deadline: Instant) -> (GitSnapshot, bool) {
    let mut snapshot = GitSnapshot {
        is_repository: false,
        branch: None,
        status: Vec::new(),
        recent_commits: Vec::new(),
        worktrees: Vec::new(),
        managed_worktree: None,
        truncated: false,
        diagnostic: None,
    };
    if git_budget_exhausted(&mut snapshot, deadline, "git repository probe") {
        return (snapshot, true);
    }
    let repository = match run_git_bounded_with_deadline(
        root,
        &["rev-parse", "--is-inside-work-tree"],
        4 * 1_024,
        deadline,
    )
    .await
    {
        Ok(output) => output,
        Err(error) => {
            append_git_diagnostic(
                &mut snapshot,
                &format!("git inspection unavailable: {error}"),
            );
            return (snapshot, false);
        }
    };
    snapshot.truncated |= repository.truncated;
    if repository.timed_out {
        append_git_diagnostic(&mut snapshot, "git repository probe timed out");
        return (snapshot, false);
    }
    if !repository.success
        || String::from_utf8_lossy(&repository.stdout).trim() != "true"
    {
        let stderr = String::from_utf8_lossy(&repository.stderr);
        if !stderr.to_ascii_lowercase().contains("not a git repository") {
            append_git_diagnostic(&mut snapshot, stderr.trim());
        }
        return (snapshot, false);
    }
    snapshot.is_repository = true;

    if git_budget_exhausted(&mut snapshot, deadline, "git branch query") {
        return (snapshot, true);
    }
    match run_git_bounded_with_deadline(root, &["branch", "--show-current"], 4 * 1_024, deadline).await {
        Ok(output) => {
            snapshot.truncated |= output.truncated;
            if output.timed_out {
                append_git_diagnostic(&mut snapshot, "git branch query timed out");
            } else if output.success {
                let branch = String::from_utf8_lossy(&output.stdout).trim().to_owned();
                if !branch.is_empty() {
                    snapshot.branch = Some(truncate_git_field(
                        &branch,
                        MAX_REPOSITORY_PATH_BYTES,
                        &mut snapshot.truncated,
                    ));
                }
            }
        }
        Err(error) => append_git_diagnostic(
            &mut snapshot,
            &format!("git branch query failed: {error}"),
        ),
    }
    if snapshot.branch.is_none() && !git_budget_exhausted(&mut snapshot, deadline, "git detached-HEAD probe") {
        if let Ok(output) = run_git_bounded_with_deadline(root, &["rev-parse", "--short", "HEAD"], 4 * 1_024, deadline).await {
            snapshot.truncated |= output.truncated;
            if output.success && !output.timed_out {
                let head = String::from_utf8_lossy(&output.stdout).trim().to_owned();
                if !head.is_empty() {
                    snapshot.branch = Some(format!("detached:{head}"));
                }
            }
        }
    }

    if git_budget_exhausted(&mut snapshot, deadline, "git status") {
        return (snapshot, true);
    }
    match run_git_bounded_with_deadline(
        root,
        &[
            "status",
            "--porcelain=v1",
            "-z",
            "--renames",
            "--untracked-files=normal",
            "--",
            ".",
        ],
        GIT_OUTPUT_MAX_BYTES,
        deadline,
    )
    .await
    {
        Ok(output) => {
            snapshot.truncated |= output.truncated;
            if output.timed_out {
                append_git_diagnostic(&mut snapshot, "git status timed out");
            } else if output.success {
                parse_git_status(&output.stdout, &mut snapshot);
            } else {
                append_git_diagnostic(
                    &mut snapshot,
                    String::from_utf8_lossy(&output.stderr).trim(),
                );
            }
        }
        Err(error) => append_git_diagnostic(
            &mut snapshot,
            &format!("git status failed: {error}"),
        ),
    }

    if git_budget_exhausted(&mut snapshot, deadline, "git log") {
        return (snapshot, true);
    }
    let log_limit = (GIT_COMMIT_MAX_ENTRIES + 1).to_string();
    match run_git_bounded_with_deadline(
        root,
        &["log", "-n", &log_limit, "--pretty=format:%H%x1f%s", "--", "."],
        16 * 1_024,
        deadline,
    )
    .await
    {
        Ok(output) => {
            snapshot.truncated |= output.truncated;
            if output.timed_out {
                append_git_diagnostic(&mut snapshot, "git log timed out");
            } else if output.success {
                parse_git_commits(&output.stdout, &mut snapshot);
            } else {
                let stderr = String::from_utf8_lossy(&output.stderr);
                if !stderr.to_ascii_lowercase().contains("does not have any commits") {
                    append_git_diagnostic(&mut snapshot, stderr.trim());
                }
            }
        }
        Err(error) => append_git_diagnostic(
            &mut snapshot,
            &format!("git log failed: {error}"),
        ),
    }

    if git_budget_exhausted(&mut snapshot, deadline, "git worktree list") {
        return (snapshot, true);
    }
    match list_git_worktrees_with_deadline(root, deadline).await {
        Ok(worktrees) => {
            snapshot.worktrees = worktrees.into_iter().map(protocol_worktree).collect()
        }
        Err(error) => append_git_diagnostic(
            &mut snapshot,
            &format!("git worktree list failed: {}", error.message),
        ),
    }
    (snapshot, false)
}

fn parse_git_status(output: &[u8], snapshot: &mut GitSnapshot) {
    let mut remaining = output;
    while !remaining.is_empty() {
        if snapshot.status.len() >= GIT_STATUS_MAX_ENTRIES {
            snapshot.truncated = true;
            break;
        }
        let Some(record_end) = remaining.iter().position(|byte| *byte == 0) else {
            snapshot.truncated = true;
            break;
        };
        let record = &remaining[..record_end];
        remaining = &remaining[record_end + 1..];
        let has_previous_path = record
            .get(..2)
            .is_some_and(|status| status.iter().any(|byte| matches!(*byte, b'R' | b'C')));
        let previous_path_bytes = if has_previous_path {
            let Some(previous_end) = remaining.iter().position(|byte| *byte == 0) else {
                snapshot.truncated = true;
                break;
            };
            let previous = &remaining[..previous_end];
            remaining = &remaining[previous_end + 1..];
            Some(previous)
        } else {
            None
        };
        if record.len() < 4
            || record[2] != b' '
            || !is_git_status_code(record[0])
            || !is_git_status_code(record[1])
        {
            snapshot.truncated = true;
            continue;
        }
        let Some(path) = windows_repository_path_from_bytes(&record[3..]) else {
            snapshot.truncated = true;
            continue;
        };
        let previous_path = match previous_path_bytes {
            Some(previous) => {
                let Some(previous) = windows_repository_path_from_bytes(previous) else {
                    snapshot.truncated = true;
                    continue;
                };
                Some(previous)
            }
            None => None,
        };
        snapshot.status.push(GitStatusEntry {
            index_status: (record[0] as char).to_string(),
            worktree_status: (record[1] as char).to_string(),
            path,
            previous_path,
        });
    }
}

fn is_git_status_code(byte: u8) -> bool {
    matches!(byte, b' ' | b'M' | b'T' | b'A' | b'D' | b'R' | b'C' | b'U' | b'?' | b'!')
}

fn parse_git_commits(output: &[u8], snapshot: &mut GitSnapshot) {
    for line in String::from_utf8_lossy(output).lines() {
        let Some((id, summary)) = line.split_once('\u{1f}') else {
            continue;
        };
        if snapshot.recent_commits.len() >= GIT_COMMIT_MAX_ENTRIES {
            snapshot.truncated = true;
            break;
        }
        let id = truncate_git_field(id, 64, &mut snapshot.truncated);
        let summary = truncate_git_field(summary, 512, &mut snapshot.truncated);
        snapshot.recent_commits.push(GitCommitSummary { id, summary });
    }
}

fn truncate_git_field(value: &str, max_bytes: usize, truncated: &mut bool) -> String {
    if value.len() <= max_bytes {
        return value.to_owned();
    }
    *truncated = true;
    let mut boundary = max_bytes;
    while boundary > 0 && !value.is_char_boundary(boundary) {
        boundary -= 1;
    }
    value[..boundary].to_owned()
}

fn append_git_diagnostic(snapshot: &mut GitSnapshot, message: &str) {
    if message.is_empty() {
        return;
    }
    let normalized = message
        .chars()
        .map(|character| if character.is_control() { ' ' } else { character })
        .collect::<String>();
    let mut diagnostic = snapshot.diagnostic.take().unwrap_or_default();
    if !diagnostic.is_empty() {
        diagnostic.push_str("; ");
    }
    diagnostic.push_str(normalized.trim());
    snapshot.diagnostic = Some(truncate_git_field(
        &diagnostic,
        GIT_DIAGNOSTIC_MAX_BYTES,
        &mut snapshot.truncated,
    ));
}

async fn run_git_bounded(
    root: &str,
    arguments: &[&str],
    output_limit: usize,
) -> io::Result<GitCommandOutput> {
    run_git_read_bounded(root, arguments, output_limit, GIT_COMMAND_TIMEOUT_MS).await
}

async fn read_git_history_bounded(
    root: &str,
    path: Option<&RepositoryPath>,
    before: Option<&GitObjectId>,
    limit: u16,
) -> Result<GitHistoryPage, NodeFailure> {
    let path = path
        .map(|path| {
            path.as_utf8().ok_or_else(|| {
                failure(
                    NodeFailureCode::InvalidRepositoryPath,
                    "git history path must use UTF-8",
                )
            })
        })
        .transpose()?
        .unwrap_or(".");
    let count = (usize::from(limit) + 1).to_string();
    let start = before
        .map(|revision| format!("{}^", revision.as_str()))
        .unwrap_or_else(|| "HEAD".to_owned());
    let arguments = [
        "--no-pager",
        "log",
        "--no-decorate",
        "--date=iso-strict",
        "--pretty=format:%H%x1f%P%x1f%s%x1f%an%x1f%ae%x1f%aI%x1f%cn%x1f%ce%x1f%cI%x1e",
        "-n",
        count.as_str(),
        start.as_str(),
        "--",
        path,
    ];
    let output = run_git_bounded(root, &arguments, 256 * 1_024)
        .await
        .map_err(|_| failure(NodeFailureCode::GitReadFailed, "git history command failed"))?;
    if output.timed_out {
        return Err(failure(NodeFailureCode::GitReadTimedOut, "git history exceeded its bounded deadline"));
    }
    if !output.success {
        return Err(failure(NodeFailureCode::GitReadFailed, "git history could not be read"));
    }
    let mut commits = parse_git_history(&output.stdout);
    let has_more = commits.len() > usize::from(limit) || output.truncated;
    commits.truncate(usize::from(limit));
    let next_before = has_more.then(|| commits.last().map(|commit| commit.id.clone())).flatten();
    Ok(GitHistoryPage { commits, next_before, truncated: output.truncated })
}

fn parse_git_history(output: &[u8]) -> Vec<GitCommitDetails> {
    String::from_utf8_lossy(output)
        .split('\u{1e}')
        .filter_map(|record| {
            let fields = record.trim_matches(['\r', '\n']).split('\u{1f}').collect::<Vec<_>>();
            if fields.len() != 9 {
                return None;
            }
            let id = GitObjectId::new(fields[0].to_owned()).ok()?;
            let parents = if fields[1].is_empty() {
                Vec::new()
            } else {
                fields[1]
                    .split(' ')
                    .map(|value| GitObjectId::new(value.to_owned()))
                    .collect::<Result<Vec<_>, _>>()
                    .ok()?
            };
            Some(GitCommitDetails {
                id,
                parents,
                subject: bounded_git_text(fields[2], 512),
                author_name: bounded_git_text(fields[3], 256),
                author_email: bounded_git_text(fields[4], 320),
                authored_at: bounded_git_text(fields[5], 64),
                committer_name: bounded_git_text(fields[6], 256),
                committer_email: bounded_git_text(fields[7], 320),
                committed_at: bounded_git_text(fields[8], 64),
                signature_status: GitSignatureStatus::NoSignature,
                signer: None,
            })
        })
        .take(usize::from(MAX_GIT_HISTORY_COMMITS) + 1)
        .collect()
}

fn bounded_git_text(value: &str, max_bytes: usize) -> String {
    let normalized = value
        .chars()
        .map(|character| if character.is_control() { ' ' } else { character })
        .collect::<String>();
    if normalized.len() <= max_bytes {
        return normalized;
    }
    let mut boundary = max_bytes;
    while boundary > 0 && !normalized.is_char_boundary(boundary) {
        boundary -= 1;
    }
    normalized[..boundary].to_owned()
}

async fn read_git_diff_bounded(root: &str, request: GitDiffRequest) -> Result<GitDiff, NodeFailure> {
    let path = request.path.as_ref().map(|path| {
        path.as_utf8()
            .ok_or_else(|| failure(NodeFailureCode::InvalidRepositoryPath, "git diff path must use UTF-8"))
    }).transpose()?;
    let mut arguments = match &request.mode {
        GitDiffMode::Working => vec!["--no-pager", "-c", "diff.external=", "diff", "--no-ext-diff", "--no-textconv"],
        GitDiffMode::Staged => vec!["--no-pager", "-c", "diff.external=", "diff", "--cached", "--no-ext-diff", "--no-textconv"],
        GitDiffMode::Commit { .. } => vec!["--no-pager", "-c", "diff.external=", "show", "--format=fuller", "--no-ext-diff", "--no-textconv"],
    };
    if let GitDiffMode::Commit { revision } = &request.mode {
        arguments.push(revision.as_str());
    }
    arguments.push("--");
    if let Some(path) = path {
        arguments.push(path);
    }
    let output = run_git_bounded(root, &arguments, MAX_GIT_DIFF_BYTES)
        .await
        .map_err(|_| failure(NodeFailureCode::GitReadFailed, "git diff command failed"))?;
    if output.timed_out {
        return Err(failure(NodeFailureCode::GitReadTimedOut, "git diff exceeded its bounded deadline"));
    }
    if !output.success {
        return Err(failure(NodeFailureCode::GitReadFailed, "git diff could not be read"));
    }
    Ok(GitDiff {
        mode: request.mode,
        path: request.path,
        text: String::from_utf8_lossy(&output.stdout).into_owned(),
        truncated: output.truncated,
    })
}

async fn process_request(shared: &NodeShared, connection_id: u64, role: ClientRole, envelope: RequestEnvelope) -> ResponseEnvelope {
    let result = process_request_inner(shared, connection_id, role, envelope.request).await;
    ResponseEnvelope { request_id: envelope.request_id, result }
}

async fn process_request_inner(shared: &NodeShared, connection_id: u64, role: ClientRole, request: NodeRequest) -> Result<NodeResponse, NodeFailure> {
    if !request.harness_mcp_contract_is_valid_at(unix_time_ms()) {
        return Err(failure(NodeFailureCode::InvalidRequest, "harness MCP request is invalid or stale"));
    }
    let read_only = matches!(
        &request,
        NodeRequest::Snapshot
            | NodeRequest::Resync { .. }
            | NodeRequest::BrowseHostDirectories { .. }
            | NodeRequest::InspectWorkspace { .. }
            | NodeRequest::ReadWorkspaceFile { .. }
            | NodeRequest::ReadGitHistory { .. }
            | NodeRequest::ReadGitDiff { .. }
            | NodeRequest::CatalogNativeSessions { .. }
            | NodeRequest::PageNativeSessions { .. }
            | NodeRequest::PreviewNativeSession { .. }
            | NodeRequest::PreviewSessionRecord { .. }
    );
    let _mutation_guard = if read_only {
        None
    } else {
        let guard = shared.mutation_gate.lock().await;
        if shared.shutdown.load(Ordering::Acquire) {
            return Err(failure(NodeFailureCode::ShuttingDown, "node shutdown has begun"));
        }
        Some(guard)
    };
    match request {
        NodeRequest::Snapshot => Ok(NodeResponse::Snapshot {
            event_sequence: shared.current_sequence(),
            controller: shared.controller_state(),
            snapshot: shared.snapshot(),
        }),
        NodeRequest::Resync { after_sequence } => Ok(shared.resync(after_sequence)),
        NodeRequest::ArmHarnessMcpReservation {
            reservation_id,
            activation_digest,
            spawn_spec,
            launch,
            expires_at_unix_ms,
        } => {
            shared.require_controller(connection_id, role)?;
            let registry = shared.harness_mcp_registry.as_ref().ok_or_else(|| {
                failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP proxy is not configured")
            })?;
            let expires_at_unix_ms = registry
                .arm(reservation_id.clone(), activation_digest.clone(), spawn_spec, launch, expires_at_unix_ms)
                .await
                .map_err(harness_mcp_failure)?;
            Ok(NodeResponse::Armed { reservation_id, activation_digest, expires_at_unix_ms })
        }
        NodeRequest::SpawnSpecWithHarnessMcp {
            reservation_id,
            activation_digest,
            spec,
            deadline_unix_ms,
        } => {
            shared.require_controller(connection_id, role)?;
            let receipt = shared
                .spawn_from_spec_with_harness_mcp(
                    reservation_id.clone(), activation_digest.clone(), spec, deadline_unix_ms,
                )
                .await?;
            Ok(NodeResponse::Spawned { reservation_id, activation_digest, receipt })
        }
        NodeRequest::ActivateHarnessMcpReservation {
            reservation_id,
            activation_digest,
            record_id,
            session,
        } => {
            shared.require_controller(connection_id, role)?;
            let provider_root_pid = shared.handle.snapshot().sessions.iter().find(|current| {
                current.instance_id == session.session.instance_id
                    && current.generation == session.session.generation
            }).and_then(|current| current.process_id).ok_or_else(|| {
                failure(NodeFailureCode::BindingMismatch, "provider root process is unavailable")
            })?;
            shared.harness_mcp_registry.as_ref().ok_or_else(|| {
                failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP proxy is not configured")
            })?.activate(
                &reservation_id, &activation_digest, &record_id, &session, provider_root_pid,
            ).map_err(harness_mcp_failure)?;
            Ok(NodeResponse::Activated { reservation_id, activation_digest, record_id, session })
        }
        NodeRequest::AbortHarnessMcpReservation { reservation_id, activation_digest } => {
            shared.require_controller(connection_id, role)?;
            let instance_id = shared.harness_mcp_registry.as_ref().ok_or_else(|| {
                failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP proxy is not configured")
            })?.abort(&reservation_id, &activation_digest).map_err(harness_mcp_failure)?;
            if let Some(instance_id) = instance_id {
                SessionLifecycleHook::on_harness_reservation_aborted(&*shared, instance_id);
            }
            Ok(NodeResponse::Aborted { reservation_id, activation_digest })
        }
        NodeRequest::PutHarnessMcpReplyChunk {
            reservation_id, activation_digest, record_id, session, call_id,
            offset, final_chunk, chunk_hex,
        } => {
            shared.require_controller(connection_id, role)?;
            let (next_offset, completed) = shared.harness_mcp_registry.as_ref().ok_or_else(|| {
                failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP proxy is not configured")
            })?.put_reply_chunk(
                &reservation_id, &activation_digest, &record_id, &session, &call_id,
                offset, final_chunk, &chunk_hex,
            ).map_err(harness_mcp_failure)?;
            Ok(NodeResponse::ReplyChunkAccepted {
                reservation_id, activation_digest, record_id, session, call_id,
                next_offset, completed,
            })
        }
        NodeRequest::RejectHarnessMcpCall {
            reservation_id, activation_digest, record_id, session, call_id, reason,
        } => {
            shared.require_controller(connection_id, role)?;
            shared.harness_mcp_registry.as_ref().ok_or_else(|| {
                failure(NodeFailureCode::HarnessMcpUnavailable, "harness MCP proxy is not configured")
            })?.reject_call(
                &reservation_id, &activation_digest, &record_id, &session, &call_id, reason,
            ).map_err(harness_mcp_failure)?;
            Ok(NodeResponse::CallRejected {
                reservation_id, activation_digest, record_id, session, call_id,
            })
        }
        NodeRequest::BeginDeliveryStage { manifest } => {
            shared.require_controller(connection_id, role)?;
            shared.begin_delivery_stage(manifest)
        }
        NodeRequest::PutDeliveryBlobChunk {
            stage_id,
            blob_digest,
            offset,
            chunk_hex,
        } => {
            shared.require_controller(connection_id, role)?;
            shared.put_delivery_blob_chunk(stage_id, blob_digest, offset, chunk_hex)
        }
        NodeRequest::CommitDeliveryStage { stage_id } => {
            shared.require_controller(connection_id, role)?;
            let receipt = shared.commit_delivery_stage(stage_id)?;
            Ok(NodeResponse::DeliveryCommitted { receipt })
        }
        NodeRequest::AbortDeliveryStage { stage_id } => {
            shared.require_controller(connection_id, role)?;
            shared.abort_delivery_stage(&stage_id)?;
            Ok(NodeResponse::DeliveryStageAborted { stage_id })
        }
        NodeRequest::BrowseHostDirectories { directory, after } => {
            let listing = shared.browse_host_directories(directory, after).await?;
            Ok(NodeResponse::HostDirectoriesBrowsed { listing })
        }
        NodeRequest::InspectWorkspace { workspace_id } => {
            let inspection = shared.inspect_workspace(workspace_id).await?;
            Ok(NodeResponse::WorkspaceInspected { inspection })
        }
        NodeRequest::ReadWorkspaceFile { workspace_id, path } => {
            let file = shared.read_workspace_file(workspace_id, path).await?;
            Ok(NodeResponse::WorkspaceFileRead { file })
        }
        NodeRequest::WriteWorkspaceFile { workspace_id, path, expected_revision, text } => {
            shared.require_controller(connection_id, role)?;
            let file = shared
                .write_workspace_file(workspace_id, path, expected_revision, text)
                .await?;
            Ok(NodeResponse::WorkspaceFileWritten { file })
        }
        NodeRequest::CreateWorkspaceFile { workspace_id, path } => {
            shared.require_controller(connection_id, role)?;
            let file = shared.create_workspace_file(workspace_id, path).await?;
            Ok(NodeResponse::WorkspaceFileCreated { file })
        }
        NodeRequest::CreateWorkspaceDirectory { workspace_id, path } => {
            shared.require_controller(connection_id, role)?;
            let entry = shared
                .create_workspace_directory(workspace_id.clone(), path)
                .await?;
            Ok(NodeResponse::WorkspaceDirectoryCreated { workspace_id, entry })
        }
        NodeRequest::ReadGitHistory { workspace_id, path, before, limit } => {
            if role != ClientRole::Operator {
                return Err(failure(NodeFailureCode::ObserverReadOnly, "git history requires an operator connection"));
            }
            if !(1..=MAX_GIT_HISTORY_COMMITS).contains(&limit) {
                return Err(failure(NodeFailureCode::InvalidRequest, "git history limit is invalid"));
            }
            let page = shared
                .read_git_history(workspace_id.clone(), path, before, limit)
                .await?;
            Ok(NodeResponse::GitHistoryRead { workspace_id, page })
        }
        NodeRequest::ReadGitDiff { workspace_id, request } => {
            if role != ClientRole::Operator {
                return Err(failure(NodeFailureCode::ObserverReadOnly, "git diff requires an operator connection"));
            }
            let diff = shared.read_git_diff(workspace_id.clone(), request).await?;
            Ok(NodeResponse::GitDiffRead { workspace_id, diff })
        }
        NodeRequest::CatalogNativeSessions { route, limit } => {
            if role != ClientRole::Operator {
                return Err(failure(
                    NodeFailureCode::ObserverReadOnly,
                    "native session catalog requires an operator connection",
                ));
            }
            if !(1..=gate4agent_types::NATIVE_SESSION_CATALOG_LIMIT_MAX).contains(&limit) {
                return Err(failure(
                    NodeFailureCode::InvalidRequest,
                    "native session catalog limit is invalid",
                ));
            }
            let (entries, summary) = shared
                .catalog_native_sessions(route.clone(), limit)
                .await?;
            Ok(NodeResponse::NativeSessionsCataloged {
                route,
                entries,
                summary: Some(summary),
            })
        }
        NodeRequest::PageNativeSessions {
            route,
            window,
            catalog_revision,
            recent_cutoff_unix_ms,
            after_selection_id,
            limit,
        } => {
            if role != ClientRole::Operator {
                return Err(failure(
                    NodeFailureCode::ObserverReadOnly,
                    "native session catalog paging requires an operator connection",
                ));
            }
            if !(1..=gate4agent_types::NATIVE_SESSION_CATALOG_LIMIT_MAX).contains(&limit)
                || after_selection_id
                    .as_deref()
                    .is_some_and(|cursor| validate_candidate_id(cursor).is_err())
            {
                return Err(failure(
                    NodeFailureCode::InvalidRequest,
                    "native session catalog page request is invalid",
                ));
            }
            let page = shared
                .page_native_sessions(
                    route.clone(),
                    window,
                    catalog_revision,
                    recent_cutoff_unix_ms,
                    after_selection_id,
                    limit,
                )
                .await?;
            Ok(NodeResponse::NativeSessionsPaged {
                route,
                page,
            })
        }
        NodeRequest::PreviewNativeSession {
            selection,
            message_limit,
        } => {
            if role != ClientRole::Operator {
                return Err(failure(
                    NodeFailureCode::ObserverReadOnly,
                    "native session preview requires an operator connection",
                ));
            }
            if !(1..=gate4agent_types::NATIVE_SESSION_PREVIEW_MESSAGE_LIMIT_MAX)
                .contains(&message_limit)
                || selection.validate().is_err()
            {
                return Err(failure(
                    NodeFailureCode::InvalidRequest,
                    "native session preview request is invalid",
                ));
            }
            let preview = shared
                .preview_native_session(selection.clone(), message_limit)
                .await?;
            Ok(NodeResponse::NativeSessionPreviewed {
                selection,
                preview,
            })
        }
        NodeRequest::IndexNativeSession {
            selection,
            display_name,
        } => {
            shared.require_controller(connection_id, role)?;
            let record = shared
                .index_native_session(selection.clone(), display_name)
                .await?;
            Ok(NodeResponse::NativeSessionIndexed { selection, record })
        }
        NodeRequest::PreviewSessionRecord {
            record_id,
            message_limit,
        } => {
            if role != ClientRole::Operator {
                return Err(failure(
                    NodeFailureCode::ObserverReadOnly,
                    "native session preview requires an operator connection",
                ));
            }
            if !(1..=gate4agent_types::NATIVE_SESSION_PREVIEW_MESSAGE_LIMIT_MAX)
                .contains(&message_limit)
            {
                return Err(failure(
                    NodeFailureCode::InvalidRequest,
                    "native session preview request is invalid",
                ));
            }
            let record = shared.record(&record_id)?;
            let working_directory = shared.workspace_root(&record.workspace_id)?;
            if !platform::roots_equal(
                &working_directory,
                windows_path_text(&record.canonical_root),
            ) {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "managed session workspace root changed; refusing to preview another directory",
                ));
            }
            let identity = record.provider_session.clone().ok_or_else(|| {
                failure(
                    NodeFailureCode::BackendOperationFailed,
                    "native session preview is unavailable for this session record",
                )
            })?;
            if identity.key != ProviderSessionKey::SessionId {
                return Err(failure(
                    NodeFailureCode::BackendOperationFailed,
                    "native session preview is unavailable for this session identity",
                ));
            }
            let preview = shared
                .preview_native_session_by_session_id(
                    record.workspace_id.clone(), record.provider.clone(), identity.id.clone(), message_limit,
                )
                .await?;
            if preview.session_id != identity.id {
                return Err(failure(
                    NodeFailureCode::SessionRecordConflict,
                    "native session preview identity changed while loading",
                ));
            }
            shared.revalidate_session_record_preview(&record, &identity)?;
            let preview: gate4agent_types::SessionRecordPreview = preview.into();
            shared.publish(NodeEvent::SessionRecordHistorySummarized {
                record_id: record_id.clone(),
                summary: SessionHistorySummaryV1::from(&preview),
            });
            Ok(NodeResponse::SessionRecordPreviewed {
                record_id,
                preview,
            })
        }
        NodeRequest::AcquireController { lease_ms } => {
            let controller = shared.acquire_controller(connection_id, role, lease_ms)?;
            Ok(NodeResponse::Controller { controller: Some(controller) })
        }
        NodeRequest::ReleaseController => {
            shared.release_controller(connection_id);
            Ok(NodeResponse::Controller { controller: shared.controller_state() })
        }
        NodeRequest::RegisterWorkspace { workspace_id, root } => {
            shared.require_controller(connection_id, role)?;
            let root = require_windows_path(root)?;
            shared.reject_managed_reservation(Some(&workspace_id), Some(&root))?;
            let workspace = shared.register_workspace(workspace_id, root).await?;
            Ok(NodeResponse::WorkspaceRegistered { workspace })
        }
        NodeRequest::CreateStandaloneWorkspace {
            workspace_id,
            root,
            initial_branch,
        } => {
            shared.require_controller(connection_id, role)?;
            let root = require_windows_path(root)?;
            shared.reject_managed_reservation(Some(&workspace_id), Some(&root))?;
            let workspace = shared
                .create_standalone_workspace(workspace_id, root, initial_branch)
                .await?;
            Ok(NodeResponse::StandaloneWorkspaceCreated { workspace })
        }
        NodeRequest::UnregisterWorkspace { workspace_id } => {
            shared.require_controller(connection_id, role)?;
            shared.reject_managed_reservation(Some(&workspace_id), None)?;
            shared.unregister_workspace(&workspace_id)?;
            Ok(NodeResponse::WorkspaceUnregistered { workspace_id })
        }
        NodeRequest::CreateWorktree {
            source_workspace_id,
            workspace_id,
            target_root,
            branch,
            base,
        } => {
            shared.require_controller(connection_id, role)?;
            let target_root = require_windows_path(target_root)?;
            shared.reject_managed_reservation(Some(&workspace_id), Some(&target_root))?;
            let (worktree, workspace) = shared
                .create_worktree(
                    source_workspace_id,
                    workspace_id,
                    target_root,
                    branch,
                    base,
                )
                .await?;
            Ok(NodeResponse::WorktreeCreated { worktree, workspace })
        }
        NodeRequest::RemoveWorktree {
            source_workspace_id,
            target_root,
        } => {
            shared.require_controller(connection_id, role)?;
            let native_target_root = require_windows_path(target_root.clone())?;
            shared.reject_managed_reservation(None, Some(&native_target_root))?;
            let workspace_id = shared
                .remove_worktree(source_workspace_id, native_target_root)
                .await?;
            Ok(NodeResponse::WorktreeRemoved {
                target_root,
                workspace_id,
            })
        }
        NodeRequest::Spawn { workspace_id, provider, mode, terminal_size, initial_prompt } => {
            shared.require_controller(connection_id, role)?;
            if !terminal_size.is_valid() {
                return Err(failure(NodeFailureCode::InvalidRequest, "spawn requires a valid terminal size"));
            }
            if let Some(prompt) = initial_prompt.as_deref() {
                validate_node_text("spawn initial prompt", prompt)?;
            }
            match shared
                .spawn_session(workspace_id.clone(), provider.clone(), mode, terminal_size, initial_prompt)
                .await
            {
                Ok(session) => {
                    shared.mark_spawn_provisional(session.clone());
                    Ok(NodeResponse::SpawnAccepted { session })
                }
                Err(err) => {
                    tracing::warn!(
                        %provider,
                        %workspace_id,
                        ?mode,
                        code = ?err.code,
                        message = %err.message,
                        "session spawn refused"
                    );
                    Err(err)
                }
            }
        }
        NodeRequest::SpawnWithOptions { workspace_id, provider, mode, terminal_size, initial_prompt, options } => {
            shared.require_controller(connection_id, role)?;
            if !terminal_size.is_valid() {
                return Err(failure(NodeFailureCode::InvalidRequest, "spawn requires a valid terminal size"));
            }
            if let Some(prompt) = initial_prompt.as_deref() {
                validate_node_text("spawn initial prompt", prompt)?;
            }
            let plan = backend_paths::plan_launch_options(
                provider.as_str(),
                mode,
                options.model.is_some(),
                options.effort.is_some(),
            )
            .map_err(|r| {
                tracing::warn!(%provider, reason = %r.message, "launch option path refused");
                failure(NodeFailureCode::InvalidRequest, "launch option path refused")
            })?;
            let selection = spawn_selection(&options)?;
            let nick_model = selection.as_ref().map(|s| s.model.clone());
            let pty_selection = match plan {
                backend_paths::LaunchOptionsPlan::PtyFlags => selection,
                _ => None,
            };
            let spawned = SPAWN_ORIGIN.scope(options.origin.clone(), async {
                SPAWN_PARENT.scope(options.parent_session_id.clone(), async {
                    SPAWN_NICK_MODEL.scope(nick_model, SPAWN_SESSION_OPTIONS
                        .scope(pty_selection, shared.spawn_session(workspace_id.clone(), provider.clone(), mode, terminal_size, initial_prompt)))
                        .await
                }).await
            }).await;
            match spawned {
                Ok(session) => {
                    if plan == backend_paths::LaunchOptionsPlan::AcpAfterSpawn {
                        shared
                            .pending_acp_options
                            .lock()
                            .unwrap_or_else(|p| p.into_inner())
                            .insert(session.session.instance_id, (options.model.clone(), options.effort.clone()));
                    }
                    shared.mark_spawn_provisional(session.clone());
                    tracing::info!(%provider, model = ?options.model, effort = ?options.effort, "session spawned with launch options");
                    Ok(NodeResponse::SpawnAccepted { session })
                }
                Err(err) => {
                    tracing::warn!(%provider, %workspace_id, code = ?err.code, message = %err.message, "session spawn with options refused");
                    Err(err)
                }
            }
        }
        NodeRequest::SpawnSpec { spec } => {
            shared.require_controller(connection_id, role)?;
            let receipt = shared.spawn_from_spec(spec).await?;
            Ok(NodeResponse::SpawnSpecAccepted { receipt })
        }
        NodeRequest::SpawnManagedWorktree { request } => {
            shared.require_controller(connection_id, role)?;
            let receipt = shared.spawn_managed_worktree(request).await?;
            Ok(NodeResponse::ManagedWorktreeSpawnAccepted { receipt })
        }
        NodeRequest::SpawnManagedWorktreeV2 { request } => {
            shared.require_controller(connection_id, role)?;
            let receipt = shared.spawn_managed_worktree_v2(request).await?;
            Ok(NodeResponse::ManagedWorktreeSpawnAccepted { receipt })
        }
        NodeRequest::CleanupManagedWorktree { lease_id } => {
            shared.require_controller(connection_id, role)?;
            let lease = shared.cleanup_managed_worktree(&lease_id, true).await?;
            Ok(NodeResponse::ManagedWorktreeCleanup { lease })
        }
        NodeRequest::DiscoverHistory { session, limit } => {
            controlled_session(shared, connection_id, role, &session)?;
            let candidates = shared.discover_history(&session, limit).await?;
            Ok(NodeResponse::HistoryDiscovered {
                session,
                candidates,
            })
        }
        NodeRequest::LoadHistory {
            session,
            candidate_id,
        } => {
            controlled_session(shared, connection_id, role, &session)?;
            let loaded = shared
                .load_history(&session, candidate_id)
                .await?;
            Ok(NodeResponse::HistoryLoaded {
                session,
                session_id: loaded.session_id,
                message_count: loaded.message_count,
                completed_turn_count: loaded.completed_turn_count,
            })
        }
        NodeRequest::ExportContextPackForSessionRecord { record_id, session } => {
            shared.require_controller(connection_id, role)?;
            let context = shared
                .export_context_pack_for_session_record(&record_id, &session, false)
                .await?;
            Ok(NodeResponse::ContextPackForSessionRecordExported {
                record_id,
                session,
                context,
            })
        }
        NodeRequest::ExportContextPack { session } => {
            controlled_session(shared, connection_id, role, &session)?;
            let context = shared.export_context_pack(&session).await?;
            Ok(NodeResponse::ContextPackExported { context })
        }
        NodeRequest::ForgetContextPack { context_id } => {
            shared.require_controller(connection_id, role)?;
            shared.forget_context_pack(&context_id)?;
            Ok(NodeResponse::ContextPackForgotten { context_id })
        }
        NodeRequest::ResolveDurableContextPack { context_id } => {
            // Read-only, idempotent, no controller lease required: this lets
            // a caller preflight "is this durably exported pack still here"
            // without holding the Node's mutation controller.
            let context = shared
                .context_catalog
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&context_id)
                .map(|pack| pack.receipt().clone())
                .ok_or_else(|| {
                    failure(
                        NodeFailureCode::UnknownContextPack,
                        "context pack is not present",
                    )
                })?;
            Ok(NodeResponse::DurableContextPackResolved { context })
        }
        NodeRequest::ReadContextPack { digest } => {
            // Read-only fetch of the pack's own bytes, keyed by content digest
            // rather than the caller's `SpawnContextId`: same no-controller-lease
            // rationale as `ResolveDurableContextPack` above, one step further
            // down the same catalog.
            let (id, byte_len, bytes) = shared
                .context_catalog
                .read()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get_by_digest(&digest)
                .map(|pack| {
                    (pack.receipt().id.clone(), pack.receipt().byte_len, pack.bytes().to_vec())
                })
                .ok_or_else(|| {
                    failure(
                        NodeFailureCode::UnknownContextPack,
                        &format!("context pack {digest} not on this node"),
                    )
                })?;
            tracing::debug!(
                digest = digest.as_str(),
                byte_len,
                "read context pack bytes",
            );
            Ok(NodeResponse::ContextPackBytesRead {
                pack: ContextPackBytesRead {
                    digest,
                    id,
                    byte_len,
                    bytes,
                },
            })
        }
        NodeRequest::Resume { session, terminal_size, initial_prompt } => {
            let provider = controlled_session(shared, connection_id, role, &session)?;
            if let Some(prompt) = initial_prompt.as_deref() {
                validate_node_text("resume initial prompt", prompt)?;
            }
            let runtime_requirement = if initial_prompt.is_some() {
                ProviderRuntimeRequirement::ResumeWithPrompt
            } else {
                ProviderRuntimeRequirement::Resume
            };
            shared.require_session_runtime_policy(&session, runtime_requirement)?;
            let runtime_policy = shared
                .admit_provider_runtime(&provider, runtime_requirement)
                .await?;
            let working_directory = shared.bound_workspace_root(&session)?;
            let request = ResumeLaunchRequest {
                working_directory,
                terminal_size,
                initial_prompt,
            };
            request
                .validate()
                .map_err(|error| failure(NodeFailureCode::InvalidRequest, &error.to_string()))?;
            let command = shared.prepare_command(ControlCommand::Resume {
                instance_id: session.session.instance_id,
                target: ResumeTarget::CurrentProvider,
                runtime_policy,
                request,
            });
            shared.arm_resume(&session, command.id, runtime_policy)?;
            let dispatch = shared.dispatch_envelope(command);
            if let Err(error) = dispatch {
                shared.clear_armed_resume(&session);
                return Err(error);
            }
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::RenameSessionRecord {
            record_id,
            display_name,
        } => {
            shared.require_controller(connection_id, role)?;
            let record = shared.rename_session_record(&record_id, display_name)?;
            Ok(NodeResponse::SessionRecordUpdated { record })
        }
        NodeRequest::SetSessionTask {
            record_id,
            expected_revision,
            target,
        } => {
            shared.require_controller(connection_id, role)?;
            let record = shared.set_session_task(&record_id, expected_revision, target)?;
            Ok(NodeResponse::SessionRecordUpdated { record })
        }
        NodeRequest::IndexProviderSession {
            workspace_id,
            provider,
            identity,
            display_name,
        } => {
            shared.require_controller(connection_id, role)?;
            let record = shared.index_provider_session(
                workspace_id,
                provider,
                identity,
                display_name,
            )?;
            Ok(NodeResponse::ProviderSessionIndexed { record })
        }
        NodeRequest::ResumeSessionRecord {
            record_id,
            terminal_size,
            initial_prompt,
        } => {
            shared.require_controller(connection_id, role)?;
            if let Some(prompt) = initial_prompt.as_deref() {
                validate_node_text("managed resume initial prompt", prompt)?;
            }
            let (record, session) = shared
                .resume_session_record(
                    &record_id,
                    terminal_size,
                    initial_prompt,
                )
                .await?;
            Ok(NodeResponse::SessionRecordResumed { record, session })
        }
        NodeRequest::ForgetSessionRecord { record_id } => {
            shared.require_controller(connection_id, role)?;
            shared.forget_session_record(&record_id).await?;
            Ok(NodeResponse::SessionRecordForgotten { record_id })
        }
        NodeRequest::Prompt { session, text } => {
            let agent_id = controlled_session(shared, connection_id, role, &session)?;
            validate_node_text("prompt", &text)?;
            shared.require_session_runtime_policy(
                &session,
                ProviderRuntimeRequirement::SemanticPrompt,
            )?;
            let framing = prompt_framing(&agent_id);
            shared
                .dispatch_input_bounded(
                    &session,
                    InputAction::SubmitPrompt(PromptPayload { text, framing }),
                )
                .await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Paste { session, text } => {
            controlled_session(shared, connection_id, role, &session)?;
            validate_node_text("paste", &text)?;
            shared.require_session_runtime_policy(
                &session,
                ProviderRuntimeRequirement::SemanticPrompt,
            )?;
            shared
                .dispatch_input_bounded(
                    &session,
                    InputAction::InsertDraft(PromptPayload {
                        text,
                        framing: PromptFraming::BracketedPaste,
                    }),
                )
                .await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Input { session, text } => {
            controlled_session(shared, connection_id, role, &session)?;
            validate_node_text("terminal input", &text)?;
            shared
                .dispatch_input_bounded(
                    &session,
                    InputAction::TerminalText(TerminalText { text }),
                )
                .await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::TerminalBytes { session, bytes } => {
            controlled_session(shared, connection_id, role, &session)?;
            shared.sessionize_spawn(session.session.instance_id);
            let action = terminal_bytes_action(bytes)?;
            shared
                .dispatch_input_bounded(&session, action)
                .await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::TerminalControl { session, control } => {
            controlled_session(shared, connection_id, role, &session)?;
            shared
                .dispatch_input_bounded(&session, InputAction::TerminalControl(control))
                .await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Resize { session, size } => {
            controlled_session(shared, connection_id, role, &session)?;
            shared.sessionize_spawn(session.session.instance_id);
            if !size.is_valid() {
                return Err(failure(NodeFailureCode::InvalidRequest, "terminal size is invalid"));
            }
            shared.dispatch_resize_bounded(&session, size).await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Interrupt { session } => {
            controlled_session(shared, connection_id, role, &session)?;
            shared
                .dispatch_input_bounded(
                    &session,
                    InputAction::TerminalControl(TerminalControl::Interrupt),
                )
                .await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Stop { session, force } => {
            controlled_session(shared, connection_id, role, &session)?;
            shared.sessionize_spawn(session.session.instance_id);
            shared.dispatch(ControlCommand::Stop { instance_id: session.session.instance_id, force })?;
            shared.retire_session_grok_leader(session.session.instance_id);
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Remove { session } => {
            controlled_session(shared, connection_id, role, &session)?;
            shared.remove_session(&session).await?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::ResolveInteraction { session, correlation_id, response } => {
            shared.require_controller(connection_id, role)?;
            let snapshot = shared.require_acp_session(&session)?;
            let interaction = snapshot
                .provider
                .interactions
                .iter()
                .find(|interaction| {
                    interaction_correlation(
                        session.session.instance_id,
                        session.session.generation,
                        interaction.id.0,
                    ) == correlation_id
                })
                .ok_or_else(|| failure(
                    NodeFailureCode::InvalidRequest,
                    "unknown interaction correlation",
                ))?;
            if interaction.status != ProviderInteractionStatus::Pending {
                return Err(failure(
                    NodeFailureCode::BackendOperationFailed,
                    "interaction has already been resolved",
                ));
            }
            response
                .validate_for(interaction.interaction_kind)
                .map_err(|error| failure(NodeFailureCode::InvalidRequest, &error.to_string()))?;
            let interaction_id = interaction.id;
            let response_kind = response.kind();
            let response_outcome = response.outcome();
            shared.dispatch(ControlCommand::ResolveInteraction {
                instance_id: session.session.instance_id,
                generation: session.session.generation,
                interaction_id,
                response,
            })?;
            // The one line that lets an operator compare what THIS node
            // recorded against what the provider itself reports doing --
            // measured live on a kimi run where our side resolved `true`
            // while the agent reported "rejected" and neither layer had a
            // line to line up against the other.
            tracing::info!(
                node_id = %shared.node_id,
                session = ?session.session,
                correlation_id = %correlation_id,
                interaction_id = interaction_id.0,
                response_kind = ?response_kind,
                outcome = ?response_outcome,
                "interaction resolved",
            );
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::SetSessionMode { session, mode_id } => {
            shared.require_controller(connection_id, role)?;
            shared.require_acp_session(&session)?;
            shared.dispatch(ControlCommand::SetSessionMode {
                instance_id: session.session.instance_id,
                mode_id,
            })?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::SetSessionConfigOption {
            session,
            option_id,
            value_json,
        } => {
            shared.require_controller(connection_id, role)?;
            shared.require_acp_session(&session)?;
            shared.dispatch(ControlCommand::SetSessionConfigOption {
                instance_id: session.session.instance_id,
                option_id,
                value_json,
            })?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::SetSessionModel { session, model_id } => {
            shared.require_controller(connection_id, role)?;
            shared.require_acp_session(&session)?;
            shared.dispatch(ControlCommand::SetSessionModel {
                instance_id: session.session.instance_id,
                model_id,
            })?;
            Ok(NodeResponse::Accepted)
        }
        NodeRequest::Shutdown => {
            shared.require_controller(connection_id, role)?;
            shared.begin_shutdown_locked().await?;
            Ok(NodeResponse::ShuttingDown)
        }
    }
}

fn controlled_session(shared: &NodeShared, connection_id: u64, role: ClientRole, session: &SessionAddress) -> Result<AgentId, NodeFailure> {
    shared.require_controller(connection_id, role)?;
    shared.validate_address(session)
}

/// Selects the sole history candidate matching `provider_session_id` when
/// the managed record carries a verified identity, or the sole candidate in
/// the discovered set at all when it does not (see
/// `export_context_pack_for_session_record_inner`'s identity match). Either
/// way, more than one match refuses instead of guessing which one is exact.
fn select_history_candidate(
    candidates: &[HistoryCandidateSummary],
    provider_session_id: Option<&str>,
) -> Result<String, NodeFailure> {
    let mut matches = candidates.iter().filter(|candidate| match provider_session_id {
        Some(id) => candidate.session_id_hint == id,
        None => true,
    });
    let candidate = matches.next().ok_or_else(|| {
        failure(
            NodeFailureCode::SessionRecordConflict,
            if provider_session_id.is_some() {
                "no history candidate matches the managed provider session"
            } else {
                "no history candidate exists for the managed session"
            },
        )
    })?;
    if matches.next().is_some() {
        return Err(failure(
            NodeFailureCode::SessionRecordConflict,
            if provider_session_id.is_some() {
                "history identity is ambiguous for the managed provider session"
            } else {
                "history is ambiguous without a verified provider session identity"
            },
        ));
    }
    Ok(candidate.id.clone())
}

fn resolved_spawn_profile_summary(
    profile: &SpawnProfileDefaults,
    environment_profiles: &BTreeMap<SpawnEnvironmentProfileId, EnvironmentProfileBinding>,
) -> Option<SpawnProfileSummary> {
    let environment_profile = match profile.environment_profile_id.as_ref() {
        None => None,
        Some(profile_id) => {
            let binding = environment_profiles.get(profile_id)?;
            if binding.provider != profile.provider
                || binding.native_profile_id(profile.mode).is_none()
            {
                return None;
            }
            Some(ResolvedEnvironmentProfileReceipt {
                profile_id: binding.id.clone(),
                profile_revision: binding.revision.clone(),
                network_allowlist: None,
                browser_profile_id: None,
            })
        }
    };
    Some(SpawnProfileSummary {
        id: profile.profile_id.clone(),
        revision: profile.revision.clone(),
        environment_profile,
    })
}

/// True if `current` is an acceptable version of `expected` at export
/// revalidation/commit time.
///
/// When `allow_clean_detachment` is `false` (the on-demand,
/// `NodeRequest::ExportContextPackForSessionRecord` API path), `current` must
/// be byte-identical to `expected` and still actively bound to `session` —
/// the original, unchanged invariant.
///
/// When `true` (the reactive auto-export-at-exit path, `§2.1`), `current` may
/// ALSO be the exact Live -> Dormant transition that the same clean exit this
/// export reacts to produces on its own: `state` Live -> Dormant,
/// `active_session` `Some(session)` -> `None`, `updated_at_unix_ms`
/// advancing. Every other field — including `provider_session`, `context`,
/// `bundle`, `task_binding` — must still match exactly. A record that changed
/// in any other way (rebind, a different active session, an identity
/// conflict, capacity eviction) is rejected either way; this widens nothing
/// about which sessions are eligible, only how the record's own expected
/// detachment is tolerated mid-export.
fn session_record_export_target_matches(
    expected: &ManagedSessionRecord,
    current: &ManagedSessionRecord,
    session: &SessionAddress,
    allow_clean_detachment: bool,
) -> bool {
    if current == expected && current.active_session.as_ref() == Some(session) {
        return current.state == ManagedSessionState::Live;
    }
    allow_clean_detachment
        && current.state == ManagedSessionState::Dormant
        && current.active_session.is_none()
        && current.record_id == expected.record_id
        && current.display_name == expected.display_name
        && current.provider == expected.provider
        && current.mode == expected.mode
        && current.workspace_id == expected.workspace_id
        && current.canonical_root == expected.canonical_root
        && current.provider_session == expected.provider_session
        && current.environment_profile == expected.environment_profile
        && current.bundle == expected.bundle
        && current.context_id == expected.context_id
        && current.context == expected.context
        && current.exported_context == expected.exported_context
        && current.task_binding == expected.task_binding
        && current.created_at_unix_ms == expected.created_at_unix_ms
        && current.last_error == expected.last_error
}

fn session_record_context_export_binding_is_exact(
    expected: &ManagedSessionRecord,
    current: &ManagedSessionRecord,
    identity: Option<&ProviderSessionIdentity>,
    session: &SessionAddress,
    binding: &SessionBinding,
    provider: &AgentId,
    current_root: &str,
    allow_clean_detachment: bool,
) -> bool {
    session_record_export_target_matches(expected, current, session, allow_clean_detachment)
        && current.provider_session.as_ref() == identity
        && current.workspace_id == session.workspace_id
        && provider == &current.provider
        && binding.workspace_id == session.workspace_id
        && binding.generation == session.session.generation
        && binding.record_id.as_ref() == Some(&current.record_id)
        && platform::roots_equal(
            current_root,
            windows_path_text(&current.canonical_root),
        )
}

fn session_record_context_export_source_is_usable(
    record: &ManagedSessionRecord,
    status: &SessionStatus,
    allow_clean_detachment: bool,
) -> bool {
    (record.state == ManagedSessionState::Live
        || (allow_clean_detachment && record.state == ManagedSessionState::Dormant))
        && context_pack_source_status_is_usable(status)
}

fn prompt_framing(_agent_id: &AgentId) -> PromptFraming {
    PromptFraming::BracketedPaste
}

fn validate_node_text(field: &str, text: &str) -> Result<(), NodeFailure> {
    if text.len() > MAX_NODE_TEXT_BYTES {
        return Err(failure(
            NodeFailureCode::InvalidRequest,
            &format!(
                "{field} length {} exceeds the {MAX_NODE_TEXT_BYTES}-byte node limit",
                text.len(),
            ),
        ));
    }
    Ok(())
}

fn validate_terminal_bytes(bytes: &[u8]) -> Result<(), NodeFailure> {
    if bytes.is_empty() || bytes.len() > MAX_NODE_TERMINAL_BYTES {
        return Err(failure(
            NodeFailureCode::InvalidRequest,
            &format!(
                "terminal byte sequence must contain 1..={MAX_NODE_TERMINAL_BYTES} bytes; received {}",
                bytes.len(),
            ),
        ));
    }
    Ok(())
}

fn terminal_bytes_action(bytes: Vec<u8>) -> Result<InputAction, NodeFailure> {
    validate_terminal_bytes(&bytes)?;
    Ok(InputAction::TerminalBytes(bytes))
}

fn validate_workspace_request_root(root: &str) -> Result<(), NodeFailure> {
    if root.is_empty()
        || root.len() > MAX_WORKSPACE_ROOT_BYTES
        || root.chars().any(char::is_control)
    {
        return Err(failure(
            NodeFailureCode::InvalidWorkspaceRoot,
            &format!(
                "workspace root must contain 1..={MAX_WORKSPACE_ROOT_BYTES} bytes and no control characters",
            ),
        ));
    }
    Ok(())
}

fn canonical_standalone_workspace_candidate(
    workspace_id: &WorkspaceId,
    root: &str,
) -> Result<String, NodeServerError> {
    let path = Path::new(root);
    match std::fs::symlink_metadata(path) {
        Ok(_) => WorkspaceConfig::new(workspace_id.clone(), path)
            .map(|workspace| workspace.canonical_root),
        Err(error) if error.kind() == io::ErrorKind::NotFound => {
            if !path.is_absolute() {
                return Err(NodeServerError::InvalidWorkspaceRoot {
                    workspace_id: workspace_id.clone(),
                    path: root.to_owned(),
                    message: "path is not absolute".to_owned(),
                });
            }
            let name = path.file_name().ok_or_else(|| NodeServerError::InvalidWorkspaceRoot {
                workspace_id: workspace_id.clone(),
                path: root.to_owned(),
                message: "path has no standalone directory name".to_owned(),
            })?;
            let parent = path.parent().ok_or_else(|| NodeServerError::InvalidWorkspaceRoot {
                workspace_id: workspace_id.clone(),
                path: root.to_owned(),
                message: "path has no parent directory".to_owned(),
            })?;
            let canonical = std::fs::canonicalize(parent)
                .map(|parent| parent.join(name))
                .map_err(|error| NodeServerError::InvalidWorkspaceRoot {
                    workspace_id: workspace_id.clone(),
                    path: root.to_owned(),
                    message: error.to_string(),
                })?;
            let canonical_root = canonical.into_os_string().into_string().map_err(|path| {
                NodeServerError::InvalidWorkspaceRoot {
                    workspace_id: workspace_id.clone(),
                    path: path.to_string_lossy().into_owned(),
                    message: "canonical path is not valid Unicode".to_owned(),
                }
            })?;
            let canonical_root = platform::normalize_canonical_root(canonical_root);
            validate_workspace_root(workspace_id, &canonical_root)?;
            Ok(canonical_root)
        }
        Err(error) => Err(NodeServerError::InvalidWorkspaceRoot {
            workspace_id: workspace_id.clone(),
            path: root.to_owned(),
            message: error.to_string(),
        }),
    }
}

fn validate_git_revision(field: &str, revision: Option<&str>) -> Result<(), NodeFailure> {
    let Some(revision) = revision else {
        return Ok(());
    };
    if revision.is_empty()
        || revision.len() > MAX_REPOSITORY_PATH_BYTES
        || revision.chars().any(char::is_control)
    {
        return Err(failure(
            NodeFailureCode::InvalidRequest,
            &format!(
                "{field} must contain 1..={MAX_REPOSITORY_PATH_BYTES} bytes and no control characters",
            ),
        ));
    }
    Ok(())
}

fn git_worktree_failure(error: GitWorktreeError) -> NodeFailure {
    let code = match error.kind {
        GitWorktreeErrorKind::Invalid => NodeFailureCode::InvalidRequest,
        GitWorktreeErrorKind::NotRepository => NodeFailureCode::NotGitRepository,
        GitWorktreeErrorKind::Conflict => NodeFailureCode::WorktreeConflict,
        GitWorktreeErrorKind::Protected => NodeFailureCode::WorktreeProtected,
        GitWorktreeErrorKind::Dirty => NodeFailureCode::WorktreeDirty,
        GitWorktreeErrorKind::Locked => NodeFailureCode::WorktreeLocked,
        GitWorktreeErrorKind::Failed => NodeFailureCode::BackendOperationFailed,
    };
    failure(code, &error.message)
}

fn standalone_workspace_failure(error: StandaloneWorkspaceError) -> NodeFailure {
    let code = match error.kind {
        StandaloneWorkspaceErrorKind::InvalidRoot => NodeFailureCode::InvalidWorkspaceRoot,
        StandaloneWorkspaceErrorKind::InvalidInitialBranch => NodeFailureCode::InvalidRequest,
        StandaloneWorkspaceErrorKind::GitInitializationFailed => {
            NodeFailureCode::BackendOperationFailed
        }
        StandaloneWorkspaceErrorKind::RecoveryRequired => {
            NodeFailureCode::StandaloneWorkspaceRecoveryRequired
        }
    };
    failure(code, error.message)
}

fn managed_git_worktree_failure(error: GitWorktreeError) -> NodeFailure {
    let (code, message) = match error.kind {
        GitWorktreeErrorKind::Invalid => (
            NodeFailureCode::InvalidRequest,
            "managed Git input is invalid",
        ),
        GitWorktreeErrorKind::NotRepository => (
            NodeFailureCode::NotGitRepository,
            "managed source is not a Git repository",
        ),
        GitWorktreeErrorKind::Conflict => (
            NodeFailureCode::WorktreeConflict,
            "managed Git identity conflicts with existing repository state",
        ),
        GitWorktreeErrorKind::Protected => (
            NodeFailureCode::ManagedWorktreeOwnershipConflict,
            "managed worktree ownership validation failed",
        ),
        GitWorktreeErrorKind::Dirty => (
            NodeFailureCode::WorktreeDirty,
            "managed worktree contains uncommitted changes",
        ),
        GitWorktreeErrorKind::Locked => (
            NodeFailureCode::WorktreeLocked,
            "managed worktree is locked",
        ),
        GitWorktreeErrorKind::Failed => (
            NodeFailureCode::BackendOperationFailed,
            "managed Git operation failed",
        ),
    };
    NodeFailure { code, message: message.to_owned() }
}

fn managed_spawn_receipt(
    resolved: &ResolvedSpawnSpec,
    incarnation_id: NodeIncarnationId,
    session: SessionAddress,
    lease: ManagedWorktreeLeaseSnapshot,
    environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
    bundle: Option<ResolvedBundleReceipt>,
    context: Option<ResolvedContextPackReceipt>,
) -> ManagedWorktreeSpawnReceipt {
    let mut managed = resolved.clone();
    managed.target.worktree_id = Some(lease.workspace_id.clone());
    ManagedWorktreeSpawnReceipt {
        spawn: managed.receipt_with_materialization(
            incarnation_id,
            session,
            environment_profile,
            bundle,
            context,
        ),
        lease,
    }
}

fn validate_selected_worktree(
    source_root: &str,
    selected_root: &str,
    worktrees: &[NativeGitWorktreeSnapshot],
) -> Result<(), NodeFailure> {
    if !worktrees
        .iter()
        .any(|worktree| worktree_paths_equal(&worktree.path, source_root) && !worktree.is_bare)
    {
        return Err(failure(
            NodeFailureCode::WorktreeProtected,
            "source workspace is not an authoritative non-bare Git worktree root",
        ));
    }
    if !worktrees.iter().any(|worktree| {
        worktree_paths_equal(&worktree.path, selected_root)
            && !worktree.is_main
            && !worktree.is_bare
    }) {
        return Err(failure(
            NodeFailureCode::WorktreeProtected,
            "selected workspace is not an eligible Git worktree in the source repository",
        ));
    }
    Ok(())
}

fn workspace_file_failure(error: WorkspaceFileReadError) -> NodeFailure {
    let code = match error.kind() {
        WorkspaceFileReadErrorKind::InvalidPath => NodeFailureCode::InvalidRepositoryPath,
        WorkspaceFileReadErrorKind::UnsafePath | WorkspaceFileReadErrorKind::ReparsePoint => {
            NodeFailureCode::RepositoryPathUnsafe
        }
        WorkspaceFileReadErrorKind::NotFound => NodeFailureCode::RepositoryFileNotFound,
        WorkspaceFileReadErrorKind::NotRegularFile => {
            NodeFailureCode::RepositoryFileNotRegular
        }
        WorkspaceFileReadErrorKind::AccessDenied | WorkspaceFileReadErrorKind::Io => {
            NodeFailureCode::RepositoryFileReadFailed
        }
        WorkspaceFileReadErrorKind::RevisionConflict => {
            NodeFailureCode::RepositoryFileRevisionConflict
        }
        WorkspaceFileReadErrorKind::AlreadyExists
        | WorkspaceFileReadErrorKind::ParentNotFound
        | WorkspaceFileReadErrorKind::ParentNotDirectory
        | WorkspaceFileReadErrorKind::Canceled => {
            NodeFailureCode::RepositoryFileReadFailed
        }
    };
    failure(code, "repository file read failed")
}

fn workspace_file_write_failure(error: WorkspaceFileReadError) -> NodeFailure {
    let code = match error.kind() {
        WorkspaceFileReadErrorKind::InvalidPath => NodeFailureCode::InvalidRepositoryPath,
        WorkspaceFileReadErrorKind::UnsafePath | WorkspaceFileReadErrorKind::ReparsePoint => {
            NodeFailureCode::RepositoryPathUnsafe
        }
        WorkspaceFileReadErrorKind::NotFound => NodeFailureCode::RepositoryFileNotFound,
        WorkspaceFileReadErrorKind::NotRegularFile => {
            NodeFailureCode::RepositoryFileNotRegular
        }
        WorkspaceFileReadErrorKind::AccessDenied | WorkspaceFileReadErrorKind::Io => {
            NodeFailureCode::RepositoryFileWriteFailed
        }
        WorkspaceFileReadErrorKind::RevisionConflict => {
            NodeFailureCode::RepositoryFileRevisionConflict
        }
        WorkspaceFileReadErrorKind::AlreadyExists
        | WorkspaceFileReadErrorKind::ParentNotFound
        | WorkspaceFileReadErrorKind::ParentNotDirectory
        | WorkspaceFileReadErrorKind::Canceled => {
            NodeFailureCode::RepositoryFileWriteFailed
        }
    };
    failure(code, "repository file write failed")
}

async fn settle_workspace_entry_create<T>(
    mut task: tokio::task::JoinHandle<Result<T, WorkspaceFileReadError>>,
    commit_state: Arc<AtomicU8>,
    deadline: Duration,
    timeout_message: &'static str,
    task_failure_message: &'static str,
) -> Result<T, NodeFailure> {
    let joined = match timeout(deadline, &mut task).await {
        Ok(joined) => joined,
        Err(_) => {
            if commit_state
                .compare_exchange(
                    WORKSPACE_ENTRY_CREATE_PENDING,
                    WORKSPACE_ENTRY_CREATE_CANCELED,
                    Ordering::AcqRel,
                    Ordering::Acquire,
                )
                .is_ok()
            {
                return Err(failure(
                    NodeFailureCode::RepositoryEntryCreateTimedOut,
                    timeout_message,
                ));
            }
            debug_assert_eq!(
                commit_state.load(Ordering::Acquire),
                WORKSPACE_ENTRY_CREATE_COMMITTING,
            );
            task.await
        }
    };
    joined
        .map_err(|_| {
            failure(
                NodeFailureCode::RepositoryEntryCreateFailed,
                task_failure_message,
            )
        })?
        .map_err(workspace_entry_create_failure)
}

fn workspace_entry_create_failure(error: WorkspaceFileReadError) -> NodeFailure {
    let code = match error.kind() {
        WorkspaceFileReadErrorKind::InvalidPath => NodeFailureCode::InvalidRepositoryPath,
        WorkspaceFileReadErrorKind::UnsafePath | WorkspaceFileReadErrorKind::ReparsePoint => {
            NodeFailureCode::RepositoryPathUnsafe
        }
        WorkspaceFileReadErrorKind::AlreadyExists => {
            NodeFailureCode::RepositoryEntryAlreadyExists
        }
        WorkspaceFileReadErrorKind::ParentNotFound | WorkspaceFileReadErrorKind::NotFound => {
            NodeFailureCode::RepositoryParentNotFound
        }
        WorkspaceFileReadErrorKind::ParentNotDirectory
        | WorkspaceFileReadErrorKind::NotRegularFile => {
            NodeFailureCode::RepositoryParentNotDirectory
        }
        WorkspaceFileReadErrorKind::AccessDenied | WorkspaceFileReadErrorKind::Io => {
            NodeFailureCode::RepositoryEntryCreateFailed
        }
        WorkspaceFileReadErrorKind::RevisionConflict => {
            NodeFailureCode::RepositoryEntryCreateFailed
        }
        WorkspaceFileReadErrorKind::Canceled => {
            NodeFailureCode::RepositoryEntryCreateTimedOut
        }
    };
    failure(code, "repository entry create failed")
}

fn workspace_file_revision(bytes: &[u8]) -> WorkspaceFileRevision {
    let value = digest(&SHA256, bytes)
        .as_ref()
        .iter()
        .map(|byte| format!("{byte:02x}"))
        .collect();
    WorkspaceFileRevision::new(value).expect("SHA-256 produces a valid workspace revision")
}

fn managed_spawn_request_digest_v2(
    request: &ManagedWorktreeSpawnRequestV2,
) -> Result<String, NodeFailure> {
    let encoded = serde_json::to_vec(request).map_err(|_| {
        failure(
            NodeFailureCode::InvalidRequest,
            "managed worktree V2 request could not be canonicalized",
        )
    })?;
    let mut value = String::with_capacity(71);
    value.push_str("sha256:");
    for byte in digest(&SHA256, &encoded).as_ref() {
        use std::fmt::Write as _;
        write!(&mut value, "{byte:02x}").expect("writing to a String cannot fail");
    }
    Ok(value)
}

fn native_session_preview_failure(error: NativeSessionPreviewError) -> NodeFailure {
    let code = match error {
        NativeSessionPreviewError::InvalidLimit => NodeFailureCode::InvalidRequest,
        NativeSessionPreviewError::WorkspaceUnavailable => NodeFailureCode::UnknownWorkspace,
        NativeSessionPreviewError::StaleCatalog => NodeFailureCode::StaleNativeSessionCatalog,
        NativeSessionPreviewError::UnsupportedProvider
        | NativeSessionPreviewError::PreviewUnavailable
        | NativeSessionPreviewError::SessionNotFound
        | NativeSessionPreviewError::AmbiguousSession => {
            NodeFailureCode::BackendOperationFailed
        }
    };
    failure(code, "native session preview failed")
}

fn host_directory_failure(error: HostDirectoryBrowseError) -> NodeFailure {
    let code = match error.kind() {
        HostDirectoryBrowseErrorKind::Invalid => NodeFailureCode::HostDirectoryInvalid,
        HostDirectoryBrowseErrorKind::ReadFailed => NodeFailureCode::HostDirectoryReadFailed,
    };
    failure(code, "host directory browse failed")
}

fn delivery_failure(error: DeliveryStoreError) -> NodeFailure {
    let code = match error {
        DeliveryStoreError::InvalidManifest => NodeFailureCode::DeliveryManifestInvalid,
        DeliveryStoreError::UnknownStage => NodeFailureCode::UnknownDeliveryStage,
        DeliveryStoreError::Capacity | DeliveryStoreError::StageConflict => {
            NodeFailureCode::DeliveryStageConflict
        }
        DeliveryStoreError::UnexpectedBlob => NodeFailureCode::DeliveryBlobUnexpected,
        DeliveryStoreError::ChunkOutOfOrder | DeliveryStoreError::ChunkOverflow => {
            NodeFailureCode::DeliveryChunkOutOfOrder
        }
        DeliveryStoreError::BlobDigestMismatch => {
            NodeFailureCode::DeliveryBlobDigestMismatch
        }
        DeliveryStoreError::BundleDigestMismatch => {
            NodeFailureCode::DeliveryBundleDigestMismatch
        }
        DeliveryStoreError::StageIncomplete => NodeFailureCode::DeliveryStageIncomplete,
        DeliveryStoreError::Unavailable
        | DeliveryStoreError::Corrupt
        | DeliveryStoreError::Storage(_) => NodeFailureCode::DeliveryStageStorageFailed,
    };
    failure(code, "delivery operation failed")
}

fn validate_workspace_root(
    workspace_id: &WorkspaceId,
    canonical_root: &str,
) -> Result<(), NodeServerError> {
    #[cfg(windows)]
    if canonical_root.starts_with(r"\\") {
        return Err(NodeServerError::InvalidWorkspaceRoot {
            workspace_id: workspace_id.clone(),
            path: canonical_root.to_owned(),
            message: "UNC workspace roots are unsupported by Windows PTY providers".to_owned(),
        });
    }
    if !platform::workspace_root_supported(canonical_root)
        || canonical_root.len() > WORKING_DIRECTORY_MAX_BYTES
    {
        return Err(NodeServerError::InvalidWorkspaceRoot {
            workspace_id: workspace_id.clone(),
            path: canonical_root.to_owned(),
            message: "canonical path must be absolute, bounded, and free of control characters"
                .to_owned(),
        });
    }
    Ok(())
}

fn failure(code: NodeFailureCode, _message: &str) -> NodeFailure {
    NodeFailure {
        code,
        message: node_failure_category(code).to_owned(),
    }
}

fn harness_mcp_failure(error: HarnessMcpProxyError) -> NodeFailure {
    let code = match error {
        HarnessMcpProxyError::Unavailable => NodeFailureCode::HarnessMcpUnavailable,
        HarnessMcpProxyError::NotFound => NodeFailureCode::ReservationNotFound,
        HarnessMcpProxyError::Conflict => NodeFailureCode::ReservationConflict,
        HarnessMcpProxyError::Expired => NodeFailureCode::ReservationExpired,
        HarnessMcpProxyError::BindingMismatch => NodeFailureCode::BindingMismatch,
        HarnessMcpProxyError::NotActivated => NodeFailureCode::NotActivated,
        HarnessMcpProxyError::CallNotFound => NodeFailureCode::CallNotFound,
        HarnessMcpProxyError::ChunkOutOfOrder => NodeFailureCode::ChunkOutOfOrder,
        HarnessMcpProxyError::ResponseTooLarge => NodeFailureCode::ResponseTooLarge,
    };
    failure(code, "harness MCP proxy operation failed")
}

/// Numbers each harness-MCP overlay this process constructs, in
/// construction order, so two overlays built back to back in one node process
/// still get distinct trace files.
static NEXT_HARNESS_MCP_TRACE_SEQUENCE: AtomicU64 = AtomicU64::new(1);

/// Builds the optional trace environment entry of one harness-MCP overlay.
/// The caller's launch description names both the entry and the node-process
/// variable that opts in: when that variable holds a non-empty directory, the
/// entry names a trace file under it. Returns `None` when the launch has no
/// trace, or the directory is unset, empty, or not valid Unicode. Never creates
/// the directory; that is the operator's job.
fn harness_mcp_trace_env_entry(launch: &HarnessMcpLaunchV1) -> Option<(OsString, OsString)> {
    let trace = launch.trace.as_ref()?;
    let trace_dir = std::env::var(&trace.dir_env).ok()?;
    if trace_dir.is_empty() {
        return None;
    }
    let sequence = NEXT_HARNESS_MCP_TRACE_SEQUENCE.fetch_add(1, Ordering::Relaxed);
    let path = std::path::Path::new(&trace_dir).join(format!("harness-mcp-{sequence}.trace"));
    Some((OsString::from(trace.env.as_str()), path.into_os_string()))
}

fn spawn_deadline_remaining(deadline: Instant) -> Result<Duration, NodeFailure> {
    let remaining = deadline.saturating_duration_since(Instant::now());
    if remaining.is_zero() {
        Err(failure(
            NodeFailureCode::SpawnDeadlineExceeded,
            "spawn deadline elapsed",
        ))
    } else {
        Ok(remaining)
    }
}

fn spawn_dispatch_timeout(deadline: Option<Instant>) -> Result<Duration, NodeFailure> {
    let bounded = Duration::from_millis(SPAWN_DISPATCH_TIMEOUT_MS);
    match deadline {
        Some(deadline) => Ok(spawn_deadline_remaining(deadline)?.min(bounded)),
        None => Ok(bounded),
    }
}

fn spawn_dispatch_error(error: NodeFailure, deadline: Option<Instant>) -> NodeFailure {
    if deadline.is_some_and(|deadline| Instant::now() >= deadline) {
        failure(
            NodeFailureCode::SpawnDeadlineExceeded,
            "spawn dispatch exceeded the spawn deadline",
        )
    } else {
        error
    }
}

fn spawn_runtime_capabilities(
    capabilities: &SpawnRequiredCapabilities,
) -> Result<Vec<ProviderRuntimeCapability>, NodeFailure> {
    capabilities
        .iter()
        .map(|capability| match capability.as_str() {
            SPAWN_RUNTIME_RAW_PTY_LIFECYCLE => Ok(ProviderRuntimeCapability::RawPtyLifecycle),
            SPAWN_RUNTIME_SEMANTIC_READINESS => Ok(ProviderRuntimeCapability::SemanticReadiness),
            SPAWN_RUNTIME_STRUCTURED_PROMPT => Ok(ProviderRuntimeCapability::StructuredPrompt),
            SPAWN_RUNTIME_PROVIDER_SESSION_IDENTITY => {
                Ok(ProviderRuntimeCapability::ProviderSessionIdentity)
            }
            SPAWN_RUNTIME_SEMANTIC_RESUME => Ok(ProviderRuntimeCapability::SemanticResume),
            _ => Err(failure(
                NodeFailureCode::UnsupportedSpawnCapability,
                "spawn required capability is unknown",
            )),
        })
        .collect()
}

fn persistence_failure(_error: io::Error) -> NodeFailure {
    NodeFailure {
        code: NodeFailureCode::BackendOperationFailed,
        message: DURABLE_STATE_COMMIT_FAILED_ERROR.to_owned(),
    }
}

fn node_failure_category(code: NodeFailureCode) -> &'static str {
    match code {
        NodeFailureCode::InvalidRequest => "invalid-request",
        NodeFailureCode::UnsupportedCapability => "unsupported-capability",
        NodeFailureCode::HarnessMcpUnavailable => "harness-mcp-unavailable",
        NodeFailureCode::ReservationNotFound => "reservation-not-found",
        NodeFailureCode::ReservationConflict => "reservation-conflict",
        NodeFailureCode::ReservationExpired => "reservation-expired",
        NodeFailureCode::BindingMismatch => "binding-mismatch",
        NodeFailureCode::NotActivated => "not-activated",
        NodeFailureCode::CallNotFound => "call-not-found",
        NodeFailureCode::ChunkOutOfOrder => "chunk-out-of-order",
        NodeFailureCode::ResponseTooLarge => "response-too-large",
        NodeFailureCode::DeliveryManifestInvalid => "delivery-manifest-invalid",
        NodeFailureCode::UnknownDeliveryStage => "unknown-delivery-stage",
        NodeFailureCode::DeliveryStageConflict => "delivery-stage-conflict",
        NodeFailureCode::DeliveryBlobUnexpected => "delivery-blob-unexpected",
        NodeFailureCode::DeliveryChunkOutOfOrder => "delivery-chunk-out-of-order",
        NodeFailureCode::DeliveryBlobDigestMismatch => "delivery-blob-digest-mismatch",
        NodeFailureCode::DeliveryBundleDigestMismatch => "delivery-bundle-digest-mismatch",
        NodeFailureCode::DeliveryStageIncomplete => "delivery-stage-incomplete",
        NodeFailureCode::DeliveryStageStorageFailed => "delivery-stage-storage-failed",
        NodeFailureCode::Unauthorized => "unauthorized",
        NodeFailureCode::ObserverReadOnly => "observer-read-only",
        NodeFailureCode::ControllerBusy => "controller-busy",
        NodeFailureCode::ControllerRequired => "controller-required",
        NodeFailureCode::UnknownWorkspace => "unknown-workspace",
        NodeFailureCode::HostDirectoryInvalid => "host-directory-invalid",
        NodeFailureCode::HostDirectoryReadFailed => "host-directory-read-failed",
        NodeFailureCode::HostDirectoryReadTimedOut => "host-directory-read-timed-out",
        NodeFailureCode::InvalidRepositoryPath => "invalid-repository-path",
        NodeFailureCode::RepositoryFileNotFound => "repository-file-not-found",
        NodeFailureCode::RepositoryFileNotRegular => "repository-file-not-regular",
        NodeFailureCode::RepositoryPathUnsafe => "repository-path-unsafe",
        NodeFailureCode::RepositoryFileReadTimedOut => "repository-file-read-timed-out",
        NodeFailureCode::RepositoryFileReadFailed => "repository-file-read-failed",
        NodeFailureCode::RepositoryFileWriteTimedOut => "repository-file-write-timed-out",
        NodeFailureCode::RepositoryFileWriteFailed => "repository-file-write-failed",
        NodeFailureCode::RepositoryFileRevisionConflict => "repository-file-revision-conflict",
        NodeFailureCode::RepositoryEntryAlreadyExists => "repository-entry-already-exists",
        NodeFailureCode::RepositoryParentNotFound => "repository-parent-not-found",
        NodeFailureCode::RepositoryParentNotDirectory => "repository-parent-not-directory",
        NodeFailureCode::RepositoryEntryCreateTimedOut => "repository-entry-create-timed-out",
        NodeFailureCode::RepositoryEntryCreateFailed => "repository-entry-create-failed",
        NodeFailureCode::GitReadTimedOut => "git-read-timed-out",
        NodeFailureCode::GitReadFailed => "git-read-failed",
        NodeFailureCode::UnknownSpawnProfile => "unknown-spawn-profile",
        NodeFailureCode::SpawnProfileRevisionMismatch => "spawn-profile-revision-mismatch",
        NodeFailureCode::SpawnTargetMismatch => "spawn-target-mismatch",
        NodeFailureCode::SpawnIdempotencyConflict => "spawn-idempotency-conflict",
        NodeFailureCode::SpawnIdempotencyCapacity => "spawn-idempotency-capacity",
        NodeFailureCode::SpawnDeadlineExceeded => "spawn-deadline-exceeded",
        NodeFailureCode::UnsupportedSpawnCapability => "unsupported-spawn-capability",
        NodeFailureCode::UnsupportedTransport => "unsupported-transport",
        NodeFailureCode::TurnInFlight => "turn-in-flight",
        NodeFailureCode::UnknownEnvironmentProfile => "unknown-environment-profile",
        NodeFailureCode::UnknownNetworkAllowlist => "unknown-network-allowlist",
        NodeFailureCode::UnsupportedNetworkAllowlistMapping => {
            "unsupported-network-allowlist-mapping"
        }
        NodeFailureCode::BrowserStationProbeUnavailable => {
            "browser-station-probe-unavailable"
        }
        NodeFailureCode::BrowserStationUnreachable => "browser-station-unreachable",
        NodeFailureCode::BrowserStationProfileBusy => "browser-station-profile-busy",
        NodeFailureCode::EnvironmentProfileBindingMismatch => {
            "environment-profile-binding-mismatch"
        }
        NodeFailureCode::UnknownBundle => "unknown-bundle",
        NodeFailureCode::BundleBindingMismatch => "bundle-binding-mismatch",
        NodeFailureCode::BundleMaterializationFailed => "bundle-materialization-failed",
        NodeFailureCode::UnknownContextPack => "unknown-context-pack",
        NodeFailureCode::ContextPackBusy => "context-pack-busy",
        NodeFailureCode::ContextPackMaterializationFailed => {
            "context-pack-materialization-failed"
        }
        NodeFailureCode::InvalidWorkspaceRoot => "invalid-workspace-root",
        NodeFailureCode::DuplicateWorkspaceId => "duplicate-workspace-id",
        NodeFailureCode::DuplicateWorkspaceRoot => "duplicate-workspace-root",
        NodeFailureCode::WorkspaceBusy => "workspace-busy",
        NodeFailureCode::LastWorkspace => "last-workspace",
        NodeFailureCode::NotGitRepository => "not-git-repository",
        NodeFailureCode::WorktreeConflict => "worktree-conflict",
        NodeFailureCode::WorktreeProtected => "worktree-protected",
        NodeFailureCode::WorktreeDirty => "worktree-dirty",
        NodeFailureCode::WorktreeLocked => "worktree-locked",
        NodeFailureCode::UnknownManagedWorktreeLease => "unknown-managed-worktree-lease",
        NodeFailureCode::ManagedWorktreeBusy => "managed-worktree-busy",
        NodeFailureCode::ManagedWorktreeOwnershipConflict => "managed-worktree-ownership-conflict",
        NodeFailureCode::ManagedWorktreeProfileRevisionMismatch => {
            "managed-worktree-profile-revision-mismatch"
        }
        NodeFailureCode::ManagedWorktreeRecoveryRequired => "managed-worktree-recovery-required",
        NodeFailureCode::StandaloneWorkspaceRecoveryRequired => {
            "standalone-workspace-recovery-required"
        }
        NodeFailureCode::UnknownSession => "unknown-session",
        NodeFailureCode::UnknownSessionRecord => "unknown-session-record",
        NodeFailureCode::SessionRecordNotResumable => "session-record-not-resumable",
        NodeFailureCode::SessionRecordBusy => "session-record-busy",
        NodeFailureCode::SessionRecordConflict => "session-record-conflict",
        NodeFailureCode::SessionWorkspaceMismatch => "session-workspace-mismatch",
        NodeFailureCode::WorkspaceRegistrationRequired => {
            "workspace-registration-required"
        }
        NodeFailureCode::StaleNativeSessionCatalog => "stale-native-session-catalog",
        NodeFailureCode::StaleGeneration => "stale-generation",
        NodeFailureCode::BackendBusy => "backend-busy",
        NodeFailureCode::BackendDisconnected => "backend-disconnected",
        NodeFailureCode::BackendOperationFailed => "backend-operation-failed",
        NodeFailureCode::ShuttingDown => "shutting-down",
    }
}

fn durable_state_server_error(error: io::Error, category: &'static str) -> NodeServerError {
    NodeServerError::DurableState(io::Error::new(error.kind(), category))
}

fn durable_state_load_error(error: io::Error) -> NodeServerError {
    let category = match session_registry::state_load_refusal(&error) {
        Some(session_registry::StateLoadRefusal::UnsupportedSchema) => {
            DURABLE_STATE_SCHEMA_UNSUPPORTED_ERROR
        }
        Some(session_registry::StateLoadRefusal::PathSemanticsUnsupported) => {
            DURABLE_STATE_PATH_SEMANTICS_UNSUPPORTED_ERROR
        }
        Some(session_registry::StateLoadRefusal::NodeIdentityMismatch) => {
            DURABLE_STATE_CONFLICT_ERROR
        }
        _ => DURABLE_STATE_LOAD_FAILED_ERROR,
    };
    durable_state_server_error(error, category)
}

fn unix_time_ms() -> u64 {
    std::time::SystemTime::now()
        .duration_since(std::time::UNIX_EPOCH)
        .unwrap_or_default()
        .as_millis()
        .min(u64::MAX as u128) as u64
}

fn detached_record_state(record: &ManagedSessionRecord) -> ManagedSessionState {
    if record.provider_session.is_some() {
        ManagedSessionState::Dormant
    } else {
        ManagedSessionState::Unavailable
    }
}

fn active_record_state(
    identity_admitted: bool,
    provider_session_is_known: bool,
) -> ManagedSessionState {
    if identity_admitted && !provider_session_is_known {
        ManagedSessionState::IdentityPending
    } else {
        ManagedSessionState::Live
    }
}

fn managed_worktree_record_holders(
    records: &[ManagedSessionRecord],
) -> Vec<(SessionRecordId, WorkspaceId)> {
    records
        .iter()
        .filter(|record| record.provider_session.is_some())
        .map(|record| (record.record_id.clone(), record.workspace_id.clone()))
        .collect()
}

fn managed_spawn_record_ownership(
    binding: &SessionBinding,
    effective_runtime_policy: ProviderRuntimePolicy,
) -> (Option<SessionRecordId>, Option<SessionRecordId>) {
    debug_assert_eq!(binding.runtime_policy, effective_runtime_policy);
    if effective_runtime_policy.provider_session_identity {
        (binding.record_id.clone(), None)
    } else {
        (None, binding.record_id.clone())
    }
}

#[derive(Debug, Error)]
pub enum NodeServerError {
    #[error("node endpoint must be a bounded absolute local transport path")]
    InvalidEndpoint,
    #[error("node access token must contain 1..=4096 bytes")]
    InvalidAccessToken,
    #[error("node HTTP observer must listen on a loopback address: {0}")]
    InvalidApiListen(std::net::SocketAddr),
    #[error("node browser bridge must listen on a loopback address: {0}")]
    InvalidBridgeListen(std::net::SocketAddr),
    #[error("node browser bridge token must contain 1..=4096 bytes")]
    InvalidBridgeToken,
    #[error("bridge underlay requires --bridge-listen (local HTTP+WS door)")]
    BridgeUnderlayRequiresBridgeListen,
    #[error("bridge underlay requires GATE4AGENT_BRIDGE_TOKEN (application barrier)")]
    BridgeUnderlayRequiresBridgeToken,
    #[error("mesh underlay auth token must contain 1..=4096 bytes")]
    InvalidBridgeUnderlayToken,
    #[error("mesh underlay transport key must be 32 bytes (64 hex digits)")]
    InvalidBridgeUnderlayKey,
    #[error("node call-home relay must be loopback or a concrete C2 tunnel address with a nonzero port: {0}")]
    InvalidCallHome(std::net::SocketAddr),
    #[error("node could not reach its call-home relay: {0}")]
    CallHomeTransport(#[source] std::io::Error),
    #[error("node durable state path must be an absolute file path: {0}")]
    InvalidStatePath(String),
    #[error("harness MCP helper must be an exact reviewed absolute regular file")]
    InvalidHarnessMcpHelper,
    #[error("network allowlist catalog path must be an absolute regular file: {0}")]
    InvalidNetworkAllowlistCatalogPath(String),
    #[error("network allowlist catalog could not be read: {0}")]
    NetworkAllowlistCatalogIo(#[source] std::io::Error),
    #[error("network allowlist catalog line {line}: {message}")]
    InvalidNetworkAllowlistCatalogEntry { line: usize, message: String },
    #[error("network allowlist catalog: {0}")]
    InvalidNetworkAllowlistCatalog(String),
    #[error("network allowlist catalog exceeds the {max}-entry limit")]
    NetworkAllowlistCatalogCapacity { max: usize },
    #[error("the local state directory is unavailable; supply an explicit state path")]
    LocalStateDirectoryUnavailable,
    #[error("the local runtime directory is unavailable; supply an explicit endpoint")]
    LocalRuntimeDirectoryUnavailable,
    #[error("node durable state failed: {0}")]
    DurableState(io::Error),
    #[error("node requires at least one configured workspace")]
    NoWorkspaces,
    #[error("workspace '{workspace_id}' root '{path}' is invalid: {message}")]
    InvalidWorkspaceRoot {
        workspace_id: WorkspaceId,
        path: String,
        message: String,
    },
    #[error("duplicate workspace ID: {0}")]
    DuplicateWorkspaceId(WorkspaceId),
    #[error("workspaces '{first}' and '{second}' resolve to the same root '{root}'")]
    DuplicateWorkspaceRoot {
        first: WorkspaceId,
        second: WorkspaceId,
        root: String,
    },
    #[error("workspace '{0}' uses managed worktrees but has no local profile")]
    ManagedWorktreeProfileRequired(WorkspaceId),
    #[error("workspace '{0}' has managed worktree profiles but is not in managed mode")]
    ManagedWorktreeProfileModeMismatch(WorkspaceId),
    #[error("workspace '{workspace_id}' has duplicate managed worktree profile '{profile_id}'")]
    DuplicateManagedWorktreeProfile {
        workspace_id: WorkspaceId,
        profile_id: WorktreeProfileId,
    },
    #[error("workspace '{workspace_id}' exceeds the {max}-profile managed worktree limit")]
    ManagedWorktreeProfileCapacity {
        workspace_id: WorkspaceId,
        max: usize,
    },
    #[error("workspace '{workspace_id}' managed worktree profile '{profile_id}' is invalid: {message}")]
    InvalidManagedWorktreeProfile {
        workspace_id: WorkspaceId,
        profile_id: WorktreeProfileId,
        message: String,
    },
    #[error("duplicate node environment profile: {0}")]
    DuplicateEnvironmentProfile(SpawnEnvironmentProfileId),
    #[error("node environment profile provider is unavailable: {0}")]
    EnvironmentProfileProviderUnavailable(AgentId),
    #[error("node environment profile capacity is {max}")]
    EnvironmentProfileCapacity { max: usize },
    #[error("node environment profiles reuse native profile ID '{0}'")]
    DuplicateNativeEnvironmentProfile(String),
    #[error("node native environment profile is invalid: {0}")]
    NativeEnvironmentProfile(String),
    #[error("node session-environment materialization root must be absolute")]
    InvalidSessionEnvironmentRoot,
    #[error("node session-environment materializer is unavailable")]
    SessionEnvironmentMaterializerRequired,
    #[error("node session-environment materializer failed to initialize")]
    SessionEnvironmentMaterializer,
    #[error("node bundle catalog is invalid: {0}")]
    BundleCatalog(String),
    #[error("node delivery store failed to initialize: {0}")]
    DeliveryStore(String),
    #[error("node context pack store failed to initialize")]
    ContextPackStore,
    #[error("active agent registry failed: {0}")]
    Registry(String),
    #[error("node provider contract manifest is invalid: {0}")]
    ProviderContractManifest(String),
    #[error("named pipe I/O failed: {0}")]
    Io(#[from] io::Error),
    #[error("node HTTP observer failed: {0}")]
    HttpApi(io::Error),
    #[error("node browser bridge failed: {0}")]
    BridgeApi(io::Error),
    #[error(transparent)]
    Frame(#[from] FrameError),
    #[error("node handshake failed: {0}")]
    Handshake(String),
    #[error("node authentication frame was not received before the bounded deadline")]
    AuthenticationTimedOut,
    #[error("node authentication primitive failed: {0}")]
    Authentication(String),
    #[error("node incarnation identity generation failed: {0}")]
    IncarnationIdentity(String),
    #[error("node pre-authentication limiter is closed")]
    PreauthClosed,
    #[error("node authenticated connection limit was reached")]
    AuthenticatedConnectionLimit,
    #[error("node Ctrl+C/CtrlBreak signal stream closed")]
    SignalStreamClosed,
    #[error("node stop-all dispatch failed: {0:?}")]
    ShutdownDispatch(NodeFailure),
    #[error("node shutdown timed out with {active_native_sessions} physical sessions retained")]
    ShutdownTimedOut { active_native_sessions: usize },
}

impl From<crate::network_allowlist_catalog::NetworkAllowlistCatalogError> for NodeServerError {
    fn from(error: crate::network_allowlist_catalog::NetworkAllowlistCatalogError) -> Self {
        use crate::network_allowlist_catalog::NetworkAllowlistCatalogError as E;
        match error {
            E::InvalidPath(path) => Self::InvalidNetworkAllowlistCatalogPath(path),
            E::Io(error) => Self::NetworkAllowlistCatalogIo(error),
            E::InvalidEntry { line, message } => {
                Self::InvalidNetworkAllowlistCatalogEntry { line, message }
            }
            E::InvalidCatalog(message) => Self::InvalidNetworkAllowlistCatalog(message),
            E::Capacity { max } => Self::NetworkAllowlistCatalogCapacity { max },
        }
    }
}

#[cfg(test)]
mod agent_stream_blocked_tests {
    use super::*;
    use gate4agent_types::{
        AdapterId, AdapterVerification, HostRequestOutcome as ProviderHostRequestOutcome,
        ProviderSource,
    };

    fn provider_source(family: AdapterFamily, adapter: &str) -> ProviderSource {
        ProviderSource {
            family,
            binding: AdapterBinding::new(
                AdapterId::new(adapter).unwrap(),
                "fixture/v1",
                AdapterVerification::SyntheticFixture,
            )
            .unwrap(),
        }
    }

    fn provider_control_event_at(
        family: AdapterFamily,
        adapter: &str,
        source_sequence: u64,
        provider_event: ProviderEvent,
    ) -> ControlEvent {
        ControlEvent {
            sequence: 41,
            command_id: None,
            instance_id: AgentInstanceId(7),
            generation: SessionGeneration(3),
            event: ControlEventKind::ProviderEvent {
                sequence: 8,
                source: provider_source(family, adapter),
                source_sequence,
                event: provider_event,
            },
        }
    }

    fn provider_control_event(family: AdapterFamily, provider_event: ProviderEvent) -> ControlEvent {
        provider_control_event_at(family, "fixture", 9, provider_event)
    }

    fn denied_host_request(
        by: ProviderHostDecisionAuthority,
        reason: Option<String>,
    ) -> ControlEvent {
        provider_control_event_at(
            AdapterFamily::Acp,
            "claude-code",
            2,
            ProviderEvent::HostRequestObserved {
                method: "terminal/create".to_owned(),
                params_json: String::new(),
                decision: ProviderHostRequestDecision::Denied { by },
                outcome: ProviderHostRequestOutcome::Executed,
                reason,
            },
        )
    }

    fn blocked(
        event: &ControlEvent,
    ) -> (
        Option<String>,
        String,
        BlockAuthorityV1,
        Option<String>,
        String,
        Option<String>,
    ) {
        let chunk = agent_stream_chunk(event).expect("expected a Blocked chunk");
        chunk.validate().expect("minted chunk must validate");
        let AgentStreamChunkKindV1::Blocked {
            correlation_id,
            tool_class,
            authority,
            reason_kind,
            reason,
            help,
        } = chunk.kind
        else {
            panic!("expected AgentStreamChunkKindV1::Blocked");
        };
        (correlation_id, tool_class, authority, reason_kind, reason, help)
    }

    /// Pins the fleet and every adapter each member declares: the fleet is
    /// exactly what `active_registry` says, and no member declares a hook
    /// adapter (lifecycle hooks are retired).
    #[test]
    fn the_enabled_provider_matrix_is_exact() {
        let registry = active_registry().unwrap();
        let (providers, adapters) = provider_contract_manifest(&registry).unwrap();
        assert_eq!(
            providers
                .iter()
                .map(|contract| contract.provider.as_str())
                .collect::<Vec<_>>(),
            // `shell` is the plain PTY provider (operator terminals and smoke tests).
            vec!["shell", "claude", "codex", "grok", "kimi"],
        );
        assert!(adapters.iter().all(|contract| {
            !matches!(contract.family, AdapterFamily::Hook | AdapterFamily::ManagedHook)
        }));
    }

    /// A gate-denied host request, WITH its reason text carried all the way
    /// from the ACP host, mints a `Blocked` chunk naming the gate.
    #[test]
    fn gate_denied_host_request_mints_a_blocked_chunk() {
        let gate_text =
            "blocked by dangerous-command gate: rule=filesystem-wipe, argument=rm -rf /";
        let event = denied_host_request(
            ProviderHostDecisionAuthority::Gate,
            Some(gate_text.to_owned()),
        );
        let chunk = agent_stream_chunk(&event).expect("expected a Blocked chunk");
        assert_eq!(chunk.source_sequence, 2);
        let (correlation_id, tool_class, authority, reason_kind, reason, help) = blocked(&event);
        assert_eq!(authority, BlockAuthorityV1::HostGate);
        assert_eq!(reason, gate_text);
        assert_eq!(correlation_id, None);
        assert_eq!(reason_kind, None);
        assert_eq!(help, None);
        assert_eq!(tool_class, "Write");
    }

    const CLASSIFIER_SAMPLE: &str = "Permission for this action was denied by the Claude Code auto mode classifier. Reason: Blocked by classifier. If you have other tasks that don't depend on this action, continue working on those. IMPORTANT: You *may* attempt to accomplish this action using other tools that might naturally be used to accomplish this goal, e.g. using head instead of cat. But you *should not* attempt to work around this denial in malicious ways, e.g. do not use your ability to run tests to execute non-test actions. You should only try to work around this restriction in reasonable ways that do not attempt to bypass the intent behind this denial. If you believe this capability is essential to complete the user's request, STOP and explain to the user what you were trying to do and why you need this permission. Let the user decide how to proceed. To allow this type of action in the future, the user can add a Bash permission rule to their settings.";

    /// The owner's classifier sample, verbatim, arriving as a
    /// `tool_call_update`-derived `ProviderEvent::ToolCompleted` with
    /// `non_execution_kind: "permission-rule"` -- mints a `Blocked` chunk with
    /// `authority: ProviderPermissionRule`, the `Reason:` sentence as `reason`
    /// and the guidance tail as `help`.
    #[test]
    fn classifier_sample_permission_rule_mints_a_blocked_chunk() {
        let event = provider_control_event(
            AdapterFamily::Acp,
            ProviderEvent::ToolCompleted {
                id: "toolu_9".to_owned(),
                output: CLASSIFIER_SAMPLE.to_owned(),
                is_error: true,
                duration_ms: None,
                agent_id: None,
                non_execution_kind: Some("permission-rule".to_owned()),
            },
        );
        let (correlation_id, _, authority, reason_kind, reason, help) = blocked(&event);
        assert_eq!(authority, BlockAuthorityV1::ProviderPermissionRule);
        assert_eq!(reason, "Blocked by classifier");
        assert_eq!(reason_kind, Some("permission-rule".to_owned()));
        assert!(help.as_deref().is_some_and(|help| help.starts_with("If you have other tasks")));
        assert!(correlation_id.is_some(), "a tool-correlated block must carry a correlation id");
    }

    /// A `session/prompt` RPC error with `data.codexErrorInfo:
    /// "usageLimitExceeded"` (measured live 2026-09-05) mints a `Blocked` chunk
    /// with `authority: ProviderQuota`, the message verbatim as `reason` and the
    /// vendor code as `reason_kind`.
    #[test]
    fn codex_quota_rpc_error_mints_a_blocked_chunk() {
        let message = "You've hit your usage limit. Upgrade to Pro (https://chatgpt.com/explore/pro), visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Sep 7th, 2026 6:19 PM.";
        let event = provider_control_event(
            AdapterFamily::Acp,
            ProviderEvent::SessionEnded {
                result: "JSON-RPC error -32603: Internal error".to_owned(),
                cost_usd: None,
                is_error: true,
                stop_reason: Some(ProviderStopReason::ProviderError {
                    code: -32603,
                    message: message.to_owned(),
                    vendor_code: Some("usageLimitExceeded".to_owned()),
                }),
            },
        );
        let (_, tool_class, authority, reason_kind, reason, _) = blocked(&event);
        assert_eq!(authority, BlockAuthorityV1::ProviderQuota);
        assert_eq!(reason, message);
        assert_eq!(reason_kind, Some("usageLimitExceeded".to_owned()));
        assert_eq!(tool_class, "Session");
    }

    /// ACP's `stopReason: "refusal"` mints a `Blocked` chunk with
    /// `authority: ProviderRefusal`.
    #[test]
    fn session_end_stop_reason_refusal_mints_a_blocked_chunk() {
        let event = provider_control_event(
            AdapterFamily::Acp,
            ProviderEvent::SessionEnded {
                result: "refusal".to_owned(),
                cost_usd: None,
                is_error: true,
                stop_reason: Some(ProviderStopReason::Refusal),
            },
        );
        let (_, _, authority, _, _, _) = blocked(&event);
        assert_eq!(authority, BlockAuthorityV1::ProviderRefusal);
    }

    /// A failed tool completion with no typed `non_execution_kind` -- or one
    /// that only says the turn stopped -- is a plain execution failure, never a
    /// block; nor is an agent's own narrative claiming one.
    #[test]
    fn failures_and_narrative_without_a_typed_block_mint_no_blocked_chunk() {
        for non_execution_kind in [None, Some("interrupted".to_owned()), Some("cancelled".to_owned())] {
            let event = provider_control_event(
                AdapterFamily::Acp,
                ProviderEvent::ToolCompleted {
                    id: "toolu_1".to_owned(),
                    output: "command exited with status 1".to_owned(),
                    is_error: true,
                    duration_ms: Some(12),
                    agent_id: None,
                    non_execution_kind,
                },
            );
            assert!(agent_stream_chunk(&event).is_none());
        }
        let narrative = provider_control_event(
            AdapterFamily::Acp,
            ProviderEvent::ToolCompleted {
                id: "toolu_2".to_owned(),
                output: "the harness blocked the write, approval needed".to_owned(),
                is_error: false,
                duration_ms: Some(3),
                agent_id: None,
                non_execution_kind: None,
            },
        );
        assert!(agent_stream_chunk(&narrative).is_none());
    }

    /// `Granted`/`Deferred` decisions never mint a `Blocked` chunk, whatever the
    /// execution outcome: a granted request that failed while running was
    /// still authorized.
    #[test]
    fn granted_and_deferred_host_requests_never_mint_a_blocked_chunk() {
        for (decision, outcome) in [
            (
                ProviderHostRequestDecision::Granted { by: ProviderHostDecisionAuthority::Policy },
                ProviderHostRequestOutcome::Executed,
            ),
            (ProviderHostRequestDecision::Deferred, ProviderHostRequestOutcome::Executed),
            (
                ProviderHostRequestDecision::Granted { by: ProviderHostDecisionAuthority::Policy },
                ProviderHostRequestOutcome::Failed {
                    error: "terminal/create spawn failed: os error 3".to_owned(),
                },
            ),
        ] {
            let event = provider_control_event_at(
                AdapterFamily::Acp,
                "claude-code",
                3,
                ProviderEvent::HostRequestObserved {
                    method: "fs/read_text_file".to_owned(),
                    params_json: String::new(),
                    decision: decision.clone(),
                    outcome,
                    reason: None,
                },
            );
            assert!(agent_stream_chunk(&event).is_none(), "{decision:?}");
        }
    }

    /// A deferred `session/request_permission` resolved by an operator or an
    /// expired deadline carries no reason text -- the chunk falls back to a
    /// categorical sentence naming the authority rather than inventing detail.
    #[test]
    fn denied_host_request_with_no_reason_falls_back_to_a_categorical_sentence() {
        for (by, expected_authority, expected_reason) in [
            (
                ProviderHostDecisionAuthority::Operator,
                BlockAuthorityV1::Operator,
                "declined by the operator",
            ),
            (
                ProviderHostDecisionAuthority::DeadlinePolicy,
                BlockAuthorityV1::HostDeadline,
                "denied by host policy after the operator deadline expired",
            ),
        ] {
            let (_, _, authority, _, reason, _) = blocked(&denied_host_request(by, None));
            assert_eq!(authority, expected_authority);
            assert_eq!(reason, expected_reason);
        }
    }

    /// An over-long reason is cut to the wire bound BEFORE the chunk is built,
    /// at a safe UTF-8 boundary -- `validate` rejects an over-long value
    /// outright rather than truncating.
    #[test]
    fn overlong_blocked_reason_is_truncated_to_the_wire_bound() {
        let oversized = "x".repeat(MAX_ACP_BLOCKED_REASON_BYTES + 500);
        let (_, _, _, _, reason, _) = blocked(&denied_host_request(
            ProviderHostDecisionAuthority::Policy,
            Some(oversized),
        ));
        assert!(reason.len() <= MAX_ACP_BLOCKED_REASON_BYTES);
    }
}

#[cfg(test)]
mod standalone_capability_platform_tests {
    use super::*;

    #[test]
    fn standalone_workspace_capability_requires_windows_identity_guards() {
        let capabilities = baseline_capabilities().unwrap();
        let advertised = capabilities.iter().any(|capability| {
            capability.as_str() == NODE_STANDALONE_WORKSPACE_LIFECYCLE_CAPABILITY
        });
        assert_eq!(advertised, cfg!(windows));

        let request = NodeRequest::CreateStandaloneWorkspace {
            workspace_id: WorkspaceId::new("standalone-platform").unwrap(),
            root: OpaqueHostPath::utf8("standalone-platform-root".to_owned()).unwrap(),
            initial_branch: None,
        };
        assert_eq!(
            request_uses_unnegotiated_capability(&request, &capabilities),
            !cfg!(windows),
        );
    }
}


#[cfg(test)]
mod station_knobs_resolve_tests {
    use super::*;
    use gate4agent_catalog::EnvMutation;
    use gate4agent_runtime_native::{
        NativeChildEnvironmentResolveError, NativeChildEnvironmentResolver, NativeLaunchProfile,
        NativeLaunchProfileId,
    };
    use std::ffi::OsString;
    use std::sync::Arc;

    struct EmptyEnvironmentResolver;

    impl NativeChildEnvironmentResolver for EmptyEnvironmentResolver {
        fn resolve_child_environment(
            &self,
        ) -> Result<Vec<EnvMutation>, NativeChildEnvironmentResolveError> {
            Ok(vec![EnvMutation {
                key: OsString::from("GATE4AGENT_TEST_PROFILE"),
                value: None,
            }])
        }
    }

    fn agent(value: &str) -> AgentId {
        AgentId::new(value).unwrap()
    }

    fn station_knobs_fixture() -> (NodeShared, crate::protocol::SpawnProfileDefaults) {
        let profile_id = SpawnEnvironmentProfileId::new("local-claude").unwrap();
        let profile_revision =
            crate::protocol::SpawnEnvironmentProfileRevision::new("local-claude-r1").unwrap();
        let spawn_defaults = crate::protocol::SpawnProfileDefaults {
            profile_id: crate::protocol::SpawnProfileId::new("default").unwrap(),
            revision: crate::protocol::SpawnProfileRevision::new("test-r1").unwrap(),
            provider: agent("claude"),
            mode: SessionMode::Pty,
            terminal_size: gate4agent_types::TerminalSize {
                rows: 24,
                columns: 80,
            },
            prompt: None,
            bundle_id: None,
            context_id: None,
            environment_profile_id: Some(profile_id.clone()),
        };
        let spawn_profiles = SpawnProfileRegistry::new([spawn_defaults.clone()]).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let control = runtime.native_launch_profile_control();
        let node_profile = NodeEnvironmentProfile::new(
            profile_id.clone(),
            profile_revision,
            agent("claude"),
            [NativeLaunchProfile::new(
                NativeLaunchProfileId::new("local-claude-pty").unwrap(),
                agent("claude"),
                TransportKind::Pty,
                vec![OsString::from("GATE4AGENT_TEST_PROFILE")],
                Arc::new(EmptyEnvironmentResolver),
            )
            .unwrap()],
        )
        .unwrap();
        let (binding, native_profiles, _materialization) = node_profile.into_parts();
        for native_profile in native_profiles {
            runtime.upsert_native_launch_profile(native_profile).unwrap();
        }
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-station-knobs-test").unwrap(),
            NodeIncarnationId::from_bytes([9; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            spawn_profiles,
            Some(control),
            None,
            None,
            None,
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(binding.id.clone(), binding);
        (shared, spawn_defaults)
    }

    /// Empty-default catalog refuses unknown network_allowlist ids.
    /// Feature-off dig2-station-probe keeps browser_profile stub echo.
    #[test]
    fn resolve_environment_profile_refuses_unknown_network_allowlist() {
        let (shared, defaults) = station_knobs_fixture();
        let unknown = crate::protocol::SpawnNetworkAllowlistId::new("not-registered").unwrap();
        let browser = crate::protocol::SpawnBrowserProfileId::new("station-profile-a").unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                network_allowlist: Some(unknown),
                browser_profile_id: Some(browser),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new(
                "station-knobs-unknown-allowlist",
            )
            .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        let failure = shared
            .resolve_environment_profile(&resolved)
            .expect_err("unknown allowlist must refuse");
        assert_eq!(failure.code, NodeFailureCode::UnknownNetworkAllowlist);
    }

    /// Registered network_allowlist (+ browser_profile_id when feature off)
    /// echo onto the env-profile receipt. Empty catalog still allows omit
    /// (None). Empty/whitespace refuse is type-level. Feature-off
    /// dig2-station-probe keeps stub browser echo; feature-on refuse is
    /// covered by `…_refuses_browser_profile_when_station_probe_fails`.
    #[test]
    fn resolve_environment_profile_echoes_registered_station_network_and_browser_knobs() {
        let (shared, defaults) = station_knobs_fixture();
        let allowlist = crate::protocol::SpawnNetworkAllowlistId::new("egress-default").unwrap();
        #[cfg(not(feature = "dig2-station-probe"))]
        let browser = crate::protocol::SpawnBrowserProfileId::new("station-profile-a").unwrap();
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert_id(allowlist.clone())
            .unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                network_allowlist: Some(allowlist.clone()),
                #[cfg(not(feature = "dig2-station-probe"))]
                browser_profile_id: Some(browser.clone()),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new("station-knobs-echo")
                .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        assert_eq!(resolved.network_allowlist.as_ref(), Some(&allowlist));
        #[cfg(not(feature = "dig2-station-probe"))]
        assert_eq!(resolved.browser_profile_id.as_ref(), Some(&browser));
        let receipt = shared
            .resolve_environment_profile(&resolved)
            .expect("resolve ok")
            .expect("env profile present");
        assert_eq!(receipt.network_allowlist.as_ref(), Some(&allowlist));
        #[cfg(not(feature = "dig2-station-probe"))]
        assert_eq!(receipt.browser_profile_id.as_ref(), Some(&browser));
        #[cfg(feature = "dig2-station-probe")]
        assert_eq!(receipt.browser_profile_id, None);
        assert_eq!(receipt.profile_id.as_str(), "local-claude");

        let omitted = crate::protocol::SpawnSpec {
            overrides: crate::protocol::SpawnOverrides::default(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new("station-knobs-omit")
                .unwrap(),
            ..spec
        };
        let resolved_omit = omitted.resolve(&defaults).unwrap();
        let bare = shared
            .resolve_environment_profile(&resolved_omit)
            .expect("resolve ok")
            .expect("env profile present");
        assert_eq!(bare.network_allowlist, None);
        assert_eq!(bare.browser_profile_id, None);
    }

    /// Feature `dig2-station-probe`: browser_profile_id set refuses when the
    /// cheap station probe cannot succeed. On non-Windows (this CI host) that
    /// is `BrowserStationProbeUnavailable`. Never cookies on C2. Lease map is
    /// unit-tested separately (probe refuses before lease on Linux).
    #[cfg(feature = "dig2-station-probe")]
    #[test]
    fn resolve_environment_profile_refuses_browser_profile_when_station_probe_fails() {
        let (shared, defaults) = station_knobs_fixture();
        let browser = crate::protocol::SpawnBrowserProfileId::new("station-profile-a").unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                browser_profile_id: Some(browser),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new(
                "station-knobs-probe-refuse",
            )
            .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        let failure = shared
            .resolve_environment_profile(&resolved)
            .expect_err("browser_profile with failing probe must refuse");
        #[cfg(windows)]
        {
            assert!(
                matches!(
                    failure.code,
                    NodeFailureCode::BrowserStationUnreachable
                        | NodeFailureCode::BrowserStationProbeUnavailable
                ),
                "unexpected code {:?}",
                failure.code
            );
        }
        #[cfg(not(windows))]
        {
            assert_eq!(
                failure.code,
                NodeFailureCode::BrowserStationProbeUnavailable
            );
        }
    }

    /// Feature on: omitting browser_profile_id still resolves (no probe).
    #[cfg(feature = "dig2-station-probe")]
    #[test]
    fn resolve_environment_profile_skips_station_probe_when_browser_profile_omitted() {
        let (shared, defaults) = station_knobs_fixture();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides::default(),
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new(
                "station-knobs-probe-omit",
            )
            .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        let receipt = shared
            .resolve_environment_profile(&resolved)
            .expect("omit browser_profile must not probe")
            .expect("env profile present");
        assert_eq!(receipt.browser_profile_id, None);
    }

    /// Feature dig2-station-probe: exclusive BrowserStationLease on NodeShared
    /// refuses a second holder for the same opaque profile id; release on
    /// remove_binding allows reacquire. Never ImportSession/cookies on C2.
    #[cfg(feature = "dig2-station-probe")]
    #[test]
    fn browser_station_lease_exclusive_and_clears_on_remove_binding() {
        let (shared, _defaults) = station_knobs_fixture();
        let profile = crate::protocol::SpawnBrowserProfileId::new("station-profile-a").unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let address_a = SessionAddress {
            workspace_id: workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(101),
                generation: SessionGeneration(1),
            },
        };
        let address_b = SessionAddress {
            workspace_id: workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(102),
                generation: SessionGeneration(1),
            },
        };
        let guard_a = crate::dig2_station_lease::acquire_lease(
            &shared.browser_station_leases,
            profile.clone(),
            address_a.session.instance_id,
            1,
        )
        .expect("first lease");
        let busy = crate::dig2_station_lease::acquire_lease(
            &shared.browser_station_leases,
            profile.clone(),
            address_b.session.instance_id,
            2,
        )
        .expect_err("second holder must refuse");
        assert!(matches!(
            busy,
            crate::dig2_station_lease::BrowserStationLeaseError::ProfileBusy { .. }
        ));
        // Simulate a bound session so remove_binding clears the lease.
        shared.bind_session_with_policy(
            &address_a,
            ProviderRuntimePolicy::raw_pty(),
            None,
        );
        guard_a.retain();
        assert!(shared.remove_binding(&address_a).is_some());
        crate::dig2_station_lease::acquire_lease(
            &shared.browser_station_leases,
            profile,
            address_b.session.instance_id,
            3,
        )
        .expect("reacquire after clear")
        .retain();
        assert!(
            crate::dig2_station_lease::release_lease_for_holder(
                &shared.browser_station_leases,
                address_b.session.instance_id,
            )
        );
    }

    /// Feature-off: no browser_station_leases field; stub echo documented in
    /// resolve_environment_profile_echoes_registered_station_network_and_browser_knobs.
    #[cfg(not(feature = "dig2-station-probe"))]
    #[test]
    fn browser_station_lease_feature_off_keeps_stub_without_lease_table() {
        let (shared, defaults) = station_knobs_fixture();
        let browser = crate::protocol::SpawnBrowserProfileId::new("station-profile-a").unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                browser_profile_id: Some(browser.clone()),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new("lease-stub-off")
                .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        let receipt = shared
            .resolve_environment_profile(&resolved)
            .expect("stub resolve")
            .expect("env profile");
        assert_eq!(receipt.browser_profile_id.as_ref(), Some(&browser));
    }


    /// Startup file loader registers ids into the empty-default catalog.
    /// Feature-off dig2 probe stays stub. Never secrets on C2.
    #[test]
    fn network_allowlist_catalog_loads_from_temp_file() {
        let unique = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap()
            .as_nanos();
        let path = std::env::temp_dir().join(format!(
            "gate4agent-node-allowlist-config-{}-{unique}.txt",
            std::process::id(),
        ));
        std::fs::write(
            &path,
            "# opaque station allowlist ids\negress-default\nlab-egress\n",
        )
        .unwrap();
        let loaded = crate::network_allowlist_catalog::load_network_allowlist_catalog_file(&path)
            .expect("temp catalog file must load");
        let _ = std::fs::remove_file(&path);
        assert_eq!(loaded.len(), 2);
        let (shared, defaults) = station_knobs_fixture();
        {
            let mut catalog = shared
                .network_allowlist_catalog
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            *catalog = loaded;
        }
        let allowlist = crate::protocol::SpawnNetworkAllowlistId::new("egress-default").unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                network_allowlist: Some(allowlist.clone()),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new(
                "station-knobs-catalog-file",
            )
            .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        let receipt = shared
            .resolve_environment_profile(&resolved)
            .expect("registered via file load")
            .expect("env profile present");
        assert_eq!(receipt.network_allowlist.as_ref(), Some(&allowlist));
    }

    /// Snapshot launch inventory echoes registered catalog ids (opaque).
    /// Dig2 station probe is orthogonal (feature `dig2-station-probe`). Never secrets on C2.
    #[test]
    fn snapshot_launch_inventory_lists_network_allowlist_catalog_ids() {
        let (shared, _defaults) = station_knobs_fixture();
        let allowlist = crate::protocol::SpawnNetworkAllowlistId::new("egress-default").unwrap();
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert_id(allowlist.clone())
            .unwrap();
        let snapshot = shared.snapshot();
        let inventory = snapshot
            .launch_inventory
            .expect("launch inventory present");
        let ids = inventory
            .network_allowlists
            .expect("non-empty catalog surfaces ids");
        assert_eq!(ids, vec![allowlist]);
    }

    /// Track B: registered id with provider_native codex_network_access refuses
    /// clearly for Claude (fixture provider). Unknown id still UnknownNetworkAllowlist.
    /// Never secrets on C2. Codex Moderate maps to `-c` overlay; RO/FullAuto refuse.
    #[test]
    fn resolve_environment_profile_refuses_unsupported_provider_native_mapping() {
        let (shared, defaults) = station_knobs_fixture();
        let allowlist = crate::protocol::SpawnNetworkAllowlistId::new("egress-codex-only").unwrap();
        let entry = crate::network_allowlist_catalog::NetworkAllowlistEntry {
            id: allowlist.clone(),
            permits: vec![crate::network_allowlist_catalog::NetworkPermitSketch {
                protocol: crate::network_allowlist_catalog::NetworkPermitProtocol::Tcp,
                peer: "127.0.0.1:443".to_owned(),
            }],
            provider_native: Some(
                crate::network_allowlist_catalog::ProviderNativeNetworkSketch {
                    codex_network_access: Some(true),
                },
            ),
        };
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(entry)
            .unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                network_allowlist: Some(allowlist),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new(
                "station-knobs-unsupported-mapping",
            )
            .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        assert_eq!(resolved.provider.as_str(), "claude");
        let failure = shared
            .resolve_environment_profile(&resolved)
            .expect_err("claude + codex_network_access must refuse");
        assert_eq!(
            failure.code,
            NodeFailureCode::UnsupportedNetworkAllowlistMapping
        );
    }

    /// Codex Moderate + codex_network_access yields `-c` overlay argv.
    /// ReadOnly / FullAuto refuse UnsupportedNetworkAllowlistMapping.
    /// Never secrets on C2.
    #[test]
    fn resolve_codex_network_access_overlay_moderate_only() {
        let (shared, defaults) = station_knobs_fixture();
        let allowlist = crate::protocol::SpawnNetworkAllowlistId::new("egress-codex-net").unwrap();
        let entry = crate::network_allowlist_catalog::NetworkAllowlistEntry {
            id: allowlist.clone(),
            permits: Vec::new(),
            provider_native: Some(
                crate::network_allowlist_catalog::ProviderNativeNetworkSketch {
                    codex_network_access: Some(true),
                },
            ),
        };
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(entry)
            .unwrap();

        let overlay = shared
            .resolve_codex_network_access_overlay_args(
                &agent("codex"),
                SessionMode::Pty,
                ApprovalLevel::Moderate,
                Some(&allowlist),
            )
            .expect("Moderate Codex maps network_access");
        assert_eq!(
            overlay,
            vec![
                std::ffi::OsString::from("-c"),
                std::ffi::OsString::from("sandbox_workspace_write.network_access=true"),
            ]
        );

        let acp = shared
            .resolve_codex_network_access_overlay_args(
                &agent("codex"),
                SessionMode::Acp,
                ApprovalLevel::Moderate,
                Some(&allowlist),
            )
            .unwrap();
        assert_eq!(acp, overlay);

        let inline = shared
            .resolve_codex_network_access_overlay_args(
                &agent("codex"),
                SessionMode::Inline,
                ApprovalLevel::Moderate,
                Some(&allowlist),
            )
            .unwrap_err();
        assert_eq!(
            inline.code,
            NodeFailureCode::UnsupportedNetworkAllowlistMapping
        );

        for level in [ApprovalLevel::ReadOnly, ApprovalLevel::FullAuto] {
            let spec = crate::protocol::SpawnSpec {
                target: crate::protocol::SpawnTarget {
                    node_id: shared.node_id.clone(),
                    workspace_id: WorkspaceId::new("primary").unwrap(),
                    worktree_id: None,
                },
                profile_id: defaults.profile_id.clone(),
                expected_profile_revision: defaults.revision.clone(),
                overrides: crate::protocol::SpawnOverrides {
                    provider: crate::protocol::SpawnOverride::Set {
                        value: agent("codex"),
                    },
                    approval_level: Some(level),
                    network_allowlist: Some(allowlist.clone()),
                    ..crate::protocol::SpawnOverrides::default()
                },
                deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
                idempotency_key: crate::protocol::SpawnIdempotencyKey::new(format!(
                    "codex-net-refuse-{}",
                    match level {
                        ApprovalLevel::ReadOnly => "ro",
                        ApprovalLevel::FullAuto => "fa",
                        _ => "other",
                    }
                ))
                .unwrap(),
                required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
            };
            let resolved = spec.resolve(&defaults).unwrap();
            let failure = shared
                .resolve_environment_profile(&resolved)
                .expect_err("RO/FullAuto must refuse");
            assert_eq!(
                failure.code,
                NodeFailureCode::UnsupportedNetworkAllowlistMapping
            );
        }
    }

    /// Claude PTY + catalog permits → ProviderHome `--settings` sidecar with
    /// sandbox.network.allowedDomains. ACP / missing ProviderHome refuse.
    /// Never secrets on C2; does not invent provider_native Claude keys.
    #[test]
    fn resolve_claude_settings_network_overlay_pty_writes_sidecar() {
        let (shared, _defaults) = station_knobs_fixture();
        let allowlist =
            crate::protocol::SpawnNetworkAllowlistId::new("egress-claude-domains").unwrap();
        let entry = crate::network_allowlist_catalog::NetworkAllowlistEntry {
            id: allowlist.clone(),
            permits: vec![
                crate::network_allowlist_catalog::NetworkPermitSketch {
                    protocol: crate::network_allowlist_catalog::NetworkPermitProtocol::Tcp,
                    peer: "github.com:443".to_owned(),
                },
                crate::network_allowlist_catalog::NetworkPermitSketch {
                    protocol: crate::network_allowlist_catalog::NetworkPermitProtocol::Tcp,
                    peer: "*.npmjs.org".to_owned(),
                },
            ],
            provider_native: None,
        };
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(entry)
            .unwrap();

        let unique = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap()
            .as_nanos();
        let provider_home = std::env::temp_dir().join(format!(
            "gate4agent-claude-provider-home-{}-{unique}",
            std::process::id(),
        ));
        std::fs::create_dir_all(&provider_home).unwrap();

        let overlay = shared
            .resolve_network_allowlist_overlay_args(
                &agent("claude"),
                SessionMode::Pty,
                ApprovalLevel::Moderate,
                Some(&allowlist),
                Some(provider_home.as_path()),
            )
            .expect("Claude PTY settings overlay on unix");
        let settings_path = provider_home.join(
            crate::network_allowlist_catalog::CLAUDE_STATION_NETWORK_SETTINGS_FILE,
        );
        assert_eq!(
            overlay,
            vec![
                std::ffi::OsString::from("--settings"),
                std::ffi::OsString::from(settings_path.as_os_str()),
            ]
        );
        let body = std::fs::read_to_string(&settings_path).unwrap();
        let value: serde_json::Value = serde_json::from_str(&body).unwrap();
        assert_eq!(value["sandbox"]["enabled"], true);
        assert_eq!(
            value["sandbox"]["network"]["allowedDomains"],
            serde_json::json!(["github.com", "*.npmjs.org"])
        );
        assert!(settings_path.starts_with(&provider_home));

        let acp = shared
            .resolve_network_allowlist_overlay_args(
                &agent("claude"),
                SessionMode::Acp,
                ApprovalLevel::Moderate,
                Some(&allowlist),
                Some(provider_home.as_path()),
            )
            .expect_err("Claude ACP must refuse settings overlay");
        assert_eq!(
            acp.code,
            NodeFailureCode::UnsupportedNetworkAllowlistMapping
        );

        let no_home = shared
            .resolve_network_allowlist_overlay_args(
                &agent("claude"),
                SessionMode::Pty,
                ApprovalLevel::Moderate,
                Some(&allowlist),
                None,
            )
            .expect_err("Claude overlay requires ProviderHome");
        assert_eq!(
            no_home.code,
            NodeFailureCode::UnsupportedNetworkAllowlistMapping
        );

        let bare = crate::protocol::SpawnNetworkAllowlistId::new("egress-claude-bare").unwrap();
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert_id(bare.clone())
            .unwrap();
        let empty = shared
            .resolve_network_allowlist_overlay_args(
                &agent("claude"),
                SessionMode::Pty,
                ApprovalLevel::Moderate,
                Some(&bare),
                Some(provider_home.as_path()),
            )
            .unwrap();
        assert!(empty.is_empty());

        let _ = std::fs::remove_dir_all(&provider_home);
    }

    /// Kimi / Grok with permits stay without invented argv overlays.
    #[test]
    fn resolve_kimi_grok_network_overlay_stays_empty_without_native() {
        let (shared, _defaults) = station_knobs_fixture();
        let allowlist =
            crate::protocol::SpawnNetworkAllowlistId::new("egress-kimi-permits").unwrap();
        let entry = crate::network_allowlist_catalog::NetworkAllowlistEntry {
            id: allowlist.clone(),
            permits: vec![crate::network_allowlist_catalog::NetworkPermitSketch {
                protocol: crate::network_allowlist_catalog::NetworkPermitProtocol::Tcp,
                peer: "example.com:443".to_owned(),
            }],
            provider_native: None,
        };
        shared
            .network_allowlist_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(entry)
            .unwrap();
        for provider in ["kimi", "grok"] {
            let overlay = shared
                .resolve_network_allowlist_overlay_args(
                    &agent(provider),
                    SessionMode::Pty,
                    ApprovalLevel::Moderate,
                    Some(&allowlist),
                    None,
                )
                .unwrap();
            assert!(
                overlay.is_empty(),
                "{provider} must not invent network argv from permits"
            );
        }
    }

    /// Track B: JSON v2 catalog file loads permits; inventory still ids only.
    #[test]
    fn network_allowlist_catalog_loads_json_v2_and_lists_ids_only() {
        let unique = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap()
            .as_nanos();
        let path = std::env::temp_dir().join(format!(
            "gate4agent-node-allowlist-json-{}-{unique}.json",
            std::process::id(),
        ));
        std::fs::write(
            &path,
            r#"{
              "schema_version": 2,
              "entries": [
                {
                  "id": "egress-default",
                  "permits": [{ "protocol": "tcp", "peer": "127.0.0.1:443" }]
                },
                { "id": "lab-egress" }
              ]
            }"#,
        )
        .unwrap();
        let loaded = crate::network_allowlist_catalog::load_network_allowlist_catalog_file(&path)
            .expect("json v2 catalog must load");
        let _ = std::fs::remove_file(&path);
        assert_eq!(loaded.len(), 2);
        let entry = loaded
            .get(&crate::protocol::SpawnNetworkAllowlistId::new("egress-default").unwrap())
            .unwrap();
        assert_eq!(entry.permits.len(), 1);
        let (shared, defaults) = station_knobs_fixture();
        {
            let mut catalog = shared
                .network_allowlist_catalog
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            *catalog = loaded;
        }
        let allowlist = crate::protocol::SpawnNetworkAllowlistId::new("egress-default").unwrap();
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: shared.node_id.clone(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: defaults.profile_id.clone(),
            expected_profile_revision: defaults.revision.clone(),
            overrides: crate::protocol::SpawnOverrides {
                network_allowlist: Some(allowlist.clone()),
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new(
                "station-knobs-catalog-json",
            )
            .unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let resolved = spec.resolve(&defaults).unwrap();
        let receipt = shared
            .resolve_environment_profile(&resolved)
            .expect("permits-only entry ok for claude")
            .expect("env profile present");
        assert_eq!(receipt.network_allowlist.as_ref(), Some(&allowlist));
        let inventory = shared
            .snapshot()
            .launch_inventory
            .expect("launch inventory present");
        let ids = inventory.network_allowlists.expect("ids surface");
        assert_eq!(
            ids,
            vec![
                crate::protocol::SpawnNetworkAllowlistId::new("egress-default").unwrap(),
                crate::protocol::SpawnNetworkAllowlistId::new("lab-egress").unwrap(),
            ]
        );
    }


}


#[cfg(test)]
mod workspace_environment_collision_tests {
    use super::*;
    use crate::session_environment::{
        NodeSessionMaterializationProfile, NodeSessionPathBinding, NodeSessionPathClass,
    };
    use gate4agent_catalog::EnvMutation;
    use gate4agent_runtime_native::{
        NativeChildEnvironmentResolveError, NativeChildEnvironmentResolver, NativeLaunchProfile,
        NativeLaunchProfileId,
    };
    use std::ffi::OsString;
    use std::sync::Arc;

    struct EmptyEnvironmentResolver;

    impl NativeChildEnvironmentResolver for EmptyEnvironmentResolver {
        fn resolve_child_environment(
            &self,
        ) -> Result<Vec<EnvMutation>, NativeChildEnvironmentResolveError> {
            Ok(vec![EnvMutation {
                key: OsString::from("GATE4AGENT_TEST_PROFILE"),
                value: None,
            }])
        }
    }

    fn agent(value: &str) -> AgentId {
        AgentId::new(value).unwrap()
    }

    /// Two Claude ProviderHome profiles (`CLAUDE_CONFIG_DIR` A vs B) on one node.
    fn claude_config_dir_collision_fixture() -> (
        NodeShared,
        ResolvedEnvironmentProfileReceipt,
        ResolvedEnvironmentProfileReceipt,
    ) {
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let control = runtime.native_launch_profile_control();
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-env-collision-test").unwrap(),
            NodeIncarnationId::from_bytes([3; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            Some(control),
            None,
            None,
            None,
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );

        let mut receipts = Vec::new();
        for (suffix, native_suffix) in [("a", "a-pty"), ("b", "b-pty")] {
            let profile_id =
                SpawnEnvironmentProfileId::new(format!("claude-config-dir-{suffix}")).unwrap();
            let profile_revision = crate::protocol::SpawnEnvironmentProfileRevision::new(format!(
                "claude-config-dir-{suffix}-r1"
            ))
            .unwrap();
            let materialization = NodeSessionMaterializationProfile::new(
                Vec::new(),
                vec![NodeSessionPathBinding::new(
                    "CLAUDE_CONFIG_DIR",
                    NodeSessionPathClass::ProviderHome,
                )
                .unwrap()],
                Vec::new(),
            )
            .unwrap();
            let node_profile = NodeEnvironmentProfile::new_with_materialization(
                profile_id.clone(),
                profile_revision.clone(),
                agent("claude"),
                [NativeLaunchProfile::new(
                    NativeLaunchProfileId::new(format!("claude-config-dir-{native_suffix}"))
                        .unwrap(),
                    agent("claude"),
                    TransportKind::Pty,
                    vec![OsString::from("GATE4AGENT_TEST_PROFILE")],
                    Arc::new(EmptyEnvironmentResolver),
                )
                .unwrap()],
                Some(materialization),
            )
            .unwrap();
            let (binding, native_profiles, materialization) = node_profile.into_parts();
            for native_profile in native_profiles {
                runtime.upsert_native_launch_profile(native_profile).unwrap();
            }
            shared
                .environment_profiles
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(binding.id.clone(), binding);
            shared
                .environment_materialization_profiles
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(profile_id.clone(), materialization.unwrap());
            receipts.push(ResolvedEnvironmentProfileReceipt {
                profile_id,
                profile_revision,
                network_allowlist: None,
                browser_profile_id: None,
            });
        }
        let profile_b = receipts.pop().unwrap();
        let profile_a = receipts.pop().unwrap();
        (shared, profile_a, profile_b)
    }

    #[test]
    fn refuse_distinct_claude_config_dir_profiles_on_same_workspace_cwd() {
        let (shared, profile_a, profile_b) = claude_config_dir_collision_fixture();
        let primary = WorkspaceId::new("primary").unwrap();
        let worktree = WorkspaceId::new("worktree-b").unwrap();
        let address = SessionAddress {
            workspace_id: primary.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(41),
                generation: SessionGeneration(1),
            },
        };
        shared.bind_session_with_policy(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(profile_a.clone()),
        );

        let refused = shared
            .ensure_workspace_environment_profile_compatible(&primary, Some(&profile_b))
            .unwrap_err();
        assert_eq!(refused.code, NodeFailureCode::WorkspaceBusy);

        // Some vs None on the same cwd is also a collision.
        let refused_none = shared
            .ensure_workspace_environment_profile_compatible(&primary, None)
            .unwrap_err();
        assert_eq!(refused_none.code, NodeFailureCode::WorkspaceBusy);

        // Same profile on the same workspace remains allowed.
        shared
            .ensure_workspace_environment_profile_compatible(&primary, Some(&profile_a))
            .unwrap();

        // Distinct workspace id (managed-worktree parallel path) allows profile B.
        shared
            .ensure_workspace_environment_profile_compatible(&worktree, Some(&profile_b))
            .unwrap();
    }

    #[tokio::test]
    async fn spawn_session_refuses_conflicting_environment_profile_before_mutation() {
        let (shared, profile_a, profile_b) = claude_config_dir_collision_fixture();
        let primary = WorkspaceId::new("primary").unwrap();
        let address = SessionAddress {
            workspace_id: primary.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(41),
                generation: SessionGeneration(1),
            },
        };
        shared.bind_session_with_policy(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(profile_a),
        );

        let failure = shared
            .spawn_session_with_deadline(
                primary,
                agent("claude"),
                SessionMode::Pty,
                gate4agent_types::TerminalSize {
                    rows: 24,
                    columns: 80,
                },
                None,
                Some(profile_b),
                None,
                None,
                None,
                None,
                SpawnRecordPolicy::ProviderIdentityOnly,
                Some(Instant::now() + Duration::from_secs(30)),
                &[],
                None,
                ApprovalLevel::default(),
                None,
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::WorkspaceBusy);
        // Guard runs before instance id mint / bind.
        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 1);
        assert!(shared.handle.snapshot().sessions.is_empty());
    }
}

#[cfg(test)]
mod spawn_characterization_tests {
    use super::*;
    use crate::session_environment::{
        NodeSecretReference, NodeSecretResolveError, NodeSecretValue,
        NodeSessionEnvironmentMutation, NodeSessionFile, NodeSessionPathBinding,
        NodeSessionPathClass,
    };
    use gate4agent_catalog::EnvMutation;
    use gate4agent_runtime_native::{
        NativeChildEnvironmentResolveError, NativeChildEnvironmentResolver,
        NativeLaunchProfile, NativeLaunchProfileId,
    };
    use std::ffi::OsString;
    use std::sync::Arc;

    struct EmptyEnvironmentResolver;

    struct FixtureSecretResolver {
        deny: Arc<AtomicBool>,
    }

    impl NodeSecretResolver for FixtureSecretResolver {
        fn resolve(
            &self,
            _reference: &NodeSecretReference,
        ) -> Result<NodeSecretValue, NodeSecretResolveError> {
            if self.deny.load(Ordering::Acquire) {
                Err(NodeSecretResolveError::Denied)
            } else {
                NodeSecretValue::text("fixture-secret")
                    .map_err(|_| NodeSecretResolveError::Unavailable)
            }
        }
    }

    impl NativeChildEnvironmentResolver for EmptyEnvironmentResolver {
        fn resolve_child_environment(
            &self,
        ) -> Result<Vec<EnvMutation>, NativeChildEnvironmentResolveError> {
            Ok(vec![EnvMutation {
                key: OsString::from("GATE4AGENT_TEST_PROFILE"),
                value: None,
            }])
        }
    }

    fn agent(value: &str) -> AgentId {
        AgentId::new(value).unwrap()
    }

    fn temporary_workspace_root(label: &str) -> std::path::PathBuf {
        let unique = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap()
            .as_nanos();
        std::env::temp_dir().join(format!(
            "gate4agent-node-{label}-{}-{unique}",
            std::process::id(),
        ))
    }

    fn materialization_test_shared(
        deny_secret: bool,
    ) -> (
        NodeShared,
        NativeRuntime,
        ResolvedEnvironmentProfileReceipt,
        PathBuf,
        Arc<AtomicBool>,
    ) {
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        materialization_test_shared_with_workspace(deny_secret, workspace)
    }

    fn materialization_test_shared_with_workspace(
        deny_secret: bool,
        workspace: WorkspaceConfig,
    ) -> (
        NodeShared,
        NativeRuntime,
        ResolvedEnvironmentProfileReceipt,
        PathBuf,
        Arc<AtomicBool>,
    ) {
        let root = temporary_workspace_root(if deny_secret {
            "materialization-denied"
        } else {
            "materialization-ready"
        });
        std::fs::create_dir_all(&root).unwrap();
        let materialization_root = root.join("session-environments");
        let deny = Arc::new(AtomicBool::new(deny_secret));
        let resolver = Arc::new(FixtureSecretResolver {
            deny: Arc::clone(&deny),
        });
        let materializer = SessionEnvironmentMaterializer::new(
            materialization_root,
            resolver,
        )
        .unwrap();
        let profile_id = SpawnEnvironmentProfileId::new("materialized-claude").unwrap();
        let profile_revision = crate::protocol::SpawnEnvironmentProfileRevision::new(
            "materialized-claude-r1",
        )
        .unwrap();
        let materialization = NodeSessionMaterializationProfile::new(
            vec![NodeSessionEnvironmentMutation::SetSecret {
                key: "GATE4AGENT_SESSION_TOKEN".to_owned(),
                reference: NodeSecretReference::new("fixture-token").unwrap(),
            }],
            vec![NodeSessionPathBinding::new(
                "GATE4AGENT_PROVIDER_HOME",
                NodeSessionPathClass::ProviderHome,
            )
            .unwrap()],
            vec![NodeSessionFile::secret(
                NodeSessionPathClass::Config,
                "auth/token",
                NodeSecretReference::new("fixture-token").unwrap(),
            )
            .unwrap()],
        )
        .unwrap();
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let control = runtime.native_launch_profile_control();
        let node_profile = NodeEnvironmentProfile::new_with_materialization(
            profile_id.clone(),
            profile_revision.clone(),
            agent("claude"),
            [NativeLaunchProfile::new(
                NativeLaunchProfileId::new("materialized-claude-pty").unwrap(),
                agent("claude"),
                TransportKind::Pty,
                vec![OsString::from("GATE4AGENT_TEST_PROFILE")],
                Arc::new(EmptyEnvironmentResolver),
            )
            .unwrap()],
            Some(materialization),
        )
        .unwrap();
        let (binding, native_profiles, materialization) = node_profile.into_parts();
        for native_profile in native_profiles {
            runtime.upsert_native_launch_profile(native_profile).unwrap();
        }
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-materialization-test").unwrap(),
            NodeIncarnationId::from_bytes([9; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            Some(control),
            None,
            Some(materializer),
            None,
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(binding.id.clone(), binding);
        shared
            .environment_materialization_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(profile_id.clone(), materialization.unwrap());
        (
            shared,
            runtime,
            ResolvedEnvironmentProfileReceipt {
                profile_id,
                profile_revision,
                network_allowlist: None,
                browser_profile_id: None,
            },
            root,
            deny,
        )
    }


    // ---- Characterization of the spawn preparation block (pre-SpawnPreparer) ----

    async fn characterization_spawn(
        shared: &NodeShared,
        mode: SessionMode,
        environment_profile: Option<ResolvedEnvironmentProfileReceipt>,
        required: &[ProviderRuntimeCapability],
        harness_mcp: Option<&PreparedHarnessMcpSpawn>,
    ) -> Result<(SessionAddress, ProviderRuntimePolicy), NodeFailure> {
        shared
            .spawn_session_with_deadline(
                WorkspaceId::new("primary").unwrap(),
                agent("claude"),
                mode,
                gate4agent_types::TerminalSize { rows: 24, columns: 80 },
                None,
                environment_profile,
                None,
                None,
                None,
                Some(ProviderRuntimePolicy::raw_pty()),
                SpawnRecordPolicy::ProviderIdentityOnly,
                Some(Instant::now() + Duration::from_secs(30)),
                required,
                harness_mcp,
                ApprovalLevel::default(),
                None,
                None,
            )
            .await
    }

    fn assert_no_session_state(shared: &NodeShared) {
        assert!(shared.handle.snapshot().sessions.is_empty());
        assert!(shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        assert!(shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
    }

    #[tokio::test]
    async fn spawn_unadmitted_required_capability_refuses_before_id_mint() {
        let (shared, runtime, _receipt, root, _deny) = materialization_test_shared(false);
        let error = characterization_spawn(
            &shared,
            SessionMode::Pty,
            None,
            &[ProviderRuntimeCapability::SemanticReadiness],
            None,
        )
        .await
        .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::UnsupportedSpawnCapability);
        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 1);
        assert_no_session_state(&shared);
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn spawn_denied_environment_materialization_fails_after_id_mint_with_no_state() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(true);
        let error = characterization_spawn(&shared, SessionMode::Pty, Some(receipt), &[], None)
            .await
            .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::BackendOperationFailed);
        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 2);
        assert_no_session_state(&shared);
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn remove_binding_returns_binding_and_is_idempotent_for_environment_session() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(false);
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(77),
                generation: SessionGeneration(1),
            },
        };
        shared.bind_session_with_policy(&address, ProviderRuntimePolicy::raw_pty(), Some(receipt));
        let removed = shared.remove_binding(&address).expect("binding removed");
        assert!(removed.environment_profile.is_some());
        assert!(shared.remove_binding(&address).is_none());
        assert_no_session_state(&shared);
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    async fn characterization_prepared_harness(provider: &str) -> PreparedHarnessMcpSpawn {
        use crate::harness_mcp_proxy::{HarnessMcpProxyRegistry, ReviewedHarnessMcpProgram};
        use crate::protocol::{HarnessMcpActivationDigest, HarnessMcpLaunchV1, HarnessMcpReservationId};
        let helper = ReviewedHarnessMcpProgram::review(std::env::current_exe().unwrap())
            .expect("review current test executable as fixture helper");
        let registry = HarnessMcpProxyRegistry::new(helper);
        let spec = crate::protocol::SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: NodeId::new("node-characterization").unwrap(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: crate::protocol::SpawnProfileId::new("claude").unwrap(),
            expected_profile_revision: crate::protocol::SpawnProfileRevision::new("r1").unwrap(),
            overrides: crate::protocol::SpawnOverrides::default(),
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: crate::protocol::SpawnIdempotencyKey::new("characterization-harness").unwrap(),
            required_capabilities: crate::protocol::SpawnRequiredCapabilities::default(),
        };
        let reservation = HarnessMcpReservationId::new(format!("hmcpres_{}", "c".repeat(24))).unwrap();
        let digest = HarnessMcpActivationDigest::new(format!("sha256:{}", "c".repeat(64))).unwrap();
        let launch = HarnessMcpLaunchV1 {
            server_name: "fixture-harness".to_owned(),
            args: vec!["--session-proxy".to_owned()],
            endpoint_env: "FIXTURE_SESSION_ENDPOINT".to_owned(),
            token_env: "FIXTURE_SESSION_TOKEN".to_owned(),
            program_env: "FIXTURE_MCP_PROGRAM".to_owned(),
            trace: None,
            scrub_env: Vec::new(),
        };
        let expires = unix_time_ms().saturating_add(30_000);
        registry.arm(reservation.clone(), digest.clone(), spec.clone(), launch, expires).await.unwrap();
        registry
            .prepare_spawn(&reservation, &digest, &spec, expires, agent(provider))
            .unwrap()
    }

    #[tokio::test]
    async fn spawn_harness_overlay_refuses_inline_and_provider_mismatch_with_no_state() {
        let (shared, runtime, _receipt, root, _deny) = materialization_test_shared(false);
        let prepared = characterization_prepared_harness("claude").await;
        let error = characterization_spawn(&shared, SessionMode::Inline, None, &[], Some(&prepared))
            .await
            .unwrap_err();
        // Inline is stopped by runtime admission before the harness check runs.
        assert_eq!(error.code, NodeFailureCode::UnsupportedSpawnCapability);
        let mismatched = characterization_prepared_harness("codex").await;
        let error = characterization_spawn(&shared, SessionMode::Pty, None, &[], Some(&mismatched))
            .await
            .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::BindingMismatch);
        assert_no_session_state(&shared);
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn spawn_harness_overlay_without_launch_control_is_unavailable_with_no_state() {
        let (mut shared, runtime, _receipt, root, _deny) = materialization_test_shared(false);
        shared.native_launch_profile_control = None;
        let prepared = characterization_prepared_harness("claude").await;
        let error = characterization_spawn(&shared, SessionMode::Pty, None, &[], Some(&prepared))
            .await
            .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::HarnessMcpUnavailable);
        assert_no_session_state(&shared);
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }
}

#[cfg(all(test, windows))]
mod tests {
    use super::*;
    use gate4agent_types::ProviderActivity;
    use crate::session_environment::{
        NodeSecretReference, NodeSecretResolveError, NodeSecretValue,
        NodeSessionEnvironmentMutation, NodeSessionFile, NodeSessionPathBinding,
        NodeSessionPathClass,
    };
    use gate4agent_catalog::EnvMutation;
    use gate4agent_runtime_native::{
        NativeChildEnvironmentResolveError, NativeChildEnvironmentResolver,
        NativeLaunchProfile, NativeLaunchProfileId,
    };
    use std::ffi::OsString;
    use std::sync::Arc;

    struct EmptyEnvironmentResolver;

    struct FixtureSecretResolver {
        deny: Arc<AtomicBool>,
    }

    impl NodeSecretResolver for FixtureSecretResolver {
        fn resolve(
            &self,
            _reference: &NodeSecretReference,
        ) -> Result<NodeSecretValue, NodeSecretResolveError> {
            if self.deny.load(Ordering::Acquire) {
                Err(NodeSecretResolveError::Denied)
            } else {
                NodeSecretValue::text("fixture-secret")
                    .map_err(|_| NodeSecretResolveError::Unavailable)
            }
        }
    }

    impl NativeChildEnvironmentResolver for EmptyEnvironmentResolver {
        fn resolve_child_environment(
            &self,
        ) -> Result<Vec<EnvMutation>, NativeChildEnvironmentResolveError> {
            Ok(vec![EnvMutation {
                key: OsString::from("GATE4AGENT_TEST_PROFILE"),
                value: None,
            }])
        }
    }

    fn agent(value: &str) -> AgentId {
        AgentId::new(value).unwrap()
    }

    fn terminal_test_shared_with_mode(mode: WorktreeServiceMode) -> NodeShared {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap()
        .with_worktree_service_mode(mode);
        NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-terminal-test").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        )
    }

    fn terminal_test_shared() -> NodeShared {
        terminal_test_shared_with_mode(WorktreeServiceMode::Manual)
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn managed_worktree_v2_failure_probe_keeps_only_the_latest_code() {
        let probe = SpawnManagedWorktreeV2FailureProbe::default();
        assert_eq!(probe.latest_code(), None);

        probe.record(Some(NodeFailureCode::ManagedWorktreeOwnershipConflict));
        assert_eq!(
            probe.latest_code(),
            Some(NodeFailureCode::ManagedWorktreeOwnershipConflict),
        );

        probe.record(Some(NodeFailureCode::SpawnDeadlineExceeded));
        assert_eq!(
            probe.latest_code(),
            Some(NodeFailureCode::SpawnDeadlineExceeded),
        );

        probe.record(None);
        assert_eq!(probe.latest_code(), None);
    }

    #[test]
    fn launch_snapshot_is_authoritative_bounded_and_path_free() {
        let source = temporary_workspace_root("launch-inventory-source");
        let allocation = temporary_workspace_root("launch-inventory-allocation");
        std::fs::create_dir_all(&source).unwrap();
        std::fs::create_dir_all(&allocation).unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let mut workspace = WorkspaceConfig::new(workspace_id.clone(), &source)
            .unwrap()
            .with_worktree_service_mode(WorktreeServiceMode::Managed);
        for index in 0..MAX_MANAGED_WORKTREE_PROFILES_PER_WORKSPACE {
            workspace = workspace
                .with_managed_worktree_profile(
                    ManagedWorktreeProfile::new(
                        WorktreeProfileId::new(format!("profile-{index}")).unwrap(),
                        crate::protocol::WorktreeProfileRevision::new("v1").unwrap(),
                        &allocation,
                        "gate4agent",
                        "HEAD",
                        ManagedWorktreeRetention::RemoveWhenReleased,
                    )
                    .unwrap(),
                )
                .unwrap();
        }
        let overflow = workspace.clone().with_managed_worktree_profile(
            ManagedWorktreeProfile::new(
                WorktreeProfileId::new("overflow").unwrap(),
                crate::protocol::WorktreeProfileRevision::new("v1").unwrap(),
                &allocation,
                "gate4agent",
                "HEAD",
                ManagedWorktreeRetention::Retain,
            )
            .unwrap(),
        );
        assert!(matches!(
            overflow,
            Err(NodeServerError::ManagedWorktreeProfileCapacity {
                max: MAX_MANAGED_WORKTREE_PROFILES_PER_WORKSPACE,
                ..
            }),
        ));

        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-launch-inventory").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let snapshot = shared.snapshot();
        let launch = snapshot.launch_inventory.as_ref().unwrap();
        assert_eq!(launch.spawn_profiles.as_ref().unwrap().len(), 1);
        assert!(launch.bundles.as_ref().unwrap().is_empty());
        let profiles = snapshot.workspaces[0]
            .managed_worktree_profiles
            .as_ref()
            .unwrap();
        assert_eq!(
            snapshot.workspaces[0].worktree_service_mode,
            Some(WorktreeServiceMode::Managed),
        );
        assert_eq!(
            profiles.profiles.len(),
            MAX_MANAGED_WORKTREE_PROFILES_PER_WORKSPACE,
        );
        let public_inventory = serde_json::to_string(&(launch, profiles)).unwrap();
        for forbidden in ["allocation_root", "branch_prefix", "base", "prompt", "environment", "home"] {
            assert!(!public_inventory.contains(forbidden), "launch inventory leaked {forbidden}");
        }
        let legacy = snapshot_for_wire(
            &shared,
            true,
            true,
            false,
            false,
            true,
            false,
            true,
            false,
            true,
        );
        assert!(legacy.launch_inventory.is_none());
        assert!(legacy.workspaces[0].managed_worktree_profiles.is_none());

        drop(shared);
        std::fs::remove_dir_all(source).unwrap();
        std::fs::remove_dir_all(allocation).unwrap();
    }

    #[test]
    fn agent_progress_projection_omits_sensitive_provider_payloads_and_is_capability_gated() {
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_AGENT_PROGRESS_SNAPSHOT_CAPABILITY
        }));
        let source = gate4agent_types::ProviderSource {
            family: AdapterFamily::PtySemantic,
            binding: AdapterBinding::new(
                gate4agent_types::AdapterId::new("claude").unwrap(),
                "fixture/v1",
                gate4agent_types::AdapterVerification::SyntheticFixture,
            )
            .unwrap(),
        };
        let provider = ProviderSnapshot {
            sequence: 17,
            session: Some(ProviderSessionIdentity {
                key: ProviderSessionKey::SessionId,
                id: "PRIVATE_PROVIDER_SESSION".to_owned(),
                transcript_path: Some(r"C:\PRIVATE_PROVIDER_PATH".to_owned()),
            }),
            model: Some("PRIVATE_MODEL".to_owned()),
            tools: vec!["PRIVATE_TOOL_INVENTORY".to_owned()],
            completed_turns: 3,
            usage: gate4agent_types::TokenUsage {
                input_tokens: 10,
                output_tokens: 20,
                cache_read_tokens: 30,
                cache_write_tokens: 40,
                reasoning_tokens: 50,
                context_window: Some(200_000),
            },
            lead_activity: ProviderActivity::WaitingForInput,
            activity: ProviderActivity::WaitingForInput,
            current_prompt: Some("PRIVATE_CURRENT_PROMPT".to_owned()),
            active_tools: (0..9)
                .map(|index| gate4agent_types::ActiveProviderTool {
                    id: format!("private-tool-id-{index}"),
                    name: if index == 0 {
                        format!("  Read\u{0000}{}", "x".repeat(80))
                    } else {
                        format!("Tool-{index}")
                    },
                    input_json: "PRIVATE_TOOL_INPUT_JSON".to_owned(),
                })
                .collect(),
            interactions: vec![gate4agent_types::ProviderInteraction {
                id: gate4agent_types::ProviderInteractionId(17),
                source: source.clone(),
                provider_request_id: Some("PRIVATE_PROVIDER_REQUEST".to_owned()),
                interaction_kind: ProviderInteractionKind::Approval,
                tool_name: " Approve\u{0007}Tool ".to_owned(),
                prompt: "PRIVATE_INTERACTION_PROMPT".to_owned(),
                agent_id: Some("PRIVATE_INTERACTION_AGENT".to_owned()),
                resume_lead_activity: Some(ProviderActivity::Working),
                status: ProviderInteractionStatus::Pending,
            }],
            subagents: vec![gate4agent_types::ProviderSubagent {
                source: source.clone(),
                provider_agent_id: "PRIVATE_SUBAGENT_ID".to_owned(),
                agent_type: Some("PRIVATE_SUBAGENT_TYPE".to_owned()),
                description: Some("PRIVATE_SUBAGENT_DESCRIPTION".to_owned()),
            }],
            sources: vec![gate4agent_types::ProviderSourceCursor {
                source,
                sequence: 17,
                gap_count: 2,
                stale: true,
            }],
            last_event: Some(ProviderEvent::Error {
                message: "PRIVATE_PROVIDER_ERROR".to_owned(),
            }),
            gap_count: 2,
            stale: true,
        };
        let address = terminal_address(3);
        let entry = agent_progress_from_provider_snapshot(address.clone(), &provider).unwrap();
        assert_eq!(entry.address, address);
        assert_eq!(entry.progress.provider_sequence, 17);
        assert_eq!(entry.progress.active_tool_count, 9);
        assert_eq!(
            entry.progress.active_tool_labels.len(),
            MAX_AGENT_PROGRESS_ACTIVE_TOOL_LABELS,
        );
        assert_eq!(entry.progress.subagent_count, 1);
        assert_eq!(entry.progress.last_event_kind, Some(AgentProgressEventKindV1::Error));
        assert!(entry.progress.truncated);
        let encoded = serde_json::to_string(&entry).unwrap();
        for forbidden in [
            "PRIVATE_PROVIDER_SESSION",
            "PRIVATE_PROVIDER_PATH",
            "PRIVATE_MODEL",
            "PRIVATE_TOOL_INVENTORY",
            "PRIVATE_CURRENT_PROMPT",
            "PRIVATE_TOOL_INPUT_JSON",
            "PRIVATE_PROVIDER_REQUEST",
            "PRIVATE_INTERACTION_PROMPT",
            "PRIVATE_INTERACTION_AGENT",
            "PRIVATE_SUBAGENT_ID",
            "PRIVATE_SUBAGENT_TYPE",
            "PRIVATE_SUBAGENT_DESCRIPTION",
            "PRIVATE_PROVIDER_ERROR",
            "input_json",
            "current_prompt",
            "session_id",
        ] {
            assert!(!encoded.contains(forbidden), "agent progress leaked {forbidden}");
        }

        let snapshot = NodeSnapshot {
            node_id: NodeId::new("node-progress-test").unwrap(),
            enabled_providers: vec![agent("claude")],
            provider_runtime_statuses: ProviderRuntimeStatuses::default(),
            workspaces: Vec::new(),
            session_records: Vec::new(),
            managed_worktrees: Vec::new(),
            launch_inventory: None,
            agent_progress: vec![entry],
        };
        let mut legacy_reply = ResponseEnvelope {
            request_id: 1,
            result: Ok(NodeResponse::Snapshot {
                event_sequence: 0,
                controller: None,
                snapshot: snapshot.clone(),
            }),
        };
        project_response_without_agent_progress(&mut legacy_reply);
        let Ok(NodeResponse::Snapshot { snapshot: legacy, .. }) = legacy_reply.result else {
            panic!("agent progress projection changed response kind");
        };
        assert!(legacy.agent_progress.is_empty());
        assert_eq!(snapshot.agent_progress.len(), 1);
    }

    fn terminal_address(generation: u64) -> SessionAddress {
        SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(41),
                generation: SessionGeneration(generation),
            },
        }
    }

    fn spawn_spec_fixture() -> SpawnSpec {
        SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id: NodeId::new("node-terminal-test").unwrap(),
                workspace_id: WorkspaceId::new("primary").unwrap(),
                worktree_id: None,
            },
            profile_id: crate::protocol::SpawnProfileId::new("default").unwrap(),
            expected_profile_revision: crate::protocol::SpawnProfileRevision::new("builtin-v1")
                .unwrap(),
            overrides: crate::protocol::SpawnOverrides::default(),
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(30_000).unwrap(),
            idempotency_key: SpawnIdempotencyKey::new("spawn-spec-fixture").unwrap(),
            required_capabilities: SpawnRequiredCapabilities::default(),
        }
    }

    fn environment_profile_test_shared(
    ) -> (NodeShared, NativeRuntime, ResolvedEnvironmentProfileReceipt) {
        let profile_id = SpawnEnvironmentProfileId::new("local-claude").unwrap();
        let profile_revision = crate::protocol::SpawnEnvironmentProfileRevision::new(
            "local-claude-r1",
        )
        .unwrap();
        let spawn_profiles = SpawnProfileRegistry::new([
            crate::protocol::SpawnProfileDefaults {
                profile_id: crate::protocol::SpawnProfileId::new("default").unwrap(),
                revision: crate::protocol::SpawnProfileRevision::new("test-r1").unwrap(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                terminal_size: gate4agent_types::TerminalSize {
                    rows: 24,
                    columns: 80,
                },
                prompt: None,
                bundle_id: None,
                context_id: None,
                environment_profile_id: Some(profile_id.clone()),
            },
        ])
        .unwrap();
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let control = runtime.native_launch_profile_control();
        let node_profile = NodeEnvironmentProfile::new(
            profile_id.clone(),
            profile_revision.clone(),
            agent("claude"),
            [NativeLaunchProfile::new(
                NativeLaunchProfileId::new("local-claude-pty").unwrap(),
                agent("claude"),
                TransportKind::Pty,
                vec![OsString::from("GATE4AGENT_TEST_PROFILE")],
                Arc::new(EmptyEnvironmentResolver),
            )
            .unwrap()],
        )
        .unwrap();
        let (binding, native_profiles, _materialization) = node_profile.into_parts();
        for native_profile in native_profiles {
            runtime.upsert_native_launch_profile(native_profile).unwrap();
        }
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-terminal-test").unwrap(),
            NodeIncarnationId::from_bytes([0; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            spawn_profiles,
            Some(control),
            None,
            None,
            None,
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(binding.id.clone(), binding);
        (
            shared,
            runtime,
            ResolvedEnvironmentProfileReceipt {
                profile_id,
                profile_revision,
                network_allowlist: None,
                browser_profile_id: None,
            },
        )
    }

    fn materialization_test_shared(
        deny_secret: bool,
    ) -> (
        NodeShared,
        NativeRuntime,
        ResolvedEnvironmentProfileReceipt,
        PathBuf,
        Arc<AtomicBool>,
    ) {
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        materialization_test_shared_with_workspace(deny_secret, workspace)
    }

    fn materialization_test_shared_with_workspace(
        deny_secret: bool,
        workspace: WorkspaceConfig,
    ) -> (
        NodeShared,
        NativeRuntime,
        ResolvedEnvironmentProfileReceipt,
        PathBuf,
        Arc<AtomicBool>,
    ) {
        let root = temporary_workspace_root(if deny_secret {
            "materialization-denied"
        } else {
            "materialization-ready"
        });
        std::fs::create_dir_all(&root).unwrap();
        let materialization_root = root.join("session-environments");
        let deny = Arc::new(AtomicBool::new(deny_secret));
        let resolver = Arc::new(FixtureSecretResolver {
            deny: Arc::clone(&deny),
        });
        let materializer = SessionEnvironmentMaterializer::new(
            materialization_root,
            resolver,
        )
        .unwrap();
        let profile_id = SpawnEnvironmentProfileId::new("materialized-claude").unwrap();
        let profile_revision = crate::protocol::SpawnEnvironmentProfileRevision::new(
            "materialized-claude-r1",
        )
        .unwrap();
        let materialization = NodeSessionMaterializationProfile::new(
            vec![NodeSessionEnvironmentMutation::SetSecret {
                key: "GATE4AGENT_SESSION_TOKEN".to_owned(),
                reference: NodeSecretReference::new("fixture-token").unwrap(),
            }],
            vec![NodeSessionPathBinding::new(
                "GATE4AGENT_PROVIDER_HOME",
                NodeSessionPathClass::ProviderHome,
            )
            .unwrap()],
            vec![NodeSessionFile::secret(
                NodeSessionPathClass::Config,
                "auth/token",
                NodeSecretReference::new("fixture-token").unwrap(),
            )
            .unwrap()],
        )
        .unwrap();
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let control = runtime.native_launch_profile_control();
        let node_profile = NodeEnvironmentProfile::new_with_materialization(
            profile_id.clone(),
            profile_revision.clone(),
            agent("claude"),
            [NativeLaunchProfile::new(
                NativeLaunchProfileId::new("materialized-claude-pty").unwrap(),
                agent("claude"),
                TransportKind::Pty,
                vec![OsString::from("GATE4AGENT_TEST_PROFILE")],
                Arc::new(EmptyEnvironmentResolver),
            )
            .unwrap()],
            Some(materialization),
        )
        .unwrap();
        let (binding, native_profiles, materialization) = node_profile.into_parts();
        for native_profile in native_profiles {
            runtime.upsert_native_launch_profile(native_profile).unwrap();
        }
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-materialization-test").unwrap(),
            NodeIncarnationId::from_bytes([9; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            Some(control),
            None,
            Some(materializer),
            None,
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(binding.id.clone(), binding);
        shared
            .environment_materialization_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(profile_id.clone(), materialization.unwrap());
        (
            shared,
            runtime,
            ResolvedEnvironmentProfileReceipt {
                profile_id,
                profile_revision,
                network_allowlist: None,
                browser_profile_id: None,
            },
            root,
            deny,
        )
    }

    #[cfg(feature = "fixture")]
    #[derive(Clone, Copy)]
    enum CodexHomeProfile {
        Missing,
        WrongClass,
        Exact,
    }

    #[cfg(feature = "fixture")]
    fn codex_bundle_test_shared(
        home_profile: CodexHomeProfile,
    ) -> (
        NodeShared,
        NativeRuntime,
        ResolvedEnvironmentProfileReceipt,
        NodeBundle,
        PathBuf,
    ) {
        const ROOT_MANIFEST: &[u8] = br#"{"$schema":"https://agent-plugins.org/schemas/1.0.0/plugin.schema.json","name":"review-tools"}"#;
        const CLAUDE_MANIFEST: &[u8] =
            br#"{"name":"review-tools","version":"1.0.0","description":"Review helpers"}"#;
        const SKILL: &[u8] = b"---\nname: review-code\ndescription: Review code for correctness and safety.\n---\n\nReview the selected change.\n";
        const DIGEST: &str =
            "sha256:941f20868a6ef49b4329bf1bb1368515763f5b64d8279b05cd9700966083d707";

        let (shared, mut runtime, _claude_receipt, root, _deny) =
            materialization_test_shared(false);
        let profile_id = SpawnEnvironmentProfileId::new(match home_profile {
            CodexHomeProfile::Missing => "codex-home-missing",
            CodexHomeProfile::WrongClass => "codex-home-wrong",
            CodexHomeProfile::Exact => "codex-home-exact",
        })
        .unwrap();
        let profile_revision = crate::protocol::SpawnEnvironmentProfileRevision::new(
            "codex-home-r1",
        )
        .unwrap();
        let materialization = match home_profile {
            CodexHomeProfile::Missing => None,
            CodexHomeProfile::WrongClass | CodexHomeProfile::Exact => {
                Some(NodeSessionMaterializationProfile::new(
                    Vec::new(),
                    vec![NodeSessionPathBinding::new(
                        "CODEX_HOME",
                        if matches!(home_profile, CodexHomeProfile::Exact) {
                            NodeSessionPathClass::ProviderHome
                        } else {
                            NodeSessionPathClass::Config
                        },
                    )
                    .unwrap()],
                    Vec::new(),
                )
                .unwrap())
            }
        };
        let node_profile = NodeEnvironmentProfile::new_with_materialization(
            profile_id.clone(),
            profile_revision.clone(),
            agent("codex"),
            [NativeLaunchProfile::new(
                NativeLaunchProfileId::new(format!("{profile_id}-pty")).unwrap(),
                agent("codex"),
                TransportKind::Pty,
                vec![OsString::from("GATE4AGENT_TEST_PROFILE")],
                Arc::new(EmptyEnvironmentResolver),
            )
            .unwrap()],
            materialization,
        )
        .unwrap();
        let (binding, native_profiles, materialization) = node_profile.into_parts();
        for native_profile in native_profiles {
            runtime.upsert_native_launch_profile(native_profile).unwrap();
        }
        shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(binding.id.clone(), binding);
        if let Some(materialization) = materialization {
            shared
                .environment_materialization_profiles
                .write()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .insert(profile_id.clone(), materialization);
        }

        let bundle_source = root.join(format!("bundle-source-{profile_id}"));
        std::fs::create_dir_all(bundle_source.join(".claude-plugin")).unwrap();
        std::fs::create_dir_all(bundle_source.join("skills/review-code")).unwrap();
        std::fs::write(bundle_source.join("plugin.json"), ROOT_MANIFEST).unwrap();
        std::fs::write(
            bundle_source.join(".claude-plugin/plugin.json"),
            CLAUDE_MANIFEST,
        )
        .unwrap();
        std::fs::write(bundle_source.join("skills/review-code/SKILL.md"), SKILL).unwrap();
        crate::bundle_catalog::protect_bundle_source_tree_fixture(&bundle_source).unwrap();
        let bundle = NodeBundle::new(
            crate::protocol::SpawnBundleId::new("review-tools").unwrap(),
            crate::protocol::SpawnBundleRevision::new("review-tools-r1").unwrap(),
            crate::protocol::SpawnBundleDigest::new(DIGEST).unwrap(),
            &bundle_source,
        )
        .unwrap();
        *shared
            .bundle_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            BundleCatalog::new([bundle.clone()]).unwrap();
        (
            shared,
            runtime,
            ResolvedEnvironmentProfileReceipt {
                profile_id,
                profile_revision,
                network_allowlist: None,
                browser_profile_id: None,
            },
            bundle,
            root,
        )
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn codex_bundle_preflight_rejects_missing_or_wrong_home_before_materialization() {
        for home_profile in [CodexHomeProfile::Missing, CodexHomeProfile::WrongClass] {
            let (shared, runtime, receipt, bundle, root) =
                codex_bundle_test_shared(home_profile);
            let error = shared
                .bundle_layout(
                    &agent("codex"),
                    SessionMode::Pty,
                    Some(&receipt),
                    &bundle,
                )
                .unwrap_err();
            assert_eq!(error.code, NodeFailureCode::BundleBindingMismatch);
            assert!(shared
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .is_empty());
            let materialization_root = root.join("session-environments");
            assert!(!std::fs::read_dir(&materialization_root)
                .unwrap()
                .filter_map(Result::ok)
                .any(|entry| entry.file_type().is_ok_and(|kind| kind.is_dir())));
            drop(shared);
            drop(runtime);
            let _ = std::fs::remove_dir_all(root);
        }
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn codex_bundle_exact_home_profile_materializes_only_the_skill_tree() {
        let (shared, runtime, receipt, bundle, root) =
            codex_bundle_test_shared(CodexHomeProfile::Exact);
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(310),
                generation: SessionGeneration(1),
            },
        };
        let (overlay, guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("codex"),
                SessionMode::Pty,
                Some(&receipt),
                Some(&bundle.receipt()),
                None,
                None,
            )
            .unwrap()
            .unwrap();
        assert!(matches!(overlay, Some(PreparedNativeLaunchOverlay::Instance(_))));
        let ownership = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(guard.id().unwrap())
            .unwrap()
            .clone();
        let (profile, _, _) = shared
            .materialization_profile(
                &agent("codex"),
                SessionMode::Pty,
                Some(&receipt),
                Some(&bundle.receipt()),
                None,
            )
            .unwrap()
            .unwrap();
        let environment = shared
            .session_environment_materializer
            .as_ref()
            .unwrap()
            .resolve_environment(&ownership, &profile)
            .unwrap();
        assert!(environment.iter().any(|mutation| {
            mutation.key == OsString::from("CODEX_HOME")
                && mutation.value.as_deref() == Some(ownership.provider_home().as_os_str())
        }));
        assert_eq!(
            std::fs::read(ownership.provider_home().join("skills/review-code/SKILL.md"))
                .unwrap(),
            b"---\nname: review-code\ndescription: Review code for correctness and safety.\n---\n\nReview the selected change.\n",
        );
        assert!(std::fs::read_dir(ownership.bundle_root())
            .unwrap()
            .next()
            .is_none());
        drop(guard);
        drop(shared);
        drop(runtime);
        let _ = std::fs::remove_dir_all(root);
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn codex_cold_record_resume_revalidates_the_isolated_skill_tree() {
        let (shared, runtime, receipt, bundle, root) =
            codex_bundle_test_shared(CodexHomeProfile::Exact);
        let bundle_receipt = bundle.receipt();
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(311),
                generation: SessionGeneration(1),
            },
        };
        let (_overlay, guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("codex"),
                SessionMode::Pty,
                Some(&receipt),
                Some(&bundle_receipt),
                None,
                None,
            )
            .unwrap()
            .unwrap();
        let materialization_id = guard.id().unwrap().clone();
        let skill_path = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&materialization_id)
            .unwrap()
            .provider_home()
            .join("skills/review-code/SKILL.md");
        let record_id = shared
            .bind_spawn_session_with_materialization(
                &address,
                agent("codex"),
                SessionMode::Pty,
                ProviderRuntimePolicy::new(true, false, false, true, false, false).unwrap(),
                SpawnRecordPolicy::ProviderIdentityOnly,
                Some(receipt.clone()),
                Some(bundle_receipt.clone()),
                None,
                Some(materialization_id.clone()),
            )
            .unwrap()
            .unwrap();
        guard.retain();
        std::fs::write(skill_path, b"changed-after-record-bind").unwrap();

        let error = match shared.resolve_record_materialization(
                &record_id,
                &agent("codex"),
                SessionMode::Pty,
                Some(&receipt),
                Some(&bundle_receipt),
                None,
            ) {
                Ok(_) => panic!("changed Codex skill tree unexpectedly revalidated"),
                Err(error) => error,
            };
        assert_eq!(error.code, NodeFailureCode::BundleMaterializationFailed);
        assert_eq!(
            shared
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&materialization_id)
                .unwrap()
                .state(),
            MaterializationState::RecoveryRequired,
        );
        drop(shared);
        drop(runtime);
        let _ = std::fs::remove_dir_all(root);
    }

    fn bind_record_owned_materialization_fixture(
        shared: &NodeShared,
        receipt: &ResolvedEnvironmentProfileReceipt,
        instance_id: u64,
    ) -> (SessionAddress, SessionRecordId, MaterializationId, PathBuf) {
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(instance_id),
                generation: SessionGeneration(1),
            },
        };
        let (overlay, materialization_guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("claude"),
                SessionMode::Pty,
                Some(receipt),
                None,
                None,
                None,
            )
            .unwrap()
            .unwrap();
        let materialization_id = materialization_guard.id().unwrap().clone();
        let materialization_root = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&materialization_id)
            .unwrap()
            .root()
            .to_path_buf();
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(receipt),
            )
            .unwrap()
            .unwrap();
        assert!(shared
            .install_prepared_launch_overlay(address.session.instance_id, overlay.unwrap())
            .unwrap()
            .is_none());
        let policy = ProviderRuntimePolicy::new(true, false, false, true, false, false).unwrap();
        let record_id = shared
            .bind_spawn_session_with_materialization(
                &address,
                agent("claude"),
                SessionMode::Pty,
                policy,
                SpawnRecordPolicy::ProviderIdentityOnly,
                Some(receipt.clone()),
                None,
                None,
                Some(materialization_id.clone()),
            )
            .unwrap()
            .unwrap();
        selection.retain();
        materialization_guard.retain();
        (address, record_id, materialization_id, materialization_root)
    }

    #[test]
    fn child_environment_profile_capability_is_state_aware_and_legacy_safe() {
        let (shared, _runtime, environment_profile) = environment_profile_test_shared();
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_CHILD_ENVIRONMENT_PROFILE_CAPABILITY
        }));
        let support = node_compatibility_support_for_manifest(&[], &[]).unwrap();
        assert_eq!(support.state_schema.versions.maximum(), NODE_STATE_SCHEMA_V10);
        let mut spec = spawn_spec_fixture();
        spec.expected_profile_revision =
            crate::protocol::SpawnProfileRevision::new("test-r1").unwrap();
        assert!(matches!(
            &spec.overrides.environment_profile_id,
            crate::protocol::SpawnOverride::Inherit,
        ));
        assert!(!NodeRequest::SpawnSpec { spec: spec.clone() }
            .requires_child_environment_profile_capability());
        assert!(request_requires_child_environment_profile(
            &shared,
            &NodeRequest::SpawnSpec { spec: spec.clone() },
        ));

        let address = terminal_address(1);
        shared.bind_session_with_policy(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(environment_profile.clone()),
        );
        assert!(request_requires_child_environment_profile(
            &shared,
            &NodeRequest::Input {
                session: address.clone(),
                text: "x".to_owned(),
            },
        ));

        let mut record = record("claude", "profile-record");
        record.active_session = Some(address.clone());
        record.environment_profile = Some(environment_profile.clone());
        let record_id = record.record_id.clone();
        shared.insert_record(record.clone()).unwrap();
        assert!(request_requires_child_environment_profile(
            &shared,
            &NodeRequest::ResumeSessionRecord {
                record_id,
                terminal_size: gate4agent_types::TerminalSize {
                    rows: 24,
                    columns: 80,
                },
                initial_prompt: None,
            },
        ));

        let snapshot = snapshot_for_wire(
            &shared, false, true, true, true, false, false, false, false, true,
        );
        assert_eq!(snapshot.session_records.len(), 1);
        assert!(snapshot.session_records[0].environment_profile.is_none());
        let event = project_event_without_child_environment_profile(NodeEventEnvelope {
            sequence: 1,
            event: NodeEvent::SessionRecordUpserted { record },
        });
        let NodeEvent::SessionRecordUpserted { record } = event.event else {
            panic!("record projection changed the event kind");
        };
        assert!(record.environment_profile.is_none());

        let resolved = shared.resolve_spawn_spec(&spec).unwrap();
        let mut reply = ResponseEnvelope {
            request_id: 1,
            result: Ok(NodeResponse::SpawnSpecAccepted {
                receipt: resolved.receipt_with_environment(
                    shared.incarnation_id,
                    address,
                    Some(environment_profile),
                ),
            }),
        };
        project_response_without_child_environment_profile(&mut reply);
        assert_eq!(
            reply.result.unwrap_err().code,
            NodeFailureCode::UnsupportedCapability,
        );
    }

    #[test]
    fn spawn_profile_environment_authority_is_exact_and_legacy_safe() {
        let (shared, _runtime, environment_profile) = environment_profile_test_shared();
        let snapshot = shared.snapshot();
        let profiles = snapshot
            .launch_inventory
            .as_ref()
            .and_then(|inventory| inventory.spawn_profiles.as_ref())
            .unwrap();
        assert_eq!(profiles.len(), 1);
        assert_eq!(profiles[0].environment_profile, Some(environment_profile));
        assert!(snapshot.requires_child_environment_profile_capability());

        let mut legacy = snapshot.clone();
        clear_snapshot_child_environment_profiles(&mut legacy);
        assert!(legacy
            .launch_inventory
            .as_ref()
            .unwrap()
            .spawn_profiles
            .as_ref()
            .unwrap()[0]
            .environment_profile
            .is_none());
        assert!(!legacy.requires_child_environment_profile_capability());

        let profile = shared.spawn_profiles.iter().next().unwrap().clone();
        let bindings = shared
            .environment_profiles
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clone();
        let mut provider_mismatch = bindings.clone();
        provider_mismatch
            .values_mut()
            .next()
            .unwrap()
            .provider = agent("codex");
        assert!(resolved_spawn_profile_summary(&profile, &provider_mismatch).is_none());
        let mut mode_mismatch = profile;
        mode_mismatch.mode = SessionMode::Inline;
        assert!(resolved_spawn_profile_summary(&mode_mismatch, &bindings).is_none());

        shared
            .environment_profiles
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .clear();
        assert!(shared
            .snapshot()
            .launch_inventory
            .unwrap()
            .spawn_profiles
            .unwrap()
            .is_empty());
    }

    #[test]
    fn session_bundle_capability_is_state_aware_and_legacy_safe() {
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_SESSION_BUNDLE_MATERIALIZATION_CAPABILITY
        }));
        let shared = terminal_test_shared();
        let bundle = ResolvedBundleReceipt {
            id: crate::protocol::SpawnBundleId::new("review-bundle").unwrap(),
            revision: crate::protocol::SpawnBundleRevision::new("r1").unwrap(),
            digest: crate::protocol::SpawnBundleDigest::new(format!(
                "sha256:{}",
                "0".repeat(64),
            ))
            .unwrap(),
        };
        let mut bundled = record("claude", "bundle-record");
        bundled.bundle = Some(bundle.clone());
        let record_id = bundled.record_id.clone();
        shared.insert_record(bundled.clone()).unwrap();
        assert!(request_requires_session_bundle(
            &shared,
            &NodeRequest::ForgetSessionRecord {
                record_id: record_id.clone(),
            },
        ));

        let snapshot = snapshot_for_wire(
            &shared, false, true, true, true, true, false, false, false, true,
        );
        assert!(snapshot.session_records[0].bundle.is_none());
        let launch = snapshot.launch_inventory.as_ref().unwrap();
        assert!(launch.spawn_profiles.is_some());
        assert!(launch.bundles.is_none());
        let event = project_event_without_session_bundle(NodeEventEnvelope {
            sequence: 1,
            event: NodeEvent::SessionRecordUpserted { record: bundled },
        });
        let NodeEvent::SessionRecordUpserted { record } = event.event else {
            panic!("record projection changed the event kind");
        };
        assert!(record.bundle.is_none());

        let resolved = shared.resolve_spawn_spec(&spawn_spec_fixture()).unwrap();
        let mut reply = ResponseEnvelope {
            request_id: 1,
            result: Ok(NodeResponse::SpawnSpecAccepted {
                receipt: resolved.receipt_with_materialization(
                    shared.incarnation_id,
                    terminal_address(17),
                    None,
                    Some(bundle),
                    None,
                ),
            }),
        };
        project_response_without_session_bundle(&mut reply);
        assert_eq!(
            reply.result.unwrap_err().code,
            NodeFailureCode::UnsupportedCapability,
        );
    }

    #[test]
    fn history_context_pack_capability_redacts_loaded_messages_and_legacy_metadata() {
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_HISTORY_CONTEXT_PACK_CAPABILITY
        }));
        let context_id = SpawnContextId::new("context-review").unwrap();
        let context = ResolvedContextPackReceipt {
            id: context_id.clone(),
            digest: crate::protocol::SpawnContextDigest::new(format!(
                "sha256:{}",
                "c".repeat(64),
            ))
            .unwrap(),
            lineage: ContextPackLineageReceipt {
                source_node_id: NodeId::new("node-source").unwrap(),
                source_session: terminal_address(1),
                source_provider: agent("kimi"),
            },
            source_message_count: 2,
            retained_message_count: 2,
            byte_len: 256,
            truncated: false,
        };
        assert!(context.is_valid());
        let mut bound_record = record("codex", "context-record");
        bound_record.context_id = Some(context_id);
        bound_record.context = Some(context.clone());
        let session = gate4agent_types::SessionSnapshot {
            instance_id: AgentInstanceId(91),
            agent_id: agent("kimi"),
            transport: TransportKind::Pty,
            generation: SessionGeneration(3),
            status: SessionStatus::Running,
            pending_operation: None,
            pending_input: None,
            process_id: Some(9001),
            terminal_size: None,
            terminal_frame: None,
            terminal_stale: None,
            session_options: None,
            capabilities: gate4agent_types::CapabilitySnapshot::default(),
            history: gate4agent_types::HistorySnapshot {
                pending: None,
                candidates: vec![HistoryCandidateSummary {
                    id: "candidate-opaque".to_owned(),
                    session_id_hint: "session-hint".to_owned(),
                    modified_at_unix_ms: Some(1),
                }],
                loaded_candidate_id: Some("candidate-opaque".to_owned()),
                loaded: Some(HistorySessionRecord {
                    session_id: "private-vendor-session".to_owned(),
                    title: Some("private title".to_owned()),
                    cwd: Some(r"C:\private\history-root".to_owned()),
                    model: Some("private-model".to_owned()),
                    message_count: 2,
                    completed_turn_count: None,
                    total_tokens: 19,
                    messages: vec![
                        gate4agent_types::HistoryMessageRecord {
                            role: gate4agent_types::HistoryMessageRole::User,
                            text: "F7_PRIVATE_HISTORY_MESSAGE".to_owned(),
                        },
                        gate4agent_types::HistoryMessageRecord {
                            role: gate4agent_types::HistoryMessageRole::Assistant,
                            text: "private answer".to_owned(),
                        },
                    ],
                }),
                last_error: None,
            },
            resume: gate4agent_types::ResumeSnapshot::default(),
            foreground: gate4agent_types::ForegroundSnapshot::default(),
            provider: gate4agent_types::ProviderSnapshot::default(),
            screen_state: gate4agent_types::PtyScreenState::default(),
        };
        let original = NodeSnapshot {
            node_id: NodeId::new("node-terminal-test").unwrap(),
            enabled_providers: vec![agent("kimi"), agent("codex")],
            provider_runtime_statuses: ProviderRuntimeStatuses::default(),
            workspaces: vec![WorkspaceSnapshot {
                workspace_id: WorkspaceId::new("primary").unwrap(),
                canonical_root: opaque_windows_path(
                    std::env::current_dir().unwrap().to_string_lossy().into_owned(),
                ),
                sessions: vec![session],
                worktree_service_mode: None,
                managed_worktree_profiles: None,
            }],
            session_records: vec![bound_record],
            managed_worktrees: Vec::new(),
            launch_inventory: None,
            agent_progress: Vec::new(),
        };

        let mut negotiated = original.clone();
        project_snapshot_history_for_wire(&mut negotiated, true);
        assert_eq!(negotiated.workspaces[0].sessions[0].history.candidates.len(), 1);
        assert!(negotiated.workspaces[0].sessions[0].history.loaded.is_none());
        assert_eq!(negotiated.session_records[0].context.as_ref(), Some(&context));
        assert!(!serde_json::to_string(&negotiated)
            .unwrap()
            .contains("F7_PRIVATE_HISTORY_MESSAGE"));

        let mut legacy = original;
        project_snapshot_history_for_wire(&mut legacy, false);
        clear_snapshot_context_packs(&mut legacy);
        assert_eq!(
            legacy.workspaces[0].sessions[0].history,
            gate4agent_types::HistorySnapshot::default(),
        );
        assert!(legacy.session_records[0].context_id.is_none());
        assert!(legacy.session_records[0].context.is_none());
        let encoded = serde_json::to_string(&legacy).unwrap();
        assert!(!encoded.contains("F7_PRIVATE_HISTORY_MESSAGE"));
        assert!(!encoded.contains("context-review"));

        let mut reply = ResponseEnvelope {
            request_id: 7,
            result: Ok(NodeResponse::ContextPackExported { context }),
        };
        project_response_without_context_pack(&mut reply);
        assert_eq!(
            reply.result.unwrap_err().code,
            NodeFailureCode::UnsupportedCapability,
        );
    }

    #[test]
    fn forgetting_unbound_context_pack_evicts_replay_but_retained_record_is_busy() {
        let shared = terminal_test_shared();
        let history = HistorySessionRecord {
            session_id: "fixture-history".to_owned(),
            title: None,
            cwd: None,
            model: None,
            message_count: 1,
            completed_turn_count: None,
            total_tokens: 0,
            messages: vec![gate4agent_types::HistoryMessageRecord {
                role: gate4agent_types::HistoryMessageRole::User,
                text: "bounded handoff".to_owned(),
            }],
        };
        let pack = NodeContextPack::export(
            ContextPackLineageReceipt {
                source_node_id: shared.node_id.clone(),
                source_session: terminal_address(1),
                source_provider: agent("claude"),
            },
            &history,
        )
        .unwrap();
        let context = shared
            .context_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(pack)
            .unwrap();
        let mut retained = record("codex", "context-retained-record");
        retained.context_id = Some(context.id.clone());
        retained.context = Some(context.clone());
        let record_id = retained.record_id.clone();
        shared.insert_record(retained).unwrap();
        assert_eq!(
            shared.forget_context_pack(&context.id).unwrap_err().code,
            NodeFailureCode::ContextPackBusy,
        );
        assert!(shared
            .context_catalog
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&context.id)
            .is_some());
        shared
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .remove(&record_id);

        let mut spec = spawn_spec_fixture();
        spec.overrides.context_id = crate::protocol::SpawnOverride::Set {
            value: context.id.clone(),
        };
        let resolved = shared.resolve_spawn_spec(&spec).unwrap();
        let receipt = resolved.receipt_with_materialization(
            shared.incarnation_id,
            terminal_address(2),
            None,
            None,
            Some(context.clone()),
        );
        assert!(receipt.context_binding_is_valid());
        shared.remember_spawn_spec(spec.clone(), Ok(receipt), Instant::now());

        shared.forget_context_pack(&context.id).unwrap();
        assert!(shared
            .context_catalog
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&context.id)
            .is_none());
        assert!(shared
            .replay_spawn_spec(&spec, Instant::now())
            .unwrap()
            .is_none());
    }

    #[test]
    fn environment_profile_selection_is_owned_by_the_exact_session_binding() {
        let (shared, mut runtime, environment_profile) = environment_profile_test_shared();
        let address = terminal_address(1);
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&environment_profile),
            )
            .unwrap()
            .unwrap();
        shared.bind_session_with_policy(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(environment_profile.clone()),
        );
        selection.retain();
        let native_id = NativeLaunchProfileId::new("local-claude-pty").unwrap();
        assert!(matches!(
            runtime.remove_native_launch_profile(&native_id),
            Err(gate4agent_runtime_native::NativeLaunchProfileError::ProfileInUse),
        ));
        assert!(shared.remove_binding(&address).is_some());
        assert_eq!(runtime.remove_native_launch_profile(&native_id), Ok(true));

        let mismatched = ResolvedEnvironmentProfileReceipt {
            profile_id: environment_profile.profile_id,
            profile_revision: crate::protocol::SpawnEnvironmentProfileRevision::new(
                "local-claude-r2",
            )
            .unwrap(),
            network_allowlist: None,
            browser_profile_id: None,
        };
        let error = match shared.select_environment_profile(
                AgentInstanceId(42),
                &agent("claude"),
                SessionMode::Pty,
                Some(&mismatched),
            ) {
            Ok(_) => panic!("mismatched environment profile revision was selected"),
            Err(error) => error,
        };
        assert_eq!(
            error.code,
            NodeFailureCode::EnvironmentProfileBindingMismatch,
        );
        assert!(!shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .contains_key(&AgentInstanceId(42)));
    }

    #[test]
    fn combined_environment_and_bundle_overlay_clears_with_its_binding() {
        let (shared, mut runtime, environment_profile) = environment_profile_test_shared();
        let address = terminal_address(1);
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&environment_profile),
            )
            .unwrap()
            .unwrap();
        let overlay = NativeInstanceLaunchOverlay::new(
            agent("claude"),
            TransportKind::Pty,
            vec![EnvMutation {
                key: OsString::from("GATE4AGENT_SESSION_TOKEN"),
                value: Some(OsString::from("fixture-secret")),
            }],
            vec![
                OsString::from("--plugin-dir"),
                std::env::current_dir().unwrap().into_os_string(),
            ],
        )
        .unwrap();
        let instance_overlay = shared
            .install_prepared_launch_overlay(
                address.session.instance_id,
                PreparedNativeLaunchOverlay::Instance(overlay),
            )
            .unwrap()
            .unwrap();
        let bundle = ResolvedBundleReceipt {
            id: crate::protocol::SpawnBundleId::new("combined-bundle").unwrap(),
            revision: crate::protocol::SpawnBundleRevision::new("combined-r1").unwrap(),
            digest: crate::protocol::SpawnBundleDigest::new(format!(
                "sha256:{}",
                "0".repeat(64),
            ))
            .unwrap(),
        };
        shared.bind_session_with_materialization(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(environment_profile),
            Some(bundle),
            None,
            None,
        );
        selection.retain();
        instance_overlay.retain();

        let native_id = NativeLaunchProfileId::new("local-claude-pty").unwrap();
        assert!(matches!(
            runtime.remove_native_launch_profile(&native_id),
            Err(gate4agent_runtime_native::NativeLaunchProfileError::ProfileInUse),
        ));
        assert!(shared.remove_binding(&address).is_some());
        assert!(!shared
            .native_launch_profile_control
            .as_ref()
            .unwrap()
            .clear_native_instance_launch_overlay(address.session.instance_id));
        assert_eq!(runtime.remove_native_launch_profile(&native_id), Ok(true));
    }

    #[test]
    fn session_environment_materialization_failure_is_pre_child_and_durable() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(true);
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(201),
                generation: SessionGeneration(1),
            },
        };
        let error = match shared.prepare_session_materialization(
            &address,
            &agent("claude"),
            SessionMode::Pty,
            Some(&receipt),
            None,
            None,
            None,
        ) {
            Ok(_) => panic!("denied local reference unexpectedly materialized"),
            Err(error) => error,
        };
        assert_eq!(error.code, NodeFailureCode::BackendOperationFailed);
        assert!(shared.handle.snapshot().sessions.is_empty());
        assert!(shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        assert!(shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn session_environment_binding_retains_on_stop_and_cleans_after_remove_reap() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(false);
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(202),
                generation: SessionGeneration(1),
            },
        };
        let (overlay, materialization_guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
                None,
                None,
                None,
            )
            .unwrap()
            .unwrap();
        let materialization_id = materialization_guard.id().unwrap().clone();
        let materialization_root = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&materialization_id)
            .unwrap()
            .root()
            .to_path_buf();
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
            )
            .unwrap()
            .unwrap();
        assert!(shared
            .install_prepared_launch_overlay(address.session.instance_id, overlay.unwrap())
            .unwrap()
            .is_none());
        shared.bind_session_with_materialization(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(receipt),
            None,
            None,
            Some(materialization_id),
        );
        selection.retain();
        materialization_guard.retain();

        assert!(materialization_root.is_dir());
        assert!(shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .contains_key(&address.session.instance_id));

        let removed = shared.remove_binding(&address).unwrap();
        shared
            .cleanup_session_owned_materialization(&address, &removed)
            .unwrap();
        assert!(!materialization_root.exists());
        assert!(shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn record_owned_session_environment_reuses_on_resume_and_forget_cleans() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(false);
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(203),
                generation: SessionGeneration(1),
            },
        };
        let (overlay, materialization_guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
                None,
                None,
                None,
            )
            .unwrap()
            .unwrap();
        let materialization_id = materialization_guard.id().unwrap().clone();
        let materialization_root = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&materialization_id)
            .unwrap()
            .root()
            .to_path_buf();
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
            )
            .unwrap()
            .unwrap();
        assert!(shared
            .install_prepared_launch_overlay(address.session.instance_id, overlay.unwrap())
            .unwrap()
            .is_none());
        let policy = ProviderRuntimePolicy::new(true, false, false, true, false, false).unwrap();
        let record_id = shared
            .bind_spawn_session_with_materialization(
                &address,
                agent("claude"),
                SessionMode::Pty,
                policy,
                SpawnRecordPolicy::ProviderIdentityOnly,
                Some(receipt.clone()),
                None,
                None,
                Some(materialization_id.clone()),
            )
            .unwrap()
            .unwrap();
        selection.retain();
        materialization_guard.retain();
        assert_eq!(
            shared
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&materialization_id)
                .unwrap()
                .owner(),
            &MaterializationOwner::Record {
                record_id: record_id.clone(),
            },
        );

        let removed = shared.remove_binding(&address).unwrap();
        shared
            .cleanup_session_owned_materialization(&address, &removed)
            .unwrap();
        assert!(materialization_root.is_dir());
        assert!(shared
            .resolve_record_materialization(
                &record_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
                None,
                None,
            )
            .unwrap()
            .is_some());
        {
            let mut records = shared
                .session_records
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let record = records.records.get_mut(&record_id).unwrap();
            record.active_session = None;
            record.state = ManagedSessionState::Unavailable;
        }
        shared.forget_session_record(&record_id).await.unwrap();
        assert!(!materialization_root.exists());
        assert!(shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn record_materialization_revalidation_failure_persists_recovery_required() {
        let (mut shared, runtime, receipt, root, _deny) = materialization_test_shared(false);
        let state_path = root.join("node-state-v6.json");
        shared.state_path = Some(state_path.clone());
        let (_address, _record_id, materialization_id, materialization_root) =
            bind_record_owned_materialization_fixture(&shared, &receipt, 205);
        std::fs::write(
            materialization_root.join(".gate4agent-materialization-owner"),
            b"tampered",
        )
        .unwrap();

        let error = match shared.resolve_record_materialization(
            &_record_id,
            &agent("claude"),
            SessionMode::Pty,
            Some(&receipt),
            None,
            None,
        ) {
            Ok(_) => panic!("tampered owner marker unexpectedly revalidated"),
            Err(error) => error,
        };
        assert_eq!(error.code, NodeFailureCode::BackendOperationFailed);
        assert_eq!(
            shared
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&materialization_id)
                .unwrap()
                .state(),
            MaterializationState::RecoveryRequired,
        );
        let loaded = session_registry::load(Some(&state_path), &shared.node_id).unwrap();
        assert_eq!(loaded.materializations.len(), 1);
        assert_eq!(
            loaded.materializations[0].state(),
            MaterializationState::RecoveryRequired,
        );
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn transient_record_materialization_resolution_failure_remains_ready() {
        let (shared, runtime, receipt, root, deny) = materialization_test_shared(false);
        let (_address, record_id, materialization_id, _materialization_root) =
            bind_record_owned_materialization_fixture(&shared, &receipt, 206);
        deny.store(true, Ordering::Release);

        let error = match shared.resolve_record_materialization(
            &record_id,
            &agent("claude"),
            SessionMode::Pty,
            Some(&receipt),
            None,
            None,
        ) {
            Ok(_) => panic!("denied transient resolver unexpectedly succeeded"),
            Err(error) => error,
        };
        assert_eq!(error.code, NodeFailureCode::BackendOperationFailed);
        assert_eq!(
            shared
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&materialization_id)
                .unwrap()
                .state(),
            MaterializationState::Ready,
        );
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn startup_missing_record_materialization_is_not_resumable() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(false);
        let record_id = SessionRecordId::new("sr-missing-materialization").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: record_id.clone(),
                display_name: "missing materialization".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::Dormant,
                workspace_id: WorkspaceId::new("primary").unwrap(),
                canonical_root: opaque_windows_path(
                    std::env::current_dir().unwrap().to_string_lossy().into_owned(),
                ),
                provider_session: Some(gate4agent_types::ProviderSessionIdentity {
                    key: gate4agent_types::ProviderSessionKey::SessionId,
                    id: "provider-session-missing-materialization".to_owned(),
                    transcript_path: None,
                }),
                active_session: None,
                environment_profile: Some(receipt),
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 1,
                updated_at_unix_ms: 1,
                last_error: None,
            })
            .unwrap();

        shared.reconcile_materializations();
        let record = shared.record(&record_id).unwrap();
        assert_eq!(record.state, ManagedSessionState::Unavailable);
        assert!(record.provider_session.is_none());
        assert_eq!(
            record.last_error.as_deref(),
            Some("environment-profile-unavailable"),
        );
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn managed_worktree_cleanup_waits_for_session_environment_cleanup() {
        let (shared, runtime, receipt, root, _deny) = materialization_test_shared(false);
        let lease = install_managed_lease(&shared);
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(204),
                generation: SessionGeneration(1),
            },
        };
        let (overlay, materialization_guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
                None,
                None,
                Some(lease.lease_id.clone()),
            )
            .unwrap()
            .unwrap();
        let materialization_id = materialization_guard.id().unwrap().clone();
        let materialization_root = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&materialization_id)
            .unwrap()
            .root()
            .to_path_buf();
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
            )
            .unwrap()
            .unwrap();
        assert!(shared
            .install_prepared_launch_overlay(address.session.instance_id, overlay.unwrap())
            .unwrap()
            .is_none());
        shared.bind_session_with_materialization(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            Some(receipt),
            None,
            None,
            Some(materialization_id),
        );
        selection.retain();
        materialization_guard.retain();

        let blocked = shared
            .cleanup_managed_worktree(&lease.lease_id, false)
            .await
            .unwrap_err();
        assert_eq!(blocked.code, NodeFailureCode::ManagedWorktreeRecoveryRequired);
        assert!(materialization_root.is_dir());
        let removed = shared.remove_binding(&address).unwrap();
        shared
            .cleanup_session_owned_materialization(&address, &removed)
            .unwrap();
        assert!(!materialization_root.exists());
        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn raw_managed_record_is_inventory_only_and_does_not_block_session_cleanup() {
        let git_root = temporary_workspace_root("raw-managed-inventory");
        let source = git_root.join("source");
        let allocation = git_root.join("allocation");
        std::fs::create_dir_all(&source).unwrap();
        std::fs::create_dir_all(&allocation).unwrap();
        run_test_git(&source, &["init"]);
        run_test_git(&source, &["config", "user.email", "gate4agent@example.invalid"]);
        run_test_git(&source, &["config", "user.name", "Gate4Agent Test"]);
        std::fs::write(source.join("seed.txt"), "seed\n").unwrap();
        run_test_git(&source, &["add", "seed.txt"]);
        run_test_git(&source, &["commit", "-m", "seed"]);
        let profile = ManagedWorktreeProfile::new(
            WorktreeProfileId::new("default").unwrap(),
            crate::protocol::WorktreeProfileRevision::new("v1").unwrap(),
            &allocation,
            "gate4agent",
            "HEAD",
            ManagedWorktreeRetention::RemoveWhenReleased,
        )
        .unwrap();
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            &source,
        )
        .unwrap()
        .with_worktree_service_mode(WorktreeServiceMode::Managed)
        .with_managed_worktree_profile(profile.clone())
        .unwrap();
        let (shared, mut runtime, receipt, materialization_fixture_root, _deny) =
            materialization_test_shared_with_workspace(false, workspace);
        let target = PathBuf::from(profile.allocation_root()).join("mw-raw-inventory");
        let source_text = source.to_string_lossy().into_owned();
        let target_text = target.to_string_lossy().into_owned();
        let created = create_git_worktree(
            &source_text,
            &target_text,
            "gate4agent/mw-raw-inventory",
            Some("HEAD"),
        )
        .await
        .unwrap();
        let lease = ManagedWorktreeLeaseRecord {
            lease_id: ManagedWorktreeLeaseId::new("mw-raw-inventory").unwrap(),
            source_workspace_id: WorkspaceId::new("primary").unwrap(),
            workspace_id: WorkspaceId::new("managed-raw-inventory").unwrap(),
            profile_id: profile.profile_id().clone(),
            profile_revision: profile.revision().clone(),
            target_root: created.path.clone(),
            branch: "gate4agent/mw-raw-inventory".to_owned(),
            base_commit: created.head.clone(),
            expected_head: Some(created.head.clone()),
            retention: ManagedWorktreeRetention::RemoveWhenReleased,
            state: ManagedWorktreeLeaseState::Ready,
            session_holders: Vec::new(),
            record_holders: Vec::new(),
            cleanup_failure: None,
            created_at_unix_ms: 1,
            updated_at_unix_ms: 1,
        };
        shared
            .workspaces
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(lease.workspace_id.clone(), created.path.clone());
        *shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            ManagedWorktreeRegistry::from_records(vec![lease.clone()], Vec::new()).unwrap();
        let address = SessionAddress {
            workspace_id: lease.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(205),
                generation: SessionGeneration(1),
            },
        };
        let (overlay, materialization_guard) = shared
            .prepare_session_materialization(
                &address,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
                None,
                None,
                Some(lease.lease_id.clone()),
            )
            .unwrap()
            .unwrap();
        let materialization_id = materialization_guard.id().unwrap().clone();
        let materialization_root = shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&materialization_id)
            .unwrap()
            .root()
            .to_path_buf();
        let selection = shared
            .select_environment_profile(
                address.session.instance_id,
                &agent("claude"),
                SessionMode::Pty,
                Some(&receipt),
            )
            .unwrap()
            .unwrap();
        assert!(shared
            .install_prepared_launch_overlay(address.session.instance_id, overlay.unwrap())
            .unwrap()
            .is_none());
        let record_id = shared
            .bind_spawn_session_with_materialization(
                &address,
                agent("claude"),
                SessionMode::Pty,
                ProviderRuntimePolicy::raw_pty(),
                SpawnRecordPolicy::Always,
                Some(receipt.clone()),
                None,
                None,
                Some(materialization_id.clone()),
            )
            .unwrap()
            .unwrap();
        selection.retain();
        materialization_guard.retain();
        let record = shared.record(&record_id).unwrap();
        assert_eq!(record.state, ManagedSessionState::Live);
        assert!(record.provider_session.is_none());
        assert!(record.environment_profile.is_none());
        assert!(record.bundle.is_none());
        assert!(record.context_id.is_none());
        assert!(record.context.is_none());
        assert_eq!(record.active_session.as_ref(), Some(&address));
        assert_eq!(
            shared
                .materializations
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&materialization_id)
                .unwrap()
                .owner(),
            &MaterializationOwner::Session {
                incarnation_id: shared.incarnation_id,
                instance_id: address.session.instance_id,
                generation: address.session.generation,
            },
        );
        {
            let mut bindings = shared
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            bindings
                .get_mut(&address.session.instance_id)
                .unwrap()
                .managed_worktree_lease_id = Some(lease.lease_id.clone());
        }
        let lease_snapshot = shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .bind_session(
                &lease.lease_id,
                ManagedWorktreeSessionHolder {
                    incarnation_id: shared.incarnation_id,
                    instance_id: address.session.instance_id,
                    generation: address.session.generation,
                },
                None,
                unix_time_ms(),
            )
            .unwrap();
        assert_eq!(lease_snapshot.active_session_count, 1);
        assert_eq!(lease_snapshot.managed_record_count, 0);
        shared.persist_state().unwrap();
        assert!(shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&lease.lease_id)
            .unwrap()
            .record_holders
            .is_empty());
        shared
            .handle
            .dispatch(shared.prepare_command(ControlCommand::Register {
                instance_id: address.session.instance_id,
                agent_id: agent("claude"),
                transport: TransportKind::Pty,
            }))
            .unwrap();
        runtime.tick().await;
        shared.reconcile_managed_record(
            &record_id,
            &address,
            &ControlEvent {
                sequence: 1,
                command_id: None,
                instance_id: address.session.instance_id,
                generation: address.session.generation,
                event: ControlEventKind::Removed,
            },
            false,
            false,
        );
        let remove = shared.remove_session(&address);
        let drive_runtime = async {
            runtime.tick().await;
        };
        let (removed, ()) = tokio::join!(remove, drive_runtime);
        removed.unwrap();

        assert!(!materialization_root.exists());
        assert!(!Path::new(&created.path).exists());
        assert_eq!(
            shared
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&lease.lease_id)
                .unwrap()
                .state,
            ManagedWorktreeLeaseState::Removed,
        );
        let renamed = shared
            .rename_session_record(&record_id, "raw managed inventory".to_owned())
            .unwrap();
        assert_eq!(renamed.record_id, record_id);
        assert_eq!(renamed.display_name, "raw managed inventory");
        assert_eq!(renamed.state, ManagedSessionState::Unavailable);
        assert!(renamed.active_session.is_none());

        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(materialization_fixture_root).unwrap();
        std::fs::remove_dir_all(git_root).unwrap();
    }

    fn install_managed_lease(shared: &NodeShared) -> ManagedWorktreeLeaseRecord {
        let root = std::env::current_dir().unwrap()
            .join("managed-test-target")
            .to_string_lossy()
            .into_owned();
        let lease = ManagedWorktreeLeaseRecord {
            lease_id: ManagedWorktreeLeaseId::new("mw-test").unwrap(),
            source_workspace_id: WorkspaceId::new("primary").unwrap(),
            workspace_id: WorkspaceId::new("managed-test").unwrap(),
            profile_id: WorktreeProfileId::new("default").unwrap(),
            profile_revision: crate::protocol::WorktreeProfileRevision::new("v1").unwrap(),
            target_root: root.clone(),
            branch: "gate4agent/mw-test".to_owned(),
            base_commit: "0123456789abcdef0123456789abcdef01234567".to_owned(),
            expected_head: Some("0123456789abcdef0123456789abcdef01234567".to_owned()),
            retention: ManagedWorktreeRetention::RemoveWhenReleased,
            state: ManagedWorktreeLeaseState::Ready,
            session_holders: Vec::new(),
            record_holders: Vec::new(),
            cleanup_failure: None,
            created_at_unix_ms: 1,
            updated_at_unix_ms: 1,
        };
        shared.workspaces.write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(lease.workspace_id.clone(), root);
        *shared.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            ManagedWorktreeRegistry::from_records(vec![lease.clone()], Vec::new()).unwrap();
        lease
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn monitoring_fixture_managed_spawn_retains_effective_record_holder_and_converges_live() {
        let mut shared = terminal_test_shared();
        shared.fixture_semantic_hook_policy = true;
        let lease = install_managed_lease(&shared);
        let address = SessionAddress {
            workspace_id: lease.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(206),
                generation: SessionGeneration(1),
            },
        };
        let pre_admission_policy = ProviderRuntimePolicy::raw_pty();
        let effective_runtime_policy =
            shared.effective_spawn_runtime_policy(pre_admission_policy);
        assert_ne!(effective_runtime_policy, pre_admission_policy);
        assert!(effective_runtime_policy.provider_session_identity);

        let record_id = shared
            .bind_spawn_session(
                &address,
                agent("claude"),
                SessionMode::Pty,
                effective_runtime_policy,
                SpawnRecordPolicy::Always,
                None,
            )
            .unwrap()
            .unwrap();
        assert_eq!(
            shared.record(&record_id).unwrap().state,
            ManagedSessionState::IdentityPending,
        );
        let (record_holder, raw_inventory_record_id) = {
            let mut bindings = shared
                .session_bindings
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let binding = bindings.get_mut(&address.session.instance_id).unwrap();
            binding.managed_worktree_lease_id = Some(lease.lease_id.clone());
            managed_spawn_record_ownership(binding, effective_runtime_policy)
        };
        assert_eq!(record_holder.as_ref(), Some(&record_id));
        assert!(raw_inventory_record_id.is_none());
        let snapshot = shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .bind_session(
                &lease.lease_id,
                ManagedWorktreeSessionHolder {
                    incarnation_id: shared.incarnation_id,
                    instance_id: address.session.instance_id,
                    generation: address.session.generation,
                },
                record_holder,
                unix_time_ms(),
            )
            .unwrap();
        assert_eq!(snapshot.managed_record_count, 1);
        assert_eq!(
            shared
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&lease.lease_id)
                .unwrap()
                .record_holders,
            vec![record_id.clone()],
        );

        let identity = ProviderSessionIdentity {
            key: ProviderSessionKey::SessionId,
            id: "monitoring-fixture-managed-session".to_owned(),
            transcript_path: None,
        };
        shared.publish_control(ControlEvent {
            sequence: 1,
            command_id: None,
            instance_id: address.session.instance_id,
            generation: address.session.generation,
            event: ControlEventKind::ProviderEvent {
                sequence: 1,
                source: gate4agent_types::ProviderSource {
                    family: AdapterFamily::Hook,
                    binding: AdapterBinding::new(
                        gate4agent_types::AdapterId::new("claude-code").unwrap(),
                        "fixture/v1",
                        gate4agent_types::AdapterVerification::SyntheticFixture,
                    )
                    .unwrap(),
                },
                source_sequence: 1,
                event: ProviderEvent::SessionIdentityObserved {
                    identity: identity.clone(),
                },
            },
        });

        let live = shared.record(&record_id).unwrap();
        assert_eq!(live.state, ManagedSessionState::Live);
        assert_eq!(live.provider_session.as_ref(), Some(&identity));
        assert_eq!(live.active_session.as_ref(), Some(&address));
        assert_eq!(
            shared
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .get(&lease.lease_id)
                .unwrap()
                .record_holders,
            vec![record_id],
        );
    }

    fn managed_v2_test_shared(
        allocation_root: &Path,
        state_path: Option<PathBuf>,
        profile_revision: &str,
    ) -> NodeShared {
        let profile = ManagedWorktreeProfile::new(
            WorktreeProfileId::new("default").unwrap(),
            WorktreeProfileRevision::new(profile_revision).unwrap(),
            allocation_root,
            "gate4agent",
            "HEAD",
            ManagedWorktreeRetention::RemoveWhenReleased,
        )
        .unwrap();
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap()
        .with_worktree_service_mode(WorktreeServiceMode::Managed)
        .with_managed_worktree_profile(profile)
        .unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-terminal-test").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        shared.state_path = state_path;
        shared
    }

    fn managed_v2_request(idempotency_key: &str) -> ManagedWorktreeSpawnRequestV2 {
        let mut spawn_spec = spawn_spec_fixture();
        spawn_spec.idempotency_key = SpawnIdempotencyKey::new(idempotency_key).unwrap();
        ManagedWorktreeSpawnRequestV2 {
            spawn_spec,
            worktree_profile_id: WorktreeProfileId::new("default").unwrap(),
            expected_profile_revision: WorktreeProfileRevision::new("v1").unwrap(),
        }
    }

    #[test]
    fn managed_spawn_receipt_rebinds_allocated_worktree_and_roundtrips_wire() {
        let shared = terminal_test_shared();
        let mut lease = install_managed_lease(&shared);
        let session = SessionAddress {
            workspace_id: lease.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(73),
                generation: SessionGeneration(4),
            },
        };
        lease.state = ManagedWorktreeLeaseState::InUse;
        lease.session_holders.push(ManagedWorktreeSessionHolder {
            incarnation_id: shared.incarnation_id,
            instance_id: session.session.instance_id,
            generation: session.session.generation,
        });
        let resolved = shared.resolve_spawn_spec(&spawn_spec_fixture()).unwrap();
        assert!(resolved.target.worktree_id.is_none());

        let receipt = managed_spawn_receipt(
            &resolved,
            shared.incarnation_id,
            session.clone(),
            lease.snapshot(),
            None,
            None,
            None,
        );
        assert!(resolved.target.worktree_id.is_none());
        assert_eq!(receipt.spawn.target.workspace_id, lease.source_workspace_id);
        assert_eq!(receipt.spawn.target.worktree_id.as_ref(), Some(&lease.workspace_id));
        assert_eq!(receipt.spawn.session, session);
        assert_eq!(receipt.lease.workspace_id, lease.workspace_id);
        let encoded = serde_json::to_vec(&receipt).unwrap();
        let decoded: ManagedWorktreeSpawnReceipt = serde_json::from_slice(&encoded).unwrap();
        assert_eq!(decoded, receipt);
    }

    #[tokio::test]
    async fn managed_spawn_v2_rejects_profile_revision_before_allocation() {
        let root = temporary_workspace_root("managed-v2-revision");
        let allocation = root.join("allocation");
        std::fs::create_dir_all(&allocation).unwrap();
        let shared = managed_v2_test_shared(
            &allocation,
            Some(root.join("node-state.json")),
            "v1",
        );
        let mut request = managed_v2_request("managed-v2-revision");
        request.expected_profile_revision = WorktreeProfileRevision::new("v2").unwrap();

        let failure = shared.spawn_managed_worktree_v2(request).await.unwrap_err();

        assert_eq!(
            failure.code,
            NodeFailureCode::ManagedWorktreeProfileRevisionMismatch,
        );
        assert!(shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records()
            .is_empty());
        assert!(shared
            .managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn managed_spawn_v2_concurrent_same_key_has_one_durable_reservation() {
        let root = temporary_workspace_root("managed-v2-concurrent");
        let allocation = root.join("allocation");
        std::fs::create_dir_all(&allocation).unwrap();
        let shared = Arc::new(managed_v2_test_shared(
            &allocation,
            Some(root.join("node-state.json")),
            "v1",
        ));
        let request = managed_v2_request("managed-v2-concurrent");
        let barrier = Arc::new(std::sync::Barrier::new(3));
        let mut joins = Vec::new();
        for _ in 0..2 {
            let shared = Arc::clone(&shared);
            let request = request.clone();
            let barrier = Arc::clone(&barrier);
            joins.push(std::thread::spawn(move || {
                let digest = managed_spawn_request_digest_v2(&request).unwrap();
                barrier.wait();
                shared.acquire_durable_managed_spawn_v2(&request, digest)
            }));
        }
        barrier.wait();
        let results = joins
            .into_iter()
            .map(|join| join.join().unwrap())
            .collect::<Vec<_>>();
        assert_eq!(
            results
                .iter()
                .filter(|result| {
                    matches!(result, Ok(DurableManagedSpawnReplayDecision::Reserved))
                })
                .count(),
            1,
        );
        assert_eq!(
            results
                .iter()
                .filter(|result| {
                    matches!(result, Err(error) if error.code == NodeFailureCode::BackendBusy)
                })
                .count(),
            1,
        );
        assert_eq!(
            shared
                .managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .len(),
            1,
        );
        assert!(shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records()
            .is_empty());
        drop(shared);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn managed_spawn_v2_linked_pending_reopen_fails_closed_without_reallocation() {
        let root = temporary_workspace_root("managed-v2-linked-pending");
        let allocation = root.join("allocation");
        std::fs::create_dir_all(&allocation).unwrap();
        let state_path = root.join("node-state.json");
        let shared = managed_v2_test_shared(&allocation, Some(state_path.clone()), "v1");
        let lease = install_managed_lease(&shared);
        let request = managed_v2_request("managed-v2-linked-pending");
        assert!(matches!(
            shared
                .acquire_durable_managed_spawn_v2(
                    &request,
                    managed_spawn_request_digest_v2(&request).unwrap(),
                )
                .unwrap(),
            DurableManagedSpawnReplayDecision::Reserved,
        ));
        {
            let _transaction = shared
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            shared
                .link_durable_managed_spawn_v2_lease_locked(
                    &request.spawn_spec.idempotency_key,
                    &lease.lease_id,
                )
                .unwrap();
            shared.persist_state_locked().unwrap();
        }
        drop(shared);

        let mut loaded = session_registry::load(
            Some(&state_path),
            &NodeId::new("node-terminal-test").unwrap(),
        )
        .unwrap();
        let reopened = managed_v2_test_shared(&allocation, Some(state_path), "v2");
        *reopened
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            ManagedWorktreeRegistry::from_records(
                std::mem::take(&mut loaded.managed_worktrees),
                std::mem::take(&mut loaded.managed_worktree_tombstones),
            )
            .unwrap();
        *reopened
            .managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) = loaded
            .managed_spawn_replays
            .into_iter()
            .map(|record| (record.idempotency_key.clone(), record))
            .collect();
        let lease_count = reopened
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records()
            .len();

        let failure = reopened
            .spawn_managed_worktree_v2(request)
            .await
            .unwrap_err();

        assert_eq!(
            failure.code,
            NodeFailureCode::ManagedWorktreeRecoveryRequired,
        );
        assert_eq!(
            reopened
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records()
                .len(),
            lease_count,
        );
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn managed_spawn_v2_replays_exact_receipt_after_durable_reopen_and_conflicts() {
        let root = temporary_workspace_root("managed-v2-reopen");
        let allocation = root.join("allocation");
        std::fs::create_dir_all(&allocation).unwrap();
        let state_path = root.join("node-state.json");
        let shared = managed_v2_test_shared(&allocation, Some(state_path.clone()), "v1");
        let lease = install_managed_lease(&shared);
        let request = managed_v2_request("managed-v2-reopen");
        let session = SessionAddress {
            workspace_id: lease.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(91),
                generation: SessionGeneration(1),
            },
        };
        let snapshot = {
            let mut registry = shared
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            let current = registry.get_mut(&lease.lease_id).unwrap();
            current.state = ManagedWorktreeLeaseState::InUse;
            current.session_holders.push(ManagedWorktreeSessionHolder {
                incarnation_id: shared.incarnation_id,
                instance_id: session.session.instance_id,
                generation: session.session.generation,
            });
            current.snapshot()
        };
        let resolved = shared.resolve_spawn_spec(&request.spawn_spec).unwrap();
        let receipt = managed_spawn_receipt(
            &resolved,
            shared.incarnation_id,
            session,
            snapshot,
            None,
            None,
            None,
        );
        assert!(matches!(
            shared
                .acquire_durable_managed_spawn_v2(
                    &request,
                    managed_spawn_request_digest_v2(&request).unwrap(),
                )
                .unwrap(),
            DurableManagedSpawnReplayDecision::Reserved,
        ));
        {
            let _transaction = shared
                .state_transaction
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner());
            shared
                .link_durable_managed_spawn_v2_lease_locked(
                    &request.spawn_spec.idempotency_key,
                    &lease.lease_id,
                )
                .unwrap();
            shared.persist_state_locked().unwrap();
        }
        shared
            .commit_durable_managed_spawn_v2(&request, receipt.clone())
            .unwrap();
        let legacy_same_key = ManagedWorktreeSpawnRequest {
            spawn_spec: request.spawn_spec.clone(),
            worktree_profile_id: request.worktree_profile_id.clone(),
        };
        shared.remember_managed_spawn_attempt(
            Some(&request.spawn_spec.idempotency_key),
            legacy_same_key.clone(),
            Ok(receipt.clone()),
            Instant::now(),
        );
        assert!(shared
            .replay_managed_spawn(&legacy_same_key, Instant::now())
            .unwrap()
            .is_none());
        drop(shared);

        let mut loaded = session_registry::load(
            Some(&state_path),
            &NodeId::new("node-terminal-test").unwrap(),
        )
        .unwrap();
        assert_eq!(loaded.managed_spawn_replays.len(), 1);
        let reopened = managed_v2_test_shared(&allocation, Some(state_path), "v2");
        *reopened
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            ManagedWorktreeRegistry::from_records(
                std::mem::take(&mut loaded.managed_worktrees),
                std::mem::take(&mut loaded.managed_worktree_tombstones),
            )
            .unwrap();
        *reopened
            .managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) = loaded
            .managed_spawn_replays
            .into_iter()
            .map(|record| (record.idempotency_key.clone(), record))
            .collect();
        let lease_count_before = reopened
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records()
            .len();

        assert_eq!(
            reopened
                .spawn_managed_worktree_v2(request.clone())
                .await
                .unwrap(),
            receipt,
        );
        assert_eq!(
            reopened
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records()
                .len(),
            lease_count_before,
        );
        let mut changed = request;
        changed.spawn_spec.deadline_ms = crate::protocol::SpawnDeadlineMs::new(29_000).unwrap();
        let failure = reopened
            .spawn_managed_worktree_v2(changed)
            .await
            .unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnIdempotencyConflict);
        assert_eq!(
            reopened
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records()
                .len(),
            lease_count_before,
        );
        let mut new_key = managed_v2_request("managed-v2-new-after-profile-change");
        new_key.expected_profile_revision = WorktreeProfileRevision::new("v1").unwrap();
        let failure = reopened
            .spawn_managed_worktree_v2(new_key)
            .await
            .unwrap_err();
        assert_eq!(
            failure.code,
            NodeFailureCode::ManagedWorktreeProfileRevisionMismatch,
        );
        assert_eq!(
            reopened
                .managed_worktrees
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .records()
                .len(),
            lease_count_before,
        );
        assert_eq!(
            reopened
                .managed_spawn_replays
                .lock()
                .unwrap_or_else(|poisoned| poisoned.into_inner())
                .len(),
            1,
        );
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn legacy_managed_spawn_idempotency_remains_transient_and_exact() {
        let shared = terminal_test_shared();
        let request = ManagedWorktreeSpawnRequest {
            spawn_spec: spawn_spec_fixture(),
            worktree_profile_id: WorktreeProfileId::new("default").unwrap(),
        };
        let expected = failure(NodeFailureCode::BackendBusy, "legacy fixture failure");
        shared.remember_managed_spawn(
            request.clone(),
            Err(expected.clone()),
            Instant::now(),
        );

        assert_eq!(
            shared
                .replay_managed_spawn(&request, Instant::now())
                .unwrap()
                .unwrap(),
            Err(expected),
        );
        assert!(shared
            .managed_spawn_replays
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
    }

    #[tokio::test]
    async fn ordinary_spawn_and_spawn_spec_cannot_bypass_managed_lease_holder_fence() {
        let shared = terminal_test_shared();
        let lease = install_managed_lease(&shared);
        let raw = shared.spawn_session(
            lease.workspace_id.clone(),
            agent("claude"),
            SessionMode::Pty,
            gate4agent_types::TerminalSize { rows: 24, columns: 80 },
            None,
        ).await.unwrap_err();
        assert_eq!(raw.code, NodeFailureCode::ManagedWorktreeOwnershipConflict);
        let mut spec = spawn_spec_fixture();
        spec.target.workspace_id = lease.workspace_id.clone();
        let specified = shared.spawn_from_spec(spec).await.unwrap_err();
        assert_eq!(specified.code, NodeFailureCode::ManagedWorktreeOwnershipConflict);
        let mut selected = spawn_spec_fixture();
        selected.idempotency_key = SpawnIdempotencyKey::new("managed-selected-bypass").unwrap();
        selected.target.worktree_id = Some(lease.workspace_id);
        let selected = shared.spawn_from_spec(selected).await.unwrap_err();
        assert_eq!(selected.code, NodeFailureCode::ManagedWorktreeOwnershipConflict);
        assert!(shared.handle.snapshot().sessions.is_empty());
    }

    #[test]
    fn legacy_projection_omits_managed_snapshot_events_and_path_bearing_diagnostics() {
        let shared = terminal_test_shared();
        let lease = install_managed_lease(&shared);
        let snapshot = snapshot_for_wire(
            &shared, true, true, true, false, true, true, false, false, true,
        );
        assert!(snapshot.managed_worktrees.is_empty());
        assert!(snapshot.workspaces.iter().all(|workspace| {
            workspace.managed_worktree_profiles.is_none()
        }));
        let mut reply = ResponseEnvelope {
            request_id: 1,
            result: Ok(NodeResponse::Resync {
                event_sequence: 1,
                oldest_available_sequence: 1,
                snapshot: shared.snapshot(),
                events: vec![NodeEventEnvelope {
                    sequence: 1,
                    event: NodeEvent::ManagedWorktreeUpserted { lease: lease.snapshot() },
                }],
            }),
        };
        project_response_without_managed_worktrees(&mut reply);
        let Ok(NodeResponse::Resync { snapshot, events, .. }) = reply.result else {
            panic!("projection changed the response kind");
        };
        assert!(snapshot.managed_worktrees.is_empty());
        assert!(events.is_empty());
        let mut git = git_snapshot_for_parser();
        git.branch = Some(lease.branch.clone());
        git.managed_worktree = Some(crate::protocol::ManagedWorktreeGitScope {
            lease_id: lease.lease_id.clone(),
            source_workspace_id: lease.source_workspace_id.clone(),
            branch: lease.branch.clone(),
            base_commit: GitObjectId::new(lease.base_commit.clone()).unwrap(),
            active_session_count: 1,
            managed_record_count: 0,
        });
        let mut inspection_reply = ResponseEnvelope {
            request_id: 2,
            result: Ok(NodeResponse::WorkspaceInspected {
                inspection: WorkspaceInspection {
                    workspace_id: lease.workspace_id.clone(),
                    entries: Vec::new(),
                    tree_truncated: false,
                    git,
                    truncation: None,
                },
            }),
        };
        project_response_without_managed_worktrees(&mut inspection_reply);
        let Ok(NodeResponse::WorkspaceInspected { inspection }) = inspection_reply.result else {
            panic!("projection changed the inspection response kind");
        };
        assert!(inspection.git.managed_worktree.is_none());
        let failure = managed_git_worktree_failure(GitWorktreeError {
            kind: GitWorktreeErrorKind::Failed,
            message: r"git failed at C:\private\managed-target".to_owned(),
        });
        assert!(!failure.message.contains("private"));
        assert!(!failure.message.contains("managed-target"));
    }

    #[tokio::test]
    async fn restart_reconciliation_retains_exact_owned_worktree_and_explicit_cleanup_removes_it() {
        let root = temporary_workspace_root("managed-restart");
        let source = root.join("source");
        let allocation = root.join("allocation");
        std::fs::create_dir_all(&source).unwrap();
        std::fs::create_dir_all(&allocation).unwrap();
        run_test_git(&source, &["init"]);
        run_test_git(&source, &["config", "user.email", "gate4agent@example.invalid"]);
        run_test_git(&source, &["config", "user.name", "Gate4Agent Test"]);
        std::fs::write(source.join("seed.txt"), "seed\n").unwrap();
        run_test_git(&source, &["add", "seed.txt"]);
        run_test_git(&source, &["commit", "-m", "seed"]);
        let profile = ManagedWorktreeProfile::new(
            WorktreeProfileId::new("default").unwrap(),
            crate::protocol::WorktreeProfileRevision::new("v1").unwrap(),
            &allocation,
            "gate4agent",
            "HEAD",
            ManagedWorktreeRetention::Retain,
        ).unwrap();
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            &source,
        ).unwrap()
            .with_worktree_service_mode(WorktreeServiceMode::Managed)
            .with_managed_worktree_profile(profile.clone()).unwrap();
        let target = PathBuf::from(profile.allocation_root()).join("mw-restart");
        let source_text = workspace.canonical_root().to_owned();
        let target_text = target.to_string_lossy().into_owned();
        let created = create_git_worktree(
            &source_text,
            &target_text,
            "gate4agent/mw-restart",
            Some("HEAD"),
        ).await.unwrap();
        let lease = ManagedWorktreeLeaseRecord {
            lease_id: ManagedWorktreeLeaseId::new("mw-restart").unwrap(),
            source_workspace_id: WorkspaceId::new("primary").unwrap(),
            workspace_id: WorkspaceId::new("managed-restart").unwrap(),
            profile_id: profile.profile_id().clone(),
            profile_revision: profile.revision().clone(),
            target_root: created.path.clone(),
            branch: "gate4agent/mw-restart".to_owned(),
            base_commit: created.head.clone(),
            expected_head: None,
            retention: ManagedWorktreeRetention::Retain,
            state: ManagedWorktreeLeaseState::Allocating,
            session_holders: Vec::new(),
            record_holders: Vec::new(),
            cleanup_failure: None,
            created_at_unix_ms: 1,
            updated_at_unix_ms: 1,
        };
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-managed-restart").unwrap(),
            NodeIncarnationId::from_bytes([7; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            None,
            None,
            None,
            None,
            Vec::new(),
            vec![lease.clone()],
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        shared.reconcile_managed_worktrees().await;
        let retained = shared.managed_worktrees.lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&lease.lease_id).unwrap().clone();
        assert_eq!(retained.state, ManagedWorktreeLeaseState::Retained);
        assert!(shared.workspaces.read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .contains_key(&lease.workspace_id));
        let removed = shared.cleanup_managed_worktree(&lease.lease_id, true).await.unwrap();
        assert_eq!(removed.state, ManagedWorktreeLeaseState::Removed);
        assert!(!Path::new(&created.path).exists());
        std::fs::remove_dir_all(root).unwrap();
    }

    fn run_test_git(root: &Path, arguments: &[&str]) {
        let output = std::process::Command::new("git")
            .arg("-C").arg(root).args(arguments).output().unwrap();
        assert!(
            output.status.success(),
            "git {:?} failed: {}",
            arguments,
            String::from_utf8_lossy(&output.stderr),
        );
    }

    #[tokio::test]
    async fn spawn_spec_validation_fails_before_session_mutation() {
        let shared = terminal_test_shared();
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_SPAWN_SPEC_DEFAULTS_OVERRIDES_CAPABILITY
        }));
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_SPAWN_PROFILE_REVISION_CAPABILITY
        }));
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_WORKTREE_SELECTION_CAPABILITY
        }));

        let mut target_mismatch = spawn_spec_fixture();
        target_mismatch.target.node_id = NodeId::new("other-node").unwrap();
        let failure = shared.spawn_from_spec(target_mismatch).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnTargetMismatch);

        let mut unknown_profile = spawn_spec_fixture();
        unknown_profile.idempotency_key = SpawnIdempotencyKey::new("unknown-profile").unwrap();
        unknown_profile.profile_id = crate::protocol::SpawnProfileId::new("missing").unwrap();
        let failure = shared.spawn_from_spec(unknown_profile).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::UnknownSpawnProfile);

        let mut revision_mismatch = spawn_spec_fixture();
        revision_mismatch.idempotency_key =
            SpawnIdempotencyKey::new("profile-revision-mismatch").unwrap();
        revision_mismatch.expected_profile_revision =
            crate::protocol::SpawnProfileRevision::new("test-r2").unwrap();
        let failure = shared.spawn_from_spec(revision_mismatch).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnProfileRevisionMismatch);

        let mut unsupported_materializer = spawn_spec_fixture();
        unsupported_materializer.idempotency_key =
            SpawnIdempotencyKey::new("unsupported-materializer").unwrap();
        unsupported_materializer.overrides.bundle_id = crate::protocol::SpawnOverride::Set {
            value: crate::protocol::SpawnBundleId::new("bundle-v1").unwrap(),
        };
        let failure = shared
            .spawn_from_spec(unsupported_materializer)
            .await
            .unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::UnknownBundle);

        let failure = shared
            .spawn_session_with_deadline(
                WorkspaceId::new("primary").unwrap(),
                agent("claude"),
                SessionMode::Pty,
                gate4agent_types::TerminalSize {
                    rows: 24,
                    columns: 80,
                },
                None,
                None,
                None,
                None,
                None,
                None,
                SpawnRecordPolicy::ProviderIdentityOnly,
                Some(Instant::now()),
                &[],
                None,
                ApprovalLevel::default(),
                None,
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnDeadlineExceeded);
        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 1);
        assert!(shared.handle.snapshot().sessions.is_empty());
    }

    #[test]
    fn worktree_selection_requires_its_separate_negotiated_capability() {
        let mut spec = spawn_spec_fixture();
        spec.target.worktree_id = Some(WorkspaceId::new("selected-worktree").unwrap());
        let request = NodeRequest::SpawnSpec { spec };
        let spawn_spec_capability =
            CapabilityId::new(NODE_SPAWN_SPEC_DEFAULTS_OVERRIDES_CAPABILITY).unwrap();
        assert!(request_uses_unnegotiated_capability(
            &request,
            &[spawn_spec_capability.clone()],
        ));
        let worktree_capability =
            CapabilityId::new(NODE_WORKTREE_SELECTION_CAPABILITY).unwrap();
        assert!(request_uses_unnegotiated_capability(
            &request,
            &[spawn_spec_capability.clone(), worktree_capability.clone()],
        ));
        let profile_revision_capability =
            CapabilityId::new(NODE_SPAWN_PROFILE_REVISION_CAPABILITY).unwrap();
        assert!(request_uses_unnegotiated_capability(
            &request,
            &[
                spawn_spec_capability.clone(),
                worktree_capability.clone(),
                profile_revision_capability.clone(),
            ],
        ));
        // Default `SpawnOverrides` leaves `bundle_id`/`context_id` at
        // `Inherit`, not `Clear` — the profile's own defaults might still
        // materialize a bundle or a context pack, so both capabilities stay
        // conservatively required until negotiated (see
        // `requires_session_bundle_materialization_capability` /
        // `requires_history_context_pack_capability`).
        let bundle_materialization_capability =
            CapabilityId::new(NODE_SESSION_BUNDLE_MATERIALIZATION_CAPABILITY).unwrap();
        assert!(request_uses_unnegotiated_capability(
            &request,
            &[
                spawn_spec_capability.clone(),
                worktree_capability.clone(),
                profile_revision_capability.clone(),
                bundle_materialization_capability.clone(),
            ],
        ));
        let history_context_pack_capability =
            CapabilityId::new(NODE_HISTORY_CONTEXT_PACK_CAPABILITY).unwrap();
        assert!(!request_uses_unnegotiated_capability(
            &request,
            &[
                spawn_spec_capability,
                worktree_capability,
                profile_revision_capability,
                bundle_materialization_capability,
                history_context_pack_capability,
            ],
        ));
    }

    #[tokio::test]
    async fn spawn_spec_idempotency_replays_receipt_and_conflicts_before_session_mutation() {
        let mut shared = terminal_test_shared();
        let spec = spawn_spec_fixture();
        let receipt = shared
            .resolve_spawn_spec(&spec)
            .unwrap()
            .receipt(shared.incarnation_id, terminal_address(1));
        shared.remember_spawn_spec(spec.clone(), Ok(receipt.clone()), Instant::now());

        let mut revised = shared.spawn_profiles.get(&spec.profile_id).unwrap().clone();
        revised.revision = crate::protocol::SpawnProfileRevision::new("builtin-v2").unwrap();
        shared.spawn_profiles = SpawnProfileRegistry::new([revised]).unwrap();

        assert_eq!(shared.spawn_from_spec(spec.clone()).await.unwrap(), receipt);

        let mut revision_conflicting = spec.clone();
        revision_conflicting.expected_profile_revision =
            crate::protocol::SpawnProfileRevision::new("builtin-v2").unwrap();
        let failure = shared.spawn_from_spec(revision_conflicting).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnIdempotencyConflict);

        let mut stale_cache_miss = spec.clone();
        stale_cache_miss.idempotency_key =
            SpawnIdempotencyKey::new("stale-profile-cache-miss").unwrap();
        let failure = shared.spawn_from_spec(stale_cache_miss).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnProfileRevisionMismatch);

        let mut conflicting = spec;
        conflicting.deadline_ms = crate::protocol::SpawnDeadlineMs::new(31_000).unwrap();
        let failure = shared.spawn_from_spec(conflicting).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::SpawnIdempotencyConflict);
        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 1);
        assert!(shared.handle.snapshot().sessions.is_empty());
    }

    #[tokio::test]
    async fn off_worktree_service_rejects_selection_and_mutation_before_git() {
        let shared = terminal_test_shared_with_mode(WorktreeServiceMode::Off);
        let mut spec = spawn_spec_fixture();
        spec.target.worktree_id = Some(WorkspaceId::new("unregistered-worktree").unwrap());
        let failure = shared.spawn_from_spec(spec).await.unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::UnsupportedSpawnCapability);

        let failure = shared
            .create_worktree(
                WorkspaceId::new("primary").unwrap(),
                WorkspaceId::new("new-worktree").unwrap(),
                "not-an-absolute-path".to_owned(),
                "invalid branch".to_owned(),
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::UnsupportedSpawnCapability);

        let failure = shared
            .remove_worktree(
                WorkspaceId::new("primary").unwrap(),
                "not-an-absolute-path".to_owned(),
            )
            .await
            .unwrap_err();
        assert_eq!(failure.code, NodeFailureCode::UnsupportedSpawnCapability);
        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 1);
        assert!(shared.handle.snapshot().sessions.is_empty());
    }

    #[tokio::test]
    async fn manual_worktree_registration_failure_removes_the_created_worktree() {
        let root = temporary_workspace_root("manual-worktree-compensation");
        let source = root.join("source");
        let target = root.join("target");
        let invalid_state_parent = root.join("state-parent-is-a-file");
        let invalid_state_path = invalid_state_parent.join("state.json");
        std::fs::create_dir_all(&source).unwrap();
        std::fs::write(&invalid_state_parent, "not a directory").unwrap();
        run_test_git(&source, &["init"]);
        run_test_git(&source, &["config", "user.email", "gate4agent@example.invalid"]);
        run_test_git(&source, &["config", "user.name", "Gate4Agent Test"]);
        std::fs::write(source.join("seed.txt"), "seed\n").unwrap();
        run_test_git(&source, &["add", "seed.txt"]);
        run_test_git(&source, &["commit", "-m", "seed"]);

        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            &source,
        ).unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-worktree-compensation").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        shared.state_path = Some(invalid_state_path);

        let error = shared.create_worktree(
            WorkspaceId::new("primary").unwrap(),
            WorkspaceId::new("compensated").unwrap(),
            target.to_string_lossy().into_owned(),
            "gate4agent/compensated".to_owned(),
            Some("HEAD".to_owned()),
        ).await.unwrap_err();

        assert_eq!(error.code, NodeFailureCode::BackendOperationFailed);
        assert!(!target.exists());
        assert!(list_git_worktrees(source.to_str().unwrap()).await.unwrap()
            .iter()
            .all(|worktree| !worktree_paths_equal(&worktree.path, &target.to_string_lossy())));
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn selected_worktree_requires_authoritative_non_main_non_bare_entry() {
        fn worktree(path: &str, is_main: bool, is_bare: bool) -> NativeGitWorktreeSnapshot {
            NativeGitWorktreeSnapshot {
                path: path.to_owned(),
                head: "0123456789abcdef".to_owned(),
                branch: Some("refs/heads/test".to_owned()),
                is_bare,
                is_main,
                locked: false,
                lock_reason: None,
                prunable: false,
                prunable_reason: None,
                workspace_id: None,
            }
        }

        let source = r"C:\repo";
        let selected = r"C:\repo-worktree";
        let listed = vec![
            worktree(source, true, false),
            worktree(selected, false, false),
        ];
        assert!(validate_selected_worktree(source, selected, &listed).is_ok());

        let main_failure = validate_selected_worktree(source, source, &listed).unwrap_err();
        assert_eq!(main_failure.code, NodeFailureCode::WorktreeProtected);

        let bare = vec![
            worktree(source, true, false),
            worktree(selected, false, true),
        ];
        let bare_failure = validate_selected_worktree(source, selected, &bare).unwrap_err();
        assert_eq!(bare_failure.code, NodeFailureCode::WorktreeProtected);

        let foreign_failure =
            validate_selected_worktree(source, r"C:\foreign", &listed).unwrap_err();
        assert_eq!(foreign_failure.code, NodeFailureCode::WorktreeProtected);
    }

    fn terminal_frame(sequence: u64) -> TerminalFrame {
        TerminalFrame {
            sequence,
            size: gate4agent_types::TerminalSize {
                rows: 24,
                columns: 80,
            },
            cursor_row: 2,
            cursor_column: 3,
            contents: format!("frame-{sequence}"),
            formatted: vec![1, 2, 3],
            scrollback_formatted: Vec::new(),
            alternate_screen: false,
            mouse_protocol_enabled: false,
            mouse_protocol_encoding: Default::default(),
            produced_at_unix_ms: 0,
            screen_state: gate4agent_types::PtyScreenState::default(),
            bracketed_paste: None,
        }
    }

    #[test]
    fn terminal_frame_watermark_coalesces_and_resets_for_exact_session_address() {
        let shared = terminal_test_shared();
        let mut receiver = shared.terminal_event_tx.subscribe();
        let original = terminal_address(1);

        shared.publish_terminal_frame_candidates(vec![(original.clone(), terminal_frame(7))]);
        let first = receiver.try_recv().unwrap();
        assert_eq!(first.len(), 1);
        assert!(matches!(
            &first[0].event,
            NodeEvent::TerminalFrame { address, frame }
                if address == &original && frame.sequence == 7
        ));

        shared.publish_terminal_frame_candidates(vec![(original.clone(), terminal_frame(7))]);
        shared.publish_terminal_frame_candidates(vec![(original.clone(), terminal_frame(6))]);
        assert!(matches!(
            receiver.try_recv(),
            Err(broadcast::error::TryRecvError::Empty)
        ));

        shared.publish_terminal_frame_candidates(vec![(original.clone(), terminal_frame(8))]);
        let advanced = receiver.try_recv().unwrap();
        assert_eq!(advanced[0].sequence, 2);

        let resumed = terminal_address(2);
        shared.publish_terminal_frame_candidates(vec![(resumed.clone(), terminal_frame(1))]);
        let reset = receiver.try_recv().unwrap();
        assert_eq!(reset[0].sequence, 3);
        assert!(matches!(
            &reset[0].event,
            NodeEvent::TerminalFrame { address, frame }
                if address == &resumed && frame.sequence == 1
        ));
        shared.clear_terminal_frame_watermark(&resumed);
        assert!(!shared
            .terminal_frame_watermarks
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .contains_key(&resumed.session.instance_id));
    }

    #[test]
    fn terminal_frame_batches_replace_without_entering_node_event_history() {
        let shared = terminal_test_shared();
        let mut receiver = shared.terminal_event_tx.subscribe();
        let address = terminal_address(1);
        let count = NODE_EVENT_HISTORY_MAX as u64 + 17;

        for sequence in 1..=count {
            shared.publish_terminal_frame_candidates(vec![(
                address.clone(),
                terminal_frame(sequence),
            )]);
        }

        let history = shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        assert!(history.events.is_empty());
        assert_eq!(history.last_sequence, count);
        assert_eq!(history.replay_floor_sequence, 1);
        drop(history);
        let NodeResponse::Resync {
            event_sequence,
            oldest_available_sequence,
            events,
            ..
        } = shared.resync(0) else {
            unreachable!("resync helper returned another response")
        };
        assert_eq!(event_sequence, count);
        assert_eq!(oldest_available_sequence, 1);
        assert!(events.is_empty());
        assert!(matches!(
            resync_required_event(&shared).event,
            NodeEvent::ResyncRequired {
                oldest_available_sequence: 1,
            }
        ));
        assert!(matches!(
            receiver.try_recv(),
            Err(broadcast::error::TryRecvError::Lagged(skipped)) if skipped == count - 1
        ));
        let latest = receiver.try_recv().unwrap();
        assert_eq!(latest.len(), 1);
        assert_eq!(latest[0].sequence, count);
    }

    #[test]
    fn real_durable_eviction_advances_authoritative_replay_floor() {
        let shared = terminal_test_shared();
        for _ in 0..=NODE_EVENT_HISTORY_MAX {
            shared.publish(NodeEvent::ControllerChanged { controller: None });
        }

        let NodeResponse::Resync {
            event_sequence,
            oldest_available_sequence,
            events,
            ..
        } = shared.resync(0) else {
            unreachable!("resync helper returned another response")
        };
        assert_eq!(event_sequence, NODE_EVENT_HISTORY_MAX as u64 + 1);
        assert_eq!(oldest_available_sequence, 2);
        assert_eq!(events.first().map(|event| event.sequence), Some(2));
        assert_eq!(events.len(), NODE_EVENT_HISTORY_MAX);
        assert!(matches!(
            resync_required_event(&shared).event,
            NodeEvent::ResyncRequired {
                oldest_available_sequence: 2,
            }
        ));
    }

    #[test]
    fn legacy_terminal_frame_connection_has_no_live_subscription() {
        let shared = terminal_test_shared();
        let without_capability = terminal_event_subscription(&shared, false);
        let with_capability = terminal_event_subscription(&shared, true);
        assert!(without_capability.is_none());
        assert!(with_capability.is_some());
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_TERMINAL_FRAME_EVENTS_CAPABILITY
        }));
    }

    #[test]
    fn continuous_terminal_output_leaves_request_service_after_bounded_event_burst() {
        let mut pending = Vec::new();
        let mut event_sequence = 0_u64;
        for frame_sequence in 1..=4 {
            for instance in 1..=(NODE_CONNECTION_EVENT_BURST_MAX as u64 * 2) {
                event_sequence += 1;
                let mut address = terminal_address(1);
                address.session.instance_id = AgentInstanceId(instance);
                queue_connection_event(
                    &mut pending,
                    NodeEventEnvelope {
                        sequence: event_sequence,
                        event: NodeEvent::TerminalFrame {
                            address,
                            frame: terminal_frame(frame_sequence),
                        },
                    },
                    0,
                );
            }
        }
        assert_eq!(pending.len(), NODE_CONNECTION_EVENT_BURST_MAX * 2);
        pending.sort_unstable_by_key(|event| event.sequence);

        let mut uninterrupted = pending.clone();
        let first_burst = connection_event_burst_len(uninterrupted.len());
        uninterrupted.drain(..first_burst);
        let second_burst = connection_event_burst_len(uninterrupted.len());
        uninterrupted.drain(..second_burst);
        assert!(uninterrupted.is_empty());

        let (frame_tx, mut frame_rx) =
            mpsc::channel::<Result<ClientFrame, FrameError>>(1);
        frame_tx
            .try_send(Ok(ClientFrame::Request(RequestEnvelope {
                request_id: 77,
                request: NodeRequest::Snapshot,
            })))
            .unwrap();
        let burst_len = connection_event_burst_len(pending.len());
        assert_eq!(burst_len, NODE_CONNECTION_EVENT_BURST_MAX);
        pending.drain(..burst_len);
        assert_eq!(pending.len(), NODE_CONNECTION_EVENT_BURST_MAX);
        assert!(matches!(
            frame_rx.try_recv(),
            Ok(Ok(ClientFrame::Request(RequestEnvelope {
                request_id: 77,
                request: NodeRequest::Snapshot,
            })))
        ));
    }

    #[test]
    fn terminal_lag_watermark_discards_retained_and_replayed_batches() {
        let mut pending = Vec::new();
        for sequence in [7_u64, 8] {
            let mut address = terminal_address(1);
            address.session.instance_id = AgentInstanceId(sequence);
            queue_connection_event(
                &mut pending,
                NodeEventEnvelope {
                    sequence,
                    event: NodeEvent::TerminalFrame {
                        address,
                        frame: terminal_frame(sequence),
                    },
                },
                0,
            );
        }
        let mut discard_through = 0;
        apply_connection_resync_watermark(&mut pending, &mut discard_through, 8);
        assert!(pending.is_empty());

        let replayed = NodeEventEnvelope {
            sequence: 8,
            event: NodeEvent::TerminalFrame {
                address: terminal_address(1),
                frame: terminal_frame(8),
            },
        };
        let advanced = NodeEventEnvelope {
            sequence: 9,
            event: NodeEvent::TerminalFrame {
                address: terminal_address(2),
                frame: terminal_frame(1),
            },
        };
        queue_connection_event_batch(
            &mut pending,
            &[replayed, advanced.clone()],
            discard_through,
        );
        assert_eq!(pending, vec![advanced]);
    }

    fn record(provider: &str, record_id: &str) -> ManagedSessionRecord {
        ManagedSessionRecord {
            record_id: SessionRecordId::new(record_id).unwrap(),
            display_name: format!("{provider} record"),
            provider: agent(provider),
            mode: SessionMode::Pty,
            state: ManagedSessionState::Unavailable,
            workspace_id: WorkspaceId::new("primary").unwrap(),
            canonical_root: opaque_windows_path(
                std::env::current_dir().unwrap().to_string_lossy().into_owned(),
            ),
            provider_session: None,
            active_session: None,
            environment_profile: None,
            bundle: None,
            context_id: None,
            context: None,
            exported_context: None,
            task_binding: None,
            created_at_unix_ms: 1,
            updated_at_unix_ms: 1,
            last_error: None,
        }
    }

    fn retention_test_record(
        workspace_id: &str,
        record_id: &str,
        state: ManagedSessionState,
        updated_at_unix_ms: u64,
    ) -> ManagedSessionRecord {
        ManagedSessionRecord {
            record_id: SessionRecordId::new(record_id).unwrap(),
            display_name: format!("{record_id} display"),
            provider: agent("claude"),
            mode: SessionMode::Pty,
            state,
            workspace_id: WorkspaceId::new(workspace_id).unwrap(),
            canonical_root: opaque_windows_path(
                std::env::current_dir().unwrap().to_string_lossy().into_owned(),
            ),
            provider_session: None,
            active_session: None,
            environment_profile: None,
            bundle: None,
            context_id: None,
            context: None,
            exported_context: None,
            task_binding: None,
            created_at_unix_ms: updated_at_unix_ms,
            updated_at_unix_ms,
            last_error: None,
        }
    }

    /// Two workspaces of three `Unavailable` records each, staggered by
    /// age, plus one never-touchable decoy per non-`Unavailable` state in
    /// `workspace-a` (all as old as that workspace's oldest real record --
    /// if the sweep's state gate ever leaked, these would be the first
    /// thing it wrongly retired). Ages, oldest to newest:
    /// `workspace-a`: a1 (500s), a2 (300s), a3 (100s).
    /// `workspace-b`: b1 (400s), b2 (200s), b3 (50s).
    fn retention_fixture_records(now: u64) -> Vec<ManagedSessionRecord> {
        vec![
            retention_test_record("workspace-a", "a1", ManagedSessionState::Unavailable, now - 500_000),
            retention_test_record("workspace-a", "a2", ManagedSessionState::Unavailable, now - 300_000),
            retention_test_record("workspace-a", "a3", ManagedSessionState::Unavailable, now - 100_000),
            retention_test_record("workspace-b", "b1", ManagedSessionState::Unavailable, now - 400_000),
            retention_test_record("workspace-b", "b2", ManagedSessionState::Unavailable, now - 200_000),
            retention_test_record("workspace-b", "b3", ManagedSessionState::Unavailable, now - 50_000),
            retention_test_record("workspace-a", "decoy-live", ManagedSessionState::Live, now - 500_000),
            retention_test_record(
                "workspace-a",
                "decoy-pending",
                ManagedSessionState::IdentityPending,
                now - 500_000,
            ),
            retention_test_record(
                "workspace-a",
                "decoy-dormant",
                ManagedSessionState::Dormant,
                now - 500_000,
            ),
        ]
    }

    fn retention_fixture_shared() -> (NodeShared, NativeRuntime, PathBuf, u64) {
        let root = temporary_workspace_root("session-record-retention");
        std::fs::create_dir_all(&root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_a =
            WorkspaceConfig::new(WorkspaceId::new("workspace-a").unwrap(), &root).unwrap();
        let workspace_b =
            WorkspaceConfig::new(WorkspaceId::new("workspace-b").unwrap(), &root).unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-retention-test").unwrap(),
            vec![workspace_a, workspace_b],
            vec![agent("claude")],
        );
        shared.state_path = Some(root.join("node-state-v10.json"));
        let now = unix_time_ms();
        for record in retention_fixture_records(now) {
            shared.insert_record(record).unwrap();
        }
        shared
            .persist_state_locked()
            .expect("fixture-only, empty-history persist against a fresh temp state path");
        (shared, runtime, root, now)
    }

    fn retention_removed_record_ids(shared: &NodeShared) -> std::collections::BTreeSet<String> {
        shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .events
            .iter()
            .filter_map(|envelope| match &envelope.event {
                NodeEvent::SessionRecordRemoved { record_id } => {
                    Some(record_id.as_str().to_owned())
                }
                _ => None,
            })
            .collect()
    }

    fn retention_remaining_record_ids(shared: &NodeShared) -> std::collections::BTreeSet<String> {
        shared
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .keys()
            .map(|record_id| record_id.as_str().to_owned())
            .collect()
    }

    fn owned(values: &[&str]) -> std::collections::BTreeSet<String> {
        values.iter().map(|value| (*value).to_owned()).collect()
    }

    #[tokio::test]
    async fn session_record_retention_keep_n_only_keeps_the_newest_per_workspace() {
        let (mut shared, runtime, root, _now) = retention_fixture_shared();
        shared.session_record_retention = SessionRecordRetentionConfig {
            age_ms: 0,
            keep_per_workspace: 1,
        };
        shared.retire_unavailable_session_records().await;

        assert_eq!(
            retention_remaining_record_ids(&shared),
            owned(&["a3", "b3", "decoy-live", "decoy-pending", "decoy-dormant"]),
        );
        assert_eq!(
            retention_removed_record_ids(&shared),
            owned(&["a1", "a2", "b1", "b2"]),
        );
        assert_eq!(shared.retired_records_total.load(Ordering::Relaxed), 4);

        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    /// Age-only would retire {a1, a2, b1}; keep-N-only would retire
    /// {a1, a2, b1, b2}. With both flags set the sweep must retire exactly
    /// the intersection {a1, a2, b1} -- `b2` fails the age test (it is only
    /// 200s old against a 250s threshold) even though it fails the keep-N
    /// test too, proving retirement needs BOTH, not either.
    #[tokio::test]
    async fn session_record_retention_both_set_retires_only_the_intersection() {
        let (mut shared, runtime, root, _now) = retention_fixture_shared();
        shared.session_record_retention = SessionRecordRetentionConfig {
            age_ms: 250_000,
            keep_per_workspace: 1,
        };
        shared.retire_unavailable_session_records().await;

        assert_eq!(
            retention_remaining_record_ids(&shared),
            owned(&["a3", "b2", "b3", "decoy-live", "decoy-pending", "decoy-dormant"]),
        );
        assert_eq!(retention_removed_record_ids(&shared), owned(&["a1", "a2", "b1"]));
        assert_eq!(shared.retired_records_total.load(Ordering::Relaxed), 3);

        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn session_record_retention_both_disabled_is_a_no_op() {
        let (mut shared, runtime, root, _now) = retention_fixture_shared();
        shared.session_record_retention = SessionRecordRetentionConfig::default();
        shared.retire_unavailable_session_records().await;

        assert_eq!(
            retention_remaining_record_ids(&shared),
            owned(&[
                "a1", "a2", "a3", "b1", "b2", "b3",
                "decoy-live", "decoy-pending", "decoy-dormant",
            ]),
        );
        assert!(retention_removed_record_ids(&shared).is_empty());
        assert_eq!(shared.retired_records_total.load(Ordering::Relaxed), 0);

        drop(shared);
        drop(runtime);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn session_record_context_export_selects_one_exact_history_identity() {
        let candidates = vec![
            HistoryCandidateSummary {
                id: "candidate-other".to_owned(),
                session_id_hint: "provider-other".to_owned(),
                modified_at_unix_ms: Some(1),
            },
            HistoryCandidateSummary {
                id: "candidate-exact".to_owned(),
                session_id_hint: "provider-exact".to_owned(),
                modified_at_unix_ms: Some(2),
            },
        ];
        assert_eq!(
            select_history_candidate(&candidates, Some("provider-exact")).unwrap(),
            "candidate-exact",
        );
    }

    #[test]
    fn session_record_context_export_rejects_missing_and_ambiguous_history_identity() {
        let candidate = |id: &str, hint: &str| HistoryCandidateSummary {
            id: id.to_owned(),
            session_id_hint: hint.to_owned(),
            modified_at_unix_ms: None,
        };
        let missing = select_history_candidate(
            &[candidate("candidate-other", "provider-other")],
            Some("provider-exact"),
        )
        .unwrap_err();
        assert_eq!(missing.code, NodeFailureCode::SessionRecordConflict);
        let ambiguous = select_history_candidate(
            &[
                candidate("candidate-a", "provider-exact"),
                candidate("candidate-b", "provider-exact"),
            ],
            Some("provider-exact"),
        )
        .unwrap_err();
        assert_eq!(ambiguous.code, NodeFailureCode::SessionRecordConflict);
    }

    /// The PTY-sidecar-observation shape (no fleet provider today, but
    /// capability-keyed rather than vendor-locked) never carries a verified
    /// `provider_session`; its record-bound export instead falls back to
    /// "exactly one discovered candidate" (see
    /// `export_context_pack_for_session_record_inner`). This is the same
    /// ambiguity refusal as the identity-filtered path, just without an
    /// identity to filter by.
    #[test]
    fn session_record_context_export_selects_sole_history_candidate_without_identity() {
        let candidate = |id: &str, hint: &str| HistoryCandidateSummary {
            id: id.to_owned(),
            session_id_hint: hint.to_owned(),
            modified_at_unix_ms: None,
        };
        assert_eq!(
            select_history_candidate(&[candidate("candidate-sole", "sidecar-session")], None)
                .unwrap(),
            "candidate-sole",
        );
        let missing = select_history_candidate(&[], None).unwrap_err();
        assert_eq!(missing.code, NodeFailureCode::SessionRecordConflict);
        let ambiguous = select_history_candidate(
            &[
                candidate("candidate-a", "sidecar-session-a"),
                candidate("candidate-b", "sidecar-session-b"),
            ],
            None,
        )
        .unwrap_err();
        assert_eq!(ambiguous.code, NodeFailureCode::SessionRecordConflict);
    }

    #[test]
    fn session_record_context_export_revalidation_rejects_record_change() {
        let session = terminal_address(1);
        let identity = ProviderSessionIdentity {
            key: ProviderSessionKey::SessionId,
            id: "provider-exact".to_owned(),
            transcript_path: Some(r"C:\private\provider.jsonl".to_owned()),
        };
        let mut expected = record("claude", "record-context-export");
        expected.state = ManagedSessionState::Live;
        expected.provider_session = Some(identity.clone());
        expected.active_session = Some(session.clone());
        let binding = SessionBinding {
            workspace_id: session.workspace_id.clone(),
            generation: session.session.generation,
            runtime_policy: ProviderRuntimePolicy::raw_pty(),
            pending_resume: None,
            record_id: Some(expected.record_id.clone()),
            managed_worktree_lease_id: None,
            environment_profile: None,
            bundle: None,
            context: None,
            materialization_id: None,
        };
        let current_root = windows_path_text(&expected.canonical_root).to_owned();
        assert!(session_record_context_export_binding_is_exact(
            &expected,
            &expected,
            Some(&identity),
            &session,
            &binding,
            &expected.provider,
            &current_root,
            false,
        ));
        let mut changed = expected.clone();
        changed.updated_at_unix_ms += 1;
        assert!(!session_record_context_export_binding_is_exact(
            &expected,
            &changed,
            Some(&identity),
            &session,
            &binding,
            &expected.provider,
            &current_root,
            false,
        ));
        // A same-instant timestamp bump alone (state and active_session
        // otherwise unchanged) is not the clean-detachment transition
        // either, even with the reactive flag on: only the exact Live ->
        // Dormant + active_session cleared shape qualifies.
        assert!(!session_record_context_export_binding_is_exact(
            &expected,
            &changed,
            Some(&identity),
            &session,
            &binding,
            &expected.provider,
            &current_root,
            true,
        ));
        let mut detached = expected.clone();
        detached.state = ManagedSessionState::Dormant;
        detached.active_session = None;
        detached.updated_at_unix_ms += 1;
        assert!(!session_record_context_export_binding_is_exact(
            &expected,
            &detached,
            Some(&identity),
            &session,
            &binding,
            &expected.provider,
            &current_root,
            false,
        ));
        assert!(session_record_context_export_binding_is_exact(
            &expected,
            &detached,
            Some(&identity),
            &session,
            &binding,
            &expected.provider,
            &current_root,
            true,
        ));
    }

    /// Mirrors `session_record_context_export_revalidation_rejects_record_change`
    /// for a record whose provider never carries a verified identity (the
    /// PTY-sidecar-observation shape -- capability-keyed, no fleet provider
    /// declares one today): `identity` is `None` throughout, and the
    /// exactness check falls back to comparing `provider_session` itself,
    /// which must still be `None` on both sides.
    #[test]
    fn session_record_context_export_binding_is_exact_without_identity() {
        let session = terminal_address(1);
        let mut expected = record("pty-sidecar-fixture", "record-context-export-no-identity");
        expected.state = ManagedSessionState::Live;
        expected.active_session = Some(session.clone());
        let binding = SessionBinding {
            workspace_id: session.workspace_id.clone(),
            generation: session.session.generation,
            runtime_policy: ProviderRuntimePolicy::raw_pty(),
            pending_resume: None,
            record_id: Some(expected.record_id.clone()),
            managed_worktree_lease_id: None,
            environment_profile: None,
            bundle: None,
            context: None,
            materialization_id: None,
        };
        let current_root = windows_path_text(&expected.canonical_root).to_owned();
        assert!(session_record_context_export_binding_is_exact(
            &expected,
            &expected,
            None,
            &session,
            &binding,
            &expected.provider,
            &current_root,
            false,
        ));
        // A record that gained an identity between the initial lookup and
        // this recheck no longer matches the `None` this shape expects to
        // keep seeing -- treated the same as any other mid-export drift.
        let mut drifted = expected.clone();
        drifted.provider_session = Some(ProviderSessionIdentity {
            key: ProviderSessionKey::SessionId,
            id: "unexpected-identity".to_owned(),
            transcript_path: None,
        });
        assert!(!session_record_context_export_binding_is_exact(
            &expected,
            &drifted,
            None,
            &session,
            &binding,
            &expected.provider,
            &current_root,
            false,
        ));
    }

    #[test]
    fn session_record_context_export_preflight_requires_live_usable_source() {
        let mut source = record("claude", "record-context-export-preflight");
        source.state = ManagedSessionState::Live;
        assert!(session_record_context_export_source_is_usable(
            &source,
            &SessionStatus::Running,
            false,
        ));
        assert!(session_record_context_export_source_is_usable(
            &source,
            &SessionStatus::Exited { exit_code: Some(0) },
            false,
        ));

        source.state = ManagedSessionState::Dormant;
        assert!(!session_record_context_export_source_is_usable(
            &source,
            &SessionStatus::Running,
            false,
        ));
        // The reactive auto-export-at-exit path (allow_clean_detachment) is
        // the only caller that may treat a Dormant, cleanly-exited record as
        // still usable — the on-demand path above never does.
        assert!(session_record_context_export_source_is_usable(
            &source,
            &SessionStatus::Exited { exit_code: Some(0) },
            true,
        ));
        assert!(!session_record_context_export_source_is_usable(
            &source,
            &SessionStatus::Exited { exit_code: Some(0) },
            false,
        ));
        source.state = ManagedSessionState::Live;
        assert!(!session_record_context_export_source_is_usable(
            &source,
            &SessionStatus::Starting,
            false,
        ));
    }

    #[test]
    fn session_record_context_export_final_conflict_leaves_catalog_empty() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-context-export-conflict").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let history = HistorySessionRecord {
            session_id: "provider-exact".to_owned(),
            title: None,
            cwd: None,
            model: None,
            message_count: 1,
            completed_turn_count: None,
            total_tokens: 0,
            messages: vec![gate4agent_types::HistoryMessageRecord {
                role: gate4agent_types::HistoryMessageRole::User,
                text: "bounded context".to_owned(),
            }],
        };
        let pack = NodeContextPack::export(
            ContextPackLineageReceipt {
                source_node_id: shared.node_id.clone(),
                source_session: terminal_address(1),
                source_provider: agent("claude"),
            },
            &history,
        )
        .unwrap();
        let context_id = pack.receipt().id.clone();
        let session = terminal_address(1);
        let identity = ProviderSessionIdentity {
            key: ProviderSessionKey::SessionId,
            id: history.session_id.clone(),
            transcript_path: None,
        };
        let mut expected = record("claude", "record-context-export-final-conflict");
        expected.state = ManagedSessionState::Live;
        expected.provider_session = Some(identity.clone());
        expected.active_session = Some(session.clone());
        let mut changed = expected.clone();
        changed.updated_at_unix_ms += 1;
        shared.insert_record(changed).unwrap();

        let error = shared
            .commit_context_pack_for_session_record(
                &expected,
                Some(&identity),
                &session,
                "candidate-exact",
                &history,
                pack,
                false,
            )
            .unwrap_err();

        assert_eq!(error.code, NodeFailureCode::SessionRecordConflict);
        assert!(shared
            .context_catalog
            .read()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&context_id)
            .is_none());
    }

    #[tokio::test]
    async fn session_task_binding_mints_assigns_clears_with_cas_and_persists_v9() {
        let root = temporary_workspace_root("session-task-binding");
        std::fs::create_dir_all(&root).unwrap();
        let state_path = root.join("node-state.json");
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(WorkspaceId::new("primary").unwrap(), &root).unwrap();
        let node_id = NodeId::new("node-1").unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            node_id.clone(),
            vec![workspace],
            vec![agent("claude")],
        );
        shared.state_path = Some(state_path.clone());
        let record = record("claude", "sr-task");
        let record_id = record.record_id.clone();
        shared.insert_record(record).unwrap();
        shared.persist_state().unwrap();
        shared
            .acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS)
            .unwrap();

        let minted = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::SetSessionTask {
                record_id: record_id.clone(),
                expected_revision: 0,
                target: SessionTaskTargetV1::New,
            },
        )
        .await
        .unwrap();
        let NodeResponse::SessionRecordUpdated { record: minted } = minted else {
            panic!("session task mutation returned another response");
        };
        let minted_binding = minted.task_binding.clone().unwrap();
        let minted_task_id = minted_binding.task_id.clone().unwrap();
        assert_eq!(minted_binding.revision, 1);
        assert!(minted_task_id.as_str().starts_with("task-"));
        assert_eq!(minted_task_id.as_str().len(), 29);

        let event_count = shared.current_sequence();
        let repeated = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::SetSessionTask {
                record_id: record_id.clone(),
                expected_revision: 1,
                target: SessionTaskTargetV1::Existing {
                    task_id: minted_task_id.clone(),
                },
            },
        )
        .await
        .unwrap();
        assert_eq!(repeated, NodeResponse::SessionRecordUpdated { record: minted.clone() });
        assert_eq!(shared.current_sequence(), event_count);

        let stale = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::SetSessionTask {
                record_id: record_id.clone(),
                expected_revision: 0,
                target: SessionTaskTargetV1::Existing {
                    task_id: minted_task_id,
                },
            },
        )
        .await
        .unwrap_err();
        assert_eq!(stale.code, NodeFailureCode::SessionRecordConflict);

        let assigned_id: TaskId = "task-ffeeddccbbaa998877665544".parse().unwrap();
        let assigned = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::SetSessionTask {
                record_id: record_id.clone(),
                expected_revision: 1,
                target: SessionTaskTargetV1::Existing {
                    task_id: assigned_id.clone(),
                },
            },
        )
        .await
        .unwrap();
        let NodeResponse::SessionRecordUpdated { record: assigned } = assigned else {
            panic!("session task assignment returned another response");
        };
        assert_eq!(assigned.task_binding.as_ref().unwrap().revision, 2);
        assert_eq!(assigned.task_binding.as_ref().unwrap().task_id.as_ref(), Some(&assigned_id));

        let cleared = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::SetSessionTask {
                record_id: record_id.clone(),
                expected_revision: 2,
                target: SessionTaskTargetV1::Clear,
            },
        )
        .await
        .unwrap();
        let NodeResponse::SessionRecordUpdated { record: cleared } = cleared else {
            panic!("session task clear returned another response");
        };
        assert_eq!(cleared.task_binding.as_ref().unwrap().revision, 3);
        assert!(cleared.task_binding.as_ref().unwrap().task_id.is_none());
        assert!(cleared.task_binding.as_ref().unwrap().changed_at_unix_ms > 0);
        assert_eq!(
            cleared.task_binding.as_ref().unwrap().changed_at_unix_ms,
            cleared.updated_at_unix_ms,
        );

        let persisted = std::fs::read(&state_path).unwrap();
        assert_eq!(serde_json::from_slice::<serde_json::Value>(&persisted).unwrap()["version"], NODE_STATE_SCHEMA_V10);
        let loaded = session_registry::load(Some(&state_path), &node_id).unwrap();
        assert_eq!(loaded.records[0].task_binding, cleared.task_binding);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn session_task_capability_strips_snapshots_events_and_replies() {
        let mut bound = record("claude", "sr-task-projection");
        bound.updated_at_unix_ms = 2;
        bound.task_binding = Some(SessionTaskBindingV1 {
            revision: 1,
            task_id: Some("task-00112233445566778899aaff".parse().unwrap()),
            changed_at_unix_ms: 2,
        });
        let request = NodeRequest::SetSessionTask {
            record_id: bound.record_id.clone(),
            expected_revision: 1,
            target: SessionTaskTargetV1::Clear,
        };
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_SESSION_TASK_CORRELATION_CAPABILITY
        }));
        assert!(!request_uses_unnegotiated_capability(
            &request,
            &baseline_capabilities().unwrap(),
        ));
        assert!(request_uses_unnegotiated_capability(&request, &[]));

        let mut snapshot = terminal_test_shared().snapshot();
        snapshot.session_records.push(bound.clone());
        let mut reply = ResponseEnvelope {
            request_id: 1,
            result: Ok(NodeResponse::Resync {
                event_sequence: 1,
                oldest_available_sequence: 1,
                snapshot,
                events: vec![NodeEventEnvelope {
                    sequence: 1,
                    event: NodeEvent::SessionRecordUpserted {
                        record: bound.clone(),
                    },
                }],
            }),
        };
        project_response_without_session_task_binding(&mut reply);
        let Ok(NodeResponse::Resync { snapshot, events, .. }) = reply.result else {
            panic!("task projection changed the response kind");
        };
        assert!(snapshot.session_records[0].task_binding.is_none());
        let NodeEvent::SessionRecordUpserted { record } = &events[0].event else {
            panic!("task projection changed the event kind");
        };
        assert!(record.task_binding.is_none());

        let projected = project_event_without_session_task_binding(NodeEventEnvelope {
            sequence: 2,
            event: NodeEvent::SessionRecordUpserted { record: bound.clone() },
        });
        let NodeEvent::SessionRecordUpserted { record } = projected.event else {
            panic!("task event projection changed the event kind");
        };
        assert!(record.task_binding.is_none());

        let mut direct = ResponseEnvelope {
            request_id: 2,
            result: Ok(NodeResponse::SessionRecordUpdated { record: bound }),
        };
        project_response_without_session_task_binding(&mut direct);
        let Ok(NodeResponse::SessionRecordUpdated { record }) = direct.result else {
            panic!("task reply projection changed the response kind");
        };
        assert!(record.task_binding.is_none());
    }

    #[test]
    fn windows_runtime_default_node_endpoint_is_exact_and_valid() {
        assert_eq!(DEFAULT_NODE_ENDPOINT, r"\\.\pipe\gate4agent-node");
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let config = NodeServerConfig::new(
            DEFAULT_NODE_ENDPOINT,
            "fixture-token",
            NodeId::new("node-1").unwrap(),
            [workspace],
        )
        .unwrap();
        assert_eq!(config.endpoint, DEFAULT_NODE_ENDPOINT);
    }

    #[cfg(all(feature = "fixture", windows))]
    #[test]
    fn provider_bundle_argv_hold_fixture_is_parent_bounded_and_waits_after_proof() {
        let root = temporary_workspace_root("provider-bundle-argv-hold");
        let outside = temporary_workspace_root("provider-bundle-argv-hold-outside");
        std::fs::create_dir_all(&root).unwrap();
        std::fs::create_dir_all(&outside).unwrap();
        let proof_path = root.join("provider.proof");
        let release_signal = root.join("release.signal");
        let config = NodeServerConfig::new(
            format!(
                r"\\.\pipe\gate4agent-provider-bundle-hold-{}",
                std::process::id(),
            ),
            "fixture-token",
            NodeId::new("provider-bundle-hold-node").unwrap(),
            [WorkspaceConfig::new(
                WorkspaceId::new("primary").unwrap(),
                std::env::current_dir().unwrap(),
            )
            .unwrap()],
        )
        .unwrap()
        .with_spawn_profiles(SpawnProfileRegistry::new([
            crate::protocol::SpawnProfileDefaults {
                profile_id: crate::protocol::SpawnProfileId::new("kimi-bundle-hold").unwrap(),
                revision: crate::protocol::SpawnProfileRevision::new("kimi-bundle-hold-r1")
                    .unwrap(),
                provider: agent("kimi"),
                mode: SessionMode::Pty,
                terminal_size: gate4agent_types::TerminalSize {
                    rows: 24,
                    columns: 80,
                },
                prompt: None,
                bundle_id: None,
                context_id: None,
                environment_profile_id: None,
            },
        ])
        .unwrap());
        let server = NodeServer::new_provider_bundle_argv_hold_fixture(
            config,
            agent("kimi"),
            proof_path.clone(),
            release_signal.clone(),
        )
        .unwrap();
        assert_eq!(server.shared.enabled_providers, [agent("kimi")]);

        let spec = NodeServer::provider_bundle_argv_fixture_spec(
            agent("kimi"),
            proof_path.clone(),
            Some(release_signal.clone()),
        )
        .unwrap();
        let wrapper = &spec.launch.fixed_args[spec.launch.fixed_args.len() - 3];
        let proof_write = wrapper.find("WriteAllLines($proofPath").unwrap();
        let release_wait = wrapper
            .find("while (-not (Test-Path -LiteralPath $releaseSignal -PathType Leaf))")
            .unwrap();
        let fixture_ready = wrapper.find("fixture-ready>").unwrap();
        assert!(proof_write < release_wait);
        assert!(release_wait < fixture_ready);
        assert!(wrapper.contains("[DateTime]::UtcNow.AddSeconds(45)"));
        assert!(wrapper.contains("Start-Sleep -Milliseconds 20"));
        assert_eq!(
            &spec.launch.fixed_args[spec.launch.fixed_args.len() - 2..],
            &[
                proof_path.to_string_lossy().into_owned(),
                release_signal.to_string_lossy().into_owned(),
            ],
        );

        let error = NodeServer::provider_bundle_argv_fixture_spec(
            agent("kimi"),
            proof_path,
            Some(outside.join("release.signal")),
        )
        .unwrap_err();
        assert!(matches!(
            error,
            NodeServerError::Registry(message)
                if message == "provider bundle argv release path must share the proof parent"
        ));
        drop(server);
        std::fs::remove_dir_all(root).unwrap();
        std::fs::remove_dir_all(outside).unwrap();
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn four_provider_context_fixture_registry_is_unambiguous_and_history_bound() {
        let root = temporary_workspace_root("context-fixture-registry");
        std::fs::create_dir_all(&root).unwrap();
        let proof_path = root.join("context.proof");
        let config = NodeServerConfig::new(
            format!(
                r"\\.\pipe\gate4agent-context-fixture-registry-{}",
                std::process::id(),
            ),
            "fixture-token",
            NodeId::new("context-fixture-node").unwrap(),
            [WorkspaceConfig::new(
                WorkspaceId::new("primary").unwrap(),
                std::env::current_dir().unwrap(),
            )
            .unwrap()],
        )
        .unwrap();
        let server = NodeServer::new_context_pack_fixture(config, proof_path).unwrap();
        let mut enabled = server
            .shared
            .enabled_providers
            .iter()
            .map(AgentId::as_str)
            .collect::<Vec<_>>();
        enabled.sort_unstable();
        assert_eq!(enabled, ["claude", "codex", "grok", "kimi"]);
        for provider in &server.shared.enabled_providers {
            assert!(server
                .shared
                .provider_adapter_contracts
                .iter()
                .any(|contract| {
                    &contract.provider == provider
                        && contract.family == AdapterFamily::History
                }));
        }
        drop(server);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn monitoring_context_fixture_combines_claude_and_codex_hooks_with_history() {
        let root = temporary_workspace_root("monitoring-context-fixture");
        std::fs::create_dir_all(&root).unwrap();
        let proof_path = root.join("context.proof");
        let standard = NodeServer::context_pack_fixture_catalog(
            proof_path.clone(),
            None,
            false,
        ).unwrap();
        let monitoring = NodeServer::context_pack_fixture_catalog(
            proof_path.clone(),
            None,
            true,
        ).unwrap();
        let claude = AgentId::new("claude").unwrap();
        let standard_claude = standard.get(&claude).unwrap();
        let monitoring_claude = monitoring.get(&claude).unwrap();
        // Lifecycle hooks are retired (owner ruling 2026-09-25): neither the
        // standard nor the monitoring fixture declares a hook adapter
        // anymore.
        assert!(monitoring_claude.capabilities.adapters.hook.is_none());
        assert_eq!(
            monitoring_claude.capabilities.adapters.history,
            standard_claude.capabilities.adapters.history,
        );
        assert_ne!(monitoring_claude.launch, standard_claude.launch);
        let codex = AgentId::new("codex").unwrap();
        let standard_codex = standard.get(&codex).unwrap();
        let monitoring_codex = monitoring.get(&codex).unwrap();
        assert!(monitoring_codex.capabilities.adapters.hook.is_none());
        assert_eq!(
            monitoring_codex.capabilities.adapters.history,
            standard_codex.capabilities.adapters.history,
        );
        assert_ne!(monitoring_codex.launch, standard_codex.launch);
        let codex_validation = monitoring_codex.launch.fixed_args.iter()
            .find(|argument| argument.contains("F7_CODEX_BUNDLE_CONTEXT_VALIDATED"))
            .unwrap();
        for required in [
            "$allowedTopLevel = @('schema', 'source_provider', 'source_message_count', 'retained_messages', 'repository', 'truncated')",
            "$requiredTopLevel = @('schema', 'source_provider', 'source_message_count', 'retained_messages', 'truncated')",
            "@('role', 'text')",
            "g4a-private-provider-session-canary",
            "private-provider-login-identity",
            "$rawProof",
            "$env:GATE4AGENT_HOOK_URL",
            "g4a-private-provider-session-canary",
        ] {
            assert!(codex_validation.contains(required), "missing privacy validation: {required}");
        }
        for provider in ["grok", "kimi"] {
            let provider = AgentId::new(provider).unwrap();
            assert_eq!(monitoring.get(&provider), standard.get(&provider));
        }

        let config = NodeServerConfig::new(
            format!(
                r"\\.\pipe\gate4agent-monitoring-context-fixture-{}",
                std::process::id(),
            ),
            "fixture-token",
            NodeId::new("monitoring-context-fixture-node").unwrap(),
            [WorkspaceConfig::new(
                WorkspaceId::new("primary").unwrap(),
                std::env::current_dir().unwrap(),
            )
            .unwrap()],
        )
        .unwrap();
        let server = NodeServer::new_monitoring_context_pack_fixture(config, proof_path).unwrap();
        assert!(server.shared.fixture_semantic_hook_policy);
        drop(server);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn kimi_context_only_fixture_is_bounded_and_preserves_codex_validation() {
        let root = temporary_workspace_root("kimi-context-only-fixture");
        std::fs::create_dir_all(&root).unwrap();
        let proof_path = root.join("context.proof");
        let standard = NodeServer::context_pack_fixture_catalog(
            proof_path.clone(),
            None,
            false,
        ).unwrap();
        let kimi = AgentId::new("kimi").unwrap();
        let context_only = NodeServer::context_pack_fixture_catalog(
            proof_path,
            Some(&kimi),
            false,
        )
        .unwrap();

        let codex = AgentId::new("codex").unwrap();
        assert_eq!(
            standard.get(&codex).unwrap().launch.fixed_args,
            context_only.get(&codex).unwrap().launch.fixed_args,
        );
        let script = context_only
            .get(&kimi)
            .unwrap()
            .launch
            .fixed_args
            .iter()
            .find(|argument| argument.contains("F7_KIMI_CONTEXT_ONLY_VALIDATED"))
            .expect("Kimi context-only validation script is missing");
        for required in [
            "$bundleArgs.Count -ne 0",
            "GATE4AGENT_CONTEXT_ROOT",
            "context-pack.json",
            "$entries.Count -ne 1",
            "g4a-context-pack-v1",
            "$document.PSObject.Properties['cwd']",
            "'claude', 'codex', 'grok', 'kimi'",
            "$hasUser",
            "$hasAssistant",
            "SHA256",
            "context-only",
        ] {
            assert!(script.contains(required), "missing validation: {required}");
        }
        for forbidden in ["CODEX_HOME", "USERPROFILE", "auth", "token", "global config"] {
            assert!(!script.contains(forbidden), "forbidden home/auth access: {forbidden}");
        }
        assert!(!standard
            .get(&kimi)
            .unwrap()
            .launch
            .fixed_args
            .iter()
            .any(|argument| argument.contains("F7_KIMI_CONTEXT_ONLY_VALIDATED")));

        std::fs::remove_dir_all(root).unwrap();
    }

    #[cfg(all(feature = "fixture", windows))]
    #[tokio::test]
    async fn kimi_context_only_fixture_spawns_catalogued_context_pack_through_spawn_spec() {
        let root = temporary_workspace_root("kimi-context-only-spawn");
        let workspace_root = root.join("workspace");
        std::fs::create_dir_all(&workspace_root).unwrap();
        let materialization_root = root.join("private-materializations");
        let proof_path = root.join("context.proof");
        let node_id = NodeId::new("node-kimi-context-only-spawn").unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let profile_id = crate::protocol::SpawnProfileId::new("target-kimi").unwrap();
        let endpoint = format!(
            r"\\.\pipe\gate4agent-kimi-context-only-spawn-{}-{}",
            std::process::id(),
            unix_time_ms(),
        );
        let spawn_profiles = SpawnProfileRegistry::new([
            crate::protocol::SpawnProfileDefaults {
                profile_id: profile_id.clone(),
                revision: crate::protocol::SpawnProfileRevision::new("target-kimi-r1").unwrap(),
                provider: agent("kimi"),
                mode: SessionMode::Pty,
                terminal_size: gate4agent_types::TerminalSize {
                    rows: 30,
                    columns: 120,
                },
                prompt: None,
                bundle_id: None,
                context_id: None,
                environment_profile_id: None,
            },
        ])
        .unwrap();
        let mut config = NodeServerConfig::new(
            &endpoint,
            "fixture-token",
            node_id.clone(),
            [WorkspaceConfig::new(workspace_id.clone(), &workspace_root).unwrap()],
        )
        .unwrap()
        .with_spawn_profiles(spawn_profiles)
        .with_session_environment_materialization(
            materialization_root,
            Arc::new(FixtureSecretResolver {
                deny: Arc::new(AtomicBool::new(false)),
            }),
        )
        .unwrap();
        config.fixture_raw_pty_runtime = true;
        let server = NodeServer::new_context_only_proof_fixture(
            config,
            agent("kimi"),
            proof_path.clone(),
        )
        .unwrap();
        let shared = Arc::clone(&server.shared);
        let shutdown = server.shutdown_handle();

        let history = HistorySessionRecord {
            session_id: "context-only-source-history".to_owned(),
            title: None,
            cwd: None,
            model: None,
            message_count: 2,
            completed_turn_count: None,
            total_tokens: 0,
            messages: vec![
                gate4agent_types::HistoryMessageRecord {
                    role: gate4agent_types::HistoryMessageRole::User,
                    text: "continue the bounded parent run through native C2".to_owned(),
                },
                gate4agent_types::HistoryMessageRecord {
                    role: gate4agent_types::HistoryMessageRole::Assistant,
                    text: "the exact parent context is ready for the child run".to_owned(),
                },
            ],
        };
        let pack = NodeContextPack::export(
            ContextPackLineageReceipt {
                source_node_id: node_id.clone(),
                source_session: SessionAddress {
                    workspace_id: workspace_id.clone(),
                    session: SessionKey {
                        instance_id: AgentInstanceId(71),
                        generation: SessionGeneration(1),
                    },
                },
                source_provider: agent("codex"),
            },
            &history,
        )
        .unwrap();
        let expected_context_hash = digest(&SHA256, pack.bytes())
            .as_ref()
            .iter()
            .map(|byte| format!("{byte:02x}"))
            .collect::<String>();
        let context = shared
            .context_catalog
            .write()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .insert(pack)
            .unwrap();
        let spec = SpawnSpec {
            target: crate::protocol::SpawnTarget {
                node_id,
                workspace_id: workspace_id.clone(),
                worktree_id: None,
            },
            profile_id,
            expected_profile_revision: crate::protocol::SpawnProfileRevision::new(
                "target-kimi-r1",
            ).unwrap(),
            overrides: crate::protocol::SpawnOverrides {
                context_id: crate::protocol::SpawnOverride::Set {
                    value: context.id.clone(),
                },
                ..crate::protocol::SpawnOverrides::default()
            },
            deadline_ms: crate::protocol::SpawnDeadlineMs::new(10_000).unwrap(),
            idempotency_key: SpawnIdempotencyKey::new("kimi-context-only-spawn").unwrap(),
            required_capabilities: SpawnRequiredCapabilities::default(),
        };
        let resolved = match shared.resolve_spawn_spec(&spec) {
            Ok(resolved) => resolved,
            Err(error) => panic!(
                "Kimi context-only resolve rejected: exact_code={:?} message={}",
                error.code,
                error.message,
            ),
        };
        let resolved_context = match shared.resolve_context(&resolved) {
            Ok(Some(resolved_context)) => resolved_context,
            Ok(None) => panic!("Kimi context-only resolve omitted the exact ContextPack"),
            Err(error) => panic!(
                "Kimi context catalog resolve rejected: exact_code={:?} message={}",
                error.code,
                error.message,
            ),
        };
        assert_eq!(resolved_context, context);
        let runtime_policy = match shared
            .admit_provider_runtime(&agent("kimi"), ProviderRuntimeRequirement::RawPty)
            .await
        {
            Ok(runtime_policy) => runtime_policy,
            Err(error) => panic!(
                "Kimi RawPty admission rejected: exact_code={:?} message={}",
                error.code,
                error.message,
            ),
        };
        assert!(runtime_policy.raw_pty_lifecycle);

        let launch_control = shared.native_launch_profile_control.as_ref().unwrap();
        let generic_overlay = NativeLaunchEnvironmentOverlay::new(
            agent("kimi"),
            TransportKind::Pty,
            vec![EnvMutation {
                key: OsString::from("GATE4AGENT_UNPROFILED_GENERIC"),
                value: Some(OsString::from("must-remain-rejected")),
            }],
        )
        .unwrap();
        assert_eq!(
            launch_control
                .install_native_launch_environment_overlay(
                    AgentInstanceId(72),
                    generic_overlay,
                )
                .unwrap_err(),
            gate4agent_runtime_native::NativeLaunchProfileError::EnvironmentOverlaySelectionMissing,
        );

        let diagnostic_address = SessionAddress {
            workspace_id: workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(73),
                generation: SessionGeneration(1),
            },
        };
        let (diagnostic_overlay, diagnostic_materialization) = match shared
            .prepare_session_materialization(
                &diagnostic_address,
                &agent("kimi"),
                SessionMode::Pty,
                None,
                None,
                Some(&resolved_context),
                None,
            )
        {
            Ok(Some(prepared)) => prepared,
            Ok(None) => panic!("Kimi context-only materialization produced no launch overlay"),
            Err(error) => panic!(
                "Kimi context-only materialization rejected: exact_code={:?} message={}",
                error.code,
                error.message,
            ),
        };
        let diagnostic_overlay = diagnostic_overlay
            .expect("Kimi context-only materialization omitted its environment overlay");
        assert!(matches!(
            &diagnostic_overlay,
            PreparedNativeLaunchOverlay::Environment(_),
        ));
        match shared.install_prepared_launch_overlay(
            diagnostic_address.session.instance_id,
            diagnostic_overlay,
        ) {
            Ok(None) => {}
            Ok(Some(_)) => panic!("Kimi context-only overlay unexpectedly retained argv authority"),
            Err(error) => panic!(
                "Kimi context-only overlay installation rejected: exact_code={:?} message={}",
                error.code,
                error.message,
            ),
        }
        assert!(launch_control.clear_native_instance_launch_overlay(
            diagnostic_address.session.instance_id,
        ));
        drop(diagnostic_materialization);
        assert!(shared
            .materializations
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());

        let node_task = tokio::spawn(server.run());
        let ready_client = timeout(Duration::from_secs(5), async {
            loop {
                match gate4agent_node_wire::LocalNodeClient::connect(
                    &endpoint,
                    &shared.node_id,
                    ClientRole::Observer,
                    "fixture-token",
                )
                .await
                {
                    Ok(client) => break client,
                    Err(_) if !node_task.is_finished() => sleep(Duration::from_millis(10)).await,
                    Err(error) => panic!("Kimi context-only Node stopped before readiness: {error}"),
                }
            }
        })
        .await
        .expect("Kimi context-only Node did not become ready");
        assert_eq!(
            ready_client
                .hello()
                .snapshot
                .provider_runtime_statuses
                .iter()
                .find(|status| status.provider().as_str() == "kimi")
                .expect("Kimi runtime status is missing")
                .mode(),
            crate::protocol::ProviderRuntimeMode::RawPassthrough,
        );
        drop(ready_client);

        let receipt = match shared.spawn_from_spec(spec).await {
            Ok(receipt) => receipt,
            Err(error) => panic!(
                "Kimi context-only SpawnSpec rejected: exact_code={:?} message={}",
                error.code,
                error.message,
            ),
        };
        assert_eq!(receipt.provider, agent("kimi"));
        assert_eq!(receipt.context.as_ref(), Some(&context));
        assert!(receipt.context_binding_is_valid());
        timeout(Duration::from_secs(5), async {
            while !proof_path.is_file() {
                sleep(Duration::from_millis(10)).await;
            }
        })
        .await
        .expect("Kimi context-only fixture did not write its proof");

        let proof = std::fs::read_to_string(&proof_path).unwrap();
        let lines = proof.lines().collect::<Vec<_>>();
        assert_eq!(lines.len(), 7);
        assert_eq!(lines[0], "context-only");
        assert!(Path::new(lines[1]).is_absolute());
        assert_ne!(
            std::fs::canonicalize(Path::new(lines[1])).unwrap(),
            std::fs::canonicalize(&workspace_root).unwrap(),
        );
        assert_eq!(
            std::fs::canonicalize(Path::new(lines[2])).unwrap(),
            std::fs::canonicalize(&workspace_root).unwrap(),
        );
        assert_eq!(lines[3], expected_context_hash);
        assert_eq!(lines[4], "g4a-context-pack-v1");
        assert_eq!(lines[5], "codex");
        assert_eq!(lines[6], "2");
        assert!(shared.handle.snapshot().sessions.iter().any(|session| {
            session.instance_id == receipt.session.session.instance_id
                && session.agent_id.as_str() == "kimi"
        }));

        shutdown.request_shutdown().await.unwrap();
        timeout(Duration::from_secs(5), node_task)
            .await
            .unwrap()
            .unwrap()
            .unwrap();
        drop(shutdown);
        drop(shared);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[cfg(feature = "fixture")]
    #[test]
    fn clean_exit_fixture_constructor_is_fixture_scoped_and_path_bounded() {
        let root = temporary_workspace_root("clean-exit-constructor");
        std::fs::create_dir_all(&root).unwrap();
        let config = construction_test_config("clean-exit-constructor")
            .with_state_path(root.join("node-state.json"))
            .unwrap();
        let server = NodeServer::new_clean_exit_fixture(
            config,
            root.clone(),
            root.join("started.marker"),
            root.join("release.signal"),
        )
        .unwrap();
        assert_eq!(
            server
                .shared
                .enabled_providers
                .iter()
                .map(AgentId::as_str)
                .collect::<Vec<_>>(),
            ["claude"],
        );
        drop(server);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn production_registry_provider_contract_manifest_is_exact() {
        let registry = active_registry().unwrap();
        let (providers, adapters) = provider_contract_manifest(&registry).unwrap();
        assert_eq!(
            providers
                .iter()
                .map(|contract| (contract.provider.as_str(), contract.revision.as_str()))
                .collect::<Vec<_>>(),
            vec![
                ("claude", "orca:d8629c41c832436463d5f0b4e4deb95f867fdc42"),
                ("codex", "orca:d8629c41c832436463d5f0b4e4deb95f867fdc42"),
                ("grok", "orca:d8629c41c832436463d5f0b4e4deb95f867fdc42"),
                ("kimi", "orca:d8629c41c832436463d5f0b4e4deb95f867fdc42"),
            ]
        );
        assert_eq!(
            adapters
                .iter()
                .map(|contract| (
                    contract.provider.as_str(),
                    contract.family,
                    contract.adapter_id.as_str(),
                    contract.revision.as_str(),
                ))
                .collect::<Vec<_>>(),
            vec![
                ("claude", AdapterFamily::PtySemantic, "claude-code", "gate4agent-adapter/v1"),
                ("claude", AdapterFamily::Pipe, "claude-code", "gate4agent-adapter/v1"),
                ("claude", AdapterFamily::Acp, "claude-code", "gate4agent-adapter/v1"),
                ("claude", AdapterFamily::OneShot, "claude", "gate4agent-inline/claude-code-2.1/v1"),
                ("claude", AdapterFamily::History, "claude-code", "gate4agent-adapter/v1"),
                ("claude", AdapterFamily::Resume, "claude-code", "gate4agent-adapter/v1"),
                ("claude", AdapterFamily::SessionOptions, "claude-code", "gate4agent-session-options/orca-d8629c4/v1"),
                ("codex", AdapterFamily::PtySemantic, "codex", "gate4agent-adapter/v1"),
                ("codex", AdapterFamily::Pipe, "codex", "gate4agent-adapter/v1"),
                ("codex", AdapterFamily::Acp, "codex", "gate4agent-adapter/v1"),
                ("codex", AdapterFamily::OneShot, "codex", "gate4agent-inline/codex-cli-0.144/v1"),
                ("codex", AdapterFamily::History, "codex", "gate4agent-adapter/v1"),
                ("codex", AdapterFamily::Resume, "codex", "gate4agent-adapter/v1"),
                ("codex", AdapterFamily::SessionOptions, "codex", "gate4agent-session-options/orca-d8629c4/v1"),
                ("grok", AdapterFamily::Acp, "grok", "gate4agent-adapter/v1"),
                ("grok", AdapterFamily::History, "grok", "gate4agent-adapter/v1"),
                ("grok", AdapterFamily::Resume, "grok", "gate4agent-adapter/v1"),
                ("kimi", AdapterFamily::PtySemantic, "kimi", "gate4agent-adapter/v1"),
                ("kimi", AdapterFamily::Pipe, "kimi", "gate4agent-adapter/v1"),
                ("kimi", AdapterFamily::Acp, "kimi", "gate4agent-adapter/v1"),
                ("kimi", AdapterFamily::OneShot, "kimi", "gate4agent-inline/kimi-code-0.31/v1"),
                ("kimi", AdapterFamily::History, "kimi", "gate4agent-adapter/v1"),
                ("kimi", AdapterFamily::Resume, "kimi", "gate4agent-adapter/v1"),
            ]
        );
    }

    fn construction_test_config(name: &str) -> NodeServerConfig {
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        NodeServerConfig::new(
            format!(r"\\.\pipe\gate4agent-{name}"),
            "fixture-token",
            NodeId::new(name).unwrap(),
            [workspace],
        )
        .unwrap()
    }

    fn maximum_size_provider_manifest_registry() -> AgentRegistry {
        let adapter = AdapterBinding::new(
            gate4agent_types::AdapterId::new("a".repeat(96)).unwrap(),
            "r".repeat(crate::protocol::MAX_ADAPTER_CONTRACT_REVISION_BYTES),
            gate4agent_types::AdapterVerification::SyntheticFixture,
        )
        .unwrap();
        let agent_ids = ["claude", "codex", "kimi"]
            .into_iter()
            .map(|agent_id| AgentId::new(agent_id).unwrap())
            .collect::<Vec<_>>();
        let adapters = gate4agent_catalog::AdapterRegistry::new(
            [
                AdapterFamily::PtySemantic,
                AdapterFamily::Pipe,
                AdapterFamily::OneShot,
                AdapterFamily::Acp,
                AdapterFamily::Hook,
                AdapterFamily::ManagedHook,
                AdapterFamily::History,
                AdapterFamily::Resume,
                AdapterFamily::SessionOptions,
                AdapterFamily::CapabilityProbe,
            ]
            .into_iter()
            .map(|family| gate4agent_catalog::AdapterDescriptor {
                family,
                binding: adapter.clone(),
                agents: agent_ids.clone(),
            }),
        )
        .unwrap();
        let specs = agent_ids
            .iter()
            .map(|agent_id| {
                let agent_id = agent_id.as_str();
                let mut spec = builtin_registry().get_by_id(agent_id).unwrap().clone();
                spec.revision =
                    "r".repeat(crate::protocol::MAX_PROVIDER_CONTRACT_REVISION_BYTES);
                spec.capabilities.transports.pty_adapter = Some(adapter.clone());
                spec.capabilities.transports.pipe = Some(gate4agent_types::PipeTransportSpec {
                    adapter: adapter.clone(),
                    protocol: gate4agent_types::PipeProtocol::SemanticNdjson,
                    launch_override: None,
                    prompt_delivery: gate4agent_types::PipePromptDelivery::None,
                });
                spec.capabilities.transports.acp = Some(gate4agent_types::AcpTransportSpec {
                    adapter: adapter.clone(),
                    launch_override: None,
                });
                spec.capabilities.adapters.hook = Some(adapter.clone());
                spec.capabilities.adapters.managed_hook = Some(adapter.clone());
                spec.capabilities.adapters.one_shot = Some(adapter.clone());
                spec.capabilities.adapters.history = Some(adapter.clone());
                spec.capabilities.adapters.resume = Some(adapter.clone());
                spec.capabilities.adapters.session_options = Some(adapter.clone());
                spec.capabilities.adapters.capability_probe = Some(adapter.clone());
                spec
            })
            .collect::<Vec<_>>();
        AgentRegistry::new_with_adapters(specs, &adapters).unwrap()
    }

    /// The real fleet's manifest is accepted by a real server construction.
    ///
    /// The count is asserted against `active_registry` itself rather than a
    /// literal, so this stays a test that construction succeeds for whatever
    /// the fleet is -- which is the property worth guarding -- instead of a
    /// second place the fleet size is written down and has to be kept in
    /// step with the first.
    #[test]
    fn node_server_construction_accepts_the_production_manifest() {
        let registry = active_registry().unwrap();
        let (providers, _) = provider_contract_manifest(&registry).unwrap();
        assert_eq!(providers.len(), registry.iter().count());
        assert!(!providers.is_empty());
        let server = NodeServer::new_with_registry(
            construction_test_config("manifest-production-bound"),
            registry,
        )
        .unwrap();
        drop(server);
    }

    #[test]
    fn node_server_construction_rejects_count_valid_manifest_over_handshake_capacity() {
        let registry = maximum_size_provider_manifest_registry();
        let (providers, adapters) = provider_contract_manifest(&registry).unwrap();
        assert_eq!(providers.len(), 3);
        assert_eq!(adapters.len(), 30);
        assert!(adapters.len() <= crate::protocol::MAX_PROVIDER_ADAPTER_CONTRACTS);
        let error = match NodeServer::new_with_registry(
            construction_test_config("manifest-handshake-overflow"),
            registry,
        ) {
            Ok(_) => panic!("oversized negotiated manifest was accepted"),
            Err(error) => error,
        };
        assert!(matches!(
            error,
            NodeServerError::ProviderContractManifest(message)
                if message.contains("authentication binding length")
                    && message.contains("8192-byte limit")
        ));
    }

    #[test]
    fn provider_contract_manifest_rejects_wire_revision_overflow_before_startup() {
        let mut spec = builtin_registry().get_by_id("claude").unwrap().clone();
        spec.revision = "x".repeat(crate::protocol::MAX_PROVIDER_CONTRACT_REVISION_BYTES + 1);
        let registry = AgentRegistry::new([spec]).unwrap();
        assert!(matches!(
            provider_contract_manifest(&registry),
            Err(NodeServerError::ProviderContractManifest(message))
                if message.contains("exceeds the 128-byte limit")
        ));
    }

    #[test]
    fn provider_contract_manifest_rejects_invalid_wire_revision_before_startup() {
        let mut spec = builtin_registry().get_by_id("claude").unwrap().clone();
        spec.revision = "invalid revision".to_owned();
        let registry = AgentRegistry::new([spec]).unwrap();
        assert!(matches!(
            provider_contract_manifest(&registry),
            Err(NodeServerError::ProviderContractManifest(message))
                if message.contains("bounded lowercase ASCII")
        ));
    }

    #[test]
    fn provider_contract_manifest_rejects_conflicting_duplicate_family_before_startup() {
        let mut spec = builtin_registry().get_by_id("claude").unwrap().clone();
        let transport_binding = spec.capabilities.adapters.one_shot.clone().unwrap();
        let conflicting_binding = builtin_registry()
            .get_by_id("codex")
            .unwrap()
            .capabilities
            .adapters
            .one_shot
            .clone()
            .unwrap();
        let pipe = spec.capabilities.transports.pipe.as_mut().unwrap();
        pipe.protocol = gate4agent_types::PipeProtocol::OneShotText;
        pipe.adapter = transport_binding;
        spec.capabilities.adapters.one_shot = Some(conflicting_binding);
        let registry = AgentRegistry::new([spec]).unwrap();
        assert!(matches!(
            provider_contract_manifest(&registry),
            Err(NodeServerError::ProviderContractManifest(message))
                if message.contains("conflicting OneShot adapter bindings")
        ));
    }

    #[test]
    fn public_node_failures_expose_only_fixed_categories() {
        let provider = failure(
            NodeFailureCode::BackendOperationFailed,
            r"provider bearer-secret failed at C:\private\session.jsonl",
        );
        assert_eq!(provider.message, "backend-operation-failed");
        assert!(!provider.message.contains("bearer-secret"));
        assert!(!provider.message.contains(r"C:\private"));
        let persistence = persistence_failure(io::Error::new(
            io::ErrorKind::Other,
            r"state write failed at C:\private\state-v1.json",
        ));
        assert_eq!(persistence.message, DURABLE_STATE_COMMIT_FAILED_ERROR);
        assert!(!persistence.message.contains(r"C:\private"));

        for kind in [io::ErrorKind::PermissionDenied, io::ErrorKind::Unsupported] {
            let generic = durable_state_load_error(io::Error::new(kind, "host I/O failure"));
            assert_eq!(
                generic.to_string(),
                "node durable state failed: durable-state-load-failed",
            );
        }
    }

    #[test]
    fn terminal_byte_sequences_are_bounded_before_dispatch() {
        let sequence = b"\x1b[1;5D".to_vec();
        assert_eq!(
            terminal_bytes_action(sequence.clone()).unwrap(),
            InputAction::TerminalBytes(sequence),
        );
        assert_eq!(
            terminal_bytes_action(Vec::new()).unwrap_err().code,
            NodeFailureCode::InvalidRequest,
        );
        assert_eq!(
            terminal_bytes_action(vec![0; MAX_NODE_TERMINAL_BYTES + 1])
                .unwrap_err()
                .code,
            NodeFailureCode::InvalidRequest,
        );
    }

    #[test]
    fn node_server_rejects_a_second_owner_of_the_same_durable_state_path() {
        let root = temporary_workspace_root("exclusive-state-owner");
        std::fs::create_dir_all(&root).unwrap();
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            &root,
        )
        .unwrap();
        let state_path = root.join("state-v1.json");
        let endpoint = format!(
            r"\\.\pipe\gate4agent-node-state-lock-{}-{}",
            std::process::id(),
            std::time::SystemTime::now()
                .duration_since(std::time::UNIX_EPOCH)
                .unwrap()
                .as_nanos(),
        );
        let config = NodeServerConfig::new(
            endpoint,
            "fixture-token",
            NodeId::new("node-1").unwrap(),
            [workspace],
        )
        .unwrap()
        .with_state_path(&state_path)
        .unwrap();

        let first = NodeServer::new(config.clone()).unwrap();
        let error = match NodeServer::new(config.clone()) {
            Ok(_) => panic!("a second node server acquired the same durable state path"),
            Err(error) => error,
        };
        assert!(matches!(
            &error,
            NodeServerError::DurableState(error)
                if error.kind() == io::ErrorKind::WouldBlock
        ));
        assert_eq!(
            error.to_string(),
            "node durable state failed: durable-state-lock-failed",
        );
        assert!(!error.to_string().contains(&state_path.to_string_lossy().into_owned()));
        drop(first);
        let second = NodeServer::new(config).unwrap();
        drop(second);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[test]
    fn session_binding_is_workspace_scoped_and_removed_fail_closed() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(
            workspace_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace.clone()],
            vec![agent("claude"), agent("codex"), agent("kimi")],
        );
        let instance_id = AgentInstanceId(17);
        let generation = SessionGeneration(3);
        assert!(shared.address_for(instance_id, generation).is_none());
        shared.bind_session(instance_id, workspace_id.clone(), generation);
        let address = SessionAddress {
            workspace_id,
            session: SessionKey { instance_id, generation },
        };
        assert_eq!(
            shared.workspace_root(&address.workspace_id).unwrap(),
            workspace.canonical_root,
        );
        assert_eq!(shared.address_for(instance_id, generation), Some(address.clone()));
        shared.remove_binding(&address);
        assert!(shared.address_for(instance_id, generation).is_none());
    }

    #[test]
    fn open_provider_request_gate_is_state_aware_and_fail_closed() {
        let address = SessionAddress {
            workspace_id: WorkspaceId::new("primary").unwrap(),
            session: SessionKey {
                instance_id: AgentInstanceId(7),
                generation: SessionGeneration(2),
            },
        };
        let record_id = SessionRecordId::new("record-a").unwrap();
        let size = gate4agent_types::TerminalSize {
            rows: 24,
            columns: 80,
        };
        let address_requests = [
            NodeRequest::Resume {
                session: address.clone(),
                terminal_size: size,
                initial_prompt: None,
            },
            NodeRequest::Prompt { session: address.clone(), text: "p".to_owned() },
            NodeRequest::Paste { session: address.clone(), text: "p".to_owned() },
            NodeRequest::Input { session: address.clone(), text: "p".to_owned() },
            NodeRequest::TerminalBytes { session: address.clone(), bytes: vec![1] },
            NodeRequest::TerminalControl {
                session: address.clone(),
                control: TerminalControl::Enter,
            },
            NodeRequest::Resize { session: address.clone(), size },
            NodeRequest::Interrupt { session: address.clone() },
            NodeRequest::Stop { session: address.clone(), force: false },
            NodeRequest::Remove { session: address },
        ];
        for request in &address_requests {
            assert!(request_requires_open_provider_ids_with(
                request,
                |_| Some(agent("third-party-agent")),
                |_| Some(agent("claude")),
            ));
            assert!(!request_requires_open_provider_ids_with(
                request,
                |_| Some(agent("claude")),
                |_| Some(agent("claude")),
            ));
            assert!(request_requires_open_provider_ids_with(
                request,
                |_| None,
                |_| Some(agent("claude")),
            ));
        }

        let record_requests = [
            NodeRequest::RenameSessionRecord {
                record_id: record_id.clone(),
                display_name: "renamed".to_owned(),
            },
            NodeRequest::ResumeSessionRecord {
                record_id: record_id.clone(),
                terminal_size: size,
                initial_prompt: None,
            },
            NodeRequest::ForgetSessionRecord { record_id },
        ];
        for request in &record_requests {
            assert!(request_requires_open_provider_ids_with(
                request,
                |_| Some(agent("claude")),
                |_| Some(agent("grok")),
            ));
            assert!(!request_requires_open_provider_ids_with(
                request,
                |_| Some(agent("claude")),
                |_| Some(agent("kimi")),
            ));
            assert!(request_requires_open_provider_ids_with(
                request,
                |_| Some(agent("claude")),
                |_| None,
            ));
        }

        assert!(request_requires_open_provider_ids_with(
            &NodeRequest::Spawn {
                workspace_id: WorkspaceId::new("primary").unwrap(),
                provider: agent("third-party-agent"),
                mode: SessionMode::Pty,
                terminal_size: size,
                initial_prompt: None,
            },
            |_| None,
            |_| None,
        ));
        assert!(!request_requires_open_provider_ids_with(
            &NodeRequest::Snapshot,
            |_| None,
            |_| None,
        ));
        assert!(request_requires_open_provider_ids_with(
            &NodeRequest::ForgetContextPack {
                context_id: SpawnContextId::new("ctx-forget").unwrap(),
            },
            |_| None,
            |_| None,
        ));
    }

    #[test]
    fn legacy_projection_filters_open_record_replies_and_event_history() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude"), agent("grok")],
        );
        let legacy = record("claude", "legacy-record");
        let open = record("grok", "open-record");
        let legacy_upsert = shared.publish(NodeEvent::SessionRecordUpserted {
            record: legacy.clone(),
        });
        let open_upsert = shared.publish(NodeEvent::SessionRecordUpserted {
            record: open.clone(),
        });
        let legacy_removed = shared.publish(NodeEvent::SessionRecordRemoved {
            record_id: legacy.record_id.clone(),
        });
        let open_removed = shared.publish(NodeEvent::SessionRecordRemoved {
            record_id: open.record_id.clone(),
        });
        assert!(project_event_legacy_provider_ids(&shared, legacy_upsert.clone()).is_some());
        assert!(project_event_legacy_provider_ids(&shared, open_upsert.clone()).is_none());
        assert!(project_event_legacy_provider_ids(&shared, legacy_removed.clone()).is_some());
        assert!(project_event_legacy_provider_ids(&shared, open_removed.clone()).is_none());

        let mut record_reply = ResponseEnvelope {
            request_id: 1,
            result: Ok(NodeResponse::SessionRecordUpdated { record: open }),
        };
        project_response_legacy_provider_ids(&shared, &mut record_reply);
        assert!(matches!(
            record_reply.result,
            Err(NodeFailure { code: NodeFailureCode::UnsupportedCapability, .. })
        ));

        let mut resync = ResponseEnvelope {
            request_id: 2,
            result: Ok(NodeResponse::Resync {
                event_sequence: open_removed.sequence,
                oldest_available_sequence: 1,
                snapshot: shared.snapshot(),
                events: vec![legacy_upsert, open_upsert, legacy_removed, open_removed],
            }),
        };
        project_response_legacy_provider_ids(&shared, &mut resync);
        let Ok(NodeResponse::Resync { snapshot, events, .. }) = resync.result else {
            panic!("legacy projection changed the resync response kind");
        };
        assert!(snapshot.session_records.iter().all(|item| {
            provider_id_is_legacy(&item.provider)
        }));
        assert_eq!(events.len(), 2);
        assert!(events.iter().all(|event| matches!(
            &event.event,
            NodeEvent::SessionRecordUpserted { record }
                if provider_id_is_legacy(&record.provider)
        ) || matches!(&event.event, NodeEvent::SessionRecordRemoved { .. })));
    }

    #[test]
    fn session_binding_capacity_is_bounded_by_the_control_session_limit() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(
            workspace_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        for index in 0..CONTROL_SESSIONS_MAX {
            shared.bind_session(
                AgentInstanceId((index + 1) as u64),
                workspace_id.clone(),
                SessionGeneration(1),
            );
        }
        let error = shared.ensure_binding_capacity().unwrap_err();
        assert_eq!(error.code, NodeFailureCode::BackendBusy);
    }

    #[tokio::test]
    async fn provider_spawn_admission_rejects_before_session_mutation() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-provider-admission").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        shared.provider_runtime_statuses = ProviderRuntimeStatuses::new([
            crate::protocol::ProviderRuntimeStatus::unavailable(agent("claude")),
        ])
        .unwrap();
        let terminal_size = gate4agent_types::TerminalSize {
            rows: 24,
            columns: 80,
        };

        let unavailable = shared
            .spawn_session(
                WorkspaceId::new("primary").unwrap(),
                agent("claude"),
                SessionMode::Pty,
                terminal_size,
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(unavailable.code, NodeFailureCode::BackendOperationFailed);
        assert_eq!(unavailable.message, "backend-operation-failed");

        shared.provider_runtime_statuses = ProviderRuntimeStatuses::new([
            crate::protocol::ProviderRuntimeStatus::raw_passthrough(
                agent("claude"),
                Some(crate::protocol::ProviderRuntimeVersion::new("999.0.0").unwrap()),
            ),
        ])
        .unwrap();
        let semantic = shared
            .spawn_session(
                WorkspaceId::new("primary").unwrap(),
                agent("claude"),
                SessionMode::Inline,
                terminal_size,
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(semantic.code, NodeFailureCode::UnsupportedCapability);
        assert_eq!(semantic.message, "unsupported-capability");

        assert_eq!(shared.next_instance_id.load(Ordering::Acquire), 1);
        assert!(shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .is_empty());
        assert!(shared
            .session_records
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .records
            .is_empty());
        assert!(shared.handle.snapshot().sessions.is_empty());
    }

    #[tokio::test]
    async fn raw_spawn_binding_is_visible_with_a_durable_live_record() {
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(
            workspace_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-raw-spawn-record").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let address = SessionAddress {
            workspace_id,
            session: SessionKey {
                instance_id: AgentInstanceId(71),
                generation: SessionGeneration::default(),
            },
        };

        let record_id = shared
            .bind_spawn_session(
                &address,
                agent("claude"),
                SessionMode::Pty,
                ProviderRuntimePolicy::raw_pty(),
                SpawnRecordPolicy::Always,
                None,
            )
            .unwrap()
            .unwrap();
        shared
            .handle
            .dispatch(shared.prepare_command(ControlCommand::Register {
                instance_id: address.session.instance_id,
                agent_id: agent("claude"),
                transport: TransportKind::Pty,
            }))
            .unwrap();
        runtime.tick().await;

        assert!(shared.handle.snapshot().sessions.iter().any(|session| {
            session.instance_id == address.session.instance_id
                && session.generation == address.session.generation
        }));
        let record = shared.record(&record_id).unwrap();
        assert_eq!(record.display_name, "claude #1");
        assert_eq!(record.state, ManagedSessionState::Live);
        assert_eq!(record.active_session.as_ref(), Some(&address));
        assert!(record.provider_session.is_none());
        let binding_record_id = shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&address.session.instance_id)
            .and_then(|binding| binding.record_id.clone());
        assert_eq!(binding_record_id.as_ref(), Some(&record_id));

        let renamed = shared
            .rename_session_record(&record_id, "raw review".to_owned())
            .unwrap();
        assert_eq!(renamed.record_id, record_id);
        assert_eq!(renamed.display_name, "raw review");
        shared.reconcile_managed_record(
            &record_id,
            &address,
            &ControlEvent {
                sequence: 1,
                command_id: None,
                instance_id: address.session.instance_id,
                generation: address.session.generation,
                event: ControlEventKind::Running { process_id: None },
            },
            false,
            false,
        );
        let running = shared.record(&record_id).unwrap();
        assert_eq!(running.state, ManagedSessionState::Live);
        assert_eq!(running.active_session.as_ref(), Some(&address));
        assert_eq!(running.display_name, "raw review");

        shared.reconcile_managed_record(
            &record_id,
            &address,
            &ControlEvent {
                sequence: 2,
                command_id: None,
                instance_id: address.session.instance_id,
                generation: address.session.generation,
                event: ControlEventKind::Exited {
                    exit_code: Some(0),
                    forced: false,
                },
            },
            false,
            false,
        );
        let detached = shared.record(&record_id).unwrap();
        assert_eq!(detached.state, ManagedSessionState::Unavailable);
        assert!(detached.active_session.is_none());
        assert_eq!(detached.display_name, "raw review");
        let renamed_detached = shared
            .rename_session_record(&record_id, "raw review detached".to_owned())
            .unwrap();
        assert_eq!(renamed_detached.record_id, record_id);
        assert_eq!(renamed_detached.state, ManagedSessionState::Unavailable);
        assert!(renamed_detached.active_session.is_none());
        assert_eq!(renamed_detached.display_name, "raw review detached");
        assert_eq!(shared.snapshot().session_records, vec![renamed_detached]);
    }

    #[test]
    fn legacy_raw_spawn_binding_remains_untracked() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(
            workspace_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-legacy-raw-spawn").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let address = SessionAddress {
            workspace_id,
            session: SessionKey {
                instance_id: AgentInstanceId(72),
                generation: SessionGeneration::default(),
            },
        };

        let record_id = shared
            .bind_spawn_session(
                &address,
                agent("claude"),
                SessionMode::Pty,
                ProviderRuntimePolicy::raw_pty(),
                SpawnRecordPolicy::ProviderIdentityOnly,
                None,
            )
            .unwrap();

        assert!(record_id.is_none());
        let binding_record_id = shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&address.session.instance_id)
            .and_then(|binding| binding.record_id.clone());
        assert!(binding_record_id.is_none());
        assert!(shared.snapshot().session_records.is_empty());
    }

    #[tokio::test]
    async fn raw_runtime_policy_rejects_prompt_paste_and_resume_before_mutation() {
        let catalog = active_registry().unwrap();
        let (handle, mut runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(
            workspace_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-raw-semantic-gate").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        shared.provider_runtime_statuses = ProviderRuntimeStatuses::new([
            crate::protocol::ProviderRuntimeStatus::raw_passthrough(agent("claude"), None),
        ])
        .unwrap();
        shared
            .acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS)
            .unwrap();
        let address = SessionAddress {
            workspace_id,
            session: SessionKey {
                instance_id: AgentInstanceId(72),
                generation: SessionGeneration::default(),
            },
        };
        shared.bind_session_with_policy(
            &address,
            ProviderRuntimePolicy::raw_pty(),
            None,
        );
        shared
            .handle
            .dispatch(shared.prepare_command(ControlCommand::Register {
                instance_id: address.session.instance_id,
                agent_id: agent("claude"),
                transport: TransportKind::Pty,
            }))
            .unwrap();
        runtime.tick().await;
        let command_id_before = shared.next_command_id.load(Ordering::Acquire);
        let revision_before = shared.handle.snapshot().revision;
        let history_sequence_before = shared.current_sequence();
        let terminal_size = gate4agent_types::TerminalSize {
            rows: 24,
            columns: 80,
        };

        for request in [
            NodeRequest::Prompt {
                session: address.clone(),
                text: "prompt".to_owned(),
            },
            NodeRequest::Paste {
                session: address.clone(),
                text: "paste".to_owned(),
            },
            // `initial_prompt: Some(_)` selects `ResumeWithPrompt`, which needs
            // the same semantic capabilities as `Prompt`/`Paste`. A bare
            // (promptless) resume is a raw PTY relaunch and IS admitted under
            // `raw_pty()` — see `raw_pty_admits_provider_native_resume_without_prompt_only`
            // in `provider_runtime.rs`; it is deliberately not exercised here.
            NodeRequest::Resume {
                session: address.clone(),
                terminal_size,
                initial_prompt: Some("resume".to_owned()),
            },
        ] {
            let error = process_request_inner(
                &shared,
                77,
                ClientRole::Operator,
                request,
            )
            .await
            .unwrap_err();
            assert_eq!(error.code, NodeFailureCode::UnsupportedCapability);
        }

        assert_eq!(shared.next_command_id.load(Ordering::Acquire), command_id_before);
        assert_eq!(shared.handle.snapshot().revision, revision_before);
        assert_eq!(shared.current_sequence(), history_sequence_before);
        let bindings = shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let binding = bindings.get(&address.session.instance_id).unwrap();
        assert_eq!(binding.generation, address.session.generation);
        assert!(binding.pending_resume.is_none());
        assert!(binding.record_id.is_none());
    }

    #[tokio::test]
    async fn windows_rejects_unix_bytes_workspace_path_before_filesystem_access() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let primary = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![primary],
            vec![agent("claude")],
        );
        shared
            .acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS)
            .unwrap();
        let before = shared.snapshot();
        let error = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::RegisterWorkspace {
                workspace_id: WorkspaceId::new("foreign").unwrap(),
                root: OpaqueHostPath::unix_bytes(b"/srv/repo".to_vec()).unwrap(),
            },
        )
        .await
        .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::InvalidRequest);
        assert_eq!(error.message, "invalid-request");
        assert_eq!(shared.snapshot().workspaces, before.workspaces);
    }

    #[tokio::test]
    async fn dynamic_workspaces_reject_duplicates_busy_and_last_then_publish_ordered_events() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let primary_id = WorkspaceId::new("primary").unwrap();
        let primary = WorkspaceConfig::new(
            primary_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![primary.clone()],
            vec![agent("claude")],
        );
        let secondary_id = WorkspaceId::new("secondary").unwrap();
        let secondary = shared
            .register_workspace(
                secondary_id.clone(),
                std::env::temp_dir().to_string_lossy().into_owned(),
            )
            .await
            .unwrap();
        assert_eq!(secondary.workspace_id, secondary_id);
        assert!(secondary.sessions.is_empty());
        assert_eq!(shared.snapshot().workspaces.len(), 2);

        let duplicate_id = shared
            .register_workspace(
                secondary_id.clone(),
                primary.canonical_root().to_owned(),
            )
            .await
            .unwrap_err();
        assert_eq!(duplicate_id.code, NodeFailureCode::DuplicateWorkspaceId);
        let duplicate_root = shared
            .register_workspace(
                WorkspaceId::new("duplicate-root").unwrap(),
                windows_path_text(&secondary.canonical_root).to_owned(),
            )
            .await
            .unwrap_err();
        assert_eq!(duplicate_root.code, NodeFailureCode::DuplicateWorkspaceRoot);

        let address = SessionAddress {
            workspace_id: secondary_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(41),
                generation: SessionGeneration(1),
            },
        };
        shared.bind_session(
            address.session.instance_id,
            secondary_id.clone(),
            address.session.generation,
        );
        let busy = shared.unregister_workspace(&secondary_id).unwrap_err();
        assert_eq!(busy.code, NodeFailureCode::WorkspaceBusy);
        shared.remove_binding(&address);
        shared.unregister_workspace(&secondary_id).unwrap();
        assert_eq!(shared.snapshot().workspaces.len(), 1);

        let last = shared.unregister_workspace(&primary_id).unwrap_err();
        assert_eq!(last.code, NodeFailureCode::LastWorkspace);
        let history = shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        assert!(matches!(
            &history.events[0],
            NodeEventEnvelope {
                sequence: 1,
                event: NodeEvent::WorkspaceAdded { workspace },
            } if workspace.workspace_id == secondary_id
        ));
        assert!(matches!(
            &history.events[1],
            NodeEventEnvelope {
                sequence: 2,
                event: NodeEvent::WorkspaceRemoved { workspace_id },
            } if workspace_id == &secondary_id
        ));
    }

    #[tokio::test]
    async fn provider_session_reference_index_is_controller_gated_and_idempotent() {
        let secondary_root = temporary_workspace_root("provider-session-reference-index");
        std::fs::create_dir_all(&secondary_root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let primary_id = WorkspaceId::new("primary").unwrap();
        let secondary_id = WorkspaceId::new("secondary").unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-session-reference-index").unwrap(),
            vec![
                WorkspaceConfig::new(primary_id.clone(), std::env::current_dir().unwrap())
                    .unwrap(),
                WorkspaceConfig::new(secondary_id.clone(), &secondary_root).unwrap(),
            ],
            vec![agent("claude"), agent("codex")],
        );
        let identity = ProviderSessionIdentity {
            key: gate4agent_types::ProviderSessionKey::SessionId,
            id: "provider-session-42".to_owned(),
            transcript_path: None,
        };
        let index_request = |workspace_id: WorkspaceId,
                             provider: AgentId,
                             identity: ProviderSessionIdentity,
                             display_name: &str| {
            NodeRequest::IndexProviderSession {
                workspace_id,
                provider,
                identity,
                display_name: display_name.to_owned(),
            }
        };
        let request = index_request(
            primary_id.clone(),
            agent("claude"),
            identity.clone(),
            "release shepherd",
        );
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_PROVIDER_SESSION_REFERENCE_INDEX_CAPABILITY
        }));
        let observer = process_request_inner(
            &shared,
            77,
            ClientRole::Observer,
            request.clone(),
        )
        .await
        .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        let uncontrolled = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            request.clone(),
        )
        .await
        .unwrap_err();
        assert_eq!(uncontrolled.code, NodeFailureCode::ControllerRequired);
        shared
            .acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS)
            .unwrap();

        let indexed = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            request.clone(),
        )
        .await
        .unwrap();
        let NodeResponse::ProviderSessionIndexed { record } = indexed else {
            panic!("provider session reference index returned another response");
        };
        assert_eq!(record.state, ManagedSessionState::Dormant);
        assert_eq!(record.mode, SessionMode::Pty);
        assert_eq!(record.workspace_id, primary_id);
        assert_eq!(record.provider_session.as_ref(), Some(&identity));
        assert!(record.active_session.is_none());
        assert!(record.environment_profile.is_none());
        assert!(record.bundle.is_none());
        assert!(record.context.is_none());

        let repeated = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            index_request(
                primary_id.clone(),
                agent("claude"),
                identity.clone(),
                "ignored replacement",
            ),
        )
        .await
        .unwrap();
        assert!(matches!(
            repeated,
            NodeResponse::ProviderSessionIndexed { record: ref existing }
                if existing.record_id == record.record_id
                    && existing.display_name == "release shepherd"
        ));
        let conflicting_workspace = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            index_request(
                secondary_id,
                agent("claude"),
                identity.clone(),
                "release shepherd",
            ),
        )
        .await
        .unwrap_err();
        assert_eq!(conflicting_workspace.code, NodeFailureCode::SessionRecordConflict);
        let conflicting_provider = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            index_request(
                primary_id.clone(),
                agent("codex"),
                identity.clone(),
                "release shepherd",
            ),
        )
        .await
        .unwrap_err();
        assert_eq!(conflicting_provider.code, NodeFailureCode::SessionRecordConflict);
        let transcript_rejected = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            index_request(
                primary_id,
                agent("claude"),
                ProviderSessionIdentity {
                    transcript_path: Some("C:/provider/transcript.jsonl".to_owned()),
                    ..identity
                },
                "release shepherd",
            ),
        )
        .await
        .unwrap_err();
        assert_eq!(transcript_rejected.code, NodeFailureCode::InvalidRequest);
        let upserts = shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .events
            .iter()
            .filter(|event| matches!(
                &event.event,
                NodeEvent::SessionRecordUpserted { record: published }
                    if published.record_id == record.record_id
            ))
            .count();
        assert_eq!(upserts, 1);
        std::fs::remove_dir_all(secondary_root).unwrap();
    }

    #[tokio::test]
    async fn standalone_workspace_is_independent_registered_and_controller_gated() {
        let fixture_root = temporary_workspace_root("standalone-independent");
        let target = fixture_root.join("independent");
        std::fs::create_dir_all(&fixture_root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let selected = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let selected_root = selected.canonical_root().to_owned();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-standalone").unwrap(),
            vec![selected],
            vec![agent("claude")],
        );
        let workspace_id = WorkspaceId::new("independent").unwrap();
        let request = NodeRequest::CreateStandaloneWorkspace {
            workspace_id: workspace_id.clone(),
            root: opaque_windows_path(target.to_string_lossy().into_owned()),
            initial_branch: Some("main".to_owned()),
        };
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_STANDALONE_WORKSPACE_LIFECYCLE_CAPABILITY
        }));
        assert!(!request_uses_unnegotiated_capability(
            &request,
            &baseline_capabilities().unwrap(),
        ));
        assert!(request_uses_unnegotiated_capability(&request, &[]));

        let observer = process_request_inner(&shared, 77, ClientRole::Observer, request.clone())
            .await
            .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        assert!(!target.exists());
        let uncontrolled = process_request_inner(&shared, 77, ClientRole::Operator, request.clone())
            .await
            .unwrap_err();
        assert_eq!(uncontrolled.code, NodeFailureCode::ControllerRequired);
        assert!(!target.exists());
        shared
            .acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS)
            .unwrap();

        let response = process_request_inner(&shared, 77, ClientRole::Operator, request)
            .await
            .unwrap();
        let NodeResponse::StandaloneWorkspaceCreated { workspace } = response else {
            panic!("standalone workspace creation returned another response");
        };
        assert_eq!(workspace.workspace_id, workspace_id);
        assert!(target.join(".git").is_dir());
        let branch = run_git_bounded(
            target.to_str().unwrap(),
            &["branch", "--show-current"],
            GIT_OUTPUT_MAX_BYTES,
        )
        .await
        .unwrap();
        assert!(branch.success);
        assert_eq!(String::from_utf8(branch.stdout).unwrap().trim(), "main");
        let worktrees = list_git_worktrees(target.to_str().unwrap()).await.unwrap();
        assert_eq!(worktrees.len(), 1);
        let listed_root = WorkspaceConfig::new(
            WorkspaceId::new("listed-independent").unwrap(),
            &worktrees[0].path,
        )
        .unwrap();
        assert!(platform::roots_equal(
            listed_root.canonical_root(),
            windows_path_text(&workspace.canonical_root),
        ));
        assert!(!platform::roots_equal(listed_root.canonical_root(), &selected_root));
        assert!(shared.snapshot().workspaces.iter().any(|snapshot| {
            snapshot.workspace_id == workspace_id
                && snapshot.canonical_root == workspace.canonical_root
        }));
        assert!(shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .events
            .iter()
            .any(|event| matches!(
                &event.event,
                NodeEvent::WorkspaceAdded { workspace }
                    if workspace.workspace_id == workspace_id
            )));
        std::fs::remove_dir_all(fixture_root).unwrap();
    }

    #[tokio::test]
    async fn standalone_workspace_registration_failure_preserves_guarded_repository_for_recovery() {
        let fixture_root = temporary_workspace_root("standalone-compensation");
        let created_target = fixture_root.join("created-target");
        let existing_target = fixture_root.join("existing-target");
        let invalid_state_parent = fixture_root.join("state-parent-is-a-file");
        let invalid_state_path = invalid_state_parent.join("state.json");
        std::fs::create_dir_all(&existing_target).unwrap();
        std::fs::write(&invalid_state_parent, "not a directory").unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let primary = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-standalone-compensation").unwrap(),
            vec![primary],
            vec![agent("claude")],
        );
        shared.state_path = Some(invalid_state_path);

        let created_recovery = shared
            .create_standalone_workspace(
                WorkspaceId::new("compensated").unwrap(),
                created_target.to_string_lossy().into_owned(),
                Some("main".to_owned()),
            )
            .await
            .unwrap_err();
        assert_eq!(
            created_recovery.code,
            NodeFailureCode::StandaloneWorkspaceRecoveryRequired,
        );
        assert!(created_target.join(".git").is_dir());
        assert!(shared.snapshot().workspaces.iter().all(|workspace| {
            workspace.workspace_id.as_str() != "compensated"
        }));

        let existing_recovery = shared
            .create_standalone_workspace(
                WorkspaceId::new("restored").unwrap(),
                existing_target.to_string_lossy().into_owned(),
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(
            existing_recovery.code,
            NodeFailureCode::StandaloneWorkspaceRecoveryRequired,
        );
        assert!(existing_target.is_dir());
        assert!(existing_target.join(".git").is_dir());
        assert!(shared.snapshot().workspaces.iter().all(|workspace| {
            workspace.workspace_id.as_str() != "restored"
        }));

        let registered_empty = fixture_root.join("registered-empty");
        std::fs::create_dir(&registered_empty).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let registered = WorkspaceConfig::new(
            WorkspaceId::new("registered-empty").unwrap(),
            &registered_empty,
        )
        .unwrap();
        let duplicate_shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-standalone-duplicate-root").unwrap(),
            vec![registered],
            vec![agent("claude")],
        );
        let duplicate = duplicate_shared
            .create_standalone_workspace(
                WorkspaceId::new("duplicate-root").unwrap(),
                registered_empty.to_string_lossy().into_owned(),
                None,
            )
            .await
            .unwrap_err();
        assert_eq!(duplicate.code, NodeFailureCode::DuplicateWorkspaceRoot);
        assert!(std::fs::read_dir(&registered_empty).unwrap().next().is_none());
        std::fs::remove_dir_all(fixture_root).unwrap();
    }

    #[test]
    fn managed_record_id_collision_preserves_the_existing_record() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace.clone()],
            vec![agent("claude")],
        );
        let record_id = SessionRecordId::new("sr-collision").unwrap();
        let original = ManagedSessionRecord {
            record_id: record_id.clone(),
            display_name: "original".to_owned(),
            provider: agent("claude"),
            mode: SessionMode::Pty,
            state: ManagedSessionState::Dormant,
            workspace_id: workspace.workspace_id,
            canonical_root: opaque_windows_path(workspace.canonical_root),
            provider_session: None,
            active_session: None,
            environment_profile: None,
            bundle: None,
            context_id: None,
            context: None,
            exported_context: None,
            task_binding: None,
            created_at_unix_ms: 1,
            updated_at_unix_ms: 1,
            last_error: None,
        };
        shared.insert_record(original.clone()).unwrap();
        let mut collision = original.clone();
        collision.display_name = "replacement".to_owned();
        let error = shared.insert_record(collision).unwrap_err();
        assert_eq!(error.code, NodeFailureCode::SessionRecordConflict);
        assert_eq!(shared.record(&record_id).unwrap(), original);
    }

    #[test]
    fn managed_record_runtime_errors_are_exposed_only_as_allowlisted_categories() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace.clone()],
            vec![agent("claude")],
        );
        let record_id = SessionRecordId::new("sr-runtime-error").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: record_id.clone(),
                display_name: "runtime error".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::IdentityPending,
                workspace_id: workspace.workspace_id,
                canonical_root: opaque_windows_path(workspace.canonical_root),
                provider_session: None,
                active_session: None,
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 1,
                updated_at_unix_ms: 1,
                last_error: None,
            })
            .unwrap();

        shared
            .mark_record_error(
                &record_id,
                r"provider failed with bearer-secret-123 at C:\private\session.jsonl",
            )
            .unwrap();
        let record = shared.record(&record_id).unwrap();
        assert_eq!(record.state, ManagedSessionState::Unavailable);
        assert_eq!(
            record.last_error.as_deref(),
            Some("provider-runtime-failed"),
        );
        let snapshot = shared.snapshot();
        assert_eq!(snapshot.session_records, vec![record]);
    }

    /// Regression coverage for the "operator sees `deadline` instead of the
    /// kernel's own named rejection" defect: a spawn-dispatch waiter must be
    /// able to learn a command's asynchronous kernel rejection (here,
    /// specifically classified as `UnsupportedTransport`) exactly once, and
    /// must not still find it after that -- proving the fast path this
    /// mechanism exists for (`spawn_session_with_deadline`'s commit-wait
    /// loop) drains the reason instead of leaving it to be rediscovered (or
    /// missed) on a later poll.
    #[test]
    fn rejected_command_reason_is_classified_and_consumed_exactly_once() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );

        assert!(shared.take_rejected_command_reason(CommandId(1)).is_none());

        shared.record_rejected_command(
            CommandId(1),
            "agent 'claude' does not support transport Acp".to_owned(),
            true,
        );
        // An unrelated command_id must not see another command's reason.
        assert!(shared.take_rejected_command_reason(CommandId(2)).is_none());

        let reason = shared.take_rejected_command_reason(CommandId(1)).unwrap();
        assert_eq!(reason.message, "agent 'claude' does not support transport Acp");
        assert!(reason.unsupported_transport);

        // Consumed: a second read for the same command_id finds nothing.
        assert!(shared.take_rejected_command_reason(CommandId(1)).is_none());

        // A rejection unrelated to transport support keeps its own
        // classification distinct, so the reader can choose the generic
        // `BackendOperationFailed` code instead of misreporting
        // `UnsupportedTransport`.
        shared.record_rejected_command(
            CommandId(3),
            "backend busy".to_owned(),
            false,
        );
        let unclassified = shared.take_rejected_command_reason(CommandId(3)).unwrap();
        assert!(!unclassified.unsupported_transport);
    }

    #[test]
    fn provider_identity_update_is_ignored_without_exact_session_policy() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-identity-policy").unwrap(),
            vec![workspace.clone()],
            vec![agent("claude")],
        );
        let address = SessionAddress {
            workspace_id: workspace.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(90),
                generation: SessionGeneration(1),
            },
        };
        let record_id = SessionRecordId::new("sr-policy-denied").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: record_id.clone(),
                display_name: "policy denied".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::IdentityPending,
                workspace_id: workspace.workspace_id,
                canonical_root: opaque_windows_path(workspace.canonical_root),
                provider_session: None,
                active_session: Some(address.clone()),
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 1,
                updated_at_unix_ms: 1,
                last_error: None,
            })
            .unwrap();
        let event = ControlEvent {
            sequence: 1,
            command_id: None,
            instance_id: address.session.instance_id,
            generation: address.session.generation,
            event: ControlEventKind::ProviderEvent {
                sequence: 1,
                source: gate4agent_types::ProviderSource {
                    family: AdapterFamily::PtySemantic,
                    binding: AdapterBinding::new(
                        gate4agent_types::AdapterId::new("claude").unwrap(),
                        "fixture/v1",
                        gate4agent_types::AdapterVerification::SyntheticFixture,
                    )
                    .unwrap(),
                },
                source_sequence: 1,
                event: gate4agent_types::ProviderEvent::SessionIdentityObserved {
                    identity: gate4agent_types::ProviderSessionIdentity {
                        key: gate4agent_types::ProviderSessionKey::SessionId,
                        id: "provider-session".to_owned(),
                        transcript_path: None,
                    },
                },
            },
        };

        shared.reconcile_managed_record(&record_id, &address, &event, false, false);

        let record = shared.record(&record_id).unwrap();
        assert!(record.provider_session.is_none());
        assert_eq!(record.state, ManagedSessionState::IdentityPending);
        assert_eq!(record.active_session.as_ref(), Some(&address));
    }

    #[test]
    fn provider_identity_cannot_rebind_a_record_across_workspaces() {
        let secondary_root = temporary_workspace_root("identity-scope");
        std::fs::create_dir_all(&secondary_root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let primary = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let secondary = WorkspaceConfig::new(
            WorkspaceId::new("secondary").unwrap(),
            &secondary_root,
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![primary.clone(), secondary.clone()],
            vec![agent("claude")],
        );
        let identity = gate4agent_types::ProviderSessionIdentity {
            key: gate4agent_types::ProviderSessionKey::SessionId,
            id: "provider-session".to_owned(),
            transcript_path: None,
        };
        let dormant_id = SessionRecordId::new("sr-dormant").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: dormant_id.clone(),
                display_name: "dormant".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::Dormant,
                workspace_id: primary.workspace_id,
                canonical_root: opaque_windows_path(primary.canonical_root),
                provider_session: Some(identity.clone()),
                active_session: None,
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 1,
                updated_at_unix_ms: 1,
                last_error: None,
            })
            .unwrap();
        let address = SessionAddress {
            workspace_id: secondary.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(91),
                generation: SessionGeneration(1),
            },
        };
        let current_id = SessionRecordId::new("sr-current").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: current_id.clone(),
                display_name: "current".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::IdentityPending,
                workspace_id: secondary.workspace_id,
                canonical_root: opaque_windows_path(secondary.canonical_root),
                provider_session: None,
                active_session: Some(address.clone()),
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 2,
                updated_at_unix_ms: 2,
                last_error: None,
            })
            .unwrap();
        shared.bind_managed_session(
            &address,
            current_id.clone(),
            ProviderRuntimePolicy::new(true, true, true, true, true, false).unwrap(),
            None,
        );
        let event = ControlEvent {
            sequence: 1,
            command_id: None,
            instance_id: address.session.instance_id,
            generation: address.session.generation,
            event: ControlEventKind::ProviderEvent {
                sequence: 1,
                source: gate4agent_types::ProviderSource {
                    family: gate4agent_types::AdapterFamily::PtySemantic,
                    binding: gate4agent_types::AdapterBinding::new(
                        gate4agent_types::AdapterId::new("claude").unwrap(),
                        "fixture/v1",
                        gate4agent_types::AdapterVerification::SyntheticFixture,
                    )
                    .unwrap(),
                },
                source_sequence: 1,
                event: gate4agent_types::ProviderEvent::SessionIdentityObserved {
                    identity,
                },
            },
        };
        shared.reconcile_managed_record(&current_id, &address, &event, true, false);

        let binding = shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&address.session.instance_id)
            .cloned()
            .unwrap();
        assert_eq!(binding.record_id.as_ref(), Some(&current_id));
        assert_eq!(shared.record(&dormant_id).unwrap().state, ManagedSessionState::Dormant);
        let current = shared.record(&current_id).unwrap();
        assert_eq!(current.state, ManagedSessionState::Unavailable);
        assert_eq!(current.active_session.as_ref(), Some(&address));
        assert_eq!(
            current.last_error.as_deref(),
            Some(PROVIDER_SESSION_SCOPE_CONFLICT_ERROR),
        );
        std::fs::remove_dir_all(secondary_root).unwrap();
    }

    #[tokio::test]
    async fn semantic_identity_with_transcript_path_reuses_record_and_survives_reload() {
        let root = temporary_workspace_root("semantic-provider-session");
        std::fs::create_dir_all(&root).unwrap();
        let state_path = root.join("state-v1.json");
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            &root,
        )
        .unwrap();
        let node_id = NodeId::new("node-semantic-identity").unwrap();
        let shared = NodeShared::new_with_incarnation(
            handle,
            "fixture-token".to_owned(),
            node_id.clone(),
            NodeIncarnationId::from_bytes([0; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace.clone()],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            None,
            None,
            None,
            Some(state_path.clone()),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            Vec::new(),
            None,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        let persisted_identity = gate4agent_types::ProviderSessionIdentity {
            key: gate4agent_types::ProviderSessionKey::SessionId,
            id: "provider-session".to_owned(),
            transcript_path: None,
        };
        let durable_id = SessionRecordId::new("sr-durable").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: durable_id.clone(),
                display_name: "durable".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::Dormant,
                workspace_id: workspace.workspace_id.clone(),
                canonical_root: opaque_windows_path(workspace.canonical_root.clone()),
                provider_session: Some(persisted_identity.clone()),
                active_session: None,
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 1,
                updated_at_unix_ms: 1,
                last_error: None,
            })
            .unwrap();
        let address = SessionAddress {
            workspace_id: workspace.workspace_id.clone(),
            session: SessionKey {
                instance_id: AgentInstanceId(92),
                generation: SessionGeneration(2),
            },
        };
        let pending_id = SessionRecordId::new("sr-pending").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: pending_id.clone(),
                display_name: "pending".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::IdentityPending,
                workspace_id: workspace.workspace_id.clone(),
                canonical_root: opaque_windows_path(workspace.canonical_root.clone()),
                provider_session: None,
                active_session: Some(address.clone()),
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 2,
                updated_at_unix_ms: 2,
                last_error: None,
            })
            .unwrap();
        shared.bind_managed_session(
            &address,
            pending_id.clone(),
            ProviderRuntimePolicy::new(true, true, true, true, true, false).unwrap(),
            None,
        );
        let observed_identity = gate4agent_types::ProviderSessionIdentity {
            transcript_path: Some(r"C:\private\provider-transcript.jsonl".to_owned()),
            ..persisted_identity
        };
        let event = ControlEvent {
            sequence: 1,
            command_id: None,
            instance_id: address.session.instance_id,
            generation: address.session.generation,
            event: ControlEventKind::ProviderEvent {
                sequence: 1,
                source: gate4agent_types::ProviderSource {
                    family: gate4agent_types::AdapterFamily::PtySemantic,
                    binding: gate4agent_types::AdapterBinding::new(
                        gate4agent_types::AdapterId::new("claude").unwrap(),
                        "fixture/v1",
                        gate4agent_types::AdapterVerification::SyntheticFixture,
                    )
                    .unwrap(),
                },
                source_sequence: 1,
                event: gate4agent_types::ProviderEvent::SessionIdentityObserved {
                    identity: observed_identity.clone(),
                },
            },
        };
        shared.reconcile_managed_record(&pending_id, &address, &event, true, false);

        let snapshot = shared.snapshot();
        assert_eq!(snapshot.session_records.len(), 1);
        let live = &snapshot.session_records[0];
        assert_eq!(live.record_id, durable_id);
        assert_eq!(live.state, ManagedSessionState::Live);
        assert_eq!(live.active_session.as_ref(), Some(&address));
        assert_eq!(live.provider_session.as_ref(), Some(&observed_identity));
        let binding = shared
            .session_bindings
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner())
            .get(&address.session.instance_id)
            .cloned()
            .unwrap();
        assert_eq!(binding.record_id.as_ref(), Some(&durable_id));

        let mut duplicate = live.clone();
        duplicate.record_id = SessionRecordId::new("sr-duplicate").unwrap();
        duplicate.display_name = "duplicate".to_owned();
        duplicate.state = ManagedSessionState::Dormant;
        duplicate.active_session = None;
        duplicate.provider_session.as_mut().unwrap().transcript_path = None;
        let duplicate_error = shared.insert_record(duplicate).unwrap_err();
        assert_eq!(duplicate_error.code, NodeFailureCode::SessionRecordConflict);
        assert_eq!(shared.snapshot().session_records.len(), 1);

        let terminal_size = gate4agent_types::TerminalSize {
            rows: 24,
            columns: 80,
        };
        let (first_busy, second_busy) = tokio::join!(
            shared.resume_session_record(&durable_id, terminal_size, None),
            shared.resume_session_record(&durable_id, terminal_size, None),
        );
        for busy in [first_busy.unwrap_err(), second_busy.unwrap_err()] {
            assert_eq!(busy.code, NodeFailureCode::SessionRecordBusy);
            assert_eq!(busy.message, "session-record-busy");
        }

        let loaded = session_registry::load(Some(&state_path), &node_id).unwrap();
        assert_eq!(loaded.records.len(), 1);
        assert_eq!(loaded.records[0].record_id, durable_id);
        assert_eq!(loaded.records[0].state, ManagedSessionState::Dormant);
        assert_eq!(
            loaded.records[0]
                .provider_session
                .as_ref()
                .unwrap()
                .transcript_path,
            None,
        );
        let catalog = active_registry().unwrap();
        let (reloaded_handle, _reloaded_runtime) =
            NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let reloaded = NodeShared::new_with_incarnation(
            reloaded_handle,
            "fixture-token".to_owned(),
            node_id,
            NodeIncarnationId::from_bytes([1; crate::protocol::NODE_INCARNATION_ID_BYTES]),
            vec![workspace],
            vec![agent("claude")],
            ProviderRuntimeStatuses::default(),
            None,
            Vec::new(),
            Vec::new(),
            SpawnProfileRegistry::default(),
            None,
            None,
            None,
            None,
            loaded.records,
            loaded.managed_worktrees,
            loaded.managed_worktree_tombstones,
            loaded.materializations,
            loaded.warning,
            MUTATION_SETTLE_TIMEOUT_MS.saturating_add(READINESS_SETTLE_HEADROOM_MS),
        );
        assert_eq!(reloaded.snapshot().session_records.len(), 1);
        assert_eq!(reloaded.snapshot().session_records[0].record_id, durable_id);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn workspace_reregistration_requires_the_recorded_root_and_restores_records() {
        let secondary_root = temporary_workspace_root("workspace-restore");
        let other_root = temporary_workspace_root("workspace-conflict");
        std::fs::create_dir_all(&secondary_root).unwrap();
        std::fs::create_dir_all(&other_root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let primary = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let secondary = WorkspaceConfig::new(
            WorkspaceId::new("secondary").unwrap(),
            &secondary_root,
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![primary, secondary.clone()],
            vec![agent("claude")],
        );
        let record_id = SessionRecordId::new("sr-workspace").unwrap();
        shared
            .insert_record(ManagedSessionRecord {
                record_id: record_id.clone(),
                display_name: "workspace record".to_owned(),
                provider: agent("claude"),
                mode: SessionMode::Pty,
                state: ManagedSessionState::Dormant,
                workspace_id: secondary.workspace_id.clone(),
                canonical_root: opaque_windows_path(secondary.canonical_root.clone()),
                provider_session: Some(gate4agent_types::ProviderSessionIdentity {
                    key: gate4agent_types::ProviderSessionKey::SessionId,
                    id: "provider-session".to_owned(),
                    transcript_path: None,
                }),
                active_session: None,
                environment_profile: None,
                bundle: None,
                context_id: None,
                context: None,
                exported_context: None,
                task_binding: None,
                created_at_unix_ms: 1,
                updated_at_unix_ms: 1,
                last_error: None,
            })
            .unwrap();
        shared.unregister_workspace(&secondary.workspace_id).unwrap();
        let unavailable = shared.record(&record_id).unwrap();
        assert_eq!(unavailable.state, ManagedSessionState::Unavailable);
        assert_eq!(windows_path_text(&unavailable.canonical_root), secondary.canonical_root);

        let conflict = shared
            .register_workspace(
                secondary.workspace_id.clone(),
                other_root.to_string_lossy().into_owned(),
            )
            .await
            .unwrap_err();
        assert_eq!(conflict.code, NodeFailureCode::SessionRecordConflict);
        shared
            .register_workspace(
                secondary.workspace_id,
                secondary_root.to_string_lossy().into_owned(),
            )
            .await
            .unwrap();
        let restored = shared.record(&record_id).unwrap();
        assert_eq!(restored.state, ManagedSessionState::Dormant);
        assert!(restored.last_error.is_none());
        std::fs::remove_dir_all(secondary_root).unwrap();
        std::fs::remove_dir_all(other_root).unwrap();
    }

    #[test]
    fn dynamic_workspace_root_is_rejected_before_filesystem_canonicalization() {
        let error = validate_workspace_request_root(
            &"x".repeat(MAX_WORKSPACE_ROOT_BYTES + 1),
        )
        .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::InvalidWorkspaceRoot);
        let control = validate_workspace_request_root("C:\\repo\nchild").unwrap_err();
        assert_eq!(control.code, NodeFailureCode::InvalidWorkspaceRoot);
    }

    #[test]
    fn concurrent_publish_and_resync_never_acknowledge_an_unappended_event() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let publishers = 4_u64;
        let events_per_publisher = 256_u64;
        let start = std::sync::Barrier::new(publishers as usize + 1);
        let finished = AtomicU64::new(0);

        std::thread::scope(|scope| {
            for _ in 0..publishers {
                scope.spawn(|| {
                    start.wait();
                    for _ in 0..events_per_publisher {
                        shared.publish(NodeEvent::ControllerChanged { controller: None });
                    }
                    finished.fetch_add(1, Ordering::Release);
                });
            }
            start.wait();
            while finished.load(Ordering::Acquire) != publishers {
                assert_resync_history_is_linearized(shared.resync(0));
                std::thread::yield_now();
            }
        });
        let response = shared.resync(0);
        assert_resync_history_is_linearized(response.clone());
        let NodeResponse::Resync { event_sequence, events, .. } = response else {
            unreachable!("resync helper returned another response");
        };
        assert_eq!(event_sequence, publishers * events_per_publisher);
        assert_eq!(events.len() as u64, event_sequence);
    }

    fn assert_resync_history_is_linearized(response: NodeResponse) {
        let NodeResponse::Resync { event_sequence, events, .. } = response else {
            unreachable!("resync helper returned another response");
        };
        assert!(events.windows(2).all(|pair| {
            pair[0].sequence.checked_add(1) == Some(pair[1].sequence)
        }));
        assert_eq!(events.last().map_or(0, |event| event.sequence), event_sequence);
    }

    #[test]
    fn canonical_workspace_roots_are_safe_for_cmd_exe() {
        assert_eq!(
            platform::normalize_canonical_root(r"\\?\C:\repo\worktree".to_owned()),
            r"C:\repo\worktree",
        );
        assert_eq!(
            platform::normalize_canonical_root(r"\\?\UNC\server\share\repo".to_owned()),
            r"\\server\share\repo",
        );
        assert!(validate_workspace_root(
            &WorkspaceId::new("network").unwrap(),
            r"\\server\share\repo",
        )
        .is_err());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        assert!(!workspace.canonical_root.starts_with(r"\\?\"));
    }

    #[test]
    fn resume_rebinds_only_on_the_expected_authorized_generation() {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(
            workspace_id.clone(),
            std::env::current_dir().unwrap(),
        )
        .unwrap();
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let instance_id = AgentInstanceId(17);
        let original = SessionAddress {
            workspace_id,
            session: SessionKey {
                instance_id,
                generation: SessionGeneration(3),
            },
        };
        shared.bind_session(
            instance_id,
            original.workspace_id.clone(),
            original.session.generation,
        );
        shared
            .arm_resume(
                &original,
                CommandId(41),
                ProviderRuntimePolicy::new(true, true, true, true, true, false).unwrap(),
            )
            .unwrap();

        shared.publish_control(ControlEvent {
            sequence: 1,
            command_id: None,
            instance_id,
            generation: SessionGeneration(4),
            event: ControlEventKind::Running { process_id: None },
        });
        assert_eq!(
            shared.address_for(instance_id, SessionGeneration(3)),
            Some(original.clone()),
        );
        assert!(shared.address_for(instance_id, SessionGeneration(4)).is_none());

        shared.publish_control(ControlEvent {
            sequence: 2,
            command_id: Some(CommandId(42)),
            instance_id,
            generation: SessionGeneration(3),
            event: ControlEventKind::CommandRejected {
                message: "unrelated command".to_owned(),
            },
        });

        shared.publish_control(ControlEvent {
            sequence: 3,
            command_id: None,
            instance_id,
            generation: SessionGeneration(4),
            event: ControlEventKind::ResumeAuthorized {
                session: gate4agent_types::ResumeSessionSummary {
                    key: gate4agent_types::ProviderSessionKey::SessionId,
                    id: "fixture-session".to_owned(),
                },
            },
        });
        assert!(shared.address_for(instance_id, SessionGeneration(3)).is_none());
        let rebound = shared.address_for(instance_id, SessionGeneration(4)).unwrap();
        assert_eq!(rebound.workspace_id, original.workspace_id);
        let history = shared
            .history
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        assert!(history.events.iter().any(|envelope| matches!(
            &envelope.event,
            NodeEvent::Control { address, event }
                if address == &rebound
                    && matches!(&event.event, ControlEventKind::ResumeAuthorized { .. })
        )));
    }

    #[test]
    fn all_node_pty_prompts_use_bracketed_paste_framing() {
        for agent in ["claude", "codex", "kimi"] {
            assert_eq!(
                prompt_framing(&AgentId::new(agent).unwrap()),
                PromptFraming::BracketedPaste
            );
        }
    }

    fn generous_walk_deadline() -> Instant {
        Instant::now() + Duration::from_secs(30)
    }

    #[test]
    fn workspace_tree_is_relative_and_skips_heavy_directories() {
        let root = temporary_workspace_root("tree");
        std::fs::create_dir_all(root.join("src")).unwrap();
        std::fs::create_dir_all(root.join(".git/objects")).unwrap();
        std::fs::create_dir_all(root.join("target/debug")).unwrap();
        std::fs::create_dir_all(root.join("node_modules/package")).unwrap();
        std::fs::write(root.join("src/lib.rs"), b"pub fn fixture() {}\n").unwrap();
        std::fs::write(root.join("README.md"), b"fixture\n").unwrap();
        // A renamed/agent-scoped build directory (`target-a2`-style, per the
        // real repository's own build layout) that carries the Cache
        // Directory Tagging Specification marker cargo writes into every
        // `--target-dir` it creates: must be skipped even though its name
        // does not exactly match `target`.
        std::fs::create_dir_all(root.join("target-a2/debug")).unwrap();
        std::fs::write(root.join("target-a2/CACHEDIR.TAG"), b"Signature: 8a477f597d28d172789f06886806bc55\n").unwrap();
        // A directory that merely *starts with* `target` but carries no
        // CACHEDIR.TAG: the new prefix-adjacent check must not false-match
        // on the name alone, so this stays in the response.
        std::fs::create_dir_all(root.join("target-notes")).unwrap();
        std::fs::write(root.join("target-notes/plan.md"), b"not a build directory\n").unwrap();

        let (entries, truncated, _budget) =
            collect_workspace_entries(&root, generous_walk_deadline(), WORKSPACE_INSPECTION_ENTRY_CAP_DEFAULT);
        assert!(!truncated);
        assert!(entries.iter().any(|entry| {
            entry.relative_path.as_utf8() == Some("src")
                && entry.kind == WorkspaceEntryKind::Directory
        }));
        assert!(entries.iter().any(|entry| {
            entry.relative_path.as_utf8() == Some("src/lib.rs")
                && entry.kind == WorkspaceEntryKind::File
        }));
        assert!(entries.iter().any(|entry| {
            entry.relative_path.as_utf8() == Some("target-notes")
                && entry.kind == WorkspaceEntryKind::Directory
        }));
        assert!(entries.iter().any(|entry| {
            entry.relative_path.as_utf8() == Some("target-notes/plan.md")
                && entry.kind == WorkspaceEntryKind::File
        }));
        assert!(entries.iter().all(|entry| {
            let path = entry.relative_path.as_utf8().unwrap();
            !path.starts_with(".git")
                && !(path == "target" || path.starts_with("target/"))
                && !(path == "target-a2" || path.starts_with("target-a2/"))
                && !path.starts_with("node_modules")
        }));

        std::fs::remove_dir_all(&root).unwrap();
    }

    #[test]
    fn workspace_walk_stops_at_its_entry_cap_and_marks_a_partial_result() {
        let root = temporary_workspace_root("tree-entry-cap");
        std::fs::create_dir_all(&root).unwrap();
        for index in 0..20 {
            std::fs::write(root.join(format!("file-{index:02}.txt")), b"fixture\n").unwrap();
        }

        let (entries, truncated, budget) =
            collect_workspace_entries(&root, generous_walk_deadline(), 5);
        assert!(truncated);
        assert!(budget.entry_cap_exceeded);
        assert!(!budget.time_budget_exceeded);
        assert!(entries.len() <= 5);

        let inspection_truncation = workspace_inspection_truncation(&budget, false, Duration::from_millis(1))
            .expect("an entry-cap-truncated walk must report a truncation marker");
        assert!(inspection_truncation.walk_entry_cap_exceeded);
        assert!(!inspection_truncation.walk_time_budget_exceeded);
        assert!(!inspection_truncation.git_time_budget_exceeded);
        assert!(inspection_truncation.entries_visited >= 5);

        std::fs::remove_dir_all(&root).unwrap();
    }

    #[test]
    fn workspace_walk_within_budget_reports_no_truncation() {
        let root = temporary_workspace_root("tree-no-truncation");
        std::fs::create_dir_all(&root).unwrap();
        std::fs::write(root.join("only-file.txt"), b"fixture\n").unwrap();

        let (_entries, truncated, budget) =
            collect_workspace_entries(&root, generous_walk_deadline(), WORKSPACE_INSPECTION_ENTRY_CAP_DEFAULT);
        assert!(!truncated);
        assert!(workspace_inspection_truncation(&budget, false, Duration::from_millis(1)).is_none());

        std::fs::remove_dir_all(&root).unwrap();
    }

    #[test]
    fn workspace_walk_emits_strict_global_byte_order_for_prefix_named_siblings() {
        let root = temporary_workspace_root("tree-prefix-siblings");
        std::fs::create_dir_all(root.join("gate4agent-c2/src")).unwrap();
        std::fs::write(root.join("gate4agent-c2/src/lib.rs"), b"fixture\n").unwrap();
        std::fs::create_dir_all(root.join("gate4agent-c2-client")).unwrap();
        std::fs::write(root.join("gate4agent-c2-client/lib.rs"), b"fixture\n").unwrap();

        let (entries, truncated, _budget) =
            collect_workspace_entries(&root, generous_walk_deadline(), WORKSPACE_INSPECTION_ENTRY_CAP_DEFAULT);
        assert!(!truncated);
        let paths = entries
            .iter()
            .map(|entry| entry.relative_path.as_utf8().unwrap().to_owned())
            .collect::<Vec<_>>();
        assert!(paths.windows(2).all(|pair| pair[0] < pair[1]));
        assert_eq!(
            paths,
            vec![
                "gate4agent-c2".to_owned(),
                "gate4agent-c2-client".to_owned(),
                "gate4agent-c2-client/lib.rs".to_owned(),
                "gate4agent-c2/src".to_owned(),
                "gate4agent-c2/src/lib.rs".to_owned(),
            ],
        );

        std::fs::remove_dir_all(&root).unwrap();
    }

    #[test]
    fn git_parsers_cap_status_and_commit_results() {
        let mut status_output = Vec::new();
        for index in 0..=GIT_STATUS_MAX_ENTRIES {
            status_output.extend_from_slice(format!(" M src/file-{index}.rs\0").as_bytes());
        }
        let mut snapshot = git_snapshot_for_parser();
        parse_git_status(&status_output, &mut snapshot);
        assert_eq!(snapshot.status.len(), GIT_STATUS_MAX_ENTRIES);
        assert!(snapshot.truncated);
        assert_eq!(snapshot.status[0].index_status, " ");
        assert_eq!(snapshot.status[0].worktree_status, "M");

        snapshot.truncated = false;
        let commit_output = (0..=GIT_COMMIT_MAX_ENTRIES)
            .map(|index| format!("abc{index}\u{1f}commit {index}\n"))
            .collect::<String>();
        parse_git_commits(commit_output.as_bytes(), &mut snapshot);
        assert_eq!(snapshot.recent_commits.len(), GIT_COMMIT_MAX_ENTRIES);
        assert!(snapshot.truncated);
    }

    #[test]
    fn porcelain_v1_z_parser_preserves_current_then_previous_rename_and_copy_order() {
        let mut snapshot = git_snapshot_for_parser();
        parse_git_status(
            b"R  src/current name.rs\0src/previous name.rs\0 C src/copy.rs\0src/original.rs\0?? src/line\nname.rs\0",
            &mut snapshot,
        );

        assert!(!snapshot.truncated);
        assert_eq!(snapshot.status.len(), 3);
        assert_eq!(snapshot.status[0].index_status, "R");
        assert_eq!(snapshot.status[0].worktree_status, " ");
        assert_eq!(snapshot.status[0].path.as_utf8(), Some("src/current name.rs"));
        assert_eq!(
            snapshot.status[0]
                .previous_path
                .as_ref()
                .and_then(RepositoryPath::as_utf8),
            Some("src/previous name.rs"),
        );
        assert_eq!(snapshot.status[1].index_status, " ");
        assert_eq!(snapshot.status[1].worktree_status, "C");
        assert_eq!(snapshot.status[1].path.as_utf8(), Some("src/copy.rs"));
        assert_eq!(
            snapshot.status[1]
                .previous_path
                .as_ref()
                .and_then(RepositoryPath::as_utf8),
            Some("src/original.rs"),
        );
        assert_eq!(snapshot.status[2].path.as_utf8(), Some("src/line\nname.rs"));
        assert!(snapshot.status[2].previous_path.is_none());
    }

    #[test]
    fn porcelain_v1_z_parser_never_invents_invalid_or_incomplete_path_identity() {
        let mut snapshot = git_snapshot_for_parser();
        parse_git_status(
            b"?? valid.rs\0?? invalid-\xff.rs\0?? invalid\\windows.rs\0R  current.rs\0",
            &mut snapshot,
        );

        assert!(snapshot.truncated);
        assert_eq!(snapshot.status.len(), 1);
        assert_eq!(snapshot.status[0].path.as_utf8(), Some("valid.rs"));
        assert!(snapshot.status[0].previous_path.is_none());
    }

    #[tokio::test]
    async fn observer_can_browse_host_directories_without_controller() {
        let root = temporary_workspace_root("host-directory-observer");
        std::fs::create_dir_all(root.join("directory-b")).unwrap();
        std::fs::create_dir_all(root.join("directory-a")).unwrap();
        std::fs::write(root.join("ordinary-file"), b"not a directory").unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(workspace_id, &root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let request = NodeRequest::BrowseHostDirectories {
            directory: Some(OpaqueHostPath::utf8(root.to_string_lossy().into_owned()).unwrap()),
            after: None,
        };
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == CAPABILITY_HOST_DIRECTORY_BROWSE_V1
        }));
        assert!(!request_uses_unnegotiated_capability(
            &request,
            &baseline_capabilities().unwrap(),
        ));
        assert!(request_uses_unnegotiated_capability(&request, &[]));

        let response = process_request_inner(&shared, 77, ClientRole::Observer, request)
            .await
            .unwrap();
        let NodeResponse::HostDirectoriesBrowsed { listing } = response else {
            panic!("host directory browse returned another response");
        };
        assert_eq!(
            listing
                .entries
                .iter()
                .map(|entry| entry.display_name.as_str())
                .collect::<Vec<_>>(),
            vec!["directory-a", "directory-b"],
        );
        assert!(listing.entries.iter().all(|entry| !entry.is_link));
        assert!(!listing.incomplete);
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn observer_can_inspect_only_a_registered_workspace() {
        let root = temporary_workspace_root("observer");
        std::fs::create_dir_all(root.join("src")).unwrap();
        std::fs::write(root.join("src/main.rs"), b"fn main() {}\n").unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(workspace_id.clone(), &root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );

        let response = process_request_inner(
            &shared,
            77,
            ClientRole::Observer,
            NodeRequest::InspectWorkspace {
                workspace_id: workspace_id.clone(),
            },
        )
        .await
        .unwrap();
        let NodeResponse::WorkspaceInspected { inspection } = response else {
            panic!("workspace inspection returned another response");
        };
        assert_eq!(inspection.workspace_id, workspace_id);
        assert!(inspection.entries.iter().any(|entry| {
            entry.relative_path.as_utf8() == Some("src/main.rs")
        }));

        let unknown = process_request_inner(
            &shared,
            77,
            ClientRole::Observer,
            NodeRequest::InspectWorkspace {
                workspace_id: WorkspaceId::new("unknown").unwrap(),
            },
        )
        .await
        .unwrap_err();
        assert_eq!(unknown.code, NodeFailureCode::UnknownWorkspace);
        std::fs::remove_dir_all(&root).unwrap();
    }

    #[test]
    fn context_pack_source_accepts_only_running_or_successful_exit() {
        assert!(context_pack_source_status_is_usable(&SessionStatus::Running));
        assert!(context_pack_source_status_is_usable(&SessionStatus::Exited {
            exit_code: Some(0),
        }));
        assert!(!context_pack_source_status_is_usable(&SessionStatus::Exited {
            exit_code: Some(1),
        }));
        assert!(!context_pack_source_status_is_usable(&SessionStatus::Exited {
            exit_code: None,
        }));
        assert!(!context_pack_source_status_is_usable(&SessionStatus::Failed {
            message: "provider failed".to_owned(),
        }));
        assert!(!context_pack_source_status_is_usable(&SessionStatus::Registered));
        assert!(!context_pack_source_status_is_usable(&SessionStatus::Starting));
        assert!(!context_pack_source_status_is_usable(&SessionStatus::Stopping));
    }

    #[test]
    fn context_pack_repository_rejects_changed_head_with_same_git_snapshot() {
        let git = git_snapshot_for_parser();
        let first = ContextPackRepositoryObservation {
            head: ContextPackRepositoryHead::Commit("a".repeat(40)),
            git: git.clone(),
            files: Vec::new(),
        };
        let second = ContextPackRepositoryObservation {
            head: ContextPackRepositoryHead::Commit("b".repeat(40)),
            git,
            files: Vec::new(),
        };

        let error = stable_context_pack_repository(first, second).unwrap_err();

        assert_eq!(
            error.code,
            NodeFailureCode::ContextPackMaterializationFailed,
        );
    }

    #[test]
    fn context_pack_repository_rejects_changed_file_with_same_git_snapshot() {
        let git = git_snapshot_for_parser();
        let first = ContextPackRepositoryObservation {
            head: ContextPackRepositoryHead::Commit("a".repeat(40)),
            git: git.clone(),
            files: vec![ContextPackRepositoryFileSource::utf8(
                "README.md",
                "first\n".to_owned(),
                6,
            )],
        };
        let second = ContextPackRepositoryObservation {
            head: ContextPackRepositoryHead::Commit("a".repeat(40)),
            git,
            files: vec![ContextPackRepositoryFileSource::utf8(
                "README.md",
                "other\n".to_owned(),
                6,
            )],
        };

        let error = stable_context_pack_repository(first, second).unwrap_err();

        assert_eq!(
            error.code,
            NodeFailureCode::ContextPackMaterializationFailed,
        );
    }

    #[tokio::test]
    async fn native_session_catalog_zero_active_session_fixture() {
        let workspace_root = temporary_workspace_root("native-catalog-workspace");
        let history_root = temporary_workspace_root("native-catalog-history");
        let outside_root = temporary_workspace_root("native-catalog-outside");
        std::fs::create_dir_all(&workspace_root).unwrap();
        std::fs::create_dir_all(&history_root).unwrap();
        std::fs::create_dir_all(&outside_root).unwrap();
        let transcript = |session_id: &str, cwd: &Path, title: &str| {
            [
                serde_json::json!({
                    "type": "user",
                    "sessionId": session_id,
                    "cwd": cwd.to_str().unwrap(),
                    "message": { "content": "raw user text must not cross the catalog wire" }
                }),
                serde_json::json!({
                    "type": "assistant",
                    "sessionId": session_id,
                    "cwd": cwd.to_str().unwrap(),
                    "message": { "model": "claude-sonnet", "content": "raw answer" }
                }),
                serde_json::json!({
                    "type": "ai-title",
                    "sessionId": session_id,
                    "aiTitle": title
                }),
            ]
            .into_iter()
            .map(|record| record.to_string())
            .collect::<Vec<_>>()
            .join("\n")
        };
        std::fs::write(
            history_root.join("stable-session.jsonl"),
            transcript("stable-session", &workspace_root, "Workspace review"),
        )
        .unwrap();
        std::fs::write(
            history_root.join("outside-session.jsonl"),
            transcript("outside-session", &outside_root, "Outside review"),
        )
        .unwrap();
        let history = NativeHistoryConfig::new(vec![
            NativeHistoryRoot::new(
                gate4agent_types::AdapterId::new("claude-code").unwrap(),
                HistorySourceLayout::SingleNdjson,
                history_root.clone(),
            )
            .unwrap(),
        ])
        .unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        assert!(handle.snapshot().sessions.is_empty());
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(workspace_id.clone(), &workspace_root).unwrap();
        let mut shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-native-catalog").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        shared.native_session_catalog = Some(Arc::new(Mutex::new(
            NativeSessionCatalogAuthority::new(history),
        )));
        let route = NativeSessionCatalogRoute::workspace(
            workspace_id.clone(),
            agent("claude"),
        );
        let request = NodeRequest::CatalogNativeSessions {
            route: route.clone(),
            limit: 2,
        };
        let observer = process_request_inner(&shared, 7, ClientRole::Observer, request.clone())
            .await
            .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        let response = process_request_inner(&shared, 7, ClientRole::Operator, request)
            .await
            .unwrap();
        let NodeResponse::NativeSessionsCataloged { entries, summary, .. } = response else {
            panic!("native catalog returned a different response");
        };
        let summary = summary.expect("node must emit native session catalog summary metadata");
        assert_eq!(entries.len(), 1);
        assert!(gate4agent_types::validate_candidate_id(&entries[0].selection_id).is_ok());
        assert_eq!(entries[0].external_group, None);
        assert_eq!(entries[0].record_id, None);
        assert_eq!(entries[0].title, None);
        assert_eq!(entries[0].model, None);
        assert_eq!(entries[0].message_count, 0);
        let encoded_entries = serde_json::to_string(&entries).unwrap();
        assert!(!encoded_entries.contains("stable-session"));
        assert!(!encoded_entries.contains(history_root.to_string_lossy().as_ref()));
        let page_request = NodeRequest::PageNativeSessions {
            route: route.clone(),
            window: crate::protocol::NativeSessionCatalogWindow::Recent,
            catalog_revision: summary.catalog_revision,
            recent_cutoff_unix_ms: summary.recent_cutoff_unix_ms,
            after_selection_id: None,
            limit: 2,
        };
        let observer = process_request_inner(
            &shared,
            7,
            ClientRole::Observer,
            page_request.clone(),
        )
        .await
        .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        let page_response = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            page_request.clone(),
        )
        .await
        .unwrap();
        assert!(matches!(
            page_response,
            NodeResponse::NativeSessionsPaged { page, .. }
                if page.entries.len() == 1 && !page.has_more && page.remaining_count == 0
        ));
        let stale = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::PageNativeSessions {
                route: route.clone(),
                window: crate::protocol::NativeSessionCatalogWindow::Recent,
                catalog_revision: summary.catalog_revision.wrapping_add(1),
                recent_cutoff_unix_ms: summary.recent_cutoff_unix_ms,
                after_selection_id: None,
                limit: 2,
            },
        )
        .await
        .unwrap_err();
        assert_eq!(stale.code, NodeFailureCode::StaleNativeSessionCatalog);
        let selection = NativeSessionSelection {
            route: route.clone(),
            catalog_revision: summary.catalog_revision,
            recent_cutoff_unix_ms: summary.recent_cutoff_unix_ms,
            selection_id: entries[0].selection_id.clone(),
        };
        let preview_response = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::PreviewNativeSession {
                selection: selection.clone(),
                message_limit: 1,
            },
        )
        .await
        .unwrap();
        let NodeResponse::NativeSessionPreviewed { preview, .. } = preview_response else {
            panic!("native preview returned a different response");
        };
        assert_eq!(preview.messages.len(), 1);
        assert!(preview.message_count_exact);
        assert_eq!(preview.messages[0].text, "raw answer");
        assert!(preview.truncated);

        let index_request = NodeRequest::IndexNativeSession {
            selection: selection.clone(),
            display_name: "Saved Claude".to_owned(),
        };
        let observer = process_request_inner(
            &shared,
            7,
            ClientRole::Observer,
            index_request.clone(),
        )
        .await
        .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        let without_controller = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            index_request.clone(),
        )
        .await
        .unwrap_err();
        assert_eq!(without_controller.code, NodeFailureCode::ControllerRequired);
        let acquired = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::AcquireController { lease_ms: 5_000 },
        )
        .await
        .unwrap();
        assert!(matches!(acquired, NodeResponse::Controller { controller: Some(_) }));
        let indexed = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            index_request,
        )
        .await
        .unwrap();
        assert!(indexed.native_session_index_contract_is_valid());
        let NodeResponse::NativeSessionIndexed {
            selection: echoed_selection,
            record,
        } = indexed else {
            panic!("native session index returned a different response");
        };
        assert_eq!(echoed_selection, selection);
        let recataloged = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::CatalogNativeSessions {
                route,
                limit: 2,
            },
        )
        .await
        .unwrap();
        let NodeResponse::NativeSessionsCataloged { entries, .. } = recataloged else {
            panic!("native catalog returned a different response after indexing");
        };
        assert_eq!(entries[0].record_id.as_ref(), Some(&record.record_id));

        let unregistered_route = NativeSessionCatalogRoute::unregistered(agent("claude"));
        let external_catalog = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::CatalogNativeSessions {
                route: unregistered_route.clone(),
                limit: 2,
            },
        )
        .await
        .unwrap();
        let external_json = serde_json::to_string(&external_catalog).unwrap();
        assert!(!external_json.contains("outside-session"));
        assert!(!external_json.contains(outside_root.to_string_lossy().as_ref()));
        assert!(!external_json.contains(history_root.to_string_lossy().as_ref()));
        assert!(!external_json.contains("\"session_id\""));
        assert!(!external_json.contains("\"cwd\""));
        assert!(!external_json.contains("\"path\""));
        let NodeResponse::NativeSessionsCataloged {
            route: echoed_route,
            entries: external_entries,
            summary: Some(external_summary),
        } = external_catalog
        else {
            panic!("unregistered native catalog returned a different response");
        };
        assert_eq!(echoed_route, unregistered_route);
        assert_eq!(external_entries.len(), 1);
        assert_eq!(external_entries[0].record_id, None);
        let external_group = external_entries[0]
            .external_group
            .as_ref()
            .expect("unregistered session must have an external group");
        assert_eq!(
            external_group.kind,
            gate4agent_types::NativeSessionExternalGroupKind::Project,
        );
        assert!(external_group.group_id.starts_with("external-"));
        assert_eq!(
            external_group.display_name,
            outside_root.file_name().unwrap().to_string_lossy(),
        );
        let external_selection = NativeSessionSelection {
            route: unregistered_route,
            catalog_revision: external_summary.catalog_revision,
            recent_cutoff_unix_ms: external_summary.recent_cutoff_unix_ms,
            selection_id: external_entries[0].selection_id.clone(),
        };
        let external_preview = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::PreviewNativeSession {
                selection: external_selection.clone(),
                message_limit: 1,
            },
        )
        .await
        .unwrap();
        let external_preview_json = serde_json::to_string(&external_preview).unwrap();
        assert!(!external_preview_json.contains("outside-session"));
        assert!(!external_preview_json.contains(outside_root.to_string_lossy().as_ref()));
        assert!(!external_preview_json.contains("\"session_id\""));
        let NodeResponse::NativeSessionPreviewed { preview, .. } = external_preview else {
            panic!("unregistered native preview returned a different response");
        };
        assert_eq!(preview.messages.len(), 1);
        let external_index = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::IndexNativeSession {
                selection: external_selection,
                display_name: "External Claude".to_owned(),
            },
        )
        .await
        .unwrap_err();
        assert_eq!(
            external_index.code,
            NodeFailureCode::WorkspaceRegistrationRequired,
        );
        let record_response = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::PreviewSessionRecord {
                record_id: record.record_id.clone(),
                message_limit: 2,
            },
        )
        .await
        .unwrap();
        let NodeResponse::SessionRecordPreviewed { record_id, preview } = record_response else {
            panic!("record preview returned a different response");
        };
        assert_eq!(record_id, record.record_id);
        assert_eq!(preview.messages.len(), 2);
        let encoded = serde_json::to_string(&preview).unwrap();
        assert!(!encoded.contains("stable-session"));
        assert!(!encoded.contains(history_root.to_string_lossy().as_ref()));
        let NodeResponse::Resync { events, .. } = shared.resync(0) else {
            panic!("record preview history summary returned a different response");
        };
        let summaries = events
            .iter()
            .filter_map(|envelope| match &envelope.event {
                NodeEvent::SessionRecordHistorySummarized { record_id, summary }
                    if record_id == &record.record_id =>
                {
                    Some(*summary)
                }
                _ => None,
            })
            .collect::<Vec<_>>();
        assert_eq!(summaries, vec![SessionHistorySummaryV1::from(&preview)]);
        let summary_json = serde_json::to_string(&summaries).unwrap();
        for private in [
            "stable-session",
            "raw user text must not cross the catalog wire",
            "raw answer",
            "Workspace review",
            "claude-sonnet",
        ] {
            assert!(!summary_json.contains(private), "{private}");
        }
        let identity = record.provider_session.clone().unwrap();
        assert_eq!(
            shared.revalidate_session_record_preview(&record, &identity),
            Ok(())
        );
        shared.remove_record_memory(&record.record_id);
        assert_eq!(
            shared
                .revalidate_session_record_preview(&record, &identity)
                .unwrap_err()
                .code,
            NodeFailureCode::UnknownSessionRecord
        );
        let released = process_request_inner(
            &shared,
            7,
            ClientRole::Operator,
            NodeRequest::ReleaseController,
        )
        .await
        .unwrap();
        assert!(matches!(released, NodeResponse::Controller { controller: None }));
        assert!(shared.controller_state().is_none());
        std::fs::remove_dir_all(workspace_root).unwrap();
        std::fs::remove_dir_all(history_root).unwrap();
        std::fs::remove_dir_all(outside_root).unwrap();
    }

    #[tokio::test]
    async fn native_session_catalog_concurrent_operation_fails_fast_without_waiting_on_mutex() {
        let history_root = temporary_workspace_root("native-catalog-concurrent-operation");
        std::fs::create_dir_all(&history_root).unwrap();
        let history = NativeHistoryConfig::new(vec![
            NativeHistoryRoot::new(
                gate4agent_types::AdapterId::new("claude-code").unwrap(),
                HistorySourceLayout::SingleNdjson,
                history_root.clone(),
            )
            .unwrap(),
        ])
        .unwrap();
        let catalog = Arc::new(Mutex::new(NativeSessionCatalogAuthority::new(history)));
        let held = catalog.lock().unwrap();
        let result = timeout(
            Duration::from_secs(1),
            run_native_session_catalog_operation(
                Arc::clone(&catalog),
                "native session catalog",
                |_| Ok::<(), std::convert::Infallible>(()),
            ),
        )
        .await
        .expect("concurrent native catalog request must not wait for the operation deadline")
        .unwrap_err();
        assert_eq!(result.code, NodeFailureCode::BackendBusy);
        drop(held);
        std::fs::remove_dir_all(history_root).unwrap();
    }

    fn temporary_workspace_root(label: &str) -> std::path::PathBuf {
        let unique = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap()
            .as_nanos();
        std::env::temp_dir().join(format!(
            "gate4agent-node-{label}-{}-{unique}",
            std::process::id(),
        ))
    }

    fn git_snapshot_for_parser() -> GitSnapshot {
        GitSnapshot {
            is_repository: true,
            branch: Some("main".to_owned()),
            status: Vec::new(),
            recent_commits: Vec::new(),
            worktrees: Vec::new(),
            managed_worktree: None,
            truncated: false,
            diagnostic: None,
        }
    }

    #[tokio::test]
    async fn workspace_inspection_scopes_only_exact_active_managed_branch() {
        let root = temporary_workspace_root("managed-git-scope");
        std::fs::create_dir_all(&root).unwrap();
        run_test_git(&root, &["init"]);
        run_test_git(&root, &["config", "user.email", "gate4agent@example.invalid"]);
        run_test_git(&root, &["config", "user.name", "Gate4Agent Test"]);
        std::fs::write(root.join("seed.txt"), "seed\n").unwrap();
        run_test_git(&root, &["add", "seed.txt"]);
        run_test_git(&root, &["commit", "-m", "seed"]);
        run_test_git(&root, &["checkout", "-b", "gate4agent/a"]);

        let workspace_id = WorkspaceId::new("managed-a").unwrap();
        let workspace = WorkspaceConfig::new(workspace_id.clone(), &root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let mut lease = ManagedWorktreeLeaseRecord {
            lease_id: ManagedWorktreeLeaseId::new("mw-a").unwrap(),
            source_workspace_id: WorkspaceId::new("primary").unwrap(),
            workspace_id: workspace_id.clone(),
            profile_id: WorktreeProfileId::new("default").unwrap(),
            profile_revision: crate::protocol::WorktreeProfileRevision::new("v1").unwrap(),
            target_root: root.to_string_lossy().into_owned(),
            branch: "gate4agent/a".to_owned(),
            base_commit: "0123456789abcdef0123456789abcdef01234567".to_owned(),
            expected_head: None,
            retention: ManagedWorktreeRetention::Retain,
            state: ManagedWorktreeLeaseState::InUse,
            session_holders: vec![ManagedWorktreeSessionHolder {
                incarnation_id: shared.incarnation_id,
                instance_id: AgentInstanceId(7),
                generation: SessionGeneration(1),
            }],
            record_holders: Vec::new(),
            cleanup_failure: None,
            created_at_unix_ms: 1,
            updated_at_unix_ms: 1,
        };
        *shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            ManagedWorktreeRegistry::from_records(vec![lease.clone()], Vec::new()).unwrap();

        let inspection = shared.inspect_workspace(workspace_id.clone()).await.unwrap();
        let scope = inspection.git.managed_worktree.unwrap();
        assert_eq!(scope.lease_id, lease.lease_id);
        assert_eq!(scope.branch, "gate4agent/a");
        assert_eq!(scope.active_session_count, 1);

        lease.branch = "gate4agent/b".to_owned();
        *shared
            .managed_worktrees
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner()) =
            ManagedWorktreeRegistry::from_records(vec![lease], Vec::new()).unwrap();
        let mismatch = shared.inspect_workspace(workspace_id).await.unwrap();
        assert!(mismatch.git.managed_worktree.is_none());
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn workspace_file_write_requires_controller_and_rejects_stale_revision() {
        let root = temporary_workspace_root("workspace-file-write-controller");
        std::fs::create_dir_all(root.join("src")).unwrap();
        std::fs::write(root.join("src/lib.rs"), b"old\n").unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(workspace_id.clone(), &root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let path = RepositoryPath::utf8("src/lib.rs".to_owned()).unwrap();
        let expected_revision = workspace_file_revision(b"old\n");
        let request = NodeRequest::WriteWorkspaceFile {
            workspace_id: workspace_id.clone(),
            path: path.clone(),
            expected_revision: expected_revision.clone(),
            text: "new\n".to_owned(),
        };
        let observer = process_request_inner(&shared, 77, ClientRole::Observer, request.clone())
            .await
            .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        let uncontrolled = process_request_inner(&shared, 77, ClientRole::Operator, request.clone())
            .await
            .unwrap_err();
        assert_eq!(uncontrolled.code, NodeFailureCode::ControllerRequired);
        shared.acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS).unwrap();
        let response = process_request_inner(&shared, 77, ClientRole::Operator, request).await.unwrap();
        let NodeResponse::WorkspaceFileWritten { file } = response else {
            panic!("workspace file write returned another response");
        };
        assert_eq!(file.revision, Some(workspace_file_revision(b"new\n")));
        assert_eq!(std::fs::read(root.join("src/lib.rs")).unwrap(), b"new\n");
        let stale = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::WriteWorkspaceFile {
                workspace_id,
                path,
                expected_revision,
                text: "lost update\n".to_owned(),
            },
        )
        .await
        .unwrap_err();
        assert_eq!(stale.code, NodeFailureCode::RepositoryFileRevisionConflict);
        assert_eq!(std::fs::read(root.join("src/lib.rs")).unwrap(), b"new\n");
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn workspace_entry_create_requires_controller_and_never_overwrites() {
        let root = temporary_workspace_root("workspace-entry-create-controller");
        std::fs::create_dir_all(root.join("src")).unwrap();
        let workspace_id = WorkspaceId::new("primary").unwrap();
        let workspace = WorkspaceConfig::new(workspace_id.clone(), &root).unwrap();
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let shared = NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-1").unwrap(),
            vec![workspace],
            vec![agent("claude")],
        );
        let path = RepositoryPath::utf8("src/new.rs".to_owned()).unwrap();
        let request = NodeRequest::CreateWorkspaceFile {
            workspace_id: workspace_id.clone(),
            path: path.clone(),
        };
        assert!(baseline_capabilities().unwrap().iter().any(|capability| {
            capability.as_str() == NODE_WORKSPACE_ENTRY_CREATE_CAPABILITY
        }));
        assert!(!request_uses_unnegotiated_capability(
            &request,
            &baseline_capabilities().unwrap(),
        ));
        assert!(request_uses_unnegotiated_capability(&request, &[]));
        let observer = process_request_inner(&shared, 77, ClientRole::Observer, request.clone())
            .await
            .unwrap_err();
        assert_eq!(observer.code, NodeFailureCode::ObserverReadOnly);
        let uncontrolled = process_request_inner(&shared, 77, ClientRole::Operator, request.clone())
            .await
            .unwrap_err();
        assert_eq!(uncontrolled.code, NodeFailureCode::ControllerRequired);
        shared.acquire_controller(77, ClientRole::Operator, DEFAULT_CONTROLLER_LEASE_MS).unwrap();

        let response = process_request_inner(&shared, 77, ClientRole::Operator, request.clone())
            .await
            .unwrap();
        let NodeResponse::WorkspaceFileCreated { file } = response else {
            panic!("workspace file create returned another response");
        };
        assert_eq!(file.workspace_id, workspace_id);
        assert_eq!(file.path, path);
        assert_eq!(file.revision, Some(workspace_file_revision(&[])));
        assert_eq!(std::fs::read(root.join("src/new.rs")).unwrap(), Vec::<u8>::new());

        let duplicate = process_request_inner(&shared, 77, ClientRole::Operator, request)
            .await
            .unwrap_err();
        assert_eq!(duplicate.code, NodeFailureCode::RepositoryEntryAlreadyExists);

        let directory_path = RepositoryPath::utf8("src/nested".to_owned()).unwrap();
        let response = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::CreateWorkspaceDirectory {
                workspace_id: workspace_id.clone(),
                path: directory_path.clone(),
            },
        )
        .await
        .unwrap();
        assert_eq!(
            response,
            NodeResponse::WorkspaceDirectoryCreated {
                workspace_id: workspace_id.clone(),
                entry: WorkspaceEntry {
                    relative_path: directory_path,
                    kind: WorkspaceEntryKind::Directory,
                },
            },
        );
        assert!(root.join("src/nested").is_dir());

        let missing_parent = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::CreateWorkspaceFile {
                workspace_id: workspace_id.clone(),
                path: RepositoryPath::utf8("missing/new.rs".to_owned()).unwrap(),
            },
        )
        .await
        .unwrap_err();
        assert_eq!(missing_parent.code, NodeFailureCode::RepositoryParentNotFound);
        let non_directory_parent = process_request_inner(
            &shared,
            77,
            ClientRole::Operator,
            NodeRequest::CreateWorkspaceFile {
                workspace_id,
                path: RepositoryPath::utf8("src/new.rs/child".to_owned()).unwrap(),
            },
        )
        .await
        .unwrap_err();
        assert_eq!(
            non_directory_parent.code,
            NodeFailureCode::RepositoryParentNotDirectory,
        );
        std::fs::remove_dir_all(root).unwrap();
    }

    #[tokio::test]
    async fn workspace_entry_create_timeout_cancels_before_commit_without_late_mutation() {
        let root = temporary_workspace_root("workspace-entry-create-timeout-cancel");
        std::fs::create_dir_all(root.join("src")).unwrap();
        #[cfg(windows)]
        let root = std::fs::canonicalize(root).unwrap();
        let path = RepositoryPath::utf8("src/late.rs".to_owned()).unwrap();
        let commit_state = Arc::new(AtomicU8::new(WORKSPACE_ENTRY_CREATE_PENDING));
        let barrier = Arc::new(std::sync::Barrier::new(2));
        let done = Arc::new(AtomicBool::new(false));
        let task_commit_state = Arc::clone(&commit_state);
        let task_barrier = Arc::clone(&barrier);
        let task_done = Arc::clone(&done);
        let task_root = root.clone();
        let task = tokio::task::spawn_blocking(move || {
            task_barrier.wait();
            let result = create_workspace_file_on_disk(
                &task_root,
                &path,
                &task_commit_state,
            );
            task_done.store(true, Ordering::Release);
            result
        });

        let error = settle_workspace_entry_create(
            task,
            Arc::clone(&commit_state),
            Duration::from_millis(10),
            "fixture deadline",
            "fixture task failed",
        )
        .await
        .unwrap_err();
        assert_eq!(error.code, NodeFailureCode::RepositoryEntryCreateTimedOut);
        assert_eq!(
            commit_state.load(Ordering::Acquire),
            WORKSPACE_ENTRY_CREATE_CANCELED,
        );

        barrier.wait();
        timeout(Duration::from_secs(1), async {
            while !done.load(Ordering::Acquire) {
                tokio::task::yield_now().await;
            }
        })
        .await
        .expect("canceled blocking create did not settle");
        assert!(!root.join("src/late.rs").exists());
        std::fs::remove_dir_all(root).unwrap();
    }
}

#[cfg(test)]
mod provisional_spawn_tests {
    use super::*;
    use std::sync::Arc;

    fn shared() -> NodeShared {
        let catalog = active_registry().unwrap();
        let (handle, _runtime) = NativeRuntime::new(catalog, NativeRuntimeConfig::default());
        let workspace = WorkspaceConfig::new(
            WorkspaceId::new("primary").unwrap(),
            std::env::current_dir().unwrap(),
        )
        .unwrap()
        .with_worktree_service_mode(WorktreeServiceMode::Manual);
        NodeShared::new(
            handle,
            "fixture-token".to_owned(),
            NodeId::new("node-provisional-test").unwrap(),
            vec![workspace],
            vec![AgentId::new("claude").unwrap()],
        )
    }

    /// Provisional draft map: sessionize by instance id only; 50 sequential
    /// mark/claim cycles never collide, and a claimed draft is never reaped.
    #[test]
    fn provisional_spawn_keys_are_unique_and_sessionize_prevents_reap() {
        let shared = shared();
        let ws = WorkspaceId::new("primary").unwrap();
        let mut ids = Vec::with_capacity(50);
        for i in 1u64..=50 {
            let id = AgentInstanceId(i);
            ids.push(id);
            let address = SessionAddress {
                workspace_id: ws.clone(),
                session: SessionKey {
                    instance_id: id,
                    generation: SessionGeneration(1),
                },
            };
            shared.mark_spawn_provisional(address);
        }
        assert_eq!(
            shared
                .provisional_spawns
                .lock()
                .unwrap_or_else(|p| p.into_inner())
                .len(),
            50
        );
        for id in ids.iter().step_by(2) {
            shared.sessionize_spawn(*id);
        }
        assert_eq!(
            shared
                .provisional_spawns
                .lock()
                .unwrap_or_else(|p| p.into_inner())
                .len(),
            25
        );
        assert!(shared.take_due_provisional_spawns().is_empty());
        {
            let mut map = shared
                .provisional_spawns
                .lock()
                .unwrap_or_else(|p| p.into_inner());
            let past = Instant::now() - Duration::from_secs(91);
            for (_, (_, at)) in map.iter_mut() {
                *at = past;
            }
        }
        let due = shared.take_due_provisional_spawns();
        assert_eq!(due.len(), 25);
        let due_ids: std::collections::BTreeSet<_> =
            due.iter().map(|a| a.session.instance_id.0).collect();
        let expected: std::collections::BTreeSet<_> =
            ids.iter().skip(1).step_by(2).map(|id| id.0).collect();
        assert_eq!(due_ids, expected);
        assert!(shared
            .provisional_spawns
            .lock()
            .unwrap_or_else(|p| p.into_inner())
            .is_empty());
    }

    /// Twenty parallel provisional marks must each get their own instance key;
    /// killing/sessionizing one id must not touch the others.
    #[test]
    fn provisional_spawn_parallel_marks_isolate_kills_by_instance_id() {
        let shared = Arc::new(shared());
        let ws = WorkspaceId::new("primary").unwrap();
        let mut handles = Vec::new();
        for i in 1u64..=20 {
            let shared = Arc::clone(&shared);
            let ws = ws.clone();
            handles.push(std::thread::spawn(move || {
                let id = AgentInstanceId(i);
                let address = SessionAddress {
                    workspace_id: ws,
                    session: SessionKey {
                        instance_id: id,
                        generation: SessionGeneration(1),
                    },
                };
                shared.mark_spawn_provisional(address);
                id
            }));
        }
        let mut ids = Vec::new();
        for h in handles {
            ids.push(h.join().unwrap());
        }
        ids.sort_by_key(|id| id.0);
        assert_eq!(ids.len(), 20);
        ids.dedup();
        assert_eq!(ids.len(), 20, "parallel marks must not share instance keys");
        assert_eq!(
            shared
                .provisional_spawns
                .lock()
                .unwrap_or_else(|p| p.into_inner())
                .len(),
            20
        );
        shared.sessionize_spawn(AgentInstanceId(7));
        let left: Vec<_> = shared
            .provisional_spawns
            .lock()
            .unwrap_or_else(|p| p.into_inner())
            .keys()
            .map(|id| id.0)
            .collect();
        assert!(!left.contains(&7));
        assert_eq!(left.len(), 19);
    }
}


#[cfg(unix)]
extern "C" {
    #[link_name = "geteuid"]
    fn libc_geteuid() -> u32;
}

#[cfg(test)]
mod call_home_link_tests {
    use super::*;

    #[test]
    fn call_home_backoff_is_capped_and_monotonic() {
        let mut last = Duration::ZERO;
        for attempt in 1..20 {
            let next = call_home_backoff(attempt);
            assert!(next >= last);
            assert!(next <= Duration::from_secs(8));
            last = next;
        }
        assert_eq!(call_home_backoff(0), Duration::from_millis(500));
    }

    #[tokio::test]
    async fn call_home_socket_gets_keepalive() {
        let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
        let addr = listener.local_addr().unwrap();
        let (client, _server) = tokio::join!(tokio::net::TcpStream::connect(addr), listener.accept());
        let client = client.unwrap();
        enable_call_home_keepalive(&client).unwrap();
        let sock = socket2::SockRef::from(&client);
        assert!(sock.keepalive().unwrap());
        #[cfg(any(target_os = "linux", target_os = "macos"))]
        assert_eq!(sock.tcp_keepalive_time().unwrap(), CALL_HOME_KEEPALIVE_IDLE);
    }
}

/// A provider transcript for this session id exists in a known provider home.
fn provider_session_exists(provider: &str, id: &str) -> bool {
    if provider != "claude" { return false; }
    let mut homes: Vec<PathBuf> = std::env::var_os("HOME").map(PathBuf::from).into_iter().collect();
    if let Some(extra) = std::env::var_os("HATCHERY_PROVIDER_HOMES") { homes.extend(std::env::split_paths(&extra)); }
    let name = format!("{id}.jsonl");
    homes.iter().any(|h| std::fs::read_dir(h.join(".claude/projects")).map_or(false, |rd| rd.flatten().any(|d| d.path().join(&name).is_file())))
}

/// Append launch args to a prepared overlay (or create an instance overlay for them).
fn overlay_with_extra_args(
    provider: &AgentId,
    mode: SessionMode,
    overlay: Option<PreparedNativeLaunchOverlay>,
    args: Vec<OsString>,
) -> Result<Option<PreparedNativeLaunchOverlay>, NodeFailure> {
    let bad = || failure(NodeFailureCode::BackendOperationFailed, "resume launch args overlay is invalid");
    Ok(match (overlay, args) {
        (prepared, args) if args.is_empty() => prepared,
        (Some(PreparedNativeLaunchOverlay::Instance(mut o)), args) => { o.append_extra_args(args).map_err(|_| bad())?; Some(PreparedNativeLaunchOverlay::Instance(o)) }
        (Some(PreparedNativeLaunchOverlay::Environment(o)), args) => Some(PreparedNativeLaunchOverlay::Instance(o.into_instance_with_extra_args(args).map_err(|_| bad())?)),
        (None, args) => Some(PreparedNativeLaunchOverlay::Instance(NativeInstanceLaunchOverlay::new(
            provider.clone(),
            match mode { SessionMode::Pty => TransportKind::Pty, SessionMode::Acp => TransportKind::Acp, SessionMode::Inline => TransportKind::Pipe },
            Vec::new(),
            args,
        ).map_err(|_| bad())?)),
    })
}

/// Log a provider-error decision; escalations and limits go to core as session signals.
fn provider_error_act(workspace: &str, instance: u64, provider: &str, via: &str, act: crate::provider_error::Action) {
    use crate::provider_error::Action;
    match act {
        Action::Retry { attempt, delay } => tracing::info!(target: "provider_retry", instance_id = instance, provider, via, attempt, max = crate::provider_error::MAX_ATTEMPTS, delay_ms = delay.as_millis() as u64, "provider error: retry scheduled"),
        Action::Limit { found } => {
            tracing::info!(target: "provider_retry", instance_id = instance, provider, via, "provider error: limit, no retry");
            if via == "acp" {
                crate::session_signals::emit(workspace, instance, provider, crate::session_signals::Signal::Limit { hint: found.hint });
            }
        }
        Action::Escalate { found, attempts } => {
            tracing::warn!(target: "provider_retry", instance_id = instance, provider, via, class = found.class.as_str(), code = ?found.code, attempts, "provider error: escalated");
            crate::session_signals::emit(workspace, instance, provider, crate::session_signals::Signal::ProviderError { class: found.class.as_str(), code: found.code, attempts, hint: found.hint });
        }
    }
}

/// Turn trace in the node log for ACP sessions (start, tools, permission asks, end, errors):
/// names and sizes only, never prompt, tool input or output text.
fn trace_acp_turn(address: &SessionAddress, event: &ControlEvent) {
    let id = address.session.instance_id.0;
    let ControlEventKind::ProviderEvent { event: e, .. } = &event.event else { return };
    match e {
        ProviderEvent::TurnStarted { prompt } => tracing::info!(instance_id = id, prompt_chars = prompt.as_deref().map(str::len).unwrap_or(0), "acp turn started"),
        ProviderEvent::ToolStarted { name, .. } => tracing::info!(instance_id = id, tool = %name, "acp tool call started"),
        ProviderEvent::ToolCompleted { is_error, duration_ms, non_execution_kind, .. } => tracing::info!(instance_id = id, is_error, duration_ms = ?duration_ms, not_run = ?non_execution_kind, "acp tool call finished"),
        ProviderEvent::InteractionRequested { interaction_kind, tool_name, options, .. } => tracing::info!(instance_id = id, kind = ?interaction_kind, tool = %tool_name, options = options.len(), "acp permission/interaction requested"),
        ProviderEvent::TurnInterrupted => tracing::info!(instance_id = id, "acp turn interrupted"),
        ProviderEvent::SessionEnded { is_error, stop_reason, .. } => tracing::info!(instance_id = id, is_error, stop_reason = ?stop_reason, "acp turn ended"),
        ProviderEvent::Error { message } => tracing::warn!(instance_id = id, error = %message.chars().take(200).collect::<String>(), "acp provider error"),
        _ => {}
    }
}