halley_core/

field.rs

use crate::cluster::{Cluster, ClusterId, ClusterRemoveMemberOutcome};
use crate::cluster_layout::ClusterCycleDirection;
use crate::decay::DecayLevel;
use crate::stacking::cycle_stacking_members;
use crate::viewport::Viewport;
use crate::visual::{NodeVisual, VisualParams, build_visuals, build_visuals_in_view};

use std::collections::HashMap;

/// A stable identity for anything that exists in the Field.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
pub struct NodeId(u64);

impl NodeId {
    pub fn new(raw: u64) -> Self {
        Self(raw)
    }

    pub fn as_u64(self) -> u64 {
        self.0
    }
}

impl std::fmt::Display for NodeId {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "{}", self.0)
    }
}

/// 2D point / vector in Field coordinates.
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct Vec2 {
    pub x: f32,
    pub y: f32,
}

/// Axis-aligned rectangle.
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct Rect {
    pub min: Vec2,
    pub max: Vec2,
}

impl Rect {
    pub fn width(self) -> f32 {
        self.max.x - self.min.x
    }

    pub fn height(self) -> f32 {
        self.max.y - self.min.y
    }

    pub fn contains(self, p: Vec2) -> bool {
        p.x >= self.min.x && p.x <= self.max.x && p.y >= self.min.y && p.y <= self.max.y
    }

    pub fn intersects(self, other: Rect) -> bool {
        self.min.x <= other.max.x
            && self.max.x >= other.min.x
            && self.min.y <= other.max.y
            && self.max.y >= other.min.y
    }
}

/// Semantic visibility flags.
/// This is NOT rendering; it's "experience-layer existence":
/// - hidden nodes should be skipped by focus/nav/bearings/in_view.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub struct Visibility(u8);

impl Visibility {
    pub const NONE: Self = Self(0);

    /// Hidden because user/system explicitly hid it.
    pub const HIDDEN_EXPLICIT: Self = Self(1 << 0);

    /// Hidden because its cluster is collapsed.
    pub const HIDDEN_BY_CLUSTER: Self = Self(1 << 1);

    /// Node exists in storage, but is currently detached from the experience layer.
    pub const DETACHED: Self = Self(1 << 2);

    pub fn is_hidden(self) -> bool {
        (self.0 & (Self::HIDDEN_EXPLICIT.0 | Self::HIDDEN_BY_CLUSTER.0 | Self::DETACHED.0)) != 0
    }

    pub fn has(self, flag: Self) -> bool {
        (self.0 & flag.0) != 0
    }

    pub fn set(&mut self, flag: Self, on: bool) {
        if on {
            self.0 |= flag.0;
        } else {
            self.0 &= !flag.0;
        }
    }

    pub fn clear(&mut self, flag: Self) {
        self.0 &= !flag.0;
    }
}

/// What kind of thing a node represents.
#[derive(Clone, Debug, PartialEq, Eq)]
pub enum NodeKind {
    Surface,
    Core, // collapsed cluster handle
}

/// Representation state.
#[derive(Clone, Debug, PartialEq, Eq)]
pub enum NodeState {
    Active,
    Drifting,
    Node, // dot with label
    Core, // only meaningful for Core kind
}

/// A Node is the universal "thing" that exists in the Field.
#[derive(Clone, Debug)]
pub struct Node {
    pub id: NodeId,
    pub kind: NodeKind,
    pub state: NodeState,

    pub label: String,

    /// Center position in Field coordinates.
    pub pos: Vec2,

    pub intrinsic_size: Vec2, // "real" size for Active
    pub footprint: Vec2,      // spatial occupancy right now
    pub resize_footprint: Option<Vec2>,

    /// Pinned in place (movement constraint). This was previously called `anchored`.
    pub pinned: bool,

    /// Routing marker: important node that should always be surfaced in navigation
    /// (Bearings/Lens). Does NOT bypass visibility rules.
    pub anchor: bool,

    /// Semantic visibility / participation flags.
    pub visibility: Visibility,

    pub last_touch_ms: u64,
    pub decay: DecayLevel,
}

/// The infinite 2D space containing all Nodes.
pub struct Field {
    next_node: u64,
    nodes: HashMap<NodeId, Node>,

    next_cluster: u64,
    clusters: HashMap<ClusterId, Cluster>,
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum ClusterCreateError {
    TooFewMembers,
    DuplicateMember,
    MissingNode(NodeId),
    AlreadyClustered(NodeId),
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum ClusterAddMemberError {
    MissingCluster,
    MissingNode(NodeId),
    AlreadyClustered(NodeId),
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum ClusterWorkspaceSpawnError {
    MissingCluster,
    ClusterNotActive,
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum ClusterReorderError {
    MissingCluster,
    InvalidMembers,
    UnknownMember(NodeId),
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum RemoveNodeClusterEffect {
    RemovedMember(ClusterId),
    DissolvedCluster(ClusterId),
    RemovedCore(ClusterId),
}

impl Field {
    fn make_surface_node(id: NodeId, label: String, pos: Vec2, size: Vec2) -> Node {
        Node {
            id,
            kind: NodeKind::Surface,
            state: NodeState::Active,
            label,
            pos,
            intrinsic_size: size,
            footprint: size,
            resize_footprint: None,
            pinned: false,
            anchor: false,
            visibility: Visibility::NONE,
            last_touch_ms: 0,
            decay: DecayLevel::Hot,
        }
    }

    pub fn new() -> Self {
        Self {
            next_node: 1,
            nodes: HashMap::new(),
            next_cluster: 1,
            clusters: HashMap::new(),
        }
    }

    pub fn nodes(&self) -> &HashMap<NodeId, Node> {
        &self.nodes
    }

    pub fn node(&self, id: NodeId) -> Option<&Node> {
        if let Some(node) = self.nodes.get(&id) {
            return Some(node);
        }
        self.clusters
            .values()
            .find_map(|cluster| cluster.workspace_member(id))
    }

    pub fn node_mut(&mut self, id: NodeId) -> Option<&mut Node> {
        if self.nodes.contains_key(&id) {
            return self.nodes.get_mut(&id);
        }
        for cluster in self.clusters.values_mut() {
            if let Some(node) = cluster.workspace_member_mut(id) {
                return Some(node);
            }
        }
        None
    }

    /// Spawn a basic Surface node.
    pub fn spawn_surface(&mut self, label: impl Into<String>, pos: Vec2, size: Vec2) -> NodeId {
        let id = NodeId(self.next_node);
        self.next_node += 1;

        let node = Self::make_surface_node(id, label.into(), pos, size);

        self.nodes.insert(id, node);
        id
    }

    pub fn spawn_surface_in_active_cluster(
        &mut self,
        id: ClusterId,
        label: impl Into<String>,
        size: Vec2,
    ) -> Result<NodeId, ClusterWorkspaceSpawnError> {
        let label = label.into();
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return Err(ClusterWorkspaceSpawnError::MissingCluster);
        };
        if !cluster.is_active() {
            return Err(ClusterWorkspaceSpawnError::ClusterNotActive);
        }

        let node_id = NodeId(self.next_node);
        self.next_node += 1;
        if !cluster.add_member(node_id) {
            return Err(ClusterWorkspaceSpawnError::ClusterNotActive);
        }

        let node = Self::make_surface_node(node_id, label, Vec2 { x: 0.0, y: 0.0 }, size);
        if !cluster.insert_workspace_member(node) {
            return Err(ClusterWorkspaceSpawnError::ClusterNotActive);
        }
        Ok(node_id)
    }

    pub fn spawn_surface_in_active_cluster_front(
        &mut self,
        id: ClusterId,
        label: impl Into<String>,
        size: Vec2,
    ) -> Result<NodeId, ClusterWorkspaceSpawnError> {
        let label = label.into();
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return Err(ClusterWorkspaceSpawnError::MissingCluster);
        };
        if !cluster.is_active() {
            return Err(ClusterWorkspaceSpawnError::ClusterNotActive);
        }

        let node_id = NodeId(self.next_node);
        self.next_node += 1;
        if !cluster.add_member_front(node_id) {
            return Err(ClusterWorkspaceSpawnError::ClusterNotActive);
        }

        let node = Self::make_surface_node(node_id, label, Vec2 { x: 0.0, y: 0.0 }, size);
        if !cluster.insert_workspace_member(node) {
            return Err(ClusterWorkspaceSpawnError::ClusterNotActive);
        }
        Ok(node_id)
    }

    /// Remove a node from the Field.
    pub fn remove(&mut self, id: NodeId) -> Option<Node> {
        self.remove_node_cluster_safe(id).map(|(node, _)| node)
    }

    pub fn remove_node_cluster_safe(
        &mut self,
        id: NodeId,
    ) -> Option<(Node, Option<RemoveNodeClusterEffect>)> {
        if let Some(cid) = self.cluster_id_for_member_public(id) {
            let cluster_len = self.cluster(cid)?.members().len();
            let removed = if self.cluster(cid).is_some_and(|cluster| cluster.is_active()) {
                self.clusters
                    .get_mut(&cid)?
                    .active_workspace
                    .as_mut()?
                    .nodes
                    .remove(&id)?
            } else {
                self.nodes.remove(&id)?
            };
            if cluster_len <= 2 {
                self.finish_dissolve_cluster(cid);
                return Some((
                    removed,
                    Some(RemoveNodeClusterEffect::DissolvedCluster(cid)),
                ));
            }

            let cluster = self.clusters.get_mut(&cid)?;
            cluster.remove_member_for_node_removal(id);
            return Some((removed, Some(RemoveNodeClusterEffect::RemovedMember(cid))));
        }

        if let Some(cid) = self.cluster_id_for_core_public(id) {
            let removed = self.nodes.remove(&id)?;
            let was_collapsed = self
                .cluster(cid)
                .is_some_and(|cluster| cluster.is_collapsed());
            if was_collapsed {
                let _ = self.expand_cluster(cid);
            }
            if let Some(cluster) = self.clusters.get_mut(&cid) {
                cluster.core = None;
                cluster.set_collapsed(false);
            }
            return Some((removed, Some(RemoveNodeClusterEffect::RemovedCore(cid))));
        }

        self.nodes.remove(&id).map(|node| (node, None))
    }

    pub fn is_cluster_member(&self, id: NodeId) -> bool {
        self.cluster_id_for_member_public(id).is_some()
    }

    pub fn is_active_cluster_member(&self, id: NodeId) -> bool {
        self.clusters
            .values()
            .any(|cluster| cluster.is_active() && cluster.contains(id))
    }

    pub fn participates_in_field_dynamics(&self, id: NodeId) -> bool {
        self.node(id).is_some() && !self.is_active_cluster_member(id)
    }

    pub fn participates_in_field_activity(&self, id: NodeId) -> bool {
        self.node(id).is_some() && !self.is_cluster_member(id)
    }

    pub fn participates_in_field_view(&self, id: NodeId) -> bool {
        self.node(id).is_some() && !self.is_active_cluster_member(id)
    }

    pub fn node_ids_all(&self) -> Vec<NodeId> {
        let mut ids: Vec<NodeId> = self.nodes.keys().copied().collect();
        for cluster in self.clusters.values() {
            if let Some(active_workspace) = cluster.active_workspace.as_ref() {
                ids.extend(active_workspace.nodes.keys().copied());
            }
        }
        ids
    }

    /// Set/unset movement pinning.
    pub fn set_pinned(&mut self, id: NodeId, on: bool) -> bool {
        let Some(n) = self.node_mut(id) else {
            return false;
        };
        n.pinned = on;
        true
    }

    /// Back-compat alias: previously `anchor()` meant "pinned in place".
    /// Prefer `set_pinned()`. (We keep this to avoid churn in other modules.)
    pub fn anchor(&mut self, id: NodeId, on: bool) -> bool {
        self.set_pinned(id, on)
    }

    /// Set/unset routing anchor marker.
    pub fn set_anchor(&mut self, id: NodeId, on: bool) -> bool {
        let Some(n) = self.node_mut(id) else {
            return false;
        };
        n.anchor = on;
        true
    }

    pub fn is_anchor(&self, id: NodeId) -> bool {
        self.node(id).is_some_and(|n| n.anchor)
    }

    /// Return all experience-visible anchors (stable order).
    pub fn anchors(&self) -> Vec<NodeId> {
        let mut out: Vec<NodeId> = self
            .nodes
            .iter()
            .filter_map(|(&id, n)| {
                (self.participates_in_field_view(id) && self.is_visible(id) && n.anchor)
                    .then_some(id)
            })
            .collect();
        out.sort_by_key(|id| id.as_u64());
        out
    }

    /// Carry a node to a new position (respects pinning).
    pub fn carry(&mut self, id: NodeId, to: Vec2) -> bool {
        let Some(n) = self.node_mut(id) else {
            return false;
        };
        if n.pinned {
            return false;
        }
        n.pos = to;
        true
    }

    /// Axis-aligned bounds in Field space.
    pub fn bounds(&self, id: NodeId) -> Option<Rect> {
        let n = self.node(id)?;
        Some(Self::bounds_for_node(n))
    }

    fn bounds_for_node(n: &Node) -> Rect {
        let half = Vec2 {
            x: n.footprint.x * 0.5,
            y: n.footprint.y * 0.5,
        };
        Rect {
            min: Vec2 {
                x: n.pos.x - half.x,
                y: n.pos.y - half.y,
            },
            max: Vec2 {
                x: n.pos.x + half.x,
                y: n.pos.y + half.y,
            },
        }
    }

    /// Return nodes that intersect the view rect AND are experience-visible.
    pub fn in_view(&self, view: Rect) -> Vec<NodeId> {
        self.nodes
            .keys()
            .copied()
            .filter(|&id| self.participates_in_field_view(id))
            .filter(|&id| self.is_visible(id))
            .filter(|&id| self.bounds(id).is_some_and(|b| b.intersects(view)))
            .collect()
    }

    /// Return all nodes that intersect the view rect (includes hidden nodes).
    pub fn in_view_all(&self, view: Rect) -> Vec<NodeId> {
        self.nodes
            .keys()
            .copied()
            .filter(|&id| self.participates_in_field_view(id))
            .filter(|&id| self.bounds(id).is_some_and(|b| b.intersects(view)))
            .collect()
    }

    /// True iff the node exists and is not hidden by any visibility reason.
    pub fn is_visible(&self, id: NodeId) -> bool {
        self.node(id).is_some_and(|n| !n.visibility.is_hidden())
    }

    /// Explicit hide/show (does not touch cluster-hidden).
    pub fn set_hidden(&mut self, id: NodeId, on: bool) -> bool {
        let Some(n) = self.node_mut(id) else {
            return false;
        };
        n.visibility.set(Visibility::HIDDEN_EXPLICIT, on);
        true
    }

    /// Detach/attach.
    pub fn set_detached(&mut self, id: NodeId, on: bool) -> bool {
        let Some(n) = self.node_mut(id) else {
            return false;
        };
        n.visibility.set(Visibility::DETACHED, on);
        true
    }

    /// Record interaction with a node.
    pub fn touch(&mut self, id: NodeId, now_ms: u64) -> bool {
        if self.is_cluster_member(id) {
            return self.node(id).is_some();
        }
        let Some(n) = self.node_mut(id) else {
            return false;
        };
        n.last_touch_ms = now_ms;
        n.decay = DecayLevel::Hot;

        // Core is a handle; it doesn't switch representation via touch.
        if n.kind != NodeKind::Core {
            n.state = NodeState::Active;
            n.footprint = n.resize_footprint.unwrap_or(n.intrinsic_size);
        }

        true
    }

    /// Apply a decay level to a node by mapping it to representation state.
    pub fn set_decay_level(&mut self, id: NodeId, level: DecayLevel) -> bool {
        if self.cluster_id_for_member_public(id).is_some() {
            return self.node(id).is_some();
        }
        let Some(n) = self.node(id) else {
            return false;
        };

        // Core is a handle; it doesn't decay away.
        if n.kind == NodeKind::Core {
            return true;
        }

        let state = match level {
            DecayLevel::Hot => NodeState::Active,
            DecayLevel::Cold => NodeState::Node,
        };

        if let Some(nm) = self.node_mut(id) {
            nm.decay = level;
        }
        self.set_state(id, state)
    }

    pub fn set_state(&mut self, id: NodeId, state: NodeState) -> bool {
        const DOT: Vec2 = Vec2 { x: 24.0, y: 24.0 };
        const CORE: Vec2 = Vec2 { x: 48.0, y: 48.0 };

        let Some(n) = self.node_mut(id) else {
            return false;
        };

        n.state = state.clone();
        n.footprint = match state {
            NodeState::Active => n.resize_footprint.unwrap_or(n.intrinsic_size),
            NodeState::Drifting => n.footprint,
            NodeState::Node => DOT,
            NodeState::Core => CORE,
        };

        true
    }

    pub fn set_resize_footprint(&mut self, id: NodeId, size: Option<Vec2>) -> bool {
        let Some(n) = self.nodes.get_mut(&id) else {
            return false;
        };

        n.resize_footprint = size;
        if matches!(n.state, NodeState::Active) {
            n.footprint = n.resize_footprint.unwrap_or(n.intrinsic_size);
        }

        true
    }

    pub fn sync_active_footprint_to_intrinsic(&mut self, id: NodeId) -> bool {
        let Some(n) = self.nodes.get_mut(&id) else {
            return false;
        };
        n.resize_footprint = None;
        if matches!(n.state, NodeState::Active) {
            n.footprint = n.intrinsic_size;
        }
        true
    }

    /// Canonical visuals feed: for full behavior, use `build_visuals()` directly.
    /// These helpers delegate to the same implementation to avoid drift.
    pub fn visuals_visible(&self) -> Vec<NodeVisual> {
        let vp = Viewport::new(Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 0.0, y: 0.0 });
        build_visuals(self, &vp, VisualParams::default())
    }

    pub fn visuals_in_view(&self, view: Rect) -> Vec<NodeVisual> {
        let vp = Viewport::new(Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 0.0, y: 0.0 });
        build_visuals_in_view(self, &vp, view, VisualParams::default())
    }

    pub fn cluster(&self, id: ClusterId) -> Option<&Cluster> {
        self.clusters.get(&id)
    }

    pub fn cluster_ids(&self) -> Vec<ClusterId> {
        let mut ids: Vec<_> = self.clusters.keys().copied().collect();
        ids.sort_by_key(|id| id.as_u64());
        ids
    }

    pub fn cluster_mut(&mut self, id: ClusterId) -> Option<&mut Cluster> {
        self.clusters.get_mut(&id)
    }

    pub fn move_member_into_active_cluster_workspace(
        &mut self,
        id: ClusterId,
        member: NodeId,
    ) -> bool {
        let Some(node) = self.nodes.remove(&member) else {
            return false;
        };
        let Some(cluster) = self.clusters.get_mut(&id) else {
            self.nodes.insert(member, node);
            return false;
        };
        if !cluster.is_active()
            || !cluster.contains(member)
            || !cluster.insert_workspace_member(node)
        {
            if let Some(node) = cluster.remove_workspace_member(member) {
                self.nodes.insert(member, node);
            }
            return false;
        }
        true
    }

    pub fn move_member_out_of_active_cluster_workspace(
        &mut self,
        id: ClusterId,
        member: NodeId,
    ) -> bool {
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return false;
        };
        if !cluster.is_active() {
            return false;
        }
        let Some(node) = cluster.remove_workspace_member(member) else {
            return false;
        };
        self.insert_existing(node);
        true
    }

    /// Remove a cluster record (needed for cross-space transfer).
    pub fn remove_cluster(&mut self, id: ClusterId) -> Option<Cluster> {
        self.clusters.remove(&id)
    }

    /// Insert an existing cluster record (needed for cross-space transfer).
    pub fn insert_cluster(&mut self, cluster: Cluster) {
        // keep ids stable; bump next_cluster so future creates don’t collide
        self.next_cluster = self.next_cluster.max(cluster.id.as_u64() + 1);
        self.clusters.insert(cluster.id, cluster);
    }

    pub fn create_cluster(
        &mut self,
        members: Vec<NodeId>,
    ) -> Result<ClusterId, ClusterCreateError> {
        if members.len() < 2 {
            return Err(ClusterCreateError::TooFewMembers);
        }

        if find_duplicate_member(&members).is_some() {
            return Err(ClusterCreateError::DuplicateMember);
        }

        for &member in &members {
            if self.node(member).is_none() {
                return Err(ClusterCreateError::MissingNode(member));
            }
            if self.cluster_id_for_member_public(member).is_some() {
                return Err(ClusterCreateError::AlreadyClustered(member));
            }
        }

        let id = ClusterId::new(self.next_cluster);
        self.next_cluster += 1;

        let mut any_member_pinned = false;
        for &member in &members {
            if self.node(member).is_some_and(|n| n.pinned) {
                any_member_pinned = true;
                let _ = self.set_pinned(member, false);
            }
        }

        let mut cluster = Cluster::new(id, members).ok_or(ClusterCreateError::TooFewMembers)?;
        cluster.pinned = any_member_pinned;
        self.clusters.insert(id, cluster);
        Ok(id)
    }

    pub fn cluster_id_for_core_public(&self, core: NodeId) -> Option<ClusterId> {
        self.clusters
            .iter()
            .find_map(|(&cid, c)| (c.core == Some(core)).then_some(cid))
    }

    pub fn cluster_id_for_member_public(&self, member: NodeId) -> Option<ClusterId> {
        self.clusters
            .iter()
            .find_map(|(&cid, c)| c.contains(member).then_some(cid))
    }

    pub fn add_member_to_cluster(
        &mut self,
        id: ClusterId,
        member: NodeId,
    ) -> Result<(), ClusterAddMemberError> {
        if self.node(member).is_none() {
            return Err(ClusterAddMemberError::MissingNode(member));
        }
        if self.cluster_id_for_member_public(member).is_some() {
            return Err(ClusterAddMemberError::AlreadyClustered(member));
        }
        let is_pinned = self.node(member).is_some_and(|n| n.pinned);
        if is_pinned {
            let _ = self.set_pinned(member, false);
        }

        let Some(cluster) = self.clusters.get_mut(&id) else {
            return Err(ClusterAddMemberError::MissingCluster);
        };
        if !cluster.add_member(member) {
            return Err(ClusterAddMemberError::AlreadyClustered(member));
        }

        if is_pinned {
            cluster.pinned = true;
        }

        Ok(())
    }

    pub fn add_member_to_cluster_front(
        &mut self,
        id: ClusterId,
        member: NodeId,
    ) -> Result<(), ClusterAddMemberError> {
        if self.node(member).is_none() {
            return Err(ClusterAddMemberError::MissingNode(member));
        }
        if self.cluster_id_for_member_public(member).is_some() {
            return Err(ClusterAddMemberError::AlreadyClustered(member));
        }

        let is_pinned = self.node(member).is_some_and(|n| n.pinned);
        if is_pinned {
            let _ = self.set_pinned(member, false);
        }

        let Some(cluster) = self.clusters.get_mut(&id) else {
            return Err(ClusterAddMemberError::MissingCluster);
        };
        if !cluster.add_member_front(member) {
            return Err(ClusterAddMemberError::AlreadyClustered(member));
        }

        if is_pinned {
            cluster.pinned = true;
        }

        Ok(())
    }

    pub fn remove_member_from_cluster(
        &mut self,
        id: ClusterId,
        member: NodeId,
    ) -> Option<ClusterRemoveMemberOutcome> {
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return None;
        };
        cluster.remove_member(member)
    }

    pub fn reorder_cluster_members(
        &mut self,
        id: ClusterId,
        ordered_members: Vec<NodeId>,
    ) -> Result<(), ClusterReorderError> {
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return Err(ClusterReorderError::MissingCluster);
        };
        for &member in &ordered_members {
            if !cluster.contains(member) {
                return Err(ClusterReorderError::UnknownMember(member));
            }
        }
        if !cluster.reorder_members(ordered_members) {
            return Err(ClusterReorderError::InvalidMembers);
        }
        Ok(())
    }

    pub fn promote_cluster_member_to_master(
        &mut self,
        id: ClusterId,
        member: NodeId,
    ) -> Result<(), ClusterReorderError> {
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return Err(ClusterReorderError::MissingCluster);
        };
        if !cluster.contains(member) {
            return Err(ClusterReorderError::UnknownMember(member));
        }
        if !cluster.promote_member_to_master(member) {
            return Err(ClusterReorderError::InvalidMembers);
        }
        Ok(())
    }

    pub fn swap_cluster_overflow_member_with_visible(
        &mut self,
        id: ClusterId,
        overflow_member: NodeId,
        visible_member: NodeId,
        max_stack: usize,
    ) -> bool {
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return false;
        };
        cluster.swap_overflow_member_with_visible(overflow_member, visible_member, max_stack)
    }

    pub fn reorder_cluster_overflow_member(
        &mut self,
        id: ClusterId,
        member: NodeId,
        target_overflow_index: usize,
        max_stack: usize,
    ) -> bool {
        let Some(cluster) = self.clusters.get_mut(&id) else {
            return false;
        };
        cluster.reorder_overflow_member(member, target_overflow_index, max_stack)
    }

    pub fn cycle_cluster_stacking_members(
        &mut self,
        id: ClusterId,
        direction: ClusterCycleDirection,
    ) -> Option<NodeId> {
        let cluster = self.clusters.get_mut(&id)?;
        cycle_stacking_members(&mut cluster.members, direction)
    }

    pub fn dissolve_cluster(&mut self, id: ClusterId) -> bool {
        self.finish_dissolve_cluster(id)
    }

    pub fn activate_cluster_workspace(&mut self, id: ClusterId) -> bool {
        let (members, core_id, already_active) = {
            let Some(cluster) = self.clusters.get(&id) else {
                return false;
            };
            (
                cluster.members().to_vec(),
                cluster.core,
                cluster.is_active(),
            )
        };
        if already_active {
            return true;
        }

        let mut workspace_nodes = HashMap::new();
        for member in &members {
            let Some(node) = self.nodes.remove(member) else {
                return false;
            };
            workspace_nodes.insert(*member, node);
        }

        if let Some(core_id) = core_id {
            let _ = self.nodes.remove(&core_id);
        }

        let Some(cluster) = self.clusters.get_mut(&id) else {
            return false;
        };
        cluster.enter_active();
        for (_, node) in workspace_nodes {
            let _ = cluster.insert_workspace_member(node);
        }
        true
    }

    pub fn deactivate_cluster_workspace(&mut self, id: ClusterId) -> bool {
        let workspace_nodes = {
            let Some(cluster) = self.clusters.get_mut(&id) else {
                return false;
            };
            if !cluster.is_active() {
                return true;
            }
            let Some(active_workspace) = cluster.active_workspace.take() else {
                cluster.exit_active();
                return true;
            };
            cluster.mode = crate::cluster::ClusterMode::Expanded;
            active_workspace.nodes
        };

        for (_, node) in workspace_nodes {
            self.insert_existing(node);
        }
        true
    }

    /// Drag the cluster by its core handle.
    pub fn carry_cluster_by_core(&mut self, core: NodeId, to: Vec2) -> bool {
        if self.cluster_id_for_core_public(core).is_none() {
            return false;
        }
        if self.node(core).is_some_and(|n| n.pinned) {
            return false;
        }
        self.carry(core, to)
    }

    /// Collapse the cluster into a Core node.
    pub fn collapse_cluster(&mut self, id: ClusterId) -> Option<NodeId> {
        let (members, already_collapsed, existing_core) = {
            let c = self.clusters.get(&id)?;
            (c.members().to_vec(), c.is_collapsed(), c.core)
        };

        if already_collapsed {
            return existing_core;
        }

        if self.cluster(id).is_some_and(|cluster| cluster.is_active()) {
            let _ = self.deactivate_cluster_workspace(id);
        }

        for m in &members {
            self.set_state(*m, NodeState::Node);
            if let Some(n) = self.node_mut(*m) {
                n.visibility.set(Visibility::HIDDEN_BY_CLUSTER, true);
            }
        }

        let mut sum = Vec2 { x: 0.0, y: 0.0 };
        for m in &members {
            let n = self.node(*m)?;
            sum.x += n.pos.x;
            sum.y += n.pos.y;
        }
        let k = members.len() as f32;
        let core_pos = Vec2 {
            x: sum.x / k,
            y: sum.y / k,
        };

        let core_id = match existing_core {
            Some(cid) => {
                if !self.nodes.contains_key(&cid) {
                    let core = Node {
                        id: cid,
                        kind: NodeKind::Core,
                        state: NodeState::Core,
                        label: format!("Cluster {}", id.as_u64()),
                        pos: core_pos,
                        intrinsic_size: Vec2 { x: 48.0, y: 48.0 },
                        footprint: Vec2 { x: 48.0, y: 48.0 },
                        resize_footprint: None,
                        pinned: false,
                        anchor: false,
                        visibility: Visibility::NONE,
                        last_touch_ms: 0,
                        decay: DecayLevel::Hot,
                    };
                    self.nodes.insert(cid, core);
                }
                cid
            }
            None => {
                let cid = NodeId::new(self.next_node);
                self.next_node += 1;

                let core = Node {
                    id: cid,
                    kind: NodeKind::Core,
                    state: NodeState::Core,
                    label: format!("Cluster {}", id.as_u64()),
                    pos: core_pos,
                    intrinsic_size: Vec2 { x: 48.0, y: 48.0 },
                    footprint: Vec2 { x: 48.0, y: 48.0 },
                    resize_footprint: None,
                    pinned: false,
                    anchor: false,
                    visibility: Visibility::NONE,
                    last_touch_ms: 0,
                    decay: DecayLevel::Hot,
                };
                self.nodes.insert(cid, core);
                cid
            }
        };

        if let Some(n) = self.node_mut(core_id) {
            n.pos = core_pos;
            n.kind = NodeKind::Core;
            n.state = NodeState::Core;
            n.footprint = Vec2 { x: 48.0, y: 48.0 };
            n.intrinsic_size = Vec2 { x: 48.0, y: 48.0 };

            n.visibility.clear(Visibility::HIDDEN_BY_CLUSTER);
            n.visibility.clear(Visibility::DETACHED);
        }

        let c = self.clusters.get_mut(&id)?;
        let pinned = c.pinned;
        c.set_collapsed(true);
        c.core = Some(core_id);

        if let Some(n) = self.node_mut(core_id) {
            n.pinned = pinned;
        }

        Some(core_id)
    }

    /// Expand the cluster.
    pub fn expand_cluster(&mut self, id: ClusterId) -> bool {
        if self.cluster(id).is_some_and(|cluster| cluster.is_active()) {
            return true;
        }
        let members = {
            let c = match self.clusters.get(&id) {
                Some(c) => c,
                None => return false,
            };
            if !c.is_collapsed() {
                return true;
            }
            c.members().to_vec()
        };

        for m in members {
            self.set_state(m, NodeState::Active);
            if let Some(n) = self.node_mut(m) {
                n.visibility.set(Visibility::HIDDEN_BY_CLUSTER, false);
            }
        }

        if let Some(c) = self.clusters.get_mut(&id) {
            c.set_collapsed(false);
        }
        true
    }

    pub fn insert_existing(&mut self, node: Node) {
        // keep ids stable; bump next_node if needed so future spawns don’t collide
        self.next_node = self.next_node.max(node.id.as_u64() + 1);
        self.nodes.insert(node.id, node);
    }

    pub fn clusters_iter(&self) -> impl Iterator<Item = &Cluster> {
        self.clusters.values()
    }

    fn finish_dissolve_cluster(&mut self, id: ClusterId) -> bool {
        let Some(cluster) = self.clusters.remove(&id) else {
            return false;
        };

        if let Some(active_workspace) = cluster.active_workspace {
            for (_, mut node) in active_workspace.nodes {
                node.visibility.clear(Visibility::HIDDEN_BY_CLUSTER);
                node.visibility.clear(Visibility::DETACHED);
                node.state = NodeState::Active;
                node.footprint = node.resize_footprint.unwrap_or(node.intrinsic_size);
                self.insert_existing(node);
            }
        } else {
            for member in cluster.members() {
                let _ = self.set_state(*member, NodeState::Active);
                if let Some(node) = self.node_mut(*member) {
                    node.visibility.clear(Visibility::HIDDEN_BY_CLUSTER);
                }
            }
        }

        if let Some(core_id) = cluster.core {
            let _ = self.nodes.remove(&core_id);
        }

        true
    }
}

fn find_duplicate_member(members: &[NodeId]) -> Option<NodeId> {
    let mut seen = std::collections::HashSet::new();
    for member in members {
        if !seen.insert(*member) {
            return Some(*member);
        }
    }
    None
}

impl Default for Field {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn cluster_create_rejects_missing_nodes() {
        let mut f = Field::new();
        let missing = NodeId::new(999);
        assert_eq!(
            f.create_cluster(vec![missing]),
            Err(ClusterCreateError::TooFewMembers)
        );
    }

    #[test]
    fn cluster_create_rejects_singletons() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert_eq!(
            f.create_cluster(vec![a]),
            Err(ClusterCreateError::TooFewMembers)
        );
    }

    #[test]
    fn cluster_create_rejects_duplicate_members() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert_eq!(
            f.create_cluster(vec![a, a, b]),
            Err(ClusterCreateError::DuplicateMember)
        );
    }

    #[test]
    fn collapse_cluster_creates_core_and_shrinks_members() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let core = f.collapse_cluster(cid).unwrap();

        assert_eq!(f.node(a).unwrap().state, NodeState::Node);
        assert_eq!(f.node(b).unwrap().state, NodeState::Node);
        assert_eq!(f.node(a).unwrap().footprint, Vec2 { x: 24.0, y: 24.0 });

        assert!(
            f.node(a)
                .unwrap()
                .visibility
                .has(Visibility::HIDDEN_BY_CLUSTER)
        );
        assert!(
            f.node(b)
                .unwrap()
                .visibility
                .has(Visibility::HIDDEN_BY_CLUSTER)
        );
        assert!(!f.is_visible(a));
        assert!(!f.is_visible(b));

        let cn = f.node(core).unwrap();
        assert_eq!(cn.kind, NodeKind::Core);
        assert_eq!(cn.state, NodeState::Core);
        assert_eq!(cn.footprint, Vec2 { x: 48.0, y: 48.0 });
        assert!(f.is_visible(core));

        let c = f.cluster(cid).unwrap();
        assert!(c.is_collapsed());
        assert_eq!(c.core, Some(core));
    }

    #[test]
    fn collapsing_active_cluster_restores_visible_core_to_field_queries() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: -20.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });
        let b = f.spawn_surface("B", Vec2 { x: 20.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });
        let c = f.spawn_surface("C", Vec2 { x: 200.0, y: 0.0 }, Vec2 { x: 80.0, y: 40.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let first_core = f.collapse_cluster(cid).unwrap();
        assert!(f.activate_cluster_workspace(cid));
        assert!(f.node(first_core).is_none());

        let core = f.collapse_cluster(cid).unwrap();
        assert_eq!(core, first_core);

        let core_node = f.node(core).unwrap();
        assert_eq!(core_node.kind, NodeKind::Core);
        assert_eq!(core_node.state, NodeState::Core);
        assert!(f.nodes().contains_key(&core));
        assert!(f.participates_in_field_view(core));
        assert!(f.is_visible(core));

        let view = Rect {
            min: Vec2 {
                x: -100.0,
                y: -100.0,
            },
            max: Vec2 { x: 100.0, y: 100.0 },
        };

        assert!(f.in_view(view).contains(&core));
        assert!(f.in_view_all(view).contains(&core));
        assert!(f.visuals_visible().iter().any(|visual| visual.id == core));
        assert!(
            f.visuals_in_view(view)
                .iter()
                .any(|visual| visual.id == core)
        );
        assert!(!f.in_view(view).contains(&a));
        assert!(!f.in_view(view).contains(&b));
        assert!(!f.is_visible(a));
        assert!(!f.is_visible(b));
        assert!(f.is_visible(c));
    }

    #[test]
    fn expand_cluster_restores_members_active_and_visible() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        f.collapse_cluster(cid).unwrap();

        assert!(f.expand_cluster(cid));

        assert_eq!(f.node(a).unwrap().state, NodeState::Active);
        assert_eq!(f.node(b).unwrap().state, NodeState::Active);
        assert_eq!(f.node(a).unwrap().footprint, Vec2 { x: 100.0, y: 50.0 });

        assert!(
            !f.node(a)
                .unwrap()
                .visibility
                .has(Visibility::HIDDEN_BY_CLUSTER)
        );
        assert!(f.is_visible(a));

        let c = f.cluster(cid).unwrap();
        assert!(!c.is_collapsed());
    }

    #[test]
    fn carry_respects_pinned() {
        let mut f = Field::new();
        let id = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert!(f.carry(id, Vec2 { x: 5.0, y: 5.0 }));
        assert_eq!(f.node(id).unwrap().pos, Vec2 { x: 5.0, y: 5.0 });

        assert!(f.set_pinned(id, true));
        assert!(!f.carry(id, Vec2 { x: 9.0, y: 9.0 }));
        assert_eq!(f.node(id).unwrap().pos, Vec2 { x: 5.0, y: 5.0 });
    }

    #[test]
    fn in_view_finds_intersections() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let _b = f.spawn_surface("B", Vec2 { x: 100.0, y: 100.0 }, Vec2 { x: 10.0, y: 10.0 });

        let view = Rect {
            min: Vec2 { x: -20.0, y: -20.0 },
            max: Vec2 { x: 20.0, y: 20.0 },
        };

        let ids = f.in_view_all(view);
        assert_eq!(ids, vec![a]);
    }

    #[test]
    fn in_view_skips_hidden_nodes() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert!(f.set_hidden(a, true));

        let view = Rect {
            min: Vec2 { x: -20.0, y: -20.0 },
            max: Vec2 { x: 20.0, y: 20.0 },
        };

        let ids = f.in_view(view);
        assert!(ids.is_empty());
        assert!(!f.is_visible(a));
    }

    #[test]
    fn set_state_changes_footprint() {
        let mut f = Field::new();
        let id = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 100.0, y: 50.0 });

        assert_eq!(f.node(id).unwrap().footprint, Vec2 { x: 100.0, y: 50.0 });

        assert!(f.set_state(id, NodeState::Node));
        assert_eq!(f.node(id).unwrap().footprint, Vec2 { x: 24.0, y: 24.0 });

        assert!(f.set_state(id, NodeState::Active));
        assert_eq!(f.node(id).unwrap().footprint, Vec2 { x: 100.0, y: 50.0 });
    }

    #[test]
    fn touch_sets_last_touch_and_wakes_node() {
        let mut f = Field::new();
        let id = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert!(f.set_decay_level(id, DecayLevel::Cold));
        assert_eq!(f.node(id).unwrap().state, NodeState::Node);

        assert!(f.touch(id, 1234));
        let n = f.node(id).unwrap();
        assert_eq!(n.last_touch_ms, 1234);
        assert_eq!(n.decay, DecayLevel::Hot);
        assert_eq!(n.state, NodeState::Active);
    }

    #[test]
    fn set_decay_level_maps_to_representation_state() {
        let mut f = Field::new();
        let id = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert!(f.set_decay_level(id, DecayLevel::Hot));
        assert_eq!(f.node(id).unwrap().decay, DecayLevel::Hot);
        assert_eq!(f.node(id).unwrap().state, NodeState::Active);

        assert!(f.set_decay_level(id, DecayLevel::Cold));
        assert_eq!(f.node(id).unwrap().decay, DecayLevel::Cold);
        assert_eq!(f.node(id).unwrap().state, NodeState::Node);
    }

    #[test]
    fn core_ignores_set_decay_level() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let core = f.collapse_cluster(cid).unwrap();

        assert!(f.set_decay_level(core, DecayLevel::Cold));
        let n = f.node(core).unwrap();
        assert_eq!(n.kind, NodeKind::Core);
        assert_eq!(n.state, NodeState::Core);
    }

    #[test]
    fn carry_cluster_by_core_moves_only_core_representation() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let core = f.collapse_cluster(cid).unwrap();

        let core_before = f.node(core).unwrap().pos;
        let a_before = f.node(a).unwrap().pos;
        let b_before = f.node(b).unwrap().pos;

        assert!(f.carry_cluster_by_core(core, Vec2 { x: 100.0, y: 50.0 }));

        let core_after = f.node(core).unwrap().pos;
        let a_after = f.node(a).unwrap().pos;
        let b_after = f.node(b).unwrap().pos;

        assert_eq!(core_after, Vec2 { x: 100.0, y: 50.0 });
        assert_ne!(core_after, core_before);
        assert_eq!(a_after, a_before);
        assert_eq!(b_after, b_before);
    }

    #[test]
    fn carry_cluster_by_core_respects_pinned() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let core = f.collapse_cluster(cid).unwrap();

        let core_pos = f.node(core).unwrap().pos;
        let a_pos = f.node(a).unwrap().pos;
        let b_pos = f.node(b).unwrap().pos;

        assert!(f.set_pinned(core, true));
        assert!(!f.carry_cluster_by_core(core, Vec2 { x: 999.0, y: 999.0 }));

        assert_eq!(f.node(core).unwrap().pos, core_pos);
        assert_eq!(f.node(a).unwrap().pos, a_pos);
        assert_eq!(f.node(b).unwrap().pos, b_pos);
    }

    #[test]
    fn visuals_skip_hidden_nodes() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 50.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        assert!(f.set_hidden(b, true));

        let vis = f.visuals_visible();
        assert_eq!(vis.len(), 1);
        assert_eq!(vis[0].id, a);
    }

    #[test]
    fn remove_member_requires_explicit_dissolve_for_two_member_cluster() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();

        assert_eq!(
            f.remove_member_from_cluster(cid, a),
            Some(ClusterRemoveMemberOutcome::RequiresDissolve)
        );
        let cluster = f.cluster(cid).unwrap();
        assert_eq!(cluster.members(), &[a, b]);
        assert_eq!(cluster.master(), a);
    }

    #[test]
    fn raw_member_removal_dissolves_two_member_cluster_without_leaking_singleton() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let core = f.collapse_cluster(cid).unwrap();

        let (_, effect) = f.remove_node_cluster_safe(a).unwrap();

        assert_eq!(effect, Some(RemoveNodeClusterEffect::DissolvedCluster(cid)));
        assert!(f.cluster(cid).is_none());
        assert!(f.node(core).is_none());
        assert!(f.node(a).is_none());
        assert!(f.node(b).is_some());
        assert!(f.is_visible(b));
    }

    #[test]
    fn raw_member_removal_keeps_larger_cluster_valid() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let c = f.spawn_surface("C", Vec2 { x: 20.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b, c]).unwrap();

        let (_, effect) = f.remove_node_cluster_safe(c).unwrap();

        assert_eq!(effect, Some(RemoveNodeClusterEffect::RemovedMember(cid)));
        let cluster = f.cluster(cid).unwrap();
        assert_eq!(cluster.members(), &[a, b]);
    }

    #[test]
    fn promote_and_reorder_preserve_explicit_master_contract() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let c = f.spawn_surface("C", Vec2 { x: 20.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b, c]).unwrap();
        f.promote_cluster_member_to_master(cid, c).unwrap();
        assert_eq!(f.cluster(cid).unwrap().members(), &[c, a, b]);
        assert_eq!(f.cluster(cid).unwrap().master(), c);

        f.reorder_cluster_members(cid, vec![b, c, a]).unwrap();
        assert_eq!(f.cluster(cid).unwrap().members(), &[b, c, a]);
        assert_eq!(f.cluster(cid).unwrap().master(), b);
        assert_eq!(f.cluster(cid).unwrap().secondaries(), &[c, a]);
    }

    #[test]
    fn active_cluster_members_do_not_participate_in_field_dynamics() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        assert!(f.activate_cluster_workspace(cid));

        assert!(f.is_active_cluster_member(a));
        assert!(!f.participates_in_field_dynamics(a));
        assert!(!f.participates_in_field_activity(a));
    }

    #[test]
    fn spawning_into_active_cluster_workspace_bypasses_field_storage() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        assert!(f.activate_cluster_workspace(cid));

        let c = f
            .spawn_surface_in_active_cluster(cid, "C", Vec2 { x: 30.0, y: 20.0 })
            .unwrap();

        assert!(f.node(c).is_some());
        assert!(!f.nodes().contains_key(&c));
        assert!(f.is_active_cluster_member(c));
        assert_eq!(f.cluster(cid).unwrap().members(), &[a, b, c]);
    }

    #[test]
    fn spawning_into_active_cluster_workspace_front_inserts_new_member_first() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        assert!(f.activate_cluster_workspace(cid));

        let c = f
            .spawn_surface_in_active_cluster_front(cid, "C", Vec2 { x: 30.0, y: 20.0 })
            .unwrap();

        assert_eq!(f.cluster(cid).unwrap().members(), &[c, a, b]);
    }

    #[test]
    fn adding_member_to_cluster_front_inserts_new_member_first() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let c = f.spawn_surface("C", Vec2 { x: 20.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        f.add_member_to_cluster_front(cid, c).unwrap();

        assert_eq!(f.cluster(cid).unwrap().members(), &[c, a, b]);
    }

    #[test]
    fn active_cluster_workspace_members_support_state_and_position_updates() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        assert!(f.activate_cluster_workspace(cid));

        assert!(f.set_state(a, NodeState::Node));
        assert!(f.carry(a, Vec2 { x: 400.0, y: 300.0 }));

        let node = f.node(a).unwrap();
        assert_eq!(node.state, NodeState::Node);
        assert_eq!(node.pos, Vec2 { x: 400.0, y: 300.0 });
        assert!(f.bounds(a).is_some());
    }

    #[test]
    fn cluster_workspace_layout_only_tiles_first_four_members() {
        let mut f = Field::new();
        let members = (0..6)
            .map(|index| {
                f.spawn_surface(
                    format!("N{}", index),
                    Vec2 {
                        x: index as f32 * 10.0,
                        y: 0.0,
                    },
                    Vec2 { x: 10.0, y: 10.0 },
                )
            })
            .collect::<Vec<_>>();

        let cid = f.create_cluster(members.clone()).unwrap();
        let cluster = f.cluster(cid).unwrap();
        let layout = cluster.workspace_layout(
            crate::tiling::Rect {
                x: 0.0,
                y: 0.0,
                w: 1000.0,
                h: 600.0,
            },
            3,
        );

        assert_eq!(cluster.visible_members(3), &members[..4]);
        assert_eq!(cluster.overflow_members(3), &members[4..]);
        assert_eq!(layout.tiles.len(), 4);
        assert!(
            layout
                .tiles
                .iter()
                .all(|tile| members[..4].contains(&tile.id))
        );
    }

    #[test]
    fn swapping_overflow_member_with_visible_preserves_queue_order() {
        let mut f = Field::new();
        let members = (0..6)
            .map(|index| {
                f.spawn_surface(
                    format!("N{}", index),
                    Vec2 {
                        x: index as f32 * 10.0,
                        y: 0.0,
                    },
                    Vec2 { x: 10.0, y: 10.0 },
                )
            })
            .collect::<Vec<_>>();

        let cid = f.create_cluster(members.clone()).unwrap();
        assert!(f.swap_cluster_overflow_member_with_visible(cid, members[4], members[2], 3));

        let cluster = f.cluster(cid).unwrap();
        assert_eq!(
            cluster.members(),
            &[
                members[0], members[1], members[4], members[3], members[2], members[5]
            ]
        );
        assert_eq!(
            cluster.visible_members(3),
            &[members[0], members[1], members[4], members[3]]
        );
        assert_eq!(cluster.overflow_members(3), &[members[2], members[5]]);
    }

    #[test]
    fn reordering_overflow_members_updates_queue_order_only() {
        let mut f = Field::new();
        let members = (0..7)
            .map(|index| {
                f.spawn_surface(
                    format!("N{}", index),
                    Vec2 {
                        x: index as f32 * 10.0,
                        y: 0.0,
                    },
                    Vec2 { x: 10.0, y: 10.0 },
                )
            })
            .collect::<Vec<_>>();

        let cid = f.create_cluster(members.clone()).unwrap();
        assert!(f.reorder_cluster_overflow_member(cid, members[6], 0, 3));

        let cluster = f.cluster(cid).unwrap();
        assert_eq!(cluster.visible_members(3), &members[..4]);
        assert_eq!(
            cluster.overflow_members(3),
            &[members[6], members[4], members[5]]
        );
    }

    #[test]
    fn touch_is_noop_for_cluster_members() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 10.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        let before = f.node(a).unwrap().last_touch_ms;

        assert!(f.touch(a, 9999));
        assert_eq!(f.node(a).unwrap().last_touch_ms, before);

        assert!(f.activate_cluster_workspace(cid));
        assert!(f.touch(a, 12345));
        assert_eq!(f.node(a).unwrap().last_touch_ms, before);
    }

    #[test]
    fn active_cluster_members_are_excluded_from_field_view_queries() {
        let mut f = Field::new();
        let a = f.spawn_surface("A", Vec2 { x: 0.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let b = f.spawn_surface("B", Vec2 { x: 20.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });
        let c = f.spawn_surface("C", Vec2 { x: 200.0, y: 0.0 }, Vec2 { x: 10.0, y: 10.0 });

        let cid = f.create_cluster(vec![a, b]).unwrap();
        assert!(f.activate_cluster_workspace(cid));

        let view = Rect {
            min: Vec2 { x: -50.0, y: -50.0 },
            max: Vec2 { x: 50.0, y: 50.0 },
        };

        assert!(!f.in_view(view).contains(&a));
        assert!(!f.in_view(view).contains(&b));
        assert_eq!(f.in_view(view), vec![]);
        assert_eq!(f.in_view_all(view), vec![]);
        assert_eq!(f.visuals_visible().len(), 1);
        assert_eq!(f.visuals_visible()[0].id, c);
    }
}