Skip to main content

gkit_core/
config.rs

1//! Resolve a repo's base/integration branch — the single branch gkit treats as
2//! "the trunk" for the correct-branch check. Replaces the zsh's hardcoded
3//! `dev|main|master`. Resolution order:
4//!   1. explicit CLI `--base-branch`
5//!   2. per-repo `git config gkit.baseBranch`
6//!   3. a remote-tracking branch — `origin/main`, else `origin/master`
7//!   4. otherwise **unresolved**: a base couldn't be determined (e.g. a
8//!      single-branch clone of a feature branch). The correct-branch check then
9//!      fails rather than silently passing against the wrong base.
10
11use crate::git::Git;
12use std::collections::HashSet;
13use std::path::Path;
14
15/// Where a resolved base branch came from — surfaced by `logoff --verbose`.
16#[derive(Debug, Clone, Copy, PartialEq, Eq)]
17pub enum BaseSource {
18    /// Explicit CLI `--base-branch`.
19    Flag,
20    /// `git config gkit.baseBranch`.
21    Config,
22    /// Derived from a remote-tracking branch (`origin/main`, else `origin/master`).
23    Remote,
24    /// Could not be determined from any source.
25    Unresolved,
26}
27
28/// A base branch plus where it was resolved from. `name` is `None` only when
29/// `source` is [`BaseSource::Unresolved`].
30#[derive(Debug, Clone)]
31pub struct ResolvedBase {
32    pub name: Option<String>,
33    pub source: BaseSource,
34}
35
36impl ResolvedBase {
37    fn flag(name: &str) -> Self {
38        Self {
39            name: Some(name.to_string()),
40            source: BaseSource::Flag,
41        }
42    }
43    fn config(name: &str) -> Self {
44        Self {
45            name: Some(name.to_string()),
46            source: BaseSource::Config,
47        }
48    }
49    fn remote(name: &str) -> Self {
50        Self {
51            name: Some(name.to_string()),
52            source: BaseSource::Remote,
53        }
54    }
55    /// The unresolved sentinel: no base, fails the correct-branch check.
56    pub fn unresolved() -> Self {
57        Self {
58            name: None,
59            source: BaseSource::Unresolved,
60        }
61    }
62
63    /// Human-readable "branch (how it was derived)" for `logoff --verbose`.
64    pub fn describe(&self) -> String {
65        match (&self.name, self.source) {
66            (Some(b), BaseSource::Flag) => format!("{b} (from --base-branch)"),
67            (Some(b), BaseSource::Config) => format!("{b} (from git config gkit.baseBranch)"),
68            (Some(b), BaseSource::Remote) => format!("{b} (derived from remote origin/{b})"),
69            _ => "UNRESOLVED — gkit.baseBranch unset and no origin/main or origin/master \
70                  (correct-branch can't be checked)"
71                .to_string(),
72        }
73    }
74}
75
76/// Resolve the base branch for the `logoff` correct-branch check (see module docs).
77pub fn resolve_base(git: &dyn Git, dir: &Path, cli_override: Option<&str>) -> ResolvedBase {
78    if let Some(b) = cli_override {
79        let b = b.trim();
80        if !b.is_empty() {
81            return ResolvedBase::flag(b);
82        }
83    }
84    let cfg = git.run(dir, &["config", "--get", "gkit.baseBranch"]);
85    if cfg.success && !cfg.trimmed().is_empty() {
86        return ResolvedBase::config(cfg.trimmed());
87    }
88    // Derive from remote-tracking branches: main first, then master. A single-branch
89    // clone of a feature branch has neither -> unresolved (correct-branch fails).
90    let remotes: HashSet<String> = git
91        .run(
92            dir,
93            &[
94                "for-each-ref",
95                "--format=%(refname:short)",
96                "refs/remotes/origin/*",
97            ],
98        )
99        .stdout
100        .lines()
101        .filter_map(|l| l.trim().strip_prefix("origin/").map(str::to_string))
102        .collect();
103    for cand in ["main", "master"] {
104        if remotes.contains(cand) {
105            return ResolvedBase::remote(cand);
106        }
107    }
108    ResolvedBase::unresolved()
109}
110
111/// Read `gkit.solo` (a bool) for a repo. Default `false` (team workflow) when
112/// unset or unparsable. When `true`, the correct-branch check additionally flags
113/// sitting on an integration branch while feature branches exist on the remote —
114/// meaningful for a solo developer where every remote branch is their own.
115/// Honors git's config layering: `--global` for a personal default, repo config
116/// to override. Set manually (e.g. `git config gkit.solo true`) — `gkit clone`
117/// does not stamp it.
118pub fn resolve_solo(git: &dyn Git, dir: &Path) -> bool {
119    let o = git.run(dir, &["config", "--get", "--bool", "gkit.solo"]);
120    o.success && o.trimmed() == "true"
121}
122
123/// Current branch, or `None` if HEAD is detached (no symbolic ref).
124pub fn current_branch_opt(git: &dyn Git, dir: &Path) -> Option<String> {
125    let o = git.run(dir, &["symbolic-ref", "--short", "HEAD"]);
126    if o.success {
127        Some(o.trimmed().to_string())
128    } else {
129        None
130    }
131}
132
133/// Resolve the base branch to *switch to* (for stmb). Unlike [`resolve_base`]
134/// this never falls back to HEAD (HEAD is the feature branch here): CLI override →
135/// `gkit.baseBranch` → `origin/HEAD` default branch. `None` if undeterminable.
136pub fn resolve_switch_base(
137    git: &dyn Git,
138    dir: &Path,
139    cli_override: Option<&str>,
140) -> Option<String> {
141    if let Some(b) = cli_override {
142        if !b.trim().is_empty() {
143            return Some(b.trim().to_string());
144        }
145    }
146    let cfg = git.run(dir, &["config", "--get", "gkit.baseBranch"]);
147    if cfg.success && !cfg.trimmed().is_empty() {
148        return Some(cfg.trimmed().to_string());
149    }
150    let head = git.run(
151        dir,
152        &["symbolic-ref", "--short", "refs/remotes/origin/HEAD"],
153    );
154    if head.success {
155        return head.trimmed().strip_prefix("origin/").map(str::to_string);
156    }
157    None
158}
159
160#[cfg(test)]
161mod tests {
162    use super::*;
163    use crate::git::test_support::FakeGit;
164    use std::path::Path;
165
166    fn d() -> &'static Path {
167        Path::new("/x")
168    }
169
170    /// `for-each-ref refs/remotes/origin/*` stub listing the given remote branches.
171    fn with_remotes(g: FakeGit, branches: &[&str]) -> FakeGit {
172        let listing = branches
173            .iter()
174            .map(|b| format!("origin/{b}"))
175            .collect::<Vec<_>>()
176            .join("\n");
177        g.ok(
178            "for-each-ref --format=%(refname:short) refs/remotes/origin/*",
179            &listing,
180        )
181    }
182
183    #[test]
184    fn cli_override_wins() {
185        let g = FakeGit::new().ok("config --get gkit.baseBranch", "dev");
186        let r = resolve_base(&g, d(), Some("main"));
187        assert_eq!(r.name.as_deref(), Some("main"));
188        assert_eq!(r.source, BaseSource::Flag);
189    }
190
191    #[test]
192    fn falls_back_to_git_config() {
193        let g = FakeGit::new().ok("config --get gkit.baseBranch", "dev");
194        let r = resolve_base(&g, d(), None);
195        assert_eq!(r.name.as_deref(), Some("dev"));
196        assert_eq!(r.source, BaseSource::Config);
197    }
198
199    #[test]
200    fn derives_main_from_remote_when_config_unset() {
201        let g = with_remotes(
202            FakeGit::new().fail("config --get gkit.baseBranch"),
203            &["feature-x", "main", "master"],
204        );
205        let r = resolve_base(&g, d(), None);
206        // main wins over master.
207        assert_eq!(r.name.as_deref(), Some("main"));
208        assert_eq!(r.source, BaseSource::Remote);
209    }
210
211    #[test]
212    fn derives_master_when_no_main() {
213        let g = with_remotes(
214            FakeGit::new().fail("config --get gkit.baseBranch"),
215            &["master", "feature-y"],
216        );
217        let r = resolve_base(&g, d(), None);
218        assert_eq!(r.name.as_deref(), Some("master"));
219        assert_eq!(r.source, BaseSource::Remote);
220    }
221
222    #[test]
223    fn unresolved_when_no_config_and_no_main_master() {
224        // e.g. a single-branch clone of a feature branch.
225        let g = with_remotes(
226            FakeGit::new().fail("config --get gkit.baseBranch"),
227            &["feature-only"],
228        );
229        let r = resolve_base(&g, d(), None);
230        assert_eq!(r.name, None);
231        assert_eq!(r.source, BaseSource::Unresolved);
232    }
233
234    #[test]
235    fn resolve_solo_defaults_false_and_reads_bool() {
236        // unset / failing config -> false
237        assert!(!resolve_solo(
238            &FakeGit::new().fail("config --get --bool gkit.solo"),
239            d()
240        ));
241        // explicit true / false
242        assert!(resolve_solo(
243            &FakeGit::new().ok("config --get --bool gkit.solo", "true"),
244            d()
245        ));
246        assert!(!resolve_solo(
247            &FakeGit::new().ok("config --get --bool gkit.solo", "false"),
248            d()
249        ));
250    }
251
252    #[test]
253    fn current_branch_opt_detects_detached() {
254        let on = FakeGit::new().ok("symbolic-ref --short HEAD", "feat");
255        assert_eq!(current_branch_opt(&on, d()), Some("feat".into()));
256        let detached = FakeGit::new().fail("symbolic-ref --short HEAD");
257        assert_eq!(current_branch_opt(&detached, d()), None);
258    }
259
260    #[test]
261    fn switch_base_uses_origin_head_not_current() {
262        // config unset -> use origin/HEAD default, NOT the (feature) HEAD
263        let g = FakeGit::new().fail("config --get gkit.baseBranch").ok(
264            "symbolic-ref --short refs/remotes/origin/HEAD",
265            "origin/dev",
266        );
267        assert_eq!(resolve_switch_base(&g, d(), None), Some("dev".into()));
268        // override still wins
269        assert_eq!(
270            resolve_switch_base(&g, d(), Some("main")),
271            Some("main".into())
272        );
273    }
274}