git_internal/internal/pack/

cache_object.rs

//! Cache object representation plus disk-backed serialization helpers used by the pack decoder to
//! bound memory while still serving delta reconstruction quickly.

use std::{
    borrow::Cow,
    fs, io,
    io::Write,
    ops::Deref,
    path::{Path, PathBuf},
    sync::{
        Arc,
        atomic::{AtomicBool, AtomicUsize, Ordering},
    },
};

use lru_mem::{HeapSize, MemSize};
use rkyv::{
    Archive, Deserialize as RkyvDeserialize, Serialize as RkyvSerialize,
    api::high::{HighSerializer, HighValidator},
    bytecheck::CheckBytes,
    de::Pool,
    rancor::{Error as RkyvError, Strategy},
    ser::allocator::ArenaHandle,
    util::AlignedVec,
};
use tempfile::NamedTempFile;
use threadpool::ThreadPool;

use crate::{
    hash::ObjectHash,
    internal::{
        metadata::{EntryMeta, MetaAttached},
        object::types::ObjectType,
        pack::{entry::Entry, utils},
    },
};

// static CACHE_OBJS_MEM_SIZE: AtomicUsize = AtomicUsize::new(0);

/// file load&store trait
pub trait FileLoadStore: Sized {
    fn f_load(path: &Path) -> Result<Self, io::Error>;
    fn f_save(&self, path: &Path) -> Result<(), io::Error>;
}

fn write_bytes_atomically(path: &Path, data: &[u8]) -> Result<(), io::Error> {
    if path.exists() {
        return Ok(());
    }
    let dir = path
        .parent()
        .filter(|parent| !parent.as_os_str().is_empty())
        .unwrap_or_else(|| Path::new("."));

    let mut temp_file = NamedTempFile::new_in(dir)?;
    temp_file.write_all(data)?;

    match temp_file.persist_noclobber(path) {
        Ok(_persisted) => Ok(()),
        Err(err) if err.error.kind() == io::ErrorKind::AlreadyExists && path.exists() => Ok(()),
        Err(err) => Err(err.error),
    }
}

impl<T> FileLoadStore for T
where
    T: Archive,
    T: for<'a> RkyvSerialize<HighSerializer<AlignedVec, ArenaHandle<'a>, RkyvError>>,
    T::Archived: for<'a> CheckBytes<HighValidator<'a, RkyvError>>
        + RkyvDeserialize<T, Strategy<Pool, RkyvError>>,
{
    /// load object from file
    fn f_load(path: &Path) -> Result<T, io::Error> {
        let data = fs::read(path)?;
        let obj = rkyv::from_bytes::<T, RkyvError>(&data).map_err(io::Error::other)?;
        Ok(obj)
    }

    fn f_save(&self, path: &Path) -> Result<(), io::Error> {
        if path.exists() {
            return Ok(());
        }

        let data = rkyv::to_bytes::<RkyvError>(self).map_err(io::Error::other)?;
        write_bytes_atomically(path, &data)
    }
}

/// Represents the metadata of a cache object, indicating whether it is a delta or not.
#[derive(
    PartialEq,
    Eq,
    Clone,
    Debug,
    serde::Serialize,
    serde::Deserialize,
    rkyv::Archive,
    rkyv::Serialize,
    rkyv::Deserialize,
)]
pub(crate) enum CacheObjectInfo {
    /// The object is one of the four basic types:
    /// [`ObjectType::Blob`], [`ObjectType::Tree`], [`ObjectType::Commit`], or [`ObjectType::Tag`].
    /// The metadata contains the [`ObjectType`] and the [`ObjectHash`] hash of the object.
    BaseObject(ObjectType, ObjectHash),
    /// The object is an offset delta with a specified offset delta [`usize`],
    /// and the size of the expanded object (previously `delta_final_size`).
    OffsetDelta(usize, usize),
    /// Similar to [`OffsetDelta`], but delta algorithm is `zstd`.
    OffsetZstdelta(usize, usize),
    /// The object is a hash delta with a specified [`ObjectHash`] hash,
    /// and the size of the expanded object (previously `delta_final_size`).
    HashDelta(ObjectHash, usize),
}

impl CacheObjectInfo {
    /// Get the [`ObjectType`] of the object.
    pub(crate) fn object_type(&self) -> ObjectType {
        match self {
            CacheObjectInfo::BaseObject(obj_type, _) => *obj_type,
            CacheObjectInfo::OffsetDelta(_, _) => ObjectType::OffsetDelta,
            CacheObjectInfo::OffsetZstdelta(_, _) => ObjectType::OffsetZstdelta,
            CacheObjectInfo::HashDelta(_, _) => ObjectType::HashDelta,
        }
    }
}

/// Represents a cached object in memory, which may be a delta or a base object.
#[derive(Debug)]
pub struct CacheObject {
    pub(crate) info: CacheObjectInfo,
    pub offset: usize,
    pub crc32: u32,
    pub data_decompressed: Vec<u8>,
    pub mem_recorder: Option<Arc<AtomicUsize>>, // record mem-size of all CacheObjects of a Pack
    pub is_delta_in_pack: bool,
    pub(crate) known_hash: Option<ObjectHash>,
}

#[derive(Debug, rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)]
struct CacheObjectOnDisk {
    info: CacheObjectInfo,
    offset: usize,
    crc32: u32,
    data_decompressed: Vec<u8>,
    is_delta_in_pack: bool,
}

#[derive(Debug, rkyv::Archive, rkyv::Serialize)]
struct CacheObjectOnDiskRef<'a> {
    #[rkyv(with = rkyv::with::AsOwned)]
    info: Cow<'a, CacheObjectInfo>,
    offset: usize,
    crc32: u32,
    #[rkyv(with = rkyv::with::AsOwned)]
    data_decompressed: Cow<'a, [u8]>,
    is_delta_in_pack: bool,
}

impl<'a> From<&'a CacheObject> for CacheObjectOnDiskRef<'a> {
    fn from(value: &'a CacheObject) -> Self {
        Self {
            info: Cow::Borrowed(&value.info),
            offset: value.offset,
            crc32: value.crc32,
            data_decompressed: Cow::Borrowed(value.data_decompressed.as_slice()),
            is_delta_in_pack: value.is_delta_in_pack,
        }
    }
}

impl From<CacheObjectOnDisk> for CacheObject {
    fn from(value: CacheObjectOnDisk) -> Self {
        Self {
            info: value.info,
            offset: value.offset,
            crc32: value.crc32,
            data_decompressed: value.data_decompressed,
            mem_recorder: None,
            is_delta_in_pack: value.is_delta_in_pack,
            known_hash: None,
        }
    }
}

impl FileLoadStore for CacheObject {
    fn f_load(path: &Path) -> Result<Self, io::Error> {
        let obj = CacheObjectOnDisk::f_load(path)?;
        Ok(obj.into())
    }

    fn f_save(&self, path: &Path) -> Result<(), io::Error> {
        if path.exists() {
            return Ok(());
        }

        let data = rkyv::to_bytes::<RkyvError>(&CacheObjectOnDiskRef::from(self))
            .map_err(io::Error::other)?;
        write_bytes_atomically(path, &data)
    }
}

impl Clone for CacheObject {
    fn clone(&self) -> Self {
        let obj = CacheObject {
            info: self.info.clone(),
            offset: self.offset,
            crc32: self.crc32,
            data_decompressed: self.data_decompressed.clone(),
            mem_recorder: self.mem_recorder.clone(),
            is_delta_in_pack: self.is_delta_in_pack,
            known_hash: self.known_hash,
        };
        obj.record_mem_size();
        obj
    }
}

// ! used by lru_mem to calculate the size of the object, limit the memory usage.
// ! the implementation of HeapSize is not accurate, only calculate the size of the data_decompress
// Note that: mem_size == value_size + heap_size, and we only need to impl HeapSize because value_size is known
impl HeapSize for CacheObject {
    /// If a [`CacheObject`] is [`ObjectType::HashDelta`] or [`ObjectType::OffsetDelta`],
    /// it will expand to another [`CacheObject`] of other types. To prevent potential OOM,
    /// we record the size of the expanded object as well as that of the object itself.
    ///
    /// Base objects, *i.e.*, [`ObjectType::Blob`], [`ObjectType::Tree`], [`ObjectType::Commit`],
    /// and [`ObjectType::Tag`], will not be expanded, so the heap-size of the object is the same
    /// as the size of the data.
    ///
    fn heap_size(&self) -> usize {
        match &self.info {
            CacheObjectInfo::BaseObject(_, _) => self.data_decompressed.heap_size(),
            CacheObjectInfo::OffsetDelta(_, delta_final_size)
            | CacheObjectInfo::OffsetZstdelta(_, delta_final_size)
            | CacheObjectInfo::HashDelta(_, delta_final_size) => {
                // To those who are concerned about why these two values are added,
                // let's consider the lifetime of two `CacheObject`s, say `delta_obj`
                // and `final_obj` in the function `Pack::rebuild_delta`.
                //
                // `delta_obj` is dropped only after `Pack::rebuild_delta` returns,
                // but the space for `final_obj` is allocated in that function.
                //
                // Therefore, during the execution of `Pack::rebuild_delta`, both `delta_obj`
                // and `final_obj` coexist. The maximum memory usage is the sum of the memory
                // usage of `delta_obj` and `final_obj`.
                self.data_decompressed.heap_size() + delta_final_size
            }
        }
    }
}

impl Drop for CacheObject {
    // Check: the heap-size subtracted when Drop is equal to the heap-size recorded
    // (cannot change the heap-size during life cycle)
    fn drop(&mut self) {
        // (&*self).heap_size() != self.heap_size()
        if let Some(mem_recorder) = &self.mem_recorder {
            mem_recorder.fetch_sub((*self).mem_size(), Ordering::Release);
        }
    }
}

/// Heap-size recorder for a class(struct)
/// <br> You should use a static Var to record mem-size
/// and record mem-size after construction & minus it in `drop()`
/// <br> So, variable-size fields in object should NOT be modified to keep heap-size stable.
/// <br> Or, you can record the initial mem-size in this object
/// <br> Or, update it (not impl)
pub trait MemSizeRecorder: MemSize {
    fn record_mem_size(&self);
    fn set_mem_recorder(&mut self, mem_size: Arc<AtomicUsize>);
    // fn get_mem_size() -> usize;
}

impl MemSizeRecorder for CacheObject {
    /// record the mem-size of this `CacheObj` in a `static` `var`
    /// <br> since that, DO NOT modify `CacheObj` after recording
    fn record_mem_size(&self) {
        if let Some(mem_recorder) = &self.mem_recorder {
            mem_recorder.fetch_add(self.mem_size(), Ordering::Release);
        }
    }

    fn set_mem_recorder(&mut self, mem_recorder: Arc<AtomicUsize>) {
        self.mem_recorder = Some(mem_recorder);
    }

    // fn get_mem_size() -> usize {
    //     CACHE_OBJS_MEM_SIZE.load(Ordering::Acquire)
    // }
}

impl CacheObject {
    /// Create a new CacheObject which is neither [`ObjectType::OffsetDelta`] nor [`ObjectType::HashDelta`].
    pub fn new_for_undeltified(
        obj_type: ObjectType,
        data: Vec<u8>,
        offset: usize,
        crc32: u32,
    ) -> Self {
        let hash = utils::calculate_object_hash(obj_type, &data);
        CacheObject {
            info: CacheObjectInfo::BaseObject(obj_type, hash),
            offset,
            crc32,
            data_decompressed: data,
            mem_recorder: None,
            is_delta_in_pack: false,
            known_hash: None,
        }
    }

    /// Get the [`ObjectType`] of the object.
    pub fn object_type(&self) -> ObjectType {
        self.info.object_type()
    }

    /// Get the [`ObjectHash`] hash of the object.
    ///
    /// If the object is a delta object, return [`None`].
    pub fn base_object_hash(&self) -> Option<ObjectHash> {
        match &self.info {
            CacheObjectInfo::BaseObject(_, hash) => Some(*hash),
            _ => None,
        }
    }

    /// Get the encoded OFS_DELTA distance from this object back to its base.
    ///
    /// Pack decoding stores the base object's absolute pack offset internally,
    /// but the public accessor mirrors Git's OFS_DELTA representation: callers
    /// subtract this distance from `self.offset` to locate the base entry.
    ///
    /// If the object is not an offset delta, return [`None`].
    pub fn offset_delta(&self) -> Option<usize> {
        match &self.info {
            CacheObjectInfo::OffsetDelta(base_offset, _) => self.offset.checked_sub(*base_offset),
            _ => None,
        }
    }

    /// Get the absolute pack offset of this offset-delta object's base.
    ///
    /// If the object is not an offset delta, return [`None`].
    pub fn offset_delta_base_offset(&self) -> Option<usize> {
        match &self.info {
            CacheObjectInfo::OffsetDelta(base_offset, _) => Some(*base_offset),
            _ => None,
        }
    }

    /// Get the hash delta of the object.
    ///
    /// If the object is not a hash delta, return [`None`].
    pub fn hash_delta(&self) -> Option<ObjectHash> {
        match &self.info {
            CacheObjectInfo::HashDelta(hash, _) => Some(*hash),
            _ => None,
        }
    }

    /// transform the CacheObject to Entry
    pub fn to_entry(&self) -> Entry {
        match self.info {
            CacheObjectInfo::BaseObject(obj_type, hash) => Entry {
                obj_type,
                data: self.data_decompressed.clone(),
                hash,
                chain_len: 0,
            },
            _ => {
                unreachable!("delta object should not persist!")
            }
        }
    }

    /// transform the CacheObject to MetaAttached<Entry, EntryMeta>
    pub fn to_entry_metadata(&self) -> MetaAttached<Entry, EntryMeta> {
        match self.info {
            CacheObjectInfo::BaseObject(obj_type, hash) => {
                let entry = Entry {
                    obj_type,
                    data: self.data_decompressed.clone(),
                    hash,
                    chain_len: 0,
                };
                let meta = EntryMeta {
                    // pack_id:Some(pack_id),
                    pack_offset: Some(self.offset),
                    crc32: Some(self.crc32),
                    is_delta: Some(self.is_delta_in_pack),
                    ..Default::default()
                };
                MetaAttached { inner: entry, meta }
            }

            _ => {
                unreachable!("delta object should not persist!")
            }
        }
    }

    /// transform the CacheObject to MetaAttached<Entry, EntryMeta> without cloning object data
    pub fn into_entry_metadata(mut self) -> MetaAttached<Entry, EntryMeta> {
        let recorded_size = self.mem_size();
        if let Some(mem_recorder) = self.mem_recorder.take() {
            mem_recorder.fetch_sub(recorded_size, Ordering::Release);
        }

        match self.info {
            CacheObjectInfo::BaseObject(obj_type, hash) => {
                let data = std::mem::take(&mut self.data_decompressed);
                let entry = Entry {
                    obj_type,
                    data,
                    hash,
                    chain_len: 0,
                };
                let meta = EntryMeta {
                    pack_offset: Some(self.offset),
                    crc32: Some(self.crc32),
                    is_delta: Some(self.is_delta_in_pack),
                    ..Default::default()
                };
                MetaAttached { inner: entry, meta }
            }

            _ => {
                unreachable!("delta object should not persist!")
            }
        }
    }
}

/// trait alias for simple use
pub trait ArcWrapperBounds: HeapSize + FileLoadStore + Send + Sync + 'static {}
// You must impl `Alias Trait` for all the `T` satisfying Constraints
// Or, `T` will not satisfy `Alias Trait` even if it satisfies the Original traits
impl<T: HeapSize + FileLoadStore + Send + Sync + 'static> ArcWrapperBounds for T {}

/// Implementing encapsulation of Arc to enable third-party Trait HeapSize implementation for the Arc type
/// Because of use Arc in LruCache, the LruCache is not clear whether a pointer will drop the referenced
/// content when it is ejected from the cache, the actual memory usage is not accurate
pub struct ArcWrapper<T: ArcWrapperBounds> {
    pub data: Arc<T>,
    complete_signal: Arc<AtomicBool>,
    pool: Option<Arc<ThreadPool>>,
    pub store_path: Option<PathBuf>, // path to store when drop
}
impl<T: ArcWrapperBounds> ArcWrapper<T> {
    /// Create a new ArcWrapper
    pub fn new(data: Arc<T>, share_flag: Arc<AtomicBool>, pool: Option<Arc<ThreadPool>>) -> Self {
        ArcWrapper {
            data,
            complete_signal: share_flag,
            pool,
            store_path: None,
        }
    }
    /// Sets the file path where this object will be persisted when evicted from cache.
    pub fn set_store_path(&mut self, path: PathBuf) {
        self.store_path = Some(path);
    }
}

impl<T: ArcWrapperBounds> HeapSize for ArcWrapper<T> {
    fn heap_size(&self) -> usize {
        self.data.heap_size()
    }
}

impl<T: ArcWrapperBounds> Clone for ArcWrapper<T> {
    /// clone won't clone the store_path
    fn clone(&self) -> Self {
        ArcWrapper {
            data: self.data.clone(),
            complete_signal: self.complete_signal.clone(),
            pool: self.pool.clone(),
            store_path: None,
        }
    }
}

impl<T: ArcWrapperBounds> Deref for ArcWrapper<T> {
    type Target = Arc<T>;
    fn deref(&self) -> &Self::Target {
        &self.data
    }
}
impl<T: ArcWrapperBounds> Drop for ArcWrapper<T> {
    // `drop` will be called in `lru_cache.insert()` when cache full & eject the LRU
    // `lru_cache.insert()` is protected by Mutex
    fn drop(&mut self) {
        if !self.complete_signal.load(Ordering::Acquire)
            && let Some(path) = &self.store_path
        {
            match &self.pool {
                Some(pool) => {
                    let data_copy = self.data.clone();
                    let path_copy = path.clone();
                    let complete_signal = self.complete_signal.clone();
                    // block entire process, wait for IO, Control Memory
                    // queue size will influence the Memory usage
                    while pool.queued_count() > 2000 {
                        std::thread::yield_now();
                    }
                    pool.execute(move || {
                        if !complete_signal.load(Ordering::Acquire) {
                            let res = data_copy.f_save(&path_copy);
                            if let Err(e) = res {
                                println!("[f_save] {path_copy:?} error: {e:?}");
                            }
                        }
                    });
                }
                None => {
                    let res = self.data.f_save(path);
                    if let Err(e) = res {
                        println!("[f_save] {path:?} error: {e:?}");
                    }
                }
            }
        }
    }
}
#[cfg(test)]
mod test {
    use std::{fs, sync::Mutex};

    use lru_mem::LruCache;
    use tempfile::tempdir;

    use super::*;
    use crate::hash::{HashKind, set_hash_kind_for_test};

    /// Helper to build a base CacheObject with the given size.
    fn make_obj(size: usize) -> CacheObject {
        CacheObject {
            info: CacheObjectInfo::BaseObject(ObjectType::Blob, ObjectHash::default()),
            offset: 0,
            crc32: 0,
            data_decompressed: vec![0; size],
            mem_recorder: None,
            is_delta_in_pack: false,
            known_hash: None,
        }
    }

    #[test]
    fn offset_delta_accessor_returns_encoded_distance() {
        let base_offset = 1024;
        let delta_distance = 128;
        let object_offset = base_offset + delta_distance;

        let obj = CacheObject {
            info: CacheObjectInfo::OffsetDelta(base_offset, 32),
            offset: object_offset,
            crc32: 0,
            data_decompressed: Vec::new(),
            mem_recorder: None,
            is_delta_in_pack: true,
            known_hash: None,
        };

        assert_eq!(obj.offset_delta(), Some(delta_distance));
        assert_eq!(obj.offset_delta_base_offset(), Some(base_offset));
    }

    /// Test that the memory size recording works correctly for CacheObject.
    #[test]
    fn test_heap_size_record() {
        for (kind, size) in [(HashKind::Sha1, 1024usize), (HashKind::Sha256, 2048usize)] {
            let _guard = set_hash_kind_for_test(kind);
            let mut obj = make_obj(size);
            let mem = Arc::new(AtomicUsize::default());
            assert_eq!(mem.load(Ordering::Relaxed), 0);
            obj.set_mem_recorder(mem.clone());
            obj.record_mem_size();
            assert_eq!(mem.load(Ordering::Relaxed), obj.mem_size());
            drop(obj);
            assert_eq!(mem.load(Ordering::Relaxed), 0);
        }
    }

    /// Test that the heap size of CacheObject and ArcWrapper are the same.
    #[test]
    fn test_cache_object_with_same_size() {
        for (kind, size) in [(HashKind::Sha1, 1024usize), (HashKind::Sha256, 2048usize)] {
            let _guard = set_hash_kind_for_test(kind);
            let a = make_obj(size);
            assert_eq!(a.heap_size(), size);

            let b = ArcWrapper::new(Arc::new(a.clone()), Arc::new(AtomicBool::new(false)), None);
            assert_eq!(b.heap_size(), size);
        }
    }

    /// Test that the LRU cache correctly ejects the least recently used object when capacity is exceeded.
    #[test]
    fn test_cache_object_with_lru() {
        for (kind, cap, size_a, size_b) in [
            (
                HashKind::Sha1,
                2048usize,
                1024usize,
                (1024.0 * 1.5) as usize,
            ),
            (
                HashKind::Sha256,
                4096usize,
                2048usize,
                (2048.0 * 1.5) as usize,
            ),
        ] {
            let _guard = set_hash_kind_for_test(kind);
            let mut cache = LruCache::new(cap);

            let hash_a = ObjectHash::default();
            let hash_b = ObjectHash::new(b"b"); // whatever different hash
            let a = make_obj(size_a);
            let b = make_obj(size_b);

            {
                let r = cache.insert(
                    hash_a.to_string(),
                    ArcWrapper::new(Arc::new(a.clone()), Arc::new(AtomicBool::new(true)), None),
                );
                assert!(r.is_ok());
            }

            {
                let r = cache.try_insert(
                    hash_b.to_string(),
                    ArcWrapper::new(Arc::new(b.clone()), Arc::new(AtomicBool::new(true)), None),
                );
                assert!(r.is_err());
                if let Err(lru_mem::TryInsertError::WouldEjectLru { .. }) = r {
                    // expected
                } else {
                    panic!("Expected WouldEjectLru error");
                }

                let r = cache.insert(
                    hash_b.to_string(),
                    ArcWrapper::new(Arc::new(b.clone()), Arc::new(AtomicBool::new(true)), None),
                );
                assert!(r.is_ok());
            }

            {
                let r = cache.get(&hash_a.to_string());
                assert!(r.is_none());
            }
        }
    }

    /// test that the Drop trait is called when an object is ejected from the LRU cache
    #[derive(
        serde::Serialize, serde::Deserialize, rkyv::Archive, rkyv::Serialize, rkyv::Deserialize,
    )]
    struct Test {
        a: usize,
    }
    impl Drop for Test {
        fn drop(&mut self) {
            println!("drop Test");
        }
    }
    impl HeapSize for Test {
        fn heap_size(&self) -> usize {
            self.a
        }
    }
    #[test]
    fn test_lru_drop() {
        println!("insert a");
        let cache = LruCache::new(2048);
        let cache = Arc::new(Mutex::new(cache));
        {
            let mut c = cache.as_ref().lock().unwrap();
            let _ = c.insert(
                "a",
                ArcWrapper::new(
                    Arc::new(Test { a: 1024 }),
                    Arc::new(AtomicBool::new(true)),
                    None,
                ),
            );
        }
        println!("insert b, a should be ejected");
        {
            let mut c = cache.as_ref().lock().unwrap();
            let _ = c.insert(
                "b",
                ArcWrapper::new(
                    Arc::new(Test { a: 1200 }),
                    Arc::new(AtomicBool::new(true)),
                    None,
                ),
            );
        }
        let b = {
            let mut c = cache.as_ref().lock().unwrap();
            c.get("b").cloned()
        };
        println!("insert c, b should not be ejected");
        {
            let mut c = cache.as_ref().lock().unwrap();
            let _ = c.insert(
                "c",
                ArcWrapper::new(
                    Arc::new(Test { a: 1200 }),
                    Arc::new(AtomicBool::new(true)),
                    None,
                ),
            );
        }
        println!("user b: {}", b.as_ref().unwrap().a);
        println!("test over, enject all");
    }

    #[test]
    fn test_cache_object_serialize() {
        for (kind, size) in [(HashKind::Sha1, 1024usize), (HashKind::Sha256, 2048usize)] {
            let _guard = set_hash_kind_for_test(kind);
            let a = make_obj(size);
            let s = rkyv::to_bytes::<RkyvError>(&CacheObjectOnDiskRef::from(&a)).unwrap();
            let b: CacheObject = rkyv::from_bytes::<CacheObjectOnDisk, RkyvError>(&s)
                .unwrap()
                .into();
            assert_eq!(a.info, b.info);
            assert_eq!(a.data_decompressed, b.data_decompressed);
            assert_eq!(a.offset, b.offset);
            assert!(b.mem_recorder.is_none());
        }
    }

    #[test]
    fn test_write_bytes_atomically_creates_file_when_missing() {
        let dir = tempdir().unwrap();
        let path = dir.path().join("object");

        write_bytes_atomically(&path, b"fresh").unwrap();

        assert_eq!(fs::read(&path).unwrap(), b"fresh");
    }

    #[test]
    fn test_write_bytes_atomically_returns_when_target_exists() {
        let dir = tempdir().unwrap();
        let path = dir.path().join("object");

        fs::write(&path, b"existing").unwrap();
        write_bytes_atomically(&path, b"new-data").unwrap();

        assert_eq!(fs::read(&path).unwrap(), b"existing");
    }

    #[test]
    fn test_cache_object_file_roundtrip() {
        let dir = tempdir().unwrap();
        let path = dir.path().join("object");
        let a = make_obj(1024);

        a.f_save(&path).unwrap();
        let b = CacheObject::f_load(&path).unwrap();

        assert_eq!(a.info, b.info);
        assert_eq!(a.data_decompressed, b.data_decompressed);
        assert_eq!(a.offset, b.offset);
        assert!(b.mem_recorder.is_none());
    }

    #[test]
    fn test_arc_wrapper_drop_store() {
        let mut path = PathBuf::from(".cache_temp/test_arc_wrapper_drop_store");
        fs::create_dir_all(&path).unwrap();
        path.push("test_obj");
        let mut a = ArcWrapper::new(Arc::new(1024), Arc::new(AtomicBool::new(false)), None);
        a.set_store_path(path.clone());
        drop(a);

        assert!(path.exists());
        path.pop();
        fs::remove_dir_all(&path).unwrap();
        // Try to remove parent .cache_temp directory if it's empty
        let _ = fs::remove_dir(".cache_temp");
    }

    #[test]
    /// test warpper can't correctly store the data when lru eject it
    fn test_arc_wrapper_with_lru() {
        let mut cache = LruCache::new(1500);
        let path = PathBuf::from(".cache_temp/test_arc_wrapper_with_lru");
        let _ = fs::remove_dir_all(&path);
        fs::create_dir_all(&path).unwrap();
        let shared_flag = Arc::new(AtomicBool::new(false));

        // insert a, a not ejected
        let a_path = path.join("a");
        {
            let mut a = ArcWrapper::new(Arc::new(Test { a: 1024 }), shared_flag.clone(), None);
            a.set_store_path(a_path.clone());
            let b = ArcWrapper::new(Arc::new(1024), shared_flag.clone(), None);
            assert!(b.store_path.is_none());

            println!("insert a with heap size: {:?}", a.heap_size());
            let rt = cache.insert("a", a);
            if let Err(e) = rt {
                panic!("{}", format!("insert a failed: {:?}", e.to_string()));
            }
            println!("after insert a, cache used = {}", cache.current_size());
        }
        assert!(!a_path.exists());

        let b_path = path.join("b");
        // insert b, a should be ejected
        {
            let mut b = ArcWrapper::new(Arc::new(Test { a: 996 }), shared_flag.clone(), None);
            b.set_store_path(b_path.clone());
            let rt = cache.insert("b", b);
            if let Err(e) = rt {
                panic!("{}", format!("insert a failed: {:?}", e.to_string()));
            }
            println!("after insert b, cache used = {}", cache.current_size());
        }
        assert!(a_path.exists());
        assert!(!b_path.exists());
        shared_flag.store(true, Ordering::Release);
        fs::remove_dir_all(path).unwrap();
        // Try to remove parent .cache_temp directory if it's empty
        let _ = fs::remove_dir(".cache_temp");
        // should pass even b's path not exists
    }
}