ghostscope_compiler/ebpf/

context.rs

//! eBPF LLVM context and core infrastructure
//!
//! This module provides the main code generation context and basic LLVM
//! infrastructure for eBPF program generation.

use super::maps::MapManager;
use crate::script::{VarType, VariableContext};
use ghostscope_dwarf::DwarfAnalyzer;
use inkwell::builder::Builder;
use inkwell::context::Context;
use inkwell::debug_info::DebugInfoBuilder;
use inkwell::module::Module;
use inkwell::targets::{Target, TargetTriple};
use inkwell::values::{FunctionValue, IntValue, PointerValue};
use inkwell::AddressSpace;
use inkwell::OptimizationLevel;
use std::collections::HashMap;
use thiserror::Error;
use tracing::info;

/// Compile-time context containing PC address and module information for DWARF queries
#[derive(Debug, Clone)]
pub struct CompileTimeContext {
    pub pc_address: u64,
    pub module_path: String,
}

#[derive(Error, Debug)]
pub enum CodeGenError {
    #[error("LLVM compilation error: {0}")]
    LLVMError(String),
    #[error("Unsupported evaluation result: {0}")]
    UnsupportedEvaluation(String),
    #[error("Register mapping error: {0}")]
    RegisterMappingError(String),
    #[error("Memory access error: {0}")]
    MemoryAccessError(String),
    #[error("Builder error: {0}")]
    Builder(String),

    // === Legacy variable management errors ===
    #[error("Variable not found: {0}")]
    VariableNotFound(String),
    #[error("Variable not in scope: {0}")]
    VariableNotInScope(String),
    #[error("Type error: {0}")]
    TypeError(String),
    #[error("Not implemented: {0}")]
    NotImplemented(String),
    #[error("DWARF expression error: {0}")]
    DwarfError(String),
    #[error("Type size not available for variable: {0}")]
    TypeSizeNotAvailable(String),
}

pub type Result<T> = std::result::Result<T, CodeGenError>;

/// eBPF LLVM code generation context
pub struct EbpfContext<'ctx> {
    pub context: &'ctx Context,
    pub module: Module<'ctx>,
    pub builder: Builder<'ctx>,

    // eBPF-specific function declarations
    pub trace_printk_fn: FunctionValue<'ctx>,

    // Map manager for eBPF maps
    pub map_manager: MapManager<'ctx>,

    // Debug infrastructure
    pub di_builder: DebugInfoBuilder<'ctx>,
    pub compile_unit: inkwell::debug_info::DICompileUnit<'ctx>,

    // Register cache for pt_regs access
    pub register_cache: HashMap<u16, IntValue<'ctx>>,

    // === Complete Variable Management System ===
    pub variables: HashMap<String, PointerValue<'ctx>>, // Variable name -> LLVM pointer
    pub var_types: HashMap<String, VarType>,            // Variable name -> type
    pub optimized_out_vars: HashMap<String, bool>,      // Optimized out variables
    pub var_pc_addresses: HashMap<String, u64>,         // Variable -> PC address
    pub variable_context: Option<VariableContext>,      // Scope validation context
    pub process_analyzer: Option<*mut DwarfAnalyzer>,   // Multi-module DWARF analyzer
    pub current_trace_id: Option<u32>,                  // Current trace_id being compiled
    pub current_compile_time_context: Option<CompileTimeContext>, // PC address and module for DWARF queries

    // === New instruction-based compilation system ===
    pub trace_context: ghostscope_protocol::TraceContext, // Trace context for optimized transmission
    pub current_resolved_var_module_path: Option<String>,

    // Per-invocation stack key for proc_module_offsets lookups (allocated in entry block)
    pub pm_key_alloca: Option<inkwell::values::PointerValue<'ctx>>, // [3 x i32] alloca
    // Per-invocation event accumulation offset (u32) stored on stack (entry block)
    pub event_offset_alloca: Option<inkwell::values::PointerValue<'ctx>>,
    // Tracks whether the last proc_module_offsets lookup succeeded (used to skip reads)
    pub offsets_found_flag: Option<inkwell::values::PointerValue<'ctx>>,

    // Compilation options (includes eBPF map configuration)
    pub compile_options: crate::CompileOptions,

    // === Control-flow expression error capture (soft abort) ===
    pub condition_context_active: bool,

    // === DWARF alias variables (script-level symbolic references) ===
    // These variables do not store pointer values; instead they remember the RHS
    // expression and are resolved to runtime addresses at use sites.
    pub alias_vars: HashMap<String, crate::script::Expr>,

    // === Script string variables (store literal bytes for content printing) ===
    // When a variable is bound from a string literal (or copied from another string var),
    // we keep its bytes (including optional NUL) here for content printing via ImmediateBytes.
    pub string_vars: HashMap<String, Vec<u8>>,

    // === Lexical scoping for immutable variables ===
    // Each scope frame records names declared in that scope.
    pub scope_stack: Vec<std::collections::HashSet<String>>,
}

// Temporary alias for backward compatibility during refactoring
pub type NewCodeGen<'ctx> = EbpfContext<'ctx>;

impl<'ctx> EbpfContext<'ctx> {
    /// Create a new eBPF code generation context
    pub fn new(
        context: &'ctx Context,
        module_name: &str,
        trace_id: Option<u32>,
        compile_options: &crate::CompileOptions,
    ) -> Result<Self> {
        let module = context.create_module(module_name);
        let builder = context.create_builder();

        // Initialize standard BPF target
        Target::initialize_bpf(&Default::default());

        // Create BPF target triple
        let triple = TargetTriple::create("bpf-pc-linux");

        // Get target and create target machine
        let target = Target::from_triple(&triple).map_err(|e| {
            CodeGenError::LLVMError(format!("Failed to get target from triple: {e}"))
        })?;
        let target_machine = target
            .create_target_machine(
                &triple,
                "generic",
                "+alu32",
                OptimizationLevel::Default,
                inkwell::targets::RelocMode::PIC,
                inkwell::targets::CodeModel::Small,
            )
            .ok_or_else(|| {
                CodeGenError::LLVMError("Failed to create target machine".to_string())
            })?;

        // Set module data layout and triple
        let data_layout = target_machine.get_target_data().get_data_layout();
        module.set_data_layout(&data_layout);
        module.set_triple(&triple);

        // Initialize debug info
        let (di_builder, compile_unit) = module.create_debug_info_builder(
            true,                                         // allow_unresolved
            inkwell::debug_info::DWARFSourceLanguage::C,  // language
            "ghostscope_generated.c",                     // filename
            ".",                                          // directory
            "ghostscope-compiler",                        // producer
            false,                                        // is_optimized
            "",                                           // flags
            1,                                            // runtime_version
            "",                                           // split_name
            inkwell::debug_info::DWARFEmissionKind::Full, // kind
            0,                                            // dwo_id
            false,                                        // split_debug_inlining
            false,                                        // debug_info_for_profiling
            "",                                           // sysroot
            "",                                           // sdk
        );

        let map_manager = MapManager::new(context);

        // Declare eBPF helper functions
        let trace_printk_fn = Self::declare_trace_printk(context, &module);

        Ok(Self {
            context,
            module,
            builder,
            trace_printk_fn,
            map_manager,
            di_builder,
            compile_unit,
            register_cache: HashMap::new(),

            // Initialize variable management system
            variables: HashMap::new(),
            var_types: HashMap::new(),
            optimized_out_vars: HashMap::new(),
            var_pc_addresses: HashMap::new(),
            variable_context: None,
            process_analyzer: None,
            current_trace_id: trace_id,
            current_compile_time_context: None,

            // Initialize new instruction-based compilation system
            trace_context: ghostscope_protocol::TraceContext::new(),
            current_resolved_var_module_path: None,
            pm_key_alloca: None,
            event_offset_alloca: None,
            offsets_found_flag: None,
            compile_options: compile_options.clone(),

            // Control-flow expression context
            condition_context_active: false,

            // Alias variables
            alias_vars: HashMap::new(),
            // String variables
            string_vars: HashMap::new(),

            // Scopes
            scope_stack: Vec::new(),
        })
    }

    /// Enter a new lexical scope
    pub fn enter_scope(&mut self) {
        self.scope_stack.push(std::collections::HashSet::new());
    }

    /// Exit current lexical scope and drop all names declared within
    pub fn exit_scope(&mut self) {
        if let Some(names) = self.scope_stack.pop() {
            for name in names {
                self.variables.remove(&name);
                self.var_types.remove(&name);
                self.alias_vars.remove(&name);
                self.string_vars.remove(&name);
                self.optimized_out_vars.remove(&name);
                self.var_pc_addresses.remove(&name);
            }
        }
    }

    /// Check if a name exists in any active scope
    pub fn is_name_in_any_scope(&self, name: &str) -> bool {
        self.scope_stack.iter().any(|s| s.contains(name))
    }

    /// Check if a name exists in current (top) scope
    pub fn is_name_in_current_scope(&self, name: &str) -> bool {
        match self.scope_stack.last() {
            Some(top) => top.contains(name),
            None => false,
        }
    }

    /// Declare a name in the current scope. Disallow same-scope redeclaration and shadowing.
    pub fn declare_name_in_current_scope(&mut self, name: &str) -> Result<()> {
        if self.scope_stack.is_empty() {
            // Initialize a root scope if not present
            self.enter_scope();
        }
        if self.is_name_in_current_scope(name) {
            return Err(CodeGenError::TypeError(format!(
                "Redeclaration in the same scope is not allowed: '{name}'"
            )));
        }
        if self.is_name_in_any_scope(name) {
            return Err(CodeGenError::TypeError(format!(
                "Shadowing is not allowed for immutable variables: '{name}'"
            )));
        }
        if let Some(top) = self.scope_stack.last_mut() {
            top.insert(name.to_string());
        }
        Ok(())
    }

    /// Create a new code generator with DWARF analyzer support
    pub fn new_with_process_analyzer(
        context: &'ctx Context,
        module_name: &str,
        process_analyzer: Option<&mut DwarfAnalyzer>,
        trace_id: Option<u32>,
        compile_options: &crate::CompileOptions,
    ) -> Result<Self> {
        let mut codegen = Self::new(context, module_name, trace_id, compile_options)?;
        codegen.process_analyzer = process_analyzer.map(|pa| pa as *const _ as *mut _);
        Ok(codegen)
    }

    /// Set compile-time context for DWARF queries
    pub fn set_compile_time_context(&mut self, pc_address: u64, module_path: String) {
        self.current_compile_time_context = Some(CompileTimeContext {
            pc_address,
            module_path,
        });
    }

    /// Get compile-time context for DWARF queries
    pub fn get_compile_time_context(&self) -> Result<&CompileTimeContext> {
        self.current_compile_time_context
            .as_ref()
            .ok_or_else(|| CodeGenError::DwarfError("No compile-time context set".to_string()))
    }

    /// Take and clear the current module hint for offsets (if any)
    pub fn take_module_hint(&mut self) -> Option<String> {
        self.current_resolved_var_module_path.take()
    }

    /// Declare trace_printk eBPF helper function
    fn declare_trace_printk(context: &'ctx Context, module: &Module<'ctx>) -> FunctionValue<'ctx> {
        let i32_type = context.i32_type();
        let ptr_type = context.ptr_type(AddressSpace::default());
        let i64_type = context.i64_type();

        // int bpf_trace_printk(const char *fmt, u32 fmt_size, ...)
        let fn_type = i32_type.fn_type(&[ptr_type.into(), i64_type.into()], true);

        module.add_function("bpf_trace_printk", fn_type, None)
    }

    /// Create basic eBPF function with proper signature
    pub fn create_basic_ebpf_function(&mut self, function_name: &str) -> Result<()> {
        let i32_type = self.context.i32_type();
        let ptr_type = self.context.ptr_type(AddressSpace::default());

        // eBPF function signature: int function(struct pt_regs *ctx)
        let fn_type = i32_type.fn_type(&[ptr_type.into()], false);

        let function = self.module.add_function(function_name, fn_type, None);

        // Set section attribute for uprobe
        function.add_attribute(
            inkwell::attributes::AttributeLoc::Function,
            self.context.create_string_attribute("section", "uprobe"),
        );

        // Create basic block
        let basic_block = self.context.append_basic_block(function, "entry");
        self.builder.position_at_end(basic_block);

        info!("Created eBPF function: {}", function_name);
        Ok(())
    }

    /// Test helper: ensure proc_module_offsets map exists in the module
    #[cfg(test)]
    pub fn __test_ensure_proc_offsets_map(&mut self) -> Result<()> {
        self.map_manager
            .create_proc_module_offsets_map(
                &self.module,
                &self.di_builder,
                &self.compile_unit,
                "proc_module_offsets",
                self.compile_options.proc_module_offsets_max_entries,
            )
            .map_err(|e| {
                CodeGenError::LLVMError(format!(
                    "Failed to create proc_module_offsets map in test: {e}"
                ))
            })
    }

    /// Test helper: allocate per-invocation pm_key on the entry block like create_main_function
    #[cfg(test)]
    pub fn __test_alloc_pm_key(&mut self) -> Result<()> {
        let i32_type = self.context.i32_type();
        let key_arr_ty = i32_type.array_type(4);
        let key_alloca = self
            .builder
            .build_alloca(key_arr_ty, "pm_key")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.pm_key_alloca = Some(key_alloca);
        Ok(())
    }

    /// Get the LLVM module reference
    pub fn get_module(&self) -> &Module<'ctx> {
        &self.module
    }

    /// Get the string table after compilation
    pub fn get_trace_context(&self) -> ghostscope_protocol::TraceContext {
        self.trace_context.clone()
    }

    /// Get pt_regs parameter from current function
    pub fn get_pt_regs_parameter(&self) -> Result<PointerValue<'ctx>> {
        let current_function = self
            .builder
            .get_insert_block()
            .ok_or_else(|| CodeGenError::Builder("No current basic block".to_string()))?
            .get_parent()
            .ok_or_else(|| CodeGenError::Builder("No parent function".to_string()))?;

        let pt_regs_param = current_function
            .get_first_param()
            .ok_or_else(|| CodeGenError::Builder("Function has no parameters".to_string()))?
            .into_pointer_value();

        Ok(pt_regs_param)
    }

    /// Compile a complete program with statements
    pub fn compile_program(
        &mut self,
        _program: &crate::script::Program,
        function_name: &str,
        trace_statements: &[crate::script::Statement],
        target_pid: Option<u32>,
        compile_time_pc: Option<u64>,
        module_path: Option<&str>,
    ) -> Result<(FunctionValue<'ctx>, ghostscope_protocol::TraceContext)> {
        info!(
            "Starting program compilation with function: {}",
            function_name
        );

        // Set the current trace_id and compile-time context for code generation
        self.current_compile_time_context =
            if let (Some(pc), Some(path)) = (compile_time_pc, module_path) {
                Some(CompileTimeContext {
                    pc_address: pc,
                    module_path: path.to_string(),
                })
            } else {
                None
            };

        // Create required maps - critical for eBPF loader
        // Create event output map based on compile options
        match self.compile_options.event_map_type {
            crate::EventMapType::RingBuf => {
                self.map_manager
                    .create_ringbuf_map(
                        &self.module,
                        &self.di_builder,
                        &self.compile_unit,
                        "ringbuf",
                        self.compile_options.ringbuf_size,
                    )
                    .map_err(|e| {
                        CodeGenError::LLVMError(format!("Failed to create ringbuf map: {e}"))
                    })?;
            }
            crate::EventMapType::PerfEventArray => {
                self.map_manager
                    .create_perf_event_array_map(
                        &self.module,
                        &self.di_builder,
                        &self.compile_unit,
                        "events",
                    )
                    .map_err(|e| {
                        CodeGenError::LLVMError(format!(
                            "Failed to create perf event array map: {e}"
                        ))
                    })?;
            }
        }

        // Create per-CPU accumulation maps for single-record event emission
        //  - event_accum_buffer: value size = max_trace_event_size bytes, entries = 1
        //  - event_accum_offset: value size = 4 bytes (u32), entries = 1
        self.map_manager
            .create_percpu_array_map(
                &self.module,
                &self.di_builder,
                &self.compile_unit,
                "event_accum_buffer",
                1,
                self.compile_options.max_trace_event_size as u64,
            )
            .map_err(|e| {
                CodeGenError::LLVMError(format!("Failed to create event_accum_buffer: {e}"))
            })?;

        // Create ASLR offsets map for (pid,module) → section offsets
        self.map_manager
            .create_proc_module_offsets_map(
                &self.module,
                &self.di_builder,
                &self.compile_unit,
                "proc_module_offsets",
                self.compile_options.proc_module_offsets_max_entries,
            )
            .map_err(|e| {
                CodeGenError::LLVMError(format!("Failed to create proc_module_offsets map: {e}"))
            })?;

        // Variables are now queried on-demand when accessed in expressions
        // No need to pre-populate DWARF variables

        // Create main function
        let main_function = self.create_main_function(function_name)?;

        // Add PID filtering if target_pid is specified
        if let Some(pid) = target_pid {
            self.add_pid_filter(pid)?;
        }

        // Use new staged transmission system for all statements
        let program = crate::script::ast::Program {
            statements: trace_statements.to_vec(),
        };

        // Collect variable types from DWARF analysis
        let variable_types = std::collections::HashMap::new(); // Empty for now, will be populated by codegen

        // Generate staged transmission code using new architecture
        let trace_context =
            self.compile_program_with_staged_transmission(&program, variable_types)?;
        info!(
            "Generated TraceContext with {} strings",
            trace_context.string_count()
        );

        // Return success
        let i32_type = self.context.i32_type();
        let return_value = i32_type.const_int(0, false);
        self.builder
            .build_return(Some(&return_value))
            .map_err(|e| CodeGenError::Builder(e.to_string()))?;

        info!(
            "Successfully compiled program with function: {} and TraceContext",
            function_name
        );
        Ok((main_function, trace_context))
    }

    /// Create the main eBPF function
    fn create_main_function(&mut self, function_name: &str) -> Result<FunctionValue<'ctx>> {
        let i32_type = self.context.i32_type();
        let ptr_type = self.context.ptr_type(AddressSpace::default());

        // Create function type: int function_name(void *ctx)
        let fn_type = i32_type.fn_type(&[ptr_type.into()], false);
        let function = self.module.add_function(function_name, fn_type, None);

        // CRITICAL: Set section name for eBPF loader to find the function
        function.set_section(Some("uprobe"));

        // Create basic block and position builder
        let basic_block = self.context.append_basic_block(function, "entry");
        self.builder.position_at_end(basic_block);

        // Allocate fixed-size per-invocation key buffer on the eBPF stack (entry block)
        // Layout: [ pid:u32, pad:u32, cookie_lo:u32, cookie_hi:u32 ] to match struct {u32; u64}
        let key_arr_ty = i32_type.array_type(4);
        let key_alloca = self
            .builder
            .build_alloca(key_arr_ty, "pm_key")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.pm_key_alloca = Some(key_alloca);

        // Allocate per-invocation event_offset (u32) and initialize to 0
        let event_off_alloca = self
            .builder
            .build_alloca(i32_type, "event_offset")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.builder
            .build_store(event_off_alloca, i32_type.const_zero())
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.event_offset_alloca = Some(event_off_alloca);

        info!("Created main function: {}", function_name);
        Ok(function)
    }

    /// Add PID filtering logic to the current function
    /// This generates LLVM IR to check current PID against target PID and early return if not matching
    fn add_pid_filter(&mut self, target_pid: u32) -> Result<()> {
        info!("Adding PID filter for target PID: {}", target_pid);

        // Get current function and entry block
        let current_fn = self
            .builder
            .get_insert_block()
            .unwrap()
            .get_parent()
            .unwrap();

        // Create basic blocks for control flow
        let continue_block = self
            .context
            .append_basic_block(current_fn, "continue_execution");
        let early_return_block = self
            .context
            .append_basic_block(current_fn, "pid_mismatch_return");

        // Get current PID/TID using bpf_get_current_pid_tgid helper
        let pid_tgid_value = self.get_current_pid_tgid()?;

        // Extract TGID (high 32 bits) by right shifting 32 bits
        let shift_amount = self.context.i64_type().const_int(32, false);
        let current_tgid = self
            .builder
            .build_right_shift(pid_tgid_value, shift_amount, false, "current_tgid")
            .map_err(|e| CodeGenError::Builder(e.to_string()))?;

        // Convert target_pid to i64 and compare
        let target_pid_value = self.context.i64_type().const_int(target_pid as u64, false);
        let pid_matches = self
            .builder
            .build_int_compare(
                inkwell::IntPredicate::EQ,
                current_tgid,
                target_pid_value,
                "pid_matches",
            )
            .map_err(|e| CodeGenError::Builder(e.to_string()))?;

        // Conditional branch: if pid matches, continue; else early return
        self.builder
            .build_conditional_branch(pid_matches, continue_block, early_return_block)
            .map_err(|e| CodeGenError::Builder(e.to_string()))?;

        // Early return block - just return 0
        self.builder.position_at_end(early_return_block);
        self.builder
            .build_return(Some(&self.context.i32_type().const_int(0, false)))
            .map_err(|e| CodeGenError::Builder(e.to_string()))?;

        // Position at continue block for the rest of the function
        self.builder.position_at_end(continue_block);

        info!(
            "PID filter added successfully for target PID: {}",
            target_pid
        );
        Ok(())
    }

    /// Get or create a global i8 flag by name, initialized to 0
    pub fn get_or_create_flag_global(&mut self, name: &str) -> PointerValue<'ctx> {
        if let Some(g) = self.module.get_global(name) {
            return g.as_pointer_value();
        }
        let i8_type = self.context.i8_type();
        let global = self
            .module
            .add_global(i8_type, Some(AddressSpace::default()), name);
        global.set_initializer(&i8_type.const_zero());
        global.as_pointer_value()
    }

    /// Set a flag global to a constant u8 value at runtime
    pub fn store_flag_value(&mut self, name: &str, value: u8) -> Result<()> {
        let ptr = self.get_or_create_flag_global(name);
        self.builder
            .build_store(ptr, self.context.i8_type().const_int(value as u64, false))
            .map_err(|e| CodeGenError::LLVMError(format!("Failed to store flag {name}: {e}")))?;
        Ok(())
    }

    /// Mark that at least one variable succeeded (status==0)
    pub fn mark_any_success(&mut self) -> Result<()> {
        self.store_flag_value("_gs_any_success", 1)
    }

    /// Mark that at least one variable failed (status!=0)
    pub fn mark_any_fail(&mut self) -> Result<()> {
        self.store_flag_value("_gs_any_fail", 1)
    }

    /// Get (and create if needed) the global flag tracking the last proc_module_offsets lookup.
    /// Stored as i8 where 0 = miss, 1 = found.
    pub fn get_or_create_offsets_found_flag(&mut self) -> inkwell::values::PointerValue<'ctx> {
        if let Some(ptr) = self.offsets_found_flag {
            return ptr;
        }
        let i8_type = self.context.i8_type();
        // TODO: Replace this global flag with explicit control-flow checks when memory-read emission is refactored.
        let global =
            self.module
                .add_global(i8_type, Some(AddressSpace::default()), "_gs_offsets_found");
        global.set_initializer(&i8_type.const_int(1, false));
        let ptr = global.as_pointer_value();
        self.offsets_found_flag = Some(ptr);
        ptr
    }

    /// Store a boolean into the offsets-found flag (true => found, false => miss).
    pub fn store_offsets_found_flag(
        &mut self,
        flag: inkwell::values::IntValue<'ctx>,
    ) -> Result<()> {
        let ptr = self.get_or_create_offsets_found_flag();
        let i8_type = self.context.i8_type();
        let flag_i8 = self
            .builder
            .build_int_z_extend(flag, i8_type, "offset_flag_i8")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.builder
            .build_store(ptr, flag_i8)
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        Ok(())
    }

    /// Store a constant boolean value into the offsets-found flag.
    pub fn store_offsets_found_const(&mut self, value: bool) -> Result<()> {
        let ptr = self.get_or_create_offsets_found_flag();
        let i8_type = self.context.i8_type();
        self.builder
            .build_store(ptr, i8_type.const_int(value as u64, false))
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        Ok(())
    }

    /// Load the current offsets-found flag as i1 (true => found, false => miss).
    pub fn load_offsets_found_flag(&mut self) -> Result<inkwell::values::IntValue<'ctx>> {
        let ptr = self.get_or_create_offsets_found_flag();
        let i8_type = self.context.i8_type();
        let raw = self
            .builder
            .build_load(i8_type, ptr, "offsets_found_raw")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?
            .into_int_value();
        let is_non_zero = self
            .builder
            .build_int_compare(
                inkwell::IntPredicate::NE,
                raw,
                i8_type.const_zero(),
                "offsets_found_bool",
            )
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        Ok(is_non_zero)
    }

    /// Get or create global for condition error code (i8). Name: _gs_cond_error
    pub fn get_or_create_cond_error_global(&mut self) -> PointerValue<'ctx> {
        if let Some(g) = self.module.get_global("_gs_cond_error") {
            return g.as_pointer_value();
        }
        let i8_type = self.context.i8_type();
        let global =
            self.module
                .add_global(i8_type, Some(AddressSpace::default()), "_gs_cond_error");
        global.set_initializer(&i8_type.const_zero());
        global.as_pointer_value()
    }

    /// Reset condition error to 0 (only meaningful when condition_context_active=true)
    pub fn reset_condition_error(&mut self) -> Result<()> {
        let ptr = self.get_or_create_cond_error_global();
        self.builder
            .build_store(ptr, self.context.i8_type().const_zero())
            .map_err(|e| CodeGenError::LLVMError(format!("Failed to reset _gs_cond_error: {e}")))?;
        // Also reset error address
        let aptr = self.get_or_create_cond_error_addr_global();
        self.builder
            .build_store(aptr, self.context.i64_type().const_zero())
            .map_err(|e| {
                CodeGenError::LLVMError(format!("Failed to reset _gs_cond_error_addr: {e}"))
            })?;
        // Also reset flags
        let fptr = self.get_or_create_cond_error_flags_global();
        self.builder
            .build_store(fptr, self.context.i8_type().const_zero())
            .map_err(|e| {
                CodeGenError::LLVMError(format!("Failed to reset _gs_cond_error_flags: {e}"))
            })?;
        Ok(())
    }

    /// Get or create global for condition error address (i64). Name: _gs_cond_error_addr
    pub fn get_or_create_cond_error_addr_global(&mut self) -> PointerValue<'ctx> {
        if let Some(g) = self.module.get_global("_gs_cond_error_addr") {
            return g.as_pointer_value();
        }
        let i64_type = self.context.i64_type();
        let global = self.module.add_global(
            i64_type,
            Some(AddressSpace::default()),
            "_gs_cond_error_addr",
        );
        global.set_initializer(&i64_type.const_zero());
        global.as_pointer_value()
    }

    /// If in condition context, set error code when it's currently 0 (first error wins)
    pub fn set_condition_error_if_unset(&mut self, code: u8) -> Result<()> {
        if !self.condition_context_active {
            return Ok(());
        }
        let ptr = self.get_or_create_cond_error_global();
        let cur = self
            .builder
            .build_load(self.context.i8_type(), ptr, "cond_err_cur")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?
            .into_int_value();
        let is_zero = self
            .builder
            .build_int_compare(
                inkwell::IntPredicate::EQ,
                cur,
                self.context.i8_type().const_zero(),
                "cond_err_is_zero",
            )
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        let newv_bv: inkwell::values::BasicValueEnum =
            self.context.i8_type().const_int(code as u64, false).into();
        let sel = self
            .builder
            .build_select::<inkwell::values::BasicValueEnum, _>(
                is_zero,
                newv_bv,
                cur.into(),
                "cond_err_new",
            )
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.builder
            .build_store(ptr, sel)
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        Ok(())
    }

    /// Read the current condition error as i1 predicate: (error != 0)
    pub fn build_condition_error_predicate(&mut self) -> Result<inkwell::values::IntValue<'ctx>> {
        let ptr = self.get_or_create_cond_error_global();
        let cur = self
            .builder
            .build_load(self.context.i8_type(), ptr, "cond_err_cur")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?
            .into_int_value();
        self.builder
            .build_int_compare(
                inkwell::IntPredicate::NE,
                cur,
                self.context.i8_type().const_zero(),
                "cond_err_nonzero",
            )
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))
    }

    /// Get or create global for condition error flags (i8). Name: _gs_cond_error_flags
    pub fn get_or_create_cond_error_flags_global(&mut self) -> PointerValue<'ctx> {
        if let Some(g) = self.module.get_global("_gs_cond_error_flags") {
            return g.as_pointer_value();
        }
        let i8_type = self.context.i8_type();
        let global = self.module.add_global(
            i8_type,
            Some(AddressSpace::default()),
            "_gs_cond_error_flags",
        );
        global.set_initializer(&i8_type.const_zero());
        global.as_pointer_value()
    }

    /// OR into condition error flags (BV must be i8)
    pub fn or_condition_error_flags(&mut self, flags: IntValue<'ctx>) -> Result<()> {
        if !self.condition_context_active {
            return Ok(());
        }
        let ptr = self.get_or_create_cond_error_flags_global();
        let cur = self
            .builder
            .build_load(self.context.i8_type(), ptr, "cond_err_flags_cur")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?
            .into_int_value();
        let newv = self
            .builder
            .build_or(cur, flags, "cond_err_flags_or")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.builder
            .build_store(ptr, newv)
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        Ok(())
    }

    /// If in condition context, record failing address (first win). addr must be i64
    pub fn set_condition_error_addr_if_unset(&mut self, addr: IntValue<'ctx>) -> Result<()> {
        if !self.condition_context_active {
            return Ok(());
        }
        let ptr = self.get_or_create_cond_error_addr_global();
        let cur = self
            .builder
            .build_load(self.context.i64_type(), ptr, "cond_err_addr_cur")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?
            .into_int_value();
        let is_zero = self
            .builder
            .build_int_compare(
                inkwell::IntPredicate::EQ,
                cur,
                self.context.i64_type().const_zero(),
                "cond_err_addr_is_zero",
            )
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        let sel = self
            .builder
            .build_select::<IntValue<'ctx>, _>(is_zero, addr, cur, "cond_err_addr_new")
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        self.builder
            .build_store(ptr, sel)
            .map_err(|e| CodeGenError::LLVMError(e.to_string()))?;
        Ok(())
    }
}