fresh/view/

keybinding_editor.rs

//! Keybinding Editor rendering and input handling
//!
//! Renders the keybinding editor modal and handles input events.

use crate::app::keybinding_editor::{
    BindingSource, ContextFilter, DeleteResult, DisplayRow, EditMode, KeybindingEditor, SearchMode,
    SourceFilter,
};
use crate::input::keybindings::{format_keybinding, KeybindingResolver};
use crate::view::dimming::apply_dimming;
use crate::view::theme::Theme;
use crate::view::ui::scrollbar::{render_scrollbar, ScrollbarColors};
use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
use ratatui::{
    layout::{Constraint, Layout, Rect},
    style::{Modifier, Style},
    text::{Line, Span},
    widgets::{Block, Borders, Clear, Paragraph},
    Frame,
};
use rust_i18n::t;

/// Compute the centred modal rectangle for the keybinding editor within
/// `area`.
///
/// The result is offset by `area.x`/`area.y` so the modal centres within
/// the area it was handed — not the whole screen. When the orchestrator
/// left dock is open the editor passes the post-dock-split `chrome_area`
/// (whose `x` starts to the right of the dock); without these offsets the
/// modal would be placed relative to column 0 and bleed left under the
/// dock, leaving it partially obscured and off-centre.
fn keybinding_modal_area(area: Rect) -> Rect {
    // Modal dimensions: 90% width, 90% height
    let modal_width = (area.width as f32 * 0.90).min(120.0) as u16;
    let modal_height = (area.height as f32 * 0.90) as u16;
    let modal_width = modal_width.max(60).min(area.width.saturating_sub(2));
    let modal_height = modal_height.max(20).min(area.height.saturating_sub(2));

    let x = area.x + (area.width.saturating_sub(modal_width)) / 2;
    let y = area.y + (area.height.saturating_sub(modal_height)) / 2;

    Rect {
        x,
        y,
        width: modal_width,
        height: modal_height,
    }
}

/// Render the keybinding editor modal
pub fn render_keybinding_editor(
    frame: &mut Frame,
    area: Rect,
    editor: &mut KeybindingEditor,
    theme: &Theme,
) {
    let modal_area = keybinding_modal_area(area);

    // Clear background
    frame.render_widget(Clear, modal_area);

    // Border
    let title = format!(
        " {} \u{2500} [{}] ",
        t!("keybinding_editor.title"),
        editor.active_keymap
    );
    let block = Block::default()
        .title(title)
        .borders(Borders::ALL)
        .border_style(Style::default().fg(theme.popup_border_fg))
        .style(Style::default().bg(theme.popup_bg).fg(theme.popup_text_fg));

    let inner = block.inner(modal_area);
    frame.render_widget(block, modal_area);

    // Layout: header (3-4 lines) | table | footer (1 line)
    let chunks = Layout::vertical([
        Constraint::Length(3), // Header: config path + search + filters
        Constraint::Min(5),    // Table
        Constraint::Length(1), // Footer hints
    ])
    .split(inner);

    // Store layout for mouse hit testing
    editor.layout.modal_area = modal_area;
    editor.layout.table_area = chunks[1];
    editor.layout.table_first_row_y = chunks[1].y + 2; // +2 for header + separator
    editor.layout.search_bar = Some(Rect {
        x: inner.x,
        y: inner.y + 1, // second row of header
        width: inner.width,
        height: 1,
    });
    // Reset dialog layouts (will be set if dialogs are rendered)
    editor.layout.dialog_buttons = None;
    editor.layout.dialog_key_field = None;
    editor.layout.dialog_action_field = None;
    editor.layout.dialog_context_field = None;
    editor.layout.confirm_buttons = None;
    editor.layout.table_scrollbar = None;

    render_header(frame, chunks[0], editor, theme);
    render_table(frame, chunks[1], editor, theme);
    render_footer(frame, chunks[2], editor, theme);

    // Render dialogs on top
    if editor.showing_help {
        render_help_overlay(frame, inner, theme);
    }

    // Need to temporarily take dialog to avoid borrow conflict
    if let Some(dialog) = editor.edit_dialog.take() {
        apply_dimming(frame, modal_area);
        render_edit_dialog(frame, inner, &dialog, editor, theme);
        editor.edit_dialog = Some(dialog);
    }

    if editor.showing_confirm_dialog {
        apply_dimming(frame, modal_area);
        render_confirm_dialog(frame, inner, editor, theme);
    }
}

/// Render the header section (config path, search, filters)
fn render_header(frame: &mut Frame, area: Rect, editor: &KeybindingEditor, theme: &Theme) {
    let chunks = Layout::vertical([
        Constraint::Length(1), // Config path + keymap info
        Constraint::Length(1), // Search bar
        Constraint::Length(1), // Filters
    ])
    .split(area);

    // Line 1: Config file path and keymap names
    let mut path_spans = vec![
        Span::styled(
            format!(" {} ", t!("keybinding_editor.label_config")),
            Style::default().fg(theme.popup_text_fg),
        ),
        Span::styled(
            &editor.config_file_path,
            Style::default().fg(theme.diagnostic_info_fg),
        ),
    ];
    if !editor.keymap_names.is_empty() {
        path_spans.push(Span::styled(
            format!("  {} ", t!("keybinding_editor.label_maps")),
            Style::default().fg(theme.popup_text_fg),
        ));
        path_spans.push(Span::styled(
            editor.keymap_names.join(", "),
            Style::default().fg(theme.popup_text_fg),
        ));
    }
    frame.render_widget(Paragraph::new(Line::from(path_spans)), chunks[0]);

    // Line 2: Search bar
    if editor.search_active {
        let search_spans = match editor.search_mode {
            SearchMode::Text => {
                let mut spans = vec![
                    Span::styled(
                        format!(" {} ", t!("keybinding_editor.label_search")),
                        Style::default()
                            .fg(theme.help_key_fg)
                            .add_modifier(Modifier::BOLD),
                    ),
                    Span::styled(
                        &editor.search_query,
                        Style::default().fg(theme.popup_text_fg),
                    ),
                ];
                if editor.search_focused {
                    spans.push(Span::styled("_", Style::default().fg(theme.cursor)));
                    spans.push(Span::styled(
                        format!("  {}", t!("keybinding_editor.search_text_hint")),
                        Style::default().fg(theme.popup_text_fg),
                    ));
                }
                spans
            }
            SearchMode::RecordKey => {
                let key_text = if editor.search_key_display.is_empty() {
                    t!("keybinding_editor.press_a_key").to_string()
                } else {
                    editor.search_key_display.clone()
                };
                vec![
                    Span::styled(
                        format!(" {} ", t!("keybinding_editor.label_record_key")),
                        Style::default()
                            .fg(theme.diagnostic_warning_fg)
                            .add_modifier(Modifier::BOLD),
                    ),
                    Span::styled(key_text, Style::default().fg(theme.popup_text_fg)),
                    Span::styled(
                        format!("  {}", t!("keybinding_editor.search_record_hint")),
                        Style::default().fg(theme.popup_text_fg),
                    ),
                ]
            }
        };
        frame.render_widget(Paragraph::new(Line::from(search_spans)), chunks[1]);
    } else {
        let hint = Line::from(vec![
            Span::styled(" ", Style::default()),
            Span::styled(
                t!("keybinding_editor.search_hint").to_string(),
                Style::default().fg(theme.popup_text_fg),
            ),
        ]);
        frame.render_widget(Paragraph::new(hint), chunks[1]);
    }

    // Line 3: Filters and counts
    let total = editor.bindings.len();
    let filtered = editor.filtered_indices.len();
    let count_str = if filtered == total {
        t!("keybinding_editor.bindings_count", count = total).to_string()
    } else {
        t!(
            "keybinding_editor.bindings_filtered",
            filtered = filtered,
            total = total
        )
        .to_string()
    };

    let filter_spans = vec![
        Span::styled(
            format!(" {} ", t!("keybinding_editor.label_context")),
            Style::default().fg(theme.popup_text_fg),
        ),
        Span::styled(
            format!("[{}]", editor.context_filter_display()),
            Style::default().fg(if editor.context_filter == ContextFilter::All {
                theme.popup_text_fg
            } else {
                theme.diagnostic_info_fg
            }),
        ),
        Span::styled(
            format!("  {} ", t!("keybinding_editor.label_source")),
            Style::default().fg(theme.popup_text_fg),
        ),
        Span::styled(
            format!("[{}]", editor.source_filter_display()),
            Style::default().fg(if editor.source_filter == SourceFilter::All {
                theme.popup_text_fg
            } else {
                theme.diagnostic_info_fg
            }),
        ),
        Span::styled(
            format!("  {}", count_str),
            Style::default().fg(theme.popup_text_fg),
        ),
        Span::styled(
            if editor.has_changes {
                format!("  {}", t!("keybinding_editor.modified"))
            } else {
                String::new()
            },
            Style::default().fg(theme.diagnostic_warning_fg),
        ),
    ];
    frame.render_widget(Paragraph::new(Line::from(filter_spans)), chunks[2]);
}

/// Render the keybinding table
fn render_table(frame: &mut Frame, area: Rect, editor: &mut KeybindingEditor, theme: &Theme) {
    if area.height < 2 {
        return;
    }

    let inner_width = area.width.saturating_sub(2); // Leave room for scrollbar

    // Column widths (adaptive): Key | Action Name | Description | Context | Source
    let key_col_width = (inner_width as f32 * 0.16).min(20.0) as u16;
    let action_name_col_width = (inner_width as f32 * 0.22).min(28.0) as u16;
    let context_col_width = (inner_width as f32 * 0.18).clamp(14.0, 30.0) as u16;
    let source_col_width = 8u16;
    let fixed_cols =
        key_col_width + action_name_col_width + context_col_width + source_col_width + 5; // +5 for spacers
    let description_col_width = inner_width.saturating_sub(fixed_cols);

    // Header line
    let header = Line::from(vec![
        Span::styled(" ", Style::default()),
        Span::styled(
            pad_right(&t!("keybinding_editor.header_key"), key_col_width as usize),
            Style::default()
                .fg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD),
        ),
        Span::styled(" ", Style::default()),
        Span::styled(
            pad_right(
                &t!("keybinding_editor.header_action"),
                action_name_col_width as usize,
            ),
            Style::default()
                .fg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD),
        ),
        Span::styled(" ", Style::default()),
        Span::styled(
            pad_right(
                &t!("keybinding_editor.header_description"),
                description_col_width as usize,
            ),
            Style::default()
                .fg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD),
        ),
        Span::styled(" ", Style::default()),
        Span::styled(
            pad_right(
                &t!("keybinding_editor.header_context"),
                context_col_width as usize,
            ),
            Style::default()
                .fg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD),
        ),
        Span::styled(" ", Style::default()),
        Span::styled(
            pad_right(
                &t!("keybinding_editor.header_source"),
                source_col_width as usize,
            ),
            Style::default()
                .fg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD),
        ),
    ]);
    frame.render_widget(Paragraph::new(header), Rect { height: 1, ..area });

    // Separator
    if area.height > 1 {
        let sep = "\u{2500}".repeat(inner_width as usize);
        frame.render_widget(
            Paragraph::new(Line::from(Span::styled(
                format!(" {}", sep),
                Style::default().fg(theme.popup_text_fg),
            ))),
            Rect {
                y: area.y + 1,
                height: 1,
                ..area
            },
        );
    }

    // Table rows
    let table_area = Rect {
        y: area.y + 2,
        height: area.height.saturating_sub(2),
        ..area
    };

    // Sync scroll state with actual viewport dimensions
    editor.scroll.set_viewport(table_area.height);
    editor
        .scroll
        .set_content_height(editor.display_rows.len() as u16);

    let visible_rows = table_area.height as usize;
    let scroll_offset = editor.scroll.offset as usize;

    for (display_idx, display_row) in editor
        .display_rows
        .iter()
        .skip(scroll_offset)
        .take(visible_rows)
        .enumerate()
    {
        let row_y = table_area.y + display_idx as u16;
        if row_y >= table_area.y + table_area.height {
            break;
        }

        let is_selected = scroll_offset + display_idx == editor.selected;
        let row_area = Rect {
            y: row_y,
            height: 1,
            ..table_area
        };

        match display_row {
            DisplayRow::SectionHeader {
                plugin_name,
                collapsed,
                binding_count,
            } => {
                let (row_bg, row_fg) = if is_selected {
                    (theme.popup_selection_bg, theme.popup_text_fg)
                } else {
                    (theme.popup_bg, theme.help_key_fg)
                };

                let chevron = if *collapsed { "\u{25b6}" } else { "\u{25bc}" };
                let label = match plugin_name {
                    Some(name) => name.as_str(),
                    None => "Builtin",
                };

                let header_text = format!("{} {} ({})", chevron, label, binding_count);
                let header_style = Style::default()
                    .fg(row_fg)
                    .bg(row_bg)
                    .add_modifier(Modifier::BOLD);

                let indicator = if is_selected { ">" } else { " " };
                let row = Line::from(vec![
                    Span::styled(indicator, Style::default().fg(theme.help_key_fg).bg(row_bg)),
                    Span::styled(header_text, header_style),
                ]);

                frame.render_widget(
                    Paragraph::new("").style(Style::default().bg(row_bg)),
                    row_area,
                );
                frame.render_widget(Paragraph::new(row), row_area);
            }
            DisplayRow::Binding(binding_idx) => {
                let binding = &editor.bindings[*binding_idx];

                let (row_bg, row_fg) = if is_selected {
                    (theme.popup_selection_bg, theme.popup_text_fg)
                } else {
                    (theme.popup_bg, theme.popup_text_fg)
                };

                let key_style = Style::default()
                    .fg(if is_selected {
                        theme.popup_text_fg
                    } else {
                        theme.help_key_fg
                    })
                    .bg(row_bg);
                let action_name_style = Style::default()
                    .fg(if is_selected {
                        theme.popup_text_fg
                    } else {
                        theme.diagnostic_info_fg
                    })
                    .bg(row_bg);
                let action_style = Style::default().fg(row_fg).bg(row_bg);
                let context_style = Style::default()
                    .fg(if is_selected {
                        row_fg
                    } else {
                        theme.popup_text_fg
                    })
                    .bg(row_bg);
                let source_style = Style::default()
                    .fg(
                        if binding.source == BindingSource::Custom
                            || binding.source == BindingSource::Plugin
                        {
                            if is_selected {
                                theme.popup_text_fg
                            } else {
                                theme.diagnostic_info_fg
                            }
                        } else {
                            context_style.fg.unwrap_or(theme.popup_text_fg)
                        },
                    )
                    .bg(row_bg);

                let indicator = if is_selected { ">" } else { " " };

                let row = Line::from(vec![
                    Span::styled(indicator, Style::default().fg(theme.help_key_fg).bg(row_bg)),
                    Span::styled(
                        pad_right(&binding.key_display, key_col_width as usize),
                        key_style,
                    ),
                    Span::styled(" ", action_name_style),
                    Span::styled(
                        pad_right(&binding.action, action_name_col_width as usize),
                        action_name_style,
                    ),
                    Span::styled(" ", action_style),
                    Span::styled(
                        pad_right(&binding.action_display, description_col_width as usize),
                        action_style,
                    ),
                    Span::styled(" ", context_style),
                    Span::styled(
                        pad_right(&binding.context, context_col_width as usize),
                        context_style,
                    ),
                    Span::styled(" ", source_style),
                    Span::styled(
                        pad_right(
                            &match binding.source {
                                BindingSource::Custom => {
                                    t!("keybinding_editor.source_custom").to_string()
                                }
                                BindingSource::Keymap => {
                                    t!("keybinding_editor.source_keymap").to_string()
                                }
                                BindingSource::Plugin => {
                                    t!("keybinding_editor.source_plugin", default = "Plugin")
                                        .to_string()
                                }
                                BindingSource::Unbound => String::new(),
                            },
                            source_col_width as usize,
                        ),
                        source_style,
                    ),
                ]);

                frame.render_widget(
                    Paragraph::new("").style(Style::default().bg(row_bg)),
                    row_area,
                );
                frame.render_widget(Paragraph::new(row), row_area);
            }
        }
    }

    // Scrollbar
    if editor.scroll.needs_scrollbar() {
        let sb_area = Rect::new(
            table_area.x + table_area.width.saturating_sub(1),
            table_area.y,
            1,
            table_area.height,
        );
        let sb_state = editor.scroll.to_scrollbar_state();
        let sb_colors = ScrollbarColors::from_theme(theme);
        render_scrollbar(frame, sb_area, &sb_state, &sb_colors);
        editor.layout.table_scrollbar = Some(sb_area);
    }
}

/// Render the footer with key hints
fn render_footer(frame: &mut Frame, area: Rect, editor: &KeybindingEditor, theme: &Theme) {
    let hints = if editor.search_active && editor.search_focused {
        vec![
            Span::styled(" Esc", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_cancel")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("Tab", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_toggle_mode")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("Enter", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}", t!("keybinding_editor.footer_confirm")),
                Style::default().fg(theme.popup_text_fg),
            ),
        ]
    } else {
        vec![
            Span::styled(" Enter", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_edit")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("a", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_add")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("d", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_delete")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("/", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_search")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("r", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_record_key")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("c", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_context")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("s", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_source")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("?", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_help")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("Ctrl+S", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}  ", t!("keybinding_editor.footer_save")),
                Style::default().fg(theme.popup_text_fg),
            ),
            Span::styled("Esc", Style::default().fg(theme.help_key_fg)),
            Span::styled(
                format!(":{}", t!("keybinding_editor.footer_close")),
                Style::default().fg(theme.popup_text_fg),
            ),
        ]
    };

    frame.render_widget(Paragraph::new(Line::from(hints)), area);
}

/// Render the help overlay
fn render_help_overlay(frame: &mut Frame, area: Rect, theme: &Theme) {
    let width = 52u16.min(area.width.saturating_sub(4));
    let height = 22u16.min(area.height.saturating_sub(4));
    let x = area.x + (area.width.saturating_sub(width)) / 2;
    let y = area.y + (area.height.saturating_sub(height)) / 2;

    let dialog_area = Rect {
        x,
        y,
        width,
        height,
    };
    frame.render_widget(Clear, dialog_area);

    let block = Block::default()
        .title(format!(" {} ", t!("keybinding_editor.help_title")))
        .borders(Borders::ALL)
        .border_style(Style::default().fg(theme.popup_border_fg))
        .style(Style::default().bg(theme.popup_bg).fg(theme.popup_text_fg));
    let inner = block.inner(dialog_area);
    frame.render_widget(block, dialog_area);

    let h_nav = t!("keybinding_editor.help_navigation").to_string();
    let h_move = t!("keybinding_editor.help_move_up_down").to_string();
    let h_page = t!("keybinding_editor.help_page_up_down").to_string();
    let h_first = t!("keybinding_editor.help_first_last").to_string();
    let h_search = t!("keybinding_editor.help_search").to_string();
    let h_by_name = t!("keybinding_editor.help_search_by_name").to_string();
    let h_by_key = t!("keybinding_editor.help_search_by_key").to_string();
    let h_toggle = t!("keybinding_editor.help_toggle_search").to_string();
    let h_cancel = t!("keybinding_editor.help_cancel_search").to_string();
    let h_editing = t!("keybinding_editor.help_editing").to_string();
    let h_edit = t!("keybinding_editor.help_edit_binding").to_string();
    let h_add = t!("keybinding_editor.help_add_binding").to_string();
    let h_del = t!("keybinding_editor.help_delete_binding").to_string();
    let h_filters = t!("keybinding_editor.help_filters").to_string();
    let h_ctx = t!("keybinding_editor.help_cycle_context").to_string();
    let h_src = t!("keybinding_editor.help_cycle_source").to_string();
    let h_save = t!("keybinding_editor.help_save_changes").to_string();
    let h_close = t!("keybinding_editor.help_close_help").to_string();

    let help_lines = vec![
        help_line(&h_nav, "", theme, true),
        help_line("  \u{2191} / \u{2193}", &h_move, theme, false),
        help_line("  PgUp / PgDn", &h_page, theme, false),
        help_line("  Home / End", &h_first, theme, false),
        help_line("", "", theme, false),
        help_line(&h_search, "", theme, true),
        help_line("  /", &h_by_name, theme, false),
        help_line("  r", &h_by_key, theme, false),
        help_line("  Tab", &h_toggle, theme, false),
        help_line("  Esc", &h_cancel, theme, false),
        help_line("", "", theme, false),
        help_line(&h_editing, "", theme, true),
        help_line("  Enter", &h_edit, theme, false),
        help_line("  a", &h_add, theme, false),
        help_line("  d / Delete", &h_del, theme, false),
        help_line("", "", theme, false),
        help_line(&h_filters, "", theme, true),
        help_line("  c", &h_ctx, theme, false),
        help_line("  s", &h_src, theme, false),
        help_line("", "", theme, false),
        help_line("  Ctrl+S", &h_save, theme, false),
        help_line("  Esc / ?", &h_close, theme, false),
    ];

    let para = Paragraph::new(help_lines);
    frame.render_widget(para, inner);
}

fn help_line<'a>(key: &'a str, desc: &'a str, theme: &Theme, is_header: bool) -> Line<'a> {
    if is_header {
        Line::from(vec![Span::styled(
            key,
            Style::default()
                .fg(theme.popup_text_fg)
                .add_modifier(Modifier::BOLD),
        )])
    } else {
        Line::from(vec![
            Span::styled(
                format!("{:16}", key),
                Style::default()
                    .fg(theme.help_key_fg)
                    .add_modifier(Modifier::BOLD),
            ),
            Span::styled(desc, Style::default().fg(theme.popup_text_fg)),
        ])
    }
}

/// Maximum number of autocomplete suggestions to display
const MAX_AUTOCOMPLETE_VISIBLE: usize = 8;

/// Render the edit/add binding dialog
fn render_edit_dialog(
    frame: &mut Frame,
    area: Rect,
    dialog: &crate::app::keybinding_editor::EditBindingState,
    editor: &mut KeybindingEditor,
    theme: &Theme,
) {
    let width = 56u16.min(area.width.saturating_sub(4));
    let height = 18u16.min(area.height.saturating_sub(4));
    let x = area.x + (area.width.saturating_sub(width)) / 2;
    let y = area.y + (area.height.saturating_sub(height)) / 2;

    let dialog_area = Rect {
        x,
        y,
        width,
        height,
    };
    frame.render_widget(Clear, dialog_area);

    let title = if dialog.editing_index.is_some() {
        format!(" {} ", t!("keybinding_editor.dialog_edit_title"))
    } else {
        format!(" {} ", t!("keybinding_editor.dialog_add_title"))
    };

    let block = Block::default()
        .title(title)
        .borders(Borders::ALL)
        .border_style(Style::default().fg(theme.popup_border_fg))
        .style(Style::default().bg(theme.popup_bg).fg(theme.popup_text_fg));
    let inner = block.inner(dialog_area);
    frame.render_widget(block, dialog_area);

    let chunks = Layout::vertical([
        Constraint::Length(1), // Instructions
        Constraint::Length(1), // Spacer
        Constraint::Length(1), // Key field
        Constraint::Length(1), // Action field
        Constraint::Length(1), // Action description (read-only)
        Constraint::Length(1), // Context field
        Constraint::Length(1), // Spacer
        Constraint::Min(3),    // Conflicts / error
        Constraint::Length(1), // Buttons
    ])
    .split(inner);

    // Instructions
    let instr = if dialog.capturing_special && dialog.focus_area == 0 {
        t!("keybinding_editor.instr_capturing_special").to_string()
    } else {
        match dialog.mode {
            EditMode::RecordingKey => t!("keybinding_editor.instr_recording_key").to_string(),
            EditMode::EditingAction => t!("keybinding_editor.instr_editing_action").to_string(),
            EditMode::EditingContext => t!("keybinding_editor.instr_editing_context").to_string(),
        }
    };
    frame.render_widget(
        Paragraph::new(Line::from(Span::styled(
            format!(" {}", instr),
            Style::default().fg(theme.popup_text_fg),
        ))),
        chunks[0],
    );

    // Key field
    let key_focused = dialog.focus_area == 0;
    let key_none_text;
    let key_recording_text;
    let key_text = if dialog.key_display.is_empty() {
        if dialog.mode == EditMode::RecordingKey {
            key_recording_text = t!("keybinding_editor.key_recording").to_string();
            &key_recording_text
        } else {
            key_none_text = t!("keybinding_editor.key_none").to_string();
            &key_none_text
        }
    } else {
        &dialog.key_display
    };
    let field_bg = if key_focused {
        theme.popup_selection_bg
    } else {
        theme.popup_bg
    };
    let key_label_style = if key_focused {
        Style::default()
            .fg(theme.help_key_fg)
            .bg(field_bg)
            .add_modifier(Modifier::BOLD)
    } else {
        Style::default().fg(theme.popup_text_fg).bg(field_bg)
    };
    let key_value_style = Style::default().fg(theme.popup_text_fg).bg(field_bg);
    if key_focused {
        frame.render_widget(
            Paragraph::new("").style(Style::default().bg(field_bg)),
            chunks[2],
        );
    }
    let mut key_spans = vec![
        Span::styled(
            format!("   {:9}", t!("keybinding_editor.label_key")),
            key_label_style,
        ),
        Span::styled(key_text, key_value_style),
    ];
    if key_focused && dialog.capturing_special {
        key_spans.push(Span::styled(
            format!("  {}", t!("keybinding_editor.capture_any_key_hint")),
            Style::default()
                .fg(theme.diagnostic_warning_fg)
                .bg(field_bg)
                .add_modifier(Modifier::BOLD),
        ));
    } else if key_focused && !dialog.capturing_special {
        key_spans.push(Span::styled(
            format!("  {}", t!("keybinding_editor.capture_special_hint")),
            Style::default().fg(theme.popup_text_fg).bg(field_bg),
        ));
    }
    frame.render_widget(Paragraph::new(Line::from(key_spans)), chunks[2]);

    // Action field
    let action_focused = dialog.focus_area == 1;
    let field_bg = if action_focused {
        theme.popup_selection_bg
    } else {
        theme.popup_bg
    };
    let action_label_style = if action_focused {
        Style::default()
            .fg(theme.help_key_fg)
            .bg(field_bg)
            .add_modifier(Modifier::BOLD)
    } else {
        Style::default().fg(theme.popup_text_fg).bg(field_bg)
    };
    let has_error = dialog.action_error.is_some();
    let action_value_style = if has_error {
        Style::default().fg(theme.diagnostic_error_fg).bg(field_bg)
    } else {
        Style::default().fg(theme.popup_text_fg).bg(field_bg)
    };
    let action_placeholder;
    let action_display = if dialog.action_text.is_empty() && dialog.mode != EditMode::EditingAction
    {
        action_placeholder = t!("keybinding_editor.action_placeholder").to_string();
        &action_placeholder
    } else {
        &dialog.action_text
    };
    if action_focused {
        frame.render_widget(
            Paragraph::new("").style(Style::default().bg(field_bg)),
            chunks[3],
        );
    }
    let mut action_spans = vec![
        Span::styled(
            format!("   {:9}", t!("keybinding_editor.label_action")),
            action_label_style,
        ),
        Span::styled(action_display, action_value_style),
    ];
    if action_focused && dialog.mode == EditMode::EditingAction {
        action_spans.push(Span::styled(
            "_",
            Style::default().fg(theme.cursor).bg(field_bg),
        ));
    }
    frame.render_widget(Paragraph::new(Line::from(action_spans)), chunks[3]);

    // Action description (read-only, shown when action text is a valid action)
    if !dialog.action_text.is_empty() {
        let description = KeybindingResolver::format_action_from_str(&dialog.action_text);
        // Only show if description differs from the raw action name
        if description.to_lowercase() != dialog.action_text.replace('_', " ").to_lowercase() {
            frame.render_widget(
                Paragraph::new(Line::from(vec![
                    Span::styled("            ", Style::default().fg(theme.popup_text_fg)),
                    Span::styled(
                        format!("\u{2192} {}", description),
                        Style::default()
                            .fg(theme.popup_text_fg)
                            .add_modifier(Modifier::ITALIC),
                    ),
                ])),
                chunks[4],
            );
        }
    }

    // Context field
    let ctx_focused = dialog.focus_area == 2;
    let field_bg = if ctx_focused {
        theme.popup_selection_bg
    } else {
        theme.popup_bg
    };
    let ctx_label_style = if ctx_focused {
        Style::default()
            .fg(theme.help_key_fg)
            .bg(field_bg)
            .add_modifier(Modifier::BOLD)
    } else {
        Style::default().fg(theme.popup_text_fg).bg(field_bg)
    };
    if ctx_focused {
        frame.render_widget(
            Paragraph::new("").style(Style::default().bg(field_bg)),
            chunks[5],
        );
    }
    frame.render_widget(
        Paragraph::new(Line::from(vec![
            Span::styled(
                format!("   {:9}", t!("keybinding_editor.label_context")),
                ctx_label_style,
            ),
            Span::styled(
                format!("[{}]", dialog.context),
                Style::default().fg(theme.popup_text_fg).bg(field_bg),
            ),
            if ctx_focused {
                Span::styled(
                    format!("  {}", t!("keybinding_editor.context_change_hint")),
                    Style::default().fg(theme.popup_text_fg).bg(field_bg),
                )
            } else {
                Span::raw("")
            },
        ])),
        chunks[5],
    );

    // Conflicts or error in the info area
    let mut info_lines: Vec<Line> = Vec::new();
    if let Some(ref err) = dialog.action_error {
        info_lines.push(Line::from(Span::styled(
            format!("   \u{2717} {}", err),
            Style::default()
                .fg(theme.diagnostic_error_fg)
                .add_modifier(Modifier::BOLD),
        )));
    }
    if !dialog.conflicts.is_empty() {
        info_lines.push(Line::from(Span::styled(
            format!("   {}", t!("keybinding_editor.conflicts_label")),
            Style::default()
                .fg(theme.diagnostic_warning_fg)
                .add_modifier(Modifier::BOLD),
        )));
        for conflict in &dialog.conflicts {
            info_lines.push(Line::from(Span::styled(
                format!("     {}", conflict),
                Style::default().fg(theme.diagnostic_warning_fg),
            )));
        }
    }
    if !info_lines.is_empty() {
        frame.render_widget(Paragraph::new(info_lines), chunks[7]);
    }

    // Buttons
    let btn_focused = dialog.focus_area == 3;
    let save_style = if btn_focused && dialog.selected_button == 0 {
        Style::default()
            .fg(theme.popup_bg)
            .bg(theme.help_key_fg)
            .add_modifier(Modifier::BOLD)
    } else {
        Style::default().fg(theme.popup_text_fg)
    };
    let cancel_style = if btn_focused && dialog.selected_button == 1 {
        Style::default()
            .fg(theme.popup_bg)
            .bg(theme.help_key_fg)
            .add_modifier(Modifier::BOLD)
    } else {
        Style::default().fg(theme.popup_text_fg)
    };
    // Store field areas for mouse hit testing
    editor.layout.dialog_key_field = Some(chunks[2]);
    editor.layout.dialog_action_field = Some(chunks[3]);
    editor.layout.dialog_context_field = Some(chunks[5]);

    let save_text = format!(" {} ", t!("keybinding_editor.btn_save"));
    let cancel_text = format!(" {} ", t!("keybinding_editor.btn_cancel"));
    let save_x = chunks[8].x + 3;
    let cancel_x = save_x + save_text.len() as u16 + 2;
    editor.layout.dialog_buttons = Some((
        Rect {
            x: save_x,
            y: chunks[8].y,
            width: save_text.len() as u16,
            height: 1,
        },
        Rect {
            x: cancel_x,
            y: chunks[8].y,
            width: cancel_text.len() as u16,
            height: 1,
        },
    ));

    frame.render_widget(
        Paragraph::new(Line::from(vec![
            Span::raw("   "),
            Span::styled(save_text, save_style),
            Span::raw("  "),
            Span::styled(cancel_text, cancel_style),
        ])),
        chunks[8],
    );

    // Render autocomplete popup on top of everything if visible
    if dialog.autocomplete_visible && !dialog.autocomplete_suggestions.is_empty() {
        render_autocomplete_popup(frame, chunks[3], dialog, theme);
    }
}

/// Render the autocomplete suggestions popup below the action field
fn render_autocomplete_popup(
    frame: &mut Frame,
    action_field_area: Rect,
    dialog: &crate::app::keybinding_editor::EditBindingState,
    theme: &Theme,
) {
    let suggestion_count = dialog
        .autocomplete_suggestions
        .len()
        .min(MAX_AUTOCOMPLETE_VISIBLE);
    if suggestion_count == 0 {
        return;
    }

    // Position: below the action field, offset to align with text
    let popup_x = action_field_area.x + 12; // offset past "   Action:  "
    let popup_y = action_field_area.y + 1;
    let popup_width = 36u16.min(action_field_area.width.saturating_sub(12));
    let popup_height = (suggestion_count as u16) + 2; // +2 for border

    let popup_area = Rect {
        x: popup_x,
        y: popup_y,
        width: popup_width,
        height: popup_height,
    };

    frame.render_widget(Clear, popup_area);

    let block = Block::default()
        .borders(Borders::ALL)
        .border_style(Style::default().fg(theme.popup_border_fg))
        .style(Style::default().bg(theme.popup_bg).fg(theme.popup_text_fg));
    let inner = block.inner(popup_area);
    frame.render_widget(block, popup_area);

    // Determine scroll offset for autocomplete list
    let selected = dialog.autocomplete_selected.unwrap_or(0);
    let scroll_offset = if selected >= MAX_AUTOCOMPLETE_VISIBLE {
        selected - MAX_AUTOCOMPLETE_VISIBLE + 1
    } else {
        0
    };

    let mut lines: Vec<Line> = Vec::new();
    for (i, suggestion) in dialog
        .autocomplete_suggestions
        .iter()
        .skip(scroll_offset)
        .take(MAX_AUTOCOMPLETE_VISIBLE)
        .enumerate()
    {
        let actual_idx = i + scroll_offset;
        let is_selected = Some(actual_idx) == dialog.autocomplete_selected;

        let style = if is_selected {
            Style::default()
                .fg(theme.popup_bg)
                .bg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD)
        } else {
            Style::default().fg(theme.popup_text_fg).bg(theme.popup_bg)
        };

        // Pad the suggestion to fill the width
        let display = pad_right(suggestion, inner.width as usize);
        lines.push(Line::from(Span::styled(display, style)));
    }

    frame.render_widget(Paragraph::new(lines), inner);
}

/// Render the unsaved changes confirm dialog
fn render_confirm_dialog(
    frame: &mut Frame,
    area: Rect,
    editor: &mut KeybindingEditor,
    theme: &Theme,
) {
    let width = 44u16.min(area.width.saturating_sub(4));
    let height = 7u16.min(area.height.saturating_sub(4));
    let x = area.x + (area.width.saturating_sub(width)) / 2;
    let y = area.y + (area.height.saturating_sub(height)) / 2;

    let dialog_area = Rect {
        x,
        y,
        width,
        height,
    };
    frame.render_widget(Clear, dialog_area);

    let block = Block::default()
        .title(format!(" {} ", t!("keybinding_editor.confirm_title")))
        .borders(Borders::ALL)
        .border_style(Style::default().fg(theme.diagnostic_warning_fg))
        .style(Style::default().bg(theme.popup_bg).fg(theme.popup_text_fg));
    let inner = block.inner(dialog_area);
    frame.render_widget(block, dialog_area);

    let chunks = Layout::vertical([
        Constraint::Length(2), // Message
        Constraint::Length(1), // Spacer
        Constraint::Length(1), // Buttons
    ])
    .split(inner);

    frame.render_widget(
        Paragraph::new(Line::from(Span::styled(
            format!(" {}", t!("keybinding_editor.confirm_message")),
            Style::default().fg(theme.popup_text_fg),
        ))),
        chunks[0],
    );

    let options = [
        t!("keybinding_editor.btn_save").to_string(),
        t!("keybinding_editor.btn_discard").to_string(),
        t!("keybinding_editor.btn_cancel").to_string(),
    ];
    // Compute button areas for mouse hit testing
    let mut x_offset = chunks[2].x + 1;
    let mut btn_rects = Vec::new();
    let mut spans = vec![Span::raw(" ")];
    for (i, opt) in options.iter().enumerate() {
        let style = if i == editor.confirm_selection {
            Style::default()
                .fg(theme.popup_bg)
                .bg(theme.help_key_fg)
                .add_modifier(Modifier::BOLD)
        } else {
            Style::default().fg(theme.popup_text_fg)
        };
        let text = format!(" {} ", opt);
        let text_len = text.len() as u16;
        btn_rects.push(Rect {
            x: x_offset,
            y: chunks[2].y,
            width: text_len,
            height: 1,
        });
        x_offset += text_len + 2; // +2 for spacing
        spans.push(Span::styled(text, style));
        spans.push(Span::raw("  "));
    }
    if btn_rects.len() == 3 {
        editor.layout.confirm_buttons = Some((btn_rects[0], btn_rects[1], btn_rects[2]));
    }

    frame.render_widget(Paragraph::new(Line::from(spans)), chunks[2]);
}

/// Right-pad a string to a given width (in chars), truncating if necessary
fn pad_right(s: &str, width: usize) -> String {
    let char_count = s.chars().count();
    if char_count >= width {
        s.chars().take(width).collect()
    } else {
        let padding = width - char_count;
        format!("{}{}", s, " ".repeat(padding))
    }
}

// ==================== INPUT HANDLING ====================

/// Handle input for the keybinding editor. Returns true if the editor should close.
pub fn handle_keybinding_editor_input(
    editor: &mut KeybindingEditor,
    event: &KeyEvent,
) -> KeybindingEditorAction {
    // Help overlay
    if editor.showing_help {
        match event.code {
            KeyCode::Esc | KeyCode::Char('?') | KeyCode::Enter => {
                editor.showing_help = false;
            }
            _ => {}
        }
        return KeybindingEditorAction::Consumed;
    }

    // Confirm dialog
    if editor.showing_confirm_dialog {
        return handle_confirm_input(editor, event);
    }

    // Edit dialog
    if editor.edit_dialog.is_some() {
        return handle_edit_dialog_input(editor, event);
    }

    // Search mode (only when focused/accepting input)
    if editor.search_active && editor.search_focused {
        return handle_search_input(editor, event);
    }

    // Main table navigation
    handle_main_input(editor, event)
}

/// Actions that the keybinding editor can return to the parent
pub enum KeybindingEditorAction {
    /// Input was consumed, no further action needed
    Consumed,
    /// Close the editor (no save)
    Close,
    /// Save and close
    SaveAndClose,
    /// Status message to display
    StatusMessage(String),
}

fn handle_main_input(editor: &mut KeybindingEditor, event: &KeyEvent) -> KeybindingEditorAction {
    match (event.code, event.modifiers) {
        // Close / clear search
        (KeyCode::Esc, KeyModifiers::NONE) => {
            if editor.search_active {
                // Search is visible but unfocused — clear it
                editor.cancel_search();
                KeybindingEditorAction::Consumed
            } else if editor.has_changes {
                editor.showing_confirm_dialog = true;
                editor.confirm_selection = 0;
                KeybindingEditorAction::Consumed
            } else {
                KeybindingEditorAction::Close
            }
        }

        // Save
        (KeyCode::Char('s'), m) if m.contains(KeyModifiers::CONTROL) => {
            KeybindingEditorAction::SaveAndClose
        }

        // Navigation
        (KeyCode::Up, KeyModifiers::NONE) | (KeyCode::Char('k'), KeyModifiers::NONE) => {
            editor.select_prev();
            KeybindingEditorAction::Consumed
        }
        (KeyCode::Down, KeyModifiers::NONE) | (KeyCode::Char('j'), KeyModifiers::NONE) => {
            editor.select_next();
            KeybindingEditorAction::Consumed
        }
        (KeyCode::PageUp, _) => {
            editor.page_up();
            KeybindingEditorAction::Consumed
        }
        (KeyCode::PageDown, _) => {
            editor.page_down();
            KeybindingEditorAction::Consumed
        }
        (KeyCode::Home, _) => {
            editor.selected = 0;
            editor.scroll.offset = 0;
            KeybindingEditorAction::Consumed
        }
        (KeyCode::End, _) => {
            editor.selected = editor.display_rows.len().saturating_sub(1);
            editor.ensure_visible_public();
            KeybindingEditorAction::Consumed
        }

        // Search (re-focuses existing search if visible)
        (KeyCode::Char('/'), KeyModifiers::NONE) => {
            editor.start_search();
            KeybindingEditorAction::Consumed
        }

        // Record key search
        (KeyCode::Char('r'), KeyModifiers::NONE) => {
            editor.start_record_key_search();
            KeybindingEditorAction::Consumed
        }

        // Help
        (KeyCode::Char('?'), _) => {
            editor.showing_help = true;
            KeybindingEditorAction::Consumed
        }

        // Add binding
        (KeyCode::Char('a'), KeyModifiers::NONE) => {
            editor.open_add_dialog();
            KeybindingEditorAction::Consumed
        }

        // Enter: toggle section header or edit binding
        (KeyCode::Enter, KeyModifiers::NONE) => {
            if editor.selected_is_section_header() {
                editor.toggle_section_at_selected();
            } else {
                editor.open_edit_dialog();
            }
            KeybindingEditorAction::Consumed
        }

        // Delete binding
        (KeyCode::Char('d'), KeyModifiers::NONE) | (KeyCode::Delete, _) => {
            match editor.delete_selected() {
                DeleteResult::CustomRemoved => KeybindingEditorAction::StatusMessage(
                    t!("keybinding_editor.status_binding_removed").to_string(),
                ),
                DeleteResult::KeymapOverridden => KeybindingEditorAction::StatusMessage(
                    t!("keybinding_editor.status_keymap_overridden").to_string(),
                ),
                DeleteResult::CannotDelete | DeleteResult::NothingSelected => {
                    KeybindingEditorAction::StatusMessage(
                        t!("keybinding_editor.status_cannot_delete").to_string(),
                    )
                }
            }
        }

        // Context filter
        (KeyCode::Char('c'), KeyModifiers::NONE) => {
            editor.cycle_context_filter();
            KeybindingEditorAction::Consumed
        }

        // Source filter
        (KeyCode::Char('s'), KeyModifiers::NONE) => {
            editor.cycle_source_filter();
            KeybindingEditorAction::Consumed
        }

        _ => KeybindingEditorAction::Consumed,
    }
}

fn handle_search_input(editor: &mut KeybindingEditor, event: &KeyEvent) -> KeybindingEditorAction {
    match editor.search_mode {
        SearchMode::Text => match (event.code, event.modifiers) {
            (KeyCode::Esc, _) => {
                editor.cancel_search();
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Enter, _) | (KeyCode::Down, _) => {
                // Unfocus search, keep results visible, move to list
                editor.search_focused = false;
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Up, _) => {
                // Unfocus search, move to list, select last item
                editor.search_focused = false;
                editor.selected = editor.filtered_indices.len().saturating_sub(1);
                editor.ensure_visible_public();
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Tab, _) => {
                // Switch to record key mode
                editor.search_mode = SearchMode::RecordKey;
                editor.search_key_display.clear();
                editor.search_key_code = None;
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Backspace, _) => {
                editor.search_query.pop();
                editor.apply_filters();
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Char(c), m) if !m.contains(KeyModifiers::CONTROL) => {
                editor.search_query.push(c);
                editor.apply_filters();
                KeybindingEditorAction::Consumed
            }
            _ => KeybindingEditorAction::Consumed,
        },
        SearchMode::RecordKey => match (event.code, event.modifiers) {
            (KeyCode::Esc, KeyModifiers::NONE) => {
                editor.cancel_search();
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Tab, KeyModifiers::NONE) => {
                // Switch to text mode, preserve query
                editor.search_mode = SearchMode::Text;
                editor.apply_filters();
                KeybindingEditorAction::Consumed
            }
            (KeyCode::Enter, KeyModifiers::NONE) => {
                // Unfocus search, keep results visible
                editor.search_focused = false;
                KeybindingEditorAction::Consumed
            }
            _ => {
                // Record the key
                editor.record_search_key(event);
                KeybindingEditorAction::Consumed
            }
        },
    }
}

fn handle_edit_dialog_input(
    editor: &mut KeybindingEditor,
    event: &KeyEvent,
) -> KeybindingEditorAction {
    // Take the dialog out to avoid borrow conflicts
    let mut dialog = match editor.edit_dialog.take() {
        Some(d) => d,
        None => return KeybindingEditorAction::Consumed,
    };

    // In special-capture mode on the key field, record the very next key
    // (including Esc, Tab, Enter) and exit capture mode.
    if dialog.capturing_special && dialog.focus_area == 0 {
        match event.code {
            KeyCode::Modifier(_) => {} // ignore bare modifier presses
            _ => {
                dialog.key_code = Some(event.code);
                dialog.modifiers = event.modifiers;
                dialog.key_display = format_keybinding(&event.code, &event.modifiers);
                dialog.conflicts =
                    editor.find_conflicts(event.code, event.modifiers, &dialog.context);
                dialog.capturing_special = false;
            }
        }
        editor.edit_dialog = Some(dialog);
        return KeybindingEditorAction::Consumed;
    }

    // Close dialog on Esc
    if event.code == KeyCode::Esc && event.modifiers == KeyModifiers::NONE {
        // Don't put it back - it's closed
        return KeybindingEditorAction::Consumed;
    }

    match dialog.focus_area {
        0 => {
            // Key recording area
            match (event.code, event.modifiers) {
                // Enter enters special-capture mode for the next keypress
                (KeyCode::Enter, KeyModifiers::NONE) => {
                    dialog.capturing_special = true;
                }
                (KeyCode::Tab | KeyCode::Down, KeyModifiers::NONE) => {
                    dialog.focus_area = 1;
                    dialog.mode = EditMode::EditingAction;
                }
                _ => {
                    // Keys are only recorded via capture mode (Enter then key).
                    // Ignore everything else in the key field.
                }
            }
        }
        1 => {
            // Action editing area with autocomplete
            match (event.code, event.modifiers) {
                (KeyCode::Tab, KeyModifiers::NONE) => {
                    // Accept selected autocomplete suggestion, or move to next field
                    if dialog.autocomplete_visible {
                        if let Some(sel) = dialog.autocomplete_selected {
                            if sel < dialog.autocomplete_suggestions.len() {
                                let suggestion = dialog.autocomplete_suggestions[sel].clone();
                                dialog.action_text = suggestion;
                                dialog.action_cursor = dialog.action_text.len();
                                dialog.autocomplete_visible = false;
                                dialog.autocomplete_selected = None;
                                dialog.action_error = None;
                            }
                        }
                    } else {
                        dialog.focus_area = 2;
                        dialog.mode = EditMode::EditingContext;
                    }
                }
                (KeyCode::BackTab, _) => {
                    dialog.autocomplete_visible = false;
                    dialog.focus_area = 0;
                    dialog.mode = EditMode::RecordingKey;
                }
                (KeyCode::Enter, KeyModifiers::NONE) => {
                    // Accept selected autocomplete suggestion, or move to buttons
                    if dialog.autocomplete_visible {
                        if let Some(sel) = dialog.autocomplete_selected {
                            if sel < dialog.autocomplete_suggestions.len() {
                                let suggestion = dialog.autocomplete_suggestions[sel].clone();
                                dialog.action_text = suggestion;
                                dialog.action_cursor = dialog.action_text.len();
                                dialog.autocomplete_visible = false;
                                dialog.autocomplete_selected = None;
                                dialog.action_error = None;
                            }
                        }
                    } else {
                        dialog.focus_area = 3;
                        dialog.selected_button = 0;
                        dialog.mode = EditMode::EditingContext;
                    }
                }
                (KeyCode::Up, _) if dialog.autocomplete_visible => {
                    // Navigate autocomplete up
                    if let Some(sel) = dialog.autocomplete_selected {
                        if sel > 0 {
                            dialog.autocomplete_selected = Some(sel - 1);
                        }
                    }
                }
                (KeyCode::Down, _) if dialog.autocomplete_visible => {
                    // Navigate autocomplete down
                    if let Some(sel) = dialog.autocomplete_selected {
                        let max = dialog.autocomplete_suggestions.len().saturating_sub(1);
                        if sel < max {
                            dialog.autocomplete_selected = Some(sel + 1);
                        }
                    }
                }
                (KeyCode::Up, KeyModifiers::NONE) => {
                    // Move to previous field (key)
                    dialog.autocomplete_visible = false;
                    dialog.focus_area = 0;
                    dialog.mode = EditMode::RecordingKey;
                }
                (KeyCode::Down, KeyModifiers::NONE) => {
                    // Move to next field (context)
                    dialog.focus_area = 2;
                    dialog.mode = EditMode::EditingContext;
                }
                (KeyCode::Esc, _) if dialog.autocomplete_visible => {
                    // Close autocomplete without closing dialog
                    dialog.autocomplete_visible = false;
                    dialog.autocomplete_selected = None;
                    // Put dialog back and return early (don't let outer Esc handler close dialog)
                    editor.edit_dialog = Some(dialog);
                    return KeybindingEditorAction::Consumed;
                }
                (KeyCode::Backspace, _) => {
                    if dialog.action_cursor > 0 {
                        dialog.action_cursor -= 1;
                        dialog.action_text.remove(dialog.action_cursor);
                        dialog.action_error = None;
                    }
                    // Put dialog back and update autocomplete
                    editor.edit_dialog = Some(dialog);
                    editor.update_autocomplete();
                    return KeybindingEditorAction::Consumed;
                }
                (KeyCode::Char(c), m) if !m.contains(KeyModifiers::CONTROL) => {
                    dialog.action_text.insert(dialog.action_cursor, c);
                    dialog.action_cursor += 1;
                    dialog.action_error = None;
                    // Put dialog back and update autocomplete
                    editor.edit_dialog = Some(dialog);
                    editor.update_autocomplete();
                    return KeybindingEditorAction::Consumed;
                }
                _ => {}
            }
        }
        2 => {
            // Context selection area
            match (event.code, event.modifiers) {
                (KeyCode::Tab | KeyCode::Down, KeyModifiers::NONE) => {
                    dialog.focus_area = 3;
                    dialog.selected_button = 0;
                }
                (KeyCode::BackTab, _) | (KeyCode::Up, KeyModifiers::NONE) => {
                    dialog.focus_area = 1;
                    dialog.mode = EditMode::EditingAction;
                }
                (KeyCode::Left, _) => {
                    if dialog.context_option_index > 0 {
                        dialog.context_option_index -= 1;
                        dialog.context =
                            dialog.context_options[dialog.context_option_index].clone();
                        // Update conflicts
                        if let Some(key_code) = dialog.key_code {
                            dialog.conflicts =
                                editor.find_conflicts(key_code, dialog.modifiers, &dialog.context);
                        }
                    }
                }
                (KeyCode::Right, _) => {
                    if dialog.context_option_index + 1 < dialog.context_options.len() {
                        dialog.context_option_index += 1;
                        dialog.context =
                            dialog.context_options[dialog.context_option_index].clone();
                        if let Some(key_code) = dialog.key_code {
                            dialog.conflicts =
                                editor.find_conflicts(key_code, dialog.modifiers, &dialog.context);
                        }
                    }
                }
                (KeyCode::Enter, _) => {
                    dialog.focus_area = 3;
                    dialog.selected_button = 0;
                }
                _ => {}
            }
        }
        3 => {
            // Buttons area
            match (event.code, event.modifiers) {
                (KeyCode::Tab, KeyModifiers::NONE) => {
                    if dialog.selected_button < 1 {
                        // Move from Save to Cancel
                        dialog.selected_button = 1;
                    } else {
                        // Wrap from Cancel to Key field
                        dialog.focus_area = 0;
                        dialog.mode = EditMode::RecordingKey;
                    }
                }
                (KeyCode::BackTab, _) => {
                    if dialog.selected_button > 0 {
                        // Move from Cancel to Save
                        dialog.selected_button = 0;
                    } else {
                        // Wrap from Save to Context field
                        dialog.focus_area = 2;
                        dialog.mode = EditMode::EditingContext;
                    }
                }
                (KeyCode::Up, KeyModifiers::NONE) => {
                    dialog.focus_area = 2;
                    dialog.mode = EditMode::EditingContext;
                }
                (KeyCode::Left, _) => {
                    if dialog.selected_button > 0 {
                        dialog.selected_button -= 1;
                    }
                }
                (KeyCode::Right, _) => {
                    if dialog.selected_button < 1 {
                        dialog.selected_button += 1;
                    }
                }
                (KeyCode::Enter, _) => {
                    if dialog.selected_button == 0 {
                        // Save - put the dialog back first so apply_edit_dialog can take it
                        editor.edit_dialog = Some(dialog);
                        if let Some(err) = editor.apply_edit_dialog() {
                            // Validation failed - dialog is still open with error
                            return KeybindingEditorAction::StatusMessage(err);
                        }
                        return KeybindingEditorAction::Consumed;
                    } else {
                        // Cancel - don't put dialog back
                        return KeybindingEditorAction::Consumed;
                    }
                }
                _ => {}
            }
        }
        _ => {}
    }

    // Put the dialog back
    editor.edit_dialog = Some(dialog);
    KeybindingEditorAction::Consumed
}

fn handle_confirm_input(editor: &mut KeybindingEditor, event: &KeyEvent) -> KeybindingEditorAction {
    match (event.code, event.modifiers) {
        (KeyCode::Left, _) => {
            if editor.confirm_selection > 0 {
                editor.confirm_selection -= 1;
            }
            KeybindingEditorAction::Consumed
        }
        (KeyCode::Right, _) => {
            if editor.confirm_selection < 2 {
                editor.confirm_selection += 1;
            }
            KeybindingEditorAction::Consumed
        }
        (KeyCode::Enter, _) => match editor.confirm_selection {
            0 => KeybindingEditorAction::SaveAndClose,
            1 => KeybindingEditorAction::Close, // Discard
            _ => {
                editor.showing_confirm_dialog = false;
                KeybindingEditorAction::Consumed
            }
        },
        (KeyCode::Esc, _) => {
            editor.showing_confirm_dialog = false;
            KeybindingEditorAction::Consumed
        }
        _ => KeybindingEditorAction::Consumed,
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    /// The modal must stay fully inside the area it is handed and be
    /// horizontally centred within it. Regression test for the
    /// orchestrator-dock case where the editor passes the post-dock-split
    /// `chrome_area` (with a non-zero `x`): the modal used to be placed
    /// relative to column 0, bleeding left under the dock and ending up
    /// off-centre.
    #[test]
    fn modal_centres_within_offset_area_left_of_dock() {
        // Full screen 120x40 with a 34-column left dock carved off, so the
        // chrome area starts at x = 34.
        let chrome = Rect::new(34, 0, 120 - 34, 40);
        let modal = keybinding_modal_area(chrome);

        // Fully contained within the chrome area — never bleeds under the
        // dock (left edge) or past the right/bottom edges.
        assert!(modal.x >= chrome.x, "modal bleeds left under the dock");
        assert!(
            modal.x + modal.width <= chrome.x + chrome.width,
            "modal overflows the right edge"
        );
        assert!(
            modal.y + modal.height <= chrome.y + chrome.height,
            "modal overflows the bottom edge"
        );

        // Horizontally centred within the chrome area: left and right
        // margins are equal (within one column for odd remainders).
        let left_margin = modal.x - chrome.x;
        let right_margin = (chrome.x + chrome.width) - (modal.x + modal.width);
        assert!(
            left_margin.abs_diff(right_margin) <= 1,
            "modal not centred: left={left_margin} right={right_margin}"
        );
    }

    /// With no dock (area at origin) the modal is still centred — the
    /// offsets must not regress the common full-screen case.
    #[test]
    fn modal_centres_within_full_screen() {
        let area = Rect::new(0, 0, 120, 40);
        let modal = keybinding_modal_area(area);

        let left_margin = modal.x;
        let right_margin = area.width - (modal.x + modal.width);
        assert!(
            left_margin.abs_diff(right_margin) <= 1,
            "modal not centred on full screen: left={left_margin} right={right_margin}"
        );
        assert!(modal.x + modal.width <= area.width);
        assert!(modal.y + modal.height <= area.height);
    }
}