1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
use fj_math::{Point, Scalar, Winding};
use crate::{
objects::{Cycle, Face, Surface, SurfaceVertex},
storage::Handle,
};
use super::{Validate, ValidationConfig, ValidationError};
impl Validate for Face {
fn validate_with_config(
&self,
config: &ValidationConfig,
errors: &mut Vec<ValidationError>,
) {
FaceValidationError::check_interior_winding(self, errors);
FaceValidationError::check_vertex_positions(self, config, errors);
}
}
#[derive(Clone, Debug, thiserror::Error)]
pub enum FaceValidationError {
#[error(
"`Surface` of an interior `Cycle` doesn't match `Face`'s `Surface`\n\
- `Surface` of the `Face`: {surface:#?}\n\
- Invalid interior `Cycle`: {interior:#?}\n\
- `Face`: {face:#?}"
)]
SurfaceMismatch {
surface: Handle<Surface>,
interior: Handle<Cycle>,
face: Face,
},
#[error(
"Interior of `Face` has invalid winding; must be opposite of exterior\n\
- Winding of exterior cycle: {exterior_winding:#?}\n\
- Winding of interior cycle: {interior_winding:#?}\n\
- `Face`: {face:#?}"
)]
InvalidInteriorWinding {
exterior_winding: Winding,
interior_winding: Winding,
face: Face,
},
#[error(
"`SurfaceVertex` position doesn't match position of its global form\n\
- Surface position: {surface_position:?}\n\
- Surface position converted to global position: \
{surface_position_as_global:?}\n\
- Global position: {global_position:?}\n\
- Distance between the positions: {distance}\n\
- `SurfaceVertex`: {surface_vertex:#?}"
)]
VertexPositionMismatch {
surface_position: Point<2>,
surface_position_as_global: Point<3>,
global_position: Point<3>,
distance: Scalar,
surface_vertex: Handle<SurfaceVertex>,
},
}
impl FaceValidationError {
fn check_interior_winding(face: &Face, errors: &mut Vec<ValidationError>) {
let exterior_winding = face.exterior().winding();
for interior in face.interiors() {
let interior_winding = interior.winding();
if exterior_winding == interior_winding {
errors.push(
Box::new(Self::InvalidInteriorWinding {
exterior_winding,
interior_winding,
face: face.clone(),
})
.into(),
);
}
}
}
fn check_vertex_positions(
face: &Face,
config: &ValidationConfig,
errors: &mut Vec<ValidationError>,
) {
for cycle in face.all_cycles() {
for half_edge in cycle.half_edges() {
for surface_vertex in half_edge.surface_vertices() {
let surface_position_as_global = face
.surface()
.geometry()
.point_from_surface_coords(surface_vertex.position());
let global_position =
surface_vertex.global_form().position();
let distance = surface_position_as_global
.distance_to(&global_position);
if distance > config.identical_max_distance {
errors.push(
Box::new(Self::VertexPositionMismatch {
surface_position: surface_vertex.position(),
surface_position_as_global,
global_position,
distance,
surface_vertex: surface_vertex.clone(),
})
.into(),
);
}
}
}
}
}
}
#[cfg(test)]
mod tests {
use fj_interop::ext::ArrayExt;
use fj_math::{Scalar, Vector};
use crate::{
algorithms::reverse::Reverse,
builder::{CycleBuilder, FaceBuilder, HalfEdgeBuilder},
insert::Insert,
objects::{Cycle, Face, HalfEdge, SurfaceVertex},
partial::{Partial, PartialCycle, PartialFace, PartialObject},
services::Services,
validate::Validate,
};
#[test]
fn face_surface_mismatch() -> anyhow::Result<()> {
let mut services = Services::new();
let valid = {
let mut face = PartialFace {
surface: Partial::from(services.objects.surfaces.xy_plane()),
..Default::default()
};
face.exterior.write().update_as_polygon_from_points([
[0., 0.],
[3., 0.],
[0., 3.],
]);
face.add_interior().write().update_as_polygon_from_points([
[1., 1.],
[1., 2.],
[2., 1.],
]);
face.build(&mut services.objects)
};
let invalid = {
let surface = services.objects.surfaces.xz_plane();
let mut cycle = PartialCycle::default();
cycle.update_as_polygon_from_points([[1., 1.], [1., 2.], [2., 1.]]);
cycle.infer_vertex_positions_if_necessary(&surface.geometry());
let cycle = cycle
.build(&mut services.objects)
.insert(&mut services.objects);
let interiors = [cycle];
Face::new(
valid.surface().clone(),
valid.exterior().clone(),
interiors,
valid.color(),
)
};
valid.validate_and_return_first_error()?;
assert!(invalid.validate_and_return_first_error().is_err());
Ok(())
}
#[test]
fn face_invalid_interior_winding() -> anyhow::Result<()> {
let mut services = Services::new();
let valid = {
let mut face = PartialFace {
surface: Partial::from(services.objects.surfaces.xy_plane()),
..Default::default()
};
face.exterior.write().update_as_polygon_from_points([
[0., 0.],
[3., 0.],
[0., 3.],
]);
face.add_interior().write().update_as_polygon_from_points([
[1., 1.],
[1., 2.],
[2., 1.],
]);
face.build(&mut services.objects)
};
let invalid = {
let interiors = valid
.interiors()
.cloned()
.map(|cycle| cycle.reverse(&mut services.objects))
.collect::<Vec<_>>();
Face::new(
valid.surface().clone(),
valid.exterior().clone(),
interiors,
valid.color(),
)
};
valid.validate_and_return_first_error()?;
assert!(invalid.validate_and_return_first_error().is_err());
Ok(())
}
#[test]
fn surface_vertex_position_mismatch() -> anyhow::Result<()> {
let mut services = Services::new();
let valid = {
let surface = services.objects.surfaces.xy_plane();
let mut face = PartialFace {
surface: Partial::from(surface.clone()),
..Default::default()
};
let mut half_edge = face.exterior.write().add_half_edge();
half_edge.write().update_as_circle_from_radius(1.);
half_edge
.write()
.infer_vertex_positions_if_necessary(&surface.geometry());
face.build(&mut services.objects)
};
let invalid = {
let half_edge = {
let half_edge = valid.exterior().half_edges().next().unwrap();
let boundary = half_edge
.boundary()
.map(|point| point + Vector::from([Scalar::PI / 2.]));
let mut surface_vertices =
half_edge.surface_vertices().map(Clone::clone);
let mut invalid = None;
for surface_vertex in surface_vertices.each_mut_ext() {
let invalid = invalid.get_or_insert_with(|| {
SurfaceVertex::new(
[0., 1.],
surface_vertex.global_form().clone(),
)
.insert(&mut services.objects)
});
*surface_vertex = invalid.clone();
}
let boundary = boundary.zip_ext(surface_vertices);
HalfEdge::new(
half_edge.curve(),
boundary,
half_edge.global_form().clone(),
)
.insert(&mut services.objects)
};
let exterior =
Cycle::new([half_edge]).insert(&mut services.objects);
Face::new(
valid.surface().clone(),
exterior,
valid.interiors().cloned(),
valid.color(),
)
};
valid.validate_and_return_first_error()?;
assert!(invalid.validate_and_return_first_error().is_err());
Ok(())
}
}