feagi_brain_development/

connectome_manager.rs

// Copyright 2025 Neuraville Inc.
// SPDX-License-Identifier: Apache-2.0

/*!
ConnectomeManager - Core brain connectivity manager.

This is the central orchestrator for the FEAGI connectome, managing:
- Cortical areas and their metadata
- Brain regions and hierarchy
- Neuron/synapse queries (delegates to NPU for actual data)
- Genome loading and persistence

## Architecture

The ConnectomeManager is a **metadata manager** that:
1. Stores cortical area/region definitions
2. Provides a high-level API for brain structure queries
3. Delegates neuron/synapse CRUD to the NPU (Structure of Arrays)

## Design Principles

- **Singleton**: One global instance per FEAGI process
- **Thread-safe**: Uses RwLock for concurrent reads
- **Performance**: Optimized for hot-path queries (area lookups)
- **NPU Delegation**: Neuron/synapse data lives in NPU, not here

Copyright 2025 Neuraville Inc.
Licensed under the Apache License, Version 2.0
*/

use once_cell::sync::Lazy;
use parking_lot::RwLock;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::hash::Hasher;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Arc, Mutex};
use tracing::{debug, error, info, trace, warn};
use xxhash_rust::xxh64::Xxh64;

/// Merged region `inputs` / `outputs` (base64 cortical IDs) after `recompute_brain_region_io_registry`.
pub type BrainRegionIoRegistry = HashMap<String, (Vec<String>, Vec<String>)>;

use crate::models::{BrainRegion, BrainRegionHierarchy, CorticalArea, CorticalAreaDimensions};
use crate::types::{BduError, BduResult};
use feagi_npu_neural::synapse::SYNAPSE_EDGE_ASSOCIATIVE_MEMORY;
use feagi_npu_neural::types::NeuronId;
use feagi_structures::genomic::cortical_area::{
    CoreCorticalType, CorticalAreaType, CorticalID, CustomCorticalType,
};
use feagi_structures::genomic::descriptors::GenomeCoordinate3D;

// State manager access for fatigue calculation
// Note: feagi-state-manager is always available when std is enabled (it's a default feature)
use feagi_state_manager::StateManager;

const DATA_HASH_SEED: u64 = 0;
// JSON number precision (Godot) is limited to 53 bits; mask to keep hashes stable across transports.
const HASH_SAFE_MASK: u64 = (1u64 << 53) - 1;

// NPU integration (optional dependency)
// use feagi_npu_burst_engine::RustNPU; // Now using DynamicNPU

/// Global singleton instance of ConnectomeManager
static INSTANCE: Lazy<Arc<RwLock<ConnectomeManager>>> =
    Lazy::new(|| Arc::new(RwLock::new(ConnectomeManager::new())));

/// Configuration for ConnectomeManager
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ConnectomeConfig {
    /// Maximum number of neurons (for NPU sizing)
    pub max_neurons: usize,

    /// Maximum number of synapses (for NPU sizing)
    pub max_synapses: usize,

    /// Backend type ("cpu", "cuda", "wgpu")
    pub backend: String,
}

impl Default for ConnectomeConfig {
    fn default() -> Self {
        Self {
            max_neurons: 10_000_000,
            max_synapses: 100_000_000,
            backend: "cpu".to_string(),
        }
    }
}

/// One-call diagnostic for memory twin creation/health on a mapping pair.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct MemoryTwinDiagnostic {
    pub src_cortical_area: String,
    pub dst_cortical_area: String,
    pub src_cortical_type: String,
    pub dst_cortical_type: String,
    pub mapping_exists: bool,
    pub episodic_rule_count: usize,
    pub twin_expected: bool,
    pub twin_present: bool,
    pub twin_cortical_area: Option<String>,
    pub reason: Option<String>,
    pub src_parent_region_id: Option<String>,
    pub dst_parent_region_id: Option<String>,
    pub twin_parent_region_id: Option<String>,
    pub twin_parent_matches_src_parent: Option<bool>,
}

/// Central manager for the FEAGI connectome
///
/// ## Responsibilities
///
/// 1. **Cortical Area Management**: Add, remove, query cortical areas
/// 2. **Brain Region Management**: Hierarchical organization
/// 3. **Neuron/Synapse Queries**: High-level API (delegates to NPU)
/// 4. **Genome I/O**: Load/save brain structure
///
/// ## Data Storage
///
/// - **Cortical areas**: Stored in HashMap for O(1) lookup
/// - **Brain regions**: Stored in BrainRegionHierarchy
/// - **Neuron data**: Lives in NPU (not stored here)
/// - **Synapse data**: Lives in NPU (not stored here)
///
/// ## Thread Safety
///
/// Uses `RwLock` for concurrent reads with exclusive writes.
/// Multiple threads can read simultaneously, but writes block.
///
pub struct ConnectomeManager {
    /// Map of cortical_id -> CorticalArea metadata
    cortical_areas: HashMap<CorticalID, CorticalArea>,

    /// Map of cortical_id -> cortical_idx (fast reverse lookup)
    cortical_id_to_idx: HashMap<CorticalID, u32>,

    /// Map of cortical_idx -> cortical_id (fast reverse lookup)
    cortical_idx_to_id: HashMap<u32, CorticalID>,

    /// Next available cortical index
    next_cortical_idx: u32,

    /// Brain region hierarchy
    brain_regions: BrainRegionHierarchy,

    /// Morphology registry from loaded genome
    morphology_registry: feagi_evolutionary::MorphologyRegistry,

    /// Configuration
    config: ConnectomeConfig,

    /// Optional reference to the Rust NPU for neuron/synapse queries
    ///
    /// This is set by the Python process manager after NPU initialization.
    /// All neuron/synapse data queries delegate to the NPU.
    /// Wrapped in TracingMutex to automatically log all lock acquisitions
    npu: Option<Arc<feagi_npu_burst_engine::TracingMutex<feagi_npu_burst_engine::DynamicNPU>>>,

    /// Plasticity executor reference (optional, only when plasticity feature is enabled)
    #[cfg(feature = "plasticity")]
    plasticity_executor:
        Option<Arc<std::sync::Mutex<feagi_npu_plasticity::AsyncPlasticityExecutor>>>,

    /// Cached neuron count (lock-free read) - updated by burst engine
    /// This prevents health checks from blocking on NPU lock
    cached_neuron_count: Arc<AtomicUsize>,

    /// Cached synapse count (lock-free read) - updated by burst engine
    /// This prevents health checks from blocking on NPU lock
    cached_synapse_count: Arc<AtomicUsize>,

    /// Per-area neuron count cache (lock-free reads) - updated when neurons are created/deleted
    /// This prevents health checks from blocking on NPU lock
    cached_neuron_counts_per_area: Arc<RwLock<HashMap<CorticalID, AtomicUsize>>>,

    /// Per-area synapse count cache (lock-free reads) - updated when synapses are created/deleted
    /// This prevents health checks from blocking on NPU lock
    cached_synapse_counts_per_area: Arc<RwLock<HashMap<CorticalID, AtomicUsize>>>,

    /// Is the connectome initialized (has cortical areas)?
    initialized: bool,

    /// Last fatigue index calculation time (for rate limiting)
    last_fatigue_calculation: Arc<Mutex<std::time::Instant>>,
}

/// Type alias for neuron batch data: (x, y, z, threshold, threshold_limit, leak, resting, neuron_type, refractory_period, excitability, consecutive_fire_limit, snooze_period, mp_charge_accumulation)
type NeuronData = (
    u32,
    u32,
    u32,
    f32,
    f32,
    f32,
    f32,
    i32,
    u16,
    f32,
    u16,
    u16,
    bool,
);

impl ConnectomeManager {
    fn get_mapping_rules_for_destination<'a>(
        mapping_dst: &'a serde_json::Map<String, serde_json::Value>,
        dst_area_id: &CorticalID,
    ) -> Option<&'a Vec<serde_json::Value>> {
        if let Some(rules) = mapping_dst
            .get(&dst_area_id.as_base_64())
            .and_then(|value| value.as_array())
        {
            return Some(rules);
        }

        // Compatibility path: some legacy genomes may still store destination IDs
        // as 6/8-char ASCII keys instead of base64. Resolve by semantic ID equality.
        for (raw_dst_key, rules_value) in mapping_dst {
            let parsed_dst = CorticalID::try_from_base_64(raw_dst_key)
                .or_else(|_| CorticalID::try_from_legacy_ascii(raw_dst_key));
            if parsed_dst.as_ref().ok() != Some(dst_area_id) {
                continue;
            }
            if let Some(rules) = rules_value.as_array() {
                return Some(rules);
            }
        }

        None
    }

    /// Create a new ConnectomeManager (private - use `instance()`)
    fn new() -> Self {
        Self {
            cortical_areas: HashMap::new(),
            cortical_id_to_idx: HashMap::new(),
            cortical_idx_to_id: HashMap::new(),
            // CRITICAL: Reserve indices for invariant core areas (0..=6).
            next_cortical_idx: 7, // Reserve 0=_death, 1=_power, 2=_fatigue, 3=_pain, 4=_pleasure, 5=_fear, 6=_hope
            brain_regions: BrainRegionHierarchy::new(),
            morphology_registry: feagi_evolutionary::MorphologyRegistry::new(),
            config: ConnectomeConfig::default(),
            npu: None,
            #[cfg(feature = "plasticity")]
            plasticity_executor: None,
            cached_neuron_count: Arc::new(AtomicUsize::new(0)),
            cached_synapse_count: Arc::new(AtomicUsize::new(0)),
            cached_neuron_counts_per_area: Arc::new(RwLock::new(HashMap::new())),
            cached_synapse_counts_per_area: Arc::new(RwLock::new(HashMap::new())),
            initialized: false,
            last_fatigue_calculation: Arc::new(Mutex::new(
                std::time::Instant::now() - std::time::Duration::from_secs(10),
            )), // Initialize to allow first calculation
        }
    }

    /// Get the global singleton instance
    ///
    /// # Returns
    ///
    /// Arc to the ConnectomeManager wrapped in RwLock
    ///
    /// # Example
    ///
    /// ```ignore
    /// use feagi_brain_development::ConnectomeManager;
    ///
    /// let manager = ConnectomeManager::instance();
    /// let read_lock = manager.read();
    /// let area_count = read_lock.get_cortical_area_count();
    /// ```
    ///
    pub fn instance() -> Arc<RwLock<ConnectomeManager>> {
        // Note: Singleton is always f32 for backward compatibility
        // New code should use ConnectomeManager::<T>::new_for_testing_with_npu() for custom types
        Arc::clone(&*INSTANCE)
    }

    /// Calculate optimal visualization voxel granularity for a cortical area
    ///
    /// This function determines the granularity for aggregated rendering based on:
    /// - Total voxel count (larger areas get larger chunks)
    /// - Aspect ratio (handles thin dimensions like 1024×900×3)
    /// - Target chunk count (~2k-10k chunks for manageable message size)
    ///
    /// # Arguments
    ///
    /// * `dimensions` - The cortical area dimensions (width, height, depth)
    ///
    /// # Returns
    ///
    /// Tuple of (chunk_x, chunk_y, chunk_z) that divides evenly into dimensions
    ///
    ///
    /// Create a new isolated instance for testing
    ///
    /// This bypasses the singleton pattern and creates a fresh instance.
    /// Use this in tests to avoid conflicts between parallel test runs.
    ///
    /// # Example
    ///
    /// ```rust
    /// let manager = ConnectomeManager::new_for_testing();
    /// // Use manager in isolated test
    /// ```
    pub fn new_for_testing() -> Self {
        Self {
            cortical_areas: HashMap::new(),
            cortical_id_to_idx: HashMap::new(),
            cortical_idx_to_id: HashMap::new(),
            next_cortical_idx: 0,
            brain_regions: BrainRegionHierarchy::new(),
            morphology_registry: feagi_evolutionary::MorphologyRegistry::new(),
            config: ConnectomeConfig::default(),
            npu: None,
            #[cfg(feature = "plasticity")]
            plasticity_executor: None,
            cached_neuron_count: Arc::new(AtomicUsize::new(0)),
            cached_synapse_count: Arc::new(AtomicUsize::new(0)),
            cached_neuron_counts_per_area: Arc::new(RwLock::new(HashMap::new())),
            cached_synapse_counts_per_area: Arc::new(RwLock::new(HashMap::new())),
            initialized: false,
            last_fatigue_calculation: Arc::new(Mutex::new(
                std::time::Instant::now() - std::time::Duration::from_secs(10),
            )),
        }
    }

    /// Create a new isolated instance for testing with NPU
    ///
    /// This bypasses the singleton pattern and creates a fresh instance with NPU connected.
    /// Use this in tests to avoid conflicts between parallel test runs.
    ///
    /// # Arguments
    ///
    /// * `npu` - Arc<TracingMutex<DynamicNPU>> to connect to this manager
    ///
    /// # Example
    ///
    /// ```rust
    /// let npu = Arc::new(TracingMutex::new(RustNPU::new(1_000_000, 10_000_000, 10), "NPU"));
    /// let manager = ConnectomeManager::new_for_testing_with_npu(npu);
    /// ```
    pub fn new_for_testing_with_npu(
        npu: Arc<feagi_npu_burst_engine::TracingMutex<feagi_npu_burst_engine::DynamicNPU>>,
    ) -> Self {
        Self {
            cortical_areas: HashMap::new(),
            cortical_id_to_idx: HashMap::new(),
            cortical_idx_to_id: HashMap::new(),
            next_cortical_idx: 7,
            brain_regions: BrainRegionHierarchy::new(),
            morphology_registry: feagi_evolutionary::MorphologyRegistry::new(),
            config: ConnectomeConfig::default(),
            npu: Some(npu),
            #[cfg(feature = "plasticity")]
            plasticity_executor: None,
            cached_neuron_count: Arc::new(AtomicUsize::new(0)),
            cached_synapse_count: Arc::new(AtomicUsize::new(0)),
            cached_neuron_counts_per_area: Arc::new(RwLock::new(HashMap::new())),
            cached_synapse_counts_per_area: Arc::new(RwLock::new(HashMap::new())),
            initialized: false,
            last_fatigue_calculation: Arc::new(Mutex::new(
                std::time::Instant::now() - std::time::Duration::from_secs(10),
            )),
        }
    }

    /// Set up core morphologies in the registry (for testing only)
    ///
    /// This is a test helper to set up core morphologies (projector, block_to_block, etc.)
    /// in the morphology registry so that synaptogenesis tests can run.
    ///
    /// # Note
    ///
    /// This should only be called in tests. Morphologies are typically loaded from genome files.
    /// This method is public to allow integration tests to access it.
    pub fn setup_core_morphologies_for_testing(&mut self) {
        feagi_evolutionary::add_core_morphologies(&mut self.morphology_registry);
    }

    /// Reset the singleton (for testing only)
    ///
    /// # Safety
    ///
    /// This should only be called in tests to reset state between test runs.
    /// Calling this in production code will cause all references to the old
    /// instance to become stale.
    ///
    #[cfg(test)]
    pub fn reset_for_testing() {
        let mut instance = INSTANCE.write();
        *instance = Self::new();
    }

    // ======================================================================
    // Data Hashing (event-driven updates for health_check)
    // ======================================================================

    /// Update stored hashes for data types that have changed.
    fn update_state_hashes(
        &self,
        brain_regions: Option<u64>,
        cortical_areas: Option<u64>,
        brain_geometry: Option<u64>,
        morphologies: Option<u64>,
        cortical_mappings: Option<u64>,
    ) {
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        if let Some(value) = brain_regions {
            state_manager.set_brain_regions_hash(value);
        }
        if let Some(value) = cortical_areas {
            state_manager.set_cortical_areas_hash(value);
        }
        if let Some(value) = brain_geometry {
            state_manager.set_brain_geometry_hash(value);
        }
        if let Some(value) = morphologies {
            state_manager.set_morphologies_hash(value);
        }
        if let Some(value) = cortical_mappings {
            state_manager.set_cortical_mappings_hash(value);
        }
    }

    /// Refresh the brain regions hash (hierarchy, membership, and properties).
    fn refresh_brain_regions_hash(&self) {
        let hash = self.compute_brain_regions_hash();
        self.update_state_hashes(Some(hash), None, None, None, None);
    }

    #[allow(dead_code)]
    /// Refresh the cortical areas hash (metadata and properties).
    fn refresh_cortical_areas_hash(&self) {
        let hash = self.compute_cortical_areas_hash();
        self.update_state_hashes(None, Some(hash), None, None, None);
    }

    #[allow(dead_code)]
    /// Refresh the brain geometry hash (positions, dimensions, 2D coordinates).
    fn refresh_brain_geometry_hash(&self) {
        let hash = self.compute_brain_geometry_hash();
        self.update_state_hashes(None, None, Some(hash), None, None);
    }

    /// Refresh the morphologies hash.
    fn refresh_morphologies_hash(&self) {
        let hash = self.compute_morphologies_hash();
        self.update_state_hashes(None, None, None, Some(hash), None);
    }

    /// Refresh the cortical mappings hash.
    pub fn refresh_cortical_mappings_hash(&self) {
        let hash = self.compute_cortical_mappings_hash();
        self.update_state_hashes(None, None, None, None, Some(hash));
    }

    /// Refresh cortical area-related hashes based on the affected data.
    pub fn refresh_cortical_area_hashes(&self, properties_changed: bool, geometry_changed: bool) {
        let cortical_hash = if properties_changed {
            Some(self.compute_cortical_areas_hash())
        } else {
            None
        };
        let geometry_hash = if geometry_changed {
            Some(self.compute_brain_geometry_hash())
        } else {
            None
        };
        self.update_state_hashes(None, cortical_hash, geometry_hash, None, None);
    }

    /// Compute hash for brain regions (hierarchy, membership, and properties).
    fn compute_brain_regions_hash(&self) -> u64 {
        let mut hasher = Xxh64::new(DATA_HASH_SEED);
        let mut region_ids: Vec<String> = self
            .brain_regions
            .get_all_region_ids()
            .into_iter()
            .cloned()
            .collect();
        region_ids.sort();

        for region_id in region_ids {
            let Some(region) = self.brain_regions.get_region(&region_id) else {
                continue;
            };
            Self::hash_str(&mut hasher, &region_id);
            Self::hash_str(&mut hasher, &region.name);
            Self::hash_str(&mut hasher, &region.region_type.to_string());
            let parent_id = self.brain_regions.get_parent(&region_id);
            match parent_id {
                Some(parent) => Self::hash_str(&mut hasher, parent),
                None => Self::hash_str(&mut hasher, "null"),
            }

            let mut cortical_ids: Vec<String> = region
                .cortical_areas
                .iter()
                .map(|id| id.as_base_64())
                .collect();
            cortical_ids.sort();
            for cortical_id in cortical_ids {
                Self::hash_str(&mut hasher, &cortical_id);
            }

            Self::hash_properties_filtered(&mut hasher, &region.properties, &[]);
        }

        hasher.finish() & HASH_SAFE_MASK
    }

    /// Compute hash for cortical areas and properties (excluding mappings).
    fn compute_cortical_areas_hash(&self) -> u64 {
        let mut hasher = Xxh64::new(DATA_HASH_SEED);
        let mut areas: Vec<&CorticalArea> = self.cortical_areas.values().collect();
        areas.sort_by_key(|area| area.cortical_id.as_base_64());

        for area in areas {
            let cortical_id = area.cortical_id.as_base_64();
            Self::hash_str(&mut hasher, &cortical_id);
            hasher.write_u32(area.cortical_idx);
            Self::hash_str(&mut hasher, &area.name);
            Self::hash_str(&mut hasher, &area.cortical_type.to_string());

            let excluded = ["cortical_mapping_dst", "upstream_cortical_areas"];
            Self::hash_properties_filtered(&mut hasher, &area.properties, &excluded);
        }

        hasher.finish() & HASH_SAFE_MASK
    }

    /// Compute hash for brain geometry (area positions, dimensions, and 2D coordinates).
    fn compute_brain_geometry_hash(&self) -> u64 {
        let mut hasher = Xxh64::new(DATA_HASH_SEED);
        let mut areas: Vec<&CorticalArea> = self.cortical_areas.values().collect();
        areas.sort_by_key(|area| area.cortical_id.as_base_64());

        for area in areas {
            let cortical_id = area.cortical_id.as_base_64();
            Self::hash_str(&mut hasher, &cortical_id);

            Self::hash_i32(&mut hasher, area.position.x);
            Self::hash_i32(&mut hasher, area.position.y);
            Self::hash_i32(&mut hasher, area.position.z);

            Self::hash_u32(&mut hasher, area.dimensions.width);
            Self::hash_u32(&mut hasher, area.dimensions.height);
            Self::hash_u32(&mut hasher, area.dimensions.depth);

            let coord_2d = area
                .properties
                .get("coordinate_2d")
                .or_else(|| area.properties.get("coordinates_2d"));
            match coord_2d {
                Some(value) => Self::hash_json_value(&mut hasher, value),
                None => Self::hash_str(&mut hasher, "null"),
            }
        }

        hasher.finish() & HASH_SAFE_MASK
    }

    /// Compute hash for morphologies.
    fn compute_morphologies_hash(&self) -> u64 {
        let mut hasher = Xxh64::new(DATA_HASH_SEED);
        let mut morphology_ids = self.morphology_registry.morphology_ids();
        morphology_ids.sort();

        for morphology_id in morphology_ids {
            if let Some(morphology) = self.morphology_registry.get(&morphology_id) {
                Self::hash_str(&mut hasher, &morphology_id);
                Self::hash_str(&mut hasher, &format!("{:?}", morphology.morphology_type));
                Self::hash_str(&mut hasher, &morphology.class);
                if let Ok(value) = serde_json::to_value(&morphology.parameters) {
                    Self::hash_json_value(&mut hasher, &value);
                }
            }
        }

        hasher.finish() & HASH_SAFE_MASK
    }

    /// Compute hash for cortical mappings (cortical_mapping_dst).
    fn compute_cortical_mappings_hash(&self) -> u64 {
        let mut hasher = Xxh64::new(DATA_HASH_SEED);
        let mut areas: Vec<&CorticalArea> = self.cortical_areas.values().collect();
        areas.sort_by_key(|area| area.cortical_id.as_base_64());

        for area in areas {
            let cortical_id = area.cortical_id.as_base_64();
            Self::hash_str(&mut hasher, &cortical_id);
            if let Some(serde_json::Value::Object(map)) =
                area.properties.get("cortical_mapping_dst")
            {
                let mut dest_ids: Vec<&String> = map.keys().collect();
                dest_ids.sort();
                for dest_id in dest_ids {
                    Self::hash_str(&mut hasher, dest_id);
                    if let Some(value) = map.get(dest_id) {
                        Self::hash_json_value(&mut hasher, value);
                    }
                }
            } else {
                Self::hash_str(&mut hasher, "null");
            }
        }

        hasher.finish() & HASH_SAFE_MASK
    }

    /// Hash a string with a separator to avoid concatenation collisions.
    fn hash_str(hasher: &mut Xxh64, value: &str) {
        hasher.write(value.as_bytes());
        hasher.write_u8(0);
    }

    /// Hash a signed 32-bit integer deterministically.
    fn hash_i32(hasher: &mut Xxh64, value: i32) {
        hasher.write(&value.to_le_bytes());
    }

    /// Hash an unsigned 32-bit integer deterministically.
    fn hash_u32(hasher: &mut Xxh64, value: u32) {
        hasher.write(&value.to_le_bytes());
    }

    /// Hash JSON values deterministically with sorted object keys.
    fn hash_json_value(hasher: &mut Xxh64, value: &serde_json::Value) {
        match value {
            serde_json::Value::Null => {
                hasher.write_u8(0);
            }
            serde_json::Value::Bool(val) => {
                hasher.write_u8(1);
                hasher.write_u8(*val as u8);
            }
            serde_json::Value::Number(num) => {
                hasher.write_u8(2);
                Self::hash_str(hasher, &num.to_string());
            }
            serde_json::Value::String(val) => {
                hasher.write_u8(3);
                Self::hash_str(hasher, val);
            }
            serde_json::Value::Array(items) => {
                hasher.write_u8(4);
                for item in items {
                    Self::hash_json_value(hasher, item);
                }
            }
            serde_json::Value::Object(map) => {
                hasher.write_u8(5);
                let mut keys: Vec<&String> = map.keys().collect();
                keys.sort();
                for key in keys {
                    Self::hash_str(hasher, key);
                    if let Some(val) = map.get(key) {
                        Self::hash_json_value(hasher, val);
                    }
                }
            }
        }
    }

    /// Hash JSON properties deterministically, excluding specific keys.
    fn hash_properties_filtered(
        hasher: &mut Xxh64,
        properties: &HashMap<String, serde_json::Value>,
        excluded_keys: &[&str],
    ) {
        let mut keys: Vec<&String> = properties.keys().collect();
        keys.sort();
        for key in keys {
            if excluded_keys.contains(&key.as_str()) {
                continue;
            }
            Self::hash_str(hasher, key);
            if let Some(value) = properties.get(key) {
                Self::hash_json_value(hasher, value);
            }
        }
    }

    // ======================================================================
    // Cortical Area Management
    // ======================================================================

    /// Add a new cortical area
    ///
    /// # Arguments
    ///
    /// * `area` - The cortical area to add
    ///
    /// # Returns
    ///
    /// The assigned cortical index
    ///
    /// # Errors
    ///
    /// Returns error if:
    /// - An area with the same cortical_id already exists
    /// - The area's cortical_idx conflicts with an existing area
    ///
    pub fn add_cortical_area(&mut self, mut area: CorticalArea) -> BduResult<u32> {
        // Check if area already exists
        if self.cortical_areas.contains_key(&area.cortical_id) {
            return Err(BduError::InvalidArea(format!(
                "Cortical area {} already exists",
                area.cortical_id
            )));
        }

        // CRITICAL: Reserve cortical_idx 0..=6 for invariant core areas.
        // Use feagi-data-processing types as single source of truth
        use feagi_structures::genomic::cortical_area::CoreCorticalType;

        let death_id = CoreCorticalType::Death.to_cortical_id();
        let power_id = CoreCorticalType::Power.to_cortical_id();
        let fatigue_id = CoreCorticalType::Fatigue.to_cortical_id();
        let pain_id = CoreCorticalType::Pain.to_cortical_id();
        let pleasure_id = CoreCorticalType::Pleasure.to_cortical_id();
        let fear_id = CoreCorticalType::Fear.to_cortical_id();
        let hope_id = CoreCorticalType::Hope.to_cortical_id();

        let is_death_area = area.cortical_id == death_id;
        let is_power_area = area.cortical_id == power_id;
        let is_fatigue_area = area.cortical_id == fatigue_id;
        let is_pain_area = area.cortical_id == pain_id;
        let is_pleasure_area = area.cortical_id == pleasure_id;
        let is_fear_area = area.cortical_id == fear_id;
        let is_hope_area = area.cortical_id == hope_id;

        if is_death_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=0 to _death area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 0;
        } else if is_power_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=1 to _power area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 1;
        } else if is_fatigue_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=2 to _fatigue area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 2;
        } else if is_pain_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=3 to _pain area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 3;
        } else if is_pleasure_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=4 to _pleasure area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 4;
        } else if is_fear_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=5 to _fear area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 5;
        } else if is_hope_area {
            trace!(
                target: "feagi-bdu",
                "[CORE-AREA] Assigning RESERVED cortical_idx=6 to _hope area (id={})",
                area.cortical_id
            );
            area.cortical_idx = 6;
        } else {
            // Regular areas: assign cortical_idx if not set (will be >=7 due to reservation)
            if area.cortical_idx == 0 {
                area.cortical_idx = self.next_cortical_idx;
                self.next_cortical_idx += 1;
                trace!(
                    target: "feagi-bdu",
                    "[REGULAR-AREA] Assigned cortical_idx={} to area '{}' (should be >=7)",
                    area.cortical_idx,
                    area.cortical_id.as_base_64()
                );
            } else {
                // Check for reserved index collision
                if area.cortical_idx <= 6 {
                    warn!(
                        "Regular area '{}' attempted to use RESERVED cortical_idx={}! Reassigning to next available.",
                        area.cortical_id, area.cortical_idx);
                    area.cortical_idx = self.next_cortical_idx;
                    self.next_cortical_idx += 1;
                    info!(
                        "   Reassigned '{}' to cortical_idx={}",
                        area.cortical_id, area.cortical_idx
                    );
                } else if self.cortical_idx_to_id.contains_key(&area.cortical_idx) {
                    return Err(BduError::InvalidArea(format!(
                        "Cortical index {} is already in use",
                        area.cortical_idx
                    )));
                }

                // Update next_cortical_idx if needed
                if area.cortical_idx >= self.next_cortical_idx {
                    self.next_cortical_idx = area.cortical_idx + 1;
                }
            }
        }

        let cortical_id = area.cortical_id;
        let cortical_idx = area.cortical_idx;

        // Update lookup maps
        self.cortical_id_to_idx.insert(cortical_id, cortical_idx);
        self.cortical_idx_to_id.insert(cortical_idx, cortical_id);

        // Initialize upstream_cortical_areas property (empty array for O(1) lookup)
        area.properties
            .insert("upstream_cortical_areas".to_string(), serde_json::json!([]));

        // Default visualization voxel granularity is 1x1x1 (assumed, not stored)
        // User overrides are stored in properties["visualization_voxel_granularity"] only if != 1x1x1

        // If the caller provided a parent brain region ID, persist the association in the
        // BrainRegionHierarchy membership set (this drives /v1/region/regions_members).
        //
        // IMPORTANT: This is separate from storing "parent_region_id" in the cortical area's
        // properties. BV may show that property even if the hierarchy isn't updated.
        let parent_region_id = area
            .properties
            .get("parent_region_id")
            .and_then(|v| v.as_str())
            .map(|s| s.to_string());

        // Store area
        self.cortical_areas.insert(cortical_id, area);

        // Update region membership (source of truth for region->areas listing)
        if let Some(region_id) = parent_region_id {
            let region = self
                .brain_regions
                .get_region_mut(&region_id)
                .ok_or_else(|| {
                    BduError::InvalidArea(format!(
                        "Unknown parent_region_id '{}' for cortical area {}",
                        region_id,
                        cortical_id.as_base_64()
                    ))
                })?;
            region.add_area(cortical_id);
        }

        // CRITICAL: Initialize per-area count caches to 0 (lock-free for readers)
        // This allows healthcheck endpoints to read counts without NPU lock
        {
            let mut neuron_cache = self.cached_neuron_counts_per_area.write();
            neuron_cache.insert(cortical_id, AtomicUsize::new(0));
            let mut synapse_cache = self.cached_synapse_counts_per_area.write();
            synapse_cache.insert(cortical_id, AtomicUsize::new(0));
        }
        // @cursor:critical-path - BV pulls per-area stats from StateManager without NPU lock.
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        state_manager.init_cortical_area_stats(&cortical_id.as_base_64());

        // CRITICAL: Register cortical area in NPU during corticogenesis
        // This must happen BEFORE neurogenesis so neurons can look up their cortical IDs
        // Use base64 format for proper CorticalID conversion
        if let Some(ref npu) = self.npu {
            trace!(target: "feagi-bdu", "[LOCK-TRACE] add_cortical_area: attempting NPU lock for registration");
            if let Ok(mut npu_lock) = npu.lock() {
                trace!(target: "feagi-bdu", "[LOCK-TRACE] add_cortical_area: acquired NPU lock for registration");
                npu_lock.register_cortical_area(cortical_idx, cortical_id.as_base_64());
                trace!(
                    target: "feagi-bdu",
                    "Registered cortical area idx={} -> '{}' in NPU",
                    cortical_idx,
                    cortical_id.as_base_64()
                );
            }
        }

        // Synchronize cortical area flags with NPU (psp_uniform_distribution, mp_driven_psp, etc.)
        self.sync_cortical_area_flags_to_npu()?;

        self.initialized = true;

        self.refresh_cortical_area_hashes(true, true);
        self.refresh_brain_regions_hash();

        Ok(cortical_idx)
    }

    /// Remove a cortical area by ID
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - ID of the cortical area to remove
    ///
    /// # Returns
    ///
    /// `Ok(())` if removed, error if area doesn't exist
    ///
    /// # Note
    ///
    /// This does NOT remove neurons from the NPU - that must be done separately.
    ///
    pub fn remove_cortical_area(&mut self, cortical_id: &CorticalID) -> BduResult<()> {
        let area = self.cortical_areas.remove(cortical_id).ok_or_else(|| {
            BduError::InvalidArea(format!("Cortical area {} does not exist", cortical_id))
        })?;

        // Remove from lookup maps
        self.cortical_id_to_idx.remove(cortical_id);
        self.cortical_idx_to_id.remove(&area.cortical_idx);

        self.refresh_cortical_area_hashes(true, true);
        Ok(())
    }

    /// Update a cortical area ID without changing its cortical_idx.
    ///
    /// This remaps internal lookup tables, brain-region membership, and mapping keys.
    pub fn rename_cortical_area_id(
        &mut self,
        old_id: &CorticalID,
        new_id: CorticalID,
        new_cortical_type: CorticalAreaType,
    ) -> BduResult<()> {
        self.rename_cortical_area_id_with_options(old_id, new_id, new_cortical_type, true)
    }

    /// Update a cortical area ID without changing its cortical_idx, with optional NPU registry update.
    pub fn rename_cortical_area_id_with_options(
        &mut self,
        old_id: &CorticalID,
        new_id: CorticalID,
        new_cortical_type: CorticalAreaType,
        update_npu_registry: bool,
    ) -> BduResult<()> {
        if !self.cortical_areas.contains_key(old_id) {
            return Err(BduError::InvalidArea(format!(
                "Cortical area {} does not exist",
                old_id
            )));
        }
        if self.cortical_areas.contains_key(&new_id) {
            return Err(BduError::InvalidArea(format!(
                "Cortical area {} already exists",
                new_id
            )));
        }

        let mut area = self.cortical_areas.remove(old_id).ok_or_else(|| {
            BduError::InvalidArea(format!("Cortical area {} does not exist", old_id))
        })?;
        let cortical_idx = area.cortical_idx;
        area.cortical_id = new_id;
        area.cortical_type = new_cortical_type;

        self.cortical_areas.insert(new_id, area);
        self.cortical_id_to_idx.remove(old_id);
        self.cortical_id_to_idx.insert(new_id, cortical_idx);
        self.cortical_idx_to_id.insert(cortical_idx, new_id);

        // Update per-area count caches
        {
            let mut neuron_cache = self.cached_neuron_counts_per_area.write();
            if let Some(value) = neuron_cache.remove(old_id) {
                neuron_cache.insert(new_id, value);
            }
            let mut synapse_cache = self.cached_synapse_counts_per_area.write();
            if let Some(value) = synapse_cache.remove(old_id) {
                synapse_cache.insert(new_id, value);
            }
        }

        // Update brain-region membership
        self.brain_regions.rename_cortical_area_id(old_id, new_id);

        // Update cortical mapping properties referencing the old ID
        let old_id_str = old_id.as_base_64();
        let new_id_str = new_id.as_base_64();
        for area in self.cortical_areas.values_mut() {
            if let Some(mapping) = area
                .properties
                .get_mut("cortical_mapping_dst")
                .and_then(|v| v.as_object_mut())
            {
                if let Some(value) = mapping.remove(&old_id_str) {
                    mapping.insert(new_id_str.clone(), value);
                }
            }
        }

        // Update NPU cortical_id registry if requested
        if update_npu_registry {
            if let Some(ref npu) = self.npu {
                if let Ok(mut npu_lock) = npu.lock() {
                    npu_lock.register_cortical_area(cortical_idx, new_id.as_base_64());
                }
            }
        }

        self.refresh_cortical_area_hashes(true, true);
        self.refresh_brain_regions_hash();
        self.refresh_cortical_mappings_hash();

        Ok(())
    }

    /// Get a cortical area by ID
    pub fn get_cortical_area(&self, cortical_id: &CorticalID) -> Option<&CorticalArea> {
        self.cortical_areas.get(cortical_id)
    }

    /// Get a mutable reference to a cortical area
    pub fn get_cortical_area_mut(&mut self, cortical_id: &CorticalID) -> Option<&mut CorticalArea> {
        self.cortical_areas.get_mut(cortical_id)
    }

    /// Get cortical index by ID
    pub fn get_cortical_idx(&self, cortical_id: &CorticalID) -> Option<u32> {
        self.cortical_id_to_idx.get(cortical_id).copied()
    }

    /// Find which brain region contains a cortical area
    ///
    /// This is used to populate `parent_region_id` in API responses for Brain Visualizer.
    /// Delegates to BrainRegionHierarchy for the actual search.
    ///
    /// # Arguments
    /// * `cortical_id` - Cortical area to search for
    ///
    /// # Returns
    /// * `Option<String>` - Parent region ID (UUID string) if found
    ///
    pub fn get_parent_region_id_for_area(&self, cortical_id: &CorticalID) -> Option<String> {
        self.brain_regions.find_region_containing_area(cortical_id)
    }

    /// True if `area` has at least one efferent mapping to a cortical area outside its brain region
    /// (including destinations not assigned to any region).
    pub fn has_cross_region_outgoing(&self, area: &CorticalID) -> bool {
        let Some(my_region) = self.brain_regions.find_region_containing_area(area) else {
            return false;
        };
        let Some(src_area) = self.cortical_areas.get(area) else {
            return false;
        };
        let Some(dst_obj) = src_area
            .properties
            .get("cortical_mapping_dst")
            .and_then(|v| v.as_object())
        else {
            return false;
        };
        for dst_key in dst_obj.keys() {
            let Ok(dst_id) = CorticalID::try_from_base_64(dst_key) else {
                continue;
            };
            match self.brain_regions.find_region_containing_area(&dst_id) {
                None => return true,
                Some(rid) if rid != my_region => return true,
                _ => {}
            }
        }
        false
    }

    /// True if `area` has at least one afferent mapping from a cortical area outside its brain region.
    pub fn has_cross_region_incoming(&self, area: &CorticalID) -> bool {
        let Some(my_region) = self.brain_regions.find_region_containing_area(area) else {
            return false;
        };
        let my_b64 = area.as_base_64();
        for (src_id, src_area) in &self.cortical_areas {
            if src_id == area {
                continue;
            }
            let Some(dst_map) = src_area
                .properties
                .get("cortical_mapping_dst")
                .and_then(|v| v.as_object())
            else {
                continue;
            };
            if !dst_map.contains_key(&my_b64) {
                continue;
            }
            match self.brain_regions.find_region_containing_area(src_id) {
                None => return true,
                Some(rid) if rid != my_region => return true,
                _ => {}
            }
        }
        false
    }

    /// Recompute brain-region `inputs`/`outputs` registries from current cortical mappings.
    ///
    /// This drives `/v1/region/regions_members` (via `BrainRegion.properties["inputs"/"outputs"]`).
    ///
    /// Semantics (matches Python `_auto_assign_region_io()` and BV expectations):
    /// - **outputs**: Any cortical area *in the region* that connects to an area outside the region
    /// - **inputs**: Any cortical area *in the region* that receives a connection from outside the region
    ///
    /// This function updates the hierarchy in-place and returns the computed base64 ID lists
    /// for downstream persistence into `RuntimeGenome`.
    pub fn recompute_brain_region_io_registry(&mut self) -> BduResult<BrainRegionIoRegistry> {
        use std::collections::HashSet;

        let region_ids: Vec<String> = self
            .brain_regions
            .get_all_region_ids()
            .into_iter()
            .cloned()
            .collect();

        let mut inputs_by_region: HashMap<String, HashSet<String>> = HashMap::new();
        let mut outputs_by_region: HashMap<String, HashSet<String>> = HashMap::new();

        // Initialize so regions with no IO still get cleared deterministically.
        for rid in &region_ids {
            inputs_by_region.insert(rid.clone(), HashSet::new());
            outputs_by_region.insert(rid.clone(), HashSet::new());
        }

        for (src_id, src_area) in &self.cortical_areas {
            let Some(dstmap) = src_area
                .properties
                .get("cortical_mapping_dst")
                .and_then(|v| v.as_object())
            else {
                continue;
            };

            let Some(src_region_id) = self.brain_regions.find_region_containing_area(src_id) else {
                debug!(
                    target: "feagi-bdu",
                    "Skipping region IO for source area {} (not in any region)",
                    src_id.as_base_64()
                );
                continue;
            };

            for dst_id_str in dstmap.keys() {
                let dst_id = CorticalID::try_from_base_64(dst_id_str).map_err(|e| {
                    BduError::InvalidArea(format!(
                        "Unable to recompute region IO: invalid destination cortical id '{}' in cortical_mapping_dst for {}: {}",
                        dst_id_str,
                        src_id.as_base_64(),
                        e
                    ))
                })?;

                let Some(dst_region_id) = self.brain_regions.find_region_containing_area(&dst_id)
                else {
                    warn!(
                        target: "feagi-bdu",
                        "Skipping region IO for destination area {} (not in any region)",
                        dst_id.as_base_64()
                    );
                    continue;
                };

                if src_region_id == dst_region_id {
                    continue;
                }

                outputs_by_region
                    .entry(src_region_id.clone())
                    .or_default()
                    .insert(src_id.as_base_64());
                inputs_by_region
                    .entry(dst_region_id.clone())
                    .or_default()
                    .insert(dst_id.as_base_64());
            }
        }

        // Union in declared interface lists so export/import and pre-wired regions show IO without edges.
        for rid in &region_ids {
            let Some(region) = self.brain_regions.get_region(rid) else {
                continue;
            };
            let in_ids = crate::region_io_designation::parse_designated_id_list(
                region
                    .properties
                    .get(crate::region_io_designation::DESIGNATED_INPUTS_KEY),
            )?;
            let out_ids = crate::region_io_designation::parse_designated_id_list(
                region
                    .properties
                    .get(crate::region_io_designation::DESIGNATED_OUTPUTS_KEY),
            )?;
            for id in in_ids {
                inputs_by_region
                    .entry(rid.clone())
                    .or_default()
                    .insert(id.as_base_64());
            }
            for id in out_ids {
                outputs_by_region
                    .entry(rid.clone())
                    .or_default()
                    .insert(id.as_base_64());
            }
        }

        let mut computed: HashMap<String, (Vec<String>, Vec<String>)> = HashMap::new();
        for rid in region_ids {
            let mut inputs: Vec<String> = inputs_by_region
                .remove(&rid)
                .unwrap_or_default()
                .into_iter()
                .collect();
            let mut outputs: Vec<String> = outputs_by_region
                .remove(&rid)
                .unwrap_or_default()
                .into_iter()
                .collect();

            inputs.sort();
            outputs.sort();

            let region = self.brain_regions.get_region_mut(&rid).ok_or_else(|| {
                BduError::InvalidArea(format!(
                    "Unable to recompute region IO: region '{}' not found in hierarchy",
                    rid
                ))
            })?;

            if inputs.is_empty() {
                region.properties.remove("inputs");
            } else {
                region
                    .properties
                    .insert("inputs".to_string(), serde_json::json!(inputs.clone()));
            }

            if outputs.is_empty() {
                region.properties.remove("outputs");
            } else {
                region
                    .properties
                    .insert("outputs".to_string(), serde_json::json!(outputs.clone()));
            }

            computed.insert(rid, (inputs, outputs));
        }

        self.refresh_brain_regions_hash();

        Ok(computed)
    }

    /// Get the root brain region ID (region with no parent)
    ///
    /// # Returns
    /// * `Option<String>` - Root region ID (UUID string) if found
    ///
    pub fn get_root_region_id(&self) -> Option<String> {
        self.brain_regions.get_root_region_id()
    }

    /// Get cortical ID by index
    pub fn get_cortical_id(&self, cortical_idx: u32) -> Option<&CorticalID> {
        self.cortical_idx_to_id.get(&cortical_idx)
    }

    /// Get all cortical_idx -> cortical_id mappings (for burst loop caching)
    /// Returns a HashMap of cortical_idx -> cortical_id (base64 string)
    pub fn get_all_cortical_idx_to_id_mappings(&self) -> ahash::AHashMap<u32, String> {
        self.cortical_idx_to_id
            .iter()
            .map(|(idx, id)| (*idx, id.as_base_64()))
            .collect()
    }

    /// Get all cortical_idx -> visualization_voxel_granularity mappings
    ///
    /// Returns a map of cortical_idx to (granularity_x, granularity_y, granularity_z) for areas that have
    /// visualization voxel granularity configured.
    pub fn get_all_visualization_granularities(&self) -> ahash::AHashMap<u32, (u32, u32, u32)> {
        let mut granularities = ahash::AHashMap::new();
        for (cortical_id, area) in &self.cortical_areas {
            let cortical_idx = self
                .cortical_id_to_idx
                .get(cortical_id)
                .copied()
                .unwrap_or(0);

            // Extract visualization granularity overrides from properties.
            // Default is 1x1x1 (assumed, not stored) so we only include non-default overrides.
            if let Some(granularity_json) = area.properties.get("visualization_voxel_granularity") {
                if let Some(arr) = granularity_json.as_array() {
                    if arr.len() == 3 {
                        let x_opt = arr[0]
                            .as_u64()
                            .or_else(|| arr[0].as_f64().map(|f| f as u64));
                        let y_opt = arr[1]
                            .as_u64()
                            .or_else(|| arr[1].as_f64().map(|f| f as u64));
                        let z_opt = arr[2]
                            .as_u64()
                            .or_else(|| arr[2].as_f64().map(|f| f as u64));

                        if let (Some(x), Some(y), Some(z)) = (x_opt, y_opt, z_opt) {
                            let granularity = (x as u32, y as u32, z as u32);
                            // Only include overrides (non-default)
                            if granularity != (1, 1, 1) {
                                granularities.insert(cortical_idx, granularity);
                            }
                        }
                    }
                }
            }
        }
        granularities
    }

    /// Get all cortical area IDs
    pub fn get_cortical_area_ids(&self) -> Vec<&CorticalID> {
        self.cortical_areas.keys().collect()
    }

    /// Get the number of cortical areas
    pub fn get_cortical_area_count(&self) -> usize {
        self.cortical_areas.len()
    }

    /// Get all cortical areas that have synapses targeting the specified area (upstream/afferent areas)
    ///
    /// Reads from the `upstream_cortical_areas` property stored on the cortical area.
    /// This property is maintained by `add_upstream_area()` and `remove_upstream_area()`.
    ///
    /// # Arguments
    ///
    /// * `target_cortical_id` - The cortical area ID to find upstream connections for
    ///
    /// # Returns
    ///
    /// Vec of cortical_idx values for all upstream areas
    ///
    pub fn get_upstream_cortical_areas(&self, target_cortical_id: &CorticalID) -> Vec<u32> {
        if let Some(area) = self.cortical_areas.get(target_cortical_id) {
            if let Some(upstream_prop) = area.properties.get("upstream_cortical_areas") {
                if let Some(upstream_array) = upstream_prop.as_array() {
                    return upstream_array
                        .iter()
                        .filter_map(|v| v.as_u64().map(|n| n as u32))
                        .collect();
                }
            }

            // Property missing - data integrity issue
            warn!(target: "feagi-bdu",
                "Cortical area '{}' missing 'upstream_cortical_areas' property - treating as empty",
                target_cortical_id.as_base_64()
            );
        }

        Vec::new()
    }

    /// Filter upstream cortical indices to exclude memory areas.
    pub fn filter_non_memory_upstream_areas(&self, upstream: &[u32]) -> Vec<u32> {
        upstream
            .iter()
            .filter_map(|idx| {
                let cortical_id = self.cortical_idx_to_id.get(idx)?;
                let area = self.cortical_areas.get(cortical_id)?;
                if matches!(area.cortical_type, CorticalAreaType::Memory(_)) {
                    None
                } else {
                    Some(*idx)
                }
            })
            .collect()
    }

    /// Recompute and persist upstream_cortical_areas for a target area from mapping properties.
    ///
    /// This is a recovery path for stale upstream tracking after connectome or mapping edits.
    pub fn refresh_upstream_cortical_areas_from_mappings(
        &mut self,
        target_cortical_id: &CorticalID,
    ) -> Vec<u32> {
        use std::collections::HashSet;
        let target_id_str = target_cortical_id.as_base_64();
        let mut upstream_idxs = HashSet::new();
        for (src_id, src_area) in &self.cortical_areas {
            if src_id == target_cortical_id {
                continue;
            }
            if let Some(mapping) = src_area
                .properties
                .get("cortical_mapping_dst")
                .and_then(|v| v.as_object())
            {
                if mapping.contains_key(&target_id_str) {
                    upstream_idxs.insert(src_area.cortical_idx);
                }
            }
        }

        let mut upstream_list: Vec<u32> = upstream_idxs.into_iter().collect();
        upstream_list.sort_unstable();

        if let Some(target_area) = self.cortical_areas.get_mut(target_cortical_id) {
            target_area.properties.insert(
                "upstream_cortical_areas".to_string(),
                serde_json::json!(upstream_list),
            );
        }

        self.get_upstream_cortical_areas(target_cortical_id)
    }

    /// Add an upstream cortical area to a target area's upstream list
    ///
    /// This should be called when synapses are created from src_cortical_idx to target_cortical_id.
    ///
    /// # Arguments
    ///
    /// * `target_cortical_id` - The cortical area receiving connections
    /// * `src_cortical_idx` - The cortical index of the source area
    ///
    pub fn add_upstream_area(&mut self, target_cortical_id: &CorticalID, src_cortical_idx: u32) {
        if let Some(area) = self.cortical_areas.get_mut(target_cortical_id) {
            let upstream_array = area
                .properties
                .entry("upstream_cortical_areas".to_string())
                .or_insert_with(|| serde_json::json!([]));

            if let Some(arr) = upstream_array.as_array_mut() {
                let src_value = serde_json::json!(src_cortical_idx);
                if !arr.contains(&src_value) {
                    arr.push(src_value);
                    debug!(target: "feagi-bdu",
                        "Added upstream area idx={} to cortical area '{}'",
                        src_cortical_idx, target_cortical_id.as_base_64()
                    );
                }
            }
        }
    }

    /// Get the memory twin cortical ID for a given memory area and upstream area.
    pub fn get_memory_twin_for_upstream_idx(
        &self,
        memory_area_idx: u32,
        upstream_idx: u32,
    ) -> Option<CorticalID> {
        let memory_id = self.cortical_idx_to_id.get(&memory_area_idx)?;
        let upstream_id = self.cortical_idx_to_id.get(&upstream_idx)?;
        let area = self.cortical_areas.get(memory_id)?;
        let mapping = area
            .properties
            .get("memory_twin_areas")
            .and_then(|v| v.as_object())?;
        let twin_b64 = mapping.get(&upstream_id.as_base_64())?.as_str()?;
        CorticalID::try_from_base_64(twin_b64).ok()
    }

    /// Diagnose memory-twin eligibility and status for a specific mapping pair.
    ///
    /// This gives API/MCP a one-call answer to:
    /// - whether a twin is expected,
    /// - whether one exists,
    /// - and the precise blocker when it does not.
    pub fn diagnose_memory_twin_for_mapping(
        &self,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
    ) -> BduResult<MemoryTwinDiagnostic> {
        let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
            BduError::InvalidArea(format!(
                "Source area not found: {}",
                src_area_id.as_base_64()
            ))
        })?;
        let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
            BduError::InvalidArea(format!(
                "Destination area not found: {}",
                dst_area_id.as_base_64()
            ))
        })?;

        let src_is_memory = matches!(src_area.cortical_type, CorticalAreaType::Memory(_));
        let dst_is_memory = matches!(dst_area.cortical_type, CorticalAreaType::Memory(_));

        let rules_opt = src_area
            .properties
            .get("cortical_mapping_dst")
            .and_then(|v| v.as_object())
            .and_then(|mapping_dst| {
                Self::get_mapping_rules_for_destination(mapping_dst, dst_area_id)
            });
        let mapping_exists = rules_opt.is_some();
        let episodic_rule_count = rules_opt
            .map(|rules| {
                rules
                    .iter()
                    .filter(|rule| {
                        let morphology_id = rule
                            .as_object()
                            .and_then(|obj| obj.get("morphology_id"))
                            .and_then(|v| v.as_str())
                            .or_else(|| {
                                rule.as_array()
                                    .and_then(|arr| arr.first())
                                    .and_then(|v| v.as_str())
                            });
                        morphology_id == Some("episodic_memory")
                    })
                    .count()
            })
            .unwrap_or(0);

        let twin_expected =
            mapping_exists && episodic_rule_count > 0 && dst_is_memory && !src_is_memory;
        let twin_cortical_area = dst_area
            .properties
            .get("memory_twin_areas")
            .and_then(|v| v.as_object())
            .and_then(|map| map.get(&src_area_id.as_base_64()))
            .and_then(|v| v.as_str())
            .map(ToString::to_string);
        let twin_present = twin_cortical_area.is_some();

        let twin_parent_region_id = twin_cortical_area.as_ref().and_then(|twin_b64| {
            CorticalID::try_from_base_64(twin_b64)
                .ok()
                .and_then(|twin_id| {
                    self.cortical_areas.get(&twin_id).and_then(|area| {
                        area.properties
                            .get("parent_region_id")
                            .and_then(|v| v.as_str())
                            .map(ToString::to_string)
                    })
                })
        });
        let src_parent_region_id = src_area
            .properties
            .get("parent_region_id")
            .and_then(|v| v.as_str())
            .map(ToString::to_string);
        let dst_parent_region_id = dst_area
            .properties
            .get("parent_region_id")
            .and_then(|v| v.as_str())
            .map(ToString::to_string);
        let twin_parent_matches_src_parent = match (&twin_parent_region_id, &src_parent_region_id) {
            (Some(twin_parent), Some(src_parent)) => Some(twin_parent == src_parent),
            (None, None) if twin_present => Some(true),
            _ if twin_present => Some(false),
            _ => None,
        };

        let reason = if !mapping_exists {
            Some("no_mapping_rule_between_src_and_dst".to_string())
        } else if episodic_rule_count == 0 {
            Some("mapping_exists_but_not_episodic_memory".to_string())
        } else if !dst_is_memory {
            Some("destination_is_not_memory_area".to_string())
        } else if src_is_memory {
            Some("upstream_is_memory_area_twin_not_supported".to_string())
        } else if !twin_present {
            Some("twin_expected_but_missing".to_string())
        } else if twin_parent_matches_src_parent == Some(false) {
            Some("twin_parent_region_mismatch_with_source".to_string())
        } else {
            None
        };

        Ok(MemoryTwinDiagnostic {
            src_cortical_area: src_area_id.as_base_64(),
            dst_cortical_area: dst_area_id.as_base_64(),
            src_cortical_type: src_area.cortical_type.to_string(),
            dst_cortical_type: dst_area.cortical_type.to_string(),
            mapping_exists,
            episodic_rule_count,
            twin_expected,
            twin_present,
            twin_cortical_area,
            reason,
            src_parent_region_id,
            dst_parent_region_id,
            twin_parent_region_id,
            twin_parent_matches_src_parent,
        })
    }

    /// Ensure a memory twin area exists for the given upstream and memory areas.
    pub fn ensure_memory_twin_area(
        &mut self,
        memory_area_id: &CorticalID,
        upstream_area_id: &CorticalID,
    ) -> BduResult<CorticalID> {
        use crate::models::CorticalAreaExt;

        let register_replay_mapping = |manager: &mut ConnectomeManager,
                                       twin_id: &CorticalID|
         -> BduResult<()> {
            let Some(npu) = manager.npu.as_ref() else {
                return Ok(());
            };
            let memory_area_idx =
                *manager
                    .cortical_id_to_idx
                    .get(memory_area_id)
                    .ok_or_else(|| {
                        BduError::InvalidArea(format!(
                            "Memory area idx missing for {}",
                            memory_area_id.as_base_64()
                        ))
                    })?;
            let upstream_area_idx = *manager
                .cortical_id_to_idx
                .get(upstream_area_id)
                .ok_or_else(|| {
                    BduError::InvalidArea(format!(
                        "Upstream area idx missing for {}",
                        upstream_area_id.as_base_64()
                    ))
                })?;
            let twin_area_idx = *manager.cortical_id_to_idx.get(twin_id).ok_or_else(|| {
                BduError::InvalidArea(format!(
                    "Twin area idx missing for {}",
                    twin_id.as_base_64()
                ))
            })?;
            let twin_area = manager.cortical_areas.get(twin_id).ok_or_else(|| {
                BduError::InvalidArea(format!("Twin area {} not found", twin_id.as_base_64()))
            })?;
            let potential = twin_area.firing_threshold() + twin_area.firing_threshold_increment();
            if let Ok(mut npu_lock) = npu.lock() {
                npu_lock.register_memory_twin_mapping(
                    memory_area_idx,
                    upstream_area_idx,
                    twin_area_idx,
                    potential,
                );
            }
            Ok(())
        };

        let memory_area = self.cortical_areas.get(memory_area_id).ok_or_else(|| {
            BduError::InvalidArea(format!(
                "Memory area {} not found",
                memory_area_id.as_base_64()
            ))
        })?;
        let upstream_area = self.cortical_areas.get(upstream_area_id).ok_or_else(|| {
            BduError::InvalidArea(format!(
                "Upstream area {} not found",
                upstream_area_id.as_base_64()
            ))
        })?;

        if matches!(upstream_area.cortical_type, CorticalAreaType::Memory(_)) {
            return Err(BduError::InvalidArea(format!(
                "Upstream area {} is memory type; twin creation is only for non-memory areas",
                upstream_area_id.as_base_64()
            )));
        }

        if let Some(existing) = memory_area
            .properties
            .get("memory_twin_areas")
            .and_then(|v| v.as_object())
            .and_then(|map| map.get(&upstream_area_id.as_base_64()))
            .and_then(|v| v.as_str())
            .and_then(|s| CorticalID::try_from_base_64(s).ok())
        {
            self.ensure_memory_replay_mapping(memory_area_id, &existing)?;
            register_replay_mapping(self, &existing)?;
            self.refresh_cortical_mappings_hash();
            return Ok(existing);
        }

        let twin_id = self.build_memory_twin_id(memory_area_id, upstream_area_id)?;
        if self.cortical_areas.contains_key(&twin_id) {
            if let Some(existing) = self.cortical_areas.get_mut(&twin_id) {
                let expected_source = upstream_area_id.as_base_64();
                let expected_target = memory_area_id.as_base_64();
                let existing_source = existing
                    .properties
                    .get("memory_twin_of")
                    .and_then(|v| v.as_str());
                let existing_target = existing
                    .properties
                    .get("memory_twin_for")
                    .and_then(|v| v.as_str());
                if existing_source != Some(expected_source.as_str())
                    || existing_target != Some(expected_target.as_str())
                {
                    warn!(
                        target: "feagi-bdu",
                        "Twin cortical ID properties missing/mismatched for {} -> {}; repairing",
                        upstream_area_id.as_base_64(),
                        memory_area_id.as_base_64()
                    );
                    existing.properties.insert(
                        "memory_twin_of".to_string(),
                        serde_json::json!(expected_source),
                    );
                    existing.properties.insert(
                        "memory_twin_for".to_string(),
                        serde_json::json!(expected_target),
                    );
                }
            }
            self.set_memory_twin_mapping(memory_area_id, upstream_area_id, &twin_id);
            self.ensure_memory_replay_mapping(memory_area_id, &twin_id)?;
            register_replay_mapping(self, &twin_id)?;
            self.refresh_cortical_mappings_hash();
            return Ok(twin_id);
        }

        let twin_name = format!("{}_twin", upstream_area.name.replace(' ', "_"));
        let twin_type = CorticalAreaType::Custom(CustomCorticalType::LeakyIntegrateFire);
        let twin_position = self.build_memory_twin_position(memory_area, upstream_area);
        let mut twin_area = CorticalArea::new(
            twin_id,
            0,
            twin_name,
            upstream_area.dimensions,
            twin_position,
            twin_type,
        )?;
        twin_area.properties = self.build_memory_twin_properties(
            memory_area,
            upstream_area,
            memory_area_id,
            upstream_area_id,
        );

        let _twin_idx = self.add_cortical_area(twin_area)?;
        let _ = self.create_neurons_for_area(&twin_id);

        self.set_memory_twin_mapping(memory_area_id, upstream_area_id, &twin_id);
        self.ensure_memory_replay_mapping(memory_area_id, &twin_id)?;
        register_replay_mapping(self, &twin_id)?;
        self.refresh_cortical_mappings_hash();
        Ok(twin_id)
    }

    fn build_memory_twin_position(
        &self,
        _memory_area: &CorticalArea,
        upstream_area: &CorticalArea,
    ) -> GenomeCoordinate3D {
        let width = upstream_area.dimensions.width as f32;
        let margin = (width * 0.25).ceil() as i32;
        let offset = upstream_area.dimensions.width as i32 + margin;
        GenomeCoordinate3D::new(
            upstream_area.position.x + offset,
            upstream_area.position.y,
            upstream_area.position.z,
        )
    }

    fn build_memory_twin_id(
        &self,
        memory_area_id: &CorticalID,
        upstream_area_id: &CorticalID,
    ) -> BduResult<CorticalID> {
        let mut hasher = Xxh64::new(DATA_HASH_SEED);
        hasher.write(memory_area_id.as_base_64().as_bytes());
        hasher.write(upstream_area_id.as_base_64().as_bytes());
        hasher.write(b"memory_twin");
        let hash = hasher.finish();
        let mut bytes = hash.to_be_bytes();
        bytes[0] = b'c';
        CorticalID::try_from_bytes(&bytes)
            .map_err(|e| BduError::Internal(format!("Failed to build twin cortical ID: {}", e)))
    }

    fn build_memory_twin_properties(
        &self,
        _memory_area: &CorticalArea,
        upstream_area: &CorticalArea,
        memory_area_id: &CorticalID,
        upstream_area_id: &CorticalID,
    ) -> HashMap<String, serde_json::Value> {
        let mut props = upstream_area.properties.clone();
        props.remove("cortical_mapping_dst");
        props.remove("upstream_cortical_areas");
        props.remove("parent_region_id");
        props.insert("cortical_group".to_string(), serde_json::json!("CUSTOM"));
        props.insert("is_mem_type".to_string(), serde_json::json!(false));
        props.insert(
            "memory_twin_of".to_string(),
            serde_json::json!(upstream_area_id.as_base_64()),
        );
        props.insert(
            "memory_twin_for".to_string(),
            serde_json::json!(memory_area_id.as_base_64()),
        );
        if let Some(parent_region_id) = upstream_area
            .properties
            .get("parent_region_id")
            .and_then(|v| v.as_str())
        {
            props.insert(
                "parent_region_id".to_string(),
                serde_json::json!(parent_region_id),
            );
        }
        props
    }

    fn set_memory_twin_mapping(
        &mut self,
        memory_area_id: &CorticalID,
        upstream_area_id: &CorticalID,
        twin_id: &CorticalID,
    ) {
        if let Some(memory_area) = self.cortical_areas.get_mut(memory_area_id) {
            let mapping = memory_area
                .properties
                .entry("memory_twin_areas".to_string())
                .or_insert_with(|| serde_json::json!({}));
            if let Some(map) = mapping.as_object_mut() {
                map.insert(
                    upstream_area_id.as_base_64(),
                    serde_json::json!(twin_id.as_base_64()),
                );
            }
        }
    }

    fn ensure_memory_replay_mapping(
        &mut self,
        memory_area_id: &CorticalID,
        twin_id: &CorticalID,
    ) -> BduResult<()> {
        if !self.morphology_registry.contains("memory_replay") {
            feagi_evolutionary::add_core_morphologies(&mut self.morphology_registry);
        }
        self.refresh_morphologies_hash();
        let mapping_data = vec![serde_json::json!({
            "morphology_id": "memory_replay",
            "morphology_scalar": [1, 1, 1],
            "postSynapticCurrent_multiplier": 1,
            "plasticity_flag": false,
            "plasticity_constant": 0,
            "ltp_multiplier": 0,
            "ltd_multiplier": 0,
            "plasticity_window": 0,
        })];
        self.update_cortical_mapping(memory_area_id, twin_id, mapping_data)?;
        let _ = self.regenerate_synapses_for_mapping(memory_area_id, twin_id)?;
        // Update cortical area hash so BV refreshes area details (outgoing mappings).
        self.refresh_cortical_area_hashes(true, false);
        Ok(())
    }

    /// Remove an upstream cortical area from a target area's upstream list
    ///
    /// This should be called when all synapses from src_cortical_idx to target_cortical_id are deleted.
    ///
    /// # Arguments
    ///
    /// * `target_cortical_id` - The cortical area that had connections
    /// * `src_cortical_idx` - The cortical index of the source area to remove
    ///
    pub fn remove_upstream_area(&mut self, target_cortical_id: &CorticalID, src_cortical_idx: u32) {
        if let Some(area) = self.cortical_areas.get_mut(target_cortical_id) {
            if let Some(upstream_prop) = area.properties.get_mut("upstream_cortical_areas") {
                if let Some(arr) = upstream_prop.as_array_mut() {
                    let src_value = serde_json::json!(src_cortical_idx);
                    if let Some(pos) = arr.iter().position(|v| v == &src_value) {
                        arr.remove(pos);
                        debug!(target: "feagi-bdu",
                            "Removed upstream area idx={} from cortical area '{}'",
                            src_cortical_idx, target_cortical_id.as_base_64()
                        );
                    }
                }
            }
        }
    }

    /// Check if a cortical area exists
    pub fn has_cortical_area(&self, cortical_id: &CorticalID) -> bool {
        self.cortical_areas.contains_key(cortical_id)
    }

    /// Check if the connectome is initialized (has areas)
    pub fn is_initialized(&self) -> bool {
        self.initialized && !self.cortical_areas.is_empty()
    }

    // ======================================================================
    // Brain Region Management
    // ======================================================================

    /// Add a brain region
    pub fn add_brain_region(
        &mut self,
        region: BrainRegion,
        parent_id: Option<String>,
    ) -> BduResult<()> {
        self.brain_regions.add_region(region, parent_id)?;
        self.refresh_brain_regions_hash();
        Ok(())
    }

    /// Remove a brain region
    pub fn remove_brain_region(&mut self, region_id: &str) -> BduResult<()> {
        self.brain_regions.remove_region(region_id)?;
        self.refresh_brain_regions_hash();
        Ok(())
    }

    /// Change the parent of an existing brain region.
    pub fn change_brain_region_parent(
        &mut self,
        region_id: &str,
        new_parent_id: &str,
    ) -> BduResult<()> {
        self.brain_regions.change_parent(region_id, new_parent_id)?;
        self.refresh_brain_regions_hash();
        Ok(())
    }

    /// Get a brain region by ID
    pub fn get_brain_region(&self, region_id: &str) -> Option<&BrainRegion> {
        self.brain_regions.get_region(region_id)
    }

    /// Get a mutable reference to a brain region
    pub fn get_brain_region_mut(&mut self, region_id: &str) -> Option<&mut BrainRegion> {
        self.brain_regions.get_region_mut(region_id)
    }

    /// Get all brain region IDs
    pub fn get_brain_region_ids(&self) -> Vec<&String> {
        self.brain_regions.get_all_region_ids()
    }

    /// Get the brain region hierarchy
    pub fn get_brain_region_hierarchy(&self) -> &BrainRegionHierarchy {
        &self.brain_regions
    }

    // ========================================================================
    // MORPHOLOGY ACCESS
    // ========================================================================

    /// Get all morphologies from the loaded genome
    pub fn get_morphologies(&self) -> &feagi_evolutionary::MorphologyRegistry {
        &self.morphology_registry
    }

    /// Get morphology count
    pub fn get_morphology_count(&self) -> usize {
        self.morphology_registry.count()
    }

    /// Insert or overwrite a morphology definition in the in-memory registry.
    ///
    /// NOTE: This updates the runtime registry used by mapping/synapse generation.
    /// Callers that also maintain a RuntimeGenome (source of truth) MUST update it too.
    pub fn upsert_morphology(
        &mut self,
        morphology_id: String,
        morphology: feagi_evolutionary::Morphology,
    ) {
        self.morphology_registry
            .add_morphology(morphology_id, morphology);
        self.refresh_morphologies_hash();
    }

    /// Remove a morphology definition from the in-memory registry.
    ///
    /// Returns true if the morphology existed and was removed.
    ///
    /// NOTE: Callers that also maintain a RuntimeGenome (source of truth) MUST update it too.
    pub fn remove_morphology(&mut self, morphology_id: &str) -> bool {
        let removed = self.morphology_registry.remove_morphology(morphology_id);
        if removed {
            self.refresh_morphologies_hash();
        }
        removed
    }

    // ========================================================================
    // CORTICAL MAPPING UPDATES
    // ========================================================================

    /// Update cortical mapping properties between two cortical areas
    ///
    /// Updates only the source area's `cortical_mapping_dst` entry for this destination.
    /// Associative memory mappings are **directed**: a reverse edge (if any) is stored only when
    /// the client updates that pair explicitly (separate PUT).
    ///
    /// # Arguments
    /// * `src_area_id` - Source cortical area ID
    /// * `dst_area_id` - Destination cortical area ID
    /// * `mapping_data` - List of connection specifications
    ///
    /// # Returns
    /// * `BduResult<()>` - Ok if successful, Err otherwise
    pub fn update_cortical_mapping(
        &mut self,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
        mapping_data: Vec<serde_json::Value>,
    ) -> BduResult<()> {
        use tracing::info;

        crate::region_io_designation::validate_cross_region_mapping_proposal(
            self,
            src_area_id,
            dst_area_id,
            &mapping_data,
        )?;

        debug!(target: "feagi-bdu", "Updating cortical mapping: {} -> {}", src_area_id, dst_area_id);

        {
            // Get source area (must exist)
            let src_area = self.cortical_areas.get_mut(src_area_id).ok_or_else(|| {
                crate::types::BduError::InvalidArea(format!(
                    "Source area not found: {}",
                    src_area_id
                ))
            })?;

            // Get or create cortical_mapping_dst property
            let cortical_mapping_dst =
                if let Some(existing) = src_area.properties.get_mut("cortical_mapping_dst") {
                    existing.as_object_mut().ok_or_else(|| {
                        crate::types::BduError::InvalidMorphology(
                            "cortical_mapping_dst is not an object".to_string(),
                        )
                    })?
                } else {
                    // Create new cortical_mapping_dst
                    src_area
                        .properties
                        .insert("cortical_mapping_dst".to_string(), serde_json::json!({}));
                    src_area
                        .properties
                        .get_mut("cortical_mapping_dst")
                        .unwrap()
                        .as_object_mut()
                        .unwrap()
                };

            // Update or add the mapping for this destination
            if mapping_data.is_empty() {
                // Empty mapping_data = delete the connection
                cortical_mapping_dst.remove(&dst_area_id.as_base_64());
                info!(target: "feagi-bdu", "Removed mapping from {} to {}", src_area_id, dst_area_id);
            } else {
                cortical_mapping_dst.insert(
                    dst_area_id.as_base_64(),
                    serde_json::Value::Array(mapping_data.clone()),
                );
                debug!(target: "feagi-bdu", "Updated mapping from {} to {} with {} connections",
                      src_area_id, dst_area_id, mapping_data.len());
            }
        }

        self.refresh_cortical_mappings_hash();

        Ok(())
    }

    /// Regenerate synapses for a specific cortical mapping
    ///
    /// Creates new synapses based on mapping rules. Only removes existing synapses if
    /// a mapping already existed (update case), not for new mappings (allows multiple
    /// synapses between the same neurons).
    ///
    /// # Arguments
    /// * `src_area_id` - Source cortical area ID
    /// * `dst_area_id` - Destination cortical area ID
    ///
    /// # Returns
    /// * `BduResult<usize>` - Number of synapses created
    pub fn regenerate_synapses_for_mapping(
        &mut self,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
    ) -> BduResult<usize> {
        use tracing::info;

        debug!(target: "feagi-bdu", "Regenerating synapses: {} -> {}", src_area_id, dst_area_id);

        let mapping_rules_len = self
            .cortical_areas
            .get(src_area_id)
            .and_then(|area| area.properties.get("cortical_mapping_dst"))
            .and_then(|v| v.as_object())
            .and_then(|map| map.get(&dst_area_id.as_base_64()))
            .and_then(|v| v.as_array())
            .map(|arr| arr.len())
            .unwrap_or(0);
        tracing::debug!(
            target: "feagi-bdu",
            "Mapping rules for {} -> {}: {}",
            src_area_id,
            dst_area_id,
            mapping_rules_len
        );

        // If NPU is available, regenerate synapses
        let Some(npu_arc) = self.npu.clone() else {
            info!(target: "feagi-bdu", "NPU not available - skipping synapse regeneration");
            return Ok(0);
        };

        // Mapping regeneration must be deterministic:
        // - On mapping deletion: prune all synapses from A→B, then attempt synaptogenesis (which yields 0).
        // - On rule removal/updates: prune all synapses from A→B, then re-run synaptogenesis using the *current*
        //   mapping rules. This guarantees stale synapses from removed rules do not persist, while preserving
        //   other A→B mappings by re-creating them from the remaining rules.
        //
        // NOTE: This pruning requires retrieving neuron IDs in each area. Today, that can be O(all_neurons)
        // via `get_neurons_in_cortical_area()`. This is the safest correctness-first behavior.

        let src_idx = *self.cortical_id_to_idx.get(src_area_id).ok_or_else(|| {
            BduError::InvalidArea(format!("No cortical idx for source area {}", src_area_id))
        })?;
        let dst_idx = *self.cortical_id_to_idx.get(dst_area_id).ok_or_else(|| {
            BduError::InvalidArea(format!(
                "No cortical idx for destination area {}",
                dst_area_id
            ))
        })?;

        // Prune all existing synapses from src_area→dst_area before (re)creating based on current rules.
        // This prevents stale synapses when rules are removed/edited.
        let mut pruned_synapse_count: usize = 0;
        use std::time::Instant;
        let start = Instant::now();

        // Get neuron lists (may be slow; see note above).
        //
        // IMPORTANT: Do not rely on per-area cached neuron counts here. Pruning must be correct even if
        // caches are stale (e.g., in tests or during partial initialization). If either side is empty,
        // pruning is a no-op anyway.
        let (sources, targets) = {
            let lock_start = std::time::Instant::now();
            let npu = npu_arc.lock().unwrap();
            let lock_wait = lock_start.elapsed();
            tracing::debug!(
                target: "feagi-bdu",
                "[NPU-LOCK] prune list lock wait {:.2}ms for {} -> {}",
                lock_wait.as_secs_f64() * 1000.0,
                src_area_id,
                dst_area_id
            );
            let sources: Vec<NeuronId> = npu
                .get_neurons_in_cortical_area(src_idx)
                .into_iter()
                .map(NeuronId)
                .collect();
            let targets: Vec<NeuronId> = npu
                .get_neurons_in_cortical_area(dst_idx)
                .into_iter()
                .map(NeuronId)
                .collect();
            (sources, targets)
        };

        tracing::debug!(
            target: "feagi-bdu",
            "Prune synapses: {} sources, {} targets",
            sources.len(),
            targets.len()
        );

        if !sources.is_empty() && !targets.is_empty() {
            let remove_start = Instant::now();
            pruned_synapse_count = {
                let lock_start = std::time::Instant::now();
                let mut npu = npu_arc.lock().unwrap();
                let lock_wait = lock_start.elapsed();
                tracing::debug!(
                    target: "feagi-bdu",
                    "[NPU-LOCK] prune remove lock wait {:.2}ms for {} -> {}",
                    lock_wait.as_secs_f64() * 1000.0,
                    src_area_id,
                    dst_area_id
                );
                // Use direct source-target batch removal here rather than index-based removal.
                // This avoids false "Pruned 0" outcomes when propagation synapse_index is stale
                // during repeated rapid remap operations.
                npu.remove_synapses_between(sources, targets)
            };
            let remove_time = remove_start.elapsed();
            let total_time = start.elapsed();

            info!(
                target: "feagi-bdu",
                "Pruned {} existing synapses for mapping {} -> {} (total={}ms, remove={}ms)",
                pruned_synapse_count,
                src_area_id,
                dst_area_id,
                total_time.as_millis(),
                remove_time.as_millis()
            );

            // Update StateManager synapse count (health_check endpoint)
            if pruned_synapse_count > 0 {
                let pruned_u32 = u32::try_from(pruned_synapse_count).map_err(|_| {
                    BduError::Internal(format!(
                        "Pruned synapse count overflow (usize -> u32): {}",
                        pruned_synapse_count
                    ))
                })?;
                let state_manager = StateManager::instance();
                let state_manager = state_manager.read();
                let core_state = state_manager.get_core_state();
                core_state.subtract_synapse_count(pruned_u32);
                state_manager.subtract_cortical_area_outgoing_synapses(
                    &src_area_id.as_base_64(),
                    pruned_synapse_count,
                );
                state_manager.subtract_cortical_area_incoming_synapses(
                    &dst_area_id.as_base_64(),
                    pruned_synapse_count,
                );

                // Best-effort: adjust per-area outgoing synapse count cache for the source area.
                // (Cache is used for lock-free health-check reads; correctness is eventually
                // consistent via periodic refresh of global count from NPU.)
                {
                    let mut cache = self.cached_synapse_counts_per_area.write();
                    let entry = cache
                        .entry(*src_area_id)
                        .or_insert_with(|| AtomicUsize::new(0));
                    let mut current = entry.load(Ordering::Relaxed);
                    loop {
                        let next = current.saturating_sub(pruned_synapse_count);
                        match entry.compare_exchange(
                            current,
                            next,
                            Ordering::Relaxed,
                            Ordering::Relaxed,
                        ) {
                            Ok(_) => break,
                            Err(v) => current = v,
                        }
                    }
                }
            }
        }

        // Apply cortical mapping rules to create synapses (may be 0 for memory areas).
        //
        // IMPORTANT:
        // - We already pruned A→B synapses above to ensure no stale synapses remain after a rule removal/update.
        // - `apply_cortical_mapping_for_pair()` returns the created synapse count but does not update
        //   StateManager/caches; we do that immediately after the call.
        let synapse_count = self.apply_cortical_mapping_for_pair(src_area_id, dst_area_id)?;
        tracing::debug!(
            target: "feagi-bdu",
            "Synaptogenesis created {} synapses for {} -> {}",
            synapse_count,
            src_area_id,
            dst_area_id
        );

        // Update synapse count caches and StateManager based on synapses created.
        // NOTE: apply_cortical_mapping_for_pair() does not touch caches/StateManager.
        if synapse_count > 0 {
            let created_u32 = u32::try_from(synapse_count).map_err(|_| {
                BduError::Internal(format!(
                    "Created synapse count overflow (usize -> u32): {}",
                    synapse_count
                ))
            })?;

            // Update per-area outgoing synapse count cache (source area)
            {
                let mut cache = self.cached_synapse_counts_per_area.write();
                cache
                    .entry(*src_area_id)
                    .or_insert_with(|| AtomicUsize::new(0))
                    .fetch_add(synapse_count, Ordering::Relaxed);
            }

            // Update StateManager synapse count (health_check endpoint)
            let state_manager = StateManager::instance();
            let state_manager = state_manager.read();
            let core_state = state_manager.get_core_state();
            core_state.add_synapse_count(created_u32);
            state_manager
                .add_cortical_area_outgoing_synapses(&src_area_id.as_base_64(), synapse_count);
            state_manager
                .add_cortical_area_incoming_synapses(&dst_area_id.as_base_64(), synapse_count);
        }

        // Update upstream area tracking based on MAPPING existence, not synapse count
        // Memory areas have 0 synapses but still need upstream tracking for pattern detection
        let src_idx_for_upstream = src_idx;

        // Check if mapping exists by looking at cortical_mapping_dst property (after update)
        let has_mapping = self
            .cortical_areas
            .get(src_area_id)
            .and_then(|area| area.properties.get("cortical_mapping_dst"))
            .and_then(|v| v.as_object())
            .and_then(|map| map.get(&dst_area_id.as_base_64()))
            .is_some();

        debug!(target: "feagi-bdu",
            "Mapping result: {} synapses, {} -> {} (mapping_exists={}, will {}update upstream)",
            synapse_count,
            src_area_id.as_base_64(),
            dst_area_id.as_base_64(),
            has_mapping,
            if has_mapping { "" } else { "NOT " }
        );

        if has_mapping {
            // Mapping exists - add to upstream tracking (for both memory and regular areas)
            self.add_upstream_area(dst_area_id, src_idx_for_upstream);

            if let Some(dst_area) = self.cortical_areas.get(dst_area_id) {
                if matches!(dst_area.cortical_type, CorticalAreaType::Memory(_)) {
                    if let Err(e) = self.ensure_memory_twin_area(dst_area_id, src_area_id) {
                        warn!(
                            target: "feagi-bdu",
                            "Failed to ensure memory twin for {} -> {}: {}",
                            src_area_id.as_base_64(),
                            dst_area_id.as_base_64(),
                            e
                        );
                    }
                }
            }

            // If destination is a memory area, register it with PlasticityExecutor (automatic)
            #[cfg(feature = "plasticity")]
            if let Some(ref executor) = self.plasticity_executor {
                use feagi_evolutionary::extract_memory_properties;

                if let Some(dst_area) = self.cortical_areas.get(dst_area_id) {
                    if let Some(mem_props) = extract_memory_properties(&dst_area.properties) {
                        let upstream_areas = self.get_upstream_cortical_areas(dst_area_id);
                        debug!(
                            target: "feagi-bdu",
                            "Registering memory area idx={} id={} upstream={} depth={}",
                            dst_area.cortical_idx,
                            dst_area_id.as_base_64(),
                            upstream_areas.len(),
                            mem_props.temporal_depth
                        );

                        // Ensure FireLedger tracks the upstream areas with at least the required temporal depth.
                        // Dense, burst-aligned tracking is required for correct memory pattern hashing.
                        if let Some(ref npu_arc) = self.npu {
                            if let Ok(mut npu) = npu_arc.lock() {
                                let existing_configs = npu.get_all_fire_ledger_configs();
                                for &upstream_idx in &upstream_areas {
                                    let existing = existing_configs
                                        .iter()
                                        .find(|(idx, _)| *idx == upstream_idx)
                                        .map(|(_, w)| *w)
                                        .unwrap_or(0);

                                    let desired = mem_props.temporal_depth as usize;
                                    let resolved = existing.max(desired);
                                    if resolved != existing {
                                        if let Err(e) =
                                            npu.configure_fire_ledger_window(upstream_idx, resolved)
                                        {
                                            warn!(
                                                target: "feagi-bdu",
                                                "Failed to configure FireLedger window for upstream area idx={} (requested={}): {}",
                                                upstream_idx,
                                                resolved,
                                                e
                                            );
                                        }
                                    }
                                }
                            } else {
                                warn!(target: "feagi-bdu", "Failed to lock NPU for FireLedger configuration");
                            }
                        }

                        if let Ok(exec) = executor.lock() {
                            use feagi_npu_plasticity::{
                                MemoryNeuronLifecycleConfig, PlasticityExecutor,
                            };

                            let lifecycle_config = MemoryNeuronLifecycleConfig {
                                initial_lifespan: mem_props.init_lifespan,
                                lifespan_growth_rate: mem_props.lifespan_growth_rate,
                                longterm_threshold: mem_props.longterm_threshold,
                                max_reactivations: 1000,
                            };

                            exec.register_memory_area(
                                dst_area.cortical_idx,
                                dst_area_id.as_base_64(),
                                mem_props.temporal_depth,
                                upstream_areas.clone(),
                                Some(lifecycle_config),
                                mem_props.mp_learning_enabled,
                            );
                        } else {
                            warn!(target: "feagi-bdu", "Failed to lock PlasticityExecutor");
                        }
                    } else {
                        debug!(
                            target: "feagi-bdu",
                            "Skipping plasticity registration: no memory properties for area {}",
                            dst_area_id.as_base_64()
                        );
                    }
                } else {
                    warn!(target: "feagi-bdu", "Destination area {} not found in cortical_areas", dst_area_id.as_base_64());
                }
            } else {
                warn!(
                    target: "feagi-bdu",
                    "PlasticityExecutor not available; memory area {} not registered",
                    dst_area_id.as_base_64()
                );
            }

            #[cfg(not(feature = "plasticity"))]
            {
                info!(target: "feagi-bdu", "Plasticity feature disabled at compile time");
            }
        } else {
            // Mapping deleted - remove from upstream tracking
            self.remove_upstream_area(dst_area_id, src_idx_for_upstream);

            // Ensure any STDP mapping parameters for this pair are removed when the mapping is gone.
            let mut npu = npu_arc.lock().unwrap();
            let _was_registered = npu.unregister_stdp_mapping(src_idx, dst_idx);
        }

        debug!(
            target: "feagi-bdu",
            "Created {} new synapses: {} -> {}",
            synapse_count,
            src_area_id,
            dst_area_id
        );

        // CRITICAL: Rebuild synapse index so removals are reflected in propagation and query paths.
        // Many morphology paths rebuild the index after creation, but pruning requires an explicit rebuild.
        if pruned_synapse_count > 0 || synapse_count == 0 {
            let mut npu = npu_arc.lock().unwrap();
            npu.rebuild_synapse_index();
            info!(
                target: "feagi-bdu",
                "Rebuilt synapse index after regenerating {} -> {} (pruned={}, created={})",
                src_area_id,
                dst_area_id,
                pruned_synapse_count,
                synapse_count
            );
        } else {
            debug!(
                target: "feagi-bdu",
                "Skipped synapse index rebuild for mapping {} -> {} (created={}, pruned=0; index rebuilt during synaptogenesis)",
                src_area_id,
                dst_area_id,
                synapse_count
            );
        }

        // Refresh the global synapse count cache from NPU (deterministic after prune/create).
        {
            let npu = npu_arc.lock().unwrap();
            let fresh_count = npu.get_synapse_count();
            self.cached_synapse_count
                .store(fresh_count, Ordering::Relaxed);
        }

        Ok(synapse_count)
    }

    /// Whole numbers often arrive as JSON floats (e.g. `1.0`); `as_i64`/`as_u64` return None for those.
    fn json_number_as_i64_for_stdp(v: &serde_json::Value) -> Option<i64> {
        v.as_i64().or_else(|| v.as_f64().map(|f| f as i64))
    }

    fn json_number_as_usize_for_stdp(v: &serde_json::Value) -> Option<usize> {
        v.as_u64()
            .map(|n| n as usize)
            .or_else(|| v.as_f64().map(|f| f as usize))
    }

    /// Register STDP mapping parameters for a plastic rule
    #[allow(clippy::too_many_arguments)]
    fn register_stdp_mapping_for_rule(
        npu: &Arc<feagi_npu_burst_engine::TracingMutex<feagi_npu_burst_engine::DynamicNPU>>,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
        src_cortical_idx: u32,
        dst_cortical_idx: u32,
        rule_obj: &serde_json::Map<String, serde_json::Value>,
        bidirectional_stdp: bool,
        synapse_psp: f32,
        synapse_type: feagi_npu_neural::SynapseType,
    ) -> BduResult<()> {
        let plasticity_window = rule_obj
            .get("plasticity_window")
            .and_then(Self::json_number_as_usize_for_stdp)
            .ok_or_else(|| {
                BduError::Internal(format!(
                    "Missing plasticity_window in plastic mapping rule {} -> {}",
                    src_area_id, dst_area_id
                ))
            })?;
        let plasticity_constant = rule_obj
            .get("plasticity_constant")
            .and_then(Self::json_number_as_i64_for_stdp)
            .ok_or_else(|| {
                BduError::Internal(format!(
                    "Missing plasticity_constant in plastic mapping rule {} -> {}",
                    src_area_id, dst_area_id
                ))
            })?;
        let ltp_i64 = rule_obj
            .get("ltp_multiplier")
            .and_then(Self::json_number_as_i64_for_stdp)
            .ok_or_else(|| {
                BduError::Internal(format!(
                    "Missing ltp_multiplier in plastic mapping rule {} -> {}",
                    src_area_id, dst_area_id
                ))
            })?;
        let ltp_multiplier = i8::try_from(ltp_i64).map_err(|_| {
            BduError::Internal(format!(
                "ltp_multiplier must fit in i8 range {}..={} (got {}) on mapping {} -> {}",
                i8::MIN,
                i8::MAX,
                ltp_i64,
                src_area_id,
                dst_area_id
            ))
        })?;
        let ltd_i64 = rule_obj
            .get("ltd_multiplier")
            .and_then(Self::json_number_as_i64_for_stdp)
            .ok_or_else(|| {
                BduError::Internal(format!(
                    "Missing ltd_multiplier in plastic mapping rule {} -> {}",
                    src_area_id, dst_area_id
                ))
            })?;
        let ltd_multiplier = i8::try_from(ltd_i64).map_err(|_| {
            BduError::Internal(format!(
                "ltd_multiplier must fit in i8 range {}..={} (got {}) on mapping {} -> {}",
                i8::MIN,
                i8::MAX,
                ltd_i64,
                src_area_id,
                dst_area_id
            ))
        })?;

        // Resolve plasticity_mode with legacy fallback (auto-migrate strategy):
        //   - new genomes set `plasticity_mode: "off" | "stdp" | "rstdp"` directly;
        //   - legacy genomes only have `plasticity_flag: bool` -> Stdp / Off mapping.
        let plasticity_mode = match rule_obj.get("plasticity_mode").and_then(|v| v.as_str()) {
            Some(s) if s.eq_ignore_ascii_case("rstdp") || s.eq_ignore_ascii_case("r-stdp") => {
                feagi_npu_burst_engine::npu::PlasticityMode::RStdp
            }
            Some(s) if s.eq_ignore_ascii_case("stdp") => {
                feagi_npu_burst_engine::npu::PlasticityMode::Stdp
            }
            Some(s) if s.eq_ignore_ascii_case("off") => {
                feagi_npu_burst_engine::npu::PlasticityMode::Off
            }
            Some(other) => {
                return Err(BduError::Internal(format!(
                    "Unknown plasticity_mode '{}' in mapping rule {} -> {}",
                    other, src_area_id, dst_area_id
                )));
            }
            None => feagi_npu_burst_engine::npu::PlasticityMode::Stdp,
        };

        // R-STDP-only fields. Strings name cortical areas by 6-char base-64 ID; resolve via NPU.
        let eligibility_decay_bursts = rule_obj
            .get("eligibility_decay_bursts")
            .and_then(|v| v.as_u64())
            .map(|n| n as u32)
            .unwrap_or(0);
        let reward_source_area_id = rule_obj
            .get("reward_source_area")
            .and_then(|v| v.as_str())
            .map(str::to_string);
        let punishment_source_area_id = rule_obj
            .get("punishment_source_area")
            .and_then(|v| v.as_str())
            .map(str::to_string);

        // Optional upper-bound clamp for plasticity weight commits. Absent / null means no
        // clamp (legacy unbounded behaviour). When provided, must be a strictly positive
        // f32 (finite or `+inf`); `NaN`, zero, and negatives are rejected so the runtime
        // never sees a malformed sentinel.
        let max_weight_provided = rule_obj.get("max_weight").is_some()
            && !rule_obj
                .get("max_weight")
                .map(|v| v.is_null())
                .unwrap_or(true);
        let max_weight: f32 = if max_weight_provided {
            let raw = rule_obj
                .get("max_weight")
                .and_then(|v| v.as_f64())
                .ok_or_else(|| {
                    BduError::Internal(format!(
                        "max_weight must be a number on mapping {} -> {}",
                        src_area_id, dst_area_id
                    ))
                })?;
            if raw.is_nan() || raw <= 0.0 {
                return Err(BduError::Internal(format!(
                    "max_weight must be strictly positive (got {}) on mapping {} -> {}",
                    raw, src_area_id, dst_area_id
                )));
            }
            raw as f32
        } else {
            f32::INFINITY
        };

        // Optional f32 learning-rate scale on the end-of-burst weight commit: w += eta * R * e.
        // Omitted / null → 1.0. Must be finite, strictly positive, and not +inf.
        let plasticity_eta_provided = rule_obj.get("plasticity_eta").is_some()
            && !rule_obj
                .get("plasticity_eta")
                .map(|v| v.is_null())
                .unwrap_or(true);
        let plasticity_eta: f32 = if plasticity_eta_provided {
            let raw = rule_obj
                .get("plasticity_eta")
                .and_then(|v| v.as_f64())
                .ok_or_else(|| {
                    BduError::Internal(format!(
                        "plasticity_eta must be a number on mapping {} -> {}",
                        src_area_id, dst_area_id
                    ))
                })?;
            if raw.is_nan() || raw <= 0.0 || !raw.is_finite() {
                return Err(BduError::Internal(format!(
                    "plasticity_eta must be finite and strictly positive (got {}) on mapping {} -> {}",
                    raw, src_area_id, dst_area_id
                )));
            }
            raw as f32
        } else {
            1.0
        };

        // Validate R-STDP fields are absent when not in RStdp mode (catches genome typos early).
        if !matches!(
            plasticity_mode,
            feagi_npu_burst_engine::npu::PlasticityMode::RStdp
        ) && (reward_source_area_id.is_some()
            || punishment_source_area_id.is_some()
            || eligibility_decay_bursts != 0)
        {
            return Err(BduError::Internal(format!(
                "R-STDP fields (reward_source_area / punishment_source_area / eligibility_decay_bursts) \
                 only valid when plasticity_mode='rstdp' on mapping {} -> {}",
                src_area_id, dst_area_id
            )));
        }

        // `max_weight` is only meaningful when plasticity is active. Reject explicit values
        // on Off-mode mappings to surface genome typos early; an absent field silently
        // resolves to `f32::INFINITY` above and is fine.
        if matches!(
            plasticity_mode,
            feagi_npu_burst_engine::npu::PlasticityMode::Off
        ) && max_weight_provided
        {
            return Err(BduError::Internal(format!(
                "max_weight is only valid when plasticity_mode is 'stdp' or 'rstdp' (got off) on mapping {} -> {}",
                src_area_id, dst_area_id
            )));
        }

        if matches!(
            plasticity_mode,
            feagi_npu_burst_engine::npu::PlasticityMode::Off
        ) && plasticity_eta_provided
        {
            return Err(BduError::Internal(format!(
                "plasticity_eta is only valid when plasticity_mode is 'stdp' or 'rstdp' (got off) on mapping {} -> {}",
                src_area_id, dst_area_id
            )));
        }

        trace!(target: "feagi-bdu", "[LOCK-TRACE] create_neurons_for_area: attempting NPU lock");
        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;
        trace!(target: "feagi-bdu", "[LOCK-TRACE] create_neurons_for_area: acquired NPU lock");

        // Resolve reward/punishment area names to cortical_idx (R-STDP only). The detector
        // areas must already be registered with the NPU before this mapping is parsed; the
        // genome ordering normally handles this because cortical areas are processed before
        // their cross-area mapping rules.
        let resolve_optional_area =
            |label: &str, name_opt: &Option<String>| -> BduResult<Option<u32>> {
                let Some(name) = name_opt else {
                    return Ok(None);
                };
                match npu_lock.get_cortical_area_id(name.as_str()) {
                    Some(idx) => Ok(Some(idx)),
                    None => Err(BduError::Internal(format!(
                        "Unknown {} cortical area '{}' on R-STDP mapping {} -> {}",
                        label, name, src_area_id, dst_area_id
                    ))),
                }
            };
        let reward_source_area =
            resolve_optional_area("reward_source_area", &reward_source_area_id)?;
        let punishment_source_area =
            resolve_optional_area("punishment_source_area", &punishment_source_area_id)?;

        // Off-mode mappings are skipped (no NPU registration, no fire-ledger tracking).
        if matches!(
            plasticity_mode,
            feagi_npu_burst_engine::npu::PlasticityMode::Off
        ) {
            return Ok(());
        }

        let params = feagi_npu_burst_engine::npu::StdpMappingParams {
            plasticity_window,
            plasticity_constant,
            ltp_multiplier,
            ltd_multiplier,
            bidirectional_stdp,
            synapse_psp,
            synapse_type,
            plasticity_mode,
            eligibility_decay_bursts,
            reward_source_area,
            punishment_source_area,
            max_weight,
            plasticity_eta,
        };

        npu_lock
            .register_stdp_mapping(src_cortical_idx, dst_cortical_idx, params)
            .map_err(|e| {
                BduError::Internal(format!(
                    "Failed to register STDP mapping {} -> {}: {}",
                    src_area_id, dst_area_id, e
                ))
            })?;

        // FireLedger tracking. Plain STDP needs depth=plasticity_window on src+dst. R-STDP
        // additionally needs depth>=1 on reward/punishment source areas so `activity_density`
        // can sample current-burst firing.
        let mut areas_to_track: Vec<(u32, usize)> = vec![
            (src_cortical_idx, plasticity_window),
            (dst_cortical_idx, plasticity_window),
        ];
        if let Some(area) = reward_source_area {
            areas_to_track.push((area, 1));
        }
        if let Some(area) = punishment_source_area {
            areas_to_track.push((area, 1));
        }

        let existing_configs = npu_lock.get_all_fire_ledger_configs();
        for (area_idx, required_depth) in areas_to_track {
            let existing = existing_configs
                .iter()
                .find(|(idx, _)| *idx == area_idx)
                .map(|(_, w)| *w)
                .unwrap_or(0);
            let resolved = existing.max(required_depth);
            if resolved != existing {
                npu_lock
                    .configure_fire_ledger_window(area_idx, resolved)
                    .map_err(|e| {
                        BduError::Internal(format!(
                            "Failed to configure FireLedger window for area idx={} (requested={}): {}",
                            area_idx, resolved, e
                        ))
                    })?;
            }
        }

        Ok(())
    }

    /// Resolve synapse weight, PSP, type, and per-synapse delay (bursts) from a mapping rule.
    fn resolve_synapse_params_for_rule(
        &self,
        src_area_id: &CorticalID,
        rule: &serde_json::Value,
    ) -> BduResult<(f32, f32, feagi_npu_neural::SynapseType, u8)> {
        // Get source area to access PSP property
        let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
            crate::types::BduError::InvalidArea(format!("Source area not found: {}", src_area_id))
        })?;

        // Extract weight from rule (`postSynapticCurrent_multiplier`) as full-precision float.
        let (weight, synapse_type) = {
            let parse_f64 = |v: &serde_json::Value| -> Option<f64> {
                if let Some(i) = v.as_i64() {
                    return Some(i as f64);
                }
                v.as_f64()
            };

            let mult: f64 = if let Some(obj) = rule.as_object() {
                obj.get("postSynapticCurrent_multiplier")
                    .and_then(parse_f64)
                    .unwrap_or(1.0)
            } else if let Some(arr) = rule.as_array() {
                arr.get(2).and_then(parse_f64).unwrap_or(1.0)
            } else {
                128.0
            };

            if mult < 0.0 {
                (mult.abs() as f32, feagi_npu_neural::SynapseType::Inhibitory)
            } else {
                (mult as f32, feagi_npu_neural::SynapseType::Excitatory)
            }
        };

        // PSP from source cortical area (float; stored as f32 on synapses)
        use crate::models::cortical_area::CorticalAreaExt;
        let psp_f32 = src_area.postsynaptic_current();

        let delay_bursts: u8 = if let Some(obj) = rule.as_object() {
            obj.get("synaptic_delay_bursts")
                .and_then(|v| v.as_u64())
                .map(|d| u8::try_from(d).unwrap_or(1))
                .unwrap_or(1)
        } else if let Some(arr) = rule.as_array() {
            arr.get(8)
                .and_then(|v| v.as_u64())
                .map(|d| u8::try_from(d).unwrap_or(1))
                .unwrap_or(1)
        } else {
            1
        };
        if delay_bursts < 1 {
            return Err(crate::types::BduError::Internal(format!(
                "synaptic_delay_bursts must be >= 1 (src area {})",
                src_area_id.as_base_64()
            )));
        }

        tracing::debug!(
            target: "feagi-bdu",
            "Resolved synapse params src={} weight={} psp={} type={:?} delay_bursts={}",
            src_area_id.as_base_64(),
            weight,
            psp_f32,
            synapse_type,
            delay_bursts
        );

        Ok((weight, psp_f32, synapse_type, delay_bursts))
    }

    /// Apply cortical mapping for a specific area pair
    fn apply_cortical_mapping_for_pair(
        &mut self,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
    ) -> BduResult<usize> {
        // Clone the rules to avoid borrow checker issues.
        //
        // IMPORTANT: absence of mapping rules is a valid state (e.g. mapping deletion).
        // In that case, return Ok(0) rather than an error so API callers can treat
        // "deleted mapping" as success (and BV can update its cache/UI).
        let rules = {
            let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                crate::types::BduError::InvalidArea(format!(
                    "Source area not found: {}",
                    src_area_id
                ))
            })?;

            let Some(mapping_dst) = src_area
                .properties
                .get("cortical_mapping_dst")
                .and_then(|v| v.as_object())
            else {
                return Ok(0);
            };

            let Some(rules) = Self::get_mapping_rules_for_destination(mapping_dst, dst_area_id)
            else {
                return Ok(0);
            };

            rules.clone()
        }; // Borrow ends here

        if rules.is_empty() {
            return Ok(0);
        }

        // Get indices for STDP handling
        let src_cortical_idx = *self.cortical_id_to_idx.get(src_area_id).ok_or_else(|| {
            crate::types::BduError::InvalidArea(format!("No index for {}", src_area_id))
        })?;
        let dst_cortical_idx = *self.cortical_id_to_idx.get(dst_area_id).ok_or_else(|| {
            crate::types::BduError::InvalidArea(format!("No index for {}", dst_area_id))
        })?;

        // Clone NPU Arc for STDP handling (Arc::clone is cheap - just increments ref count)
        let npu_arc = self
            .npu
            .as_ref()
            .ok_or_else(|| crate::types::BduError::Internal("NPU not connected".to_string()))?
            .clone();

        tracing::debug!(
            target: "feagi-bdu",
            "Applying {} mapping rule(s) for {} -> {}",
            rules.len(),
            src_area_id,
            dst_area_id
        );
        // Apply each morphology rule
        let mut total_synapses = 0;
        for rule in &rules {
            let morphology_id = if let Some(rule_obj) = rule.as_object() {
                rule_obj
                    .get("morphology_id")
                    .and_then(|v| v.as_str())
                    .unwrap_or("unknown")
                    .to_string()
            } else if let Some(rule_arr) = rule.as_array() {
                rule_arr
                    .first()
                    .and_then(|v| v.as_str())
                    .unwrap_or("unknown")
                    .to_string()
            } else {
                "unknown".to_string()
            };

            let rule_keys: Vec<String> = rule
                .as_object()
                .map(|obj| obj.keys().cloned().collect())
                .unwrap_or_default();

            // Handle STDP/plasticity configuration if needed
            let mut plasticity_flag = rule
                .as_object()
                .and_then(|obj| obj.get("plasticity_flag"))
                .and_then(|v| v.as_bool())
                .unwrap_or(false);
            if morphology_id == "associative_memory" {
                plasticity_flag = true;
            }
            if plasticity_flag {
                let Some(rule_obj) = rule.as_object() else {
                    return Err(crate::types::BduError::InvalidMorphology(
                        "Plasticity mapping rule must be an object format".to_string(),
                    ));
                };
                let (_weight, psp, synapse_type, _delay_bursts) =
                    self.resolve_synapse_params_for_rule(src_area_id, rule)?;
                // Associative-memory mappings are directional.
                // Bidirectional behavior requires two explicit mappings (A->B and B->A).
                let bidirectional_stdp = false;
                if let Err(e) = Self::register_stdp_mapping_for_rule(
                    &npu_arc,
                    src_area_id,
                    dst_area_id,
                    src_cortical_idx,
                    dst_cortical_idx,
                    rule_obj,
                    bidirectional_stdp,
                    psp,
                    synapse_type,
                ) {
                    tracing::error!(
                        target: "feagi-bdu",
                        "STDP mapping registration failed for {} -> {} (morphology={}, keys={:?}): {}",
                        src_area_id,
                        dst_area_id,
                        morphology_id,
                        rule_keys,
                        e
                    );
                    return Err(e);
                }
            }

            // Handle conditional gate (transistor synapse) configuration if present.
            // The gate_source_area field specifies a cortical area whose firing activity
            // gates propagation through all synapses created by this mapping rule.
            if let Some(gate_area_str) = rule
                .as_object()
                .and_then(|obj| obj.get("gate_source_area"))
                .and_then(|v| v.as_str())
            {
                let gate_area_id = CorticalID::try_from_base_64(gate_area_str).map_err(|_| {
                    crate::types::BduError::Internal(format!(
                        "Invalid gate_source_area '{}' on mapping {} -> {}",
                        gate_area_str, src_area_id, dst_area_id
                    ))
                })?;
                let gate_cortical_idx =
                    self.cortical_id_to_idx.get(&gate_area_id).ok_or_else(|| {
                        crate::types::BduError::Internal(format!(
                            "Unknown gate_source_area '{}' on mapping {} -> {}",
                            gate_area_str, src_area_id, dst_area_id
                        ))
                    })?;

                let mut npu_lock = npu_arc.lock().map_err(|_| {
                    crate::types::BduError::Internal(
                        "Failed to acquire NPU lock for gate registration".to_string(),
                    )
                })?;
                if let Err(e) = npu_lock.register_gate_mapping(
                    src_cortical_idx,
                    dst_cortical_idx,
                    *gate_cortical_idx,
                ) {
                    tracing::error!(
                        target: "feagi-bdu",
                        "Gate mapping registration failed for {} -> {} (gate={}): {}",
                        src_area_id,
                        dst_area_id,
                        gate_area_str,
                        e
                    );
                    return Err(crate::types::BduError::Internal(format!(
                        "Gate registration failed: {}",
                        e
                    )));
                }
            }

            // Apply the morphology rule
            let synapse_count = match self.apply_single_morphology_rule(
                src_area_id,
                dst_area_id,
                rule,
            ) {
                Ok(count) => count,
                Err(e) => {
                    tracing::error!(
                        target: "feagi-bdu",
                        "Mapping rule application failed for {} -> {} (morphology={}, keys={:?}): {}",
                        src_area_id,
                        dst_area_id,
                        morphology_id,
                        rule_keys,
                        e
                    );
                    return Err(e);
                }
            };
            total_synapses += synapse_count;
            tracing::debug!(
                target: "feagi-bdu",
                "Rule {} created {} synapses for {} -> {}",
                morphology_id,
                synapse_count,
                src_area_id,
                dst_area_id
            );
        }

        Ok(total_synapses)
    }

    /// Apply a function-type morphology (projector, memory, block_to_block, etc.)
    ///
    /// This helper consolidates all function-type morphology logic in one place.
    /// Function-type morphologies are code-driven and require code changes to add new ones.
    ///
    /// # Arguments
    /// * `morphology_id` - The morphology ID string (e.g., "projector", "block_to_block")
    /// * `rule` - The morphology rule JSON value
    /// * `npu_arc` - Arc to the NPU (for batched operations)
    /// * `npu` - Locked NPU reference
    /// * `src_area_id`, `dst_area_id` - Source and destination area IDs
    /// * `src_idx`, `dst_idx` - Source and destination area indices
    /// * `weight`, `psp`, `synapse_attractivity` - Synapse parameters
    #[allow(clippy::too_many_arguments)]
    fn apply_function_morphology(
        &self,
        morphology_id: &str,
        rule: &serde_json::Value,
        npu_arc: &Arc<feagi_npu_burst_engine::TracingMutex<feagi_npu_burst_engine::DynamicNPU>>,
        npu: &mut feagi_npu_burst_engine::DynamicNPU,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
        src_idx: u32,
        dst_idx: u32,
        weight: f32,
        psp: f32,
        synapse_attractivity: u8,
        synapse_type: feagi_npu_neural::SynapseType,
        delay_bursts: u8,
    ) -> BduResult<usize> {
        match morphology_id {
            "projector" | "transpose_xy" | "transpose_yz" | "transpose_xz" => {
                // Get dimensions from cortical areas (no neuron scanning!)
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;

                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                // Legacy-compatible transpose mappings from Python FEAGI:
                // projector_xy -> (y, x, z), projector_yz -> (x, z, y), projector_xz -> (z, y, x)
                let transpose = match morphology_id {
                    "transpose_xy" => Some((1, 0, 2)),
                    "transpose_yz" => Some((0, 2, 1)),
                    "transpose_xz" => Some((2, 1, 0)),
                    _ => None,
                };

                use crate::connectivity::core_morphologies::apply_projector_morphology_with_dimensions;
                let count = apply_projector_morphology_with_dimensions(
                    npu,
                    src_idx,
                    dst_idx,
                    src_dimensions,
                    dst_dimensions,
                    transpose,
                    None, // project_last_layer_of
                    weight,
                    psp,
                    synapse_attractivity,
                    synapse_type,
                    0,
                    delay_bursts,
                )?;
                // Ensure the propagation engine sees the newly created synapses immediately
                npu.rebuild_synapse_index();
                Ok(count as usize)
            }
            "centered_projector" => {
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;

                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                let count = crate::connectivity::core_morphologies::apply_centered_projector_morphology_with_dimensions(
                    npu,
                    src_idx,
                    dst_idx,
                    src_dimensions,
                    dst_dimensions,
                    weight,
                    psp,
                    synapse_attractivity,
                    synapse_type,
                    delay_bursts,
                )?;
                if count > 0 {
                    npu.rebuild_synapse_index();
                }
                Ok(count as usize)
            }
            "episodic_memory" => {
                // Episodic memory morphology: No physical synapses created
                // Pattern detection and memory neuron creation handled by PlasticityService
                use tracing::trace;
                trace!(
                    target: "feagi-bdu",
                    "Episodic memory morphology: {} -> {} (no physical synapses, plasticity-driven)",
                    src_idx, dst_idx
                );
                Ok(0)
            }
            "memory_replay" => {
                // Replay mapping: semantic only, no physical synapses
                use tracing::trace;
                trace!(
                    target: "feagi-bdu",
                    "Memory replay morphology: {} -> {} (no physical synapses)",
                    src_idx, dst_idx
                );
                Ok(0)
            }
            "associative_memory" => {
                // Associative memory (bi-directional STDP) mapping:
                // If both ends are memory areas, create synapses between LIF twins to enable associations.
                // Otherwise, no initial synapses are created (STDP will update existing synapses).
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;

                if matches!(src_area.cortical_type, CorticalAreaType::Memory(_))
                    && matches!(dst_area.cortical_type, CorticalAreaType::Memory(_))
                {
                    let src_dimensions = (
                        src_area.dimensions.width as usize,
                        src_area.dimensions.height as usize,
                        src_area.dimensions.depth as usize,
                    );
                    let dst_dimensions = (
                        dst_area.dimensions.width as usize,
                        dst_area.dimensions.height as usize,
                        dst_area.dimensions.depth as usize,
                    );
                    use crate::connectivity::core_morphologies::apply_projector_morphology_with_dimensions;
                    let count = apply_projector_morphology_with_dimensions(
                        npu,
                        src_idx,
                        dst_idx,
                        src_dimensions,
                        dst_dimensions,
                        None,
                        None,
                        weight,
                        psp,
                        synapse_attractivity,
                        synapse_type,
                        SYNAPSE_EDGE_ASSOCIATIVE_MEMORY,
                        delay_bursts,
                    )?;
                    npu.rebuild_synapse_index();
                    Ok(count as usize)
                } else {
                    Ok(0)
                }
            }
            "block_to_block" => {
                tracing::warn!(
                    target: "feagi-bdu",
                    "🔍 DEBUG apply_function_morphology: block_to_block case reached with src_idx={}, dst_idx={}",
                    src_idx, dst_idx
                );
                // Get dimensions from cortical areas (no neuron scanning!)
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;

                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                // Extract scalar from rule (morphology_scalar)
                let scalar = if let Some(obj) = rule.as_object() {
                    // Object format: get from morphology_scalar array
                    if let Some(scalar_arr) =
                        obj.get("morphology_scalar").and_then(|v| v.as_array())
                    {
                        // Use first element as scalar (or default to 1)
                        scalar_arr.first().and_then(|v| v.as_i64()).unwrap_or(1) as u32
                    } else {
                        1 // @architecture:acceptable - default scalar
                    }
                } else if let Some(arr) = rule.as_array() {
                    // Array format: [morphology_id, scalar, multiplier, ...]
                    arr.get(1).and_then(|v| v.as_i64()).unwrap_or(1) as u32
                } else {
                    1 // @architecture:acceptable - default scalar
                };

                // CRITICAL: Do NOT call get_neurons_in_cortical_area to check neuron count!
                // Use dimensions to estimate: if area is large, use batched version
                let estimated_neurons = src_dimensions.0 * src_dimensions.1 * src_dimensions.2;
                let count = if estimated_neurons > 100_000 {
                    // Release lock and use batched version
                    let _ = npu;

                    crate::connectivity::synaptogenesis::apply_block_connection_morphology_batched(
                        npu_arc,
                        src_idx,
                        dst_idx,
                        src_dimensions,
                        dst_dimensions,
                        scalar, // scaling_factor
                        weight,
                        psp,
                        synapse_attractivity,
                        synapse_type,
                        delay_bursts,
                    )? as usize
                } else {
                    // Small area: use regular version (faster for small counts)
                    tracing::warn!(
                        target: "feagi-bdu",
                        "🔍 DEBUG connectome_manager: Calling apply_block_connection_morphology with src_idx={}, dst_idx={}, src_dim={:?}, dst_dim={:?}",
                        src_idx, dst_idx, src_dimensions, dst_dimensions
                    );
                    let count =
                        crate::connectivity::synaptogenesis::apply_block_connection_morphology(
                            npu,
                            src_idx,
                            dst_idx,
                            src_dimensions,
                            dst_dimensions,
                            scalar, // scaling_factor
                            weight,
                            psp,
                            synapse_attractivity,
                            synapse_type,
                            delay_bursts,
                        )? as usize;
                    tracing::warn!(
                        target: "feagi-bdu",
                        "🔍 DEBUG connectome_manager: apply_block_connection_morphology returned count={}",
                        count
                    );
                    // Rebuild synapse index while we still have the lock
                    if count > 0 {
                        npu.rebuild_synapse_index();
                    }
                    count
                };

                // Ensure the propagation engine sees the newly created synapses immediately (batched version only)
                if count > 0 && estimated_neurons > 100_000 {
                    let mut npu_lock = npu_arc.lock().unwrap();
                    npu_lock.rebuild_synapse_index();
                }

                Ok(count)
            }
            "bitmask_encoder_x" | "bitmask_encoder_y" | "bitmask_encoder_z"
            | "bitmask_decoder_x" | "bitmask_decoder_y" | "bitmask_decoder_z" => {
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;

                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                let (axis, mode) = match morphology_id {
                    "bitmask_encoder_x" => (
                        crate::connectivity::core_morphologies::BitmaskAxis::X,
                        crate::connectivity::core_morphologies::BitmaskMode::Encoder,
                    ),
                    "bitmask_encoder_y" => (
                        crate::connectivity::core_morphologies::BitmaskAxis::Y,
                        crate::connectivity::core_morphologies::BitmaskMode::Encoder,
                    ),
                    "bitmask_encoder_z" => (
                        crate::connectivity::core_morphologies::BitmaskAxis::Z,
                        crate::connectivity::core_morphologies::BitmaskMode::Encoder,
                    ),
                    "bitmask_decoder_x" => (
                        crate::connectivity::core_morphologies::BitmaskAxis::X,
                        crate::connectivity::core_morphologies::BitmaskMode::Decoder,
                    ),
                    "bitmask_decoder_y" => (
                        crate::connectivity::core_morphologies::BitmaskAxis::Y,
                        crate::connectivity::core_morphologies::BitmaskMode::Decoder,
                    ),
                    "bitmask_decoder_z" => (
                        crate::connectivity::core_morphologies::BitmaskAxis::Z,
                        crate::connectivity::core_morphologies::BitmaskMode::Decoder,
                    ),
                    _ => unreachable!("matched bitmask morphology above"),
                };

                let count =
                    crate::connectivity::core_morphologies::apply_bitmask_morphology_with_dimensions(
                        npu,
                        src_idx,
                        dst_idx,
                        src_dimensions,
                        dst_dimensions,
                        axis,
                        mode,
                        weight,
                        psp,
                        synapse_attractivity,
                        synapse_type,
                        delay_bursts,
                    )?;
                if count > 0 {
                    npu.rebuild_synapse_index();
                }
                Ok(count as usize)
            }
            "sweeper" => {
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                let count =
                    crate::connectivity::core_morphologies::apply_sweeper_morphology_with_dimensions(
                        npu,
                        src_idx,
                        dst_idx,
                        dst_dimensions,
                        weight,
                        psp,
                        synapse_attractivity,
                        synapse_type,
                        delay_bursts,
                    )?;
                if count > 0 {
                    npu.rebuild_synapse_index();
                }
                Ok(count as usize)
            }
            "last_to_first" => {
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;
                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                let count = crate::connectivity::core_morphologies::apply_last_to_first_morphology_with_dimensions(
                    npu,
                    src_idx,
                    dst_idx,
                    src_dimensions,
                    dst_dimensions,
                    weight,
                    psp,
                    synapse_attractivity,
                    synapse_type,
                    delay_bursts,
                )?;
                if count > 0 {
                    npu.rebuild_synapse_index();
                }
                Ok(count as usize)
            }
            "first_to_last" => {
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;
                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                let count = crate::connectivity::core_morphologies::apply_first_to_last_morphology_with_dimensions(
                    npu,
                    src_idx,
                    dst_idx,
                    src_dimensions,
                    dst_dimensions,
                    weight,
                    psp,
                    synapse_attractivity,
                    synapse_type,
                    delay_bursts,
                )?;
                if count > 0 {
                    npu.rebuild_synapse_index();
                }
                Ok(count as usize)
            }
            "rotator_z" => {
                let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Source area not found: {}",
                        src_area_id
                    ))
                })?;
                let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                    crate::types::BduError::InvalidArea(format!(
                        "Destination area not found: {}",
                        dst_area_id
                    ))
                })?;
                let src_dimensions = (
                    src_area.dimensions.width as usize,
                    src_area.dimensions.height as usize,
                    src_area.dimensions.depth as usize,
                );
                let dst_dimensions = (
                    dst_area.dimensions.width as usize,
                    dst_area.dimensions.height as usize,
                    dst_area.dimensions.depth as usize,
                );

                let count = crate::connectivity::core_morphologies::apply_rotator_z_morphology_with_dimensions(
                    npu,
                    src_idx,
                    dst_idx,
                    src_dimensions,
                    dst_dimensions,
                    weight,
                    psp,
                    synapse_attractivity,
                    synapse_type,
                    delay_bursts,
                )?;
                if count > 0 {
                    npu.rebuild_synapse_index();
                }
                Ok(count as usize)
            }
            _ => {
                // Other function morphologies not yet implemented
                // NOTE: To add a new function-type morphology, add a case here
                use tracing::debug;
                debug!(target: "feagi-bdu", "Function morphology {} not yet implemented", morphology_id);
                Ok(0)
            }
        }
    }

    /// Apply a single morphology rule
    fn apply_single_morphology_rule(
        &mut self,
        src_area_id: &CorticalID,
        dst_area_id: &CorticalID,
        rule: &serde_json::Value,
    ) -> BduResult<usize> {
        // Extract morphology_id from rule (array or dict format)
        let morphology_id = if let Some(arr) = rule.as_array() {
            arr.first().and_then(|v| v.as_str()).unwrap_or("")
        } else if let Some(obj) = rule.as_object() {
            obj.get("morphology_id")
                .and_then(|v| v.as_str())
                .unwrap_or("")
        } else {
            return Ok(0);
        };

        if morphology_id.is_empty() {
            return Ok(0);
        }

        // Get morphology from registry
        let morphology = self.morphology_registry.get(morphology_id).ok_or_else(|| {
            crate::types::BduError::InvalidMorphology(format!(
                "Morphology not found: {}",
                morphology_id
            ))
        })?;

        // Convert area IDs to cortical indices (required by NPU functions)
        let src_idx = self.cortical_id_to_idx.get(src_area_id).ok_or_else(|| {
            crate::types::BduError::InvalidArea(format!(
                "Source area ID not found: {}",
                src_area_id
            ))
        })?;
        let dst_idx = self.cortical_id_to_idx.get(dst_area_id).ok_or_else(|| {
            crate::types::BduError::InvalidArea(format!(
                "Destination area ID not found: {}",
                dst_area_id
            ))
        })?;

        // Apply morphology based on type
        if let Some(ref npu_arc) = self.npu {
            let lock_start = std::time::Instant::now();
            let mut npu = npu_arc.lock().unwrap();
            let lock_wait = lock_start.elapsed();
            tracing::debug!(
                target: "feagi-bdu",
                "[NPU-LOCK] synaptogenesis lock wait {:.2}ms for {} -> {} (morphology={})",
                lock_wait.as_secs_f64() * 1000.0,
                src_area_id,
                dst_area_id,
                morphology_id
            );

            let (weight, psp, synapse_type, delay_bursts) =
                self.resolve_synapse_params_for_rule(src_area_id, rule)?;

            // Extract synapse_attractivity from rule (probability 0-100)
            let synapse_attractivity = if let Some(obj) = rule.as_object() {
                obj.get("synapse_attractivity")
                    .and_then(|v| v.as_u64())
                    .unwrap_or(100) as u8
            } else {
                100 // @architecture:acceptable - default to always create when not specified
            };

            match morphology.morphology_type {
                feagi_evolutionary::MorphologyType::Functions => {
                    tracing::debug!(
                        target: "feagi-bdu",
                        "apply_single_morphology_rule: Functions type, morphology_id={}, calling apply_function_morphology",
                        morphology_id
                    );
                    // Function-based morphologies (projector, memory, block_to_block, etc.)
                    // Delegate to helper function to consolidate all function-type logic
                    self.apply_function_morphology(
                        morphology_id,
                        rule,
                        npu_arc,
                        &mut npu,
                        src_area_id,
                        dst_area_id,
                        *src_idx,
                        *dst_idx,
                        weight,
                        psp,
                        synapse_attractivity,
                        synapse_type,
                        delay_bursts,
                    )
                }
                feagi_evolutionary::MorphologyType::Vectors => {
                    use crate::connectivity::synaptogenesis::apply_vectors_morphology_with_dimensions;

                    // Get dimensions from cortical areas (no neuron scanning!)
                    let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                        crate::types::BduError::InvalidArea(format!(
                            "Destination area not found: {}",
                            dst_area_id
                        ))
                    })?;

                    let dst_dimensions = (
                        dst_area.dimensions.width as usize,
                        dst_area.dimensions.height as usize,
                        dst_area.dimensions.depth as usize,
                    );

                    if let feagi_evolutionary::MorphologyParameters::Vectors { ref vectors } =
                        morphology.parameters
                    {
                        // Convert Vec<[i32; 3]> to Vec<(i32, i32, i32)>
                        let vectors_tuples: Vec<(i32, i32, i32)> =
                            vectors.iter().map(|v| (v[0], v[1], v[2])).collect();

                        let count = apply_vectors_morphology_with_dimensions(
                            &mut npu,
                            *src_idx,
                            *dst_idx,
                            vectors_tuples,
                            dst_dimensions,
                            weight,               // From rule, not hardcoded
                            psp,                  // PSP from source area, NOT hardcoded!
                            synapse_attractivity, // From rule, not hardcoded
                            synapse_type,
                            delay_bursts,
                        )?;
                        // Ensure the propagation engine sees the newly created synapses immediately,
                        // and avoid a second outer NPU mutex acquisition later in the mapping update path.
                        npu.rebuild_synapse_index();
                        Ok(count as usize)
                    } else {
                        Ok(0)
                    }
                }
                feagi_evolutionary::MorphologyType::Patterns => {
                    use crate::connectivity::core_morphologies::apply_patterns_morphology;
                    use crate::connectivity::rules::patterns::{
                        Pattern3D, PatternElement as RulePatternElement,
                    };
                    use feagi_evolutionary::PatternElement as EvoPatternElement;

                    let feagi_evolutionary::MorphologyParameters::Patterns { ref patterns } =
                        morphology.parameters
                    else {
                        return Ok(0);
                    };

                    let convert_element =
                        |element: &EvoPatternElement|
                         -> crate::types::BduResult<RulePatternElement> {
                            match element {
                                EvoPatternElement::Value(value) => {
                                    if *value < 0 {
                                        return Err(crate::types::BduError::InvalidMorphology(
                                            format!(
                                                "Pattern morphology {} contains negative voxel coordinate {}",
                                                morphology_id, value
                                            ),
                                        ));
                                    }
                                    Ok(RulePatternElement::Exact(*value))
                                }
                                EvoPatternElement::Wildcard => Ok(RulePatternElement::Wildcard),
                                EvoPatternElement::Skip => Ok(RulePatternElement::Skip),
                                EvoPatternElement::Exclude => Ok(RulePatternElement::Exclude),
                                EvoPatternElement::DirectionPositive => {
                                    Ok(RulePatternElement::DirectionExclusive(
                                        crate::connectivity::rules::patterns::Direction::Positive,
                                    ))
                                }
                                EvoPatternElement::DirectionNegative => {
                                    Ok(RulePatternElement::DirectionExclusive(
                                        crate::connectivity::rules::patterns::Direction::Negative,
                                    ))
                                }
                                EvoPatternElement::DirectionPositiveInclusive => {
                                    Ok(RulePatternElement::DirectionInclusive(
                                        crate::connectivity::rules::patterns::Direction::Positive,
                                    ))
                                }
                                EvoPatternElement::DirectionNegativeInclusive => {
                                    Ok(RulePatternElement::DirectionInclusive(
                                        crate::connectivity::rules::patterns::Direction::Negative,
                                    ))
                                }
                                EvoPatternElement::Offset(off) => {
                                    Ok(RulePatternElement::Offset(*off))
                                }
                                EvoPatternElement::Range(lo, hi) => {
                                    Ok(RulePatternElement::Range(*lo, *hi))
                                }
                            }
                        };

                    let mut converted_patterns = Vec::with_capacity(patterns.len());
                    for pattern_pair in patterns {
                        if pattern_pair.len() != 2 {
                            return Err(crate::types::BduError::InvalidMorphology(format!(
                                "Pattern morphology {} must contain [src, dst] pairs",
                                morphology_id
                            )));
                        }

                        let src_pattern = &pattern_pair[0];
                        let dst_pattern = &pattern_pair[1];

                        if src_pattern.len() != 3 || dst_pattern.len() != 3 {
                            return Err(crate::types::BduError::InvalidMorphology(format!(
                                "Pattern morphology {} requires 3-axis patterns",
                                morphology_id
                            )));
                        }

                        let src: Pattern3D = (
                            convert_element(&src_pattern[0])?,
                            convert_element(&src_pattern[1])?,
                            convert_element(&src_pattern[2])?,
                        );
                        let dst: Pattern3D = (
                            convert_element(&dst_pattern[0])?,
                            convert_element(&dst_pattern[1])?,
                            convert_element(&dst_pattern[2])?,
                        );

                        converted_patterns.push((src, dst));
                    }

                    let count = apply_patterns_morphology(
                        &mut npu,
                        *src_idx,
                        *dst_idx,
                        converted_patterns,
                        weight,
                        psp,
                        synapse_attractivity,
                        synapse_type,
                        delay_bursts,
                    )?;
                    if count > 0 {
                        npu.rebuild_synapse_index();
                    }
                    Ok(count as usize)
                }
                feagi_evolutionary::MorphologyType::Composite => {
                    let feagi_evolutionary::MorphologyParameters::Composite { .. } =
                        morphology.parameters
                    else {
                        return Ok(0);
                    };

                    if morphology_id != "tile" {
                        use tracing::debug;
                        debug!(
                            target: "feagi-bdu",
                            "Composite morphology {} not yet implemented",
                            morphology_id
                        );
                        return Ok(0);
                    }

                    let src_area = self.cortical_areas.get(src_area_id).ok_or_else(|| {
                        crate::types::BduError::InvalidArea(format!(
                            "Source area not found: {}",
                            src_area_id
                        ))
                    })?;
                    let dst_area = self.cortical_areas.get(dst_area_id).ok_or_else(|| {
                        crate::types::BduError::InvalidArea(format!(
                            "Destination area not found: {}",
                            dst_area_id
                        ))
                    })?;
                    let src_dimensions = (
                        src_area.dimensions.width as usize,
                        src_area.dimensions.height as usize,
                        src_area.dimensions.depth as usize,
                    );
                    let dst_dimensions = (
                        dst_area.dimensions.width as usize,
                        dst_area.dimensions.height as usize,
                        dst_area.dimensions.depth as usize,
                    );

                    let count =
                        crate::connectivity::core_morphologies::apply_tile_morphology_with_dimensions(
                            &mut npu,
                            *src_idx,
                            *dst_idx,
                            src_dimensions,
                            dst_dimensions,
                            weight,
                            psp,
                            synapse_attractivity,
                            synapse_type,
                            delay_bursts,
                        )?;
                    if count > 0 {
                        npu.rebuild_synapse_index();
                    }
                    Ok(count as usize)
                }
            }
        } else {
            Ok(0) // NPU not available
        }
    }

    // ======================================================================
    // NPU Integration
    // ======================================================================

    /// Set the NPU reference for neuron/synapse queries
    ///
    /// This should be called once during FEAGI initialization after the NPU is created.
    ///
    /// # Arguments
    ///
    /// * `npu` - Arc to the Rust NPU (wrapped in TracingMutex for automatic lock tracing)
    ///
    pub fn set_npu(
        &mut self,
        npu: Arc<feagi_npu_burst_engine::TracingMutex<feagi_npu_burst_engine::DynamicNPU>>,
    ) {
        self.npu = Some(Arc::clone(&npu));
        info!(target: "feagi-bdu","🔗 ConnectomeManager: NPU reference set");

        // CRITICAL: Update State Manager with capacity values (from config, never changes)
        // This ensures health check endpoint can read capacity without acquiring NPU lock
        #[cfg(not(feature = "wasm"))]
        {
            use feagi_state_manager::StateManager;
            let state_manager = StateManager::instance();
            let state_manager = state_manager.read();
            let core_state = state_manager.get_core_state();
            // Capacity comes from config (set at initialization, never changes)
            core_state.set_neuron_capacity(self.config.max_neurons as u32);
            core_state.set_synapse_capacity(self.config.max_synapses as u32);
            info!(
                target: "feagi-bdu",
                "📊 Updated State Manager with capacity: {} neurons, {} synapses",
                self.config.max_neurons, self.config.max_synapses
            );
        }

        // CRITICAL: Backfill cortical area registrations into NPU.
        //
        // Cortical areas can be created/loaded before the NPU is attached (startup ordering).
        // Those areas won't be registered via `add_cortical_area()` (it registers only if NPU is present),
        // which causes visualization encoding to fall back to "area_{idx}" and subsequently drop the area
        // (base64 decode fails), making BV appear to "miss" firing activity for that cortical area.
        let existing_area_count = self.cortical_id_to_idx.len();
        if existing_area_count > 0 {
            match npu.lock() {
                Ok(mut npu_lock) => {
                    for (cortical_id, cortical_idx) in self.cortical_id_to_idx.iter() {
                        npu_lock.register_cortical_area(*cortical_idx, cortical_id.as_base_64());
                    }
                    info!(
                        target: "feagi-bdu",
                        "🔁 Backfilled {} cortical area registrations into NPU",
                        existing_area_count
                    );
                }
                Err(e) => {
                    warn!(
                        target: "feagi-bdu",
                        "⚠️ Failed to lock NPU for cortical area backfill registration: {}",
                        e
                    );
                }
            }
        }

        // Initialize cached stats immediately
        self.update_all_cached_stats();
        info!(target: "feagi-bdu","📊 Initialized cached stats: {} neurons, {} synapses",
            self.get_neuron_count(), self.get_synapse_count());
    }

    /// Check if NPU is connected
    pub fn has_npu(&self) -> bool {
        self.npu.is_some()
    }

    /// Get NPU reference (read-only access for queries)
    ///
    /// # Returns
    ///
    /// * `Option<&Arc<Mutex<RustNPU>>>` - Reference to NPU if connected
    ///
    pub fn get_npu(
        &self,
    ) -> Option<&Arc<feagi_npu_burst_engine::TracingMutex<feagi_npu_burst_engine::DynamicNPU>>>
    {
        self.npu.as_ref()
    }

    /// Set the PlasticityExecutor reference (optional, only if plasticity feature enabled)
    /// The executor is passed as Arc<Mutex<dyn Any>> for feature-gating compatibility
    #[cfg(feature = "plasticity")]
    pub fn set_plasticity_executor(
        &mut self,
        executor: Arc<std::sync::Mutex<feagi_npu_plasticity::AsyncPlasticityExecutor>>,
    ) {
        if let Ok(mut exec) = executor.lock() {
            use feagi_npu_plasticity::executor::PlasticityExecutor;
            if !exec.is_running() {
                exec.start();
            }
        } else {
            warn!(target: "feagi-bdu", "⚠️ Failed to lock PlasticityExecutor for startup");
        }
        self.plasticity_executor = Some(executor);
        info!(target: "feagi-bdu", "🔗 ConnectomeManager: PlasticityExecutor reference set");
    }

    /// Get the PlasticityExecutor reference (if plasticity feature enabled)
    #[cfg(feature = "plasticity")]
    pub fn get_plasticity_executor(
        &self,
    ) -> Option<&Arc<std::sync::Mutex<feagi_npu_plasticity::AsyncPlasticityExecutor>>> {
        self.plasticity_executor.as_ref()
    }

    /// Get neuron capacity from config (lock-free, never acquires NPU lock)
    ///
    /// # Returns
    ///
    /// * `usize` - Maximum neuron capacity from config (single source of truth)
    ///
    /// # Performance
    ///
    /// This is a lock-free read from config that never blocks, even during burst processing.
    /// Capacity values are set at NPU initialization and never change.
    ///
    pub fn get_neuron_capacity(&self) -> usize {
        // CRITICAL: Read from config, NOT NPU - capacity never changes and should not acquire locks
        self.config.max_neurons
    }

    /// Get synapse capacity from config (lock-free, never acquires NPU lock)
    ///
    /// # Returns
    ///
    /// * `usize` - Maximum synapse capacity from config (single source of truth)
    ///
    /// # Performance
    ///
    /// This is a lock-free read from config that never blocks, even during burst processing.
    /// Capacity values are set at NPU initialization and never change.
    ///
    pub fn get_synapse_capacity(&self) -> usize {
        // CRITICAL: Read from config, NOT NPU - capacity never changes and should not acquire locks
        self.config.max_synapses
    }

    /// Update fatigue index based on utilization of neuron and synapse arrays
    ///
    /// Calculates fatigue index as max(regular_neuron_util%, memory_neuron_util%, synapse_util%)
    /// Applies hysteresis: triggers at 85%, clears at 80%
    /// Rate limited to max once per 2 seconds to protect against rapid changes
    ///
    /// # Safety
    ///
    /// This method is completely non-blocking and safe to call during genome loading.
    /// If StateManager is unavailable or locked, it will skip the calculation gracefully.
    ///
    /// # Returns
    ///
    /// * `Option<u8>` - New fatigue index (0-100) if calculation was performed, None if rate limited or StateManager unavailable
    pub fn update_fatigue_index(&self) -> Option<u8> {
        // Rate limiting: max once per 2 seconds
        let mut last_calc = match self.last_fatigue_calculation.lock() {
            Ok(guard) => guard,
            Err(_) => return None, // Lock poisoned, skip calculation
        };

        let now = std::time::Instant::now();
        if now.duration_since(*last_calc).as_secs() < 2 {
            return None; // Rate limited
        }
        *last_calc = now;
        drop(last_calc);

        // Get regular neuron utilization
        let regular_neuron_count = self.get_neuron_count();
        let regular_neuron_capacity = self.get_neuron_capacity();
        let regular_neuron_util = if regular_neuron_capacity > 0 {
            ((regular_neuron_count as f64 / regular_neuron_capacity as f64) * 100.0).round() as u8
        } else {
            0
        };

        // Get memory neuron utilization from state manager
        // Use try_read() to avoid blocking during neurogenesis
        // If StateManager singleton initialization fails or is locked, skip calculation entirely
        let memory_neuron_util = match StateManager::instance().try_read() {
            Some(state_manager) => state_manager.get_core_state().get_memory_neuron_util(),
            None => {
                // StateManager is locked or not ready - skip fatigue calculation
                return None;
            }
        };

        // Get synapse utilization
        let synapse_count = self.get_synapse_count();
        let synapse_capacity = self.get_synapse_capacity();
        let synapse_util = if synapse_capacity > 0 {
            ((synapse_count as f64 / synapse_capacity as f64) * 100.0).round() as u8
        } else {
            0
        };

        // Calculate fatigue index as max of all utilizations
        let fatigue_index = regular_neuron_util
            .max(memory_neuron_util)
            .max(synapse_util);

        // Apply hysteresis: trigger at 85%, clear at 80%
        let current_fatigue_active = {
            // Try to read current state - if unavailable, assume false
            StateManager::instance()
                .try_read()
                .map(|m| m.get_core_state().is_fatigue_active())
                .unwrap_or(false)
        };

        let new_fatigue_active = if fatigue_index >= 85 {
            true
        } else if fatigue_index < 80 {
            false
        } else {
            current_fatigue_active // Keep current state in hysteresis zone
        };

        // Update state manager with all values
        // Use try_write() to avoid blocking during neurogenesis
        // If StateManager is unavailable, skip update (non-blocking)
        if let Some(state_manager) = StateManager::instance().try_write() {
            let core_state = state_manager.get_core_state();
            core_state.set_fatigue_index(fatigue_index);
            core_state.set_fatigue_active(new_fatigue_active);
            core_state.set_regular_neuron_util(regular_neuron_util);
            core_state.set_memory_neuron_util(memory_neuron_util);
            core_state.set_synapse_util(synapse_util);
        } else {
            // StateManager is locked or not ready - skip update (non-blocking)
            trace!(target: "feagi-bdu", "[FATIGUE] StateManager unavailable, skipping update");
        }

        // Update NPU's atomic boolean
        if let Some(ref npu) = self.npu {
            if let Ok(mut npu_lock) = npu.lock() {
                npu_lock.set_fatigue_active(new_fatigue_active);
            }
        }

        trace!(
            target: "feagi-bdu",
            "[FATIGUE] Index={}, Active={}, Regular={}%, Memory={}%, Synapse={}%",
            fatigue_index, new_fatigue_active, regular_neuron_util, memory_neuron_util, synapse_util
        );

        Some(fatigue_index)
    }

    // ======================================================================
    // Neuron/Synapse Creation Methods (Delegates to NPU)
    // ======================================================================

    /// Create neurons for a cortical area
    ///
    /// This delegates to the NPU's optimized batch creation function.
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Cortical area ID (6-character string)
    ///
    /// # Returns
    ///
    /// Number of neurons created
    ///
    pub fn create_neurons_for_area(&mut self, cortical_id: &CorticalID) -> BduResult<u32> {
        // Get cortical area
        let area = self
            .cortical_areas
            .get(cortical_id)
            .ok_or_else(|| {
                BduError::InvalidArea(format!("Cortical area {} not found", cortical_id))
            })?
            .clone();

        // Get cortical index
        let cortical_idx = self.cortical_id_to_idx.get(cortical_id).ok_or_else(|| {
            BduError::InvalidArea(format!("No index for cortical area {}", cortical_id))
        })?;

        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        // Extract neural parameters from area properties using CorticalAreaExt trait
        // This ensures consistent defaults across the codebase
        use crate::models::CorticalAreaExt;
        let per_voxel_cnt = area.neurons_per_voxel();
        let firing_threshold = area.firing_threshold();
        let firing_threshold_increment_x = area.firing_threshold_increment_x();
        let firing_threshold_increment_y = area.firing_threshold_increment_y();
        let firing_threshold_increment_z = area.firing_threshold_increment_z();
        // SIMD-friendly encoding: 0.0 means no limit, convert to MAX
        let firing_threshold_limit_raw = area.firing_threshold_limit();
        let firing_threshold_limit = if firing_threshold_limit_raw == 0.0 {
            f32::MAX // SIMD-friendly encoding: MAX = no limit
        } else {
            firing_threshold_limit_raw
        };

        // DEBUG: Log the increment values
        if firing_threshold_increment_x != 0.0
            || firing_threshold_increment_y != 0.0
            || firing_threshold_increment_z != 0.0
        {
            info!(
                target: "feagi-bdu",
                "🔍 [DEBUG] Area {}: firing_threshold_increment = [{}, {}, {}]",
                cortical_id.as_base_64(),
                firing_threshold_increment_x,
                firing_threshold_increment_y,
                firing_threshold_increment_z
            );
        } else {
            // Check if properties exist but are just 0
            if area.properties.contains_key("firing_threshold_increment_x")
                || area.properties.contains_key("firing_threshold_increment_y")
                || area.properties.contains_key("firing_threshold_increment_z")
            {
                info!(
                    target: "feagi-bdu",
                    "🔍 [DEBUG] Area {}: INCREMENT PROPERTIES FOUND: x={:?}, y={:?}, z={:?}",
                    cortical_id.as_base_64(),
                    area.properties.get("firing_threshold_increment_x"),
                    area.properties.get("firing_threshold_increment_y"),
                    area.properties.get("firing_threshold_increment_z")
                );
            }
        }

        let leak_coefficient = area.leak_coefficient();
        let excitability = area.neuron_excitability();
        let refractory_period = area.refractory_period();
        // SIMD-friendly encoding: 0 means no limit, convert to MAX
        let consecutive_fire_limit_raw = area.consecutive_fire_count() as u16;
        let consecutive_fire_limit = if consecutive_fire_limit_raw == 0 {
            u16::MAX // SIMD-friendly encoding: MAX = no limit
        } else {
            consecutive_fire_limit_raw
        };
        let snooze_length = area.snooze_period();
        let mp_charge_accumulation = area.mp_charge_accumulation();

        // Calculate expected neuron count for logging
        let voxels = area.dimensions.width as usize
            * area.dimensions.height as usize
            * area.dimensions.depth as usize;
        let expected_neurons = voxels * per_voxel_cnt as usize;

        trace!(
            target: "feagi-bdu",
            "Creating neurons for area {}: {}x{}x{} voxels × {} neurons/voxel = {} total neurons",
            cortical_id.as_base_64(),
            area.dimensions.width,
            area.dimensions.height,
            area.dimensions.depth,
            per_voxel_cnt,
            expected_neurons
        );

        // Call NPU to create neurons
        // NOTE: Cortical area should already be registered in NPU during corticogenesis
        // Scope the lock so it is released before the rate_modulated_leak block below, which
        // must take the same NPU mutex again (second lock while npu_lock lived = deadlock).
        let neuron_count: u32 = {
            let mut npu_lock = npu
                .lock()
                .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;
            npu_lock
                .create_cortical_area_neurons(
                    *cortical_idx,
                    area.dimensions.width,
                    area.dimensions.height,
                    area.dimensions.depth,
                    per_voxel_cnt,
                    firing_threshold,
                    firing_threshold_increment_x,
                    firing_threshold_increment_y,
                    firing_threshold_increment_z,
                    firing_threshold_limit,
                    leak_coefficient,
                    0.0, // resting_potential (LIF default)
                    0,   // neuron_type (excitatory)
                    refractory_period,
                    excitability,
                    consecutive_fire_limit,
                    snooze_length,
                    mp_charge_accumulation,
                )
                .map_err(|e| BduError::Internal(format!("NPU neuron creation failed: {}", e)))?
        };

        trace!(
            target: "feagi-bdu",
            "Created {} neurons for area {} via NPU",
            neuron_count,
            cortical_id.as_base_64()
        );

        // CRITICAL: Update per-area neuron count cache (lock-free for readers)
        // This allows healthcheck endpoints to read counts without NPU lock
        {
            let mut cache = self.cached_neuron_counts_per_area.write();
            cache
                .entry(*cortical_id)
                .or_insert_with(|| AtomicUsize::new(0))
                .store(neuron_count as usize, Ordering::Relaxed);
        }

        // @cursor:critical-path - Keep BV-facing stats in StateManager.
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        state_manager
            .set_cortical_area_neuron_count(&cortical_id.as_base_64(), neuron_count as usize);

        // Update total neuron count cache
        self.cached_neuron_count
            .fetch_add(neuron_count as usize, Ordering::Relaxed);

        // CRITICAL: Update StateManager neuron count (for health_check endpoint)
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        let core_state = state_manager.get_core_state();
        core_state.add_neuron_count(neuron_count);
        core_state.add_regular_neuron_count(neuron_count);

        // Opt-in homeostatic leak: register on NPU (cold pass only when enabled; see `neural/docs/rate_modulated_leak.md`).
        if let Some(npu) = &self.npu {
            if let Ok(mut npl) = npu.lock() {
                if let Some(v) = area.properties.get("rate_modulated_leak") {
                    use crate::models::CorticalAreaExt;
                    let idxs: Vec<usize> = npl
                        .get_neurons_in_cortical_area(*cortical_idx)
                        .into_iter()
                        .map(|id| id as usize)
                        .collect();
                    npl.sync_rate_modulated_leak_from_cortical_property(
                        *cortical_idx,
                        v,
                        area.leak_coefficient(),
                        idxs,
                    );
                } else {
                    npl.remove_rate_modulated_leak(*cortical_idx);
                }
            }
        }

        // Trigger fatigue index recalculation after neuron creation
        // NOTE: Disabled during genome loading to prevent blocking
        // Fatigue calculation will be enabled after genome loading completes
        // if neuron_count > 0 {
        //     let _ = self.update_fatigue_index();
        // }

        Ok(neuron_count)
    }

    /// Add a single neuron to a cortical area
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Cortical area ID
    /// * `x` - X coordinate
    /// * `y` - Y coordinate
    /// * `z` - Z coordinate
    /// * `firing_threshold` - Firing threshold (minimum MP to fire)
    /// * `firing_threshold_limit` - Firing threshold limit (maximum MP to fire, 0 = no limit)
    /// * `leak_coefficient` - Leak coefficient
    /// * `resting_potential` - Resting membrane potential
    /// * `neuron_type` - Neuron type (0=excitatory, 1=inhibitory)
    /// * `refractory_period` - Refractory period
    /// * `excitability` - Excitability multiplier
    /// * `consecutive_fire_limit` - Maximum consecutive fires
    /// * `snooze_length` - Snooze duration after consecutive fire limit
    /// * `mp_charge_accumulation` - Whether membrane potential accumulates
    ///
    /// # Returns
    ///
    /// The newly created neuron ID
    ///
    #[allow(clippy::too_many_arguments)]
    pub fn add_neuron(
        &mut self,
        cortical_id: &CorticalID,
        x: u32,
        y: u32,
        z: u32,
        firing_threshold: f32,
        firing_threshold_limit: f32,
        leak_coefficient: f32,
        resting_potential: f32,
        neuron_type: u8,
        refractory_period: u16,
        excitability: f32,
        consecutive_fire_limit: u16,
        snooze_length: u16,
        mp_charge_accumulation: bool,
    ) -> BduResult<u64> {
        // Validate cortical area exists
        if !self.cortical_areas.contains_key(cortical_id) {
            return Err(BduError::InvalidArea(format!(
                "Cortical area {} not found",
                cortical_id
            )));
        }

        let cortical_idx = *self
            .cortical_id_to_idx
            .get(cortical_id)
            .ok_or_else(|| BduError::InvalidArea(format!("No index for {}", cortical_id)))?;

        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        // Add neuron via NPU
        let neuron_id = npu_lock
            .add_neuron(
                firing_threshold,
                firing_threshold_limit,
                leak_coefficient,
                resting_potential,
                neuron_type as i32,
                refractory_period,
                excitability,
                consecutive_fire_limit,
                snooze_length,
                mp_charge_accumulation,
                cortical_idx,
                x,
                y,
                z,
            )
            .map_err(|e| BduError::Internal(format!("Failed to add neuron: {}", e)))?;

        trace!(
            target: "feagi-bdu",
            "Created neuron {} in area {} at ({}, {}, {})",
            neuron_id.0,
            cortical_id,
            x,
            y,
            z
        );

        // CRITICAL: Update StateManager neuron count (for health_check endpoint)
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        let core_state = state_manager.get_core_state();
        core_state.add_neuron_count(1);
        core_state.add_regular_neuron_count(1);
        state_manager.add_cortical_area_neuron_count(&cortical_id.as_base_64(), 1);

        Ok(neuron_id.0 as u64)
    }

    /// Delete a neuron by ID
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Global neuron ID
    ///
    /// # Returns
    ///
    /// `true` if the neuron was deleted, `false` if it didn't exist
    ///
    pub fn delete_neuron(&mut self, neuron_id: u64) -> BduResult<bool> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        let cortical_idx = npu_lock.get_neuron_cortical_area(neuron_id as u32);
        let cortical_id = cortical_idx.and_then(|idx| self.cortical_idx_to_id.get(&idx).cloned());

        let deleted = npu_lock.delete_neuron(neuron_id as u32);

        if deleted {
            trace!(target: "feagi-bdu", "Deleted neuron {}", neuron_id);

            // CRITICAL: Update StateManager neuron count (for health_check endpoint)
            let state_manager = StateManager::instance();
            let state_manager = state_manager.read();
            let core_state = state_manager.get_core_state();
            core_state.subtract_neuron_count(1);
            core_state.subtract_regular_neuron_count(1);
            if let Some(cortical_id) = cortical_id {
                state_manager.subtract_cortical_area_neuron_count(&cortical_id.as_base_64(), 1);
            }

            // Trigger fatigue index recalculation after neuron deletion
            // NOTE: Disabled during genome loading to prevent blocking
            // let _ = self.update_fatigue_index();
        }

        Ok(deleted)
    }

    /// Apply cortical mapping rules (dstmap) to create synapses
    ///
    /// This parses the destination mapping rules from a source area and
    /// creates synapses using the NPU's synaptogenesis functions.
    ///
    /// # Arguments
    ///
    /// * `src_cortical_id` - Source cortical area ID
    ///
    /// # Returns
    ///
    /// Number of synapses created
    ///
    pub fn apply_cortical_mapping(&mut self, src_cortical_id: &CorticalID) -> BduResult<u32> {
        // Get source area
        let src_area = self
            .cortical_areas
            .get(src_cortical_id)
            .ok_or_else(|| {
                BduError::InvalidArea(format!("Source area {} not found", src_cortical_id))
            })?
            .clone();

        // Get dstmap from area properties
        let dstmap = match src_area.properties.get("cortical_mapping_dst") {
            Some(serde_json::Value::Object(map)) if !map.is_empty() => map,
            _ => return Ok(0), // No mappings
        };

        let src_cortical_idx = *self
            .cortical_id_to_idx
            .get(src_cortical_id)
            .ok_or_else(|| BduError::InvalidArea(format!("No index for {}", src_cortical_id)))?;

        let mut total_synapses = 0u32;
        let mut upstream_updates: Vec<(CorticalID, u32)> = Vec::new(); // Collect updates to apply later

        // Process each destination area using the unified path
        for (dst_cortical_id_str, _rules) in dstmap {
            // Convert string to CorticalID
            let dst_cortical_id = match CorticalID::try_from_base_64(dst_cortical_id_str) {
                Ok(id) => id,
                Err(_) => {
                    warn!(target: "feagi-bdu","Invalid cortical ID format: {}, skipping", dst_cortical_id_str);
                    continue;
                }
            };

            // Verify destination area exists
            if !self.cortical_id_to_idx.contains_key(&dst_cortical_id) {
                warn!(target: "feagi-bdu","Destination area {} not found, skipping", dst_cortical_id);
                continue;
            }

            // Apply cortical mapping for this pair (handles STDP and all morphology rules)
            let synapse_count =
                self.apply_cortical_mapping_for_pair(src_cortical_id, &dst_cortical_id)?;
            total_synapses += synapse_count as u32;

            // Queue upstream area update for ANY mapping (even if no synapses created)
            // This is critical for memory areas which have mappings but no physical synapses
            upstream_updates.push((dst_cortical_id, src_cortical_idx));
        }

        // Apply all upstream area updates now that NPU borrows are complete
        for (dst_id, src_idx) in upstream_updates {
            self.add_upstream_area(&dst_id, src_idx);
        }

        trace!(
            target: "feagi-bdu",
            "Created {} synapses for area {} via NPU",
            total_synapses,
            src_cortical_id
        );

        // CRITICAL: Update per-area synapse count cache (lock-free for readers)
        // This allows healthcheck endpoints to read counts without NPU lock
        if total_synapses > 0 {
            let mut cache = self.cached_synapse_counts_per_area.write();
            cache
                .entry(*src_cortical_id)
                .or_insert_with(|| AtomicUsize::new(0))
                .fetch_add(total_synapses as usize, Ordering::Relaxed);
        }

        // Update total synapse count cache
        self.cached_synapse_count
            .fetch_add(total_synapses as usize, Ordering::Relaxed);

        // CRITICAL: Update StateManager synapse count (for health_check endpoint)
        if total_synapses > 0 {
            let state_manager = StateManager::instance();
            let state_manager = state_manager.read();
            let core_state = state_manager.get_core_state();
            core_state.add_synapse_count(total_synapses);
        }

        Ok(total_synapses)
    }

    // ======================================================================
    // Neuron Query Methods (Delegates to NPU)
    // ======================================================================

    /// Check if a neuron exists
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - The neuron ID to check
    ///
    /// # Returns
    ///
    /// `true` if the neuron exists in the NPU, `false` otherwise
    ///
    /// # Note
    ///
    /// Returns `false` if NPU is not connected
    ///
    pub fn has_neuron(&self, neuron_id: u64) -> bool {
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.lock() {
                // Check if neuron exists AND is valid (not deleted)
                npu_lock.is_neuron_valid(neuron_id as u32)
            } else {
                false
            }
        } else {
            false
        }
    }

    /// Get total number of active neurons (lock-free cached read with opportunistic update)
    ///
    /// # Returns
    ///
    /// The total number of neurons (from cache)
    ///
    /// # Performance
    ///
    /// This is a lock-free atomic read that never blocks, even during burst processing.
    /// Opportunistically updates cache if NPU is available (non-blocking try_lock).
    ///
    pub fn get_neuron_count(&self) -> usize {
        // Opportunistically update cache if NPU is available (non-blocking)
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.try_lock() {
                let fresh_count = npu_lock.get_neuron_count();
                self.cached_neuron_count
                    .store(fresh_count, Ordering::Relaxed);
            }
            // If NPU is busy, just use cached value
        }

        // Always return cached value (never blocks)
        self.cached_neuron_count.load(Ordering::Relaxed)
    }

    /// Update the cached neuron count (explicit update)
    ///
    /// Use this if you want to force a cache update. Most callers should just
    /// use get_neuron_count() which updates opportunistically.
    ///
    pub fn update_cached_neuron_count(&self) {
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.try_lock() {
                let count = npu_lock.get_neuron_count();
                self.cached_neuron_count.store(count, Ordering::Relaxed);
            }
        }
    }

    /// Refresh cached neuron count for a single cortical area from the NPU.
    ///
    /// Returns the refreshed count if successful.
    pub fn refresh_neuron_count_for_area(&self, cortical_id: &CorticalID) -> Option<usize> {
        let npu = self.npu.as_ref()?;
        let cortical_idx = *self.cortical_id_to_idx.get(cortical_id)?;
        let npu_lock = npu.lock().ok()?;
        let count = npu_lock.get_neurons_in_cortical_area(cortical_idx).len();
        drop(npu_lock);

        let mut cache = self.cached_neuron_counts_per_area.write();
        cache
            .entry(*cortical_id)
            .or_insert_with(|| AtomicUsize::new(0))
            .store(count, Ordering::Relaxed);

        // @cursor:critical-path - Keep BV-facing stats in StateManager.
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        state_manager.set_cortical_area_neuron_count(&cortical_id.as_base_64(), count);

        self.update_cached_neuron_count();

        Some(count)
    }

    /// Get total number of synapses (lock-free cached read with opportunistic update)
    ///
    /// # Returns
    ///
    /// The total number of synapses (from cache)
    ///
    /// # Performance
    ///
    /// This is a lock-free atomic read that never blocks, even during burst processing.
    /// Opportunistically updates cache if NPU is available (non-blocking try_lock).
    ///
    pub fn get_synapse_count(&self) -> usize {
        // Opportunistically update cache if NPU is available (non-blocking)
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.try_lock() {
                let fresh_count = npu_lock.get_synapse_count();
                self.cached_synapse_count
                    .store(fresh_count, Ordering::Relaxed);
            }
            // If NPU is busy, just use cached value
        }

        // Always return cached value (never blocks)
        self.cached_synapse_count.load(Ordering::Relaxed)
    }

    /// Update the cached synapse count (explicit update)
    ///
    /// Use this if you want to force a cache update. Most callers should just
    /// use get_synapse_count() which updates opportunistically.
    ///
    pub fn update_cached_synapse_count(&self) {
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.try_lock() {
                let count = npu_lock.get_synapse_count();
                self.cached_synapse_count.store(count, Ordering::Relaxed);
            }
        }
    }

    /// Update all cached stats (neuron and synapse counts)
    ///
    /// This is called automatically when NPU is connected and can be called
    /// explicitly if you want to force a cache refresh.
    ///
    pub fn update_all_cached_stats(&self) {
        self.update_cached_neuron_count();
        self.update_cached_synapse_count();
    }

    /// Get neuron coordinates (x, y, z)
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - The neuron ID to query
    ///
    /// # Returns
    ///
    /// Coordinates as (x, y, z), or (0, 0, 0) if neuron doesn't exist or NPU not connected
    ///
    pub fn get_neuron_coordinates(&self, neuron_id: u64) -> (u32, u32, u32) {
        // Memory neurons live in the plasticity MemoryNeuronArray, not the NPU dense neuron array.
        // Do not take the NPU mutex here: synapse inspector paths (`peer_cortical_voxel_fields`)
        // resolve cortical idx via the plasticity lock first, then coordinates. The burst thread
        // holds NPU while notifying plasticity — taking NPU after plasticity would deadlock.
        #[cfg(feature = "plasticity")]
        {
            if feagi_npu_plasticity::NeuronIdManager::is_memory_neuron_id(neuron_id as u32) {
                return (0, 0, 0);
            }
        }
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.lock() {
                npu_lock
                    .get_neuron_coordinates(neuron_id as u32)
                    .unwrap_or((0, 0, 0))
            } else {
                (0, 0, 0)
            }
        } else {
            (0, 0, 0)
        }
    }

    /// Get the cortical area index for a neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - The neuron ID to query
    ///
    /// # Returns
    ///
    /// Cortical area index, or 0 if neuron doesn't exist or NPU not connected
    ///
    pub fn get_neuron_cortical_idx(&self, neuron_id: u64) -> u32 {
        self.get_neuron_cortical_idx_opt(neuron_id).unwrap_or(0)
    }

    /// Cortical area index for a neuron, or `None` if the neuron slot is invalid / NPU unavailable.
    ///
    /// Memory neurons (global ids in `50_000_000..=99_999_999`) are not stored in the dense
    /// [`NeuronArray`] index space; their cortical membership is resolved via the plasticity
    /// [`MemoryNeuronArray`] when the plasticity feature is enabled.
    pub fn get_neuron_cortical_idx_opt(&self, neuron_id: u64) -> Option<u32> {
        #[cfg(feature = "plasticity")]
        {
            if feagi_npu_plasticity::NeuronIdManager::is_memory_neuron_id(neuron_id as u32) {
                return self.memory_neuron_cortical_idx_opt(neuron_id as u32);
            }
        }
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.lock() {
                npu_lock.get_neuron_cortical_area(neuron_id as u32)
            } else {
                None
            }
        } else {
            None
        }
    }

    /// Resolve cortical index for a memory-neuron global id through the plasticity executor.
    #[cfg(feature = "plasticity")]
    fn memory_neuron_cortical_idx_opt(&self, neuron_id: u32) -> Option<u32> {
        let exec = self.get_plasticity_executor()?;
        let guard = exec.lock().ok()?;
        guard
            .memory_neuron_detail(neuron_id)
            .map(|d| d.cortical_area_idx)
    }

    /// Get all neuron IDs in a specific cortical area
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID (string)
    ///
    /// # Returns
    ///
    /// Vec of neuron IDs in the area, or empty vec if area doesn't exist or NPU not connected
    ///
    pub fn get_neurons_in_area(&self, cortical_id: &CorticalID) -> Vec<u64> {
        // Get cortical_idx from cortical_id
        let cortical_idx = match self.cortical_id_to_idx.get(cortical_id) {
            Some(idx) => *idx,
            None => return Vec::new(),
        };

        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.lock() {
                // Convert Vec<u32> to Vec<u64>
                npu_lock
                    .get_neurons_in_cortical_area(cortical_idx)
                    .into_iter()
                    .map(|id| id as u64)
                    .collect()
            } else {
                Vec::new()
            }
        } else {
            Vec::new()
        }
    }

    /// Get all outgoing synapses from a source neuron
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - The source neuron ID
    ///
    /// # Returns
    ///
    /// Vec of (target_neuron_id, weight, psp, synapse_type), or empty if NPU not connected
    ///
    pub fn get_outgoing_synapses(&self, source_neuron_id: u64) -> Vec<(u32, f32, f32, u8)> {
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.lock() {
                npu_lock.get_outgoing_synapses(source_neuron_id as u32)
            } else {
                Vec::new()
            }
        } else {
            Vec::new()
        }
    }

    /// Get all incoming synapses to a target neuron
    ///
    /// # Arguments
    ///
    /// * `target_neuron_id` - The target neuron ID
    ///
    /// # Returns
    ///
    /// Vec of (source_neuron_id, weight, psp, synapse_type), or empty if NPU not connected
    ///
    pub fn get_incoming_synapses(&self, target_neuron_id: u64) -> Vec<(u32, f32, f32, u8)> {
        if let Some(ref npu) = self.npu {
            if let Ok(npu_lock) = npu.lock() {
                npu_lock.get_incoming_synapses(target_neuron_id as u32)
            } else {
                Vec::new()
            }
        } else {
            Vec::new()
        }
    }

    /// Get neuron count for a specific cortical area
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID (string)
    ///
    /// # Returns
    ///
    /// Number of neurons in the area, or 0 if area doesn't exist or NPU not connected
    ///
    /// Get neuron count for a specific cortical area (lock-free cached read)
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// The number of neurons in the area (from cache, never blocks on NPU lock)
    ///
    /// # Performance
    ///
    /// This is a lock-free atomic read that never blocks, even during burst processing.
    /// Count is maintained in ConnectomeManager and updated when neurons are created/deleted.
    ///
    pub fn get_neuron_count_in_area(&self, cortical_id: &CorticalID) -> usize {
        // CRITICAL: Read from cache (lock-free) - never query NPU for healthcheck endpoints
        let cache = self.cached_neuron_counts_per_area.read();
        let base_count = cache
            .get(cortical_id)
            .map(|count| count.load(Ordering::Relaxed))
            .unwrap_or(0);

        // Memory areas maintain neurons outside the NPU; add their count from StateManager.
        let memory_count = self
            .cortical_areas
            .get(cortical_id)
            .and_then(|area| feagi_evolutionary::extract_memory_properties(&area.properties))
            .and_then(|_| {
                StateManager::instance()
                    .try_read()
                    .and_then(|state_manager| {
                        state_manager.get_cortical_area_stats(&cortical_id.as_base_64())
                    })
            })
            .map(|stats| stats.neuron_count)
            .unwrap_or(0);

        base_count.saturating_add(memory_count)
    }

    /// Get all cortical areas that have neurons
    ///
    /// # Returns
    ///
    /// Vec of (cortical_id, neuron_count) for areas with at least one neuron
    ///
    pub fn get_populated_areas(&self) -> Vec<(String, usize)> {
        let mut result = Vec::new();

        for cortical_id in self.cortical_areas.keys() {
            let count = self.get_neuron_count_in_area(cortical_id);
            if count > 0 {
                result.push((cortical_id.to_string(), count));
            }
        }

        result
    }

    /// Check if a cortical area has any neurons
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// `true` if the area has at least one neuron, `false` otherwise
    ///
    pub fn is_area_populated(&self, cortical_id: &CorticalID) -> bool {
        self.get_neuron_count_in_area(cortical_id) > 0
    }

    /// Get total synapse count for a specific cortical area (outgoing only) - lock-free cached read
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// Total number of outgoing synapses from neurons in this area (from cache, never blocks on NPU lock)
    ///
    /// # Performance
    ///
    /// This is a lock-free atomic read that never blocks, even during burst processing.
    /// Count is maintained in ConnectomeManager and updated when synapses are created/deleted.
    ///
    pub fn get_synapse_count_in_area(&self, cortical_id: &CorticalID) -> usize {
        // CRITICAL: Read from cache (lock-free) - never query NPU for healthcheck endpoints
        let cache = self.cached_synapse_counts_per_area.read();
        cache
            .get(cortical_id)
            .map(|count| count.load(Ordering::Relaxed))
            .unwrap_or(0)
    }

    /// Get total incoming synapse count for a specific cortical area.
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// Total number of incoming synapses targeting neurons in this area.
    pub fn get_incoming_synapse_count_in_area(&self, cortical_id: &CorticalID) -> usize {
        if !self.cortical_id_to_idx.contains_key(cortical_id) {
            return 0;
        }

        if let Some(state_manager) = StateManager::instance().try_read() {
            if let Some(stats) = state_manager.get_cortical_area_stats(&cortical_id.as_base_64()) {
                return stats.incoming_synapse_count;
            }
        }

        0
    }

    /// Get total outgoing synapse count for a specific cortical area.
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// Total number of outgoing synapses originating from neurons in this area.
    pub fn get_outgoing_synapse_count_in_area(&self, cortical_id: &CorticalID) -> usize {
        if !self.cortical_id_to_idx.contains_key(cortical_id) {
            return 0;
        }

        if let Some(state_manager) = StateManager::instance().try_read() {
            if let Some(stats) = state_manager.get_cortical_area_stats(&cortical_id.as_base_64()) {
                return stats.outgoing_synapse_count;
            }
        }

        0
    }

    /// Check if two neurons are connected (source → target)
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - The source neuron ID
    /// * `target_neuron_id` - The target neuron ID
    ///
    /// # Returns
    ///
    /// `true` if there is a synapse from source to target, `false` otherwise
    ///
    pub fn are_neurons_connected(&self, source_neuron_id: u64, target_neuron_id: u64) -> bool {
        let synapses = self.get_outgoing_synapses(source_neuron_id);
        synapses
            .iter()
            .any(|(target, _, _, _)| *target == target_neuron_id as u32)
    }

    /// Get connection strength (weight) between two neurons
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - The source neuron ID
    /// * `target_neuron_id` - The target neuron ID
    ///
    /// # Returns
    ///
    /// Synapse weight (`f32`), or None if no connection exists
    ///
    pub fn get_connection_weight(
        &self,
        source_neuron_id: u64,
        target_neuron_id: u64,
    ) -> Option<f32> {
        let synapses = self.get_outgoing_synapses(source_neuron_id);
        synapses
            .iter()
            .find(|(target, _, _, _)| *target == target_neuron_id as u32)
            .map(|(_, weight, _, _)| *weight)
    }

    /// Get connectivity statistics for a cortical area
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// (neuron_count, total_synapses, avg_synapses_per_neuron)
    ///
    pub fn get_area_connectivity_stats(&self, cortical_id: &CorticalID) -> (usize, usize, f32) {
        let neurons = self.get_neurons_in_area(cortical_id);
        let neuron_count = neurons.len();

        if neuron_count == 0 {
            return (0, 0, 0.0);
        }

        let mut total_synapses = 0;
        for neuron_id in neurons {
            total_synapses += self.get_outgoing_synapses(neuron_id).len();
        }

        let avg_synapses = total_synapses as f32 / neuron_count as f32;

        (neuron_count, total_synapses, avg_synapses)
    }

    /// Get the cortical area ID (string) for a neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - The neuron ID
    ///
    /// # Returns
    ///
    /// The cortical area ID, or None if neuron doesn't exist
    ///
    pub fn get_neuron_cortical_id(&self, neuron_id: u64) -> Option<CorticalID> {
        let cortical_idx = self.get_neuron_cortical_idx_opt(neuron_id)?;
        self.cortical_idx_to_id.get(&cortical_idx).copied()
    }

    /// Get neuron density (neurons per voxel) for a cortical area
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - The cortical area ID
    ///
    /// # Returns
    ///
    /// Neuron density (neurons per voxel), or 0.0 if area doesn't exist
    ///
    pub fn get_neuron_density(&self, cortical_id: &CorticalID) -> f32 {
        let area = match self.cortical_areas.get(cortical_id) {
            Some(a) => a,
            None => return 0.0,
        };

        let neuron_count = self.get_neuron_count_in_area(cortical_id);
        let volume = area.dimensions.width * area.dimensions.height * area.dimensions.depth;

        if volume == 0 {
            return 0.0;
        }

        neuron_count as f32 / volume as f32
    }

    /// Get all cortical areas with connectivity statistics
    ///
    /// # Returns
    ///
    /// Vec of (cortical_id, neuron_count, synapse_count, density)
    ///
    pub fn get_all_area_stats(&self) -> Vec<(String, usize, usize, f32)> {
        let mut stats = Vec::new();

        for cortical_id in self.cortical_areas.keys() {
            let neuron_count = self.get_neuron_count_in_area(cortical_id);
            let synapse_count = self.get_synapse_count_in_area(cortical_id);
            let density = self.get_neuron_density(cortical_id);

            stats.push((
                cortical_id.to_string(),
                neuron_count,
                synapse_count,
                density,
            ));
        }

        stats
    }

    // ======================================================================
    // Configuration
    // ======================================================================

    /// Get the configuration
    pub fn get_config(&self) -> &ConnectomeConfig {
        &self.config
    }

    /// Update configuration
    pub fn set_config(&mut self, config: ConnectomeConfig) {
        self.config = config;
    }

    // ======================================================================
    // Genome I/O
    // ======================================================================

    /// Ensure core cortical areas (_death, _power, _fatigue, _pain, _pleasure, _fear, _hope) exist
    ///
    /// Core areas are required for brain operation:
    /// - `_death` (cortical_idx=0): Manages neuron death and cleanup
    /// - `_power` (cortical_idx=1): Provides power injection for burst engine
    /// - `_fatigue` (cortical_idx=2): Monitors brain fatigue and triggers sleep mode
    /// - `_pain` (cortical_idx=3): Pain signal processing
    /// - `_pleasure` (cortical_idx=4): Pleasure signal processing
    /// - `_fear` (cortical_idx=5): Fear signal processing
    /// - `_hope` (cortical_idx=6): Hope signal processing
    ///
    /// If any core area is missing from the genome, it will be automatically created
    /// with default properties (1x1x1 dimensions, minimal configuration).
    ///
    /// # Returns
    ///
    /// * `Ok(())` if all core areas exist or were successfully created
    /// * `Err(BduError)` if creation fails
    pub fn ensure_core_cortical_areas(&mut self) -> BduResult<()> {
        info!(target: "feagi-bdu", "🔧 [CORE-AREA] Ensuring core cortical areas exist...");

        use feagi_structures::genomic::cortical_area::{
            CoreCorticalType, CorticalArea, CorticalAreaDimensions, CorticalAreaType,
        };

        // Core areas are always 1x1x1 as per requirements
        let core_dimensions = CorticalAreaDimensions::new(1, 1, 1).map_err(|e| {
            BduError::Internal(format!("Failed to create core area dimensions: {}", e))
        })?;

        // Default position for core areas (origin)
        let core_position = (0, 0, 0).into();

        // Check and create _death (cortical_idx=0)
        let death_id = CoreCorticalType::Death.to_cortical_id();
        if !self.cortical_areas.contains_key(&death_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _death area (cortical_idx=0)");
            let death_area = CorticalArea::new(
                death_id,
                0, // Will be overridden by add_cortical_area to 0
                "_death".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Death),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _death area: {}", e)))?;
            match self.add_cortical_area(death_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _death area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _death area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _death area already exists");
        }

        // Check and create _power (cortical_idx=1)
        let power_id = CoreCorticalType::Power.to_cortical_id();
        if !self.cortical_areas.contains_key(&power_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _power area (cortical_idx=1)");
            let power_area = CorticalArea::new(
                power_id,
                1, // Will be overridden by add_cortical_area to 1
                "_power".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Power),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _power area: {}", e)))?;
            match self.add_cortical_area(power_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _power area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _power area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _power area already exists");
        }

        // Check and create _fatigue (cortical_idx=2)
        let fatigue_id = CoreCorticalType::Fatigue.to_cortical_id();
        let pain_id = CoreCorticalType::Pain.to_cortical_id();
        let pleasure_id = CoreCorticalType::Pleasure.to_cortical_id();
        let fear_id = CoreCorticalType::Fear.to_cortical_id();
        let hope_id = CoreCorticalType::Hope.to_cortical_id();
        if !self.cortical_areas.contains_key(&fatigue_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _fatigue area (cortical_idx=2)");
            let fatigue_area = CorticalArea::new(
                fatigue_id,
                2, // Will be overridden by add_cortical_area to 2
                "_fatigue".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Fatigue),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _fatigue area: {}", e)))?;
            match self.add_cortical_area(fatigue_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _fatigue area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _fatigue area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _fatigue area already exists");
        }

        // Check and create _pain (cortical_idx=3)
        if !self.cortical_areas.contains_key(&pain_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _pain area (cortical_idx=3)");
            let pain_area = CorticalArea::new(
                pain_id,
                3, // Will be overridden by add_cortical_area to 3
                "_pain".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Pain),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _pain area: {}", e)))?;
            match self.add_cortical_area(pain_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _pain area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _pain area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _pain area already exists");
        }

        // Check and create _pleasure (cortical_idx=4)
        if !self.cortical_areas.contains_key(&pleasure_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _pleasure area (cortical_idx=4)");
            let pleasure_area = CorticalArea::new(
                pleasure_id,
                4, // Will be overridden by add_cortical_area to 4
                "_pleasure".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Pleasure),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _pleasure area: {}", e)))?;
            match self.add_cortical_area(pleasure_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _pleasure area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _pleasure area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _pleasure area already exists");
        }

        // Check and create _fear (cortical_idx=5)
        if !self.cortical_areas.contains_key(&fear_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _fear area (cortical_idx=5)");
            let fear_area = CorticalArea::new(
                fear_id,
                5, // Will be overridden by add_cortical_area to 5
                "_fear".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Fear),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _fear area: {}", e)))?;
            match self.add_cortical_area(fear_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _fear area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _fear area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _fear area already exists");
        }

        // Check and create _hope (cortical_idx=6)
        if !self.cortical_areas.contains_key(&hope_id) {
            info!(target: "feagi-bdu", "🔧 [CORE-AREA] Creating missing _hope area (cortical_idx=6)");
            let hope_area = CorticalArea::new(
                hope_id,
                6, // Will be overridden by add_cortical_area to 6
                "_hope".to_string(),
                core_dimensions,
                core_position,
                CorticalAreaType::Core(CoreCorticalType::Hope),
            )
            .map_err(|e| BduError::Internal(format!("Failed to create _hope area: {}", e)))?;
            match self.add_cortical_area(hope_area) {
                Ok(idx) => {
                    info!(target: "feagi-bdu", "  ✅ Created _hope area with cortical_idx={}", idx);
                }
                Err(e) => {
                    error!(target: "feagi-bdu", "  ❌ Failed to add _hope area: {}", e);
                    return Err(e);
                }
            }
        } else {
            info!(target: "feagi-bdu", "  ✓ _hope area already exists");
        }

        info!(target: "feagi-bdu", "🔧 [CORE-AREA] Core area check complete");
        Ok(())
    }

    /// Save the connectome as a genome JSON
    ///
    /// **DEPRECATED**: This method produces incomplete hierarchical format v2.1 without morphologies/physiology.
    /// Use `GenomeService::save_genome()` instead, which produces complete flat format v3.0.
    ///
    /// This method is kept only for legacy tests. Production code MUST use GenomeService.
    ///
    /// # Arguments
    ///
    /// * `genome_id` - Optional custom genome ID (generates timestamp-based ID if None)
    /// * `genome_title` - Optional custom genome title
    ///
    /// # Returns
    ///
    /// JSON string representation of the genome (hierarchical v2.1, incomplete)
    ///
    #[deprecated(
        note = "Use GenomeService::save_genome() instead. This produces incomplete v2.1 format without morphologies/physiology."
    )]
    #[allow(deprecated)]
    pub fn save_genome_to_json(
        &self,
        genome_id: Option<String>,
        genome_title: Option<String>,
    ) -> BduResult<String> {
        // Build parent map from brain region hierarchy
        let mut brain_regions_with_parents = std::collections::HashMap::new();

        for region_id in self.brain_regions.get_all_region_ids() {
            if let Some(region) = self.brain_regions.get_region(region_id) {
                let parent_id = self
                    .brain_regions
                    .get_parent(region_id)
                    .map(|s| s.to_string());
                brain_regions_with_parents
                    .insert(region_id.to_string(), (region.clone(), parent_id));
            }
        }

        // Generate and return JSON
        Ok(feagi_evolutionary::GenomeSaver::save_to_json(
            &self.cortical_areas,
            &brain_regions_with_parents,
            genome_id,
            genome_title,
        )?)
    }

    // Load genome from file and develop brain
    //
    // This was a high-level convenience method that:
    // 1. Loads genome from JSON file
    // 2. Prepares for new genome (clears existing state)
    // 3. Runs neuroembryogenesis to develop the brain
    //
    // # Arguments
    //
    // * `genome_path` - Path to genome JSON file
    //
    // # Returns
    //
    // Development progress information
    //
    // NOTE: load_from_genome_file() and load_from_genome() have been REMOVED.
    // All genome loading must now go through GenomeService::load_genome() which:
    // - Stores RuntimeGenome for persistence
    // - Updates genome metadata
    // - Provides async/await support
    // - Includes timeout protection
    // - Ensures core cortical areas exist
    //
    // See: feagi-services/src/impls/genome_service_impl.rs::load_genome()

    /// Prepare for loading a new genome
    ///
    /// Clears all existing cortical areas, brain regions, and resets state.
    /// This is typically called before loading a new genome.
    ///
    pub fn prepare_for_new_genome(&mut self) -> BduResult<()> {
        info!(target: "feagi-bdu","Preparing for new genome (clearing existing state)");

        // Clear cortical areas
        self.cortical_areas.clear();
        self.cortical_id_to_idx.clear();
        self.cortical_idx_to_id.clear();
        // CRITICAL: Reserve 0..=6 for invariant core areas.
        self.next_cortical_idx = 7;
        info!("🔧 [BRAIN-RESET] Cortical mapping cleared, next_cortical_idx reset to 7 (reserves 0=_death, 1=_power, 2=_fatigue, 3=_pain, 4=_pleasure, 5=_fear, 6=_hope)");

        // Clear brain regions
        self.brain_regions = BrainRegionHierarchy::new();

        // Reset NPU runtime state to prevent old neurons/synapses from leaking into the next genome.
        if let Some(ref npu) = self.npu {
            let mut npu_lock = npu
                .lock()
                .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;
            npu_lock
                .reset_for_new_genome()
                .map_err(|e| BduError::Internal(format!("Failed to reset NPU: {}", e)))?;
        }

        info!(target: "feagi-bdu","✅ Connectome cleared and ready for new genome");
        Ok(())
    }

    /// Calculate and resize memory for a genome
    ///
    /// Analyzes the genome to determine memory requirements and
    /// prepares the NPU for the expected neuron/synapse counts.
    ///
    /// # Arguments
    ///
    /// * `genome` - Genome to analyze for memory requirements
    ///
    pub fn resize_for_genome(
        &mut self,
        genome: &feagi_evolutionary::RuntimeGenome,
    ) -> BduResult<()> {
        // Store morphologies from genome
        self.morphology_registry = genome.morphologies.clone();
        info!(target: "feagi-bdu", "Stored {} morphologies from genome", self.morphology_registry.count());

        // Calculate required capacity from genome stats
        let required_neurons = genome.stats.innate_neuron_count;
        let required_synapses = genome.stats.innate_synapse_count;

        info!(target: "feagi-bdu",
            "Genome requires: {} neurons, {} synapses",
            required_neurons,
            required_synapses
        );

        // Calculate total voxels from all cortical areas
        let mut total_voxels = 0;
        for area in genome.cortical_areas.values() {
            total_voxels += area.dimensions.width * area.dimensions.height * area.dimensions.depth;
        }

        info!(target: "feagi-bdu",
            "Genome has {} cortical areas with {} total voxels",
            genome.cortical_areas.len(),
            total_voxels
        );

        // TODO: Resize NPU if needed
        // For now, we assume NPU has sufficient capacity
        // In the future, we may want to dynamically resize the NPU based on genome requirements

        Ok(())
    }

    // ========================================================================
    // SYNAPSE OPERATIONS
    // ========================================================================

    /// Create a synapse between two neurons
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - Source neuron ID
    /// * `target_neuron_id` - Target neuron ID
    /// * `weight` - Synapse weight (`f32`)
    /// * `psp` - Synapse PSP (`f32`)
    /// * `synapse_type` - Synapse type (0=excitatory, 1=inhibitory)
    ///
    /// # Returns
    ///
    /// `Ok(())` if synapse created successfully
    ///
    pub fn create_synapse(
        &mut self,
        source_neuron_id: u64,
        target_neuron_id: u64,
        weight: f32,
        psp: f32,
        synapse_type: u8,
    ) -> BduResult<()> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        // Verify both neurons exist
        let source_exists = (source_neuron_id as u32) < npu_lock.get_neuron_count() as u32;
        let target_exists = (target_neuron_id as u32) < npu_lock.get_neuron_count() as u32;

        if !source_exists {
            return Err(BduError::InvalidNeuron(format!(
                "Source neuron {} not found",
                source_neuron_id
            )));
        }
        if !target_exists {
            return Err(BduError::InvalidNeuron(format!(
                "Target neuron {} not found",
                target_neuron_id
            )));
        }

        // Create synapse via NPU
        let syn_type = if synapse_type == 0 {
            feagi_npu_neural::synapse::SynapseType::Excitatory
        } else {
            feagi_npu_neural::synapse::SynapseType::Inhibitory
        };

        let synapse_idx = npu_lock
            .add_synapse(
                NeuronId(source_neuron_id as u32),
                NeuronId(target_neuron_id as u32),
                feagi_npu_neural::types::SynapticWeight(weight),
                feagi_npu_neural::types::SynapticPsp(psp),
                syn_type,
                0,
                1,
            )
            .map_err(|e| BduError::Internal(format!("Failed to create synapse: {}", e)))?;

        debug!(target: "feagi-bdu", "Created synapse: {} -> {} (weight: {}, psp: {}, type: {}, idx: {})",
            source_neuron_id, target_neuron_id, weight, psp, synapse_type, synapse_idx);

        let source_cortical_idx = npu_lock.get_neuron_cortical_area(source_neuron_id as u32);
        let target_cortical_idx = npu_lock.get_neuron_cortical_area(target_neuron_id as u32);
        let source_cortical_id =
            source_cortical_idx.and_then(|idx| self.cortical_idx_to_id.get(&idx).cloned());
        let target_cortical_id =
            target_cortical_idx.and_then(|idx| self.cortical_idx_to_id.get(&idx).cloned());

        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        let core_state = state_manager.get_core_state();
        core_state.add_synapse_count(1);
        if let Some(cortical_id) = source_cortical_id {
            state_manager.add_cortical_area_outgoing_synapses(&cortical_id.as_base_64(), 1);
        }
        if let Some(cortical_id) = target_cortical_id {
            state_manager.add_cortical_area_incoming_synapses(&cortical_id.as_base_64(), 1);
        }

        // Trigger fatigue index recalculation after synapse creation
        // NOTE: Disabled during genome loading to prevent blocking
        // let _ = self.update_fatigue_index();

        Ok(())
    }

    /// Synchronize cortical area flags with NPU
    /// This should be called after adding/updating cortical areas
    fn sync_cortical_area_flags_to_npu(&mut self) -> BduResult<()> {
        if let Some(ref npu) = self.npu {
            if let Ok(mut npu_lock) = npu.lock() {
                // Build psp_uniform_distribution flags map
                let mut psp_uniform_flags = ahash::AHashMap::new();
                let mut mp_driven_psp_flags = ahash::AHashMap::new();
                let mut postsynaptic_current_flags = ahash::AHashMap::new();
                let mut degeneration_flags = ahash::AHashMap::new();

                for (cortical_id, area) in &self.cortical_areas {
                    // When the property is absent: Power and Memory cortical areas default to uniform
                    // PSP (full PSP per synapse); other areas default to divided PSP.
                    let default_psp_uniform = *cortical_id
                        == CoreCorticalType::Power.to_cortical_id()
                        || matches!(area.cortical_type, CorticalAreaType::Memory(_));
                    let psp_uniform = area
                        .get_property("psp_uniform_distribution")
                        .and_then(|v| v.as_bool())
                        .unwrap_or(default_psp_uniform);
                    psp_uniform_flags.insert(*cortical_id, psp_uniform);

                    // Get mp_driven_psp flag (default to false)
                    let mp_driven_psp = area
                        .get_property("mp_driven_psp")
                        .and_then(|v| v.as_bool())
                        .unwrap_or(false);
                    mp_driven_psp_flags.insert(*cortical_id, mp_driven_psp);

                    // Store configured baseline PSP for reset-time restoration.
                    let postsynaptic_current = area
                        .get_property("postsynaptic_current")
                        .and_then(|v| v.as_f64())
                        .unwrap_or(1.0) as f32;
                    postsynaptic_current_flags.insert(*cortical_id, postsynaptic_current);

                    // Get degeneration coefficient (default 0.0 = disabled)
                    let degeneration = area
                        .get_property("degeneration")
                        .and_then(|v| v.as_f64())
                        .unwrap_or(0.0) as f32;
                    if degeneration > 0.0 {
                        degeneration_flags.insert(*cortical_id, degeneration);
                    }
                }

                // Update NPU with flags
                npu_lock.set_psp_uniform_distribution_flags(psp_uniform_flags);
                npu_lock.set_mp_driven_psp_flags(mp_driven_psp_flags);
                npu_lock.set_postsynaptic_current_flags(postsynaptic_current_flags);
                npu_lock.set_degeneration_flags(degeneration_flags);

                trace!(
                    target: "feagi-bdu",
                    "Synchronized cortical area flags to NPU ({} areas)",
                    self.cortical_areas.len()
                );
            }
        }

        Ok(())
    }

    /// Get synapse information between two neurons
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - Source neuron ID
    /// * `target_neuron_id` - Target neuron ID
    ///
    /// # Returns
    ///
    /// `Some((weight, psp, type))` if synapse exists, `None` otherwise
    ///
    pub fn get_synapse(
        &self,
        source_neuron_id: u64,
        target_neuron_id: u64,
    ) -> Option<(f32, f32, u8)> {
        // Get NPU
        let npu = self.npu.as_ref()?;
        let npu_lock = npu.lock().ok()?;

        // Use get_incoming_synapses and filter by source
        // (This does O(n) scan of synapse_array, but works even when propagation engine isn't updated)
        let incoming = npu_lock.get_incoming_synapses(target_neuron_id as u32);

        // Find the synapse from our specific source
        for (source_id, weight, psp, synapse_type) in incoming {
            if source_id == source_neuron_id as u32 {
                return Some((weight, psp, synapse_type));
            }
        }

        None
    }

    /// Update the weight of an existing synapse
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - Source neuron ID
    /// * `target_neuron_id` - Target neuron ID
    /// * `new_weight` - New synapse weight (0-255)
    ///
    /// # Returns
    ///
    /// `Ok(())` if synapse updated, `Err` if synapse not found
    ///
    pub fn update_synapse_weight(
        &mut self,
        source_neuron_id: u64,
        target_neuron_id: u64,
        new_weight: f32,
    ) -> BduResult<()> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        // Update synapse weight via NPU
        let updated = npu_lock.update_synapse_weight(
            NeuronId(source_neuron_id as u32),
            NeuronId(target_neuron_id as u32),
            feagi_npu_neural::types::SynapticWeight(new_weight),
        );

        if updated {
            debug!(target: "feagi-bdu","Updated synapse weight: {} -> {} = {}", source_neuron_id, target_neuron_id, new_weight);
            Ok(())
        } else {
            Err(BduError::InvalidSynapse(format!(
                "Synapse {} -> {} not found",
                source_neuron_id, target_neuron_id
            )))
        }
    }

    /// Remove a synapse between two neurons
    ///
    /// # Arguments
    ///
    /// * `source_neuron_id` - Source neuron ID
    /// * `target_neuron_id` - Target neuron ID
    ///
    /// # Returns
    ///
    /// `Ok(true)` if synapse removed, `Ok(false)` if synapse didn't exist
    ///
    pub fn remove_synapse(
        &mut self,
        source_neuron_id: u64,
        target_neuron_id: u64,
    ) -> BduResult<bool> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        let source_cortical_idx = npu_lock.get_neuron_cortical_area(source_neuron_id as u32);
        let target_cortical_idx = npu_lock.get_neuron_cortical_area(target_neuron_id as u32);
        let source_cortical_id =
            source_cortical_idx.and_then(|idx| self.cortical_idx_to_id.get(&idx).cloned());
        let target_cortical_id =
            target_cortical_idx.and_then(|idx| self.cortical_idx_to_id.get(&idx).cloned());

        // Remove synapse via NPU
        let removed = npu_lock.remove_synapse(
            NeuronId(source_neuron_id as u32),
            NeuronId(target_neuron_id as u32),
        );

        if removed {
            debug!(target: "feagi-bdu","Removed synapse: {} -> {}", source_neuron_id, target_neuron_id);

            // CRITICAL: Update StateManager synapse count (for health_check endpoint)
            let state_manager = StateManager::instance();
            let state_manager = state_manager.read();
            let core_state = state_manager.get_core_state();
            core_state.subtract_synapse_count(1);
            if let Some(cortical_id) = source_cortical_id {
                state_manager
                    .subtract_cortical_area_outgoing_synapses(&cortical_id.as_base_64(), 1);
            }
            if let Some(cortical_id) = target_cortical_id {
                state_manager
                    .subtract_cortical_area_incoming_synapses(&cortical_id.as_base_64(), 1);
            }
        }

        Ok(removed)
    }

    // ========================================================================
    // BATCH OPERATIONS
    // ========================================================================

    /// Batch create multiple neurons at once (SIMD-optimized)
    ///
    /// This is significantly faster than calling `add_neuron()` in a loop
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Target cortical area
    /// * `neurons` - Vector of neuron parameters (x, y, z, firing_threshold, leak, resting_potential, etc.)
    ///
    /// # Returns
    ///
    /// Vector of created neuron IDs
    ///
    pub fn batch_create_neurons(
        &mut self,
        cortical_id: &CorticalID,
        neurons: Vec<NeuronData>,
    ) -> BduResult<Vec<u64>> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        // Get cortical area to verify it exists and get its index
        let area = self.get_cortical_area(cortical_id).ok_or_else(|| {
            BduError::InvalidArea(format!("Cortical area {} not found", cortical_id))
        })?;
        let cortical_idx = area.cortical_idx;

        let count = neurons.len();

        // Extract parameters into separate vectors for batch operation
        let mut x_coords = Vec::with_capacity(count);
        let mut y_coords = Vec::with_capacity(count);
        let mut z_coords = Vec::with_capacity(count);
        let mut firing_thresholds = Vec::with_capacity(count);
        let mut threshold_limits = Vec::with_capacity(count);
        let mut leak_coeffs = Vec::with_capacity(count);
        let mut resting_potentials = Vec::with_capacity(count);
        let mut neuron_types = Vec::with_capacity(count);
        let mut refractory_periods = Vec::with_capacity(count);
        let mut excitabilities = Vec::with_capacity(count);
        let mut consec_fire_limits = Vec::with_capacity(count);
        let mut snooze_lengths = Vec::with_capacity(count);
        let mut mp_accums = Vec::with_capacity(count);
        let mut cortical_areas = Vec::with_capacity(count);

        for (
            x,
            y,
            z,
            threshold,
            threshold_limit,
            leak,
            resting,
            ntype,
            refract,
            excit,
            consec_limit,
            snooze,
            mp_accum,
        ) in neurons
        {
            x_coords.push(x);
            y_coords.push(y);
            z_coords.push(z);
            firing_thresholds.push(threshold);
            threshold_limits.push(threshold_limit);
            leak_coeffs.push(leak);
            resting_potentials.push(resting);
            neuron_types.push(ntype);
            refractory_periods.push(refract);
            excitabilities.push(excit);
            consec_fire_limits.push(consec_limit);
            snooze_lengths.push(snooze);
            mp_accums.push(mp_accum);
            cortical_areas.push(cortical_idx);
        }

        // Get the current neuron count - this will be the first ID of our batch
        let first_neuron_id = npu_lock.get_neuron_count() as u32;

        // Call NPU batch creation (SIMD-optimized)
        // Signature: (thresholds, threshold_limits, leak_coeffs, resting_pots, neuron_types, refract, excit, consec_limits, snooze, mp_accums, cortical_areas, x, y, z)
        // Convert f32 vectors to T
        // DynamicNPU will handle f32 inputs and convert internally based on its precision
        let firing_thresholds_t = firing_thresholds;
        let threshold_limits_t = threshold_limits;
        let resting_potentials_t = resting_potentials;
        let (neurons_created, _indices) = npu_lock.add_neurons_batch(
            firing_thresholds_t,
            threshold_limits_t,
            leak_coeffs,
            resting_potentials_t,
            neuron_types,
            refractory_periods,
            excitabilities,
            consec_fire_limits,
            snooze_lengths,
            mp_accums,
            cortical_areas,
            x_coords,
            y_coords,
            z_coords,
        );

        // Generate neuron IDs (they are sequential starting from first_neuron_id)
        let mut neuron_ids = Vec::with_capacity(count);
        for i in 0..neurons_created {
            neuron_ids.push((first_neuron_id + i) as u64);
        }

        info!(target: "feagi-bdu","Batch created {} neurons in cortical area {}", count, cortical_id);

        // CRITICAL: Update StateManager neuron count (for health_check endpoint)
        let state_manager = StateManager::instance();
        let state_manager = state_manager.read();
        let core_state = state_manager.get_core_state();
        core_state.add_neuron_count(neurons_created);
        core_state.add_regular_neuron_count(neurons_created);
        state_manager.add_cortical_area_neuron_count(&cortical_id.as_base_64(), count);

        // Best-effort: keep per-area cache in sync for lock-free reads.
        {
            let mut cache = self.cached_neuron_counts_per_area.write();
            cache
                .entry(*cortical_id)
                .or_insert_with(|| AtomicUsize::new(0))
                .fetch_add(count, Ordering::Relaxed);
        }

        Ok(neuron_ids)
    }

    /// Delete multiple neurons at once (batch operation)
    ///
    /// # Arguments
    ///
    /// * `neuron_ids` - Vector of neuron IDs to delete
    ///
    /// # Returns
    ///
    /// Number of neurons actually deleted
    ///
    pub fn delete_neurons_batch(&mut self, neuron_ids: Vec<u64>) -> BduResult<usize> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        let mut deleted_count = 0;
        let mut per_area_deleted: std::collections::HashMap<String, usize> =
            std::collections::HashMap::new();

        // Delete each neuron
        // Note: Could be optimized with a batch delete method in NPU if needed
        for neuron_id in neuron_ids {
            let cortical_idx = npu_lock.get_neuron_cortical_area(neuron_id as u32);
            let cortical_id =
                cortical_idx.and_then(|idx| self.cortical_idx_to_id.get(&idx).cloned());

            if npu_lock.delete_neuron(neuron_id as u32) {
                deleted_count += 1;
                if let Some(cortical_id) = cortical_id {
                    let key = cortical_id.as_base_64();
                    *per_area_deleted.entry(key).or_insert(0) += 1;
                }
            }
        }

        info!(target: "feagi-bdu","Batch deleted {} neurons", deleted_count);

        // CRITICAL: Update StateManager neuron count (for health_check endpoint)
        if deleted_count > 0 {
            let state_manager = StateManager::instance();
            let state_manager = state_manager.read();
            let core_state = state_manager.get_core_state();
            core_state.subtract_neuron_count(deleted_count as u32);
            core_state.subtract_regular_neuron_count(deleted_count as u32);
            for (cortical_id, count) in per_area_deleted {
                state_manager.subtract_cortical_area_neuron_count(&cortical_id, count);
            }
        }

        // Trigger fatigue index recalculation after batch neuron deletion
        // NOTE: Disabled during genome loading to prevent blocking
        // if deleted_count > 0 {
        //     let _ = self.update_fatigue_index();
        // }

        Ok(deleted_count)
    }

    // ========================================================================
    // NEURON UPDATE OPERATIONS
    // ========================================================================

    /// Update properties of an existing neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Target neuron ID
    /// * `firing_threshold` - Optional new firing threshold
    /// * `leak_coefficient` - Optional new leak coefficient
    /// * `resting_potential` - Optional new resting potential
    /// * `excitability` - Optional new excitability
    ///
    /// # Returns
    ///
    /// `Ok(())` if neuron updated successfully
    ///
    pub fn update_neuron_properties(
        &mut self,
        neuron_id: u64,
        firing_threshold: Option<f32>,
        leak_coefficient: Option<f32>,
        resting_potential: Option<f32>,
        excitability: Option<f32>,
    ) -> BduResult<()> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        let neuron_id_u32 = neuron_id as u32;

        // Verify neuron exists by trying to update at least one property
        let mut updated = false;

        // Update properties if provided
        if let Some(threshold) = firing_threshold {
            if npu_lock.update_neuron_threshold(neuron_id_u32, threshold) {
                updated = true;
                debug!(target: "feagi-bdu","Updated neuron {} firing_threshold = {}", neuron_id, threshold);
            } else if !updated {
                return Err(BduError::InvalidNeuron(format!(
                    "Neuron {} not found",
                    neuron_id
                )));
            }
        }

        if let Some(leak) = leak_coefficient {
            if npu_lock.update_neuron_leak(neuron_id_u32, leak) {
                updated = true;
                debug!(target: "feagi-bdu","Updated neuron {} leak_coefficient = {}", neuron_id, leak);
            } else if !updated {
                return Err(BduError::InvalidNeuron(format!(
                    "Neuron {} not found",
                    neuron_id
                )));
            }
        }

        if let Some(resting) = resting_potential {
            if npu_lock.update_neuron_resting_potential(neuron_id_u32, resting) {
                updated = true;
                debug!(target: "feagi-bdu","Updated neuron {} resting_potential = {}", neuron_id, resting);
            } else if !updated {
                return Err(BduError::InvalidNeuron(format!(
                    "Neuron {} not found",
                    neuron_id
                )));
            }
        }

        if let Some(excit) = excitability {
            if npu_lock.update_neuron_excitability(neuron_id_u32, excit) {
                updated = true;
                debug!(target: "feagi-bdu","Updated neuron {} excitability = {}", neuron_id, excit);
            } else if !updated {
                return Err(BduError::InvalidNeuron(format!(
                    "Neuron {} not found",
                    neuron_id
                )));
            }
        }

        if !updated {
            return Err(BduError::Internal(
                "No properties provided for update".to_string(),
            ));
        }

        info!(target: "feagi-bdu","Updated properties for neuron {}", neuron_id);

        Ok(())
    }

    /// Update the firing threshold of a specific neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Target neuron ID
    /// * `new_threshold` - New firing threshold value
    ///
    /// # Returns
    ///
    /// `Ok(())` if threshold updated successfully
    ///
    pub fn set_neuron_firing_threshold(
        &mut self,
        neuron_id: u64,
        new_threshold: f32,
    ) -> BduResult<()> {
        // Get NPU
        let npu = self
            .npu
            .as_ref()
            .ok_or_else(|| BduError::Internal("NPU not connected".to_string()))?;

        let mut npu_lock = npu
            .lock()
            .map_err(|e| BduError::Internal(format!("Failed to lock NPU: {}", e)))?;

        // Update threshold via NPU
        if npu_lock.update_neuron_threshold(neuron_id as u32, new_threshold) {
            debug!(target: "feagi-bdu","Set neuron {} firing threshold = {}", neuron_id, new_threshold);
            Ok(())
        } else {
            Err(BduError::InvalidNeuron(format!(
                "Neuron {} not found",
                neuron_id
            )))
        }
    }

    // ========================================================================
    // AREA MANAGEMENT & QUERIES
    // ========================================================================

    /// Get cortical area by name (alternative to ID lookup)
    ///
    /// # Arguments
    ///
    /// * `name` - Human-readable area name
    ///
    /// # Returns
    ///
    /// `Some(CorticalArea)` if found, `None` otherwise
    ///
    pub fn get_cortical_area_by_name(&self, name: &str) -> Option<CorticalArea> {
        self.cortical_areas
            .values()
            .find(|area| area.name == name)
            .cloned()
    }

    /// Resize a cortical area (changes dimensions, may require neuron reallocation)
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Target cortical area ID
    /// * `new_dimensions` - New dimensions (width, height, depth)
    ///
    /// # Returns
    ///
    /// `Ok(())` if resized successfully
    ///
    /// # Note
    ///
    /// This does NOT automatically create/delete neurons. It only updates metadata.
    /// Caller must handle neuron population separately.
    ///
    pub fn resize_cortical_area(
        &mut self,
        cortical_id: &CorticalID,
        new_dimensions: CorticalAreaDimensions,
    ) -> BduResult<()> {
        // Validate dimensions
        if new_dimensions.width == 0 || new_dimensions.height == 0 || new_dimensions.depth == 0 {
            return Err(BduError::InvalidArea(format!(
                "Invalid dimensions: {:?} (all must be > 0)",
                new_dimensions
            )));
        }

        // Get and update area
        let area = self.cortical_areas.get_mut(cortical_id).ok_or_else(|| {
            BduError::InvalidArea(format!("Cortical area {} not found", cortical_id))
        })?;

        let old_dimensions = area.dimensions;
        area.dimensions = new_dimensions;

        // Note: Visualization voxel granularity is user-driven, not recalculated on resize
        // If user had set a custom value, it remains; otherwise defaults to 1x1x1

        info!(target: "feagi-bdu",
            "Resized cortical area {} from {:?} to {:?}",
            cortical_id,
            old_dimensions,
            new_dimensions
        );

        self.refresh_cortical_area_hashes(false, true);

        Ok(())
    }

    /// Get all cortical areas in a brain region
    ///
    /// # Arguments
    ///
    /// * `region_id` - Brain region ID
    ///
    /// # Returns
    ///
    /// Vector of cortical area IDs in the region
    ///
    pub fn get_areas_in_region(&self, region_id: &str) -> BduResult<Vec<String>> {
        let region = self.brain_regions.get_region(region_id).ok_or_else(|| {
            BduError::InvalidArea(format!("Brain region {} not found", region_id))
        })?;

        // Convert CorticalID to base64 strings
        Ok(region
            .cortical_areas
            .iter()
            .map(|id| id.as_base_64())
            .collect())
    }

    /// Update brain region properties
    ///
    /// # Arguments
    ///
    /// * `region_id` - Target region ID
    /// * `new_name` - Optional new name
    /// * `new_description` - Optional new description
    ///
    /// # Returns
    ///
    /// `Ok(())` if updated successfully
    ///
    pub fn update_brain_region(
        &mut self,
        region_id: &str,
        new_name: Option<String>,
        new_description: Option<String>,
    ) -> BduResult<()> {
        let region = self
            .brain_regions
            .get_region_mut(region_id)
            .ok_or_else(|| {
                BduError::InvalidArea(format!("Brain region {} not found", region_id))
            })?;

        if let Some(name) = new_name {
            region.name = name;
            debug!(target: "feagi-bdu","Updated brain region {} name", region_id);
        }

        if let Some(desc) = new_description {
            // BrainRegion doesn't have a description field in the struct, so we'll store it in properties
            region
                .properties
                .insert("description".to_string(), serde_json::json!(desc));
            debug!(target: "feagi-bdu","Updated brain region {} description", region_id);
        }

        info!(target: "feagi-bdu","Updated brain region {}", region_id);

        self.refresh_brain_regions_hash();

        Ok(())
    }

    /// Update brain region properties with generic property map
    ///
    /// Supports updating any brain region property including coordinates, title, description, etc.
    ///
    /// # Arguments
    ///
    /// * `region_id` - Target region ID
    /// * `properties` - Map of property names to new values
    ///
    /// # Returns
    ///
    /// `Ok(())` if updated successfully
    ///
    pub fn update_brain_region_properties(
        &mut self,
        region_id: &str,
        properties: std::collections::HashMap<String, serde_json::Value>,
    ) -> BduResult<Option<BrainRegionIoRegistry>> {
        use tracing::{debug, info};

        let should_recompute_io = properties
            .contains_key(crate::region_io_designation::DESIGNATED_INPUTS_KEY)
            || properties.contains_key(crate::region_io_designation::DESIGNATED_OUTPUTS_KEY);

        if properties.contains_key(crate::region_io_designation::DESIGNATED_INPUTS_KEY)
            || properties.contains_key(crate::region_io_designation::DESIGNATED_OUTPUTS_KEY)
        {
            let region_snapshot = self
                .brain_regions
                .get_region(region_id)
                .ok_or_else(|| {
                    BduError::InvalidArea(format!("Brain region {} not found", region_id))
                })?
                .clone();
            let (merged_in, merged_out) = crate::region_io_designation::merged_designated_lists(
                &region_snapshot,
                &properties,
            )?;
            crate::region_io_designation::validate_merged_designations_against_connectivity(
                self,
                &region_snapshot,
                &merged_in,
                &merged_out,
            )?;
        }

        let region = self
            .brain_regions
            .get_region_mut(region_id)
            .ok_or_else(|| {
                BduError::InvalidArea(format!("Brain region {} not found", region_id))
            })?;

        for (key, value) in properties {
            match key.as_str() {
                // BV (FEAGIRequests.edit_region_object) sends `region_title`; other clients use `title` / `name`.
                "title" | "name" | "region_title" => {
                    if let Some(name) = value.as_str() {
                        region.name = name.to_string();
                        debug!(target: "feagi-bdu", "Updated brain region {} name = {}", region_id, name);
                    }
                }
                "coordinate_3d" | "coordinates_3d" => {
                    region
                        .properties
                        .insert("coordinate_3d".to_string(), value.clone());
                    debug!(target: "feagi-bdu", "Updated brain region {} coordinate_3d = {:?}", region_id, value);
                }
                "coordinate_2d" | "coordinates_2d" => {
                    region
                        .properties
                        .insert("coordinate_2d".to_string(), value.clone());
                    debug!(target: "feagi-bdu", "Updated brain region {} coordinate_2d = {:?}", region_id, value);
                }
                "description" => {
                    region
                        .properties
                        .insert("description".to_string(), value.clone());
                    debug!(target: "feagi-bdu", "Updated brain region {} description", region_id);
                }
                "region_type" => {
                    if let Some(type_str) = value.as_str() {
                        // Note: RegionType is currently a placeholder (Undefined only)
                        // Specific region types will be added in the future
                        region.region_type = feagi_structures::genomic::RegionType::Undefined;
                        debug!(target: "feagi-bdu", "Updated brain region {} type = {}", region_id, type_str);
                    }
                }
                // Store any other properties in the properties map
                _ => {
                    region.properties.insert(key.clone(), value.clone());
                    debug!(target: "feagi-bdu", "Updated brain region {} property {} = {:?}", region_id, key, value);
                }
            }
        }

        info!(target: "feagi-bdu", "Updated brain region {} properties", region_id);

        // Designated IO affects merged inputs/outputs used by regions_members and BV plates; recompute
        // so connectivity-derived and declared lists stay merged in region.properties.
        if should_recompute_io {
            let registry = self.recompute_brain_region_io_registry()?;
            return Ok(Some(registry));
        }

        // Keep StateManager health hashes in sync so clients (e.g. Brain Visualizer) detect changes via
        // brain_regions_hash on the next health poll. Without this, PUT /v1/region/region updates
        // (coordinates, title, etc.) do not bump the hash — same as update_brain_region for name/description.
        self.refresh_brain_regions_hash();

        Ok(None)
    }

    // ========================================================================
    // NEURON QUERY METHODS (P6)
    // ========================================================================

    /// Get neuron by 3D coordinates within a cortical area
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Cortical area ID
    /// * `x` - X coordinate
    /// * `y` - Y coordinate
    /// * `z` - Z coordinate
    ///
    /// # Returns
    ///
    /// `Some(neuron_id)` if found, `None` otherwise
    ///
    pub fn get_neuron_by_coordinates(
        &self,
        cortical_id: &CorticalID,
        x: u32,
        y: u32,
        z: u32,
    ) -> Option<u64> {
        // Get cortical area to get its index
        let area = self.get_cortical_area(cortical_id)?;
        let cortical_idx = area.cortical_idx;

        // Query NPU via public method
        let npu = self.npu.as_ref()?;
        let npu_lock = npu.lock().ok()?;

        npu_lock
            .get_neuron_id_at_coordinate(cortical_idx, x, y, z)
            .map(|id| id as u64)
    }

    /// Get the position (coordinates) of a neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Neuron ID
    ///
    /// # Returns
    ///
    /// `Some((x, y, z))` if found, `None` otherwise
    ///
    pub fn get_neuron_position(&self, neuron_id: u64) -> Option<(u32, u32, u32)> {
        let npu = self.npu.as_ref()?;
        let npu_lock = npu.lock().ok()?;

        // Verify neuron exists and get coordinates
        let neuron_count = npu_lock.get_neuron_count();
        if (neuron_id as usize) >= neuron_count {
            return None;
        }

        Some(
            npu_lock
                .get_neuron_coordinates(neuron_id as u32)
                .unwrap_or((0, 0, 0)),
        )
    }

    /// Get which cortical area contains a specific neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Neuron ID
    ///
    /// # Returns
    ///
    /// `Some(cortical_id)` if found, `None` otherwise
    ///
    pub fn get_cortical_area_for_neuron(&self, neuron_id: u64) -> Option<CorticalID> {
        let npu = self.npu.as_ref()?;
        let npu_lock = npu.lock().ok()?;

        // Verify neuron exists
        let neuron_count = npu_lock.get_neuron_count();
        if (neuron_id as usize) >= neuron_count {
            return None;
        }

        let cortical_idx = npu_lock.get_neuron_cortical_area(neuron_id as u32)?;

        // Look up cortical_id from index
        self.cortical_areas
            .values()
            .find(|area| area.cortical_idx == cortical_idx)
            .map(|area| area.cortical_id)
    }

    /// Get all properties of a neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Neuron ID
    ///
    /// # Returns
    ///
    /// `Some(properties)` if found, `None` otherwise
    ///
    pub fn get_neuron_properties(
        &self,
        neuron_id: u64,
    ) -> Option<std::collections::HashMap<String, serde_json::Value>> {
        let npu = self.npu.as_ref()?;
        let npu_lock = npu.lock().ok()?;

        let neuron_id_u32 = neuron_id as u32;
        let idx = neuron_id as usize;

        // Verify neuron exists
        let neuron_count = npu_lock.get_neuron_count();
        if idx >= neuron_count {
            return None;
        }

        let mut properties = std::collections::HashMap::new();

        // Basic info
        properties.insert("neuron_id".to_string(), serde_json::json!(neuron_id));

        // Get coordinates
        let (x, y, z) = npu_lock.get_neuron_coordinates(neuron_id_u32)?;
        properties.insert("x".to_string(), serde_json::json!(x));
        properties.insert("y".to_string(), serde_json::json!(y));
        properties.insert("z".to_string(), serde_json::json!(z));

        // Get cortical area
        let cortical_idx = npu_lock.get_neuron_cortical_area(neuron_id_u32)?;
        properties.insert("cortical_area".to_string(), serde_json::json!(cortical_idx));

        // Per-neuron dynamics flags + cortical-level propagation flags (synaptic engine).
        properties.insert(
            "mp_charge_accumulation".to_string(),
            serde_json::json!(npu_lock.get_mp_charge_accumulation_at(idx).unwrap_or(false)),
        );
        properties.insert(
            "neuron_type".to_string(),
            serde_json::json!(npu_lock.get_neuron_type_at(idx).unwrap_or(0)),
        );
        let (mp_drv, psp_uni) = self
            .cortical_idx_to_id
            .get(&cortical_idx)
            .map(|cid| {
                (
                    npu_lock.get_mp_driven_psp_for_cortical(cid),
                    npu_lock.get_psp_uniform_distribution_for_cortical(cid),
                )
            })
            .unwrap_or((false, false));
        properties.insert("mp_driven_psp".to_string(), serde_json::json!(mp_drv));
        properties.insert(
            "psp_uniform_distribution".to_string(),
            serde_json::json!(psp_uni),
        );

        // Neuron state: always expose the same keys (stable JSON for clients) even when
        // `get_neuron_state` is unavailable (e.g. invalid mask / edge indexing).
        let (consec_count, consec_limit, snooze, mp, threshold, refract_countdown) = npu_lock
            .get_neuron_state(NeuronId(neuron_id_u32))
            .unwrap_or((0u16, 0u16, 0u16, 0.0f32, 0.0f32, 0u16));
        properties.insert(
            "consecutive_fire_count".to_string(),
            serde_json::json!(consec_count),
        );
        properties.insert(
            "consecutive_fire_limit".to_string(),
            serde_json::json!(consec_limit),
        );
        properties.insert("snooze_period".to_string(), serde_json::json!(snooze));
        properties.insert("membrane_potential".to_string(), serde_json::json!(mp));
        properties.insert("threshold".to_string(), serde_json::json!(threshold));
        properties.insert(
            "refractory_countdown".to_string(),
            serde_json::json!(refract_countdown),
        );

        // Scalar neuron parameters (stable keys; default when storage omits a value).
        properties.insert(
            "leak_coefficient".to_string(),
            serde_json::json!(npu_lock
                .get_neuron_property_by_index(idx, "leak_coefficient")
                .unwrap_or(0.0)),
        );
        properties.insert(
            "resting_potential".to_string(),
            serde_json::json!(npu_lock
                .get_neuron_property_by_index(idx, "resting_potential")
                .unwrap_or(0.0)),
        );
        properties.insert(
            "excitability".to_string(),
            serde_json::json!(npu_lock
                .get_neuron_property_by_index(idx, "excitability")
                .unwrap_or(0.0)),
        );
        properties.insert(
            "threshold_limit".to_string(),
            serde_json::json!(npu_lock
                .get_neuron_property_by_index(idx, "threshold_limit")
                .unwrap_or(0.0)),
        );
        properties.insert(
            "refractory_period".to_string(),
            serde_json::json!(npu_lock
                .get_neuron_property_u16_by_index(idx, "refractory_period")
                .unwrap_or(0)),
        );

        Some(properties)
    }

    /// Get a specific property of a neuron
    ///
    /// # Arguments
    ///
    /// * `neuron_id` - Neuron ID
    /// * `property_name` - Name of the property to retrieve
    ///
    /// # Returns
    ///
    /// `Some(value)` if found, `None` otherwise
    ///
    pub fn get_neuron_property(
        &self,
        neuron_id: u64,
        property_name: &str,
    ) -> Option<serde_json::Value> {
        self.get_neuron_properties(neuron_id)?
            .get(property_name)
            .cloned()
    }

    // ========================================================================
    // CORTICAL AREA LIST/QUERY METHODS (P6)
    // ========================================================================

    /// Get all cortical area IDs
    ///
    /// # Returns
    ///
    /// Vector of all cortical area IDs
    ///
    pub fn get_all_cortical_ids(&self) -> Vec<CorticalID> {
        self.cortical_areas.keys().copied().collect()
    }

    /// Get all cortical area indices
    ///
    /// # Returns
    ///
    /// Vector of all cortical area indices
    ///
    pub fn get_all_cortical_indices(&self) -> Vec<u32> {
        self.cortical_areas
            .values()
            .map(|area| area.cortical_idx)
            .collect()
    }

    /// Get all cortical area names
    ///
    /// # Returns
    ///
    /// Vector of all cortical area names
    ///
    pub fn get_cortical_area_names(&self) -> Vec<String> {
        self.cortical_areas
            .values()
            .map(|area| area.name.clone())
            .collect()
    }

    /// List all input (IPU/sensory) cortical areas
    ///
    /// # Returns
    ///
    /// Vector of IPU/sensory area IDs
    ///
    pub fn list_ipu_areas(&self) -> Vec<CorticalID> {
        use crate::models::CorticalAreaExt;
        self.cortical_areas
            .values()
            .filter(|area| area.is_input_area())
            .map(|area| area.cortical_id)
            .collect()
    }

    /// List all output (OPU/motor) cortical areas
    ///
    /// # Returns
    ///
    /// Vector of OPU/motor area IDs
    ///
    pub fn list_opu_areas(&self) -> Vec<CorticalID> {
        use crate::models::CorticalAreaExt;
        self.cortical_areas
            .values()
            .filter(|area| area.is_output_area())
            .map(|area| area.cortical_id)
            .collect()
    }

    /// Get maximum dimensions across all cortical areas
    ///
    /// # Returns
    ///
    /// (max_width, max_height, max_depth)
    ///
    pub fn get_max_cortical_area_dimensions(&self) -> (usize, usize, usize) {
        self.cortical_areas
            .values()
            .fold((0, 0, 0), |(max_w, max_h, max_d), area| {
                (
                    max_w.max(area.dimensions.width as usize),
                    max_h.max(area.dimensions.height as usize),
                    max_d.max(area.dimensions.depth as usize),
                )
            })
    }

    /// Get all properties of a cortical area as a JSON-serializable map
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Cortical area ID
    ///
    /// # Returns
    ///
    /// `Some(properties)` if found, `None` otherwise
    ///
    pub fn get_cortical_area_properties(
        &self,
        cortical_id: &CorticalID,
    ) -> Option<std::collections::HashMap<String, serde_json::Value>> {
        let area = self.get_cortical_area(cortical_id)?;

        let mut properties = std::collections::HashMap::new();
        properties.insert(
            "cortical_id".to_string(),
            serde_json::json!(area.cortical_id),
        );
        properties.insert(
            "cortical_id_s".to_string(),
            serde_json::json!(area.cortical_id.to_string()),
        );
        properties.insert(
            "cortical_idx".to_string(),
            serde_json::json!(area.cortical_idx),
        );
        properties.insert("name".to_string(), serde_json::json!(area.name));
        use crate::models::CorticalAreaExt;
        properties.insert(
            "area_type".to_string(),
            serde_json::json!(area.get_cortical_group()),
        );
        properties.insert(
            "dimensions".to_string(),
            serde_json::json!({
                "width": area.dimensions.width,
                "height": area.dimensions.height,
                "depth": area.dimensions.depth,
            }),
        );
        properties.insert("position".to_string(), serde_json::json!(area.position));

        // Copy all properties from area.properties to the response
        for (key, value) in &area.properties {
            properties.insert(key.clone(), value.clone());
        }

        // Add custom properties
        properties.extend(area.properties.clone());

        Some(properties)
    }

    /// Get properties of all cortical areas
    ///
    /// # Returns
    ///
    /// Vector of property maps for all areas
    ///
    pub fn get_all_cortical_area_properties(
        &self,
    ) -> Vec<std::collections::HashMap<String, serde_json::Value>> {
        self.cortical_areas
            .keys()
            .filter_map(|id| self.get_cortical_area_properties(id))
            .collect()
    }

    // ========================================================================
    // BRAIN REGION QUERY METHODS (P6)
    // ========================================================================

    /// Get all brain region IDs
    ///
    /// # Returns
    ///
    /// Vector of all brain region IDs
    ///
    pub fn get_all_brain_region_ids(&self) -> Vec<String> {
        self.brain_regions
            .get_all_region_ids()
            .into_iter()
            .cloned()
            .collect()
    }

    /// Get all brain region names
    ///
    /// # Returns
    ///
    /// Vector of all brain region names
    ///
    pub fn get_brain_region_names(&self) -> Vec<String> {
        self.brain_regions
            .get_all_region_ids()
            .iter()
            .filter_map(|id| {
                self.brain_regions
                    .get_region(id)
                    .map(|region| region.name.clone())
            })
            .collect()
    }

    /// Get properties of a brain region
    ///
    /// # Arguments
    ///
    /// * `region_id` - Brain region ID
    ///
    /// # Returns
    ///
    /// `Some(properties)` if found, `None` otherwise
    ///
    pub fn get_brain_region_properties(
        &self,
        region_id: &str,
    ) -> Option<std::collections::HashMap<String, serde_json::Value>> {
        let region = self.brain_regions.get_region(region_id)?;

        let mut properties = std::collections::HashMap::new();
        properties.insert("region_id".to_string(), serde_json::json!(region.region_id));
        properties.insert("name".to_string(), serde_json::json!(region.name));
        properties.insert(
            "region_type".to_string(),
            serde_json::json!(format!("{:?}", region.region_type)),
        );
        properties.insert(
            "cortical_areas".to_string(),
            serde_json::json!(region.cortical_areas.iter().collect::<Vec<_>>()),
        );

        // Add custom properties
        properties.extend(region.properties.clone());

        Some(properties)
    }

    /// Check if a cortical area exists
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Cortical area ID to check
    ///
    /// # Returns
    ///
    /// `true` if area exists, `false` otherwise
    ///
    pub fn cortical_area_exists(&self, cortical_id: &CorticalID) -> bool {
        self.cortical_areas.contains_key(cortical_id)
    }

    /// Check if a brain region exists
    ///
    /// # Arguments
    ///
    /// * `region_id` - Brain region ID to check
    ///
    /// # Returns
    ///
    /// `true` if region exists, `false` otherwise
    ///
    pub fn brain_region_exists(&self, region_id: &str) -> bool {
        self.brain_regions.get_region(region_id).is_some()
    }

    /// Get the total number of brain regions
    ///
    /// # Returns
    ///
    /// Number of brain regions
    ///
    pub fn get_brain_region_count(&self) -> usize {
        self.brain_regions.region_count()
    }

    /// Get neurons by cortical area (alias for get_neurons_in_area for API compatibility)
    ///
    /// # Arguments
    ///
    /// * `cortical_id` - Cortical area ID
    ///
    /// # Returns
    ///
    /// Vector of neuron IDs in the area
    ///
    pub fn get_neurons_by_cortical_area(&self, cortical_id: &CorticalID) -> Vec<u64> {
        // This is an alias for get_neurons_in_area, which already exists
        // Keeping it for Python API compatibility
        // Note: The signature says Vec<NeuronId> but implementation returns Vec<u64>
        self.get_neurons_in_area(cortical_id)
    }
}

// Manual Debug implementation (RustNPU doesn't implement Debug)
impl std::fmt::Debug for ConnectomeManager {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("ConnectomeManager")
            .field("cortical_areas", &self.cortical_areas.len())
            .field("next_cortical_idx", &self.next_cortical_idx)
            .field("brain_regions", &self.brain_regions)
            .field(
                "npu",
                &if self.npu.is_some() {
                    "Connected"
                } else {
                    "Not connected"
                },
            )
            .field("initialized", &self.initialized)
            .finish()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use feagi_structures::genomic::cortical_area::CoreCorticalType;

    #[test]
    fn test_singleton_instance() {
        let instance1 = ConnectomeManager::instance();
        let instance2 = ConnectomeManager::instance();

        // Both should point to the same instance
        assert_eq!(Arc::strong_count(&instance1), Arc::strong_count(&instance2));
    }

    #[test]
    fn test_add_cortical_area() {
        ConnectomeManager::reset_for_testing();

        let instance = ConnectomeManager::instance();
        let mut manager = instance.write();

        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        let cortical_id = CorticalID::try_from_bytes(b"cst_add_").unwrap(); // Use unique custom ID
        let cortical_type = CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean);
        let area = CorticalArea::new(
            cortical_id,
            0,
            "Visual Input".to_string(),
            CorticalAreaDimensions::new(128, 128, 20).unwrap(),
            (0, 0, 0).into(),
            cortical_type,
        )
        .unwrap();

        let initial_count = manager.get_cortical_area_count();
        let _cortical_idx = manager.add_cortical_area(area).unwrap();

        assert_eq!(manager.get_cortical_area_count(), initial_count + 1);
        assert!(manager.has_cortical_area(&cortical_id));
        assert!(manager.is_initialized());
    }

    #[test]
    fn test_cortical_area_lookups() {
        ConnectomeManager::reset_for_testing();

        let instance = ConnectomeManager::instance();
        let mut manager = instance.write();

        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        let cortical_id = CorticalID::try_from_bytes(b"cst_look").unwrap(); // Use unique custom ID
        let cortical_type = CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean);
        let area = CorticalArea::new(
            cortical_id,
            0,
            "Test Area".to_string(),
            CorticalAreaDimensions::new(10, 10, 10).unwrap(),
            (0, 0, 0).into(),
            cortical_type,
        )
        .unwrap();

        let cortical_idx = manager.add_cortical_area(area).unwrap();

        // ID -> idx lookup
        assert_eq!(manager.get_cortical_idx(&cortical_id), Some(cortical_idx));

        // idx -> ID lookup
        assert_eq!(manager.get_cortical_id(cortical_idx), Some(&cortical_id));

        // Get area
        let retrieved_area = manager.get_cortical_area(&cortical_id).unwrap();
        assert_eq!(retrieved_area.name, "Test Area");
    }

    #[test]
    fn test_remove_cortical_area() {
        ConnectomeManager::reset_for_testing();

        let instance = ConnectomeManager::instance();
        let mut manager = instance.write();

        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        let cortical_id = CoreCorticalType::Power.to_cortical_id();

        // Remove area if it already exists from previous tests
        if manager.has_cortical_area(&cortical_id) {
            manager.remove_cortical_area(&cortical_id).unwrap();
        }

        let cortical_type = CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean);
        let area = CorticalArea::new(
            cortical_id,
            0,
            "Test".to_string(),
            CorticalAreaDimensions::new(10, 10, 10).unwrap(),
            (0, 0, 0).into(),
            cortical_type,
        )
        .unwrap();

        let initial_count = manager.get_cortical_area_count();
        manager.add_cortical_area(area).unwrap();
        assert_eq!(manager.get_cortical_area_count(), initial_count + 1);

        manager.remove_cortical_area(&cortical_id).unwrap();
        assert_eq!(manager.get_cortical_area_count(), initial_count);
        assert!(!manager.has_cortical_area(&cortical_id));
    }

    #[test]
    fn test_duplicate_area_error() {
        ConnectomeManager::reset_for_testing();

        let instance = ConnectomeManager::instance();
        let mut manager = instance.write();

        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        // Use a unique ID only for this test to avoid collisions with other tests (e.g. Power)
        // when tests run in parallel; we still test duplicate by adding the same ID twice.
        let cortical_id = CorticalID::try_from_bytes(b"cst_dup1").unwrap();
        let cortical_type = CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean);
        let area1 = CorticalArea::new(
            cortical_id,
            0,
            "First".to_string(),
            CorticalAreaDimensions::new(10, 10, 10).unwrap(),
            (0, 0, 0).into(),
            cortical_type,
        )
        .unwrap();

        let area2 = CorticalArea::new(
            cortical_id, // Same ID - duplicate
            1,
            "Second".to_string(),
            CorticalAreaDimensions::new(10, 10, 10).unwrap(),
            (0, 0, 0).into(),
            cortical_type,
        )
        .unwrap();

        manager.add_cortical_area(area1).unwrap();
        let result = manager.add_cortical_area(area2);

        assert!(result.is_err());
    }

    #[test]
    fn test_brain_region_management() {
        ConnectomeManager::reset_for_testing();

        let instance = ConnectomeManager::instance();
        let mut manager = instance.write();

        let region_id = feagi_structures::genomic::brain_regions::RegionID::new();
        let region_id_str = region_id.to_string();
        let root = BrainRegion::new(
            region_id,
            "Root".to_string(),
            feagi_structures::genomic::brain_regions::RegionType::Undefined,
        )
        .unwrap();

        let initial_count = manager.get_brain_region_ids().len();
        manager.add_brain_region(root, None).unwrap();

        assert_eq!(manager.get_brain_region_ids().len(), initial_count + 1);
        assert!(manager.get_brain_region(&region_id_str).is_some());
    }

    #[test]
    fn test_synapse_operations() {
        use feagi_npu_burst_engine::npu::RustNPU;
        use feagi_npu_burst_engine::TracingMutex;
        use std::sync::Arc;

        // Create NPU and manager for isolated test state
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::DynamicNPU;
        use feagi_npu_runtime::StdRuntime;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu_result =
            RustNPU::new(runtime, backend, 100, 1000, 10).expect("Failed to create NPU");
        let npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu_result), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(npu.clone());

        // First create a cortical area to add neurons to
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        let cortical_id = CorticalID::try_from_bytes(b"cst_syn_").unwrap(); // Use unique custom ID
        let cortical_type = CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean);
        let area = CorticalArea::new(
            cortical_id,
            0, // cortical_idx
            "Test Area".to_string(),
            CorticalAreaDimensions::new(10, 10, 1).unwrap(),
            (0, 0, 0).into(), // position
            cortical_type,
        )
        .unwrap();
        let cortical_idx = manager.add_cortical_area(area).unwrap();

        // Register the cortical area with the NPU using the cortical ID's base64 representation
        if let Some(npu_arc) = manager.get_npu() {
            if let Ok(mut npu_guard) = npu_arc.try_lock() {
                if let DynamicNPU::F32(ref mut npu) = *npu_guard {
                    npu.register_cortical_area(cortical_idx, cortical_id.as_base_64());
                }
            }
        }

        // Create two neurons
        let neuron1_id = manager
            .add_neuron(
                &cortical_id,
                0,
                0,
                0,     // coordinates
                100.0, // firing_threshold
                0.0,   // firing_threshold_limit (0 = no limit)
                0.1,   // leak_coefficient
                -60.0, // resting_potential
                0,     // neuron_type
                2,     // refractory_period
                1.0,   // excitability
                5,     // consecutive_fire_limit
                10,    // snooze_length
                false, // mp_charge_accumulation
            )
            .unwrap();

        let neuron2_id = manager
            .add_neuron(
                &cortical_id,
                1,
                0,
                0, // coordinates
                100.0,
                f32::MAX, // firing_threshold_limit (MAX = no limit, SIMD-friendly encoding)
                0.1,
                -60.0,
                0,
                2,
                1.0,
                5,
                10,
                false,
            )
            .unwrap();

        // Test create_synapse (creation should succeed)
        manager
            .create_synapse(
                neuron1_id, neuron2_id, 128.0, // weight
                64.0,  // psp
                0,     // excitatory
            )
            .unwrap();

        // Note: Synapse retrieval/update/removal tests require full NPU propagation engine initialization
        // which is beyond the scope of this unit test. The important part is that create_synapse succeeds.
        println!("✅ Synapse creation test passed");
    }

    #[test]
    fn test_apply_cortical_mapping_missing_rules_is_ok() {
        // This guards against a regression where deleting a mapping causes a 500 because
        // synapse regeneration treats "no mapping rules" as an error.
        let mut manager = ConnectomeManager::new_for_testing();

        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };

        let src_id = CorticalID::try_from_bytes(b"map_src_").unwrap();
        let dst_id = CorticalID::try_from_bytes(b"map_dst_").unwrap();

        let src_area = CorticalArea::new(
            src_id,
            0,
            "src".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();

        let dst_area = CorticalArea::new(
            dst_id,
            1,
            "dst".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainOutput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();

        manager.add_cortical_area(src_area).unwrap();
        manager.add_cortical_area(dst_area).unwrap();

        // No cortical_mapping_dst property set -> should be Ok(0), not an error
        let count = manager
            .apply_cortical_mapping_for_pair(&src_id, &dst_id)
            .unwrap();
        assert_eq!(count, 0);

        // Now create then delete mapping; missing destination rules should still be Ok(0)
        manager
            .update_cortical_mapping(
                &src_id,
                &dst_id,
                vec![serde_json::json!({"morphology_id":"m1"})],
            )
            .unwrap();
        manager
            .update_cortical_mapping(&src_id, &dst_id, vec![])
            .unwrap();

        let count2 = manager
            .apply_cortical_mapping_for_pair(&src_id, &dst_id)
            .unwrap();
        assert_eq!(count2, 0);
    }

    #[test]
    fn test_get_mapping_rules_for_destination_supports_legacy_key() {
        let dst_id = CorticalID::try_from_bytes(b"csrc0002").unwrap();
        let mapping_dst = serde_json::json!({
            "csrc0002": [
                {"morphology_id": "m1"}
            ]
        });
        let mapping_obj = mapping_dst.as_object().expect("mapping must be an object");

        let rules = ConnectomeManager::get_mapping_rules_for_destination(mapping_obj, &dst_id)
            .expect("legacy destination key should resolve");
        assert_eq!(rules.len(), 1);
        assert_eq!(
            rules[0].get("morphology_id").and_then(|v| v.as_str()),
            Some("m1")
        );
    }

    #[test]
    fn test_get_neuron_properties_always_includes_neuron_state_keys() {
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::RustNPU;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(
            feagi_npu_burst_engine::DynamicNPU::F32(npu),
            "TestNPU",
        ));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());

        let area_id = CorticalID::try_from_bytes(b"cst_nsp_").unwrap();
        let area = CorticalArea::new(
            area_id,
            0,
            "n".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();

        manager.add_cortical_area(area).unwrap();
        let nid = manager
            .add_neuron(
                &area_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false,
            )
            .unwrap();

        let props = manager
            .get_neuron_properties(nid)
            .expect("neuron properties");
        for key in [
            "consecutive_fire_count",
            "consecutive_fire_limit",
            "snooze_period",
            "membrane_potential",
            "threshold",
            "refractory_countdown",
            "mp_charge_accumulation",
            "neuron_type",
            "mp_driven_psp",
            "psp_uniform_distribution",
            "leak_coefficient",
            "resting_potential",
            "excitability",
            "threshold_limit",
            "refractory_period",
        ] {
            assert!(props.contains_key(key), "missing neuron state key: {key}");
        }
    }

    #[test]
    fn test_mapping_deletion_prunes_synapses_between_areas() {
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::RustNPU;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        use std::sync::Arc;

        // Create NPU and manager (small capacities for a deterministic unit test)
        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(
            feagi_npu_burst_engine::DynamicNPU::F32(npu),
            "TestNPU",
        ));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());

        // Create two cortical areas
        let src_id = CorticalID::try_from_bytes(b"cst_src_").unwrap();
        let dst_id = CorticalID::try_from_bytes(b"cst_dst_").unwrap();

        let src_area = CorticalArea::new(
            src_id,
            0,
            "src".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();
        let dst_area = CorticalArea::new(
            dst_id,
            1,
            "dst".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainOutput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();

        manager.add_cortical_area(src_area).unwrap();
        manager.add_cortical_area(dst_area).unwrap();

        // Add a couple neurons to each area
        let s0 = manager
            .add_neuron(&src_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        let s1 = manager
            .add_neuron(&src_id, 1, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        let t0 = manager
            .add_neuron(&dst_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        let t1 = manager
            .add_neuron(&dst_id, 1, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();

        // Create synapses that represent an established mapping between the two areas
        manager.create_synapse(s0, t0, 128.0, 200.0, 0).unwrap();
        manager.create_synapse(s1, t1, 128.0, 200.0, 0).unwrap();

        // Build index once before pruning
        {
            let mut npu = dyn_npu.lock().unwrap();
            npu.rebuild_synapse_index();
            assert_eq!(npu.get_synapse_count(), 2);
        }

        // Simulate mapping deletion and regeneration: should prune synapses and not re-add any
        manager
            .update_cortical_mapping(&src_id, &dst_id, vec![])
            .unwrap();
        let created = manager
            .regenerate_synapses_for_mapping(&src_id, &dst_id)
            .unwrap();
        assert_eq!(created, 0);

        // Verify synapses are gone (invalidated) and no outgoing synapses remain from the sources
        {
            let mut npu = dyn_npu.lock().unwrap();
            // Pruning invalidates synapses; rebuild the index so counts/outgoing queries reflect the current state.
            npu.rebuild_synapse_index();
            assert_eq!(npu.get_synapse_count(), 0);
            assert!(npu.get_outgoing_synapses(s0 as u32).is_empty());
            assert!(npu.get_outgoing_synapses(s1 as u32).is_empty());
        }
    }

    #[test]
    fn test_mapping_update_prunes_synapses_between_areas() {
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::RustNPU;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };
        use std::sync::Arc;

        // Create NPU and manager (small capacities for a deterministic unit test)
        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(
            feagi_npu_burst_engine::DynamicNPU::F32(npu),
            "TestNPU",
        ));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());

        // Seed core morphologies so mapping regeneration can resolve function morphologies (e.g. "episodic_memory").
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        // Create two cortical areas
        // Use valid custom cortical IDs (the `cst...` namespace).
        let src_id = CorticalID::try_from_bytes(b"cstupds1").unwrap();
        let dst_id = CorticalID::try_from_bytes(b"cstupdt1").unwrap();

        let src_area = CorticalArea::new(
            src_id,
            0,
            "src".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();
        let dst_area = CorticalArea::new(
            dst_id,
            0,
            "dst".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainOutput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();

        manager.add_cortical_area(src_area).unwrap();
        manager.add_cortical_area(dst_area).unwrap();

        // Add a couple neurons to each area
        let s0 = manager
            .add_neuron(&src_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        let s1 = manager
            .add_neuron(&src_id, 1, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        let t0 = manager
            .add_neuron(&dst_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        let t1 = manager
            .add_neuron(&dst_id, 1, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();

        // Create synapses that represent an established mapping between the two areas
        manager.create_synapse(s0, t0, 128.0, 200.0, 0).unwrap();
        manager.create_synapse(s1, t1, 128.0, 200.0, 0).unwrap();

        // Build index once before pruning
        {
            let mut npu = dyn_npu.lock().unwrap();
            npu.rebuild_synapse_index();
            assert_eq!(npu.get_synapse_count(), 2);
        }

        // Update mapping rules (non-empty) and regenerate.
        // This should prune the existing A→B synapses before re-applying the mapping.
        //
        // Use "episodic_memory" morphology to avoid creating physical synapses; the key assertion is that
        // the pre-existing synapses were pruned on update.
        manager
            .update_cortical_mapping(
                &src_id,
                &dst_id,
                vec![serde_json::json!({
                    "morphology_id": "episodic_memory",
                    "morphology_scalar": [1],
                    "postSynapticCurrent_multiplier": 1,
                    "plasticity_flag": false,
                    "plasticity_constant": 0,
                    "ltp_multiplier": 0,
                    "ltd_multiplier": 0,
                    "plasticity_window": 0,
                })],
            )
            .unwrap();
        let created = manager
            .regenerate_synapses_for_mapping(&src_id, &dst_id)
            .unwrap();
        assert_eq!(created, 0);

        // Verify synapses are gone and no outgoing synapses remain from the sources
        {
            let mut npu = dyn_npu.lock().unwrap();
            // Pruning invalidates synapses; rebuild the index so counts/outgoing queries reflect the current state.
            npu.rebuild_synapse_index();
            assert_eq!(npu.get_synapse_count(), 0);
            assert!(npu.get_outgoing_synapses(s0 as u32).is_empty());
            assert!(npu.get_outgoing_synapses(s1 as u32).is_empty());
        }
    }

    #[test]
    fn test_upstream_area_tracking() {
        // Test that upstream_cortical_areas property is maintained correctly
        use crate::models::cortical_area::CorticalArea;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID,
        };

        // Create test manager with NPU
        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());

        // Seed the morphology registry with core morphologies so mapping regeneration can run.
        // (new_for_testing_with_npu() intentionally starts empty.)
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        // Create source area
        let src_id = CorticalID::try_from_bytes(b"csrc0000").unwrap();
        let src_area = CorticalArea::new(
            src_id,
            0,
            "Source Area".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Custom(
                feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
            ),
        )
        .unwrap();
        let src_idx = manager.add_cortical_area(src_area).unwrap();

        // Create destination area (memory area)
        let dst_id = CorticalID::try_from_bytes(b"cdst0000").unwrap();
        let dst_area = CorticalArea::new(
            dst_id,
            0,
            "Dest Area".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Custom(
                feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
            ),
        )
        .unwrap();
        manager.add_cortical_area(dst_area).unwrap();

        // Verify upstream_cortical_areas property was initialized to empty array
        {
            let dst_area = manager.get_cortical_area(&dst_id).unwrap();
            let upstream = dst_area.properties.get("upstream_cortical_areas").unwrap();
            assert!(
                upstream.as_array().unwrap().is_empty(),
                "Upstream areas should be empty initially"
            );
        }

        // Create a mapping from src to dst
        let mapping_data = vec![serde_json::json!({
            "morphology_id": "episodic_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
        })];
        manager
            .update_cortical_mapping(&src_id, &dst_id, mapping_data)
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&src_id, &dst_id)
            .unwrap();

        // Verify src_idx was added to dst's upstream_cortical_areas
        {
            let upstream_areas = manager.get_upstream_cortical_areas(&dst_id);
            assert_eq!(upstream_areas.len(), 1, "Should have 1 upstream area");
            assert_eq!(
                upstream_areas[0], src_idx,
                "Upstream area should be src_idx"
            );
        }

        // Delete the mapping
        manager
            .update_cortical_mapping(&src_id, &dst_id, vec![])
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&src_id, &dst_id)
            .unwrap();

        // Verify src_idx was removed from dst's upstream_cortical_areas
        {
            let upstream_areas = manager.get_upstream_cortical_areas(&dst_id);
            assert_eq!(
                upstream_areas.len(),
                0,
                "Should have 0 upstream areas after deletion"
            );
        }
    }

    #[test]
    fn test_refresh_upstream_areas_for_associative_memory_pairs() {
        use crate::models::cortical_area::CorticalArea;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID, MemoryCorticalType,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        let a1_id = CorticalID::try_from_bytes(b"csrc0002").unwrap();
        let a2_id = CorticalID::try_from_bytes(b"csrc0003").unwrap();
        let m1_id = CorticalID::try_from_bytes(b"mmem0002").unwrap();
        let m2_id = CorticalID::try_from_bytes(b"mmem0003").unwrap();

        let a1_area = CorticalArea::new(
            a1_id,
            0,
            "A1".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Custom(
                feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
            ),
        )
        .unwrap();
        let a2_area = CorticalArea::new(
            a2_id,
            0,
            "A2".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Custom(
                feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
            ),
        )
        .unwrap();

        let mut m1_area = CorticalArea::new(
            m1_id,
            0,
            "M1".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        m1_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        m1_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        let mut m2_area = CorticalArea::new(
            m2_id,
            0,
            "M2".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        m2_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        m2_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        let a1_idx = manager.add_cortical_area(a1_area).unwrap();
        let a2_idx = manager.add_cortical_area(a2_area).unwrap();
        let m1_idx = manager.add_cortical_area(m1_area).unwrap();
        let m2_idx = manager.add_cortical_area(m2_area).unwrap();

        manager
            .add_neuron(&a1_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        manager
            .add_neuron(&a2_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();

        let episodic_mapping = vec![serde_json::json!({
            "morphology_id": "episodic_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
        })];
        manager
            .update_cortical_mapping(&a1_id, &m1_id, episodic_mapping.clone())
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&a1_id, &m1_id)
            .unwrap();
        manager
            .update_cortical_mapping(&a2_id, &m2_id, episodic_mapping)
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&a2_id, &m2_id)
            .unwrap();

        let assoc_mapping = vec![serde_json::json!({
            "morphology_id": "associative_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
            "plasticity_flag": true,
            "plasticity_constant": 1,
            "ltp_multiplier": 1,
            "ltd_multiplier": 1,
            "plasticity_window": 5,
        })];
        manager
            .update_cortical_mapping(&m1_id, &m2_id, assoc_mapping.clone())
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&m1_id, &m2_id)
            .unwrap();
        // Second directed edge (bidirectional link is two explicit mappings, not auto-mirror).
        manager
            .update_cortical_mapping(&m2_id, &m1_id, assoc_mapping)
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&m2_id, &m1_id)
            .unwrap();

        let upstream_m1 = manager.get_upstream_cortical_areas(&m1_id);
        let upstream_m2 = manager.get_upstream_cortical_areas(&m2_id);
        assert_eq!(
            upstream_m1.len(),
            2,
            "M1 should have A1 and M2 as upstreams once both directed associative edges exist"
        );
        assert_eq!(
            upstream_m2.len(),
            2,
            "M2 should have A2 and M1 as upstreams"
        );

        manager.refresh_upstream_cortical_areas_from_mappings(&m1_id);
        manager.refresh_upstream_cortical_areas_from_mappings(&m2_id);

        let upstream_m1 = manager.get_upstream_cortical_areas(&m1_id);
        let upstream_m2 = manager.get_upstream_cortical_areas(&m2_id);
        assert_eq!(upstream_m1.len(), 2, "M1 upstreams unchanged after refresh");
        assert_eq!(upstream_m2.len(), 2, "M2 upstreams unchanged after refresh");
        assert!(upstream_m1.contains(&a1_idx));
        assert!(upstream_m1.contains(&m2_idx));
        assert!(upstream_m2.contains(&a2_idx));
        assert!(upstream_m2.contains(&m1_idx));

        // Fire upstream neurons and ensure burst processing works without altering upstream tracking.
        {
            let mut npu_lock = dyn_npu.lock().unwrap();
            let injected_a1 = npu_lock.inject_sensory_xyzp_by_id(&a1_id, &[(0, 0, 0, 1.0)]);
            let injected_a2 = npu_lock.inject_sensory_xyzp_by_id(&a2_id, &[(0, 0, 0, 1.0)]);
            assert_eq!(injected_a1, 1, "Expected A1 injection to match one neuron");
            assert_eq!(injected_a2, 1, "Expected A2 injection to match one neuron");
            npu_lock.process_burst().expect("Burst processing failed");
        }

        let upstream_m1 = manager.get_upstream_cortical_areas(&m1_id);
        let upstream_m2 = manager.get_upstream_cortical_areas(&m2_id);
        assert_eq!(
            upstream_m1.len(),
            2,
            "M1 should keep 2 upstreams after firing"
        );
        assert_eq!(
            upstream_m2.len(),
            2,
            "M2 should keep 2 upstreams after firing"
        );
    }

    #[test]
    fn test_memory_twin_created_for_memory_mapping() {
        use crate::models::cortical_area::CorticalArea;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID, IOCorticalAreaConfigurationFlag,
            MemoryCorticalType,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        let src_id = CorticalID::try_from_bytes(b"csrc0001").unwrap();
        let dst_id = CorticalID::try_from_bytes(b"mmem0001").unwrap();

        let src_area = CorticalArea::new(
            src_id,
            0,
            "Source Area".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();
        let mut dst_area = CorticalArea::new(
            dst_id,
            0,
            "Memory Area".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        dst_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        dst_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        manager.add_cortical_area(src_area).unwrap();
        manager.add_cortical_area(dst_area).unwrap();

        let mapping_data = vec![serde_json::json!({
            "morphology_id": "episodic_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
        })];
        manager
            .update_cortical_mapping(&src_id, &dst_id, mapping_data)
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&src_id, &dst_id)
            .unwrap();

        let memory_area = manager.get_cortical_area(&dst_id).unwrap();
        let twin_map = memory_area
            .properties
            .get("memory_twin_areas")
            .and_then(|v| v.as_object())
            .expect("memory_twin_areas should be set");
        let twin_id_str = twin_map
            .get(&src_id.as_base_64())
            .and_then(|v| v.as_str())
            .expect("Missing twin entry for upstream area");
        let twin_id = CorticalID::try_from_base_64(twin_id_str).unwrap();
        let mapping = memory_area
            .properties
            .get("cortical_mapping_dst")
            .and_then(|v| v.as_object())
            .and_then(|map| map.get(&twin_id.as_base_64()))
            .and_then(|v| v.as_array())
            .expect("Missing memory replay mapping for twin area");
        let uses_replay = mapping.iter().any(|rule| {
            rule.get("morphology_id")
                .and_then(|v| v.as_str())
                .is_some_and(|id| id == "memory_replay")
        });
        assert!(uses_replay, "Expected memory_replay mapping for twin area");

        let twin_area = manager.get_cortical_area(&twin_id).unwrap();
        assert!(matches!(
            twin_area.cortical_type,
            CorticalAreaType::Custom(_)
        ));
        assert_eq!(
            twin_area
                .properties
                .get("memory_twin_of")
                .and_then(|v| v.as_str()),
            Some(src_id.as_base_64().as_str())
        );
        assert_eq!(
            twin_area
                .properties
                .get("memory_twin_for")
                .and_then(|v| v.as_str()),
            Some(dst_id.as_base_64().as_str())
        );
    }

    #[test]
    fn test_associative_memory_between_memory_areas_creates_synapses() {
        use crate::models::cortical_area::CorticalArea;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID, MemoryCorticalType,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        let m1_id = CorticalID::try_from_bytes(b"mmem0402").unwrap();
        let m2_id = CorticalID::try_from_bytes(b"mmem0403").unwrap();

        let mut m1_area = CorticalArea::new(
            m1_id,
            0,
            "Memory M1".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        m1_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        m1_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        let mut m2_area = CorticalArea::new(
            m2_id,
            0,
            "Memory M2".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        m2_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        m2_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        manager.add_cortical_area(m1_area).unwrap();
        manager.add_cortical_area(m2_area).unwrap();

        manager
            .add_neuron(&m1_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();
        manager
            .add_neuron(&m2_id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
            .unwrap();

        let mapping_data = vec![serde_json::json!({
            "morphology_id": "associative_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
            "plasticity_flag": true,
            "plasticity_constant": 1,
            "ltp_multiplier": 1,
            "ltd_multiplier": 1,
            "plasticity_window": 5,
        })];
        manager
            .update_cortical_mapping(&m1_id, &m2_id, mapping_data)
            .unwrap();
        let created = manager
            .regenerate_synapses_for_mapping(&m1_id, &m2_id)
            .unwrap();
        assert!(
            created > 0,
            "Expected associative memory mapping between memory areas to create synapses"
        );
        let npu_guard = dyn_npu.lock().unwrap();
        let assoc_tagged =
            npu_guard.count_synapses_with_edge_flag_bits(SYNAPSE_EDGE_ASSOCIATIVE_MEMORY);
        assert!(
            assoc_tagged >= 1,
            "associative_memory connectome path should stamp SYNAPSE_EDGE_ASSOCIATIVE_MEMORY on created synapses"
        );
    }

    #[test]
    fn test_memory_twin_repair_on_load_preserves_replay_mapping() {
        use crate::models::cortical_area::CorticalArea;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID, IOCorticalAreaConfigurationFlag,
            MemoryCorticalType,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        let src_id = CorticalID::try_from_bytes(b"csrc0002").unwrap();
        let mem_id = CorticalID::try_from_bytes(b"mmem0002").unwrap();

        let src_area = CorticalArea::new(
            src_id,
            0,
            "Source Area".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();
        let mut mem_area = CorticalArea::new(
            mem_id,
            0,
            "Memory Area".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        mem_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        mem_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        manager.add_cortical_area(src_area).unwrap();
        manager.add_cortical_area(mem_area).unwrap();

        let twin_id = manager
            .build_memory_twin_id(&mem_id, &src_id)
            .expect("Failed to build twin id");
        let twin_area = CorticalArea::new(
            twin_id,
            0,
            "Source Area_twin".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Custom(
                feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
            ),
        )
        .unwrap();
        manager.add_cortical_area(twin_area).unwrap();

        let repaired = manager
            .ensure_memory_twin_area(&mem_id, &src_id)
            .expect("Failed to repair twin");
        assert_eq!(repaired, twin_id);

        let mem_area = manager.get_cortical_area(&mem_id).unwrap();
        let twin_map = mem_area
            .properties
            .get("memory_twin_areas")
            .and_then(|v| v.as_object())
            .expect("memory_twin_areas should be set");
        let twin_id_str = twin_map
            .get(&src_id.as_base_64())
            .and_then(|v| v.as_str())
            .expect("Missing twin entry for upstream area");
        assert_eq!(twin_id_str, twin_id.as_base_64());

        let replay_map = mem_area
            .properties
            .get("cortical_mapping_dst")
            .and_then(|v| v.as_object())
            .and_then(|map| map.get(&twin_id.as_base_64()))
            .and_then(|v| v.as_array())
            .expect("Missing memory replay mapping for twin area");
        let uses_replay = replay_map.iter().any(|rule| {
            rule.get("morphology_id")
                .and_then(|v| v.as_str())
                .is_some_and(|id| id == "memory_replay")
        });
        assert!(uses_replay, "Expected memory_replay mapping for twin area");

        let twin_area = manager.get_cortical_area(&twin_id).unwrap();
        assert_eq!(
            twin_area
                .properties
                .get("memory_twin_of")
                .and_then(|v| v.as_str()),
            Some(src_id.as_base_64().as_str())
        );
        assert_eq!(
            twin_area
                .properties
                .get("memory_twin_for")
                .and_then(|v| v.as_str()),
            Some(mem_id.as_base_64().as_str())
        );
    }

    #[test]
    fn test_memory_twin_inherits_upstream_parent_region() {
        use crate::models::cortical_area::CorticalArea;
        use crate::models::BrainRegion;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::brain_regions::{RegionID, RegionType};
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID, IOCorticalAreaConfigurationFlag,
            MemoryCorticalType,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);
        let src_region_id = RegionID::new();
        let src_region_id_str = src_region_id.to_string();
        manager
            .add_brain_region(
                BrainRegion::new(
                    src_region_id,
                    "Src Region".to_string(),
                    RegionType::Undefined,
                )
                .unwrap(),
                None,
            )
            .unwrap();
        let mem_region_id = RegionID::new();
        let mem_region_id_str = mem_region_id.to_string();
        manager
            .add_brain_region(
                BrainRegion::new(
                    mem_region_id,
                    "Mem Region".to_string(),
                    RegionType::Undefined,
                )
                .unwrap(),
                None,
            )
            .unwrap();

        let src_id = CorticalID::try_from_bytes(b"csrc1001").unwrap();
        let mem_id = CorticalID::try_from_bytes(b"mmem1001").unwrap();

        let mut src_area = CorticalArea::new(
            src_id,
            0,
            "Origin".to_string(),
            CorticalAreaDimensions::new(4, 4, 1).unwrap(),
            (10, 20, 0).into(),
            CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
        )
        .unwrap();
        src_area.properties.insert(
            "parent_region_id".to_string(),
            serde_json::json!(src_region_id_str.clone()),
        );

        let mut mem_area = CorticalArea::new(
            mem_id,
            0,
            "Memory".to_string(),
            CorticalAreaDimensions::new(2, 2, 1).unwrap(),
            (200, 300, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        mem_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        mem_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));
        mem_area.properties.insert(
            "parent_region_id".to_string(),
            serde_json::json!(mem_region_id_str.clone()),
        );

        manager.add_cortical_area(src_area).unwrap();
        manager.add_cortical_area(mem_area).unwrap();

        let mapping_data = vec![serde_json::json!({
            "morphology_id": "episodic_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
        })];
        manager
            .update_cortical_mapping(&src_id, &mem_id, mapping_data)
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&src_id, &mem_id)
            .unwrap();

        let memory_area = manager.get_cortical_area(&mem_id).unwrap();
        let twin_map = memory_area
            .properties
            .get("memory_twin_areas")
            .and_then(|v| v.as_object())
            .expect("memory_twin_areas should be set");
        let twin_id = CorticalID::try_from_base_64(
            twin_map
                .get(&src_id.as_base_64())
                .and_then(|v| v.as_str())
                .expect("missing twin for source"),
        )
        .unwrap();
        let twin_area = manager.get_cortical_area(&twin_id).unwrap();

        assert_eq!(
            twin_area
                .properties
                .get("parent_region_id")
                .and_then(|v| v.as_str()),
            Some(src_region_id_str.as_str()),
            "Twin should inherit upstream/source parent region"
        );
        assert_ne!(
            twin_area
                .properties
                .get("parent_region_id")
                .and_then(|v| v.as_str()),
            Some(mem_region_id_str.as_str()),
            "Twin must not inherit memory area's parent region"
        );
    }

    #[test]
    fn test_memory_twin_diagnostic_explains_memory_upstream_blocker() {
        use crate::models::cortical_area::CorticalArea;
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaDimensions, CorticalAreaType, CorticalID, MemoryCorticalType,
        };
        use std::sync::Arc;

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("Failed to create NPU");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut manager = ConnectomeManager::new_for_testing_with_npu(dyn_npu.clone());
        feagi_evolutionary::templates::add_core_morphologies(&mut manager.morphology_registry);

        let m1_id = CorticalID::try_from_bytes(b"mmem2001").unwrap();
        let m2_id = CorticalID::try_from_bytes(b"mmem2002").unwrap();

        let mut m1_area = CorticalArea::new(
            m1_id,
            0,
            "Memory A".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        m1_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        m1_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        let mut m2_area = CorticalArea::new(
            m2_id,
            0,
            "Memory B".to_string(),
            CorticalAreaDimensions::new(1, 1, 1).unwrap(),
            (0, 0, 0).into(),
            CorticalAreaType::Memory(MemoryCorticalType::Memory),
        )
        .unwrap();
        m2_area
            .properties
            .insert("is_mem_type".to_string(), serde_json::json!(true));
        m2_area
            .properties
            .insert("temporal_depth".to_string(), serde_json::json!(1));

        manager.add_cortical_area(m1_area).unwrap();
        manager.add_cortical_area(m2_area).unwrap();

        let mapping_data = vec![serde_json::json!({
            "morphology_id": "episodic_memory",
            "morphology_scalar": 1,
            "postSynapticCurrent_multiplier": 1.0,
        })];
        manager
            .update_cortical_mapping(&m1_id, &m2_id, mapping_data)
            .unwrap();
        manager
            .regenerate_synapses_for_mapping(&m1_id, &m2_id)
            .unwrap();

        let diagnostic = manager
            .diagnose_memory_twin_for_mapping(&m1_id, &m2_id)
            .expect("diagnostic should succeed");
        assert!(diagnostic.mapping_exists);
        assert_eq!(diagnostic.episodic_rule_count, 1);
        assert!(!diagnostic.twin_expected);
        assert!(!diagnostic.twin_present);
        assert_eq!(
            diagnostic.reason.as_deref(),
            Some("upstream_is_memory_area_twin_not_supported")
        );
    }

    /// Helper for the `max_weight` validation tests below: stand up a minimal connectome with
    /// a plastic mapping `src -> dst` plus the two detector areas required for R-STDP rules.
    /// Returns the manager (so individual tests can drive `update_cortical_mapping` against
    /// it) along with the four cortical IDs in (src, dst, reward, pain) order.
    fn build_max_weight_test_manager() -> (
        ConnectomeManager,
        CorticalID,
        CorticalID,
        CorticalID,
        CorticalID,
    ) {
        use feagi_npu_burst_engine::backend::CPUBackend;
        use feagi_npu_burst_engine::TracingMutex;
        use feagi_npu_burst_engine::{DynamicNPU, RustNPU};
        use feagi_npu_runtime::StdRuntime;
        use feagi_structures::genomic::cortical_area::{
            CorticalAreaType, IOCorticalAreaConfigurationFlag,
        };

        let runtime = StdRuntime;
        let backend = CPUBackend::new();
        let npu = RustNPU::new(runtime, backend, 10_000, 10_000, 10).expect("npu");
        let dyn_npu = Arc::new(TracingMutex::new(DynamicNPU::F32(npu), "TestNPU"));
        let mut mgr = ConnectomeManager::new_for_testing_with_npu(dyn_npu);
        // Seed the core morphology registry; `all_to_all` is the simplest plastic morphology
        // available and is required to exercise the STDP rule parser path in
        // `regenerate_synapses_for_mapping`.
        feagi_evolutionary::templates::add_core_morphologies(&mut mgr.morphology_registry);

        let src = CorticalID::try_from_bytes(b"cstmwsrc").unwrap();
        let dst = CorticalID::try_from_bytes(b"cstmwdst").unwrap();
        let reward = CorticalID::try_from_bytes(b"cstmwrwd").unwrap();
        let pain = CorticalID::try_from_bytes(b"cstmwpan").unwrap();

        for (id, label, kind) in [
            (
                src,
                "src",
                CorticalAreaType::BrainInput(IOCorticalAreaConfigurationFlag::Boolean),
            ),
            (
                dst,
                "dst",
                CorticalAreaType::BrainOutput(IOCorticalAreaConfigurationFlag::Boolean),
            ),
            (
                reward,
                "reward",
                CorticalAreaType::Custom(
                    feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
                ),
            ),
            (
                pain,
                "pain",
                CorticalAreaType::Custom(
                    feagi_structures::genomic::cortical_area::CustomCorticalType::LeakyIntegrateFire,
                ),
            ),
        ] {
            mgr.add_cortical_area(
                CorticalArea::new(
                    id,
                    0,
                    label.to_string(),
                    CorticalAreaDimensions::new(1, 1, 1).unwrap(),
                    (0, 0, 0).into(),
                    kind,
                )
                .unwrap(),
            )
            .unwrap();
            mgr.add_neuron(&id, 0, 0, 0, 1.0, 0.0, 0.1, 0.0, 0, 1, 1.0, 3, 1, false)
                .unwrap();
        }
        (mgr, src, dst, reward, pain)
    }

    /// Drive the full BDU mapping pipeline (store rules then regenerate synapses, which is
    /// where the STDP rule parser actually runs) so the validation tests below exercise the
    /// same code path as a `PUT /v1/cortical_mapping/mapping_properties` followed by the
    /// regeneration step kicked off by the connectome service.
    fn write_and_regenerate_mapping(
        mgr: &mut ConnectomeManager,
        src: &CorticalID,
        dst: &CorticalID,
        rule: serde_json::Value,
    ) -> BduResult<usize> {
        mgr.update_cortical_mapping(src, dst, vec![rule])?;
        mgr.regenerate_synapses_for_mapping(src, dst)
    }

    /// Acceptance test: an R-STDP mapping rule with a finite, positive `max_weight` parses
    /// cleanly through the BDU pipeline used by `PUT /v1/cortical_mapping/mapping_properties`
    /// + the post-write regeneration step.
    #[test]
    fn test_max_weight_finite_positive_accepted_on_rstdp_rule() {
        let (mut mgr, src, dst, reward, pain) = build_max_weight_test_manager();

        let result = write_and_regenerate_mapping(
            &mut mgr,
            &src,
            &dst,
            serde_json::json!({
                "morphology_id": "block_to_block",
                "morphology_scalar": [1, 1, 1],
                "postSynapticCurrent_multiplier": 1,
                "plasticity_flag": true,
                "plasticity_constant": 1,
                "ltp_multiplier": 1,
                "ltd_multiplier": 1,
                "plasticity_window": 10,
                "synaptic_delay_bursts": 1,
                "plasticity_mode": "rstdp",
                "eligibility_decay_bursts": 50,
                "reward_source_area": reward.as_base_64(),
                "punishment_source_area": pain.as_base_64(),
                "max_weight": 12.5,
            }),
        );
        assert!(
            result.is_ok(),
            "valid max_weight=12.5 must be accepted, got {:?}",
            result
        );
    }

    /// Validation test: zero, negative, and non-numeric `max_weight` values must be rejected
    /// at parse time so the runtime never sees a malformed sentinel. (`NaN` and `Infinity`
    /// cannot appear in valid JSON -- `serde_json::json!(f64::NAN)` already serializes to
    /// `Null` -- so we cover the in-band wrong-type case via a string instead.)
    #[test]
    fn test_max_weight_invalid_values_rejected() {
        for bad in &[
            serde_json::json!(0.0),
            serde_json::json!(-1.5),
            serde_json::json!("not_a_number"),
        ] {
            let (mut mgr, src, dst, reward, pain) = build_max_weight_test_manager();
            let result = write_and_regenerate_mapping(
                &mut mgr,
                &src,
                &dst,
                serde_json::json!({
                    "morphology_id": "block_to_block",
                    "morphology_scalar": [1, 1, 1],
                    "postSynapticCurrent_multiplier": 1,
                    "plasticity_flag": true,
                    "plasticity_constant": 1,
                    "ltp_multiplier": 1,
                    "ltd_multiplier": 1,
                    "plasticity_window": 10,
                    "synaptic_delay_bursts": 1,
                    "plasticity_mode": "rstdp",
                    "eligibility_decay_bursts": 50,
                    "reward_source_area": reward.as_base_64(),
                    "punishment_source_area": pain.as_base_64(),
                    "max_weight": bad,
                }),
            );
            assert!(
                result.is_err(),
                "max_weight={:?} should have been rejected, got {:?}",
                bad,
                result
            );
        }
    }

    /// `ltp_multiplier` / `ltd_multiplier` are stored as `i8` in the NPU; values outside
    /// `-128..=127` must fail at BDU parse time.
    #[test]
    fn test_ltp_ltd_multiplier_out_of_i8_range_rejected() {
        let (mut mgr, src, dst, reward, pain) = build_max_weight_test_manager();
        let result = write_and_regenerate_mapping(
            &mut mgr,
            &src,
            &dst,
            serde_json::json!({
                "morphology_id": "block_to_block",
                "morphology_scalar": [1, 1, 1],
                "postSynapticCurrent_multiplier": 1,
                "plasticity_flag": true,
                "plasticity_constant": 1,
                "ltp_multiplier": 200,
                "ltd_multiplier": 1,
                "plasticity_window": 10,
                "synaptic_delay_bursts": 1,
                "plasticity_mode": "rstdp",
                "eligibility_decay_bursts": 50,
                "reward_source_area": reward.as_base_64(),
                "punishment_source_area": pain.as_base_64(),
            }),
        );
        assert!(
            result.is_err(),
            "ltp_multiplier=200 must be rejected (i8 range); got {:?}",
            result
        );
    }

    /// Validation test: setting an explicit `max_weight` on an off-mode (non-plastic) rule
    /// is meaningless and must surface as a clear error instead of being silently ignored.
    #[test]
    fn test_max_weight_rejected_when_plasticity_off() {
        let (mut mgr, src, dst, _reward, _pain) = build_max_weight_test_manager();

        let result = write_and_regenerate_mapping(
            &mut mgr,
            &src,
            &dst,
            serde_json::json!({
                "morphology_id": "block_to_block",
                "morphology_scalar": [1, 1, 1],
                "postSynapticCurrent_multiplier": 1,
                // `plasticity_flag: true` is required to enter the rule-parsing branch in
                // `regenerate_synapses_for_mapping`; the off-mode validation is then driven
                // by the explicit `plasticity_mode: "off"` selector below, which is the
                // canonical successor of the legacy boolean flag.
                "plasticity_flag": true,
                "plasticity_constant": 0,
                "ltp_multiplier": 0,
                "ltd_multiplier": 0,
                "plasticity_window": 0,
                "synaptic_delay_bursts": 1,
                "plasticity_mode": "off",
                "max_weight": 10.0,
            }),
        );
        assert!(
            result.is_err(),
            "max_weight on off-mode rule must be rejected; got {:?}",
            result
        );
    }

    #[test]
    fn test_plasticity_eta_rejected_when_plasticity_off() {
        let (mut mgr, src, dst, _reward, _pain) = build_max_weight_test_manager();

        let result = write_and_regenerate_mapping(
            &mut mgr,
            &src,
            &dst,
            serde_json::json!({
                "morphology_id": "block_to_block",
                "morphology_scalar": [1, 1, 1],
                "postSynapticCurrent_multiplier": 1,
                "plasticity_flag": true,
                "plasticity_constant": 0,
                "ltp_multiplier": 0,
                "ltd_multiplier": 0,
                "plasticity_window": 0,
                "synaptic_delay_bursts": 1,
                "plasticity_mode": "off",
                "plasticity_eta": 0.5,
            }),
        );
        assert!(
            result.is_err(),
            "plasticity_eta on off-mode rule must be rejected; got {:?}",
            result
        );
    }

    #[test]
    fn test_plasticity_eta_non_positive_rejected() {
        let (mut mgr, src, dst, reward, pain) = build_max_weight_test_manager();

        let result = write_and_regenerate_mapping(
            &mut mgr,
            &src,
            &dst,
            serde_json::json!({
                "morphology_id": "block_to_block",
                "morphology_scalar": [1, 1, 1],
                "postSynapticCurrent_multiplier": 1,
                "plasticity_flag": true,
                "plasticity_constant": 1,
                "ltp_multiplier": 1,
                "ltd_multiplier": 1,
                "plasticity_window": 10,
                "synaptic_delay_bursts": 1,
                "plasticity_mode": "rstdp",
                "eligibility_decay_bursts": 50,
                "reward_source_area": reward.as_base_64(),
                "punishment_source_area": pain.as_base_64(),
                "plasticity_eta": 0.0,
            }),
        );
        assert!(
            result.is_err(),
            "plasticity_eta=0 must be rejected; got {:?}",
            result
        );
    }
}