fallow_config/config/
rules.rs

1use schemars::JsonSchema;
2use serde::{Deserialize, Serialize};
3
4/// Severity level for rules.
5///
6/// Controls whether an issue type causes CI failure (`error`), is reported
7/// without failing (`warn`), or is suppressed entirely (`off`).
8#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Deserialize, Serialize, JsonSchema)]
9#[serde(rename_all = "lowercase")]
10pub enum Severity {
11    /// Report and fail CI (non-zero exit code).
12    #[default]
13    Error,
14    /// Report but don't fail CI.
15    Warn,
16    /// Don't detect or report.
17    Off,
18}
19
20impl Severity {
21    /// Default value for fields that should default to `Warn` instead of `Error`.
22    const fn default_warn() -> Self {
23        Self::Warn
24    }
25
26    /// Default value for fields that should default to `Off`.
27    const fn default_off() -> Self {
28        Self::Off
29    }
30}
31
32impl std::fmt::Display for Severity {
33    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
34        match self {
35            Self::Error => write!(f, "error"),
36            Self::Warn => write!(f, "warn"),
37            Self::Off => write!(f, "off"),
38        }
39    }
40}
41
42impl std::str::FromStr for Severity {
43    type Err = String;
44
45    fn from_str(s: &str) -> Result<Self, Self::Err> {
46        match s.to_lowercase().as_str() {
47            "error" => Ok(Self::Error),
48            "warn" | "warning" => Ok(Self::Warn),
49            "off" | "none" => Ok(Self::Off),
50            other => Err(format!(
51                "unknown severity: '{other}' (expected error, warn, or off)"
52            )),
53        }
54    }
55}
56
57/// Per-issue-type severity configuration.
58///
59/// Controls which issue types cause CI failure, are reported as warnings,
60/// or are suppressed entirely. Most fields default to `Severity::Error`.
61///
62/// Rule names use kebab-case in config files (e.g., `"unused-files": "error"`).
63#[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)]
64#[serde(rename_all = "kebab-case")]
65pub struct RulesConfig {
66    #[serde(default, alias = "unused-file")]
67    pub unused_files: Severity,
68    #[serde(default, alias = "unused-export")]
69    pub unused_exports: Severity,
70    #[serde(default, alias = "unused-type")]
71    pub unused_types: Severity,
72    #[serde(default = "Severity::default_off", alias = "private-type-leak")]
73    pub private_type_leaks: Severity,
74    #[serde(default, alias = "unused-dependency")]
75    pub unused_dependencies: Severity,
76    #[serde(default = "Severity::default_warn", alias = "unused-dev-dependency")]
77    pub unused_dev_dependencies: Severity,
78    #[serde(
79        default = "Severity::default_warn",
80        alias = "unused-optional-dependency"
81    )]
82    pub unused_optional_dependencies: Severity,
83    #[serde(default, alias = "unused-enum-member")]
84    pub unused_enum_members: Severity,
85    #[serde(default, alias = "unused-class-member")]
86    pub unused_class_members: Severity,
87    #[serde(default, alias = "unresolved-import")]
88    pub unresolved_imports: Severity,
89    #[serde(default, alias = "unlisted-dependency")]
90    pub unlisted_dependencies: Severity,
91    #[serde(default, alias = "duplicate-export")]
92    pub duplicate_exports: Severity,
93    #[serde(default = "Severity::default_warn", alias = "type-only-dependency")]
94    pub type_only_dependencies: Severity,
95    #[serde(default = "Severity::default_warn", alias = "test-only-dependency")]
96    pub test_only_dependencies: Severity,
97    #[serde(default, alias = "circular-dependency")]
98    pub circular_dependencies: Severity,
99    #[serde(default, alias = "boundary-violations")]
100    pub boundary_violation: Severity,
101    #[serde(default, alias = "coverage-gap")]
102    pub coverage_gaps: Severity,
103    #[serde(default = "Severity::default_off", alias = "feature-flag")]
104    pub feature_flags: Severity,
105    #[serde(default = "Severity::default_warn", alias = "stale-suppression")]
106    pub stale_suppressions: Severity,
107    #[serde(default = "Severity::default_warn", alias = "unused-catalog-entry")]
108    pub unused_catalog_entries: Severity,
109    #[serde(default, alias = "unresolved-catalog-reference")]
110    pub unresolved_catalog_references: Severity,
111    #[serde(
112        default = "Severity::default_warn",
113        alias = "unused-dependency-override"
114    )]
115    pub unused_dependency_overrides: Severity,
116    #[serde(default, alias = "misconfigured-dependency-override")]
117    pub misconfigured_dependency_overrides: Severity,
118}
119
120impl Default for RulesConfig {
121    fn default() -> Self {
122        Self {
123            unused_files: Severity::Error,
124            unused_exports: Severity::Error,
125            unused_types: Severity::Error,
126            private_type_leaks: Severity::Off,
127            unused_dependencies: Severity::Error,
128            unused_dev_dependencies: Severity::Warn,
129            unused_optional_dependencies: Severity::Warn,
130            unused_enum_members: Severity::Error,
131            unused_class_members: Severity::Error,
132            unresolved_imports: Severity::Error,
133            unlisted_dependencies: Severity::Error,
134            duplicate_exports: Severity::Error,
135            type_only_dependencies: Severity::Warn,
136            test_only_dependencies: Severity::Warn,
137            circular_dependencies: Severity::Error,
138            boundary_violation: Severity::Error,
139            coverage_gaps: Severity::Off,
140            feature_flags: Severity::Off,
141            stale_suppressions: Severity::Warn,
142            unused_catalog_entries: Severity::Warn,
143            unresolved_catalog_references: Severity::Error,
144            unused_dependency_overrides: Severity::Warn,
145            misconfigured_dependency_overrides: Severity::Error,
146        }
147    }
148}
149
150impl RulesConfig {
151    /// Apply a partial rules config on top. Only `Some` fields override.
152    pub const fn apply_partial(&mut self, partial: &PartialRulesConfig) {
153        if let Some(s) = partial.unused_files {
154            self.unused_files = s;
155        }
156        if let Some(s) = partial.unused_exports {
157            self.unused_exports = s;
158        }
159        if let Some(s) = partial.unused_types {
160            self.unused_types = s;
161        }
162        if let Some(s) = partial.private_type_leaks {
163            self.private_type_leaks = s;
164        }
165        if let Some(s) = partial.unused_dependencies {
166            self.unused_dependencies = s;
167        }
168        if let Some(s) = partial.unused_dev_dependencies {
169            self.unused_dev_dependencies = s;
170        }
171        if let Some(s) = partial.unused_optional_dependencies {
172            self.unused_optional_dependencies = s;
173        }
174        if let Some(s) = partial.unused_enum_members {
175            self.unused_enum_members = s;
176        }
177        if let Some(s) = partial.unused_class_members {
178            self.unused_class_members = s;
179        }
180        if let Some(s) = partial.unresolved_imports {
181            self.unresolved_imports = s;
182        }
183        if let Some(s) = partial.unlisted_dependencies {
184            self.unlisted_dependencies = s;
185        }
186        if let Some(s) = partial.duplicate_exports {
187            self.duplicate_exports = s;
188        }
189        if let Some(s) = partial.type_only_dependencies {
190            self.type_only_dependencies = s;
191        }
192        if let Some(s) = partial.test_only_dependencies {
193            self.test_only_dependencies = s;
194        }
195        if let Some(s) = partial.circular_dependencies {
196            self.circular_dependencies = s;
197        }
198        if let Some(s) = partial.boundary_violation {
199            self.boundary_violation = s;
200        }
201        if let Some(s) = partial.coverage_gaps {
202            self.coverage_gaps = s;
203        }
204        if let Some(s) = partial.feature_flags {
205            self.feature_flags = s;
206        }
207        if let Some(s) = partial.stale_suppressions {
208            self.stale_suppressions = s;
209        }
210        if let Some(s) = partial.unused_catalog_entries {
211            self.unused_catalog_entries = s;
212        }
213        if let Some(s) = partial.unresolved_catalog_references {
214            self.unresolved_catalog_references = s;
215        }
216        if let Some(s) = partial.unused_dependency_overrides {
217            self.unused_dependency_overrides = s;
218        }
219        if let Some(s) = partial.misconfigured_dependency_overrides {
220            self.misconfigured_dependency_overrides = s;
221        }
222    }
223}
224
225/// Partial per-issue-type severity for overrides. All fields optional.
226#[derive(Debug, Default, Clone, Deserialize, Serialize, JsonSchema)]
227#[serde(rename_all = "kebab-case")]
228pub struct PartialRulesConfig {
229    #[serde(
230        default,
231        alias = "unused-file",
232        skip_serializing_if = "Option::is_none"
233    )]
234    pub unused_files: Option<Severity>,
235    #[serde(
236        default,
237        alias = "unused-export",
238        skip_serializing_if = "Option::is_none"
239    )]
240    pub unused_exports: Option<Severity>,
241    #[serde(
242        default,
243        alias = "unused-type",
244        skip_serializing_if = "Option::is_none"
245    )]
246    pub unused_types: Option<Severity>,
247    #[serde(
248        default,
249        alias = "private-type-leak",
250        skip_serializing_if = "Option::is_none"
251    )]
252    pub private_type_leaks: Option<Severity>,
253    #[serde(
254        default,
255        alias = "unused-dependency",
256        skip_serializing_if = "Option::is_none"
257    )]
258    pub unused_dependencies: Option<Severity>,
259    #[serde(
260        default,
261        alias = "unused-dev-dependency",
262        skip_serializing_if = "Option::is_none"
263    )]
264    pub unused_dev_dependencies: Option<Severity>,
265    #[serde(
266        default,
267        alias = "unused-optional-dependency",
268        skip_serializing_if = "Option::is_none"
269    )]
270    pub unused_optional_dependencies: Option<Severity>,
271    #[serde(
272        default,
273        alias = "unused-enum-member",
274        skip_serializing_if = "Option::is_none"
275    )]
276    pub unused_enum_members: Option<Severity>,
277    #[serde(
278        default,
279        alias = "unused-class-member",
280        skip_serializing_if = "Option::is_none"
281    )]
282    pub unused_class_members: Option<Severity>,
283    #[serde(
284        default,
285        alias = "unresolved-import",
286        skip_serializing_if = "Option::is_none"
287    )]
288    pub unresolved_imports: Option<Severity>,
289    #[serde(
290        default,
291        alias = "unlisted-dependency",
292        skip_serializing_if = "Option::is_none"
293    )]
294    pub unlisted_dependencies: Option<Severity>,
295    #[serde(
296        default,
297        alias = "duplicate-export",
298        skip_serializing_if = "Option::is_none"
299    )]
300    pub duplicate_exports: Option<Severity>,
301    #[serde(
302        default,
303        alias = "type-only-dependency",
304        skip_serializing_if = "Option::is_none"
305    )]
306    pub type_only_dependencies: Option<Severity>,
307    #[serde(
308        default,
309        alias = "test-only-dependency",
310        skip_serializing_if = "Option::is_none"
311    )]
312    pub test_only_dependencies: Option<Severity>,
313    #[serde(
314        default,
315        alias = "circular-dependency",
316        skip_serializing_if = "Option::is_none"
317    )]
318    pub circular_dependencies: Option<Severity>,
319    #[serde(
320        default,
321        alias = "boundary-violations",
322        skip_serializing_if = "Option::is_none"
323    )]
324    pub boundary_violation: Option<Severity>,
325    #[serde(
326        default,
327        alias = "coverage-gap",
328        skip_serializing_if = "Option::is_none"
329    )]
330    pub coverage_gaps: Option<Severity>,
331    #[serde(
332        default,
333        alias = "feature-flag",
334        skip_serializing_if = "Option::is_none"
335    )]
336    pub feature_flags: Option<Severity>,
337    #[serde(
338        default,
339        alias = "stale-suppression",
340        skip_serializing_if = "Option::is_none"
341    )]
342    pub stale_suppressions: Option<Severity>,
343    #[serde(
344        default,
345        alias = "unused-catalog-entry",
346        skip_serializing_if = "Option::is_none"
347    )]
348    pub unused_catalog_entries: Option<Severity>,
349    #[serde(
350        default,
351        alias = "unresolved-catalog-reference",
352        skip_serializing_if = "Option::is_none"
353    )]
354    pub unresolved_catalog_references: Option<Severity>,
355    #[serde(
356        default,
357        alias = "unused-dependency-override",
358        skip_serializing_if = "Option::is_none"
359    )]
360    pub unused_dependency_overrides: Option<Severity>,
361    #[serde(
362        default,
363        alias = "misconfigured-dependency-override",
364        skip_serializing_if = "Option::is_none"
365    )]
366    pub misconfigured_dependency_overrides: Option<Severity>,
367}
368
369#[cfg(test)]
370mod tests {
371    use super::*;
372
373    #[test]
374    fn rules_default_severities() {
375        let rules = RulesConfig::default();
376        assert_eq!(rules.unused_files, Severity::Error);
377        assert_eq!(rules.unused_exports, Severity::Error);
378        assert_eq!(rules.unused_types, Severity::Error);
379        assert_eq!(rules.private_type_leaks, Severity::Off);
380        assert_eq!(rules.unused_dependencies, Severity::Error);
381        assert_eq!(rules.unused_dev_dependencies, Severity::Warn);
382        assert_eq!(rules.unused_optional_dependencies, Severity::Warn);
383        assert_eq!(rules.unused_enum_members, Severity::Error);
384        assert_eq!(rules.unused_class_members, Severity::Error);
385        assert_eq!(rules.unresolved_imports, Severity::Error);
386        assert_eq!(rules.unlisted_dependencies, Severity::Error);
387        assert_eq!(rules.duplicate_exports, Severity::Error);
388        assert_eq!(rules.type_only_dependencies, Severity::Warn);
389        assert_eq!(rules.test_only_dependencies, Severity::Warn);
390        assert_eq!(rules.circular_dependencies, Severity::Error);
391        assert_eq!(rules.boundary_violation, Severity::Error);
392        assert_eq!(rules.coverage_gaps, Severity::Off);
393        assert_eq!(rules.feature_flags, Severity::Off);
394        assert_eq!(rules.stale_suppressions, Severity::Warn);
395        assert_eq!(rules.unused_catalog_entries, Severity::Warn);
396        assert_eq!(rules.unresolved_catalog_references, Severity::Error);
397    }
398
399    #[test]
400    fn rules_deserialize_kebab_case() {
401        let json_str = r#"{
402            "unused-files": "error",
403            "unused-exports": "warn",
404            "unused-types": "off"
405        }"#;
406        let rules: RulesConfig = serde_json::from_str(json_str).unwrap();
407        assert_eq!(rules.unused_files, Severity::Error);
408        assert_eq!(rules.unused_exports, Severity::Warn);
409        assert_eq!(rules.unused_types, Severity::Off);
410        // Unset fields default to error
411        assert_eq!(rules.unresolved_imports, Severity::Error);
412    }
413
414    #[test]
415    fn rules_deserialize_circular_dependency_alias() {
416        let json_str = r#"{
417            "circular-dependency": "off"
418        }"#;
419        let rules: RulesConfig = serde_json::from_str(json_str).unwrap();
420        assert_eq!(rules.circular_dependencies, Severity::Off);
421    }
422
423    #[test]
424    fn rules_deserialize_boundary_violations_alias() {
425        let json_str = r#"{
426            "boundary-violations": "off"
427        }"#;
428        let rules: RulesConfig = serde_json::from_str(json_str).unwrap();
429        assert_eq!(rules.boundary_violation, Severity::Off);
430
431        let partial: PartialRulesConfig = serde_json::from_str(json_str).unwrap();
432        assert_eq!(partial.boundary_violation, Some(Severity::Off));
433    }
434
435    #[test]
436    fn rules_deserialize_singular_aliases_for_every_plural_rule() {
437        // Mirrors the LSP's per-diagnostic singular codes (e.g. "unused-export")
438        // so users who copy the form they see in IDE warnings into their config
439        // get their stated severity honored instead of silently dropped.
440        let json_str = r#"{
441            "unused-file": "off",
442            "unused-export": "off",
443            "unused-type": "off",
444            "private-type-leak": "warn",
445            "unused-dependency": "off",
446            "unused-dev-dependency": "off",
447            "unused-optional-dependency": "off",
448            "unused-enum-member": "off",
449            "unused-class-member": "off",
450            "unresolved-import": "off",
451            "unlisted-dependency": "off",
452            "duplicate-export": "off",
453            "type-only-dependency": "off",
454            "test-only-dependency": "off",
455            "coverage-gap": "warn",
456            "feature-flag": "warn",
457            "stale-suppression": "off",
458            "unused-catalog-entry": "error",
459            "unresolved-catalog-reference": "warn"
460        }"#;
461
462        let rules: RulesConfig = serde_json::from_str(json_str).unwrap();
463        assert_eq!(rules.unused_files, Severity::Off);
464        assert_eq!(rules.unused_exports, Severity::Off);
465        assert_eq!(rules.unused_types, Severity::Off);
466        assert_eq!(rules.private_type_leaks, Severity::Warn);
467        assert_eq!(rules.unused_dependencies, Severity::Off);
468        assert_eq!(rules.unused_dev_dependencies, Severity::Off);
469        assert_eq!(rules.unused_optional_dependencies, Severity::Off);
470        assert_eq!(rules.unused_enum_members, Severity::Off);
471        assert_eq!(rules.unused_class_members, Severity::Off);
472        assert_eq!(rules.unresolved_imports, Severity::Off);
473        assert_eq!(rules.unlisted_dependencies, Severity::Off);
474        assert_eq!(rules.duplicate_exports, Severity::Off);
475        assert_eq!(rules.type_only_dependencies, Severity::Off);
476        assert_eq!(rules.test_only_dependencies, Severity::Off);
477        assert_eq!(rules.coverage_gaps, Severity::Warn);
478        assert_eq!(rules.feature_flags, Severity::Warn);
479        assert_eq!(rules.stale_suppressions, Severity::Off);
480        assert_eq!(rules.unused_catalog_entries, Severity::Error);
481        assert_eq!(rules.unresolved_catalog_references, Severity::Warn);
482
483        let partial: PartialRulesConfig = serde_json::from_str(json_str).unwrap();
484        assert_eq!(partial.unused_files, Some(Severity::Off));
485        assert_eq!(partial.unused_exports, Some(Severity::Off));
486        assert_eq!(partial.unused_types, Some(Severity::Off));
487        assert_eq!(partial.private_type_leaks, Some(Severity::Warn));
488        assert_eq!(partial.unused_dependencies, Some(Severity::Off));
489        assert_eq!(partial.unused_dev_dependencies, Some(Severity::Off));
490        assert_eq!(partial.unused_optional_dependencies, Some(Severity::Off));
491        assert_eq!(partial.unused_enum_members, Some(Severity::Off));
492        assert_eq!(partial.unused_class_members, Some(Severity::Off));
493        assert_eq!(partial.unresolved_imports, Some(Severity::Off));
494        assert_eq!(partial.unlisted_dependencies, Some(Severity::Off));
495        assert_eq!(partial.duplicate_exports, Some(Severity::Off));
496        assert_eq!(partial.type_only_dependencies, Some(Severity::Off));
497        assert_eq!(partial.test_only_dependencies, Some(Severity::Off));
498        assert_eq!(partial.coverage_gaps, Some(Severity::Warn));
499        assert_eq!(partial.feature_flags, Some(Severity::Warn));
500        assert_eq!(partial.stale_suppressions, Some(Severity::Off));
501        assert_eq!(partial.unused_catalog_entries, Some(Severity::Error));
502        assert_eq!(partial.unresolved_catalog_references, Some(Severity::Warn));
503    }
504
505    #[test]
506    fn severity_from_str() {
507        assert_eq!("error".parse::<Severity>().unwrap(), Severity::Error);
508        assert_eq!("warn".parse::<Severity>().unwrap(), Severity::Warn);
509        assert_eq!("warning".parse::<Severity>().unwrap(), Severity::Warn);
510        assert_eq!("off".parse::<Severity>().unwrap(), Severity::Off);
511        assert_eq!("none".parse::<Severity>().unwrap(), Severity::Off);
512        assert!("invalid".parse::<Severity>().is_err());
513    }
514
515    #[test]
516    fn apply_partial_only_some_fields() {
517        let mut rules = RulesConfig::default();
518        let partial = PartialRulesConfig {
519            unused_files: Some(Severity::Warn),
520            unused_exports: Some(Severity::Off),
521            ..Default::default()
522        };
523        rules.apply_partial(&partial);
524        assert_eq!(rules.unused_files, Severity::Warn);
525        assert_eq!(rules.unused_exports, Severity::Off);
526        // Unset fields unchanged
527        assert_eq!(rules.unused_types, Severity::Error);
528        assert_eq!(rules.unresolved_imports, Severity::Error);
529    }
530
531    #[test]
532    fn severity_display() {
533        assert_eq!(Severity::Error.to_string(), "error");
534        assert_eq!(Severity::Warn.to_string(), "warn");
535        assert_eq!(Severity::Off.to_string(), "off");
536    }
537
538    #[test]
539    fn apply_partial_all_none_changes_nothing() {
540        let mut rules = RulesConfig::default();
541        let original = rules.clone();
542        let partial = PartialRulesConfig::default(); // all None
543        rules.apply_partial(&partial);
544        assert_eq!(rules.unused_files, original.unused_files);
545        assert_eq!(rules.unused_exports, original.unused_exports);
546        assert_eq!(
547            rules.type_only_dependencies,
548            original.type_only_dependencies
549        );
550    }
551
552    #[test]
553    fn apply_partial_all_fields_set() {
554        let mut rules = RulesConfig::default();
555        let partial = PartialRulesConfig {
556            unused_files: Some(Severity::Off),
557            unused_exports: Some(Severity::Off),
558            unused_types: Some(Severity::Off),
559            private_type_leaks: Some(Severity::Off),
560            unused_dependencies: Some(Severity::Off),
561            unused_dev_dependencies: Some(Severity::Off),
562            unused_optional_dependencies: Some(Severity::Off),
563            unused_enum_members: Some(Severity::Off),
564            unused_class_members: Some(Severity::Off),
565            unresolved_imports: Some(Severity::Off),
566            unlisted_dependencies: Some(Severity::Off),
567            duplicate_exports: Some(Severity::Off),
568            type_only_dependencies: Some(Severity::Off),
569            test_only_dependencies: Some(Severity::Off),
570            circular_dependencies: Some(Severity::Off),
571            boundary_violation: Some(Severity::Off),
572            coverage_gaps: Some(Severity::Off),
573            feature_flags: Some(Severity::Off),
574            stale_suppressions: Some(Severity::Off),
575            unused_catalog_entries: Some(Severity::Off),
576            unresolved_catalog_references: Some(Severity::Off),
577            unused_dependency_overrides: Some(Severity::Off),
578            misconfigured_dependency_overrides: Some(Severity::Off),
579        };
580        rules.apply_partial(&partial);
581        assert_eq!(rules.unused_files, Severity::Off);
582        assert_eq!(rules.private_type_leaks, Severity::Off);
583        assert_eq!(rules.circular_dependencies, Severity::Off);
584        assert_eq!(rules.type_only_dependencies, Severity::Off);
585        assert_eq!(rules.test_only_dependencies, Severity::Off);
586        assert_eq!(rules.boundary_violation, Severity::Off);
587        assert_eq!(rules.coverage_gaps, Severity::Off);
588        assert_eq!(rules.feature_flags, Severity::Off);
589        assert_eq!(rules.stale_suppressions, Severity::Off);
590    }
591
592    #[test]
593    fn rules_config_defaults_include_optional_deps() {
594        let rules = RulesConfig::default();
595        assert_eq!(rules.unused_optional_dependencies, Severity::Warn);
596    }
597
598    #[test]
599    fn severity_from_str_case_insensitive() {
600        assert_eq!("ERROR".parse::<Severity>().unwrap(), Severity::Error);
601        assert_eq!("Warn".parse::<Severity>().unwrap(), Severity::Warn);
602        assert_eq!("OFF".parse::<Severity>().unwrap(), Severity::Off);
603        assert_eq!("Warning".parse::<Severity>().unwrap(), Severity::Warn);
604        assert_eq!("NONE".parse::<Severity>().unwrap(), Severity::Off);
605    }
606
607    #[test]
608    fn severity_from_str_invalid_returns_error() {
609        let result = "critical".parse::<Severity>();
610        assert!(result.is_err());
611        let err = result.unwrap_err();
612        assert!(
613            err.contains("unknown severity"),
614            "Expected descriptive error, got: {err}"
615        );
616    }
617
618    // ── PartialRulesConfig deserialization ───────────────────────────
619
620    #[test]
621    fn partial_rules_empty_json() {
622        let partial: PartialRulesConfig = serde_json::from_str("{}").unwrap();
623        assert!(partial.unused_files.is_none());
624        assert!(partial.unused_exports.is_none());
625        assert!(partial.unused_types.is_none());
626        assert!(partial.unused_dependencies.is_none());
627        assert!(partial.circular_dependencies.is_none());
628        assert!(partial.boundary_violation.is_none());
629        assert!(partial.coverage_gaps.is_none());
630        assert!(partial.feature_flags.is_none());
631        assert!(partial.stale_suppressions.is_none());
632    }
633
634    #[test]
635    fn partial_rules_subset_json() {
636        let json = r#"{
637            "unused-files": "warn",
638            "circular-dependencies": "off"
639        }"#;
640        let partial: PartialRulesConfig = serde_json::from_str(json).unwrap();
641        assert_eq!(partial.unused_files, Some(Severity::Warn));
642        assert_eq!(partial.circular_dependencies, Some(Severity::Off));
643        assert!(partial.unused_exports.is_none());
644    }
645
646    #[test]
647    fn partial_rules_deserialize_circular_dependency_alias() {
648        let json = r#"{
649            "circular-dependency": "warn"
650        }"#;
651        let partial: PartialRulesConfig = serde_json::from_str(json).unwrap();
652        assert_eq!(partial.circular_dependencies, Some(Severity::Warn));
653    }
654
655    #[test]
656    fn partial_rules_all_fields_json() {
657        let json = r#"{
658            "unused-files": "error",
659            "unused-exports": "warn",
660            "unused-types": "off",
661            "unused-dependencies": "error",
662            "unused-dev-dependencies": "warn",
663            "unused-optional-dependencies": "off",
664            "unused-enum-members": "error",
665            "unused-class-members": "warn",
666            "unresolved-imports": "off",
667            "unlisted-dependencies": "error",
668            "duplicate-exports": "warn",
669            "type-only-dependencies": "off",
670            "test-only-dependencies": "error",
671            "circular-dependencies": "warn",
672            "boundary-violation": "off",
673            "coverage-gaps": "warn",
674            "feature-flags": "error",
675            "stale-suppressions": "off"
676        }"#;
677        let partial: PartialRulesConfig = serde_json::from_str(json).unwrap();
678        assert_eq!(partial.unused_files, Some(Severity::Error));
679        assert_eq!(partial.unused_exports, Some(Severity::Warn));
680        assert_eq!(partial.unused_types, Some(Severity::Off));
681        assert_eq!(partial.unused_dependencies, Some(Severity::Error));
682        assert_eq!(partial.unused_dev_dependencies, Some(Severity::Warn));
683        assert_eq!(partial.unused_optional_dependencies, Some(Severity::Off));
684        assert_eq!(partial.unused_enum_members, Some(Severity::Error));
685        assert_eq!(partial.unused_class_members, Some(Severity::Warn));
686        assert_eq!(partial.unresolved_imports, Some(Severity::Off));
687        assert_eq!(partial.unlisted_dependencies, Some(Severity::Error));
688        assert_eq!(partial.duplicate_exports, Some(Severity::Warn));
689        assert_eq!(partial.type_only_dependencies, Some(Severity::Off));
690        assert_eq!(partial.test_only_dependencies, Some(Severity::Error));
691        assert_eq!(partial.circular_dependencies, Some(Severity::Warn));
692        assert_eq!(partial.boundary_violation, Some(Severity::Off));
693        assert_eq!(partial.coverage_gaps, Some(Severity::Warn));
694        assert_eq!(partial.feature_flags, Some(Severity::Error));
695        assert_eq!(partial.stale_suppressions, Some(Severity::Off));
696    }
697
698    // ── PartialRulesConfig serialization skip_serializing_if ────────
699
700    #[test]
701    fn partial_rules_none_fields_not_serialized() {
702        let partial = PartialRulesConfig::default();
703        let json = serde_json::to_string(&partial).unwrap();
704        assert_eq!(
705            json, "{}",
706            "all-None partial should serialize to empty object"
707        );
708    }
709
710    #[test]
711    fn partial_rules_some_fields_serialized() {
712        let partial = PartialRulesConfig {
713            unused_files: Some(Severity::Warn),
714            ..Default::default()
715        };
716        let json = serde_json::to_string(&partial).unwrap();
717        assert!(json.contains("unused-files"));
718        assert!(!json.contains("unused-exports"));
719    }
720
721    // ── Severity JSON deserialization ────────────────────────────────
722
723    #[test]
724    fn severity_json_deserialization() {
725        let error: Severity = serde_json::from_str(r#""error""#).unwrap();
726        assert_eq!(error, Severity::Error);
727
728        let warn: Severity = serde_json::from_str(r#""warn""#).unwrap();
729        assert_eq!(warn, Severity::Warn);
730
731        let off: Severity = serde_json::from_str(r#""off""#).unwrap();
732        assert_eq!(off, Severity::Off);
733    }
734
735    #[test]
736    fn severity_invalid_json_value_rejected() {
737        let result: Result<Severity, _> = serde_json::from_str(r#""critical""#);
738        assert!(result.is_err());
739    }
740
741    // ── Severity default ────────────────────────────────────────────
742
743    #[test]
744    fn severity_default_is_error() {
745        assert_eq!(Severity::default(), Severity::Error);
746    }
747
748    // ── RulesConfig JSON serialize roundtrip ─────────────────────────
749
750    #[test]
751    fn rules_config_json_roundtrip() {
752        let rules = RulesConfig {
753            unused_files: Severity::Warn,
754            unused_exports: Severity::Off,
755            type_only_dependencies: Severity::Error,
756            ..RulesConfig::default()
757        };
758        let json = serde_json::to_string(&rules).unwrap();
759        let restored: RulesConfig = serde_json::from_str(&json).unwrap();
760        assert_eq!(restored.unused_files, Severity::Warn);
761        assert_eq!(restored.unused_exports, Severity::Off);
762        assert_eq!(restored.type_only_dependencies, Severity::Error);
763        assert_eq!(restored.unused_dependencies, Severity::Error); // default
764    }
765
766    // ── apply_partial preserves type_only/test_only defaults ────────
767
768    #[test]
769    fn apply_partial_preserves_type_only_default() {
770        let mut rules = RulesConfig::default();
771        let partial = PartialRulesConfig {
772            unused_files: Some(Severity::Off),
773            ..Default::default()
774        };
775        rules.apply_partial(&partial);
776        // type_only_dependencies defaults to Warn, should be preserved
777        assert_eq!(rules.type_only_dependencies, Severity::Warn);
778        assert_eq!(rules.test_only_dependencies, Severity::Warn);
779    }
780}
fallow_config/config/rules.rs

fallow_config/config/
rules.rs
