Expand description
Weakening-signal pass (6.F), PROMOTED TO A HEADLINE per v6.
A diff-scoped base-vs-head pass over the changed files that flags the AI-era failure modes a green check hides: tests removed or skipped, coverage / thresholds lowered, suppressions added, security checks/steps removed.
Always ADVISORY, reviewer-private, NEVER gates, NEVER auto-posted. It rides the brief envelope (exit-0 by construction) as a headline section.
Honest scope (ADR-001, syntactic): these are line-shape heuristics over the base-vs-head text of changed files, NOT a semantic test-coverage proof. A signal is an attention pointer (“the diff weakened a guardrail here”), framed so a reviewer decides.
Structs§
- Weakening
Signal - One weakening signal: a category, the file it was detected in, and a short human-readable evidence string. Reviewer-private; never gates.
Enums§
- Weakening
Kind - The category of a single weakening signal.
Functions§
- detect_
added_ suppressions - Detect added suppressions: a
fallow-ignore/eslint-disable/@ts-ignore/@ts-expect-errorcount that increased between base and head. Only counts occurrences on a COMMENT line (a line containing//,#,/*,*, or<!--), since a real suppression directive always lives in a comment. This keeps the token list’s own definition (e.g. the string array in this file) from self-flagging, the only false-positive class the real-world smoke hit. - detect_
lowered_ thresholds - Detect lowered numeric thresholds: a config key whose numeric value decreased between base and head. Scans common coverage/threshold key names; a key present in both with a strictly smaller head value is a weakening.
- detect_
removed_ security_ steps - Detect removed security CI steps: a line invoking a security scanner / audit step that was present in base but is gone in head. Scoped to CI files by the caller; here we count net-removed scanner-invoking lines.
- detect_
removed_ tests - Detect net-removed tests: a
it(/test(/describe(callsite count that dropped between base and head (a test deleted). - detect_
test_ weakening - Detect skipped-test additions: an
it.skip/xit/describe.skip/.onlytoken present in head but not base..onlynarrows the run to a subset, silently excluding siblings, so it counts as a weakening too. - is_
ci_ file - Whether a path looks like a CI workflow file (where security-step removal is meaningful).
- is_
test_ file - Whether a path looks like a test file (where test removal/skip is meaningful).