Skip to main content

fallow_api/
explain.rs

1//! Metric and rule definitions for explainable CLI output.
2//!
3//! Provides structured metadata that describes what each metric, threshold,
4//! and rule means, consumed by the `_meta` object in JSON output and by
5//! SARIF `fullDescription` / `helpUri` fields.
6
7use serde_json::Value;
8
9/// Rule definition for SARIF `fullDescription` and JSON `_meta`.
10pub struct RuleDef {
11    /// Canonical rule id, such as `fallow/unused-export` or
12    /// `security/sql-injection`; used as the SARIF rule id.
13    pub id: &'static str,
14    /// Coarse category label used by the sticky PR/MR comment renderer to
15    /// group findings into collapsible sections (Dead code, Dependencies,
16    /// Duplication, Health, Architecture, Suppressions). One source of
17    /// truth so the CodeClimate / SARIF / review-envelope path and the
18    /// renderer never drift; a unit test below asserts every RuleDef has
19    /// a non-empty category.
20    pub category: &'static str,
21    /// Human-readable rule title.
22    pub name: &'static str,
23    /// One-line description used as the SARIF `shortDescription`.
24    pub short: &'static str,
25    /// Paragraph-length description used as the SARIF `fullDescription`.
26    pub full: &'static str,
27    /// Path under the docs site base URL for the rule's `helpUri`.
28    pub docs_path: &'static str,
29}
30
31/// Rule definitions for every dead-code family finding.
32pub const CHECK_RULES: &[RuleDef] = &[
33    RuleDef {
34        id: "fallow/unused-file",
35        category: "Dead code",
36        name: "Unused Files",
37        short: "File is not reachable from any entry point",
38        full: "Source files that are not imported by any other module and are not entry points (scripts, tests, configs). These files can safely be deleted. Detection uses graph reachability from configured entry points.",
39        docs_path: "explanations/dead-code#unused-files",
40    },
41    RuleDef {
42        id: "fallow/unused-export",
43        category: "Dead code",
44        name: "Unused Exports",
45        short: "Export is never imported",
46        full: "Named exports that are never imported by any other module in the project. Includes both direct exports and re-exports through barrel files. The export may still be used locally within the same file.",
47        docs_path: "explanations/dead-code#unused-exports",
48    },
49    RuleDef {
50        id: "fallow/unused-type",
51        category: "Dead code",
52        name: "Unused Type Exports",
53        short: "Type export is never imported",
54        full: "Type-only exports (interfaces, type aliases, enums used only as types) that are never imported. These do not generate runtime code but add maintenance burden.",
55        docs_path: "explanations/dead-code#unused-types",
56    },
57    RuleDef {
58        id: "fallow/private-type-leak",
59        category: "Dead code",
60        name: "Private Type Leaks",
61        short: "Exported signature references a private type",
62        full: "Exported values or types whose public TypeScript signature references a same-file type declaration that is not exported. Consumers cannot name that private type directly, so the backing type should be exported or removed from the public signature.",
63        docs_path: "explanations/dead-code#private-type-leaks",
64    },
65    RuleDef {
66        id: "fallow/deprecated-export-in-use",
67        category: "Dead code",
68        name: "Deprecated Exports in Use",
69        short: "Export marked @deprecated is still referenced",
70        full: "Exports whose leading JSDoc carries @deprecated and that still have at least one consumer in a reachable file. Each finding lists the exact consumer count, a sample of up to 10 consumers sorted by path and line, and the deprecation message. A deprecated export with no consumer is reported as an unused export instead, marked deprecated. A consumer in an unreachable file does not count, because that file is dead code itself. `public_api` is true when the export lives in an entry point or a re-export chain reaches one: external consumers are not visible, so the finding makes no removal claim. The rule is opt-in and defaults to off. A per-path override resolves on the file that declares the export, not on the consumer.",
71        docs_path: "explanations/dead-code#deprecated-exports-in-use",
72    },
73    RuleDef {
74        id: "fallow/unused-dependency",
75        category: "Dependencies",
76        name: "Unused Dependencies",
77        short: "Dependency listed but never imported",
78        full: "Packages listed in dependencies that are never imported or required by any source file. Framework plugins and CLI tools may be false positives; use the ignore_dependencies config to suppress.",
79        docs_path: "explanations/dead-code#unused-dependencies",
80    },
81    RuleDef {
82        id: "fallow/unused-dev-dependency",
83        category: "Dependencies",
84        name: "Unused Dev Dependencies",
85        short: "Dev dependency listed but never imported",
86        full: "Packages listed in devDependencies that are never imported by test files, config files, or scripts. Build tools and jest presets that are referenced only in config may appear as false positives.",
87        docs_path: "explanations/dead-code#unused-devdependencies",
88    },
89    RuleDef {
90        id: "fallow/unused-optional-dependency",
91        category: "Dependencies",
92        name: "Unused Optional Dependencies",
93        short: "Optional dependency listed but never imported",
94        full: "Packages listed in optionalDependencies that are never imported. Optional dependencies are typically platform-specific; verify they are not needed on any supported platform before removing.",
95        docs_path: "explanations/dead-code#unused-optionaldependencies",
96    },
97    RuleDef {
98        id: "fallow/type-only-dependency",
99        category: "Dependencies",
100        name: "Type-only Dependencies",
101        short: "Production dependency only used via type-only imports",
102        full: "Production dependencies that are only imported via `import type` statements. These can be moved to devDependencies since they generate no runtime code and are stripped during compilation.",
103        docs_path: "explanations/dead-code#type-only-dependencies",
104    },
105    RuleDef {
106        id: "fallow/test-only-dependency",
107        category: "Dependencies",
108        name: "Test-only Dependencies",
109        short: "Production dependency only imported by test files",
110        full: "Production dependencies that are only imported from test files. These can usually move to devDependencies because production entry points do not require them at runtime.",
111        docs_path: "explanations/dead-code#test-only-dependencies",
112    },
113    RuleDef {
114        id: "fallow/dev-dependency-in-production",
115        category: "Dependencies",
116        name: "Dev Dependencies Used in Production",
117        short: "devDependency imported by production code with a runtime import",
118        full: "A package in `devDependencies` that is imported by production (non-test, non-config) source code via a runtime/value import. Whether it should be promoted to `dependencies` depends on the deployment: a production-only install (`pnpm install --prod`) omits devDependencies, so an import resolved at runtime breaks, while a build that inlines the package into its output resolves nothing at runtime and promoting it can instead make the deployment require an install it did not need. This is the promote-side mirror of `test-only-dependency` and `type-only-dependency`. A dev dependency imported from production code only via `import type` is NOT flagged (types are erased at build time), and a package also listed in `dependencies`, `peerDependencies`, or `optionalDependencies` is left alone because another manifest section provides it at runtime.",
119        docs_path: "explanations/dead-code#dev-dependencies-in-production",
120    },
121    RuleDef {
122        id: "fallow/unused-enum-member",
123        category: "Dead code",
124        name: "Unused Enum Members",
125        short: "Enum member is never referenced",
126        full: "Enum members that are never referenced in the codebase. Uses scope-aware binding analysis to track all references including computed access patterns.",
127        docs_path: "explanations/dead-code#unused-enum-members",
128    },
129    RuleDef {
130        id: "fallow/unused-class-member",
131        category: "Dead code",
132        name: "Unused Class Members",
133        short: "Class member is never referenced",
134        full: "Class methods and properties that are never referenced outside the class. Private members are checked within the class scope; public members are checked project-wide.",
135        docs_path: "explanations/dead-code#unused-class-members",
136    },
137    RuleDef {
138        id: "fallow/unused-store-member",
139        category: "Dead code",
140        name: "Unused Store Members",
141        short: "Store member is never accessed by any consumer",
142        full: "Pinia store members (a `state` / `getters` / `actions` key, or a setup-store returned key) declared but never accessed by any consumer project-wide. The store binding is imported (so the module is reachable) yet a specific member is dead. Defaults to warn, not error: a store has an open declaration surface (plugins, dynamic dispatch) so confidence is lower. Activates only when pinia or @pinia/nuxt is a declared dependency.",
143        docs_path: "explanations/dead-code#unused-store-members",
144    },
145    RuleDef {
146        id: "fallow/unresolved-import",
147        category: "Dead code",
148        name: "Unresolved Imports",
149        short: "Import could not be resolved",
150        full: "Import specifiers that could not be resolved to a file on disk. Common causes: deleted files, typos in paths, missing path aliases in tsconfig, or uninstalled packages.",
151        docs_path: "explanations/dead-code#unresolved-imports",
152    },
153    RuleDef {
154        id: "fallow/unlisted-dependency",
155        category: "Dependencies",
156        name: "Unlisted Dependencies",
157        short: "Dependency used but not in package.json",
158        full: "Packages imported without an applicable dependency declaration in package.json. This includes workspace packages imported from the repository root: npm workspace links make a package resolvable, but do not declare a dependency. Package self-references are allowed. Private packages and tooling may use ancestor declarations; publishable runtime code must declare its own dependencies.",
159        docs_path: "explanations/dead-code#unlisted-dependencies",
160    },
161    RuleDef {
162        id: "fallow/duplicate-export",
163        category: "Dead code",
164        name: "Duplicate Exports",
165        short: "Export name appears in multiple modules",
166        full: "The same export name is defined in multiple modules. Consumers may import from the wrong module, leading to subtle bugs. Consider renaming or consolidating.",
167        docs_path: "explanations/dead-code#duplicate-exports",
168    },
169    RuleDef {
170        id: "fallow/circular-dependency",
171        category: "Architecture",
172        name: "Circular Dependencies",
173        short: "Circular dependency chain detected",
174        full: "A cycle in the module import graph. Circular dependencies cause undefined behavior with CommonJS (partial modules) and initialization ordering issues with ESM. Break cycles by extracting shared code.",
175        docs_path: "explanations/dead-code#circular-dependencies",
176    },
177    RuleDef {
178        id: "fallow/re-export-cycle",
179        category: "Architecture",
180        name: "Re-Export Cycles",
181        short: "Two or more barrel files re-export from each other in a loop",
182        full: "A barrel file re-exports from another barrel that ultimately re-exports back. When this happens, imports from any file in the loop may silently come up empty, because the re-export chain has no terminating module to resolve names against. To fix this: open any one file in the loop and remove the `export * from` (or `export { ... } from`) statement that points back into the cycle. Any single removal will break the cycle and restore working re-exports. A self-loop (a single barrel re-exporting from itself, often a rename leftover) is reported under the same rule with kind `self-loop`.",
183        docs_path: "explanations/dead-code#re-export-cycles",
184    },
185    RuleDef {
186        id: "fallow/package-cycle",
187        category: "Architecture",
188        name: "Package Cycles",
189        short: "Two or more workspace packages import each other in a loop",
190        full: "Workspace packages whose resolved imports form a cycle. Each workspace package is a node and each resolved import from one package to another is an edge, so a package cycle can exist when no file-level cycle exists. Imports from test, spec, story, fixture and tooling config files are not edges, because those files are not part of the package build. Packages in a cycle cannot be built in dependency order. Each hop shows one example import and a `type_only` flag; a type-only hop still matters for declaration builds. To fix this, remove the imports on one hop, for example by moving the shared code to a package that both packages import.",
191        docs_path: "explanations/dead-code#package-cycles",
192    },
193    RuleDef {
194        id: "fallow/boundary-violation",
195        category: "Architecture",
196        name: "Boundary Violations",
197        short: "Import crosses a configured architecture boundary",
198        full: "A module imports from a zone that its configured boundary rules do not allow. Boundary checks help keep layered architecture, feature slices, and package ownership rules enforceable.",
199        docs_path: "explanations/dead-code#boundary-violations",
200    },
201    RuleDef {
202        id: "fallow/boundary-coverage",
203        category: "Architecture",
204        name: "Boundary Coverage",
205        short: "Source file matches no configured architecture boundary zone",
206        full: "A reachable source file is not assigned to any configured boundary zone while boundaries.coverage.requireAllFiles is enabled. Add the file to a zone pattern, move it under an existing zone, or allow-list generated and intentionally unzoned paths with boundaries.coverage.allowUnmatched.",
207        docs_path: "explanations/dead-code#boundary-violations",
208    },
209    RuleDef {
210        id: "fallow/boundary-call-violation",
211        category: "Architecture",
212        name: "Boundary Call Violation",
213        short: "Zoned file calls a callee its zone forbids",
214        full: "A file classified into a boundary zone calls a callee matching one of the zone's boundaries.calls.forbidden patterns. The check is syntactic: it matches the written callee path and the import-resolved canonical path, and it only applies to files classified into a zone. Move the call behind an allowed abstraction, or adjust the zone's forbidden patterns if the rule was wrong.",
215        docs_path: "explanations/dead-code#boundary-violations",
216    },
217    RuleDef {
218        id: "fallow/policy-violation",
219        category: "Policy",
220        name: "Policy Violation",
221        short: "Usage violates a configured rule-pack policy",
222        full: "A call, import, export, catalogue-derived effect, or graph-resolved GDP proof producer violates a configured rule pack (the rulePacks config key). Packs are pure declarative data. Call and effect rules use written plus import-resolved canonical callees; import rules match the raw specifier. GDP rules trace @gdp-ts/core proof producers through unambiguous re-exports and restrict which files may create proof factories, optionally by exact static proof kind. This is syntactic ownership analysis, not a runtime authorization guarantee. Follow the rule's message, move a producer into an allowed file, scope the rule with files/exclude globs, or adjust its severity.",
223        docs_path: "explanations/dead-code#policy-violations",
224    },
225    RuleDef {
226        id: "fallow/stale-suppression",
227        category: "Suppressions",
228        name: "Stale Suppressions",
229        short: "Suppression comment or tag no longer matches any issue",
230        full: "A fallow-ignore-next-line, fallow-ignore-file, or @expected-unused suppression that no longer matches any active issue. The underlying problem was fixed but the suppression was left behind. Remove it to keep the codebase clean.",
231        docs_path: "explanations/dead-code#stale-suppressions",
232    },
233    RuleDef {
234        id: "fallow/missing-suppression-reason",
235        category: "Suppressions",
236        name: "Missing Suppression Reason",
237        short: "Suppression comment omits a required reason",
238        full: "A fallow-ignore-next-line or fallow-ignore-file suppression omits the explanatory reason required by the requireSuppressionReason rule. Add a short reason after the suppression token, or remove the suppression if the issue is no longer intentional.",
239        docs_path: "explanations/dead-code#stale-suppressions",
240    },
241    RuleDef {
242        id: "fallow/unused-catalog-entry",
243        category: "Dependencies",
244        name: "Unused catalog entry",
245        short: "Catalog entry not referenced by any workspace package",
246        full: "An entry in a package manager catalog (`pnpm-workspace.yaml` `catalog:` / `catalogs:` or Bun root `package.json` `workspaces.catalog` / `workspaces.catalogs`) that no workspace package.json dependency and no pnpm override (`pnpm-workspace.yaml` `overrides`, skipped when `packageManager` names a pnpm version that ignores it: pnpm before 10.5.1, or pnpm 10 or earlier when the root `package.json` declares non-empty `pnpm.overrides` or `resolutions`; root `package.json` `pnpm.overrides`, skipped when `packageManager` names pnpm 11 or later; root `package.json` `resolutions`, read only when `packageManager` names pnpm 10 or earlier) references via the `catalog:` protocol. Catalog entries are leftover dependency metadata once a package is removed from every consumer; delete the entry to keep the catalog truthful. See also: fallow/unresolved-catalog-reference (the inverse: consumer references a catalog that does not declare the package).",
247        docs_path: "explanations/dead-code#unused-catalog-entries",
248    },
249    RuleDef {
250        id: "fallow/empty-catalog-group",
251        category: "Dependencies",
252        name: "Empty catalog group",
253        short: "Named catalog group has no entries",
254        full: "A named group under `catalogs:` in `pnpm-workspace.yaml` or Bun root `package.json` has no package entries. Empty named groups are leftover catalog structure after the last entry is removed. The default `catalog` map is intentionally ignored because some projects keep it as a stable hook.",
255        docs_path: "explanations/dead-code#empty-catalog-groups",
256    },
257    RuleDef {
258        id: "fallow/unresolved-catalog-reference",
259        category: "Dependencies",
260        name: "Unresolved catalog reference",
261        short: "package.json references a catalog that does not declare the package",
262        full: "A workspace package.json declares a dependency with the `catalog:` or `catalog:<name>` protocol, but the catalog has no entry for that package. The package manager install will fail until the catalog is fixed. To fix: add the package to the named catalog, switch the reference to a different catalog that does declare it, or remove the reference and pin a hardcoded version. Scope: the detector scans `dependencies`, `devDependencies`, `peerDependencies`, and `optionalDependencies` in every workspace `package.json`, plus the pnpm override values in `pnpm-workspace.yaml` `overrides` (skipped when `packageManager` names a pnpm version that ignores it: pnpm before 10.5.1, or pnpm 10 or earlier when the root `package.json` declares non-empty `pnpm.overrides` or `resolutions`), root `package.json` `pnpm.overrides` (skipped when `packageManager` names pnpm 11 or later, because pnpm 11 does not read it), and root `package.json` `resolutions` (read only when `packageManager` names pnpm 10 or earlier), using `pnpm-workspace.yaml` catalogs when present and Bun root `package.json` catalogs otherwise. See also: fallow/unused-catalog-entry (the inverse: catalog entries no consumer references).",
263        docs_path: "explanations/dead-code#unresolved-catalog-references",
264    },
265    RuleDef {
266        id: "fallow/unused-dependency-override",
267        category: "Dependencies",
268        name: "Unused dependency override",
269        short: "Package-manager override target is not declared or resolved",
270        full: "An entry in `pnpm-workspace.yaml`'s `overrides:` section (skipped when `packageManager` names a pnpm version that ignores it: pnpm before 10.5.1, or pnpm 10 or earlier when the root `package.json` declares non-empty `pnpm.overrides` or `resolutions`), `package.json#pnpm.overrides` (skipped when `packageManager` names pnpm 11 or later, which does not read it), npm or Bun's top-level `package.json#overrides`, or Bun's `package.json#resolutions` whose target package is not declared by any workspace package and is not present in the active readable lockfile (`pnpm-lock.yaml`, `package-lock.json`, `npm-shrinkwrap.json`, or `bun.lock`). Override entries linger after their target package leaves the resolved dependency tree. pnpm and npm projects without a readable lockfile fall back to workspace package manifests and keep a `hint` so transitive CVE pins can be reviewed before removal. Bun projects with only binary `bun.lockb` fail closed: fallow reports a workspace diagnostic and emits no unused-override finding until a readable `bun.lock` exists. To fix: delete the entry, refresh the active lockfile if it is stale, or add the entry to `ignoreDependencyOverrides` when the override is intentionally retained. See also: fallow/misconfigured-dependency-override.",
271        docs_path: "explanations/dead-code#unused-dependency-overrides",
272    },
273    RuleDef {
274        id: "fallow/misconfigured-dependency-override",
275        category: "Dependencies",
276        name: "Misconfigured dependency override",
277        short: "Package-manager override has an unparsable key or value",
278        full: "An entry in `pnpm-workspace.yaml#overrides` (skipped when `packageManager` names a pnpm version that ignores it: pnpm before 10.5.1, or pnpm 10 or earlier when the root `package.json` declares non-empty `pnpm.overrides` or `resolutions`), `package.json#pnpm.overrides` (skipped when `packageManager` names pnpm 11 or later, which does not read it), npm or Bun's top-level `package.json#overrides`, or Bun's `package.json#resolutions` whose key or value cannot be interpreted in that source's override grammar. Common shapes include an empty key, an empty value, a malformed version selector (`@types/react@<<18`), or an unbalanced parent matcher (`react>`). The active package manager may reject or ignore the entry. To fix: correct the key or value according to that package manager's grammar, or remove the entry. See also: fallow/unused-dependency-override.",
279        docs_path: "explanations/dead-code#misconfigured-dependency-overrides",
280    },
281    RuleDef {
282        id: "fallow/invalid-client-export",
283        category: "Policy",
284        name: "Invalid client export",
285        short: "\"use client\" file exports a server-only / route-config name",
286        full: "A file carrying the `\"use client\"` directive also exports a Next.js server-only or route-segment config name (such as `metadata`, `generateMetadata`, `revalidate`, `generateStaticParams`, or a route HTTP method like `GET`/`POST`). Next.js rejects this combination at build time. Move the server-only export to a non-client module (a server component, a `route.ts`, or a separate config file), or remove the `\"use client\"` directive if the module does not need to be a client boundary. The check runs only when the project declares `next`.",
287        docs_path: "explanations/dead-code#invalid-client-exports",
288    },
289    RuleDef {
290        id: "fallow/mixed-client-server-barrel",
291        category: "Policy",
292        name: "Mixed client/server barrel",
293        short: "Barrel re-exports both a \"use client\" module and a server-only module",
294        full: "A barrel file (a module whose exports are `export ... from` re-exports) forwards a name from a `\"use client\"` module alongside a name from a server-only module (one carrying `\"use server\"`, importing the `server-only` package, or importing a server-only Next.js API such as `next/headers`). Importing one name from such a barrel drags the other's directive context across the React Server Components boundary, the documented Next.js App Router footgun. Type-only re-exports are ignored (erased at build), and a barrel re-exporting a client module alongside an ordinary undirected utility does NOT flag. To fix: split the barrel so client and server-only modules are re-exported from separate entry points. The check runs only when the project declares `next`.",
295        docs_path: "explanations/dead-code#mixed-client-server-barrels",
296    },
297    RuleDef {
298        id: "fallow/misplaced-directive",
299        category: "Policy",
300        name: "Misplaced directive",
301        short: "\"use client\" / \"use server\" directive is not in the leading position and is ignored",
302        full: "A `\"use client\"` or `\"use server\"` directive string appears as an expression statement after a non-directive statement (an `import`, a `const`). React Server Components bundlers only honor a directive in the leading prologue, before any other statement; once any statement precedes it the string is parsed as an ordinary expression and SILENTLY IGNORED. The intended client/server boundary never takes effect, so the file is treated as a server module. To fix: move the directive to the very top of the file, above every import. The check runs only when the project declares `next`.",
303        docs_path: "explanations/dead-code#misplaced-directives",
304    },
305    RuleDef {
306        id: "fallow/unprovided-inject",
307        category: "Dead code",
308        name: "Unprovided injects",
309        short: "inject() / getContext() reads a key that no provide() / setContext() supplies",
310        full: "A Vue `inject(KEY)` or Svelte `getContext(KEY)` reads a dependency-injection key (an imported or module-local symbol) that no matching `provide(KEY)` / `setContext(KEY)` supplies anywhere in the project. The read resolves to undefined at runtime, surfaced only at render. To fix: add a matching provider for the key, or remove the dead inject. Defaults to warn, not error: a provider may live outside the analyzed graph (an app-level provide registered elsewhere, a plugin, a host application). String-literal keys and keys imported from a package are abstained.",
311        docs_path: "explanations/dead-code#unprovided-injects",
312    },
313    RuleDef {
314        id: "fallow/unrendered-component",
315        category: "Dead code",
316        name: "Unrendered components",
317        short: "A Vue / Svelte component is reachable through a barrel but rendered nowhere",
318        full: "A Vue or Svelte single-file component (the default export of a `.vue` / `.svelte` file) is reachable in the module graph (a barrel re-exports it) but instantiated NOWHERE in the project: no `<Tag>`, no `:is` / `this=` binding, no `components` / `app.component` registration, no `h()` / auto-import use, and no script value-read. It survives unused-file (the barrel keeps it reachable) and unused-export (the re-export counts as a use), yet no file actually renders it. To fix: render the component somewhere, or delete it and drop the dead re-export. Defaults to warn, not error: a component can be rendered reflectively (a dynamic `<component :is>` resolved from a non-literal value), so analyzer confidence is lower. Components that are themselves entry points (route pages, layouts, `App.vue`) and components re-exported from a non-private package entry point are abstained.",
319        docs_path: "explanations/dead-code#unrendered-components",
320    },
321    RuleDef {
322        id: "fallow/absent-component-prop",
323        category: "Dead code",
324        name: "Absent optional component props",
325        short: "Known reachable callers omit an optional prop consumed inside its component",
326        full: "A used optional component input is supplied by none of its inspected reachable callers. The finding includes the declaration, framework, default presence and caller locations. Enable absent-component-props explicitly; it defaults to off. Supported contracts cover React, Preact, Solid, Qwik, Vue, Svelte, Astro, Angular, Lit and Ember. Unknown spreads, dynamic or escaped component references, ambiguous bindings, incomplete contracts and externally exposed APIs abstain. Review defaults and API intent manually; static analysis does not prove runtime unreachability.",
327        docs_path: "explanations/dead-code#absent-component-props",
328    },
329    RuleDef {
330        id: "fallow/unused-component-prop",
331        category: "Dead code",
332        name: "Unused component props",
333        short: "A Vue, Svelte, or React component prop is referenced nowhere in its own component",
334        full: "A declared component prop referenced nowhere inside its own component, in these framework shapes: a Vue `<script setup>` defineProps prop, a Svelte 5 `$props()` prop, or a React/Preact prop destructured from a component's first parameter and read nowhere in its body. Framework type checkers check caller-side prop correctness, not this in-component dead-input direction. Conservative: Vue abstains on `$attrs` fallthrough, whole-object props use, defineExpose, defineModel, and imported prop-type aliases; Svelte abstains on rest, computed, nested, and whole-object `$props()` shapes; React abstains on rest spread (`{...rest}`), props forwarded by spread, props passed wholesale to a hook, `forwardRef` / imported-interface props, and exported public-API component props. Default warn; suppress or remove the prop.",
335        docs_path: "explanations/dead-code#unused-component-props",
336    },
337    RuleDef {
338        id: "fallow/unused-component-emit",
339        category: "Dead code",
340        name: "Unused component emits",
341        short: "A Vue <script setup> defineEmits event is emitted nowhere in its own component",
342        full: "A Vue `<script setup>` defineEmits declared event that is emitted nowhere in its own component (no `emit('<name>')` call). vue-tsc / Volar check caller-side emit correctness, not this in-component dead-output direction. Conservative: abstains on `$attrs` fallthrough, whole-object emit use, defineExpose, defineModel, and imported emit-type aliases. Default warn; suppress or remove the emit.",
343        docs_path: "explanations/dead-code#unused-component-emits",
344    },
345    RuleDef {
346        id: "fallow/unused-component-input",
347        category: "Dead code",
348        name: "Unused component inputs",
349        short: "An Angular @Input() / signal input() / model() input is read nowhere in its own component",
350        full: "An Angular `@Input()` / signal `input()` / `model()` declared input that is read nowhere in its own component (neither the inline / external template nor the class body). The Angular compiler never flags a declared-but-unread `@Input`, and there is no `@angular-eslint` rule for it. Conservative: usage detection over-credits by design (a template sentinel ref, any class-body member access by that name, or a bare identifier read counts as used), and the whole component abstains on an unresolved `extends` heritage clause (a base class in another file may read the input). A `model()` is recorded as an input only. Default warn; suppress or remove the input. The check runs only when the project declares `@angular/core`.",
351        docs_path: "explanations/dead-code#unused-component-inputs",
352    },
353    RuleDef {
354        id: "fallow/unused-component-output",
355        category: "Dead code",
356        name: "Unused component outputs",
357        short: "An Angular @Output() / signal output() output is emitted nowhere in its own component",
358        full: "An Angular `@Output()` / signal `output()` declared output that is emitted nowhere in its own component (no `this.<output>.emit(...)`). The Angular compiler never flags a declared-but-unemitted `@Output`, and there is no `@angular-eslint` rule for it. Conservative: usage detection over-credits by design (a `this.<output>.emit` call site, or any value read of `this.<output>` that might forward it, counts as used), and the whole component abstains on an unresolved `extends` heritage clause. A `model()`-derived implicit output is never flagged. Default warn; suppress or remove the output. The check runs only when the project declares `@angular/core`.",
359        docs_path: "explanations/dead-code#unused-component-outputs",
360    },
361    RuleDef {
362        id: "fallow/unused-svelte-event",
363        category: "Dead code",
364        name: "Unused Svelte events",
365        short: "A Svelte component dispatches a createEventDispatcher event whose name is listened to nowhere in the project",
366        full: "A Svelte component that dispatches a custom event via `createEventDispatcher` (`const dispatch = createEventDispatcher(); dispatch('save')`) whose event name is listened to NOWHERE in the analyzed project. This is the cross-file dead-OUTPUT direction: the component fires an event nothing handles. No native tool covers the listener side: eslint-plugin-svelte and svelte-check are single-file / type-only. fallow builds a project-wide listened-event set from every component-tag `on:<name>` binding (event forwarding, an `on:<name>` with no handler, counts as a listen), then flags a dispatched event whose name is in no listened set. Conservative (zero false positives): the whole component abstains on a dynamic `dispatch(<nonLiteral>)` (the event name is unknowable) or a `dispatch` reference forwarded as a value; a DOM `on:click` on a lowercase element is NOT a custom event and is ignored; and any listener on any component anywhere credits the name (the liberal over-credit, false-negative-safe direction). Default warn; remove the dispatched event or wire a listener. The check runs only when the project declares `svelte`.",
367        docs_path: "explanations/dead-code#unused-svelte-events",
368    },
369    RuleDef {
370        id: "fallow/unused-effect-layer",
371        category: "Dead code",
372        name: "Unused Effect layers",
373        short: "An Effect layer is composed only into layers that nothing uses",
374        full: "An Effect `Layer` definition (a module-scope const or a class static property such as `static layer = Layer.effect(this, make)`) whose every reference sits inside other layer definitions that are themselves unused. The layer never reaches `Effect.provide`, `ManagedRuntime.make`, `Layer.launch` or any other runtime use. fallow builds a layer graph from `Layer.*` initializers and `.pipe(Layer.*)` chains. Any value reference outside a layer definition is a root, including references in functions and tests. A layer with zero references is not reported here: `unused-export` or `unused-class-member` reports it, so the rule reports the tail of a dead composition and names the unused consumers. Default warn. The check runs only when the project declares `effect`.",
375        docs_path: "explanations/dead-code#unused-effect-layers",
376    },
377    RuleDef {
378        id: "fallow/unused-tagged-error",
379        category: "Dead code",
380        name: "Unused tagged errors",
381        short: "An Effect tagged error class is referenced only as a type or a catchTag string, and no code constructs or fails with it",
382        full: "A class that extends `Data.TaggedError(\"X\")` or `Schema.TaggedError<Self>()(\"X\", ...)` that type positions or `catchTag(\"X\")` handlers reference, but that no code reads as a value. Any value reference counts as a producer: `new X()`, `X.make`, `Schema.Union(X)`, an API or RPC error declaration that decodes the error at a boundary, or passing the class to a function. Only type positions and catch-tag strings do not count. A class with zero references is left to `unused-export`. The finding lists the `catchTag` handlers of the tag. Default warn. The check runs only when the project declares `effect`.",
383        docs_path: "explanations/dead-code#unused-tagged-errors",
384    },
385    RuleDef {
386        id: "fallow/unproduced-catch-tag",
387        category: "Dead code",
388        name: "Unproduced catch tags",
389        short: "A catchTag handler names a project error tag that no code produces",
390        full: "A `catchTag(\"X\", ...)` or `catchTags({ X: ... })` handler where every project class with tag `X` is never constructed or failed with, and no object literal `_tag: \"X\"` or tagged constructor produces the tag. A tag that no project class declares can come from a package, so the rule abstains. Effect built-in tags such as `TimeoutException` are never reported. The rule reports a handler only when no `unused-tagged-error` finding covers its classes: the error rule is off, or its finding is suppressed. Default warn. The check runs only when the project declares `effect`.",
391        docs_path: "explanations/dead-code#unproduced-catch-tags",
392    },
393    RuleDef {
394        id: "fallow/unused-server-action",
395        category: "Dead code",
396        name: "Unused server actions",
397        short: "A Next.js Server Action exported from a \"use server\" file is referenced by no code in the project",
398        full: "A Next.js Server Action (an export of a `\"use server\"` file) that no code in the project references: no import-and-call, no `action={fn}` JSX binding, no `<form action={fn}>`. This is the cross-graph \"declared but zero consumers\" direction, reclassified out of `unused-export` for `\"use server\"` files so the finding carries the action-specific signal. eslint-plugin-next is single-file and cannot see cross-file usage. It does NOT mean the endpoint is unreachable: Next.js still registers a generated action id, so it stays POST-able; it means no project code references it (likely forgotten or dead, and a candidate for removal to shrink surface area). Default warn; wire the action to a consumer or remove it. The check runs only when the project declares `next`.",
399        docs_path: "explanations/dead-code#unused-server-actions",
400    },
401    RuleDef {
402        id: "fallow/unused-load-data-key",
403        category: "Dead code",
404        name: "Unused load data keys",
405        short: "A SvelteKit load() return-object key is read by no consumer",
406        full: "A SvelteKit route `load()` (in `+page.ts` / `+page.server.ts` and the `.js` variants) returns an object whose keys become the route's `data` prop. A returned key that NO consumer reads is dead: it runs a real server-side fetch / DB cost on every request for data nothing renders. fallow checks two channels: the sibling `+page.svelte`'s `data.<key>` reads (route-pinned), and project-wide `page.data.<key>` (Svelte 5 `$app/state`) / `$page.data.<key>` (Svelte 4 `$app/stores`) reads in any component. `svelte-check` types `data` via generated `$types` but never flags an unread RETURNED key. The detector abstains (never false-flags) on a spread / non-literal / multi-return / computed-key / wrapped `load`, on a sibling that passes the whole `data` object opaquely, on a `+page.server.ts` whose universal `+page.ts` sibling forwards its `data`, and project-wide when any whole-object use of `page.data` / `$page.data` is seen. Default warn; delete the key or wire a consumer. A load fetch can have side effects, so there is no safe auto-fix. The check runs only when the project declares `@sveltejs/kit`.",
407        docs_path: "explanations/dead-code#unused-load-data-keys",
408    },
409    RuleDef {
410        id: "fallow/prop-drilling",
411        category: "Dead code",
412        name: "Prop drilling",
413        short: "A React/Preact prop is forwarded unchanged through 3+ pass-through components to a distant consumer",
414        full: "A React/Preact prop is received by a component, forwarded UNCHANGED to a child, and forwarded again through two or more intermediate \"pass-through\" components until a component that substantively uses it. The high-confidence signal is that the received identifier appears ONLY as the root of forwarded child-JSX attribute values (so `<Child userName={user.name}/>` counts: the prop `user` is projected forward), not the attribute name matching. fallow emits located per-chain records (the source, each pass-through hop, and the consumer with file + line + component name) so CI and an agent can act: colocate the consumer with the data, lift the value to a React context/provider at a mid-chain hop, or compose the component so the intermediates no longer thread the prop. This is a graph-derived health signal, not a correctness error. The rule defaults to OFF (opt-in), like private-type-leak and the security rules: enable it with `prop-drilling: \"warn\"` in `rules`. Set `prop-drilling: \"error\"` to enforce remaining chains in CI. Warnings remain advisory even with strict flags. File overrides resolve at the source hop and can activate the rule when the base setting is off. Suppressed or baselined chains do not gate. Zero false positives by construction: any `{...props}` spread, `cloneElement`, element-as-prop / render-prop / children-as-function, or context `*.Provider` anywhere in the chain abstains the whole chain, as does an ambiguous or unresolvable hop. The check runs only when the project declares `react` / `react-dom` / `next` / `preact`.",
415        docs_path: "explanations/dead-code#prop-drilling",
416    },
417    RuleDef {
418        id: "fallow/thin-wrapper",
419        category: "Dead code",
420        name: "Thin wrapper",
421        short: "A React/Preact component whose whole body is a single spread-forwarded child render (a candidate for inlining)",
422        full: "A React/Preact component whose ENTIRE body is structural indirection: it returns exactly one capitalized component element that forwards the component's own props via a bare spread (`return <Child {...props}/>`), with no host-element wrapper, no extra children, no named attributes alongside the spread, no hooks, no branching, and no other statements. Such a component adds nothing of its own: it is a CANDIDATE for inlining at its call sites or deleting, not a correctness error. fallow emits a located per-wrapper record (file + line + the wrapper and child component names) so CI and an agent can act. The rule defaults to OFF (opt-in), like prop-drilling and the security rules: enable it with `thin-wrapper: \"warn\"` in `rules`. Zero false positives by construction: a `forwardRef` / `memo` wrapper (the sanctioned way to make a child ref-able or set a perf boundary), an EXPORTED component (a public-API re-brand / encapsulation), a context `*.Provider` wrapper, a `cloneElement` / render-prop forward, a wrapper that passes ANY named attribute alongside the spread (a fixed configuration), a self-render, or an unresolvable / member-expression child all abstain. A TypeScript-only type-narrowing wrapper (`const StrictButton = (p: StrictProps) => <Button {...p}/>`) is a known limitation under ADR-001's syntactic analysis; suppress it with the inline comment. The check runs only when the project declares `react` / `react-dom` / `next` / `preact`.",
423        docs_path: "explanations/dead-code#thin-wrapper",
424    },
425    RuleDef {
426        id: "fallow/duplicate-prop-shape",
427        category: "Dead code",
428        name: "Duplicate prop shape",
429        short: "Three or more React/Preact components across two or more files declare an identical prop-name set (a missing shared Props type)",
430        full: "Three or more distinct React/Preact components, living in two or more files, whose statically-harvested prop NAME set is byte-for-byte IDENTICAL after (a) excluding a fixed denylist of ubiquitous DOM / render-passthrough prop names (className, style, id, children, key, ref, the common event handlers, plus data-* / aria-* by prefix) and (b) requiring the REMAINING significant set to have four or more members. Identity is over NAMES only, never types (ADR-001 cannot resolve types). This is a structural-refactor health signal: the recurring shape is a missing shared abstraction, so extract one shared `Props` type (or a base component) that every member reuses. It is never a correctness error and never an auto-fix. fallow emits one located record per participating component, each naming the shared `shape`, the `group_size`, and the OTHER members in `sharing_components`. The rule defaults to OFF (opt-in), like thin-wrapper and the security rules: enable it with `duplicate-prop-shape: \"warn\"` in `rules`. Anti-noise gates (defended as rule-of-three plus a denylist-survivor floor, not tuned magic): the four-significant-prop floor turns `{label, onClick}` buttons into non-findings; the three-component floor is the rule-of-three abstraction trigger; the two-file floor keeps a local same-shaped variant pair (a render-prop pair, a Foo/FooImpl split) unflagged. A component whose props are not fully harvestable (a rest/spread signature, a forwardRef/memo over an imported interface) ABSTAINS, because a partial prop set can never be proven identical. Exact full-set identity ONLY: a superset / subset relationship does NOT group, so a four-prop group and a five-prop superset form TWO findings (the price of zero invalid groups: the finding always fits one extracted shared type). The check runs only when the project declares `react` / `react-dom` / `next` / `preact`.",
431        docs_path: "explanations/dead-code#duplicate-prop-shape",
432    },
433    RuleDef {
434        id: "fallow/route-collision",
435        category: "Policy",
436        name: "Route collision",
437        short: "Two or more Next.js App Router route files resolve to the same URL",
438        full: "Two or more App Router route files (a `page` or a `route` handler) resolve to the SAME URL within one app-root. Route groups `(name)` and parallel slots `@name` do not change the URL, so `app/(marketing)/about/page.tsx` and `app/(shop)/about/page.tsx` both own `/about`. Next.js fails the build (\"You cannot have two parallel pages that resolve to the same path\") because a URL can have at most one owner, whether a Page or a Route Handler. fallow surfaces every colliding file at once; the build error names only one. Buckets are scoped per app-root (per workspace package), so a monorepo with several independent Next apps sharing a path is not flagged. Files under a private `_folder` or an intercepting marker `(.)`/`(..)`/`(...)` are excluded. There is no safe auto-fix: move or merge one of the files so each URL has a single owner. The check runs only when the project declares `next`.",
439        docs_path: "explanations/dead-code#route-collisions",
440    },
441    RuleDef {
442        id: "fallow/dynamic-segment-name-conflict",
443        category: "Policy",
444        name: "Dynamic segment name conflict",
445        short: "Sibling Next.js dynamic route segments use different slug names at the same position",
446        full: "Two or more sibling dynamic route segments at the same App Router tree position use different param spellings (`[id]` vs `[slug]`, or a catch-all `[...x]` vs an optional catch-all `[[...x]]`). Next.js throws \"You cannot use different slug names for the same dynamic path\" at dev and production runtime when the position is hit, because one position must resolve to a single param name. `next build` does NOT catch this (the build succeeds), so CI passes while the route crashes on its first request; fallow's static catch closes that gap. Route groups are transparent to the position and parallel slots fork it, so only genuinely-sibling segments conflict. To fix: rename the dynamic segments at the position to one consistent slug name. The check runs only when the project declares `next`.",
447        docs_path: "explanations/dead-code#dynamic-segment-name-conflicts",
448    },
449];
450
451/// Look up a rule definition by its SARIF rule ID across all rule sets.
452#[must_use]
453pub fn rule_by_id(id: &str) -> Option<&'static RuleDef> {
454    CHECK_RULES
455        .iter()
456        .chain(HEALTH_RULES.iter())
457        .chain(DUPES_RULES.iter())
458        .chain(FLAGS_RULES.iter())
459        .chain(SECURITY_RULES.iter())
460        .chain(AUDIT_RULES.iter())
461        .find(|r| r.id == id)
462}
463
464/// Every registered rule in registry order: dead-code, health, duplication,
465/// flags, security, then audit. The order is the `fallow schema`
466/// `issue_types` order and the `fallow://issue-types` resource order.
467pub fn all_rules() -> impl Iterator<Item = &'static RuleDef> {
468    CHECK_RULES
469        .iter()
470        .chain(HEALTH_RULES.iter())
471        .chain(DUPES_RULES.iter())
472        .chain(FLAGS_RULES.iter())
473        .chain(SECURITY_RULES.iter())
474        .chain(AUDIT_RULES.iter())
475}
476
477/// The command family a rule reports under (`dead-code`, `health`, `dupes`,
478/// `flags`, `security`, or `audit`), derived from the registry array that owns it.
479/// Membership is by id (unique across registries); the registries are
480/// `const` slices, so pointer identity is not stable across uses.
481#[must_use]
482pub fn rule_command(rule: &RuleDef) -> &'static str {
483    let owns = |rules: &[RuleDef]| rules.iter().any(|candidate| candidate.id == rule.id);
484    if owns(HEALTH_RULES) {
485        "health"
486    } else if owns(DUPES_RULES) {
487        "dupes"
488    } else if owns(FLAGS_RULES) {
489        "flags"
490    } else if owns(SECURITY_RULES) {
491        "security"
492    } else if owns(AUDIT_RULES) {
493        "audit"
494    } else {
495        "dead-code"
496    }
497}
498
499/// The rule id without its `fallow/` or `security/` namespace prefix, which
500/// is the canonical issue code (`unused-export`, `sql-injection`).
501#[must_use]
502pub fn bare_rule_id(rule: &RuleDef) -> &'static str {
503    rule.id.split_once('/').map_or(rule.id, |(_, bare)| bare)
504}
505
506/// The `rules.*` config key whose default severity gates findings of `rule`:
507/// the rule's own `config_key` for a 1:1 rule, else the key of the shared rule
508/// its suppression token names (every tainted-sink catalogue category is gated
509/// by `security-sink`, coverage findings by `coverage-gaps`). `None` for
510/// findings with no `rules.*` gate at all (complexity and duplication
511/// metrics, refactoring targets, runtime-coverage verdicts); a suppression
512/// token that is not a `rules.*` key (`code-duplication`, `feature-flag`)
513/// yields `None` too, so every returned key resolves in
514/// [`crate::schemas::default_rule_severities`].
515///
516/// Shared by `fallow schema` and the `fallow://issue-types` MCP resource so
517/// the two never disagree on which default severity a finding inherits.
518#[must_use]
519pub fn rule_severity_key(rule: &RuleDef) -> Option<&'static str> {
520    let bare = bare_rule_id(rule);
521    let candidate = fallow_types::issue_meta::issue_meta_by_code(bare)
522        .and_then(|meta| meta.config_key.or(meta.suppress_token))
523        .or_else(|| match rule_command(rule) {
524            "security" => Some(if bare == "client-server-leak" {
525                "security-client-server-leak"
526            } else {
527                "security-sink"
528            }),
529            "health" if matches!(bare, "untested-file" | "untested-export") => {
530                Some("coverage-gaps")
531            }
532            _ => None,
533        })?;
534    crate::schemas::is_rule_severity_key(candidate).then_some(candidate)
535}
536
537/// Build the docs URL for a rule.
538#[must_use]
539pub fn rule_docs_url(rule: &RuleDef) -> String {
540    let docs_path = rule_result_meta(rule).map_or(rule.docs_path, |meta| meta.meta_docs_path);
541    fallow_output::rule_docs_url(docs_path)
542}
543
544fn rule_result_meta(rule: &RuleDef) -> Option<&'static fallow_types::issue_meta::IssueResultMeta> {
545    let code = rule.id.strip_prefix("fallow/")?;
546    fallow_types::issue_meta::issue_result_meta_by_code(code)
547}
548
549fn rule_explain_name(rule: &RuleDef) -> &'static str {
550    rule_result_meta(rule).map_or(rule.name, |meta| meta.meta_name)
551}
552
553fn rule_explain_summary(rule: &RuleDef) -> &'static str {
554    rule_result_meta(rule).map_or(rule.short, |meta| meta.sarif_description)
555}
556
557/// Extra educational content for the standalone `fallow explain <issue-type>`
558/// command. Kept separate from [`RuleDef`] so SARIF and `_meta` payloads remain
559/// compact while terminal users and agents can ask for worked examples on
560/// demand.
561pub struct RuleGuide {
562    /// Worked code example illustrating the issue.
563    pub example: &'static str,
564    /// Step-by-step remediation guidance.
565    pub how_to_fix: &'static str,
566}
567
568/// Look up an issue type from a user-facing token.
569///
570/// Accepts canonical SARIF ids (`fallow/unused-export`), issue tokens
571/// (`unused-export`), and common CLI filter spellings (`unused-exports`).
572#[must_use]
573pub fn rule_by_token(token: &str) -> Option<&'static RuleDef> {
574    let trimmed = token.trim();
575    if trimmed.is_empty() {
576        return None;
577    }
578    if let Some(rule) = rule_by_id(trimmed) {
579        return Some(rule);
580    }
581    let normalized = trimmed
582        .strip_prefix("fallow/")
583        .unwrap_or(trimmed)
584        .trim_start_matches("--")
585        .replace('_', "-")
586        .split_whitespace()
587        .collect::<Vec<_>>()
588        .join("-");
589    if let Some(rule) = dead_code_registry_rule(&normalized) {
590        return Some(rule);
591    }
592    if let Some(rule) = rule_by_id(&format!("fallow/{normalized}")) {
593        return Some(rule);
594    }
595    let alias = health_alias_id(&normalized).or_else(|| security_alias_id(&normalized));
596    if let Some(id) = alias
597        && let Some(rule) = rule_by_id(id)
598    {
599        return Some(rule);
600    }
601    let security_token = normalized.strip_prefix("security-").unwrap_or(&normalized);
602    let security_id = format!("security/{security_token}");
603    if let Some(rule) = rule_by_id(&security_id) {
604        return Some(rule);
605    }
606    let singular = normalized
607        .strip_suffix('s')
608        .filter(|_| normalized != "unused-class")
609        .unwrap_or(&normalized);
610    let singular_security_token = singular.strip_prefix("security-").unwrap_or(singular);
611    let singular_security_id = format!("security/{singular_security_token}");
612    if let Some(rule) = rule_by_id(&singular_security_id) {
613        return Some(rule);
614    }
615    let id = format!("fallow/{singular}");
616    rule_by_id(&id).or_else(|| {
617        CHECK_RULES
618            .iter()
619            .chain(HEALTH_RULES.iter())
620            .chain(DUPES_RULES.iter())
621            .chain(FLAGS_RULES.iter())
622            .chain(SECURITY_RULES.iter())
623            .chain(AUDIT_RULES.iter())
624            .find(|rule| {
625                rule.docs_path.ends_with(&normalized)
626                    || rule.docs_path.ends_with(singular)
627                    || rule_result_meta(rule).is_some_and(|meta| {
628                        meta.meta_docs_path.ends_with(&normalized)
629                            || meta.meta_docs_path.ends_with(singular)
630                            || meta.meta_name.eq_ignore_ascii_case(trimmed)
631                    })
632                    || rule.name.eq_ignore_ascii_case(trimmed)
633            })
634    })
635}
636
637fn dead_code_registry_rule(normalized: &str) -> Option<&'static RuleDef> {
638    let meta = fallow_types::issue_meta::issue_meta_for_contract_token(normalized)?;
639    CHECK_RULES
640        .iter()
641        .find(|rule| rule.id.strip_prefix("fallow/") == Some(meta.code))
642}
643
644fn health_alias_id(normalized: &str) -> Option<&'static str> {
645    match normalized {
646        "complexity" | "high-complexity" => Some("fallow/high-complexity"),
647        "cyclomatic" | "high-cyclomatic" | "high-cyclomatic-complexity" => {
648            Some("fallow/high-cyclomatic-complexity")
649        }
650        "cognitive" | "high-cognitive" | "high-cognitive-complexity" => {
651            Some("fallow/high-cognitive-complexity")
652        }
653        "crap" | "high-crap" | "high-crap-score" => Some("fallow/high-crap-score"),
654        "duplication" | "dupes" | "code-duplication" => Some("fallow/code-duplication"),
655        "feature-flag" | "feature-flags" | "flags" => Some("fallow/feature-flag"),
656        "flag-retirement" | "flag-retirement-candidate" | "retirement" => {
657            Some("fallow/flag-retirement-candidate")
658        }
659        _ => None,
660    }
661}
662
663fn security_alias_id(normalized: &str) -> Option<&'static str> {
664    match normalized {
665        "security"
666        | "security-candidate"
667        | "security-candidates"
668        | "tainted-sink"
669        | "tainted-sinks"
670        | "security-sink"
671        | "security-sinks" => Some("security/tainted-sink"),
672        "client-server-leak"
673        | "client-server-leaks"
674        | "security-client-server-leak"
675        | "security-client-server-leaks" => Some("security/client-server-leak"),
676        "hardcoded-secret" | "hardcoded-secrets" | "hard-coded-secret" | "hard-coded-secrets" => {
677            Some("security/hardcoded-secret")
678        }
679        _ => None,
680    }
681}
682
683/// Return worked-example and fix guidance for a rule.
684#[must_use]
685pub fn rule_guide(rule: &RuleDef) -> RuleGuide {
686    source_dead_code_rule_guide(rule.id)
687        .or_else(|| member_import_rule_guide(rule.id))
688        .or_else(|| architecture_rule_guide(rule.id))
689        .or_else(|| catalog_rule_guide(rule.id))
690        .or_else(|| health_runtime_rule_guide(rule.id))
691        .or_else(|| duplication_rule_guide(rule.id))
692        .or_else(|| security_rule_guide(rule.id))
693        .or_else(|| audit_rule_guide(rule.id))
694        .unwrap_or_else(fallback_rule_guide)
695}
696
697fn audit_rule_guide(id: &str) -> Option<RuleGuide> {
698    Some(match id {
699        "fallow/weakened-tests" => RuleGuide {
700            example: "A change turns `it('charges tax', ...)` into `it.skip('charges tax', ...)`, or lowers `coverage.thresholds.lines` from 90 to 70.",
701            how_to_fix: "Decide if the weaker test or threshold is intended. If it is, suppress the finding with `// fallow-ignore-next-line weakened-tests` (or `fallow-ignore-file` for a file-level kind), or set the rule to `off` for the path in `overrides`.",
702        },
703        "fallow/added-suppression" => RuleGuide {
704            example: "A change adds `// @ts-expect-error` above a call instead of a correct type.",
705            how_to_fix: "Decide if the suppression is necessary. If it is, keep it and suppress the finding with `// fallow-ignore-next-line added-suppression`, or turn the rule off for the path.",
706        },
707        "fallow/test-only-branch" => RuleGuide {
708            example: "A change adds `if (process.env.NODE_ENV === 'test') return cached;` to `src/pricing.ts`.",
709            how_to_fix: "Prefer a seam that tests can inject, such as a parameter or a module mock. If the branch is intended, suppress it with `// fallow-ignore-next-line test-only-branch`.",
710        },
711        "fallow/diverged-clone-sibling" => RuleGuide {
712            example: "`src/a/total.ts` and `src/b/total.ts` held the same function. The change fixes a bug in the first copy only.",
713            how_to_fix: "Check the unchanged copies in `related`. Apply the same change there, or extract a shared function. If the copies must differ, suppress with `// fallow-ignore-next-line diverged-clone-sibling`.",
714        },
715        "fallow/added-dependency" => RuleGuide {
716            example: "A change adds `\"left-pad\": \"^1.3.0\"` to `dependencies`.",
717            how_to_fix: "Check that the package exists, is maintained, and is not already covered by a dependency of the project. Suppress through `overrides` because `package.json` cannot hold a comment.",
718        },
719        _ => return None,
720    })
721}
722
723fn source_dead_code_rule_guide(id: &str) -> Option<RuleGuide> {
724    Some(match id {
725        "fallow/unused-file" => RuleGuide {
726            example: "src/old-widget.ts is not imported by any entry point, route, script, or config file.",
727            how_to_fix: "Delete the file if it is genuinely dead. If a framework loads it implicitly, add the right plugin/config pattern or mark it in alwaysUsed.",
728        },
729        "fallow/unused-export" => RuleGuide {
730            example: "export const formatPrice = ... exists in src/money.ts, but no module imports formatPrice.",
731            how_to_fix: "Remove the export or make it file-local. If it is public API, import it from an entry point or add an intentional suppression with context.",
732        },
733        "fallow/unused-type" => RuleGuide {
734            example: "export interface LegacyProps is exported, but no module imports the type.",
735            how_to_fix: "Remove the type export, inline it, or keep it behind an explicit API entry point when consumers rely on it.",
736        },
737        "fallow/private-type-leak" => RuleGuide {
738            example: "export function makeUser(): InternalUser exposes InternalUser even though InternalUser is not exported.",
739            how_to_fix: "Export the referenced type, change the public signature to an exported type, or keep the helper private.",
740        },
741        "fallow/deprecated-export-in-use" => RuleGuide {
742            example: "/** @deprecated Use formatMoney. */ export function formatPrice() is still imported by src/cart.ts and src/checkout.ts.",
743            how_to_fix: "Move each consumer to the replacement the message names, then remove the export. For the full consumer list, run `fallow dead-code --trace <file>:<export>`. Enable the rule with `deprecated-exports-in-use: \"warn\"` in `rules`, or pass `--deprecated-exports-in-use` for one run.",
744        },
745        "fallow/unused-dependency"
746        | "fallow/unused-dev-dependency"
747        | "fallow/unused-optional-dependency" => RuleGuide {
748            example: "package.json lists left-pad, but no source, script, config, or plugin-recognized file imports it.",
749            how_to_fix: "Remove the dependency after checking runtime/plugin usage. If another workspace uses it, move the dependency to that workspace.",
750        },
751        "fallow/type-only-dependency" => RuleGuide {
752            example: "zod is in dependencies but only appears in import type declarations.",
753            how_to_fix: "Move the package to devDependencies unless runtime code imports it as a value.",
754        },
755        "fallow/test-only-dependency" => RuleGuide {
756            example: "vitest is listed in dependencies, but only test files import it.",
757            how_to_fix: "Move the package to devDependencies unless production code imports it at runtime.",
758        },
759        "fallow/dev-dependency-in-production" => RuleGuide {
760            example: "yaml is in devDependencies, but src/config.ts imports { parse } from 'yaml' and runs it at runtime.",
761            how_to_fix: "Move the package to dependencies when the deployment installs them, so a production-only install keeps it. Leave it in devDependencies if the build inlines it into the output, if the only production imports are `import type`, or if another manifest section (dependencies / peer / optional) already provides it.",
762        },
763        _ => return None,
764    })
765}
766
767fn member_import_rule_guide(id: &str) -> Option<RuleGuide> {
768    Some(match id {
769        "fallow/unused-enum-member" => RuleGuide {
770            example: "Status.Legacy remains in an exported enum, but no code reads that member.",
771            how_to_fix: "Remove the member after checking serialized/API compatibility, or suppress it with a reason when external data still uses it.",
772        },
773        "fallow/unused-class-member" => RuleGuide {
774            example: "class Parser has a public parseLegacy method that is never called in the project.",
775            how_to_fix: "Remove or privatize the member. For reflection/framework lifecycle hooks, configure or suppress the intentional entry point.",
776        },
777        "fallow/unused-store-member" => RuleGuide {
778            example: "useCartStore declares a discountTotal getter that no component, composable, or other store ever reads.",
779            how_to_fix: "Remove the unused state property, getter, or action. If it is consumed reflectively (a Pinia plugin, $onAction, or dynamic dispatch), suppress the line with // fallow-ignore-next-line unused-store-member.",
780        },
781        "fallow/unprovided-inject" => RuleGuide {
782            example: "A component calls inject(ThemeKey) (Vue) or getContext(ThemeKey) (Svelte) with an imported symbol key, but no provide(ThemeKey) / setContext(ThemeKey) exists anywhere in the project.",
783            how_to_fix: "Add a matching provide() / setContext() for the key, or remove the dead inject() / getContext(). If a provider lives outside the analyzed graph (an app-level provide registered elsewhere, a plugin, a host app), suppress the line with // fallow-ignore-next-line unprovided-inject.",
784        },
785        "fallow/unrendered-component" => RuleGuide {
786            example: "components/Orphan.vue is re-exported from a barrel (export { default as Orphan } from './Orphan.vue') but no template, registration, h() call, or dynamic import ever renders it.",
787            how_to_fix: "Render the component where it belongs, or delete it and remove the dead barrel re-export. If it is rendered reflectively (a dynamic <component :is> from a non-literal value), suppress the line with // fallow-ignore-next-line unrendered-component.",
788        },
789        "fallow/absent-component-prop" => RuleGuide {
790            example: "Card declares highlight?: boolean with a false default, reads highlight in its render body, and every inspected reachable caller renders <Card /> without highlight.",
791            how_to_fix: "Review inspected callers, defaults and API intent. Keep intentional stable props, update the component manually, or add a declaration-line fallow-ignore-next-line absent-component-prop comment. This candidate has no automatic fix.",
792        },
793        "fallow/unused-component-prop" => RuleGuide {
794            example: "Widget.vue declares defineProps<{ size: string }>(), or a React Widget({ size }) destructures `size`, but `size` is referenced nowhere in the component (Vue: its script or template; React: its function body or JSX).",
795            how_to_fix: "Remove the unused prop, or reference it in the component (Vue: the script / template; React: the function body or JSX). If the prop is part of a deliberately-stable public component API, suppress the line with // fallow-ignore-next-line unused-component-prop.",
796        },
797        "fallow/unused-component-emit" => RuleGuide {
798            example: "Widget.vue declares defineEmits<{ close: [] }>() but `emit('close')` is called nowhere in the component's script.",
799            how_to_fix: "Remove the unused emit, or emit it in the script. If the emit is part of a deliberately-stable public component API, suppress the line with // fallow-ignore-next-line unused-component-emit.",
800        },
801        "fallow/unused-component-input" => RuleGuide {
802            example: "user-card.component.ts declares @Input() size: string (or size = input<string>()) but `size` is read nowhere in the template or the class body.",
803            how_to_fix: "Remove the unused input, or read it in the template or class body. If the input is part of a deliberately-stable public component API, suppress the line with // fallow-ignore-next-line unused-component-input.",
804        },
805        "fallow/unused-component-output" => RuleGuide {
806            example: "user-card.component.ts declares @Output() close = new EventEmitter<void>() (or close = output<void>()) but `this.close.emit(...)` is called nowhere in the class.",
807            how_to_fix: "Remove the unused output, or emit it from the class. If the output is part of a deliberately-stable public component API, suppress the line with // fallow-ignore-next-line unused-component-output.",
808        },
809        "fallow/unused-svelte-event" => RuleGuide {
810            example: "Child.svelte calls const dispatch = createEventDispatcher(); dispatch('dead'), but no parent listens for it (no <Child on:dead> anywhere in the project).",
811            how_to_fix: "Remove the dispatched event, or listen for it on the component (<Child on:dead={...}> or forward it via <Child on:dead>). If the event is dispatched reflectively (a dynamic name) or is part of a deliberately-stable public component API, suppress the line with // fallow-ignore-next-line unused-svelte-event.",
812        },
813        "fallow/unused-effect-layer" => RuleGuide {
814            example: "services.ts defines const CacheLive = Cache.layer.pipe(Layer.provide(Db.layer)) and export const OrphanLive = Layer.mergeAll(CacheLive), but nothing provides OrphanLive.",
815            how_to_fix: "Remove the unused consumer layers first, then this layer, or compose the layer into a layer that reaches a runtime. If code outside the analyzed project composes it, suppress the line with // fallow-ignore-next-line unused-effect-layer.",
816        },
817        "fallow/unused-tagged-error" => RuleGuide {
818            example: "errors.ts declares class Expired extends Data.TaggedError(\"Expired\"), signatures list it in the error channel and a handler calls catchTag(\"Expired\"), but no code constructs Expired or fails with it.",
819            how_to_fix: "Fail with the error where the condition occurs, or remove the class, its type references and its catchTag handlers. If consumers outside the project construct or decode it, suppress the line with // fallow-ignore-next-line unused-tagged-error.",
820        },
821        "fallow/unproduced-catch-tag" => RuleGuide {
822            example: "main.ts calls Effect.catchTag(\"Expired\", ...), the only class with tag Expired is never constructed, and the unused-tagged-error finding for it is suppressed.",
823            how_to_fix: "Remove the handler, or fail with the error where the condition occurs. If a package or code outside the project produces the tag, suppress the line with // fallow-ignore-next-line unproduced-catch-tag.",
824        },
825        "fallow/unused-server-action" => RuleGuide {
826            example: "app/actions.ts has \"use server\" and exports submitForm, but no component imports it, binds it via action={submitForm}, or uses it in <form action={submitForm}>.",
827            how_to_fix: "Wire the action to a consumer (an import-and-call, an action={fn} binding, or a <form action={fn}>), or remove it. If it is invoked reflectively (an action registry dispatching by id, or a non-JS caller), suppress the line with // fallow-ignore-next-line unused-server-action.",
828        },
829        "fallow/unused-load-data-key" => RuleGuide {
830            example: "src/routes/blog/+page.ts returns { posts, draftCount } but +page.svelte only reads data.posts and no component reads page.data.draftCount.",
831            how_to_fix: "Delete the unused key from the load() return (and skip its fetch), or wire a consumer (read data.<key> in +page.svelte, or page.data.<key> in a shared component). If the load fetch has a side effect you must keep, suppress the line with // fallow-ignore-next-line unused-load-data-key.",
832        },
833        "fallow/prop-drilling" => RuleGuide {
834            example: "Page receives `user` and renders <Layout user={user}/>; Layout only re-passes it to <Sidebar user={user}/>; Sidebar only re-passes it to <Profile user={user}/>, which finally reads user.name. The prop is drilled through Layout and Sidebar untouched.",
835            how_to_fix: "Collapse the chain: colocate the consumer with the data, lift the value into a React context/provider at a mid-chain hop and consume it there, or compose the component (pass the rendered child as children) so the intermediates no longer thread the prop. Enable the rule with rules.prop-drilling = \"warn\" (it defaults to off). To accept one chain, suppress the source prop with // fallow-ignore-next-line prop-drilling.",
836        },
837        "fallow/thin-wrapper" => RuleGuide {
838            example: "const ButtonWrapper = (props) => <Button {...props}/>; the wrapper has no own markup, hooks, or logic, so it only re-points at Button.",
839            how_to_fix: "Inline the wrapper at its call sites (use <Button .../> directly) or delete it. Keep it only if it is a deliberate seam (a planned divergence point, a public-API re-brand): an exported wrapper already abstains. Enable the rule with rules.thin-wrapper = \"warn\" (it defaults to off). To accept one wrapper, suppress it with // fallow-ignore-next-line thin-wrapper above the component definition.",
840        },
841        "fallow/duplicate-prop-shape" => RuleGuide {
842            example: "FieldText, FieldNumber, and FieldSelect (across three files) each declare exactly { name, label, value, onChange, error }. The five significant prop names are identical, so they form one duplicate-prop-shape group.",
843            how_to_fix: "Extract one shared Props type (e.g. type FieldProps = { name; label; value; onChange; error }) that every member reuses, or a base component the variants compose. Keep them separate only if a per-variant prop divergence is planned. Enable the rule with rules.duplicate-prop-shape = \"warn\" (it defaults to off). To accept one member, suppress it with // fallow-ignore-next-line duplicate-prop-shape above the component definition; the suppressed member still appears in its siblings' sharing_components because the group is real regardless of suppression.",
844        },
845        "fallow/unresolved-import" => RuleGuide {
846            example: "src/app.ts imports ./routes/admin, but no matching file exists after extension and index resolution.",
847            how_to_fix: "Fix the specifier, restore the missing file, install the package, or align tsconfig path aliases with the runtime resolver.",
848        },
849        "fallow/unlisted-dependency" => RuleGuide {
850            example: "Root src/app.ts imports @acme/shared, an npm workspace package. The root package.json lists workspaces but does not list @acme/shared as a dependency, so the import is unlisted even when npm links it into node_modules.",
851            how_to_fix: "Declare the imported package in the owning package.json, including the root manifest for root code. Use dependencies for runtime needs or devDependencies for tooling/tests, with a version accepted by your package manager. Self-references need no declaration. For deliberately ambient packages, use ignoreDependencies as an explicit opt-out.",
852        },
853        "fallow/duplicate-export" => RuleGuide {
854            example: "Button is exported from both src/ui/button.ts and src/components/button.ts.",
855            how_to_fix: "Rename or consolidate the exports so consumers have one intentional import target.",
856        },
857        _ => return None,
858    })
859}
860
861fn architecture_rule_guide(id: &str) -> Option<RuleGuide> {
862    Some(match id {
863        "fallow/circular-dependency" => RuleGuide {
864            example: "src/a.ts imports src/b.ts, and src/b.ts imports src/a.ts.",
865            how_to_fix: "Extract shared code to a third module, invert the dependency, or split initialization-time side effects from type-only contracts.",
866        },
867        "fallow/boundary-violation" => RuleGuide {
868            example: "features/billing imports app/admin even though the configured boundary only allows imports from shared and entities.",
869            how_to_fix: "Move the shared contract to an allowed zone, invert the dependency, or update the boundary config only if the architecture rule was wrong.",
870        },
871        "fallow/boundary-coverage" => RuleGuide {
872            example: "src/generated/client.ts is reachable but does not match any boundaries.zones[].patterns entry.",
873            how_to_fix: "Add the file to the intended zone pattern, move it under a zoned directory, or add a generated-file glob to boundaries.coverage.allowUnmatched.",
874        },
875        "fallow/boundary-call-violation" => RuleGuide {
876            example: "src/domain/policy.ts calls execSync from node:child_process while boundaries.calls.forbidden bans child_process.* from the domain zone.",
877            how_to_fix: "Move the call into a zone that may perform the effect, route it through an allowed abstraction, or narrow the forbidden pattern if the rule was wrong. To suppress, use the boundary family token: `// fallow-ignore-next-line boundary-violation` governs import, coverage, and call findings alike (the rule-id-shaped `boundary-call-violation` is accepted as an alias).",
878        },
879        "fallow/policy-violation" => RuleGuide {
880            example: "src/app.ts imports moment while a rule pack bans the moment specifier with the message 'Use date-fns.'",
881            how_to_fix: "Follow the rule's message to replace banned usage or remove a banned export. For a GDP proof producer, move proof factory creation into an allowed file, or correct the rule's allowedFiles and optional proofKinds if the ownership policy was wrong. To waive one rule, use `// fallow-ignore-next-line policy-violation:<pack>/<rule-id>` or the file-level form. Use bare `policy-violation` only when you intend to suppress every rule-pack finding at that scope.",
882        },
883        "fallow/stale-suppression" => RuleGuide {
884            example: "// fallow-ignore-next-line unused-export remains above an export that is now used.",
885            how_to_fix: "Remove the suppression. If a different issue is still intentional, replace it with a current, specific suppression.",
886        },
887        "fallow/missing-suppression-reason" => RuleGuide {
888            example: "// fallow-ignore-next-line unused-export appears without the required explanatory reason.",
889            how_to_fix: "Add a concise reason after the suppression token, or remove the suppression if the issue is no longer intentional.",
890        },
891        _ => return None,
892    })
893}
894
895fn catalog_rule_guide(id: &str) -> Option<RuleGuide> {
896    Some(match id {
897        "fallow/unused-catalog-entry" => RuleGuide {
898            example: "The catalog source declares `catalog: { is-even: ^1.0.0 }`, but no workspace package.json declares `\"is-even\": \"catalog:\"`.",
899            how_to_fix: "Delete the entry from the catalog source file. If any consumer uses a hardcoded version (surfaced in `hardcoded_consumers`), switch that consumer to `catalog:` first to keep versions aligned.",
900        },
901        "fallow/empty-catalog-group" => RuleGuide {
902            example: "The catalog source declares `catalogs: { react17: {} }` after the last react17 entry was removed.",
903            how_to_fix: "Delete the empty named group from the catalog source file. Comments between the deleted header and the next sibling can stay in place for manual review.",
904        },
905        "fallow/unresolved-catalog-reference" => RuleGuide {
906            example: "packages/app/package.json declares `\"old-react\": \"catalog:react17\"`, but `catalogs.react17` in the catalog source does not declare `old-react`. The package manager install will fail.",
907            how_to_fix: "If `available_in_catalogs` is non-empty, change the reference to one of those catalogs (e.g. `catalog:react18`). Otherwise add the package to the named catalog in the catalog source, or remove the catalog reference and pin a hardcoded version. For staged migrations where the catalog edit lands separately, add the (package, catalog, consumer) triple to `ignoreCatalogReferences` in your fallow config.",
908        },
909        "fallow/unused-dependency-override" => RuleGuide {
910            example: "The root package.json declares `overrides: { axios: ^1.6.0 }`, but no workspace package.json declares `axios` and the active lockfile does not resolve it.",
911            how_to_fix: "Delete the entry from its reported declaration source. If the finding is caused by a stale or missing readable lockfile, refresh the active lockfile and rerun fallow. If the override is intentionally retained, add it to `ignoreDependencyOverrides` in your fallow config.",
912        },
913        "fallow/misconfigured-dependency-override" => RuleGuide {
914            example: "The root package.json declares `overrides: { \"axios\": \"\" }`. An empty override value is invalid and the active package manager will reject or ignore it.",
915            how_to_fix: "Fix the key or value to match the active package manager's grammar. For pnpm this includes bare or scoped package names, version selectors, parent matchers, and the supported `-`, `$ref`, and `npm:alias` values. For npm or Bun, preserve the supported nested object shape. Remove experimental entries that should not remain.",
916        },
917        _ => return None,
918    })
919}
920
921fn health_runtime_rule_guide(id: &str) -> Option<RuleGuide> {
922    Some(match id {
923        "fallow/high-cyclomatic-complexity"
924        | "fallow/high-cognitive-complexity"
925        | "fallow/high-complexity" => RuleGuide {
926            example: "A function contains several nested conditionals, loops, and early exits, exceeding the configured complexity threshold. fallow also flags synthetic template-family findings on markup: Angular .html templates and inline `@Component({ template: ... })` literals, Vue SFC `<template>` blocks, Svelte markup, and Astro markup, plus each top-level Svelte `{#snippet name(...)}` block as its own `<snippet:NAME>` unit. `<component>` rollup findings combine the worst class method with its template.",
927            how_to_fix: "For function findings, extract named helpers, split independent branches, flatten guard clauses, and add tests around the behavior before refactoring. For `<template>` findings, flatten nested control flow and move branch selection out of the markup: Angular `@if`/`@for`/`@switch`/`@defer` and legacy `*ngIf`/`*ngFor` into computed signals on the component class, Vue `v-if`/`v-else-if`/`v-for` into computed properties, Svelte `{#if}`/`{:else if}`/`{#each}`/`{#await}`/`{#key}` into derived state, Astro control flow into props resolved in the frontmatter. In Svelte, moving a repeated or deeply nested block into a top-level `{#snippet}` gives it its own `<snippet:NAME>` unit with nesting rebased to zero, so the in-file extraction moves the score; splitting a large template into child components lowers the score in every dialect. For `<component>` rollup findings, attack the larger half first; the per-half breakdown lives in `component_rollup`. To report these findings without a failed run, set the `complexity-cyclomatic` or `complexity-cognitive` rule to `warn`.",
928        },
929        "fallow/high-crap-score" => RuleGuide {
930            example: "A complex function has little or no matching Istanbul coverage, so its CRAP score crosses the configured gate. Synthetic template-family units (the `<template>` units on Angular, Vue, Svelte and Astro markup, and Svelte `<snippet:NAME>` units) are not scored on this dimension: a template carries no direct coverage of its own, so fallow gates templates on the cyclomatic and cognitive dimensions instead.",
931            how_to_fix: "Add focused tests for the risky branches first, then simplify the function if the score remains high. Template findings never carry this rule, so a `maxCrap` override scoped to a template unit buys nothing and can be removed. To report these findings without a failed run, set the `complexity-crap` rule to `warn`.",
932        },
933        "fallow/refactoring-target" => RuleGuide {
934            example: "A file combines high complexity density, churn, fan-in, and dead-code signals.",
935            how_to_fix: "Start with the listed evidence: remove dead exports, extract complex functions, then reduce fan-out or cycles in small steps.",
936        },
937        "fallow/untested-file" | "fallow/untested-export" => RuleGuide {
938            example: "Production-reachable code has no dependency path from discovered test entry points.",
939            how_to_fix: "Add or wire a test that imports the runtime path, or update entry-point/test discovery if the existing test is invisible to fallow.",
940        },
941        "fallow/runtime-safe-to-delete"
942        | "fallow/runtime-review-required"
943        | "fallow/runtime-low-traffic"
944        | "fallow/runtime-coverage-unavailable"
945        | "fallow/runtime-coverage" => RuleGuide {
946            example: "Runtime coverage shows a function was never called, barely called, or could not be matched during the capture window.",
947            how_to_fix: "Treat high-confidence cold static-dead code as delete candidates. For advisory or unavailable coverage, inspect seasonality, workers, source maps, and capture quality first.",
948        },
949        _ => return None,
950    })
951}
952
953fn duplication_rule_guide(id: &str) -> Option<RuleGuide> {
954    Some(match id {
955        "fallow/code-duplication" => RuleGuide {
956            example: "Two files contain the same normalized token sequence across a multi-line block.",
957            how_to_fix: "Extract the shared logic when the duplicated behavior should evolve together. Leave it duplicated when the similarity is accidental and likely to diverge.",
958        },
959        _ => return None,
960    })
961}
962
963fn security_rule_guide(id: &str) -> Option<RuleGuide> {
964    Some(match id {
965        "security/tainted-sink" => RuleGuide {
966            example: "A non-literal request field reaches a catalogue sink such as security/sql-injection or security/dangerous-html. The finding is a candidate, not proof of exploitability.",
967            how_to_fix: "Trace the source, sink, sanitization, and runtime context. Fix confirmed issues with parameterization, escaping, validation, or safer APIs, and suppress only reviewed false positives with context.",
968        },
969        "security/client-server-leak" => RuleGuide {
970            example: "A module marked `use client` imports code that reads a non-public `process.env` or `import.meta.env` value through a static path.",
971            how_to_fix: "Keep non-public env reads on the server side, move the value behind an API boundary, or rename only intentionally public values to the framework's public prefix.",
972        },
973        "security/hardcoded-secret" => RuleGuide {
974            example: "A provider-prefixed token-shaped literal is assigned to a secret-shaped variable, and the hardcoded-secret category is explicitly included.",
975            how_to_fix: "Rotate real credentials, move them to a secret manager or environment variable, and keep test-only literals clearly fake so they do not resemble provider tokens.",
976        },
977        id if id.starts_with("security/") => RuleGuide {
978            example: "A `fallow security` candidate uses this catalogue category as its SARIF rule id, for example security/sql-injection for a matched SQL sink.",
979            how_to_fix: "Review the candidate trace before acting. Confirm attacker control, missing sanitization, and reachable runtime context, then fix with the category-appropriate safer API or add a reviewed suppression.",
980        },
981        _ => return None,
982    })
983}
984
985fn fallback_rule_guide() -> RuleGuide {
986    RuleGuide {
987        example: "Run the relevant command with --format json --quiet --explain to inspect this rule in context.",
988        how_to_fix: "Use the issue action hints, source location, and docs URL to decide whether to remove, move, configure, or suppress the finding.",
989    }
990}
991
992/// Build the typed standalone explain output for a user-facing issue token.
993///
994/// # Errors
995///
996/// Returns a structured programmatic error when the token does not map to a
997/// registered rule.
998pub fn explain_issue_type(
999    issue_type: &str,
1000) -> Result<fallow_output::ExplainOutput, crate::ProgrammaticError> {
1001    let Some(rule) = rule_by_token(issue_type) else {
1002        return Err(unknown_explain_error(issue_type));
1003    };
1004    let guide = rule_guide(rule);
1005    Ok(fallow_output::ExplainOutput {
1006        id: rule.id.to_string(),
1007        name: rule_explain_name(rule).to_string(),
1008        summary: rule_explain_summary(rule).to_string(),
1009        rationale: rule.full.to_string(),
1010        example: guide.example.to_string(),
1011        how_to_fix: guide.how_to_fix.to_string(),
1012        docs: rule_docs_url(rule),
1013    })
1014}
1015
1016/// Serialize standalone explain output using the programmatic API contract.
1017///
1018/// # Errors
1019///
1020/// Returns a structured programmatic error for unknown rule tokens or JSON
1021/// serialization failures.
1022pub fn serialize_explain_programmatic_json(
1023    issue_type: &str,
1024    analysis_run_id: Option<&str>,
1025) -> Result<serde_json::Value, crate::ProgrammaticError> {
1026    let output = explain_issue_type(issue_type)?;
1027    fallow_output::serialize_explain_json_output(output, analysis_run_id).map_err(|error| {
1028        crate::ProgrammaticError::new(format!("JSON serialization error: {error}"), 2)
1029            .with_code("json_serialization")
1030    })
1031}
1032
1033/// Structured error for an unrecognized `fallow explain` issue type, with
1034/// suggestions matched to whether the token looks security-related.
1035#[must_use]
1036pub fn unknown_explain_error(issue_type: &str) -> crate::ProgrammaticError {
1037    if let Some(nearest) = nearest_explain_token(issue_type) {
1038        return crate::ProgrammaticError::new(
1039            format!("unknown issue type '{issue_type}'. Did you mean '{nearest}'?"),
1040            2,
1041        )
1042        .with_code("unknown_issue_type")
1043        .with_help(format!("fallow explain {nearest}"));
1044    }
1045    let message = if looks_security_explain_token(issue_type) {
1046        format!(
1047            "unknown issue type '{issue_type}'. Try values like tainted-sink, client-server-leak, hardcoded-secret, sql-injection, or security/sql-injection"
1048        )
1049    } else {
1050        format!(
1051            "unknown issue type '{issue_type}'. Try values like unused files, unused-export, high complexity, or code duplication"
1052        )
1053    };
1054    crate::ProgrammaticError::new(message, 2).with_code("unknown_issue_type")
1055}
1056
1057/// The registered token closest to an unrecognized one, over the same
1058/// vocabulary [`rule_by_token`] accepts (bare ids and namespaced rule ids).
1059/// A hardcoded example list cannot name the token that is one edit away, and
1060/// that is the token the caller almost always meant.
1061fn nearest_explain_token(issue_type: &str) -> Option<&'static str> {
1062    let normalized = issue_type
1063        .trim()
1064        .strip_prefix("fallow/")
1065        .unwrap_or_else(|| issue_type.trim())
1066        .trim_start_matches("--")
1067        .replace('_', "-");
1068    let candidates: Vec<&'static str> = all_rules()
1069        .flat_map(|rule| [bare_rule_id(rule), rule.id])
1070        .collect();
1071    fallow_config::levenshtein::closest_match(&normalized, candidates)
1072}
1073
1074fn looks_security_explain_token(issue_type: &str) -> bool {
1075    let normalized = issue_type.trim().to_ascii_lowercase().replace('_', "-");
1076    normalized.contains("security")
1077        || normalized.contains("secret")
1078        || normalized.contains("sink")
1079        || normalized.contains("cwe")
1080        || normalized.contains("client-server")
1081        || normalized.contains("injection")
1082}
1083
1084/// Rule definitions for complexity and health findings.
1085pub const HEALTH_RULES: &[RuleDef] = &[
1086    RuleDef {
1087        id: "fallow/high-cyclomatic-complexity",
1088        category: "Health",
1089        name: "High Cyclomatic Complexity",
1090        short: "Function has high cyclomatic complexity",
1091        full: "McCabe cyclomatic complexity exceeds the configured threshold. Cyclomatic complexity counts the number of independent paths through a function (1 + decision points: if/else, switch cases, loops, ternary, logical operators). High values indicate functions that are hard to test exhaustively. fallow also emits this rule on synthetic `<template>` findings across every supported template dialect (Angular .html templates and inline `@Component({ template: ... })` literals, Vue SFC `<template>` blocks, Svelte markup, Astro markup), counting each dialect's control-flow blocks (Angular `@if`/`@else if`/`@for`/`@case`/`@defer (when ...)` and legacy `*ngIf`/`*ngFor`; Vue `v-if`/`v-else-if`/`v-for`; Svelte `{#if}`/`{:else if}`/`{#each}`/`{#await}`/`{#key}`; the Astro equivalents) plus ternary and logical operators inside bound attributes and interpolations; on each top-level Svelte `{#snippet name(...)}` block, emitted as its own `<snippet:NAME>` unit; and on synthetic `<component>` rollup findings whose `cyclomatic` is the worst class method's score plus the template's. Ranking and `--targets` use the rollup total; JSON exposes the per-half breakdown under `component_rollup`.",
1092        docs_path: "explanations/health#cyclomatic-complexity",
1093    },
1094    RuleDef {
1095        id: "fallow/high-cognitive-complexity",
1096        category: "Health",
1097        name: "High Cognitive Complexity",
1098        short: "Function has high cognitive complexity",
1099        full: "SonarSource cognitive complexity exceeds the configured threshold. Unlike cyclomatic complexity, cognitive complexity penalizes nesting depth and non-linear control flow (breaks, continues, early returns). It measures how hard a function is to understand when reading sequentially. fallow also emits this rule on synthetic `<template>` findings across every supported template dialect (Angular .html templates and inline `@Component({ template: ... })` literals, Vue SFC `<template>` blocks, Svelte markup, Astro markup), where nesting penalties accumulate on stacked control-flow blocks: Angular `@if`/`@for`/`@switch`, Vue `v-if`/`v-for`, Svelte `{#if}`/`{#each}`/`{#await}`; on each top-level Svelte `{#snippet name(...)}` block, emitted as its own `<snippet:NAME>` unit with nesting rebased to zero so in-file snippet extraction lowers the parent template's score; and on synthetic `<component>` rollup findings whose `cognitive` is the worst class method's score plus the template's. Ranking and `--targets` use the rollup total; JSON exposes the per-half breakdown under `component_rollup`.",
1100        docs_path: "explanations/health#cognitive-complexity",
1101    },
1102    RuleDef {
1103        id: "fallow/high-complexity",
1104        category: "Health",
1105        name: "High Complexity (Both)",
1106        short: "Function exceeds both complexity thresholds",
1107        full: "Function exceeds both cyclomatic and cognitive complexity thresholds. This is the strongest signal that a function needs refactoring, it has many paths AND is hard to understand. The same rule fires on synthetic `<template>` findings in every supported template dialect (Angular .html templates and inline `@Component({ template: ... })` literals, Vue SFC `<template>` blocks, Svelte markup, Astro markup) when both metrics exceed their thresholds, and on synthetic `<component>` rollup findings whose totals are the worst class method's score plus the template's. Ranking and `--targets` use the rollup totals; JSON exposes the per-half breakdown under `component_rollup`.",
1108        docs_path: "explanations/health#complexity-metrics",
1109    },
1110    RuleDef {
1111        id: "fallow/high-crap-score",
1112        category: "Health",
1113        name: "High CRAP Score",
1114        short: "Function has a high CRAP score (complexity combined with low coverage)",
1115        full: "The function's CRAP (Change Risk Anti-Patterns) score meets or exceeds the configured threshold. CRAP combines cyclomatic complexity with test coverage using the Savoia and Evans (2007) formula: `CC^2 * (1 - coverage/100)^3 + CC`. High CRAP indicates changes to this function carry high risk because it is complex AND poorly tested. Pair with `--coverage` for accurate per-function scoring; without it fallow estimates coverage from the module graph. This rule fires on functions only: synthetic template-family units (`<template>`, Svelte `<snippet:NAME>`) are excluded from the CRAP dimension, because a template is exercised only through its component and carries no coverage the formula could measure. Templates gate on the cyclomatic and cognitive dimensions instead.",
1116        docs_path: "explanations/health#crap-score",
1117    },
1118    RuleDef {
1119        id: "fallow/refactoring-target",
1120        category: "Health",
1121        name: "Refactoring Target",
1122        short: "File identified as a high-priority refactoring candidate",
1123        full: "File identified as a refactoring candidate based on a weighted combination of complexity density, churn velocity, dead code ratio, fan-in (blast radius), and fan-out (coupling). Categories: urgent churn+complexity, break circular dependency, split high-impact file, remove dead code, extract complex functions, reduce coupling.",
1124        docs_path: "explanations/health#refactoring-targets",
1125    },
1126    RuleDef {
1127        id: "fallow/css-token-drift",
1128        category: "Health",
1129        name: "CSS Token Drift",
1130        short: "CSS or CSS-in-JS hardcoded styling value bypasses the design token system",
1131        full: "A styling value appears to bypass the project's design token system, for example a Tailwind arbitrary value in markup. The finding is advisory by default and does not affect the audit verdict unless rules.css-token-drift is set to error. Verify the value and replace it with an existing scale token when appropriate.",
1132        docs_path: "explanations/health#css-token-drift",
1133    },
1134    RuleDef {
1135        id: "fallow/css-duplicate-block",
1136        category: "Health",
1137        name: "CSS Duplicate Block",
1138        short: "CSS or CSS-in-JS declaration block is duplicated across rules",
1139        full: "A style rule declaration block is repeated across selectors, suggesting copy-pasted styling that can often be consolidated. The finding is advisory by default and does not affect the audit verdict unless rules.css-duplicate-block is set to error.",
1140        docs_path: "explanations/health#css-duplicate-block",
1141    },
1142    RuleDef {
1143        id: "fallow/css-selector-complexity",
1144        category: "Health",
1145        name: "CSS Selector Complexity",
1146        short: "CSS selector, nesting, or important usage is structurally complex",
1147        full: "A CSS or CSS-in-JS rule crosses the structural floor for selector specificity, selector complexity, nesting depth, or important usage. The finding is advisory by default and does not affect the audit verdict unless rules.css-selector-complexity is set to error.",
1148        docs_path: "explanations/health#css-selector-complexity",
1149    },
1150    RuleDef {
1151        id: "fallow/css-dead-surface",
1152        category: "Health",
1153        name: "CSS Dead Surface",
1154        short: "CSS or CSS-in-JS surface appears unused",
1155        full: "A styling surface appears unused in the analyzed project, such as a scoped SFC class with no component-local use. The finding is advisory by default and does not affect the audit verdict unless rules.css-dead-surface is set to error. Verify dynamic consumers before deleting.",
1156        docs_path: "explanations/health#css-dead-surface",
1157    },
1158    RuleDef {
1159        id: "fallow/css-broken-reference",
1160        category: "Health",
1161        name: "CSS Broken Reference",
1162        short: "CSS or CSS-in-JS reference resolves to no stylesheet definition",
1163        full: "A styling reference appears unresolved, such as a class token or keyframes name that has no stylesheet definition in the analyzed project. The finding is advisory by default and does not affect the audit verdict unless rules.css-broken-reference is set to error. Verify external or CSS-in-JS definitions before fixing.",
1164        docs_path: "explanations/health#css-broken-reference",
1165    },
1166    RuleDef {
1167        id: "fallow/untested-file",
1168        category: "Health",
1169        name: "Untested File",
1170        short: "Runtime-reachable file has no test dependency path",
1171        full: "A file is reachable from runtime entry points but not from any discovered test entry point. This indicates production code that no test imports, directly or transitively, according to the static module graph.",
1172        docs_path: "explanations/health#coverage-gaps",
1173    },
1174    RuleDef {
1175        id: "fallow/untested-export",
1176        category: "Health",
1177        name: "Untested Export",
1178        short: "Runtime-reachable export has no test dependency path",
1179        full: "A value export is reachable from runtime entry points but no test-reachable module references it. This is a static test dependency gap rather than line coverage, and highlights exports exercised only through production entry paths.",
1180        docs_path: "explanations/health#coverage-gaps",
1181    },
1182    RuleDef {
1183        id: "fallow/runtime-safe-to-delete",
1184        category: "Health",
1185        name: "Production Safe To Delete",
1186        short: "Statically unused AND never invoked in production with V8 tracking",
1187        full: "The function is both statically unreachable in the module graph and was never invoked during the observed runtime coverage window. This is the highest-confidence delete signal fallow emits.",
1188        docs_path: "explanations/health#runtime-coverage",
1189    },
1190    RuleDef {
1191        id: "fallow/runtime-review-required",
1192        category: "Health",
1193        name: "Production Review Required",
1194        short: "Statically used but never invoked in production",
1195        full: "The function is reachable in the module graph (or exercised by tests / untracked call sites) but was not invoked during the observed runtime coverage window. Needs a human look: may be seasonal, error-path only, or legitimately unused.",
1196        docs_path: "explanations/health#runtime-coverage",
1197    },
1198    RuleDef {
1199        id: "fallow/runtime-low-traffic",
1200        category: "Health",
1201        name: "Production Low Traffic",
1202        short: "Function was invoked below the low-traffic threshold",
1203        full: "The function was invoked in production but below the configured `--low-traffic-threshold` fraction of total trace count (spec default 0.1%). Effectively dead for the current period.",
1204        docs_path: "explanations/health#runtime-coverage",
1205    },
1206    RuleDef {
1207        id: "fallow/runtime-coverage-unavailable",
1208        category: "Health",
1209        name: "Runtime Coverage Unavailable",
1210        short: "Runtime coverage could not be resolved for this function",
1211        full: "The function could not be matched to a V8-tracked coverage entry. Common causes: the function lives in a worker thread (separate V8 isolate), it is lazy-parsed and never reached the JIT tier, or its source map did not resolve to the expected source path. This is advisory, not a dead-code signal.",
1212        docs_path: "explanations/health#runtime-coverage",
1213    },
1214    RuleDef {
1215        id: "fallow/runtime-coverage",
1216        category: "Health",
1217        name: "Runtime Coverage",
1218        short: "Runtime coverage finding",
1219        full: "Generic runtime-coverage finding for verdicts not covered by a more specific rule. Covers the forward-compat `unknown` sentinel; the CLI filters `active` entries out of `runtime_coverage.findings` so the surfaced list stays actionable.",
1220        docs_path: "explanations/health#runtime-coverage",
1221    },
1222    RuleDef {
1223        id: "fallow/coverage-intelligence-risky-change",
1224        category: "Health",
1225        name: "Coverage Intelligence Risky Change",
1226        short: "Changed hot path combines high CRAP and low test coverage",
1227        full: "Coverage intelligence combined change scope, runtime hot-path evidence, low test coverage, and high CRAP into a risky-change finding. Add focused tests or split the change before merging.",
1228        docs_path: "explanations/health#coverage-intelligence",
1229    },
1230    RuleDef {
1231        id: "fallow/coverage-intelligence-delete",
1232        category: "Health",
1233        name: "Coverage Intelligence Delete",
1234        short: "Static and runtime evidence indicate code can be deleted",
1235        full: "Coverage intelligence combined static unused status, runtime cold evidence, and lack of test reachability into a high-confidence delete recommendation.",
1236        docs_path: "explanations/health#coverage-intelligence",
1237    },
1238    RuleDef {
1239        id: "fallow/coverage-intelligence-review",
1240        category: "Health",
1241        name: "Coverage Intelligence Review",
1242        short: "Cold reachable uncovered code needs owner review",
1243        full: "Coverage intelligence found code that is statically reachable but cold in runtime evidence, uncovered by tests, and ownership-risky. Route it to an owner before changing or deleting it.",
1244        docs_path: "explanations/health#coverage-intelligence",
1245    },
1246    RuleDef {
1247        id: "fallow/coverage-intelligence-refactor",
1248        category: "Health",
1249        name: "Coverage Intelligence Refactor",
1250        short: "Hot covered code has high CRAP and should be refactored carefully",
1251        full: "Coverage intelligence found hot production code that is covered by tests but still has high CRAP. Refactor carefully while preserving behavior.",
1252        docs_path: "explanations/health#coverage-intelligence",
1253    },
1254];
1255
1256/// Rule definitions for duplication findings.
1257pub const DUPES_RULES: &[RuleDef] = &[RuleDef {
1258    id: "fallow/code-duplication",
1259    category: "Duplication",
1260    name: "Code Duplication",
1261    short: "Duplicated code block",
1262    full: "A block of code that appears in multiple locations with identical or near-identical token sequences. Clone detection uses normalized token comparison, abstracting identifiers and literals in non-strict modes. Duplicated line counts and percentages include every instance, including the first. Overlapping line ranges in the same file count once. Redundant token counts exclude one retained copy per clone group.",
1263    docs_path: "explanations/duplication#clone-groups",
1264}];
1265
1266/// Rule definitions for the diff-risk rules of `fallow audit`.
1267pub const AUDIT_RULES: &[RuleDef] = &[
1268    RuleDef {
1269        id: "fallow/weakened-tests",
1270        category: "Audit",
1271        name: "Weakened Tests",
1272        short: "The change weakens tests or a coverage threshold",
1273        full: "`fallow audit` compares the base and head text of each changed file. The `kind` field tells how the change weakened the tests: `skip-only` (a new `.skip`, `.only`, `xit` or `fit` marker), `removed-tests` (fewer test cases in a file, while the total of all changed test files also dropped), `assertion-drop` (fewer `expect`, `assert` or `should` calls in a test file with no test case removed), or `coverage-threshold` (a coverage or quality threshold that is less strict). A drop does not report when the lost test lines name code that the change removed, such as a deleted function or a deleted fixture directory: the tests went with that code. A name of a deleted file that a changed file still holds, a name that a deleted file only imports, a directory that still exists, and a reserved word such as `import` do not count. An assertion drop reports only when assertions are at least half of the code lines that the file lost, so a test rewrite that moves setup checks into a helper does not report. The finding is a fact about the change, not a proof that coverage dropped. Defaults to `warn`.",
1274        docs_path: "cli/audit#diff-risk-rules",
1275    },
1276    RuleDef {
1277        id: "fallow/added-suppression",
1278        category: "Audit",
1279        name: "Added Suppressions",
1280        short: "The change adds a suppression comment",
1281        full: "`fallow audit` reports a comment line that the change adds with a lint, type-check, coverage or Fallow suppression: `eslint-disable`, `oxlint-disable`, `biome-ignore`, `deno-lint-ignore`, `@ts-ignore`, `@ts-expect-error`, `@ts-nocheck`, `istanbul ignore`, `c8 ignore`, `v8 ignore` or `fallow-ignore`. A moved comment is not added. A `fallow-ignore` comment that names only diff-risk rules does not count. Files below a fixture or generated directory (`fixture`, `fixtures`, `__fixtures__`, `__snapshots__`, `generated`, `__generated__`) do not report, because a tool writes them or a test reads them as data. Defaults to `warn`.",
1282        docs_path: "cli/audit#diff-risk-rules",
1283    },
1284    RuleDef {
1285        id: "fallow/test-only-branch",
1286        category: "Audit",
1287        name: "Test-Only Branches",
1288        short: "The change adds a test-environment branch to source code",
1289        full: "`fallow audit` reports a line that the change adds to a non-test source file and that checks the test environment: `process.env.NODE_ENV` compared with `'test'`, `process.env.VITEST` or `process.env.JEST_WORKER_ID`. Such a branch lets the tests take a path that production does not take. A Vitest in-source test block (`if (import.meta.vitest)`) is test code and is not reported. Tool config files are skipped. A check that only keeps `console` output quiet in tests (`if (process.env.NODE_ENV !== 'test') console.warn(...)`), and a check that picks an env file (`'.env.test'`), do not report. Defaults to `warn`.",
1290        docs_path: "cli/audit#diff-risk-rules",
1291    },
1292    RuleDef {
1293        id: "fallow/diverged-clone-sibling",
1294        category: "Audit",
1295        name: "Diverged Clone Siblings",
1296        short: "The change edits one copy of duplicated code but not its siblings",
1297        full: "`fallow audit` reports a base clone group where the change edited exactly one copy, the edit broke the clone, and every other copy kept its text. The siblings can need the same change. A cosmetic edit that keeps the clone, a removed copy, a change that edits every copy, and an edit to a test or story copy do not report. Needs the base snapshot of `--gate new-only`. Opt-in: defaults to `off`, because copies often differ on purpose, for example an input and an output type, or a legacy copy. Set it to `warn` or `error` to review every diverged copy.",
1298        docs_path: "cli/audit#diff-risk-rules",
1299    },
1300    RuleDef {
1301        id: "fallow/added-dependency",
1302        category: "Audit",
1303        name: "Added Dependencies",
1304        short: "The change adds a dependency",
1305        full: "`fallow audit` reports a dependency that the change adds to a `package.json`. A new dependency is often correct, so the rule defaults to `off`. Set it to `warn` or `error` to review every new package. An invented package name already fails as an unresolved import or an unlisted dependency.",
1306        docs_path: "cli/audit#diff-risk-rules",
1307    },
1308];
1309
1310/// Rule definitions for feature-flag findings.
1311pub const FLAGS_RULES: &[RuleDef] = &[
1312    RuleDef {
1313        id: "fallow/feature-flag",
1314        category: "Flags",
1315        name: "Feature Flags",
1316        short: "Detected feature flag pattern",
1317        full: "A feature flag pattern detected by `fallow flags`: environment-variable checks, flag SDK calls (LaunchDarkly, Unleash, and similar), or config-object lookups. Long-lived flags accumulate dead branches; review old flags for retirement and pair with dead-code analysis to find branches that can no longer execute.",
1318        docs_path: "cli/flags",
1319    },
1320    RuleDef {
1321        id: "fallow/flag-retirement-candidate",
1322        category: "Flags",
1323        name: "Flag Retirement Candidate",
1324        short: "Feature flag is a retirement candidate",
1325        full: "A feature flag that `fallow flags --retirement` lists with at least one retirement reason: one read site, reads only in tests, a literal constant, identical or empty guard branches, guarded dead code, a definition that no code reads, or a vendor state from `--flag-state` (rolled out, archived, missing in the vendor export, or in the export only). The report is advisory. A person decides to remove the flag; Fallow does not remove code.",
1326        docs_path: "cli/flags#retirement-report",
1327    },
1328];
1329
1330macro_rules! security_catalogue_rule {
1331    ($id:literal, $name:literal, $cwe:literal) => {
1332        RuleDef {
1333            id: concat!("security/", $id),
1334            category: "Security",
1335            name: $name,
1336            short: concat!("Catalogue security candidate for CWE-", $cwe),
1337            full: concat!(
1338                $name,
1339                " is a data-driven `fallow security` tainted-sink catalogue category with CWE-",
1340                $cwe,
1341                " metadata. fallow reports it as an unverified candidate when a captured sink shape matches this category. Use it to understand or filter `security/",
1342                $id,
1343                "` findings, then inspect the trace, source, sink, sanitization, and application context before treating it as exploitable."
1344            ),
1345            docs_path: "cli/security",
1346        }
1347    };
1348}
1349
1350/// Rule definitions for security candidate findings, including the
1351/// data-driven tainted-sink catalogue categories.
1352pub const SECURITY_RULES: &[RuleDef] = &[
1353    RuleDef {
1354        id: "security/tainted-sink",
1355        category: "Security",
1356        name: "Tainted Sink Candidates",
1357        short: "Syntactic security sink candidates require verification",
1358        full: "The `tainted-sink` family covers data-driven `fallow security` catalogue categories. These findings are unverified candidates, not confirmed vulnerabilities. fallow can connect known source signals to captured sink shapes and add CWE metadata, but it does not prove attacker control, missing sanitization, exploitability, or business impact.",
1359        docs_path: "cli/security",
1360    },
1361    RuleDef {
1362        id: "security/client-server-leak",
1363        category: "Security",
1364        name: "Client-server Secret Leak Candidates",
1365        short: "Client-bound code reaches a non-public env read",
1366        full: "`client-server-leak` reports a candidate when a `use client` module can transitively reach a static non-public `process.env` or `import.meta.env` read. Public-by-convention env prefixes are treated as public. The finding is advisory and still needs bundle, framework, and runtime verification before treating it as a real exposure.",
1367        docs_path: "cli/security",
1368    },
1369    RuleDef {
1370        id: "security/hardcoded-secret",
1371        category: "Security",
1372        name: "Hardcoded Secret Candidates",
1373        short: "Provider-prefixed or contextual secret literals require verification",
1374        full: "`hardcoded-secret` reports opt-in candidates for provider-prefixed or contextual secret-shaped literals. The category is include-required and only runs when listed in `security.categories.include`. It avoids raw entropy alone, but every result still requires review, secret rotation decisions, and context before acting.",
1375        docs_path: "cli/security",
1376    },
1377    security_catalogue_rule!("dangerous-html", "Dangerous HTML sink", "79"),
1378    security_catalogue_rule!(
1379        "template-escape-bypass",
1380        "Template escape bypass sink",
1381        "79"
1382    ),
1383    security_catalogue_rule!("command-injection", "OS command injection sink", "78"),
1384    security_catalogue_rule!("code-injection", "Code injection sink", "94"),
1385    security_catalogue_rule!("dynamic-regex", "Dynamic regular expression sink", "1333"),
1386    security_catalogue_rule!("redos-regex", "ReDoS regex sink", "1333"),
1387    security_catalogue_rule!(
1388        "resource-amplification",
1389        "Resource amplification sink",
1390        "400"
1391    ),
1392    security_catalogue_rule!("dynamic-module-load", "Dynamic module load sink", "95"),
1393    security_catalogue_rule!("sql-injection", "SQL injection sink", "89"),
1394    security_catalogue_rule!("ssrf", "Server-side request forgery sink", "918"),
1395    security_catalogue_rule!(
1396        "secret-to-network",
1397        "Secret reaches a network request",
1398        "201"
1399    ),
1400    security_catalogue_rule!("path-traversal", "Path traversal sink", "22"),
1401    security_catalogue_rule!(
1402        "header-injection",
1403        "HTTP response header injection sink",
1404        "113"
1405    ),
1406    security_catalogue_rule!("open-redirect", "Open redirect sink", "601"),
1407    security_catalogue_rule!(
1408        "postmessage-wildcard-origin",
1409        "Wildcard postMessage target origin",
1410        "346"
1411    ),
1412    security_catalogue_rule!("tls-validation-disabled", "TLS validation disabled", "295"),
1413    security_catalogue_rule!("cleartext-transport", "Cleartext transport URL", "319"),
1414    security_catalogue_rule!(
1415        "electron-unsafe-webpreferences",
1416        "Unsafe Electron BrowserWindow preferences",
1417        "1188"
1418    ),
1419    security_catalogue_rule!(
1420        "world-writable-permission",
1421        "World-writable chmod mode",
1422        "732"
1423    ),
1424    security_catalogue_rule!(
1425        "insecure-temp-file",
1426        "Predictable temporary file path",
1427        "377"
1428    ),
1429    security_catalogue_rule!(
1430        "mysql-multiple-statements",
1431        "MySQL multiple statements enabled",
1432        "89"
1433    ),
1434    security_catalogue_rule!("permissive-cors", "Permissive CORS policy", "942"),
1435    security_catalogue_rule!("insecure-cookie", "Insecure cookie options", "614"),
1436    security_catalogue_rule!("mass-assignment", "Mass assignment sink", "915"),
1437    security_catalogue_rule!("weak-crypto", "Runtime-selectable crypto algorithm", "327"),
1438    security_catalogue_rule!("insecure-randomness", "Insecure randomness sink", "338"),
1439    security_catalogue_rule!("jwt-alg-none", "JWT alg none", "347"),
1440    security_catalogue_rule!(
1441        "jwt-verify-missing-algorithms",
1442        "JWT verify missing algorithms allowlist",
1443        "347"
1444    ),
1445    security_catalogue_rule!("deprecated-cipher", "Deprecated cipher constructor", "327"),
1446    security_catalogue_rule!(
1447        "unsafe-buffer-alloc",
1448        "Unsafe Buffer allocation sink",
1449        "1188"
1450    ),
1451    security_catalogue_rule!(
1452        "unsafe-deserialization",
1453        "Unsafe deserialization sink",
1454        "502"
1455    ),
1456    security_catalogue_rule!(
1457        "angular-trusted-html",
1458        "Angular bypassSecurityTrust sink",
1459        "79"
1460    ),
1461    security_catalogue_rule!("nextjs-open-redirect", "Next.js open redirect sink", "601"),
1462    security_catalogue_rule!("dom-document-write", "DOM document.write sink", "79"),
1463    security_catalogue_rule!("jquery-html", "jQuery .html() sink", "79"),
1464    security_catalogue_rule!(
1465        "route-send-file",
1466        "Route file-send path traversal sink",
1467        "22"
1468    ),
1469    security_catalogue_rule!("webview-injection", "WebView injected-script sink", "94"),
1470    security_catalogue_rule!("prototype-pollution", "Prototype pollution sink", "1321"),
1471    security_catalogue_rule!("zip-slip", "Archive path-traversal (zip-slip) sink", "22"),
1472    security_catalogue_rule!("nosql-injection", "NoSQL injection sink", "943"),
1473    security_catalogue_rule!("ssti", "Server-side template injection sink", "1336"),
1474    security_catalogue_rule!("xxe", "XML external entity (XXE) sink", "611"),
1475    security_catalogue_rule!("secret-pii-log", "Secret or PII logged", "532"),
1476    security_catalogue_rule!("xpath-injection", "XPath injection sink", "643"),
1477    security_catalogue_rule!(
1478        "llm-call-injection",
1479        "Untrusted input reaches an LLM call",
1480        "1427"
1481    ),
1482];
1483
1484/// Build the `_meta` object for `fallow security --format json --explain`.
1485#[must_use]
1486pub fn security_meta() -> fallow_types::envelope::Meta {
1487    fallow_output::security_meta(SECURITY_RULES.iter().map(|rule| {
1488        fallow_output::SecurityRuleMeta {
1489            id: rule.id,
1490            name: rule.name,
1491            description: rule.full,
1492            docs_path: rule.docs_path,
1493        }
1494    }))
1495}
1496
1497/// Build the `_meta` object for `fallow coverage setup --json --explain`.
1498#[must_use]
1499pub fn coverage_setup_meta() -> Value {
1500    fallow_output::coverage_setup_meta()
1501}
1502
1503/// Build the `_meta` object for `fallow coverage analyze --format json --explain`.
1504#[must_use]
1505pub fn coverage_analyze_meta() -> Value {
1506    fallow_output::coverage_analyze_meta()
1507}
1508
1509#[cfg(test)]
1510#[allow(
1511    clippy::unwrap_used,
1512    reason = "registry tests intentionally index fixture JSON"
1513)]
1514mod tests {
1515    use super::*;
1516    use serde_json::json;
1517
1518    fn meta_value(meta: fallow_types::envelope::Meta) -> Value {
1519        serde_json::to_value(meta).expect("metadata should serialize")
1520    }
1521
1522    fn check_meta() -> Value {
1523        meta_value(fallow_output::check_meta())
1524    }
1525
1526    fn health_meta() -> Value {
1527        meta_value(fallow_output::health_meta())
1528    }
1529
1530    fn dupes_meta() -> Value {
1531        meta_value(fallow_output::dupes_meta())
1532    }
1533
1534    #[test]
1535    fn audit_rules_resolve_by_bare_token_and_report_under_audit() {
1536        for rule in AUDIT_RULES {
1537            let bare = bare_rule_id(rule);
1538            assert_eq!(rule_by_token(bare).map(|found| found.id), Some(rule.id));
1539            assert_eq!(rule_command(rule), "audit");
1540            assert_eq!(rule_severity_key(rule), Some(bare));
1541        }
1542    }
1543
1544    #[test]
1545    fn all_rules_walks_every_registry_in_order() {
1546        let ids: Vec<&str> = all_rules().map(|rule| rule.id).collect();
1547        let expected: Vec<&str> = CHECK_RULES
1548            .iter()
1549            .chain(HEALTH_RULES)
1550            .chain(DUPES_RULES)
1551            .chain(FLAGS_RULES)
1552            .chain(SECURITY_RULES)
1553            .chain(AUDIT_RULES)
1554            .map(|rule| rule.id)
1555            .collect();
1556        assert_eq!(ids, expected);
1557        let mut unique = ids.clone();
1558        unique.sort_unstable();
1559        unique.dedup();
1560        assert_eq!(
1561            unique.len(),
1562            ids.len(),
1563            "duplicate rule id across registries"
1564        );
1565    }
1566
1567    #[test]
1568    fn rule_command_names_the_owning_registry() {
1569        assert_eq!(rule_command(&CHECK_RULES[0]), "dead-code");
1570        assert_eq!(rule_command(&HEALTH_RULES[0]), "health");
1571        assert_eq!(rule_command(&DUPES_RULES[0]), "dupes");
1572        assert_eq!(rule_command(&FLAGS_RULES[0]), "flags");
1573        assert_eq!(rule_command(&SECURITY_RULES[0]), "security");
1574    }
1575
1576    #[test]
1577    fn severity_key_follows_the_gating_rule() {
1578        let by_id = |id: &str| rule_by_id(id).unwrap();
1579        assert_eq!(bare_rule_id(by_id("fallow/unused-export")), "unused-export");
1580        assert_eq!(
1581            bare_rule_id(by_id("security/sql-injection")),
1582            "sql-injection"
1583        );
1584        assert_eq!(
1585            rule_severity_key(by_id("fallow/unused-export")),
1586            Some("unused-exports")
1587        );
1588        assert_eq!(
1589            rule_severity_key(by_id("fallow/untested-file")),
1590            Some("coverage-gaps")
1591        );
1592        assert_eq!(
1593            rule_severity_key(by_id("security/sql-injection")),
1594            Some("security-sink")
1595        );
1596        assert_eq!(
1597            rule_severity_key(by_id("security/client-server-leak")),
1598            Some("security-client-server-leak")
1599        );
1600        assert_eq!(
1601            rule_severity_key(by_id("fallow/high-cyclomatic-complexity")),
1602            None
1603        );
1604        assert_eq!(
1605            rule_severity_key(by_id("fallow/code-duplication")),
1606            None,
1607            "a suppression token that is not a rules.* key never becomes a severity key"
1608        );
1609        let defaults = crate::schemas::default_rule_severities();
1610        for rule in all_rules() {
1611            if let Some(key) = rule_severity_key(rule) {
1612                assert!(
1613                    defaults.get(key).is_some_and(serde_json::Value::is_string),
1614                    "severity key {key} for {} is not a rules.* config key",
1615                    rule.id
1616                );
1617            }
1618        }
1619    }
1620
1621    #[test]
1622    fn rule_by_id_finds_check_rule() {
1623        let rule = rule_by_id("fallow/unused-file").unwrap();
1624        assert_eq!(rule.name, "Unused Files");
1625    }
1626
1627    #[test]
1628    fn rule_by_id_finds_health_rule() {
1629        let rule = rule_by_id("fallow/high-cyclomatic-complexity").unwrap();
1630        assert_eq!(rule.name, "High Cyclomatic Complexity");
1631    }
1632
1633    #[test]
1634    fn rule_by_id_finds_dupes_rule() {
1635        let rule = rule_by_id("fallow/code-duplication").unwrap();
1636        assert_eq!(rule.name, "Code Duplication");
1637    }
1638
1639    #[test]
1640    fn rule_by_id_finds_security_rule() {
1641        let rule = rule_by_id("security/tainted-sink").unwrap();
1642        assert_eq!(rule.name, "Tainted Sink Candidates");
1643    }
1644
1645    #[test]
1646    fn rule_by_id_finds_flags_rule() {
1647        let rule = rule_by_id("fallow/feature-flag").unwrap();
1648        assert_eq!(rule.name, "Feature Flags");
1649    }
1650
1651    #[test]
1652    fn rule_by_id_returns_none_for_unknown() {
1653        assert!(rule_by_id("fallow/nonexistent").is_none());
1654        assert!(rule_by_id("").is_none());
1655    }
1656
1657    #[test]
1658    fn rule_docs_url_format() {
1659        let rule = rule_by_id("fallow/unused-export").unwrap();
1660        let url = rule_docs_url(rule);
1661        assert!(url.starts_with("https://fallow.tools/docs/"));
1662        assert!(url.contains("unused-exports"));
1663    }
1664
1665    #[test]
1666    fn explain_output_prefers_issue_result_registry_contract_fields() {
1667        let output = explain_issue_type("unused-type").unwrap();
1668        let meta = fallow_types::issue_meta::issue_result_meta_by_code("unused-type").unwrap();
1669        assert_eq!(output.name, meta.meta_name);
1670        assert_eq!(output.summary, meta.sarif_description);
1671        assert_eq!(
1672            output.docs,
1673            fallow_output::rule_docs_url(meta.meta_docs_path)
1674        );
1675    }
1676
1677    #[test]
1678    fn dependency_override_explanations_cover_supported_package_managers() {
1679        let unused = explain_issue_type("unused-dependency-override").unwrap();
1680        assert_eq!(unused.name, "Unused dependency override");
1681        assert!(unused.summary.contains("Package-manager override"));
1682        assert!(unused.rationale.contains("npm"));
1683        assert!(unused.rationale.contains("Bun"));
1684
1685        let misconfigured = explain_issue_type("misconfigured-dependency-override").unwrap();
1686        assert_eq!(misconfigured.name, "Misconfigured dependency override");
1687        assert!(misconfigured.summary.contains("Package-manager override"));
1688        assert!(misconfigured.rationale.contains("npm"));
1689        assert!(misconfigured.rationale.contains("Bun"));
1690    }
1691
1692    #[test]
1693    fn result_sarif_rule_ids_have_explain_metadata() {
1694        for contract in fallow_output::issue_output_contracts() {
1695            for rule_id in contract.sarif_rule_ids {
1696                assert!(
1697                    rule_by_id(&rule_id).is_some(),
1698                    "result metadata code {} has SARIF rule id {rule_id} without RuleDef",
1699                    contract.code
1700                );
1701            }
1702        }
1703    }
1704
1705    #[test]
1706    fn registry_dead_code_tokens_resolve_to_explain_rules() {
1707        for meta in fallow_types::issue_meta::ISSUE_KIND_META {
1708            let Some(expected) = CHECK_RULES
1709                .iter()
1710                .find(|rule| rule.id.strip_prefix("fallow/") == Some(meta.code))
1711            else {
1712                continue;
1713            };
1714            assert_registry_token(expected, meta.code);
1715            for token in meta.aliases {
1716                assert_registry_token(expected, token);
1717            }
1718            if let Some(token) = meta.config_key {
1719                assert_registry_token(expected, token);
1720            }
1721            if let Some(token) = meta.mcp_issue_type {
1722                assert_registry_token(expected, token);
1723            }
1724            if let Some(token) = meta.filter_flag {
1725                assert_registry_token(expected, token);
1726            }
1727            if let Some(token) = meta.suppress_token {
1728                assert_registry_token(expected, token);
1729            }
1730        }
1731    }
1732
1733    fn assert_registry_token(expected: &RuleDef, token: &str) {
1734        if !registry_token_is_unique(token) {
1735            return;
1736        }
1737        let actual = rule_by_token(token)
1738            .unwrap_or_else(|| panic!("registry token {token} did not resolve to an explain rule"));
1739        assert_eq!(
1740            actual.id, expected.id,
1741            "registry token {token} resolved to the wrong explain rule"
1742        );
1743    }
1744
1745    fn registry_token_is_unique(token: &str) -> bool {
1746        fallow_types::issue_meta::ISSUE_KIND_META
1747            .iter()
1748            .filter(|meta| {
1749                CHECK_RULES
1750                    .iter()
1751                    .any(|rule| rule.id.strip_prefix("fallow/") == Some(meta.code))
1752                    && fallow_types::issue_meta::issue_meta_matches_contract_token(meta, token)
1753            })
1754            .count()
1755            == 1
1756    }
1757
1758    #[test]
1759    fn check_rules_all_have_fallow_prefix() {
1760        for rule in CHECK_RULES {
1761            assert!(
1762                rule.id.starts_with("fallow/"),
1763                "rule {} should start with fallow/",
1764                rule.id
1765            );
1766        }
1767    }
1768
1769    #[test]
1770    fn check_rules_all_have_docs_path() {
1771        for rule in CHECK_RULES {
1772            assert!(
1773                !rule.docs_path.is_empty(),
1774                "rule {} should have a docs_path",
1775                rule.id
1776            );
1777        }
1778    }
1779
1780    #[test]
1781    fn check_rules_no_duplicate_ids() {
1782        let mut seen = rustc_hash::FxHashSet::default();
1783        for rule in CHECK_RULES
1784            .iter()
1785            .chain(HEALTH_RULES)
1786            .chain(DUPES_RULES)
1787            .chain(FLAGS_RULES)
1788            .chain(SECURITY_RULES)
1789        {
1790            assert!(seen.insert(rule.id), "duplicate rule id: {}", rule.id);
1791        }
1792    }
1793
1794    #[test]
1795    fn check_meta_has_docs_and_rules() {
1796        let meta = check_meta();
1797        assert!(meta.get("docs").is_some());
1798        assert!(meta.get("rules").is_some());
1799        let rules = meta["rules"].as_object().unwrap();
1800        assert_eq!(rules.len(), CHECK_RULES.len());
1801        assert!(rules.contains_key("unused-file"));
1802        assert!(rules.contains_key("unused-export"));
1803        assert!(rules.contains_key("unused-type"));
1804        assert!(rules.contains_key("unused-dependency"));
1805        assert!(rules.contains_key("unused-dev-dependency"));
1806        assert!(rules.contains_key("unused-optional-dependency"));
1807        assert!(rules.contains_key("unused-enum-member"));
1808        assert!(rules.contains_key("unused-class-member"));
1809        assert!(rules.contains_key("unresolved-import"));
1810        assert!(rules.contains_key("unlisted-dependency"));
1811        assert!(rules.contains_key("duplicate-export"));
1812        assert!(rules.contains_key("type-only-dependency"));
1813        assert!(rules.contains_key("circular-dependency"));
1814    }
1815
1816    #[test]
1817    fn check_meta_documents_per_finding_auto_fixable() {
1818        let meta = check_meta();
1819        let defs = meta["field_definitions"].as_object().unwrap();
1820        let note = defs["actions[].auto_fixable"].as_str().unwrap();
1821        assert!(
1822            note.contains("PER FINDING"),
1823            "auto_fixable note must call out per-finding evaluation"
1824        );
1825        assert!(
1826            note.contains("remove-catalog-entry"),
1827            "auto_fixable note must cite remove-catalog-entry per-instance flip"
1828        );
1829        assert!(
1830            note.contains("used_in_workspaces"),
1831            "auto_fixable note must cite the dependency-action per-instance flip"
1832        );
1833        assert!(
1834            note.contains("ignoreExports"),
1835            "auto_fixable note must cite the duplicate-exports config-fixable flip"
1836        );
1837        assert!(defs.contains_key("actions[]"));
1838    }
1839
1840    #[test]
1841    fn health_and_dupes_meta_share_actions_field_definitions() {
1842        for meta in [health_meta(), dupes_meta()] {
1843            let defs = meta["field_definitions"].as_object().unwrap();
1844            assert_eq!(
1845                defs["actions[]"].as_str().unwrap(),
1846                fallow_output::ACTIONS_FIELD_DEFINITION,
1847            );
1848            assert_eq!(
1849                defs["actions[].auto_fixable"].as_str().unwrap(),
1850                fallow_output::ACTIONS_AUTO_FIXABLE_FIELD_DEFINITION,
1851            );
1852        }
1853    }
1854
1855    #[test]
1856    fn check_meta_rule_has_required_fields() {
1857        let meta = check_meta();
1858        let rules = meta["rules"].as_object().unwrap();
1859        for (key, value) in rules {
1860            assert!(value.get("name").is_some(), "rule {key} missing 'name'");
1861            assert!(
1862                value.get("description").is_some(),
1863                "rule {key} missing 'description'"
1864            );
1865            assert!(value.get("docs").is_some(), "rule {key} missing 'docs'");
1866        }
1867    }
1868
1869    #[test]
1870    fn health_meta_has_metrics() {
1871        let meta = health_meta();
1872        assert!(meta.get("docs").is_some());
1873        let metrics = meta["metrics"].as_object().unwrap();
1874        assert!(metrics.contains_key("cyclomatic"));
1875        assert!(metrics.contains_key("cognitive"));
1876        assert!(metrics.contains_key("maintainability_index"));
1877        assert!(metrics.contains_key("complexity_density"));
1878        assert!(metrics.contains_key("fan_in"));
1879        assert!(metrics.contains_key("fan_out"));
1880    }
1881
1882    #[test]
1883    fn dupes_meta_has_metrics() {
1884        let meta = dupes_meta();
1885        assert!(meta.get("docs").is_some());
1886        let metrics = meta["metrics"].as_object().unwrap();
1887        assert!(metrics.contains_key("duplication_percentage"));
1888        assert!(metrics.contains_key("token_count"));
1889        assert!(metrics.contains_key("clone_groups"));
1890        assert!(metrics.contains_key("clone_families"));
1891    }
1892
1893    #[test]
1894    fn coverage_setup_meta_has_docs_fields_enums_and_warnings() {
1895        let meta = coverage_setup_meta();
1896        assert_eq!(meta["docs_url"], fallow_output::COVERAGE_SETUP_DOCS);
1897        assert!(
1898            meta["field_definitions"]
1899                .as_object()
1900                .unwrap()
1901                .contains_key("members[]")
1902        );
1903        assert!(
1904            meta["field_definitions"]
1905                .as_object()
1906                .unwrap()
1907                .contains_key("config_written")
1908        );
1909        assert!(
1910            meta["field_definitions"]
1911                .as_object()
1912                .unwrap()
1913                .contains_key("members[].package_manager")
1914        );
1915        assert!(
1916            meta["field_definitions"]
1917                .as_object()
1918                .unwrap()
1919                .contains_key("members[].warnings")
1920        );
1921        assert!(
1922            meta["enums"]
1923                .as_object()
1924                .unwrap()
1925                .contains_key("framework_detected")
1926        );
1927        assert!(
1928            meta["warnings"]
1929                .as_object()
1930                .unwrap()
1931                .contains_key("No runtime workspace members were detected")
1932        );
1933        assert!(
1934            meta["warnings"]
1935                .as_object()
1936                .unwrap()
1937                .contains_key("Package manager was not detected")
1938        );
1939    }
1940
1941    #[test]
1942    fn coverage_analyze_meta_documents_data_source_and_action_vocabulary() {
1943        let meta = coverage_analyze_meta();
1944        assert_eq!(meta["docs_url"], fallow_output::COVERAGE_ANALYZE_DOCS);
1945        let fields = meta["field_definitions"].as_object().unwrap();
1946        assert!(fields.contains_key("runtime_coverage.summary.data_source"));
1947        assert!(fields.contains_key("runtime_coverage.summary.last_received_at"));
1948        assert!(fields.contains_key("runtime_coverage.findings[].evidence.test_coverage"));
1949        assert!(fields.contains_key("runtime_coverage.findings[].actions[].type"));
1950        let enums = meta["enums"].as_object().unwrap();
1951        assert_eq!(enums["data_source"], json!(["local", "cloud"]));
1952        assert_eq!(enums["test_coverage"], json!(["covered", "not_covered"]));
1953        assert_eq!(enums["v8_tracking"], json!(["tracked", "untracked"]));
1954        assert_eq!(
1955            enums["action_type"],
1956            json!(["delete-cold-code", "review-runtime"])
1957        );
1958        let warnings = meta["warnings"].as_object().unwrap();
1959        assert!(warnings.contains_key("cloud_functions_unmatched"));
1960    }
1961
1962    #[test]
1963    fn health_rules_all_have_fallow_prefix() {
1964        for rule in HEALTH_RULES {
1965            assert!(
1966                rule.id.starts_with("fallow/"),
1967                "health rule {} should start with fallow/",
1968                rule.id
1969            );
1970        }
1971    }
1972
1973    #[test]
1974    fn health_rules_all_have_docs_path() {
1975        for rule in HEALTH_RULES {
1976            assert!(
1977                !rule.docs_path.is_empty(),
1978                "health rule {} should have a docs_path",
1979                rule.id
1980            );
1981        }
1982    }
1983
1984    #[test]
1985    fn health_rules_all_have_non_empty_fields() {
1986        for rule in HEALTH_RULES {
1987            assert!(
1988                !rule.name.is_empty(),
1989                "health rule {} missing name",
1990                rule.id
1991            );
1992            assert!(
1993                !rule.short.is_empty(),
1994                "health rule {} missing short description",
1995                rule.id
1996            );
1997            assert!(
1998                !rule.full.is_empty(),
1999                "health rule {} missing full description",
2000                rule.id
2001            );
2002        }
2003    }
2004
2005    #[test]
2006    fn dupes_rules_all_have_fallow_prefix() {
2007        for rule in DUPES_RULES {
2008            assert!(
2009                rule.id.starts_with("fallow/"),
2010                "dupes rule {} should start with fallow/",
2011                rule.id
2012            );
2013        }
2014    }
2015
2016    #[test]
2017    fn dupes_rules_all_have_docs_path() {
2018        for rule in DUPES_RULES {
2019            assert!(
2020                !rule.docs_path.is_empty(),
2021                "dupes rule {} should have a docs_path",
2022                rule.id
2023            );
2024        }
2025    }
2026
2027    #[test]
2028    fn dupes_rules_all_have_non_empty_fields() {
2029        for rule in DUPES_RULES {
2030            assert!(!rule.name.is_empty(), "dupes rule {} missing name", rule.id);
2031            assert!(
2032                !rule.short.is_empty(),
2033                "dupes rule {} missing short description",
2034                rule.id
2035            );
2036            assert!(
2037                !rule.full.is_empty(),
2038                "dupes rule {} missing full description",
2039                rule.id
2040            );
2041        }
2042    }
2043
2044    #[test]
2045    fn security_rules_all_have_security_prefix() {
2046        for rule in SECURITY_RULES {
2047            assert!(
2048                rule.id.starts_with("security/"),
2049                "security rule {} should start with security/",
2050                rule.id
2051            );
2052        }
2053    }
2054
2055    #[test]
2056    fn security_rules_all_have_docs_path() {
2057        for rule in SECURITY_RULES {
2058            assert_eq!(
2059                rule.docs_path, "cli/security",
2060                "security rule {} should point at security docs",
2061                rule.id
2062            );
2063        }
2064    }
2065
2066    #[test]
2067    fn security_rules_all_have_non_empty_fields() {
2068        for rule in SECURITY_RULES {
2069            assert!(
2070                !rule.name.is_empty(),
2071                "security rule {} missing name",
2072                rule.id
2073            );
2074            assert!(
2075                !rule.short.is_empty(),
2076                "security rule {} missing short description",
2077                rule.id
2078            );
2079            assert!(
2080                !rule.full.is_empty(),
2081                "security rule {} missing full description",
2082                rule.id
2083            );
2084        }
2085    }
2086
2087    #[test]
2088    fn check_rules_all_have_non_empty_fields() {
2089        for rule in CHECK_RULES {
2090            assert!(!rule.name.is_empty(), "check rule {} missing name", rule.id);
2091            assert!(
2092                !rule.short.is_empty(),
2093                "check rule {} missing short description",
2094                rule.id
2095            );
2096            assert!(
2097                !rule.full.is_empty(),
2098                "check rule {} missing full description",
2099                rule.id
2100            );
2101        }
2102    }
2103
2104    #[test]
2105    fn rule_docs_url_health_rule() {
2106        let rule = rule_by_id("fallow/high-cyclomatic-complexity").unwrap();
2107        let url = rule_docs_url(rule);
2108        assert!(url.starts_with("https://fallow.tools/docs/"));
2109        assert!(url.contains("health"));
2110    }
2111
2112    #[test]
2113    fn rule_docs_url_dupes_rule() {
2114        let rule = rule_by_id("fallow/code-duplication").unwrap();
2115        let url = rule_docs_url(rule);
2116        assert!(url.starts_with("https://fallow.tools/docs/"));
2117        assert!(url.contains("duplication"));
2118    }
2119
2120    #[test]
2121    fn rule_docs_url_security_rule() {
2122        let rule = rule_by_id("security/sql-injection").unwrap();
2123        let url = rule_docs_url(rule);
2124        assert_eq!(url, "https://fallow.tools/docs/cli/security/");
2125    }
2126
2127    #[test]
2128    fn health_meta_all_metrics_have_name_and_description() {
2129        let meta = health_meta();
2130        let metrics = meta["metrics"].as_object().unwrap();
2131        for (key, value) in metrics {
2132            assert!(
2133                value.get("name").is_some(),
2134                "health metric {key} missing 'name'"
2135            );
2136            assert!(
2137                value.get("description").is_some(),
2138                "health metric {key} missing 'description'"
2139            );
2140            assert!(
2141                value.get("interpretation").is_some(),
2142                "health metric {key} missing 'interpretation'"
2143            );
2144        }
2145    }
2146
2147    #[test]
2148    fn health_meta_has_all_expected_metrics() {
2149        let meta = health_meta();
2150        let metrics = meta["metrics"].as_object().unwrap();
2151        let expected = [
2152            "cyclomatic",
2153            "cognitive",
2154            "line_count",
2155            "lines",
2156            "maintainability_index",
2157            "complexity_density",
2158            "dead_code_ratio",
2159            "fan_in",
2160            "fan_out",
2161            "score",
2162            "weighted_commits",
2163            "median_files_per_commit",
2164            "median_lines_per_commit",
2165            "degree",
2166            "trend",
2167            "priority",
2168            "efficiency",
2169            "effort",
2170            "confidence",
2171            "bus_factor",
2172            "contributor_count",
2173            "share",
2174            "stale_days",
2175            "drift",
2176            "unowned",
2177            "runtime_coverage_verdict",
2178            "runtime_coverage_state",
2179            "runtime_coverage_confidence",
2180            "production_invocations",
2181            "percent_dead_in_production",
2182        ];
2183        for key in &expected {
2184            assert!(
2185                metrics.contains_key(*key),
2186                "health_meta missing expected metric: {key}"
2187            );
2188        }
2189    }
2190
2191    #[test]
2192    fn dupes_meta_all_metrics_have_name_and_description() {
2193        let meta = dupes_meta();
2194        let metrics = meta["metrics"].as_object().unwrap();
2195        for (key, value) in metrics {
2196            assert!(
2197                value.get("name").is_some(),
2198                "dupes metric {key} missing 'name'"
2199            );
2200            assert!(
2201                value.get("description").is_some(),
2202                "dupes metric {key} missing 'description'"
2203            );
2204        }
2205    }
2206
2207    #[test]
2208    fn dupes_meta_has_line_count() {
2209        let meta = dupes_meta();
2210        let metrics = meta["metrics"].as_object().unwrap();
2211        assert!(metrics.contains_key("line_count"));
2212    }
2213
2214    #[test]
2215    fn check_docs_url_valid() {
2216        assert!(fallow_output::CHECK_DOCS.starts_with("https://"));
2217        assert!(fallow_output::CHECK_DOCS.contains("dead-code"));
2218    }
2219
2220    #[test]
2221    fn health_docs_url_valid() {
2222        assert!(fallow_output::HEALTH_DOCS.starts_with("https://"));
2223        assert!(fallow_output::HEALTH_DOCS.contains("health"));
2224    }
2225
2226    #[test]
2227    fn dupes_docs_url_valid() {
2228        assert!(fallow_output::DUPES_DOCS.starts_with("https://"));
2229        assert!(fallow_output::DUPES_DOCS.contains("dupes"));
2230    }
2231
2232    #[test]
2233    fn check_meta_docs_url_matches_constant() {
2234        let meta = check_meta();
2235        assert_eq!(meta["docs"].as_str().unwrap(), fallow_output::CHECK_DOCS);
2236    }
2237
2238    #[test]
2239    fn health_meta_docs_url_matches_constant() {
2240        let meta = health_meta();
2241        assert_eq!(meta["docs"].as_str().unwrap(), fallow_output::HEALTH_DOCS);
2242    }
2243
2244    #[test]
2245    fn dupes_meta_docs_url_matches_constant() {
2246        let meta = dupes_meta();
2247        assert_eq!(meta["docs"].as_str().unwrap(), fallow_output::DUPES_DOCS);
2248    }
2249
2250    #[test]
2251    fn check_rules_count() {
2252        assert_eq!(CHECK_RULES.len(), 52);
2253    }
2254
2255    #[test]
2256    fn health_rules_count() {
2257        assert_eq!(HEALTH_RULES.len(), 21);
2258    }
2259
2260    #[test]
2261    fn dupes_rules_count() {
2262        assert_eq!(DUPES_RULES.len(), 1);
2263    }
2264
2265    #[test]
2266    fn flags_rules_count() {
2267        assert_eq!(FLAGS_RULES.len(), 2);
2268    }
2269
2270    #[test]
2271    fn security_rules_count() {
2272        assert_eq!(
2273            SECURITY_RULES.len(),
2274            matcher_entries_from_security_catalogue().len() + 3
2275        );
2276    }
2277
2278    #[test]
2279    fn security_rules_cover_every_catalogue_matcher() {
2280        let mut rule_ids = rustc_hash::FxHashSet::default();
2281        for rule in SECURITY_RULES {
2282            rule_ids.insert(rule.id);
2283        }
2284
2285        for matcher in matcher_entries_from_security_catalogue() {
2286            let rule_id = format!("security/{}", matcher.id);
2287            assert!(
2288                rule_ids.contains(rule_id.as_str()),
2289                "security matcher {} has no explain rule",
2290                matcher.id
2291            );
2292        }
2293    }
2294
2295    #[test]
2296    fn security_catalogue_rules_match_catalogue_title_and_cwe() {
2297        for matcher in matcher_entries_from_security_catalogue() {
2298            let rule_id = format!("security/{}", matcher.id);
2299            let rule = rule_by_id(&rule_id)
2300                .unwrap_or_else(|| panic!("security matcher {} has no explain rule", matcher.id));
2301            let cwe = format!("CWE-{}", matcher.cwe);
2302            assert_eq!(
2303                rule.name, matcher.title,
2304                "security matcher {} has stale explain title",
2305                matcher.id
2306            );
2307            assert!(
2308                rule.short.contains(&cwe),
2309                "security matcher {} explain summary does not mention {cwe}",
2310                matcher.id
2311            );
2312            assert!(
2313                rule.full.contains(&cwe),
2314                "security matcher {} explain rationale does not mention {cwe}",
2315                matcher.id
2316            );
2317        }
2318    }
2319
2320    /// Every registered rule must declare a category. The PR/MR sticky
2321    /// renderer reads this via `category_for_rule`; without an entry the
2322    /// rule silently falls into the "Dead code" default and reviewers may
2323    /// see it grouped under an unexpected section. Catching this here is
2324    /// the same pattern as `check_rules_count` for the rule count itself.
2325    #[test]
2326    fn every_rule_declares_a_category() {
2327        let allowed = [
2328            "Dead code",
2329            "Dependencies",
2330            "Duplication",
2331            "Health",
2332            "Architecture",
2333            "Suppressions",
2334            "Security",
2335            "Policy",
2336            "Flags",
2337        ];
2338        for rule in CHECK_RULES
2339            .iter()
2340            .chain(HEALTH_RULES)
2341            .chain(DUPES_RULES)
2342            .chain(FLAGS_RULES)
2343            .chain(SECURITY_RULES)
2344        {
2345            assert!(
2346                !rule.category.is_empty(),
2347                "rule {} has empty category",
2348                rule.id
2349            );
2350            assert!(
2351                allowed.contains(&rule.category),
2352                "rule {} has unrecognised category {:?}; add to allowlist or pick from {:?}",
2353                rule.id,
2354                rule.category,
2355                allowed
2356            );
2357        }
2358    }
2359
2360    #[derive(Debug)]
2361    struct MatcherEntry {
2362        id: &'static str,
2363        title: &'static str,
2364        cwe: &'static str,
2365    }
2366
2367    fn matcher_entries_from_security_catalogue() -> Vec<MatcherEntry> {
2368        let toml = include_str!("../../security/data/security_matchers.toml");
2369        let mut entries = Vec::new();
2370        let mut in_matcher = false;
2371        let mut id = None;
2372        let mut title = None;
2373        let mut cwe = None;
2374
2375        for line in toml.lines() {
2376            let trimmed = line.trim();
2377            if trimmed == "[[matcher]]" {
2378                if let (Some(id), Some(title), Some(cwe)) = (id.take(), title.take(), cwe.take()) {
2379                    entries.push(MatcherEntry { id, title, cwe });
2380                }
2381                in_matcher = true;
2382                continue;
2383            }
2384            if trimmed.starts_with("[[") {
2385                if let (Some(id), Some(title), Some(cwe)) = (id.take(), title.take(), cwe.take()) {
2386                    entries.push(MatcherEntry { id, title, cwe });
2387                }
2388                in_matcher = false;
2389                continue;
2390            }
2391            if !in_matcher {
2392                continue;
2393            }
2394            if let Some(value) = trimmed
2395                .strip_prefix("id = \"")
2396                .and_then(|value| value.strip_suffix('"'))
2397            {
2398                id = Some(value);
2399            } else if let Some(value) = trimmed
2400                .strip_prefix("title = \"")
2401                .and_then(|value| value.strip_suffix('"'))
2402            {
2403                title = Some(value);
2404            } else if let Some(value) = trimmed.strip_prefix("cwe = ") {
2405                cwe = Some(value);
2406            }
2407        }
2408
2409        if let (Some(id), Some(title), Some(cwe)) = (id.take(), title.take(), cwe.take()) {
2410            entries.push(MatcherEntry { id, title, cwe });
2411        }
2412
2413        let mut seen = rustc_hash::FxHashSet::default();
2414        entries
2415            .into_iter()
2416            .filter(|entry| seen.insert(entry.id))
2417            .collect()
2418    }
2419
2420    /// A one-edit typo used to get the same hardcoded example list as a
2421    /// completely novel token, so the caller never saw the token that was
2422    /// actually one edit away.
2423    #[test]
2424    fn unknown_explain_error_names_the_token_one_edit_away() {
2425        let error = unknown_explain_error("unused-exportz");
2426        assert_eq!(error.code.as_deref(), Some("unknown_issue_type"));
2427        assert!(error.message.contains("unused-export"), "{}", error.message);
2428        assert_eq!(error.help.as_deref(), Some("fallow explain unused-export"));
2429        assert!(
2430            rule_by_token("unused-export").is_some(),
2431            "suggestion must resolve"
2432        );
2433    }
2434
2435    /// A token that resembles nothing registered must stay silent rather than
2436    /// point at an unrelated rule.
2437    #[test]
2438    fn unknown_explain_error_keeps_the_example_list_for_a_novel_token() {
2439        let error = unknown_explain_error("banana-split-detector");
2440        assert!(!error.message.contains("Did you mean"), "{}", error.message);
2441        assert_eq!(error.help, None);
2442    }
2443}