fallow_api/

list_runtime.rs

//! Programmatic list-command runtime helpers.

use std::path::{Path, PathBuf};

use fallow_config::{AuthoredRule, LogicalGroup, LogicalGroupStatus, ResolvedBoundaryConfig};
use fallow_output::{
    ListEntryPointOutput, RootEnvelopeMode, WorkspaceInfo as WorkspaceOutputInfo, WorkspacesOutput,
};
use fallow_types::discover::{DiscoveredFile, EntryPoint};
use rustc_hash::FxHashMap;

use crate::{
    AnalysisOptions, BoundariesListLogicalGroup, BoundariesListRule, BoundariesListZone,
    BoundariesListing, ListJsonEnvelope, ListJsonOutputInput, ProgrammaticError,
    analysis_context::changed_files_for_run, resolve_programmatic_analysis_context,
    serialize_list_json_output,
};

type ProgrammaticResult<T> = Result<T, ProgrammaticError>;

/// Options for MCP/project metadata listing through the programmatic API.
#[derive(Debug, Clone, Default)]
pub struct ProjectInfoOptions {
    /// Shared analysis options: root, config path, and cache behavior.
    pub analysis: AnalysisOptions,
    /// Include the resolved entry points in the output.
    pub entry_points: bool,
    /// Include the discovered file list in the output.
    pub files: bool,
    /// Include the detected plugin names in the output.
    pub plugins: bool,
    /// Include the boundaries listing in the output.
    pub boundaries: bool,
}

/// Options for `fallow list --boundaries` through the programmatic API.
#[derive(Debug, Clone, Default)]
pub struct ListBoundariesOptions {
    /// Shared analysis options: root, config path, and cache behavior.
    pub analysis: AnalysisOptions,
}

/// Typed output for project metadata listing before JSON serialization.
#[derive(Debug, Clone)]
pub struct ProjectInfoProgrammaticOutput {
    /// Detected plugin names; `None` when the section was not requested.
    pub plugins: Option<Vec<String>>,
    /// Discovered file paths; `None` when the section was not requested.
    pub files: Option<Vec<String>>,
    /// Resolved entry points; `None` when the section was not requested.
    pub entry_points: Option<Vec<ListEntryPointOutput>>,
    /// Boundaries listing; `None` when the section was not requested.
    pub boundaries: Option<BoundariesListing>,
    /// Workspace listing; `None` when the section was not requested.
    pub workspaces: Option<WorkspacesOutput<fallow_config::WorkspaceDiagnostic>>,
    /// Which list envelope shape wraps the serialized body.
    pub envelope: ListJsonEnvelope,
    /// Whether the serialized root envelope carries a `kind` discriminant.
    pub envelope_mode: RootEnvelopeMode,
}

/// Serialize typed project-info output to the stable JSON contract.
///
/// # Errors
///
/// Returns a structured programmatic error when JSON serialization fails.
pub fn serialize_project_info_programmatic_json(
    output: ProjectInfoProgrammaticOutput,
) -> ProgrammaticResult<serde_json::Value> {
    serialize_list_json_output(
        ListJsonOutputInput {
            plugins: output.plugins,
            files: output.files,
            entry_points: output.entry_points,
            boundaries: output.boundaries,
            workspaces: output.workspaces,
        },
        output.envelope_mode,
        output.envelope,
    )
    .map_err(|err| {
        ProgrammaticError::new(format!("failed to serialize project info output: {err}"), 2)
            .with_code("FALLOW_PROJECT_INFO_SERIALIZE_FAILED")
            .with_context("project_info")
    })
}

/// Typed output for `fallow list --boundaries` before JSON serialization.
#[derive(Debug, Clone)]
pub struct ListBoundariesProgrammaticOutput {
    /// Typed boundaries listing produced by the run.
    pub boundaries: BoundariesListing,
    /// Whether the serialized root envelope carries a `kind` discriminant.
    pub envelope_mode: RootEnvelopeMode,
}

/// Serialize typed boundary-list output to the stable JSON contract.
///
/// # Errors
///
/// Returns a structured programmatic error when JSON serialization fails.
pub fn serialize_list_boundaries_programmatic_json(
    output: ListBoundariesProgrammaticOutput,
) -> ProgrammaticResult<serde_json::Value> {
    serialize_list_json_output(
        ListJsonOutputInput::<BoundariesListing, serde_json::Value> {
            plugins: None,
            files: None,
            entry_points: None,
            boundaries: Some(output.boundaries),
            workspaces: None,
        },
        output.envelope_mode,
        ListJsonEnvelope::Boundaries,
    )
    .map_err(|err| {
        ProgrammaticError::new(
            format!("failed to serialize list boundaries output: {err}"),
            2,
        )
        .with_code("FALLOW_LIST_BOUNDARIES_SERIALIZE_FAILED")
        .with_context("list_boundaries")
    })
}

/// Owned boundary listing data shared by CLI and programmatic renderers.
#[derive(Debug, Clone)]
pub struct BoundaryData {
    /// Configured zones with per-zone matched file counts.
    pub zones: Vec<ZoneInfo>,
    /// Configured allow rules between zones.
    pub rules: Vec<RuleInfo>,
    /// Logical parent/child groups with derived file-count totals.
    pub logical_groups: Vec<LogicalGroupInfo>,
    /// Whether the resolved config declares no boundaries at all.
    pub is_empty: bool,
}

/// One configured boundary zone with its matched file count.
#[derive(Debug, Clone)]
pub struct ZoneInfo {
    /// Zone name from the config.
    pub name: String,
    /// Glob patterns that assign files to the zone.
    pub patterns: Vec<String>,
    /// Number of discovered files matching the zone.
    pub file_count: usize,
}

/// One configured boundary allow rule.
#[derive(Debug, Clone)]
pub struct RuleInfo {
    /// Source zone the rule applies to.
    pub from: String,
    /// Zone names the source zone may import from.
    pub allow: Vec<String>,
}

/// View-model mirror of [`LogicalGroup`] with derived file-count totals.
#[derive(Debug, Clone)]
pub struct LogicalGroupInfo {
    /// Parent zone name.
    pub name: String,
    /// Child zone names.
    pub children: Vec<String>,
    /// Authored `autoDiscover` paths.
    pub auto_discover: Vec<String>,
    /// Authored parent rule, if any.
    pub authored_rule: Option<AuthoredRule>,
    /// Fallback zone name, if the parent kept patterns.
    pub fallback_zone: Option<String>,
    /// Original `zones[]` index.
    pub source_zone_index: usize,
    /// Discovery status.
    pub status: LogicalGroupStatus,
    /// Total files across children plus the fallback zone.
    pub file_count: usize,
    /// Files matched by the child zones only.
    pub child_file_count: usize,
    /// Files matched by the fallback zone only.
    pub fallback_file_count: usize,
    /// Merged duplicate parent indices.
    pub merged_from: Option<Vec<usize>>,
    /// Authored parent root, if any.
    pub original_zone_root: Option<String>,
    /// Child-to-source zone indexes.
    pub child_source_indices: Vec<usize>,
}

/// Run `list_boundaries` through the API-owned runtime path.
///
/// # Errors
///
/// Returns a structured programmatic error for invalid options or config-load
/// failures.
pub fn run_list_boundaries(
    options: &ListBoundariesOptions,
) -> ProgrammaticResult<ListBoundariesProgrammaticOutput> {
    let resolved = resolve_programmatic_analysis_context(&options.analysis)?;
    resolved.install(|| {
        let project_config = load_list_project_config(&resolved)?;
        let session = fallow_engine::session::AnalysisSession::from_config(project_config);
        let changed_files = changed_files_for_run(&resolved)?;
        let discovered = scoped_discovered_files(session.files(), changed_files.as_ref());
        let data = compute_boundary_data(session.config(), Some(&discovered));

        Ok(ListBoundariesProgrammaticOutput {
            boundaries: boundary_data_to_output(&data),
            envelope_mode: RootEnvelopeMode::Tagged,
        })
    })
}

/// Run project metadata listing through the API-owned runtime path.
///
/// # Errors
///
/// Returns a structured programmatic error for invalid options, config-load
/// failures, or plugin regex errors.
pub fn run_project_info(
    options: &ProjectInfoOptions,
) -> ProgrammaticResult<ProjectInfoProgrammaticOutput> {
    let resolved = resolve_programmatic_analysis_context(&options.analysis)?;
    resolved.install(|| {
        let project_config = load_list_project_config(&resolved)?;
        let session = fallow_engine::session::AnalysisSession::from_config(project_config);
        let config = session.config();
        let workspaces = session.workspaces();
        let show_all = project_info_should_show_all(options);
        let changed_files = changed_files_for_run(&resolved)?;
        let discovered =
            project_info_discovered_files(options, show_all, &session, changed_files.as_ref());
        let discovered_ref = discovered.as_deref();

        let plugin_result = collect_plugin_result(
            resolved.root(),
            config,
            options,
            show_all,
            discovered_ref,
            workspaces,
        )?;
        let entry_points = collect_entry_points(
            config,
            options,
            show_all,
            discovered_ref,
            workspaces,
            plugin_result.as_ref(),
        );
        let boundaries = options
            .boundaries
            .then(|| boundary_data_to_output(&compute_boundary_data(config, discovered_ref)));
        let workspaces = if show_all {
            Some(collect_workspace_output(
                resolved.root(),
                workspaces,
                session.workspace_diagnostics(),
            ))
        } else {
            None
        };
        let envelope = if boundaries.is_some() {
            ListJsonEnvelope::Boundaries
        } else {
            ListJsonEnvelope::Plain
        };

        Ok(ProjectInfoProgrammaticOutput {
            plugins: collect_plugins(options, show_all, plugin_result.as_ref()),
            files: collect_files(options, show_all, discovered_ref, resolved.root()),
            entry_points: entry_points
                .map(|entries| entry_points_to_output(&entries, resolved.root())),
            boundaries,
            workspaces,
            envelope,
            envelope_mode: RootEnvelopeMode::Tagged,
        })
    })
}

fn project_info_discovered_files(
    options: &ProjectInfoOptions,
    show_all: bool,
    session: &fallow_engine::session::AnalysisSession,
    changed_files: Option<&rustc_hash::FxHashSet<PathBuf>>,
) -> Option<Vec<DiscoveredFile>> {
    let needs_discovery =
        options.files || options.entry_points || options.boundaries || options.plugins || show_all;
    needs_discovery.then(|| scoped_discovered_files(session.files(), changed_files))
}

fn scoped_discovered_files(
    files: &[DiscoveredFile],
    changed_files: Option<&rustc_hash::FxHashSet<PathBuf>>,
) -> Vec<DiscoveredFile> {
    let Some(changed_files) = changed_files else {
        return files.to_vec();
    };
    files
        .iter()
        .filter(|file| changed_files.contains(&file.path))
        .cloned()
        .collect()
}

fn load_list_project_config(
    resolved: &crate::ProgrammaticAnalysisContext,
) -> ProgrammaticResult<fallow_engine::project_config::ProjectConfig> {
    fallow_engine::project_config::config_for_project_analysis(
        resolved.root(),
        resolved.config_path().as_deref(),
        fallow_engine::project_config::ProjectConfigOptions {
            output: fallow_types::output_format::OutputFormat::Json,
            no_cache: resolved.no_cache(),
            threads: resolved.threads(),
            production_override: resolved.production_override(),
            quiet: true,
            analysis: fallow_config::ProductionAnalysis::DeadCode,
            allow_remote_extends: resolved.allow_remote_extends(),
        },
    )
    .map_err(|err| {
        ProgrammaticError::new(format!("failed to load config: {err}"), 2)
            .with_code("FALLOW_CONFIG_LOAD_FAILED")
            .with_context("analysis.configPath")
    })
}

const fn project_info_should_show_all(options: &ProjectInfoOptions) -> bool {
    !options.entry_points && !options.files && !options.plugins && !options.boundaries
}

fn collect_plugins(
    options: &ProjectInfoOptions,
    show_all: bool,
    plugin_result: Option<&fallow_engine::plugins::AggregatedPluginResult>,
) -> Option<Vec<String>> {
    if options.plugins || show_all {
        plugin_result.map(|plugin_result| plugin_result.active_plugins().to_vec())
    } else {
        None
    }
}

fn collect_files(
    options: &ProjectInfoOptions,
    show_all: bool,
    discovered: Option<&[DiscoveredFile]>,
    root: &Path,
) -> Option<Vec<String>> {
    if options.files || show_all {
        discovered.map(|files| {
            files
                .iter()
                .map(|file| format_display_path(&file.path, root))
                .collect()
        })
    } else {
        None
    }
}

fn collect_plugin_result(
    root: &Path,
    config: &fallow_config::ResolvedConfig,
    options: &ProjectInfoOptions,
    show_all: bool,
    discovered: Option<&[DiscoveredFile]>,
    workspaces: &[fallow_config::WorkspaceInfo],
) -> ProgrammaticResult<Option<fallow_engine::plugins::AggregatedPluginResult>> {
    if !(options.plugins || options.entry_points || show_all) {
        return Ok(None);
    }
    let Some(files) = discovered else {
        return Ok(None);
    };
    fallow_engine::list_inventory::collect_active_plugins(root, config, files, workspaces)
        .map(Some)
        .map_err(|err| match err {
            fallow_engine::list_inventory::ListInventoryError::PluginRegex(errors) => {
                ProgrammaticError::new(
                    fallow_engine::plugins::registry::format_plugin_regex_errors(&errors),
                    2,
                )
                .with_code("FALLOW_PLUGIN_REGEX_FAILED")
                .with_context("project_info.plugins")
            }
        })
}

fn collect_entry_points(
    config: &fallow_config::ResolvedConfig,
    options: &ProjectInfoOptions,
    show_all: bool,
    discovered: Option<&[DiscoveredFile]>,
    workspaces: &[fallow_config::WorkspaceInfo],
    plugin_result: Option<&fallow_engine::plugins::AggregatedPluginResult>,
) -> Option<Vec<EntryPoint>> {
    if !(options.entry_points || show_all) {
        return None;
    }
    let discovered = discovered?;
    Some(fallow_engine::list_inventory::collect_entry_points(
        config,
        discovered,
        workspaces,
        plugin_result,
    ))
}

fn entry_points_to_output(entries: &[EntryPoint], root: &Path) -> Vec<ListEntryPointOutput> {
    entries
        .iter()
        .map(|entry| ListEntryPointOutput {
            path: format_display_path(&entry.path, root),
            source: entry.source.to_string(),
        })
        .collect()
}

fn collect_workspace_output(
    root: &Path,
    workspaces: &[fallow_config::WorkspaceInfo],
    diagnostics: &[fallow_config::WorkspaceDiagnostic],
) -> WorkspacesOutput<fallow_config::WorkspaceDiagnostic> {
    let workspaces = workspaces
        .iter()
        .map(|workspace| {
            let relative = workspace.root.strip_prefix(root).unwrap_or(&workspace.root);
            WorkspaceOutputInfo {
                name: workspace.name.clone(),
                path: relative.display().to_string().replace('\\', "/"),
                is_internal_dependency: workspace.is_internal_dependency,
            }
        })
        .collect::<Vec<_>>();
    WorkspacesOutput {
        workspace_count: workspaces.len(),
        workspaces,
        // Project-relative like the sibling `workspaces[].path` and like every
        // analysis envelope's `workspace_diagnostics[]`. The list envelope has
        // no post-serialization `strip_root_prefix` pass, so it normalises here.
        workspace_diagnostics: diagnostics
            .iter()
            .map(|diagnostic| diagnostic.clone().into_root_relative(root))
            .collect(),
    }
}

fn format_display_path(path: &Path, root: &Path) -> String {
    path.strip_prefix(root)
        .unwrap_or(path)
        .display()
        .to_string()
        .replace('\\', "/")
}

/// Compute boundary listing data from resolved config and optional discovery.
#[must_use]
pub fn compute_boundary_data(
    config: &fallow_config::ResolvedConfig,
    discovered: Option<&[DiscoveredFile]>,
) -> BoundaryData {
    let boundaries = &config.boundaries;

    if boundaries.is_empty() {
        return BoundaryData {
            zones: vec![],
            rules: vec![],
            logical_groups: vec![],
            is_empty: true,
        };
    }

    let zones = build_boundary_zones(config, discovered);
    let rules = build_boundary_rules(boundaries);
    let logical_groups = build_logical_groups(boundaries, &zones);

    BoundaryData {
        zones,
        rules,
        logical_groups,
        is_empty: false,
    }
}

fn build_boundary_zones(
    config: &fallow_config::ResolvedConfig,
    discovered: Option<&[DiscoveredFile]>,
) -> Vec<ZoneInfo> {
    config
        .boundaries
        .zones
        .iter()
        .map(|zone| ZoneInfo {
            name: zone.name.clone(),
            patterns: zone.matchers.iter().map(|m| m.glob().to_string()).collect(),
            file_count: count_boundary_zone_files(config, discovered, &zone.name),
        })
        .collect()
}

fn count_boundary_zone_files(
    config: &fallow_config::ResolvedConfig,
    discovered: Option<&[DiscoveredFile]>,
    zone_name: &str,
) -> usize {
    discovered.map_or(0, |files| {
        files
            .iter()
            .filter(|file| {
                let rel = file
                    .path
                    .strip_prefix(&config.root)
                    .ok()
                    .map(|path| path.to_string_lossy().replace('\\', "/"));
                rel.is_some_and(|path| config.boundaries.classify_zone(&path) == Some(zone_name))
            })
            .count()
    })
}

fn build_boundary_rules(boundaries: &ResolvedBoundaryConfig) -> Vec<RuleInfo> {
    boundaries
        .rules
        .iter()
        .map(|rule| RuleInfo {
            from: rule.from_zone.clone(),
            allow: rule.allowed_zones.clone(),
        })
        .collect()
}

fn build_logical_groups(
    boundaries: &ResolvedBoundaryConfig,
    zones: &[ZoneInfo],
) -> Vec<LogicalGroupInfo> {
    let zone_count_by_name: FxHashMap<&str, usize> = zones
        .iter()
        .map(|zone| (zone.name.as_str(), zone.file_count))
        .collect();

    boundaries
        .logical_groups
        .iter()
        .map(|group| logical_group_info(group, &zone_count_by_name))
        .collect()
}

fn logical_group_info(
    group: &LogicalGroup,
    zone_count_by_name: &FxHashMap<&str, usize>,
) -> LogicalGroupInfo {
    let child_file_count: usize = group
        .children
        .iter()
        .filter_map(|child| zone_count_by_name.get(child.as_str()).copied())
        .sum();
    let fallback_file_count = group
        .fallback_zone
        .as_deref()
        .and_then(|fallback| zone_count_by_name.get(fallback).copied())
        .unwrap_or(0);

    LogicalGroupInfo {
        name: group.name.clone(),
        children: group.children.clone(),
        auto_discover: group.auto_discover.clone(),
        authored_rule: group.authored_rule.clone(),
        fallback_zone: group.fallback_zone.clone(),
        source_zone_index: group.source_zone_index,
        status: group.status,
        file_count: child_file_count + fallback_file_count,
        child_file_count,
        fallback_file_count,
        merged_from: group.merged_from.clone(),
        original_zone_root: group.original_zone_root.clone(),
        child_source_indices: group.child_source_indices.clone(),
    }
}

/// Convert boundary listing data to the stable output contract.
#[must_use]
pub fn boundary_data_to_output(data: &BoundaryData) -> BoundariesListing {
    if data.is_empty {
        return BoundariesListing {
            configured: false,
            zone_count: 0,
            zones: Vec::new(),
            rule_count: 0,
            rules: Vec::new(),
            logical_group_count: 0,
            logical_groups: Vec::new(),
        };
    }

    BoundariesListing {
        configured: true,
        zone_count: data.zones.len(),
        zones: data
            .zones
            .iter()
            .map(|zone| BoundariesListZone {
                name: zone.name.clone(),
                patterns: zone.patterns.clone(),
                file_count: zone.file_count,
            })
            .collect(),
        rule_count: data.rules.len(),
        rules: data
            .rules
            .iter()
            .map(|rule| BoundariesListRule {
                from: rule.from.clone(),
                allow: rule.allow.clone(),
            })
            .collect(),
        logical_group_count: data.logical_groups.len(),
        logical_groups: data
            .logical_groups
            .iter()
            .map(logical_group_info_to_output)
            .collect(),
    }
}

fn logical_group_info_to_output(group: &LogicalGroupInfo) -> BoundariesListLogicalGroup {
    BoundariesListLogicalGroup {
        name: group.name.clone(),
        children: group.children.clone(),
        auto_discover: group.auto_discover.clone(),
        status: group.status,
        source_zone_index: group.source_zone_index,
        file_count: group.file_count,
        authored_rule: group.authored_rule.clone(),
        fallback_zone: group.fallback_zone.clone(),
        merged_from: group.merged_from.clone(),
        original_zone_root: group.original_zone_root.clone(),
        child_source_indices: group.child_source_indices.clone(),
    }
}

#[cfg(test)]
mod tests {
    use std::process::Command;

    use serde_json::json;

    use super::*;

    /// The `fallow workspaces` / `fallow list --workspaces` envelope and the
    /// MCP `project_info` tool have no post-serialization `strip_root_prefix`
    /// pass, so `collect_workspace_output` is what makes their diagnostic
    /// paths project-relative like every other envelope's.
    #[test]
    fn workspace_output_emits_project_relative_diagnostic_paths() {
        let root = Path::new("/project");
        let output = collect_workspace_output(
            root,
            &[],
            &[fallow_config::WorkspaceDiagnostic::new(
                root,
                root.join("packages/inner"),
                fallow_config::WorkspaceDiagnosticKind::UndeclaredWorkspace,
            )],
        );

        let value = serde_json::to_value(&output).expect("workspaces output serializes");
        assert_eq!(value["workspace_diagnostics"][0]["path"], "packages/inner");
    }

    fn empty_boundary_data() -> BoundaryData {
        BoundaryData {
            zones: vec![],
            rules: vec![],
            logical_groups: vec![],
            is_empty: true,
        }
    }

    fn boundary_data_to_json(data: &BoundaryData) -> serde_json::Value {
        serde_json::to_value(boundary_data_to_output(data))
            .expect("boundary list output should serialize")
    }

    fn git(project: &Path, args: &[&str]) {
        let status = Command::new("git")
            .args(args)
            .current_dir(project)
            .status()
            .expect("git command should run");
        assert!(status.success(), "git {args:?} failed");
    }

    fn setup_changed_boundary_project() -> tempfile::TempDir {
        let project = tempfile::tempdir().expect("project");
        std::fs::write(
            project.path().join("package.json"),
            r#"{"name":"changed-list-api","main":"src/app/index.ts"}"#,
        )
        .expect("write package");
        std::fs::write(
            project.path().join(".fallowrc.json"),
            r#"{
                "boundaries": {
                    "zones": [
                        { "name": "app", "patterns": ["src/app/**"] },
                        { "name": "shared", "patterns": ["src/shared/**"] }
                    ]
                }
            }"#,
        )
        .expect("write config");
        std::fs::create_dir_all(project.path().join("src/app")).expect("create app");
        std::fs::create_dir_all(project.path().join("src/shared")).expect("create shared");
        std::fs::write(
            project.path().join("src/app/index.ts"),
            "export const app = 1;\n",
        )
        .expect("write app");
        std::fs::write(
            project.path().join("src/shared/index.ts"),
            "export const shared = 1;\n",
        )
        .expect("write shared");

        git(project.path(), &["init", "-q"]);
        git(
            project.path(),
            &["config", "user.email", "test@example.com"],
        );
        git(project.path(), &["config", "user.name", "Test User"]);
        git(project.path(), &["config", "commit.gpgsign", "false"]);
        git(project.path(), &["add", "."]);
        git(project.path(), &["commit", "-qm", "initial"]);
        std::fs::write(
            project.path().join("src/app/index.ts"),
            "export const app = 2;\n",
        )
        .expect("modify app");
        project
    }

    #[test]
    fn project_info_default_sections_match_plain_list_contract() {
        let project = tempfile::tempdir().expect("project");
        std::fs::write(
            project.path().join("package.json"),
            r#"{"name":"project-info-api","main":"src/index.ts"}"#,
        )
        .expect("write package");
        std::fs::create_dir_all(project.path().join("src")).expect("create src");
        std::fs::write(
            project.path().join("src/index.ts"),
            "export const value = 1;\n",
        )
        .expect("write source");

        let output = serialize_project_info_programmatic_json(
            run_project_info(&ProjectInfoOptions {
                analysis: AnalysisOptions {
                    root: Some(project.path().to_path_buf()),
                    no_cache: true,
                    ..AnalysisOptions::default()
                },
                ..ProjectInfoOptions::default()
            })
            .expect("project info should run"),
        )
        .expect("project info should serialize");

        assert_eq!(output["file_count"], 1);
        assert_eq!(output["files"][0], "src/index.ts");
        assert_eq!(output["entry_point_count"], 1);
        assert_eq!(output["workspace_count"], 0);
        assert!(output.get("kind").is_none());
    }

    #[test]
    fn project_info_surfaces_malformed_root_package_json() {
        let project = tempfile::tempdir().expect("project");
        std::fs::write(project.path().join("package.json"), "{").expect("write package");

        let err = run_project_info(&ProjectInfoOptions {
            analysis: AnalysisOptions {
                root: Some(project.path().to_path_buf()),
                no_cache: true,
                ..AnalysisOptions::default()
            },
            ..ProjectInfoOptions::default()
        })
        .expect_err("malformed root package.json must fail project info");

        assert_eq!(err.exit_code, 2);
        assert_eq!(err.code.as_deref(), Some("FALLOW_CONFIG_LOAD_FAILED"));
        assert!(
            err.message.contains("package.json"),
            "error should name the malformed root package.json"
        );
    }

    #[test]
    fn project_info_default_sections_include_undeclared_workspace_diagnostic() {
        let project = tempfile::tempdir().expect("project");
        std::fs::write(
            project.path().join("package.json"),
            r#"{"name":"project-info-api","workspaces":["packages/*"]}"#,
        )
        .expect("write package");
        std::fs::create_dir_all(project.path().join("packages/app")).expect("workspace dir");
        std::fs::write(
            project.path().join("packages/app/package.json"),
            r#"{"name":"app","main":"src/index.ts"}"#,
        )
        .expect("write workspace package");
        std::fs::create_dir_all(project.path().join("tools/extra")).expect("extra package dir");
        std::fs::write(
            project.path().join("tools/extra/package.json"),
            r#"{"name":"extra"}"#,
        )
        .expect("write extra package");

        let output = serialize_project_info_programmatic_json(
            run_project_info(&ProjectInfoOptions {
                analysis: AnalysisOptions {
                    root: Some(project.path().to_path_buf()),
                    no_cache: true,
                    ..AnalysisOptions::default()
                },
                ..ProjectInfoOptions::default()
            })
            .expect("project info should run"),
        )
        .expect("project info should serialize");

        let diagnostics = output["workspace_diagnostics"]
            .as_array()
            .expect("project info should include workspace_diagnostics");
        assert!(
            diagnostics.iter().any(|diagnostic| {
                diagnostic["kind"].as_str() == Some("undeclared-workspace")
                    // Project-relative, like every other envelope's
                    // `workspace_diagnostics[].path` (issue #2366 follow-up).
                    && diagnostic["path"].as_str() == Some("tools/extra")
            }),
            "project info must include undeclared workspace diagnostics from the reused session, got {diagnostics:#?}"
        );
    }

    /// Issue #2366: the MCP `project_info` tool reads the same workspace value
    /// the `fallow workspaces` envelope does, so a glob declared in both
    /// `package.json` and `pnpm-workspace.yaml` must reach an agent as one
    /// entry per directory, project-relative, exactly as the CLI reports it.
    #[test]
    fn project_info_reports_one_entry_per_directory_for_a_glob_in_two_manifests() {
        let project = tempfile::tempdir().expect("project");
        let root = project.path();
        std::fs::create_dir_all(root.join("pkgs/aaa")).expect("first package-less dir");
        std::fs::create_dir_all(root.join("pkgs/bbb")).expect("second package-less dir");
        std::fs::create_dir_all(root.join("src")).expect("source dir");
        std::fs::write(
            root.join("package.json"),
            r#"{"name":"two-manifest-root","private":true,"workspaces":["./pkgs/*"]}"#,
        )
        .expect("write root manifest");
        std::fs::write(
            root.join("pnpm-workspace.yaml"),
            "packages:\n  - \"pkgs/*\"\n",
        )
        .expect("write pnpm workspace manifest");
        std::fs::write(root.join("src/index.ts"), "export const value = 1;\n")
            .expect("write source");

        let output = serialize_project_info_programmatic_json(
            run_project_info(&ProjectInfoOptions {
                analysis: AnalysisOptions {
                    root: Some(root.to_path_buf()),
                    no_cache: true,
                    ..AnalysisOptions::default()
                },
                ..ProjectInfoOptions::default()
            })
            .expect("project info should run"),
        )
        .expect("project info should serialize");

        let reported: Vec<(&str, &str)> = output["workspace_diagnostics"]
            .as_array()
            .expect("project info should include workspace_diagnostics")
            .iter()
            .map(|diagnostic| {
                (
                    diagnostic["pattern"].as_str().unwrap_or_default(),
                    diagnostic["path"].as_str().unwrap_or_default(),
                )
            })
            .collect();

        assert_eq!(
            reported,
            vec![("pkgs/*", "pkgs/aaa"), ("pkgs/*", "pkgs/bbb")],
            "project_info agrees with the CLI envelopes: {}",
            output["workspace_diagnostics"]
        );
    }

    #[test]
    fn list_runtimes_scope_files_and_boundary_counts_to_changed_since() {
        let project = setup_changed_boundary_project();
        let analysis = AnalysisOptions {
            root: Some(project.path().to_path_buf()),
            changed_since: Some("HEAD".to_string()),
            no_cache: true,
            ..AnalysisOptions::default()
        };

        let project_info = serialize_project_info_programmatic_json(
            run_project_info(&ProjectInfoOptions {
                analysis: analysis.clone(),
                files: true,
                boundaries: true,
                ..ProjectInfoOptions::default()
            })
            .expect("project info should run"),
        )
        .expect("project info should serialize");
        let files = project_info["files"].as_array().expect("files array");
        assert_eq!(files, &[json!("src/app/index.ts")]);
        assert_eq!(project_info["boundaries"]["zones"][0]["file_count"], 1);
        assert_eq!(project_info["boundaries"]["zones"][1]["file_count"], 0);

        let boundaries = serialize_list_boundaries_programmatic_json(
            run_list_boundaries(&ListBoundariesOptions { analysis })
                .expect("list boundaries should run"),
        )
        .expect("list boundaries should serialize");
        assert_eq!(boundaries["boundaries"]["zones"][0]["file_count"], 1);
        assert_eq!(boundaries["boundaries"]["zones"][1]["file_count"], 0);
    }

    #[test]
    fn boundary_json_empty_includes_logical_groups_key() {
        let value = boundary_data_to_json(&empty_boundary_data());

        assert_eq!(value["configured"], false);
        assert_eq!(value["zone_count"], 0);
        assert_eq!(value["rule_count"], 0);
        assert_eq!(value["logical_group_count"], 0);
        assert_eq!(value["logical_groups"], json!([]));
    }

    #[test]
    fn boundary_json_logical_group_carries_all_fields() {
        let data = BoundaryData {
            zones: vec![ZoneInfo {
                name: "features/auth".to_string(),
                patterns: vec!["src/features/auth/**".to_string()],
                file_count: 3,
            }],
            rules: vec![],
            logical_groups: vec![LogicalGroupInfo {
                name: "features".to_string(),
                children: vec!["features/auth".to_string()],
                auto_discover: vec!["./src/features/".to_string()],
                authored_rule: Some(AuthoredRule {
                    allow: vec!["shared".to_string()],
                    allow_type_only: vec!["types".to_string()],
                }),
                fallback_zone: None,
                source_zone_index: 1,
                status: LogicalGroupStatus::Ok,
                file_count: 3,
                child_file_count: 3,
                fallback_file_count: 0,
                merged_from: None,
                original_zone_root: None,
                child_source_indices: vec![],
            }],
            is_empty: false,
        };

        let value = boundary_data_to_json(&data);
        let group = &value["logical_groups"][0];

        assert_eq!(value["logical_group_count"], 1);
        assert_eq!(group["name"], "features");
        assert_eq!(group["children"][0], "features/auth");
        assert_eq!(group["auto_discover"][0], "./src/features/");
        assert_eq!(group["status"], "ok");
        assert_eq!(group["source_zone_index"], 1);
        assert_eq!(group["file_count"], 3);
        assert_eq!(group["authored_rule"]["allow"][0], "shared");
        assert_eq!(group["authored_rule"]["allow_type_only"][0], "types");
        assert!(group.get("fallback_zone").is_none());
        assert!(group.get("merged_from").is_none());
        assert!(group.get("original_zone_root").is_none());
        assert!(group.get("child_source_indices").is_none());
    }

    #[test]
    fn boundary_json_logical_group_optional_fields_round_trip() {
        let data = BoundaryData {
            zones: vec![],
            rules: vec![],
            logical_groups: vec![LogicalGroupInfo {
                name: "features".to_string(),
                children: vec!["features/auth".to_string(), "features/billing".to_string()],
                auto_discover: vec!["src/features".to_string(), "src/modules".to_string()],
                authored_rule: None,
                fallback_zone: Some("features".to_string()),
                source_zone_index: 0,
                status: LogicalGroupStatus::Empty,
                file_count: 2,
                child_file_count: 0,
                fallback_file_count: 2,
                merged_from: Some(vec![0, 3]),
                original_zone_root: Some("packages/app/".to_string()),
                child_source_indices: vec![0, 1],
            }],
            is_empty: false,
        };

        let group = &boundary_data_to_json(&data)["logical_groups"][0];

        assert_eq!(group["status"], "empty");
        assert_eq!(group["fallback_zone"], "features");
        assert_eq!(group["merged_from"][1], 3);
        assert_eq!(group["original_zone_root"], "packages/app/");
        assert_eq!(group["child_source_indices"][1], 1);
    }
}