entelix_core/

llm_facing.rs

//! LLM-facing channel — type-level separation of operator-facing
//! diagnostics from the value the model actually sees (invariant #16).
//!
//! Two surfaces, both narrowly defined:
//!
//! - [`LlmRenderable`] — `render_for_llm()` returns the raw model-facing
//!   value; `for_llm()` wraps it in a sealed [`RenderedForLlm`] carrier
//!   so emit sites cannot fabricate model-facing content without
//!   passing through a registered impl. Implementors keep prose brief,
//!   omit operator-only context (status codes, type-system
//!   identifiers, source chains), and never echo input payloads —
//!   those are prompt-injection vectors.
//! - [`LlmFacingSchema`] — `strip(&Value) -> Value` reduces a JSON
//!   Schema to the keys vendor APIs actually consume (`type`,
//!   `properties`, `required`, `items`, `enum`, `description`,
//!   bounds…). Schemars-generated knobs (`$schema`, `title`,
//!   `$defs`, `$ref`, format specifiers like `int64`) ride out.
//!   Saves 30–120 tokens per tool per request × every turn.
//!
//! ## Why the sealed carrier
//!
//! Errors, future sub-agent results, approval decisions, and
//! memory-recall summaries all flow through the same funnel toward
//! the model's context window. Without a sealed carrier any
//! `String`-typed field can be fabricated by external code — a
//! reviewer reading an emit site cannot distinguish "this string
//! went through the LLM-facing rendering" from "this string was
//! built directly from operator content". Wrapping the value in
//! `RenderedForLlm<T>` whose constructor is private to this
//! module makes the boundary structural: the only path from value
//! to carrier is the trait's default `for_llm` impl, which wraps
//! the implementer's `render_for_llm` output. A subtype that
//! tries to override `for_llm` cannot reach `RenderedForLlm::new`,
//! so the sealing holds across crate boundaries.
//!
//! ## Why a separate trait rather than a method on `Error`
//!
//! The split lets non-`Error` types (custom tool error wrappers, MCP
//! server errors lifted into IR, future sub-agent result types) opt
//! into the same contract without coupling to `entelix_core::Error`.
//! Default impls on `Error` and `String`/`&str` cover the common
//! cases; bespoke implementors override `render_for_llm` only.
//!
//! ## Enforcement
//!
//! `crates/entelix-tools/tests/llm_context_economy.rs` regression-checks
//! that built-in tool outputs and tool-spec schemas never leak the
//! forbidden patterns. CI rejects new sites silently re-introducing
//! operator-channel content into the model's view.

use std::collections::BTreeMap;

use serde_json::{Map, Value};

use crate::error::Error;

/// Sealed carrier for a model-facing value of type `T`. Constructed
/// only by [`LlmRenderable::for_llm`]'s default impl — the
/// constructor is `pub(crate)`, so an external crate that
/// implements [`LlmRenderable<T>`] for its own type can override
/// `render_for_llm` (the raw producer) but cannot override
/// `for_llm` (the carrier-producing wrapper) because it has no way
/// to reach `RenderedForLlm::new`. Emit sites that accept
/// `RenderedForLlm<T>` therefore receive a value that
/// structurally must have come through the trait funnel.
///
/// `RenderedForLlm` is intentionally minimal — it exposes
/// [`Self::into_inner`] for consumers that need to forward the
/// underlying value (the audit-log projection of
/// `AgentEvent::ToolError` does exactly this when emitting the
/// model-safe rendering as `GraphEvent::ToolResult` content). The
/// carrier carries no metadata because the boundary it enforces is
/// authorship, not provenance.
#[derive(Clone, Debug, Eq, Hash, PartialEq)]
pub struct RenderedForLlm<T>(T);

impl<T> RenderedForLlm<T> {
    /// Sealed constructor — only [`LlmRenderable::for_llm`]'s
    /// default impl reaches this. `pub(crate)` is the entire seal.
    pub(crate) const fn new(inner: T) -> Self {
        Self(inner)
    }

    /// Borrow the inner model-facing value.
    #[must_use]
    pub const fn as_inner(&self) -> &T {
        &self.0
    }

    /// Consume the carrier and return the inner value.
    #[must_use]
    pub fn into_inner(self) -> T {
        self.0
    }
}

impl<T: AsRef<str>> AsRef<str> for RenderedForLlm<T> {
    fn as_ref(&self) -> &str {
        self.0.as_ref()
    }
}

impl<T: std::fmt::Display> std::fmt::Display for RenderedForLlm<T> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        self.0.fmt(f)
    }
}

impl<T> serde::Serialize for RenderedForLlm<T>
where
    T: serde::Serialize,
{
    fn serialize<S: serde::Serializer>(&self, ser: S) -> std::result::Result<S::Ok, S::Error> {
        self.0.serialize(ser)
    }
}

impl<'de, T> serde::Deserialize<'de> for RenderedForLlm<T>
where
    T: serde::Deserialize<'de>,
{
    fn deserialize<D: serde::Deserializer<'de>>(de: D) -> std::result::Result<Self, D::Error> {
        // Audit-log replay paths (re-load `AgentEvent::ToolError`
        // events from a `SessionLog`) must reconstruct the carrier
        // around its persisted inner value. The persisted value
        // already passed `for_llm` on first emit (invariant 18 —
        // events are the SSoT), so deserialising into the carrier
        // is the inverse, not a fresh fabrication.
        T::deserialize(de).map(Self::new)
    }
}

/// Render a value (typically an error, sub-agent result, or
/// memory-recall summary) into the short, actionable form the
/// model is allowed to see. Implementors define
/// [`Self::render_for_llm`] (the raw producer); the default
/// [`Self::for_llm`] wraps the result in a sealed
/// [`RenderedForLlm`] carrier whose constructor is private to this
/// crate, so emit sites that accept the carrier receive a value
/// that structurally went through the trait.
///
/// Implementations keep prose brief, omit operator-only context
/// (status codes, type-system identifiers, source chains), and
/// never echo input payloads — those are prompt-injection vectors.
/// The full operator-facing form continues to flow through
/// `Display` / `Error::source` / event sinks / OTel.
pub trait LlmRenderable<T> {
    /// The raw model-facing rendering. Must not include vendor
    /// status codes, `provider returned …` framing, source chains,
    /// RFC3339 timestamps, or internal type names — operator
    /// channels carry those.
    fn render_for_llm(&self) -> T;

    /// Sealed carrier wrapping [`Self::render_for_llm`]'s output.
    /// External crates that implement this trait cannot override
    /// this method without access to `RenderedForLlm::new`, which
    /// is `pub(crate)` to `entelix-core`. The boundary therefore
    /// holds across crate boundaries: only `entelix-core`'s default
    /// impl can produce a `RenderedForLlm<T>`.
    fn for_llm(&self) -> RenderedForLlm<T> {
        RenderedForLlm::new(self.render_for_llm())
    }
}

// `use_self` would prefer `Self` in place of `String` here, but the
// trait param `String` and the receiver type `String` are
// fundamentally the same in this two-parameter `LlmRenderable<T>`
// shape — substituting `Self` reads worse than the explicit form.
#[allow(clippy::use_self)]
impl LlmRenderable<String> for String {
    /// Identity rendering. The seal still holds — `for_llm()`'s
    /// default impl (the only path to `RenderedForLlm::new`) routes
    /// every emit through this trait, even when the operator's hint
    /// is already a plain string. Validators raising
    /// `Error::ModelRetry` thus write
    /// `"corrective text".to_owned().for_llm()` and the type system
    /// confirms the rendering boundary was crossed.
    fn render_for_llm(&self) -> String {
        self.clone()
    }
}

impl LlmRenderable<String> for &str {
    fn render_for_llm(&self) -> String {
        (*self).to_owned()
    }
}

impl LlmRenderable<String> for Error {
    /// Short, model-actionable rendering. Mapping:
    ///
    /// - `InvalidRequest(msg)` → `"invalid input: {msg}"` — the
    ///   message is already caller-supplied and free of vendor
    ///   identifiers.
    /// - `Provider { .. }` → `"upstream model error"` — vendor
    ///   status is operator-only.
    /// - `Auth(_)` → `"authentication failed"` — never echo the
    ///   underlying provider's auth diagnostic.
    /// - `Config(_)` → `"tool misconfigured"` — operator must fix.
    /// - `Cancelled` → `"cancelled"`.
    /// - `DeadlineExceeded` → `"timed out"`.
    /// - `Interrupted { .. }` → `"awaiting human review"`.
    /// - `Serde(_)` → `"output could not be serialised"` — the
    ///   inner serde error names internal types.
    fn render_for_llm(&self) -> String {
        match self {
            Self::InvalidRequest(msg) => format!("invalid input: {msg}"),
            Self::Provider { .. } => "upstream model error".to_owned(),
            Self::Auth(_) => "authentication failed".to_owned(),
            Self::Config(_) => "tool misconfigured".to_owned(),
            Self::Cancelled => "cancelled".to_owned(),
            Self::DeadlineExceeded => "timed out".to_owned(),
            Self::Interrupted { .. } => "awaiting human review".to_owned(),
            Self::Serde(_) => "output could not be serialised".to_owned(),
            // Usage-limit breaches are operational signals — the
            // model does not need budget visibility (and exposing
            // it would invite the model to plan around limits).
            Self::UsageLimitExceeded(_) => "request quota reached".to_owned(),
            // `ModelRetry` carries an already-rendered hint by
            // construction — surface that text verbatim. The retry
            // loop catches the variant before LLM emission in normal
            // flow; this branch covers leaks past the loop boundary.
            Self::ModelRetry { hint, .. } => hint.as_inner().clone(),
        }
    }
}

/// JSON-Schema sanitiser — strips schemars / draft-meta keys that
/// vendor APIs ignore but that still cost tokens to ship.
pub struct LlmFacingSchema;

/// JSON-Schema key classification — drives the schema-aware walk.
///
/// Different keys hold different *kinds* of value: some carry literal
/// data (`type: "string"`, `description: "..."`), some carry a single
/// nested schema (`items`, `additionalProperties` when an object),
/// some carry an array of schemas (`anyOf`, `oneOf`, `allOf`), some
/// carry a `map<user-name, schema>` (`properties`), and some carry
/// user data that must not be schema-walked (`enum`, `default`,
/// `const`, `required`). The classifier picks the right walk for
/// each key so user-named properties survive the strip and user
/// values are not accidentally pruned to empty objects.
enum AllowedKey {
    /// Literal value — `type`, `description`, bounds, `format`, …
    /// Cloned through (with the `format` noise filter applied).
    Literal,
    /// Single nested schema — `items` (single-schema form),
    /// `additionalProperties` (when an object), `not`.
    Schema,
    /// Array of nested schemas — `anyOf`, `oneOf`, `allOf`.
    /// `items` (array form) also flows through here at runtime.
    SchemaArray,
    /// Map of user-named entries to schemas — `properties`. Keys
    /// are preserved verbatim; values are schema-walked.
    SchemaMap,
    /// User data — `enum`, `default`, `const`, `required`. Cloned
    /// verbatim; never schema-walked.
    UserData,
}

fn classify(key: &str) -> Option<AllowedKey> {
    Some(match key {
        "type" | "description" | "minimum" | "maximum" | "exclusiveMinimum"
        | "exclusiveMaximum" | "minLength" | "maxLength" | "minItems" | "maxItems"
        | "uniqueItems" | "minProperties" | "maxProperties" | "pattern" | "format" => {
            AllowedKey::Literal
        }
        "items" | "additionalProperties" | "not" => AllowedKey::Schema,
        "anyOf" | "oneOf" | "allOf" => AllowedKey::SchemaArray,
        "properties" => AllowedKey::SchemaMap,
        "enum" | "default" | "const" | "required" => AllowedKey::UserData,
        _ => return None,
    })
}

/// `format` values that read as noise to the vendor — the
/// JSON-Schema-encoded width hint is already implied by
/// `type: "integer"`/`"number"` and the model gains nothing from
/// seeing it. Removing them shrinks the wire without losing meaning.
const NOISY_FORMATS: &[&str] = &[
    "int8", "int16", "int32", "int64", "uint8", "uint16", "uint32", "uint64", "float", "double",
];

impl LlmFacingSchema {
    /// Walk `schema` and return a copy containing only
    /// vendor-relevant keys. The walk inlines `$ref`/`$defs`
    /// indirection so the resulting schema is self-contained — no
    /// dangling references, no draft-meta envelope.
    ///
    /// Self-referential `$ref` chains (`Inner` → `Inner`, or
    /// `A` → `B` → `A`) cannot be expanded into a finite tree.
    /// On cycle the recursion breaks at the offending node by
    /// substituting an empty `{}` (accept-any) schema and
    /// `tracing::warn!`s the cycle's def-name chain so operators
    /// see the truncation. The accept-any substitute keeps the
    /// surrounding shape valid for vendor consumption — the model
    /// loses the inner recursion's structural detail (necessarily,
    /// since cyclic types have no finite JSON Schema form), but
    /// the schema as a whole stays well-formed.
    #[must_use]
    pub fn strip(schema: &Value) -> Value {
        let defs = collect_defs(schema);
        let mut visited: Vec<String> = Vec::new();
        strip_schema(schema, &defs, &mut visited)
    }
}

fn collect_defs(schema: &Value) -> BTreeMap<String, Value> {
    let mut out = BTreeMap::new();
    if let Some(obj) = schema.as_object() {
        // Merge `$defs` (2020-12) and the legacy `definitions` key.
        for key in ["$defs", "definitions"] {
            if let Some(Value::Object(defs)) = obj.get(key) {
                for (name, body) in defs {
                    out.insert(name.clone(), body.clone());
                }
            }
        }
    }
    out
}

/// Strip one schema node. Resolves `$ref` indirection up front, then
/// dispatches each surviving key according to its [`AllowedKey`]
/// classification.
///
/// `visited` is the stack of `$defs` / `definitions` names currently
/// being expanded along this branch of the recursion. A `$ref` whose
/// target name already sits on the stack is a cycle — without
/// breaking the recursion the call stack-overflows on any
/// self-referential type (`Box<Self>` in a Rust struct → schemars
/// emits a `$ref` back into its own `$defs` body).
fn strip_schema(node: &Value, defs: &BTreeMap<String, Value>, visited: &mut Vec<String>) -> Value {
    let Some(obj) = node.as_object() else {
        // Not an object (likely a boolean schema like
        // `additionalProperties: false` or an `items: true` shorthand)
        // — clone through unchanged.
        return node.clone();
    };

    // `$ref` short-circuits — replace the whole node with the
    // stripped definition body. Eliminates `$defs` indirection.
    // Cyclic chains break to an accept-any `{}` substitute so
    // self-referential types do not stack-overflow the encoder.
    if let Some(Value::String(reference)) = obj.get("$ref")
        && let Some(name) = reference
            .strip_prefix("#/$defs/")
            .or_else(|| reference.strip_prefix("#/definitions/"))
        && let Some(target) = defs.get(name)
    {
        if visited.iter().any(|seen| seen == name) {
            let cycle_chain: Vec<&str> = visited
                .iter()
                .map(String::as_str)
                .chain(std::iter::once(name))
                .collect();
            tracing::warn!(
                cycle = ?cycle_chain,
                "LlmFacingSchema::strip broke a $ref cycle — emitting accept-any substitute"
            );
            return Value::Object(Map::new());
        }
        visited.push(name.to_owned());
        let stripped = strip_schema(target, defs, visited);
        visited.pop();
        return stripped;
    }

    let mut out = Map::new();
    for (key, value) in obj {
        let Some(kind) = classify(key) else {
            continue;
        };
        match kind {
            AllowedKey::Literal => {
                if key == "format"
                    && let Some(format) = value.as_str()
                    && NOISY_FORMATS.contains(&format)
                {
                    continue;
                }
                out.insert(key.clone(), value.clone());
            }
            AllowedKey::Schema => {
                // `items` may be a single schema or an array of
                // schemas (tuple-style validation); `additionalProperties`
                // may be a boolean. Dispatch per shape.
                let stripped = match value {
                    Value::Array(arr) => {
                        Value::Array(arr.iter().map(|v| strip_schema(v, defs, visited)).collect())
                    }
                    other => strip_schema(other, defs, visited),
                };
                out.insert(key.clone(), stripped);
            }
            AllowedKey::SchemaArray => {
                if let Value::Array(arr) = value {
                    let stripped: Vec<Value> =
                        arr.iter().map(|v| strip_schema(v, defs, visited)).collect();
                    out.insert(key.clone(), Value::Array(stripped));
                } else {
                    // Malformed — keep the original; the vendor will
                    // reject it with a clearer error than we can
                    // synthesize here.
                    out.insert(key.clone(), value.clone());
                }
            }
            AllowedKey::SchemaMap => {
                // User-named keys → preserve verbatim, values → walk.
                if let Value::Object(map) = value {
                    let stripped: Map<String, Value> = map
                        .iter()
                        .map(|(k, v)| (k.clone(), strip_schema(v, defs, visited)))
                        .collect();
                    out.insert(key.clone(), Value::Object(stripped));
                } else {
                    out.insert(key.clone(), value.clone());
                }
            }
            AllowedKey::UserData => {
                out.insert(key.clone(), value.clone());
            }
        }
    }
    Value::Object(out)
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::indexing_slicing)]
mod tests {
    use super::*;
    use serde_json::json;

    #[test]
    fn render_for_llm_omits_provider_status() {
        let err = Error::provider_http(503, "vendor down".to_owned());
        let rendered = err.render_for_llm();
        assert!(!rendered.contains("503"), "{rendered}");
        assert!(!rendered.contains("vendor down"), "{rendered}");
        assert!(!rendered.contains("provider returned"), "{rendered}");
    }

    #[test]
    fn render_for_llm_invalid_request_carries_caller_message() {
        let err = Error::invalid_request("missing 'task' field");
        assert_eq!(err.render_for_llm(), "invalid input: missing 'task' field");
    }

    #[test]
    fn strip_removes_schema_envelope() {
        let raw = json!({
            "$schema": "https://json-schema.org/draft/2020-12/schema",
            "title": "DoubleInput",
            "type": "object",
            "properties": {"n": {"type": "integer", "format": "int64"}},
            "required": ["n"]
        });
        let stripped = LlmFacingSchema::strip(&raw);
        assert!(stripped.get("$schema").is_none());
        assert!(stripped.get("title").is_none());
        assert_eq!(stripped["type"], "object");
        assert_eq!(stripped["properties"]["n"]["type"], "integer");
        // int64 is the noisy width hint — dropped.
        assert!(stripped["properties"]["n"].get("format").is_none());
        assert_eq!(stripped["required"], json!(["n"]));
    }

    #[test]
    fn strip_inlines_refs_and_drops_defs_envelope() {
        let raw = json!({
            "$schema": "https://json-schema.org/draft/2020-12/schema",
            "title": "Outer",
            "type": "object",
            "properties": {"inner": {"$ref": "#/$defs/Inner"}},
            "$defs": {
                "Inner": {
                    "title": "Inner",
                    "type": "object",
                    "properties": {"x": {"type": "string"}},
                    "required": ["x"]
                }
            }
        });
        let stripped = LlmFacingSchema::strip(&raw);
        assert!(stripped.get("$defs").is_none());
        let inner = &stripped["properties"]["inner"];
        // $ref resolved → inlined object, title gone.
        assert_eq!(inner["type"], "object");
        assert_eq!(inner["properties"]["x"]["type"], "string");
        assert!(inner.get("title").is_none());
    }

    #[test]
    fn strip_keeps_meaningful_format_specifiers() {
        // `date-time`, `email`, `uri` are real vendor-honored
        // formats — the noise list only targets width hints.
        let raw = json!({
            "type": "string",
            "format": "date-time"
        });
        let stripped = LlmFacingSchema::strip(&raw);
        assert_eq!(stripped["format"], "date-time");
    }

    #[test]
    fn strip_breaks_self_referential_ref_cycle() {
        // `Tree { children: Vec<Tree> }` — schemars emits a `$ref`
        // pointing back into `Tree`'s own `$defs` body. Without
        // cycle detection the inliner stack-overflows on this
        // shape, which would be a DoS surface for operator-supplied
        // schemas.
        let raw = json!({
            "$schema": "https://json-schema.org/draft/2020-12/schema",
            "title": "Tree",
            "type": "object",
            "properties": {
                "value": {"type": "string"},
                "children": {
                    "type": "array",
                    "items": {"$ref": "#/$defs/Tree"}
                }
            },
            "$defs": {
                "Tree": {
                    "type": "object",
                    "properties": {
                        "value": {"type": "string"},
                        "children": {
                            "type": "array",
                            "items": {"$ref": "#/$defs/Tree"}
                        }
                    }
                }
            }
        });
        let stripped = LlmFacingSchema::strip(&raw);
        // Convention (matches ajv, json-ref-resolver, etc.): the
        // first expansion of a `$ref` along a recursion branch is
        // performed; the *second* hit on the same name breaks the
        // cycle. So `Tree.children.items` expands once into the
        // Tree body, and the next `Tree.children.items` inside
        // that expansion is the accept-any substitute.
        assert_eq!(stripped["type"], "object");
        assert_eq!(stripped["properties"]["value"]["type"], "string");
        let one_level_deep = &stripped["properties"]["children"]["items"];
        assert_eq!(one_level_deep["type"], "object");
        assert_eq!(one_level_deep["properties"]["value"]["type"], "string");
        let cycle_break = &one_level_deep["properties"]["children"]["items"];
        assert_eq!(cycle_break, &json!({}));
    }

    #[test]
    fn strip_breaks_mutually_recursive_ref_cycle() {
        // `A { b: B }` and `B { a: A }` — alternating `$ref`s. The
        // visited stack must catch the cycle at the second hop back
        // to A, not just direct self-references.
        let raw = json!({
            "type": "object",
            "properties": {"root": {"$ref": "#/$defs/A"}},
            "$defs": {
                "A": {
                    "type": "object",
                    "properties": {"b": {"$ref": "#/$defs/B"}}
                },
                "B": {
                    "type": "object",
                    "properties": {"a": {"$ref": "#/$defs/A"}}
                }
            }
        });
        let stripped = LlmFacingSchema::strip(&raw);
        let root = &stripped["properties"]["root"];
        assert_eq!(root["type"], "object");
        // root.b expanded to B; B.a hits the cycle → accept-any.
        let cycle_break = &root["properties"]["b"]["properties"]["a"];
        assert_eq!(cycle_break, &json!({}));
    }

    #[test]
    fn strip_inlines_shared_non_cyclic_ref_at_every_usage() {
        // `Outer { x: Shared, y: Shared }` — `Shared` referenced
        // twice but never recursively. Both usages must inline
        // independently; the visited stack must `pop` after `x` so
        // `y` can re-enter `Shared`.
        let raw = json!({
            "type": "object",
            "properties": {
                "x": {"$ref": "#/$defs/Shared"},
                "y": {"$ref": "#/$defs/Shared"}
            },
            "$defs": {
                "Shared": {"type": "string", "description": "shared scalar"}
            }
        });
        let stripped = LlmFacingSchema::strip(&raw);
        assert_eq!(stripped["properties"]["x"]["type"], "string");
        assert_eq!(stripped["properties"]["x"]["description"], "shared scalar");
        assert_eq!(stripped["properties"]["y"]["type"], "string");
        assert_eq!(stripped["properties"]["y"]["description"], "shared scalar");
    }
}