embed_seglist/

seglist.rs

//! SegList : A segmented list with cache-friendly node sizes.
//!
//! Support push() / pop() from the tail, and one-time consume all elements.
//! It does not support random access.
//!
//! Each segment's capacity is calculated at runtime based on T's size
//! to fit within a cache line. (The first segment is 2* CACHE_LINE_SIZE, the subsequent allocation
//! use CACHE_LINE_SIZE * 4)
//!
//! It's faster than Vec when the number of items is small (1~64), because it does not re-allocate
//! during `push()`. It's slower than Vec when the number is very large (due to pointer dereference cost).
//!
//! # NOTE
//!
//! T is allow to larger than `2 * CACHE_LINE_SIZE`, in this case `SegList` will ensure at least 2
//! items in one segment. But it's not efficient when T larger than 64B, you should consider put T into Box.
//!
//! # Example
//!
//! ```rust
//! use embed_seglist::SegList;
//!
//! // Create a new SegList
//! let mut list: SegList<i32> = SegList::new();
//!
//! // Push elements to the back
//! list.push(10);
//! list.push(20);
//! list.push(30);
//!
//! assert_eq!(list.len(), 3);
//! assert_eq!(list.first(), Some(&10));
//! assert_eq!(list.last(), Some(&30));
//!
//! // Pop elements from the back (LIFO order)
//! assert_eq!(list.pop(), Some(30));
//! assert_eq!(list.pop(), Some(20));
//! assert_eq!(list.pop(), Some(10));
//! assert_eq!(list.pop(), None);
//! assert!(list.is_empty());
//!
//! // Iterate over elements
//! list.push(1);
//! list.push(2);
//! list.push(3);
//! let sum: i32 = list.iter().sum();
//! assert_eq!(sum, 6);
//!
//! // Mutable iteration
//! for item in list.iter_mut() {
//!     *item *= 10;
//! }
//! assert_eq!(list.last(), Some(&30));
//!
//! // Drain all elements (consumes the list)
//! let drained: Vec<i32> = list.into_iter().collect();
//! assert_eq!(drained, vec![10, 20, 30]);
//! ```

use alloc::alloc::{alloc, dealloc, handle_alloc_error};
use core::alloc::Layout;
use core::fmt;
use core::mem::{MaybeUninit, align_of, needs_drop, size_of};
use core::ptr::{NonNull, null_mut};
use embed_collections::CACHE_LINE_SIZE;

/// Segmented list with cache-friendly segment sizes.
///
/// Support push() / pop() from the tail, and one-time consume all elements.
/// It does not support random access.
///
/// Each segment's capacity is calculated at runtime based on T's size
/// to fit within a cache line. (The first segment is 2 * CACHE_LINE_SIZE, the subsequent allocation
/// use CACHE_LINE_SIZE * 4)
///
/// It's faster than Vec when the number of items is small (1~64), because it does not re-allocate
/// during `push()`. It's slower than Vec when the number is very large (due to pointer dereference cost).
///
/// # NOTE
///
/// T is allow to larger than `2 * CACHE_LINE_SIZE`, in this case SegList will ensure at least 2
/// items in one segment. But it's not efficient when T larger than 128B, you should consider put T into Box.
///
/// Refer to [module level](crate) doc for examples.
pub struct SegList<T> {
    /// Pointer to the last segment (tail.get_header().next points to first element), to reduce the main struct size
    tail: NonNull<SegHeader<T>>,
    /// Total number of elements in the list
    count: usize,
}

unsafe impl<T: Send> Send for SegList<T> {}
unsafe impl<T: Send> Sync for SegList<T> {}

impl<T> SegList<T> {
    /// Create a new empty SegList with one allocated segment
    pub fn new() -> Self {
        let mut seg = unsafe { Segment::<T>::alloc(null_mut(), null_mut(), true) };
        let header_ptr = seg.header.as_ptr();
        let header = seg.get_header_mut();
        // Make it circular: tail.next points to head (itself for now)
        header.next = header_ptr;
        Self { tail: seg.header, count: 0 }
    }

    /// Returns true if the list is empty
    #[inline(always)]
    pub fn is_empty(&self) -> bool {
        self.count == 0
    }

    /// Get the base capacity of the first segment
    #[inline(always)]
    pub const fn segment_cap() -> usize {
        Segment::<T>::base_cap()
    }

    /// Returns the total number of elements in the list
    #[inline(always)]
    pub fn len(&self) -> usize {
        self.count
    }

    /// Push an element to the back of the list
    #[inline]
    pub fn push(&mut self, item: T) {
        unsafe {
            let mut tail_seg = Segment::from_raw(self.tail);
            if tail_seg.is_full() {
                let tail_ptr = tail_seg.header.as_ptr();
                let cur = tail_seg.get_header_mut();
                // Subsequent segments use LARGE_LAYOUT (cacheline * 2)
                let new_seg = Segment::alloc(tail_ptr, cur.next, false);
                cur.next = new_seg.header.as_ptr();
                self.tail = new_seg.header;
                tail_seg = new_seg;
            }
            tail_seg.push(item);
        }
        self.count += 1;
    }

    /// Pop an element from the back of the list
    #[inline]
    pub fn pop(&mut self) -> Option<T> {
        if self.count == 0 {
            return None;
        }
        unsafe {
            let mut tail_seg = Segment::from_raw(self.tail);
            let (item, is_empty) = tail_seg.pop();
            if is_empty {
                let cur = tail_seg.get_header_mut();
                let first_ptr = cur.next;
                let cur_prev = cur.prev;
                if self.tail.as_ptr() != first_ptr && !cur_prev.is_null() {
                    // More than one segment: remove tail segment
                    self.tail = NonNull::new_unchecked(cur_prev);
                    (*self.tail.as_ptr()).next = first_ptr;
                    tail_seg.dealloc();
                }
                // If only one segment, keep it for future use
            }
            self.count -= 1;
            Some(item)
        }
    }

    // Break the cycle and free all segments
    #[inline(always)]
    fn break_first_node(&mut self) -> Segment<T> {
        let tail_header = unsafe { self.tail.as_mut() };
        let first = tail_header.next;
        tail_header.next = null_mut();
        unsafe { Segment::from_raw(NonNull::new_unchecked(first)) }
    }

    #[inline(always)]
    fn first_ptr(&self) -> NonNull<SegHeader<T>> {
        // SAFETY: tail always points to a valid segment with at least one element.
        // get first segment through next ptr from the tail
        unsafe {
            let tail_header = self.tail.as_ref();
            let first = tail_header.next;
            NonNull::new_unchecked(first)
        }
    }

    /// Returns an iterator over the list
    #[inline]
    pub fn iter(&self) -> SegListIter<'_, T> {
        let first_seg = unsafe { Segment::from_raw(self.first_ptr()) };
        SegListIter {
            base: IterBase { cur: first_seg, cur_idx: 0, remaining: self.count, forward: true },
            _marker: core::marker::PhantomData,
        }
    }

    /// Returns a reverse iterator over the list
    #[inline]
    pub fn iter_rev(&self) -> SegListIter<'_, T> {
        let tail_seg = unsafe { Segment::from_raw(self.tail) };
        let tail_header = tail_seg.get_header();
        let start_idx = if tail_header.count > 0 { tail_header.count as usize - 1 } else { 0 };
        SegListIter {
            base: IterBase {
                cur: tail_seg,
                cur_idx: start_idx,
                remaining: self.count,
                forward: false,
            },
            _marker: core::marker::PhantomData,
        }
    }

    /// Returns a mutable iterator over the list
    #[inline]
    pub fn iter_mut(&mut self) -> SegListIterMut<'_, T> {
        let first_seg = unsafe { Segment::from_raw(self.first_ptr()) };
        SegListIterMut {
            base: IterBase { cur: first_seg, cur_idx: 0, remaining: self.count, forward: true },
            _marker: core::marker::PhantomData,
        }
    }

    /// Returns a mutable reverse iterator over the list
    #[inline]
    pub fn iter_mut_rev(&mut self) -> SegListIterMut<'_, T> {
        let tail_seg = unsafe { Segment::from_raw(self.tail) };
        let tail_header = tail_seg.get_header();
        let start_idx = if tail_header.count > 0 { tail_header.count as usize - 1 } else { 0 };
        SegListIterMut {
            base: IterBase {
                cur: tail_seg,
                cur_idx: start_idx,
                remaining: self.count,
                forward: false,
            },
            _marker: core::marker::PhantomData,
        }
    }

    /// Returns a draining iterator that consumes the list and yields elements from tail to head
    pub fn into_iter_rev(mut self) -> SegListIntoIter<T> {
        // break the cycle
        let mut first = self.break_first_node();
        let remaining = self.count;
        let (cur, start_idx) = if self.count == 0 {
            unsafe {
                first.dealloc();
            }
            (None, 0)
        } else {
            let tail_seg = unsafe { Segment::from_raw(self.tail) };
            let tail_header = tail_seg.get_header();
            let start_idx = if tail_header.count > 0 { tail_header.count as usize - 1 } else { 0 };
            (Some(tail_seg), start_idx)
        };
        core::mem::forget(self);
        SegListIntoIter { cur, cur_idx: start_idx, forward: false, remaining }
    }

    /// Returns a reference to the first element in the list
    #[inline]
    pub fn first(&self) -> Option<&T> {
        if self.count == 0 {
            return None;
        }
        // SAFETY: tail always points to a valid segment with at least one element.
        // get first segment through next ptr from the tail
        unsafe {
            let first_seg = Segment::from_raw(self.first_ptr());
            Some((*first_seg.item_ptr(0)).assume_init_ref())
        }
    }

    /// Returns a mut reference to the first element in the list
    #[inline]
    pub fn first_mut(&self) -> Option<&T> {
        if self.count == 0 {
            return None;
        }
        // SAFETY: tail always points to a valid segment with at least one element.
        // get first segment through next ptr from the tail
        unsafe {
            let first_seg = Segment::from_raw(self.first_ptr());
            Some((*first_seg.item_ptr(0)).assume_init_mut())
        }
    }

    /// Returns a reference to the last element in the list
    #[inline]
    pub fn last(&self) -> Option<&T> {
        // SAFETY: tail always points to a valid segment with at least one element
        unsafe {
            let tail_seg = Segment::from_raw(self.tail);
            let header = tail_seg.get_header();
            if header.count == 0 {
                return None;
            }
            let idx = (header.count - 1) as usize;
            Some((*tail_seg.item_ptr(idx)).assume_init_ref())
        }
    }

    /// Returns a mutable reference to the last element in the list
    #[inline]
    pub fn last_mut(&mut self) -> Option<&mut T> {
        // SAFETY: tail always points to a valid segment with at least one element
        unsafe {
            let tail_seg = Segment::from_raw(self.tail);
            let header = tail_seg.get_header();
            if header.count == 0 {
                return None;
            }
            let idx = (header.count - 1) as usize;
            Some((*tail_seg.item_ptr(idx)).assume_init_mut())
        }
    }

    /// Clear all elements from the list
    #[inline(always)]
    pub fn clear(&mut self) {
        if self.count == 0 {
            return;
        }
        unsafe {
            let tail_header = self.tail.as_mut();
            let first = tail_header.next;
            let mut cur = Segment::from_raw(self.tail);
            loop {
                let next = cur.get_header().prev;
                if next.is_null() {
                    if needs_drop::<T>() {
                        cur.drop_items();
                    }
                    self.count = 0;
                    let header = cur.get_header_mut();
                    header.count = 0;
                    header.next = first;
                    self.tail = NonNull::new_unchecked(first);
                    return;
                } else {
                    cur.dealloc_with_items();
                    cur = Segment::from_raw(NonNull::new_unchecked(next));
                }
            }
        }
    }
}

impl<T> Default for SegList<T> {
    fn default() -> Self {
        Self::new()
    }
}

impl<T> Drop for SegList<T> {
    fn drop(&mut self) {
        // Break the cycle and get the first segment
        let mut cur = self.break_first_node();
        loop {
            // Save next pointer before dealloc
            let next = cur.get_header().next;
            unsafe { cur.dealloc_with_items() };
            if next.is_null() {
                break;
            }
            cur = unsafe { Segment::from_raw(NonNull::new_unchecked(next)) };
        }
    }
}

impl<T> IntoIterator for SegList<T> {
    type Item = T;
    type IntoIter = SegListIntoIter<T>;

    #[inline(always)]
    fn into_iter(mut self) -> Self::IntoIter {
        // Break the cycle and get the first segment
        let mut first = self.break_first_node();
        let remaining = self.count;
        let cur = if self.count == 0 {
            unsafe {
                first.dealloc();
            }
            None
        } else {
            Some(first)
        };
        // To prevent drop from being called
        core::mem::forget(self);
        SegListIntoIter { cur, cur_idx: 0, forward: true, remaining }
    }
}

impl<'a, T> IntoIterator for &'a SegList<T> {
    type Item = &'a T;
    type IntoIter = SegListIter<'a, T>;

    #[inline(always)]
    fn into_iter(self) -> Self::IntoIter {
        self.iter()
    }
}

impl<'a, T> IntoIterator for &'a mut SegList<T> {
    type Item = &'a mut T;
    type IntoIter = SegListIterMut<'a, T>;

    #[inline(always)]
    fn into_iter(self) -> Self::IntoIter {
        self.iter_mut()
    }
}

impl<T: fmt::Debug> fmt::Debug for SegList<T> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("SegList").field("len", &self.len()).finish()
    }
}

/// Segment header containing metadata
#[repr(C)]
struct SegHeader<T> {
    /// Count of valid elements in this segment
    count: u32,
    /// Capacity of this segment (may vary for different segments)
    cap: u32,
    prev: *mut SegHeader<T>,
    /// Next segment in the list
    next: *mut SegHeader<T>,
    _marker: core::marker::PhantomData<T>,
}

/// A segment containing header and element storage
struct Segment<T> {
    /// Pointer to the header
    header: NonNull<SegHeader<T>>,
}

unsafe impl<T: Send> Send for Segment<T> {}

impl<T> Segment<T> {
    // data_offset is the same for both base and large layouts
    const DATA_OFFSET: usize = Self::calc_data_offset();

    // Pre-calculate layout for cacheline-sized segment (first segment)
    // (cap, layout)
    const BASE_LAYOUT: (usize, Layout) = Self::calc_layout_const(CACHE_LINE_SIZE * 2);

    // Pre-calculate layout for cacheline*2-sized segment (subsequent segments)
    // (cap, layout)
    const LARGE_LAYOUT: (usize, Layout) = Self::calc_layout_const(CACHE_LINE_SIZE * 4);

    /// Const fn to calculate data offset (same for all segments)
    const fn calc_data_offset() -> usize {
        let mut data_offset = size_of::<SegHeader<T>>();
        let t_size = size_of::<T>();
        let t_align = align_of::<MaybeUninit<T>>();

        if t_size != 0 {
            data_offset = (data_offset + t_align - 1) & !(t_align - 1);
        }
        data_offset
    }

    /// Const fn to calculate layout for a given cache line size
    const fn calc_layout_const(cache_line: usize) -> (usize, Layout) {
        let t_size = size_of::<T>();
        let data_offset = Self::DATA_OFFSET;
        let capacity;
        let final_alloc_size;
        let final_align;

        if t_size == 0 {
            // 0-size does not actually take place
            capacity = 1024;
            final_alloc_size = cache_line;
            final_align = cache_line;
        } else {
            let min_elements = 2;
            let min_required_size = data_offset + (t_size * min_elements);
            let alloc_size = (min_required_size + cache_line - 1) & !(cache_line - 1);
            final_align = if cache_line > align_of::<MaybeUninit<T>>() {
                cache_line
            } else {
                align_of::<MaybeUninit<T>>()
            };
            final_alloc_size = (alloc_size + final_align - 1) & !(final_align - 1);
            capacity = (final_alloc_size - data_offset) / t_size;
            // rust 1.57 support assert in const fn
            assert!(capacity >= min_elements);
        }

        match Layout::from_size_align(final_alloc_size, final_align) {
            Ok(l) => (capacity, l),
            Err(_) => panic!("Invalid layout"),
        }
    }

    /// Get the base capacity (first segment's capacity)
    #[inline(always)]
    const fn base_cap() -> usize {
        Self::BASE_LAYOUT.0
    }

    /// Get the large capacity (subsequent segments' capacity)
    #[inline(always)]
    const fn large_cap() -> usize {
        Self::LARGE_LAYOUT.0
    }

    /// Get the data offset (offset of first element from header start)
    #[inline(always)]
    const fn data_offset() -> usize {
        Self::DATA_OFFSET
    }

    /// Create a new empty segment
    /// is_first: true for first segment (uses BASE_LAYOUT), false for subsequent (uses LARGE_LAYOUT)
    #[inline]
    unsafe fn alloc(prev: *mut SegHeader<T>, next: *mut SegHeader<T>, is_first: bool) -> Self {
        let (cap, layout) = if is_first {
            (Self::base_cap() as u32, Self::BASE_LAYOUT.1)
        } else {
            (Self::large_cap() as u32, Self::LARGE_LAYOUT.1)
        };
        let ptr: *mut u8 = unsafe { alloc(layout) };
        if ptr.is_null() {
            handle_alloc_error(layout);
        }
        unsafe {
            let p = NonNull::new_unchecked(ptr as *mut SegHeader<T>);
            let header = p.as_ptr();
            // Initialize header
            (*header).count = 0;
            (*header).cap = cap;
            (*header).prev = prev;
            (*header).next = next;
            Self::from_raw(p)
        }
    }

    #[inline(always)]
    unsafe fn drop_items(&self) {
        unsafe {
            for i in 0..self.len() {
                (*self.item_ptr(i)).assume_init_drop();
            }
        }
    }

    #[inline(always)]
    unsafe fn dealloc_with_items(&mut self) {
        unsafe {
            if needs_drop::<T>() {
                self.drop_items();
            }
            self.dealloc();
        }
    }

    #[inline(always)]
    unsafe fn dealloc(&mut self) {
        // Deallocate the entire segment (header + items)
        unsafe {
            let cap = (*self.header.as_ptr()).cap as usize;
            let layout =
                if cap == Self::base_cap() { Self::BASE_LAYOUT.1 } else { Self::LARGE_LAYOUT.1 };
            dealloc(self.header.as_ptr() as *mut u8, layout);
        }
    }

    #[inline(always)]
    unsafe fn from_raw(header: NonNull<SegHeader<T>>) -> Self {
        Self { header }
    }

    /// Get the count of valid elements in this segment
    #[inline(always)]
    fn len(&self) -> usize {
        unsafe { (*self.header.as_ptr()).count as usize }
    }

    #[inline(always)]
    fn get_header(&self) -> &SegHeader<T> {
        unsafe { self.header.as_ref() }
    }

    #[inline(always)]
    fn get_header_mut(&mut self) -> &mut SegHeader<T> {
        unsafe { self.header.as_mut() }
    }

    /// Check if segment has no valid elements
    #[inline(always)]
    fn is_empty(&self) -> bool {
        self.len() == 0
    }

    /// Check if segment is full
    #[inline(always)]
    fn is_full(&self) -> bool {
        let header = self.get_header();
        header.count >= header.cap
    }

    /// Get pointer to item at index
    #[inline]
    fn item_ptr(&self, index: usize) -> *mut MaybeUninit<T> {
        unsafe {
            let items =
                (self.header.as_ptr() as *mut u8).add(Self::data_offset()) as *mut MaybeUninit<T>;
            items.add(index)
        }
    }

    /// Push an element to this segment (if not full)
    #[inline]
    fn push(&mut self, item: T) {
        debug_assert!(!self.is_full());
        let idx = self.get_header().count as usize;
        unsafe {
            (*self.item_ptr(idx)).write(item);
        }
        self.get_header_mut().count = (idx + 1) as u32;
    }

    /// return (item, is_empty_now)
    #[inline]
    fn pop(&mut self) -> (T, bool) {
        debug_assert!(!self.is_empty());
        let idx = self.get_header().count - 1;
        let item = unsafe { (*self.item_ptr(idx as usize)).assume_init_read() };
        self.get_header_mut().count = idx;
        (item, idx == 0)
    }
}

/// Base iterator implementation shared by immutable and mutable iterators.
/// Manages iteration state and returns raw pointers to elements.
/// `forward` is true for forward iteration, false for backward iteration.
struct IterBase<T> {
    cur: Segment<T>,
    cur_idx: usize,
    remaining: usize,
    forward: bool,
}

impl<T> IterBase<T> {
    /// Advances the iterator and returns a pointer to the next element's MaybeUninit.
    #[inline]
    fn next(&mut self) -> Option<*mut MaybeUninit<T>> {
        if self.remaining == 0 {
            return None;
        }
        self.remaining -= 1;

        if self.forward {
            let cur_header = self.cur.get_header();
            let idx = if self.cur_idx >= cur_header.count as usize {
                let next = cur_header.next;
                self.cur = unsafe { Segment::from_raw(NonNull::new_unchecked(next)) };
                self.cur_idx = 1;
                0
            } else {
                let _idx = self.cur_idx;
                self.cur_idx = _idx + 1;
                _idx
            };
            Some(self.cur.item_ptr(idx))
        } else {
            let idx = self.cur_idx;
            let item_ptr = self.cur.item_ptr(idx);
            if self.cur_idx == 0 {
                let cur_header = self.cur.get_header();
                if !cur_header.prev.is_null() {
                    self.cur =
                        unsafe { Segment::from_raw(NonNull::new_unchecked(cur_header.prev)) };
                    let prev_header = self.cur.get_header();
                    self.cur_idx = prev_header.count as usize - 1;
                }
            } else {
                self.cur_idx -= 1;
            }
            Some(item_ptr)
        }
    }

    #[inline]
    fn size_hint(&self) -> (usize, Option<usize>) {
        (self.remaining, Some(self.remaining))
    }
}

/// Immutable iterator over SegList
pub struct SegListIter<'a, T> {
    base: IterBase<T>,
    _marker: core::marker::PhantomData<&'a T>,
}

impl<'a, T> Iterator for SegListIter<'a, T> {
    type Item = &'a T;

    #[inline]
    fn next(&mut self) -> Option<Self::Item> {
        self.base.next().map(|ptr| unsafe { (*ptr).assume_init_ref() })
    }

    #[inline]
    fn size_hint(&self) -> (usize, Option<usize>) {
        self.base.size_hint()
    }
}

impl<'a, T> ExactSizeIterator for SegListIter<'a, T> {}

/// Mutable iterator over SegList
pub struct SegListIterMut<'a, T> {
    base: IterBase<T>,
    _marker: core::marker::PhantomData<&'a mut T>,
}

impl<'a, T> Iterator for SegListIterMut<'a, T> {
    type Item = &'a mut T;

    #[inline]
    fn next(&mut self) -> Option<Self::Item> {
        self.base.next().map(|ptr| unsafe { (*ptr).assume_init_mut() })
    }

    #[inline]
    fn size_hint(&self) -> (usize, Option<usize>) {
        self.base.size_hint()
    }
}

impl<'a, T> ExactSizeIterator for SegListIterMut<'a, T> {}

/// Draining iterator over SegList
/// Consumes elements from head to tail (FIFO order) or tail to head (LIFO order)
pub struct SegListIntoIter<T> {
    cur: Option<Segment<T>>,
    cur_idx: usize,
    forward: bool,
    remaining: usize,
}

impl<T> Iterator for SegListIntoIter<T> {
    type Item = T;

    #[inline]
    fn next(&mut self) -> Option<Self::Item> {
        let cur_seg = self.cur.as_mut()?;
        self.remaining -= 1;
        unsafe {
            let item = (*cur_seg.item_ptr(self.cur_idx)).assume_init_read();
            let header = cur_seg.get_header();
            if self.forward {
                let next_idx = self.cur_idx + 1;
                if next_idx >= header.count as usize {
                    let next = header.next;
                    cur_seg.dealloc();
                    if next.is_null() {
                        self.cur = None;
                    } else {
                        self.cur = Some(Segment::from_raw(NonNull::new_unchecked(next)));
                        self.cur_idx = 0;
                    }
                } else {
                    self.cur_idx = next_idx;
                }
            } else if self.cur_idx == 0 {
                let prev = header.prev;
                cur_seg.dealloc();
                if prev.is_null() {
                    self.cur = None;
                } else {
                    let _cur = Segment::from_raw(NonNull::new_unchecked(prev));
                    self.cur_idx = _cur.get_header().count as usize - 1;
                    self.cur = Some(_cur);
                }
            } else {
                self.cur_idx -= 1;
            }
            Some(item)
        }
    }

    #[inline]
    fn size_hint(&self) -> (usize, Option<usize>) {
        (self.remaining, Some(self.remaining))
    }
}

impl<T> ExactSizeIterator for SegListIntoIter<T> {}

impl<T> Drop for SegListIntoIter<T> {
    fn drop(&mut self) {
        if let Some(mut cur) = self.cur.take() {
            unsafe {
                if self.forward {
                    // Save next pointer before dealloc
                    let header = cur.get_header();
                    let mut next = header.next;
                    // Drop remaining elements in this segment (from current index to end)
                    if needs_drop::<T>() {
                        for i in self.cur_idx..header.count as usize {
                            (*cur.item_ptr(i)).assume_init_drop();
                        }
                    }
                    cur.dealloc();
                    while !next.is_null() {
                        cur = Segment::from_raw(NonNull::new_unchecked(next));
                        next = cur.get_header().next;
                        cur.dealloc_with_items();
                    }
                } else {
                    // Save prev pointer before dealloc
                    let mut prev = cur.get_header().prev;
                    // Drop remaining elements in this segment (from start to current index)
                    if needs_drop::<T>() {
                        for i in 0..=self.cur_idx {
                            (*cur.item_ptr(i)).assume_init_drop();
                        }
                    }
                    cur.dealloc();
                    while !prev.is_null() {
                        cur = Segment::from_raw(NonNull::new_unchecked(prev));
                        prev = cur.get_header().prev;
                        cur.dealloc_with_items();
                    }
                }
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use embed_collections_test::{CounterI32, alive_count, reset_alive_count};

    #[test]
    fn test_multiple_segments() {
        let mut list: SegList<i32> = SegList::new();
        if CACHE_LINE_SIZE == 128 {
            assert_eq!(Segment::<i32>::base_cap(), 26);
        }

        for i in 0..100 {
            list.push(i);
        }

        assert_eq!(list.len(), 100);

        for i in (0..100).rev() {
            assert_eq!(list.pop(), Some(i));
        }

        assert_eq!(list.pop(), None);
    }

    #[test]
    fn test_iter_single_segment() {
        // Test with small number of elements (single segment)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..10 {
            list.push(i);
        }
        assert_eq!(list.first(), Some(&0));
        assert_eq!(list.last(), Some(&9));

        // Test immutable iterator
        let collected: Vec<i32> = list.iter().copied().collect();
        assert_eq!(collected, vec![0, 1, 2, 3, 4, 5, 6, 7, 8, 9]);

        // Test mutable iterator - modify elements
        for item in list.iter_mut() {
            *item *= 2;
        }
        assert_eq!(list.first(), Some(&0));
        assert_eq!(list.last(), Some(&18));

        // Verify modification
        let collected: Vec<i32> = list.iter().copied().collect();
        assert_eq!(collected, vec![0, 2, 4, 6, 8, 10, 12, 14, 16, 18]);

        // Test pop() - should return elements in LIFO order
        for i in (0..10).rev() {
            assert_eq!(list.pop(), Some(i * 2));
        }
        assert_eq!(list.pop(), None);
        assert!(list.is_empty());
    }

    #[test]
    fn test_iter_multi_segment() {
        // Test with many elements (multiple segments)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..200 {
            list.push(i * 10);
        }
        assert_eq!(list.first(), Some(&0));
        assert_eq!(list.last(), Some(&1990));

        // Test immutable iterator across multiple segments
        let collected: Vec<i32> = list.iter().copied().collect();
        let expected: Vec<i32> = (0..200).map(|i| i * 10).collect();
        assert_eq!(collected, expected);

        // Test mutable iterator - modify elements
        for item in list.iter_mut() {
            *item += 1;
        }
        assert_eq!(list.first(), Some(&1));
        assert_eq!(list.last(), Some(&1991));

        // Verify modification
        let collected: Vec<i32> = list.iter().copied().collect();
        let expected: Vec<i32> = (0..200).map(|i| i * 10 + 1).collect();
        assert_eq!(collected, expected);

        // Test pop() - should return elements in LIFO order across multiple segments
        for i in (0..200).rev() {
            assert_eq!(list.pop(), Some(i * 10 + 1));
        }
        assert_eq!(list.pop(), None);
        assert!(list.is_empty());
    }

    #[test]
    fn test_into_iter() {
        // Get capacity per segment for CounterI32 (i32)
        let cap = Segment::<CounterI32>::base_cap();

        // Scenario 1: Single segment, iter completely
        {
            reset_alive_count();
            {
                let mut list: SegList<CounterI32> = SegList::new();
                // Push fewer elements than one segment capacity
                for i in 0..5 {
                    list.push(CounterI32::new(i));
                }
                assert!(list.len() < cap);

                // Drain all elements
                let drained: Vec<i32> = list.into_iter().map(|d| *d).collect();
                assert_eq!(drained, vec![0, 1, 2, 3, 4]);
            }
            // All 5 elements should be dropped by drain
            assert_eq!(alive_count(), 0);
        }

        // Scenario 2: Three segments, iter first segment partially, then drop remaining
        {
            reset_alive_count();
            {
                let mut list: SegList<CounterI32> = SegList::new();
                // Push elements to create 3 segments (cap * 2 + 5 = more than 2 segments)
                let total = cap * 2 + 5;
                for i in 0..total {
                    list.push(CounterI32::new(i as i32));
                }
                assert_eq!(alive_count(), cap * 2 + 5);

                // Drain only half of first segment
                let drain_count = cap / 2;
                let mut drain_iter = list.into_iter();
                for i in 0..drain_count {
                    assert_eq!(*drain_iter.next().unwrap(), i as i32);
                }
                // Drop the drain iterator early (remaining elements should be dropped)
                drop(drain_iter);
            }
            // All elements should be dropped (drained + remaining in list)
            assert_eq!(alive_count(), 0);
        }

        // Scenario 3: Three segments, iter exactly first segment, then drop remaining
        {
            reset_alive_count();
            {
                let mut list: SegList<CounterI32> = SegList::new();
                // Push elements to create 3 segments
                let total = cap * 2 + 3;
                for i in 0..total {
                    list.push(CounterI32::new(i as i32));
                }
                assert_eq!(alive_count(), cap * 2 + 3);

                // Drain exactly first segment
                let mut drain_iter = list.into_iter();
                for i in 0..cap {
                    assert_eq!(*drain_iter.next().unwrap(), i as i32);
                }
                // Drop the drain iterator early
                drop(drain_iter);
            }
            // All elements should be dropped
            assert_eq!(alive_count(), 0);
        }
    }

    #[test]
    fn test_drop_single_segment() {
        reset_alive_count();
        {
            let mut list: SegList<CounterI32> = SegList::new();
            let cap = Segment::<CounterI32>::base_cap();

            // Push fewer elements than one segment capacity
            for i in 0..5 {
                list.push(CounterI32::new(i));
            }
            assert!(list.len() < cap);
            assert_eq!(alive_count(), 5);

            // list drops here, should drop all elements
        }

        assert_eq!(alive_count(), 0);
    }

    #[test]
    fn test_drop_multi_segment() {
        let cap = Segment::<CounterI32>::base_cap();
        reset_alive_count();
        {
            let mut list: SegList<CounterI32> = SegList::new();

            // Push elements to create multiple segments (3 segments)
            let total = cap * 2 + 10;
            for i in 0..total {
                list.push(CounterI32::new(i as i32));
            }
            assert_eq!(alive_count(), cap * 2 + 10);
            // list drops here, should drop all elements across all segments
        }
        assert_eq!(alive_count(), 0);
    }

    #[test]
    fn test_clear_1_segment() {
        reset_alive_count();
        {
            let mut list: SegList<CounterI32> = SegList::new();
            let base_cap = Segment::<CounterI32>::base_cap();

            for i in 0..base_cap as i32 {
                list.push(CounterI32::new(i));
            }
            assert_eq!(alive_count(), base_cap);
            list.clear();
            assert!(list.is_empty());
            assert_eq!(list.len(), 0);
            assert!(list.pop().is_none());
        }
        assert_eq!(alive_count(), 0);
    }

    #[test]
    fn test_clear_2_segment() {
        reset_alive_count();
        {
            let mut list: SegList<CounterI32> = SegList::new();

            let count = Segment::<CounterI32>::base_cap() + Segment::<CounterI32>::large_cap();
            for i in 0..count as i32 {
                list.push(CounterI32::new(i));
            }
            assert_eq!(alive_count(), count);
            list.clear();
            assert!(list.is_empty());
            assert_eq!(list.len(), 0);
            assert!(list.pop().is_none());
        }
        assert_eq!(alive_count(), 0);
    }

    #[test]
    fn test_clear_3_segment() {
        reset_alive_count();
        let mut list: SegList<CounterI32> = SegList::new();

        let count = Segment::<CounterI32>::base_cap() + Segment::<CounterI32>::large_cap() * 2;
        for i in 0..count as i32 {
            list.push(CounterI32::new(i));
        }
        assert_eq!(alive_count(), count);
        list.clear();
        assert!(list.is_empty());
        assert_eq!(list.len(), 0);
        assert!(list.pop().is_none());
        assert_eq!(alive_count(), 0);
    }

    /// Large struct that larger than cache line
    #[derive(Debug, Clone, Copy, PartialEq)]
    struct LargeStruct {
        data: [u64; 16], // 128 bytes
    }

    impl LargeStruct {
        fn new(val: u64) -> Self {
            Self { data: [val; 16] }
        }
    }

    #[test]
    fn test_size() {
        println!("SegList<u64>: {}", size_of::<SegList<u64>>());
        println!("SegList<(u64, u32)>: {}", size_of::<SegList<(u64, u32)>>());
        assert_eq!(size_of::<SegHeader::<LargeStruct>>(), 24);
        let data_offset = Segment::<LargeStruct>::data_offset();
        let base_cap = Segment::<LargeStruct>::base_cap();
        let large_cap = Segment::<LargeStruct>::large_cap();
        let base_layout = Segment::<LargeStruct>::BASE_LAYOUT.1;
        let large_layout = Segment::<LargeStruct>::LARGE_LAYOUT.1;
        println!(
            "LargeStruct: offset={}, base(cap={} size={} align={}), large(cap={} size={} align={})",
            data_offset,
            base_cap,
            base_layout.size(),
            base_layout.align(),
            large_cap,
            large_layout.size(),
            large_layout.align()
        );
        let data_offset = Segment::<u64>::data_offset();
        let base_cap = Segment::<u64>::base_cap();
        let large_cap = Segment::<u64>::large_cap();
        let base_layout = Segment::<u64>::BASE_LAYOUT.1;
        let large_layout = Segment::<u64>::LARGE_LAYOUT.1;
        println!(
            "u64: offset={}, base(cap={} size={} align={}), large(cap={} size={} align={})",
            data_offset,
            base_cap,
            base_layout.size(),
            base_layout.align(),
            large_cap,
            large_layout.size(),
            large_layout.align()
        );
        let data_offset = Segment::<u32>::data_offset();
        let base_cap = Segment::<u32>::base_cap();
        let large_cap = Segment::<u32>::large_cap();
        let base_layout = Segment::<u32>::BASE_LAYOUT.1;
        let large_layout = Segment::<u32>::LARGE_LAYOUT.1;
        println!(
            "u32: offset={}, base(cap={} size={} align={}), large(cap={} size={} align={})",
            data_offset,
            base_cap,
            base_layout.size(),
            base_layout.align(),
            large_cap,
            large_layout.size(),
            large_layout.align()
        );
        let data_offset = Segment::<u16>::data_offset();
        let base_cap = Segment::<u16>::base_cap();
        let large_cap = Segment::<u16>::large_cap();
        let base_layout = Segment::<u16>::BASE_LAYOUT.1;
        let large_layout = Segment::<u16>::LARGE_LAYOUT.1;
        println!(
            "u16: offset={}, base(cap={} size={} align={}), large(cap={} size={} align={})",
            data_offset,
            base_cap,
            base_layout.size(),
            base_layout.align(),
            large_cap,
            large_layout.size(),
            large_layout.align()
        );
    }

    #[test]
    fn test_large_type_push_pop() {
        let mut list: SegList<LargeStruct> = SegList::new();
        // Push elements - each segment can only hold a few due to large element size
        for i in 0..50 {
            list.push(LargeStruct::new(i));
        }
        assert_eq!(list.len(), 50);

        // Pop all elements - should work correctly across multiple segments
        for i in (0..50).rev() {
            let val = list.pop().unwrap();
            assert_eq!(val.data[0], i);
            assert_eq!(val.data[7], i);
        }
        assert!(list.is_empty());
        assert_eq!(list.pop(), None);
    }

    #[test]
    fn test_large_type_iter() {
        let mut list: SegList<LargeStruct> = SegList::new();

        // Push elements
        for i in 0..30 {
            list.push(LargeStruct::new(i * 10));
        }

        // Test iterator
        let collected: Vec<u64> = list.iter().map(|s| s.data[0]).collect();
        let expected: Vec<u64> = (0..30).map(|i| i * 10).collect();
        assert_eq!(collected, expected);
    }

    #[test]
    fn test_large_type_iter_mut() {
        let mut list: SegList<LargeStruct> = SegList::new();

        // Push elements
        for i in 0..20 {
            list.push(LargeStruct::new(i));
        }

        // Modify through iterator
        for item in list.iter_mut() {
            item.data[0] *= 2;
        }

        // Verify modification
        let collected: Vec<u64> = list.iter().map(|s| s.data[0]).collect();
        let expected: Vec<u64> = (0..20).map(|i| i * 2).collect();
        assert_eq!(collected, expected);
    }

    #[test]
    fn test_large_type_drain() {
        let mut list: SegList<LargeStruct> = SegList::new();

        // Push elements
        for i in 0..40 {
            list.push(LargeStruct::new(i));
        }

        // Drain and verify FIFO order
        let drained: Vec<u64> = list.into_iter().map(|s| s.data[0]).collect();
        let expected: Vec<u64> = (0..40).collect();
        assert_eq!(drained, expected);
    }

    #[test]
    fn test_large_type_clear() {
        let mut list: SegList<LargeStruct> = SegList::new();

        // Push elements
        for i in 0..60 {
            list.push(LargeStruct::new(i));
        }
        assert_eq!(list.len(), 60);

        // Clear
        list.clear();
        assert!(list.is_empty());
        assert_eq!(list.len(), 0);
        assert_eq!(list.pop(), None);
    }

    #[test]
    fn test_iter_rev_single_segment() {
        // Test with small number of elements (single segment)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..10 {
            list.push(i);
        }

        // Test reverse iterator
        let collected: Vec<i32> = list.iter_rev().copied().collect();
        let expected: Vec<i32> = (0..10).rev().collect();
        assert_eq!(collected, expected);

        // Test mutable reverse iterator
        for item in list.iter_mut_rev() {
            *item *= 10;
        }

        // Verify modification
        assert_eq!(list.first(), Some(&0));
        assert_eq!(list.last(), Some(&90));

        let collected: Vec<i32> = list.iter().copied().collect();
        let expected: Vec<i32> = vec![0, 10, 20, 30, 40, 50, 60, 70, 80, 90];
        assert_eq!(collected, expected);
    }

    #[test]
    fn test_iter_rev_multi_segment() {
        // Test with many elements (multiple segments)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..200 {
            list.push(i);
        }

        // Test reverse iterator across multiple segments
        let collected: Vec<i32> = list.iter_rev().copied().collect();
        let expected: Vec<i32> = (0..200).rev().collect();
        assert_eq!(collected, expected);

        // Test mutable reverse iterator across multiple segments
        for item in list.iter_mut_rev() {
            *item += 1000;
        }

        // Verify modification
        assert_eq!(list.first(), Some(&1000));
        assert_eq!(list.last(), Some(&1199));

        let collected: Vec<i32> = list.iter().copied().collect();
        let expected: Vec<i32> = (0..200).map(|i| i + 1000).collect();
        assert_eq!(collected, expected);
    }

    #[test]
    fn test_iter_rev_empty() {
        let list: SegList<i32> = SegList::new();

        let collected: Vec<i32> = list.iter_rev().copied().collect();
        assert!(collected.is_empty());

        let mut list_mut: SegList<i32> = SegList::new();
        let count = list_mut.iter_mut_rev().count();
        assert_eq!(count, 0);
    }

    #[test]
    fn test_iter_exact_size() {
        let mut list: SegList<i32> = SegList::new();

        for i in 0..50 {
            list.push(i);
        }

        // Test ExactSizeIterator on reverse iterator
        let iter = list.iter();
        assert_eq!(iter.len(), 50);

        let mut iter = list.iter();
        assert_eq!(iter.len(), 50);
        assert_eq!(iter.next(), Some(&0));
        assert_eq!(iter.len(), 49);
        assert_eq!(iter.next(), Some(&1));
        assert_eq!(iter.len(), 48);

        // Test ExactSizeIterator on mutable reverse iterator
        let mut iter_mut = list.iter_mut();
        assert_eq!(iter_mut.len(), 50);
        assert_eq!(iter_mut.next(), Some(&mut 0));
        assert_eq!(iter_mut.len(), 49);
    }

    #[test]
    fn test_iter_rev_exact_size() {
        let mut list: SegList<i32> = SegList::new();

        for i in 0..50 {
            list.push(i);
        }

        // Test ExactSizeIterator on reverse iterator
        let iter = list.iter_rev();
        assert_eq!(iter.len(), 50);

        let mut iter = list.iter_rev();
        assert_eq!(iter.len(), 50);
        assert_eq!(iter.next(), Some(&49));
        assert_eq!(iter.len(), 49);
        assert_eq!(iter.next(), Some(&48));
        assert_eq!(iter.len(), 48);

        // Test ExactSizeIterator on mutable reverse iterator
        let mut iter_mut = list.iter_mut_rev();
        assert_eq!(iter_mut.len(), 50);
        assert_eq!(iter_mut.next(), Some(&mut 49));
        assert_eq!(iter_mut.len(), 49);
    }

    #[test]
    fn test_into_iter_rev_single_segment() {
        // Test with small number of elements (single segment)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..10 {
            list.push(i);
        }
        let mut iter = list.into_iter_rev();
        assert_eq!(iter.len(), 10);
        // Test into_rev - should yield elements in LIFO order
        let mut drained: Vec<i32> = Vec::new();
        assert_eq!(iter.next(), Some(9));
        assert_eq!(iter.len(), 9);
        drained.push(9);
        let mut left: Vec<i32> = iter.collect();
        drained.append(&mut left);
        let expected: Vec<i32> = (0..10).rev().collect();
        assert_eq!(drained, expected);
    }

    #[test]
    fn test_into_iter_multi_segment() {
        // Test with many elements (multiple segments)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..200i32 {
            list.push(i);
        }
        let mut iter = list.into_iter();
        assert_eq!(iter.len(), 200);
        for i in 0..200i32 {
            assert_eq!(iter.len(), 200 - (i as usize));
            assert_eq!(iter.next(), Some(i));
        }
        assert_eq!(iter.next(), None);
    }

    #[test]
    fn test_into_iter_rev_multi_segment() {
        // Test with many elements (multiple segments)
        let mut list: SegList<i32> = SegList::new();

        for i in 0..200i32 {
            list.push(i);
        }
        let mut iter = list.into_iter_rev();
        assert_eq!(iter.len(), 200);
        for i in 0..200i32 {
            assert_eq!(iter.len(), 200 - (i as usize));
            assert_eq!(iter.next(), Some(199 - i));
        }
        assert_eq!(iter.next(), None);
    }

    #[test]
    fn test_into_iter_rev_empty() {
        let list: SegList<i32> = SegList::new();
        let iter = list.into_iter_rev();
        assert_eq!(iter.len(), 0);
        let drained: Vec<i32> = iter.collect();
        assert!(drained.is_empty());
    }

    #[test]
    fn test_into_iter_rev_partial() {
        // Test partial consumption of into_iter_rev
        let mut list: SegList<i32> = SegList::new();

        for i in 0..50 {
            list.push(i);
        }

        // Only drain half
        let mut drain = list.into_iter_rev();
        let mut drained = Vec::new();
        for _ in 0..25 {
            if let Some(item) = drain.next() {
                drained.push(item);
            }
        }
        assert_eq!(drain.len(), 25);
        // Drop drain - remaining elements should be dropped properly
        drop(drain);

        // Verify we got the last 25 elements in reverse order
        let expected: Vec<i32> = (25..50).rev().collect();
        assert_eq!(drained, expected);
    }
}