depyler_analysis/

error_reporting.rs

//! Enhanced error reporting with source location tracking and helpful suggestions

use depyler_hir::error::ErrorKind;
use anyhow::Result;
use colored::Colorize;
use rustpython_ast::Ranged;
use std::fmt;

/// Enhanced error with source location and context
#[derive(Debug)]
pub struct EnhancedError {
    /// The base error
    pub error: ErrorKind,
    /// Source file path
    pub file_path: Option<String>,
    /// Line number (1-indexed)
    pub line: Option<usize>,
    /// Column number (1-indexed)
    pub column: Option<usize>,
    /// The source line containing the error
    pub source_line: Option<String>,
    /// Helpful suggestion for fixing the error
    pub suggestion: Option<String>,
    /// Related information
    pub notes: Vec<String>,
}

impl EnhancedError {
    pub fn new(error: ErrorKind) -> Self {
        Self {
            error,
            file_path: None,
            line: None,
            column: None,
            source_line: None,
            suggestion: None,
            notes: Vec::new(),
        }
    }

    pub fn with_location(mut self, file: &str, line: usize, column: usize) -> Self {
        self.file_path = Some(file.to_string());
        self.line = Some(line);
        self.column = Some(column);
        self
    }

    pub fn with_source_line(mut self, line: &str) -> Self {
        self.source_line = Some(line.to_string());
        self
    }

    pub fn with_suggestion(mut self, suggestion: &str) -> Self {
        self.suggestion = Some(suggestion.to_string());
        self
    }

    pub fn add_note(mut self, note: &str) -> Self {
        self.notes.push(note.to_string());
        self
    }

    /// Extract location from AST node
    pub fn from_ast_node<T: Ranged>(error: ErrorKind, node: &T, source: &str) -> Self {
        let range = node.range();
        let (line, column) = get_line_column(source, range.start().into());

        let mut enhanced = Self::new(error).with_location("<input>", line, column);

        // Extract the source line
        if let Some(line_text) = get_source_line(source, line) {
            enhanced = enhanced.with_source_line(&line_text);
        }

        // Add automatic suggestions based on error type
        enhanced = add_automatic_suggestions(enhanced);

        enhanced
    }

    /// Format location information (file:line:column)
    #[inline]
    fn format_location_info(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        if let (Some(file), Some(line), Some(column)) = (&self.file_path, self.line, self.column) {
            writeln!(f, "  {} {}:{}:{}", "-->".blue().bold(), file, line, column)?;
        }
        Ok(())
    }

    /// Format source context with line number and pointer
    #[inline]
    fn format_source_context(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        if let (Some(line_text), Some(line_num), Some(col)) =
            (&self.source_line, self.line, self.column)
        {
            writeln!(f, "   {} |", format!("{:4}", " ").dimmed())?;
            writeln!(
                f,
                "   {} | {}",
                format!("{:4}", line_num).blue().bold(),
                line_text
            )?;
            writeln!(
                f,
                "   {} | {}{}",
                format!("{:4}", " ").dimmed(),
                " ".repeat(col.saturating_sub(1)),
                "^".red().bold()
            )?;
        }
        Ok(())
    }

    /// Format suggestion if present
    #[inline]
    fn format_suggestion(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        if let Some(suggestion) = &self.suggestion {
            writeln!(f, "\n{}: {}", "suggestion".green().bold(), suggestion)?;
        }
        Ok(())
    }

    /// Format all notes
    #[inline]
    fn format_notes(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        for note in &self.notes {
            writeln!(f, "  {} {}", "note:".yellow(), note)?;
        }
        Ok(())
    }
}

impl fmt::Display for EnhancedError {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        // Error header
        writeln!(f, "{}: {}", "error".red().bold(), self.error)?;

        // Location info
        self.format_location_info(f)?;

        // Source context
        self.format_source_context(f)?;

        // Suggestion
        self.format_suggestion(f)?;

        // Notes
        self.format_notes(f)?;

        Ok(())
    }
}

/// Get line and column from byte offset
fn get_line_column(source: &str, offset: u32) -> (usize, usize) {
    let mut line = 1;
    let mut column = 1;
    let offset = offset as usize;

    for (i, ch) in source.chars().enumerate() {
        if i >= offset {
            break;
        }
        if ch == '\n' {
            line += 1;
            column = 1;
        } else {
            column += 1;
        }
    }

    (line, column)
}

/// Extract a specific line from source
fn get_source_line(source: &str, line_num: usize) -> Option<String> {
    source
        .lines()
        .nth(line_num.saturating_sub(1))
        .map(String::from)
}

/// Add automatic suggestions based on error type
fn add_automatic_suggestions(error: EnhancedError) -> EnhancedError {
    let suggestion = match &error.error {
        ErrorKind::TypeMismatch {
            expected,
            found,
            context,
        } => generate_type_mismatch_suggestion(expected, found, context),
        ErrorKind::UnsupportedFeature(feature) => suggest_unsupported_feature(feature),
        ErrorKind::TypeInferenceError(msg) => suggest_type_inference_fix(msg),
        ErrorKind::InvalidTypeAnnotation(msg) => suggest_annotation_fix(msg),
        _ => None,
    };

    apply_suggestion_to_error(error, suggestion)
}

/// Apply a suggestion and notes to an error
#[inline]
fn apply_suggestion_to_error(
    mut error: EnhancedError,
    suggestion: Option<(String, Vec<String>)>,
) -> EnhancedError {
    if let Some((suggestion_text, notes)) = suggestion {
        error = error.with_suggestion(&suggestion_text);
        for note in notes {
            error = error.add_note(&note);
        }
    }
    error
}

/// Generate suggestion for unsupported Python features
#[inline]
fn suggest_unsupported_feature(feature: &str) -> Option<(String, Vec<String>)> {
    // Special case for yield (most common unsupported feature)
    if feature == "yield" {
        return Some((
            "Generator functions are not supported. Consider returning a list instead.".to_string(),
            vec!["Example: Instead of 'yield x', collect values and 'return values'".to_string()],
        ));
    }

    // Generic message for all other unsupported features
    Some((
        format!(
            "This Python feature '{feature}' is not yet supported. Consider using a simpler construct."
        ),
        vec![],
    ))
}

/// Generate suggestion for type inference errors
#[inline]
fn suggest_type_inference_fix(msg: &str) -> Option<(String, Vec<String>)> {
    if msg.contains("incompatible types") {
        Some((
            "Check that all type annotations are correct and consistent.".to_string(),
            vec!["Rust has stricter type checking than Python".to_string()],
        ))
    } else {
        None
    }
}

/// Generate suggestion for invalid type annotations
#[inline]
fn suggest_annotation_fix(msg: &str) -> Option<(String, Vec<String>)> {
    if msg.contains("borrow") {
        Some((
            "Consider using .clone() or restructuring to avoid multiple borrows.".to_string(),
            vec!["Rust's borrow checker ensures memory safety".to_string()],
        ))
    } else {
        None
    }
}

/// Generate helpful suggestions for type mismatches
fn generate_type_mismatch_suggestion(
    expected: &str,
    found: &str,
    context: &str,
) -> Option<(String, Vec<String>)> {
    // Try specific type mismatch patterns first
    if let Some(suggestion) = suggest_string_mismatch(expected, found) {
        return Some(suggestion);
    }
    if let Some(suggestion) = suggest_division_mismatch(expected, found) {
        return Some(suggestion);
    }
    if let Some(suggestion) = suggest_option_mismatch(expected, found) {
        return Some(suggestion);
    }
    if let Some(suggestion) = suggest_ownership_mismatch(expected, found) {
        return Some(suggestion);
    }
    if let Some(suggestion) = suggest_collection_mismatch(expected, found) {
        return Some(suggestion);
    }

    // Generic fallback for unmatched cases
    suggest_generic_mismatch(expected, found, context)
}

/// Suggest fix for string type mismatches (str vs String, &str)
#[inline]
fn suggest_string_mismatch(expected: &str, found: &str) -> Option<(String, Vec<String>)> {
    if (expected == "String" && found == "&str") || (expected == "str" && found == "String") {
        Some((
            "String type mismatch - Python 'str' maps to both Rust '&str' and 'String'".to_string(),
            vec![
                "In Rust:".to_string(),
                "  • '&str' is a borrowed string slice (cheap, read-only)".to_string(),
                "  • 'String' is an owned, heap-allocated string".to_string(),
                "Python string methods (.upper(), .lower(), .strip()) return owned String"
                    .to_string(),
                "Use '.to_string()' to convert &str → String, or '&s' to convert String → &str"
                    .to_string(),
            ],
        ))
    } else {
        None
    }
}

/// Suggest fix for division type mismatches (int vs float)
#[inline]
fn suggest_division_mismatch(expected: &str, found: &str) -> Option<(String, Vec<String>)> {
    if expected.contains("f64") && found.contains("i") {
        Some((
            "Division result type mismatch - Python '/' always returns float".to_string(),
            vec![
                "In Python: 10 / 3 = 3.333... (always float)".to_string(),
                "In Rust: 10 / 3 = 3 (integer), 10.0 / 3.0 = 3.333... (float)".to_string(),
                "Use '.as_f64()' or ensure operands are floats for division".to_string(),
            ],
        ))
    } else {
        None
    }
}

/// Suggest fix for Option/None type mismatches
#[inline]
fn suggest_option_mismatch(expected: &str, found: &str) -> Option<(String, Vec<String>)> {
    if expected.contains("Option") && (found == "None" || found == "()") {
        Some((
            "None type mismatch - Python None maps to Rust Option<T>".to_string(),
            vec![
                "In Rust, optional values use Option<T>:".to_string(),
                "  • Some(value) for present values".to_string(),
                "  • None for absent values".to_string(),
                "Return type must be Option<T> if function can return None".to_string(),
            ],
        ))
    } else {
        None
    }
}

/// Suggest fix for ownership mismatches (borrowed vs owned)
#[inline]
fn suggest_ownership_mismatch(expected: &str, found: &str) -> Option<(String, Vec<String>)> {
    if expected.starts_with('&') && !found.starts_with('&') {
        Some((
            format!("Ownership mismatch - expected borrowed reference '{expected}', found owned value '{found}'"),
            vec![
                "Rust distinguishes between owned values and borrowed references".to_string(),
                format!("Add '&' to borrow the value: '&{found}'"),
                "Or use .as_ref() to get a reference without moving the value".to_string(),
            ],
        ))
    } else {
        None
    }
}

/// Suggest fix for collection type mismatches (list vs Vec)
#[inline]
fn suggest_collection_mismatch(expected: &str, found: &str) -> Option<(String, Vec<String>)> {
    if (expected.contains("Vec") && found.contains("list"))
        || (expected.contains("list") && found.contains("Vec"))
    {
        Some((
            "Collection type mismatch - Python list maps to Rust Vec<T>".to_string(),
            vec![
                "Python lists are dynamic arrays, similar to Rust Vec<T>".to_string(),
                "Ensure element types match: Python list[int] → Rust Vec<i32>".to_string(),
            ],
        ))
    } else {
        None
    }
}

/// Generic fallback suggestion for unmatched type mismatches
#[inline]
fn suggest_generic_mismatch(
    expected: &str,
    found: &str,
    context: &str,
) -> Option<(String, Vec<String>)> {
    if context.contains("return") {
        Some((
            format!(
                "Return type mismatch in {context}: expected '{expected}', found '{found}'"
            ),
            vec![
                "Check that your function's return type annotation matches what you're actually returning".to_string(),
                "Python and Rust may have different type representations".to_string(),
            ],
        ))
    } else {
        Some((
            format!("Type mismatch in {context}: expected '{expected}', found '{found}'"),
            vec![
                "Rust's type system is stricter than Python's".to_string(),
                "Ensure all type annotations are explicit and consistent".to_string(),
            ],
        ))
    }
}

/// Error reporter that collects and displays enhanced errors
pub struct ErrorReporter {
    errors: Vec<EnhancedError>,
    source: String,
    file_path: String,
}

impl ErrorReporter {
    pub fn new(source: String, file_path: String) -> Self {
        Self {
            errors: Vec::new(),
            source,
            file_path,
        }
    }

    pub fn report_error(&mut self, error: ErrorKind) {
        let enhanced = EnhancedError::new(error);
        self.errors.push(enhanced);
    }

    pub fn report_error_at<T: Ranged>(&mut self, error: ErrorKind, node: &T) {
        let enhanced = EnhancedError::from_ast_node(error, node, &self.source).with_location(
            &self.file_path,
            0,
            0,
        ); // Will be overridden by from_ast_node
        self.errors.push(enhanced);
    }

    pub fn has_errors(&self) -> bool {
        !self.errors.is_empty()
    }

    pub fn display_errors(&self) {
        for (i, error) in self.errors.iter().enumerate() {
            if i > 0 {
                println!();
            }
            println!("{}", error);
        }

        if self.errors.len() > 1 {
            println!(
                "\n{}: Found {} errors",
                "summary".red().bold(),
                self.errors.len()
            );
        }
    }

    pub fn into_result<T>(self, value: T) -> Result<T> {
        if self.has_errors() {
            self.display_errors();
            anyhow::bail!("Transpilation failed with {} errors", self.errors.len())
        } else {
            Ok(value)
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_enhanced_error_display() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("yield".to_string()))
            .with_location("test.py", 5, 10)
            .with_source_line("    yield x")
            .with_suggestion("Use return with a list instead")
            .add_note("Generators are not supported");

        let display = format!("{}", error);
        assert!(display.contains("yield"));
        assert!(display.contains("test.py:5:10"));
        assert!(display.contains("yield x"));
        assert!(display.contains("suggestion"));
    }

    #[test]
    fn test_line_column_calculation() {
        let source = "line1\nline2\nline3";
        assert_eq!(get_line_column(source, 0), (1, 1));
        assert_eq!(get_line_column(source, 6), (2, 1));
        assert_eq!(get_line_column(source, 12), (3, 1));
    }

    #[test]
    fn test_automatic_suggestions() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("yield".to_string()));
        let enhanced = add_automatic_suggestions(error);

        assert!(enhanced.suggestion.is_some());
        assert!(enhanced.suggestion.unwrap().contains("Generator"));
    }

    #[test]
    fn test_string_type_mismatch_suggestion() {
        let error = EnhancedError::new(ErrorKind::TypeMismatch {
            expected: "String".to_string(),
            found: "&str".to_string(),
            context: "return type".to_string(),
        });
        let enhanced = add_automatic_suggestions(error);

        assert!(enhanced.suggestion.is_some());
        let suggestion = enhanced.suggestion.unwrap();
        assert!(suggestion.contains("String type mismatch"));
        assert!(!enhanced.notes.is_empty());
        assert!(enhanced.notes.iter().any(|n| n.contains("&str")));
    }

    #[test]
    fn test_division_type_mismatch_suggestion() {
        let error = EnhancedError::new(ErrorKind::TypeMismatch {
            expected: "f64".to_string(),
            found: "i32".to_string(),
            context: "division result".to_string(),
        });
        let enhanced = add_automatic_suggestions(error);

        assert!(enhanced.suggestion.is_some());
        let suggestion = enhanced.suggestion.unwrap();
        assert!(suggestion.contains("Division result type mismatch"));
        assert!(enhanced.notes.iter().any(|n| n.contains("always float")));
    }

    #[test]
    fn test_option_type_mismatch_suggestion() {
        let error = EnhancedError::new(ErrorKind::TypeMismatch {
            expected: "Option<i32>".to_string(),
            found: "None".to_string(),
            context: "return value".to_string(),
        });
        let enhanced = add_automatic_suggestions(error);

        assert!(enhanced.suggestion.is_some());
        let suggestion = enhanced.suggestion.unwrap();
        assert!(suggestion.contains("None type mismatch"));
        assert!(enhanced.notes.iter().any(|n| n.contains("Option<T>")));
    }

    #[test]
    fn test_ownership_mismatch_suggestion() {
        let error = EnhancedError::new(ErrorKind::TypeMismatch {
            expected: "&String".to_string(),
            found: "String".to_string(),
            context: "parameter".to_string(),
        });
        let enhanced = add_automatic_suggestions(error);

        assert!(enhanced.suggestion.is_some());
        let suggestion = enhanced.suggestion.unwrap();
        assert!(suggestion.contains("Ownership mismatch"));
        assert!(enhanced
            .notes
            .iter()
            .any(|n| n.contains("borrowed reference")));
    }

    // ============================================================
    // DEPYLER-COVERAGE-95: Additional comprehensive tests
    // ============================================================

    #[test]
    fn test_enhanced_error_new() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("async".to_string()));
        assert!(matches!(&error.error, ErrorKind::UnsupportedFeature(f) if f == "async"));
        assert!(error.file_path.is_none());
        assert!(error.line.is_none());
        assert!(error.column.is_none());
        assert!(error.source_line.is_none());
        assert!(error.suggestion.is_none());
        assert!(error.notes.is_empty());
    }

    #[test]
    fn test_enhanced_error_with_location() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .with_location("file.py", 10, 5);
        assert_eq!(error.file_path, Some("file.py".to_string()));
        assert_eq!(error.line, Some(10));
        assert_eq!(error.column, Some(5));
    }

    #[test]
    fn test_enhanced_error_with_source_line() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .with_source_line("x = 10");
        assert_eq!(error.source_line, Some("x = 10".to_string()));
    }

    #[test]
    fn test_enhanced_error_with_suggestion() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .with_suggestion("Try this instead");
        assert_eq!(error.suggestion, Some("Try this instead".to_string()));
    }

    #[test]
    fn test_enhanced_error_add_note() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .add_note("Note 1")
            .add_note("Note 2");
        assert_eq!(error.notes.len(), 2);
        assert_eq!(error.notes[0], "Note 1");
        assert_eq!(error.notes[1], "Note 2");
    }

    #[test]
    fn test_get_source_line_valid() {
        let source = "line1\nline2\nline3";
        assert_eq!(get_source_line(source, 1), Some("line1".to_string()));
        assert_eq!(get_source_line(source, 2), Some("line2".to_string()));
        assert_eq!(get_source_line(source, 3), Some("line3".to_string()));
    }

    #[test]
    fn test_get_source_line_invalid() {
        let source = "line1\nline2";
        assert!(get_source_line(source, 10).is_none());
        assert!(get_source_line(source, 0).is_some()); // saturating_sub prevents panic
    }

    #[test]
    fn test_get_line_column_start_of_lines() {
        let source = "ab\ncde\nfgh";
        // Line 1 starts at offset 0
        assert_eq!(get_line_column(source, 0), (1, 1));
        // Line 2 starts at offset 3 (after "ab\n")
        assert_eq!(get_line_column(source, 3), (2, 1));
        // Line 3 starts at offset 7 (after "ab\ncde\n")
        assert_eq!(get_line_column(source, 7), (3, 1));
    }

    #[test]
    fn test_get_line_column_middle_of_line() {
        let source = "hello world";
        assert_eq!(get_line_column(source, 0), (1, 1));
        assert_eq!(get_line_column(source, 5), (1, 6)); // 'w' position
        assert_eq!(get_line_column(source, 10), (1, 11));
    }

    #[test]
    fn test_get_line_column_end_of_source() {
        let source = "abc";
        assert_eq!(get_line_column(source, 100), (1, 4)); // Past end, still on line 1
    }

    #[test]
    fn test_suggest_unsupported_feature_yield() {
        let result = suggest_unsupported_feature("yield");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("Generator"));
        assert!(!notes.is_empty());
    }

    #[test]
    fn test_suggest_unsupported_feature_other() {
        let result = suggest_unsupported_feature("async");
        assert!(result.is_some());
        let (suggestion, _) = result.unwrap();
        assert!(suggestion.contains("async"));
        assert!(suggestion.contains("not yet supported"));
    }

    #[test]
    fn test_suggest_type_inference_fix_incompatible() {
        let result = suggest_type_inference_fix("incompatible types in expression");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("type annotations"));
        assert!(notes.iter().any(|n| n.contains("Rust")));
    }

    #[test]
    fn test_suggest_type_inference_fix_other() {
        let result = suggest_type_inference_fix("unknown type");
        assert!(result.is_none());
    }

    #[test]
    fn test_suggest_annotation_fix_borrow() {
        let result = suggest_annotation_fix("cannot borrow twice");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains(".clone()"));
        assert!(notes.iter().any(|n| n.contains("borrow checker")));
    }

    #[test]
    fn test_suggest_annotation_fix_other() {
        let result = suggest_annotation_fix("unknown annotation issue");
        assert!(result.is_none());
    }

    #[test]
    fn test_suggest_collection_mismatch_vec_list() {
        let result = suggest_collection_mismatch("Vec<i32>", "list[int]");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("Collection type mismatch"));
        assert!(notes.iter().any(|n| n.contains("dynamic arrays")));
    }

    #[test]
    fn test_suggest_collection_mismatch_list_vec() {
        let result = suggest_collection_mismatch("list[str]", "Vec<String>");
        assert!(result.is_some());
    }

    #[test]
    fn test_suggest_collection_mismatch_no_match() {
        let result = suggest_collection_mismatch("int", "float");
        assert!(result.is_none());
    }

    #[test]
    fn test_suggest_generic_mismatch_return() {
        let result = suggest_generic_mismatch("int", "str", "return statement");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("Return type mismatch"));
        assert!(notes.iter().any(|n| n.contains("return type annotation")));
    }

    #[test]
    fn test_suggest_generic_mismatch_non_return() {
        let result = suggest_generic_mismatch("int", "str", "assignment");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("Type mismatch in assignment"));
        assert!(notes.iter().any(|n| n.contains("stricter")));
    }

    #[test]
    fn test_suggest_string_mismatch_str_to_string() {
        let result = suggest_string_mismatch("str", "String");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("String type mismatch"));
        assert!(notes.iter().any(|n| n.contains(".to_string()")));
    }

    #[test]
    fn test_suggest_string_mismatch_no_match() {
        let result = suggest_string_mismatch("int", "float");
        assert!(result.is_none());
    }

    #[test]
    fn test_suggest_division_mismatch_no_match() {
        let result = suggest_division_mismatch("String", "i32");
        assert!(result.is_none());
    }

    #[test]
    fn test_suggest_option_mismatch_with_unit() {
        let result = suggest_option_mismatch("Option<String>", "()");
        assert!(result.is_some());
        let (suggestion, _) = result.unwrap();
        assert!(suggestion.contains("None type mismatch"));
    }

    #[test]
    fn test_suggest_option_mismatch_no_match() {
        let result = suggest_option_mismatch("String", "int");
        assert!(result.is_none());
    }

    #[test]
    fn test_suggest_ownership_mismatch_no_match() {
        let result = suggest_ownership_mismatch("String", "String");
        assert!(result.is_none());
    }

    #[test]
    fn test_apply_suggestion_to_error_with_suggestion() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()));
        let suggestion = Some((
            "Use this".to_string(),
            vec!["Note 1".to_string(), "Note 2".to_string()],
        ));
        let result = apply_suggestion_to_error(error, suggestion);
        assert_eq!(result.suggestion, Some("Use this".to_string()));
        assert_eq!(result.notes.len(), 2);
    }

    #[test]
    fn test_apply_suggestion_to_error_without_suggestion() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()));
        let result = apply_suggestion_to_error(error, None);
        assert!(result.suggestion.is_none());
        assert!(result.notes.is_empty());
    }

    #[test]
    fn test_error_reporter_new() {
        let reporter = ErrorReporter::new("source code".to_string(), "test.py".to_string());
        assert!(!reporter.has_errors());
    }

    #[test]
    fn test_error_reporter_report_error() {
        let mut reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.report_error(ErrorKind::UnsupportedFeature("async".to_string()));
        assert!(reporter.has_errors());
    }

    #[test]
    fn test_error_reporter_has_errors_false() {
        let reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        assert!(!reporter.has_errors());
    }

    #[test]
    fn test_error_reporter_has_errors_true() {
        let mut reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.report_error(ErrorKind::UnsupportedFeature("test".to_string()));
        assert!(reporter.has_errors());
    }

    #[test]
    fn test_error_reporter_into_result_success() {
        let reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        let result = reporter.into_result(42);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 42);
    }

    #[test]
    fn test_error_reporter_into_result_failure() {
        let mut reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.report_error(ErrorKind::UnsupportedFeature("test".to_string()));
        let result = reporter.into_result::<i32>(42);
        assert!(result.is_err());
    }

    #[test]
    fn test_enhanced_error_display_no_location() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()));
        let display = format!("{}", error);
        // ErrorKind::UnsupportedFeature displays as "Unsupported Python feature"
        assert!(display.contains("Unsupported Python feature"));
        // Should not contain location info
        assert!(!display.contains("-->"));
    }

    #[test]
    fn test_enhanced_error_display_with_notes() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .add_note("First note")
            .add_note("Second note");
        let display = format!("{}", error);
        assert!(display.contains("First note"));
        assert!(display.contains("Second note"));
    }

    #[test]
    fn test_add_automatic_suggestions_type_inference() {
        let error = EnhancedError::new(ErrorKind::TypeInferenceError(
            "incompatible types".to_string(),
        ));
        let enhanced = add_automatic_suggestions(error);
        assert!(enhanced.suggestion.is_some());
    }

    #[test]
    fn test_add_automatic_suggestions_invalid_annotation() {
        let error = EnhancedError::new(ErrorKind::InvalidTypeAnnotation(
            "cannot borrow".to_string(),
        ));
        let enhanced = add_automatic_suggestions(error);
        assert!(enhanced.suggestion.is_some());
    }

    #[test]
    fn test_add_automatic_suggestions_other_error() {
        // ParseError is a unit variant, not a tuple variant
        let error = EnhancedError::new(ErrorKind::ParseError);
        let enhanced = add_automatic_suggestions(error);
        // ParseError doesn't have automatic suggestions
        assert!(enhanced.suggestion.is_none());
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_string() {
        let result = generate_type_mismatch_suggestion("String", "&str", "return type");
        assert!(result.is_some());
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_division() {
        let result = generate_type_mismatch_suggestion("f64", "i32", "division");
        assert!(result.is_some());
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_option() {
        let result = generate_type_mismatch_suggestion("Option<i32>", "None", "return");
        assert!(result.is_some());
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_ownership() {
        let result = generate_type_mismatch_suggestion("&str", "String", "parameter");
        assert!(result.is_some());
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_collection() {
        let result = generate_type_mismatch_suggestion("Vec<i32>", "list[int]", "assignment");
        assert!(result.is_some());
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_fallback() {
        let result = generate_type_mismatch_suggestion("CustomType", "OtherType", "expression");
        assert!(result.is_some());
        let (suggestion, _) = result.unwrap();
        assert!(suggestion.contains("Type mismatch"));
    }

    #[test]
    fn test_enhanced_error_chaining() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .with_location("file.py", 1, 1)
            .with_source_line("test code")
            .with_suggestion("Try this")
            .add_note("Note 1")
            .add_note("Note 2");

        assert_eq!(error.file_path, Some("file.py".to_string()));
        assert_eq!(error.line, Some(1));
        assert_eq!(error.column, Some(1));
        assert_eq!(error.source_line, Some("test code".to_string()));
        assert_eq!(error.suggestion, Some("Try this".to_string()));
        assert_eq!(error.notes.len(), 2);
    }

    #[test]
    fn test_enhanced_error_display_full() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("test".to_string()))
            .with_location("file.py", 5, 10)
            .with_source_line("    test_code()")
            .with_suggestion("Use something else")
            .add_note("Important note");

        let display = format!("{}", error);
        assert!(display.contains("error"));
        assert!(display.contains("file.py:5:10"));
        assert!(display.contains("test_code()"));
        assert!(display.contains("suggestion"));
        assert!(display.contains("note:"));
    }

    #[test]
    fn test_get_line_column_empty_source() {
        let source = "";
        assert_eq!(get_line_column(source, 0), (1, 1));
    }

    #[test]
    fn test_get_source_line_empty_source() {
        let source = "";
        assert!(get_source_line(source, 1).is_none());
    }

    #[test]
    fn test_get_source_line_single_line() {
        let source = "only one line";
        assert_eq!(
            get_source_line(source, 1),
            Some("only one line".to_string())
        );
        assert!(get_source_line(source, 2).is_none());
    }

    #[test]
    fn test_error_reporter_display_errors_single() {
        let mut reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.report_error(ErrorKind::UnsupportedFeature("async".to_string()));
        reporter.display_errors();
        assert!(reporter.has_errors());
    }

    #[test]
    fn test_error_reporter_display_errors_multiple() {
        let mut reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.report_error(ErrorKind::UnsupportedFeature("async".to_string()));
        reporter.report_error(ErrorKind::ParseError);
        reporter.report_error(ErrorKind::TypeInferenceError("test".to_string()));
        reporter.display_errors();
        assert_eq!(reporter.errors.len(), 3);
    }

    #[test]
    fn test_error_reporter_display_errors_empty() {
        let reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.display_errors();
        assert!(!reporter.has_errors());
    }

    #[test]
    fn test_enhanced_error_format_location_info_complete() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_location("test.py", 10, 20);
        let display = format!("{}", error);
        assert!(display.contains("-->"));
        assert!(display.contains("test.py:10:20"));
    }

    #[test]
    fn test_enhanced_error_format_location_info_incomplete() {
        let mut error = EnhancedError::new(ErrorKind::ParseError);
        error.file_path = Some("test.py".to_string());
        error.line = Some(10);
        let display = format!("{}", error);
        assert!(!display.contains("-->"));
    }

    #[test]
    fn test_enhanced_error_format_source_context_complete() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_location("test.py", 5, 10)
            .with_source_line("    x = 10");
        let display = format!("{}", error);
        assert!(display.contains("x = 10"));
        assert!(display.contains("|"));
    }

    #[test]
    fn test_enhanced_error_format_source_context_incomplete() {
        let mut error = EnhancedError::new(ErrorKind::ParseError);
        error.source_line = Some("x = 10".to_string());
        error.line = Some(5);
        let display = format!("{}", error);
        assert!(!display.contains("|"));
    }

    #[test]
    fn test_enhanced_error_format_suggestion_present() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_suggestion("Try using a different syntax");
        let display = format!("{}", error);
        assert!(display.contains("suggestion"));
        assert!(display.contains("Try using a different syntax"));
    }

    #[test]
    fn test_enhanced_error_format_suggestion_absent() {
        let error = EnhancedError::new(ErrorKind::ParseError);
        let display = format!("{}", error);
        assert!(!display.contains("suggestion"));
    }

    #[test]
    fn test_enhanced_error_format_notes_present() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .add_note("First note")
            .add_note("Second note");
        let display = format!("{}", error);
        assert!(display.contains("note:"));
        assert!(display.contains("First note"));
        assert!(display.contains("Second note"));
    }

    #[test]
    fn test_enhanced_error_format_notes_absent() {
        let error = EnhancedError::new(ErrorKind::ParseError);
        let display = format!("{}", error);
        let note_count = display.matches("note:").count();
        assert_eq!(note_count, 0);
    }

    #[test]
    fn test_generate_type_mismatch_suggestion_multiple_patterns() {
        let result1 = generate_type_mismatch_suggestion("String", "&str", "context");
        assert!(result1.is_some());

        let result2 = generate_type_mismatch_suggestion("f64", "i32", "context");
        assert!(result2.is_some());

        let result3 = generate_type_mismatch_suggestion("Option<T>", "None", "context");
        assert!(result3.is_some());

        let result4 = generate_type_mismatch_suggestion("&String", "String", "context");
        assert!(result4.is_some());

        let result5 = generate_type_mismatch_suggestion("Vec<i32>", "list", "context");
        assert!(result5.is_some());
    }

    #[test]
    fn test_suggest_division_mismatch_with_various_int_types() {
        assert!(suggest_division_mismatch("f64", "i8").is_some());
        assert!(suggest_division_mismatch("f64", "i16").is_some());
        assert!(suggest_division_mismatch("f64", "i32").is_some());
        assert!(suggest_division_mismatch("f64", "i64").is_some());
        assert!(suggest_division_mismatch("f32", "i32").is_none());
    }

    #[test]
    fn test_get_line_column_multiline_with_various_offsets() {
        let source = "abc\ndef\nghi";
        assert_eq!(get_line_column(source, 0), (1, 1));
        assert_eq!(get_line_column(source, 1), (1, 2));
        assert_eq!(get_line_column(source, 2), (1, 3));
        assert_eq!(get_line_column(source, 3), (1, 4));
        assert_eq!(get_line_column(source, 4), (2, 1));
        assert_eq!(get_line_column(source, 5), (2, 2));
    }

    #[test]
    fn test_get_source_line_with_multiple_lines() {
        let source = "first\nsecond\nthird\nfourth";
        assert_eq!(get_source_line(source, 1), Some("first".to_string()));
        assert_eq!(get_source_line(source, 2), Some("second".to_string()));
        assert_eq!(get_source_line(source, 3), Some("third".to_string()));
        assert_eq!(get_source_line(source, 4), Some("fourth".to_string()));
    }

    #[test]
    fn test_enhanced_error_multiple_notes() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .add_note("Note 1")
            .add_note("Note 2")
            .add_note("Note 3");
        assert_eq!(error.notes.len(), 3);
        let display = format!("{}", error);
        assert!(display.contains("Note 1"));
        assert!(display.contains("Note 2"));
        assert!(display.contains("Note 3"));
    }

    #[test]
    fn test_error_reporter_multiple_operations() {
        let mut reporter = ErrorReporter::new("code\nmore code".to_string(), "file.py".to_string());
        assert!(!reporter.has_errors());

        reporter.report_error(ErrorKind::ParseError);
        assert!(reporter.has_errors());

        reporter.report_error(ErrorKind::UnsupportedFeature("test".to_string()));
        assert_eq!(reporter.errors.len(), 2);
    }

    #[test]
    fn test_add_automatic_suggestions_type_mismatch() {
        let error = EnhancedError::new(ErrorKind::TypeMismatch {
            expected: "String".to_string(),
            found: "&str".to_string(),
            context: "test".to_string(),
        });
        let enhanced = add_automatic_suggestions(error);
        assert!(enhanced.suggestion.is_some());
        assert!(!enhanced.notes.is_empty());
    }

    #[test]
    fn test_add_automatic_suggestions_unsupported_feature_non_yield() {
        let error = EnhancedError::new(ErrorKind::UnsupportedFeature("walrus".to_string()));
        let enhanced = add_automatic_suggestions(error);
        assert!(enhanced.suggestion.is_some());
        assert!(enhanced.suggestion.unwrap().contains("walrus"));
    }

    #[test]
    fn test_enhanced_error_display_with_column_edge_cases() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_location("test.py", 1, 1)
            .with_source_line("x");
        let display = format!("{}", error);
        assert!(display.contains("^"));
    }

    #[test]
    fn test_enhanced_error_display_with_large_column() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_location("test.py", 1, 100)
            .with_source_line("short line");
        let display = format!("{}", error);
        assert!(display.contains("^"));
    }

    #[test]
    fn test_get_line_column_unicode() {
        let source = "hello\n世界\ntest";
        assert_eq!(get_line_column(source, 0), (1, 1));
        assert_eq!(get_line_column(source, 6), (2, 1));
        assert_eq!(get_line_column(source, 7), (2, 2));
    }

    #[test]
    fn test_suggest_ownership_mismatch_with_ampersand() {
        let result = suggest_ownership_mismatch("&Vec<i32>", "Vec<i32>");
        assert!(result.is_some());
        let (suggestion, notes) = result.unwrap();
        assert!(suggestion.contains("Ownership mismatch"));
        assert!(notes.iter().any(|n| n.contains("borrowed")));
    }

    #[test]
    fn test_suggest_generic_mismatch_with_return_context() {
        let result = suggest_generic_mismatch("A", "B", "return value");
        assert!(result.is_some());
        let (suggestion, _) = result.unwrap();
        assert!(suggestion.contains("Return type mismatch"));
    }

    #[test]
    fn test_error_reporter_into_result_with_value() {
        let reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        let result = reporter.into_result("success");
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success");
    }

    #[test]
    fn test_error_reporter_into_result_with_errors() {
        let mut reporter = ErrorReporter::new("source".to_string(), "test.py".to_string());
        reporter.report_error(ErrorKind::ParseError);
        let result = reporter.into_result::<&str>("value");
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("1 error"));
    }

    #[test]
    fn test_enhanced_error_debug_output() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_location("test.py", 1, 1);
        let debug = format!("{:?}", error);
        assert!(debug.contains("EnhancedError"));
    }

    #[test]
    fn test_suggest_annotation_fix_with_borrow_keyword() {
        let result = suggest_annotation_fix("cannot borrow as mutable");
        assert!(result.is_some());
        let (suggestion, _) = result.unwrap();
        assert!(suggestion.contains(".clone()"));
    }

    #[test]
    fn test_suggest_type_inference_fix_no_match() {
        let result = suggest_type_inference_fix("some other error");
        assert!(result.is_none());
    }

    #[test]
    fn test_enhanced_error_all_fields_populated() {
        let error = EnhancedError::new(ErrorKind::TypeMismatch {
            expected: "i32".to_string(),
            found: "str".to_string(),
            context: "assignment".to_string(),
        })
        .with_location("file.py", 42, 17)
        .with_source_line("    result = \"text\"")
        .with_suggestion("Convert to the correct type")
        .add_note("First note")
        .add_note("Second note");

        assert!(error.file_path.is_some());
        assert!(error.line.is_some());
        assert!(error.column.is_some());
        assert!(error.source_line.is_some());
        assert!(error.suggestion.is_some());
        assert_eq!(error.notes.len(), 2);
    }

    #[test]
    fn test_error_reporter_with_empty_source() {
        let reporter = ErrorReporter::new(String::new(), "empty.py".to_string());
        assert!(!reporter.has_errors());
        assert_eq!(reporter.source, "");
    }

    #[test]
    fn test_get_source_line_zero_line() {
        let source = "line1\nline2\nline3";
        let result = get_source_line(source, 0);
        assert!(result.is_some());
    }

    #[test]
    fn test_enhanced_error_partial_fields() {
        let mut error = EnhancedError::new(ErrorKind::ParseError);
        error.file_path = Some("test.py".to_string());
        error.column = Some(5);
        let display = format!("{}", error);
        assert!(!display.contains("-->"));
    }

    #[test]
    fn test_from_ast_node_with_simple_source() {
        use rustpython_ast::Suite;
        use rustpython_parser::Parse;

        let source = "x = 1\ny = 2\nz = 3";
        let parsed = Suite::parse(source, "<test>").unwrap();

        if let Some(stmt) = parsed.first() {
            let error = EnhancedError::from_ast_node(
                ErrorKind::UnsupportedFeature("test".to_string()),
                stmt,
                source,
            );

            assert_eq!(error.file_path, Some("<input>".to_string()));
            assert!(error.line.is_some());
            assert!(error.column.is_some());
            assert!(error.source_line.is_some());
        }
    }

    #[test]
    fn test_from_ast_node_with_multiline_source() {
        use rustpython_ast::Suite;
        use rustpython_parser::Parse;

        let source = "def foo():\n    pass\n\nclass Bar:\n    pass";
        let parsed = Suite::parse(source, "<test>").unwrap();

        if let Some(stmt) = parsed.get(1) {
            let error = EnhancedError::from_ast_node(
                ErrorKind::TypeMismatch {
                    expected: "int".to_string(),
                    found: "str".to_string(),
                    context: "test".to_string(),
                },
                stmt,
                source,
            );

            assert!(error.line.is_some());
            assert!(error.column.is_some());
        }
    }

    #[test]
    fn test_report_error_at_with_ast_node() {
        use rustpython_ast::Suite;
        use rustpython_parser::Parse;

        let source = "x = 1 + 2";
        let parsed = Suite::parse(source, "<test>").unwrap();

        let mut reporter = ErrorReporter::new(source.to_string(), "test.py".to_string());

        if let Some(stmt) = parsed.first() {
            reporter.report_error_at(ErrorKind::UnsupportedFeature("addition".to_string()), stmt);
            assert!(reporter.has_errors());
            assert_eq!(reporter.errors.len(), 1);
        }
    }

    #[test]
    fn test_error_reporter_multiple_report_error_at() {
        use rustpython_ast::Suite;
        use rustpython_parser::Parse;

        let source = "x = 1\ny = 2\nz = 3";
        let parsed = Suite::parse(source, "<test>").unwrap();

        let mut reporter = ErrorReporter::new(source.to_string(), "multi.py".to_string());

        for stmt in &parsed {
            reporter.report_error_at(ErrorKind::ParseError, stmt);
        }

        assert_eq!(reporter.errors.len(), 3);
    }

    #[test]
    fn test_enhanced_error_column_saturation() {
        let error = EnhancedError::new(ErrorKind::ParseError)
            .with_location("test.py", 1, 0)
            .with_source_line("test");
        let display = format!("{}", error);
        assert!(display.contains("^"));
    }

    #[test]
    fn test_get_line_column_at_newline() {
        let source = "line1\nline2";
        assert_eq!(get_line_column(source, 5), (1, 6));
    }

    #[test]
    fn test_error_kinds_with_automatic_suggestions() {
        let error1 = EnhancedError::new(ErrorKind::CodeGenerationError("test".to_string()));
        let enhanced1 = add_automatic_suggestions(error1);
        assert!(enhanced1.suggestion.is_none());

        let error2 = EnhancedError::new(ErrorKind::VerificationError("test".to_string()));
        let enhanced2 = add_automatic_suggestions(error2);
        assert!(enhanced2.suggestion.is_none());
    }

    #[test]
    fn test_enhanced_error_display_minimal() {
        let error = EnhancedError::new(ErrorKind::InternalError("minimal".to_string()));
        let display = format!("{}", error);
        assert!(display.contains("error"));
        assert!(display.contains("Internal error"));
    }

    #[test]
    fn test_format_methods_edge_cases() {
        let mut error = EnhancedError::new(ErrorKind::ParseError);
        error.file_path = Some("test.py".to_string());
        error.line = None;
        error.column = Some(10);
        let display = format!("{}", error);
        assert!(!display.contains("-->"));

        error.line = Some(5);
        error.column = None;
        let display2 = format!("{}", error);
        assert!(!display2.contains("-->"));
    }
}