1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
mod symbol;
use std::{
borrow::Cow,
collections::BTreeMap,
fmt,
path::{Path, PathBuf},
};
use crate::{StringEntry, Table, TableEntry, Tag, DEFMT_VERSION};
use anyhow::{anyhow, bail, ensure};
use object::{Object, ObjectSection, ObjectSymbol};
pub fn parse_impl(elf: &[u8], check_version: bool) -> Result<Option<Table>, anyhow::Error> {
let elf = object::File::parse(elf)?;
let mut version = None;
let is_defmt_version = |name: &str| {
name.starts_with("\"_defmt_version_ = ") || name.starts_with("_defmt_version_ = ")
};
for entry in elf.symbols() {
let name = match entry.name() {
Ok(name) => name,
Err(_) => continue,
};
if is_defmt_version(name) {
let new_version = name
.trim_start_matches("\"_defmt_version_ = ")
.trim_start_matches("_defmt_version_ = ")
.trim_end_matches('"');
if let Some(version) = version {
return Err(anyhow!(
"multiple defmt versions in use: {} and {} (only one is supported)",
version,
new_version
));
}
version = Some(new_version);
}
}
let defmt_shndx = elf.section_by_name(".defmt").map(|s| s.index());
let (defmt_shndx, version) = match (defmt_shndx, version) {
(None, None) => return Ok(None),
(Some(defmt_shndx), Some(version)) => (defmt_shndx, version),
(None, Some(_)) => {
bail!("defmt version found, but no `.defmt` section - check your linker configuration");
}
(Some(_), None) => {
bail!(
"`.defmt` section found, but no version symbol - check your linker configuration"
);
}
};
if check_version {
self::check_version(version).map_err(anyhow::Error::msg)?;
}
let mut map = BTreeMap::new();
let mut timestamp = None;
for entry in elf.symbols() {
let name = match entry.name() {
Ok(name) if !name.is_empty() => name,
_ => continue,
};
if is_defmt_version(name) || name.starts_with("__DEFMT_MARKER") {
continue;
}
if entry.section_index() == Some(defmt_shndx) {
let sym = symbol::Symbol::demangle(name)?;
match sym.tag() {
symbol::SymbolTag::Defmt(tag) => {
if tag == Tag::Timestamp {
if timestamp.is_some() {
bail!("multiple timestamp format specifications found");
}
timestamp = Some(TableEntry::new(
StringEntry::new(tag, sym.data().to_string()),
name.to_string(),
));
} else {
map.insert(
entry.address() as usize,
TableEntry::new(
StringEntry::new(tag, sym.data().to_string()),
name.to_string(),
),
);
}
}
symbol::SymbolTag::Custom(_) => {}
}
}
}
let mut table = Table::new(map);
if let Some(ts) = timestamp {
table.set_timestamp_entry(ts);
}
Ok(Some(table))
}
fn check_version(version: &str) -> Result<(), String> {
enum Kind {
Semver,
Git,
}
impl Kind {
fn of(version: &str) -> Kind {
if version.contains('.') || version.parse::<u64>().is_ok() {
Kind::Semver
} else {
Kind::Git
}
}
}
if version != DEFMT_VERSION {
let mut msg = format!(
"defmt version mismatch: firmware is using {}, `probe-run` supports {}\nsuggestion: ",
version, DEFMT_VERSION
);
let git_sem = "migrate your firmware to a crates.io version of defmt (check https://https://defmt.ferrous-systems.com) OR `cargo install` a _git_ version of `probe-run`: `cargo install --git https://github.com/knurling-rs/probe-run --branch main`";
let sem_git = "`cargo install` a non-git version of `probe-run`: `cargo install probe-run`";
let sem_sem = &*format!(
"`cargo install` a different non-git version of `probe-run` that supports defmt {}",
version,
);
let git_git = &*format!(
"pin _all_ `defmt` related dependencies to revision {0}; modify Cargo.toml files as shown below\n
[dependencies]
defmt = {{ git = \"https://github.com/knurling-rs/defmt\", rev = \"{0}\" }}
defmt-rtt = {{ git = \"https://github.com/knurling-rs/defmt\", rev = \"{0}\" }}
# ONLY pin this dependency if you are using the `print-defmt` feature
panic-probe = {{ git = \"https://github.com/knurling-rs/defmt\", features = [\"print-defmt\"], rev = \"{0}\" }}",
DEFMT_VERSION
);
match (Kind::of(version), Kind::of(DEFMT_VERSION)) {
(Kind::Git, Kind::Git) => msg.push_str(git_git),
(Kind::Git, Kind::Semver) => msg.push_str(git_sem),
(Kind::Semver, Kind::Git) => msg.push_str(sem_git),
(Kind::Semver, Kind::Semver) => msg.push_str(sem_sem),
}
return Err(msg);
}
Ok(())
}
#[derive(Clone)]
pub struct Location {
pub file: PathBuf,
pub line: u64,
pub module: String,
}
impl fmt::Debug for Location {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "{}:{}", self.file.display(), self.line)
}
}
pub type Locations = BTreeMap<u64, Location>;
pub fn get_locations(elf: &[u8], table: &Table) -> Result<Locations, anyhow::Error> {
let object = object::File::parse(elf)?;
let endian = if object.is_little_endian() {
gimli::RunTimeEndian::Little
} else {
gimli::RunTimeEndian::Big
};
let load_section = |id: gimli::SectionId| {
Ok(if let Some(s) = object.section_by_name(id.name()) {
s.uncompressed_data().unwrap_or(Cow::Borrowed(&[][..]))
} else {
Cow::Borrowed(&[][..])
})
};
let load_section_sup = |_| Ok(Cow::Borrowed(&[][..]));
let dwarf_cow =
gimli::Dwarf::<Cow<[u8]>>::load::<_, _, anyhow::Error>(&load_section, &load_section_sup)?;
let borrow_section: &dyn for<'a> Fn(
&'a Cow<[u8]>,
) -> gimli::EndianSlice<'a, gimli::RunTimeEndian> =
&|section| gimli::EndianSlice::new(&*section, endian);
let dwarf = dwarf_cow.borrow(&borrow_section);
let mut units = dwarf.debug_info.units();
let mut map = BTreeMap::new();
while let Some(header) = units.next()? {
let unit = dwarf.unit(header)?;
let abbrev = header.abbreviations(&dwarf.debug_abbrev)?;
let mut cursor = header.entries(&abbrev);
ensure!(cursor.next_dfs()?.is_some(), "empty DWARF?");
let mut segments = vec![];
let mut depth = 0;
while let Some((delta_depth, entry)) = cursor.next_dfs()? {
depth += delta_depth;
if entry.tag() == gimli::constants::DW_TAG_namespace {
let mut attrs = entry.attrs();
while let Some(attr) = attrs.next()? {
if attr.name() == gimli::constants::DW_AT_name {
if let gimli::AttributeValue::DebugStrRef(off) = attr.value() {
let s = dwarf.string(off)?;
for _ in (depth as usize)..segments.len() + 1 {
segments.pop();
}
segments.push(core::str::from_utf8(&s)?.to_string());
}
}
}
} else if entry.tag() == gimli::constants::DW_TAG_variable {
let mut attrs = entry.attrs();
let mut decl_file = None;
let mut decl_line = None;
let mut name = None;
let mut linkage_name = None;
let mut location = None;
while let Some(attr) = attrs.next()? {
match attr.name() {
gimli::constants::DW_AT_name => {
if let gimli::AttributeValue::DebugStrRef(off) = attr.value() {
name = Some(off);
}
}
gimli::constants::DW_AT_decl_file => {
if let gimli::AttributeValue::FileIndex(idx) = attr.value() {
decl_file = Some(idx);
}
}
gimli::constants::DW_AT_decl_line => {
if let gimli::AttributeValue::Udata(line) = attr.value() {
decl_line = Some(line);
}
}
gimli::constants::DW_AT_location => {
if let gimli::AttributeValue::Exprloc(loc) = attr.value() {
location = Some(loc);
}
}
gimli::constants::DW_AT_linkage_name => {
if let gimli::AttributeValue::DebugStrRef(off) = attr.value() {
linkage_name = Some(off);
}
}
_ => {}
}
}
if let (
Some(name_index),
Some(linkage_name_index),
Some(file_index),
Some(line),
Some(loc),
) = (name, linkage_name, decl_file, decl_line, location)
{
let name_slice = dwarf.string(name_index)?;
let name = core::str::from_utf8(&name_slice)?;
let linkage_name_slice = dwarf.string(linkage_name_index)?;
let linkage_name = core::str::from_utf8(&linkage_name_slice)?;
if name == "DEFMT_LOG_STATEMENT" {
if table.raw_symbols().any(|i| i == linkage_name) {
let addr = exprloc2address(unit.encoding(), &loc)?;
let file = file_index_to_path(file_index, &unit, &dwarf)?;
let module = segments.join("::");
let loc = Location { file, line, module };
if let Some(old) = map.insert(addr, loc.clone()) {
bail!("BUG in DWARF variable filter: index collision for addr 0x{:08x} (old = {:?}, new = {:?})", addr, old, loc);
}
} else {
}
}
}
}
}
}
Ok(map)
}
fn file_index_to_path<R>(
index: u64,
unit: &gimli::Unit<R>,
dwarf: &gimli::Dwarf<R>,
) -> Result<PathBuf, anyhow::Error>
where
R: gimli::read::Reader,
{
ensure!(index != 0, "`FileIndex` was zero");
let header = if let Some(program) = &unit.line_program {
program.header()
} else {
bail!("no `LineProgram`");
};
let file = if let Some(file) = header.file(index) {
file
} else {
bail!("no `FileEntry` for index {}", index)
};
let mut p = PathBuf::new();
if let Some(dir) = file.directory(header) {
let dir = dwarf.attr_string(unit, dir)?;
let dir_s = dir.to_string_lossy()?;
let dir = Path::new(&dir_s[..]);
if !dir.is_absolute() {
if let Some(ref comp_dir) = unit.comp_dir {
p.push(&comp_dir.to_string_lossy()?[..]);
}
}
p.push(&dir);
}
p.push(
&dwarf
.attr_string(unit, file.path_name())?
.to_string_lossy()?[..],
);
Ok(p)
}
fn exprloc2address<R: gimli::read::Reader<Offset = usize>>(
encoding: gimli::Encoding,
data: &gimli::Expression<R>,
) -> Result<u64, anyhow::Error> {
let mut pc = data.0.clone();
while pc.len() != 0 {
if let Ok(gimli::Operation::Address { address }) =
gimli::Operation::parse(&mut pc, encoding)
{
return Ok(address);
}
}
Err(anyhow!("`Operation::Address` not found"))
}