decy_hir/

lib.rs

//! High-level Intermediate Representation for C-to-Rust transpilation.
//!
//! The HIR is a Rust-oriented representation that bridges C AST and Rust code generation.
//!
//! # Examples
//!
//! ```
//! use decy_hir::{HirFunction, HirType, HirParameter};
//!
//! // Create a simple HIR function
//! let func = HirFunction::new(
//!     "main".to_string(),
//!     HirType::Int,
//!     vec![],
//! );
//!
//! assert_eq!(func.name(), "main");
//! assert_eq!(func.return_type(), &HirType::Int);
//! ```

#![warn(missing_docs)]
#![warn(clippy::all)]
#![deny(unsafe_code)]

/// Represents a C type in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum HirType {
    /// void type
    Void,
    /// C99 _Bool type (maps to bool in Rust)
    Bool,
    /// int type (maps to i32 in Rust)
    Int,
    /// unsigned int type (maps to u32 in Rust) - DECY-158
    UnsignedInt,
    /// float type (maps to f32 in Rust)
    Float,
    /// double type (maps to f64 in Rust)
    Double,
    /// char type (maps to u8 in Rust)
    Char,
    /// signed char type (maps to i8 in Rust) - DECY-250
    SignedChar,
    /// Pointer to another type
    Pointer(Box<HirType>),
    /// Boxed type (Rust `Box<T>`)
    Box(Box<HirType>),
    /// Vec type (Rust `Vec<T>`)
    Vec(Box<HirType>),
    /// Option type (Rust `Option<T>`) - for NULL pointer handling
    Option(Box<HirType>),
    /// Reference type (Rust `&T` or `&mut T`)
    Reference {
        /// Inner type
        inner: Box<HirType>,
        /// Whether the reference is mutable
        mutable: bool,
    },
    /// Struct type (by name)
    Struct(String),
    /// Enum type (by name)
    Enum(String),
    /// Union type with named fields
    Union(Vec<(String, HirType)>),
    /// Array type with optional size (fixed-size or unsized)
    Array {
        /// Element type
        element_type: Box<HirType>,
        /// Optional size (None for unsized arrays like function parameters)
        size: Option<usize>,
    },
    /// Function pointer type (Rust `fn` type)
    FunctionPointer {
        /// Parameter types
        param_types: Vec<HirType>,
        /// Return type
        return_type: Box<HirType>,
    },
    /// String literal type (maps to &str in Rust)
    StringLiteral,
    /// Owned string type (maps to String in Rust)
    OwnedString,
    /// String reference type (maps to &str in Rust)
    StringReference,
    /// Type alias (typedef) - preserves the alias name for codegen
    /// DECY-172: Used for size_t, ssize_t, ptrdiff_t, etc.
    TypeAlias(String),
}

impl HirType {
    /// Convert from parser AST type to HIR type.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::HirType;
    /// use decy_parser::parser::Type;
    ///
    /// let hir_type = HirType::from_ast_type(&Type::Int);
    /// assert_eq!(hir_type, HirType::Int);
    /// ```
    pub fn from_ast_type(ast_type: &decy_parser::parser::Type) -> Self {
        use decy_parser::parser::Type;
        match ast_type {
            Type::Void => HirType::Void,
            Type::Bool => HirType::Bool,
            Type::Int => HirType::Int,
            Type::UnsignedInt => HirType::UnsignedInt, // DECY-158
            Type::Float => HirType::Float,
            Type::Double => HirType::Double,
            Type::Char => HirType::Char,
            Type::SignedChar => HirType::SignedChar, // DECY-250
            Type::Pointer(inner) => HirType::Pointer(Box::new(HirType::from_ast_type(inner))),
            Type::Struct(name) => HirType::Struct(name.clone()),
            Type::FunctionPointer {
                param_types,
                return_type,
            } => HirType::FunctionPointer {
                param_types: param_types.iter().map(HirType::from_ast_type).collect(),
                return_type: Box::new(HirType::from_ast_type(return_type)),
            },
            Type::Array { element_type, size } => HirType::Array {
                element_type: Box::new(HirType::from_ast_type(element_type)),
                size: size.map(|s| s as usize),
            },
            // DECY-172: Preserve type aliases like size_t, ssize_t, ptrdiff_t
            Type::TypeAlias(name) => HirType::TypeAlias(name.clone()),
        }
    }
}

/// Represents a struct field in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirStructField {
    name: String,
    field_type: HirType,
}

impl HirStructField {
    /// Create a new struct field.
    pub fn new(name: String, field_type: HirType) -> Self {
        Self { name, field_type }
    }

    /// Get the field name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the field type.
    pub fn field_type(&self) -> &HirType {
        &self.field_type
    }
}

/// Represents a struct definition in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirStruct {
    name: String,
    fields: Vec<HirStructField>,
}

impl HirStruct {
    /// Create a new struct.
    pub fn new(name: String, fields: Vec<HirStructField>) -> Self {
        Self { name, fields }
    }

    /// Get the struct name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the struct fields.
    pub fn fields(&self) -> &[HirStructField] {
        &self.fields
    }
}

/// Represents an enum variant in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirEnumVariant {
    name: String,
    value: Option<i32>,
}

impl HirEnumVariant {
    /// Create a new enum variant.
    pub fn new(name: String, value: Option<i32>) -> Self {
        Self { name, value }
    }

    /// Get the variant name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the variant value.
    pub fn value(&self) -> Option<i32> {
        self.value
    }
}

/// Represents an enum definition in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirEnum {
    name: String,
    variants: Vec<HirEnumVariant>,
}

impl HirEnum {
    /// Create a new enum.
    pub fn new(name: String, variants: Vec<HirEnumVariant>) -> Self {
        Self { name, variants }
    }

    /// Get the enum name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the enum variants.
    pub fn variants(&self) -> &[HirEnumVariant] {
        &self.variants
    }
}

/// Represents a typedef (type alias) in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirTypedef {
    name: String,
    underlying_type: HirType,
}

impl HirTypedef {
    /// Create a new typedef.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::{HirTypedef, HirType};
    ///
    /// let typedef = HirTypedef::new("Integer".to_string(), HirType::Int);
    /// assert_eq!(typedef.name(), "Integer");
    /// assert_eq!(typedef.underlying_type(), &HirType::Int);
    /// ```
    pub fn new(name: String, underlying_type: HirType) -> Self {
        Self {
            name,
            underlying_type,
        }
    }

    /// Get the typedef name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the underlying type.
    pub fn underlying_type(&self) -> &HirType {
        &self.underlying_type
    }
}

/// Represents a constant declaration in HIR (from C #define or const).
///
/// # Examples
///
/// ```
/// use decy_hir::{HirConstant, HirType, HirExpression};
///
/// let constant = HirConstant::new(
///     "MAX".to_string(),
///     HirType::Int,
///     HirExpression::IntLiteral(100),
/// );
/// assert_eq!(constant.name(), "MAX");
/// assert_eq!(constant.const_type(), &HirType::Int);
/// ```
#[derive(Debug, Clone, PartialEq)]
pub struct HirConstant {
    name: String,
    const_type: HirType,
    value: HirExpression,
}

impl HirConstant {
    /// Create a new constant.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::{HirConstant, HirType, HirExpression};
    ///
    /// let constant = HirConstant::new(
    ///     "PI".to_string(),
    ///     HirType::Float,
    ///     HirExpression::IntLiteral(3), // Simplified for example
    /// );
    /// assert_eq!(constant.name(), "PI");
    /// ```
    pub fn new(name: String, const_type: HirType, value: HirExpression) -> Self {
        Self {
            name,
            const_type,
            value,
        }
    }

    /// Get the constant name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the constant type.
    pub fn const_type(&self) -> &HirType {
        &self.const_type
    }

    /// Get the constant value expression.
    pub fn value(&self) -> &HirExpression {
        &self.value
    }
}

/// Represents a C macro definition in HIR.
///
/// C macros come in two forms:
/// - Object-like: `#define MAX 100` (simple text substitution)
/// - Function-like: `#define SQR(x) ((x) * (x))` (macro with parameters)
///
/// In Rust, these typically become:
/// - Object-like → `const` declarations
/// - Function-like → `fn` (inline functions) or `macro_rules!` (if truly necessary)
///
/// # Examples
///
/// ```
/// use decy_hir::{HirMacroDefinition, HirType, HirExpression};
///
/// // Object-like macro: #define MAX 100
/// let macro_def = HirMacroDefinition::new_object_like(
///     "MAX".to_string(),
///     "100".to_string(),
/// );
/// assert_eq!(macro_def.name(), "MAX");
/// assert!(!macro_def.is_function_like());
///
/// // Function-like macro: #define SQR(x) ((x) * (x))
/// let macro_def2 = HirMacroDefinition::new_function_like(
///     "SQR".to_string(),
///     vec!["x".to_string()],
///     "((x) * (x))".to_string(),
/// );
/// assert_eq!(macro_def2.name(), "SQR");
/// assert!(macro_def2.is_function_like());
/// assert_eq!(macro_def2.parameters(), &["x"]);
/// ```
///
/// Reference: K&R §4.11, ISO C99 §6.10.3
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirMacroDefinition {
    /// Macro name (e.g., "MAX", "SQR")
    name: String,
    /// Parameters for function-like macros (empty for object-like macros)
    parameters: Vec<String>,
    /// Macro body as a token string (unparsed)
    /// This will be expanded during codegen
    body: String,
}

impl HirMacroDefinition {
    /// Create a new object-like macro (no parameters).
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::HirMacroDefinition;
    ///
    /// // #define MAX 100
    /// let macro_def = HirMacroDefinition::new_object_like(
    ///     "MAX".to_string(),
    ///     "100".to_string(),
    /// );
    /// assert_eq!(macro_def.name(), "MAX");
    /// assert!(!macro_def.is_function_like());
    /// ```
    pub fn new_object_like(name: String, body: String) -> Self {
        Self {
            name,
            parameters: vec![],
            body,
        }
    }

    /// Create a new function-like macro (with parameters).
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::HirMacroDefinition;
    ///
    /// // #define SQR(x) ((x) * (x))
    /// let macro_def = HirMacroDefinition::new_function_like(
    ///     "SQR".to_string(),
    ///     vec!["x".to_string()],
    ///     "((x) * (x))".to_string(),
    /// );
    /// assert_eq!(macro_def.name(), "SQR");
    /// assert!(macro_def.is_function_like());
    /// assert_eq!(macro_def.parameters(), &["x"]);
    /// ```
    pub fn new_function_like(name: String, parameters: Vec<String>, body: String) -> Self {
        Self {
            name,
            parameters,
            body,
        }
    }

    /// Get the macro name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the macro parameters (empty for object-like macros).
    pub fn parameters(&self) -> &[String] {
        &self.parameters
    }

    /// Get the macro body (unparsed token string).
    pub fn body(&self) -> &str {
        &self.body
    }

    /// Check if this is a function-like macro (has parameters).
    pub fn is_function_like(&self) -> bool {
        !self.parameters.is_empty()
    }

    /// Check if this is an object-like macro (no parameters).
    pub fn is_object_like(&self) -> bool {
        self.parameters.is_empty()
    }
}

/// Represents a function parameter in HIR.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HirParameter {
    name: String,
    param_type: HirType,
    /// DECY-135: Whether the pointee type is const (for pointer params like `const char*`)
    is_pointee_const: bool,
}

impl HirParameter {
    /// Create a new HIR parameter.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::{HirParameter, HirType};
    ///
    /// let param = HirParameter::new("x".to_string(), HirType::Int);
    /// assert_eq!(param.name(), "x");
    /// ```
    pub fn new(name: String, param_type: HirType) -> Self {
        Self {
            name,
            param_type,
            is_pointee_const: false,
        }
    }

    /// Get the parameter name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the parameter type.
    pub fn param_type(&self) -> &HirType {
        &self.param_type
    }

    /// DECY-135: Check if this parameter has a const-qualified pointee.
    pub fn is_pointee_const(&self) -> bool {
        self.is_pointee_const
    }

    /// DECY-135: Check if this is a const char* parameter (should become &str).
    pub fn is_const_char_pointer(&self) -> bool {
        self.is_pointee_const
            && matches!(self.param_type, HirType::Pointer(ref inner) if **inner == HirType::Char)
    }

    /// Convert from parser AST parameter to HIR parameter.
    pub fn from_ast_parameter(ast_param: &decy_parser::parser::Parameter) -> Self {
        Self {
            name: ast_param.name.clone(),
            param_type: HirType::from_ast_type(&ast_param.param_type),
            is_pointee_const: ast_param.is_pointee_const,
        }
    }

    /// DECY-135: Create a new parameter with a transformed type but preserving is_pointee_const.
    /// Use this when transforming parameter types (e.g., pointer to reference) to maintain
    /// const char* → &str transformation capability.
    pub fn with_type(&self, new_type: HirType) -> Self {
        Self {
            name: self.name.clone(),
            param_type: new_type,
            is_pointee_const: self.is_pointee_const,
        }
    }
}

/// Represents a function in HIR.
#[derive(Debug, Clone, PartialEq)]
pub struct HirFunction {
    name: String,
    return_type: HirType,
    parameters: Vec<HirParameter>,
    body: Option<Vec<HirStatement>>,
}

impl HirFunction {
    /// Create a new HIR function.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::{HirFunction, HirType, HirParameter};
    ///
    /// let func = HirFunction::new(
    ///     "add".to_string(),
    ///     HirType::Int,
    ///     vec![
    ///         HirParameter::new("a".to_string(), HirType::Int),
    ///         HirParameter::new("b".to_string(), HirType::Int),
    ///     ],
    /// );
    ///
    /// assert_eq!(func.name(), "add");
    /// assert_eq!(func.parameters().len(), 2);
    /// ```
    pub fn new(name: String, return_type: HirType, parameters: Vec<HirParameter>) -> Self {
        Self {
            name,
            return_type,
            parameters,
            body: None,
        }
    }

    /// Get the function name.
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the return type.
    pub fn return_type(&self) -> &HirType {
        &self.return_type
    }

    /// Get the parameters.
    pub fn parameters(&self) -> &[HirParameter] {
        &self.parameters
    }

    /// Convert from parser AST function to HIR function.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::HirFunction;
    /// use decy_parser::parser::{Function, Type, Parameter};
    ///
    /// let ast_func = Function::new(
    ///     "test".to_string(),
    ///     Type::Void,
    ///     vec![],
    /// );
    ///
    /// let hir_func = HirFunction::from_ast_function(&ast_func);
    /// assert_eq!(hir_func.name(), "test");
    /// ```
    pub fn from_ast_function(ast_func: &decy_parser::parser::Function) -> Self {
        let body = if ast_func.body.is_empty() {
            None
        } else {
            Some(
                ast_func
                    .body
                    .iter()
                    .map(HirStatement::from_ast_statement)
                    .collect(),
            )
        };

        Self {
            name: ast_func.name.clone(),
            return_type: HirType::from_ast_type(&ast_func.return_type),
            parameters: ast_func
                .parameters
                .iter()
                .map(HirParameter::from_ast_parameter)
                .collect(),
            body,
        }
    }

    /// Create a new HIR function with a body.
    ///
    /// # Examples
    ///
    /// ```
    /// use decy_hir::{HirFunction, HirType, HirStatement, HirExpression};
    ///
    /// let func = HirFunction::new_with_body(
    ///     "test".to_string(),
    ///     HirType::Int,
    ///     vec![],
    ///     vec![
    ///         HirStatement::VariableDeclaration {
    ///             name: "x".to_string(),
    ///             var_type: HirType::Int,
    ///             initializer: Some(HirExpression::IntLiteral(5)),
    ///         },
    ///         HirStatement::Return(Some(HirExpression::Variable("x".to_string()))),
    ///     ],
    /// );
    ///
    /// assert_eq!(func.name(), "test");
    /// assert_eq!(func.body().len(), 2);
    /// ```
    pub fn new_with_body(
        name: String,
        return_type: HirType,
        parameters: Vec<HirParameter>,
        body: Vec<HirStatement>,
    ) -> Self {
        Self {
            name,
            return_type,
            parameters,
            body: Some(body),
        }
    }

    /// Get the function body.
    pub fn body(&self) -> &[HirStatement] {
        self.body.as_deref().unwrap_or(&[])
    }

    /// DECY-190: Check if this function has a body (is a definition, not just a declaration).
    /// Returns true for definitions, false for forward declarations/prototypes.
    pub fn has_body(&self) -> bool {
        self.body.is_some()
    }
}

/// Unary operators for expressions.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum UnaryOperator {
    /// Unary minus (-x)
    Minus,
    /// Logical NOT (!x)
    LogicalNot,
    /// Bitwise NOT (~x)
    BitwiseNot,
    /// Address-of (&x)
    AddressOf,
    /// Post-increment (x++)
    /// Returns old value, then increments
    /// Reference: ISO C99 §6.5.2.4, K&R §2.8
    PostIncrement,
    /// Post-decrement (x--)
    /// Returns old value, then decrements
    /// Reference: ISO C99 §6.5.2.4, K&R §2.8
    PostDecrement,
    /// Pre-increment (++x)
    /// Increments first, then returns new value
    /// Reference: ISO C99 §6.5.3.1, K&R §2.8
    PreIncrement,
    /// Pre-decrement (--x)
    /// Decrements first, then returns new value
    /// Reference: ISO C99 §6.5.3.1, K&R §2.8
    PreDecrement,
}

/// Binary operators for expressions.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum BinaryOperator {
    /// Addition (+)
    Add,
    /// Subtraction (-)
    Subtract,
    /// Multiplication (*)
    Multiply,
    /// Division (/)
    Divide,
    /// Modulo (%)
    Modulo,
    /// Equality (==)
    Equal,
    /// Inequality (!=)
    NotEqual,
    /// Less than (<)
    LessThan,
    /// Greater than (>)
    GreaterThan,
    /// Less than or equal (<=)
    LessEqual,
    /// Greater than or equal (>=)
    GreaterEqual,
    /// Logical AND (&&)
    LogicalAnd,
    /// Logical OR (||)
    LogicalOr,
    /// Left shift (<<)
    LeftShift,
    /// Right shift (>>)
    RightShift,
    /// Bitwise AND (&)
    BitwiseAnd,
    /// Bitwise OR (|)
    BitwiseOr,
    /// Bitwise XOR (^)
    BitwiseXor,
    /// Assignment (=) - for embedded assignments like (c=getchar())
    Assign,
    /// Comma operator (,) - DECY-224: for multi-expression statements
    Comma,
}

/// Represents an expression in HIR.
#[derive(Debug, Clone, PartialEq)]
pub enum HirExpression {
    /// Integer literal
    IntLiteral(i32),
    /// Float literal (stored as string to preserve precision)
    FloatLiteral(String),
    /// String literal (C: "hello" → Rust: "hello")
    StringLiteral(String),
    /// Character literal (C: 'a', '\0', '\n' → Rust: b'a', 0, b'\n')
    CharLiteral(i8),
    /// Variable reference
    Variable(String),
    /// Binary operation (left op right)
    BinaryOp {
        /// The operator
        op: BinaryOperator,
        /// Left operand
        left: Box<HirExpression>,
        /// Right operand
        right: Box<HirExpression>,
    },
    /// Dereference operation (*ptr)
    Dereference(Box<HirExpression>),
    /// Address-of operation (&x)
    AddressOf(Box<HirExpression>),
    /// Unary operation (-x, !x)
    UnaryOp {
        /// The operator
        op: UnaryOperator,
        /// Operand
        operand: Box<HirExpression>,
    },
    /// Post-increment expression (x++)
    /// C semantics: returns old value, then increments
    /// Rust: { let tmp = x; x += 1; tmp }
    PostIncrement {
        /// The operand to increment
        operand: Box<HirExpression>,
    },
    /// Pre-increment expression (++x)
    /// C semantics: increments first, then returns new value
    /// Rust: { x += 1; x }
    PreIncrement {
        /// The operand to increment
        operand: Box<HirExpression>,
    },
    /// Post-decrement expression (x--)
    /// C semantics: returns old value, then decrements
    /// Rust: { let tmp = x; x -= 1; tmp }
    PostDecrement {
        /// The operand to decrement
        operand: Box<HirExpression>,
    },
    /// Pre-decrement expression (--x)
    /// C semantics: decrements first, then returns new value
    /// Rust: { x -= 1; x }
    PreDecrement {
        /// The operand to decrement
        operand: Box<HirExpression>,
    },
    /// Function call (function_name(args...))
    FunctionCall {
        /// Function name
        function: String,
        /// Arguments
        arguments: Vec<HirExpression>,
    },
    /// Field access (obj.field)
    FieldAccess {
        /// Object expression
        object: Box<HirExpression>,
        /// Field name
        field: String,
    },
    /// Pointer field access (ptr->field)
    PointerFieldAccess {
        /// Pointer expression
        pointer: Box<HirExpression>,
        /// Field name
        field: String,
    },
    /// Array indexing
    ArrayIndex {
        /// Array expression
        array: Box<HirExpression>,
        /// Index expression
        index: Box<HirExpression>,
    },
    /// Safe slice indexing (DECY-069)
    /// Represents safe, bounds-checked array access: `arr[index]`
    /// Generated when pointer arithmetic can be transformed to safe indexing.
    /// Unlike ArrayIndex (which may use unsafe), SliceIndex guarantees zero unsafe blocks.
    SliceIndex {
        /// Slice/array expression
        slice: Box<HirExpression>,
        /// Index expression
        index: Box<HirExpression>,
        /// Element type (for codegen type inference)
        element_type: HirType,
    },
    /// Sizeof expression (sizeof(T) → `std::mem::size_of::<T>()`)
    Sizeof {
        /// Type name as a string (e.g., "int", "struct Data")
        type_name: String,
    },
    /// NULL literal (NULL → None)
    NullLiteral,
    /// NULL check expression (p != NULL → is_some(), p == NULL → is_none())
    IsNotNull(Box<HirExpression>),
    /// calloc(count, sizeof(T)) → vec![0; count]
    Calloc {
        /// Number of elements to allocate
        count: Box<HirExpression>,
        /// Element type
        element_type: Box<HirType>,
    },
    /// malloc(size) → Box::new(default) or Vec::with_capacity(n)
    Malloc {
        /// Size expression (typically sizeof(T) or n * sizeof(T))
        size: Box<HirExpression>,
    },
    /// realloc(ptr, new_size) → Vec::resize or Vec::reserve
    Realloc {
        /// Pointer to reallocate
        pointer: Box<HirExpression>,
        /// New size expression (typically n * sizeof(T))
        new_size: Box<HirExpression>,
    },
    /// String method call (e.g., s.len(), s.to_string(), s.clone_into(&mut dst))
    StringMethodCall {
        /// Receiver expression (e.g., s in s.len())
        receiver: Box<HirExpression>,
        /// Method name (e.g., "len", "to_string", "clone_into")
        method: String,
        /// Arguments to the method call
        arguments: Vec<HirExpression>,
    },
    /// Cast expression (C: (int)x → Rust: x as i32)
    ///
    /// Represents a C-style cast that converts an expression to a target type.
    /// Maps to Rust `as` operator for safe casts, or `transmute` for unsafe casts.
    ///
    /// # Sprint 19 Feature (DECY-059)
    ///
    /// Added in Sprint 19 to support C cast expressions.
    Cast {
        /// Target type to cast to
        target_type: HirType,
        /// Expression being cast
        expr: Box<HirExpression>,
    },
    /// Compound literal (C: (struct Point){10, 20} → Rust: Point { x: 10, y: 20 })
    ///
    /// C99 compound literals create anonymous objects of a specified type.
    /// Used for inline struct/array initialization.
    ///
    /// # Sprint 19 Feature (DECY-060)
    ///
    /// Added in Sprint 19 to support C99 compound literals.
    CompoundLiteral {
        /// Type of the compound literal (struct Point, int[], etc.)
        literal_type: HirType,
        /// Initializer expressions (values for struct fields or array elements)
        initializers: Vec<HirExpression>,
    },
    /// Ternary/Conditional expression (C: cond ? then_val : else_val)
    ///
    /// The C ternary operator evaluates the condition and returns either
    /// the then_val or else_val based on whether condition is truthy.
    ///
    /// Maps to Rust's `if cond { then_val } else { else_val }` expression.
    ///
    /// # DECY-192
    ///
    /// Added to support K&R Chapter 2.11 Conditional Expressions.
    Ternary {
        /// Condition expression (evaluated as boolean)
        condition: Box<HirExpression>,
        /// Value if condition is true
        then_expr: Box<HirExpression>,
        /// Value if condition is false
        else_expr: Box<HirExpression>,
    },
}

/// Represents a single case in a switch statement.
#[derive(Debug, Clone, PartialEq)]
pub struct SwitchCase {
    /// Case value expression (None for default case)
    pub value: Option<HirExpression>,
    /// Statements to execute for this case
    pub body: Vec<HirStatement>,
}

/// Represents a statement in HIR.
#[derive(Debug, Clone, PartialEq)]
pub enum HirStatement {
    /// Variable declaration with optional initializer
    VariableDeclaration {
        /// Variable name
        name: String,
        /// Variable type
        var_type: HirType,
        /// Optional initializer expression
        initializer: Option<HirExpression>,
    },
    /// Return statement with optional value
    Return(Option<HirExpression>),
    /// If statement with condition, then-block, and optional else-block
    If {
        /// Condition expression
        condition: HirExpression,
        /// Then block (statements to execute if condition is true)
        then_block: Vec<HirStatement>,
        /// Else block (optional statements to execute if condition is false)
        else_block: Option<Vec<HirStatement>>,
    },
    /// While loop with condition and body
    While {
        /// Loop condition
        condition: HirExpression,
        /// Loop body (statements to execute while condition is true)
        body: Vec<HirStatement>,
    },
    /// Break statement (exit loop)
    Break,
    /// Continue statement (skip to next iteration)
    Continue,
    /// Assignment statement (target = value)
    Assignment {
        /// Target variable name
        target: String,
        /// Value expression to assign
        value: HirExpression,
    },
    /// For loop with optional init, condition, optional increment, and body
    For {
        /// Initialization statements (e.g., int i = 0, j = 10) - DECY-224
        init: Vec<HirStatement>,
        /// Loop condition expression (None = infinite loop, e.g. `for(;;)`)
        condition: Option<HirExpression>,
        /// Increment statements (e.g., i++, j--) - DECY-224
        increment: Vec<HirStatement>,
        /// Loop body (statements to execute while condition is true)
        body: Vec<HirStatement>,
    },
    /// Switch statement with condition, cases, and optional default case
    Switch {
        /// Condition expression to match against
        condition: HirExpression,
        /// List of case statements
        cases: Vec<SwitchCase>,
        /// Optional default case body
        default_case: Option<Vec<HirStatement>>,
    },
    /// Pointer dereference assignment (*ptr = value)
    DerefAssignment {
        /// Target expression to dereference
        target: HirExpression,
        /// Value expression to assign
        value: HirExpression,
    },
    /// Array index assignment
    ArrayIndexAssignment {
        /// Array expression
        array: Box<HirExpression>,
        /// Index expression
        index: Box<HirExpression>,
        /// Value expression to assign
        value: HirExpression,
    },
    /// Field assignment (ptr->field = value or obj.field = value)
    FieldAssignment {
        /// Object/pointer expression
        object: HirExpression,
        /// Field name
        field: String,
        /// Value expression to assign
        value: HirExpression,
    },
    /// Free statement (free(ptr) → automatic drop via RAII)
    Free {
        /// Pointer expression to free
        pointer: HirExpression,
    },
    /// Expression statement (e.g., printf("Hello");, free(ptr);, i++;)
    ///
    /// Represents an expression used as a statement, typically for side effects.
    /// Common in C for function calls whose return values are discarded.
    ///
    /// # DECY-065
    ///
    /// Added to fix bug where function call statements (like printf) were being
    /// converted to Break placeholder, causing them to disappear during transpilation.
    Expression(HirExpression),
    /// Inline assembly statement (C: asm("...") or __asm__("..."))
    ///
    /// C inline assembly cannot be automatically transpiled to safe Rust.
    /// This variant preserves the assembly text for manual review.
    ///
    /// # DECY-197
    ///
    /// Added to handle inline assembly in C code. The codegen emits a
    /// review-required comment rather than attempting automatic translation.
    InlineAsm {
        /// The raw assembly text from the C source
        text: String,
        /// Whether the assembly might be translatable to Rust intrinsics
        translatable: bool,
    },
}

impl HirStatement {
    /// Convert from parser AST statement to HIR statement.
    pub fn from_ast_statement(ast_stmt: &decy_parser::parser::Statement) -> Self {
        use decy_parser::parser::Statement;
        match ast_stmt {
            Statement::VariableDeclaration {
                name,
                var_type,
                initializer,
            } => HirStatement::VariableDeclaration {
                name: name.clone(),
                var_type: HirType::from_ast_type(var_type),
                initializer: initializer.as_ref().map(HirExpression::from_ast_expression),
            },
            Statement::Return(expr) => {
                HirStatement::Return(expr.as_ref().map(HirExpression::from_ast_expression))
            }
            Statement::Assignment { target, value } => HirStatement::Assignment {
                target: target.clone(),
                value: HirExpression::from_ast_expression(value),
            },
            Statement::If {
                condition,
                then_block,
                else_block,
            } => HirStatement::If {
                condition: HirExpression::from_ast_expression(condition),
                then_block: then_block
                    .iter()
                    .map(HirStatement::from_ast_statement)
                    .collect(),
                else_block: else_block
                    .as_ref()
                    .map(|block| block.iter().map(HirStatement::from_ast_statement).collect()),
            },
            Statement::For {
                init,
                condition,
                increment,
                body,
            } => HirStatement::For {
                // DECY-224: Support multiple init statements
                init: init.iter().map(HirStatement::from_ast_statement).collect(),
                condition: condition
                    .as_ref()
                    .map(HirExpression::from_ast_expression),
                // DECY-224: Support multiple increment statements
                increment: increment
                    .iter()
                    .map(HirStatement::from_ast_statement)
                    .collect(),
                body: body.iter().map(HirStatement::from_ast_statement).collect(),
            },
            Statement::While { condition, body } => HirStatement::While {
                condition: HirExpression::from_ast_expression(condition),
                body: body.iter().map(HirStatement::from_ast_statement).collect(),
            },
            Statement::DerefAssignment { target, value } => HirStatement::DerefAssignment {
                target: HirExpression::from_ast_expression(target),
                value: HirExpression::from_ast_expression(value),
            },
            Statement::ArrayIndexAssignment {
                array,
                index,
                value,
            } => HirStatement::ArrayIndexAssignment {
                array: Box::new(HirExpression::from_ast_expression(array)),
                index: Box::new(HirExpression::from_ast_expression(index)),
                value: HirExpression::from_ast_expression(value),
            },
            Statement::FieldAssignment {
                object,
                field,
                value,
            } => HirStatement::FieldAssignment {
                object: HirExpression::from_ast_expression(object),
                field: field.clone(),
                value: HirExpression::from_ast_expression(value),
            },
            Statement::Break => HirStatement::Break,
            Statement::Continue => HirStatement::Continue,
            // Increment/decrement statements are converted to assignments
            // ptr++ becomes ptr = ptr + 1
            Statement::PostIncrement { target } | Statement::PreIncrement { target } => {
                HirStatement::Assignment {
                    target: target.clone(),
                    value: HirExpression::BinaryOp {
                        op: BinaryOperator::Add,
                        left: Box::new(HirExpression::Variable(target.clone())),
                        right: Box::new(HirExpression::IntLiteral(1)),
                    },
                }
            }
            // ptr-- becomes ptr = ptr - 1
            Statement::PostDecrement { target } | Statement::PreDecrement { target } => {
                HirStatement::Assignment {
                    target: target.clone(),
                    value: HirExpression::BinaryOp {
                        op: BinaryOperator::Subtract,
                        left: Box::new(HirExpression::Variable(target.clone())),
                        right: Box::new(HirExpression::IntLiteral(1)),
                    },
                }
            }
            // Compound assignments like ptr += offset become ptr = ptr + offset
            Statement::CompoundAssignment { target, op, value } => HirStatement::Assignment {
                target: target.clone(),
                value: HirExpression::BinaryOp {
                    op: convert_binary_operator(*op),
                    left: Box::new(HirExpression::Variable(target.clone())),
                    right: Box::new(HirExpression::from_ast_expression(value)),
                },
            },
            // DECY-185: Compound assignments to complex targets like *ptr *= 2, sb->capacity *= 2
            // These become DerefAssignment with a BinaryOp value
            Statement::DerefCompoundAssignment { target, op, value } => {
                let hir_target = HirExpression::from_ast_expression(target);
                HirStatement::DerefAssignment {
                    target: hir_target.clone(),
                    value: HirExpression::BinaryOp {
                        op: convert_binary_operator(*op),
                        left: Box::new(hir_target),
                        right: Box::new(HirExpression::from_ast_expression(value)),
                    },
                }
            }
            // Switch statement - convert cases and default
            Statement::Switch {
                condition,
                cases,
                default_case,
            } => HirStatement::Switch {
                condition: HirExpression::from_ast_expression(condition),
                cases: cases
                    .iter()
                    .map(|case| SwitchCase {
                        value: case.value.as_ref().map(HirExpression::from_ast_expression),
                        body: case
                            .body
                            .iter()
                            .map(HirStatement::from_ast_statement)
                            .collect(),
                    })
                    .collect(),
                default_case: default_case
                    .as_ref()
                    .map(|block| block.iter().map(HirStatement::from_ast_statement).collect()),
            },
            // Function call statement - convert to expression statement
            // DECY-065: Now properly supported with HirStatement::Expression variant
            Statement::FunctionCall {
                function,
                arguments,
            } => HirStatement::Expression(HirExpression::FunctionCall {
                function: function.clone(),
                arguments: arguments
                    .iter()
                    .map(HirExpression::from_ast_expression)
                    .collect(),
            }),
        }
    }
}

impl HirExpression {
    /// Convert from parser AST expression to HIR expression.
    pub fn from_ast_expression(ast_expr: &decy_parser::parser::Expression) -> Self {
        use decy_parser::parser::Expression;
        match ast_expr {
            Expression::IntLiteral(value) => HirExpression::IntLiteral(*value),
            Expression::FloatLiteral(value) => HirExpression::FloatLiteral(value.clone()),
            Expression::StringLiteral(value) => HirExpression::StringLiteral(value.clone()),
            Expression::CharLiteral(value) => HirExpression::CharLiteral(*value),
            Expression::Variable(name) => HirExpression::Variable(name.clone()),
            Expression::BinaryOp { op, left, right } => HirExpression::BinaryOp {
                op: convert_binary_operator(*op),
                left: Box::new(HirExpression::from_ast_expression(left)),
                right: Box::new(HirExpression::from_ast_expression(right)),
            },
            Expression::FunctionCall {
                function,
                arguments,
            } => HirExpression::FunctionCall {
                function: function.clone(),
                arguments: arguments
                    .iter()
                    .map(HirExpression::from_ast_expression)
                    .collect(),
            },
            Expression::Dereference(inner) => {
                HirExpression::Dereference(Box::new(HirExpression::from_ast_expression(inner)))
            }
            Expression::UnaryOp { op, operand } => HirExpression::UnaryOp {
                op: convert_unary_operator(*op),
                operand: Box::new(HirExpression::from_ast_expression(operand)),
            },
            Expression::ArrayIndex { array, index } => HirExpression::ArrayIndex {
                array: Box::new(HirExpression::from_ast_expression(array)),
                index: Box::new(HirExpression::from_ast_expression(index)),
            },
            Expression::FieldAccess { object, field } => HirExpression::FieldAccess {
                object: Box::new(HirExpression::from_ast_expression(object)),
                field: field.clone(),
            },
            Expression::PointerFieldAccess { pointer, field } => {
                HirExpression::PointerFieldAccess {
                    pointer: Box::new(HirExpression::from_ast_expression(pointer)),
                    field: field.clone(),
                }
            }
            // DECY-139: Increment/decrement expressions in expression context
            // Properly preserve the increment/decrement for codegen to emit correct Rust
            Expression::PostIncrement { operand } => HirExpression::PostIncrement {
                operand: Box::new(HirExpression::from_ast_expression(operand)),
            },
            Expression::PreIncrement { operand } => HirExpression::PreIncrement {
                operand: Box::new(HirExpression::from_ast_expression(operand)),
            },
            Expression::PostDecrement { operand } => HirExpression::PostDecrement {
                operand: Box::new(HirExpression::from_ast_expression(operand)),
            },
            Expression::PreDecrement { operand } => HirExpression::PreDecrement {
                operand: Box::new(HirExpression::from_ast_expression(operand)),
            },
            Expression::Sizeof { type_name } => HirExpression::Sizeof {
                type_name: type_name.clone(),
            },
            Expression::Cast { target_type, expr } => HirExpression::Cast {
                target_type: HirType::from_ast_type(target_type),
                expr: Box::new(HirExpression::from_ast_expression(expr)),
            },
            Expression::CompoundLiteral {
                literal_type,
                initializers,
            } => HirExpression::CompoundLiteral {
                literal_type: HirType::from_ast_type(literal_type),
                initializers: initializers
                    .iter()
                    .map(HirExpression::from_ast_expression)
                    .collect(),
            },
            // DECY-192: Ternary/conditional expression
            Expression::Ternary {
                condition,
                then_expr,
                else_expr,
            } => HirExpression::Ternary {
                condition: Box::new(HirExpression::from_ast_expression(condition)),
                then_expr: Box::new(HirExpression::from_ast_expression(then_expr)),
                else_expr: Box::new(HirExpression::from_ast_expression(else_expr)),
            },
        }
    }
}

/// Convert parser UnaryOperator to HIR UnaryOperator
fn convert_unary_operator(op: decy_parser::parser::UnaryOperator) -> UnaryOperator {
    use decy_parser::parser::UnaryOperator as ParserOp;
    match op {
        ParserOp::Minus => UnaryOperator::Minus,
        ParserOp::LogicalNot => UnaryOperator::LogicalNot,
        ParserOp::BitwiseNot => UnaryOperator::BitwiseNot,
        ParserOp::AddressOf => UnaryOperator::AddressOf,
    }
}

/// Convert parser BinaryOperator to HIR BinaryOperator
fn convert_binary_operator(op: decy_parser::parser::BinaryOperator) -> BinaryOperator {
    use decy_parser::parser::BinaryOperator as ParserOp;
    match op {
        ParserOp::Add => BinaryOperator::Add,
        ParserOp::Subtract => BinaryOperator::Subtract,
        ParserOp::Multiply => BinaryOperator::Multiply,
        ParserOp::Divide => BinaryOperator::Divide,
        ParserOp::Modulo => BinaryOperator::Modulo,
        ParserOp::Equal => BinaryOperator::Equal,
        ParserOp::NotEqual => BinaryOperator::NotEqual,
        ParserOp::LessThan => BinaryOperator::LessThan,
        ParserOp::GreaterThan => BinaryOperator::GreaterThan,
        ParserOp::LessEqual => BinaryOperator::LessEqual,
        ParserOp::GreaterEqual => BinaryOperator::GreaterEqual,
        ParserOp::LogicalAnd => BinaryOperator::LogicalAnd,
        ParserOp::LogicalOr => BinaryOperator::LogicalOr,
        // DECY-137: Bitwise and shift operators
        ParserOp::LeftShift => BinaryOperator::LeftShift,
        ParserOp::RightShift => BinaryOperator::RightShift,
        ParserOp::BitwiseAnd => BinaryOperator::BitwiseAnd,
        ParserOp::BitwiseOr => BinaryOperator::BitwiseOr,
        ParserOp::BitwiseXor => BinaryOperator::BitwiseXor,
        // DECY-195: Assignment operator for embedded assignments
        ParserOp::Assign => BinaryOperator::Assign,
        // DECY-224: Comma operator for multi-expression statements
        ParserOp::Comma => BinaryOperator::Comma,
    }
}

#[cfg(test)]
#[path = "hir_tests.rs"]
mod hir_tests;

#[cfg(test)]
#[path = "property_tests.rs"]
mod property_tests;

#[cfg(test)]
#[path = "statement_tests.rs"]
mod statement_tests;

#[cfg(test)]
#[path = "struct_tests.rs"]
mod struct_tests;

#[cfg(test)]
#[path = "array_indexing_tests.rs"]
mod array_indexing_tests;

#[cfg(test)]
#[path = "slice_index_tests.rs"]
mod slice_index_tests; // DECY-069

#[cfg(test)]
#[path = "for_loop_tests.rs"]
mod for_loop_tests;

#[cfg(test)]
#[path = "typedef_tests.rs"]
mod typedef_tests;

#[cfg(test)]
#[path = "typedef_property_tests.rs"]
mod typedef_property_tests;

#[cfg(test)]
#[path = "function_pointer_tests.rs"]
mod function_pointer_tests;

#[cfg(test)]
#[path = "string_tests.rs"]
mod string_tests;

#[cfg(test)]
#[path = "string_property_tests.rs"]
mod string_property_tests;

#[cfg(test)]
#[path = "switch_tests.rs"]
mod switch_tests;

#[cfg(test)]
#[path = "macro_definition_tests.rs"]
mod macro_definition_tests;

#[cfg(test)]
#[path = "coverage_tests.rs"]
mod coverage_tests;