1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
// Copyright (C) 2021 Alibaba Cloud. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

//! Physical address space manager for virtual machines.

use std::sync::Arc;

use arc_swap::ArcSwap;
use vm_memory::{GuestAddress, GuestMemoryMmap};

use crate::{AddressSpaceError, AddressSpaceLayout, AddressSpaceRegion, AddressSpaceRegionType};

/// Base implementation to manage guest physical address space, without support of region hotplug.
#[derive(Clone)]
pub struct AddressSpaceBase {
    regions: Vec<Arc<AddressSpaceRegion>>,
    layout: AddressSpaceLayout,
}

impl AddressSpaceBase {
    /// Create an instance of `AddressSpaceBase` from an `AddressSpaceRegion` array.
    ///
    /// To achieve better performance by using binary search algorithm, the `regions` vector
    /// will gotten sorted by guest physical address.
    ///
    /// Note, panicking if some regions intersects with each other.
    ///
    /// # Arguments
    /// * `regions` - prepared regions to managed by the address space instance.
    /// * `layout` - prepared address space layout configuration.
    pub fn from_regions(
        mut regions: Vec<Arc<AddressSpaceRegion>>,
        layout: AddressSpaceLayout,
    ) -> Self {
        regions.sort_unstable_by_key(|v| v.base);
        for region in regions.iter() {
            if !layout.is_region_valid(region) {
                panic!(
                    "Invalid region {:?} for address space layout {:?}",
                    region, layout
                );
            }
        }
        for idx in 1..regions.len() {
            if regions[idx].intersect_with(&regions[idx - 1]) {
                panic!("address space regions intersect with each other");
            }
        }
        AddressSpaceBase { regions, layout }
    }

    /// Insert a new address space region into the address space.
    ///
    /// # Arguments
    /// * `region` - the new region to be inserted.
    pub fn insert_region(
        &mut self,
        region: Arc<AddressSpaceRegion>,
    ) -> Result<(), AddressSpaceError> {
        if !self.layout.is_region_valid(&region) {
            return Err(AddressSpaceError::InvalidAddressRange(
                region.start_addr().0,
                region.len(),
            ));
        }
        for idx in 0..self.regions.len() {
            if self.regions[idx].intersect_with(&region) {
                return Err(AddressSpaceError::InvalidAddressRange(
                    region.start_addr().0,
                    region.len(),
                ));
            }
        }
        self.regions.push(region);
        Ok(())
    }

    /// Enumerate all regions in the address space.
    ///
    /// # Arguments
    /// * `cb` - the callback function to apply to each region.
    pub fn walk_regions<F>(&self, mut cb: F) -> Result<(), AddressSpaceError>
    where
        F: FnMut(&Arc<AddressSpaceRegion>) -> Result<(), AddressSpaceError>,
    {
        for reg in self.regions.iter() {
            cb(reg)?;
        }

        Ok(())
    }

    /// Get address space layout associated with the address space.
    pub fn layout(&self) -> AddressSpaceLayout {
        self.layout.clone()
    }

    /// Get maximum of guest physical address in the address space.
    pub fn last_addr(&self) -> GuestAddress {
        let mut last_addr = GuestAddress(self.layout.mem_start);
        for reg in self.regions.iter() {
            if reg.ty != AddressSpaceRegionType::DAXMemory && reg.last_addr() > last_addr {
                last_addr = reg.last_addr();
            }
        }
        last_addr
    }

    /// Check whether the guest physical address `guest_addr` belongs to a DAX memory region.
    ///
    /// # Arguments
    /// * `guest_addr` - the guest physical address to inquire
    pub fn is_dax_region(&self, guest_addr: GuestAddress) -> bool {
        for reg in self.regions.iter() {
            // Safe because we have validate the region when creating the address space object.
            if reg.region_type() == AddressSpaceRegionType::DAXMemory
                && reg.start_addr() <= guest_addr
                && reg.start_addr().0 + reg.len() > guest_addr.0
            {
                return true;
            }
        }
        false
    }

    /// Get optional NUMA node id associated with guest physical address `gpa`.
    ///
    /// # Arguments
    /// * `gpa` - guest physical address to query.
    pub fn numa_node_id(&self, gpa: u64) -> Option<u32> {
        for reg in self.regions.iter() {
            if gpa >= reg.base.0 && gpa < (reg.base.0 + reg.size) {
                return reg.host_numa_node_id;
            }
        }
        None
    }
}

/// An address space implementation with region hotplug capability.
///
/// The `AddressSpace` is a wrapper over [AddressSpaceBase] to support hotplug of
/// address space regions.
#[derive(Clone)]
pub struct AddressSpace {
    state: Arc<ArcSwap<AddressSpaceBase>>,
}

impl AddressSpace {
    /// Convert a [GuestMemoryMmap] object into `GuestMemoryAtomic<GuestMemoryMmap>`.
    pub fn convert_into_vm_as(
        gm: GuestMemoryMmap,
    ) -> vm_memory::atomic::GuestMemoryAtomic<GuestMemoryMmap> {
        vm_memory::atomic::GuestMemoryAtomic::from(Arc::new(gm))
    }

    /// Create an instance of `AddressSpace` from an `AddressSpaceRegion` array.
    ///
    /// To achieve better performance by using binary search algorithm, the `regions` vector
    /// will gotten sorted by guest physical address.
    ///
    /// Note, panicking if some regions intersects with each other.
    ///
    /// # Arguments
    /// * `regions` - prepared regions to managed by the address space instance.
    /// * `layout` - prepared address space layout configuration.
    pub fn from_regions(regions: Vec<Arc<AddressSpaceRegion>>, layout: AddressSpaceLayout) -> Self {
        let base = AddressSpaceBase::from_regions(regions, layout);

        AddressSpace {
            state: Arc::new(ArcSwap::new(Arc::new(base))),
        }
    }

    /// Insert a new address space region into the address space.
    ///
    /// # Arguments
    /// * `region` - the new region to be inserted.
    pub fn insert_region(
        &mut self,
        region: Arc<AddressSpaceRegion>,
    ) -> Result<(), AddressSpaceError> {
        let curr = self.state.load().regions.clone();
        let layout = self.state.load().layout.clone();
        let mut base = AddressSpaceBase::from_regions(curr, layout);
        base.insert_region(region)?;
        let _old = self.state.swap(Arc::new(base));

        Ok(())
    }

    /// Enumerate all regions in the address space.
    ///
    /// # Arguments
    /// * `cb` - the callback function to apply to each region.
    pub fn walk_regions<F>(&self, cb: F) -> Result<(), AddressSpaceError>
    where
        F: FnMut(&Arc<AddressSpaceRegion>) -> Result<(), AddressSpaceError>,
    {
        self.state.load().walk_regions(cb)
    }

    /// Get address space layout associated with the address space.
    pub fn layout(&self) -> AddressSpaceLayout {
        self.state.load().layout()
    }

    /// Get maximum of guest physical address in the address space.
    pub fn last_addr(&self) -> GuestAddress {
        self.state.load().last_addr()
    }

    /// Check whether the guest physical address `guest_addr` belongs to a DAX memory region.
    ///
    /// # Arguments
    /// * `guest_addr` - the guest physical address to inquire
    pub fn is_dax_region(&self, guest_addr: GuestAddress) -> bool {
        self.state.load().is_dax_region(guest_addr)
    }

    /// Get optional NUMA node id associated with guest physical address `gpa`.
    ///
    /// # Arguments
    /// * `gpa` - guest physical address to query.
    pub fn numa_node_id(&self, gpa: u64) -> Option<u32> {
        self.state.load().numa_node_id(gpa)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::io::Write;
    use vm_memory::GuestUsize;
    use vmm_sys_util::tempfile::TempFile;

    // define macros for unit test
    const GUEST_PHYS_END: u64 = (1 << 46) - 1;
    const GUEST_MEM_START: u64 = 0;
    const GUEST_MEM_END: u64 = GUEST_PHYS_END >> 1;
    const GUEST_DEVICE_START: u64 = GUEST_MEM_END + 1;

    #[test]
    fn test_is_reserved_region() {
        let page_size = 4096;
        let address_space_region = vec![
            Arc::new(AddressSpaceRegion::new(
                AddressSpaceRegionType::DefaultMemory,
                GuestAddress(page_size),
                page_size as GuestUsize,
            )),
            Arc::new(AddressSpaceRegion::new(
                AddressSpaceRegionType::DefaultMemory,
                GuestAddress(page_size * 2),
                page_size as GuestUsize,
            )),
            Arc::new(AddressSpaceRegion::new(
                AddressSpaceRegionType::DAXMemory,
                GuestAddress(GUEST_DEVICE_START),
                page_size as GuestUsize,
            )),
        ];
        let layout = AddressSpaceLayout::new(GUEST_PHYS_END, GUEST_MEM_START, GUEST_MEM_END);
        let address_space = AddressSpace::from_regions(address_space_region, layout);

        assert!(!address_space.is_dax_region(GuestAddress(page_size)));
        assert!(!address_space.is_dax_region(GuestAddress(page_size * 2)));
        assert!(address_space.is_dax_region(GuestAddress(GUEST_DEVICE_START)));
        assert!(address_space.is_dax_region(GuestAddress(GUEST_DEVICE_START + 1)));
        assert!(!address_space.is_dax_region(GuestAddress(GUEST_DEVICE_START + page_size)));
        assert!(address_space.is_dax_region(GuestAddress(GUEST_DEVICE_START + page_size - 1)));
    }

    #[test]
    fn test_create_address_space_base() {
        let mut file = TempFile::new().unwrap().into_file();
        let sample_buf = &[1, 2, 3, 4, 5];
        assert!(file.write_all(sample_buf).is_ok());
        file.set_len(0x10000).unwrap();

        let reg = Arc::new(
            AddressSpaceRegion::create_device_region(GuestAddress(GUEST_DEVICE_START), 0x1000)
                .unwrap(),
        );
        let regions = vec![reg];
        let layout = AddressSpaceLayout::new(GUEST_PHYS_END, GUEST_MEM_START, GUEST_MEM_END);
        let address_space = AddressSpaceBase::from_regions(regions, layout.clone());
        assert_eq!(address_space.layout(), layout);
    }

    #[test]
    #[should_panic(expected = "Invalid region")]
    fn test_create_address_space_base_when_region_invalid() {
        let reg = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x1000,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg];
        let layout = AddressSpaceLayout::new(0x2000, 0x200, 0x1800);
        let _address_space = AddressSpaceBase::from_regions(regions, layout);
    }

    #[test]
    #[should_panic(expected = "address space regions intersect with each other")]
    fn test_create_address_space_base_when_region_intersected() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x200),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let _address_space = AddressSpaceBase::from_regions(regions, layout);
    }

    #[test]
    fn test_insert_region() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1];
        let layout = AddressSpaceLayout::new(0x2000, 0x100, 0x1800);
        let mut address_space = AddressSpaceBase::from_regions(regions, layout);

        // Normal case.
        address_space.insert_region(reg2).unwrap();
        assert!(!address_space.regions[1].intersect_with(&address_space.regions[0]));

        // Error invalid address range case when region invaled.
        let invalid_reg = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x0),
            0x100,
            None,
            None,
            0,
            false,
        ));
        assert_eq!(
            format!(
                "{:?}",
                address_space.insert_region(invalid_reg).err().unwrap()
            ),
            format!("InvalidAddressRange({:?}, {:?})", 0x0, 0x100)
        );

        // Error Error invalid address range case when region to be inserted will intersect
        // exsisting regions.
        let intersected_reg = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x400),
            0x200,
            None,
            None,
            0,
            false,
        ));
        assert_eq!(
            format!(
                "{:?}",
                address_space.insert_region(intersected_reg).err().unwrap()
            ),
            format!("InvalidAddressRange({:?}, {:?})", 0x400, 0x200)
        );
    }

    #[test]
    fn test_walk_regions() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpaceBase::from_regions(regions, layout);

        // The argument of walk_regions is a function which takes a &Arc<AddressSpaceRegion>
        // and returns result. This function will be applied to all regions.
        fn do_not_have_hotplug(region: &Arc<AddressSpaceRegion>) -> Result<(), AddressSpaceError> {
            if region.is_hotplug() {
                Err(AddressSpaceError::InvalidRegionType) // The Error type is dictated to AddressSpaceError.
            } else {
                Ok(())
            }
        }
        assert!(matches!(
            address_space.walk_regions(do_not_have_hotplug).unwrap(),
            ()
        ));
    }

    #[test]
    fn test_last_addr() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpaceBase::from_regions(regions, layout);

        assert_eq!(address_space.last_addr(), GuestAddress(0x500 - 1));
    }

    #[test]
    fn test_numa_node_id() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            Some(0),
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x300,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpaceBase::from_regions(regions, layout);

        // Normal case.
        assert_eq!(address_space.numa_node_id(0x200).unwrap(), 0);
        // Inquire region with None as its numa node id.
        assert_eq!(address_space.numa_node_id(0x400), None);
        // Inquire gpa where no region is set.
        assert_eq!(address_space.numa_node_id(0x600), None);
    }

    #[test]
    fn test_convert_into_vm_as() {
        // ! Further and detailed test is needed here.
        let gmm = GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0x0), 0x400)]).unwrap();
        let _vm = AddressSpace::convert_into_vm_as(gmm);
    }

    #[test]
    fn test_insert_region_on_address_space() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1];
        let layout = AddressSpaceLayout::new(0x2000, 0x100, 0x1800);
        let mut address_space = AddressSpace::from_regions(regions, layout);

        // Normal case.
        assert!(matches!(address_space.insert_region(reg2).unwrap(), ()));

        // Error invalid address range case when region invaled.
        let invalid_reg = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x0),
            0x100,
            None,
            None,
            0,
            false,
        ));
        assert_eq!(
            format!(
                "{:?}",
                address_space.insert_region(invalid_reg).err().unwrap()
            ),
            format!("InvalidAddressRange({:?}, {:?})", 0x0, 0x100)
        );

        // Error Error invalid address range case when region to be inserted will intersect
        // exsisting regions.
        let intersected_reg = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x400),
            0x200,
            None,
            None,
            0,
            false,
        ));
        assert_eq!(
            format!(
                "{:?}",
                address_space.insert_region(intersected_reg).err().unwrap()
            ),
            format!("InvalidAddressRange({:?}, {:?})", 0x400, 0x200)
        );
    }

    #[test]
    fn test_walk_regions_on_address_space() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpace::from_regions(regions, layout);

        fn access_all_hotplug_flag(
            region: &Arc<AddressSpaceRegion>,
        ) -> Result<(), AddressSpaceError> {
            region.is_hotplug();
            Ok(())
        }

        assert!(matches!(
            address_space.walk_regions(access_all_hotplug_flag).unwrap(),
            ()
        ));
    }

    #[test]
    fn test_layout_on_address_space() {
        let reg = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x1000,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpace::from_regions(regions, layout.clone());

        assert_eq!(layout, address_space.layout());
    }

    #[test]
    fn test_last_addr_on_address_space() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x200,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpace::from_regions(regions, layout);

        assert_eq!(address_space.last_addr(), GuestAddress(0x500 - 1));
    }

    #[test]
    fn test_numa_node_id_address_space() {
        let reg1 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x100),
            0x200,
            Some(0),
            None,
            0,
            false,
        ));
        let reg2 = Arc::new(AddressSpaceRegion::build(
            AddressSpaceRegionType::DefaultMemory,
            GuestAddress(0x300),
            0x300,
            None,
            None,
            0,
            false,
        ));
        let regions = vec![reg1, reg2];
        let layout = AddressSpaceLayout::new(0x2000, 0x0, 0x1800);
        let address_space = AddressSpace::from_regions(regions, layout);

        // Normal case.
        assert_eq!(address_space.numa_node_id(0x200).unwrap(), 0);
        // Inquire region with None as its numa node id.
        assert_eq!(address_space.numa_node_id(0x400), None);
        // Inquire gpa where no region is set.
        assert_eq!(address_space.numa_node_id(0x600), None);
    }
}