1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
use crate::error::{DataFusionError, Result};
use async_trait::async_trait;
use hashbrown::HashSet;
use log::{debug, warn};
use parking_lot::{Condvar, Mutex};
use std::fmt;
use std::fmt::{Debug, Display, Formatter};
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::Arc;
use std::time::{Duration, Instant};
static CONSUMER_ID: AtomicUsize = AtomicUsize::new(0);
#[derive(Debug, Clone)]
pub enum MemoryManagerConfig {
Existing(Arc<MemoryManager>),
New {
max_memory: usize,
memory_fraction: f64,
},
}
impl Default for MemoryManagerConfig {
fn default() -> Self {
Self::New {
max_memory: usize::MAX,
memory_fraction: 0.7,
}
}
}
impl MemoryManagerConfig {
pub fn new() -> Self {
Default::default()
}
pub fn new_existing(existing: Arc<MemoryManager>) -> Self {
Self::Existing(existing)
}
pub fn try_new_limit(max_memory: usize, memory_fraction: f64) -> Result<Self> {
if max_memory == 0 {
return Err(DataFusionError::Plan(format!(
"invalid max_memory. Expected greater than 0, got {}",
max_memory
)));
}
if !(memory_fraction > 0f64 && memory_fraction <= 1f64) {
return Err(DataFusionError::Plan(format!(
"invalid fraction. Expected greater than 0 and less than 1.0, got {}",
memory_fraction
)));
}
Ok(Self::New {
max_memory,
memory_fraction,
})
}
fn pool_size(&self) -> usize {
match self {
MemoryManagerConfig::Existing(existing) => existing.pool_size,
MemoryManagerConfig::New {
max_memory,
memory_fraction,
} => (*max_memory as f64 * *memory_fraction) as usize,
}
}
}
fn next_id() -> usize {
CONSUMER_ID.fetch_add(1, Ordering::SeqCst)
}
pub enum ConsumerType {
Requesting,
Tracking,
}
#[derive(Clone, Debug, Hash, Eq, PartialEq)]
pub struct MemoryConsumerId {
pub partition_id: usize,
pub id: usize,
}
impl MemoryConsumerId {
pub fn new(partition_id: usize) -> Self {
let id = next_id();
Self { partition_id, id }
}
}
impl Display for MemoryConsumerId {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
write!(f, "{}:{}", self.partition_id, self.id)
}
}
#[async_trait]
pub trait MemoryConsumer: Send + Sync {
fn name(&self) -> String;
fn id(&self) -> &MemoryConsumerId;
fn memory_manager(&self) -> Arc<MemoryManager>;
fn partition_id(&self) -> usize {
self.id().partition_id
}
fn type_(&self) -> &ConsumerType;
async fn try_grow(&self, required: usize) -> Result<()> {
let current = self.mem_used();
debug!(
"trying to acquire {} whiling holding {} from consumer {}",
human_readable_size(required),
human_readable_size(current),
self.id(),
);
let can_grow_directly = self
.memory_manager()
.can_grow_directly(required, current)
.await;
if !can_grow_directly {
debug!(
"Failed to grow memory of {} directly from consumer {}, spilling first ...",
human_readable_size(required),
self.id()
);
let freed = self.spill().await?;
self.memory_manager()
.record_free_then_acquire(freed, required);
}
Ok(())
}
fn shrink(&self, freed: usize) {
self.memory_manager().record_free(freed);
}
async fn spill(&self) -> Result<usize>;
fn mem_used(&self) -> usize;
}
impl Debug for dyn MemoryConsumer {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
write!(
f,
"{}[{}]: {}",
self.name(),
self.id(),
human_readable_size(self.mem_used())
)
}
}
impl Display for dyn MemoryConsumer {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
write!(f, "{}[{}]", self.name(), self.id(),)
}
}
#[derive(Debug)]
pub struct MemoryManager {
requesters: Arc<Mutex<HashSet<MemoryConsumerId>>>,
pool_size: usize,
requesters_total: Arc<Mutex<usize>>,
trackers_total: AtomicUsize,
cv: Condvar,
}
impl MemoryManager {
#[allow(clippy::mutex_atomic)]
pub fn new(config: MemoryManagerConfig) -> Arc<Self> {
let pool_size = config.pool_size();
match config {
MemoryManagerConfig::Existing(manager) => manager,
MemoryManagerConfig::New { .. } => {
debug!(
"Creating memory manager with initial size {}",
human_readable_size(pool_size)
);
Arc::new(Self {
requesters: Arc::new(Mutex::new(HashSet::new())),
pool_size,
requesters_total: Arc::new(Mutex::new(0)),
trackers_total: AtomicUsize::new(0),
cv: Condvar::new(),
})
}
}
}
fn get_tracker_total(&self) -> usize {
self.trackers_total.load(Ordering::SeqCst)
}
pub(crate) fn grow_tracker_usage(&self, delta: usize) {
self.trackers_total.fetch_add(delta, Ordering::SeqCst);
}
pub(crate) fn shrink_tracker_usage(&self, delta: usize) {
let update =
self.trackers_total
.fetch_update(Ordering::SeqCst, Ordering::SeqCst, |x| {
if x >= delta {
Some(x - delta)
} else {
None
}
});
update.unwrap_or_else(|_| {
panic!(
"Tracker total memory shrink by {} underflow, current value is ",
delta
)
});
}
pub fn get_requester_total(&self) -> usize {
*self.requesters_total.lock()
}
pub(crate) fn register_requester(&self, requester_id: &MemoryConsumerId) {
self.requesters.lock().insert(requester_id.clone());
}
fn max_mem_for_requesters(&self) -> usize {
let trk_total = self.get_tracker_total();
self.pool_size - trk_total
}
async fn can_grow_directly(&self, required: usize, current: usize) -> bool {
let num_rqt = self.requesters.lock().len();
let mut rqt_current_used = self.requesters_total.lock();
let mut rqt_max = self.max_mem_for_requesters();
let granted;
loop {
let max_per_rqt = rqt_max / num_rqt;
let min_per_rqt = max_per_rqt / 2;
if required + current >= max_per_rqt {
granted = false;
break;
}
let remaining = rqt_max.checked_sub(*rqt_current_used).unwrap_or_default();
if remaining >= required {
granted = true;
*rqt_current_used += required;
break;
} else if current < min_per_rqt {
debug!(
"Cannot acquire a minimum amount of {} memory from the manager of total {}, waiting for others to spill ...",
human_readable_size(min_per_rqt), human_readable_size(self.pool_size));
let now = Instant::now();
self.cv.wait(&mut rqt_current_used);
let elapsed = now.elapsed();
if elapsed > Duration::from_secs(10) {
warn!("Elapsed on waiting for spilling: {:.2?}", elapsed);
}
} else {
granted = false;
break;
}
rqt_max = self.max_mem_for_requesters();
}
granted
}
fn record_free_then_acquire(&self, freed: usize, acquired: usize) {
let mut requesters_total = self.requesters_total.lock();
debug!(
"free_then_acquire: total {}, freed {}, acquired {}",
human_readable_size(*requesters_total),
human_readable_size(freed),
human_readable_size(acquired)
);
assert!(*requesters_total >= freed);
*requesters_total -= freed;
*requesters_total += acquired;
self.cv.notify_all();
}
fn record_free(&self, freed: usize) {
let mut requesters_total = self.requesters_total.lock();
debug!(
"free: total {}, freed {}",
human_readable_size(*requesters_total),
human_readable_size(freed)
);
assert!(*requesters_total >= freed);
*requesters_total -= freed;
self.cv.notify_all();
}
pub(crate) fn drop_consumer(&self, id: &MemoryConsumerId, mem_used: usize) {
{
let mut requesters = self.requesters.lock();
if requesters.remove(id) {
let mut total = self.requesters_total.lock();
assert!(*total >= mem_used);
*total -= mem_used;
self.cv.notify_all();
return;
}
}
self.shrink_tracker_usage(mem_used);
self.cv.notify_all();
}
}
impl Display for MemoryManager {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
write!(f,
"MemoryManager usage statistics: total {}, trackers used {}, total {} requesters used: {}",
human_readable_size(self.pool_size),
human_readable_size(self.get_tracker_total()),
self.requesters.lock().len(),
human_readable_size(self.get_requester_total()),
)
}
}
const TB: u64 = 1 << 40;
const GB: u64 = 1 << 30;
const MB: u64 = 1 << 20;
const KB: u64 = 1 << 10;
pub fn human_readable_size(size: usize) -> String {
let size = size as u64;
let (value, unit) = {
if size >= 2 * TB {
(size as f64 / TB as f64, "TB")
} else if size >= 2 * GB {
(size as f64 / GB as f64, "GB")
} else if size >= 2 * MB {
(size as f64 / MB as f64, "MB")
} else if size >= 2 * KB {
(size as f64 / KB as f64, "KB")
} else {
(size as f64, "B")
}
};
format!("{:.1} {}", value, unit)
}
#[cfg(test)]
mod tests {
use super::*;
use crate::error::Result;
use crate::execution::runtime_env::{RuntimeConfig, RuntimeEnv};
use crate::execution::MemoryConsumer;
use crate::physical_plan::metrics::{ExecutionPlanMetricsSet, MemTrackingMetrics};
use async_trait::async_trait;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::Arc;
struct DummyRequester {
id: MemoryConsumerId,
runtime: Arc<RuntimeEnv>,
spills: AtomicUsize,
mem_used: AtomicUsize,
}
impl DummyRequester {
fn new(partition: usize, runtime: Arc<RuntimeEnv>) -> Self {
Self {
id: MemoryConsumerId::new(partition),
runtime,
spills: AtomicUsize::new(0),
mem_used: AtomicUsize::new(0),
}
}
async fn do_with_mem(&self, grow: usize) -> Result<()> {
self.try_grow(grow).await?;
self.mem_used.fetch_add(grow, Ordering::SeqCst);
Ok(())
}
fn get_spills(&self) -> usize {
self.spills.load(Ordering::SeqCst)
}
}
#[async_trait]
impl MemoryConsumer for DummyRequester {
fn name(&self) -> String {
"dummy".to_owned()
}
fn id(&self) -> &MemoryConsumerId {
&self.id
}
fn memory_manager(&self) -> Arc<MemoryManager> {
self.runtime.memory_manager.clone()
}
fn type_(&self) -> &ConsumerType {
&ConsumerType::Requesting
}
async fn spill(&self) -> Result<usize> {
self.spills.fetch_add(1, Ordering::SeqCst);
let used = self.mem_used.swap(0, Ordering::SeqCst);
Ok(used)
}
fn mem_used(&self) -> usize {
self.mem_used.load(Ordering::SeqCst)
}
}
struct DummyTracker {
id: MemoryConsumerId,
runtime: Arc<RuntimeEnv>,
mem_used: usize,
}
impl DummyTracker {
fn new(partition: usize, runtime: Arc<RuntimeEnv>, mem_used: usize) -> Self {
runtime.grow_tracker_usage(mem_used);
Self {
id: MemoryConsumerId::new(partition),
runtime,
mem_used,
}
}
}
#[async_trait]
impl MemoryConsumer for DummyTracker {
fn name(&self) -> String {
"dummy".to_owned()
}
fn id(&self) -> &MemoryConsumerId {
&self.id
}
fn memory_manager(&self) -> Arc<MemoryManager> {
self.runtime.memory_manager.clone()
}
fn type_(&self) -> &ConsumerType {
&ConsumerType::Tracking
}
async fn spill(&self) -> Result<usize> {
Ok(0)
}
fn mem_used(&self) -> usize {
self.mem_used
}
}
#[tokio::test]
async fn basic_functionalities() {
let config = RuntimeConfig::new()
.with_memory_manager(MemoryManagerConfig::try_new_limit(100, 1.0).unwrap());
let runtime = Arc::new(RuntimeEnv::new(config).unwrap());
DummyTracker::new(0, runtime.clone(), 5);
assert_eq!(runtime.memory_manager.get_tracker_total(), 5);
let tracker1 = DummyTracker::new(0, runtime.clone(), 10);
assert_eq!(runtime.memory_manager.get_tracker_total(), 15);
DummyTracker::new(0, runtime.clone(), 15);
assert_eq!(runtime.memory_manager.get_tracker_total(), 30);
runtime.drop_consumer(tracker1.id(), tracker1.mem_used);
assert_eq!(runtime.memory_manager.get_tracker_total(), 20);
let ms = ExecutionPlanMetricsSet::new();
let tracking_metric = MemTrackingMetrics::new_with_rt(&ms, 0, runtime.clone());
tracking_metric.init_mem_used(15);
assert_eq!(runtime.memory_manager.get_tracker_total(), 35);
drop(tracking_metric);
assert_eq!(runtime.memory_manager.get_tracker_total(), 20);
let requester1 = DummyRequester::new(0, runtime.clone());
runtime.register_requester(requester1.id());
requester1.do_with_mem(40).await.unwrap();
requester1.do_with_mem(10).await.unwrap();
assert_eq!(requester1.get_spills(), 0);
assert_eq!(requester1.mem_used(), 50);
assert_eq!(*runtime.memory_manager.requesters_total.lock(), 50);
let requester2 = DummyRequester::new(0, runtime.clone());
runtime.register_requester(requester2.id());
requester2.do_with_mem(20).await.unwrap();
requester2.do_with_mem(30).await.unwrap();
assert_eq!(requester2.get_spills(), 1);
assert_eq!(requester2.mem_used(), 30);
requester1.do_with_mem(10).await.unwrap();
assert_eq!(requester1.get_spills(), 1);
assert_eq!(requester1.mem_used(), 10);
assert_eq!(*runtime.memory_manager.requesters_total.lock(), 40);
}
#[tokio::test]
#[should_panic(expected = "invalid max_memory. Expected greater than 0, got 0")]
async fn test_try_new_with_limit_0() {
MemoryManagerConfig::try_new_limit(0, 1.0).unwrap();
}
#[tokio::test]
#[should_panic(
expected = "invalid fraction. Expected greater than 0 and less than 1.0, got -9.6"
)]
async fn test_try_new_with_limit_neg_fraction() {
MemoryManagerConfig::try_new_limit(100, -9.6).unwrap();
}
#[tokio::test]
#[should_panic(
expected = "invalid fraction. Expected greater than 0 and less than 1.0, got 9.6"
)]
async fn test_try_new_with_limit_too_large() {
MemoryManagerConfig::try_new_limit(100, 9.6).unwrap();
}
#[tokio::test]
async fn test_try_new_with_limit_pool_size() {
let config = MemoryManagerConfig::try_new_limit(100, 0.5).unwrap();
assert_eq!(config.pool_size(), 50);
let config = MemoryManagerConfig::try_new_limit(100000, 0.1).unwrap();
assert_eq!(config.pool_size(), 10000);
}
}