cu29_runtime/

debug.rs

//! CuDebug: lightweight time-travel debugger helpers on top of Copper logs.
//!
//! Design goals:
//! - Do **not** load entire copperlists into memory (logs can be huge).
//! - Build a compact section index in one streaming pass (copperlists + keyframes).
//! - Keep keyframes in memory (much smaller) and lazily page copperlist sections
//!   with a tiny LRU cache for snappy stepping.
//! - Reuse the public `CuSimApplication` API and user-provided sim callbacks.

use crate::app::{CuSimApplication, CurrentRuntimeCopperList};
use crate::curuntime::KeyFrame;
use crate::reflect::{ReflectTaskIntrospection, TypeRegistry, dump_type_registry_schema};
use crate::simulation::SimOverride;
use bincode::config::standard;
use bincode::decode_from_std_read;
use bincode::error::DecodeError;
use cu29_clock::{CuTime, RobotClock, RobotClockMock};
use cu29_traits::{CopperListTuple, CuError, CuResult, UnifiedLogType};
use cu29_unifiedlog::{
    LogPosition, SectionHeader, SectionStorage, UnifiedLogRead, UnifiedLogWrite, UnifiedLogger,
    UnifiedLoggerBuilder, UnifiedLoggerRead,
};
use std::collections::{HashMap, VecDeque};
use std::io;
use std::marker::PhantomData;
use std::path::Path;
use std::sync::Arc;

/// Result of a jump/step, useful for benchmarking cache effectiveness.
#[derive(Debug, Clone)]
pub struct JumpOutcome {
    /// Copperlist id we landed on
    pub culistid: u64,
    /// Keyframe used to rewind (if any)
    pub keyframe_culistid: Option<u64>,
    /// Number of copperlists replayed after the keyframe
    pub replayed: usize,
}

/// Section-cache statistics for a debug session.
#[derive(Debug, Clone, Copy)]
pub struct SectionCacheStats {
    pub cap: usize,
    pub entries: usize,
    pub hits: u64,
    pub misses: u64,
    pub evictions: u64,
}

#[allow(dead_code)]
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(crate) enum IndexedResolveMode {
    Exact,
    AtOrAfter,
    AtOrBefore,
}

/// Metadata for one copperlist section (no payload kept).
#[derive(Debug, Clone)]
pub(crate) struct SectionIndexEntry {
    pub(crate) pos: LogPosition,
    pub(crate) start_idx: usize,
    pub(crate) len: usize,
    pub(crate) first_id: u64,
    pub(crate) last_id: u64,
    pub(crate) first_ts: Option<CuTime>,
    pub(crate) last_ts: Option<CuTime>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(crate) struct LogIndexProgress {
    pub(crate) scanned_bytes: u64,
    pub(crate) total_bytes: u64,
    pub(crate) indexed_entries: usize,
}

/// Cached copperlists for one section.
#[derive(Debug, Clone)]
struct CachedSection<P: CopperListTuple> {
    entries: Vec<Arc<crate::copperlist::CopperList<P>>>,
    timestamps: Vec<Option<CuTime>>,
}

/// A reusable debugging session that can time-travel within a recorded log.
///
/// `CB` builds a simulation callback for a specific copperlist entry. This keeps the
/// API generic: the caller can replay recorded outputs, drive the mock clock inside a
/// CopperList, or inject extra assertions inside the callback. `TF` extracts a
/// timestamp from a copperlist to support time-based seeking.
const DEFAULT_SECTION_CACHE_CAP: usize = 8;
pub struct CuDebugSession<App, P, CB, TF, S, L>
where
    P: CopperListTuple,
    S: SectionStorage,
    L: UnifiedLogWrite<S> + 'static,
{
    app: App,
    robot_clock: RobotClock,
    clock_mock: RobotClockMock,
    log_reader: UnifiedLoggerRead,
    sections: Vec<SectionIndexEntry>,
    total_entries: usize,
    keyframes: Vec<KeyFrame>,
    started: bool,
    current_idx: Option<usize>,
    last_keyframe: Option<u64>,
    build_callback: CB,
    time_of: TF,
    // Tiny LRU cache of decoded sections
    cache: HashMap<usize, CachedSection<P>>,
    cache_order: VecDeque<usize>,
    cache_cap: usize,
    cache_hits: u64,
    cache_misses: u64,
    cache_evictions: u64,
    phantom: PhantomData<(S, L)>,
}

impl<App, P, CB, TF, S, L> CuDebugSession<App, P, CB, TF, S, L>
where
    App: CuSimApplication<S, L>,
    L: UnifiedLogWrite<S> + 'static,
    S: SectionStorage,
    P: CopperListTuple + 'static,
    CB: for<'a> Fn(
        &'a crate::copperlist::CopperList<P>,
        RobotClock,
        RobotClockMock,
    ) -> Box<dyn for<'z> FnMut(App::Step<'z>) -> SimOverride + 'a>,
    TF: Fn(&crate::copperlist::CopperList<P>) -> Option<CuTime> + Clone,
{
    /// Build a session directly from a unified log on disk (streaming index, no bulk load).
    pub fn from_log(
        log_base: &Path,
        app: App,
        robot_clock: RobotClock,
        clock_mock: RobotClockMock,
        build_callback: CB,
        time_of: TF,
    ) -> CuResult<Self> {
        Self::from_log_with_progress(
            log_base,
            app,
            robot_clock,
            clock_mock,
            build_callback,
            time_of,
            |_| {},
        )
    }

    pub(crate) fn from_log_with_progress(
        log_base: &Path,
        app: App,
        robot_clock: RobotClock,
        clock_mock: RobotClockMock,
        build_callback: CB,
        time_of: TF,
        mut progress: impl FnMut(LogIndexProgress),
    ) -> CuResult<Self> {
        let _ = crate::logcodec::seed_effective_config_from_log::<P>(log_base)?;
        let (sections, keyframes, total_entries) =
            index_log_with_progress::<P, _, _>(log_base, &time_of, &mut progress)?;
        let log_reader = build_read_logger(log_base)?;
        Ok(Self::new(
            log_reader,
            app,
            robot_clock,
            clock_mock,
            sections,
            total_entries,
            keyframes,
            build_callback,
            time_of,
        ))
    }

    /// Build a session directly from a log, with an explicit cache size.
    pub fn from_log_with_cache_cap(
        log_base: &Path,
        app: App,
        robot_clock: RobotClock,
        clock_mock: RobotClockMock,
        build_callback: CB,
        time_of: TF,
        cache_cap: usize,
    ) -> CuResult<Self> {
        Self::from_log_with_cache_cap_and_progress(
            log_base,
            app,
            robot_clock,
            clock_mock,
            build_callback,
            time_of,
            cache_cap,
            |_| {},
        )
    }

    #[allow(clippy::too_many_arguments)]
    pub(crate) fn from_log_with_cache_cap_and_progress(
        log_base: &Path,
        app: App,
        robot_clock: RobotClock,
        clock_mock: RobotClockMock,
        build_callback: CB,
        time_of: TF,
        cache_cap: usize,
        mut progress: impl FnMut(LogIndexProgress),
    ) -> CuResult<Self> {
        let _ = crate::logcodec::seed_effective_config_from_log::<P>(log_base)?;
        let (sections, keyframes, total_entries) =
            index_log_with_progress::<P, _, _>(log_base, &time_of, &mut progress)?;
        let log_reader = build_read_logger(log_base)?;
        Ok(Self::new_with_cache_cap(
            log_reader,
            app,
            robot_clock,
            clock_mock,
            sections,
            total_entries,
            keyframes,
            build_callback,
            time_of,
            cache_cap,
        ))
    }

    /// Create a new session from prebuilt indices.
    #[allow(clippy::too_many_arguments)]
    pub(crate) fn new(
        log_reader: UnifiedLoggerRead,
        app: App,
        robot_clock: RobotClock,
        clock_mock: RobotClockMock,
        sections: Vec<SectionIndexEntry>,
        total_entries: usize,
        keyframes: Vec<KeyFrame>,
        build_callback: CB,
        time_of: TF,
    ) -> Self {
        Self::new_with_cache_cap(
            log_reader,
            app,
            robot_clock,
            clock_mock,
            sections,
            total_entries,
            keyframes,
            build_callback,
            time_of,
            DEFAULT_SECTION_CACHE_CAP,
        )
    }

    #[allow(clippy::too_many_arguments)]
    pub(crate) fn new_with_cache_cap(
        log_reader: UnifiedLoggerRead,
        app: App,
        robot_clock: RobotClock,
        clock_mock: RobotClockMock,
        sections: Vec<SectionIndexEntry>,
        total_entries: usize,
        keyframes: Vec<KeyFrame>,
        build_callback: CB,
        time_of: TF,
        cache_cap: usize,
    ) -> Self {
        Self {
            app,
            robot_clock,
            clock_mock,
            log_reader,
            sections,
            total_entries,
            keyframes,
            started: false,
            current_idx: None,
            last_keyframe: None,
            build_callback,
            time_of,
            cache: HashMap::new(),
            cache_order: VecDeque::new(),
            cache_cap: cache_cap.max(1),
            cache_hits: 0,
            cache_misses: 0,
            cache_evictions: 0,
            phantom: PhantomData,
        }
    }

    #[inline]
    pub fn app(&self) -> &App {
        &self.app
    }

    #[inline]
    pub fn app_mut(&mut self) -> &mut App {
        &mut self.app
    }

    // Framework replay engine: drives the raw (app-deprecated) lifecycle on purpose.
    #[allow(deprecated)]
    fn ensure_started(&mut self) -> CuResult<()> {
        if self.started {
            return Ok(());
        }
        let mut noop = |_step: App::Step<'_>| SimOverride::ExecuteByRuntime;
        self.app.start_all_tasks(&mut noop)?;
        self.started = true;
        Ok(())
    }

    fn nearest_keyframe(&self, target_culistid: u64) -> Option<KeyFrame> {
        nearest_replay_keyframe(&self.keyframes, target_culistid)
    }

    fn restore_keyframe(&mut self, kf: &KeyFrame) -> CuResult<()> {
        self.app.restore_keyframe(kf)?;
        self.clock_mock.set_value(kf.timestamp.as_nanos());
        self.last_keyframe = Some(kf.culistid);
        Ok(())
    }

    fn clear_runtime_copperlist_snapshot(&mut self)
    where
        App: CurrentRuntimeCopperList<P>,
    {
        self.app.set_current_runtime_copperlist_bytes(None);
    }

    fn normalize_runtime_copperlist_snapshot(
        &mut self,
        recorded: &crate::copperlist::CopperList<P>,
    ) -> CuResult<()>
    where
        App: CurrentRuntimeCopperList<P>,
    {
        let normalized = self
            .app
            .current_runtime_copperlist_bytes()
            .map(|bytes| {
                let (mut runtime_cl, _) = bincode::decode_from_slice::<
                    crate::copperlist::CopperList<P>,
                    _,
                >(bytes, standard())
                .map_err(|e| {
                    CuError::new_with_cause("Failed to decode runtime CopperList snapshot", e)
                })?;
                runtime_cl.id = recorded.id;
                bincode::encode_to_vec(&runtime_cl, standard()).map_err(|e| {
                    CuError::new_with_cause("Failed to encode normalized CopperList snapshot", e)
                })
            })
            .transpose()?;
        self.app.set_current_runtime_copperlist_bytes(normalized);
        Ok(())
    }

    fn find_section_for_index(&self, idx: usize) -> Option<usize> {
        self.sections
            .binary_search_by(|s| {
                if idx < s.start_idx {
                    std::cmp::Ordering::Greater
                } else if idx >= s.start_idx + s.len {
                    std::cmp::Ordering::Less
                } else {
                    std::cmp::Ordering::Equal
                }
            })
            .ok()
    }

    fn find_section_for_culistid(&self, culistid: u64) -> Option<usize> {
        self.sections
            .binary_search_by(|s| {
                if culistid < s.first_id {
                    std::cmp::Ordering::Greater
                } else if culistid > s.last_id {
                    std::cmp::Ordering::Less
                } else {
                    std::cmp::Ordering::Equal
                }
            })
            .ok()
    }

    fn touch_cache(&mut self, key: usize) {
        if let Some(pos) = self.cache_order.iter().position(|k| *k == key) {
            self.cache_order.remove(pos);
        }
        self.cache_order.push_back(key);
        while self.cache_order.len() > self.cache_cap {
            if let Some(old) = self.cache_order.pop_front()
                && self.cache.remove(&old).is_some()
            {
                self.cache_evictions = self.cache_evictions.saturating_add(1);
            }
        }
    }

    fn load_section(&mut self, section_idx: usize) -> CuResult<&CachedSection<P>> {
        if self.cache.contains_key(&section_idx) {
            self.cache_hits = self.cache_hits.saturating_add(1);
            self.touch_cache(section_idx);
            // SAFETY: key exists, unwrap ok.
            return Ok(self.cache.get(&section_idx).unwrap());
        }
        self.cache_misses = self.cache_misses.saturating_add(1);

        let entry = &self.sections[section_idx];
        let (header, data) = read_section_at(&mut self.log_reader, entry.pos)?;
        if header.entry_type != UnifiedLogType::CopperList {
            return Err(CuError::from(
                "Section type mismatch while loading copperlists",
            ));
        }

        let (entries, timestamps) = decode_copperlists::<P, _>(&data, &self.time_of)?;
        let cached = CachedSection {
            entries,
            timestamps,
        };
        self.cache.insert(section_idx, cached);
        self.touch_cache(section_idx);
        Ok(self.cache.get(&section_idx).unwrap())
    }

    fn copperlist_at(
        &mut self,
        idx: usize,
    ) -> CuResult<(Arc<crate::copperlist::CopperList<P>>, Option<CuTime>)> {
        let section_idx = self
            .find_section_for_index(idx)
            .ok_or_else(|| CuError::from("Index outside copperlist log"))?;
        let start_idx = self.sections[section_idx].start_idx;
        let section = self.load_section(section_idx)?;
        let local = idx - start_idx;
        let cl = section
            .entries
            .get(local)
            .ok_or_else(|| CuError::from("Corrupt section index vs cache"))?
            .clone();
        let ts = section.timestamps.get(local).copied().unwrap_or(None);
        Ok((cl, ts))
    }

    fn first_section_with_last_id_at_least(&self, culistid: u64) -> usize {
        let mut left = 0usize;
        let mut right = self.sections.len();
        while left < right {
            let mid = left + (right - left) / 2;
            if self.sections[mid].last_id < culistid {
                left = mid + 1;
            } else {
                right = mid;
            }
        }
        left
    }

    fn first_section_with_first_id_greater_than(&self, culistid: u64) -> usize {
        let mut left = 0usize;
        let mut right = self.sections.len();
        while left < right {
            let mid = left + (right - left) / 2;
            if self.sections[mid].first_id <= culistid {
                left = mid + 1;
            } else {
                right = mid;
            }
        }
        left
    }

    fn index_for_culistid_at_or_after(&mut self, culistid: u64) -> CuResult<usize> {
        let mut section_idx = self.first_section_with_last_id_at_least(culistid);
        while section_idx < self.sections.len() {
            let start_idx = self.sections[section_idx].start_idx;
            let section = self.load_section(section_idx)?;
            for (offset, cl) in section.entries.iter().enumerate() {
                if cl.id >= culistid {
                    return Ok(start_idx + offset);
                }
            }
            section_idx += 1;
        }
        Err(CuError::from(format!("No CL at/after target {culistid}")))
    }

    fn index_for_culistid_at_or_before(&mut self, culistid: u64) -> CuResult<usize> {
        let mut section_idx = self.first_section_with_first_id_greater_than(culistid);
        while section_idx > 0 {
            section_idx -= 1;
            let start_idx = self.sections[section_idx].start_idx;
            let section = self.load_section(section_idx)?;
            for (offset, cl) in section.entries.iter().enumerate().rev() {
                if cl.id <= culistid {
                    return Ok(start_idx + offset);
                }
            }
        }
        Err(CuError::from(format!("No CL at/before target {culistid}")))
    }

    fn index_for_culistid(&mut self, culistid: u64) -> CuResult<usize> {
        let section_idx = self
            .find_section_for_culistid(culistid)
            .ok_or_else(|| CuError::from("Requested culistid not present in log"))?;
        let start_idx = self.sections[section_idx].start_idx;
        let section = self.load_section(section_idx)?;
        for (offset, cl) in section.entries.iter().enumerate() {
            if cl.id == culistid {
                return Ok(start_idx + offset);
            }
        }
        Err(CuError::from("culistid not found inside indexed section"))
    }

    pub(crate) fn resolve_index_for_culistid(
        &mut self,
        culistid: u64,
        mode: IndexedResolveMode,
    ) -> CuResult<usize> {
        match mode {
            IndexedResolveMode::Exact => self
                .index_for_culistid(culistid)
                .map_err(|_| CuError::from(format!("No exact CL target for {culistid}"))),
            IndexedResolveMode::AtOrAfter => self.index_for_culistid_at_or_after(culistid),
            IndexedResolveMode::AtOrBefore => self.index_for_culistid_at_or_before(culistid),
        }
    }

    fn index_for_time_at_or_after(&mut self, ts: CuTime) -> CuResult<usize> {
        for section_idx in 0..self.sections.len() {
            let section_entry = &self.sections[section_idx];
            if matches!(section_entry.last_ts, Some(last) if last < ts) {
                continue;
            }

            let start_idx = section_entry.start_idx;
            let section_first_ts = section_entry.first_ts;
            let section = self.load_section(section_idx)?;
            for (offset, maybe_ts) in section.timestamps.iter().enumerate() {
                if matches!(maybe_ts, Some(entry_ts) if *entry_ts >= ts) {
                    return Ok(start_idx + offset);
                }
            }

            if matches!(section_first_ts, Some(first) if first > ts) {
                break;
            }
        }

        Err(CuError::from(format!(
            "No timestamp at/after {}",
            ts.as_nanos()
        )))
    }

    fn index_for_time_at_or_before(&mut self, ts: CuTime) -> CuResult<usize> {
        for section_idx in (0..self.sections.len()).rev() {
            let section_entry = &self.sections[section_idx];
            if matches!(section_entry.first_ts, Some(first) if first > ts) {
                continue;
            }

            let start_idx = section_entry.start_idx;
            let section = self.load_section(section_idx)?;
            for (offset, maybe_ts) in section.timestamps.iter().enumerate().rev() {
                if matches!(maybe_ts, Some(entry_ts) if *entry_ts <= ts) {
                    return Ok(start_idx + offset);
                }
            }
        }

        Err(CuError::from(format!(
            "No timestamp at/before {}",
            ts.as_nanos()
        )))
    }

    fn index_for_exact_time(&mut self, ts: CuTime) -> CuResult<usize> {
        for section_idx in 0..self.sections.len() {
            let section_entry = &self.sections[section_idx];
            if matches!(section_entry.last_ts, Some(last) if last < ts) {
                continue;
            }
            if matches!(section_entry.first_ts, Some(first) if first > ts) {
                break;
            }

            let start_idx = section_entry.start_idx;
            let section = self.load_section(section_idx)?;
            for (offset, maybe_ts) in section.timestamps.iter().enumerate() {
                if matches!(maybe_ts, Some(entry_ts) if *entry_ts == ts) {
                    return Ok(start_idx + offset);
                }
            }
        }

        Err(CuError::from(format!(
            "No exact timestamp target for {}",
            ts.as_nanos()
        )))
    }

    fn index_for_time(&mut self, ts: CuTime) -> CuResult<usize> {
        self.resolve_index_for_time(ts, IndexedResolveMode::AtOrAfter)
    }

    pub(crate) fn resolve_index_for_time(
        &mut self,
        ts: CuTime,
        mode: IndexedResolveMode,
    ) -> CuResult<usize> {
        match mode {
            IndexedResolveMode::Exact => self.index_for_exact_time(ts),
            IndexedResolveMode::AtOrAfter => self.index_for_time_at_or_after(ts),
            IndexedResolveMode::AtOrBefore => self.index_for_time_at_or_before(ts),
        }
    }

    // Framework replay engine: drives the raw (app-deprecated) lifecycle on purpose.
    #[allow(deprecated)]
    fn replay_range(&mut self, start: usize, end: usize) -> CuResult<usize>
    where
        App: CurrentRuntimeCopperList<P>,
    {
        let mut replayed = 0usize;
        for idx in start..=end {
            let (entry, ts) = self.copperlist_at(idx)?;
            let restored = (idx == start)
                .then_some(self.last_keyframe)
                .flatten()
                .filter(|boundary| *boundary == entry.id);
            let expected = if idx > 0 {
                self.copperlist_at(idx - 1)?
                    .0
                    .id
                    .checked_add(1)
                    .ok_or_else(|| CuError::from("Replay CopperList id overflow"))?
            } else {
                0
            };
            crate::continuity::validate_replay_continuity(expected, entry.id, restored)?;
            if let Some(ts) = ts {
                self.clock_mock.set_value(ts.as_nanos());
            }
            let clock_for_cb = self.robot_clock.clone();
            let clock_mock_for_cb = self.clock_mock.clone();
            let mut cb = (self.build_callback)(entry.as_ref(), clock_for_cb, clock_mock_for_cb);
            self.app.run_one_iteration(&mut cb)?;
            self.normalize_runtime_copperlist_snapshot(entry.as_ref())?;
            replayed += 1;
            self.current_idx = Some(idx);
        }
        Ok(replayed)
    }

    pub(crate) fn goto_index(&mut self, target_idx: usize) -> CuResult<JumpOutcome>
    where
        App: CurrentRuntimeCopperList<P>,
    {
        self.ensure_started()?;
        if target_idx >= self.total_entries {
            return Err(CuError::from("Target index outside log"));
        }
        let (target_cl, _) = self.copperlist_at(target_idx)?;
        let target_culistid = target_cl.id;

        let keyframe_used: Option<u64>;
        let replay_start: usize;

        // Fast path: forward stepping from current state.
        if let Some(current) = self.current_idx {
            if target_idx == current {
                return Ok(JumpOutcome {
                    culistid: target_culistid,
                    keyframe_culistid: self.last_keyframe,
                    replayed: 0,
                });
            }

            if target_idx >= current {
                let nearest_keyframe = self.nearest_keyframe(target_culistid);
                let nearest_keyframe_idx = nearest_keyframe
                    .as_ref()
                    .and_then(|kf| self.index_for_culistid(kf.culistid).ok());

                if let (Some(kf), Some(kf_idx)) = (nearest_keyframe, nearest_keyframe_idx)
                    && kf_idx > current
                {
                    self.restore_keyframe(&kf)?;
                    self.clear_runtime_copperlist_snapshot();
                    keyframe_used = Some(kf.culistid);
                    replay_start = kf_idx;
                } else {
                    replay_start = current + 1;
                    keyframe_used = self.last_keyframe;
                }
            } else {
                // Need to rewind to nearest keyframe
                let Some(kf) = self.nearest_keyframe(target_culistid) else {
                    return Err(CuError::from("No keyframe available to rewind"));
                };
                self.restore_keyframe(&kf)?;
                self.clear_runtime_copperlist_snapshot();
                keyframe_used = Some(kf.culistid);
                replay_start = self.index_for_culistid(kf.culistid)?;
            }
        } else {
            // First jump: align to nearest keyframe
            let Some(kf) = self.nearest_keyframe(target_culistid) else {
                return Err(CuError::from("No keyframe found in log"));
            };
            self.restore_keyframe(&kf)?;
            self.clear_runtime_copperlist_snapshot();
            keyframe_used = Some(kf.culistid);
            replay_start = self.index_for_culistid(kf.culistid)?;
        }

        if replay_start > target_idx {
            return Err(CuError::from(
                "Replay start past target index; log ordering issue",
            ));
        }

        let replayed = self.replay_range(replay_start, target_idx)?;

        Ok(JumpOutcome {
            culistid: target_culistid,
            keyframe_culistid: keyframe_used,
            replayed,
        })
    }

    /// Jump to a copperlist by id.
    pub fn goto_cl(&mut self, culistid: u64) -> CuResult<JumpOutcome>
    where
        App: CurrentRuntimeCopperList<P>,
    {
        let idx = self.resolve_index_for_culistid(culistid, IndexedResolveMode::Exact)?;
        self.goto_index(idx)
    }

    /// Jump to the first copperlist at or after a timestamp.
    pub fn goto_time(&mut self, ts: CuTime) -> CuResult<JumpOutcome>
    where
        App: CurrentRuntimeCopperList<P>,
    {
        let idx = self.index_for_time(ts)?;
        self.goto_index(idx)
    }

    /// Step relative to the current cursor. Negative values rewind via keyframe.
    pub fn step(&mut self, delta: i32) -> CuResult<JumpOutcome>
    where
        App: CurrentRuntimeCopperList<P>,
    {
        let current =
            self.current_idx
                .ok_or_else(|| CuError::from("Cannot step before any jump"))? as i32;
        let target = current + delta;
        if target < 0 || target as usize >= self.total_entries {
            return Err(CuError::from("Step would move outside log bounds"));
        }
        self.goto_index(target as usize)
    }

    /// Access the copperlist at the current cursor, if any (cloned).
    pub fn current_cl(&mut self) -> CuResult<Option<Arc<crate::copperlist::CopperList<P>>>> {
        match self.current_idx {
            Some(idx) => Ok(Some(self.copperlist_at(idx)?.0)),
            None => Ok(None),
        }
    }

    /// Access a copperlist by absolute index in the log (cloned).
    pub fn cl_at(&mut self, idx: usize) -> CuResult<Option<Arc<crate::copperlist::CopperList<P>>>> {
        if idx >= self.total_entries {
            return Ok(None);
        }
        Ok(Some(self.copperlist_at(idx)?.0))
    }

    /// Total number of copperlists indexed in this session.
    pub fn total_entries(&self) -> usize {
        self.total_entries
    }

    /// The nearest keyframe (<= target CL), if any.
    pub fn nearest_keyframe_culistid(&self, target_culistid: u64) -> Option<u64> {
        self.nearest_keyframe(target_culistid).map(|kf| kf.culistid)
    }

    /// Whether the log contains an exact keyframe for this copperlist id.
    pub fn is_keyframe_culistid(&self, target_culistid: u64) -> bool {
        self.keyframes
            .iter()
            .any(|kf| kf.culistid == target_culistid)
    }

    /// Returns section-cache statistics for this session.
    pub fn section_cache_stats(&self) -> SectionCacheStats {
        SectionCacheStats {
            cap: self.cache_cap,
            entries: self.cache.len(),
            hits: self.cache_hits,
            misses: self.cache_misses,
            evictions: self.cache_evictions,
        }
    }

    /// Current absolute cursor index, if initialized.
    pub fn current_index(&self) -> Option<usize> {
        self.current_idx
    }

    /// Borrow the underlying application for inspection (e.g., task state asserts).
    pub fn with_app<R>(&mut self, f: impl FnOnce(&mut App) -> R) -> R {
        f(&mut self.app)
    }
}

impl<App, P, CB, TF, S, L> CuDebugSession<App, P, CB, TF, S, L>
where
    App: CuSimApplication<S, L> + ReflectTaskIntrospection,
    L: UnifiedLogWrite<S> + 'static,
    S: SectionStorage,
    P: CopperListTuple,
    CB: for<'a> Fn(
        &'a crate::copperlist::CopperList<P>,
        RobotClock,
        RobotClockMock,
    ) -> Box<dyn for<'z> FnMut(App::Step<'z>) -> SimOverride + 'a>,
    TF: Fn(&crate::copperlist::CopperList<P>) -> Option<CuTime> + Clone,
{
    /// Returns a reflected view of the current task instance by task id.
    pub fn reflected_task(&self, task_id: &str) -> CuResult<&dyn crate::reflect::Reflect> {
        self.app
            .reflect_task(task_id)
            .ok_or_else(|| CuError::from(format!("Task '{task_id}' was not found.")))
    }

    /// Mutable reflected task view by task id.
    pub fn reflected_task_mut(
        &mut self,
        task_id: &str,
    ) -> CuResult<&mut dyn crate::reflect::Reflect> {
        self.app
            .reflect_task_mut(task_id)
            .ok_or_else(|| CuError::from(format!("Task '{task_id}' was not found.")))
    }

    /// Borrows the current typed debug-state view for one task.
    pub fn with_debug_state<R>(
        &self,
        task_id: &str,
        f: impl FnOnce(&dyn crate::reflect::Reflect) -> R,
    ) -> CuResult<R> {
        self.app
            .with_debug_state(task_id, f)
            .ok_or_else(|| CuError::from(format!("Task '{task_id}' was not found.")))
    }

    /// Dumps the reflected runtime state of one task.
    pub fn dump_reflected_task(&self, task_id: &str) -> CuResult<String> {
        let task = self.reflected_task(task_id)?;
        #[cfg(not(feature = "reflect"))]
        {
            let _ = task;
            Err(CuError::from(
                "Task introspection is disabled. Rebuild with the `reflect` feature.",
            ))
        }

        #[cfg(feature = "reflect")]
        {
            Ok(format!("{task:#?}"))
        }
    }

    /// Dumps reflected schemas registered by this application.
    pub fn dump_reflected_task_schemas(&self) -> String {
        #[cfg(feature = "reflect")]
        let mut registry = TypeRegistry::default();
        #[cfg(not(feature = "reflect"))]
        let mut registry = TypeRegistry;
        <App as ReflectTaskIntrospection>::register_reflect_types(&mut registry);
        dump_type_registry_schema(&registry)
    }
}
/// Decode all copperlists contained in a single unified-log section.
#[allow(clippy::type_complexity)]
pub(crate) fn decode_copperlists<
    P: CopperListTuple,
    TF: Fn(&crate::copperlist::CopperList<P>) -> Option<CuTime>,
>(
    section: &[u8],
    time_of: &TF,
) -> CuResult<(
    Vec<Arc<crate::copperlist::CopperList<P>>>,
    Vec<Option<CuTime>>,
)> {
    let mut cursor = std::io::Cursor::new(section);
    let mut entries = Vec::new();
    let mut timestamps = Vec::new();
    loop {
        match decode_from_std_read::<crate::copperlist::CopperList<P>, _, _>(
            &mut cursor,
            standard(),
        ) {
            Ok(cl) => {
                timestamps.push(time_of(&cl));
                entries.push(Arc::new(cl));
            }
            Err(DecodeError::UnexpectedEnd { .. }) => break,
            Err(DecodeError::Io { inner, .. }) if inner.kind() == io::ErrorKind::UnexpectedEof => {
                break;
            }
            Err(e) => {
                return Err(CuError::new_with_cause(
                    "Failed to decode CopperList section",
                    e,
                ));
            }
        }
    }
    Ok((entries, timestamps))
}

/// Scan a copperlist section for metadata only.
#[allow(clippy::type_complexity)]
fn scan_copperlist_section<
    P: CopperListTuple,
    TF: Fn(&crate::copperlist::CopperList<P>) -> Option<CuTime>,
>(
    section: &[u8],
    time_of: &TF,
) -> CuResult<(usize, u64, u64, Option<CuTime>, Option<CuTime>)> {
    let mut cursor = std::io::Cursor::new(section);
    let mut count = 0usize;
    let mut first_id = None;
    let mut last_id = None;
    let mut first_ts = None;
    let mut last_ts = None;
    loop {
        match decode_from_std_read::<crate::copperlist::CopperList<P>, _, _>(
            &mut cursor,
            standard(),
        ) {
            Ok(cl) => {
                let ts = time_of(&cl);
                if ts.is_none() {
                    #[cfg(feature = "std")]
                    eprintln!(
                        "CuDebug index warning: missing timestamp on culistid {}; time-based seek may be less accurate",
                        cl.id
                    );
                }
                if first_id.is_none() {
                    first_id = Some(cl.id);
                    first_ts = ts;
                }
                // Recover first_ts if the first entry lacked a timestamp but a later one has it.
                if first_ts.is_none() {
                    first_ts = ts;
                }
                last_id = Some(cl.id);
                last_ts = ts.or(last_ts);
                count += 1;
            }
            Err(DecodeError::UnexpectedEnd { .. }) => break,
            Err(DecodeError::Io { inner, .. }) if inner.kind() == io::ErrorKind::UnexpectedEof => {
                break;
            }
            Err(e) => {
                return Err(CuError::new_with_cause(
                    "Failed to scan copperlist section",
                    e,
                ));
            }
        }
    }
    let first_id = first_id.ok_or_else(|| CuError::from("Empty copperlist section"))?;
    let last_id = last_id.unwrap_or(first_id);
    Ok((count, first_id, last_id, first_ts, last_ts))
}

/// Build a reusable read-only unified logger for this session.
pub(crate) fn build_read_logger(log_base: &Path) -> CuResult<UnifiedLoggerRead> {
    let logger = UnifiedLoggerBuilder::new()
        .file_base_name(log_base)
        .build()
        .map_err(|e| CuError::new_with_cause("Failed to open unified log", e))?;
    let UnifiedLogger::Read(dl) = logger else {
        return Err(CuError::from("Expected read-only unified logger"));
    };
    Ok(dl)
}

/// Read a specific section at a given position from disk using an existing handle.
pub(crate) fn read_section_at(
    log_reader: &mut UnifiedLoggerRead,
    pos: LogPosition,
) -> CuResult<(SectionHeader, Vec<u8>)> {
    log_reader.seek(pos)?;
    log_reader.raw_read_section()
}

/// Build a section-level index in one pass (copperlists + keyframes).
pub(crate) fn index_log<P, TF>(
    log_base: &Path,
    time_of: &TF,
) -> CuResult<(Vec<SectionIndexEntry>, Vec<KeyFrame>, usize)>
where
    P: CopperListTuple,
    TF: Fn(&crate::copperlist::CopperList<P>) -> Option<CuTime>,
{
    index_log_with_progress(log_base, time_of, |_| {})
}

fn index_log_with_progress<P, TF, PF>(
    log_base: &Path,
    time_of: &TF,
    mut progress: PF,
) -> CuResult<(Vec<SectionIndexEntry>, Vec<KeyFrame>, usize)>
where
    P: CopperListTuple,
    TF: Fn(&crate::copperlist::CopperList<P>) -> Option<CuTime>,
    PF: FnMut(LogIndexProgress),
{
    let sizing_logger = UnifiedLoggerBuilder::new()
        .file_base_name(log_base)
        .build()
        .map_err(|e| CuError::new_with_cause("Failed to open unified log", e))?;
    let UnifiedLogger::Read(mut sizing_reader) = sizing_logger else {
        return Err(CuError::from("Expected read-only unified logger"));
    };
    let mut total_bytes = 0u64;
    loop {
        let header = sizing_reader.raw_skip_section()?;
        if header.entry_type == UnifiedLogType::LastEntry {
            break;
        }
        total_bytes = total_bytes.saturating_add(header.used as u64);
    }

    let logger = UnifiedLoggerBuilder::new()
        .file_base_name(log_base)
        .build()
        .map_err(|e| CuError::new_with_cause("Failed to open unified log", e))?;
    let UnifiedLogger::Read(mut dl) = logger else {
        return Err(CuError::from("Expected read-only unified logger"));
    };

    let mut sections = Vec::new();
    let mut keyframes = Vec::new();
    let mut total_entries = 0usize;
    let mut scanned_bytes = 0u64;
    progress(LogIndexProgress {
        scanned_bytes,
        total_bytes,
        indexed_entries: total_entries,
    });

    loop {
        let pos = dl.position();
        let (header, data) = dl.raw_read_section()?;
        if header.entry_type == UnifiedLogType::LastEntry {
            break;
        }

        match header.entry_type {
            UnifiedLogType::CopperList => {
                let (len, first_id, last_id, first_ts, last_ts) =
                    scan_copperlist_section::<P, _>(&data, time_of)?;
                if len > 0 {
                    sections.push(SectionIndexEntry {
                        pos,
                        start_idx: total_entries,
                        len,
                        first_id,
                        last_id,
                        first_ts,
                        last_ts,
                    });
                    total_entries += len;
                }
            }
            UnifiedLogType::FrozenTasks => {
                // Read all keyframes in this section
                let mut cursor = std::io::Cursor::new(&data);
                loop {
                    match decode_from_std_read::<KeyFrame, _, _>(&mut cursor, standard()) {
                        Ok(kf) => keyframes.push(kf),
                        Err(DecodeError::UnexpectedEnd { .. }) => break,
                        Err(DecodeError::Io { inner, .. })
                            if inner.kind() == io::ErrorKind::UnexpectedEof =>
                        {
                            break;
                        }
                        Err(e) => {
                            return Err(CuError::new_with_cause(
                                "Failed to decode keyframe section",
                                e,
                            ));
                        }
                    }
                }
            }
            _ => {
                // ignore other sections
            }
        }
        scanned_bytes = scanned_bytes.saturating_add(header.used as u64);
        progress(LogIndexProgress {
            scanned_bytes,
            total_bytes,
            indexed_entries: total_entries,
        });
    }

    Ok((sections, keyframes, total_entries))
}

fn nearest_replay_keyframe(keyframes: &[KeyFrame], target_culistid: u64) -> Option<KeyFrame> {
    keyframes
        .iter()
        .filter(|kf| kf.culistid <= target_culistid)
        .max_by_key(|kf| kf.culistid)
        .cloned()
}

#[cfg(test)]
mod tests {
    use super::*;

    fn keyframe(culistid: u64) -> KeyFrame {
        KeyFrame {
            culistid,
            timestamp: CuTime::from_nanos(culistid),
            serialized_tasks: Vec::new(),
        }
    }

    #[test]
    fn replay_keyframe_selects_nearest_keyframe_at_or_before_target() {
        let keyframes = [keyframe(0), keyframe(100), keyframe(500)];

        let keyframe = nearest_replay_keyframe(&keyframes, 533).expect("replay keyframe");

        assert_eq!(keyframe.culistid, 500);
    }

    #[test]
    fn replay_keyframe_uses_nearest_available_nonzero_keyframe() {
        let keyframes = [keyframe(100), keyframe(500), keyframe(900)];

        let keyframe = nearest_replay_keyframe(&keyframes, 533).expect("replay keyframe");

        assert_eq!(keyframe.culistid, 500);
        assert!(nearest_replay_keyframe(&keyframes, 99).is_none());
    }
}