1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
use crate::{actor::DhtRequester, inbound::DhtInboundMessage};
use digest::Input;
use futures::{task::Context, Future};
use log::*;
use std::task::Poll;
use tari_comms::{pipeline::PipelineError, types::Challenge};
use tari_utilities::hex::Hex;
use tower::{layer::Layer, Service, ServiceExt};
const LOG_TARGET: &str = "comms::dht::dedup";
fn hash_inbound_message(message: &DhtInboundMessage) -> Vec<u8> {
Challenge::new().chain(&message.body).result().to_vec()
}
#[derive(Clone)]
pub struct DedupMiddleware<S> {
next_service: S,
dht_requester: DhtRequester,
}
impl<S> DedupMiddleware<S> {
pub fn new(service: S, dht_requester: DhtRequester) -> Self {
Self {
next_service: service,
dht_requester,
}
}
}
impl<S> Service<DhtInboundMessage> for DedupMiddleware<S>
where S: Service<DhtInboundMessage, Response = (), Error = PipelineError> + Clone
{
type Error = PipelineError;
type Response = ();
type Future = impl Future<Output = Result<Self::Response, Self::Error>>;
fn poll_ready(&mut self, _: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
Poll::Ready(Ok(()))
}
fn call(&mut self, message: DhtInboundMessage) -> Self::Future {
let next_service = self.next_service.clone();
let mut dht_requester = self.dht_requester.clone();
async move {
let hash = hash_inbound_message(&message);
trace!(
target: LOG_TARGET,
"Inserting message hash {} for message {} (Trace: {})",
hash.to_hex(),
message.tag,
message.dht_header.message_tag
);
if dht_requester.insert_message_hash(hash).await? {
trace!(
target: LOG_TARGET,
"Received duplicate message {} from peer '{}' (Trace: {}). Message discarded.",
message.tag,
message.source_peer.node_id.short_str(),
message.dht_header.message_tag,
);
return Ok(());
}
trace!(
target: LOG_TARGET,
"Passing message {} onto next service (Trace: {})",
message.tag,
message.dht_header.message_tag
);
next_service.oneshot(message).await
}
}
}
pub struct DedupLayer {
dht_requester: DhtRequester,
}
impl DedupLayer {
pub fn new(dht_requester: DhtRequester) -> Self {
Self { dht_requester }
}
}
impl<S> Layer<S> for DedupLayer {
type Service = DedupMiddleware<S>;
fn layer(&self, service: S) -> Self::Service {
DedupMiddleware::new(service, self.dht_requester.clone())
}
}
#[cfg(test)]
mod test {
use super::*;
use crate::{
envelope::DhtMessageFlags,
test_utils::{create_dht_actor_mock, make_dht_inbound_message, make_node_identity, service_spy},
};
use tari_test_utils::panic_context;
use tokio::runtime::Runtime;
#[test]
fn process_message() {
let mut rt = Runtime::new().unwrap();
let spy = service_spy();
let (dht_requester, mock) = create_dht_actor_mock(1);
let mock_state = mock.get_shared_state();
mock_state.set_signature_cache_insert(false);
rt.spawn(mock.run());
let mut dedup = DedupLayer::new(dht_requester).layer(spy.to_service::<PipelineError>());
panic_context!(cx);
assert!(dedup.poll_ready(&mut cx).is_ready());
let node_identity = make_node_identity();
let msg = make_dht_inbound_message(&node_identity, Vec::new(), DhtMessageFlags::empty(), false);
rt.block_on(dedup.call(msg.clone())).unwrap();
assert_eq!(spy.call_count(), 1);
mock_state.set_signature_cache_insert(true);
rt.block_on(dedup.call(msg)).unwrap();
assert_eq!(spy.call_count(), 1);
drop(dedup);
}
#[test]
fn deterministic_hash() {
const TEST_MSG: &[u8] = b"test123";
const EXPECTED_HASH: &str = "90cccd774db0ac8c6ea2deff0e26fc52768a827c91c737a2e050668d8c39c224";
let node_identity = make_node_identity();
let msg = make_dht_inbound_message(&node_identity, TEST_MSG.to_vec(), DhtMessageFlags::empty(), false);
let hash1 = hash_inbound_message(&msg);
let node_identity = make_node_identity();
let msg = make_dht_inbound_message(&node_identity, TEST_MSG.to_vec(), DhtMessageFlags::empty(), false);
let hash2 = hash_inbound_message(&msg);
assert_eq!(hash1, hash2);
let subjects = &[hash1, hash2];
assert!(subjects.into_iter().all(|h| h.to_hex() == EXPECTED_HASH));
}
}