1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
use impl_prelude::*;
#[derive(Debug)]
pub struct BadCommits {
bad_commits: Vec<CommitId>,
}
impl BadCommits {
pub fn new<I>(bad_commits: I) -> Self
where I: IntoIterator,
I::Item: ToString,
{
Self {
bad_commits: bad_commits.into_iter()
.map(|s| CommitId::new(s.to_string()))
.collect(),
}
}
}
impl Check for BadCommits {
fn name(&self) -> &str {
"bad-commits"
}
fn check(&self, _: &CheckGitContext, commit: &Commit) -> Result<CheckResult> {
let mut result = CheckResult::new();
if self.bad_commits.contains(&commit.sha1) {
result.add_error(format!("commit {} is a known-bad commit that was removed from the \
server.",
commit.sha1))
.add_alert(format!("commit {} was pushed to the server.", commit.sha1),
true);
}
Ok(result)
}
}
impl TopicCheck for BadCommits {
fn name(&self) -> &str {
"bad-commits-topic"
}
fn check(&self, ctx: &CheckGitContext, topic: &Topic) -> Result<CheckResult> {
let rev_list = ctx.git()
.arg("rev-list")
.arg("--reverse")
.arg("--topo-order")
.arg(&topic.sha1.as_str())
.arg(&format!("^{}", topic.base))
.output()
.chain_err(|| "failed to construct rev-list command")?;
if !rev_list.status.success() {
bail!(ErrorKind::Git(format!("failed to list all topic refs: {}",
String::from_utf8_lossy(&rev_list.stderr))));
}
let refs = String::from_utf8_lossy(&rev_list.stdout);
Ok(refs.lines()
.map(CommitId::new)
.fold(CheckResult::new(), |mut result, commit| {
if self.bad_commits.contains(&commit) {
result.add_error(format!("commit {} is a known-bad commit that was removed from the \
server.",
commit))
.add_alert(format!("commit {} was pushed to the server.", commit),
true);
}
result
}))
}
}
#[cfg(test)]
mod tests {
use checks::BadCommits;
use checks::test::*;
const GOOD_COMMIT: &str = "7b0c51ed98a23a32718ed7014d6d4a813423f1bd";
const BAD_COMMIT: &str = "029a00428913ee915ce5ee7250c023abfbc2aca3";
const BAD_TOPIC: &str = "3d535904b40868dcba6465cf2c3ce4358501880a";
#[test]
fn test_bad_commits_good_commit() {
let check = BadCommits::new(&[
BAD_COMMIT,
]);
run_check_ok("test_bad_commits_good_commit", GOOD_COMMIT, check);
}
#[test]
fn test_bad_commits_no_bad_commit() {
let check = BadCommits::new(&[
"0000000000000000000000000000000000000000",
]);
run_check_ok("test_bad_commits_no_bad_commit", BAD_TOPIC, check);
}
#[test]
fn test_bad_commits_already_in_history() {
let check = BadCommits::new(&[
FILLER_COMMIT,
]);
run_check_ok("test_bad_commits_already_in_history", BAD_TOPIC, check);
}
#[test]
fn test_bad_commits_not_already_in_history() {
let check = BadCommits::new(&[
BAD_COMMIT,
]);
let result = run_check("test_bad_commits_not_already_in_history", BAD_TOPIC, check);
assert_eq!(result.warnings().len(), 0);
assert_eq!(result.alerts().len(), 1);
assert_eq!(result.alerts()[0],
"commit 029a00428913ee915ce5ee7250c023abfbc2aca3 was pushed to the server.");
assert_eq!(result.errors().len(), 1);
assert_eq!(result.errors()[0],
"commit 029a00428913ee915ce5ee7250c023abfbc2aca3 is a known-bad commit that \
was removed from the server.");
assert_eq!(result.temporary(), false);
assert_eq!(result.allowed(), false);
assert_eq!(result.pass(), false);
}
#[test]
fn test_bad_commits_topic_good_commit() {
let check = BadCommits::new(&[
BAD_COMMIT,
]);
run_topic_check_ok("test_bad_commits_topic_good_commit", GOOD_COMMIT, check);
}
#[test]
fn test_bad_commits_topic_no_bad_commit() {
let check = BadCommits::new(&[
"0000000000000000000000000000000000000000",
]);
run_topic_check_ok("test_bad_commits_topic_no_bad_commit", BAD_TOPIC, check);
}
#[test]
fn test_bad_commits_topic_already_in_history() {
let check = BadCommits::new(&[
FILLER_COMMIT,
]);
run_topic_check_ok("test_bad_commits_topic_already_in_history", BAD_TOPIC, check);
}
#[test]
fn test_bad_commits_topic_not_already_in_history() {
let check = BadCommits::new(&[
BAD_COMMIT,
]);
let result = run_topic_check("test_bad_commits_topic_not_already_in_history", BAD_TOPIC, check);
assert_eq!(result.warnings().len(), 0);
assert_eq!(result.alerts().len(), 1);
assert_eq!(result.alerts()[0],
"commit 029a00428913ee915ce5ee7250c023abfbc2aca3 was pushed to the server.");
assert_eq!(result.errors().len(), 1);
assert_eq!(result.errors()[0],
"commit 029a00428913ee915ce5ee7250c023abfbc2aca3 is a known-bad commit that \
was removed from the server.");
assert_eq!(result.temporary(), false);
assert_eq!(result.allowed(), false);
assert_eq!(result.pass(), false);
}
}