1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
use impl_prelude::*;
use std::char::REPLACEMENT_CHARACTER;
#[derive(Debug, Default, Clone, Copy)]
pub struct InvalidUtf8;
impl InvalidUtf8 {
pub fn new() -> Self {
Self {}
}
}
impl ContentCheck for InvalidUtf8 {
fn name(&self) -> &str {
"invalid-utf8"
}
fn check(&self, ctx: &CheckGitContext, content: &Content) -> Result<CheckResult> {
let mut result = CheckResult::new();
for diff in content.diffs() {
match diff.status {
StatusChange::Added |
StatusChange::Modified(_) => (),
_ => continue,
}
let diff_attr = ctx.check_attr("diff", diff.name.as_path())?;
if let AttributeState::Unset = diff_attr {
continue;
}
let patch = match content.path_diff(&diff.name) {
Ok(s) => s,
Err(err) => {
result.add_alert(format!("{}failed to get the diff for file `{}`: {}.",
commit_prefix(content),
diff.name,
err),
true);
continue;
},
};
for line in patch.lines().filter(|line| line.starts_with('+')) {
if line.contains(REPLACEMENT_CHARACTER) {
let safe_line = line[1..]
.replace('\\', "\\\\")
.replace('`', "\\`");
result.add_error(format!("{}invalid utf-8 sequence added in \
`{}`: `{}`.",
commit_prefix_str(content, "not allowed;"),
diff.name,
safe_line));
}
}
}
Ok(result)
}
}
#[cfg(test)]
mod tests {
use checks::InvalidUtf8;
use checks::test::*;
const BAD_TOPIC: &str = "cf16b71a21023320ffab7b3f7673dc62f33e5022";
const FIX_TOPIC: &str = "e8763477e9ebef4a61d130724cee9e29b13f857e";
#[test]
fn test_invalid_utf8() {
let check = InvalidUtf8;
let result = run_check("test_invalid_utf8", BAD_TOPIC, check);
test_result_errors(result, &[
"commit cf16b71a21023320ffab7b3f7673dc62f33e5022 not allowed; invalid utf-8 sequence \
added in `invalid-utf8`: `This file contains an invalid utf-8 sequence: \
\u{fffd}`.",
]);
}
#[test]
fn test_invalid_utf8_topic() {
let check = InvalidUtf8;
let result = run_topic_check("test_invalid_utf8_topic", BAD_TOPIC, check);
test_result_errors(result, &[
"invalid utf-8 sequence added in `invalid-utf8`: `This file contains an invalid utf-8 \
sequence: \u{fffd}`.",
]);
}
#[test]
fn test_invalid_utf8_topic_fixed() {
let check = InvalidUtf8;
run_topic_check_ok("test_invalid_utf8_topic_fixed", FIX_TOPIC, check);
}
}